2022-06-26 03:49 ftp://ftp.de.debian.org/debian/pool/main/x/xstarfish/xstarfish_1.1+ds.orig.tar.xz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j1 platform: Linux-5.4.0-121-generic-x86_64-with-glibc2.29 python: 3.8.10 client-version: 1.3.24 compiler: g++ (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0 cppcheck: head 2.8 head-info: 242afc3 (2022-06-25 21:42:55 +0200) count: 43 43 elapsed-time: 4.7 6.8 head-timing-info: Tokenizer::simplifyTokens1: 1.45627s (avg. 0.0809041s - 18 result(s)) Tokenizer::simplifyTokens1::ValueFlow: 1.38133s (avg. 0.0767404s - 18 result(s)) Tokenizer::simplifyTokens1::createSymbolDatabase: 0.036284s (avg. 0.00201578s - 18 result(s)) Tokenizer::createTokens: 0.017928s (avg. 0.000996s - 18 result(s)) Tokenizer::simplifyTokens1::setValueType: 0.010425s (avg. 0.000579167s - 18 result(s)) Overall time: 2.95139s old-timing-info: Tokenizer::simplifyTokens1: 2.13825s (avg. 0.118792s - 18 result(s)) Tokenizer::simplifyTokens1::ValueFlow: 2.061s (avg. 0.1145s - 18 result(s)) Tokenizer::simplifyTokens1::createSymbolDatabase: 0.037263s (avg. 0.00207017s - 18 result(s)) Tokenizer::createTokens: 0.018373s (avg. 0.00102072s - 18 result(s)) Tokenizer::simplifyTokens1::setValueType: 0.01154s (avg. 0.000641111s - 18 result(s)) Overall time: 4.31493s head results: starfish-1.1/portable/generators.c:214:3: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] starfish-1.1/portable/generators.c:341:3: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] starfish-1.1/portable/generators.c:261:24: style:inconclusive: Function 'MakeLayer' argument 1 names different: declaration 'ctr' definition 'genctr'. [funcArgNamesDifferent] starfish-1.1/portable/generators.h:64:24: note: Function 'MakeLayer' argument 1 names different: declaration 'ctr' definition 'genctr'. starfish-1.1/portable/generators.c:261:24: note: Function 'MakeLayer' argument 1 names different: declaration 'ctr' definition 'genctr'. starfish-1.1/portable/generators.c:345:42: style:inconclusive: Function 'GeneratePointFunction' argument 1 names different: declaration 'h' definition 'hmax'. [funcArgNamesDifferent] starfish-1.1/portable/generators.c:133:42: note: Function 'GeneratePointFunction' argument 1 names different: declaration 'h' definition 'hmax'. starfish-1.1/portable/generators.c:345:42: note: Function 'GeneratePointFunction' argument 1 names different: declaration 'h' definition 'hmax'. starfish-1.1/portable/generators.c:345:52: style:inconclusive: Function 'GeneratePointFunction' argument 2 names different: declaration 'v' definition 'vmax'. [funcArgNamesDifferent] starfish-1.1/portable/generators.c:133:49: note: Function 'GeneratePointFunction' argument 2 names different: declaration 'v' definition 'vmax'. starfish-1.1/portable/generators.c:345:52: note: Function 'GeneratePointFunction' argument 2 names different: declaration 'v' definition 'vmax'. starfish-1.1/portable/generators.c:345:67: style:inconclusive: Function 'GeneratePointFunction' argument 3 names different: declaration 'gen' definition 'it'. [funcArgNamesDifferent] starfish-1.1/portable/generators.c:133:61: note: Function 'GeneratePointFunction' argument 3 names different: declaration 'gen' definition 'it'. starfish-1.1/portable/generators.c:345:67: note: Function 'GeneratePointFunction' argument 3 names different: declaration 'gen' definition 'it'. starfish-1.1/portable/generators.c:378:40: style:inconclusive: Function 'GetAntiAliasedPoint' argument 1 names different: declaration 'hpos' definition 'fhpos'. [funcArgNamesDifferent] starfish-1.1/portable/generators.c:135:40: note: Function 'GetAntiAliasedPoint' argument 1 names different: declaration 'hpos' definition 'fhpos'. starfish-1.1/portable/generators.c:378:40: note: Function 'GetAntiAliasedPoint' argument 1 names different: declaration 'hpos' definition 'fhpos'. starfish-1.1/portable/generators.c:378:53: style:inconclusive: Function 'GetAntiAliasedPoint' argument 2 names different: declaration 'vpos' definition 'fvpos'. [funcArgNamesDifferent] starfish-1.1/portable/generators.c:135:52: note: Function 'GetAntiAliasedPoint' argument 2 names different: declaration 'vpos' definition 'fvpos'. starfish-1.1/portable/generators.c:378:53: note: Function 'GetAntiAliasedPoint' argument 2 names different: declaration 'vpos' definition 'fvpos'. starfish-1.1/portable/generators.c:402:36: style:inconclusive: Function 'GetWrappedPoint' argument 1 names different: declaration 'hpos' definition 'fhpos'. [funcArgNamesDifferent] starfish-1.1/portable/generators.c:134:36: note: Function 'GetWrappedPoint' argument 1 names different: declaration 'hpos' definition 'fhpos'. starfish-1.1/portable/generators.c:402:36: note: Function 'GetWrappedPoint' argument 1 names different: declaration 'hpos' definition 'fhpos'. starfish-1.1/portable/generators.c:402:49: style:inconclusive: Function 'GetWrappedPoint' argument 2 names different: declaration 'vpos' definition 'fvpos'. [funcArgNamesDifferent] starfish-1.1/portable/generators.c:134:48: note: Function 'GetWrappedPoint' argument 2 names different: declaration 'vpos' definition 'fvpos'. starfish-1.1/portable/generators.c:402:49: note: Function 'GetWrappedPoint' argument 2 names different: declaration 'vpos' definition 'fvpos'. starfish-1.1/portable/generators.c:317:38: style: Unused variable: pixelval [unusedVariable] starfish-1.1/portable/generators/branchfrac-gen.c:215:6: style: Unused variable: branch [unusedVariable] starfish-1.1/portable/generators/bubble-gen.c:165:10: style: Variable 'current' is reassigned a value before the old one has been used. [redundantAssignment] starfish-1.1/portable/generators/bubble-gen.c:164:10: note: current is assigned starfish-1.1/portable/generators/bubble-gen.c:165:10: note: current is overwritten starfish-1.1/portable/generators/coswave-gen.c:137:9: style: Unused variable: rawcos [unusedVariable] starfish-1.1/portable/generators/flatwave-gen.c:170:8: style: Unused variable: hypangle [unusedVariable] starfish-1.1/portable/generators/flatwave-gen.c:170:18: style: Unused variable: hypotenuse [unusedVariable] starfish-1.1/portable/generators/flatwave-gen.c:171:8: style: Unused variable: distance [unusedVariable] starfish-1.1/portable/generators/flatwave-gen.c:171:18: style: Unused variable: transverse [unusedVariable] starfish-1.1/portable/generators/ramp-gen.c:46:8: style: Unused variable: tempv [unusedVariable] starfish-1.1/portable/generators/ramp-gen.c:47:8: style: Unused variable: hpower [unusedVariable] starfish-1.1/portable/generators/ramp-gen.c:47:16: style: Unused variable: vpower [unusedVariable] starfish-1.1/portable/generators/rangefrac-gen.c:79:6: style: Unused variable: tempblinder [unusedVariable] starfish-1.1/portable/generators/spinflake-gen.c:321:42: style:inconclusive: Function 'calcwave' argument 2 names different: declaration 'origindist' definition 'dist'. [funcArgNamesDifferent] starfish-1.1/portable/generators/spinflake-gen.c:110:42: note: Function 'calcwave' argument 2 names different: declaration 'origindist' definition 'dist'. starfish-1.1/portable/generators/spinflake-gen.c:321:42: note: Function 'calcwave' argument 2 names different: declaration 'origindist' definition 'dist'. starfish-1.1/portable/generators/spinflake-gen.c:222:9: error: Uninitialized variable: out [uninitvar] starfish-1.1/portable/generators/spinflake-gen.c:206:5: note: Assuming condition is false starfish-1.1/portable/generators/spinflake-gen.c:222:9: note: Uninitialized variable: out starfish-1.1/portable/generators/spinflake-gen.c:259:44: style: Unused variable: totalweight [unusedVariable] starfish-1.1/portable/pixels/bufferxform.c:88:2: error: Found a exit path from function with non-void return type that has missing return statement [missingReturn] starfish-1.1/portable/pixels/bufferxform.c:93:2: error: Found a exit path from function with non-void return type that has missing return statement [missingReturn] starfish-1.1/portable/pixels/bufferxform.c:185:2: error: Found a exit path from function with non-void return type that has missing return statement [missingReturn] starfish-1.1/portable/pixels/bufferxform.c:190:2: error: Found a exit path from function with non-void return type that has missing return statement [missingReturn] starfish-1.1/portable/pixels/bufferxform.c:335:2: error: Found a exit path from function with non-void return type that has missing return statement [missingReturn] starfish-1.1/portable/pixels/bufferxform.c:318:9: style: Variable 'err' is reassigned a value before the old one has been used. [redundantAssignment] starfish-1.1/portable/pixels/bufferxform.c:304:9: note: err is assigned starfish-1.1/portable/pixels/bufferxform.c:318:9: note: err is overwritten starfish-1.1/portable/pixels/bufferxform.c:320:9: style: Variable 'err' is reassigned a value before the old one has been used. [redundantAssignment] starfish-1.1/portable/pixels/bufferxform.c:318:9: note: err is assigned starfish-1.1/portable/pixels/bufferxform.c:320:9: note: err is overwritten starfish-1.1/portable/pixels/greymap.c:336:92: style:inconclusive: Function 'SetGreyRasterLine' argument 5 names different: declaration 'dest' definition 'src'. [funcArgNamesDifferent] starfish-1.1/portable/pixels/greymap.h:62:92: note: Function 'SetGreyRasterLine' argument 5 names different: declaration 'dest' definition 'src'. starfish-1.1/portable/pixels/greymap.c:336:92: note: Function 'SetGreyRasterLine' argument 5 names different: declaration 'dest' definition 'src'. starfish-1.1/portable/pixels/pixmap.c:295:71: style:inconclusive: Function 'SetPixBufPixel' argument 4 names different: declaration 'dest' definition 'src'. [funcArgNamesDifferent] starfish-1.1/portable/pixels/pixmap.h:68:71: note: Function 'SetPixBufPixel' argument 4 names different: declaration 'dest' definition 'src'. starfish-1.1/portable/pixels/pixmap.c:295:71: note: Function 'SetPixBufPixel' argument 4 names different: declaration 'dest' definition 'src'. starfish-1.1/portable/pixels/pixmap.c:385:86: style:inconclusive: Function 'SetRasterLine' argument 5 names different: declaration 'dest' definition 'src'. [funcArgNamesDifferent] starfish-1.1/portable/pixels/pixmap.h:74:86: note: Function 'SetRasterLine' argument 5 names different: declaration 'dest' definition 'src'. starfish-1.1/portable/pixels/pixmap.c:385:86: note: Function 'SetRasterLine' argument 5 names different: declaration 'dest' definition 'src'. starfish-1.1/portable/starfish-engine.c:342:3: warning: Either the condition 'out' is redundant or there is possible null pointer dereference: out. [nullPointerRedundantCheck] starfish-1.1/portable/starfish-engine.c:251:16: note: Assuming that condition 'out' is not redundant starfish-1.1/portable/starfish-engine.c:342:3: note: Null pointer dereference starfish-1.1/portable/starfish-engine.c:375:21: style:inconclusive: Function 'Starfish' argument 1 names different: declaration 'hsize' definition 'horz'. [funcArgNamesDifferent] starfish-1.1/portable/starfish-engine.h:48:21: note: Function 'Starfish' argument 1 names different: declaration 'hsize' definition 'horz'. starfish-1.1/portable/starfish-engine.c:375:21: note: Function 'Starfish' argument 1 names different: declaration 'hsize' definition 'horz'. starfish-1.1/portable/starfish-engine.c:375:31: style:inconclusive: Function 'Starfish' argument 2 names different: declaration 'vsize' definition 'vert'. [funcArgNamesDifferent] starfish-1.1/portable/starfish-engine.h:48:32: note: Function 'Starfish' argument 2 names different: declaration 'vsize' definition 'vert'. starfish-1.1/portable/starfish-engine.c:375:31: note: Function 'Starfish' argument 2 names different: declaration 'vsize' definition 'vert'. starfish-1.1/portable/starfish-engine.c:386:19: style: Variable 'templayer' is assigned a value that is never used. [unreadVariable] starfish-1.1/unix/makepng.c:63:4: error: Resource leak: theFile [resourceLeak] starfish-1.1/unix/makepng.c:75:4: error: Resource leak: theFile [resourceLeak] starfish-1.1/unix/makepng.c:37:21: style: Unused variable: x [unusedVariable] starfish-1.1/unix/makepng.c:37:24: style: Unused variable: y [unusedVariable] diff: DONE