2024-03-26 08:07 ftp://ftp.de.debian.org/debian/pool/main/x/xskat/xskat_4.0.orig.tar.gz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --inline-suppr --disable=missingInclude --suppress=unmatchedSuppression --template=daca2 --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=valueFlowBailoutIncompleteVar -D__GNUC__ --platform=unix64 -j4 platform: Linux-6.1.0-0.deb11.6-amd64-x86_64-with-glibc2.31 python: 3.9.2 client-version: 1.3.45 compiler: g++ (Debian 10.2.1-6) 10.2.1 20210110 cppcheck: head 2.13.0 head-info: 82f05c8 (2024-03-25 22:58:58 +0100) count: 153 150 elapsed-time: 20.6 55.4 head-timing-info: Tokenizer::simplifyTokens1::ValueFlow: 19.8574s (avg. 19.8574s - 1 result(s)) valueFlowLifetime(tokenlist, errorLogger, settings): 13.0763s (avg. 3.26907s - 4 result(s)) valueFlowCondition(SimpleConditionHandler{}, tokenlist, symboldatabase, errorLogger, settings, skippedFunctions): 2.39071s (avg. 0.796902s - 3 result(s)) valueFlowForLoop(tokenlist, symboldatabase, errorLogger, settings): 1.93111s (avg. 0.643702s - 3 result(s)) valueFlowAfterAssign(tokenlist, symboldatabase, errorLogger, settings, skippedFunctions): 1.34327s (avg. 0.447757s - 3 result(s)) Overall time: 20.0535s old-timing-info: Tokenizer::simplifyTokens1::ValueFlow: 54.6929s (avg. 54.6929s - 1 result(s)) valueFlowLifetime(tokenlist, errorLogger, settings): 48.3492s (avg. 12.0873s - 4 result(s)) valueFlowUninit(tokenlist, settings): 2.0123s (avg. 0.670767s - 3 result(s)) valueFlowAfterAssign(tokenlist, symboldatabase, errorLogger, settings, skippedFunctions): 1.94632s (avg. 0.648774s - 3 result(s)) valueFlowCondition(SimpleConditionHandler{}, tokenlist, symboldatabase, errorLogger, settings, skippedFunctions): 1.06778s (avg. 0.355926s - 3 result(s)) Overall time: 54.8651s head results: xskat-4.0/null.c:71:0: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/null.c:273:5: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/null.c:296:5: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/null.c:317:13: style: Parameter 'cd' can be declared as pointer to const [constParameterPointer] xskat-4.0/null.c:322:9: warning: Uninitialized variable: mfb [uninitvar] xskat-4.0/null.c:379:42: note: Calling function 'null_dicht', 5th argument 'mfb' value is xskat-4.0/null.c:322:9: note: Uninitialized variable: mfb xskat-4.0/irc.c:1384:3: warning: Return value of function pipe() is not used. [ignoredReturnValue] xskat-4.0/irc.c:1385:3: warning: Return value of function pipe() is not used. [ignoredReturnValue] xskat-4.0/irc.c:62:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/irc.c:328:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/irc.c:420:0: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/irc.c:459:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/irc.c:467:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/irc.c:832:0: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/irc.c:984:8: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/irc.c:1113:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/irc.c:1129:0: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/irc.c:1136:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/irc.c:1158:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/irc.c:1187:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/irc.c:1372:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/irc.c:1410:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/irc.c:38:7: style: Parameter 's' can be declared as pointer to const [constParameterPointer] xskat-4.0/irc.c:73:7: style: Parameter 's' can be declared as pointer to const [constParameterPointer] xskat-4.0/irc.c:175:7: style: Parameter 'cmd' can be declared as pointer to const [constParameterPointer] xskat-4.0/irc.c:424:7: style: Parameter 'q' can be declared as pointer to const [constParameterPointer] xskat-4.0/irc.c:736:10: style: Parameter 'f' can be declared as pointer to const [constParameterPointer] xskat-4.0/irc.c:747:7: style: Parameter 's' can be declared as pointer to const [constParameterPointer] xskat-4.0/irc.c:828:7: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] xskat-4.0/irc.c:913:7: style: Parameter 'q' can be declared as pointer to const [constParameterPointer] xskat-4.0/irc.c:1060:7: style: Parameter 's' can be declared as pointer to const [constParameterPointer] xskat-4.0/irc.c:1140:7: style: Parameter 'oldnick' can be declared as pointer to const [constParameterPointer] xskat-4.0/xio.c:584:34: debug: Function::addArguments found argument 'themap' with varid 0. [varid0] xskat-4.0/ramsch.c:337:0: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/ramsch.c:414:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/ramsch.c:606:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/ramsch.c:664:0: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/ramsch.c:76:21: style: Operator '|' with one operand equal to zero is redundant. [badBitmaskCheck] xskat-4.0/ramsch.c:359:14: style: Operator '|' with one operand equal to zero is redundant. [badBitmaskCheck] xskat-4.0/skat.c:58:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:64:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:92:16: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:490:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:653:7: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:716:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:1059:5: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:1085:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:1093:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:1180:0: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:1488:0: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:1528:0: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:1625:0: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:1660:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:1832:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:1848:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:2007:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:2062:8: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:2092:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:2588:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:2861:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:2926:0: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:2932:0: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:2939:0: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:2946:0: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:2971:0: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:2998:17: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/skat.c:724:7: style: Suspicious condition (assignment + comparison); Clarify expression with parentheses. [clarifyCondition] xskat-4.0/skat.c:2225:28: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] xskat-4.0/skat.c:2774:14: style: Operator '|' with one operand equal to zero is redundant. [badBitmaskCheck] xskat-4.0/skat.c:2782:15: style: Operator '|' with one operand equal to zero is redundant. [badBitmaskCheck] xskat-4.0/skat.c:2691:30: style: Condition 'hatnfb[spieler][ci>>3]' is always true [knownConditionTrueFalse] xskat-4.0/skat.c:2699:30: style: Condition 'hatnfb[spieler][cj>>3]' is always true [knownConditionTrueFalse] xskat-4.0/skat.c:1828:7: warning:inconclusive: Width 35 given in format string (no. 1) is smaller than destination buffer 'buf[40]'. [invalidScanfFormatWidth_smaller] xskat-4.0/skat.c:87:7: style: Parameter 's' can be declared as pointer to const [constParameterPointer] xskat-4.0/skat.c:800:8: style: Parameter 'b' can be declared as const array [constParameter] xskat-4.0/skat.c:868:9: style: Variable 'o[i]' is assigned a value that is never used. [unreadVariable] xskat-4.0/skat.c:889:11: style: Variable 'o[0]' is assigned a value that is never used. [unreadVariable] xskat-4.0/skat.c:2650:32: style: Variable 'ze[ci>>3]' is assigned a value that is never used. [unreadVariable] xskat-4.0/xio.c:1228:11: error: Array 'col[6][6][6]' accessed at index col[7][*][*], which is out of bounds. [arrayIndexOutOfBounds] xskat-4.0/xio.c:1236:11: note: Assignment 'i=j=k=7', assigned value is 7 xskat-4.0/xio.c:1228:11: note: Array index out of bounds xskat-4.0/xio.c:106:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xio.c:349:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xio.c:399:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xio.c:455:0: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xio.c:566:1: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xio.c:1114:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xio.c:2387:0: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xio.c:2413:0: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xio.c:2488:5: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xio.c:2591:0: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xio.c:2637:0: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xio.c:2711:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xio.c:2845:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xio.c:3351:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xio.c:1598:11: portability: Non reentrant function 'getpwuid' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getpwuid_r'. [prohibitedgetpwuidCalled] xskat-4.0/xio.c:1812:12: warning:inconclusive: Width 4 given in format string (no. 1) is smaller than destination buffer 'line[20]'. [invalidScanfFormatWidth_smaller] xskat-4.0/xio.c:868:6: portability: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS] xskat-4.0/xio.c:1635:39: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] xskat-4.0/xio.c:1637:39: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] xskat-4.0/xio.c:242:10: style: Parameter 'd' can be declared as pointer to const. However it seems that 'query_err' is a callback function, if 'd' is declared with const you might also need to cast function pointer(s). [constParameterCallback] xskat-4.0/xio.c:265:22: note: You might need to cast the function pointer here xskat-4.0/xio.c:242:10: note: Parameter 'd' can be declared as pointer to const xskat-4.0/xio.c:243:14: style: Parameter 'e' can be declared as pointer to const. However it seems that 'query_err' is a callback function, if 'e' is declared with const you might also need to cast function pointer(s). [constParameterCallback] xskat-4.0/xio.c:265:22: note: You might need to cast the function pointer here xskat-4.0/xio.c:243:14: note: Parameter 'e' can be declared as pointer to const xskat-4.0/xio.c:381:9: style: Variable 'eos' can be declared as pointer to const [constVariablePointer] xskat-4.0/xio.c:427:7: style: Parameter 'opt' can be declared as pointer to const [constParameterPointer] xskat-4.0/xio.c:459:10: style: Parameter 'd' can be declared as pointer to const. However it seems that 'ioerr' is a callback function, if 'd' is declared with const you might also need to cast function pointer(s). [constParameterCallback] xskat-4.0/xio.c:1291:22: note: You might need to cast the function pointer here xskat-4.0/xio.c:459:10: note: Parameter 'd' can be declared as pointer to const xskat-4.0/xio.c:511:9: style: Variable 'home' can be declared as pointer to const [constVariablePointer] xskat-4.0/xio.c:570:16: style: Parameter 'thegif' can be declared as pointer to const [constParameterPointer] xskat-4.0/xio.c:1161:8: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] xskat-4.0/xio.c:1269:18: style: Variable 'pwd' can be declared as pointer to const [constVariablePointer] xskat-4.0/xio.c:2550:13: style: Parameter 'x1' can be declared as const array [constParameter] xskat-4.0/xio.c:2550:18: style: Parameter 'y1' can be declared as const array [constParameter] xskat-4.0/xio.c:2550:23: style: Parameter 'x2' can be declared as const array [constParameter] xskat-4.0/xio.c:2550:28: style: Parameter 'y2' can be declared as const array [constParameter] xskat-4.0/xdial.c:294:5: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xdial.c:1059:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xdial.c:1136:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xdial.c:1166:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xdial.c:1365:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xdial.c:1566:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xdial.c:1583:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xdial.c:1838:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xdial.c:2195:5: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xdial.c:2282:0: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xdial.c:2308:5: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xdial.c:2473:0: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xdial.c:2556:0: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xdial.c:2646:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xdial.c:2884:0: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xdial.c:2909:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xdial.c:3084:3: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xdial.c:3340:0: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] xskat-4.0/xdial.c:434:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] xskat-4.0/xdial.c:435:38: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] xskat-4.0/xdial.c:660:46: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] xskat-4.0/xdial.c:725:43: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] xskat-4.0/xdial.c:726:43: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] xskat-4.0/xdial.c:727:43: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] xskat-4.0/xdial.c:774:45: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] xskat-4.0/xdial.c:775:38: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] xskat-4.0/xdial.c:776:38: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] xskat-4.0/xdial.c:955:58: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] xskat-4.0/xdial.c:956:62: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] xskat-4.0/xdial.c:957:48: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] xskat-4.0/xdial.c:1128:36: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] xskat-4.0/xdial.c:1129:36: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] xskat-4.0/xdial.c:1576:26: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] xskat-4.0/xdial.c:1612:35: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] xskat-4.0/xdial.c:189:9: style: Parameter 'ob' can be declared as pointer to const [constParameterPointer] xskat-4.0/xdial.c:266:9: style: Variable 'gr' can be declared as pointer to const [constVariablePointer] xskat-4.0/xdial.c:267:9: style: Variable 'em' can be declared as pointer to const [constVariablePointer] xskat-4.0/xdial.c:1064:9: style: Parameter 'ob' can be declared as pointer to const [constParameterPointer] xskat-4.0/xdial.c:2660:9: style: Variable 'hd' can be declared as pointer to const [constVariablePointer] xskat-4.0/xdial.c:2661:9: style: Variable 'tl' can be declared as pointer to const [constVariablePointer] xskat-4.0/xdial.c:2481:15: style: Variable 'spt' is not assigned a value. [unassignedVariable] xskat-4.0/xdial.c:2918:46: style: Variable 'spt' is not assigned a value. [unassignedVariable] xskat-4.0/xdial.c:3289:15: style: Variable 'txt' is not assigned a value. [unassignedVariable] diff: head xskat-4.0/null.c:322:9: warning: Uninitialized variable: mfb [uninitvar] xskat-4.0/null.c:379:42: note: Calling function 'null_dicht', 5th argument 'mfb' value is xskat-4.0/null.c:322:9: note: Uninitialized variable: mfb 2.13.0 xskat-4.0/xdial.c:711:23: style: Condition 'splfirst[sn]+12=splstp' is false xskat-4.0/xdial.c:711:23: note: Condition 'splfirst[sn]+12