2022-06-20 13:39 ftp://ftp.de.debian.org/debian/pool/main/x/xournalpp/xournalpp_1.1.1.orig.tar.xz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j2 platform: Linux-5.4.0-110-generic-x86_64-with-glibc2.29 python: 3.8.10 client-version: 1.3.24 compiler: g++ (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0 cppcheck: head 2.8 head-info: ff50a01 (2022-06-20 09:17:11 +0200) count: 774 765 elapsed-time: 14.4 22.1 head-timing-info: Overall time: 0s old-timing-info: Overall time: 0s head results: xournalpp-1.1.1/src/control/AudioController.cpp:22:17: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] xournalpp-1.1.1/src/control/settings/Settings.h:88:22: style: Class 'Settings' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/tools/SnapToGridInputHandler.h:20:5: style: Class 'SnapToGridInputHandler' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/ScrollHandler.h:28:5: style: Class 'ScrollHandler' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/jobs/ProgressListener.h:24:18: style: The function 'setMaximumState' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/jobs/ProgressListener.h:16:18: note: Virtual function in base class xournalpp-1.1.1/src/control/jobs/ProgressListener.h:24:18: note: Function in derived class xournalpp-1.1.1/src/control/jobs/ProgressListener.h:25:18: style: The function 'setCurrentState' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/jobs/ProgressListener.h:17:18: note: Virtual function in base class xournalpp-1.1.1/src/control/jobs/ProgressListener.h:25:18: note: Function in derived class xournalpp-1.1.1/src/control/Control.h:118:18: style: The function 'actionPerformed' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/Actions.h:61:18: note: Virtual function in base class xournalpp-1.1.1/src/control/Control.h:118:18: note: Function in derived class xournalpp-1.1.1/src/control/Control.h:125:18: style: The function 'toolColorChanged' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/ToolHandler.h:46:18: note: Virtual function in base class xournalpp-1.1.1/src/control/Control.h:125:18: note: Function in derived class xournalpp-1.1.1/src/control/Control.h:130:18: style: The function 'changeColorOfSelection' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/ToolHandler.h:51:18: note: Virtual function in base class xournalpp-1.1.1/src/control/Control.h:130:18: note: Function in derived class xournalpp-1.1.1/src/control/Control.h:131:18: style: The function 'setCustomColorSelected' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/ToolHandler.h:52:18: note: Virtual function in base class xournalpp-1.1.1/src/control/Control.h:131:18: note: Function in derived class xournalpp-1.1.1/src/control/Control.h:132:18: style: The function 'toolChanged' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/ToolHandler.h:56:18: note: Virtual function in base class xournalpp-1.1.1/src/control/Control.h:132:18: note: Function in derived class xournalpp-1.1.1/src/control/Control.h:133:18: style: The function 'toolSizeChanged' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/ToolHandler.h:53:18: note: Virtual function in base class xournalpp-1.1.1/src/control/Control.h:133:18: note: Function in derived class xournalpp-1.1.1/src/control/Control.h:134:18: style: The function 'toolFillChanged' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/ToolHandler.h:54:18: note: Virtual function in base class xournalpp-1.1.1/src/control/Control.h:134:18: note: Function in derived class xournalpp-1.1.1/src/control/Control.h:135:18: style: The function 'toolLineStyleChanged' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/ToolHandler.h:55:18: note: Virtual function in base class xournalpp-1.1.1/src/control/Control.h:135:18: note: Function in derived class xournalpp-1.1.1/src/control/Control.h:142:18: style: The function 'fileOpened' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/RecentManager.h:29:18: note: Virtual function in base class xournalpp-1.1.1/src/control/Control.h:142:18: note: Function in derived class xournalpp-1.1.1/src/control/Control.h:276:10: style: The function 'setMaximumState' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/jobs/ProgressListener.h:16:18: note: Virtual function in base class xournalpp-1.1.1/src/control/Control.h:276:10: note: Function in derived class xournalpp-1.1.1/src/control/Control.h:277:10: style: The function 'setCurrentState' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/jobs/ProgressListener.h:17:18: note: Virtual function in base class xournalpp-1.1.1/src/control/Control.h:277:10: note: Function in derived class xournalpp-1.1.1/src/control/Control.h:281:18: style: The function 'clipboardCutCopyEnabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/ClipboardHandler.h:26:18: note: Virtual function in base class xournalpp-1.1.1/src/control/Control.h:281:18: note: Function in derived class xournalpp-1.1.1/src/control/Control.h:282:18: style: The function 'clipboardPasteEnabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/ClipboardHandler.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/control/Control.h:282:18: note: Function in derived class xournalpp-1.1.1/src/control/Control.h:283:18: style: The function 'clipboardPasteText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/ClipboardHandler.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/control/Control.h:283:18: note: Function in derived class xournalpp-1.1.1/src/control/Control.h:284:18: style: The function 'clipboardPasteImage' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/ClipboardHandler.h:29:18: note: Virtual function in base class xournalpp-1.1.1/src/control/Control.h:284:18: note: Function in derived class xournalpp-1.1.1/src/control/Control.h:285:18: style: The function 'clipboardPasteXournal' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/ClipboardHandler.h:30:18: note: Virtual function in base class xournalpp-1.1.1/src/control/Control.h:285:18: note: Function in derived class xournalpp-1.1.1/src/control/Control.h:286:18: style: The function 'deleteSelection' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/ClipboardHandler.h:31:18: note: Virtual function in base class xournalpp-1.1.1/src/control/Control.h:286:18: note: Function in derived class xournalpp-1.1.1/src/control/AudioController.cpp:33:14: style: Local variable 'isRecording' shadows outer function [shadowFunction] xournalpp-1.1.1/src/control/AudioController.h:34:10: note: Shadowed declaration xournalpp-1.1.1/src/control/AudioController.cpp:33:14: note: Shadow variable xournalpp-1.1.1/src/control/AudioController.cpp:78:66: warning: Expression '-1' has a negative value. That is converted to an unsigned value and used in an unsigned calculation. [signConversion] xournalpp-1.1.1/src/control/FullscreenHandler.h:25:5: style: Class 'FullscreenHandler' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/jobs/AutosaveJob.h:24:5: style: Class 'AutosaveJob' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/jobs/BaseExportJob.h:66:9: style: Class 'ExportType' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/jobs/CustomExportJob.h:26:5: style: Class 'CustomExportJob' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/jobs/PdfExportJob.h:18:5: style: Class 'PdfExportJob' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/jobs/SaveJob.h:22:5: style: Class 'SaveJob' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/layer/LayerController.h:30:5: style: Class 'LayerController' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/pagetype/PageTypeHandler.h:34:5: style: Class 'PageTypeHandler' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/latex/LatexGenerator.h:27:5: style: Class 'LatexGenerator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/LatexController.h:43:5: style: Class 'LatexController' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/PageBackgroundChangeController.h:33:5: style: Class 'PageBackgroundChangeController' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/jobs/AutosaveJob.h:30:18: style: The function 'run' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/jobs/Job.h:58:18: note: Virtual function in base class xournalpp-1.1.1/src/control/jobs/AutosaveJob.h:30:18: note: Function in derived class xournalpp-1.1.1/src/control/jobs/AutosaveJob.h:31:10: style: The function 'afterRun' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/jobs/Job.h:72:18: note: Virtual function in base class xournalpp-1.1.1/src/control/jobs/AutosaveJob.h:31:10: note: Function in derived class xournalpp-1.1.1/src/control/jobs/AutosaveJob.h:33:21: style: The function 'getType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/jobs/Job.h:44:21: note: Virtual function in base class xournalpp-1.1.1/src/control/jobs/AutosaveJob.h:33:21: note: Function in derived class xournalpp-1.1.1/src/control/jobs/BlockingJob.h:32:10: style: The function 'execute' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/jobs/Job.h:50:18: note: Virtual function in base class xournalpp-1.1.1/src/control/jobs/BlockingJob.h:32:10: note: Function in derived class xournalpp-1.1.1/src/control/jobs/BlockingJob.h:34:21: style: The function 'getType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/jobs/Job.h:44:21: note: Virtual function in base class xournalpp-1.1.1/src/control/jobs/BlockingJob.h:34:21: note: Function in derived class xournalpp-1.1.1/src/control/jobs/BaseExportJob.h:38:18: style: The function 'afterRun' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/jobs/Job.h:72:18: note: Virtual function in base class xournalpp-1.1.1/src/control/jobs/BaseExportJob.h:38:18: note: Function in derived class xournalpp-1.1.1/src/control/jobs/CustomExportJob.h:32:10: style: The function 'run' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/jobs/Job.h:58:18: note: Virtual function in base class xournalpp-1.1.1/src/control/jobs/CustomExportJob.h:32:10: note: Function in derived class xournalpp-1.1.1/src/control/jobs/CustomExportJob.h:35:18: style: The function 'showFilechooser' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/jobs/BaseExportJob.h:41:18: note: Virtual function in base class xournalpp-1.1.1/src/control/jobs/CustomExportJob.h:35:18: note: Function in derived class xournalpp-1.1.1/src/control/jobs/CustomExportJob.h:38:18: style: The function 'afterRun' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/jobs/BaseExportJob.h:38:18: note: Virtual function in base class xournalpp-1.1.1/src/control/jobs/CustomExportJob.h:38:18: note: Function in derived class xournalpp-1.1.1/src/control/jobs/CustomExportJob.h:40:18: style: The function 'addFilterToDialog' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/jobs/BaseExportJob.h:46:18: note: Virtual function in base class xournalpp-1.1.1/src/control/jobs/CustomExportJob.h:40:18: note: Function in derived class xournalpp-1.1.1/src/control/jobs/PdfExportJob.h:24:10: style: The function 'run' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/jobs/Job.h:58:18: note: Virtual function in base class xournalpp-1.1.1/src/control/jobs/PdfExportJob.h:24:10: note: Function in derived class xournalpp-1.1.1/src/control/jobs/PdfExportJob.h:27:18: style: The function 'addFilterToDialog' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/jobs/BaseExportJob.h:46:18: note: Virtual function in base class xournalpp-1.1.1/src/control/jobs/PdfExportJob.h:27:18: note: Function in derived class xournalpp-1.1.1/src/control/jobs/SaveJob.h:28:18: style: The function 'run' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/jobs/Job.h:58:18: note: Virtual function in base class xournalpp-1.1.1/src/control/jobs/SaveJob.h:28:18: note: Function in derived class xournalpp-1.1.1/src/control/jobs/SaveJob.h:35:18: style: The function 'afterRun' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/jobs/Job.h:72:18: note: Virtual function in base class xournalpp-1.1.1/src/control/jobs/SaveJob.h:35:18: note: Function in derived class xournalpp-1.1.1/src/control/Control.cpp:2646:25: warning: Either the condition 'win!=nullptr' is redundant or there is possible null pointer dereference: win. [nullPointerRedundantCheck] xournalpp-1.1.1/src/control/Control.cpp:2638:28: note: Assuming that condition 'win!=nullptr' is not redundant xournalpp-1.1.1/src/control/Control.cpp:2646:25: note: Null pointer dereference xournalpp-1.1.1/src/control/Control.cpp:2513:19: style: The scope of the variable 'cfg' can be reduced. [variableScope] xournalpp-1.1.1/src/control/Control.cpp:2201:14: style: Local variable 'filepath' shadows outer argument [shadowArgument] xournalpp-1.1.1/src/control/Control.cpp:2177:36: note: Shadowed declaration xournalpp-1.1.1/src/control/Control.cpp:2201:14: note: Shadow variable xournalpp-1.1.1/src/control/jobs/BaseExportJob.h:66:32: performance: Function parameter 'ext' should be passed by const reference. [passedByValue] xournalpp-1.1.1/src/control/LatexController.h:60:56: performance: Function parameter 'errorMsg' should be passed by const reference. [passedByValue] xournalpp-1.1.1/src/control/LatexController.h:109:10: style:inconclusive: Technically the member function 'LatexController::isUpdating' can be const. [functionConst] xournalpp-1.1.1/src/control/LatexController.cpp:221:23: note: Technically the member function 'LatexController::isUpdating' can be const. xournalpp-1.1.1/src/control/LatexController.h:109:10: note: Technically the member function 'LatexController::isUpdating' can be const. xournalpp-1.1.1/src/control/PdfCache.cpp:37:11: warning: Member variable 'PdfCache::zoomRefreshThreshold' is not initialized in the constructor. [uninitMemberVar] xournalpp-1.1.1/src/control/PdfCache.h:29:5: style: Class 'PdfCache' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/PdfCache.cpp:46:43: style:inconclusive: Function 'setRefreshThreshold' argument 1 names different: declaration 'percentDifference' definition 'threshold'. [funcArgNamesDifferent] xournalpp-1.1.1/src/control/PdfCache.h:54:37: note: Function 'setRefreshThreshold' argument 1 names different: declaration 'percentDifference' definition 'threshold'. xournalpp-1.1.1/src/control/PdfCache.cpp:46:43: note: Function 'setRefreshThreshold' argument 1 names different: declaration 'percentDifference' definition 'threshold'. xournalpp-1.1.1/src/control/PdfCache.cpp:59:70: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/control/SearchControl.cpp:24:26: style: Local variable 'rect' shadows outer argument [shadowArgument] xournalpp-1.1.1/src/control/SearchControl.cpp:20:54: note: Shadowed declaration xournalpp-1.1.1/src/control/SearchControl.cpp:24:26: note: Shadow variable xournalpp-1.1.1/src/control/Tool.h:69:50: style:inconclusive: Member variable 'Tool::thickness' is in the wrong place in the initializer list. [initializerList] xournalpp-1.1.1/src/control/Tool.cpp:12:86: note: Member variable 'Tool::thickness' is in the wrong place in the initializer list. xournalpp-1.1.1/src/control/Tool.h:69:50: note: Member variable 'Tool::thickness' is in the wrong place in the initializer list. xournalpp-1.1.1/src/control/UndoRedoController.h:24:5: style: Class 'UndoRedoController' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/UndoRedoController.cpp:20:22: style: Consider using std::copy algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/control/XournalMain.cpp:135:22: style: Consider using std::copy_if algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/control/jobs/CustomExportJob.cpp:35:16: style: Variable 'filter' can be declared as reference to const [constVariable] xournalpp-1.1.1/src/control/jobs/CustomExportJob.cpp:42:16: style: Variable 'filter' can be declared as reference to const [constVariable] xournalpp-1.1.1/src/control/jobs/PreviewJob.h:30:5: style: Class 'PreviewJob' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/jobs/PreviewJob.h:37:19: style: The function 'getSource' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/jobs/Job.h:52:19: note: Virtual function in base class xournalpp-1.1.1/src/control/jobs/PreviewJob.h:37:19: note: Function in derived class xournalpp-1.1.1/src/control/jobs/PreviewJob.h:39:18: style: The function 'run' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/jobs/Job.h:58:18: note: Virtual function in base class xournalpp-1.1.1/src/control/jobs/PreviewJob.h:39:18: note: Function in derived class xournalpp-1.1.1/src/control/jobs/PreviewJob.h:41:21: style: The function 'getType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/jobs/Job.h:44:21: note: Virtual function in base class xournalpp-1.1.1/src/control/jobs/PreviewJob.h:41:21: note: Function in derived class xournalpp-1.1.1/src/control/jobs/RenderJob.h:27:5: style: Class 'RenderJob' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/jobs/RenderJob.h:33:21: style: The function 'getType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/jobs/Job.h:44:21: note: Virtual function in base class xournalpp-1.1.1/src/control/jobs/RenderJob.h:33:21: note: Function in derived class xournalpp-1.1.1/src/control/jobs/RenderJob.h:35:11: style: The function 'getSource' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/jobs/Job.h:52:19: note: Virtual function in base class xournalpp-1.1.1/src/control/jobs/RenderJob.h:35:11: note: Function in derived class xournalpp-1.1.1/src/control/jobs/RenderJob.h:37:10: style: The function 'run' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/jobs/Job.h:58:18: note: Virtual function in base class xournalpp-1.1.1/src/control/jobs/RenderJob.h:37:10: note: Function in derived class xournalpp-1.1.1/src/control/jobs/Scheduler.cpp:69:25: style: Local variable 'lock' shadows outer function [shadowFunction] xournalpp-1.1.1/src/control/jobs/Scheduler.h:88:10: note: Shadowed declaration xournalpp-1.1.1/src/control/jobs/Scheduler.cpp:69:25: note: Shadow variable xournalpp-1.1.1/src/control/jobs/Scheduler.cpp:123:21: style: Local variable 'lock' shadows outer function [shadowFunction] xournalpp-1.1.1/src/control/jobs/Scheduler.h:88:10: note: Shadowed declaration xournalpp-1.1.1/src/control/jobs/Scheduler.cpp:123:21: note: Shadow variable xournalpp-1.1.1/src/control/jobs/Scheduler.cpp:135:25: style: Local variable 'lock' shadows outer function [shadowFunction] xournalpp-1.1.1/src/control/jobs/Scheduler.h:88:10: note: Shadowed declaration xournalpp-1.1.1/src/control/jobs/Scheduler.cpp:135:25: note: Shadow variable xournalpp-1.1.1/src/control/jobs/Scheduler.cpp:174:25: style: Local variable 'lock' shadows outer function [shadowFunction] xournalpp-1.1.1/src/control/jobs/Scheduler.h:88:10: note: Shadowed declaration xournalpp-1.1.1/src/control/jobs/Scheduler.cpp:174:25: note: Shadow variable xournalpp-1.1.1/src/control/jobs/Scheduler.cpp:193:29: style: Local variable 'lock' shadows outer function [shadowFunction] xournalpp-1.1.1/src/control/jobs/Scheduler.h:88:10: note: Shadowed declaration xournalpp-1.1.1/src/control/jobs/Scheduler.cpp:193:29: note: Shadow variable xournalpp-1.1.1/src/control/jobs/Scheduler.cpp:243:29: style: Local variable 'lock' shadows outer function [shadowFunction] xournalpp-1.1.1/src/control/jobs/Scheduler.h:88:10: note: Shadowed declaration xournalpp-1.1.1/src/control/jobs/Scheduler.cpp:243:29: note: Shadow variable xournalpp-1.1.1/src/control/settings/MetadataManager.cpp:59:34: style: Parameter 'a' can be declared as reference to const. However it seems that 'sortMetadata' is a callback function, if 'a' is declared with const you might also need to cast function pointer(s). [constParameterCallback] xournalpp-1.1.1/src/control/settings/MetadataManager.cpp:83:41: note: You might need to cast the function pointer here xournalpp-1.1.1/src/control/settings/MetadataManager.cpp:59:34: note: Parameter 'a' can be declared as reference to const xournalpp-1.1.1/src/control/settings/MetadataManager.cpp:59:52: style: Parameter 'b' can be declared as reference to const. However it seems that 'sortMetadata' is a callback function, if 'b' is declared with const you might also need to cast function pointer(s). [constParameterCallback] xournalpp-1.1.1/src/control/settings/MetadataManager.cpp:83:41: note: You might need to cast the function pointer here xournalpp-1.1.1/src/control/settings/MetadataManager.cpp:59:52: note: Parameter 'b' can be declared as reference to const xournalpp-1.1.1/src/control/settings/MetadataManager.cpp:141:29: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/control/shaperecognizer/CircleRecognizer.cpp:59:42: style:inconclusive: Function 'recognize' argument 1 names different: declaration 's' definition 'stroke'. [funcArgNamesDifferent] xournalpp-1.1.1/src/control/shaperecognizer/CircleRecognizer.h:23:38: note: Function 'recognize' argument 1 names different: declaration 's' definition 'stroke'. xournalpp-1.1.1/src/control/shaperecognizer/CircleRecognizer.cpp:59:42: note: Function 'recognize' argument 1 names different: declaration 's' definition 'stroke'. xournalpp-1.1.1/src/control/shaperecognizer/CircleRecognizer.cpp:35:56: style: Parameter 'inertia' can be declared as reference to const [constParameter] xournalpp-1.1.1/src/control/shaperecognizer/ShapeRecognizerResult.h:24:5: style: Class 'ShapeRecognizerResult' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/shaperecognizer/ShapeRecognizerResult.cpp:23:18: style: Variable 'elem' can be declared as pointer to const [constVariable] xournalpp-1.1.1/src/control/shaperecognizer/ShapeRecognizerResult.cpp:24:24: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/control/settings/Settings.cpp:237:21: warning: %x in format string (no. 1) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int] xournalpp-1.1.1/src/control/settings/Settings.cpp:798:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:799:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:800:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:802:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:804:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:809:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:810:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:811:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:813:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:814:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:815:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:816:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:817:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:818:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:819:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:820:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:822:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:824:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:825:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:827:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:828:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:829:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:830:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:831:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:832:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:833:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:834:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:835:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:836:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:837:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:838:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:840:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:841:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:843:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:844:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:847:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:849:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:850:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:851:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:852:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:853:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:854:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:855:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:857:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:868:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:871:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:872:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:873:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:875:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:876:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:878:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:879:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:880:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:881:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:883:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:884:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:887:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:888:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:889:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:890:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:891:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:893:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:894:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:896:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:897:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:898:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:900:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:901:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:903:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:904:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:905:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:906:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:907:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:909:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:910:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:912:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:914:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:915:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:916:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:917:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:918:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:919:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:921:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:922:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:924:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:925:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:926:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:927:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:928:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:929:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:931:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:932:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:934:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:936:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:937:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:939:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:946:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:947:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:948:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:949:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:950:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:951:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:952:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:955:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:961:5: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/control/settings/Settings.cpp:799:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:798:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:799:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:800:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:799:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:800:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:802:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:800:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:802:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:804:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:802:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:804:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:809:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:804:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:809:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:810:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:809:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:810:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:811:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:810:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:811:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:813:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:811:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:813:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:814:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:813:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:814:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:815:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:814:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:815:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:816:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:815:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:816:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:817:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:816:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:817:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:818:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:817:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:818:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:819:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:818:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:819:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:820:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:819:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:820:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:822:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:820:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:822:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:824:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:822:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:824:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:825:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:824:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:825:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:827:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:825:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:827:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:828:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:827:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:828:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:829:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:828:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:829:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:830:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:829:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:830:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:831:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:830:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:831:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:832:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:831:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:832:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:833:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:832:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:833:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:834:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:833:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:834:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/tools/BaseStrokeHandler.h:31:10: style: The function 'draw' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/InputHandler.h:50:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/BaseStrokeHandler.h:31:10: note: Function in derived class xournalpp-1.1.1/src/control/settings/Settings.cpp:835:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:834:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:835:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/tools/BaseStrokeHandler.h:33:10: style: The function 'onMotionCancelEvent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/InputHandler.h:92:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/BaseStrokeHandler.h:33:10: note: Function in derived class xournalpp-1.1.1/src/control/settings/Settings.cpp:836:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:835:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:836:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/tools/BaseStrokeHandler.h:34:10: style: The function 'onMotionNotifyEvent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/InputHandler.h:59:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/BaseStrokeHandler.h:34:10: note: Function in derived class xournalpp-1.1.1/src/control/settings/Settings.cpp:837:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:836:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:837:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/tools/BaseStrokeHandler.h:35:10: style: The function 'onButtonReleaseEvent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/InputHandler.h:73:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/BaseStrokeHandler.h:35:10: note: Function in derived class xournalpp-1.1.1/src/control/settings/Settings.cpp:838:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:837:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:838:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/tools/BaseStrokeHandler.h:36:10: style: The function 'onButtonPressEvent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/InputHandler.h:79:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/BaseStrokeHandler.h:36:10: note: Function in derived class xournalpp-1.1.1/src/control/settings/Settings.cpp:840:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:838:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:840:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/tools/BaseStrokeHandler.h:37:10: style: The function 'onButtonDoublePressEvent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/InputHandler.h:85:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/BaseStrokeHandler.h:37:10: note: Function in derived class xournalpp-1.1.1/src/control/settings/Settings.cpp:850:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:849:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:850:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/tools/BaseStrokeHandler.h:38:18: style: The function 'onKeyEvent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/InputHandler.h:66:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/BaseStrokeHandler.h:38:18: note: Function in derived class xournalpp-1.1.1/src/control/settings/Settings.cpp:851:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:850:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:851:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/tools/ArrowHandler.h:22:18: style: The function 'drawShape' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/BaseStrokeHandler.h:41:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/ArrowHandler.h:22:18: note: Function in derived class xournalpp-1.1.1/src/control/settings/Settings.cpp:852:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:851:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:852:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:853:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:852:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:853:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:854:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:853:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:854:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:855:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:854:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:855:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:857:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:855:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:857:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:860:17: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:857:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:860:17: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:872:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:871:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:872:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:873:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:872:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:873:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:875:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:873:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:875:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:876:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:875:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:876:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:878:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:876:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:878:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:879:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:878:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:879:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:880:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:879:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:880:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:881:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:880:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:881:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:883:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:881:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:883:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:884:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:883:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:884:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:887:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:884:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:887:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:888:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:887:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:888:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:889:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:888:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:889:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:890:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:889:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:890:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:891:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:890:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:891:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:893:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:891:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:893:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:894:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:893:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:894:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:896:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:894:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:896:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:897:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:896:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:897:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:898:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:897:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:898:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:900:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:898:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:900:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:901:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:900:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:901:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:903:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:901:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:903:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:906:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:905:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:906:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:907:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:906:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:907:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:909:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:907:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:909:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:914:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:912:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:914:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:915:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:914:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:915:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:916:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:915:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:916:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:917:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:916:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:917:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:918:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:917:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:918:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:919:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:918:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:919:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:921:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:919:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:921:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:922:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:921:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:922:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:924:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:922:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:924:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:925:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:924:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:925:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:926:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:925:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:926:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:927:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:926:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:927:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:928:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:927:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:928:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:929:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:928:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:929:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:931:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:929:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:931:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:932:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:931:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:932:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:934:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:932:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:934:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:936:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:934:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:936:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:937:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:936:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:937:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:939:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:937:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:939:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:946:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:939:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:946:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:947:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:946:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:947:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:948:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:947:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:948:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:949:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:948:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:949:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:950:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:949:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:950:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:951:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:950:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:951:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:952:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:951:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:952:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:955:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:952:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:955:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:960:13: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:955:5: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:960:13: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:961:5: style: Variable 'xmlNode' is reassigned a value before the old one has been used. [redundantAssignment] xournalpp-1.1.1/src/control/settings/Settings.cpp:960:13: note: xmlNode is assigned xournalpp-1.1.1/src/control/settings/Settings.cpp:961:5: note: xmlNode is overwritten xournalpp-1.1.1/src/control/settings/Settings.cpp:1162:53: style:inconclusive: Function 'setStylusCursorType' argument 1 names different: declaration 'stylusCursorType' definition 'type'. [funcArgNamesDifferent] xournalpp-1.1.1/src/control/settings/Settings.h:289:47: note: Function 'setStylusCursorType' argument 1 names different: declaration 'stylusCursorType' definition 'type'. xournalpp-1.1.1/src/control/settings/Settings.cpp:1162:53: note: Function 'setStylusCursorType' argument 1 names different: declaration 'stylusCursorType' definition 'type'. xournalpp-1.1.1/src/control/settings/Settings.cpp:1212:53: style:inconclusive: Function 'setCursorHighlightBorderWidth' argument 1 names different: declaration 'width' definition 'radius'. [funcArgNamesDifferent] xournalpp-1.1.1/src/control/settings/Settings.h:304:47: note: Function 'setCursorHighlightBorderWidth' argument 1 names different: declaration 'width' definition 'radius'. xournalpp-1.1.1/src/control/settings/Settings.cpp:1212:53: note: Function 'setCursorHighlightBorderWidth' argument 1 names different: declaration 'width' definition 'radius'. xournalpp-1.1.1/src/control/settings/Settings.cpp:1533:49: style:inconclusive: Function 'setLastImagePath' argument 1 names different: declaration 'p' definition 'path'. [funcArgNamesDifferent] xournalpp-1.1.1/src/control/settings/Settings.h:190:43: note: Function 'setLastImagePath' argument 1 names different: declaration 'p' definition 'path'. xournalpp-1.1.1/src/control/settings/Settings.cpp:1533:49: note: Function 'setLastImagePath' argument 1 names different: declaration 'p' definition 'path'. xournalpp-1.1.1/src/control/settings/Settings.cpp:1573:41: style:inconclusive: Function 'setEdgePanMaxMult' argument 1 names different: declaration 'mult' definition 'maxMult'. [funcArgNamesDifferent] xournalpp-1.1.1/src/control/settings/Settings.h:148:35: note: Function 'setEdgePanMaxMult' argument 1 names different: declaration 'mult' definition 'maxMult'. xournalpp-1.1.1/src/control/settings/Settings.cpp:1573:41: note: Function 'setEdgePanMaxMult' argument 1 names different: declaration 'mult' definition 'maxMult'. xournalpp-1.1.1/src/control/settings/Settings.cpp:1866:37: style:inconclusive: Function 'getStrokeFilter' argument 1 names different: declaration 'strokeFilterIgnoreTime' definition 'ignoreTime'. [funcArgNamesDifferent] xournalpp-1.1.1/src/control/settings/Settings.h:435:31: note: Function 'getStrokeFilter' argument 1 names different: declaration 'strokeFilterIgnoreTime' definition 'ignoreTime'. xournalpp-1.1.1/src/control/settings/Settings.cpp:1866:37: note: Function 'getStrokeFilter' argument 1 names different: declaration 'strokeFilterIgnoreTime' definition 'ignoreTime'. xournalpp-1.1.1/src/control/settings/Settings.cpp:1866:57: style:inconclusive: Function 'getStrokeFilter' argument 2 names different: declaration 'strokeFilterIgnoreLength' definition 'ignoreLength'. [funcArgNamesDifferent] xournalpp-1.1.1/src/control/settings/Settings.h:435:63: note: Function 'getStrokeFilter' argument 2 names different: declaration 'strokeFilterIgnoreLength' definition 'ignoreLength'. xournalpp-1.1.1/src/control/settings/Settings.cpp:1866:57: note: Function 'getStrokeFilter' argument 2 names different: declaration 'strokeFilterIgnoreLength' definition 'ignoreLength'. xournalpp-1.1.1/src/control/settings/Settings.cpp:1866:76: style:inconclusive: Function 'getStrokeFilter' argument 3 names different: declaration 'strokeFilterSuccessiveTime' definition 'successiveTime'. [funcArgNamesDifferent] xournalpp-1.1.1/src/control/settings/Settings.h:436:31: note: Function 'getStrokeFilter' argument 3 names different: declaration 'strokeFilterSuccessiveTime' definition 'successiveTime'. xournalpp-1.1.1/src/control/settings/Settings.cpp:1866:76: note: Function 'getStrokeFilter' argument 3 names different: declaration 'strokeFilterSuccessiveTime' definition 'successiveTime'. xournalpp-1.1.1/src/control/settings/Settings.cpp:1872:36: style:inconclusive: Function 'setStrokeFilter' argument 1 names different: declaration 'strokeFilterIgnoreTime' definition 'ignoreTime'. [funcArgNamesDifferent] xournalpp-1.1.1/src/control/settings/Settings.h:441:30: note: Function 'setStrokeFilter' argument 1 names different: declaration 'strokeFilterIgnoreTime' definition 'ignoreTime'. xournalpp-1.1.1/src/control/settings/Settings.cpp:1872:36: note: Function 'setStrokeFilter' argument 1 names different: declaration 'strokeFilterIgnoreTime' definition 'ignoreTime'. xournalpp-1.1.1/src/control/settings/Settings.cpp:1872:55: style:inconclusive: Function 'setStrokeFilter' argument 2 names different: declaration 'strokeFilterIgnoreLength' definition 'ignoreLength'. [funcArgNamesDifferent] xournalpp-1.1.1/src/control/settings/Settings.h:441:61: note: Function 'setStrokeFilter' argument 2 names different: declaration 'strokeFilterIgnoreLength' definition 'ignoreLength'. xournalpp-1.1.1/src/control/settings/Settings.cpp:1872:55: note: Function 'setStrokeFilter' argument 2 names different: declaration 'strokeFilterIgnoreLength' definition 'ignoreLength'. xournalpp-1.1.1/src/control/settings/Settings.cpp:1872:73: style:inconclusive: Function 'setStrokeFilter' argument 3 names different: declaration 'strokeFilterSuccessiveTime' definition 'successiveTime'. [funcArgNamesDifferent] xournalpp-1.1.1/src/control/settings/Settings.h:441:91: note: Function 'setStrokeFilter' argument 3 names different: declaration 'strokeFilterSuccessiveTime' definition 'successiveTime'. xournalpp-1.1.1/src/control/settings/Settings.cpp:1872:73: note: Function 'setStrokeFilter' argument 3 names different: declaration 'strokeFilterSuccessiveTime' definition 'successiveTime'. xournalpp-1.1.1/src/control/settings/Settings.cpp:293:18: style: Local variable 'font' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/control/settings/Settings.h:665:13: note: Shadowed declaration xournalpp-1.1.1/src/control/settings/Settings.cpp:293:18: note: Shadow variable xournalpp-1.1.1/src/control/settings/Settings.cpp:806:10: style: Local variable 'lastSavePath' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/control/settings/Settings.h:650:14: note: Shadowed declaration xournalpp-1.1.1/src/control/settings/Settings.cpp:806:10: note: Shadow variable xournalpp-1.1.1/src/control/settings/Settings.cpp:807:10: style: Local variable 'lastOpenPath' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/control/settings/Settings.h:655:14: note: Shadowed declaration xournalpp-1.1.1/src/control/settings/Settings.cpp:807:10: note: Shadow variable xournalpp-1.1.1/src/control/settings/Settings.cpp:808:10: style: Local variable 'lastImagePath' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/control/settings/Settings.h:660:14: note: Shadowed declaration xournalpp-1.1.1/src/control/settings/Settings.cpp:808:10: note: Shadow variable xournalpp-1.1.1/src/control/settings/Settings.cpp:975:49: style: Local variable 'p' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/control/settings/Settings.cpp:959:15: note: Shadowed declaration xournalpp-1.1.1/src/control/settings/Settings.cpp:975:49: note: Shadow variable xournalpp-1.1.1/src/control/settings/Settings.cpp:2075:17: style: Variable 'attrib' can be declared as reference to const [constVariable] xournalpp-1.1.1/src/control/settings/Settings.cpp:2091:17: style: Variable 'attrib' can be declared as reference to const [constVariable] xournalpp-1.1.1/src/control/settings/Settings.cpp:2107:17: style: Variable 'attrib' can be declared as reference to const [constVariable] xournalpp-1.1.1/src/control/settings/Settings.cpp:2123:17: style: Variable 'attrib' can be declared as reference to const [constVariable] xournalpp-1.1.1/src/control/tools/BaseStrokeHandler.h:44:10: style:inconclusive: Member variable 'BaseStrokeHandler::flipShift' is in the wrong place in the initializer list. [initializerList] xournalpp-1.1.1/src/control/tools/BaseStrokeHandler.cpp:20:9: note: Member variable 'BaseStrokeHandler::flipShift' is in the wrong place in the initializer list. xournalpp-1.1.1/src/control/tools/BaseStrokeHandler.h:44:10: note: Member variable 'BaseStrokeHandler::flipShift' is in the wrong place in the initializer list. xournalpp-1.1.1/src/control/tools/CoordinateSystemHandler.h:23:18: style: The function 'drawShape' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/BaseStrokeHandler.h:41:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/CoordinateSystemHandler.h:23:18: note: Function in derived class xournalpp-1.1.1/src/control/tools/EditSelectionContents.h:167:23: style:inconclusive: Member variable 'EditSelectionContents::originalBounds' is in the wrong place in the initializer list. [initializerList] xournalpp-1.1.1/src/control/tools/EditSelectionContents.cpp:36:9: note: Member variable 'EditSelectionContents::originalBounds' is in the wrong place in the initializer list. xournalpp-1.1.1/src/control/tools/EditSelectionContents.h:167:23: note: Member variable 'EditSelectionContents::originalBounds' is in the wrong place in the initializer list. xournalpp-1.1.1/src/control/tools/EditSelectionContents.h:152:14: style:inconclusive: Technically the member function 'EditSelectionContents::Anonymous0::operator()' can be const. [functionConst] xournalpp-1.1.1/src/control/tools/Selection.h:55:18: style: The function 'finalize' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/Selection.h:30:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/Selection.h:55:18: note: Function in derived class xournalpp-1.1.1/src/control/tools/Selection.h:56:18: style: The function 'paint' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/Selection.h:31:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/Selection.h:56:18: note: Function in derived class xournalpp-1.1.1/src/control/tools/Selection.h:57:18: style: The function 'currentPos' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/Selection.h:32:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/Selection.h:57:18: note: Function in derived class xournalpp-1.1.1/src/control/tools/Selection.h:59:18: style: The function 'userTapped' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/Selection.h:33:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/Selection.h:59:18: note: Function in derived class xournalpp-1.1.1/src/control/tools/Selection.h:83:18: style: The function 'finalize' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/Selection.h:30:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/Selection.h:83:18: note: Function in derived class xournalpp-1.1.1/src/control/tools/Selection.h:84:18: style: The function 'paint' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/Selection.h:31:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/Selection.h:84:18: note: Function in derived class xournalpp-1.1.1/src/control/tools/Selection.h:85:18: style: The function 'currentPos' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/Selection.h:32:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/Selection.h:85:18: note: Function in derived class xournalpp-1.1.1/src/control/tools/Selection.h:87:18: style: The function 'userTapped' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/Selection.h:33:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/Selection.h:87:18: note: Function in derived class xournalpp-1.1.1/src/control/tools/EditSelectionContents.cpp:191:12: style:inconclusive: Same expression used in consecutive assignments of 'x1' and 'x2'. [duplicateAssignExpression] xournalpp-1.1.1/src/control/tools/EditSelectionContents.cpp:192:12: note: Same expression used in consecutive assignments of 'x1' and 'x2'. xournalpp-1.1.1/src/control/tools/EditSelectionContents.cpp:191:12: note: Same expression used in consecutive assignments of 'x1' and 'x2'. xournalpp-1.1.1/src/control/tools/EditSelectionContents.cpp:191:21: style: Same expression on both sides of '/'. [duplicateExpression] xournalpp-1.1.1/src/control/tools/EditSelectionContents.cpp:192:12: style:inconclusive: Same expression used in consecutive assignments of 'x2' and 'y1'. [duplicateAssignExpression] xournalpp-1.1.1/src/control/tools/EditSelectionContents.cpp:193:12: note: Same expression used in consecutive assignments of 'x2' and 'y1'. xournalpp-1.1.1/src/control/tools/EditSelectionContents.cpp:192:12: note: Same expression used in consecutive assignments of 'x2' and 'y1'. xournalpp-1.1.1/src/control/tools/EditSelectionContents.cpp:192:21: style: Same expression on both sides of '/'. [duplicateExpression] xournalpp-1.1.1/src/control/tools/EditSelectionContents.cpp:193:12: style:inconclusive: Same expression used in consecutive assignments of 'y1' and 'y2'. [duplicateAssignExpression] xournalpp-1.1.1/src/control/tools/EditSelectionContents.cpp:194:12: note: Same expression used in consecutive assignments of 'y1' and 'y2'. xournalpp-1.1.1/src/control/tools/EditSelectionContents.cpp:193:12: note: Same expression used in consecutive assignments of 'y1' and 'y2'. xournalpp-1.1.1/src/control/tools/EditSelectionContents.cpp:193:21: style: Same expression on both sides of '/'. [duplicateExpression] xournalpp-1.1.1/src/control/tools/EditSelectionContents.cpp:194:21: style: Same expression on both sides of '/'. [duplicateExpression] xournalpp-1.1.1/src/control/tools/EditSelection.h:312:12: style:inconclusive: Member variable 'EditSelection::x' is in the wrong place in the initializer list. [initializerList] xournalpp-1.1.1/src/control/tools/EditSelection.cpp:46:9: note: Member variable 'EditSelection::x' is in the wrong place in the initializer list. xournalpp-1.1.1/src/control/tools/EditSelection.h:312:12: note: Member variable 'EditSelection::x' is in the wrong place in the initializer list. xournalpp-1.1.1/src/control/tools/EllipseHandler.h:23:18: style: The function 'drawShape' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/BaseStrokeHandler.h:41:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/EllipseHandler.h:23:18: note: Function in derived class xournalpp-1.1.1/src/control/tools/EditSelection.cpp:452:38: style:inconclusive: Function 'mouseMove' argument 1 names different: declaration 'x' definition 'mouseX'. [funcArgNamesDifferent] xournalpp-1.1.1/src/control/tools/EditSelection.h:229:27: note: Function 'mouseMove' argument 1 names different: declaration 'x' definition 'mouseX'. xournalpp-1.1.1/src/control/tools/EditSelection.cpp:452:38: note: Function 'mouseMove' argument 1 names different: declaration 'x' definition 'mouseX'. xournalpp-1.1.1/src/control/tools/EditSelection.cpp:452:53: style:inconclusive: Function 'mouseMove' argument 2 names different: declaration 'y' definition 'mouseY'. [funcArgNamesDifferent] xournalpp-1.1.1/src/control/tools/EditSelection.h:229:37: note: Function 'mouseMove' argument 2 names different: declaration 'y' definition 'mouseY'. xournalpp-1.1.1/src/control/tools/EditSelection.cpp:452:53: note: Function 'mouseMove' argument 2 names different: declaration 'y' definition 'mouseY'. xournalpp-1.1.1/src/control/tools/EditSelection.cpp:721:37: style:inconclusive: Function 'setEdgePan' argument 1 names different: declaration 'edgePan' definition 'pan'. [funcArgNamesDifferent] xournalpp-1.1.1/src/control/tools/EditSelection.h:294:26: note: Function 'setEdgePan' argument 1 names different: declaration 'edgePan' definition 'pan'. xournalpp-1.1.1/src/control/tools/EditSelection.cpp:721:37: note: Function 'setEdgePan' argument 1 names different: declaration 'edgePan' definition 'pan'. xournalpp-1.1.1/src/control/tools/EditSelection.cpp:922:12: style: Local variable 'x' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/control/tools/EditSelection.h:312:12: note: Shadowed declaration xournalpp-1.1.1/src/control/tools/EditSelection.cpp:922:12: note: Shadow variable xournalpp-1.1.1/src/control/tools/EditSelection.cpp:923:12: style: Local variable 'y' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/control/tools/EditSelection.h:313:12: note: Shadowed declaration xournalpp-1.1.1/src/control/tools/EditSelection.cpp:923:12: note: Shadow variable xournalpp-1.1.1/src/control/tools/RectangleHandler.h:23:18: style: The function 'drawShape' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/BaseStrokeHandler.h:41:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/RectangleHandler.h:23:18: note: Function in derived class xournalpp-1.1.1/src/control/tools/RulerHandler.h:22:18: style: The function 'drawShape' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/BaseStrokeHandler.h:41:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/RulerHandler.h:22:18: note: Function in derived class xournalpp-1.1.1/src/control/tools/SplineHandler.h:41:10: style: The function 'draw' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/InputHandler.h:50:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/SplineHandler.h:41:10: note: Function in derived class xournalpp-1.1.1/src/control/tools/SplineHandler.h:43:10: style: The function 'onMotionCancelEvent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/InputHandler.h:92:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/SplineHandler.h:43:10: note: Function in derived class xournalpp-1.1.1/src/control/tools/SplineHandler.h:44:10: style: The function 'onMotionNotifyEvent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/InputHandler.h:59:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/SplineHandler.h:44:10: note: Function in derived class xournalpp-1.1.1/src/control/tools/SplineHandler.h:45:10: style: The function 'onButtonReleaseEvent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/InputHandler.h:73:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/SplineHandler.h:45:10: note: Function in derived class xournalpp-1.1.1/src/control/tools/SplineHandler.h:46:10: style: The function 'onButtonPressEvent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/InputHandler.h:79:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/SplineHandler.h:46:10: note: Function in derived class xournalpp-1.1.1/src/control/tools/SplineHandler.h:47:10: style: The function 'onButtonDoublePressEvent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/InputHandler.h:85:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/SplineHandler.h:47:10: note: Function in derived class xournalpp-1.1.1/src/control/tools/SplineHandler.h:48:18: style: The function 'onKeyEvent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/InputHandler.h:66:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/SplineHandler.h:48:18: note: Function in derived class xournalpp-1.1.1/src/control/tools/StrokeHandler.cpp:23:16: warning: Member variable 'StrokeHandler::hasPressure' is not initialized in the constructor. [uninitMemberVar] xournalpp-1.1.1/src/control/tools/StrokeStabilizer.h:57:5: warning: Member variable 'Base::strokeHandler' is not initialized in the constructor. [uninitMemberVar] xournalpp-1.1.1/src/control/tools/StrokeStabilizer.h:57:5: warning: Member variable 'Base::zoom' is not initialized in the constructor. [uninitMemberVar] xournalpp-1.1.1/src/control/tools/StrokeStabilizer.h:46:10: style:inconclusive: Technically the member function 'StrokeStabilizer::Event::operator!=' can be const. [functionConst] xournalpp-1.1.1/src/control/tools/StrokeStabilizer.h:45:5: style: Struct 'Event' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/tools/StrokeStabilizer.h:399:9: style: Struct 'VelocityEvent' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/tools/StrokeStabilizer.h:400:9: style: Struct 'VelocityEvent' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/tools/StrokeHandler.h:40:10: style: The function 'draw' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/InputHandler.h:50:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/StrokeHandler.h:40:10: note: Function in derived class xournalpp-1.1.1/src/control/tools/StrokeHandler.h:42:10: style: The function 'onMotionCancelEvent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/InputHandler.h:92:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/StrokeHandler.h:42:10: note: Function in derived class xournalpp-1.1.1/src/control/tools/StrokeHandler.h:43:10: style: The function 'onMotionNotifyEvent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/InputHandler.h:59:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/StrokeHandler.h:43:10: note: Function in derived class xournalpp-1.1.1/src/control/tools/StrokeHandler.h:44:10: style: The function 'onButtonReleaseEvent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/InputHandler.h:73:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/StrokeHandler.h:44:10: note: Function in derived class xournalpp-1.1.1/src/control/tools/StrokeHandler.h:45:10: style: The function 'onButtonPressEvent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/InputHandler.h:79:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/StrokeHandler.h:45:10: note: Function in derived class xournalpp-1.1.1/src/control/tools/StrokeHandler.h:46:10: style: The function 'onButtonDoublePressEvent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/InputHandler.h:85:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/StrokeHandler.h:46:10: note: Function in derived class xournalpp-1.1.1/src/control/tools/StrokeHandler.h:47:10: style: The function 'onKeyEvent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/InputHandler.h:66:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/StrokeHandler.h:47:10: note: Function in derived class xournalpp-1.1.1/src/control/tools/StrokeHandler.h:52:18: style: The function 'resetShapeRecognizer' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/tools/InputHandler.h:103:18: note: Virtual function in base class xournalpp-1.1.1/src/control/tools/StrokeHandler.h:52:18: note: Function in derived class xournalpp-1.1.1/src/control/tools/StrokeStabilizer.cpp:351:12: style: The scope of the variable 'weight' can be reduced. [variableScope] xournalpp-1.1.1/src/control/xml/DoubleArrayAttribute.h:26:18: style: The function 'writeOut' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/xml/Attribute.h:26:18: note: Virtual function in base class xournalpp-1.1.1/src/control/xml/DoubleArrayAttribute.h:26:18: note: Function in derived class xournalpp-1.1.1/src/control/xml/DoubleAttribute.h:26:18: style: The function 'writeOut' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/xml/Attribute.h:26:18: note: Virtual function in base class xournalpp-1.1.1/src/control/xml/DoubleAttribute.h:26:18: note: Function in derived class xournalpp-1.1.1/src/control/xml/IntAttribute.h:22:18: style: The function 'writeOut' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/xml/Attribute.h:26:18: note: Virtual function in base class xournalpp-1.1.1/src/control/xml/IntAttribute.h:22:18: note: Function in derived class xournalpp-1.1.1/src/control/xml/SizeTAttribute.h:22:18: style: The function 'writeOut' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/xml/Attribute.h:26:18: note: Virtual function in base class xournalpp-1.1.1/src/control/xml/SizeTAttribute.h:22:18: note: Function in derived class xournalpp-1.1.1/src/control/xml/TextAttribute.h:22:18: style: The function 'writeOut' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/xml/Attribute.h:26:18: note: Virtual function in base class xournalpp-1.1.1/src/control/xml/TextAttribute.h:22:18: note: Function in derived class xournalpp-1.1.1/src/control/xml/XmlNode.h:22:5: style: Class 'XmlNode' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/xml/XmlAudioNode.h:19:5: style: Class 'XmlAudioNode' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/xml/XmlImageNode.h:18:5: style: Class 'XmlImageNode' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/xml/XmlImageNode.h:26:18: style: The function 'writeOut' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/xml/XmlNode.h:43:18: note: Virtual function in base class xournalpp-1.1.1/src/control/xml/XmlImageNode.h:26:18: note: Function in derived class xournalpp-1.1.1/src/control/xml/XmlNode.cpp:64:61: style:inconclusive: Function 'writeOut' argument 2 names different: declaration '_listener' definition 'listener'. [funcArgNamesDifferent] xournalpp-1.1.1/src/control/xml/XmlNode.h:41:56: note: Function 'writeOut' argument 2 names different: declaration '_listener' definition 'listener'. xournalpp-1.1.1/src/control/xml/XmlNode.cpp:64:61: note: Function 'writeOut' argument 2 names different: declaration '_listener' definition 'listener'. xournalpp-1.1.1/src/control/xml/XmlPointNode.h:20:5: style: Class 'XmlPointNode' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/xml/XmlPointNode.h:29:18: style: The function 'writeOut' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/xml/XmlNode.h:43:18: note: Virtual function in base class xournalpp-1.1.1/src/control/xml/XmlPointNode.h:29:18: note: Function in derived class xournalpp-1.1.1/src/control/xml/XmlStrokeNode.h:20:5: style: Class 'XmlStrokeNode' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/control/xml/XmlStrokeNode.h:26:18: style: The function 'writeOut' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/xml/XmlNode.h:43:18: note: Virtual function in base class xournalpp-1.1.1/src/control/xml/XmlStrokeNode.h:26:18: note: Function in derived class xournalpp-1.1.1/src/control/xml/XmlTexNode.h:22:18: style: The function 'writeOut' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/control/xml/XmlNode.h:43:18: note: Virtual function in base class xournalpp-1.1.1/src/control/xml/XmlTexNode.h:22:18: note: Function in derived class xournalpp-1.1.1/src/control/xojfile/LoadHandler.h:51:17: style:inconclusive: Technically the member function 'LoadHandler::getLastError' can be const. [functionConst] xournalpp-1.1.1/src/control/xojfile/LoadHandler.cpp:89:19: note: Technically the member function 'LoadHandler::getLastError' can be const. xournalpp-1.1.1/src/control/xojfile/LoadHandler.h:51:17: note: Technically the member function 'LoadHandler::getLastError' can be const. xournalpp-1.1.1/src/control/xojfile/LoadHandler.h:53:17: style:inconclusive: Technically the member function 'LoadHandler::getMissingPdfFilename' can be const. [functionConst] xournalpp-1.1.1/src/control/xojfile/LoadHandler.cpp:93:19: note: Technically the member function 'LoadHandler::getMissingPdfFilename' can be const. xournalpp-1.1.1/src/control/xojfile/LoadHandler.h:53:17: note: Technically the member function 'LoadHandler::getMissingPdfFilename' can be const. xournalpp-1.1.1/src/control/xojfile/LoadHandler.cpp:687:42: warning: Logical disjunction always evaluates to true: EXPR != 7 || EXPR != 8. [incorrectLogicOperator] xournalpp-1.1.1/src/control/xojfile/LoadHandler.cpp:357:13: warning: Either the condition 'error==nullptr' is redundant or there is possible null pointer dereference: error. [nullPointerRedundantCheck] xournalpp-1.1.1/src/control/xojfile/LoadHandler.cpp:357:13: note: Assuming that condition 'error==nullptr' is not redundant xournalpp-1.1.1/src/control/xojfile/LoadHandler.cpp:357:13: note: Null pointer dereference xournalpp-1.1.1/src/control/xojfile/LoadHandler.cpp:381:13: warning: Either the condition 'error==nullptr' is redundant or there is possible null pointer dereference: error. [nullPointerRedundantCheck] xournalpp-1.1.1/src/control/xojfile/LoadHandler.cpp:381:13: note: Assuming that condition 'error==nullptr' is not redundant xournalpp-1.1.1/src/control/xojfile/LoadHandler.cpp:381:13: note: Null pointer dereference xournalpp-1.1.1/src/control/xojfile/LoadHandler.cpp:407:10: style: The scope of the variable 'attachToDocument' can be reduced. [variableScope] xournalpp-1.1.1/src/control/xojfile/LoadHandler.cpp:267:21: style: Local variable 'creator' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/control/xojfile/LoadHandler.h:121:17: note: Shadowed declaration xournalpp-1.1.1/src/control/xojfile/LoadHandler.cpp:267:21: note: Shadow variable xournalpp-1.1.1/src/control/xojfile/LoadHandler.cpp:338:20: style: Local variable 'filepath' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/control/xojfile/LoadHandler.h:115:14: note: Shadowed declaration xournalpp-1.1.1/src/control/xojfile/LoadHandler.cpp:338:20: note: Shadow variable xournalpp-1.1.1/src/control/xojfile/LoadHandler.cpp:352:17: style: Local variable 'error' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/control/xojfile/LoadHandler.h:145:13: note: Shadowed declaration xournalpp-1.1.1/src/control/xojfile/LoadHandler.cpp:352:17: note: Shadow variable xournalpp-1.1.1/src/control/xojfile/LoadHandler.cpp:374:17: style: Local variable 'error' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/control/xojfile/LoadHandler.h:145:13: note: Shadowed declaration xournalpp-1.1.1/src/control/xojfile/LoadHandler.cpp:374:17: note: Shadow variable xournalpp-1.1.1/src/control/xojfile/SaveHandler.h:38:17: style:inconclusive: Technically the member function 'SaveHandler::getErrorMessage' can be const. [functionConst] xournalpp-1.1.1/src/control/xojfile/SaveHandler.cpp:350:19: note: Technically the member function 'SaveHandler::getErrorMessage' can be const. xournalpp-1.1.1/src/control/xojfile/SaveHandler.h:38:17: note: Technically the member function 'SaveHandler::getErrorMessage' can be const. xournalpp-1.1.1/src/control/zoom/ZoomControl.cpp:81:64: style:inconclusive: Function 'withZoomStep' argument 2 names different: declaration 'stepSize' definition 'zoomStep'. [funcArgNamesDifferent] xournalpp-1.1.1/src/control/zoom/ZoomControl.h:185:57: note: Function 'withZoomStep' argument 2 names different: declaration 'stepSize' definition 'zoomStep'. xournalpp-1.1.1/src/control/zoom/ZoomControl.cpp:81:64: note: Function 'withZoomStep' argument 2 names different: declaration 'stepSize' definition 'zoomStep'. xournalpp-1.1.1/src/control/zoom/ZoomControl.cpp:205:49: style:inconclusive: Function 'addZoomListener' argument 1 names different: declaration 'listener' definition 'l'. [funcArgNamesDifferent] xournalpp-1.1.1/src/control/zoom/ZoomControl.h:122:40: note: Function 'addZoomListener' argument 1 names different: declaration 'listener' definition 'l'. xournalpp-1.1.1/src/control/zoom/ZoomControl.cpp:205:49: note: Function 'addZoomListener' argument 1 names different: declaration 'listener' definition 'l'. xournalpp-1.1.1/src/control/zoom/ZoomControl.cpp:62:42: style: Parameter 'widget' can be declared as pointer to const [constParameter] xournalpp-1.1.1/src/gui/MainWindow.h:46:18: style: The function 'show' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/GladeGui.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/gui/MainWindow.h:46:18: note: Function in derived class xournalpp-1.1.1/src/gui/GladeSearchpath.h:30:14: style:inconclusive: Technically the member function 'GladeSearchpath::findFile' can be const. [functionConst] xournalpp-1.1.1/src/gui/GladeSearchpath.cpp:18:23: note: Technically the member function 'GladeSearchpath::findFile' can be const. xournalpp-1.1.1/src/gui/GladeSearchpath.h:30:14: note: Technically the member function 'GladeSearchpath::findFile' can be const. xournalpp-1.1.1/src/gui/MainWindowToolbarMenu.h:28:5: style: Class 'MainWindowToolbarMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/gui/MainWindowToolbarMenu.cpp:73:73: style:inconclusive: Function 'tbSelectMenuitemActivated' argument 1 names different: declaration 'menuitem' definition 'checkmenuitem'. [funcArgNamesDifferent] xournalpp-1.1.1/src/gui/MainWindowToolbarMenu.h:43:61: note: Function 'tbSelectMenuitemActivated' argument 1 names different: declaration 'menuitem' definition 'checkmenuitem'. xournalpp-1.1.1/src/gui/MainWindowToolbarMenu.cpp:73:73: note: Function 'tbSelectMenuitemActivated' argument 1 names different: declaration 'menuitem' definition 'checkmenuitem'. xournalpp-1.1.1/src/gui/MainWindow.cpp:364:29: style: Array index 'i' is used before limits check. [arrayIndexThenCheck] xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarItem.h:20:5: style: Class 'ToolbarItem' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarData.h:24:5: style: Class 'ToolbarData' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:22:18: style: The function 'selected' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractItem.h:33:18: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:22:18: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:42:18: style: The function 'enable' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractItem.h:51:18: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:42:18: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/ColorToolItem.h:31:18: style: The function 'actionSelected' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractItem.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/ColorToolItem.h:31:18: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/ColorToolItem.h:33:18: style: The function 'activated' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractItem.h:36:18: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/ColorToolItem.h:33:18: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/ColorToolItem.h:35:25: style: The function 'getToolDisplayName' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:32:25: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/ColorToolItem.h:35:25: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/ColorToolItem.h:36:24: style: The function 'getNewToolIcon' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:37:24: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/ColorToolItem.h:36:24: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/ColorToolItem.h:38:25: style: The function 'getId' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractItem.h:38:25: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/ColorToolItem.h:38:25: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/ColorToolItem.h:45:18: style: The function 'enable' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:42:18: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/ColorToolItem.h:45:18: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/ColorToolItem.h:48:26: style: The function 'newItem' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:45:26: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/ColorToolItem.h:48:26: note: Function in derived class xournalpp-1.1.1/src/gui/MainWindow.cpp:185:27: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/gui/PageViewFindObjectHelper.h:77:5: style: Class 'SelectObject' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/gui/PageViewFindObjectHelper.h:127:5: style: Class 'PlayObject' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/gui/RepaintHandler.h:23:5: style: Class 'RepaintHandler' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/gui/XournalppCursor.h:27:5: style: Class 'XournalppCursor' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/gui/PageView.h:46:18: style: The function 'rerenderPage' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/Redrawable.h:52:18: note: Virtual function in base class xournalpp-1.1.1/src/gui/PageView.h:46:18: note: Function in derived class xournalpp-1.1.1/src/gui/PageView.h:47:18: style: The function 'rerenderRect' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/Redrawable.h:63:18: note: Virtual function in base class xournalpp-1.1.1/src/gui/PageView.h:47:18: note: Function in derived class xournalpp-1.1.1/src/gui/PageView.h:49:18: style: The function 'repaintPage' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/Redrawable.h:47:18: note: Virtual function in base class xournalpp-1.1.1/src/gui/PageView.h:49:18: note: Function in derived class xournalpp-1.1.1/src/gui/PageView.h:50:18: style: The function 'repaintArea' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/Redrawable.h:37:18: note: Virtual function in base class xournalpp-1.1.1/src/gui/PageView.h:50:18: note: Function in derived class xournalpp-1.1.1/src/gui/PageView.h:73:10: style: The function 'deleteViewBuffer' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/Redrawable.h:71:18: note: Virtual function in base class xournalpp-1.1.1/src/gui/PageView.h:73:10: note: Function in derived class xournalpp-1.1.1/src/gui/PageView.h:137:9: style: The function 'getX' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/Redrawable.h:73:17: note: Virtual function in base class xournalpp-1.1.1/src/gui/PageView.h:137:9: note: Function in derived class xournalpp-1.1.1/src/gui/PageView.h:143:9: style: The function 'getY' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/Redrawable.h:74:17: note: Virtual function in base class xournalpp-1.1.1/src/gui/PageView.h:143:9: note: Function in derived class xournalpp-1.1.1/src/gui/PageViewFindObjectHelper.h:104:25: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/gui/PageViewFindObjectHelper.h:147:27: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/gui/PageView.cpp:386:20: style: Local variable 'selection' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/gui/PageView.h:200:16: note: Shadowed declaration xournalpp-1.1.1/src/gui/PageView.cpp:386:20: note: Shadow variable xournalpp-1.1.1/src/gui/PageView.cpp:344:23: style: Variable 'status' can be declared as reference to const [constVariable] xournalpp-1.1.1/src/gui/PageView.cpp:906:50: style: Parameter 'rect' can be declared as reference to const [constParameter] xournalpp-1.1.1/src/gui/PageView.cpp:881:47: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/gui/PageView.cpp:895:43: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/gui/SearchBar.h:24:5: style: Class 'SearchBar' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/gui/Shadow.cpp:102:18: style: Variable 'a' is assigned a value that is never used. [unreadVariable] xournalpp-1.1.1/src/gui/Shadow.cpp:132:18: style: Variable 'a' is assigned a value that is never used. [unreadVariable] xournalpp-1.1.1/src/gui/Shadow.cpp:163:18: style: Variable 'a' is assigned a value that is never used. [unreadVariable] xournalpp-1.1.1/src/gui/TextEditorWidget.h:122:20: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/gui/TextEditorWidget.h:123:21: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/gui/TextEditorWidget.h:290:26: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/src/gui/TextEditor.cpp:554:52: style:inconclusive: Function 'findPos' argument 2 names different: declaration 'x' definition 'xPos'. [funcArgNamesDifferent] xournalpp-1.1.1/src/gui/TextEditor.h:85:44: note: Function 'findPos' argument 2 names different: declaration 'x' definition 'xPos'. xournalpp-1.1.1/src/gui/TextEditor.cpp:554:52: note: Function 'findPos' argument 2 names different: declaration 'x' definition 'xPos'. xournalpp-1.1.1/src/gui/TextEditor.cpp:554:65: style:inconclusive: Function 'findPos' argument 3 names different: declaration 'y' definition 'yPos'. [funcArgNamesDifferent] xournalpp-1.1.1/src/gui/TextEditor.h:85:54: note: Function 'findPos' argument 3 names different: declaration 'y' definition 'yPos'. xournalpp-1.1.1/src/gui/TextEditor.cpp:554:65: note: Function 'findPos' argument 3 names different: declaration 'y' definition 'yPos'. xournalpp-1.1.1/src/gui/TextEditor.cpp:952:51: style:inconclusive: Function 'paint' argument 2 names different: declaration 'rect' definition 'repaintRect'. [funcArgNamesDifferent] xournalpp-1.1.1/src/gui/TextEditor.h:31:43: note: Function 'paint' argument 2 names different: declaration 'rect' definition 'repaintRect'. xournalpp-1.1.1/src/gui/TextEditor.cpp:952:51: note: Function 'paint' argument 2 names different: declaration 'rect' definition 'repaintRect'. xournalpp-1.1.1/src/gui/TextEditor.cpp:103:11: style: Local variable 'text' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/gui/TextEditor.h:97:11: note: Shadowed declaration xournalpp-1.1.1/src/gui/TextEditor.cpp:103:11: note: Shadow variable xournalpp-1.1.1/src/gui/TextEditor.cpp:837:11: style: Local variable 'text' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/gui/TextEditor.h:97:11: note: Shadowed declaration xournalpp-1.1.1/src/gui/TextEditor.cpp:837:11: note: Shadow variable xournalpp-1.1.1/src/gui/TextEditor.cpp:915:17: style: Local variable 'text' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/gui/TextEditor.h:97:11: note: Shadowed declaration xournalpp-1.1.1/src/gui/TextEditor.cpp:915:17: note: Shadow variable xournalpp-1.1.1/src/gui/TextEditor.cpp:923:17: style: Local variable 'text' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/gui/TextEditor.h:97:11: note: Shadowed declaration xournalpp-1.1.1/src/gui/TextEditor.cpp:923:17: note: Shadow variable xournalpp-1.1.1/src/gui/TextEditor.cpp:974:16: style: Local variable 'text' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/gui/TextEditor.h:97:11: note: Shadowed declaration xournalpp-1.1.1/src/gui/TextEditor.cpp:974:16: note: Shadow variable xournalpp-1.1.1/src/gui/XournalView.cpp:368:50: style:inconclusive: Function 'scrollTo' argument 2 names different: declaration 'y' definition 'yDocument'. [funcArgNamesDifferent] xournalpp-1.1.1/src/gui/XournalView.h:47:41: note: Function 'scrollTo' argument 2 names different: declaration 'y' definition 'yDocument'. xournalpp-1.1.1/src/gui/XournalView.cpp:368:50: note: Function 'scrollTo' argument 2 names different: declaration 'y' definition 'yDocument'. xournalpp-1.1.1/src/gui/XournalView.cpp:471:12: style: Local variable 'currentPage' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/gui/XournalView.h:166:12: note: Shadowed declaration xournalpp-1.1.1/src/gui/XournalView.cpp:471:12: note: Shadow variable xournalpp-1.1.1/src/gui/XournalView.cpp:521:12: style: Local variable 'currentPage' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/gui/XournalView.h:166:12: note: Shadowed declaration xournalpp-1.1.1/src/gui/XournalView.cpp:521:12: note: Shadow variable xournalpp-1.1.1/src/gui/dialog/AboutDialog.h:18:5: style: Class 'AboutDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/gui/dialog/LatexSettingsPanel.h:21:5: style: Class 'LatexSettingsPanel' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/gui/dialog/ExportDialog.h:22:5: style: Class 'ExportDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/gui/dialog/FormatDialog.cpp:269:22: style: Boolean value assigned to floating point variable. [assignBoolToFloat] xournalpp-1.1.1/src/gui/dialog/FormatDialog.cpp:272:22: style: Boolean value assigned to floating point variable. [assignBoolToFloat] xournalpp-1.1.1/src/gui/dialog/FormatDialog.cpp:71:24: style: The comparison 'selectedFormat == -1' is always true. [knownConditionTrueFalse] xournalpp-1.1.1/src/gui/dialog/FormatDialog.cpp:37:27: note: 'selectedFormat' is assigned value '-1' here. xournalpp-1.1.1/src/gui/dialog/FormatDialog.cpp:71:24: note: The comparison 'selectedFormat == -1' is always true. xournalpp-1.1.1/src/gui/dialog/LatexDialog.h:24:5: style: Class 'LatexDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/gui/dialog/RenameLayerDialog.h:32:22: style:inconclusive: Member variable 'RenameLayerDialog::lc' is in the wrong place in the initializer list. [initializerList] xournalpp-1.1.1/src/gui/dialog/RenameLayerDialog.cpp:15:96: note: Member variable 'RenameLayerDialog::lc' is in the wrong place in the initializer list. xournalpp-1.1.1/src/gui/dialog/RenameLayerDialog.h:32:22: note: Member variable 'RenameLayerDialog::lc' is in the wrong place in the initializer list. xournalpp-1.1.1/src/gui/dialog/ToolbarManageDialog.cpp:154:19: style: Local variable 'model' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/gui/dialog/ToolbarManageDialog.h:45:19: note: Shadowed declaration xournalpp-1.1.1/src/gui/dialog/ToolbarManageDialog.cpp:154:19: note: Shadow variable xournalpp-1.1.1/src/gui/dialog/backgroundSelect/ImageElementView.h:31:18: style: The function 'paintContents' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/dialog/backgroundSelect/BaseElementView.h:56:18: note: Virtual function in base class xournalpp-1.1.1/src/gui/dialog/backgroundSelect/ImageElementView.h:31:18: note: Function in derived class xournalpp-1.1.1/src/gui/dialog/backgroundSelect/ImageElementView.h:36:17: style: The function 'getContentWidth' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/dialog/backgroundSelect/BaseElementView.h:61:17: note: Virtual function in base class xournalpp-1.1.1/src/gui/dialog/backgroundSelect/ImageElementView.h:36:17: note: Function in derived class xournalpp-1.1.1/src/gui/dialog/backgroundSelect/ImageElementView.h:41:17: style: The function 'getContentHeight' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/dialog/backgroundSelect/BaseElementView.h:66:17: note: Virtual function in base class xournalpp-1.1.1/src/gui/dialog/backgroundSelect/ImageElementView.h:41:17: note: Function in derived class xournalpp-1.1.1/src/gui/dialog/backgroundSelect/ImageElementView.h:46:18: style: The function 'calcSize' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/dialog/backgroundSelect/BaseElementView.h:71:18: note: Virtual function in base class xournalpp-1.1.1/src/gui/dialog/backgroundSelect/ImageElementView.h:46:18: note: Function in derived class xournalpp-1.1.1/src/gui/dialog/backgroundSelect/ImagesDialog.h:32:18: style: The function 'show' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/dialog/backgroundSelect/BackgroundSelectDialogBase.h:32:18: note: Virtual function in base class xournalpp-1.1.1/src/gui/dialog/backgroundSelect/ImagesDialog.h:32:18: note: Function in derived class xournalpp-1.1.1/src/gui/dialog/backgroundSelect/PdfElementView.h:33:18: style: The function 'paintContents' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/dialog/backgroundSelect/BaseElementView.h:56:18: note: Virtual function in base class xournalpp-1.1.1/src/gui/dialog/backgroundSelect/PdfElementView.h:33:18: note: Function in derived class xournalpp-1.1.1/src/gui/dialog/backgroundSelect/PdfElementView.h:38:17: style: The function 'getContentWidth' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/dialog/backgroundSelect/BaseElementView.h:61:17: note: Virtual function in base class xournalpp-1.1.1/src/gui/dialog/backgroundSelect/PdfElementView.h:38:17: note: Function in derived class xournalpp-1.1.1/src/gui/dialog/backgroundSelect/PdfElementView.h:43:17: style: The function 'getContentHeight' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/dialog/backgroundSelect/BaseElementView.h:66:17: note: Virtual function in base class xournalpp-1.1.1/src/gui/dialog/backgroundSelect/PdfElementView.h:43:17: note: Function in derived class xournalpp-1.1.1/src/gui/dialog/backgroundSelect/PdfPagesDialog.h:27:18: style: The function 'show' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/dialog/backgroundSelect/BackgroundSelectDialogBase.h:32:18: note: Virtual function in base class xournalpp-1.1.1/src/gui/dialog/backgroundSelect/PdfPagesDialog.h:27:18: note: Function in derived class xournalpp-1.1.1/src/gui/dialog/SettingsDialog.cpp:263:55: style:inconclusive: Function 'enableWithCheckbox' argument 1 names different: declaration 'checkbox' definition 'checkboxId'. [funcArgNamesDifferent] xournalpp-1.1.1/src/gui/dialog/SettingsDialog.h:40:48: note: Function 'enableWithCheckbox' argument 1 names different: declaration 'checkbox' definition 'checkboxId'. xournalpp-1.1.1/src/gui/dialog/SettingsDialog.cpp:263:55: note: Function 'enableWithCheckbox' argument 1 names different: declaration 'checkbox' definition 'checkboxId'. xournalpp-1.1.1/src/gui/dialog/SettingsDialog.cpp:263:81: style:inconclusive: Function 'enableWithCheckbox' argument 2 names different: declaration 'widget' definition 'widgetId'. [funcArgNamesDifferent] xournalpp-1.1.1/src/gui/dialog/SettingsDialog.h:40:77: note: Function 'enableWithCheckbox' argument 2 names different: declaration 'widget' definition 'widgetId'. xournalpp-1.1.1/src/gui/dialog/SettingsDialog.cpp:263:81: note: Function 'enableWithCheckbox' argument 2 names different: declaration 'widget' definition 'widgetId'. xournalpp-1.1.1/src/gui/dialog/SettingsDialog.cpp:269:56: style:inconclusive: Function 'disableWithCheckbox' argument 1 names different: declaration 'checkbox' definition 'checkboxId'. [funcArgNamesDifferent] xournalpp-1.1.1/src/gui/dialog/SettingsDialog.h:41:49: note: Function 'disableWithCheckbox' argument 1 names different: declaration 'checkbox' definition 'checkboxId'. xournalpp-1.1.1/src/gui/dialog/SettingsDialog.cpp:269:56: note: Function 'disableWithCheckbox' argument 1 names different: declaration 'checkbox' definition 'checkboxId'. xournalpp-1.1.1/src/gui/dialog/SettingsDialog.cpp:269:82: style:inconclusive: Function 'disableWithCheckbox' argument 2 names different: declaration 'widget' definition 'widgetId'. [funcArgNamesDifferent] xournalpp-1.1.1/src/gui/dialog/SettingsDialog.h:41:78: note: Function 'disableWithCheckbox' argument 2 names different: declaration 'widget' definition 'widgetId'. xournalpp-1.1.1/src/gui/dialog/SettingsDialog.cpp:269:82: note: Function 'disableWithCheckbox' argument 2 names different: declaration 'widget' definition 'widgetId'. xournalpp-1.1.1/src/gui/dialog/toolbarCustomize/ToolItemDragCurrentData.cpp:40:61: style: Parameter 'd' can be declared as pointer to const [constParameter] xournalpp-1.1.1/src/gui/dialog/toolbarCustomize/ToolbarAdapter.cpp:103:20: style: Local variable 'window' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/gui/dialog/toolbarCustomize/ToolbarAdapter.h:71:17: note: Shadowed declaration xournalpp-1.1.1/src/gui/dialog/toolbarCustomize/ToolbarAdapter.cpp:103:20: note: Shadow variable xournalpp-1.1.1/src/gui/dialog/toolbarCustomize/ToolbarDragDropHandler.h:33:10: style:inconclusive: Technically the member function 'ToolbarDragDropHandler::isInDragAndDrop' can be const. [functionConst] xournalpp-1.1.1/src/gui/dialog/toolbarCustomize/ToolbarDragDropHandler.cpp:71:30: note: Technically the member function 'ToolbarDragDropHandler::isInDragAndDrop' can be const. xournalpp-1.1.1/src/gui/dialog/toolbarCustomize/ToolbarDragDropHandler.h:33:10: note: Technically the member function 'ToolbarDragDropHandler::isInDragAndDrop' can be const. xournalpp-1.1.1/src/gui/dialog/toolbarCustomize/ToolbarDragDropHandler.h:25:5: style: Class 'ToolbarDragDropHandler' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/gui/dialog/toolbarCustomize/ToolbarDragDropHelper.cpp:8:70: style:inconclusive: Function 'gdk_context_set_icon_from_image' argument 2 names different: declaration 'image' definition 'widget'. [funcArgNamesDifferent] xournalpp-1.1.1/src/gui/dialog/toolbarCustomize/ToolbarDragDropHelper.h:20:70: note: Function 'gdk_context_set_icon_from_image' argument 2 names different: declaration 'image' definition 'widget'. xournalpp-1.1.1/src/gui/dialog/toolbarCustomize/ToolbarDragDropHelper.cpp:8:70: note: Function 'gdk_context_set_icon_from_image' argument 2 names different: declaration 'image' definition 'widget'. xournalpp-1.1.1/src/gui/inputdevices/InputContext.h:85:10: performance:inconclusive: Technically the member function 'InputContext::printDebug' can be static (but you may consider moving to unnamed namespace). [functionStatic] xournalpp-1.1.1/src/gui/inputdevices/InputContext.cpp:208:20: note: Technically the member function 'InputContext::printDebug' can be static (but you may consider moving to unnamed namespace). xournalpp-1.1.1/src/gui/inputdevices/InputContext.h:85:10: note: Technically the member function 'InputContext::printDebug' can be static (but you may consider moving to unnamed namespace). xournalpp-1.1.1/src/gui/inputdevices/InputContext.h:99:21: style:inconclusive: Technically the member function 'InputContext::getModifierState' can be const. [functionConst] xournalpp-1.1.1/src/gui/inputdevices/InputContext.cpp:155:20: note: Technically the member function 'InputContext::getModifierState' can be const. xournalpp-1.1.1/src/gui/inputdevices/InputContext.h:99:21: note: Technically the member function 'InputContext::getModifierState' can be const. xournalpp-1.1.1/src/gui/inputdevices/InputContext.h:103:10: style:inconclusive: Technically the member function 'InputContext::isBlocked' can be const. [functionConst] xournalpp-1.1.1/src/gui/inputdevices/InputContext.cpp:196:20: note: Technically the member function 'InputContext::isBlocked' can be const. xournalpp-1.1.1/src/gui/inputdevices/InputContext.h:103:10: note: Technically the member function 'InputContext::isBlocked' can be const. xournalpp-1.1.1/src/gui/inputdevices/InputContext.cpp:15:11: warning: Class 'InputContext' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] xournalpp-1.1.1/src/gui/inputdevices/InputContext.cpp:15:11: warning: Class 'InputContext' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] xournalpp-1.1.1/src/gui/inputdevices/InputContext.cpp:43:39: style:inconclusive: Function 'connect' argument 1 names different: declaration 'widget' definition 'pWidget'. [funcArgNamesDifferent] xournalpp-1.1.1/src/gui/inputdevices/InputContext.h:91:29: note: Function 'connect' argument 1 names different: declaration 'widget' definition 'pWidget'. xournalpp-1.1.1/src/gui/inputdevices/InputContext.cpp:43:39: note: Function 'connect' argument 1 names different: declaration 'widget' definition 'pWidget'. xournalpp-1.1.1/src/gui/inputdevices/InputContext.cpp:68:37: style:inconclusive: Function 'handle' argument 1 names different: declaration 'event' definition 'sourceEvent'. [funcArgNamesDifferent] xournalpp-1.1.1/src/gui/inputdevices/InputContext.h:80:27: note: Function 'handle' argument 1 names different: declaration 'event' definition 'sourceEvent'. xournalpp-1.1.1/src/gui/inputdevices/InputContext.cpp:68:37: note: Function 'handle' argument 1 names different: declaration 'event' definition 'sourceEvent'. xournalpp-1.1.1/src/gui/inputdevices/touchdisable/TouchDisableCustom.h:26:18: style: The function 'enableTouch' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/inputdevices/touchdisable/TouchDisableInterface.h:24:18: note: Virtual function in base class xournalpp-1.1.1/src/gui/inputdevices/touchdisable/TouchDisableCustom.h:26:18: note: Function in derived class xournalpp-1.1.1/src/gui/inputdevices/touchdisable/TouchDisableCustom.h:27:18: style: The function 'disableTouch' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/inputdevices/touchdisable/TouchDisableInterface.h:25:18: note: Virtual function in base class xournalpp-1.1.1/src/gui/inputdevices/touchdisable/TouchDisableCustom.h:27:18: note: Function in derived class xournalpp-1.1.1/src/gui/scroll/ScrollHandling.h:25:5: style: Class 'ScrollHandling' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/gui/sidebar/Sidebar.h:87:14: style:inconclusive: Member variable 'Sidebar::control' is in the wrong place in the initializer list. [initializerList] xournalpp-1.1.1/src/gui/sidebar/Sidebar.cpp:14:72: note: Member variable 'Sidebar::control' is in the wrong place in the initializer list. xournalpp-1.1.1/src/gui/sidebar/Sidebar.h:87:14: note: Member variable 'Sidebar::control' is in the wrong place in the initializer list. xournalpp-1.1.1/src/gui/sidebar/previews/base/SidebarPreviewBaseEntry.h:58:18: style: Virtual function 'updateSize' is called from constructor 'SidebarPreviewBaseEntry(SidebarPreviewBase*sidebar,const PageRef&page)' at line 16. Dynamic binding is not used. [virtualCallInConstructor] xournalpp-1.1.1/src/gui/sidebar/previews/base/SidebarPreviewBaseEntry.cpp:16:5: note: Calling updateSize xournalpp-1.1.1/src/gui/sidebar/previews/base/SidebarPreviewBaseEntry.h:58:18: note: updateSize is a virtual function xournalpp-1.1.1/src/gui/sidebar/previews/layer/SidebarPreviewLayerEntry.h:69:16: style:inconclusive: Member variable 'SidebarPreviewLayerEntry::box' is in the wrong place in the initializer list. [initializerList] xournalpp-1.1.1/src/gui/sidebar/previews/layer/SidebarPreviewLayerEntry.cpp:15:9: note: Member variable 'SidebarPreviewLayerEntry::box' is in the wrong place in the initializer list. xournalpp-1.1.1/src/gui/sidebar/previews/layer/SidebarPreviewLayerEntry.h:69:16: note: Member variable 'SidebarPreviewLayerEntry::box' is in the wrong place in the initializer list. xournalpp-1.1.1/src/gui/sidebar/previews/layer/SidebarPreviewLayerEntry.h:26:17: style: The function 'getHeight' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/sidebar/previews/base/SidebarPreviewBaseEntry.h:53:17: note: Virtual function in base class xournalpp-1.1.1/src/gui/sidebar/previews/layer/SidebarPreviewLayerEntry.h:26:17: note: Function in derived class xournalpp-1.1.1/src/gui/sidebar/previews/layer/SidebarPreviewLayerEntry.h:32:31: style: The function 'getRenderType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/sidebar/previews/base/SidebarPreviewBaseEntry.h:63:31: note: Virtual function in base class xournalpp-1.1.1/src/gui/sidebar/previews/layer/SidebarPreviewLayerEntry.h:32:31: note: Function in derived class xournalpp-1.1.1/src/gui/sidebar/previews/layer/SidebarPreviewLayerEntry.h:39:24: style: The function 'getWidget' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/sidebar/previews/base/SidebarPreviewBaseEntry.h:51:24: note: Virtual function in base class xournalpp-1.1.1/src/gui/sidebar/previews/layer/SidebarPreviewLayerEntry.h:39:24: note: Function in derived class xournalpp-1.1.1/src/gui/sidebar/previews/layer/SidebarPreviewLayerEntry.h:47:18: style: The function 'mouseButtonPressCallback' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/sidebar/previews/base/SidebarPreviewBaseEntry.h:69:18: note: Virtual function in base class xournalpp-1.1.1/src/gui/sidebar/previews/layer/SidebarPreviewLayerEntry.h:47:18: note: Function in derived class xournalpp-1.1.1/src/gui/sidebar/previews/page/SidebarPreviewPageEntry.h:35:26: warning: The class 'SidebarPreviewPageEntry' defines member variable with name 'sidebar' also defined in its parent class 'SidebarPreviewBaseEntry'. [duplInheritedMember] xournalpp-1.1.1/src/gui/sidebar/previews/base/SidebarPreviewBaseEntry.h:87:25: note: Parent variable 'SidebarPreviewBaseEntry::sidebar' xournalpp-1.1.1/src/gui/sidebar/previews/page/SidebarPreviewPageEntry.h:35:26: note: Derived variable 'SidebarPreviewPageEntry::sidebar' xournalpp-1.1.1/src/gui/sidebar/previews/page/SidebarPreviewPageEntry.h:32:31: style: The function 'getRenderType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/sidebar/previews/base/SidebarPreviewBaseEntry.h:63:31: note: Virtual function in base class xournalpp-1.1.1/src/gui/sidebar/previews/page/SidebarPreviewPageEntry.h:32:31: note: Function in derived class xournalpp-1.1.1/src/gui/sidebar/previews/page/SidebarPreviewPageEntry.h:36:18: style: The function 'mouseButtonPressCallback' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/sidebar/previews/base/SidebarPreviewBaseEntry.h:69:18: note: Virtual function in base class xournalpp-1.1.1/src/gui/sidebar/previews/page/SidebarPreviewPageEntry.h:36:18: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractItem.cpp:81:10: style: Local variable 'selected' shadows outer function [shadowFunction] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractItem.h:33:18: note: Shadowed declaration xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractItem.cpp:81:10: note: Shadow variable xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.cpp:34:14: style: Local variable 'selected' shadows outer function [shadowFunction] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:22:18: note: Shadowed declaration xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.cpp:34:14: note: Shadow variable xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.cpp:69:18: style: Local variable 'item' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:49:18: note: Shadowed declaration xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.cpp:69:18: note: Shadow variable xournalpp-1.1.1/src/gui/toolbarMenubar/ColorToolItem.h:78:16: style:inconclusive: Member variable 'ColorToolItem::parent' is in the wrong place in the initializer list. [initializerList] xournalpp-1.1.1/src/gui/toolbarMenubar/ColorToolItem.cpp:22:9: note: Member variable 'ColorToolItem::parent' is in the wrong place in the initializer list. xournalpp-1.1.1/src/gui/toolbarMenubar/ColorToolItem.h:78:16: note: Member variable 'ColorToolItem::parent' is in the wrong place in the initializer list. xournalpp-1.1.1/src/gui/toolbarMenubar/ColorToolItem.cpp:99:17: style: Local variable 'color' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/gui/toolbarMenubar/ColorToolItem.h:66:11: note: Shadowed declaration xournalpp-1.1.1/src/gui/toolbarMenubar/ColorToolItem.cpp:99:17: note: Shadow variable xournalpp-1.1.1/src/gui/toolbarMenubar/ColorToolItem.cpp:152:18: style: Local variable 'name' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/gui/toolbarMenubar/ColorToolItem.h:71:17: note: Shadowed declaration xournalpp-1.1.1/src/gui/toolbarMenubar/ColorToolItem.cpp:152:18: note: Shadow variable xournalpp-1.1.1/src/gui/toolbarMenubar/FontButton.h:30:18: style: The function 'activated' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractItem.h:36:18: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/FontButton.h:30:18: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/FontButton.h:33:25: style: The function 'getToolDisplayName' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:32:25: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/FontButton.h:33:25: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/FontButton.h:37:26: style: The function 'createItem' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:23:26: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/FontButton.h:37:26: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/FontButton.h:38:26: style: The function 'createTmpItem' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:24:26: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/FontButton.h:38:26: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/FontButton.h:39:26: style: The function 'newItem' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:45:26: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/FontButton.h:39:26: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/FontButton.h:44:24: style: The function 'getNewToolIcon' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:37:24: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/FontButton.h:44:24: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolButton.h:38:25: style: The function 'getToolDisplayName' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:32:25: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolButton.h:38:25: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolButton.h:42:26: style: The function 'newItem' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:45:26: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolButton.h:42:26: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolButton.h:44:24: style: The function 'getNewToolIcon' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:37:24: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolButton.h:44:24: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolDrawCombocontrol.h:31:18: style: The function 'selected' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:22:18: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolDrawCombocontrol.h:31:18: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolDrawCombocontrol.h:34:26: style: The function 'newItem' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/ToolButton.h:42:26: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolDrawCombocontrol.h:34:26: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolDrawCombocontrol.cpp:83:59: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/gui/toolbarMenubar/ToolPageLayer.h:32:25: style: The function 'getToolDisplayName' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:32:25: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolPageLayer.h:32:25: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolPageLayer.h:58:26: style: The function 'newItem' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:45:26: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolPageLayer.h:58:26: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolPageLayer.h:59:24: style: The function 'getNewToolIcon' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:37:24: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolPageLayer.h:59:24: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolPageLayer.cpp:95:16: style: Variable 'kv' can be declared as reference to const [constVariable] xournalpp-1.1.1/src/gui/toolbarMenubar/ToolPageLayer.cpp:129:16: style: Variable 'kv' can be declared as reference to const [constVariable] xournalpp-1.1.1/src/gui/toolbarMenubar/ToolPageLayer.cpp:96:32: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/gui/toolbarMenubar/ToolPageLayer.cpp:130:32: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/gui/toolbarMenubar/ToolPageSpinner.cpp:27:48: style:inconclusive: Function 'setPageInfo' argument 1 names different: declaration 'pagecount' definition 'pageCount'. [funcArgNamesDifferent] xournalpp-1.1.1/src/gui/toolbarMenubar/ToolPageSpinner.h:33:29: note: Function 'setPageInfo' argument 1 names different: declaration 'pagecount' definition 'pageCount'. xournalpp-1.1.1/src/gui/toolbarMenubar/ToolPageSpinner.cpp:27:48: note: Function 'setPageInfo' argument 1 names different: declaration 'pagecount' definition 'pageCount'. xournalpp-1.1.1/src/gui/toolbarMenubar/ToolPageSpinner.cpp:27:72: style:inconclusive: Function 'setPageInfo' argument 2 names different: declaration 'pdfpage' definition 'pdfPage'. [funcArgNamesDifferent] xournalpp-1.1.1/src/gui/toolbarMenubar/ToolPageSpinner.h:33:47: note: Function 'setPageInfo' argument 2 names different: declaration 'pdfpage' definition 'pdfPage'. xournalpp-1.1.1/src/gui/toolbarMenubar/ToolPageSpinner.cpp:27:72: note: Function 'setPageInfo' argument 2 names different: declaration 'pdfpage' definition 'pdfPage'. xournalpp-1.1.1/src/gui/toolbarMenubar/ToolSelectCombocontrol.h:30:18: style: The function 'selected' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:22:18: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolSelectCombocontrol.h:30:18: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolSelectCombocontrol.h:33:26: style: The function 'newItem' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/ToolButton.h:42:26: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolSelectCombocontrol.h:33:26: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolMenuHandler.cpp:37:11: warning: Class 'ToolMenuHandler' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] xournalpp-1.1.1/src/gui/toolbarMenubar/ToolMenuHandler.cpp:37:11: warning: Class 'ToolMenuHandler' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] xournalpp-1.1.1/src/gui/toolbarMenubar/ToolZoomSlider.h:42:25: style: The function 'getToolDisplayName' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:32:25: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolZoomSlider.h:42:25: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolZoomSlider.h:46:26: style: The function 'createItem' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:23:26: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolZoomSlider.h:46:26: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolZoomSlider.h:47:26: style: The function 'createTmpItem' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:24:26: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolZoomSlider.h:47:26: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolZoomSlider.h:50:18: style: The function 'enable' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:42:18: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolZoomSlider.h:50:18: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolZoomSlider.h:51:26: style: The function 'newItem' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:45:26: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolZoomSlider.h:51:26: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolZoomSlider.h:52:24: style: The function 'getNewToolIcon' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/gui/toolbarMenubar/AbstractToolItem.h:37:24: note: Virtual function in base class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolZoomSlider.h:52:24: note: Function in derived class xournalpp-1.1.1/src/gui/toolbarMenubar/ToolMenuHandler.cpp:303:41: performance: Function parameter 'name' should be passed by const reference. [passedByValue] xournalpp-1.1.1/src/gui/toolbarMenubar/ToolMenuHandler.cpp:303:78: performance: Function parameter 'stockIcon' should be passed by const reference. [passedByValue] xournalpp-1.1.1/src/gui/toolbarMenubar/ToolMenuHandler.cpp:303:101: performance: Function parameter 'text' should be passed by const reference. [passedByValue] xournalpp-1.1.1/src/gui/toolbarMenubar/ToolMenuHandler.cpp:308:42: performance: Function parameter 'name' should be passed by const reference. [passedByValue] xournalpp-1.1.1/src/gui/toolbarMenubar/ToolMenuHandler.cpp:308:97: performance: Function parameter 'text' should be passed by const reference. [passedByValue] xournalpp-1.1.1/src/gui/toolbarMenubar/ToolMenuHandler.cpp:314:45: performance: Function parameter 'name' should be passed by const reference. [passedByValue] xournalpp-1.1.1/src/gui/toolbarMenubar/ToolMenuHandler.cpp:315:63: performance: Function parameter 'text' should be passed by const reference. [passedByValue] xournalpp-1.1.1/src/gui/toolbarMenubar/ToolMenuHandler.cpp:321:44: performance: Function parameter 'name' should be passed by const reference. [passedByValue] xournalpp-1.1.1/src/gui/toolbarMenubar/ToolMenuHandler.cpp:322:44: performance: Function parameter 'stockIcon' should be passed by const reference. [passedByValue] xournalpp-1.1.1/src/gui/toolbarMenubar/ToolMenuHandler.cpp:322:67: performance: Function parameter 'text' should be passed by const reference. [passedByValue] xournalpp-1.1.1/src/gui/toolbarMenubar/ToolMenuHandler.cpp:162:48: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/gui/toolbarMenubar/ToolMenuHandler.cpp:286:48: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/gui/toolbarMenubar/ToolMenuHandler.cpp:525:38: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarColorNames.cpp:41:47: style:inconclusive: Function 'ToolbarColorNames' argument 1 names different: declaration 'path' definition 'readFile'. [funcArgNamesDifferent] xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarColorNames.h:23:41: note: Function 'ToolbarColorNames' argument 1 names different: declaration 'path' definition 'readFile'. xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarColorNames.cpp:41:47: note: Function 'ToolbarColorNames' argument 1 names different: declaration 'path' definition 'readFile'. xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarData.h:31:17: style:inconclusive: Technically the member function 'ToolbarData::getName' can be const. [functionConst] xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarData.cpp:37:19: note: Technically the member function 'ToolbarData::getName' can be const. xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarData.h:31:17: note: Technically the member function 'ToolbarData::getName' can be const. xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarData.h:33:17: style:inconclusive: Technically the member function 'ToolbarData::getId' can be const. [functionConst] xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarData.cpp:41:19: note: Technically the member function 'ToolbarData::getId' can be const. xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarData.h:33:17: note: Technically the member function 'ToolbarData::getId' can be const. xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarData.cpp:54:12: style: Local variable 'name' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarData.h:46:17: note: Shadowed declaration xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarData.cpp:54:12: note: Shadow variable xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarData.cpp:119:9: style: Local variable 'id' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarData.h:45:17: note: Shadowed declaration xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarData.cpp:119:9: note: Shadow variable xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarData.cpp:110:17: style: Local variable 'id' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarData.h:45:17: note: Shadowed declaration xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarData.cpp:110:17: note: Shadow variable xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarData.cpp:26:18: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarData.cpp:107:38: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarData.cpp:129:38: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarItem.h:26:10: style:inconclusive: Technically the member function 'ToolbarItem::operator==' can be const. [functionConst] xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarItem.cpp:23:19: note: Technically the member function 'ToolbarItem::operator==' can be const. xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarItem.h:26:10: note: Technically the member function 'ToolbarItem::operator==' can be const. xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarItem.cpp:23:43: style: Parameter 'other' can be declared as reference to const [constParameter] xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarEntry.h:31:17: style:inconclusive: Technically the member function 'ToolbarEntry::getName' can be const. [functionConst] xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarEntry.cpp:37:20: note: Technically the member function 'ToolbarEntry::getName' can be const. xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarEntry.h:31:17: note: Technically the member function 'ToolbarEntry::getName' can be const. xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarEntry.cpp:15:31: style: Local variable 'entries' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarEntry.h:49:23: note: Shadowed declaration xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarEntry.cpp:15:31: note: Shadow variable xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarEntry.cpp:17:17: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarModel.cpp:34:40: style: Parameter 'data' can be declared as pointer to const [constParameter] xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarModel.cpp:94:34: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/gui/widgets/SpinPageAdapter.h:30:10: style:inconclusive: Technically the member function 'SpinPageAdapter::hasWidget' can be const. [functionConst] xournalpp-1.1.1/src/gui/widgets/SpinPageAdapter.cpp:33:23: note: Technically the member function 'SpinPageAdapter::hasWidget' can be const. xournalpp-1.1.1/src/gui/widgets/SpinPageAdapter.h:30:10: note: Technically the member function 'SpinPageAdapter::hasWidget' can be const. xournalpp-1.1.1/src/gui/widgets/SpinPageAdapter.cpp:80:28: style: Local variable 'listener' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/gui/widgets/SpinPageAdapter.h:57:34: note: Shadowed declaration xournalpp-1.1.1/src/gui/widgets/SpinPageAdapter.cpp:80:28: note: Shadow variable xournalpp-1.1.1/src/gui/widgets/gtkmenutooltogglebutton.cpp:405:55: style: Parameter 'menu' can be declared as pointer to const [constParameter] xournalpp-1.1.1/src/model/Document.cpp:146:61: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] xournalpp-1.1.1/src/model/Document.h:42:12: style:inconclusive: Technically the member function 'Document::getPageCount' can be const. [functionConst] xournalpp-1.1.1/src/model/Document.cpp:104:16: note: Technically the member function 'Document::getPageCount' can be const. xournalpp-1.1.1/src/model/Document.h:42:12: note: Technically the member function 'Document::getPageCount' can be const. xournalpp-1.1.1/src/model/Document.h:63:17: style:inconclusive: Technically the member function 'Document::getLastErrorMsg' can be const. [functionConst] xournalpp-1.1.1/src/model/Document.cpp:347:16: note: Technically the member function 'Document::getLastErrorMsg' can be const. xournalpp-1.1.1/src/model/Document.h:63:17: note: Technically the member function 'Document::getLastErrorMsg' can be const. xournalpp-1.1.1/src/model/Document.h:70:14: style:inconclusive: Technically the member function 'Document::getFilepath' can be const. [functionConst] xournalpp-1.1.1/src/model/Document.cpp:110:16: note: Technically the member function 'Document::getFilepath' can be const. xournalpp-1.1.1/src/model/Document.h:70:14: note: Technically the member function 'Document::getFilepath' can be const. xournalpp-1.1.1/src/model/Document.h:71:14: style:inconclusive: Technically the member function 'Document::getPdfFilepath' can be const. [functionConst] xournalpp-1.1.1/src/model/Document.cpp:112:16: note: Technically the member function 'Document::getPdfFilepath' can be const. xournalpp-1.1.1/src/model/Document.h:71:14: note: Technically the member function 'Document::getPdfFilepath' can be const. xournalpp-1.1.1/src/model/Document.h:33:5: style: Class 'Document' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/model/Document.cpp:318:9: style: The if condition is the same as the previous if condition [duplicateCondition] xournalpp-1.1.1/src/model/Document.cpp:314:9: note: First condition xournalpp-1.1.1/src/model/Document.cpp:318:9: note: Second condition xournalpp-1.1.1/src/model/Image.h:34:18: style: The function 'scale' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/model/Element.h:50:18: note: Virtual function in base class xournalpp-1.1.1/src/model/Image.h:34:18: note: Function in derived class xournalpp-1.1.1/src/model/Image.h:35:18: style: The function 'rotate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/model/Element.h:51:18: note: Virtual function in base class xournalpp-1.1.1/src/model/Image.h:35:18: note: Function in derived class xournalpp-1.1.1/src/model/Image.h:40:22: style: The function 'clone' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/model/Element.h:74:22: note: Virtual function in base class xournalpp-1.1.1/src/model/Image.h:40:22: note: Function in derived class xournalpp-1.1.1/src/model/Layer.h:48:18: style:inconclusive: Technically the member function 'Layer::indexOf' can be const. [functionConst] xournalpp-1.1.1/src/model/Layer.cpp:74:13: note: Technically the member function 'Layer::indexOf' can be const. xournalpp-1.1.1/src/model/Layer.h:48:18: note: Technically the member function 'Layer::indexOf' can be const. xournalpp-1.1.1/src/model/Layer.h:63:10: style:inconclusive: Technically the member function 'Layer::isAnnotated' can be const. [functionConst] xournalpp-1.1.1/src/model/Layer.cpp:101:13: note: Technically the member function 'Layer::isAnnotated' can be const. xournalpp-1.1.1/src/model/Layer.h:63:10: note: Technically the member function 'Layer::isAnnotated' can be const. xournalpp-1.1.1/src/model/Layer.cpp:35:19: style: Variable 'elem2' can be declared as pointer to const [constVariable] xournalpp-1.1.1/src/model/Layer.cpp:52:19: style: Variable 'elem2' can be declared as pointer to const [constVariable] xournalpp-1.1.1/src/model/Layer.cpp:74:30: style: Parameter 'e' can be declared as pointer to const [constParameter] xournalpp-1.1.1/src/model/Layer.cpp:36:25: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/model/Layer.cpp:53:25: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/model/LineStyle.cpp:21:19: style: Local variable 'dashes' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/model/LineStyle.h:58:13: note: Shadowed declaration xournalpp-1.1.1/src/model/LineStyle.cpp:21:19: note: Shadow variable xournalpp-1.1.1/src/model/LineStyle.cpp:22:9: style: Local variable 'dashCount' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/model/LineStyle.h:63:9: note: Shadowed declaration xournalpp-1.1.1/src/model/LineStyle.cpp:22:9: note: Shadow variable xournalpp-1.1.1/src/model/PageListener.cpp:9:73: style:inconclusive: Function 'registerListener' argument 1 names different: declaration 'handler' definition '_handler'. [funcArgNamesDifferent] xournalpp-1.1.1/src/model/PageListener.h:28:63: note: Function 'registerListener' argument 1 names different: declaration 'handler' definition '_handler'. xournalpp-1.1.1/src/model/PageListener.cpp:9:73: note: Function 'registerListener' argument 1 names different: declaration 'handler' definition '_handler'. xournalpp-1.1.1/src/model/Point.cpp:15:12: style: Local variable 'x' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/model/Point.h:72:12: note: Shadowed declaration xournalpp-1.1.1/src/model/Point.cpp:15:12: note: Shadow variable xournalpp-1.1.1/src/model/Point.cpp:16:12: style: Local variable 'y' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/model/Point.h:77:12: note: Shadowed declaration xournalpp-1.1.1/src/model/Point.cpp:16:12: note: Shadow variable xournalpp-1.1.1/src/model/SplineSegment.h:100:11: style:inconclusive: Member variable 'SplineSegment::secondKnot' is in the wrong place in the initializer list. [initializerList] xournalpp-1.1.1/src/model/SplineSegment.cpp:4:45: note: Member variable 'SplineSegment::secondKnot' is in the wrong place in the initializer list. xournalpp-1.1.1/src/model/SplineSegment.h:100:11: note: Member variable 'SplineSegment::secondKnot' is in the wrong place in the initializer list. xournalpp-1.1.1/src/model/SplineSegment.cpp:7:5: performance: Variable 'firstKnot' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] xournalpp-1.1.1/src/model/SplineSegment.cpp:8:5: performance: Variable 'firstControlPoint' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] xournalpp-1.1.1/src/model/SplineSegment.cpp:9:5: performance: Variable 'secondControlPoint' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] xournalpp-1.1.1/src/model/SplineSegment.cpp:10:5: performance: Variable 'secondKnot' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] xournalpp-1.1.1/src/model/Stroke.h:117:12: warning: The class 'Stroke' defines member variable with name 'width' also defined in its parent class 'Element'. [duplInheritedMember] xournalpp-1.1.1/src/model/Element.h:87:20: note: Parent variable 'Element::width' xournalpp-1.1.1/src/model/Stroke.h:117:12: note: Derived variable 'Stroke::width' xournalpp-1.1.1/src/model/TexImage.h:53:18: style: The function 'scale' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/model/Element.h:50:18: note: Virtual function in base class xournalpp-1.1.1/src/model/TexImage.h:53:18: note: Function in derived class xournalpp-1.1.1/src/model/TexImage.h:54:18: style: The function 'rotate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/model/Element.h:51:18: note: Virtual function in base class xournalpp-1.1.1/src/model/TexImage.h:54:18: note: Function in derived class xournalpp-1.1.1/src/model/TexImage.h:60:22: style: The function 'clone' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/model/Element.h:74:22: note: Virtual function in base class xournalpp-1.1.1/src/model/TexImage.h:60:22: note: Function in derived class xournalpp-1.1.1/src/model/XojPage.h:88:21: style:inconclusive: Member variable 'XojPage::backgroundImage' is in the wrong place in the initializer list. [initializerList] xournalpp-1.1.1/src/model/XojPage.cpp:23:9: note: Member variable 'XojPage::backgroundImage' is in the wrong place in the initializer list. xournalpp-1.1.1/src/model/XojPage.h:88:21: note: Member variable 'XojPage::backgroundImage' is in the wrong place in the initializer list. xournalpp-1.1.1/src/model/XojPage.h:46:14: style:inconclusive: Technically the member function 'XojPage::getBackgroundType' can be const. [functionConst] xournalpp-1.1.1/src/model/XojPage.cpp:155:15: note: Technically the member function 'XojPage::getBackgroundType' can be const. xournalpp-1.1.1/src/model/XojPage.h:46:14: note: Technically the member function 'XojPage::getBackgroundType' can be const. xournalpp-1.1.1/src/model/XojPage.h:64:12: style:inconclusive: Technically the member function 'XojPage::getLayerCount' can be const. [functionConst] xournalpp-1.1.1/src/model/XojPage.cpp:64:15: note: Technically the member function 'XojPage::getLayerCount' can be const. xournalpp-1.1.1/src/model/XojPage.h:64:12: note: Technically the member function 'XojPage::getLayerCount' can be const. xournalpp-1.1.1/src/model/XojPage.cpp:165:12: style: Local variable 'layer' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/model/XojPage.h:99:25: note: Shadowed declaration xournalpp-1.1.1/src/model/XojPage.cpp:165:12: note: Shadow variable xournalpp-1.1.1/src/model/XojPage.cpp:50:34: style: Parameter 'layer' can be declared as pointer to const [constParameter] xournalpp-1.1.1/src/model/XojPage.cpp:137:31: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/model/eraser/EraseableStrokePart.h:25:5: style: Class 'EraseableStrokePart' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/model/eraser/EraseableStroke.cpp:12:11: warning: Class 'EraseableStroke' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] xournalpp-1.1.1/src/model/eraser/EraseableStroke.cpp:12:11: warning: Class 'EraseableStroke' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] xournalpp-1.1.1/src/model/eraser/EraseableStroke.h:30:5: style: Class 'EraseableStroke' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/model/eraser/EraseableStroke.cpp:49:19: style: Local variable 'p' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/model/eraser/EraseableStroke.cpp:44:15: note: Shadowed declaration xournalpp-1.1.1/src/model/eraser/EraseableStroke.cpp:49:19: note: Shadow variable xournalpp-1.1.1/src/pdf/base/XojCairoPdfExport.h:27:18: style: The function 'createPdf' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/pdf/base/XojPdfExport.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/pdf/base/XojCairoPdfExport.h:27:18: note: Function in derived class xournalpp-1.1.1/src/pdf/base/XojCairoPdfExport.h:28:18: style: The function 'createPdf' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/pdf/base/XojPdfExport.h:29:18: note: Virtual function in base class xournalpp-1.1.1/src/pdf/base/XojCairoPdfExport.h:28:18: note: Function in derived class xournalpp-1.1.1/src/pdf/base/XojCairoPdfExport.h:29:25: style: The function 'getLastError' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/pdf/base/XojPdfExport.h:30:25: note: Virtual function in base class xournalpp-1.1.1/src/pdf/base/XojCairoPdfExport.h:29:25: note: Function in derived class xournalpp-1.1.1/src/pdf/base/XojCairoPdfExport.h:34:18: style: The function 'setExportBackground' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/pdf/base/XojPdfExport.h:35:18: note: Virtual function in base class xournalpp-1.1.1/src/pdf/base/XojCairoPdfExport.h:34:18: note: Function in derived class xournalpp-1.1.1/src/pdf/base/XojCairoPdfExport.cpp:162:15: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/pdf/base/XojPdfDocument.h:33:10: style: The function 'assign' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/pdf/base/XojPdfDocumentInterface.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/pdf/base/XojPdfDocument.h:33:10: note: Function in derived class xournalpp-1.1.1/src/pdf/base/XojPdfDocument.h:34:10: style: The function 'equals' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/pdf/base/XojPdfDocumentInterface.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/pdf/base/XojPdfDocument.h:34:10: note: Function in derived class xournalpp-1.1.1/src/pdf/base/XojPdfDocument.h:37:10: style: The function 'save' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/pdf/base/XojPdfDocumentInterface.h:31:18: note: Virtual function in base class xournalpp-1.1.1/src/pdf/base/XojPdfDocument.h:37:10: note: Function in derived class xournalpp-1.1.1/src/pdf/base/XojPdfDocument.h:38:10: style: The function 'load' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/pdf/base/XojPdfDocumentInterface.h:32:18: note: Virtual function in base class xournalpp-1.1.1/src/pdf/base/XojPdfDocument.h:38:10: note: Function in derived class xournalpp-1.1.1/src/pdf/base/XojPdfDocument.h:39:10: style: The function 'load' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/pdf/base/XojPdfDocumentInterface.h:33:18: note: Virtual function in base class xournalpp-1.1.1/src/pdf/base/XojPdfDocument.h:39:10: note: Function in derived class xournalpp-1.1.1/src/pdf/base/XojPdfDocument.h:40:10: style: The function 'isLoaded' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/pdf/base/XojPdfDocumentInterface.h:34:18: note: Virtual function in base class xournalpp-1.1.1/src/pdf/base/XojPdfDocument.h:40:10: note: Function in derived class xournalpp-1.1.1/src/pdf/base/XojPdfDocument.h:42:20: style: The function 'getPage' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/pdf/base/XojPdfDocumentInterface.h:36:28: note: Virtual function in base class xournalpp-1.1.1/src/pdf/base/XojPdfDocument.h:42:20: note: Function in derived class xournalpp-1.1.1/src/pdf/base/XojPdfDocument.h:43:12: style: The function 'getPageCount' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/pdf/base/XojPdfDocumentInterface.h:37:20: note: Virtual function in base class xournalpp-1.1.1/src/pdf/base/XojPdfDocument.h:43:12: note: Function in derived class xournalpp-1.1.1/src/pdf/base/XojPdfDocument.h:44:29: style: The function 'getContentsIter' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/pdf/base/XojPdfDocumentInterface.h:38:37: note: Virtual function in base class xournalpp-1.1.1/src/pdf/base/XojPdfDocument.h:44:29: note: Function in derived class xournalpp-1.1.1/src/pdf/base/XojPdfDocument.cpp:31:61: performance: Function parameter 'password' should be passed by const reference. [passedByValue] xournalpp-1.1.1/src/pdf/base/XojPdfDocument.cpp:35:68: performance: Function parameter 'password' should be passed by const reference. [passedByValue] xournalpp-1.1.1/src/pdf/popplerapi/PopplerGlibPage.h:21:5: style: Class 'PopplerGlibPage' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/pdf/popplerapi/PopplerGlibDocument.cpp:43:48: style:inconclusive: Function 'save' argument 1 names different: declaration 'filepath' definition 'file'. [funcArgNamesDifferent] xournalpp-1.1.1/src/pdf/popplerapi/PopplerGlibDocument.h:31:39: note: Function 'save' argument 1 names different: declaration 'filepath' definition 'file'. xournalpp-1.1.1/src/pdf/popplerapi/PopplerGlibDocument.cpp:43:48: note: Function 'save' argument 1 names different: declaration 'filepath' definition 'file'. xournalpp-1.1.1/src/pdf/popplerapi/PopplerGlibDocument.cpp:55:48: style:inconclusive: Function 'load' argument 1 names different: declaration 'filepath' definition 'file'. [funcArgNamesDifferent] xournalpp-1.1.1/src/pdf/popplerapi/PopplerGlibDocument.h:32:39: note: Function 'load' argument 1 names different: declaration 'filepath' definition 'file'. xournalpp-1.1.1/src/pdf/popplerapi/PopplerGlibDocument.cpp:55:48: note: Function 'load' argument 1 names different: declaration 'filepath' definition 'file'. xournalpp-1.1.1/src/plugin/PluginController.h:33:10: performance:inconclusive: Technically the member function 'PluginController::loadPluginsFrom' can be static (but you may consider moving to unnamed namespace). [functionStatic] xournalpp-1.1.1/src/plugin/PluginController.cpp:22:24: note: Technically the member function 'PluginController::loadPluginsFrom' can be static (but you may consider moving to unnamed namespace). xournalpp-1.1.1/src/plugin/PluginController.h:33:10: note: Technically the member function 'PluginController::loadPluginsFrom' can be static (but you may consider moving to unnamed namespace). xournalpp-1.1.1/src/plugin/PluginController.h:38:10: performance:inconclusive: Technically the member function 'PluginController::registerToolbar' can be static (but you may consider moving to unnamed namespace). [functionStatic] xournalpp-1.1.1/src/plugin/PluginController.cpp:56:24: note: Technically the member function 'PluginController::registerToolbar' can be static (but you may consider moving to unnamed namespace). xournalpp-1.1.1/src/plugin/PluginController.h:38:10: note: Technically the member function 'PluginController::registerToolbar' can be static (but you may consider moving to unnamed namespace). xournalpp-1.1.1/src/undo/ArrangeUndoAction.cpp:8:85: performance: Function parameter 'desc' should be passed by const reference. [passedByValue] xournalpp-1.1.1/src/undo/ArrangeUndoAction.cpp:8:103: performance: Function parameter 'oldOrder' should be passed by const reference. [passedByValue] xournalpp-1.1.1/src/undo/ArrangeUndoAction.cpp:9:50: performance: Function parameter 'newOrder' should be passed by const reference. [passedByValue] xournalpp-1.1.1/src/undo/CopyUndoAction.h:26:18: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/CopyUndoAction.h:26:18: note: Function in derived class xournalpp-1.1.1/src/undo/CopyUndoAction.h:27:18: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/CopyUndoAction.h:27:18: note: Function in derived class xournalpp-1.1.1/src/undo/CopyUndoAction.h:29:25: style: The function 'getText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:30:25: note: Virtual function in base class xournalpp-1.1.1/src/undo/CopyUndoAction.h:29:25: note: Function in derived class xournalpp-1.1.1/src/undo/ColorUndoAction.h:31:18: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/ColorUndoAction.h:31:18: note: Function in derived class xournalpp-1.1.1/src/undo/ColorUndoAction.h:32:18: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/ColorUndoAction.h:32:18: note: Function in derived class xournalpp-1.1.1/src/undo/ColorUndoAction.h:33:25: style: The function 'getText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:30:25: note: Virtual function in base class xournalpp-1.1.1/src/undo/ColorUndoAction.h:33:25: note: Function in derived class xournalpp-1.1.1/src/undo/ColorUndoAction.cpp:44:32: style: Local variable 'e' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/undo/ColorUndoAction.cpp:38:27: note: Shadowed declaration xournalpp-1.1.1/src/undo/ColorUndoAction.cpp:44:32: note: Shadow variable xournalpp-1.1.1/src/undo/ColorUndoAction.cpp:70:32: style: Local variable 'e' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/undo/ColorUndoAction.cpp:64:27: note: Shadowed declaration xournalpp-1.1.1/src/undo/ColorUndoAction.cpp:70:32: note: Shadow variable xournalpp-1.1.1/src/undo/EmergencySaveRestore.h:27:18: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/EmergencySaveRestore.h:27:18: note: Function in derived class xournalpp-1.1.1/src/undo/EmergencySaveRestore.h:28:18: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/EmergencySaveRestore.h:28:18: note: Function in derived class xournalpp-1.1.1/src/undo/EmergencySaveRestore.h:30:25: style: The function 'getText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:30:25: note: Virtual function in base class xournalpp-1.1.1/src/undo/EmergencySaveRestore.h:30:25: note: Function in derived class xournalpp-1.1.1/src/undo/FillUndoAction.h:27:18: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/FillUndoAction.h:27:18: note: Function in derived class xournalpp-1.1.1/src/undo/FillUndoAction.h:28:18: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/FillUndoAction.h:28:18: note: Function in derived class xournalpp-1.1.1/src/undo/FillUndoAction.h:29:25: style: The function 'getText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:30:25: note: Virtual function in base class xournalpp-1.1.1/src/undo/FillUndoAction.h:29:25: note: Function in derived class xournalpp-1.1.1/src/undo/FillUndoAction.cpp:47:31: style: Local variable 'e' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/undo/FillUndoAction.cpp:44:26: note: Shadowed declaration xournalpp-1.1.1/src/undo/FillUndoAction.cpp:47:31: note: Shadow variable xournalpp-1.1.1/src/undo/FillUndoAction.cpp:67:31: style: Local variable 'e' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/undo/FillUndoAction.cpp:64:26: note: Shadowed declaration xournalpp-1.1.1/src/undo/FillUndoAction.cpp:67:31: note: Shadow variable xournalpp-1.1.1/src/undo/EraseUndoAction.h:26:5: style: Class 'EraseUndoAction' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/undo/EraseUndoAction.h:30:18: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/EraseUndoAction.h:30:18: note: Function in derived class xournalpp-1.1.1/src/undo/EraseUndoAction.h:31:18: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/EraseUndoAction.h:31:18: note: Function in derived class xournalpp-1.1.1/src/undo/EraseUndoAction.h:39:25: style: The function 'getText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:30:25: note: Virtual function in base class xournalpp-1.1.1/src/undo/EraseUndoAction.h:39:25: note: Function in derived class xournalpp-1.1.1/src/undo/EraseUndoAction.cpp:45:44: style: Parameter 'element' can be declared as pointer to const [constParameter] xournalpp-1.1.1/src/undo/GroupUndoAction.h:31:34: style: The function 'getPages' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:35:34: note: Virtual function in base class xournalpp-1.1.1/src/undo/GroupUndoAction.h:31:34: note: Function in derived class xournalpp-1.1.1/src/undo/GroupUndoAction.h:33:18: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/GroupUndoAction.h:33:18: note: Function in derived class xournalpp-1.1.1/src/undo/GroupUndoAction.h:34:18: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/GroupUndoAction.h:34:18: note: Function in derived class xournalpp-1.1.1/src/undo/GroupUndoAction.h:36:25: style: The function 'getText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:30:25: note: Virtual function in base class xournalpp-1.1.1/src/undo/GroupUndoAction.h:36:25: note: Function in derived class xournalpp-1.1.1/src/undo/GroupUndoAction.cpp:6:41: style: Unsigned expression 'i' can't be negative so it is unnecessary to test it. [unsignedPositive] xournalpp-1.1.1/src/undo/GroupUndoAction.cpp:24:35: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/undo/GroupUndoAction.cpp:41:42: style: Consider using std::any_of, std::all_of, std::none_of, or std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/undo/GroupUndoAction.cpp:48:42: style: Consider using std::any_of, std::all_of, std::none_of, or std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/undo/FontUndoAction.h:32:18: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/FontUndoAction.h:32:18: note: Function in derived class xournalpp-1.1.1/src/undo/FontUndoAction.h:33:18: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/FontUndoAction.h:33:18: note: Function in derived class xournalpp-1.1.1/src/undo/FontUndoAction.h:34:25: style: The function 'getText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:30:25: note: Virtual function in base class xournalpp-1.1.1/src/undo/FontUndoAction.h:34:25: note: Function in derived class xournalpp-1.1.1/src/undo/FontUndoAction.cpp:50:31: style: Local variable 'e' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/undo/FontUndoAction.cpp:44:26: note: Shadowed declaration xournalpp-1.1.1/src/undo/FontUndoAction.cpp:50:31: note: Shadow variable xournalpp-1.1.1/src/undo/FontUndoAction.cpp:83:31: style: Local variable 'e' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/undo/FontUndoAction.cpp:77:26: note: Shadowed declaration xournalpp-1.1.1/src/undo/FontUndoAction.cpp:83:31: note: Shadow variable xournalpp-1.1.1/src/undo/FontUndoAction.cpp:12:43: style: Parameter 'oldFont' can be declared as reference to const [constParameter] xournalpp-1.1.1/src/undo/FontUndoAction.cpp:12:61: style: Parameter 'newFont' can be declared as reference to const [constParameter] xournalpp-1.1.1/src/undo/InsertDeletePageUndoAction.h:26:18: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/InsertDeletePageUndoAction.h:26:18: note: Function in derived class xournalpp-1.1.1/src/undo/InsertDeletePageUndoAction.h:27:18: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/InsertDeletePageUndoAction.h:27:18: note: Function in derived class xournalpp-1.1.1/src/undo/InsertDeletePageUndoAction.h:29:25: style: The function 'getText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:30:25: note: Virtual function in base class xournalpp-1.1.1/src/undo/InsertDeletePageUndoAction.h:29:25: note: Function in derived class xournalpp-1.1.1/src/undo/InsertLayerUndoAction.h:29:18: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/InsertLayerUndoAction.h:29:18: note: Function in derived class xournalpp-1.1.1/src/undo/InsertLayerUndoAction.h:30:18: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/InsertLayerUndoAction.h:30:18: note: Function in derived class xournalpp-1.1.1/src/undo/InsertLayerUndoAction.h:32:25: style: The function 'getText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:30:25: note: Virtual function in base class xournalpp-1.1.1/src/undo/InsertLayerUndoAction.h:32:25: note: Function in derived class xournalpp-1.1.1/src/undo/LayerRenameUndoAction.h:35:12: style:inconclusive: Member variable 'LayerRenameUndoAction::layer' is in the wrong place in the initializer list. [initializerList] xournalpp-1.1.1/src/undo/LayerRenameUndoAction.cpp:9:9: note: Member variable 'LayerRenameUndoAction::layer' is in the wrong place in the initializer list. xournalpp-1.1.1/src/undo/LayerRenameUndoAction.h:35:12: note: Member variable 'LayerRenameUndoAction::layer' is in the wrong place in the initializer list. xournalpp-1.1.1/src/undo/InsertUndoAction.h:26:18: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/InsertUndoAction.h:26:18: note: Function in derived class xournalpp-1.1.1/src/undo/InsertUndoAction.h:27:18: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/InsertUndoAction.h:27:18: note: Function in derived class xournalpp-1.1.1/src/undo/InsertUndoAction.h:29:25: style: The function 'getText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:30:25: note: Virtual function in base class xournalpp-1.1.1/src/undo/InsertUndoAction.h:29:25: note: Function in derived class xournalpp-1.1.1/src/undo/InsertUndoAction.h:42:18: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/InsertUndoAction.h:42:18: note: Function in derived class xournalpp-1.1.1/src/undo/InsertUndoAction.h:43:18: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/InsertUndoAction.h:43:18: note: Function in derived class xournalpp-1.1.1/src/undo/InsertUndoAction.h:45:25: style: The function 'getText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:30:25: note: Virtual function in base class xournalpp-1.1.1/src/undo/InsertUndoAction.h:45:25: note: Function in derived class xournalpp-1.1.1/src/undo/MoveLayerUndoAction.h:30:18: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/MoveLayerUndoAction.h:30:18: note: Function in derived class xournalpp-1.1.1/src/undo/MoveLayerUndoAction.h:31:18: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/MoveLayerUndoAction.h:31:18: note: Function in derived class xournalpp-1.1.1/src/undo/MoveLayerUndoAction.h:33:25: style: The function 'getText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:30:25: note: Virtual function in base class xournalpp-1.1.1/src/undo/MoveLayerUndoAction.h:33:25: note: Function in derived class xournalpp-1.1.1/src/undo/LineStyleUndoAction.cpp:30:36: style: Local variable 'e' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/undo/LineStyleUndoAction.cpp:24:30: note: Shadowed declaration xournalpp-1.1.1/src/undo/LineStyleUndoAction.cpp:30:36: note: Shadow variable xournalpp-1.1.1/src/undo/LineStyleUndoAction.cpp:56:36: style: Local variable 'e' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/undo/LineStyleUndoAction.cpp:50:30: note: Shadowed declaration xournalpp-1.1.1/src/undo/LineStyleUndoAction.cpp:56:36: note: Shadow variable xournalpp-1.1.1/src/undo/MoveUndoAction.h:27:18: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/MoveUndoAction.h:27:18: note: Function in derived class xournalpp-1.1.1/src/undo/MoveUndoAction.h:28:18: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/MoveUndoAction.h:28:18: note: Function in derived class xournalpp-1.1.1/src/undo/MoveUndoAction.h:29:26: style: The function 'getPages' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:35:34: note: Virtual function in base class xournalpp-1.1.1/src/undo/MoveUndoAction.h:29:26: note: Function in derived class xournalpp-1.1.1/src/undo/MoveUndoAction.h:30:25: style: The function 'getText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:30:25: note: Virtual function in base class xournalpp-1.1.1/src/undo/MoveUndoAction.h:30:25: note: Function in derived class xournalpp-1.1.1/src/undo/MoveUndoAction.cpp:11:102: style: Parameter 'selected' can be declared as pointer to const [constParameter] xournalpp-1.1.1/src/undo/PageBackgroundChangedUndoAction.h:27:18: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/PageBackgroundChangedUndoAction.h:27:18: note: Function in derived class xournalpp-1.1.1/src/undo/PageBackgroundChangedUndoAction.h:28:18: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/PageBackgroundChangedUndoAction.h:28:18: note: Function in derived class xournalpp-1.1.1/src/undo/PageBackgroundChangedUndoAction.h:30:25: style: The function 'getText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:30:25: note: Virtual function in base class xournalpp-1.1.1/src/undo/PageBackgroundChangedUndoAction.h:30:25: note: Function in derived class xournalpp-1.1.1/src/undo/RemoveLayerUndoAction.h:25:18: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/RemoveLayerUndoAction.h:25:18: note: Function in derived class xournalpp-1.1.1/src/undo/RemoveLayerUndoAction.h:26:18: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/RemoveLayerUndoAction.h:26:18: note: Function in derived class xournalpp-1.1.1/src/undo/RemoveLayerUndoAction.h:28:25: style: The function 'getText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:30:25: note: Virtual function in base class xournalpp-1.1.1/src/undo/RemoveLayerUndoAction.h:28:25: note: Function in derived class xournalpp-1.1.1/src/undo/RecognizerUndoAction.h:28:18: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/RecognizerUndoAction.h:28:18: note: Function in derived class xournalpp-1.1.1/src/undo/RecognizerUndoAction.h:29:18: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/RecognizerUndoAction.h:29:18: note: Function in derived class xournalpp-1.1.1/src/undo/RecognizerUndoAction.h:31:25: style: The function 'getText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:30:25: note: Virtual function in base class xournalpp-1.1.1/src/undo/RecognizerUndoAction.h:31:25: note: Function in derived class xournalpp-1.1.1/src/undo/RecognizerUndoAction.cpp:32:18: style: Variable 's2' can be declared as pointer to const [constVariable] xournalpp-1.1.1/src/undo/RecognizerUndoAction.cpp:33:22: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/undo/RotateUndoAction.h:22:18: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/RotateUndoAction.h:22:18: note: Function in derived class xournalpp-1.1.1/src/undo/RotateUndoAction.h:23:18: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/RotateUndoAction.h:23:18: note: Function in derived class xournalpp-1.1.1/src/undo/RotateUndoAction.h:24:25: style: The function 'getText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:30:25: note: Virtual function in base class xournalpp-1.1.1/src/undo/RotateUndoAction.h:24:25: note: Function in derived class xournalpp-1.1.1/src/undo/RotateUndoAction.cpp:9:80: style: Parameter 'elements' can be declared as pointer to const [constParameter] xournalpp-1.1.1/src/undo/ScaleUndoAction.h:23:18: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/ScaleUndoAction.h:23:18: note: Function in derived class xournalpp-1.1.1/src/undo/ScaleUndoAction.h:24:18: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/ScaleUndoAction.h:24:18: note: Function in derived class xournalpp-1.1.1/src/undo/ScaleUndoAction.h:25:25: style: The function 'getText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:30:25: note: Virtual function in base class xournalpp-1.1.1/src/undo/ScaleUndoAction.h:25:25: note: Function in derived class xournalpp-1.1.1/src/undo/ScaleUndoAction.cpp:11:78: style: Parameter 'elements' can be declared as pointer to const [constParameter] xournalpp-1.1.1/src/undo/SwapUndoAction.h:27:18: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/SwapUndoAction.h:27:18: note: Function in derived class xournalpp-1.1.1/src/undo/SwapUndoAction.h:28:18: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/SwapUndoAction.h:28:18: note: Function in derived class xournalpp-1.1.1/src/undo/SwapUndoAction.h:29:26: style: The function 'getPages' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:35:34: note: Virtual function in base class xournalpp-1.1.1/src/undo/SwapUndoAction.h:29:26: note: Function in derived class xournalpp-1.1.1/src/undo/SwapUndoAction.h:30:25: style: The function 'getText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:30:25: note: Virtual function in base class xournalpp-1.1.1/src/undo/SwapUndoAction.h:30:25: note: Function in derived class xournalpp-1.1.1/src/undo/SizeUndoAction.h:27:18: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/SizeUndoAction.h:27:18: note: Function in derived class xournalpp-1.1.1/src/undo/SizeUndoAction.h:28:18: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/SizeUndoAction.h:28:18: note: Function in derived class xournalpp-1.1.1/src/undo/SizeUndoAction.h:29:25: style: The function 'getText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:30:25: note: Virtual function in base class xournalpp-1.1.1/src/undo/SizeUndoAction.h:29:25: note: Function in derived class xournalpp-1.1.1/src/undo/SizeUndoAction.cpp:72:31: style: Local variable 'e' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/undo/SizeUndoAction.cpp:69:26: note: Shadowed declaration xournalpp-1.1.1/src/undo/SizeUndoAction.cpp:72:31: note: Shadow variable xournalpp-1.1.1/src/undo/SizeUndoAction.cpp:93:31: style: Local variable 'e' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/undo/SizeUndoAction.cpp:90:26: note: Shadowed declaration xournalpp-1.1.1/src/undo/SizeUndoAction.cpp:93:31: note: Shadow variable xournalpp-1.1.1/src/undo/TextUndoAction.h:27:18: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/TextUndoAction.h:27:18: note: Function in derived class xournalpp-1.1.1/src/undo/TextUndoAction.h:28:18: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/TextUndoAction.h:28:18: note: Function in derived class xournalpp-1.1.1/src/undo/TextUndoAction.h:30:25: style: The function 'getText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:30:25: note: Virtual function in base class xournalpp-1.1.1/src/undo/TextUndoAction.h:30:25: note: Function in derived class xournalpp-1.1.1/src/undo/TextBoxUndoAction.h:27:18: style: The function 'undo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/TextBoxUndoAction.h:27:18: note: Function in derived class xournalpp-1.1.1/src/undo/TextBoxUndoAction.h:28:18: style: The function 'redo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/undo/TextBoxUndoAction.h:28:18: note: Function in derived class xournalpp-1.1.1/src/undo/TextBoxUndoAction.h:30:25: style: The function 'getText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/undo/UndoAction.h:30:25: note: Virtual function in base class xournalpp-1.1.1/src/undo/TextBoxUndoAction.h:30:25: note: Function in derived class xournalpp-1.1.1/src/undo/UndoRedoHandler.cpp:22:19: error: Returning object that points to local variable 'ptr' that will be invalid when returning. [returnDanglingLifetime] xournalpp-1.1.1/src/undo/UndoRedoHandler.cpp:22:19: note: Raw pointer to smart pointer created here. xournalpp-1.1.1/src/undo/UndoRedoHandler.cpp:21:30: note: Variable created here. xournalpp-1.1.1/src/undo/UndoRedoHandler.cpp:22:19: note: Returning object that points to local variable 'ptr' that will be invalid when returning. xournalpp-1.1.1/src/undo/UndoRedoHandler.h:41:10: style:inconclusive: Technically the member function 'UndoRedoHandler::canUndo' can be const. [functionConst] xournalpp-1.1.1/src/undo/UndoRedoHandler.cpp:150:23: note: Technically the member function 'UndoRedoHandler::canUndo' can be const. xournalpp-1.1.1/src/undo/UndoRedoHandler.h:41:10: note: Technically the member function 'UndoRedoHandler::canUndo' can be const. xournalpp-1.1.1/src/undo/UndoRedoHandler.h:42:10: style:inconclusive: Technically the member function 'UndoRedoHandler::canRedo' can be const. [functionConst] xournalpp-1.1.1/src/undo/UndoRedoHandler.cpp:152:23: note: Technically the member function 'UndoRedoHandler::canRedo' can be const. xournalpp-1.1.1/src/undo/UndoRedoHandler.h:42:10: note: Technically the member function 'UndoRedoHandler::canRedo' can be const. xournalpp-1.1.1/src/util/PlaceholderString.h:41:5: style: Struct 'PlaceholderString' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/util/DeviceListHelper.cpp:77:68: style:inconclusive: Function 'getSourceMapping' argument 1 names different: declaration 'src' definition 'source'. [funcArgNamesDifferent] xournalpp-1.1.1/src/util/DeviceListHelper.h:45:50: note: Function 'getSourceMapping' argument 1 names different: declaration 'src' definition 'source'. xournalpp-1.1.1/src/util/DeviceListHelper.cpp:77:68: note: Function 'getSourceMapping' argument 1 names different: declaration 'src' definition 'source'. xournalpp-1.1.1/src/util/CrashHandlerUnix.h:73:53: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] xournalpp-1.1.1/src/util/IconNameHelper.h:20:5: style: Class 'IconNameHelper' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/util/OutputStream.h:36:5: style: Class 'GzOutputStream' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/util/OutputStream.h:40:18: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/util/OutputStream.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/util/OutputStream.h:40:18: note: Function in derived class xournalpp-1.1.1/src/util/OutputStream.h:42:18: style: The function 'close' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/util/OutputStream.h:31:18: note: Virtual function in base class xournalpp-1.1.1/src/util/OutputStream.h:42:18: note: Function in derived class xournalpp-1.1.1/src/util/PlaceholderString.cpp:137:54: style: Parameter 'ps' can be declared as reference to const [constParameter] xournalpp-1.1.1/src/util/PathUtil.cpp:83:45: performance: Function parameter 'ext' should be passed by const reference. [passedByValue] xournalpp-1.1.1/src/util/StringUtils.cpp:23:31: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] xournalpp-1.1.1/src/util/audio/PortAudioConsumer.cpp:140:42: style: Variable 'e' can be declared as reference to const [constVariable] xournalpp-1.1.1/src/util/serializing/BinObjectEncoding.h:22:18: style: The function 'addData' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/util/serializing/ObjectEncoding.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/util/serializing/BinObjectEncoding.h:22:18: note: Function in derived class xournalpp-1.1.1/src/util/serializing/HexObjectEncoding.h:22:18: style: The function 'addData' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/util/serializing/ObjectEncoding.h:27:18: note: Virtual function in base class xournalpp-1.1.1/src/util/serializing/HexObjectEncoding.h:22:18: note: Function in derived class xournalpp-1.1.1/src/util/serializing/ObjectOutputStream.h:25:5: style: Class 'ObjectOutputStream' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/util/serializing/ObjectInputStream.cpp:122:52: style:inconclusive: Function 'readData' argument 2 names different: declaration 'len' definition 'length'. [funcArgNamesDifferent] xournalpp-1.1.1/src/util/serializing/ObjectInputStream.h:38:37: note: Function 'readData' argument 2 names different: declaration 'len' definition 'length'. xournalpp-1.1.1/src/util/serializing/ObjectInputStream.cpp:122:52: note: Function 'readData' argument 2 names different: declaration 'len' definition 'length'. xournalpp-1.1.1/src/util/serializing/ObjectInputStream.cpp:56:9: style: Local variable 'pos' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/util/serializing/ObjectInputStream.h:48:11: note: Shadowed declaration xournalpp-1.1.1/src/util/serializing/ObjectInputStream.cpp:56:9: note: Shadow variable xournalpp-1.1.1/src/view/DocumentView.cpp:13:38: warning: Class 'DocumentView' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] xournalpp-1.1.1/src/view/DocumentView.cpp:13:38: warning: Class 'DocumentView' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] xournalpp-1.1.1/src/view/DocumentView.cpp:205:13: style: Local variable 'width' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/view/DocumentView.h:112:12: note: Shadowed declaration xournalpp-1.1.1/src/view/DocumentView.cpp:205:13: note: Shadow variable xournalpp-1.1.1/src/view/DocumentView.cpp:206:13: style: Local variable 'height' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/view/DocumentView.h:113:12: note: Shadowed declaration xournalpp-1.1.1/src/view/DocumentView.cpp:206:13: note: Shadow variable xournalpp-1.1.1/src/view/background/BackgroundConfig.h:20:5: style: Class 'BackgroundConfig' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/view/background/BaseBackgroundPainter.h:33:18: style: Virtual function 'resetConfig' is called from constructor 'BaseBackgroundPainter()' at line 5. Dynamic binding is not used. [virtualCallInConstructor] xournalpp-1.1.1/src/view/background/BaseBackgroundPainter.cpp:5:50: note: Calling resetConfig xournalpp-1.1.1/src/view/background/BaseBackgroundPainter.h:33:18: note: resetConfig is a virtual function xournalpp-1.1.1/src/view/background/DottedBackgroundPainter.h:26:18: style: The function 'paint' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/view/background/BaseBackgroundPainter.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/view/background/DottedBackgroundPainter.h:26:18: note: Function in derived class xournalpp-1.1.1/src/view/background/DottedBackgroundPainter.h:32:18: style: The function 'resetConfig' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/view/background/BaseBackgroundPainter.h:33:18: note: Virtual function in base class xournalpp-1.1.1/src/view/background/DottedBackgroundPainter.h:32:18: note: Function in derived class xournalpp-1.1.1/src/view/background/GraphBackgroundPainter.h:26:18: style: The function 'paint' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/view/background/BaseBackgroundPainter.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/view/background/GraphBackgroundPainter.h:26:18: note: Function in derived class xournalpp-1.1.1/src/view/background/GraphBackgroundPainter.h:32:18: style: The function 'resetConfig' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/view/background/BaseBackgroundPainter.h:33:18: note: Virtual function in base class xournalpp-1.1.1/src/view/background/GraphBackgroundPainter.h:32:18: note: Function in derived class xournalpp-1.1.1/src/view/background/LineBackgroundPainter.h:22:5: style: Class 'LineBackgroundPainter' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/view/background/LineBackgroundPainter.h:26:18: style: The function 'paint' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/view/background/BaseBackgroundPainter.h:28:18: note: Virtual function in base class xournalpp-1.1.1/src/view/background/LineBackgroundPainter.h:26:18: note: Function in derived class xournalpp-1.1.1/src/view/background/LineBackgroundPainter.h:31:18: style: The function 'resetConfig' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xournalpp-1.1.1/src/view/background/BaseBackgroundPainter.h:33:18: note: Virtual function in base class xournalpp-1.1.1/src/view/background/LineBackgroundPainter.h:31:18: note: Function in derived class xournalpp-1.1.1/src/view/background/IsometricBackgroundPainter.h:22:5: style: Class 'IsometricBackgroundPainter' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xournalpp-1.1.1/src/view/background/MainBackgroundPainter.cpp:12:5: warning: Class 'MainBackgroundPainter' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] xournalpp-1.1.1/src/view/background/MainBackgroundPainter.cpp:12:5: warning: Class 'MainBackgroundPainter' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] xournalpp-1.1.1/src/view/background/MainBackgroundPainter.cpp:45:28: style: Local variable 'painter' shadows outer variable [shadowVariable] xournalpp-1.1.1/src/view/background/MainBackgroundPainter.h:39:54: note: Shadowed declaration xournalpp-1.1.1/src/view/background/MainBackgroundPainter.cpp:45:28: note: Shadow variable xournalpp-1.1.1/src/view/background/MainBackgroundPainter.cpp:24:16: style: Variable 'e' can be declared as reference to const [constVariable] xournalpp-1.1.1/test/SpeedTest.cpp:28:1: style: The class 'SpeedTest' does not declare a constructor although it has private member variables which likely require initialization. [noConstructor] xournalpp-1.1.1/test/SpeedTest.cpp:37:10: style:inconclusive: Technically the member function 'SpeedTest::endTest' can be const. [functionConst] xournalpp-1.1.1/test/SpeedTest.cpp:31:27: performance: Function parameter 'target' should be passed by const reference. [passedByValue] xournalpp-1.1.1/src/xoj-preview-extractor/xournalpp-thumbnailer.cpp:45:24: performance: Function parameter 'msg' should be passed by const reference. [passedByValue] xournalpp-1.1.1/test/util/XojPreviewExtractorTest.cpp:61:66: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/test/util/XojPreviewExtractorTest.cpp:83:66: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/test/util/XojPreviewExtractorTest.cpp:94:66: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/test/control/LoadHandlerTest.cpp:100:22: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/test/control/LoadHandlerTest.cpp:118:22: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/test/control/LoadHandlerTest.cpp:136:22: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/test/control/LoadHandlerTest.cpp:167:22: style: C-style pointer casting [cstyleCast] xournalpp-1.1.1/test/control/LoadHandlerTest.cpp:203:22: style: C-style pointer casting [cstyleCast] diff: head xournalpp-1.1.1/src/control/jobs/CustomExportJob.cpp:35:16: style: Variable 'filter' can be declared as reference to const [constVariable] head xournalpp-1.1.1/src/control/jobs/CustomExportJob.cpp:42:16: style: Variable 'filter' can be declared as reference to const [constVariable] 2.8 xournalpp-1.1.1/src/control/latex/LatexGenerator.cpp:78:17: style: The scope of the variable 'progName' can be reduced. [variableScope] head xournalpp-1.1.1/src/control/settings/MetadataManager.cpp:59:34: style: Parameter 'a' can be declared as reference to const. However it seems that 'sortMetadata' is a callback function, if 'a' is declared with const you might also need to cast function pointer(s). [constParameterCallback] xournalpp-1.1.1/src/control/settings/MetadataManager.cpp:83:41: note: You might need to cast the function pointer here xournalpp-1.1.1/src/control/settings/MetadataManager.cpp:59:34: note: Parameter 'a' can be declared as reference to const 2.8 xournalpp-1.1.1/src/control/settings/MetadataManager.cpp:59:34: style: Parameter 'a' can be declared with const. However it seems that 'sortMetadata' is a callback function, if 'a' is declared with const you might also need to cast function pointer(s). [constParameterCallback] xournalpp-1.1.1/src/control/settings/MetadataManager.cpp:83:41: note: You might need to cast the function pointer here xournalpp-1.1.1/src/control/settings/MetadataManager.cpp:59:34: note: Parameter 'a' can be declared with const head xournalpp-1.1.1/src/control/settings/MetadataManager.cpp:59:52: style: Parameter 'b' can be declared as reference to const. However it seems that 'sortMetadata' is a callback function, if 'b' is declared with const you might also need to cast function pointer(s). [constParameterCallback] xournalpp-1.1.1/src/control/settings/MetadataManager.cpp:83:41: note: You might need to cast the function pointer here xournalpp-1.1.1/src/control/settings/MetadataManager.cpp:59:52: note: Parameter 'b' can be declared as reference to const 2.8 xournalpp-1.1.1/src/control/settings/MetadataManager.cpp:59:52: style: Parameter 'b' can be declared with const. However it seems that 'sortMetadata' is a callback function, if 'b' is declared with const you might also need to cast function pointer(s). [constParameterCallback] xournalpp-1.1.1/src/control/settings/MetadataManager.cpp:83:41: note: You might need to cast the function pointer here xournalpp-1.1.1/src/control/settings/MetadataManager.cpp:59:52: note: Parameter 'b' can be declared with const head xournalpp-1.1.1/src/control/settings/Settings.cpp:2075:17: style: Variable 'attrib' can be declared as reference to const [constVariable] 2.8 xournalpp-1.1.1/src/control/settings/Settings.cpp:2075:17: style: Variable 'attrib' can be declared with const [constVariable] head xournalpp-1.1.1/src/control/settings/Settings.cpp:2091:17: style: Variable 'attrib' can be declared as reference to const [constVariable] 2.8 xournalpp-1.1.1/src/control/settings/Settings.cpp:2091:17: style: Variable 'attrib' can be declared with const [constVariable] head xournalpp-1.1.1/src/control/settings/Settings.cpp:2107:17: style: Variable 'attrib' can be declared as reference to const [constVariable] 2.8 xournalpp-1.1.1/src/control/settings/Settings.cpp:2107:17: style: Variable 'attrib' can be declared with const [constVariable] head xournalpp-1.1.1/src/control/settings/Settings.cpp:2123:17: style: Variable 'attrib' can be declared as reference to const [constVariable] 2.8 xournalpp-1.1.1/src/control/settings/Settings.cpp:2123:17: style: Variable 'attrib' can be declared with const [constVariable] head xournalpp-1.1.1/src/control/shaperecognizer/CircleRecognizer.cpp:35:56: style: Parameter 'inertia' can be declared as reference to const [constParameter] 2.8 xournalpp-1.1.1/src/control/shaperecognizer/CircleRecognizer.cpp:35:56: style: Parameter 'inertia' can be declared with const [constParameter] head xournalpp-1.1.1/src/control/shaperecognizer/ShapeRecognizerResult.cpp:23:18: style: Variable 'elem' can be declared as pointer to const [constVariable] 2.8 xournalpp-1.1.1/src/control/tools/EditSelection.cpp:350:23: performance:inconclusive: Use const reference for 'oldOrd' to avoid unnecessary data copying. [redundantCopyLocalConst] head xournalpp-1.1.1/src/control/zoom/ZoomControl.cpp:62:42: style: Parameter 'widget' can be declared as pointer to const [constParameter] 2.8 xournalpp-1.1.1/src/control/zoom/ZoomControl.cpp:62:42: style: Parameter 'widget' can be declared with const [constParameter] head xournalpp-1.1.1/src/gui/PageView.cpp:344:23: style: Variable 'status' can be declared as reference to const [constVariable] head xournalpp-1.1.1/src/gui/PageView.cpp:906:50: style: Parameter 'rect' can be declared as reference to const [constParameter] 2.8 xournalpp-1.1.1/src/gui/PageView.cpp:906:50: style: Parameter 'rect' can be declared with const [constParameter] head xournalpp-1.1.1/src/gui/dialog/toolbarCustomize/ToolItemDragCurrentData.cpp:40:61: style: Parameter 'd' can be declared as pointer to const [constParameter] 2.8 xournalpp-1.1.1/src/gui/dialog/toolbarCustomize/ToolItemDragCurrentData.cpp:40:61: style: Parameter 'd' can be declared with const [constParameter] head xournalpp-1.1.1/src/gui/toolbarMenubar/ToolPageLayer.cpp:129:16: style: Variable 'kv' can be declared as reference to const [constVariable] head xournalpp-1.1.1/src/gui/toolbarMenubar/ToolPageLayer.cpp:95:16: style: Variable 'kv' can be declared as reference to const [constVariable] head xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarItem.cpp:23:43: style: Parameter 'other' can be declared as reference to const [constParameter] 2.8 xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarItem.cpp:23:43: style: Parameter 'other' can be declared with const [constParameter] head xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarModel.cpp:34:40: style: Parameter 'data' can be declared as pointer to const [constParameter] 2.8 xournalpp-1.1.1/src/gui/toolbarMenubar/model/ToolbarModel.cpp:34:40: style: Parameter 'data' can be declared with const [constParameter] head xournalpp-1.1.1/src/gui/widgets/gtkmenutooltogglebutton.cpp:405:55: style: Parameter 'menu' can be declared as pointer to const [constParameter] 2.8 xournalpp-1.1.1/src/gui/widgets/gtkmenutooltogglebutton.cpp:405:55: style: Parameter 'menu' can be declared with const [constParameter] head xournalpp-1.1.1/src/model/Layer.cpp:35:19: style: Variable 'elem2' can be declared as pointer to const [constVariable] head xournalpp-1.1.1/src/model/Layer.cpp:52:19: style: Variable 'elem2' can be declared as pointer to const [constVariable] head xournalpp-1.1.1/src/model/Layer.cpp:74:30: style: Parameter 'e' can be declared as pointer to const [constParameter] 2.8 xournalpp-1.1.1/src/model/Layer.cpp:74:30: style: Parameter 'e' can be declared with const [constParameter] head xournalpp-1.1.1/src/model/XojPage.cpp:50:34: style: Parameter 'layer' can be declared as pointer to const [constParameter] 2.8 xournalpp-1.1.1/src/model/XojPage.cpp:50:34: style: Parameter 'layer' can be declared with const [constParameter] head xournalpp-1.1.1/src/undo/EraseUndoAction.cpp:45:44: style: Parameter 'element' can be declared as pointer to const [constParameter] 2.8 xournalpp-1.1.1/src/undo/EraseUndoAction.cpp:45:44: style: Parameter 'element' can be declared with const [constParameter] head xournalpp-1.1.1/src/undo/FontUndoAction.cpp:12:43: style: Parameter 'oldFont' can be declared as reference to const [constParameter] 2.8 xournalpp-1.1.1/src/undo/FontUndoAction.cpp:12:43: style: Parameter 'oldFont' can be declared with const [constParameter] head xournalpp-1.1.1/src/undo/FontUndoAction.cpp:12:61: style: Parameter 'newFont' can be declared as reference to const [constParameter] 2.8 xournalpp-1.1.1/src/undo/FontUndoAction.cpp:12:61: style: Parameter 'newFont' can be declared with const [constParameter] head xournalpp-1.1.1/src/undo/MoveUndoAction.cpp:11:102: style: Parameter 'selected' can be declared as pointer to const [constParameter] 2.8 xournalpp-1.1.1/src/undo/MoveUndoAction.cpp:11:102: style: Parameter 'selected' can be declared with const [constParameter] head xournalpp-1.1.1/src/undo/RecognizerUndoAction.cpp:32:18: style: Variable 's2' can be declared as pointer to const [constVariable] head xournalpp-1.1.1/src/undo/RotateUndoAction.cpp:9:80: style: Parameter 'elements' can be declared as pointer to const [constParameter] 2.8 xournalpp-1.1.1/src/undo/RotateUndoAction.cpp:9:80: style: Parameter 'elements' can be declared with const [constParameter] head xournalpp-1.1.1/src/undo/ScaleUndoAction.cpp:11:78: style: Parameter 'elements' can be declared as pointer to const [constParameter] 2.8 xournalpp-1.1.1/src/undo/ScaleUndoAction.cpp:11:78: style: Parameter 'elements' can be declared with const [constParameter] head xournalpp-1.1.1/src/util/PlaceholderString.cpp:137:54: style: Parameter 'ps' can be declared as reference to const [constParameter] 2.8 xournalpp-1.1.1/src/util/PlaceholderString.cpp:137:54: style: Parameter 'ps' can be declared with const [constParameter] head xournalpp-1.1.1/src/util/audio/PortAudioConsumer.cpp:140:42: style: Variable 'e' can be declared as reference to const [constVariable] head xournalpp-1.1.1/src/view/background/MainBackgroundPainter.cpp:24:16: style: Variable 'e' can be declared as reference to const [constVariable] DONE