2022-06-20 13:10 ftp://ftp.de.debian.org/debian/pool/main/x/xjig/xjig_2.4.orig.tar.gz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j1 platform: Linux-5.4.0-120-generic-x86_64-with-glibc2.29 python: 3.8.10 client-version: 1.3.24 compiler: g++ (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0 cppcheck: head 2.8 head-info: ff50a01 (2022-06-20 09:17:11 +0200) count: 193 192 elapsed-time: 23.4 33.4 head-timing-info: Tokenizer::simplifyTokens1: 7.47119s (avg. 0.622599s - 12 result(s)) Tokenizer::simplifyTokens1::ValueFlow: 7.19871s (avg. 0.599893s - 12 result(s)) Tokenizer::simplifyTokens1::createSymbolDatabase: 0.115832s (avg. 0.00965267s - 12 result(s)) Tokenizer::createTokens: 0.039225s (avg. 0.00326875s - 12 result(s)) Other::runChecks: 0.030452s (avg. 0.00253767s - 12 result(s)) Overall time: 15.0502s old-timing-info: Tokenizer::simplifyTokens1: 10.732s (avg. 0.894334s - 12 result(s)) Tokenizer::simplifyTokens1::ValueFlow: 10.448s (avg. 0.870664s - 12 result(s)) Tokenizer::simplifyTokens1::createSymbolDatabase: 0.122987s (avg. 0.0102489s - 12 result(s)) Other::runChecks: 0.044121s (avg. 0.00367675s - 12 result(s)) Tokenizer::createTokens: 0.040112s (avg. 0.00334267s - 12 result(s)) Overall time: 21.592s head results: xjig-2.4.orig/color_mapper.H:11:12: style:inconclusive: Technically the member function 'ColorMapper::get_colormap' can be const. [functionConst] xjig-2.4.orig/color_mapper.C:21:2: warning: Class 'ColorMapper' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] xjig-2.4.orig/color_mapper.C:21:2: warning: Class 'ColorMapper' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] xjig-2.4.orig/color_mapper.C:149:2: warning: Class 'Port' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] xjig-2.4.orig/color_mapper.C:149:2: warning: Class 'Port' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] xjig-2.4.orig/color_mapper.H:6:3: style: Class 'ColorMapper' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xjig-2.4.orig/color_mapper.H:27:3: style: Class 'Port' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xjig-2.4.orig/color_mapper.C:10:35: style:inconclusive: Function 'ColorMapper' argument 1 names different: declaration 'dpy' definition 'dpy_in'. [funcArgNamesDifferent] xjig-2.4.orig/color_mapper.H:6:24: note: Function 'ColorMapper' argument 1 names different: declaration 'dpy' definition 'dpy_in'. xjig-2.4.orig/color_mapper.C:10:35: note: Function 'ColorMapper' argument 1 names different: declaration 'dpy' definition 'dpy_in'. xjig-2.4.orig/color_mapper.C:82:48: style:inconclusive: Function 'alloc_color' argument 1 names different: declaration 'col' definition 'def'. [funcArgNamesDifferent] xjig-2.4.orig/color_mapper.H:9:38: note: Function 'alloc_color' argument 1 names different: declaration 'col' definition 'def'. xjig-2.4.orig/color_mapper.C:82:48: note: Function 'alloc_color' argument 1 names different: declaration 'col' definition 'def'. xjig-2.4.orig/color_mapper.C:147:21: style:inconclusive: Function 'Port' argument 1 names different: declaration 'dpy' definition 'dpy_in'. [funcArgNamesDifferent] xjig-2.4.orig/color_mapper.H:27:17: note: Function 'Port' argument 1 names different: declaration 'dpy' definition 'dpy_in'. xjig-2.4.orig/color_mapper.C:147:21: note: Function 'Port' argument 1 names different: declaration 'dpy' definition 'dpy_in'. xjig-2.4.orig/gif_image.H:39:15: style:inconclusive: Technically the member function 'GifImage::Name' can be const. [functionConst] xjig-2.4.orig/gif_image.H:40:7: style:inconclusive: Technically the member function 'GifImage::Width' can be const. [functionConst] xjig-2.4.orig/gif_image.H:41:7: style:inconclusive: Technically the member function 'GifImage::Height' can be const. [functionConst] xjig-2.4.orig/gif_image.H:42:15: style:inconclusive: Technically the member function 'GifImage::Data' can be const. [functionConst] xjig-2.4.orig/gif_image.H:44:15: style:inconclusive: Technically the member function 'GifImage::GetExtensionData' can be const. [functionConst] xjig-2.4.orig/gif_image.C:94:23: note: Technically the member function 'GifImage::GetExtensionData' can be const. xjig-2.4.orig/gif_image.H:44:15: note: Technically the member function 'GifImage::GetExtensionData' can be const. xjig-2.4.orig/gif_image.H:61:7: performance:inconclusive: Technically the member function 'GifImage::ReadImageData' can be static (but you may consider moving to unnamed namespace). [functionStatic] xjig-2.4.orig/gif_image.C:375:15: note: Technically the member function 'GifImage::ReadImageData' can be static (but you may consider moving to unnamed namespace). xjig-2.4.orig/gif_image.H:61:7: note: Technically the member function 'GifImage::ReadImageData' can be static (but you may consider moving to unnamed namespace). xjig-2.4.orig/gif_image.H:85:7: style:inconclusive: Technically the member function 'GifImage::GetNCols' can be const. [functionConst] xjig-2.4.orig/gif_image.H:17:20: warning: Class 'Extension' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] xjig-2.4.orig/gif_image.H:17:20: warning: Class 'Extension' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] xjig-2.4.orig/gif_image.C:70:2: warning: Class 'GifImage' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] xjig-2.4.orig/gif_image.C:70:2: warning: Class 'GifImage' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] xjig-2.4.orig/gif_image.H:35:3: style: Class 'GifImage' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xjig-2.4.orig/gif_image.C:317:8: error: Resource leak: fp [resourceLeak] xjig-2.4.orig/gif_image.C:80:9: style: C-style pointer casting [cstyleCast] xjig-2.4.orig/gif_image.C:145:16: style: C-style pointer casting [cstyleCast] xjig-2.4.orig/gif_image.C:186:17: style: C-style pointer casting [cstyleCast] xjig-2.4.orig/gif_image.C:314:18: style: C-style pointer casting [cstyleCast] xjig-2.4.orig/gif_image.C:315:18: style: C-style pointer casting [cstyleCast] xjig-2.4.orig/gif_image.C:320:14: style: C-style pointer casting [cstyleCast] xjig-2.4.orig/gif_image.C:391:17: style: C-style pointer casting [cstyleCast] xjig-2.4.orig/gif_image.C:541:15: style: C-style pointer casting [cstyleCast] xjig-2.4.orig/gif_image.C:654:6: style: The scope of the variable 'RawCode' can be reduced. [variableScope] xjig-2.4.orig/gif_image.C:161:27: style:inconclusive: Function 'AddAt' argument 1 names different: declaration 'x' definition 'x21'. [funcArgNamesDifferent] xjig-2.4.orig/gif_image.H:55:19: note: Function 'AddAt' argument 1 names different: declaration 'x' definition 'x21'. xjig-2.4.orig/gif_image.C:161:27: note: Function 'AddAt' argument 1 names different: declaration 'x' definition 'x21'. xjig-2.4.orig/gif_image.C:161:36: style:inconclusive: Function 'AddAt' argument 2 names different: declaration 'y' definition 'y21'. [funcArgNamesDifferent] xjig-2.4.orig/gif_image.H:55:26: note: Function 'AddAt' argument 2 names different: declaration 'y' definition 'y21'. xjig-2.4.orig/gif_image.C:161:36: note: Function 'AddAt' argument 2 names different: declaration 'y' definition 'y21'. xjig-2.4.orig/gif_image.C:161:57: style:inconclusive: Function 'AddAt' argument 3 names different: declaration 'gif2' definition 'gif_p'. [funcArgNamesDifferent] xjig-2.4.orig/gif_image.H:55:45: note: Function 'AddAt' argument 3 names different: declaration 'gif2' definition 'gif_p'. xjig-2.4.orig/gif_image.C:161:57: note: Function 'AddAt' argument 3 names different: declaration 'gif2' definition 'gif_p'. xjig-2.4.orig/gif_image.C:234:30: warning: Function 'GetSize' argument order different: declaration 'h, w' definition 'w, h' [funcArgOrderDifferent] xjig-2.4.orig/gif_image.H:45:22: note: Function 'GetSize' argument order different: declaration 'h, w' definition 'w, h' xjig-2.4.orig/gif_image.C:234:30: note: Function 'GetSize' argument order different: declaration 'h, w' definition 'w, h' xjig-2.4.orig/gif_image.C:130:13: error: Uninitialized variable: mapper [uninitvar] xjig-2.4.orig/gif_image.C:114:12: note: Assuming condition is false xjig-2.4.orig/gif_image.C:130:13: note: Uninitialized variable: mapper xjig-2.4.orig/gif_image.C:431:3: style: Variable 'b' is assigned a value that is never used. [unreadVariable] xjig-2.4.orig/gif_image.C:435:7: style: Variable 'b' is assigned a value that is never used. [unreadVariable] xjig-2.4.orig/gifx_image.C:123:2: performance: Variable 'pixmap' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] xjig-2.4.orig/gifx_image.H:12:9: style:inconclusive: Technically the member function 'GifXImage::XWidth' can be const. [functionConst] xjig-2.4.orig/gifx_image.H:13:9: style:inconclusive: Technically the member function 'GifXImage::XHeight' can be const. [functionConst] xjig-2.4.orig/gifx_image.H:14:8: style:inconclusive: Technically the member function 'GifXImage::GetXSize' can be const. [functionConst] xjig-2.4.orig/gifx_image.H:58:8: style:inconclusive: Technically the member function 'GifPixmap::IsTwinPixmap' can be const. [functionConst] xjig-2.4.orig/gifx_image.C:52:3: warning: %ld in format string (no. 5) requires 'long' but the argument type is 'unsigned long'. [invalidPrintfArgType_sint] xjig-2.4.orig/reset_image.H:37:5: style: C-style pointer casting [cstyleCast] xjig-2.4.orig/reset_image.H:89:17: style: C-style pointer casting [cstyleCast] xjig-2.4.orig/imgbuff.C:9:14: warning: Member variable 'ImageBuffer::width' is not initialized in the constructor. [uninitMemberVar] xjig-2.4.orig/imgbuff.C:9:14: warning: Member variable 'ImageBuffer::height' is not initialized in the constructor. [uninitMemberVar] xjig-2.4.orig/imgbuff.C:66:14: style: C-style pointer casting [cstyleCast] xjig-2.4.orig/vec2.h:61:3: warning:inconclusive: Member variable 'Vec2::x_val' is not initialized in the constructor. [uninitMemberVar] xjig-2.4.orig/vec2.h:61:3: warning:inconclusive: Member variable 'Vec2::y_val' is not initialized in the constructor. [uninitMemberVar] xjig-2.4.orig/real.h:172:3: style: Class 'FunTab' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xjig-2.4.orig/mat2.C:37:24: style:inconclusive: Function 'Split' argument 1 names different: declaration 'sh' definition 'sh_p'. [funcArgNamesDifferent] xjig-2.4.orig/mat2.h:133:25: note: Function 'Split' argument 1 names different: declaration 'sh' definition 'sh_p'. xjig-2.4.orig/mat2.C:37:24: note: Function 'Split' argument 1 names different: declaration 'sh' definition 'sh_p'. xjig-2.4.orig/mat2.C:37:36: style:inconclusive: Function 'Split' argument 2 names different: declaration 'sx' definition 'sx_p'. [funcArgNamesDifferent] xjig-2.4.orig/mat2.h:133:35: note: Function 'Split' argument 2 names different: declaration 'sx' definition 'sx_p'. xjig-2.4.orig/mat2.C:37:36: note: Function 'Split' argument 2 names different: declaration 'sx' definition 'sx_p'. xjig-2.4.orig/mat2.C:37:48: style:inconclusive: Function 'Split' argument 3 names different: declaration 'sy' definition 'sy_p'. [funcArgNamesDifferent] xjig-2.4.orig/mat2.h:133:45: note: Function 'Split' argument 3 names different: declaration 'sy' definition 'sy_p'. xjig-2.4.orig/mat2.C:37:48: note: Function 'Split' argument 3 names different: declaration 'sy' definition 'sy_p'. xjig-2.4.orig/mat2.C:37:60: style:inconclusive: Function 'Split' argument 4 names different: declaration 'angle' definition 'angle_p'. [funcArgNamesDifferent] xjig-2.4.orig/mat2.h:133:55: note: Function 'Split' argument 4 names different: declaration 'angle' definition 'angle_p'. xjig-2.4.orig/mat2.C:37:60: note: Function 'Split' argument 4 names different: declaration 'angle' definition 'angle_p'. xjig-2.4.orig/mat2.C:37:75: style:inconclusive: Function 'Split' argument 5 names different: declaration 'mx' definition 'tx_p'. [funcArgNamesDifferent] xjig-2.4.orig/mat2.h:133:68: note: Function 'Split' argument 5 names different: declaration 'mx' definition 'tx_p'. xjig-2.4.orig/mat2.C:37:75: note: Function 'Split' argument 5 names different: declaration 'mx' definition 'tx_p'. xjig-2.4.orig/mat2.C:37:87: style:inconclusive: Function 'Split' argument 6 names different: declaration 'my' definition 'ty_p'. [funcArgNamesDifferent] xjig-2.4.orig/mat2.h:133:78: note: Function 'Split' argument 6 names different: declaration 'my' definition 'ty_p'. xjig-2.4.orig/mat2.C:37:87: note: Function 'Split' argument 6 names different: declaration 'my' definition 'ty_p'. xjig-2.4.orig/mat2.C:54:9: style: Variable 'cosa' is assigned a value that is never used. [unreadVariable] xjig-2.4.orig/objects.C:78:18: warning: Member variable 'PieceFrameSetup::left' is not initialized in the constructor. [uninitMemberVar] xjig-2.4.orig/objects.C:78:18: warning: Member variable 'PieceFrameSetup::pin' is not initialized in the constructor. [uninitMemberVar] xjig-2.4.orig/objects.C:163:15: warning: Member variable 'RotatedFrame::windir' is not initialized in the constructor. [uninitMemberVar] xjig-2.4.orig/objects.C:382:12: warning: Member variable 'FlipFrame::mangle' is not initialized in the constructor. [uninitMemberVar] xjig-2.4.orig/objects.C:428:14: warning: Member variable 'BitmapPiece::winx' is not initialized in the constructor. [uninitMemberVar] xjig-2.4.orig/objects.C:428:14: warning: Member variable 'BitmapPiece::winy' is not initialized in the constructor. [uninitMemberVar] xjig-2.4.orig/objects.C:428:14: warning: Member variable 'BitmapPiece::offx' is not initialized in the constructor. [uninitMemberVar] xjig-2.4.orig/objects.C:428:14: warning: Member variable 'BitmapPiece::offy' is not initialized in the constructor. [uninitMemberVar] xjig-2.4.orig/objects.C:428:14: warning: Member variable 'BitmapPiece::width' is not initialized in the constructor. [uninitMemberVar] xjig-2.4.orig/objects.C:428:14: warning: Member variable 'BitmapPiece::height' is not initialized in the constructor. [uninitMemberVar] xjig-2.4.orig/objects.C:429:2: performance: Variable 'tilemask' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] xjig-2.4.orig/objects.C:521:2: performance: Variable 'tilemap' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] xjig-2.4.orig/objects.C:599:2: performance: Variable 'shadowmap' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] xjig-2.4.orig/objects.C:679:2: performance: Variable 'swin' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] xjig-2.4.orig/objects.H:100:19: style:inconclusive: Technically the member function 'PieceFrame::GetPolyLine' can be const. [functionConst] xjig-2.4.orig/objects.H:101:15: style:inconclusive: Technically the member function 'PieceFrame::Center' can be const. [functionConst] xjig-2.4.orig/objects.H:110:7: style:inconclusive: Technically the member function 'PieceFrame::same_point' can be const. [functionConst] xjig-2.4.orig/objects.H:154:15: style:inconclusive: Technically the member function 'RotatedFrame::GetPos' can be const. [functionConst] xjig-2.4.orig/objects.H:168:8: style:inconclusive: Technically the member function 'RotatedFrame::GetDir' can be const. [functionConst] xjig-2.4.orig/objects.H:215:10: style:inconclusive: Technically the member function 'BitmapPiece::GetBitmap' can be const. [functionConst] xjig-2.4.orig/objects.H:238:10: style:inconclusive: Technically the member function 'PixmapPiece::GetPixmap' can be const. [functionConst] xjig-2.4.orig/objects.H:259:10: style:inconclusive: Technically the member function 'ShadowedPiece::GetPixmap' can be const. [functionConst] xjig-2.4.orig/objects.H:262:7: performance:inconclusive: Technically the member function 'ShadowedPiece::ShadowSize' can be static (but you may consider moving to unnamed namespace). [functionStatic] xjig-2.4.orig/objects.H:330:8: style:inconclusive: Technically the member function 'DBPieceObject::StoreExtent' can be const. [functionConst] xjig-2.4.orig/objects.C:921:21: note: Technically the member function 'DBPieceObject::StoreExtent' can be const. xjig-2.4.orig/objects.H:330:8: note: Technically the member function 'DBPieceObject::StoreExtent' can be const. xjig-2.4.orig/objects.H:331:8: style:inconclusive: Technically the member function 'DBPieceObject::JoinExtent' can be const. [functionConst] xjig-2.4.orig/objects.C:944:21: note: Technically the member function 'DBPieceObject::JoinExtent' can be const. xjig-2.4.orig/objects.H:331:8: note: Technically the member function 'DBPieceObject::JoinExtent' can be const. xjig-2.4.orig/puzzle.H:29:7: style:inconclusive: Technically the member function 'Grid::Width' can be const. [functionConst] xjig-2.4.orig/puzzle.H:30:7: style:inconclusive: Technically the member function 'Grid::Height' can be const. [functionConst] xjig-2.4.orig/puzzle.H:57:7: style:inconclusive: Technically the member function 'Puzzle::Finished' can be const. [functionConst] xjig-2.4.orig/vec2list.h:21:3: style: Class 'Vec2List' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] xjig-2.4.orig/stack.H:91:8: style: The function 'ExposeRegion' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/stack.H:56:16: note: Virtual function in base class xjig-2.4.orig/stack.H:91:8: note: Function in derived class xjig-2.4.orig/stack.H:105:8: style: The function 'ExposeWindowRegion' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/stack.H:57:16: note: Virtual function in base class xjig-2.4.orig/stack.H:105:8: note: Function in derived class xjig-2.4.orig/stack.H:107:16: style: The function 'Raise' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/stack.H:59:16: note: Virtual function in base class xjig-2.4.orig/stack.H:107:16: note: Function in derived class xjig-2.4.orig/stack.H:109:8: style: The function 'DispatchPress' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/stack.H:63:16: note: Virtual function in base class xjig-2.4.orig/stack.H:109:8: note: Function in derived class xjig-2.4.orig/stack.H:110:8: style: The function 'DispatchRelease' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/stack.H:64:16: note: Virtual function in base class xjig-2.4.orig/stack.H:110:8: note: Function in derived class xjig-2.4.orig/stack.H:111:8: style: The function 'DispatchMotion' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/stack.H:65:16: note: Virtual function in base class xjig-2.4.orig/stack.H:111:8: note: Function in derived class xjig-2.4.orig/objects.H:171:16: style: The function 'PositionChanged' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/objects.H:103:16: note: Virtual function in base class xjig-2.4.orig/objects.H:171:16: note: Function in derived class xjig-2.4.orig/objects.H:172:16: style: The function 'DirectionChanged' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/objects.H:104:16: note: Virtual function in base class xjig-2.4.orig/objects.H:172:16: note: Function in derived class xjig-2.4.orig/objects.H:213:16: style: The function 'PositionChanged' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/objects.H:171:16: note: Virtual function in base class xjig-2.4.orig/objects.H:213:16: note: Function in derived class xjig-2.4.orig/objects.H:214:16: style: The function 'DirectionChanged' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/objects.H:172:16: note: Virtual function in base class xjig-2.4.orig/objects.H:214:16: note: Function in derived class xjig-2.4.orig/objects.H:237:16: style: The function 'DirectionChanged' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/objects.H:214:16: note: Virtual function in base class xjig-2.4.orig/objects.H:237:16: note: Function in derived class xjig-2.4.orig/objects.H:258:16: style: The function 'DirectionChanged' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/objects.H:237:16: note: Virtual function in base class xjig-2.4.orig/objects.H:258:16: note: Function in derived class xjig-2.4.orig/objects.H:281:16: style: The function 'PositionChanged' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/objects.H:213:16: note: Virtual function in base class xjig-2.4.orig/objects.H:281:16: note: Function in derived class xjig-2.4.orig/objects.H:282:16: style: The function 'DirectionChanged' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/objects.H:258:16: note: Virtual function in base class xjig-2.4.orig/objects.H:282:16: note: Function in derived class xjig-2.4.orig/objects.H:299:15: style: The function 'Intersects' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/stack.H:28:15: note: Virtual function in base class xjig-2.4.orig/objects.H:299:15: note: Function in derived class xjig-2.4.orig/objects.H:300:15: style: The function 'IsInside' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/stack.H:29:15: note: Virtual function in base class xjig-2.4.orig/objects.H:300:15: note: Function in derived class xjig-2.4.orig/objects.H:301:16: style: The function 'ExposeRegion' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/stack.H:25:16: note: Virtual function in base class xjig-2.4.orig/objects.H:301:16: note: Function in derived class xjig-2.4.orig/objects.H:302:16: style: The function 'ExposeWindowRegion' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/stack.H:26:16: note: Virtual function in base class xjig-2.4.orig/objects.H:302:16: note: Function in derived class xjig-2.4.orig/objects.H:304:16: style: The function 'PanView' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/stack.H:35:16: note: Virtual function in base class xjig-2.4.orig/objects.H:304:16: note: Function in derived class xjig-2.4.orig/objects.H:305:16: style: The function 'ZoomView' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/stack.H:36:16: note: Virtual function in base class xjig-2.4.orig/objects.H:305:16: note: Function in derived class xjig-2.4.orig/objects.H:328:7: style: The function 'JoinExtent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/stack.H:37:15: note: Virtual function in base class xjig-2.4.orig/objects.H:328:7: note: Function in derived class xjig-2.4.orig/objects.H:329:7: style: The function 'GetExtent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/stack.H:38:15: note: Virtual function in base class xjig-2.4.orig/objects.H:329:7: note: Function in derived class xjig-2.4.orig/objects.H:345:16: style: The function 'DispatchPress' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/stack.H:31:16: note: Virtual function in base class xjig-2.4.orig/objects.H:345:16: note: Function in derived class xjig-2.4.orig/objects.H:346:16: style: The function 'DispatchRelease' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/stack.H:32:16: note: Virtual function in base class xjig-2.4.orig/objects.H:346:16: note: Function in derived class xjig-2.4.orig/objects.H:347:16: style: The function 'DispatchMotion' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/stack.H:33:16: note: Virtual function in base class xjig-2.4.orig/objects.H:347:16: note: Function in derived class xjig-2.4.orig/objects.C:568:7: style: Condition 'page' is always false [knownConditionTrueFalse] xjig-2.4.orig/objects.C:566:23: note: Assuming that condition '!page' is not redundant xjig-2.4.orig/objects.C:568:7: note: Condition 'page' is always false xjig-2.4.orig/rotate.H:87:17: style: C-style pointer casting [cstyleCast] xjig-2.4.orig/rotate.H:90:17: style: C-style pointer casting [cstyleCast] xjig-2.4.orig/rotate.H:93:17: style: C-style pointer casting [cstyleCast] xjig-2.4.orig/rotate.H:96:17: style: C-style pointer casting [cstyleCast] xjig-2.4.orig/rotate.H:105:31: style: C-style pointer casting [cstyleCast] xjig-2.4.orig/rotate.H:141:29: style: C-style pointer casting [cstyleCast] xjig-2.4.orig/rotate.H:142:29: style: C-style pointer casting [cstyleCast] xjig-2.4.orig/objects.C:1083:24: style: C-style pointer casting [cstyleCast] xjig-2.4.orig/objects.C:738:45: style:inconclusive: Function 'Intersects' argument 3 names different: declaration 'width' definition 'w'. [funcArgNamesDifferent] xjig-2.4.orig/objects.H:299:42: note: Function 'Intersects' argument 3 names different: declaration 'width' definition 'w'. xjig-2.4.orig/objects.C:738:45: note: Function 'Intersects' argument 3 names different: declaration 'width' definition 'w'. xjig-2.4.orig/objects.C:738:51: style:inconclusive: Function 'Intersects' argument 4 names different: declaration 'height' definition 'h'. [funcArgNamesDifferent] xjig-2.4.orig/objects.H:299:52: note: Function 'Intersects' argument 4 names different: declaration 'height' definition 'h'. xjig-2.4.orig/objects.C:738:51: note: Function 'Intersects' argument 4 names different: declaration 'height' definition 'h'. xjig-2.4.orig/objects.C:768:32: style:inconclusive: Function 'PanView' argument 1 names different: declaration 'offx' definition 'ox'. [funcArgNamesDifferent] xjig-2.4.orig/objects.H:304:29: note: Function 'PanView' argument 1 names different: declaration 'offx' definition 'ox'. xjig-2.4.orig/objects.C:768:32: note: Function 'PanView' argument 1 names different: declaration 'offx' definition 'ox'. xjig-2.4.orig/objects.C:768:40: style:inconclusive: Function 'PanView' argument 2 names different: declaration 'offy' definition 'oy'. [funcArgNamesDifferent] xjig-2.4.orig/objects.H:304:39: note: Function 'PanView' argument 2 names different: declaration 'offy' definition 'oy'. xjig-2.4.orig/objects.C:768:40: note: Function 'PanView' argument 2 names different: declaration 'offy' definition 'oy'. xjig-2.4.orig/objects.C:928:37: style:inconclusive: Function 'JoinExtent' argument 1 names different: declaration 'x1' definition 'xx1'. [funcArgNamesDifferent] xjig-2.4.orig/objects.H:328:24: note: Function 'JoinExtent' argument 1 names different: declaration 'x1' definition 'xx1'. xjig-2.4.orig/objects.C:928:37: note: Function 'JoinExtent' argument 1 names different: declaration 'x1' definition 'xx1'. xjig-2.4.orig/objects.C:928:47: style:inconclusive: Function 'JoinExtent' argument 2 names different: declaration 'y1' definition 'yy1'. [funcArgNamesDifferent] xjig-2.4.orig/objects.H:328:33: note: Function 'JoinExtent' argument 2 names different: declaration 'y1' definition 'yy1'. xjig-2.4.orig/objects.C:928:47: note: Function 'JoinExtent' argument 2 names different: declaration 'y1' definition 'yy1'. xjig-2.4.orig/objects.C:928:57: style:inconclusive: Function 'JoinExtent' argument 3 names different: declaration 'x2' definition 'xx2'. [funcArgNamesDifferent] xjig-2.4.orig/objects.H:328:42: note: Function 'JoinExtent' argument 3 names different: declaration 'x2' definition 'xx2'. xjig-2.4.orig/objects.C:928:57: note: Function 'JoinExtent' argument 3 names different: declaration 'x2' definition 'xx2'. xjig-2.4.orig/objects.C:928:67: style:inconclusive: Function 'JoinExtent' argument 4 names different: declaration 'y2' definition 'yy2'. [funcArgNamesDifferent] xjig-2.4.orig/objects.H:328:51: note: Function 'JoinExtent' argument 4 names different: declaration 'y2' definition 'yy2'. xjig-2.4.orig/objects.C:928:67: note: Function 'JoinExtent' argument 4 names different: declaration 'y2' definition 'yy2'. xjig-2.4.orig/objects.C:936:36: style:inconclusive: Function 'GetExtent' argument 1 names different: declaration 'x1' definition 'xx1'. [funcArgNamesDifferent] xjig-2.4.orig/objects.H:329:23: note: Function 'GetExtent' argument 1 names different: declaration 'x1' definition 'xx1'. xjig-2.4.orig/objects.C:936:36: note: Function 'GetExtent' argument 1 names different: declaration 'x1' definition 'xx1'. xjig-2.4.orig/objects.C:936:46: style:inconclusive: Function 'GetExtent' argument 2 names different: declaration 'y1' definition 'yy1'. [funcArgNamesDifferent] xjig-2.4.orig/objects.H:329:32: note: Function 'GetExtent' argument 2 names different: declaration 'y1' definition 'yy1'. xjig-2.4.orig/objects.C:936:46: note: Function 'GetExtent' argument 2 names different: declaration 'y1' definition 'yy1'. xjig-2.4.orig/objects.C:936:56: style:inconclusive: Function 'GetExtent' argument 3 names different: declaration 'x2' definition 'xx2'. [funcArgNamesDifferent] xjig-2.4.orig/objects.H:329:41: note: Function 'GetExtent' argument 3 names different: declaration 'x2' definition 'xx2'. xjig-2.4.orig/objects.C:936:56: note: Function 'GetExtent' argument 3 names different: declaration 'x2' definition 'xx2'. xjig-2.4.orig/objects.C:936:66: style:inconclusive: Function 'GetExtent' argument 4 names different: declaration 'y2' definition 'yy2'. [funcArgNamesDifferent] xjig-2.4.orig/objects.H:329:50: note: Function 'GetExtent' argument 4 names different: declaration 'y2' definition 'yy2'. xjig-2.4.orig/objects.C:936:66: note: Function 'GetExtent' argument 4 names different: declaration 'y2' definition 'yy2'. xjig-2.4.orig/rotate.H:119:15: style: Local variable 'dx' shadows outer variable [shadowVariable] xjig-2.4.orig/global.h:81:12: note: Shadowed declaration xjig-2.4.orig/rotate.H:119:15: note: Shadow variable xjig-2.4.orig/rotate.H:120:15: style: Local variable 'dy' shadows outer variable [shadowVariable] xjig-2.4.orig/global.h:82:12: note: Shadowed declaration xjig-2.4.orig/rotate.H:120:15: note: Shadow variable xjig-2.4.orig/puzzle.C:8:7: warning: Member variable 'Grid::width' is not initialized in the constructor. [uninitMemberVar] xjig-2.4.orig/puzzle.C:8:7: warning: Member variable 'Grid::height' is not initialized in the constructor. [uninitMemberVar] xjig-2.4.orig/puzzle.C:8:7: warning: Member variable 'Grid::max_width' is not initialized in the constructor. [uninitMemberVar] xjig-2.4.orig/puzzle.C:8:7: warning: Member variable 'Grid::max_height' is not initialized in the constructor. [uninitMemberVar] xjig-2.4.orig/puzzle.C:8:7: warning: Member variable 'Grid::p' is not initialized in the constructor. [uninitMemberVar] xjig-2.4.orig/puzzle.C:47:9: warning: Member variable 'Puzzle::width' is not initialized in the constructor. [uninitMemberVar] xjig-2.4.orig/puzzle.C:47:9: warning: Member variable 'Puzzle::height' is not initialized in the constructor. [uninitMemberVar] xjig-2.4.orig/puzzle.C:47:9: warning: Member variable 'Puzzle::p' is not initialized in the constructor. [uninitMemberVar] xjig-2.4.orig/puzzle.C:81:8: warning: %x in format string (no. 1) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int] xjig-2.4.orig/puzzle.C:81:8: warning: %x in format string (no. 2) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int] xjig-2.4.orig/puzzle.C:81:8: warning: %x in format string (no. 3) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int] xjig-2.4.orig/puzzle.C:81:8: warning: %x in format string (no. 4) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int] xjig-2.4.orig/puzzle.C:137:8: warning: %x in format string (no. 1) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int] xjig-2.4.orig/puzzle.C:137:8: warning: %x in format string (no. 2) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int] xjig-2.4.orig/puzzle.C:137:8: warning: %x in format string (no. 3) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int] xjig-2.4.orig/puzzle.C:137:8: warning: %x in format string (no. 4) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int] xjig-2.4.orig/real.C:21:2: warning: Class 'FunTab' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] xjig-2.4.orig/real.C:21:2: warning: Class 'FunTab' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] xjig-2.4.orig/real.C:14:48: style:inconclusive: Function 'FunTab' argument 2 names different: declaration 'from' definition 'from_in'. [funcArgNamesDifferent] xjig-2.4.orig/real.h:172:41: note: Function 'FunTab' argument 2 names different: declaration 'from' definition 'from_in'. xjig-2.4.orig/real.C:14:48: note: Function 'FunTab' argument 2 names different: declaration 'from' definition 'from_in'. xjig-2.4.orig/real.C:14:64: style:inconclusive: Function 'FunTab' argument 3 names different: declaration 'to' definition 'to_in'. [funcArgNamesDifferent] xjig-2.4.orig/real.h:172:58: note: Function 'FunTab' argument 3 names different: declaration 'to' definition 'to_in'. xjig-2.4.orig/real.C:14:64: note: Function 'FunTab' argument 3 names different: declaration 'to' definition 'to_in'. xjig-2.4.orig/real.C:14:75: style:inconclusive: Function 'FunTab' argument 4 names different: declaration 'step' definition 'step_in'. [funcArgNamesDifferent] xjig-2.4.orig/real.h:172:72: note: Function 'FunTab' argument 4 names different: declaration 'step' definition 'step_in'. xjig-2.4.orig/real.C:14:75: note: Function 'FunTab' argument 4 names different: declaration 'step' definition 'step_in'. xjig-2.4.orig/stack.C:21:9: warning: Member variable 'Object::mystack' is not initialized in the constructor. [uninitMemberVar] xjig-2.4.orig/stack.C:64:14: warning: Member variable 'ObjectStack::close_sel' is not initialized in the constructor. [uninitMemberVar] xjig-2.4.orig/stack.C:69:2: performance: Variable 'dbmap' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] xjig-2.4.orig/stack.H:67:8: style:inconclusive: Technically the member function 'ObjectStack::PanView' can be const. [functionConst] xjig-2.4.orig/stack.C:128:19: note: Technically the member function 'ObjectStack::PanView' can be const. xjig-2.4.orig/stack.H:67:8: note: Technically the member function 'ObjectStack::PanView' can be const. xjig-2.4.orig/stack.H:68:8: style:inconclusive: Technically the member function 'ObjectStack::ZoomView' can be const. [functionConst] xjig-2.4.orig/stack.C:134:19: note: Technically the member function 'ObjectStack::ZoomView' can be const. xjig-2.4.orig/stack.H:68:8: note: Technically the member function 'ObjectStack::ZoomView' can be const. xjig-2.4.orig/stack.H:69:8: style:inconclusive: Technically the member function 'ObjectStack::GetExtent' can be const. [functionConst] xjig-2.4.orig/stack.C:145:19: note: Technically the member function 'ObjectStack::GetExtent' can be const. xjig-2.4.orig/stack.H:69:8: note: Technically the member function 'ObjectStack::GetExtent' can be const. xjig-2.4.orig/stack.C:274:22: style: C-style pointer casting [cstyleCast] xjig-2.4.orig/stack.C:226:38: style:inconclusive: Function 'ExposeRegion' argument 1 names different: declaration 'x1' definition 'x'. [funcArgNamesDifferent] xjig-2.4.orig/stack.H:91:26: note: Function 'ExposeRegion' argument 1 names different: declaration 'x1' definition 'x'. xjig-2.4.orig/stack.C:226:38: note: Function 'ExposeRegion' argument 1 names different: declaration 'x1' definition 'x'. xjig-2.4.orig/stack.C:226:45: style:inconclusive: Function 'ExposeRegion' argument 2 names different: declaration 'y1' definition 'y'. [funcArgNamesDifferent] xjig-2.4.orig/stack.H:91:34: note: Function 'ExposeRegion' argument 2 names different: declaration 'y1' definition 'y'. xjig-2.4.orig/stack.C:226:45: note: Function 'ExposeRegion' argument 2 names different: declaration 'y1' definition 'y'. xjig-2.4.orig/stack.C:247:58: style:inconclusive: Function 'ExposeWindowRegion' argument 2 names different: declaration 'x1' definition 'x'. [funcArgNamesDifferent] xjig-2.4.orig/stack.H:105:42: note: Function 'ExposeWindowRegion' argument 2 names different: declaration 'x1' definition 'x'. xjig-2.4.orig/stack.C:247:58: note: Function 'ExposeWindowRegion' argument 2 names different: declaration 'x1' definition 'x'. xjig-2.4.orig/stack.C:247:65: style:inconclusive: Function 'ExposeWindowRegion' argument 3 names different: declaration 'y1' definition 'y'. [funcArgNamesDifferent] xjig-2.4.orig/stack.H:105:50: note: Function 'ExposeWindowRegion' argument 3 names different: declaration 'y1' definition 'y'. xjig-2.4.orig/stack.C:247:65: note: Function 'ExposeWindowRegion' argument 3 names different: declaration 'y1' definition 'y'. xjig-2.4.orig/vec2.C:23:6: style: The scope of the variable 'l' can be reduced. [variableScope] xjig-2.4.orig/vec2.C:23:8: style: The scope of the variable 'u' can be reduced. [variableScope] xjig-2.4.orig/vec2.C:50:6: style: The scope of the variable 'l' can be reduced. [variableScope] xjig-2.4.orig/vec2.C:75:6: style: Local variable 'dx' shadows outer variable [shadowVariable] xjig-2.4.orig/global.h:81:12: note: Shadowed declaration xjig-2.4.orig/vec2.C:75:6: note: Shadow variable xjig-2.4.orig/vec2.C:76:6: style: Local variable 'dy' shadows outer variable [shadowVariable] xjig-2.4.orig/global.h:82:12: note: Shadowed declaration xjig-2.4.orig/vec2.C:76:6: note: Shadow variable xjig-2.4.orig/vec2list.C:162:5: style: The scope of the variable 'erg' can be reduced. [variableScope] xjig-2.4.orig/vec2list.C:12:25: style:inconclusive: Function 'Vec2List' argument 1 names different: declaration 'len' definition 'len_in'. [funcArgNamesDifferent] xjig-2.4.orig/vec2list.h:21:17: note: Function 'Vec2List' argument 1 names different: declaration 'len' definition 'len_in'. xjig-2.4.orig/vec2list.C:12:25: note: Function 'Vec2List' argument 1 names different: declaration 'len' definition 'len_in'. xjig-2.4.orig/vec2list.C:53:37: style:inconclusive: Function 'SetAt' argument 1 names different: declaration 'i' definition 'id'. [funcArgNamesDifferent] xjig-2.4.orig/vec2list.h:37:30: note: Function 'SetAt' argument 1 names different: declaration 'i' definition 'id'. xjig-2.4.orig/vec2list.C:53:37: note: Function 'SetAt' argument 1 names different: declaration 'i' definition 'id'. xjig-2.4.orig/vec2list.C:60:37: style:inconclusive: Function 'AddAt' argument 1 names different: declaration 'i' definition 'id'. [funcArgNamesDifferent] xjig-2.4.orig/vec2list.h:38:30: note: Function 'AddAt' argument 1 names different: declaration 'i' definition 'id'. xjig-2.4.orig/vec2list.C:60:37: note: Function 'AddAt' argument 1 names different: declaration 'i' definition 'id'. xjig-2.4.orig/vec2list.C:75:35: style:inconclusive: Function 'Del' argument 1 names different: declaration 'i' definition 'id'. [funcArgNamesDifferent] xjig-2.4.orig/vec2list.h:39:28: note: Function 'Del' argument 1 names different: declaration 'i' definition 'id'. xjig-2.4.orig/vec2list.C:75:35: note: Function 'Del' argument 1 names different: declaration 'i' definition 'id'. xjig-2.4.orig/vec2list.C:84:41: style:inconclusive: Function 'DelRange' argument 1 names different: declaration 'i' definition 'from'. [funcArgNamesDifferent] xjig-2.4.orig/vec2list.h:40:33: note: Function 'DelRange' argument 1 names different: declaration 'i' definition 'from'. xjig-2.4.orig/vec2list.C:84:41: note: Function 'DelRange' argument 1 names different: declaration 'i' definition 'from'. xjig-2.4.orig/vec2list.C:84:51: style:inconclusive: Function 'DelRange' argument 2 names different: declaration 'j' definition 'to'. [funcArgNamesDifferent] xjig-2.4.orig/vec2list.h:40:40: note: Function 'DelRange' argument 2 names different: declaration 'j' definition 'to'. xjig-2.4.orig/vec2list.C:84:51: note: Function 'DelRange' argument 2 names different: declaration 'j' definition 'to'. xjig-2.4.orig/vec2list.C:84:60: style:inconclusive: Function 'DelRange' argument 3 names different: declaration 'erg' definition 'start'. [funcArgNamesDifferent] xjig-2.4.orig/vec2list.h:40:48: note: Function 'DelRange' argument 3 names different: declaration 'erg' definition 'start'. xjig-2.4.orig/vec2list.C:84:60: note: Function 'DelRange' argument 3 names different: declaration 'erg' definition 'start'. xjig-2.4.orig/vec2list.C:106:53: style:inconclusive: Function 'operator=' argument 1 names different: declaration 'v' definition 'vl'. [funcArgNamesDifferent] xjig-2.4.orig/vec2list.h:31:45: note: Function 'operator=' argument 1 names different: declaration 'v' definition 'vl'. xjig-2.4.orig/vec2list.C:106:53: note: Function 'operator=' argument 1 names different: declaration 'v' definition 'vl'. xjig-2.4.orig/xjig.C:694:16: error: Buffer is accessed out of bounds: buffer [bufferAccessOutOfBounds] xjig-2.4.orig/xjig.C:245:16: style: The function 'ExposeRegion' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/stack.H:25:16: note: Virtual function in base class xjig-2.4.orig/xjig.C:245:16: note: Function in derived class xjig-2.4.orig/xjig.C:246:16: style: The function 'ZoomView' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] xjig-2.4.orig/stack.H:36:16: note: Virtual function in base class xjig-2.4.orig/xjig.C:246:16: note: Function in derived class xjig-2.4.orig/xjig.C:650:4: warning: %x in format string (no. 1) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int] xjig-2.4.orig/xjig.C:650:4: warning: %x in format string (no. 2) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int] xjig-2.4.orig/xjig.C:689:7: warning: %ld in format string (no. 1) requires 'long' but the argument type is 'unsigned long'. [invalidPrintfArgType_sint] xjig-2.4.orig/xjig.C:689:7: warning: %ld in format string (no. 2) requires 'long' but the argument type is 'unsigned long'. [invalidPrintfArgType_sint] xjig-2.4.orig/xjig.C:694:7: warning: %ld in format string (no. 1) requires 'long' but the argument type is 'unsigned long'. [invalidPrintfArgType_sint] xjig-2.4.orig/xjig.C:694:7: warning: %ld in format string (no. 2) requires 'long' but the argument type is 'unsigned long'. [invalidPrintfArgType_sint] xjig-2.4.orig/xjig.C:154:10: style: Variable 'nfound' is assigned a value that is never used. [unreadVariable] diff: head xjig-2.4.orig/vec2list.h:21:3: style: Class 'Vec2List' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] DONE