2024-04-14 02:45 ftp://ftp.de.debian.org/debian/pool/main/x/x2goclient/x2goclient_4.1.2.3.orig.tar.gz cppcheck-options: --library=posix --library=gnu --library=bsd --library=qt --library=motif --inconclusive --enable=style,information --inline-suppr --template=daca2 --disable=missingInclude --suppress=unmatchedSuppression --check-library --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning -D__GNUC__ --platform=unix64 -j4 platform: Linux-6.1.0-18-amd64-x86_64-with-glibc2.36 python: 3.11.2 client-version: 1.3.56 compiler: g++ (Debian 12.2.0-14) 12.2.0 cppcheck: head 2.13.0 head-info: 01c049d (2024-04-13 21:28:19 +0200) count: 731 381 elapsed-time: 6.5 6.1 head-timing-info: old-timing-info: head results: x2goclient-4.1.2.3/portable/stopu3client.cpp:35:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WM_CLOSE [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.h:134:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CaseInsensitive [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/SVGFrame.cpp:36:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/InteractionDialog.cpp:50:70: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Mid [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/SVGFrame.cpp:69:11: warning: Member variable 'SVGFrame::renderer' is not initialized in the constructor. [uninitMemberVar] x2goclient-4.1.2.3/src/SVGFrame.cpp:69:11: warning: Member variable 'SVGFrame::drawImg' is not initialized in the constructor. [uninitMemberVar] x2goclient-4.1.2.3/src/LDAPSession.h:31:43: performance: Variable 'err_type' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] x2goclient-4.1.2.3/src/LDAPSession.h:31:57: performance: Variable 'err_str' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] x2goclient-4.1.2.3/src/LDAPSession.h:42:15: style:inconclusive: Technically the member function 'ByteArray::getData' can be const. [functionConst] x2goclient-4.1.2.3/src/LDAPSession.h:43:10: style:inconclusive: Technically the member function 'ByteArray::asString' can be const. [functionConst] x2goclient-4.1.2.3/src/LDAPSession.h:44:7: style:inconclusive: Technically the member function 'ByteArray::length' can be const. [functionConst] x2goclient-4.1.2.3/src/sshmasterconnection.h:49:10: style:inconclusive: Technically the member function 'ChannelConnection::operator==' can be const. [functionConst] x2goclient-4.1.2.3/src/onmainwindow.h:111:10: style:inconclusive: Technically the member function 'serv::operator<' can be const. [functionConst] x2goclient-4.1.2.3/src/SVGFrame.h:33:3: style: Class 'SVGFrame' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] x2goclient-4.1.2.3/src/onmainwindow.h:245:5: style: Class 'SessTreeView' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] x2goclient-4.1.2.3/src/onmainwindow.h:323:5: style: Class 'ONMainWindow' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] x2goclient-4.1.2.3/src/sshmasterconnection.h:109:13: performance: Function 'getHost()' should return member 'host' by const reference. [returnByReference] x2goclient-4.1.2.3/src/sshmasterconnection.h:113:13: performance: Function 'getUser()' should return member 'user' by const reference. [returnByReference] x2goclient-4.1.2.3/src/onmainwindow.h:351:13: performance: Function 'retLdapServer()' should return member 'ldapServer' by const reference. [returnByReference] x2goclient-4.1.2.3/src/onmainwindow.h:359:13: performance: Function 'retLdapDn()' should return member 'ldapDn' by const reference. [returnByReference] x2goclient-4.1.2.3/src/onmainwindow.h:363:13: performance: Function 'retLdapServer1()' should return member 'ldapServer1' by const reference. [returnByReference] x2goclient-4.1.2.3/src/onmainwindow.h:371:13: performance: Function 'retLdapServer2()' should return member 'ldapServer2' by const reference. [returnByReference] x2goclient-4.1.2.3/src/onmainwindow.h:392:20: performance: Function 'getHomeDirectory()' should return member 'homeDir' by const reference. [returnByReference] x2goclient-4.1.2.3/src/onmainwindow.h:404:13: performance: Function 'getCardLogin()' should return member 'cardLogin' by const reference. [returnByReference] x2goclient-4.1.2.3/src/onmainwindow.h:408:13: performance: Function 'getDefaultCmd()' should return member 'defaultCmd' by const reference. [returnByReference] x2goclient-4.1.2.3/src/onmainwindow.h:412:13: performance: Function 'getDefaultSshPort()' should return member 'defaultSshPort' by const reference. [returnByReference] x2goclient-4.1.2.3/src/onmainwindow.h:416:13: performance: Function 'getDefaultClipboardMode()' should return member 'defaultClipboardMode' by const reference. [returnByReference] x2goclient-4.1.2.3/src/onmainwindow.h:420:13: performance: Function 'getDefaultKbdType()' should return member 'defaultKbdType' by const reference. [returnByReference] x2goclient-4.1.2.3/src/onmainwindow.h:424:17: performance: Function 'getDefaultLayout()' should return member 'defaultLayout' by const reference. [returnByReference] x2goclient-4.1.2.3/src/onmainwindow.h:428:13: performance: Function 'getDefaultPack()' should return member 'defaultPack' by const reference. [returnByReference] x2goclient-4.1.2.3/src/onmainwindow.h:484:20: performance: Function 'getSessionConf()' should return member 'sessionCfg' by const reference. [returnByReference] x2goclient-4.1.2.3/src/onmainwindow.h:560:17: performance: Function 'internApplicationsNames()' should return member '_internApplicationsNames' by const reference. [returnByReference] x2goclient-4.1.2.3/src/onmainwindow.h:564:17: performance: Function 'transApplicationsNames()' should return member '_transApplicationsNames' by const reference. [returnByReference] x2goclient-4.1.2.3/src/appdialog.cpp:48:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable treeWidget [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/appdialog.cpp:86:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable treeWidget [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/appdialog.cpp:162:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable treeWidget [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/appdialog.cpp:185:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UserRole [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/appdialog.cpp:194:65: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UserRole [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/LDAPSession.h:31:24: performance: Function parameter 'type' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/LDAPSession.h:31:36: performance: Function parameter 'str' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.h:102:52: performance: Function parameter 'dst' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.h:111:41: performance: Function parameter 'it' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.h:115:40: performance: Function parameter 'it' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.h:115:62: performance: Function parameter 'it1' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.h:1024:47: performance: Function parameter 'file_name_start' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.h:49:40: style: Parameter 't' can be declared as reference to const [constParameterReference] x2goclient-4.1.2.3/src/appdialog.h:30:5: style: Class 'AppDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] x2goclient-4.1.2.3/src/LDAPSession.cpp:85:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LDAP_OPT_PROTOCOL_VERSION [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/brokerpassdlg.cpp:24:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/LDAPSession.cpp:124:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LDAPMod [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/brokerpassdlg.cpp:44:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/LDAPSession.cpp:173:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LDAPMod [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/LDAPSession.cpp:210:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LDAP_SUCCESS [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/LDAPSession.cpp:232:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LDAP_SCOPE_SUBTREE [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/LDAPSession.cpp:299:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LDAP_SCOPE_SUBTREE [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/brokerpassdlg.h:29:5: style: Class 'BrokerPassDlg' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] x2goclient-4.1.2.3/src/clicklineedit.h:30:3: style: Class 'ClickLineEdit' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] x2goclient-4.1.2.3/src/configwidget.cpp:25:2: performance: Variable 'sessionId' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] x2goclient-4.1.2.3/src/configwidget.cpp:21:57: style:inconclusive: Function 'ConfigWidget' argument 2 names different: declaration 'mv' definition 'mw'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/configwidget.h:31:45: note: Function 'ConfigWidget' argument 2 names different: declaration 'mv' definition 'mw'. x2goclient-4.1.2.3/src/configwidget.cpp:21:57: note: Function 'ConfigWidget' argument 2 names different: declaration 'mv' definition 'mw'. x2goclient-4.1.2.3/src/configwidget.cpp:21:38: performance: Function parameter 'id' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/configdialog.cpp:262:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/connectionwidget.cpp:40:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Horizontal [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/connectionwidget.cpp:102:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/x2gosettings.h:30:5: style: Class 'X2goSettings' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] x2goclient-4.1.2.3/src/connectionwidget.cpp:33:46: performance: Function parameter 'id' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/contest.cpp:64:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Retry [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/contest.cpp:101:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable green [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/contest.cpp:131:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable green [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/contest.cpp:147:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SocketTimeoutError [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/contest.cpp:184:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SocketTimeoutError [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/cupsprint.cpp:44:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable name [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/cupsprint.cpp:133:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/cupsprint.cpp:256:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable choice1 [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/cupsprintersettingsdialog.cpp:48:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RestoreDefaults [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/cupsprintersettingsdialog.cpp:102:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Type [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/cupsprintersettingsdialog.cpp:217:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Type [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/cupsprintersettingsdialog.cpp:34:2: performance: Variable 'printer' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] x2goclient-4.1.2.3/src/cupsprintersettingsdialog.cpp:47:12: style: C-style pointer casting [cstyleCast] x2goclient-4.1.2.3/src/cupsprintersettingsdialog.cpp:50:12: style: C-style pointer casting [cstyleCast] x2goclient-4.1.2.3/src/cupsprintersettingsdialog.cpp:53:12: style: C-style pointer casting [cstyleCast] x2goclient-4.1.2.3/src/cupsprintersettingsdialog.cpp:56:12: style: C-style pointer casting [cstyleCast] x2goclient-4.1.2.3/src/cupsprintersettingsdialog.cpp:70:17: performance: Function parameter 'optionKeyword' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/cupsprintersettingsdialog.cpp:332:32: warning: Either the condition 'vals.size()1' is redundant or size of 'args' can be 2. Expression 'args[2]' causes access out of bounds. [containerOutOfBounds] x2goclient-4.1.2.3/src/ongetpass.cpp:64:23: note: Assuming that condition 'args.count()>1' is not redundant x2goclient-4.1.2.3/src/ongetpass.cpp:69:26: note: Access out of bounds x2goclient-4.1.2.3/src/ongetpass.cpp:70:29: warning: Either the condition 'args.count()>1' is redundant or size of 'args' can be 2. Expression 'args[4]' causes access out of bounds. [containerOutOfBounds] x2goclient-4.1.2.3/src/ongetpass.cpp:64:23: note: Assuming that condition 'args.count()>1' is not redundant x2goclient-4.1.2.3/src/ongetpass.cpp:70:29: note: Access out of bounds x2goclient-4.1.2.3/src/ongetpass.cpp:72:26: warning: Either the condition 'args.count()>1' is redundant or size of 'args' can be 2. Expression 'args[6]' causes access out of bounds. [containerOutOfBounds] x2goclient-4.1.2.3/src/ongetpass.cpp:64:23: note: Assuming that condition 'args.count()>1' is not redundant x2goclient-4.1.2.3/src/ongetpass.cpp:72:26: note: Access out of bounds x2goclient-4.1.2.3/src/httpbrokerclient.cpp:1018:12: style: Obsolete function 'QString::sprintf' called. It is recommended to use 'QString::asprintf', 'QString::arg' or 'QTextStream' instead. [prohibitedsprintfCalled] x2goclient-4.1.2.3/src/httpbrokerclient.cpp:985:9: style: C-style pointer casting [cstyleCast] x2goclient-4.1.2.3/src/httpbrokerclient.cpp:992:32: style: C-style pointer casting [cstyleCast] x2goclient-4.1.2.3/src/httpbrokerclient.cpp:814:45: style:inconclusive: Function 'parseSession' argument 1 names different: declaration 'sInfo' definition 'sinfo'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/httpbrokerclient.h:73:31: note: Function 'parseSession' argument 1 names different: declaration 'sInfo' definition 'sinfo'. x2goclient-4.1.2.3/src/httpbrokerclient.cpp:814:45: note: Function 'parseSession' argument 1 names different: declaration 'sInfo' definition 'sinfo'. x2goclient-4.1.2.3/src/httpbrokerclient.cpp:851:21: style: Local variable 'lst' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/httpbrokerclient.cpp:819:17: note: Shadowed declaration x2goclient-4.1.2.3/src/httpbrokerclient.cpp:851:21: note: Shadow variable x2goclient-4.1.2.3/src/httpbrokerclient.cpp:153:66: performance: Function parameter 'sshMessage' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/httpbrokerclient.cpp:814:45: performance: Function parameter 'sinfo' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/httpbrokerclient.cpp:867:5: performance: Range variable 'sline' should be declared as const reference. [iterateByValue] x2goclient-4.1.2.3/src/httpbrokerclient.cpp:1024:65: performance: Function parameter 'error' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/httpbrokerclient.cpp:1024:80: performance: Function parameter 'lastSessionError' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/printdialog.cpp:28:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/printdialog.cpp:47:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/httpbrokerclient.cpp:615:9: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] x2goclient-4.1.2.3/src/httpbrokerclient.cpp:754:13: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] x2goclient-4.1.2.3/src/httpbrokerclient.cpp:870:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] x2goclient-4.1.2.3/src/printdialog.h:31:3: style: Class 'PrintDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] x2goclient-4.1.2.3/src/printdialog.cpp:33:4: style: C-style pointer casting [cstyleCast] x2goclient-4.1.2.3/src/printdialog.cpp:25:37: style:inconclusive: Function 'PrintDialog' argument 1 names different: declaration 'par' definition 'parent'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/printdialog.h:31:26: note: Function 'PrintDialog' argument 1 names different: declaration 'par' definition 'parent'. x2goclient-4.1.2.3/src/printdialog.cpp:25:37: note: Function 'PrintDialog' argument 1 names different: declaration 'par' definition 'parent'. x2goclient-4.1.2.3/src/printprocess.cpp:76:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NormalExit [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/printprocess.cpp:108:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Rejected [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/printprocess.cpp:141:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FailedToStart [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/printprocess.cpp:193:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FailedToStart [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/help.cpp:264:13: style: The comparison '0 != terminal_cols' is always false. [knownConditionTrueFalse] x2goclient-4.1.2.3/src/help.cpp:227:31: note: 'terminal_cols' is assigned value '0' here. x2goclient-4.1.2.3/src/help.cpp:264:13: note: The comparison '0 != terminal_cols' is always false. x2goclient-4.1.2.3/src/help.cpp:291:15: style: The comparison '0 != terminal_cols' is always false. [knownConditionTrueFalse] x2goclient-4.1.2.3/src/help.cpp:227:31: note: 'terminal_cols' is assigned value '0' here. x2goclient-4.1.2.3/src/help.cpp:291:15: note: The comparison '0 != terminal_cols' is always false. x2goclient-4.1.2.3/src/printwidget.cpp:36:20: style: C-style pointer casting [cstyleCast] x2goclient-4.1.2.3/src/printprocess.cpp:44:14: style: C-style pointer casting [cstyleCast] x2goclient-4.1.2.3/src/help.cpp:224:13: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] x2goclient-4.1.2.3/src/help.cpp:262:27: style: Variable 'cur_len' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/printprocess.cpp:38:38: performance: Function parameter 'pdf' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/printprocess.cpp:38:51: performance: Function parameter 'title' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/userbutton.h:30:1: debug: SymbolDatabase couldn't resolve all user defined types. [debug] x2goclient-4.1.2.3/src/sessionexplorer.cpp:51:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoFocus [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionexplorer.cpp:188:67: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ElideLeft [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionexplorer.cpp:205:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Accepted [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionexplorer.cpp:220:69: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IniFormat [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionexplorer.cpp:242:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Accepted [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionexplorer.cpp:260:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Yes [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionexplorer.cpp:501:83: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionexplorer.cpp:521:83: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionexplorer.cpp:542:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable No [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionexplorer.cpp:584:95: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionexplorer.cpp:593:70: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionexplorer.cpp:599:55: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionexplorer.cpp:613:55: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SmoothTransformation [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionexplorer.cpp:644:69: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IniFormat [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionexplorer.cpp:663:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionexplorer.cpp:739:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionexplorer.cpp:762:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/pulsemanager.cpp:196:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Starting [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/pulsemanager.cpp:228:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Running [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/pulsemanager.cpp:369:69: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/pulsemanager.cpp:635:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/pulsemanager.cpp:693:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/pulsemanager.cpp:817:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NotRunning [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/pulsemanager.cpp:823:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Running [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionbutton.cpp:52:70: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Mid [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionbutton.cpp:377:60: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IniFormat [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionbutton.cpp:763:78: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WindingFill [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionbutton.cpp:894:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TextSingleLine [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionexplorer.cpp:400:5: style: Obsolete function 'qSort' called. It is recommended to use 'std::sort' instead. [prohibitedqSortCalled] x2goclient-4.1.2.3/src/sessionexplorer.cpp:401:5: style: Obsolete function 'qSort' called. It is recommended to use 'std::sort' instead. [prohibitedqSortCalled] x2goclient-4.1.2.3/src/sessionexplorer.cpp:266:31: style: C-style pointer casting [cstyleCast] x2goclient-4.1.2.3/src/sessionexplorer.cpp:224:17: style: Local variable 'folders' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/sessionexplorer.h:89:26: note: Shadowed declaration x2goclient-4.1.2.3/src/sessionexplorer.cpp:224:17: note: Shadow variable x2goclient-4.1.2.3/src/sessionexplorer.cpp:566:17: style: Local variable 'currentPath' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/sessionexplorer.h:99:13: note: Shadowed declaration x2goclient-4.1.2.3/src/sessionexplorer.cpp:566:17: note: Shadow variable x2goclient-4.1.2.3/src/sessionexplorer.cpp:705:17: style: Local variable 'folders' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/sessionexplorer.h:89:26: note: Shadowed declaration x2goclient-4.1.2.3/src/sessionexplorer.cpp:705:17: note: Shadow variable x2goclient-4.1.2.3/src/sessionexplorer.cpp:721:17: style: Local variable 'sessions' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/sessionexplorer.h:88:27: note: Shadowed declaration x2goclient-4.1.2.3/src/sessionexplorer.cpp:721:17: note: Shadow variable x2goclient-4.1.2.3/src/sessionexplorer.cpp:109:50: performance: Function parameter 'slst' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sessionexplorer.cpp:562:44: performance: Function parameter 'path' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sessionexplorer.cpp:580:41: performance: Function parameter 'path' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sessionexplorer.cpp:640:47: performance: Function parameter 'path' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sessionexplorer.cpp:102:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] x2goclient-4.1.2.3/src/sessionexplorer.cpp:632:13: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] x2goclient-4.1.2.3/src/sessionexplorer.cpp:744:9: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] x2goclient-4.1.2.3/src/sessionexplorer.cpp:753:9: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] x2goclient-4.1.2.3/src/sessionbutton.h:46:13: performance: Function 'name()' should return member 'nameofSession' by const reference. [returnByReference] x2goclient-4.1.2.3/src/sessionbutton.cpp:381:13: style: Local variable 'name' shadows outer function [shadowFunction] x2goclient-4.1.2.3/src/sessionbutton.h:46:13: note: Shadowed declaration x2goclient-4.1.2.3/src/sessionbutton.cpp:381:13: note: Shadow variable x2goclient-4.1.2.3/src/sessionbutton.cpp:435:13: style: Local variable 'sessIcon' shadows outer function [shadowFunction] x2goclient-4.1.2.3/src/sessionbutton.h:42:20: note: Shadowed declaration x2goclient-4.1.2.3/src/sessionbutton.cpp:435:13: note: Shadow variable x2goclient-4.1.2.3/src/sessionbutton.cpp:606:13: style: Local variable 'id' shadows outer function [shadowFunction] x2goclient-4.1.2.3/src/sessionbutton.h:38:13: note: Shadowed declaration x2goclient-4.1.2.3/src/sessionbutton.cpp:606:13: note: Shadow variable x2goclient-4.1.2.3/src/sessionbutton.cpp:910:13: style: Local variable 'cmd' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/sessionbutton.h:88:13: note: Shadowed declaration x2goclient-4.1.2.3/src/sessionbutton.cpp:910:13: note: Shadow variable x2goclient-4.1.2.3/src/sessionbutton.cpp:44:74: performance: Function parameter 'id' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sessionmanagedialog.cpp:112:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable StyledPanel [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionmanagedialog.cpp:161:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UserRole [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionmanagedialog.cpp:177:81: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionmanagedialog.cpp:205:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UserRole [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionmanagedialog.cpp:235:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UserRole [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionmanagedialog.cpp:250:75: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UserRole [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionmanagedialog.cpp:259:75: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UserRole [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionmanagedialog.cpp:268:75: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UserRole [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionmanagedialog.h:36:5: style: Class 'SessionManageDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] x2goclient-4.1.2.3/src/sessionmanagedialog.cpp:61:10: style: C-style pointer casting [cstyleCast] x2goclient-4.1.2.3/src/sessionmanagedialog.cpp:118:15: style: C-style pointer casting [cstyleCast] x2goclient-4.1.2.3/src/sessionmanagedialog.cpp:167:72: performance: Function parameter 'path' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sessionwidget.cpp:72:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable StyledPanel [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionwidget.cpp:287:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionwidget.cpp:394:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionwidget.cpp:417:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionwidget.cpp:509:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Normal [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionwidget.cpp:522:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionwidget.cpp:802:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionwidget.cpp:824:78: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sessionwidget.cpp:957:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Accepted [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/settingswidget.cpp:107:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable debugging [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/settingswidget.cpp:330:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FramelessWindowHint [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/settingswidget.cpp:370:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sessionId [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/settingswidget.cpp:533:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sessionId [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/settingswidget.cpp:343:14: style: Redundant initialization for 'x_pos'. The initialized value is overwritten before it is read. [redundantInitialization] x2goclient-4.1.2.3/src/settingswidget.cpp:341:18: note: x_pos is initialized x2goclient-4.1.2.3/src/settingswidget.cpp:343:14: note: x_pos is overwritten x2goclient-4.1.2.3/src/settingswidget.cpp:601:13: style: Local variable 'height' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/settingswidget.h:59:15: note: Shadowed declaration x2goclient-4.1.2.3/src/settingswidget.cpp:601:13: note: Shadow variable x2goclient-4.1.2.3/src/settingswidget.cpp:602:13: style: Local variable 'width' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/settingswidget.h:58:15: note: Shadowed declaration x2goclient-4.1.2.3/src/settingswidget.cpp:602:13: note: Shadow variable x2goclient-4.1.2.3/src/settingswidget.cpp:37:42: performance: Function parameter 'id' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sessionwidget.cpp:41:76: style:inconclusive: Function 'SessionWidget' argument 3 names different: declaration 'mv' definition 'mw'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/sessionwidget.h:38:65: note: Function 'SessionWidget' argument 3 names different: declaration 'mv' definition 'mw'. x2goclient-4.1.2.3/src/sessionwidget.cpp:41:76: note: Function 'SessionWidget' argument 3 names different: declaration 'mv' definition 'mw'. x2goclient-4.1.2.3/src/sessionwidget.cpp:41:57: performance: Function parameter 'id' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sharewidget.cpp:56:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoEditTriggers [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sharewidget.cpp:158:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sharewidget.cpp:200:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sharewidget.cpp:215:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sessionId [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sharewidget.cpp:301:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sessionId [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sharewidget.cpp:331:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sharewidget.cpp:126:23: style: C-style pointer casting [cstyleCast] x2goclient-4.1.2.3/src/sharewidget.cpp:39:36: performance: Function parameter 'id' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:62:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:299:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WindowStaysOnTopHint [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:363:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:676:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WriteOnly [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:875:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Plain [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:1051:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:1078:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Accepted [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:1109:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:1165:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AlignLeft [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:1355:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:1480:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Running [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:1625:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:1649:68: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:1729:61: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:1882:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Password [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:1963:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:2083:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CaseInsensitive [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:2148:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:2259:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Accepted [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:2367:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:2504:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Accepted [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:2594:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:2768:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CaseInsensitive [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:2812:61: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IniFormat [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:3073:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:3257:135: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:3285:84: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:3330:56: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Yes [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:3448:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:3485:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:3542:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:3804:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:3844:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:4059:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:4301:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IniFormat [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:4338:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:4784:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:5049:60: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IniFormat [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:5164:75: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ISODate [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:5295:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:5439:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:5542:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:5619:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:5655:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:5704:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:6180:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:6483:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:6513:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:6708:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CrashExit [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:6791:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Running [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:6910:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WriteOnly [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:7176:60: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable No [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:7213:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable No [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:7244:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:7472:60: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IniFormat [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:7673:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:7703:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:7871:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CaseInsensitive [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:8507:53: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:8528:53: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:8546:53: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:8566:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:8642:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:8670:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:8735:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:8817:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:8903:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Accepted [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:9018:64: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IniFormat [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:9158:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:9199:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:9282:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadUser [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:9357:61: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadUser [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:9440:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:9538:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:9656:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:9682:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:9735:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Running [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:9749:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:9832:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:9889:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:10206:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:10284:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:10294:72: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:10307:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:10497:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Files [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:10533:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Files [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:10545:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Files [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:11099:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WriteOnly [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:11479:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:11677:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Running [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:12050:67: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IniFormat [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:12587:70: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Mid [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:12779:70: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Mid [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:12957:70: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Mid [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:13241:67: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:13274:67: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:13285:58: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:13296:58: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:13331:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ToolButtonIconOnly [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:13361:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ToolButtonTextUnderIcon [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:13428:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Checked [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:13587:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Files [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:13671:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoError [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/onmainwindow.cpp:13758:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sshprocess.cpp:71:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Running [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sshprocess.cpp:128:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sshprocess.cpp:387:135: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sshprocess.cpp:551:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NormalExit [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sshprocess.h:43:13: performance: Function 'getSource()' should return member 'scpSource' by const reference. [returnByReference] x2goclient-4.1.2.3/src/sshprocess.cpp:111:41: style: C-style pointer casting [cstyleCast] x2goclient-4.1.2.3/src/sshprocess.cpp:143:28: style: C-style pointer casting [cstyleCast] x2goclient-4.1.2.3/src/sshprocess.cpp:125:21: style: Checking if unsigned expression 'serverSocket' is less than zero. [unsignedLessThanZero] x2goclient-4.1.2.3/src/sshprocess.cpp:308:35: performance: Function parameter 'src' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshprocess.cpp:437:61: performance: Function parameter 'data' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshprocess.cpp:463:61: performance: Function parameter 'data' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshprocess.cpp:471:57: performance: Function parameter 'message' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshprocess.cpp:484:59: performance: Function parameter 'message' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshprocess.cpp:484:76: performance: Function parameter 'sshSessionErr' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshprocess.cpp:504:71: performance: Function parameter 'error' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshprocess.cpp:512:65: performance: Function parameter 'uuid' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:199:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:301:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:314:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SSH_AGAIN [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:366:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AF_INET [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:537:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SSH_LOG_NOLOG [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:779:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SSH_OPTIONS_HOST [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:905:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SSH_SERVER_ERROR [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:989:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1084:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1205:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SSH_AUTH_METHOD_INTERACTIVE [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1272:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SSH_AUTH_SUCCESS [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1377:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1578:82: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1646:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1840:90: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1908:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:2112:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:2258:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SHUT_RDWR [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/userbutton.cpp:32:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoFocus [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/userbutton.cpp:29:5: performance: Variable 'user' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] x2goclient-4.1.2.3/src/userbutton.cpp:30:5: performance: Variable 'fname' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] x2goclient-4.1.2.3/src/userbutton.cpp:31:5: performance: Variable 'image' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] x2goclient-4.1.2.3/src/userbutton.h:39:11: performance: Function 'username()' should return member 'user' by const reference. [returnByReference] x2goclient-4.1.2.3/src/userbutton.h:40:11: performance: Function 'fullName()' should return member 'fname' by const reference. [returnByReference] x2goclient-4.1.2.3/src/userbutton.cpp:24:54: style:inconclusive: Function 'UserButton' argument 2 names different: declaration 'parent' definition 'par'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/userbutton.h:34:44: note: Function 'UserButton' argument 2 names different: declaration 'parent' definition 'par'. x2goclient-4.1.2.3/src/userbutton.cpp:24:54: note: Function 'UserButton' argument 2 names different: declaration 'parent' definition 'par'. x2goclient-4.1.2.3/src/userbutton.cpp:24:67: style:inconclusive: Function 'UserButton' argument 3 names different: declaration 'username' definition 'name'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/userbutton.h:35:24: note: Function 'UserButton' argument 3 names different: declaration 'username' definition 'name'. x2goclient-4.1.2.3/src/userbutton.cpp:24:67: note: Function 'UserButton' argument 3 names different: declaration 'username' definition 'name'. x2goclient-4.1.2.3/src/userbutton.cpp:25:69: style:inconclusive: Function 'UserButton' argument 6 names different: declaration 'backGround' definition 'bgpal'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/userbutton.h:36:41: note: Function 'UserButton' argument 6 names different: declaration 'backGround' definition 'bgpal'. x2goclient-4.1.2.3/src/userbutton.cpp:25:69: note: Function 'UserButton' argument 6 names different: declaration 'backGround' definition 'bgpal'. x2goclient-4.1.2.3/src/userbutton.cpp:24:67: performance: Function parameter 'name' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/userbutton.cpp:25:34: performance: Function parameter 'fullName' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/userbutton.cpp:25:53: style: Parameter 'foto' can be declared as reference to const [constParameterReference] x2goclient-4.1.2.3/src/x2gosettings.cpp:44:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IniFormat [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/x2gosettings.cpp:33:5: warning: Class 'X2goSettings' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] x2goclient-4.1.2.3/src/x2gosettings.cpp:33:5: warning: Class 'X2goSettings' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] x2goclient-4.1.2.3/src/x2gosettings.cpp:26:36: performance: Function parameter 'fileContent' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/x2gosettings.cpp:38:38: performance: Function parameter 'group' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/pulsemanager.cpp:54:14: style: Error code from the return value of function pulse_dir_.cd() is not used. [ignoredReturnErrorCode] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1961:13: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled] x2goclient-4.1.2.3/src/pulsemanager.cpp:52:3: performance: Variable 'pulse_dir_' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:149:22: warning: Member variable 'SshMasterConnection::interactionInterrupt' is not initialized in the constructor. [uninitMemberVar] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:149:22: warning: Member variable 'SshMasterConnection::writeHostKey' is not initialized in the constructor. [uninitMemberVar] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:149:22: warning: Member variable 'SshMasterConnection::writeHostKeyReady' is not initialized in the constructor. [uninitMemberVar] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:149:22: warning: Member variable 'SshMasterConnection::keyPhraseReady' is not initialized in the constructor. [uninitMemberVar] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:149:22: warning: Member variable 'SshMasterConnection::disconnectSessionFlag' is not initialized in the constructor. [uninitMemberVar] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:149:22: warning: Member variable 'SshMasterConnection::localProxyPort' is not initialized in the constructor. [uninitMemberVar] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:149:22: warning: Member variable 'SshMasterConnection::challengeAuthPasswordAccepted' is not initialized in the constructor. [uninitMemberVar] x2goclient-4.1.2.3/src/pulsemanager.cpp:360:8: style: The scope of the variable 'stop_processing' can be reduced. [variableScope] x2goclient-4.1.2.3/src/pulsemanager.cpp:389:38: style: Local variable 'cit' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/pulsemanager.cpp:372:38: note: Shadowed declaration x2goclient-4.1.2.3/src/pulsemanager.cpp:389:38: note: Shadow variable x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1290:16: style: Condition 'ready' is always false [knownConditionTrueFalse] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1284:24: note: Assignment 'ready=false', assigned value is 0 x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1290:16: note: Condition 'ready' is always false x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1405:16: style: Condition 'ready' is always false [knownConditionTrueFalse] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1399:24: note: Assignment 'ready=false', assigned value is 0 x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1405:16: note: Condition 'ready' is always false x2goclient-4.1.2.3/src/pulsemanager.cpp:530:27: style: Variable 'stop_processing' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:197:13: style: C-style pointer casting [cstyleCast] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:376:42: style: C-style pointer casting [cstyleCast] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:152:60: style:inconclusive: Function 'SshMasterConnection' argument 16 names different: declaration 'proxyKey' definition 'proxykey'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/sshmasterconnection.h:89:104: note: Function 'SshMasterConnection' argument 16 names different: declaration 'proxyKey' definition 'proxykey'. x2goclient-4.1.2.3/src/sshmasterconnection.cpp:152:60: note: Function 'SshMasterConnection' argument 16 names different: declaration 'proxyKey' definition 'proxykey'. x2goclient-4.1.2.3/src/sshmasterconnection.cpp:153:14: style:inconclusive: Function 'SshMasterConnection' argument 17 names different: declaration 'proxyAutologin' definition 'proxyautologin'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/sshmasterconnection.h:90:30: note: Function 'SshMasterConnection' argument 17 names different: declaration 'proxyAutologin' definition 'proxyautologin'. x2goclient-4.1.2.3/src/sshmasterconnection.cpp:153:14: note: Function 'SshMasterConnection' argument 17 names different: declaration 'proxyAutologin' definition 'proxyautologin'. x2goclient-4.1.2.3/src/sshmasterconnection.cpp:2243:42: style:inconclusive: Function 'finalize' argument 1 names different: declaration 'arg1' definition 'item'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/sshmasterconnection.h:138:23: note: Function 'finalize' argument 1 names different: declaration 'arg1' definition 'item'. x2goclient-4.1.2.3/src/sshmasterconnection.cpp:2243:42: note: Function 'finalize' argument 1 names different: declaration 'arg1' definition 'item'. x2goclient-4.1.2.3/src/sshmasterconnection.cpp:344:9: style: Local variable 'port' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/sshmasterconnection.h:191:9: note: Shadowed declaration x2goclient-4.1.2.3/src/sshmasterconnection.cpp:344:9: note: Shadow variable x2goclient-4.1.2.3/src/x2goutils.cpp:106:85: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Ok [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/x2goutils.cpp:122:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Warning [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/x2goutils.cpp:126:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Critical [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:149:68: performance: Function parameter 'host' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:149:119: performance: Function parameter 'user' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:150:17: performance: Function parameter 'pass' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:150:31: performance: Function parameter 'key' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:151:48: performance: Function parameter 'proxyserver' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:152:17: performance: Function parameter 'proxylogin' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:152:37: performance: Function parameter 'proxypassword' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:152:60: performance: Function parameter 'proxykey' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:269:69: performance: Function parameter 'dst' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:440:111: performance: Function parameter 'prompt' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:444:112: performance: Function parameter 'output' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:449:63: performance: Function parameter 'err1' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:449:77: performance: Function parameter 'err2' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:455:76: performance: Function parameter 'err' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:460:61: performance: Function parameter 'err' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:476:68: performance: Function parameter 'output' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:977:54: performance: Function parameter 'code' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:984:63: performance: Function parameter 'prompt' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1312:48: performance: Function parameter 'phrase' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1619:56: performance: Function parameter 'text' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1782:89: performance: Function parameter 'forwardHost' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1783:17: performance: Function parameter 'localHost' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1800:79: performance: Function parameter 'uuid' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1800:93: performance: Function parameter 'cmd' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1819:73: performance: Function parameter 'src' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1819:86: performance: Function parameter 'dst' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:298:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1114:76: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] x2goclient-4.1.2.3/src/sshmasterconnection.cpp:390:37: error: Uninitialized variables: con.forwardPort, con.localPort [uninitvar] x2goclient-4.1.2.3/x2gohelper/x2gohelper.cpp:21:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PROCESS_TERMINATE [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/x2gohelper/x2gohelper.cpp:35:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TH32CS_SNAPPROCESS [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/x2gohelper/x2gohelper.cpp:77:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SYNCHRONIZE [valueFlowBailoutIncompleteVar] x2goclient-4.1.2.3/x2gohelper/x2gohelper.cpp:62:26: style: Parameter 'argv' can be declared as const array [constParameter] x2goclient-4.1.2.3/src/onmainwindow.cpp:1272:26: style:inconclusive: Boolean expression '!startHidden' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean] x2goclient-4.1.2.3/src/onmainwindow.cpp:8880:9: warning: Return value of function std::move() is not used. [ignoredReturnValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:414:9: style: Obsolete function 'qsrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqsrandCalled] x2goclient-4.1.2.3/src/onmainwindow.cpp:416:29: style: Obsolete function 'qrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqrandCalled] x2goclient-4.1.2.3/src/onmainwindow.cpp:2210:5: style: Obsolete function 'qSort' called. It is recommended to use 'std::sort' instead. [prohibitedqSortCalled] x2goclient-4.1.2.3/src/onmainwindow.cpp:7828:5: style: Obsolete function 'qSort' called. It is recommended to use 'std::sort' instead. [prohibitedqSortCalled] x2goclient-4.1.2.3/src/onmainwindow.cpp:8770:5: style: Obsolete function 'qSort' called. It is recommended to use 'std::sort' instead. [prohibitedqSortCalled] x2goclient-4.1.2.3/src/onmainwindow.cpp:28:19: warning:inconclusive: Member variable 'x2goSession::brokerUser' is not assigned a value in 'x2goSession::operator='. [operatorEqVarError] x2goclient-4.1.2.3/src/onmainwindow.cpp:28:19: warning: Member variable 'x2goSession::connectedSince' is not assigned a value in 'x2goSession::operator='. [operatorEqVarError] x2goclient-4.1.2.3/src/onmainwindow.cpp:28:19: warning:inconclusive: Member variable 'x2goSession::published' is not assigned a value in 'x2goSession::operator='. [operatorEqVarError] x2goclient-4.1.2.3/src/onmainwindow.cpp:28:19: warning: Member variable 'x2goSession::colorDepth' is not assigned a value in 'x2goSession::operator='. [operatorEqVarError] x2goclient-4.1.2.3/src/onmainwindow.cpp:28:19: warning:inconclusive: Member variable 'x2goSession::fullscreen' is not assigned a value in 'x2goSession::operator='. [operatorEqVarError] x2goclient-4.1.2.3/src/onmainwindow.cpp:1272:26: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] x2goclient-4.1.2.3/src/onmainwindow.cpp:2316:14: style: Condition '!embedMode' is always true [knownConditionTrueFalse] x2goclient-4.1.2.3/src/onmainwindow.cpp:2308:47: note: Assuming that condition 'embedMode' is not redundant x2goclient-4.1.2.3/src/onmainwindow.cpp:2316:14: note: Condition '!embedMode' is always true x2goclient-4.1.2.3/src/onmainwindow.cpp:6042:18: style: Condition 'sysPulse' is always false [knownConditionTrueFalse] x2goclient-4.1.2.3/src/onmainwindow.cpp:6012:27: note: Assignment 'sysPulse=false', assigned value is 0 x2goclient-4.1.2.3/src/onmainwindow.cpp:6042:18: note: Condition 'sysPulse' is always false x2goclient-4.1.2.3/src/onmainwindow.cpp:8615:13: style: Condition '!startHidden' is always true [knownConditionTrueFalse] x2goclient-4.1.2.3/src/onmainwindow.cpp:8611:9: note: Assuming that condition '!startHidden' is not redundant x2goclient-4.1.2.3/src/onmainwindow.cpp:8615:13: note: Condition '!startHidden' is always true x2goclient-4.1.2.3/src/onmainwindow.cpp:12026:10: style: Condition 'proxyWinId' is always false [knownConditionTrueFalse] x2goclient-4.1.2.3/src/onmainwindow.cpp:12024:27: note: Calling function 'findWindow' returns 0 x2goclient-4.1.2.3/src/onmainwindow.cpp:12024:27: note: Assignment 'proxyWinId=findWindow("X2GO-"+resumingSession.sessionId)', assigned value is 0 x2goclient-4.1.2.3/src/onmainwindow.cpp:12026:10: note: Condition 'proxyWinId' is always false x2goclient-4.1.2.3/src/onmainwindow.cpp:1985:5: style: Exception should be caught by reference. [catchExceptionByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:2168:5: style: Exception should be caught by reference. [catchExceptionByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:2545:5: style: Exception should be caught by reference. [catchExceptionByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:2561:13: style: Exception should be caught by reference. [catchExceptionByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:2578:21: style: Exception should be caught by reference. [catchExceptionByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:2649:5: style: Exception should be caught by reference. [catchExceptionByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:2694:5: style: Exception should be caught by reference. [catchExceptionByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:9532:5: style: Exception should be caught by reference. [catchExceptionByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:10384:16: warning: Either the condition '!dir' is redundant or there is possible null pointer dereference: dir. [nullPointerRedundantCheck] x2goclient-4.1.2.3/src/onmainwindow.cpp:10385:9: note: Assuming that condition '!dir' is not redundant x2goclient-4.1.2.3/src/onmainwindow.cpp:10384:16: note: Null pointer dereference x2goclient-4.1.2.3/src/onmainwindow.cpp:2204:37: style: C-style pointer casting [cstyleCast] x2goclient-4.1.2.3/src/onmainwindow.cpp:5199:28: style: C-style pointer casting [cstyleCast] x2goclient-4.1.2.3/src/onmainwindow.cpp:5548:15: style: C-style pointer casting [cstyleCast] x2goclient-4.1.2.3/src/onmainwindow.cpp:13083:24: style: C-style pointer casting [cstyleCast] x2goclient-4.1.2.3/src/onmainwindow.cpp:13089:24: style: C-style pointer casting [cstyleCast] x2goclient-4.1.2.3/src/onmainwindow.cpp:5733:16: style: Variable 'sndPort' is reassigned a value before the old one has been used. [redundantAssignment] x2goclient-4.1.2.3/src/onmainwindow.cpp:5720:12: note: sndPort is assigned x2goclient-4.1.2.3/src/onmainwindow.cpp:5733:16: note: sndPort is overwritten x2goclient-4.1.2.3/src/onmainwindow.cpp:1370:9: style: The scope of the variable 'usize' can be reduced. [variableScope] x2goclient-4.1.2.3/src/onmainwindow.cpp:2261:13: style: The scope of the variable 'i' can be reduced. [variableScope] x2goclient-4.1.2.3/src/onmainwindow.cpp:4008:18: style: The scope of the variable 'useBrokerUserForProxy' can be reduced. [variableScope] x2goclient-4.1.2.3/src/onmainwindow.cpp:6110:21: style: The scope of the variable 'acmd' can be reduced. [variableScope] x2goclient-4.1.2.3/src/onmainwindow.cpp:6110:34: style: The scope of the variable 'ecmd' can be reduced. [variableScope] x2goclient-4.1.2.3/src/onmainwindow.cpp:416:37: error: Division by zero. [zerodiv] x2goclient-4.1.2.3/src/onmainwindow.cpp:411:26: note: Assuming condition is false x2goclient-4.1.2.3/src/onmainwindow.cpp:415:30: note: Assignment 'max=fileList.size()', assigned value is 0 x2goclient-4.1.2.3/src/onmainwindow.cpp:416:37: note: Division by zero x2goclient-4.1.2.3/src/onmainwindow.cpp:2534:43: style:inconclusive: Function 'initLdapSession' argument 1 names different: declaration 'showBox' definition 'showError'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/onmainwindow.h:965:33: note: Function 'initLdapSession' argument 1 names different: declaration 'showBox' definition 'showError'. x2goclient-4.1.2.3/src/onmainwindow.cpp:2534:43: note: Function 'initLdapSession' argument 1 names different: declaration 'showBox' definition 'showError'. x2goclient-4.1.2.3/src/onmainwindow.cpp:3277:96: style:inconclusive: Function 'slotSshServerAuthChallengeResponse' argument 2 names different: declaration 'Challenge' definition 'challenge'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/onmainwindow.h:1072:87: note: Function 'slotSshServerAuthChallengeResponse' argument 2 names different: declaration 'Challenge' definition 'challenge'. x2goclient-4.1.2.3/src/onmainwindow.cpp:3277:96: note: Function 'slotSshServerAuthChallengeResponse' argument 2 names different: declaration 'Challenge' definition 'challenge'. x2goclient-4.1.2.3/src/onmainwindow.cpp:3808:50: style:inconclusive: Function 'startSession' argument 1 names different: declaration 'id' definition 'sid'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/onmainwindow.h:966:40: note: Function 'startSession' argument 1 names different: declaration 'id' definition 'sid'. x2goclient-4.1.2.3/src/onmainwindow.cpp:3808:50: note: Function 'startSession' argument 1 names different: declaration 'id' definition 'sid'. x2goclient-4.1.2.3/src/onmainwindow.cpp:5527:43: style:inconclusive: Function 'slotRetSuspSess' argument 1 names different: declaration 'value' definition 'result'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/onmainwindow.h:1115:33: note: Function 'slotRetSuspSess' argument 1 names different: declaration 'value' definition 'result'. x2goclient-4.1.2.3/src/onmainwindow.cpp:5527:43: note: Function 'slotRetSuspSess' argument 1 names different: declaration 'value' definition 'result'. x2goclient-4.1.2.3/src/onmainwindow.cpp:5527:59: style:inconclusive: Function 'slotRetSuspSess' argument 2 names different: declaration 'message' definition 'output'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/onmainwindow.h:1115:47: note: Function 'slotRetSuspSess' argument 2 names different: declaration 'message' definition 'output'. x2goclient-4.1.2.3/src/onmainwindow.cpp:5527:59: note: Function 'slotRetSuspSess' argument 2 names different: declaration 'message' definition 'output'. x2goclient-4.1.2.3/src/onmainwindow.cpp:8458:43: style:inconclusive: Function 'geometry_par' argument 1 names different: declaration 'value' definition 'val'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/onmainwindow.h:974:33: note: Function 'geometry_par' argument 1 names different: declaration 'value' definition 'val'. x2goclient-4.1.2.3/src/onmainwindow.cpp:8458:43: note: Function 'geometry_par' argument 1 names different: declaration 'value' definition 'val'. x2goclient-4.1.2.3/src/onmainwindow.cpp:8486:41: style:inconclusive: Function 'setKbd_par' argument 1 names different: declaration 'value' definition 'val'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/onmainwindow.h:975:31: note: Function 'setKbd_par' argument 1 names different: declaration 'value' definition 'val'. x2goclient-4.1.2.3/src/onmainwindow.cpp:8486:41: note: Function 'setKbd_par' argument 1 names different: declaration 'value' definition 'val'. x2goclient-4.1.2.3/src/onmainwindow.cpp:8502:44: style:inconclusive: Function 'ldapParameter' argument 1 names different: declaration 'value' definition 'val'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/onmainwindow.h:976:34: note: Function 'ldapParameter' argument 1 names different: declaration 'value' definition 'val'. x2goclient-4.1.2.3/src/onmainwindow.cpp:8502:44: note: Function 'ldapParameter' argument 1 names different: declaration 'value' definition 'val'. x2goclient-4.1.2.3/src/onmainwindow.cpp:8524:45: style:inconclusive: Function 'ldap1Parameter' argument 1 names different: declaration 'value' definition 'val'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/onmainwindow.h:977:35: note: Function 'ldap1Parameter' argument 1 names different: declaration 'value' definition 'val'. x2goclient-4.1.2.3/src/onmainwindow.cpp:8524:45: note: Function 'ldap1Parameter' argument 1 names different: declaration 'value' definition 'val'. x2goclient-4.1.2.3/src/onmainwindow.cpp:8542:45: style:inconclusive: Function 'ldap2Parameter' argument 1 names different: declaration 'value' definition 'val'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/onmainwindow.h:978:35: note: Function 'ldap2Parameter' argument 1 names different: declaration 'value' definition 'val'. x2goclient-4.1.2.3/src/onmainwindow.cpp:8542:45: note: Function 'ldap2Parameter' argument 1 names different: declaration 'value' definition 'val'. x2goclient-4.1.2.3/src/onmainwindow.cpp:8562:44: style:inconclusive: Function 'packParameter' argument 1 names different: declaration 'value' definition 'val'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/onmainwindow.h:979:34: note: Function 'packParameter' argument 1 names different: declaration 'value' definition 'val'. x2goclient-4.1.2.3/src/onmainwindow.cpp:8562:44: note: Function 'packParameter' argument 1 names different: declaration 'value' definition 'val'. x2goclient-4.1.2.3/src/onmainwindow.cpp:8667:41: style:inconclusive: Function 'showTextFile' argument 1 names different: declaration 'file' definition 'fname'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/onmainwindow.h:553:31: note: Function 'showTextFile' argument 1 names different: declaration 'file' definition 'fname'. x2goclient-4.1.2.3/src/onmainwindow.cpp:8667:41: note: Function 'showTextFile' argument 1 names different: declaration 'file' definition 'fname'. x2goclient-4.1.2.3/src/onmainwindow.cpp:11829:48: style:inconclusive: Function 'resizeProxyWinOnDisplay' argument 1 names different: declaration 'display' definition 'disp'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/onmainwindow.h:1205:38: note: Function 'resizeProxyWinOnDisplay' argument 1 names different: declaration 'display' definition 'disp'. x2goclient-4.1.2.3/src/onmainwindow.cpp:11829:48: note: Function 'resizeProxyWinOnDisplay' argument 1 names different: declaration 'display' definition 'disp'. x2goclient-4.1.2.3/src/onmainwindow.cpp:2082:17: style: Local variable 'username' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/onmainwindow.h:782:18: note: Shadowed declaration x2goclient-4.1.2.3/src/onmainwindow.cpp:2082:17: note: Shadow variable x2goclient-4.1.2.3/src/onmainwindow.cpp:2112:21: style: Local variable 'username' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/onmainwindow.h:782:18: note: Shadowed declaration x2goclient-4.1.2.3/src/onmainwindow.cpp:2112:21: note: Shadow variable x2goclient-4.1.2.3/src/onmainwindow.cpp:2188:14: style: Local variable 'u' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/onmainwindow.h:709:13: note: Shadowed declaration x2goclient-4.1.2.3/src/onmainwindow.cpp:2188:14: note: Shadow variable x2goclient-4.1.2.3/src/onmainwindow.cpp:2501:13: style: Local variable 'id' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/onmainwindow.h:739:13: note: Shadowed declaration x2goclient-4.1.2.3/src/onmainwindow.cpp:2501:13: note: Shadow variable x2goclient-4.1.2.3/src/onmainwindow.cpp:2561:34: style: Local variable 'e' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:2545:26: note: Shadowed declaration x2goclient-4.1.2.3/src/onmainwindow.cpp:2561:34: note: Shadow variable x2goclient-4.1.2.3/src/onmainwindow.cpp:2563:25: style: Local variable 'message' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:2547:17: note: Shadowed declaration x2goclient-4.1.2.3/src/onmainwindow.cpp:2563:25: note: Shadow variable x2goclient-4.1.2.3/src/onmainwindow.cpp:2578:42: style: Local variable 'e' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:2561:34: note: Shadowed declaration x2goclient-4.1.2.3/src/onmainwindow.cpp:2578:42: note: Shadow variable x2goclient-4.1.2.3/src/onmainwindow.cpp:2580:33: style: Local variable 'message' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:2563:25: note: Shadowed declaration x2goclient-4.1.2.3/src/onmainwindow.cpp:2580:33: note: Shadow variable x2goclient-4.1.2.3/src/onmainwindow.cpp:3240:10: style: Local variable 'ok' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/onmainwindow.h:718:18: note: Shadowed declaration x2goclient-4.1.2.3/src/onmainwindow.cpp:3240:10: note: Shadow variable x2goclient-4.1.2.3/src/onmainwindow.cpp:3279:10: style: Local variable 'ok' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/onmainwindow.h:718:18: note: Shadowed declaration x2goclient-4.1.2.3/src/onmainwindow.cpp:3279:10: note: Shadow variable x2goclient-4.1.2.3/src/onmainwindow.cpp:4006:18: style: Local variable 'ok' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/onmainwindow.h:718:18: note: Shadowed declaration x2goclient-4.1.2.3/src/onmainwindow.cpp:4006:18: note: Shadow variable x2goclient-4.1.2.3/src/onmainwindow.cpp:7739:26: style: Local variable 'i' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:7719:18: note: Shadowed declaration x2goclient-4.1.2.3/src/onmainwindow.cpp:7739:26: note: Shadow variable x2goclient-4.1.2.3/src/onmainwindow.cpp:7760:26: style: Local variable 'i' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:7719:18: note: Shadowed declaration x2goclient-4.1.2.3/src/onmainwindow.cpp:7760:26: note: Shadow variable x2goclient-4.1.2.3/src/onmainwindow.cpp:8582:22: style: Local variable 'ok' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/onmainwindow.h:718:18: note: Shadowed declaration x2goclient-4.1.2.3/src/onmainwindow.cpp:8582:22: note: Shadow variable x2goclient-4.1.2.3/src/onmainwindow.cpp:8984:13: style: Local variable 'uname' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/onmainwindow.h:699:16: note: Shadowed declaration x2goclient-4.1.2.3/src/onmainwindow.cpp:8984:13: note: Shadow variable x2goclient-4.1.2.3/src/onmainwindow.cpp:9310:21: style: Local variable 'ln' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/onmainwindow.h:878:15: note: Shadowed declaration x2goclient-4.1.2.3/src/onmainwindow.cpp:9310:21: note: Shadow variable x2goclient-4.1.2.3/src/onmainwindow.cpp:9389:21: style: Local variable 'ln' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/onmainwindow.h:878:15: note: Shadowed declaration x2goclient-4.1.2.3/src/onmainwindow.cpp:9389:21: note: Shadow variable x2goclient-4.1.2.3/src/onmainwindow.cpp:9551:14: style: Local variable 'u' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/onmainwindow.h:709:13: note: Shadowed declaration x2goclient-4.1.2.3/src/onmainwindow.cpp:9551:14: note: Shadow variable x2goclient-4.1.2.3/src/onmainwindow.cpp:9853:17: style: Local variable 'login' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/onmainwindow.h:701:20: note: Shadowed declaration x2goclient-4.1.2.3/src/onmainwindow.cpp:9853:17: note: Shadow variable x2goclient-4.1.2.3/src/onmainwindow.cpp:10264:13: style: Local variable 'uname' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/onmainwindow.h:699:16: note: Shadowed declaration x2goclient-4.1.2.3/src/onmainwindow.cpp:10264:13: note: Shadow variable x2goclient-4.1.2.3/src/onmainwindow.h:115:40: performance: Function parameter 'it' should be passed by const reference. However it seems that 'lt' is a callback function. [passedByValueCallback] x2goclient-4.1.2.3/src/onmainwindow.cpp:8770:57: note: Function pointer used here. x2goclient-4.1.2.3/src/onmainwindow.h:115:40: note: Function parameter 'it' should be passed by const reference. However it seems that 'lt' is a callback function. x2goclient-4.1.2.3/src/onmainwindow.h:115:62: performance: Function parameter 'it1' should be passed by const reference. However it seems that 'lt' is a callback function. [passedByValueCallback] x2goclient-4.1.2.3/src/onmainwindow.cpp:8770:57: note: Function pointer used here. x2goclient-4.1.2.3/src/onmainwindow.h:115:62: note: Function parameter 'it1' should be passed by const reference. However it seems that 'lt' is a callback function. x2goclient-4.1.2.3/src/onmainwindow.cpp:728:44: performance: Function parameter 'file_name_start' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:3000:65: performance: Function parameter 'host' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:3000:79: performance: Function parameter 'port' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:3001:17: performance: Function parameter 'login' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:3002:17: performance: Function parameter 'password' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:3004:17: performance: Function parameter 'proxyserver' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:3005:17: performance: Function parameter 'proxylogin' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:3005:37: performance: Function parameter 'proxypassword' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:3005:60: performance: Function parameter 'proxyKey' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:3142:69: performance: Function parameter 'host' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:3160:52: performance: Function parameter 'server' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:3200:85: performance: Function parameter 'prompt' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:3222:86: performance: Function parameter 'output' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:3277:96: performance: Function parameter 'challenge' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:3304:64: performance: Function parameter 'sshMessage' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:3774:51: performance: Function parameter 'user' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:3774:65: performance: Function parameter 'server' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:3774:81: performance: Function parameter 'port' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:3776:5: performance: Range variable 'key' should be declared as const reference. [iterateByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:3781:5: performance: Range variable 'key' should be declared as const reference. [iterateByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:3787:5: performance: Range variable 'key' should be declared as const reference. [iterateByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:3793:5: performance: Range variable 'key' should be declared as const reference. [iterateByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:3799:5: performance: Range variable 'key' should be declared as const reference. [iterateByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:4039:59: performance: Function parameter 'output' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:5527:59: performance: Function parameter 'output' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:5640:60: performance: Function parameter 'output' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:6472:61: performance: Function parameter 'output' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:6502:64: performance: Function parameter 'output' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:7189:45: performance: Function parameter 'sessId' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:7197:42: performance: Function parameter 'sessId' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:7443:43: performance: Function parameter 'exec' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:7453:49: performance: Function parameter 'output' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:7660:61: performance: Function parameter 'output' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:7690:62: performance: Function parameter 'output' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:7712:5: performance: Range variable 'appstr' should be declared as const reference. [iterateByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:7862:45: performance: Function parameter 'param' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:8404:44: performance: Function parameter 'value' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:8426:49: performance: Function parameter 'value' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:8443:45: performance: Function parameter 'val' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:8458:43: performance: Function parameter 'val' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:8486:41: performance: Function parameter 'val' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:8502:44: performance: Function parameter 'val' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:8524:45: performance: Function parameter 'val' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:8542:45: performance: Function parameter 'val' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:8562:44: performance: Function parameter 'val' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:8609:41: performance: Function parameter 'param' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:8718:58: performance: Function parameter 'output' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:8797:62: performance: Function parameter 'output' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:8927:41: performance: Function parameter 'exports' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:9136:55: performance: Function parameter 'output' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:9183:46: performance: Function parameter 'key' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:9196:59: performance: Function parameter 'output' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:10167:44: performance: Function parameter 'intName' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:10167:61: performance: Function parameter 'transName' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:10189:57: performance: Function parameter 'output' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:10272:63: performance: Function parameter 'output' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:12292:45: performance: Function parameter 'line' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:13644:41: performance: Function parameter 'text' should be passed by const reference. [passedByValue] x2goclient-4.1.2.3/src/onmainwindow.cpp:417:27: error: Out of bounds access in expression 'fileList.at(random_selector)' because 'fileList' is empty. [containerOutOfBounds] x2goclient-4.1.2.3/src/onmainwindow.cpp:411:26: note: Assuming condition is false x2goclient-4.1.2.3/src/onmainwindow.cpp:417:27: note: Access out of bounds x2goclient-4.1.2.3/src/onmainwindow.cpp:3778:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] x2goclient-4.1.2.3/src/onmainwindow.cpp:3783:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] x2goclient-4.1.2.3/src/onmainwindow.cpp:3789:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] x2goclient-4.1.2.3/src/onmainwindow.cpp:3795:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] x2goclient-4.1.2.3/src/onmainwindow.cpp:3801:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] x2goclient-4.1.2.3/src/onmainwindow.cpp:13723:9: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] x2goclient-4.1.2.3/src/onmainwindow.cpp:4201:17: error: Uninitialized variables: s.connectedSince, s.published, s.colorDepth, s.fullscreen, s.sessionType [uninitvar] x2goclient-4.1.2.3/src/onmainwindow.cpp:7376:12: error: Uninitialized variables: s.connectedSince, s.published, s.colorDepth, s.fullscreen, s.sessionType [uninitvar] x2goclient-4.1.2.3/src/onmainwindow.cpp:4201:17: error: Uninitialized struct member: s.connectedSince [uninitStructMember] x2goclient-4.1.2.3/src/onmainwindow.cpp:4201:17: error: Uninitialized struct member: s.published [uninitStructMember] x2goclient-4.1.2.3/src/onmainwindow.cpp:4201:17: error: Uninitialized struct member: s.colorDepth [uninitStructMember] x2goclient-4.1.2.3/src/onmainwindow.cpp:4201:17: error: Uninitialized struct member: s.fullscreen [uninitStructMember] x2goclient-4.1.2.3/src/onmainwindow.cpp:4201:17: error: Uninitialized struct member: s.sessionType [uninitStructMember] x2goclient-4.1.2.3/src/onmainwindow.cpp:7376:12: error: Uninitialized struct member: s.connectedSince [uninitStructMember] x2goclient-4.1.2.3/src/onmainwindow.cpp:7376:12: error: Uninitialized struct member: s.published [uninitStructMember] x2goclient-4.1.2.3/src/onmainwindow.cpp:7376:12: error: Uninitialized struct member: s.colorDepth [uninitStructMember] x2goclient-4.1.2.3/src/onmainwindow.cpp:7376:12: error: Uninitialized struct member: s.fullscreen [uninitStructMember] x2goclient-4.1.2.3/src/onmainwindow.cpp:7376:12: error: Uninitialized struct member: s.sessionType [uninitStructMember] x2goclient-4.1.2.3/src/onmainwindow.cpp:743:17: style: Unused variable: ui_languages [unusedVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:2007:13: style: Unused variable: freeServer [unusedVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:2977:15: style: Variable 'nopass' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:4008:39: style: Variable 'useBrokerUserForProxy' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:4063:30: style: Variable 'printout' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:4316:13: style: Variable 'passwd' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:4317:13: style: Variable 'user' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:4747:13: style: Variable 'passwd' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:4748:13: style: Variable 'user' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:5304:21: style: Variable 'user' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:5393:17: style: Variable 'user' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:5395:11: style: Variable 'passwd' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:5471:17: style: Variable 'user' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:5472:11: style: Variable 'passwd' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:5608:24: style: Variable 'sid' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:5710:13: style: Variable 'passwd' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:7457:13: style: Variable 'host' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:8628:17: style: Variable 'out' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:8954:11: style: Variable 'passwd' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:9162:30: style: Variable 'printout' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:9420:19: style: Variable 'passwd' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:9421:17: style: Variable 'user' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:9422:17: style: Variable 'host' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:9379:13: style: Unused variable: loginDir [unusedVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:9380:13: style: Unused variable: logoutDir [unusedVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:10181:17: style: Variable 'user' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:10182:17: style: Variable 'host' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:10183:11: style: Variable 'passwd' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:10263:19: style: Variable 'passwd' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:10264:18: style: Variable 'uname' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:10395:19: style: Variable 'passwd' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:10396:17: style: Variable 'user' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:10397:17: style: Variable 'host' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:11725:14: style: Variable 'title' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:11728:14: style: Variable 'title' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:12271:20: style: Variable 'haveKey' is assigned a value that is never used. [unreadVariable] x2goclient-4.1.2.3/src/onmainwindow.cpp:1394:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] x2goclient-4.1.2.3/src/onmainwindow.cpp:1410:82: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] x2goclient-4.1.2.3/src/onmainwindow.cpp:1423:80: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] x2goclient-4.1.2.3/src/onmainwindow.cpp:1813:41: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] x2goclient-4.1.2.3/src/onmainwindow.cpp:2080:40: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] x2goclient-4.1.2.3/src/onmainwindow.cpp:2110:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] x2goclient-4.1.2.3/src/onmainwindow.cpp:2126:74: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] x2goclient-4.1.2.3/src/onmainwindow.cpp:2763:70: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] x2goclient-4.1.2.3/src/onmainwindow.cpp:9624:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] x2goclient-4.1.2.3/src/onmainwindow.cpp:9636:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] diff: head x2goclient-4.1.2.3/src/InteractionDialog.cpp:50:70: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Mid [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/LDAPSession.cpp:124:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LDAPMod [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/LDAPSession.cpp:173:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LDAPMod [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/LDAPSession.cpp:210:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LDAP_SUCCESS [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/LDAPSession.cpp:232:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LDAP_SCOPE_SUBTREE [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/LDAPSession.cpp:299:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LDAP_SCOPE_SUBTREE [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/SVGFrame.cpp:36:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/appdialog.cpp:162:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable treeWidget [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/appdialog.cpp:185:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UserRole [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/appdialog.cpp:194:65: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UserRole [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/appdialog.cpp:48:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable treeWidget [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/appdialog.cpp:86:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable treeWidget [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/brokerpassdlg.cpp:44:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/configdialog.cpp:262:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] 2.13.0 x2goclient-4.1.2.3/src/configdialog.cpp:286:18: style: Variable 'cancel' can be declared as pointer to const [constVariablePointer] head x2goclient-4.1.2.3/src/configwidget.cpp:21:38: performance: Function parameter 'id' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/configwidget.cpp:21:57: style:inconclusive: Function 'ConfigWidget' argument 2 names different: declaration 'mv' definition 'mw'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/configwidget.h:31:45: note: Function 'ConfigWidget' argument 2 names different: declaration 'mv' definition 'mw'. x2goclient-4.1.2.3/src/configwidget.cpp:21:57: note: Function 'ConfigWidget' argument 2 names different: declaration 'mv' definition 'mw'. head x2goclient-4.1.2.3/src/configwidget.cpp:25:2: performance: Variable 'sessionId' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] head x2goclient-4.1.2.3/src/connectionwidget.cpp:102:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/connectionwidget.cpp:33:46: performance: Function parameter 'id' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/connectionwidget.cpp:40:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Horizontal [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/contest.cpp:101:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable green [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/contest.cpp:131:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable green [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/contest.cpp:147:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SocketTimeoutError [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/contest.cpp:184:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SocketTimeoutError [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/contest.cpp:64:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Retry [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/cupsprint.cpp:114:45: performance: Function parameter 'prn' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/cupsprint.cpp:133:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/cupsprint.cpp:144:16: style: Variable 'choice' can be declared as pointer to const [constVariablePointer] head x2goclient-4.1.2.3/src/cupsprint.cpp:203:16: style: Variable 'group' can be declared as pointer to const [constVariablePointer] head x2goclient-4.1.2.3/src/cupsprint.cpp:210:48: style:inconclusive: Function 'getOptionsList' argument 1 names different: declaration 'group' definition 'groupName'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/cupsprint.h:49:39: note: Function 'getOptionsList' argument 1 names different: declaration 'group' definition 'groupName'. x2goclient-4.1.2.3/src/cupsprint.cpp:210:48: note: Function 'getOptionsList' argument 1 names different: declaration 'group' definition 'groupName'. head x2goclient-4.1.2.3/src/cupsprint.cpp:226:18: style: Variable 'option' can be declared as pointer to const [constVariablePointer] head x2goclient-4.1.2.3/src/cupsprint.cpp:256:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable choice1 [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/cupsprint.cpp:293:16: style: Variable 'opt' can be declared as pointer to const [constVariablePointer] head x2goclient-4.1.2.3/src/cupsprint.cpp:363:54: performance: Function parameter 'title' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/cupsprint.cpp:44:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable name [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/cupsprint.h:35:8: performance:inconclusive: Technically the member function 'CUPSPrint::setDefaultUserPrinter' can be static (but you may consider moving to unnamed namespace). [functionStatic] x2goclient-4.1.2.3/src/cupsprint.cpp:69:17: note: Technically the member function 'CUPSPrint::setDefaultUserPrinter' can be static (but you may consider moving to unnamed namespace). x2goclient-4.1.2.3/src/cupsprint.h:35:8: note: Technically the member function 'CUPSPrint::setDefaultUserPrinter' can be static (but you may consider moving to unnamed namespace). head x2goclient-4.1.2.3/src/cupsprint.h:48:7: style:inconclusive: Technically the member function 'CUPSPrint::getOptionGroups' can be const. [functionConst] x2goclient-4.1.2.3/src/cupsprint.cpp:194:16: note: Technically the member function 'CUPSPrint::getOptionGroups' can be const. x2goclient-4.1.2.3/src/cupsprint.h:48:7: note: Technically the member function 'CUPSPrint::getOptionGroups' can be const. head x2goclient-4.1.2.3/src/cupsprint.h:49:7: style:inconclusive: Technically the member function 'CUPSPrint::getOptionsList' can be const. [functionConst] x2goclient-4.1.2.3/src/cupsprint.cpp:210:16: note: Technically the member function 'CUPSPrint::getOptionsList' can be const. x2goclient-4.1.2.3/src/cupsprint.h:49:7: note: Technically the member function 'CUPSPrint::getOptionsList' can be const. head x2goclient-4.1.2.3/src/cupsprintersettingsdialog.cpp:102:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Type [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/cupsprintersettingsdialog.cpp:217:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Type [valueFlowBailoutIncompleteVar] 2.13.0 x2goclient-4.1.2.3/src/cupsprintersettingsdialog.cpp:332:32: warning: Either the condition 'vals.size()1' is redundant or args size can be 2. Expression 'args[2]' cause access out of bounds. [containerOutOfBounds] x2goclient-4.1.2.3/src/ongetpass.cpp:64:23: note: Assuming that condition 'args.count()>1' is not redundant x2goclient-4.1.2.3/src/ongetpass.cpp:69:26: note: Access out of bounds head x2goclient-4.1.2.3/src/ongetpass.cpp:69:26: warning: Either the condition 'args.count()>1' is redundant or size of 'args' can be 2. Expression 'args[2]' causes access out of bounds. [containerOutOfBounds] x2goclient-4.1.2.3/src/ongetpass.cpp:64:23: note: Assuming that condition 'args.count()>1' is not redundant x2goclient-4.1.2.3/src/ongetpass.cpp:69:26: note: Access out of bounds 2.13.0 x2goclient-4.1.2.3/src/ongetpass.cpp:70:29: warning: Either the condition 'args.count()>1' is redundant or args size can be 2. Expression 'args[4]' cause access out of bounds. [containerOutOfBounds] x2goclient-4.1.2.3/src/ongetpass.cpp:64:23: note: Assuming that condition 'args.count()>1' is not redundant x2goclient-4.1.2.3/src/ongetpass.cpp:70:29: note: Access out of bounds head x2goclient-4.1.2.3/src/ongetpass.cpp:70:29: warning: Either the condition 'args.count()>1' is redundant or size of 'args' can be 2. Expression 'args[4]' causes access out of bounds. [containerOutOfBounds] x2goclient-4.1.2.3/src/ongetpass.cpp:64:23: note: Assuming that condition 'args.count()>1' is not redundant x2goclient-4.1.2.3/src/ongetpass.cpp:70:29: note: Access out of bounds 2.13.0 x2goclient-4.1.2.3/src/ongetpass.cpp:72:26: warning: Either the condition 'args.count()>1' is redundant or args size can be 2. Expression 'args[6]' cause access out of bounds. [containerOutOfBounds] x2goclient-4.1.2.3/src/ongetpass.cpp:64:23: note: Assuming that condition 'args.count()>1' is not redundant x2goclient-4.1.2.3/src/ongetpass.cpp:72:26: note: Access out of bounds head x2goclient-4.1.2.3/src/ongetpass.cpp:72:26: warning: Either the condition 'args.count()>1' is redundant or size of 'args' can be 2. Expression 'args[6]' causes access out of bounds. [containerOutOfBounds] x2goclient-4.1.2.3/src/ongetpass.cpp:64:23: note: Assuming that condition 'args.count()>1' is not redundant x2goclient-4.1.2.3/src/ongetpass.cpp:72:26: note: Access out of bounds head x2goclient-4.1.2.3/src/ongetpass.cpp:85:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable No [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:10167:44: performance: Function parameter 'intName' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/onmainwindow.cpp:10167:61: performance: Function parameter 'transName' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/onmainwindow.cpp:10189:57: performance: Function parameter 'output' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/onmainwindow.cpp:10206:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:10284:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:10294:72: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:10307:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:10497:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Files [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:1051:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:10533:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Files [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:10545:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Files [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:1078:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Accepted [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:11099:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WriteOnly [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:1109:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:11479:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:1165:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AlignLeft [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:11677:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Running [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:12050:67: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IniFormat [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:12292:45: performance: Function parameter 'line' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/onmainwindow.cpp:12587:70: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Mid [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:12779:70: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Mid [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:12957:70: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Mid [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:13241:67: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:13274:67: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:13285:58: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:13296:58: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:13331:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ToolButtonIconOnly [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:13361:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ToolButtonTextUnderIcon [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:13428:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Checked [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:1355:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:13587:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Files [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:13671:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoError [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:13758:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:1480:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Running [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:1625:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:1649:68: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:1729:61: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:1882:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Password [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:1963:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:2083:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CaseInsensitive [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:2148:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:2259:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Accepted [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:2367:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:2504:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Accepted [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:2594:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:2768:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CaseInsensitive [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:2812:61: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IniFormat [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:299:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WindowStaysOnTopHint [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:3000:79: performance: Function parameter 'port' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/onmainwindow.cpp:3073:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:3257:135: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:3285:84: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:3330:56: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Yes [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:3448:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:3485:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:3542:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:363:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:3804:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:3844:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:4039:59: performance: Function parameter 'output' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/onmainwindow.cpp:4059:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] 2.13.0 x2goclient-4.1.2.3/src/onmainwindow.cpp:417:27: error: Out of bounds access in expression 'fileList.at(random_selector)' because 'fileList' is empty and 'random_selector' may be non-zero. [containerOutOfBounds] x2goclient-4.1.2.3/src/onmainwindow.cpp:411:26: note: Assuming condition is false x2goclient-4.1.2.3/src/onmainwindow.cpp:417:27: note: Access out of bounds head x2goclient-4.1.2.3/src/onmainwindow.cpp:417:27: error: Out of bounds access in expression 'fileList.at(random_selector)' because 'fileList' is empty. [containerOutOfBounds] x2goclient-4.1.2.3/src/onmainwindow.cpp:411:26: note: Assuming condition is false x2goclient-4.1.2.3/src/onmainwindow.cpp:417:27: note: Access out of bounds 2.13.0 x2goclient-4.1.2.3/src/onmainwindow.cpp:4246:12: error: Uninitialized struct member: s.connectedSince [uninitStructMember] 2.13.0 x2goclient-4.1.2.3/src/onmainwindow.cpp:4246:12: error: Uninitialized struct member: s.fullscreen [uninitStructMember] 2.13.0 x2goclient-4.1.2.3/src/onmainwindow.cpp:4246:12: error: Uninitialized struct member: s.published [uninitStructMember] head x2goclient-4.1.2.3/src/onmainwindow.cpp:4301:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IniFormat [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:4338:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:4784:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:5049:60: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IniFormat [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:5164:75: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ISODate [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:5295:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:5439:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:5542:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:5619:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:5655:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:5704:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:6180:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:62:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:6483:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:6513:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:6708:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CrashExit [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:676:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WriteOnly [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:6791:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Running [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:6910:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WriteOnly [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:7176:60: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable No [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:7213:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable No [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:7244:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:7472:60: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IniFormat [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:7673:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:7690:62: performance: Function parameter 'output' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/onmainwindow.cpp:7703:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:7712:5: performance: Range variable 'appstr' should be declared as const reference. [iterateByValue] head x2goclient-4.1.2.3/src/onmainwindow.cpp:7862:45: performance: Function parameter 'param' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/onmainwindow.cpp:7871:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CaseInsensitive [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:8458:43: performance: Function parameter 'val' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/onmainwindow.cpp:8507:53: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:8528:53: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:8546:53: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:8562:44: performance: Function parameter 'val' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/onmainwindow.cpp:8566:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:8642:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:8670:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:8718:58: performance: Function parameter 'output' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/onmainwindow.cpp:8735:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:875:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Plain [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:8797:62: performance: Function parameter 'output' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/onmainwindow.cpp:8817:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:8903:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Accepted [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:9018:64: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IniFormat [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:9136:55: performance: Function parameter 'output' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/onmainwindow.cpp:9158:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:9199:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:9282:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadUser [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:9357:61: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadUser [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:9440:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:9538:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:9656:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:9682:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:9735:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Running [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:9749:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:9832:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.cpp:9889:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoButton [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/onmainwindow.h:351:13: performance: Function 'retLdapServer()' should return member 'ldapServer' by const reference. [returnByReference] head x2goclient-4.1.2.3/src/onmainwindow.h:359:13: performance: Function 'retLdapDn()' should return member 'ldapDn' by const reference. [returnByReference] head x2goclient-4.1.2.3/src/onmainwindow.h:363:13: performance: Function 'retLdapServer1()' should return member 'ldapServer1' by const reference. [returnByReference] head x2goclient-4.1.2.3/src/onmainwindow.h:371:13: performance: Function 'retLdapServer2()' should return member 'ldapServer2' by const reference. [returnByReference] head x2goclient-4.1.2.3/src/onmainwindow.h:392:20: performance: Function 'getHomeDirectory()' should return member 'homeDir' by const reference. [returnByReference] head x2goclient-4.1.2.3/src/onmainwindow.h:404:13: performance: Function 'getCardLogin()' should return member 'cardLogin' by const reference. [returnByReference] head x2goclient-4.1.2.3/src/onmainwindow.h:408:13: performance: Function 'getDefaultCmd()' should return member 'defaultCmd' by const reference. [returnByReference] head x2goclient-4.1.2.3/src/onmainwindow.h:412:13: performance: Function 'getDefaultSshPort()' should return member 'defaultSshPort' by const reference. [returnByReference] head x2goclient-4.1.2.3/src/onmainwindow.h:416:13: performance: Function 'getDefaultClipboardMode()' should return member 'defaultClipboardMode' by const reference. [returnByReference] head x2goclient-4.1.2.3/src/onmainwindow.h:420:13: performance: Function 'getDefaultKbdType()' should return member 'defaultKbdType' by const reference. [returnByReference] head x2goclient-4.1.2.3/src/onmainwindow.h:424:17: performance: Function 'getDefaultLayout()' should return member 'defaultLayout' by const reference. [returnByReference] head x2goclient-4.1.2.3/src/onmainwindow.h:428:13: performance: Function 'getDefaultPack()' should return member 'defaultPack' by const reference. [returnByReference] head x2goclient-4.1.2.3/src/onmainwindow.h:484:20: performance: Function 'getSessionConf()' should return member 'sessionCfg' by const reference. [returnByReference] head x2goclient-4.1.2.3/src/onmainwindow.h:560:17: performance: Function 'internApplicationsNames()' should return member '_internApplicationsNames' by const reference. [returnByReference] head x2goclient-4.1.2.3/src/onmainwindow.h:564:17: performance: Function 'transApplicationsNames()' should return member '_transApplicationsNames' by const reference. [returnByReference] 2.13.0 x2goclient-4.1.2.3/src/onmainwindow.h:90:33: performance: Function parameter 'u1' should be passed by const reference. However it seems that 'lessThen' is a callback function. [passedByValueCallback] x2goclient-4.1.2.3/src/onmainwindow.cpp:2210:51: note: Function pointer used here. x2goclient-4.1.2.3/src/onmainwindow.h:90:33: note: Function parameter 'u1' should be passed by const reference. However it seems that 'lessThen' is a callback function. 2.13.0 x2goclient-4.1.2.3/src/onmainwindow.h:90:33: performance: Function parameter 'u1' should be passed by const reference. [passedByValue] 2.13.0 x2goclient-4.1.2.3/src/onmainwindow.h:90:41: performance: Function parameter 'u2' should be passed by const reference. However it seems that 'lessThen' is a callback function. [passedByValueCallback] x2goclient-4.1.2.3/src/onmainwindow.cpp:2210:51: note: Function pointer used here. x2goclient-4.1.2.3/src/onmainwindow.h:90:41: note: Function parameter 'u2' should be passed by const reference. However it seems that 'lessThen' is a callback function. 2.13.0 x2goclient-4.1.2.3/src/onmainwindow.h:90:41: performance: Function parameter 'u2' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/printdialog.cpp:28:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/printdialog.cpp:47:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/printprocess.cpp:108:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Rejected [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/printprocess.cpp:141:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FailedToStart [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/printprocess.cpp:193:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FailedToStart [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/printprocess.cpp:38:38: performance: Function parameter 'pdf' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/printprocess.cpp:38:51: performance: Function parameter 'title' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/printprocess.cpp:76:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NormalExit [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/pulsemanager.cpp:196:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Starting [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/pulsemanager.cpp:228:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Running [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/pulsemanager.cpp:369:69: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/pulsemanager.cpp:54:14: style: Error code from the return value of function pulse_dir_.cd() is not used. [ignoredReturnErrorCode] 2.13.0 x2goclient-4.1.2.3/src/pulsemanager.cpp:54:14: warning: Return value of function pulse_dir_.cd() is not used. [ignoredReturnValue] head x2goclient-4.1.2.3/src/pulsemanager.cpp:635:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/pulsemanager.cpp:693:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/pulsemanager.cpp:817:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NotRunning [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/pulsemanager.cpp:823:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Running [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionbutton.cpp:377:60: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IniFormat [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionbutton.cpp:44:74: performance: Function parameter 'id' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/sessionbutton.cpp:52:70: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Mid [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionbutton.cpp:763:78: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WindingFill [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionbutton.cpp:894:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TextSingleLine [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionbutton.cpp:910:13: style: Local variable 'cmd' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/sessionbutton.h:88:13: note: Shadowed declaration x2goclient-4.1.2.3/src/sessionbutton.cpp:910:13: note: Shadow variable head x2goclient-4.1.2.3/src/sessionbutton.h:38:13: performance: Function 'id()' should return member 'sid' by const reference. [returnByReference] head x2goclient-4.1.2.3/src/sessionbutton.h:46:13: performance: Function 'name()' should return member 'nameofSession' by const reference. [returnByReference] head x2goclient-4.1.2.3/src/sessionbutton.h:47:13: performance: Function 'getPath()' should return member 'path' by const reference. [returnByReference] head x2goclient-4.1.2.3/src/sessionexplorer.cpp:109:50: performance: Function parameter 'slst' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/sessionexplorer.cpp:188:67: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ElideLeft [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionexplorer.cpp:205:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Accepted [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionexplorer.cpp:220:69: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IniFormat [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionexplorer.cpp:242:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Accepted [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionexplorer.cpp:260:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Yes [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionexplorer.cpp:501:83: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionexplorer.cpp:51:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoFocus [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionexplorer.cpp:521:83: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionexplorer.cpp:542:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable No [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionexplorer.cpp:562:44: performance: Function parameter 'path' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/sessionexplorer.cpp:566:17: style: Local variable 'currentPath' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/sessionexplorer.h:99:13: note: Shadowed declaration x2goclient-4.1.2.3/src/sessionexplorer.cpp:566:17: note: Shadow variable head x2goclient-4.1.2.3/src/sessionexplorer.cpp:580:41: performance: Function parameter 'path' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/sessionexplorer.cpp:584:95: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionexplorer.cpp:593:70: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionexplorer.cpp:599:55: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionexplorer.cpp:613:55: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SmoothTransformation [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionexplorer.cpp:632:13: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] head x2goclient-4.1.2.3/src/sessionexplorer.cpp:640:47: performance: Function parameter 'path' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/sessionexplorer.cpp:644:69: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IniFormat [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionexplorer.cpp:663:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionexplorer.cpp:705:17: style: Local variable 'folders' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/sessionexplorer.h:89:26: note: Shadowed declaration x2goclient-4.1.2.3/src/sessionexplorer.cpp:705:17: note: Shadow variable head x2goclient-4.1.2.3/src/sessionexplorer.cpp:721:17: style: Local variable 'sessions' shadows outer variable [shadowVariable] x2goclient-4.1.2.3/src/sessionexplorer.h:88:27: note: Shadowed declaration x2goclient-4.1.2.3/src/sessionexplorer.cpp:721:17: note: Shadow variable head x2goclient-4.1.2.3/src/sessionexplorer.cpp:739:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionexplorer.cpp:762:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionexplorer.h:73:13: performance: Function 'getCurrentPath()' should return member 'currentPath' by const reference. [returnByReference] head x2goclient-4.1.2.3/src/sessionmanagedialog.cpp:112:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable StyledPanel [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionmanagedialog.cpp:161:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UserRole [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionmanagedialog.cpp:167:72: performance: Function parameter 'path' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/sessionmanagedialog.cpp:177:81: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionmanagedialog.cpp:205:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UserRole [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionmanagedialog.cpp:235:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UserRole [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionmanagedialog.cpp:250:75: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UserRole [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionmanagedialog.cpp:259:75: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UserRole [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionmanagedialog.cpp:268:75: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UserRole [valueFlowBailoutIncompleteVar] 2.13.0 x2goclient-4.1.2.3/src/sessionmanagedialog.cpp:47:18: style: Variable 'ok' can be declared as pointer to const [constVariablePointer] 2.13.0 x2goclient-4.1.2.3/src/sessionmanagedialog.cpp:92:16: style: Variable 'sc' can be declared as pointer to const [constVariablePointer] head x2goclient-4.1.2.3/src/sessionwidget.cpp:287:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionwidget.cpp:394:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionwidget.cpp:417:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionwidget.cpp:41:57: performance: Function parameter 'id' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/sessionwidget.cpp:41:76: style:inconclusive: Function 'SessionWidget' argument 3 names different: declaration 'mv' definition 'mw'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/sessionwidget.h:38:65: note: Function 'SessionWidget' argument 3 names different: declaration 'mv' definition 'mw'. x2goclient-4.1.2.3/src/sessionwidget.cpp:41:76: note: Function 'SessionWidget' argument 3 names different: declaration 'mv' definition 'mw'. head x2goclient-4.1.2.3/src/sessionwidget.cpp:509:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Normal [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionwidget.cpp:522:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionwidget.cpp:72:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable StyledPanel [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionwidget.cpp:802:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionwidget.cpp:824:78: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sessionwidget.cpp:957:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Accepted [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/settingswidget.cpp:107:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable debugging [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/settingswidget.cpp:330:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FramelessWindowHint [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/settingswidget.cpp:370:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sessionId [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/settingswidget.cpp:37:42: performance: Function parameter 'id' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/settingswidget.cpp:533:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sessionId [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sharewidget.cpp:158:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sharewidget.cpp:200:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sharewidget.cpp:215:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sessionId [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sharewidget.cpp:301:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sessionId [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sharewidget.cpp:331:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sharewidget.cpp:39:36: performance: Function parameter 'id' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/sharewidget.cpp:56:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoEditTriggers [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1084:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1205:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SSH_AUTH_METHOD_INTERACTIVE [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1272:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SSH_AUTH_SUCCESS [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1377:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1578:82: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1646:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1840:90: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sshmasterconnection.cpp:1908:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sshmasterconnection.cpp:199:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sshmasterconnection.cpp:2112:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sshmasterconnection.cpp:2258:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SHUT_RDWR [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sshmasterconnection.cpp:301:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sshmasterconnection.cpp:314:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SSH_AGAIN [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sshmasterconnection.cpp:366:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AF_INET [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sshmasterconnection.cpp:537:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SSH_LOG_NOLOG [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sshmasterconnection.cpp:779:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SSH_OPTIONS_HOST [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sshmasterconnection.cpp:905:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SSH_SERVER_ERROR [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sshmasterconnection.cpp:989:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable null [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sshmasterconnection.h:109:13: performance: Function 'getHost()' should return member 'host' by const reference. [returnByReference] head x2goclient-4.1.2.3/src/sshmasterconnection.h:113:13: performance: Function 'getUser()' should return member 'user' by const reference. [returnByReference] head x2goclient-4.1.2.3/src/sshprocess.cpp:128:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sshprocess.cpp:387:135: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sshprocess.cpp:551:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NormalExit [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sshprocess.cpp:71:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Running [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/sshprocess.h:43:13: performance: Function 'getSource()' should return member 'scpSource' by const reference. [returnByReference] head x2goclient-4.1.2.3/src/userbutton.cpp:24:54: style:inconclusive: Function 'UserButton' argument 2 names different: declaration 'parent' definition 'par'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/userbutton.h:34:44: note: Function 'UserButton' argument 2 names different: declaration 'parent' definition 'par'. x2goclient-4.1.2.3/src/userbutton.cpp:24:54: note: Function 'UserButton' argument 2 names different: declaration 'parent' definition 'par'. head x2goclient-4.1.2.3/src/userbutton.cpp:24:67: performance: Function parameter 'name' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/userbutton.cpp:24:67: style:inconclusive: Function 'UserButton' argument 3 names different: declaration 'username' definition 'name'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/userbutton.h:35:24: note: Function 'UserButton' argument 3 names different: declaration 'username' definition 'name'. x2goclient-4.1.2.3/src/userbutton.cpp:24:67: note: Function 'UserButton' argument 3 names different: declaration 'username' definition 'name'. head x2goclient-4.1.2.3/src/userbutton.cpp:25:34: performance: Function parameter 'fullName' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/userbutton.cpp:25:53: style: Parameter 'foto' can be declared as reference to const [constParameterReference] head x2goclient-4.1.2.3/src/userbutton.cpp:25:69: style:inconclusive: Function 'UserButton' argument 6 names different: declaration 'backGround' definition 'bgpal'. [funcArgNamesDifferent] x2goclient-4.1.2.3/src/userbutton.h:36:41: note: Function 'UserButton' argument 6 names different: declaration 'backGround' definition 'bgpal'. x2goclient-4.1.2.3/src/userbutton.cpp:25:69: note: Function 'UserButton' argument 6 names different: declaration 'backGround' definition 'bgpal'. head x2goclient-4.1.2.3/src/userbutton.cpp:29:5: performance: Variable 'user' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] head x2goclient-4.1.2.3/src/userbutton.cpp:30:5: performance: Variable 'fname' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] head x2goclient-4.1.2.3/src/userbutton.cpp:31:5: performance: Variable 'image' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] head x2goclient-4.1.2.3/src/userbutton.cpp:32:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoFocus [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/userbutton.h:39:11: performance: Function 'username()' should return member 'user' by const reference. [returnByReference] head x2goclient-4.1.2.3/src/userbutton.h:40:11: performance: Function 'fullName()' should return member 'fname' by const reference. [returnByReference] head x2goclient-4.1.2.3/src/x2gosettings.cpp:26:36: performance: Function parameter 'fileContent' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/x2gosettings.cpp:33:5: warning: Class 'X2goSettings' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] head x2goclient-4.1.2.3/src/x2gosettings.cpp:33:5: warning: Class 'X2goSettings' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] head x2goclient-4.1.2.3/src/x2gosettings.cpp:38:38: performance: Function parameter 'group' should be passed by const reference. [passedByValue] head x2goclient-4.1.2.3/src/x2gosettings.cpp:44:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IniFormat [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/x2goutils.cpp:106:85: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Ok [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/x2goutils.cpp:122:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Warning [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/src/x2goutils.cpp:126:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Critical [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/x2gohelper/x2gohelper.cpp:35:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TH32CS_SNAPPROCESS [valueFlowBailoutIncompleteVar] head x2goclient-4.1.2.3/x2gohelper/x2gohelper.cpp:77:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SYNCHRONIZE [valueFlowBailoutIncompleteVar] DONE