2021-09-22 06:46
ftp://ftp.de.debian.org/debian/pool/main/w/whowatch/whowatch_1.8.6.orig.tar.gz
cppcheck-options: --library=posix --library=gnu --library=bsd -j1 --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -rp=temp -D__GNUC__ --platform=unix64 temp
platform: Linux-5.4.0-86-generic-x86_64-with-glibc2.29
python: 3.8.10
client-version: 1.3.12
compiler: g++ (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
cppcheck: head 2.5
head-info: 255dc0484 (2021-09-21 19:25:41 +0200)
count: 29 32
elapsed-time: 1.4 1.3
head-timing-info:
 Tokenizer::simplifyTokens1: 0.170485s (avg. 0.0131142s - 13 result(s))
 Tokenizer::simplifyTokens1::ValueFlow: 0.099045s (avg. 0.00761885s - 13 result(s))
 Tokenizer::simplifyTokens1::createSymbolDatabase: 0.02201s (avg. 0.00169308s - 13 result(s))
 Tokenizer::createTokens: 0.02163s (avg. 0.001545s - 14 result(s))
 Tokenizer::simplifyTokens1::setValueType: 0.009823s (avg. 0.000755615s - 13 result(s))
 Overall time: 0.376373s

old-timing-info:
 Tokenizer::simplifyTokens1: 0.160059s (avg. 0.0123122s - 13 result(s))
 Tokenizer::simplifyTokens1::ValueFlow: 0.092608s (avg. 0.00712369s - 13 result(s))
 Tokenizer::createTokens: 0.021235s (avg. 0.00151679s - 14 result(s))
 Tokenizer::simplifyTokens1::createSymbolDatabase: 0.020773s (avg. 0.00159792s - 13 result(s))
 Tokenizer::simplifyTokens1::setValueType: 0.009227s (avg. 0.000709769s - 13 result(s))
 Overall time: 0.353888s

head results:
whowatch-1.8.6/src/block.c:101:22: style: Parameter 'p' can be declared with const [constParameter]
whowatch-1.8.6/src/block.c:75:23: portability: 'tmp->_block_t' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer]
whowatch-1.8.6/src/block.c:108:47: portability: 'tmp->_block_t' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer]
whowatch-1.8.6/src/owner.c:46:6: portability: Non reentrant function 'getpwuid' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getpwuid_r'. [prohibitedgetpwuidCalled]
whowatch-1.8.6/src/owner.c:45:9: warning: Either the condition '!p' is redundant or there is possible null pointer dereference: p. [nullPointerRedundantCheck]
whowatch-1.8.6/src/owner.c:44:6: note: Assuming that condition '!p' is not redundant
whowatch-1.8.6/src/owner.c:45:9: note: Null pointer dereference
whowatch-1.8.6/src/plist.c:322:2: style: Obsolescent function 'bzero' called. It is recommended to use 'memset' instead. [prohibitedbzeroCalled]
whowatch-1.8.6/src/plist.c:23:6: warning: Either the condition '!z' is redundant or there is possible null pointer dereference: p. [nullPointerRedundantCheck]
whowatch-1.8.6/src/plist.c:93:7: note: Assuming that condition '!z' is not redundant
whowatch-1.8.6/src/plist.c:101:16: note: Calling function 'pstat_update', 1st argument 'z' value is 0
whowatch-1.8.6/src/plist.c:23:6: note: Null pointer dereference
whowatch-1.8.6/src/plist.c:96:10: warning: Either the condition '!z' is redundant or there is possible null pointer dereference: z. [nullPointerRedundantCheck]
whowatch-1.8.6/src/plist.c:93:7: note: Assuming that condition '!z' is not redundant
whowatch-1.8.6/src/plist.c:96:10: note: Null pointer dereference
whowatch-1.8.6/src/plist.c:98:3: warning: Either the condition '!z' is redundant or there is possible null pointer dereference: z. [nullPointerRedundantCheck]
whowatch-1.8.6/src/plist.c:93:7: note: Assuming that condition '!z' is not redundant
whowatch-1.8.6/src/plist.c:98:3: note: Null pointer dereference
whowatch-1.8.6/src/plist.c:100:3: warning: Either the condition '!z' is redundant or there is possible null pointer dereference: z. [nullPointerRedundantCheck]
whowatch-1.8.6/src/plist.c:93:7: note: Assuming that condition '!z' is not redundant
whowatch-1.8.6/src/plist.c:100:3: note: Null pointer dereference
whowatch-1.8.6/src/plist.c:146:22: warning: Either the condition '!p' is redundant or there is possible null pointer dereference: p. [nullPointerRedundantCheck]
whowatch-1.8.6/src/plist.c:148:6: note: Assuming that condition '!p' is not redundant
whowatch-1.8.6/src/plist.c:146:22: note: Null pointer dereference
whowatch-1.8.6/src/plist.c:311:8: warning: Redundant assignment of 'w->vy' to itself. [selfAssignment]
whowatch-1.8.6/src/plist.c:138:28: style: Variable 'c' can be declared with const [constVariable]
whowatch-1.8.6/src/plist.c:211:17: style: Variable 'n' is assigned a value that is never used. [unreadVariable]
whowatch-1.8.6/src/pluglib.c:29:4: style: Variable 'n' is assigned a value that is never used. [unreadVariable]
whowatch-1.8.6/src/pluglib.c:56:4: style: Variable 'n' is assigned a value that is never used. [unreadVariable]
whowatch-1.8.6/src/proc_plugin.c:30:0: error: #error Could not determine ticks per second [preprocessorErrorDirective]
whowatch-1.8.6/src/proctree.c:59:5: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled]
whowatch-1.8.6/src/proctree.c:59:13: warning: Either the condition 'd<0' is redundant or there is possible null pointer dereference: d. [nullPointerRedundantCheck]
whowatch-1.8.6/src/proctree.c:180:6: note: Assuming that condition 'd<0' is not redundant
whowatch-1.8.6/src/proctree.c:182:25: note: Calling function 'get_pinfo', 2nd argument 'd' value is 0
whowatch-1.8.6/src/proctree.c:59:13: note: Null pointer dereference
whowatch-1.8.6/src/proctree.c:180:6: style: A pointer can not be negative so it is either pointless or an error to check if it is. [pointerLessThanZero]
whowatch-1.8.6/src/proctree.c:93:32: style:inconclusive: Function 'find_by_pid' argument 1 names different: declaration 'pid' definition 'n'. [funcArgNamesDifferent]
whowatch-1.8.6/src/proctree.h:23:32: note: Function 'find_by_pid' argument 1 names different: declaration 'pid' definition 'n'.
whowatch-1.8.6/src/proctree.c:93:32: note: Function 'find_by_pid' argument 1 names different: declaration 'pid' definition 'n'.
whowatch-1.8.6/src/proctree.c:216:31: style:inconclusive: Function 'tree_start' argument 1 names different: declaration 'root' definition 'root_pid'. [funcArgNamesDifferent]
whowatch-1.8.6/src/proctree.h:24:31: note: Function 'tree_start' argument 1 names different: declaration 'root' definition 'root_pid'.
whowatch-1.8.6/src/proctree.c:216:31: note: Function 'tree_start' argument 1 names different: declaration 'root' definition 'root_pid'.
whowatch-1.8.6/src/proctree.c:216:45: style:inconclusive: Function 'tree_start' argument 2 names different: declaration 'start' definition 'start_pid'. [funcArgNamesDifferent]
whowatch-1.8.6/src/proctree.h:24:41: note: Function 'tree_start' argument 2 names different: declaration 'start' definition 'start_pid'.
whowatch-1.8.6/src/proctree.c:216:45: note: Function 'tree_start' argument 2 names different: declaration 'start' definition 'start_pid'.
whowatch-1.8.6/src/proctree.c:245:44: style:inconclusive: Function 'tree_string' argument 2 names different: declaration 'proc' definition 'p'. [funcArgNamesDifferent]
whowatch-1.8.6/src/proctree.h:26:44: note: Function 'tree_string' argument 2 names different: declaration 'proc' definition 'p'.
whowatch-1.8.6/src/proctree.c:245:44: note: Function 'tree_string' argument 2 names different: declaration 'proc' definition 'p'.
whowatch-1.8.6/src/proctree.c:57:8: style: Local variable 'buf' shadows outer variable [shadowVariable]
whowatch-1.8.6/src/proctree.c:243:13: note: Shadowed declaration
whowatch-1.8.6/src/proctree.c:57:8: note: Shadow variable
whowatch-1.8.6/src/ulist.c:116:18: warning: Either the condition '(fd=open("/var/run/utmp",O_RDONLY))==-1' is redundant or read() argument nr 1 can have invalid value. The value is -1 but the valid values are '0:'. [invalidFunctionArg]
whowatch-1.8.6/src/ulist.c:115:39: note: Assuming that condition '(fd=open("/var/run/utmp",O_RDONLY))==-1' is not redundant
whowatch-1.8.6/src/ulist.c:116:18: note: Invalid argument
whowatch-1.8.6/src/user_plugin.c:21:7: portability: Non reentrant function 'getpwnam' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getpwnam_r'. [prohibitedgetpwnamCalled]
whowatch-1.8.6/src/whowatch.c:181:17: style: Local variable 'win' shadows outer variable [shadowVariable]
whowatch-1.8.6/src/whowatch.c:8:19: note: Shadowed declaration
whowatch-1.8.6/src/whowatch.c:181:17: note: Shadow variable
whowatch-1.8.6/src/plist.c:23:6: warning: Null pointer dereference: p [ctunullpointer]
whowatch-1.8.6/src/plist.c:93:7: note: Assuming that condition '!z' is not redundant
whowatch-1.8.6/src/plist.c:101:15: note: Calling function pstat_update, 1st argument is null
whowatch-1.8.6/src/plist.c:23:6: note: Dereferencing argument p that is null
diff:
head whowatch-1.8.6/src/block.c:101:22: style: Parameter 'p' can be declared with const [constParameter]
2.5 whowatch-1.8.6/src/owner.c:52:2: warning: Either the condition '!p' is redundant or there is possible null pointer dereference: p. [nullPointerRedundantCheck]
     whowatch-1.8.6/src/owner.c:44:6: note: Assuming that condition '!p' is not redundant
     whowatch-1.8.6/src/owner.c:52:2: note: Null pointer dereference
2.5 whowatch-1.8.6/src/owner.c:53:2: warning: Either the condition '!p' is redundant or there is possible null pointer dereference: p. [nullPointerRedundantCheck]
     whowatch-1.8.6/src/owner.c:44:6: note: Assuming that condition '!p' is not redundant
     whowatch-1.8.6/src/owner.c:53:2: note: Null pointer dereference
2.5 whowatch-1.8.6/src/plist.c:107:3: warning: Either the condition '!z' is redundant or there is possible null pointer dereference: z. [nullPointerRedundantCheck]
     whowatch-1.8.6/src/plist.c:93:7: note: Assuming that condition '!z' is not redundant
     whowatch-1.8.6/src/plist.c:107:3: note: Null pointer dereference
head whowatch-1.8.6/src/plist.c:138:28: style: Variable 'c' can be declared with const [constVariable]
2.5 whowatch-1.8.6/src/proctree.c:194:11: warning: Either the condition 'd<0' is redundant or there is possible null pointer dereference: d. [nullPointerRedundantCheck]
     whowatch-1.8.6/src/proctree.c:180:6: note: Assuming that condition 'd<0' is not redundant
     whowatch-1.8.6/src/proctree.c:194:11: note: Null pointer dereference
2.5 whowatch-1.8.6/src/ulist.c:125:8: warning: Either the condition '(fd=open("/var/run/utmp",O_RDONLY))==-1' is redundant or close() argument nr 1 can have invalid value. The value is -1 but the valid values are '0:'. [invalidFunctionArg]
     whowatch-1.8.6/src/ulist.c:115:39: note: Assuming that condition '(fd=open("/var/run/utmp",O_RDONLY))==-1' is not redundant
     whowatch-1.8.6/src/ulist.c:125:8: note: Invalid argument


DONE