2022-06-25 20:04 ftp://ftp.de.debian.org/debian/pool/main/v/vte/vte_0.28.2.orig.tar.xz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j2 platform: Linux-5.4.0-110-generic-x86_64-with-glibc2.29 python: 3.8.10 client-version: 1.3.24 compiler: g++ (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0 cppcheck: head 2.8 head-info: 242afc3 (2022-06-25 21:42:55 +0200) count: 56 56 elapsed-time: 3.3 3.4 head-timing-info: Overall time: 0s old-timing-info: Overall time: 0s head results: vte-0.28.2/gnome-pty-helper/gnome-pty-helper.c:467:0: error: #error "No means to drop privileges! Huge security risk! Won't compile." [preprocessorErrorDirective] vte-0.28.2/gnome-pty-helper/gnome-login-support.c:52:24: portability: Non reentrant function 'ttyname' called. For threadsafe applications it is recommended to use the reentrant replacement function 'ttyname_r'. [prohibitedttynameCalled] vte-0.28.2/gnome-pty-helper/gnome-login-support.c:114:29: portability: Non reentrant function 'getgrnam' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getgrnam_r'. [prohibitedgetgrnamCalled] vte-0.28.2/gnome-pty-helper/gnome-login-support.c:240:15: portability: Non reentrant function 'getgrnam' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getgrnam_r'. [prohibitedgetgrnamCalled] vte-0.28.2/gnome-pty-helper/gnome-login-support.c:227:31: style:inconclusive: Function 'openpty' argument 2 names different: declaration 'slavefd' definition 'slave_fd'. [funcArgNamesDifferent] vte-0.28.2/gnome-pty-helper/gnome-login-support.h:25:35: note: Function 'openpty' argument 2 names different: declaration 'slavefd' definition 'slave_fd'. vte-0.28.2/gnome-pty-helper/gnome-login-support.c:227:31: note: Function 'openpty' argument 2 names different: declaration 'slavefd' definition 'slave_fd'. vte-0.28.2/gnome-pty-helper/gnome-login-support.c:311:23: style:inconclusive: Function 'n_read' argument 2 names different: declaration 'buffer' definition 'buf'. [funcArgNamesDifferent] vte-0.28.2/gnome-pty-helper/gnome-login-support.h:36:27: note: Function 'n_read' argument 2 names different: declaration 'buffer' definition 'buf'. vte-0.28.2/gnome-pty-helper/gnome-login-support.c:311:23: note: Function 'n_read' argument 2 names different: declaration 'buffer' definition 'buf'. vte-0.28.2/gnome-pty-helper/gnome-login-support.c:311:32: style:inconclusive: Function 'n_read' argument 3 names different: declaration 'size' definition 'count'. [funcArgNamesDifferent] vte-0.28.2/gnome-pty-helper/gnome-login-support.h:36:39: note: Function 'n_read' argument 3 names different: declaration 'size' definition 'count'. vte-0.28.2/gnome-pty-helper/gnome-login-support.c:311:32: note: Function 'n_read' argument 3 names different: declaration 'size' definition 'count'. vte-0.28.2/gnome-pty-helper/gnome-login-support.c:347:30: style:inconclusive: Function 'n_write' argument 2 names different: declaration 'buffer' definition 'buf'. [funcArgNamesDifferent] vte-0.28.2/gnome-pty-helper/gnome-login-support.h:37:34: note: Function 'n_write' argument 2 names different: declaration 'buffer' definition 'buf'. vte-0.28.2/gnome-pty-helper/gnome-login-support.c:347:30: note: Function 'n_write' argument 2 names different: declaration 'buffer' definition 'buf'. vte-0.28.2/gnome-pty-helper/gnome-login-support.c:347:39: style:inconclusive: Function 'n_write' argument 3 names different: declaration 'size' definition 'count'. [funcArgNamesDifferent] vte-0.28.2/gnome-pty-helper/gnome-login-support.h:37:46: note: Function 'n_write' argument 3 names different: declaration 'size' definition 'count'. vte-0.28.2/gnome-pty-helper/gnome-login-support.c:347:39: note: Function 'n_write' argument 3 names different: declaration 'size' definition 'count'. vte-0.28.2/gnome-pty-helper/gnome-login-support.c:34:12: style: Variable 'pid' is assigned a value that is never used. [unreadVariable] vte-0.28.2/gnome-pty-helper/gnome-utmp.c:102:16: style: Variable 'times' is assigned a value that is never used. [unreadVariable] vte-0.28.2/gnome-pty-helper/gnome-utmp.c:238:17: style: Unused variable: tv [unusedVariable] vte-0.28.2/gnome-pty-helper/gnome-utmp.c:280:17: style: Unused variable: tv [unusedVariable] vte-0.28.2/python/vtemodule.c:33:1: error: There is an unknown macro here somewhere. Configuration is required. If DL_EXPORT is a macro then please configure it. [unknownMacro] vte-0.28.2/src/keymap.c:53:0: error: #error No termcap?? [preprocessorErrorDirective] vte-0.28.2/src/iso2022.c:327:9: style: Variable 'i' is reassigned a value before the old one has been used. [redundantAssignment] vte-0.28.2/src/iso2022.c:326:4: note: i is assigned vte-0.28.2/src/iso2022.c:327:9: note: i is overwritten vte-0.28.2/src/keysyms.c:2:15: error: syntax error: keyword 'return' is not allowed in global scope [syntaxError] vte-0.28.2/src/iso2022.c:1688:24: style: Variable 'sequence_length' is assigned a value that is never used. [unreadVariable] vte-0.28.2/src/marshal.c:65:56: style:inconclusive: Function '_vte_marshal_VOID__INT_INT' argument 2 names different: declaration 'return_value' definition 'G_GNUC_UNUSED'. [funcArgNamesDifferent] vte-0.28.2/src/marshal.c:58:64: note: Function '_vte_marshal_VOID__INT_INT' argument 2 names different: declaration 'return_value' definition 'G_GNUC_UNUSED'. vte-0.28.2/src/marshal.c:65:56: note: Function '_vte_marshal_VOID__INT_INT' argument 2 names different: declaration 'return_value' definition 'G_GNUC_UNUSED'. vte-0.28.2/src/marshal.c:68:59: style:inconclusive: Function '_vte_marshal_VOID__INT_INT' argument 5 names different: declaration 'invocation_hint' definition 'G_GNUC_UNUSED'. [funcArgNamesDifferent] vte-0.28.2/src/marshal.c:61:64: note: Function '_vte_marshal_VOID__INT_INT' argument 5 names different: declaration 'invocation_hint' definition 'G_GNUC_UNUSED'. vte-0.28.2/src/marshal.c:68:59: note: Function '_vte_marshal_VOID__INT_INT' argument 5 names different: declaration 'invocation_hint' definition 'G_GNUC_UNUSED'. vte-0.28.2/src/marshal.c:108:62: style:inconclusive: Function '_vte_marshal_VOID__OBJECT_OBJECT' argument 2 names different: declaration 'return_value' definition 'G_GNUC_UNUSED'. [funcArgNamesDifferent] vte-0.28.2/src/marshal.c:101:70: note: Function '_vte_marshal_VOID__OBJECT_OBJECT' argument 2 names different: declaration 'return_value' definition 'G_GNUC_UNUSED'. vte-0.28.2/src/marshal.c:108:62: note: Function '_vte_marshal_VOID__OBJECT_OBJECT' argument 2 names different: declaration 'return_value' definition 'G_GNUC_UNUSED'. vte-0.28.2/src/marshal.c:111:65: style:inconclusive: Function '_vte_marshal_VOID__OBJECT_OBJECT' argument 5 names different: declaration 'invocation_hint' definition 'G_GNUC_UNUSED'. [funcArgNamesDifferent] vte-0.28.2/src/marshal.c:104:70: note: Function '_vte_marshal_VOID__OBJECT_OBJECT' argument 5 names different: declaration 'invocation_hint' definition 'G_GNUC_UNUSED'. vte-0.28.2/src/marshal.c:111:65: note: Function '_vte_marshal_VOID__OBJECT_OBJECT' argument 5 names different: declaration 'invocation_hint' definition 'G_GNUC_UNUSED'. vte-0.28.2/src/marshal.c:151:60: style:inconclusive: Function '_vte_marshal_VOID__STRING_UINT' argument 2 names different: declaration 'return_value' definition 'G_GNUC_UNUSED'. [funcArgNamesDifferent] vte-0.28.2/src/marshal.c:144:68: note: Function '_vte_marshal_VOID__STRING_UINT' argument 2 names different: declaration 'return_value' definition 'G_GNUC_UNUSED'. vte-0.28.2/src/marshal.c:151:60: note: Function '_vte_marshal_VOID__STRING_UINT' argument 2 names different: declaration 'return_value' definition 'G_GNUC_UNUSED'. vte-0.28.2/src/marshal.c:154:63: style:inconclusive: Function '_vte_marshal_VOID__STRING_UINT' argument 5 names different: declaration 'invocation_hint' definition 'G_GNUC_UNUSED'. [funcArgNamesDifferent] vte-0.28.2/src/marshal.c:147:68: note: Function '_vte_marshal_VOID__STRING_UINT' argument 5 names different: declaration 'invocation_hint' definition 'G_GNUC_UNUSED'. vte-0.28.2/src/marshal.c:154:63: note: Function '_vte_marshal_VOID__STRING_UINT' argument 5 names different: declaration 'invocation_hint' definition 'G_GNUC_UNUSED'. vte-0.28.2/src/marshal.c:194:58: style:inconclusive: Function '_vte_marshal_VOID__UINT_UINT' argument 2 names different: declaration 'return_value' definition 'G_GNUC_UNUSED'. [funcArgNamesDifferent] vte-0.28.2/src/marshal.c:187:66: note: Function '_vte_marshal_VOID__UINT_UINT' argument 2 names different: declaration 'return_value' definition 'G_GNUC_UNUSED'. vte-0.28.2/src/marshal.c:194:58: note: Function '_vte_marshal_VOID__UINT_UINT' argument 2 names different: declaration 'return_value' definition 'G_GNUC_UNUSED'. vte-0.28.2/src/marshal.c:197:61: style:inconclusive: Function '_vte_marshal_VOID__UINT_UINT' argument 5 names different: declaration 'invocation_hint' definition 'G_GNUC_UNUSED'. [funcArgNamesDifferent] vte-0.28.2/src/marshal.c:190:66: note: Function '_vte_marshal_VOID__UINT_UINT' argument 5 names different: declaration 'invocation_hint' definition 'G_GNUC_UNUSED'. vte-0.28.2/src/marshal.c:197:61: note: Function '_vte_marshal_VOID__UINT_UINT' argument 5 names different: declaration 'invocation_hint' definition 'G_GNUC_UNUSED'. vte-0.28.2/src/vtepty.h:20:0: error: #error "Only can be included directly." [preprocessorErrorDirective] vte-0.28.2/src/slowcat.c:66:10: style: Variable 'bytes' is assigned a value that is never used. [unreadVariable] vte-0.28.2/src/ssfe.c:41:0: error: #error No termcap?? [preprocessorErrorDirective] vte-0.28.2/src/trie.c:604:15: style: Condition 'best!=NULL' is always true [knownConditionTrueFalse] vte-0.28.2/src/trie.c:53:6: style: struct member 'char_class_data::i' is never used. [unusedStructMember] vte-0.28.2/src/trie.c:54:8: style: struct member 'char_class_data::s' is never used. [unusedStructMember] vte-0.28.2/src/table.c:601:20: style:inconclusive: Function '_vte_table_match' argument 2 names different: declaration 'pattern' definition 'candidate'. [funcArgNamesDifferent] vte-0.28.2/src/table.h:44:25: note: Function '_vte_table_match' argument 2 names different: declaration 'pattern' definition 'candidate'. vte-0.28.2/src/table.c:601:20: note: Function '_vte_table_match' argument 2 names different: declaration 'pattern' definition 'candidate'. vte-0.28.2/src/table.c:418:8: style: Variable 'i' is assigned a value that is never used. [unreadVariable] vte-0.28.2/src/vteapp.c:982:10: warning: Either the condition 'consolefd!=-1' is redundant or close() argument nr 1 can have invalid value. The value is -1 but the valid values are '0:'. [invalidFunctionArg] vte-0.28.2/src/vteapp.c:947:17: note: Assuming that condition 'consolefd!=-1' is not redundant vte-0.28.2/src/vteapp.c:982:10: note: Invalid argument vte-0.28.2/src/vteapp.c:985:2: error: Resource leak: consolefd [resourceLeak] vte-0.28.2/src/vteapp.c:62:9: style: Variable 'window' is assigned a value that is never used. [unreadVariable] vte-0.28.2/src/vteapp.c:79:11: style: Variable 'terminal' is assigned a value that is never used. [unreadVariable] vte-0.28.2/src/vteapp.c:944:27: style: Variable 'yes' is assigned a value that is never used. [unreadVariable] vte-0.28.2/src/vteapp.c:944:32: style: Unused variable: watch [unusedVariable] vte-0.28.2/src/vteapp.c:945:15: style: Unused variable: channel [unusedVariable] vte-0.28.2/src/vteaccess.c:1314:9: style: Variable 'mapped' is assigned a value that is never used. [unreadVariable] vte-0.28.2/src/vteconv.c:241:15: style: Variable 'in_converted' is assigned a value that is never used. [unreadVariable] vte-0.28.2/src/vteconv.c:242:16: style: Variable 'out_converted' is assigned a value that is never used. [unreadVariable] vte-0.28.2/src/vtedraw.c:848:24: style:inconclusive: Function '_vte_draw_set_background_image' argument 4 names different: declaration 'file' definition 'filename'. [funcArgNamesDifferent] vte-0.28.2/src/vtedraw.h:80:21: note: Function '_vte_draw_set_background_image' argument 4 names different: declaration 'file' definition 'filename'. vte-0.28.2/src/vtedraw.c:848:24: note: Function '_vte_draw_set_background_image' argument 4 names different: declaration 'file' definition 'filename'. vte-0.28.2/src/vtedraw.c:916:25: style:inconclusive: Function '_vte_draw_set_text_font' argument 3 names different: declaration 'anti_alias' definition 'antialias'. [funcArgNamesDifferent] vte-0.28.2/src/vtedraw.h:92:30: note: Function '_vte_draw_set_text_font' argument 3 names different: declaration 'anti_alias' definition 'antialias'. vte-0.28.2/src/vtedraw.c:916:25: note: Function '_vte_draw_set_text_font' argument 3 names different: declaration 'anti_alias' definition 'antialias'. vte-0.28.2/src/vtedraw.c:1051:15: style: Variable 'n_cr_glyphs' is assigned a value that is never used. [unreadVariable] vte-0.28.2/src/vterowdata.c:152:10: style: Redundant initialization for 'i'. The initialized value is overwritten before it is read. [redundantInitialization] vte-0.28.2/src/vterowdata.c:147:12: note: i is initialized vte-0.28.2/src/vterowdata.c:152:10: note: i is overwritten vte-0.28.2/src/vtestream-file.h:206:15: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] vte-0.28.2/src/vtestream-file.h:206:9: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] vte-0.28.2/src/vtestream-file.h:206:20: style: Variable 'data' is assigned a value that is never used. [unreadVariable] vte-0.28.2/src/vteseq.c:277:10: style: Variable 'initial' is reassigned a value before the old one has been used. [redundantAssignment] vte-0.28.2/src/vteseq.c:275:10: note: initial is assigned vte-0.28.2/src/vteseq.c:277:10: note: initial is overwritten vte-0.28.2/src/vteseq.c:96:30: style: Parameter 'c' can be declared as pointer to const [constParameter] vte-0.28.2/src/vteseq.c:1458:9: style: Variable 'start' is assigned a value that is never used. [unreadVariable] vte-0.28.2/src/vteseq.c:2206:7: style: Variable 'end' is assigned a value that is never used. [unreadVariable] vte-0.28.2/src/vteseq.c:2209:7: style: Variable 'end' is assigned a value that is never used. [unreadVariable] diff: head vte-0.28.2/src/vteseq.c:96:30: style: Parameter 'c' can be declared as pointer to const [constParameter] 2.8 vte-0.28.2/src/vteseq.c:96:30: style: Parameter 'c' can be declared with const [constParameter] DONE