2022-07-01 17:44
ftp://ftp.de.debian.org/debian/pool/main/v/vboot-utils/vboot-utils_0~R99-14469.B.orig.tar.gz
cppcheck-options: --library=posix --library=gnu  --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j1
platform: Linux-5.4.0-110-generic-x86_64-with-glibc2.29
python: 3.8.10
client-version: 1.3.24
compiler: g++ (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
cppcheck: head 2.8
head-info: 596f75e (2022-07-01 10:48:32 +0200)
count: 152 152
elapsed-time: 10.5 11.9
head-timing-info:
 Tokenizer::simplifyTokens1: 9.43727s (avg. 0.0479049s - 197 result(s))
 Tokenizer::simplifyTokens1::ValueFlow: 8.13071s (avg. 0.0412727s - 197 result(s))
 Tokenizer::simplifyTokens1::createSymbolDatabase: 0.631415s (avg. 0.00320515s - 197 result(s))
 Tokenizer::createTokens: 0.280545s (avg. 0.00142409s - 197 result(s))
 Tokenizer::simplifyTokens1::setValueType: 0.184982s (avg. 0.000938995s - 197 result(s))
 Overall time: 19.445s

old-timing-info:
 Tokenizer::simplifyTokens1: 10.8301s (avg. 0.0549753s - 197 result(s))
 Tokenizer::simplifyTokens1::ValueFlow: 9.49409s (avg. 0.0481934s - 197 result(s))
 Tokenizer::simplifyTokens1::createSymbolDatabase: 0.6671s (avg. 0.00338629s - 197 result(s))
 Tokenizer::createTokens: 0.278671s (avg. 0.00141457s - 197 result(s))
 Tokenizer::simplifyTokens1::setValueType: 0.184957s (avg. 0.000938868s - 197 result(s))
 Overall time: 22.2143s

head results:
cgpt/cgpt_common.c:530:29: style: Condition 'code_point<=0x10FFFF' is always true [knownConditionTrueFalse]
cgpt/cgpt_common.c:517:7: note: Assuming that condition 'code_point<=0x10FFFF' is not redundant
cgpt/cgpt_common.c:530:29: note: Condition 'code_point<=0x10FFFF' is always true
cgpt/cgpt_common.c:509:26: style: Variable 'code_point_ready' is assigned a value that is never used. [unreadVariable]
firmware/2lib/2common.c:108:16: portability: 'parent' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer]
firmware/2lib/2context.c:16:34: portability: '(void*)sd' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer]
firmware/2lib/2gbb.c:46:23: portability: '(void*)*keyp' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer]
firmware/2lib/2hmac.c:24:11: style:inconclusive: Boolean expression '!key' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean]
firmware/2lib/2hmac.c:24:18: style:inconclusive: Boolean expression '!mac' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean]
firmware/2lib/2hmac.c:24:11: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition]
firmware/2lib/2kernel.c:113:65: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2misc.c:657:2: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
firmware/2lib/2misc.c:661:2: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
firmware/2lib/2misc.c:665:2: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
firmware/2lib/2misc.c:669:2: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
firmware/2lib/2misc.c:21:49: style: Parameter 'sig' can be declared as pointer to const [constParameter]
firmware/2lib/2misc.c:37:46: portability: '(void*)sd' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer]
firmware/2lib/2nvstorage.c:17:54: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:26:44: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:44:54: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:46:53: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:62:53: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:106:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:110:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:114:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:117:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:123:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:129:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:139:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:151:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:154:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:157:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:164:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:167:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:170:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:173:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:176:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:179:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:182:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:185:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:188:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:191:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:194:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:214:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2nvstorage.c:218:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2rsa.c:36:61: style: Parameter 'a' can be declared as pointer to const [constParameter]
firmware/2lib/2tpm_bootmode.c:50:54: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/2lib/2tpm_bootmode.c:51:45: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/lib/cgptlib/cgptlib_internal.c:302:12: style: Variable 'goodhdr' is assigned a value that is never used. [unreadVariable]
firmware/lib/tpm2_lite/marshaling.c:366:14: style: Parameter 'buffer_space' can be declared as pointer to const [constParameter]
firmware/lib/tpm_lite/tlcl.c:629:45: warning:inconclusive: Possible null pointer dereference: data [nullPointer]
firmware/lib/tpm_lite/tlcl.c:684:26: note: Calling function 'TlclWrite', 2nd argument 'NULL' value is 0
firmware/lib/tpm_lite/tlcl.c:629:45: note: Null pointer dereference
firmware/lib/vboot_kernel.c:487:9: warning: Identical condition and return expression 'rv', return value is always 0 [identicalConditionAfterEarlyExit]
firmware/lib/vboot_kernel.c:485:6: note: If condition 'rv' is true, the function will return/exit
firmware/lib/vboot_kernel.c:487:9: note: Returning identical expression 'rv'
firmware/lib/vboot_kernel.c:301:8: style: Condition 'need_keyblock_valid' is always true [knownConditionTrueFalse]
firmware/lib/vboot_kernel.c:314:8: style: Condition 'need_keyblock_valid' is always true [knownConditionTrueFalse]
firmware/lib/vboot_kernel.c:625:4: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
firmware/lib/vboot_kernel.c:300:19: style: Variable 'keyblock_valid' is assigned a value that is never used. [unreadVariable]
firmware/lib/vboot_kernel.c:313:19: style: Variable 'keyblock_valid' is assigned a value that is never used. [unreadVariable]
firmware/stub/tpm_lite_stub.c:74:13: style: Checking if unsigned expression 'in_len' is less than zero. [unsignedLessThanZero]
futility/cmd_dump_fmap.c:241:55: style: Same expression on both sides of '&&'. [duplicateExpression]
futility/cmd_dump_fmap.c:136:39: portability: 'base_of_rom' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer]
futility/cmd_gbb_utility.c:147:29: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled]
futility/cmd_gbb_utility.c:562:12: style: Variable 'gbb_base' is reassigned a value before the old one has been used. [redundantAssignment]
futility/cmd_gbb_utility.c:543:12: note: gbb_base is assigned
futility/cmd_gbb_utility.c:562:12: note: gbb_base is overwritten
futility/cmd_gbb_utility.c:195:4: style: Variable 'i' is assigned a value that is never used. [unreadVariable]
futility/cmd_gscvd.c:432:3: portability: %zd in format string (no. 2) requires 'ssize_t' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint]
futility/cmd_gscvd.c:520:3: portability: %zd in format string (no. 2) requires 'ssize_t' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint]
futility/cmd_gscvd.c:556:3: portability: %zd in format string (no. 2) requires 'ssize_t' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint]
futility/cmd_gscvd.c:600:4: warning: %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
futility/cmd_load_fmap.c:80:3: warning: %d in format string (no. 3) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
futility/cmd_show.c:240:2: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
futility/cmd_sign.c:362:2: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
futility/cmd_vbutil_firmware.c:287:2: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
futility/dump_kernel_config_lib.c:106:14: style: Condition 'to_skip<0' is always false [knownConditionTrueFalse]
futility/dump_kernel_config_lib.c:105:19: note: Assignment 'to_skip=offset-now', assigned value is greater than -1
futility/dump_kernel_config_lib.c:106:14: note: Condition 'to_skip<0' is always false
futility/dump_kernel_config_lib.c:33:32: portability: 'buf' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer]
futility/file_type_rwsig.c:308:4: warning: %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
futility/file_type_rwsig.c:386:4: warning: %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
futility/file_type_usbpd1.c:146:3: warning: %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
futility/flashrom_drv.c:50:10: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled]
futility/flashrom_drv.c:51:12: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled]
futility/misc.c:77:17: style:inconclusive: Function 'futil_valid_gbb_header' argument 3 names different: declaration 'maxlen' definition 'maxlen_ptr'. [funcArgNamesDifferent]
futility/futility.h:103:17: note: Function 'futil_valid_gbb_header' argument 3 names different: declaration 'maxlen' definition 'maxlen_ptr'.
futility/misc.c:77:17: note: Function 'futil_valid_gbb_header' argument 3 names different: declaration 'maxlen' definition 'maxlen_ptr'.
futility/updater.c:192:10: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled]
futility/updater.c:193:24: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled]
futility/updater.c:1323:7: style: Condition 'image' is always true [knownConditionTrueFalse]
futility/updater.c:359:3: warning: %d in format string (no. 3) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
futility/updater.c:359:3: warning: %d in format string (no. 5) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
futility/updater.c:432:3: warning: %d in format string (no. 5) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
futility/updater.c:926:3: warning: %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
futility/updater.c:926:3: warning: %d in format string (no. 3) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
futility/updater.c:931:3: warning: %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
futility/updater.c:931:3: warning: %d in format string (no. 3) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
futility/updater.c:371:23: error: Uninitialized struct member: to.data [uninitStructMember]
futility/updater_archive.c:230:7: style: Obsolescent function 'utimes' called. It is recommended to use 'utimensat' instead. [prohibitedutimesCalled]
futility/updater_archive.c:1025:8: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled]
futility/updater_archive.c:1026:13: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled]
futility/updater_quirks.c:190:9: error: Invalid fputc() argument nr 1. The value is -1 but the valid values are '0:'. [invalidFunctionArg]
futility/vb1_helper.c:294:37: style: Parameter 'kblob_data' can be declared as pointer to const [constParameter]
futility/vb1_helper.c:449:16: portability: 'outbuf' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer]
host/arch/arm/lib/crossystem_arch.c:90:3: error: Resource leak: file [resourceLeak]
host/arch/x86/lib/crossystem_arch.c:503:20: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled]
host/arch/x86/lib/crossystem_arch.c:533:20: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled]
host/arch/x86/lib/crossystem_arch.c:594:20: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled]
host/arch/x86/lib/crossystem_arch.c:810:2: warning: %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
host/arch/x86/lib/crossystem_arch.c:366:24: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
host/arch/x86_64/lib/crossystem_arch.c:503:20: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled]
host/arch/x86_64/lib/crossystem_arch.c:533:20: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled]
host/arch/x86_64/lib/crossystem_arch.c:594:20: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled]
host/arch/x86_64/lib/crossystem_arch.c:810:2: warning: %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
host/arch/x86_64/lib/crossystem_arch.c:366:24: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
host/lib/crossystem.c:147:7: style: Condition 'sh' is always true [knownConditionTrueFalse]
host/lib/crossystem.c:174:6: style: Condition 'sh' is always true [knownConditionTrueFalse]
host/lib/crossystem.c:105:3: error: Resource leak: lock_fd [resourceLeak]
host/lib/crossystem.c:336:40: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
host/lib/crossystem.c:339:50: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
host/lib/crossystem.c:348:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
host/lib/crossystem.c:359:31: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
host/lib/crossystem.c:363:31: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
host/lib/crossystem.c:367:37: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
host/lib/extract_vmlinuz.c:32:55: portability: 'kpart_data' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer]
host/lib/extract_vmlinuz.c:37:26: portability: 'kpart_data' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer]
host/lib/extract_vmlinuz.c:49:17: portability: 'kpart_data' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer]
host/lib/extract_vmlinuz.c:49:41: portability: 'kpart_data+vmlinuz_header_offset' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer]
host/lib/extract_vmlinuz.c:67:29: portability: 'kpart_data' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer]
host/lib/extract_vmlinuz.c:70:17: portability: 'vmlinuz' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer]
host/lib/fmap.c:58:38: portability: '(void*)fmap' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer]
host/lib/host_misc.c:98:31: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
tests/futility/test_file_types.c:45:26: style: Parameter 'argv' can be declared as const array [constParameter]
tests/gpt_misc_tests.c:23:11: style: struct member 'mock_part::start' is never used. [unusedStructMember]
tests/gpt_misc_tests.c:24:11: style: struct member 'mock_part::size' is never used. [unusedStructMember]
tests/hmac_test.c:51:2: warning: %d in format string (no. 3) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
tests/subprocess_tests.c:32:2: error: Uninitialized variable: output_buffer [uninitvar]
tests/subprocess_tests.c:96:2: error: Uninitialized variable: output_buffer [uninitvar]
tests/subprocess_tests.c:217:2: error: Uninitialized variable: output_buffer [uninitvar]
tests/subprocess_tests.c:275:2: error: Uninitialized variable: output_buffer [uninitvar]
tests/vb20_kernel_tests.c:39:11: style: struct member 'Anonymous2::kbdata' is never used. [unusedStructMember]
tests/vb20_kernel_tests.c:45:11: style: struct member 'Anonymous3::predata' is never used. [unusedStructMember]
tests/vb20_verify_fw.c:109:2: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
tests/vb20_verify_fw.c:223:2: portability: %zu in format string (no. 2) requires 'size_t' but the argument type is 'ptrdiff_t {aka signed int}'. [invalidPrintfArgType_uint]
tests/vb20_verify_fw.c:119:12: style: Checking if unsigned expression 'size' is less than zero. [unsignedLessThanZero]
tests/vb2_firmware_tests.c:39:11: style: struct member 'Anonymous2::kbdata' is never used. [unusedStructMember]
tests/vb2_firmware_tests.c:44:11: style: struct member 'Anonymous3::predata' is never used. [unusedStructMember]
tests/vb2_gbb_tests.c:45:25: portability: '(void*)gbb' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer]
tests/vb2_gbb_tests.c:193:25: portability: '(void*)rootkey' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer]
tests/vb2_keyblock_fuzzer.c:59:20: portability: 'rbase' is of type 'const void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer]
tests/vb2_misc_tests.c:322:23: style: Variable 'gbbsrc.major_version' is reassigned a value before the old one has been used. [redundantAssignment]
tests/vb2_misc_tests.c:319:23: note: gbbsrc.major_version is assigned
tests/vb2_misc_tests.c:322:23: note: gbbsrc.major_version is overwritten
tests/vb2_misc_tests.c:327:23: style: Variable 'gbbsrc.minor_version' is reassigned a value before the old one has been used. [redundantAssignment]
tests/vb2_misc_tests.c:324:23: note: gbbsrc.minor_version is assigned
tests/vb2_misc_tests.c:327:23: note: gbbsrc.minor_version is overwritten
tests/vb2_misc_tests.c:330:23: style: Variable 'gbbsrc.minor_version' is reassigned a value before the old one has been used. [redundantAssignment]
tests/vb2_misc_tests.c:327:23: note: gbbsrc.minor_version is assigned
tests/vb2_misc_tests.c:330:23: note: gbbsrc.minor_version is overwritten
tests/vboot_kernel2_tests.c:181:18: portability: 'buffer' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer]
utility/crossystem.c:291:18: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled]
utility/crossystem.c:292:25: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled]
utility/load_kernel_test.c:77:2: style:inconclusive: Statements following return, break, continue, goto or throw will never be executed. [unreachableCode]
utility/tpmc.c:486:3: style: Obsolescent function 'bzero' called. It is recommended to use 'memset' instead. [prohibitedbzeroCalled]
utility/tpmc.c:266:5: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
utility/tpmc.c:489:5: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
utility/tpmc.c:698:7: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
firmware/lib/tpm_lite/tlcl.c:629:45: error: Null pointer dereference: data [ctunullpointer]
firmware/lib/tpm_lite/tlcl.c:684:18: note: Calling function TlclWrite, 2nd argument is null
firmware/lib/tpm_lite/tlcl.c:629:45: note: Dereferencing argument data that is null
diff:
head firmware/2lib/2misc.c:21:49: style: Parameter 'sig' can be declared as pointer to const [constParameter]
2.8 firmware/2lib/2misc.c:21:49: style: Parameter 'sig' can be declared with const [constParameter]
head firmware/2lib/2rsa.c:36:61: style: Parameter 'a' can be declared as pointer to const [constParameter]
2.8 firmware/2lib/2rsa.c:36:61: style: Parameter 'a' can be declared with const [constParameter]
head firmware/lib/tpm2_lite/marshaling.c:366:14: style: Parameter 'buffer_space' can be declared as pointer to const [constParameter]
2.8 firmware/lib/tpm2_lite/marshaling.c:366:14: style: Parameter 'buffer_space' can be declared with const [constParameter]
head futility/vb1_helper.c:294:37: style: Parameter 'kblob_data' can be declared as pointer to const [constParameter]
2.8 futility/vb1_helper.c:294:37: style: Parameter 'kblob_data' can be declared with const [constParameter]
head tests/futility/test_file_types.c:45:26: style: Parameter 'argv' can be declared as const array [constParameter]
2.8 tests/futility/test_file_types.c:45:26: style: Parameter 'argv' can be declared with const [constParameter]


DONE