2024-03-26 01:57 ftp://ftp.de.debian.org/debian/pool/main/t/twinkle/twinkle_1.10.2+dfsg.orig.tar.xz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --inline-suppr --disable=missingInclude --suppress=unmatchedSuppression --template=daca2 --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=valueFlowBailoutIncompleteVar -D__GNUC__ --platform=unix64 -j4 platform: Linux-6.1.0-0.deb11.6-amd64-x86_64-with-glibc2.31 python: 3.9.2 client-version: 1.3.45 compiler: g++ (Debian 10.2.1-6) 10.2.1 20210110 cppcheck: head 2.13.0 head-info: 82f05c8 (2024-03-25 22:58:58 +0100) count: 1386 1338 elapsed-time: 14.4 640.8 head-timing-info: Condition::runChecks: 5.33817s (avg. 5.33817s - 1 result(s)) Tokenizer::simplifyTokens1::simplifyTokenList1: 0.705868s (avg. 0.705868s - 1 result(s)) Tokenizer::simplifyTokens1::simplifyTokenList1::setVarId: 0.640542s (avg. 0.640542s - 1 result(s)) Tokenizer::simplifyTokens1::ValueFlow: 0.185465s (avg. 0.185465s - 1 result(s)) Other::runChecks: 0.126937s (avg. 0.126937s - 1 result(s)) Overall time: 6.57203s old-timing-info: Tokenizer::simplifyTokens1::ValueFlow: 626.185s (avg. 626.185s - 1 result(s)) valueFlowConditionExpressions(tokenlist, symboldatabase, errorLogger, *settings): 626.013s (avg. 626.013s - 1 result(s)) Condition::runChecks: 5.45918s (avg. 5.45918s - 1 result(s)) Tokenizer::simplifyTokens1::simplifyTokenList1: 0.776825s (avg. 0.776825s - 1 result(s)) Tokenizer::simplifyTokens1::simplifyTokenList1::setVarId: 0.720964s (avg. 0.720964s - 1 result(s)) Overall time: 632.734s head results: twinkle-1.10.2/src/audio/audio_codecs.cpp:51:21: style: Parameter 'input_buf' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/audio/audio_decoder.cpp:37:18: warning: Member variable 't_audio_decoder::_codec' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/audio/audio_decoder.cpp:135:2: performance: Variable 'gsm_decoder' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/audio/audio_decoder.h:119:2: style: Class 't_gsm_audio_decoder' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/audio/audio_decoder.h:96:17: style: The function 'get_ptime' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_decoder.h:71:17: note: Virtual function in base class twinkle-1.10.2/src/audio/audio_decoder.h:96:17: note: Function in derived class twinkle-1.10.2/src/audio/audio_decoder.h:97:17: style: The function 'decode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_decoder.h:76:17: note: Virtual function in base class twinkle-1.10.2/src/audio/audio_decoder.h:97:17: note: Function in derived class twinkle-1.10.2/src/audio/audio_decoder.h:99:15: style: The function 'valid_payload_size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_decoder.h:88:15: note: Virtual function in base class twinkle-1.10.2/src/audio/audio_decoder.h:99:15: note: Function in derived class twinkle-1.10.2/src/audio/audio_decoder.h:107:17: style: The function 'get_ptime' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_decoder.h:71:17: note: Virtual function in base class twinkle-1.10.2/src/audio/audio_decoder.h:107:17: note: Function in derived class twinkle-1.10.2/src/audio/audio_decoder.h:108:17: style: The function 'decode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_decoder.h:76:17: note: Virtual function in base class twinkle-1.10.2/src/audio/audio_decoder.h:108:17: note: Function in derived class twinkle-1.10.2/src/audio/audio_decoder.h:110:15: style: The function 'valid_payload_size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_decoder.h:88:15: note: Virtual function in base class twinkle-1.10.2/src/audio/audio_decoder.h:110:15: note: Function in derived class twinkle-1.10.2/src/audio/audio_decoder.h:120:11: style: The destructor '~t_gsm_audio_decoder' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_decoder.h:67:11: note: Virtual destructor in base class twinkle-1.10.2/src/audio/audio_decoder.h:120:11: note: Destructor in derived class twinkle-1.10.2/src/audio/audio_decoder.h:122:17: style: The function 'get_ptime' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_decoder.h:71:17: note: Virtual function in base class twinkle-1.10.2/src/audio/audio_decoder.h:122:17: note: Function in derived class twinkle-1.10.2/src/audio/audio_decoder.h:123:17: style: The function 'decode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_decoder.h:76:17: note: Virtual function in base class twinkle-1.10.2/src/audio/audio_decoder.h:123:17: note: Function in derived class twinkle-1.10.2/src/audio/audio_decoder.h:125:15: style: The function 'valid_payload_size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_decoder.h:88:15: note: Virtual function in base class twinkle-1.10.2/src/audio/audio_decoder.h:125:15: note: Function in derived class twinkle-1.10.2/src/audio/audio_decoder.h:201:17: style: The function 'get_ptime' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_decoder.h:71:17: note: Virtual function in base class twinkle-1.10.2/src/audio/audio_decoder.h:201:17: note: Function in derived class twinkle-1.10.2/src/audio/audio_decoder.h:202:17: style: The function 'decode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_decoder.h:76:17: note: Virtual function in base class twinkle-1.10.2/src/audio/audio_decoder.h:202:17: note: Function in derived class twinkle-1.10.2/src/audio/audio_decoder.h:204:15: style: The function 'valid_payload_size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_decoder.h:88:15: note: Virtual function in base class twinkle-1.10.2/src/audio/audio_decoder.h:204:15: note: Function in derived class twinkle-1.10.2/src/audio/audio_device.h:37:1: style: The class 't_audio_io' does not declare a constructor although it has private member variables which likely require initialization. [noConstructor] twinkle-1.10.2/src/audio/audio_device.cpp:91:11: warning: Member variable 't_audio_io::_sample_rate' is not initialized in the constructor. Maybe it should be initialized directly in the class t_audio_io? [uninitDerivedMemberVar] twinkle-1.10.2/src/audio/audio_device.h:74:11: style: The destructor '~t_oss_io' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_device.h:39:11: note: Virtual destructor in base class twinkle-1.10.2/src/audio/audio_device.h:74:11: note: Destructor in derived class twinkle-1.10.2/src/audio/audio_device.h:75:7: style: The function 'enable' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_device.h:40:15: note: Virtual function in base class twinkle-1.10.2/src/audio/audio_device.h:75:7: note: Function in derived class twinkle-1.10.2/src/audio/audio_device.h:76:7: style: The function 'flush' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_device.h:41:15: note: Virtual function in base class twinkle-1.10.2/src/audio/audio_device.h:76:7: note: Function in derived class twinkle-1.10.2/src/audio/audio_device.h:77:6: style: The function 'get_buffer_space' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_device.h:43:14: note: Virtual function in base class twinkle-1.10.2/src/audio/audio_device.h:77:6: note: Function in derived class twinkle-1.10.2/src/audio/audio_device.h:78:6: style: The function 'get_buffer_size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_device.h:45:14: note: Virtual function in base class twinkle-1.10.2/src/audio/audio_device.h:78:6: note: Function in derived class twinkle-1.10.2/src/audio/audio_device.h:79:7: style: The function 'play_buffer_underrun' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_device.h:48:15: note: Virtual function in base class twinkle-1.10.2/src/audio/audio_device.h:79:7: note: Function in derived class twinkle-1.10.2/src/audio/audio_device.h:80:6: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_device.h:50:14: note: Virtual function in base class twinkle-1.10.2/src/audio/audio_device.h:80:6: note: Function in derived class twinkle-1.10.2/src/audio/audio_device.h:81:6: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_device.h:51:14: note: Virtual function in base class twinkle-1.10.2/src/audio/audio_device.h:81:6: note: Function in derived class twinkle-1.10.2/src/audio/audio_device.h:83:7: style: The function 'open' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_device.h:62:15: note: Virtual function in base class twinkle-1.10.2/src/audio/audio_device.h:83:7: note: Function in derived class twinkle-1.10.2/src/audio/audio_encoder.cpp:36:18: warning: Member variable 't_audio_encoder::_codec' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/audio/audio_encoder.cpp:127:2: performance: Variable 'gsm_encoder' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/audio/audio_encoder.h:90:17: style: The function 'encode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_encoder.h:80:17: note: Virtual function in base class twinkle-1.10.2/src/audio/audio_encoder.h:90:17: note: Function in derived class twinkle-1.10.2/src/audio/audio_encoder.h:100:17: style: The function 'encode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_encoder.h:80:17: note: Virtual function in base class twinkle-1.10.2/src/audio/audio_encoder.h:100:17: note: Function in derived class twinkle-1.10.2/src/audio/audio_encoder.h:112:11: style: The destructor '~t_gsm_audio_encoder' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_encoder.h:68:11: note: Virtual destructor in base class twinkle-1.10.2/src/audio/audio_encoder.h:112:11: note: Destructor in derived class twinkle-1.10.2/src/audio/audio_encoder.h:114:17: style: The function 'encode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_encoder.h:80:17: note: Virtual function in base class twinkle-1.10.2/src/audio/audio_encoder.h:114:17: note: Function in derived class twinkle-1.10.2/src/audio/audio_encoder.h:185:17: style: The function 'encode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/audio_encoder.h:80:17: note: Virtual function in base class twinkle-1.10.2/src/audio/audio_encoder.h:185:17: note: Function in derived class twinkle-1.10.2/src/audio/audio_encoder.cpp:312:47: style: Parameter 'sample_buf' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/audio/audio_encoder.cpp:335:47: style: Parameter 'sample_buf' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/audio/audio_encoder.cpp:360:47: style: Parameter 'sample_buf' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/audio/audio_encoder.cpp:383:47: style: Parameter 'sample_buf' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/audio/rtp_telephone_event.h:67:1: style: The struct 't_rtp_telephone_event' does not declare a constructor although it has private member variables which likely require initialization. [noConstructor] twinkle-1.10.2/src/audio/media_buffer.h:47:2: warning:inconclusive: Member variable 't_media_buffer::buffer' is not initialized in the constructor. [uninitMemberVarPrivate] twinkle-1.10.2/src/audio/media_buffer.h:47:2: warning:inconclusive: Member variable 't_media_buffer::buf_size' is not initialized in the constructor. [uninitMemberVarPrivate] twinkle-1.10.2/src/audio/media_buffer.h:47:2: warning:inconclusive: Member variable 't_media_buffer::pos_start' is not initialized in the constructor. [uninitMemberVarPrivate] twinkle-1.10.2/src/audio/media_buffer.h:47:2: warning:inconclusive: Member variable 't_media_buffer::pos_end' is not initialized in the constructor. [uninitMemberVarPrivate] twinkle-1.10.2/src/audio/media_buffer.h:47:2: warning:inconclusive: Member variable 't_media_buffer::empty' is not initialized in the constructor. [uninitMemberVarPrivate] twinkle-1.10.2/src/audio/audio_rx.cpp:266:13: warning: Member variable 't_audio_rx::timestamp' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/audio/audio_rx.cpp:339:3: warning: Class 't_audio_rx' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] twinkle-1.10.2/src/audio/audio_rx.cpp:339:3: warning: Class 't_audio_rx' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] twinkle-1.10.2/src/audio/media_buffer.h:51:2: style: Class 't_media_buffer' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/audio/twinkle_rtp_session.h:47:2: style: Class 't_twinkle_rtp_session' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/audio/dtmf_player.h:76:17: style: The function 'get_payload' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/dtmf_player.h:59:17: note: Virtual function in base class twinkle-1.10.2/src/audio/dtmf_player.h:76:17: note: Function in derived class twinkle-1.10.2/src/audio/dtmf_player.h:92:17: style: The function 'get_payload' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/audio/dtmf_player.h:59:17: note: Virtual function in base class twinkle-1.10.2/src/audio/dtmf_player.h:92:17: note: Function in derived class twinkle-1.10.2/src/audio/audio_rx.cpp:119:14: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/audio/audio_rx.cpp:134:20: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/audio/audio_rx.cpp:875:31: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/audio/audio_rx.cpp:877:27: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/audio/audio_rx.cpp:906:31: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/audio/audio_rx.cpp:908:27: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/audio/audio_rx.cpp:53:6: style: The scope of the variable 'status' can be reduced. [variableScope] twinkle-1.10.2/src/audio/audio_rx.cpp:134:11: style: Variable 'mix_sb' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/audio/audio_session.h:150:7: performance:inconclusive: Technically the member function 't_audio_session::confirm_zrtp_sas' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/audio/audio_session.cpp:550:23: note: Technically the member function 't_audio_session::confirm_zrtp_sas' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/audio/audio_session.h:150:7: note: Technically the member function 't_audio_session::confirm_zrtp_sas' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/audio/audio_session.h:151:7: performance:inconclusive: Technically the member function 't_audio_session::reset_zrtp_sas_confirmation' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/audio/audio_session.cpp:560:23: note: Technically the member function 't_audio_session::reset_zrtp_sas_confirmation' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/audio/audio_session.h:151:7: note: Technically the member function 't_audio_session::reset_zrtp_sas_confirmation' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/audio/audio_session.h:152:7: performance:inconclusive: Technically the member function 't_audio_session::enable_zrtp' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/audio/audio_session.cpp:570:23: note: Technically the member function 't_audio_session::enable_zrtp' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/audio/audio_session.h:152:7: note: Technically the member function 't_audio_session::enable_zrtp' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/audio/audio_session.h:153:7: performance:inconclusive: Technically the member function 't_audio_session::zrtp_request_go_clear' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/audio/audio_session.cpp:579:23: note: Technically the member function 't_audio_session::zrtp_request_go_clear' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/audio/audio_session.h:153:7: note: Technically the member function 't_audio_session::zrtp_request_go_clear' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/audio/audio_session.h:154:7: performance:inconclusive: Technically the member function 't_audio_session::zrtp_go_clear_ok' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/audio/audio_session.cpp:588:23: note: Technically the member function 't_audio_session::zrtp_go_clear_ok' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/audio/audio_session.h:154:7: note: Technically the member function 't_audio_session::zrtp_go_clear_ok' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/audio/audio_session.cpp:192:4: warning: Class 't_audio_session' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] twinkle-1.10.2/src/audio/audio_session.cpp:192:4: warning: Class 't_audio_session' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] twinkle-1.10.2/src/audio/audio_session.cpp:183:10: style: Variable 'user_config' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/audio/audio_session.cpp:238:19: style: Variable 'as_peer' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/audio/audio_session.cpp:183:10: style: Variable 'user_config' is assigned a value that is never used. [unreadVariable] twinkle-1.10.2/src/audio/dtmf_player.h:62:9: style:inconclusive: Technically the member function 't_dtmf_player::get_timestamp' can be const. [functionConst] twinkle-1.10.2/src/audio/dtmf_player.cpp:45:23: note: Technically the member function 't_dtmf_player::get_timestamp' can be const. twinkle-1.10.2/src/audio/dtmf_player.h:62:9: note: Technically the member function 't_dtmf_player::get_timestamp' can be const. twinkle-1.10.2/src/audio/dtmf_player.h:65:7: style:inconclusive: Technically the member function 't_dtmf_player::finished' can be const. [functionConst] twinkle-1.10.2/src/audio/dtmf_player.cpp:49:21: note: Technically the member function 't_dtmf_player::finished' can be const. twinkle-1.10.2/src/audio/dtmf_player.h:65:7: note: Technically the member function 't_dtmf_player::finished' can be const. twinkle-1.10.2/src/audio/dtmf_player.cpp:69:40: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/audio/freq_gen.cpp:26:39: performance: Function parameter 'frequencies' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/audio/freq_gen.cpp:122:12: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/audio/freq_gen.cpp:120:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/audio/g711.cpp:141:16: style: The scope of the variable 'aval' can be reduced. [variableScope] twinkle-1.10.2/src/audio/g711.cpp:236:16: style: The scope of the variable 'uval' can be reduced. [variableScope] twinkle-1.10.2/src/audio/g721.cpp:81:7: style:inconclusive: Function 'g721_encoder' argument 1 names different: declaration 'sample' definition 'sl'. [funcArgNamesDifferent] twinkle-1.10.2/src/audio/g72x.h:119:7: note: Function 'g721_encoder' argument 1 names different: declaration 'sample' definition 'sl'. twinkle-1.10.2/src/audio/g721.cpp:81:7: note: Function 'g721_encoder' argument 1 names different: declaration 'sample' definition 'sl'. twinkle-1.10.2/src/audio/g721.cpp:138:7: style:inconclusive: Function 'g721_decoder' argument 1 names different: declaration 'code' definition 'i'. [funcArgNamesDifferent] twinkle-1.10.2/src/audio/g72x.h:123:7: note: Function 'g721_decoder' argument 1 names different: declaration 'code' definition 'i'. twinkle-1.10.2/src/audio/g721.cpp:138:7: note: Function 'g721_decoder' argument 1 names different: declaration 'code' definition 'i'. twinkle-1.10.2/src/audio/audio_tx.cpp:51:13: warning: Member variable 't_audio_tx::dtmf_previous_timestamp' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/audio/audio_tx.cpp:120:2: warning: Class 't_audio_tx' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] twinkle-1.10.2/src/audio/audio_tx.cpp:120:2: warning: Class 't_audio_tx' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] twinkle-1.10.2/src/audio/audio_tx.cpp:222:15: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/audio/audio_tx.cpp:299:20: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/audio/audio_tx.cpp:300:16: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/audio/audio_tx.cpp:596:6: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/audio/audio_tx.cpp:702:9: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/audio/audio_tx.cpp:715:9: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/audio/audio_tx.cpp:724:9: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/audio/audio_tx.cpp:999:31: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/audio/audio_tx.cpp:1001:27: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/audio/audio_tx.cpp:161:4: style: 'continue' is redundant since it is the last statement in a loop. [redundantContinue] twinkle-1.10.2/src/audio/audio_tx.cpp:194:56: style: Parameter 'buf' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/audio/audio_tx.cpp:300:11: style: Variable 'sb' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/audio/audio_tx.cpp:595:28: style: Variable 'e' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/audio/g723_16.cpp:83:7: style:inconclusive: Function 'g723_16_encoder' argument 1 names different: declaration 'sample' definition 'sl'. [funcArgNamesDifferent] twinkle-1.10.2/src/audio/g72x.h:127:7: note: Function 'g723_16_encoder' argument 1 names different: declaration 'sample' definition 'sl'. twinkle-1.10.2/src/audio/g723_16.cpp:83:7: note: Function 'g723_16_encoder' argument 1 names different: declaration 'sample' definition 'sl'. twinkle-1.10.2/src/audio/g723_16.cpp:146:7: style:inconclusive: Function 'g723_16_decoder' argument 1 names different: declaration 'code' definition 'i'. [funcArgNamesDifferent] twinkle-1.10.2/src/audio/g72x.h:131:7: note: Function 'g723_16_decoder' argument 1 names different: declaration 'code' definition 'i'. twinkle-1.10.2/src/audio/g723_16.cpp:146:7: note: Function 'g723_16_decoder' argument 1 names different: declaration 'code' definition 'i'. twinkle-1.10.2/src/audio/audio_tx.cpp:177:37: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/audio/g723_24.cpp:69:7: style:inconclusive: Function 'g723_24_encoder' argument 1 names different: declaration 'sample' definition 'sl'. [funcArgNamesDifferent] twinkle-1.10.2/src/audio/g72x.h:135:7: note: Function 'g723_24_encoder' argument 1 names different: declaration 'sample' definition 'sl'. twinkle-1.10.2/src/audio/g723_24.cpp:69:7: note: Function 'g723_24_encoder' argument 1 names different: declaration 'sample' definition 'sl'. twinkle-1.10.2/src/audio/g723_24.cpp:124:7: style:inconclusive: Function 'g723_24_decoder' argument 1 names different: declaration 'code' definition 'i'. [funcArgNamesDifferent] twinkle-1.10.2/src/audio/g72x.h:139:7: note: Function 'g723_24_decoder' argument 1 names different: declaration 'code' definition 'i'. twinkle-1.10.2/src/audio/g723_24.cpp:124:7: note: Function 'g723_24_decoder' argument 1 names different: declaration 'code' definition 'i'. twinkle-1.10.2/src/audio/g723_40.cpp:88:7: style:inconclusive: Function 'g723_40_encoder' argument 1 names different: declaration 'sample' definition 'sl'. [funcArgNamesDifferent] twinkle-1.10.2/src/audio/g72x.h:143:7: note: Function 'g723_40_encoder' argument 1 names different: declaration 'sample' definition 'sl'. twinkle-1.10.2/src/audio/g723_40.cpp:88:7: note: Function 'g723_40_encoder' argument 1 names different: declaration 'sample' definition 'sl'. twinkle-1.10.2/src/audio/g723_40.cpp:144:7: style:inconclusive: Function 'g723_40_decoder' argument 1 names different: declaration 'code' definition 'i'. [funcArgNamesDifferent] twinkle-1.10.2/src/audio/g72x.h:147:7: note: Function 'g723_40_decoder' argument 1 names different: declaration 'code' definition 'i'. twinkle-1.10.2/src/audio/g723_40.cpp:144:7: note: Function 'g723_40_decoder' argument 1 names different: declaration 'code' definition 'i'. twinkle-1.10.2/src/audio/media_buffer.cpp:29:2: warning: Class 't_media_buffer' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] twinkle-1.10.2/src/audio/media_buffer.cpp:29:2: warning: Class 't_media_buffer' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] twinkle-1.10.2/src/audio/tone_gen.cpp:188:10: style: Condition 'stop_playing' is always false [knownConditionTrueFalse] twinkle-1.10.2/src/audio/tone_gen.cpp:175:7: note: Assuming that condition 'stop_playing' is not redundant twinkle-1.10.2/src/audio/tone_gen.cpp:188:10: note: Condition 'stop_playing' is always false twinkle-1.10.2/src/audio/tone_gen.cpp:196:8: style: Condition 'stop_playing' is always false [knownConditionTrueFalse] twinkle-1.10.2/src/audio/tone_gen.cpp:175:7: note: Assuming that condition 'stop_playing' is not redundant twinkle-1.10.2/src/audio/tone_gen.cpp:196:8: note: Condition 'stop_playing' is always false twinkle-1.10.2/src/audio/tone_gen.cpp:48:19: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/audio/tone_gen.cpp:166:16: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/audio/tone_gen.cpp:186:17: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/audio/g72x.cpp:161:7: style: The scope of the variable 'y' can be reduced. [variableScope] twinkle-1.10.2/src/audio/g72x.cpp:162:7: style: The scope of the variable 'dif' can be reduced. [variableScope] twinkle-1.10.2/src/audio/g72x.cpp:163:7: style: The scope of the variable 'al' can be reduced. [variableScope] twinkle-1.10.2/src/audio/g72x.cpp:246:9: style: The scope of the variable 'dex' can be reduced. [variableScope] twinkle-1.10.2/src/audio/g72x.cpp:247:9: style: The scope of the variable 'dqt' can be reduced. [variableScope] twinkle-1.10.2/src/audio/g72x.cpp:248:9: style: The scope of the variable 'dq' can be reduced. [variableScope] twinkle-1.10.2/src/audio/g72x.cpp:282:9: style: The scope of the variable 'a1ul' can be reduced. [variableScope] twinkle-1.10.2/src/audio/g72x.cpp:283:9: style: The scope of the variable 'pks1' can be reduced. [variableScope] twinkle-1.10.2/src/audio/g72x.cpp:284:9: style: The scope of the variable 'fa1' can be reduced. [variableScope] twinkle-1.10.2/src/audio/g72x.cpp:487:7: style: The scope of the variable 'sd' can be reduced. [variableScope] twinkle-1.10.2/src/audio/g72x.cpp:488:7: style: The scope of the variable 'im' can be reduced. [variableScope] twinkle-1.10.2/src/audio/g72x.cpp:489:7: style: The scope of the variable 'imx' can be reduced. [variableScope] twinkle-1.10.2/src/audio/g72x.cpp:536:7: style: The scope of the variable 'sd' can be reduced. [variableScope] twinkle-1.10.2/src/audio/g72x.cpp:537:7: style: The scope of the variable 'im' can be reduced. [variableScope] twinkle-1.10.2/src/audio/g72x.cpp:538:7: style: The scope of the variable 'imx' can be reduced. [variableScope] twinkle-1.10.2/src/audio/g72x.cpp:348:16: portability: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS] twinkle-1.10.2/src/audio/g72x.cpp:493:23: portability: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS] twinkle-1.10.2/src/audio/g72x.cpp:128:21: style: Parameter 'state_ptr' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/audio/g72x.cpp:146:21: style: Parameter 'state_ptr' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/audits/memman.h:47:2: warning:inconclusive: Member variable 't_ptr_info::lineno' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/audits/memman.h:47:2: warning:inconclusive: Member variable 't_ptr_info::is_array' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/audits/memman.cpp:188:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/sockets/url.h:38:2: warning: Member variable 't_ip_port::ipaddr' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/sockets/url.h:38:2: warning: Member variable 't_ip_port::port' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/sockets/socket.h:49:2: warning:inconclusive: Member variable 't_icmp_msg::type' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/sockets/socket.h:49:2: warning:inconclusive: Member variable 't_icmp_msg::code' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/sockets/socket.h:49:2: warning:inconclusive: Member variable 't_icmp_msg::icmp_src_ipaddr' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/sockets/socket.h:49:2: warning:inconclusive: Member variable 't_icmp_msg::ipaddr' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/sockets/socket.h:49:2: warning:inconclusive: Member variable 't_icmp_msg::port' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/service.h:62:2: warning:inconclusive: Member variable 't_service::user_config' is not initialized in the constructor. [uninitMemberVarPrivate] twinkle-1.10.2/src/service.h:62:2: warning:inconclusive: Member variable 't_service::cf_always_active' is not initialized in the constructor. [uninitMemberVarPrivate] twinkle-1.10.2/src/service.h:62:2: warning:inconclusive: Member variable 't_service::cf_busy_active' is not initialized in the constructor. [uninitMemberVarPrivate] twinkle-1.10.2/src/service.h:62:2: warning:inconclusive: Member variable 't_service::cf_noanswer_active' is not initialized in the constructor. [uninitMemberVarPrivate] twinkle-1.10.2/src/service.h:62:2: warning:inconclusive: Member variable 't_service::dnd_active' is not initialized in the constructor. [uninitMemberVarPrivate] twinkle-1.10.2/src/service.h:62:2: warning:inconclusive: Member variable 't_service::auto_answer_active' is not initialized in the constructor. [uninitMemberVarPrivate] twinkle-1.10.2/src/utils/record_file.h:73:7: style:inconclusive: Member variable 't_record_file < t_call_record >::field_separator' is in the wrong place in the initializer list. [initializerList] twinkle-1.10.2/src/utils/record_file.hpp:58:2: note: Member variable 't_record_file < t_call_record >::field_separator' is in the wrong place in the initializer list. twinkle-1.10.2/src/utils/record_file.h:73:7: note: Member variable 't_record_file < t_call_record >::field_separator' is in the wrong place in the initializer list. twinkle-1.10.2/src/utils/record_file.h:73:7: style:inconclusive: Member variable 't_record_file < t_buddy >::field_separator' is in the wrong place in the initializer list. [initializerList] twinkle-1.10.2/src/utils/record_file.hpp:58:2: note: Member variable 't_record_file < t_buddy >::field_separator' is in the wrong place in the initializer list. twinkle-1.10.2/src/utils/record_file.h:73:7: note: Member variable 't_record_file < t_buddy >::field_separator' is in the wrong place in the initializer list. twinkle-1.10.2/src/abstract_dialog.h:92:7: performance:inconclusive: Technically the member function 't_abstract_dialog::remove_client_request' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/abstract_dialog.cpp:33:25: note: Technically the member function 't_abstract_dialog::remove_client_request' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/abstract_dialog.h:92:7: note: Technically the member function 't_abstract_dialog::remove_client_request' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/parser/parameter.h:40:2: style: Class 't_parameter' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/parser/media_type.h:58:2: style: Class 't_media' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/parser/coding.h:33:2: style: Class 't_coding' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/parser/hdr_accept_language.h:35:2: style: Class 't_language' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/parser/sip_body.h:182:2: style: Class 't_sip_body_opaque' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/parser/sip_body.h:197:2: style: Class 't_sip_body_sipfrag' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/parser/sip_body.h:232:2: style: Class 't_sip_body_plain_text' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/parser/sip_body.h:250:2: style: Class 't_sip_body_html_text' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/sockets/url.h:141:2: style: Class 't_url' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/threads/mutex.h:38:2: style: Class 't_mutex' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/threads/mutex.h:78:2: style: Class 't_mutex_guard' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/threads/mutex.h:102:2: style: Class 't_rwmutex_reader' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/threads/mutex.h:116:2: style: Class 't_rwmutex_writer' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/sys_settings.h:98:2: style: Struct 't_win_geometry' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/parser/response.h:183:2: style: Class 't_response' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/parser/request.h:124:2: style: Class 't_request' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/sockets/socket.h:105:2: style: Class 't_socket_udp' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/sockets/socket.h:152:2: style: Class 't_socket_tcp' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/sockets/socket.h:157:2: style: Class 't_socket_tcp' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/sockets/socket.h:206:2: style: Class 't_socket_local' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/threads/sema.h:29:2: style: Class 't_semaphore' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/events.h:107:2: style: Class 't_event_network' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/events.h:207:2: style: Class 't_event_timeout' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/events.h:286:2: style: Class 't_event_start_timer' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/events.h:313:2: style: Class 't_event_stop_timer' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/events.h:338:2: style: Class 't_event_abort_trans' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/events.h:452:2: style: Class 't_event_icmp' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/events.h:513:2: style: Class 't_event_ui' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/events.h:558:2: style: Class 't_event_async_response' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/events.h:594:2: style: Class 't_event_broken_connection' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/events.h:633:2: style: Class 't_event_fncall' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/sdp/sdp.h:144:2: style: Class 't_sdp_connection' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/sdp/sdp.h:153:2: style: Class 't_sdp_attr' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/dialog.h:543:2: style: Class 't_dialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/service.h:65:2: style: Class 't_service' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/im/msg_session.h:170:2: style: Class 't_msg_session' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/mwi/mwi_dialog.h:29:2: style: Class 't_mwi_dialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/presence/presence_state.h:78:2: style: Class 't_presence_state' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/presence/buddy.h:92:2: style: Class 't_buddy' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/presence/buddy.h:251:2: style: Class 't_buddy_list' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/phone_user.h:212:2: style: Class 't_phone_user' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/userintf.h:165:9: style: Class 't_userintf' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/parser/hdr_supported.h:45:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_supported.h:45:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_accept.h:40:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_accept.h:40:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_accept_encoding.h:39:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_accept_encoding.h:39:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_accept_language.h:48:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_accept_language.h:48:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_alert_info.h:49:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_alert_info.h:49:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_allow.h:41:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_allow.h:41:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_allow_events.h:37:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_allow_events.h:37:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_auth_info.h:43:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_auth_info.h:43:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_authorization.h:39:9: style: The function 'encode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:41:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_authorization.h:39:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_authorization.h:40:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_authorization.h:40:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_call_id.h:34:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_call_id.h:34:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_call_info.h:49:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_call_info.h:49:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_contact.h:96:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_contact.h:96:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_content_disp.h:47:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_content_disp.h:47:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_content_encoding.h:39:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_content_encoding.h:39:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_content_language.h:39:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_content_language.h:39:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_content_length.h:35:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_content_length.h:35:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_content_type.h:32:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_content_type.h:32:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_cseq.h:40:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_cseq.h:40:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_date.h:34:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_date.h:34:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_error_info.h:49:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_error_info.h:49:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_event.h:48:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_event.h:48:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_expires.h:35:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_expires.h:35:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_from.h:51:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_from.h:51:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_in_reply_to.h:35:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_in_reply_to.h:35:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_max_forwards.h:35:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_max_forwards.h:35:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_min_expires.h:35:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_min_expires.h:35:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_mime_version.h:33:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_mime_version.h:33:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_organization.h:33:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_organization.h:33:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_p_asserted_identity.h:37:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_p_asserted_identity.h:37:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_p_preferred_identity.h:37:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_p_preferred_identity.h:37:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_priority.h:33:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_priority.h:33:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_privacy.h:44:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_privacy.h:44:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_proxy_authenticate.h:37:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_proxy_authenticate.h:37:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_proxy_authorization.h:39:9: style: The function 'encode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:41:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_proxy_authorization.h:39:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_proxy_authorization.h:40:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_proxy_authorization.h:40:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_proxy_require.h:33:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_proxy_require.h:33:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_rack.h:43:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_rack.h:43:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_record_route.h:38:9: style: The function 'encode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:41:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_record_route.h:38:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_record_route.h:40:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_record_route.h:40:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_refer_sub.h:42:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_refer_sub.h:42:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_refer_to.h:43:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_refer_to.h:43:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_referred_by.h:45:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_referred_by.h:45:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_replaces.h:46:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_replaces.h:46:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_reply_to.h:42:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_reply_to.h:42:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_require.h:36:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_require.h:36:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_request_disposition.h:107:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_request_disposition.h:107:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_retry_after.h:42:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_retry_after.h:42:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_route.h:41:9: style: The function 'encode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:41:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_route.h:41:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_route.h:43:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_route.h:43:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_rseq.h:37:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_rseq.h:37:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_server.h:51:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_server.h:51:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_service_route.h:38:9: style: The function 'encode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:41:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_service_route.h:38:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_service_route.h:40:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_service_route.h:40:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_sip_etag.h:45:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_sip_etag.h:45:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_sip_if_match.h:48:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_sip_if_match.h:48:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_subject.h:33:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_subject.h:33:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_subscription_state.h:59:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_subscription_state.h:59:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_timestamp.h:36:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_timestamp.h:36:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_to.h:44:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_to.h:44:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_unsupported.h:35:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_unsupported.h:35:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_user_agent.h:40:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_user_agent.h:40:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_via.h:64:9: style: The function 'encode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:41:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_via.h:64:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_via.h:66:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_via.h:66:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_warning.h:79:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_warning.h:79:9: note: Function in derived class twinkle-1.10.2/src/parser/hdr_www_authenticate.h:37:9: style: The function 'encode_value' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/header.h:44:17: note: Virtual function in base class twinkle-1.10.2/src/parser/hdr_www_authenticate.h:37:9: note: Function in derived class twinkle-1.10.2/src/parser/sip_body.h:151:11: style: The destructor '~t_sip_body_xml' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:82:11: note: Virtual destructor in base class twinkle-1.10.2/src/parser/sip_body.h:151:11: note: Destructor in derived class twinkle-1.10.2/src/parser/sip_body.h:153:17: style: The function 'encode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:88:17: note: Virtual function in base class twinkle-1.10.2/src/parser/sip_body.h:153:17: note: Function in derived class twinkle-1.10.2/src/parser/sip_body.h:184:9: style: The function 'encode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:88:17: note: Virtual function in base class twinkle-1.10.2/src/parser/sip_body.h:184:9: note: Function in derived class twinkle-1.10.2/src/parser/sip_body.h:185:14: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:94:22: note: Virtual function in base class twinkle-1.10.2/src/parser/sip_body.h:185:14: note: Function in derived class twinkle-1.10.2/src/parser/sip_body.h:186:14: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:100:22: note: Virtual function in base class twinkle-1.10.2/src/parser/sip_body.h:186:14: note: Function in derived class twinkle-1.10.2/src/parser/sip_body.h:187:10: style: The function 'get_media' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:106:18: note: Virtual function in base class twinkle-1.10.2/src/parser/sip_body.h:187:10: note: Function in derived class twinkle-1.10.2/src/parser/sip_body.h:188:17: style: The function 'get_encoded_size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:121:17: note: Virtual function in base class twinkle-1.10.2/src/parser/sip_body.h:188:17: note: Function in derived class twinkle-1.10.2/src/parser/sip_body.h:198:3: style: The destructor '~t_sip_body_sipfrag' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:82:11: note: Virtual destructor in base class twinkle-1.10.2/src/parser/sip_body.h:198:3: note: Destructor in derived class twinkle-1.10.2/src/parser/sip_body.h:199:9: style: The function 'encode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:88:17: note: Virtual function in base class twinkle-1.10.2/src/parser/sip_body.h:199:9: note: Function in derived class twinkle-1.10.2/src/parser/sip_body.h:200:14: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:94:22: note: Virtual function in base class twinkle-1.10.2/src/parser/sip_body.h:200:14: note: Function in derived class twinkle-1.10.2/src/parser/sip_body.h:201:14: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:100:22: note: Virtual function in base class twinkle-1.10.2/src/parser/sip_body.h:201:14: note: Function in derived class twinkle-1.10.2/src/parser/sip_body.h:202:10: style: The function 'get_media' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:106:18: note: Virtual function in base class twinkle-1.10.2/src/parser/sip_body.h:202:10: note: Function in derived class twinkle-1.10.2/src/parser/sip_body.h:213:9: style: The function 'encode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:88:17: note: Virtual function in base class twinkle-1.10.2/src/parser/sip_body.h:213:9: note: Function in derived class twinkle-1.10.2/src/parser/sip_body.h:214:14: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:94:22: note: Virtual function in base class twinkle-1.10.2/src/parser/sip_body.h:214:14: note: Function in derived class twinkle-1.10.2/src/parser/sip_body.h:215:14: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:100:22: note: Virtual function in base class twinkle-1.10.2/src/parser/sip_body.h:215:14: note: Function in derived class twinkle-1.10.2/src/parser/sip_body.h:216:10: style: The function 'get_media' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:106:18: note: Virtual function in base class twinkle-1.10.2/src/parser/sip_body.h:216:10: note: Function in derived class twinkle-1.10.2/src/parser/sip_body.h:234:9: style: The function 'encode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:88:17: note: Virtual function in base class twinkle-1.10.2/src/parser/sip_body.h:234:9: note: Function in derived class twinkle-1.10.2/src/parser/sip_body.h:235:14: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:94:22: note: Virtual function in base class twinkle-1.10.2/src/parser/sip_body.h:235:14: note: Function in derived class twinkle-1.10.2/src/parser/sip_body.h:236:14: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:100:22: note: Virtual function in base class twinkle-1.10.2/src/parser/sip_body.h:236:14: note: Function in derived class twinkle-1.10.2/src/parser/sip_body.h:237:10: style: The function 'get_media' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:106:18: note: Virtual function in base class twinkle-1.10.2/src/parser/sip_body.h:237:10: note: Function in derived class twinkle-1.10.2/src/parser/sip_body.h:238:17: style: The function 'get_encoded_size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:121:17: note: Virtual function in base class twinkle-1.10.2/src/parser/sip_body.h:238:17: note: Function in derived class twinkle-1.10.2/src/parser/sip_body.h:252:9: style: The function 'encode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:88:17: note: Virtual function in base class twinkle-1.10.2/src/parser/sip_body.h:252:9: note: Function in derived class twinkle-1.10.2/src/parser/sip_body.h:253:14: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:94:22: note: Virtual function in base class twinkle-1.10.2/src/parser/sip_body.h:253:14: note: Function in derived class twinkle-1.10.2/src/parser/sip_body.h:254:14: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:100:22: note: Virtual function in base class twinkle-1.10.2/src/parser/sip_body.h:254:14: note: Function in derived class twinkle-1.10.2/src/parser/sip_body.h:255:10: style: The function 'get_media' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:106:18: note: Virtual function in base class twinkle-1.10.2/src/parser/sip_body.h:255:10: note: Function in derived class twinkle-1.10.2/src/parser/sip_body.h:256:17: style: The function 'get_encoded_size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:121:17: note: Virtual function in base class twinkle-1.10.2/src/parser/sip_body.h:256:17: note: Function in derived class twinkle-1.10.2/src/threads/mutex.h:57:3: style: The destructor '~t_recursive_mutex' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/threads/mutex.h:40:11: note: Virtual destructor in base class twinkle-1.10.2/src/threads/mutex.h:57:3: note: Destructor in derived class twinkle-1.10.2/src/parser/response.h:185:13: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_message.h:194:21: note: Virtual function in base class twinkle-1.10.2/src/parser/response.h:185:13: note: Function in derived class twinkle-1.10.2/src/parser/response.h:194:9: style: The function 'encode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_message.h:210:17: note: Virtual function in base class twinkle-1.10.2/src/parser/response.h:194:9: note: Function in derived class twinkle-1.10.2/src/parser/response.h:195:15: style: The function 'encode_env' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_message.h:221:23: note: Virtual function in base class twinkle-1.10.2/src/parser/response.h:195:15: note: Function in derived class twinkle-1.10.2/src/parser/response.h:196:17: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_message.h:224:25: note: Virtual function in base class twinkle-1.10.2/src/parser/response.h:196:17: note: Function in derived class twinkle-1.10.2/src/parser/response.h:198:7: style: The function 'is_valid' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_message.h:203:15: note: Virtual function in base class twinkle-1.10.2/src/parser/response.h:198:7: note: Function in derived class twinkle-1.10.2/src/parser/response.h:210:15: style: The function 'calc_local_ip' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_message.h:257:15: note: Virtual function in base class twinkle-1.10.2/src/parser/response.h:210:15: note: Function in derived class twinkle-1.10.2/src/parser/request.h:126:13: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_message.h:194:21: note: Virtual function in base class twinkle-1.10.2/src/parser/request.h:126:13: note: Function in derived class twinkle-1.10.2/src/parser/request.h:128:9: style: The function 'encode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_message.h:210:17: note: Virtual function in base class twinkle-1.10.2/src/parser/request.h:128:9: note: Function in derived class twinkle-1.10.2/src/parser/request.h:129:15: style: The function 'encode_env' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_message.h:221:23: note: Virtual function in base class twinkle-1.10.2/src/parser/request.h:129:15: note: Function in derived class twinkle-1.10.2/src/parser/request.h:130:17: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_message.h:224:25: note: Virtual function in base class twinkle-1.10.2/src/parser/request.h:130:17: note: Function in derived class twinkle-1.10.2/src/parser/request.h:151:7: style: The function 'is_valid' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_message.h:203:15: note: Virtual function in base class twinkle-1.10.2/src/parser/request.h:151:7: note: Function in derived class twinkle-1.10.2/src/parser/request.h:202:15: style: The function 'calc_local_ip' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_message.h:257:15: note: Virtual function in base class twinkle-1.10.2/src/parser/request.h:202:15: note: Function in derived class twinkle-1.10.2/src/sockets/socket.h:114:18: style: The function 'send' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/sockets/socket.h:91:18: note: Virtual function in base class twinkle-1.10.2/src/sockets/socket.h:114:18: note: Function in derived class twinkle-1.10.2/src/sockets/socket.h:122:18: style: The function 'recv' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/sockets/socket.h:88:18: note: Virtual function in base class twinkle-1.10.2/src/sockets/socket.h:122:18: note: Function in derived class twinkle-1.10.2/src/sockets/socket.h:184:18: style: The function 'send' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/sockets/socket.h:91:18: note: Virtual function in base class twinkle-1.10.2/src/sockets/socket.h:184:18: note: Function in derived class twinkle-1.10.2/src/sockets/socket.h:188:18: style: The function 'recv' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/sockets/socket.h:88:18: note: Virtual function in base class twinkle-1.10.2/src/sockets/socket.h:188:18: note: Function in derived class twinkle-1.10.2/src/sockets/socket.h:213:18: style: The function 'recv' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/sockets/socket.h:88:18: note: Virtual function in base class twinkle-1.10.2/src/sockets/socket.h:213:18: note: Function in derived class twinkle-1.10.2/src/sockets/socket.h:215:18: style: The function 'send' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/sockets/socket.h:91:18: note: Virtual function in base class twinkle-1.10.2/src/sockets/socket.h:215:18: note: Function in derived class twinkle-1.10.2/src/transaction.h:157:15: style: The function 'process_provisional' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:90:15: note: Virtual function in base class twinkle-1.10.2/src/transaction.h:157:15: note: Function in derived class twinkle-1.10.2/src/transaction.h:207:11: style: The destructor '~t_tc_invite' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:86:11: note: Virtual destructor in base class twinkle-1.10.2/src/transaction.h:207:11: note: Destructor in derived class twinkle-1.10.2/src/transaction.h:211:7: style: The function 'process_provisional' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:157:15: note: Virtual function in base class twinkle-1.10.2/src/transaction.h:211:7: note: Function in derived class twinkle-1.10.2/src/transaction.h:216:7: style: The function 'process_final' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:94:15: note: Virtual function in base class twinkle-1.10.2/src/transaction.h:216:7: note: Function in derived class twinkle-1.10.2/src/transaction.h:218:7: style: The function 'process_icmp' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:163:15: note: Virtual function in base class twinkle-1.10.2/src/transaction.h:218:7: note: Function in derived class twinkle-1.10.2/src/transaction.h:220:7: style: The function 'process_failure' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:169:15: note: Virtual function in base class twinkle-1.10.2/src/transaction.h:220:7: note: Function in derived class twinkle-1.10.2/src/transaction.h:222:7: style: The function 'timeout' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:100:15: note: Virtual function in base class twinkle-1.10.2/src/transaction.h:222:7: note: Function in derived class twinkle-1.10.2/src/transaction.h:224:7: style: The function 'abort' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:175:15: note: Virtual function in base class twinkle-1.10.2/src/transaction.h:224:7: note: Function in derived class twinkle-1.10.2/src/transaction.h:253:11: style: The destructor '~t_tc_non_invite' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:86:11: note: Virtual destructor in base class twinkle-1.10.2/src/transaction.h:253:11: note: Destructor in derived class twinkle-1.10.2/src/transaction.h:256:7: style: The function 'process_provisional' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:157:15: note: Virtual function in base class twinkle-1.10.2/src/transaction.h:256:7: note: Function in derived class twinkle-1.10.2/src/transaction.h:260:7: style: The function 'process_final' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:94:15: note: Virtual function in base class twinkle-1.10.2/src/transaction.h:260:7: note: Function in derived class twinkle-1.10.2/src/transaction.h:262:7: style: The function 'process_icmp' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:163:15: note: Virtual function in base class twinkle-1.10.2/src/transaction.h:262:7: note: Function in derived class twinkle-1.10.2/src/transaction.h:264:7: style: The function 'process_failure' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:169:15: note: Virtual function in base class twinkle-1.10.2/src/transaction.h:264:7: note: Function in derived class twinkle-1.10.2/src/transaction.h:266:7: style: The function 'timeout' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:100:15: note: Virtual function in base class twinkle-1.10.2/src/transaction.h:266:7: note: Function in derived class twinkle-1.10.2/src/transaction.h:268:7: style: The function 'abort' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:175:15: note: Virtual function in base class twinkle-1.10.2/src/transaction.h:268:7: note: Function in derived class twinkle-1.10.2/src/transaction.h:299:7: style: The function 'process_provisional' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:90:15: note: Virtual function in base class twinkle-1.10.2/src/transaction.h:299:7: note: Function in derived class twinkle-1.10.2/src/transaction.h:303:7: style: The function 'process_final' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:94:15: note: Virtual function in base class twinkle-1.10.2/src/transaction.h:303:7: note: Function in derived class twinkle-1.10.2/src/transaction.h:339:11: style: The destructor '~t_ts_invite' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:86:11: note: Virtual destructor in base class twinkle-1.10.2/src/transaction.h:339:11: note: Destructor in derived class twinkle-1.10.2/src/transaction.h:341:7: style: The function 'process_provisional' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:299:7: note: Virtual function in base class twinkle-1.10.2/src/transaction.h:341:7: note: Function in derived class twinkle-1.10.2/src/transaction.h:342:7: style: The function 'process_final' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:303:7: note: Virtual function in base class twinkle-1.10.2/src/transaction.h:342:7: note: Function in derived class twinkle-1.10.2/src/transaction.h:343:7: style: The function 'process_retransmission' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:306:15: note: Virtual function in base class twinkle-1.10.2/src/transaction.h:343:7: note: Function in derived class twinkle-1.10.2/src/transaction.h:344:7: style: The function 'timeout' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:100:15: note: Virtual function in base class twinkle-1.10.2/src/transaction.h:344:7: note: Function in derived class twinkle-1.10.2/src/transaction.h:363:11: style: The destructor '~t_ts_non_invite' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:86:11: note: Virtual destructor in base class twinkle-1.10.2/src/transaction.h:363:11: note: Destructor in derived class twinkle-1.10.2/src/transaction.h:365:7: style: The function 'process_provisional' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:299:7: note: Virtual function in base class twinkle-1.10.2/src/transaction.h:365:7: note: Function in derived class twinkle-1.10.2/src/transaction.h:366:7: style: The function 'process_final' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:303:7: note: Virtual function in base class twinkle-1.10.2/src/transaction.h:366:7: note: Function in derived class twinkle-1.10.2/src/transaction.h:367:7: style: The function 'process_retransmission' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:306:15: note: Virtual function in base class twinkle-1.10.2/src/transaction.h:367:7: note: Function in derived class twinkle-1.10.2/src/transaction.h:368:7: style: The function 'timeout' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction.h:100:15: note: Virtual function in base class twinkle-1.10.2/src/transaction.h:368:7: note: Function in derived class twinkle-1.10.2/src/timekeeper.h:82:7: style: The function 'expired' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/timekeeper.h:59:15: note: Virtual function in base class twinkle-1.10.2/src/timekeeper.h:82:7: note: Function in derived class twinkle-1.10.2/src/timekeeper.h:83:11: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/timekeeper.h:64:19: note: Virtual function in base class twinkle-1.10.2/src/timekeeper.h:83:11: note: Function in derived class twinkle-1.10.2/src/timekeeper.h:84:15: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/timekeeper.h:65:23: note: Virtual function in base class twinkle-1.10.2/src/timekeeper.h:84:15: note: Function in derived class twinkle-1.10.2/src/timekeeper.h:87:9: style: The function 'get_name' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/timekeeper.h:68:17: note: Virtual function in base class twinkle-1.10.2/src/timekeeper.h:87:9: note: Function in derived class twinkle-1.10.2/src/timekeeper.h:101:7: style: The function 'expired' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/timekeeper.h:59:15: note: Virtual function in base class twinkle-1.10.2/src/timekeeper.h:101:7: note: Function in derived class twinkle-1.10.2/src/timekeeper.h:102:11: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/timekeeper.h:64:19: note: Virtual function in base class twinkle-1.10.2/src/timekeeper.h:102:11: note: Function in derived class twinkle-1.10.2/src/timekeeper.h:103:15: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/timekeeper.h:65:23: note: Virtual function in base class twinkle-1.10.2/src/timekeeper.h:103:15: note: Function in derived class twinkle-1.10.2/src/timekeeper.h:106:9: style: The function 'get_name' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/timekeeper.h:68:17: note: Virtual function in base class twinkle-1.10.2/src/timekeeper.h:106:9: note: Function in derived class twinkle-1.10.2/src/timekeeper.h:122:7: style: The function 'expired' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/timekeeper.h:59:15: note: Virtual function in base class twinkle-1.10.2/src/timekeeper.h:122:7: note: Function in derived class twinkle-1.10.2/src/timekeeper.h:123:11: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/timekeeper.h:64:19: note: Virtual function in base class twinkle-1.10.2/src/timekeeper.h:123:11: note: Function in derived class twinkle-1.10.2/src/timekeeper.h:124:15: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/timekeeper.h:65:23: note: Virtual function in base class twinkle-1.10.2/src/timekeeper.h:124:15: note: Function in derived class twinkle-1.10.2/src/timekeeper.h:128:9: style: The function 'get_name' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/timekeeper.h:68:17: note: Virtual function in base class twinkle-1.10.2/src/timekeeper.h:128:9: note: Function in derived class twinkle-1.10.2/src/timekeeper.h:147:7: style: The function 'expired' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/timekeeper.h:59:15: note: Virtual function in base class twinkle-1.10.2/src/timekeeper.h:147:7: note: Function in derived class twinkle-1.10.2/src/timekeeper.h:148:11: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/timekeeper.h:64:19: note: Virtual function in base class twinkle-1.10.2/src/timekeeper.h:148:11: note: Function in derived class twinkle-1.10.2/src/timekeeper.h:149:15: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/timekeeper.h:65:23: note: Virtual function in base class twinkle-1.10.2/src/timekeeper.h:149:15: note: Function in derived class twinkle-1.10.2/src/timekeeper.h:155:9: style: The function 'get_name' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/timekeeper.h:68:17: note: Virtual function in base class twinkle-1.10.2/src/timekeeper.h:155:9: note: Function in derived class twinkle-1.10.2/src/timekeeper.h:168:7: style: The function 'expired' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/timekeeper.h:59:15: note: Virtual function in base class twinkle-1.10.2/src/timekeeper.h:168:7: note: Function in derived class twinkle-1.10.2/src/timekeeper.h:169:11: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/timekeeper.h:64:19: note: Virtual function in base class twinkle-1.10.2/src/timekeeper.h:169:11: note: Function in derived class twinkle-1.10.2/src/timekeeper.h:170:15: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/timekeeper.h:65:23: note: Virtual function in base class twinkle-1.10.2/src/timekeeper.h:170:15: note: Function in derived class twinkle-1.10.2/src/timekeeper.h:172:9: style: The function 'get_name' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/timekeeper.h:68:17: note: Virtual function in base class twinkle-1.10.2/src/timekeeper.h:172:9: note: Function in derived class twinkle-1.10.2/src/timekeeper.h:186:7: style: The function 'expired' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/timekeeper.h:59:15: note: Virtual function in base class twinkle-1.10.2/src/timekeeper.h:186:7: note: Function in derived class twinkle-1.10.2/src/timekeeper.h:187:11: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/timekeeper.h:64:19: note: Virtual function in base class twinkle-1.10.2/src/timekeeper.h:187:11: note: Function in derived class twinkle-1.10.2/src/timekeeper.h:188:15: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/timekeeper.h:65:23: note: Virtual function in base class twinkle-1.10.2/src/timekeeper.h:188:15: note: Function in derived class twinkle-1.10.2/src/timekeeper.h:191:9: style: The function 'get_name' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/timekeeper.h:68:17: note: Virtual function in base class twinkle-1.10.2/src/timekeeper.h:191:9: note: Function in derived class twinkle-1.10.2/src/events.h:80:11: style: The destructor '~t_event_quit' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/events.h:67:11: note: Virtual destructor in base class twinkle-1.10.2/src/events.h:80:11: note: Destructor in derived class twinkle-1.10.2/src/events.h:81:23: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/events.h:70:23: note: Virtual function in base class twinkle-1.10.2/src/events.h:81:23: note: Function in derived class twinkle-1.10.2/src/events.h:109:3: style: The destructor '~t_event_network' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/events.h:67:11: note: Virtual destructor in base class twinkle-1.10.2/src/events.h:109:3: note: Destructor in derived class twinkle-1.10.2/src/events.h:111:15: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/events.h:70:23: note: Virtual function in base class twinkle-1.10.2/src/events.h:111:15: note: Function in derived class twinkle-1.10.2/src/events.h:162:3: style: The destructor '~t_event_user' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/events.h:67:11: note: Virtual destructor in base class twinkle-1.10.2/src/events.h:162:3: note: Destructor in derived class twinkle-1.10.2/src/events.h:164:15: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/events.h:70:23: note: Virtual function in base class twinkle-1.10.2/src/events.h:164:15: note: Function in derived class twinkle-1.10.2/src/events.h:209:3: style: The destructor '~t_event_timeout' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/events.h:67:11: note: Virtual destructor in base class twinkle-1.10.2/src/events.h:209:3: note: Destructor in derived class twinkle-1.10.2/src/events.h:211:15: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/events.h:70:23: note: Virtual function in base class twinkle-1.10.2/src/events.h:211:15: note: Function in derived class twinkle-1.10.2/src/events.h:248:15: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/events.h:70:23: note: Virtual function in base class twinkle-1.10.2/src/events.h:248:15: note: Function in derived class twinkle-1.10.2/src/events.h:289:15: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/events.h:70:23: note: Virtual function in base class twinkle-1.10.2/src/events.h:289:15: note: Function in derived class twinkle-1.10.2/src/events.h:315:15: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/events.h:70:23: note: Virtual function in base class twinkle-1.10.2/src/events.h:315:15: note: Function in derived class twinkle-1.10.2/src/events.h:340:15: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/events.h:70:23: note: Virtual function in base class twinkle-1.10.2/src/events.h:340:15: note: Function in derived class twinkle-1.10.2/src/events.h:376:3: style: The destructor '~t_event_stun_request' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/events.h:67:11: note: Virtual destructor in base class twinkle-1.10.2/src/events.h:376:3: note: Destructor in derived class twinkle-1.10.2/src/events.h:378:15: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/events.h:70:23: note: Virtual function in base class twinkle-1.10.2/src/events.h:378:15: note: Function in derived class twinkle-1.10.2/src/events.h:411:3: style: The destructor '~t_event_stun_response' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/events.h:67:11: note: Virtual destructor in base class twinkle-1.10.2/src/events.h:411:3: note: Destructor in derived class twinkle-1.10.2/src/events.h:413:15: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/events.h:70:23: note: Virtual function in base class twinkle-1.10.2/src/events.h:413:15: note: Function in derived class twinkle-1.10.2/src/events.h:435:15: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/events.h:70:23: note: Virtual function in base class twinkle-1.10.2/src/events.h:435:15: note: Function in derived class twinkle-1.10.2/src/events.h:454:15: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/events.h:70:23: note: Virtual function in base class twinkle-1.10.2/src/events.h:454:15: note: Function in derived class twinkle-1.10.2/src/events.h:515:15: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/events.h:70:23: note: Virtual function in base class twinkle-1.10.2/src/events.h:515:15: note: Function in derived class twinkle-1.10.2/src/events.h:560:15: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/events.h:70:23: note: Virtual function in base class twinkle-1.10.2/src/events.h:560:15: note: Function in derived class twinkle-1.10.2/src/events.h:596:15: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/events.h:70:23: note: Virtual function in base class twinkle-1.10.2/src/events.h:596:15: note: Function in derived class twinkle-1.10.2/src/events.h:621:15: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/events.h:70:23: note: Virtual function in base class twinkle-1.10.2/src/events.h:621:15: note: Function in derived class twinkle-1.10.2/src/call_history.h:174:15: style: The function 'create_file_record' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/utils/record_file.h:54:15: note: Virtual function in base class twinkle-1.10.2/src/call_history.h:174:15: note: Function in derived class twinkle-1.10.2/src/call_history.h:175:15: style: The function 'populate_from_file_record' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/utils/record_file.h:62:15: note: Virtual function in base class twinkle-1.10.2/src/call_history.h:175:15: note: Function in derived class twinkle-1.10.2/src/sdp/sdp.h:236:9: style: The function 'encode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:88:17: note: Virtual function in base class twinkle-1.10.2/src/sdp/sdp.h:236:9: note: Function in derived class twinkle-1.10.2/src/sdp/sdp.h:237:14: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:94:22: note: Virtual function in base class twinkle-1.10.2/src/sdp/sdp.h:237:14: note: Function in derived class twinkle-1.10.2/src/sdp/sdp.h:238:14: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:100:22: note: Virtual function in base class twinkle-1.10.2/src/sdp/sdp.h:238:14: note: Function in derived class twinkle-1.10.2/src/sdp/sdp.h:239:10: style: The function 'get_media' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:106:18: note: Virtual function in base class twinkle-1.10.2/src/sdp/sdp.h:239:10: note: Function in derived class twinkle-1.10.2/src/sdp/sdp.h:294:15: style: The function 'local_ip_check' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:113:15: note: Virtual function in base class twinkle-1.10.2/src/sdp/sdp.h:294:15: note: Function in derived class twinkle-1.10.2/src/dialog.h:502:15: style: The function 'send_request' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/abstract_dialog.h:114:15: note: Virtual function in base class twinkle-1.10.2/src/dialog.h:502:15: note: Function in derived class twinkle-1.10.2/src/dialog.h:546:11: style: The destructor '~t_dialog' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/abstract_dialog.h:171:11: note: Virtual destructor in base class twinkle-1.10.2/src/dialog.h:546:11: note: Destructor in derived class twinkle-1.10.2/src/dialog.h:548:21: style: The function 'create_request' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/abstract_dialog.h:178:21: note: Virtual function in base class twinkle-1.10.2/src/dialog.h:548:21: note: Function in derived class twinkle-1.10.2/src/dialog.h:550:20: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/abstract_dialog.h:184:29: note: Virtual function in base class twinkle-1.10.2/src/dialog.h:550:20: note: Function in derived class twinkle-1.10.2/src/dialog.h:643:15: style: The function 'resend_request_auth' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/abstract_dialog.h:202:15: note: Virtual function in base class twinkle-1.10.2/src/dialog.h:643:15: note: Function in derived class twinkle-1.10.2/src/dialog.h:645:15: style: The function 'redirect_request' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/abstract_dialog.h:210:15: note: Virtual function in base class twinkle-1.10.2/src/dialog.h:645:15: note: Function in derived class twinkle-1.10.2/src/dialog.h:647:15: style: The function 'failover_request' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/abstract_dialog.h:218:15: note: Virtual function in base class twinkle-1.10.2/src/dialog.h:647:15: note: Function in derived class twinkle-1.10.2/src/dialog.h:690:7: style: The function 'recvd_response' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/abstract_dialog.h:226:15: note: Virtual function in base class twinkle-1.10.2/src/dialog.h:690:7: note: Function in derived class twinkle-1.10.2/src/dialog.h:692:7: style: The function 'recvd_request' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/abstract_dialog.h:234:15: note: Virtual function in base class twinkle-1.10.2/src/dialog.h:692:7: note: Function in derived class twinkle-1.10.2/src/dialog.h:745:15: style: The function 'match_response' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/abstract_dialog.h:243:15: note: Virtual function in base class twinkle-1.10.2/src/dialog.h:745:15: note: Function in derived class twinkle-1.10.2/src/mwi/simple_msg_sum_body.h:77:17: style: The function 'encode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:88:17: note: Virtual function in base class twinkle-1.10.2/src/mwi/simple_msg_sum_body.h:77:17: note: Function in derived class twinkle-1.10.2/src/mwi/simple_msg_sum_body.h:80:22: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:94:22: note: Virtual function in base class twinkle-1.10.2/src/mwi/simple_msg_sum_body.h:80:22: note: Function in derived class twinkle-1.10.2/src/mwi/simple_msg_sum_body.h:83:22: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:100:22: note: Virtual function in base class twinkle-1.10.2/src/mwi/simple_msg_sum_body.h:83:22: note: Function in derived class twinkle-1.10.2/src/mwi/simple_msg_sum_body.h:85:18: style: The function 'get_media' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:106:18: note: Virtual function in base class twinkle-1.10.2/src/mwi/simple_msg_sum_body.h:85:18: note: Function in derived class twinkle-1.10.2/src/presence/buddy.h:101:11: style: The destructor '~t_buddy' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/utils/record_file.h:46:11: note: Virtual destructor in base class twinkle-1.10.2/src/presence/buddy.h:101:11: note: Destructor in derived class twinkle-1.10.2/src/presence/buddy.h:210:15: style: The function 'create_file_record' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/utils/record_file.h:54:15: note: Virtual function in base class twinkle-1.10.2/src/presence/buddy.h:210:15: note: Function in derived class twinkle-1.10.2/src/presence/buddy.h:211:15: style: The function 'populate_from_file_record' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/utils/record_file.h:62:15: note: Virtual function in base class twinkle-1.10.2/src/presence/buddy.h:211:15: note: Function in derived class twinkle-1.10.2/src/presence/buddy.h:247:15: style: The function 'add_record' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/utils/record_file.h:107:15: note: Virtual function in base class twinkle-1.10.2/src/presence/buddy.h:247:15: note: Function in derived class twinkle-1.10.2/src/phone.h:260:7: style: The function 'recvd_provisional' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:45:15: note: Virtual function in base class twinkle-1.10.2/src/phone.h:260:7: note: Function in derived class twinkle-1.10.2/src/phone.h:261:7: style: The function 'recvd_success' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:47:15: note: Virtual function in base class twinkle-1.10.2/src/phone.h:261:7: note: Function in derived class twinkle-1.10.2/src/phone.h:262:7: style: The function 'recvd_redirect' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:48:15: note: Virtual function in base class twinkle-1.10.2/src/phone.h:262:7: note: Function in derived class twinkle-1.10.2/src/phone.h:263:7: style: The function 'recvd_client_error' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:50:15: note: Virtual function in base class twinkle-1.10.2/src/phone.h:263:7: note: Function in derived class twinkle-1.10.2/src/phone.h:264:7: style: The function 'recvd_server_error' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:52:15: note: Virtual function in base class twinkle-1.10.2/src/phone.h:264:7: note: Function in derived class twinkle-1.10.2/src/phone.h:265:7: style: The function 'recvd_global_error' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:54:15: note: Virtual function in base class twinkle-1.10.2/src/phone.h:265:7: note: Function in derived class twinkle-1.10.2/src/phone.h:266:7: style: The function 'post_process_response' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:58:15: note: Virtual function in base class twinkle-1.10.2/src/phone.h:266:7: note: Function in derived class twinkle-1.10.2/src/phone.h:268:7: style: The function 'recvd_invite' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:64:15: note: Virtual function in base class twinkle-1.10.2/src/phone.h:268:7: note: Function in derived class twinkle-1.10.2/src/phone.h:271:7: style: The function 'recvd_ack' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:65:15: note: Virtual function in base class twinkle-1.10.2/src/phone.h:271:7: note: Function in derived class twinkle-1.10.2/src/phone.h:272:7: style: The function 'recvd_cancel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:66:15: note: Virtual function in base class twinkle-1.10.2/src/phone.h:272:7: note: Function in derived class twinkle-1.10.2/src/phone.h:273:7: style: The function 'recvd_bye' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:68:15: note: Virtual function in base class twinkle-1.10.2/src/phone.h:273:7: note: Function in derived class twinkle-1.10.2/src/phone.h:274:7: style: The function 'recvd_options' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:69:15: note: Virtual function in base class twinkle-1.10.2/src/phone.h:274:7: note: Function in derived class twinkle-1.10.2/src/phone.h:275:7: style: The function 'recvd_register' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:70:15: note: Virtual function in base class twinkle-1.10.2/src/phone.h:275:7: note: Function in derived class twinkle-1.10.2/src/phone.h:276:7: style: The function 'recvd_prack' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:71:15: note: Virtual function in base class twinkle-1.10.2/src/phone.h:276:7: note: Function in derived class twinkle-1.10.2/src/phone.h:277:7: style: The function 'recvd_subscribe' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:72:15: note: Virtual function in base class twinkle-1.10.2/src/phone.h:277:7: note: Function in derived class twinkle-1.10.2/src/phone.h:278:7: style: The function 'recvd_notify' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:73:15: note: Virtual function in base class twinkle-1.10.2/src/phone.h:278:7: note: Function in derived class twinkle-1.10.2/src/phone.h:279:7: style: The function 'recvd_refer' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:74:15: note: Virtual function in base class twinkle-1.10.2/src/phone.h:279:7: note: Function in derived class twinkle-1.10.2/src/phone.h:280:7: style: The function 'recvd_info' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:75:15: note: Virtual function in base class twinkle-1.10.2/src/phone.h:280:7: note: Function in derived class twinkle-1.10.2/src/phone.h:281:7: style: The function 'recvd_message' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:76:15: note: Virtual function in base class twinkle-1.10.2/src/phone.h:281:7: note: Function in derived class twinkle-1.10.2/src/phone.h:282:7: style: The function 'post_process_request' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:79:15: note: Virtual function in base class twinkle-1.10.2/src/phone.h:282:7: note: Function in derived class twinkle-1.10.2/src/phone.h:284:7: style: The function 'failure' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:83:15: note: Virtual function in base class twinkle-1.10.2/src/phone.h:284:7: note: Function in derived class twinkle-1.10.2/src/phone.h:286:7: style: The function 'recvd_stun_resp' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:86:15: note: Virtual function in base class twinkle-1.10.2/src/phone.h:286:7: note: Function in derived class twinkle-1.10.2/src/phone.h:288:7: style: The function 'recvd_refer_permission' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:89:15: note: Virtual function in base class twinkle-1.10.2/src/phone.h:288:7: note: Function in derived class twinkle-1.10.2/src/phone.h:292:15: style: The function 'handle_event_timeout' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:95:15: note: Virtual function in base class twinkle-1.10.2/src/phone.h:292:15: note: Function in derived class twinkle-1.10.2/src/phone.h:335:15: style: The function 'handle_broken_connection' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:101:15: note: Virtual function in base class twinkle-1.10.2/src/phone.h:335:15: note: Function in derived class twinkle-1.10.2/src/phone.h:339:11: style: The destructor '~t_phone' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/transaction_layer.h:104:11: note: Virtual destructor in base class twinkle-1.10.2/src/phone.h:339:11: note: Destructor in derived class twinkle-1.10.2/src/redirect.h:45:51: performance: Function parameter 'contact' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/sdp/sdp.h:270:17: performance: Function parameter 'param' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/presence/buddy.h:95:50: performance: Function parameter '_name' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:80:44: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:84:45: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:85:45: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:86:45: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:87:48: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:88:45: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:89:40: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:90:35: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:91:43: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:92:42: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:93:43: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:94:47: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:95:37: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:96:42: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:97:36: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:98:36: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:99:47: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:100:49: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:101:58: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:102:46: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:103:43: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:104:43: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:105:43: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:106:46: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:107:47: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:108:43: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/userintf.h:109:43: performance: Function parameter 'command_list' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/abstract_dialog.cpp:45:10: style: Variable 'user_config' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/abstract_dialog.cpp:121:10: style: Variable 'user_config' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/address_book.h:51:15: style: The function 'create_file_record' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/utils/record_file.h:54:15: note: Virtual function in base class twinkle-1.10.2/src/address_book.h:51:15: note: Function in derived class twinkle-1.10.2/src/address_book.h:52:15: style: The function 'populate_from_file_record' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/utils/record_file.h:62:15: note: Virtual function in base class twinkle-1.10.2/src/address_book.h:52:15: note: Function in derived class twinkle-1.10.2/src/address_book.cpp:80:54: performance: Function parameter 'other' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/address_book.cpp:106:27: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/auth.cpp:32:2: performance: Variable 'credentials' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/auth.cpp:33:2: performance: Variable 'passwd' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/auth.h:107:7: performance:inconclusive: Technically the member function 't_auth::auth_failed' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/auth.cpp:85:14: note: Technically the member function 't_auth::auth_failed' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/auth.h:107:7: note: Technically the member function 't_auth::auth_failed' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/auth.h:117:7: performance:inconclusive: Technically the member function 't_auth::remove_credentials' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/auth.cpp:102:14: note: Technically the member function 't_auth::remove_credentials' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/auth.h:117:7: note: Technically the member function 't_auth::remove_credentials' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/auth.cpp:52:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/auth.cpp:63:38: style: Unused variable: j [unusedVariable] twinkle-1.10.2/src/auth.cpp:42:25: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/client_request.cpp:42:2: warning: Class 't_client_request' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] twinkle-1.10.2/src/client_request.cpp:42:2: warning: Class 't_client_request' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] twinkle-1.10.2/src/call_history.cpp:44:16: warning: Member variable 't_call_record::direction' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/call_history.cpp:44:16: warning: Member variable 't_call_record::rel_cause' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/client_request.cpp:27:12: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/client_request.cpp:70:17: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/client_request.cpp:38:63: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/call_history.cpp:442:26: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/call_history.cpp:440:27: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/call_script.h:171:2: warning:inconclusive: Member variable 't_call_script::user_config' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/call_script.h:171:2: warning:inconclusive: Member variable 't_call_script::trigger' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/call_script.h:149:9: performance:inconclusive: Technically the member function 't_call_script::trigger2str' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/call_script.cpp:113:23: note: Technically the member function 't_call_script::trigger2str' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/call_script.h:149:9: note: Technically the member function 't_call_script::trigger2str' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/call_script.cpp:57:68: performance: Function parameter 'action_string' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/call_script.cpp:181:60: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/call_script.cpp:213:29: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/cmd_socket.cpp:135:29: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/cmd_socket.cpp:58:9: style: The scope of the variable 'log_msg' can be reduced. [variableScope] twinkle-1.10.2/src/gui/address_finder.h:74:8: error: There is an unknown macro here somewhere. Configuration is required. If slots is a macro then please configure it. [unknownMacro] twinkle-1.10.2/src/gui/getaddressform.h:17:8: error: There is an unknown macro here somewhere. Configuration is required. If slots is a macro then please configure it. [unknownMacro] twinkle-1.10.2/src/gui/addresstablemodel.cpp:24:2: performance: Variable 'm_data' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/gui/authenticationform.h:16:11: error: There is an unknown macro here somewhere. Configuration is required. If slots is a macro then please configure it. [unknownMacro] twinkle-1.10.2/src/gui/buddylistview.h:64:9: error: There is an unknown macro here somewhere. Configuration is required. If slots is a macro then please configure it. [unknownMacro] twinkle-1.10.2/src/gui/deregisterform.h:13:5: style: Class 'DeregisterForm' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/gui/dtmfform.h:17:8: error: There is an unknown macro here somewhere. Configuration is required. If slots is a macro then please configure it. [unknownMacro] twinkle-1.10.2/src/gui/getprofilenameform.h:19:8: error: There is an unknown macro here somewhere. Configuration is required. If slots is a macro then please configure it. [unknownMacro] twinkle-1.10.2/src/epa.h:106:7: performance:inconclusive: Technically the member function 't_epa::remove_client_request' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/epa.cpp:58:13: note: Technically the member function 't_epa::remove_client_request' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/epa.h:106:7: note: Technically the member function 't_epa::remove_client_request' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/epa.h:212:15: style: Virtual function 'clear' is called from destructor '~t_epa()' at line 203. Dynamic binding is not used. [virtualCallInConstructor] twinkle-1.10.2/src/epa.cpp:203:2: note: Calling clear twinkle-1.10.2/src/epa.h:212:15: note: clear is a virtual function twinkle-1.10.2/src/gui/incoming_call_popup.h:25:8: error: There is an unknown macro here somewhere. Configuration is required. If slots is a macro then please configure it. [unknownMacro] twinkle-1.10.2/src/epa.cpp:189:71: performance: Function parameter '_request_uri' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/gui/logviewform.h:19:8: error: There is an unknown macro here somewhere. Configuration is required. If slots is a macro then please configure it. [unknownMacro] twinkle-1.10.2/src/gui/numberconversionform.h:17:8: error: There is an unknown macro here somewhere. Configuration is required. If slots is a macro then please configure it. [unknownMacro] twinkle-1.10.2/src/gui/osd.h:32:8: error: There is an unknown macro here somewhere. Configuration is required. If slots is a macro then please configure it. [unknownMacro] twinkle-1.10.2/src/gui/textbrowsernoautolink.h:42:2: style: Class 'TextBrowserNoAutoLink' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/events.cpp:176:18: warning: Member variable 't_event_failure::cseq_method' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/events.cpp:183:18: warning: Member variable 't_event_failure::tid' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/events.cpp:269:23: warning: Member variable 't_event_stun_request::src_port' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/events.cpp:370:13: warning: Member variable 't_event_ui::line' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/events.cpp:370:13: warning: Member variable 't_event_ui::codec' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/events.cpp:370:13: warning: Member variable 't_event_ui::dtmf_event' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/events.cpp:370:13: warning: Member variable 't_event_ui::encrypted' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/events.cpp:370:13: warning: Member variable 't_event_ui::msg_priority' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/events.cpp:443:25: warning: Member variable 't_event_async_response::bool_response' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/gui/yesnodialog.h:31:11: error: There is an unknown macro here somewhere. Configuration is required. If slots is a macro then please configure it. [unknownMacro] twinkle-1.10.2/src/id_object.h:55:14: style:inconclusive: Technically the member function 't_id_object::get_object_id' can be const. [functionConst] twinkle-1.10.2/src/id_object.cpp:31:26: note: Technically the member function 't_id_object::get_object_id' can be const. twinkle-1.10.2/src/id_object.h:55:14: note: Technically the member function 't_id_object::get_object_id' can be const. twinkle-1.10.2/src/im/im_iscomposing_body.cpp:80:20: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/im/im_iscomposing_body.cpp:97:19: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/im/im_iscomposing_body.cpp:78:11: style: Variable 'child' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/im/im_iscomposing_body.cpp:95:11: style: Variable 'child' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/events.h:532:7: style:inconclusive: Technically the member function 't_event_ui::exec' can be const. [functionConst] twinkle-1.10.2/src/events.cpp:408:18: note: Technically the member function 't_event_ui::exec' can be const. twinkle-1.10.2/src/events.h:532:7: note: Technically the member function 't_event_ui::exec' can be const. twinkle-1.10.2/src/events.cpp:273:2: warning: Class 't_event_stun_request' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] twinkle-1.10.2/src/events.cpp:273:2: warning: Class 't_event_stun_request' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] twinkle-1.10.2/src/events.cpp:320:2: warning: Class 't_event_stun_response' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] twinkle-1.10.2/src/events.cpp:320:2: warning: Class 't_event_stun_response' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] twinkle-1.10.2/src/events.h:80:11: style: The destructor '~t_event_quit' overrides a destructor in a base class but is identical to the overridden function [uselessOverride] twinkle-1.10.2/src/events.h:67:11: note: Virtual destructor in base class twinkle-1.10.2/src/events.h:80:11: note: Destructor in derived class twinkle-1.10.2/src/im/msg_session.cpp:61:8: warning: Member variable 't_msg::direction' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/im/msg_session.cpp:61:8: warning: Member variable 't_msg::format' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/events.cpp:704:7: style: Local variable 'interrupt' shadows outer function [shadowFunction] twinkle-1.10.2/src/events.h:849:7: note: Shadowed declaration twinkle-1.10.2/src/events.cpp:704:7: note: Shadow variable twinkle-1.10.2/src/events.cpp:53:49: style: Parameter 'm' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/events.cpp:89:36: style: Parameter 'u' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/events.cpp:89:54: style: Parameter 'm' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/events.cpp:103:36: style: Parameter 'u' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/events.cpp:103:54: style: Parameter 'm' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/events.cpp:156:43: style: Parameter 't' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/events.cpp:217:51: style: Parameter 't' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/events.cpp:269:52: style: Parameter 'u' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/events.cpp:270:16: style: Parameter 'm' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/events.cpp:317:59: style: Parameter 'm' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/subscription.h:114:2: warning:inconclusive: Member variable 't_subscription::role' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/subscription.h:114:2: warning:inconclusive: Member variable 't_subscription::state' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/subscription.h:114:2: warning:inconclusive: Member variable 't_subscription::resubscribe_after' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/subscription.h:114:2: warning:inconclusive: Member variable 't_subscription::may_resubscribe' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/subscription.h:114:2: warning:inconclusive: Member variable 't_subscription::dialog' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/subscription.h:114:2: warning:inconclusive: Member variable 't_subscription::user_config' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/subscription.h:114:2: warning:inconclusive: Member variable 't_subscription::pending' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/subscription.h:114:2: warning:inconclusive: Member variable 't_subscription::id_subscription_timeout' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/subscription.h:114:2: warning:inconclusive: Member variable 't_subscription::auto_refresh' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/subscription.h:114:2: warning:inconclusive: Member variable 't_subscription::subscription_expiry' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/subscription.h:114:2: warning:inconclusive: Member variable 't_subscription::default_duration' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/subscription.h:114:2: warning:inconclusive: Member variable 't_subscription::req_out' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/dialog.h:417:7: style:inconclusive: Technically the member function 't_dialog::state_w4invite_resp' can be const. [functionConst] twinkle-1.10.2/src/dialog.cpp:1463:16: note: Technically the member function 't_dialog::state_w4invite_resp' can be const. twinkle-1.10.2/src/dialog.h:417:7: note: Technically the member function 't_dialog::state_w4invite_resp' can be const. twinkle-1.10.2/src/dialog.h:423:7: style:inconclusive: Technically the member function 't_dialog::state_early' can be const. [functionConst] twinkle-1.10.2/src/dialog.cpp:1595:16: note: Technically the member function 't_dialog::state_early' can be const. twinkle-1.10.2/src/dialog.h:423:7: note: Technically the member function 't_dialog::state_early' can be const. twinkle-1.10.2/src/dialog.h:708:7: performance:inconclusive: Technically the member function 't_dialog::recvd_stun_resp' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/dialog.cpp:3495:16: note: Technically the member function 't_dialog::recvd_stun_resp' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/dialog.h:708:7: note: Technically the member function 't_dialog::recvd_stun_resp' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/dialog.h:754:7: style:inconclusive: Technically the member function 't_dialog::match_response' can be const. [functionConst] twinkle-1.10.2/src/dialog.cpp:3675:16: note: Technically the member function 't_dialog::match_response' can be const. twinkle-1.10.2/src/dialog.h:754:7: note: Technically the member function 't_dialog::match_response' can be const. twinkle-1.10.2/src/dialog.h:763:7: style:inconclusive: Technically the member function 't_dialog::match_cancel' can be const. [functionConst] twinkle-1.10.2/src/dialog.cpp:3682:16: note: Technically the member function 't_dialog::match_cancel' can be const. twinkle-1.10.2/src/dialog.h:763:7: note: Technically the member function 't_dialog::match_cancel' can be const. twinkle-1.10.2/src/dialog.h:771:7: style:inconclusive: Technically the member function 't_dialog::is_invite_retrans' can be const. [functionConst] twinkle-1.10.2/src/dialog.cpp:3686:16: note: Technically the member function 't_dialog::is_invite_retrans' can be const. twinkle-1.10.2/src/dialog.h:771:7: note: Technically the member function 't_dialog::is_invite_retrans' can be const. twinkle-1.10.2/src/dialog.cpp:2262:2: warning: Class 't_dialog' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] twinkle-1.10.2/src/dialog.cpp:2262:2: warning: Class 't_dialog' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] twinkle-1.10.2/src/sub_refer.h:51:11: style: The destructor '~t_sub_refer' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/subscription.h:206:11: note: Virtual destructor in base class twinkle-1.10.2/src/sub_refer.h:51:11: note: Destructor in derived class twinkle-1.10.2/src/sub_refer.h:59:7: style: The function 'recv_notify' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/subscription.h:245:15: note: Virtual function in base class twinkle-1.10.2/src/sub_refer.h:59:7: note: Function in derived class twinkle-1.10.2/src/sub_refer.h:60:7: style: The function 'recv_subscribe' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/subscription.h:235:15: note: Virtual function in base class twinkle-1.10.2/src/sub_refer.h:60:7: note: Function in derived class twinkle-1.10.2/src/sub_refer.h:62:7: style: The function 'timeout' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/subscription.h:283:15: note: Virtual function in base class twinkle-1.10.2/src/sub_refer.h:62:7: note: Function in derived class twinkle-1.10.2/src/im/im_iscomposing_body.h:64:15: style: The function 'create_xml_doc' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:135:15: note: Virtual function in base class twinkle-1.10.2/src/im/im_iscomposing_body.h:64:15: note: Function in derived class twinkle-1.10.2/src/im/im_iscomposing_body.h:70:22: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:94:22: note: Virtual function in base class twinkle-1.10.2/src/im/im_iscomposing_body.h:70:22: note: Function in derived class twinkle-1.10.2/src/im/im_iscomposing_body.h:71:22: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:100:22: note: Virtual function in base class twinkle-1.10.2/src/im/im_iscomposing_body.h:71:22: note: Function in derived class twinkle-1.10.2/src/im/im_iscomposing_body.h:72:18: style: The function 'get_media' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:106:18: note: Virtual function in base class twinkle-1.10.2/src/im/im_iscomposing_body.h:72:18: note: Function in derived class twinkle-1.10.2/src/im/im_iscomposing_body.h:73:15: style: The function 'parse' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:163:15: note: Virtual function in base class twinkle-1.10.2/src/im/im_iscomposing_body.h:73:15: note: Function in derived class twinkle-1.10.2/src/stun/stun_transaction.h:124:15: style: The function 'retransmit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/stun/stun_transaction.h:80:15: note: Virtual function in base class twinkle-1.10.2/src/stun/stun_transaction.h:124:15: note: Function in derived class twinkle-1.10.2/src/stun/stun_transaction.h:148:15: style: The function 'retransmit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/stun/stun_transaction.h:80:15: note: Virtual function in base class twinkle-1.10.2/src/stun/stun_transaction.h:148:15: note: Function in derived class twinkle-1.10.2/src/stun/stun_transaction.h:155:3: style: The destructor '~t_media_stun_trans' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/stun/stun_transaction.h:96:11: note: Virtual destructor in base class twinkle-1.10.2/src/stun/stun_transaction.h:155:3: note: Destructor in derived class twinkle-1.10.2/src/dialog.cpp:1305:7: style: Condition 'r->body' is always true [knownConditionTrueFalse] twinkle-1.10.2/src/dialog.cpp:202:35: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/dialog.cpp:285:21: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/dialog.cpp:374:44: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/dialog.cpp:520:43: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/dialog.cpp:623:5: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/dialog.cpp:936:24: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/dialog.cpp:1269:22: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/dialog.cpp:1770:27: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/dialog.cpp:1968:16: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/dialog.cpp:1975:36: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/dialog.cpp:2324:36: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/dialog.cpp:2325:44: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/dialog.cpp:2326:20: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/dialog.cpp:197:6: style: The scope of the variable 'warn_code' can be reduced. [variableScope] twinkle-1.10.2/src/dialog.cpp:198:9: style: The scope of the variable 'warn_text' can be reduced. [variableScope] twinkle-1.10.2/src/dialog.cpp:930:6: style: The scope of the variable 'warn_code' can be reduced. [variableScope] twinkle-1.10.2/src/dialog.cpp:931:9: style: The scope of the variable 'warn_text' can be reduced. [variableScope] twinkle-1.10.2/src/dialog.cpp:1143:14: style: The scope of the variable 'resp' can be reduced. [variableScope] twinkle-1.10.2/src/dialog.cpp:1959:7: style: The scope of the variable 'warn_code' can be reduced. [variableScope] twinkle-1.10.2/src/dialog.cpp:1960:10: style: The scope of the variable 'warn_text' can be reduced. [variableScope] twinkle-1.10.2/src/dialog.cpp:3618:19: style: The scope of the variable 'contact' can be reduced. [variableScope] twinkle-1.10.2/src/dialog.cpp:1308:25: style: Local variable 'state' shadows outer variable [shadowVariable] twinkle-1.10.2/src/dialog.h:197:18: note: Shadowed declaration twinkle-1.10.2/src/dialog.cpp:1308:25: note: Shadow variable twinkle-1.10.2/src/call_script.h:103:42: performance: Function parameter 'action_string' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/sub_refer.h:57:16: performance: Function parameter 'reason' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/dialog.cpp:3571:40: performance: Function parameter 'reason' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/dialog.cpp:3603:83: performance: Function parameter 'reason' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/dialog.cpp:3695:9: style: Variable 'orig_top_via' can be declared as reference to const [constVariableReference] twinkle-1.10.2/src/dialog.cpp:3696:9: style: Variable 'recv_top_via' can be declared as reference to const [constVariableReference] twinkle-1.10.2/src/dialog.cpp:50:10: style: Variable 'user_config' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/dialog.cpp:1289:10: style: Variable 'user_config' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/dialog.cpp:1307:30: style: Variable 'sb' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/dialog.cpp:1617:45: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/dialog.cpp:1640:44: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/dialog.cpp:1663:49: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/dialog.cpp:2073:10: style: Variable 'user_config' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/dialog.cpp:2135:10: style: Variable 'user_config' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/dialog.cpp:2176:41: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/dialog.cpp:2259:10: style: Variable 'user_config' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/dialog.cpp:2546:10: style: Variable 'user_config' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/dialog.cpp:3144:10: style: Variable 'user_config' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/dialog.cpp:3195:14: style: Variable 'prack' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/dialog.cpp:3495:45: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/dialog.cpp:3675:44: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/dialog.cpp:3682:40: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/dialog.cpp:2298:33: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/dialog.cpp:2562:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/dialog.cpp:3621:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/log.cpp:61:9: performance: Variable 'log_filename' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/log.cpp:71:2: warning: Class 't_log' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] twinkle-1.10.2/src/log.cpp:71:2: warning: Class 't_log' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] twinkle-1.10.2/src/log.cpp:248:7: style: The scope of the variable 'log_zapped' can be reduced. [variableScope] twinkle-1.10.2/src/log.cpp:248:18: style: Variable 'log_zapped' is assigned a value that is never used. [unreadVariable] twinkle-1.10.2/src/log.cpp:275:14: style: Variable 'log_zapped' is assigned a value that is never used. [unreadVariable] twinkle-1.10.2/src/sockets/connection.h:84:2: style: Class 't_connection' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/parser/parse_ctrl.h:127:2: style: Class 't_syntax_error' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/sdp/sdp_parse_ctrl.h:59:2: style: Class 't_sdp_syntax_error' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/presence/pidf_body.h:70:15: style: The function 'create_xml_doc' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:135:15: note: Virtual function in base class twinkle-1.10.2/src/presence/pidf_body.h:70:15: note: Function in derived class twinkle-1.10.2/src/presence/pidf_body.h:76:22: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:94:22: note: Virtual function in base class twinkle-1.10.2/src/presence/pidf_body.h:76:22: note: Function in derived class twinkle-1.10.2/src/presence/pidf_body.h:77:22: style: The function 'get_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:100:22: note: Virtual function in base class twinkle-1.10.2/src/presence/pidf_body.h:77:22: note: Function in derived class twinkle-1.10.2/src/presence/pidf_body.h:78:18: style: The function 'get_media' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:106:18: note: Virtual function in base class twinkle-1.10.2/src/presence/pidf_body.h:78:18: note: Function in derived class twinkle-1.10.2/src/presence/pidf_body.h:100:15: style: The function 'parse' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/parser/sip_body.h:163:15: note: Virtual function in base class twinkle-1.10.2/src/presence/pidf_body.h:100:15: note: Function in derived class twinkle-1.10.2/src/mwi/mwi.cpp:20:8: warning: Member variable 't_mwi::msg_waiting' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/listener.cpp:431:34: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/mwi/simple_msg_sum_body.cpp:84:24: warning: Member variable 't_simple_msg_sum_body::msg_waiting' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/parser/coding.cpp:27:2: performance: Variable 'content_coding' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/parser/credentials.cpp:103:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/credentials.cpp:149:33: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/challenge.cpp:28:2: performance: Variable 'algorithm' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/parser/challenge.cpp:35:16: style: Condition 's.size()>0' is always false [knownConditionTrueFalse] twinkle-1.10.2/src/parser/challenge.cpp:48:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/challenge.cpp:92:37: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/challenge.cpp:102:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/challenge.cpp:123:22: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/challenge.cpp:141:22: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/challenge.cpp:169:33: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_accept.cpp:39:30: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_accept_encoding.cpp:34:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_accept_language.cpp:23:2: performance: Variable 'language' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/parser/hdr_accept_language.cpp:28:2: performance: Variable 'language' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/parser/hdr_accept_language.cpp:58:33: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/line.cpp:36:14: warning: Member variable 't_call_info::dtmf_inband' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/line.cpp:36:14: warning: Member variable 't_call_info::dtmf_info' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/parser/hdr_alert_info.cpp:48:36: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_allow.cpp:58:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_allow.cpp:65:35: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_auth_info.cpp:94:13: style: Variable 'add_comma' is assigned a value that is never used. [unreadVariable] twinkle-1.10.2/src/line.h:165:12: performance:inconclusive: Technically the member function 't_line::match_response' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/line.cpp:115:19: note: Technically the member function 't_line::match_response' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/line.h:165:12: note: Technically the member function 't_line::match_response' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/line.h:167:12: performance:inconclusive: Technically the member function 't_line::match_response' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/line.cpp:126:19: note: Technically the member function 't_line::match_response' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/line.h:167:12: note: Technically the member function 't_line::match_response' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/line.h:169:12: performance:inconclusive: Technically the member function 't_line::match_call_id_tags' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/line.cpp:137:19: note: Technically the member function 't_line::match_call_id_tags' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/line.h:169:12: note: Technically the member function 't_line::match_call_id_tags' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/line.h:308:7: performance:inconclusive: Technically the member function 't_line::failure' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/line.cpp:1740:14: note: Technically the member function 't_line::failure' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/line.h:308:7: note: Technically the member function 't_line::failure' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/line.h:548:7: style:inconclusive: Technically the member function 't_line::confirm_zrtp_sas' can be const. [functionConst] twinkle-1.10.2/src/line.cpp:2233:14: note: Technically the member function 't_line::confirm_zrtp_sas' can be const. twinkle-1.10.2/src/line.h:548:7: note: Technically the member function 't_line::confirm_zrtp_sas' can be const. twinkle-1.10.2/src/line.h:549:7: style:inconclusive: Technically the member function 't_line::reset_zrtp_sas_confirmation' can be const. [functionConst] twinkle-1.10.2/src/line.cpp:2248:14: note: Technically the member function 't_line::reset_zrtp_sas_confirmation' can be const. twinkle-1.10.2/src/line.h:549:7: note: Technically the member function 't_line::reset_zrtp_sas_confirmation' can be const. twinkle-1.10.2/src/line.h:550:7: style:inconclusive: Technically the member function 't_line::enable_zrtp' can be const. [functionConst] twinkle-1.10.2/src/line.cpp:2263:14: note: Technically the member function 't_line::enable_zrtp' can be const. twinkle-1.10.2/src/line.h:550:7: note: Technically the member function 't_line::enable_zrtp' can be const. twinkle-1.10.2/src/line.h:551:7: style:inconclusive: Technically the member function 't_line::zrtp_request_go_clear' can be const. [functionConst] twinkle-1.10.2/src/line.cpp:2270:14: note: Technically the member function 't_line::zrtp_request_go_clear' can be const. twinkle-1.10.2/src/line.h:551:7: note: Technically the member function 't_line::zrtp_request_go_clear' can be const. twinkle-1.10.2/src/line.h:552:7: style:inconclusive: Technically the member function 't_line::zrtp_go_clear_ok' can be const. [functionConst] twinkle-1.10.2/src/line.cpp:2277:14: note: Technically the member function 't_line::zrtp_go_clear_ok' can be const. twinkle-1.10.2/src/line.h:552:7: note: Technically the member function 't_line::zrtp_go_clear_ok' can be const. twinkle-1.10.2/src/parser/hdr_authorization.cpp:70:3: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/parser/hdr_authorization.cpp:86:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/parser/hdr_authorization.cpp:36:36: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_authorization.cpp:53:36: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_authorization.cpp:66:36: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_authorization.cpp:82:36: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_allow_events.cpp:34:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/line.cpp:1746:22: style: The scope of the variable 'cf_dest' can be reduced. [variableScope] twinkle-1.10.2/src/parser/hdr_call_info.cpp:48:35: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/line.cpp:712:81: performance: Function parameter 'reason' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/line.cpp:640:10: style: Variable 'user_config' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/line.cpp:975:10: style: Variable 'user_config' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/line.cpp:1090:10: style: Variable 'user_config' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/line.cpp:1295:10: style: Variable 'user_config' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/line.cpp:1466:10: style: Variable 'user_config' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/line.cpp:1919:12: style: Variable 'd' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/line.cpp:2012:19: style: Variable 'as' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/line.cpp:2216:10: style: Variable 'user_config' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/line.cpp:120:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/line.cpp:131:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/line.cpp:143:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/line.cpp:163:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/line.cpp:167:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/line.cpp:2309:36: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/line.cpp:2317:36: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/line.cpp:119:36: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/line.cpp:130:36: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/line.cpp:142:36: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/line.cpp:162:64: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/line.cpp:166:60: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/line.cpp:210:4: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/line.cpp:234:64: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/line.cpp:243:60: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/line.cpp:284:64: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/line.cpp:329:64: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/line.cpp:336:60: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/line.cpp:424:64: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/line.cpp:429:60: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/line.cpp:763:36: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/line.cpp:828:36: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/line.cpp:834:34: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/line.cpp:1019:37: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/line.cpp:1071:37: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/line.cpp:1162:37: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/line.cpp:1276:37: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/line.cpp:1357:37: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/line.cpp:1446:37: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_content_language.cpp:35:33: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_contact.cpp:77:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_contact.cpp:95:64: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_contact.cpp:111:72: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_contact.cpp:129:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_contact.cpp:170:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_content_encoding.cpp:35:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_date.cpp:25:13: warning: Member variable 't_hdr_date::date' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/parser/hdr_error_info.cpp:48:36: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_in_reply_to.cpp:34:28: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_p_asserted_identity.cpp:35:33: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_p_preferred_identity.cpp:35:33: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_privacy.cpp:43:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_proxy_require.cpp:34:28: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_proxy_authorization.cpp:70:3: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/parser/hdr_proxy_authorization.cpp:86:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/parser/hdr_proxy_authorization.cpp:36:36: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_proxy_authorization.cpp:53:36: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_proxy_authorization.cpp:66:36: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_proxy_authorization.cpp:82:36: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_record_route.cpp:41:30: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_record_route.cpp:58:30: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_require.cpp:50:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/parser/hdr_require.cpp:33:65: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_require.cpp:48:28: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_require.cpp:62:28: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_server.cpp:27:2: performance: Variable 'product' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/parser/hdr_server.cpp:28:2: performance: Variable 'version' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/parser/hdr_server.cpp:29:2: performance: Variable 'comment' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/parser/hdr_server.cpp:63:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/utils/record_file.h:73:7: style:inconclusive: Member variable 't_record_file < t_address_card >::field_separator' is in the wrong place in the initializer list. [initializerList] twinkle-1.10.2/src/utils/record_file.hpp:58:2: note: Member variable 't_record_file < t_address_card >::field_separator' is in the wrong place in the initializer list. twinkle-1.10.2/src/utils/record_file.h:73:7: note: Member variable 't_record_file < t_address_card >::field_separator' is in the wrong place in the initializer list. twinkle-1.10.2/src/utils/record_file.h:73:7: style:inconclusive: Member variable 't_record_file < t_mime_db_record >::field_separator' is in the wrong place in the initializer list. [initializerList] twinkle-1.10.2/src/utils/record_file.hpp:58:2: note: Member variable 't_record_file < t_mime_db_record >::field_separator' is in the wrong place in the initializer list. twinkle-1.10.2/src/utils/record_file.h:73:7: note: Member variable 't_record_file < t_mime_db_record >::field_separator' is in the wrong place in the initializer list. twinkle-1.10.2/src/parser/hdr_route.cpp:42:30: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_route.cpp:59:30: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_service_route.cpp:41:30: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_service_route.cpp:58:30: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/sockets/interfaces.h:38:2: style: Class 't_interface' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/parser/hdr_unsupported.cpp:39:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/parser/hdr_unsupported.cpp:37:28: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_unsupported.cpp:51:28: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/utils/mime_database.h:43:15: style: The function 'create_file_record' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/utils/record_file.h:54:15: note: Virtual function in base class twinkle-1.10.2/src/utils/mime_database.h:43:15: note: Function in derived class twinkle-1.10.2/src/utils/mime_database.h:44:15: style: The function 'populate_from_file_record' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/utils/record_file.h:62:15: note: Virtual function in base class twinkle-1.10.2/src/utils/mime_database.h:44:15: note: Function in derived class twinkle-1.10.2/src/utils/mime_database.h:60:15: style: The function 'add_record' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/utils/record_file.h:107:15: note: Virtual function in base class twinkle-1.10.2/src/utils/mime_database.h:60:15: note: Function in derived class twinkle-1.10.2/src/utils/mime_database.h:67:3: style: The destructor '~t_mime_database' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/utils/record_file.h:117:11: note: Virtual destructor in base class twinkle-1.10.2/src/utils/mime_database.h:67:3: note: Destructor in derived class twinkle-1.10.2/src/main.cpp:469:4: style: Exception should be caught by reference. [catchExceptionByValue] twinkle-1.10.2/src/parser/hdr_user_agent.cpp:33:27: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_supported.cpp:52:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/parser/hdr_supported.cpp:34:65: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_supported.cpp:50:28: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_supported.cpp:64:28: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/address_book.h:55:39: performance: Function parameter 'other' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/parser/hdr_warning.cpp:28:2: performance: Variable 'host' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/parser/hdr_warning.cpp:27:72: performance: Function parameter '_text' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/parser/hdr_warning.cpp:81:28: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/main.cpp:195:39: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/main.cpp:254:28: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/main.cpp:362:29: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/media_type.cpp:65:3: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/media_type.cpp:71:3: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_via.cpp:34:2: performance: Variable 'protocol_name' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/parser/hdr_via.cpp:35:2: performance: Variable 'protocol_version' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/parser/hdr_via.cpp:36:2: performance: Variable 'transport' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/parser/hdr_via.cpp:37:2: performance: Variable 'host' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/parser/hdr_via.cpp:38:2: performance: Variable 'branch' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/parser/hdr_via.cpp:177:28: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/hdr_via.cpp:194:28: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/parameter.cpp:27:2: performance: Variable 'name' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/parser/parameter.cpp:32:2: performance: Variable 'name' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/parser/parameter.cpp:33:2: performance: Variable 'value' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/parser/parameter.h:47:7: style:inconclusive: Technically the member function 't_parameter::operator==' can be const. [functionConst] twinkle-1.10.2/src/parser/parameter.cpp:53:19: note: Technically the member function 't_parameter::operator==' can be const. twinkle-1.10.2/src/parser/parameter.h:47:7: note: Technically the member function 't_parameter::operator==' can be const. twinkle-1.10.2/src/parser/parameter.cpp:70:21: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/parameter.cpp:83:67: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/header.cpp:78:6: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr] twinkle-1.10.2/src/parser/parse_ctrl.cpp:134:2: performance: Variable 'error' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/parser/parse_ctrl.cpp:100:28: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/response.cpp:25:13: warning: Member variable 't_response::code' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/parser/response.cpp:34:42: performance: Function parameter '_reason' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/parser/sip_body.cpp:196:2: performance: Variable 'duration' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/parser/sip_body.h:138:15: style: Virtual function 'clear_xml_doc' is called from destructor '~t_sip_body_xml()' at line 89. Dynamic binding is not used. [virtualCallInConstructor] twinkle-1.10.2/src/parser/sip_body.cpp:89:2: note: Calling clear_xml_doc twinkle-1.10.2/src/parser/sip_body.h:138:15: note: clear_xml_doc is a virtual function twinkle-1.10.2/src/parser/sip_body.cpp:103:16: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/parser/request.cpp:348:12: warning: Member variable 't_request::transport_specified' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/parser/sip_body.cpp:132:45: performance: Function parameter 's' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/parser/sip_body.cpp:163:55: style: Parameter 'm' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/parser/sip_body.cpp:236:69: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/request.cpp:156:21: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/parser/request.cpp:185:36: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/parser/request.cpp:424:62: performance: Function parameter 'reason' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/patterns/observer.cpp:38:36: style: Parameter 'o' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/parser/request.cpp:196:15: style: Parameter 'fail_reason' can be declared as reference to const [constParameterReference] twinkle-1.10.2/src/parser/request.cpp:619:11: style: Variable 'u' can be declared as reference to const [constVariableReference] twinkle-1.10.2/src/parser/request.cpp:36:14: style: Variable 'tbl' can be declared as const array [constVariable] twinkle-1.10.2/src/parser/request.cpp:110:7: style: Variable 'dst0' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/parser/rijndael.cpp:397:15: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/parser/rijndael.cpp:398:15: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/parser/rijndael.cpp:399:15: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/parser/rijndael.cpp:400:15: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/parser/rijndael.cpp:421:13: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/parser/rijndael.cpp:422:13: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/parser/rijndael.cpp:423:13: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/parser/rijndael.cpp:424:13: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/parser/rijndael.cpp:436:5: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/parser/rijndael.cpp:437:5: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/parser/rijndael.cpp:438:5: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/parser/rijndael.cpp:439:5: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/parser/request.cpp:183:13: style: Variable 'sqn[i]' is assigned a value that is never used. [unreadVariable] twinkle-1.10.2/src/parser/rijndael.cpp:393:10: style: The scope of the variable 't' can be reduced. [variableScope] twinkle-1.10.2/src/presence/buddy.cpp:86:58: performance: Function parameter '_name' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/presence/buddy.cpp:451:36: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/presence/buddy.cpp:467:29: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/presence/buddy.cpp:483:41: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/presence/buddy.cpp:564:38: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/presence/pidf_body.cpp:63:17: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/presence/pidf_body.cpp:94:14: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/presence/pidf_body.cpp:130:26: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/presence/pidf_body.cpp:128:11: style: Variable 'child' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/parser/sip_message.cpp:261:35: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/parser/sip_message.cpp:368:35: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/presence/presence_epa.h:45:2: style: Class 't_presence_epa' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] twinkle-1.10.2/src/presence/presence_state.cpp:51:19: warning: Member variable 't_presence_state::buddy' is not initialized in the constructor. [uninitMemberVarPrivate] twinkle-1.10.2/src/presence/presence_state.cpp:51:19: warning: Member variable 't_presence_state::basic_state' is not initialized in the constructor. [uninitMemberVarPrivate] twinkle-1.10.2/src/redirect.cpp:41:2: performance: Variable 'org_dest' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/sdp/sdp.cpp:205:19: warning: Member variable 't_sdp_connection::address_type' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/sdp/sdp.cpp:234:2: performance: Variable 'name' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/sdp/sdp.cpp:238:2: performance: Variable 'name' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/sdp/sdp.cpp:239:2: performance: Variable 'value' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/sdp/sdp.cpp:272:2: performance: Variable 'media_type' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/redirect.cpp:21:64: performance: Function parameter 'contact' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/redirect.cpp:25:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/redirect.cpp:31:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/redirect.cpp:23:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/redirect.cpp:29:33: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/redirect.cpp:61:68: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/sdp/sdp_parse_ctrl.cpp:68:2: performance: Variable 'error' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/sdp/sdp.cpp:42:42: performance: Function parameter 's' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/sdp/sdp.cpp:59:42: performance: Function parameter 's' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/sdp/sdp.cpp:76:42: performance: Function parameter 's' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/sdp/sdp.cpp:84:44: performance: Function parameter 's' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/sdp/sdp.cpp:175:46: performance: Function parameter '_address' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/sdp/sdp.cpp:209:43: performance: Function parameter '_address' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/sdp/sdp.cpp:233:31: performance: Function parameter '_name' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/sdp/sdp.cpp:237:31: performance: Function parameter '_name' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/sdp/sdp.cpp:237:45: performance: Function parameter '_value' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/sdp/sdp.cpp:724:17: performance: Function parameter 'param' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/sdp/sdp.cpp:385:14: style: Variable 'a' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/sdp/sdp.cpp:807:58: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/sdp/sdp.cpp:821:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/sdp/sdp.cpp:278:28: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/sdp/sdp.cpp:363:30: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/sdp/sdp.cpp:376:30: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/sdp/sdp.cpp:466:30: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/sdp/sdp.cpp:472:25: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/sdp/sdp.cpp:616:25: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/sdp/sdp.cpp:712:25: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/sdp/sdp.cpp:805:25: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/phone_user.cpp:100:15: warning: Member variable 't_phone_user::registration_time' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/phone_user.h:158:7: performance:inconclusive: Technically the member function 't_phone_user::handle_response_options' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/phone_user.cpp:881:20: note: Technically the member function 't_phone_user::handle_response_options' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/phone_user.h:158:7: note: Technically the member function 't_phone_user::handle_response_options' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/phone_user.cpp:107:2: warning: Class 't_phone_user' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] twinkle-1.10.2/src/phone_user.cpp:107:2: warning: Class 't_phone_user' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] twinkle-1.10.2/src/phone_user.cpp:1159:7: style: Condition 'r->body' is always true [knownConditionTrueFalse] twinkle-1.10.2/src/phone_user.cpp:1037:16: style:inconclusive: Function 'send_message' argument 3 names different: declaration 'message' definition 'msg'. [funcArgNamesDifferent] twinkle-1.10.2/src/phone_user.h:322:80: note: Function 'send_message' argument 3 names different: declaration 'message' definition 'msg'. twinkle-1.10.2/src/phone_user.cpp:1037:16: note: Function 'send_message' argument 3 names different: declaration 'message' definition 'msg'. twinkle-1.10.2/src/phone_user.cpp:552:15: style: Local variable 'req' shadows outer variable [shadowVariable] twinkle-1.10.2/src/phone_user.cpp:409:13: note: Shadowed declaration twinkle-1.10.2/src/phone_user.cpp:552:15: note: Shadow variable twinkle-1.10.2/src/phone_user.cpp:654:19: style: Variable 'c' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/phone_user.cpp:860:59: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone_user.cpp:873:63: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone_user.cpp:881:56: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone_user.cpp:992:26: style: Variable 'body' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/phone_user.cpp:1161:30: style: Variable 'sb' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/phone_user.cpp:1452:62: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone_user.cpp:1576:39: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.h:183:7: performance:inconclusive: Technically the member function 't_phone::registration' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/phone.cpp:303:15: note: Technically the member function 't_phone::registration' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/phone.h:183:7: note: Technically the member function 't_phone::registration' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/phone.h:188:7: performance:inconclusive: Technically the member function 't_phone::options' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/phone.cpp:309:15: note: Technically the member function 't_phone::options' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/phone.h:188:7: note: Technically the member function 't_phone::options' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/phone.h:300:7: style:inconclusive: Technically the member function 't_phone::line_timeout' can be const. [functionConst] twinkle-1.10.2/src/phone.cpp:2084:15: note: Technically the member function 't_phone::line_timeout' can be const. twinkle-1.10.2/src/phone.h:300:7: note: Technically the member function 't_phone::line_timeout' can be const. twinkle-1.10.2/src/phone.h:310:7: style:inconclusive: Technically the member function 't_phone::line_timeout_sub' can be const. [functionConst] twinkle-1.10.2/src/phone.cpp:2093:15: note: Technically the member function 't_phone::line_timeout_sub' can be const. twinkle-1.10.2/src/phone.h:310:7: note: Technically the member function 't_phone::line_timeout_sub' can be const. twinkle-1.10.2/src/phone.h:416:7: style:inconclusive: Technically the member function 't_phone::pub_subscribe_mwi' can be const. [functionConst] twinkle-1.10.2/src/phone.cpp:2460:15: note: Technically the member function 't_phone::pub_subscribe_mwi' can be const. twinkle-1.10.2/src/phone.h:416:7: note: Technically the member function 't_phone::pub_subscribe_mwi' can be const. twinkle-1.10.2/src/phone.h:422:7: style:inconclusive: Technically the member function 't_phone::pub_unsubscribe_mwi' can be const. [functionConst] twinkle-1.10.2/src/phone.cpp:2474:15: note: Technically the member function 't_phone::pub_unsubscribe_mwi' can be const. twinkle-1.10.2/src/phone.h:422:7: note: Technically the member function 't_phone::pub_unsubscribe_mwi' can be const. twinkle-1.10.2/src/phone.h:431:7: style:inconclusive: Technically the member function 't_phone::pub_subscribe_presence' can be const. [functionConst] twinkle-1.10.2/src/phone.cpp:2488:15: note: Technically the member function 't_phone::pub_subscribe_presence' can be const. twinkle-1.10.2/src/phone.h:431:7: note: Technically the member function 't_phone::pub_subscribe_presence' can be const. twinkle-1.10.2/src/phone.h:437:7: style:inconclusive: Technically the member function 't_phone::pub_unsubscribe_presence' can be const. [functionConst] twinkle-1.10.2/src/phone.cpp:2502:15: note: Technically the member function 't_phone::pub_unsubscribe_presence' can be const. twinkle-1.10.2/src/phone.h:437:7: note: Technically the member function 't_phone::pub_unsubscribe_presence' can be const. twinkle-1.10.2/src/phone.h:444:7: style:inconclusive: Technically the member function 't_phone::pub_publish_presence' can be const. [functionConst] twinkle-1.10.2/src/phone.cpp:2516:15: note: Technically the member function 't_phone::pub_publish_presence' can be const. twinkle-1.10.2/src/phone.h:444:7: note: Technically the member function 't_phone::pub_publish_presence' can be const. twinkle-1.10.2/src/phone.h:450:7: style:inconclusive: Technically the member function 't_phone::pub_unpublish_presence' can be const. [functionConst] twinkle-1.10.2/src/phone.cpp:2530:15: note: Technically the member function 't_phone::pub_unpublish_presence' can be const. twinkle-1.10.2/src/phone.h:450:7: note: Technically the member function 't_phone::pub_unpublish_presence' can be const. twinkle-1.10.2/src/phone.h:463:7: style:inconclusive: Technically the member function 't_phone::pub_send_message' can be const. [functionConst] twinkle-1.10.2/src/phone.cpp:2544:15: note: Technically the member function 't_phone::pub_send_message' can be const. twinkle-1.10.2/src/phone.h:463:7: note: Technically the member function 't_phone::pub_send_message' can be const. twinkle-1.10.2/src/phone.h:476:7: style:inconclusive: Technically the member function 't_phone::pub_send_im_iscomposing' can be const. [functionConst] twinkle-1.10.2/src/phone.cpp:2567:15: note: Technically the member function 't_phone::pub_send_im_iscomposing' can be const. twinkle-1.10.2/src/phone.h:476:7: note: Technically the member function 't_phone::pub_send_im_iscomposing' can be const. twinkle-1.10.2/src/phone.h:484:7: style:inconclusive: Technically the member function 't_phone::authorize' can be const. [functionConst] twinkle-1.10.2/src/phone.cpp:2657:15: note: Technically the member function 't_phone::authorize' can be const. twinkle-1.10.2/src/phone.h:484:7: note: Technically the member function 't_phone::authorize' can be const. twinkle-1.10.2/src/phone.h:487:7: style:inconclusive: Technically the member function 't_phone::remove_cached_credentials' can be const. [functionConst] twinkle-1.10.2/src/phone.cpp:2668:15: note: Technically the member function 't_phone::remove_cached_credentials' can be const. twinkle-1.10.2/src/phone.h:487:7: note: Technically the member function 't_phone::remove_cached_credentials' can be const. twinkle-1.10.2/src/phone.h:489:7: style:inconclusive: Technically the member function 't_phone::get_is_registered' can be const. [functionConst] twinkle-1.10.2/src/phone.cpp:2674:15: note: Technically the member function 't_phone::get_is_registered' can be const. twinkle-1.10.2/src/phone.h:489:7: note: Technically the member function 't_phone::get_is_registered' can be const. twinkle-1.10.2/src/phone.h:490:7: style:inconclusive: Technically the member function 't_phone::get_last_reg_failed' can be const. [functionConst] twinkle-1.10.2/src/phone.cpp:2684:15: note: Technically the member function 't_phone::get_last_reg_failed' can be const. twinkle-1.10.2/src/phone.h:490:7: note: Technically the member function 't_phone::get_last_reg_failed' can be const. twinkle-1.10.2/src/phone.h:521:7: style:inconclusive: Technically the member function 't_phone::part_of_3way' can be const. [functionConst] twinkle-1.10.2/src/phone.cpp:2841:15: note: Technically the member function 't_phone::part_of_3way' can be const. twinkle-1.10.2/src/phone.h:521:7: note: Technically the member function 't_phone::part_of_3way' can be const. twinkle-1.10.2/src/phone.h:564:7: style:inconclusive: Technically the member function 't_phone::remove_phone_user' can be const. [functionConst] twinkle-1.10.2/src/phone.cpp:3082:15: note: Technically the member function 't_phone::remove_phone_user' can be const. twinkle-1.10.2/src/phone.h:564:7: note: Technically the member function 't_phone::remove_phone_user' can be const. twinkle-1.10.2/src/phone.h:639:7: style:inconclusive: Technically the member function 't_phone::use_stun' can be const. [functionConst] twinkle-1.10.2/src/phone.cpp:3192:15: note: Technically the member function 't_phone::use_stun' can be const. twinkle-1.10.2/src/phone.h:639:7: note: Technically the member function 't_phone::use_stun' can be const. twinkle-1.10.2/src/phone.h:642:7: style:inconclusive: Technically the member function 't_phone::use_nat_keepalive' can be const. [functionConst] twinkle-1.10.2/src/phone.cpp:3206:15: note: Technically the member function 't_phone::use_nat_keepalive' can be const. twinkle-1.10.2/src/phone.h:642:7: note: Technically the member function 't_phone::use_nat_keepalive' can be const. twinkle-1.10.2/src/phone.h:645:7: style:inconclusive: Technically the member function 't_phone::disable_stun' can be const. [functionConst] twinkle-1.10.2/src/phone.cpp:3220:15: note: Technically the member function 't_phone::disable_stun' can be const. twinkle-1.10.2/src/phone.h:645:7: note: Technically the member function 't_phone::disable_stun' can be const. twinkle-1.10.2/src/phone.h:648:7: style:inconclusive: Technically the member function 't_phone::sync_nat_keepalive' can be const. [functionConst] twinkle-1.10.2/src/phone.cpp:3226:15: note: Technically the member function 't_phone::sync_nat_keepalive' can be const. twinkle-1.10.2/src/phone.h:648:7: note: Technically the member function 't_phone::sync_nat_keepalive' can be const. twinkle-1.10.2/src/phone.h:657:7: style:inconclusive: Technically the member function 't_phone::stun_discover_nat' can be const. [functionConst] twinkle-1.10.2/src/phone.cpp:3267:15: note: Technically the member function 't_phone::stun_discover_nat' can be const. twinkle-1.10.2/src/phone.h:657:7: note: Technically the member function 't_phone::stun_discover_nat' can be const. twinkle-1.10.2/src/phone.h:667:7: performance:inconclusive: Technically the member function 't_phone::stop_timer' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/phone.cpp:646:15: note: Technically the member function 't_phone::stop_timer' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/phone.h:667:7: note: Technically the member function 't_phone::stop_timer' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/phone.h:689:7: performance:inconclusive: Technically the member function 't_phone::set_sighandler' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/phone.cpp:3338:15: note: Technically the member function 't_phone::set_sighandler' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/phone.h:689:7: note: Technically the member function 't_phone::set_sighandler' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/phone.cpp:186:9: warning: Either the condition 'as_peer' is redundant or there is possible null pointer dereference: as_peer. [nullPointerRedundantCheck] twinkle-1.10.2/src/phone.cpp:176:8: note: Assuming that condition 'as_peer' is not redundant twinkle-1.10.2/src/phone.cpp:186:9: note: Null pointer dereference twinkle-1.10.2/src/phone.cpp:162:20: style: The scope of the variable 'as_peer' can be reduced. [variableScope] twinkle-1.10.2/src/phone.cpp:1463:14: style: The scope of the variable 'resp' can be reduced. [variableScope] twinkle-1.10.2/src/phone.cpp:1678:16: style: The scope of the variable 'pu' can be reduced. [variableScope] twinkle-1.10.2/src/phone.cpp:282:21: style: Local variable 'x' shadows outer variable [shadowVariable] twinkle-1.10.2/src/phone.cpp:264:19: note: Shadowed declaration twinkle-1.10.2/src/phone.cpp:282:21: note: Shadow variable twinkle-1.10.2/src/phone.cpp:3250:8: warning:inconclusive: Found suspicious operator '+', result is not used. [constStatement] twinkle-1.10.2/src/phone.cpp:253:82: performance: Function parameter 'reason' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/phone.cpp:2275:86: performance: Function parameter 'reason' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/phone.cpp:45:45: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.cpp:380:10: style: Variable 'line' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/phone.cpp:390:12: style: Variable 'user_config' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/phone.cpp:406:10: style: Variable 'user_config' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/phone.cpp:601:10: style: Variable 'user_config' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/phone.cpp:624:11: style: Variable 'user_config' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/phone.cpp:729:11: style: Variable 'user_config' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/phone.cpp:1368:12: style: Variable 'user_config' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/phone.cpp:1466:17: style: Variable 'pu' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/phone.cpp:1777:12: style: Variable 'user_config' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/phone.cpp:2045:15: style: Variable 'tmr_line' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/phone.cpp:2240:34: style: Parameter 'user' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.cpp:2288:40: style: Parameter 'user' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.cpp:2305:35: style: Parameter 'user' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.cpp:2460:41: style: Parameter 'user' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.cpp:2474:43: style: Parameter 'user' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.cpp:2488:46: style: Parameter 'user' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.cpp:2502:48: style: Parameter 'user' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.cpp:2516:44: style: Parameter 'user' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.cpp:2530:46: style: Parameter 'user' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.cpp:2544:40: style: Parameter 'user' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.cpp:2567:47: style: Parameter 'user' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.cpp:2657:33: style: Parameter 'user' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.cpp:2668:49: style: Parameter 'user' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.cpp:2674:41: style: Parameter 'user' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.cpp:2678:16: style: Variable 'pu' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/phone.cpp:2684:43: style: Parameter 'user' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.cpp:2688:16: style: Variable 'pu' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/phone.cpp:2785:41: style: Parameter 'user' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.cpp:2789:16: style: Variable 'pu' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/phone.cpp:2795:41: style: Parameter 'user' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.cpp:2799:16: style: Variable 'pu' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/phone.cpp:2805:32: style: Parameter 'user' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.cpp:2809:16: style: Variable 'pu' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/phone.cpp:2815:46: style: Parameter 'user' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.cpp:2819:16: style: Variable 'pu' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/phone.cpp:3166:16: style: Variable 'pu' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/phone.cpp:3182:16: style: Variable 'pu' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/phone.cpp:3192:32: style: Parameter 'user' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.cpp:3196:16: style: Variable 'pu' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/phone.cpp:3206:41: style: Parameter 'user' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.cpp:3210:16: style: Variable 'pu' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/phone.cpp:3220:36: style: Parameter 'user' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.cpp:3226:42: style: Parameter 'user' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.cpp:3240:11: style: Variable 'user_config' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/phone.cpp:3287:54: style: Parameter 'user' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/phone.cpp:3293:16: style: Variable 'pu' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/phone.cpp:3548:7: style: Variable 'pid' is assigned a value that is never used. [unreadVariable] twinkle-1.10.2/src/phone.cpp:2109:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/phone.cpp:2121:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/phone.cpp:2233:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/phone.cpp:3031:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/phone.cpp:3093:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/phone.cpp:3107:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/phone.cpp:3307:77: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/phone.cpp:3389:29: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/phone.cpp:3417:77: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/phone.cpp:3429:77: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/phone.cpp:3442:77: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/sender.cpp:135:6: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sender.cpp:186:6: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sender.cpp:324:6: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sender.cpp:401:9: style: The scope of the variable 'log_msg' can be reduced. [variableScope] twinkle-1.10.2/src/sender.cpp:495:12: style: The scope of the variable 'event' can be reduced. [variableScope] twinkle-1.10.2/src/sender.cpp:322:24: style: Variable 'e' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/sender.cpp:374:7: style: Variable 'm' can be declared as const array [constVariable] twinkle-1.10.2/src/sender.cpp:496:19: style: Variable 'ev_network' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/sockets/connection.cpp:100:9: style: The scope of the variable 'log_msg' can be reduced. [variableScope] twinkle-1.10.2/src/sockets/connection.cpp:153:34: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/service.cpp:363:34: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/service.cpp:369:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/service.cpp:375:36: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/sockets/dnssrv.cpp:60:22: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/dnssrv.cpp:61:22: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/dnssrv.cpp:63:20: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/dnssrv.cpp:64:20: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/dnssrv.cpp:116:11: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/dnssrv.cpp:157:4: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/dnssrv.cpp:89:10: style: Variable 'nameshdr' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/sockets/interfaces.cpp:80:6: style: Obsolescent function 'gethostbyname' called. It is recommended to use 'getaddrinfo' instead. [prohibitedgethostbynameCalled] twinkle-1.10.2/src/sockets/interfaces.cpp:59:11: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/interfaces.cpp:62:11: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/interfaces.cpp:82:31: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/interfaces.cpp:25:33: performance: Function parameter '_name' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/sockets/interfaces.cpp:37:26: style: Variable 'sin' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/sockets/interfaces.cpp:78:18: style: Variable 'h' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/sockets/interfaces.cpp:80:6: performance: Passing the result of c_str() to a function that takes std::string as argument no. 1 is slow and redundant. [stlcstrParam] twinkle-1.10.2/src/sockets/interfaces.cpp:87:35: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/sockets/interfaces.cpp:104:28: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/sockets/interfaces.cpp:86:66: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/sockets/interfaces.cpp:103:66: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/sockets/connection_table.cpp:90:21: warning: Member variable 't_connection_table::fd_pipe_modified_read_' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/sockets/connection_table.cpp:90:21: warning: Member variable 't_connection_table::fd_pipe_modified_write_' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/sockets/connection_table.cpp:90:21: warning: Member variable 't_connection_table::fd_pipe_quit_read_' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/sockets/connection_table.cpp:90:21: warning: Member variable 't_connection_table::fd_pipe_quit_write_' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/sockets/connection_table.h:61:7: performance:inconclusive: Technically the member function 't_connection_table::create_pipe' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/sockets/connection_table.cpp:38:26: note: Technically the member function 't_connection_table::create_pipe' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/sockets/connection_table.h:61:7: note: Technically the member function 't_connection_table::create_pipe' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/sockets/connection_table.h:91:7: performance:inconclusive: Technically the member function 't_connection_table::unlock' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/sockets/connection_table.cpp:110:26: note: Technically the member function 't_connection_table::unlock' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/sockets/connection_table.h:91:7: note: Technically the member function 't_connection_table::unlock' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/sockets/connection_table.cpp:149:17: style: The scope of the variable 'addr' can be reduced. [variableScope] twinkle-1.10.2/src/sockets/connection_table.cpp:150:18: style: The scope of the variable 'port' can be reduced. [variableScope] twinkle-1.10.2/src/sockets/connection_table.cpp:189:6: style: The scope of the variable 'nfds' can be reduced. [variableScope] twinkle-1.10.2/src/sockets/connection_table.cpp:266:6: style: The scope of the variable 'nfds' can be reduced. [variableScope] twinkle-1.10.2/src/sockets/connection_table.cpp:131:58: style: Parameter 'connection' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/sockets/connection_table.cpp:214:14: style: Variable 'socket' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/sockets/connection_table.cpp:236:14: style: Variable 'socket' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/sockets/connection_table.cpp:293:15: style: Variable 'socket' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/sockets/connection_table.cpp:316:14: style: Variable 'socket' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/sockets/connection_table.cpp:189:11: style: Variable 'nfds' is assigned a value that is never used. [unreadVariable] twinkle-1.10.2/src/sockets/connection_table.cpp:266:11: style: Variable 'nfds' is assigned a value that is never used. [unreadVariable] twinkle-1.10.2/src/sockets/socket.h:132:7: performance:inconclusive: Technically the member function 't_socket_udp::enable_icmp' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/sockets/socket.cpp:186:20: note: Technically the member function 't_socket_udp::enable_icmp' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/sockets/socket.h:132:7: note: Technically the member function 't_socket_udp::enable_icmp' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/sockets/socket.h:136:7: performance:inconclusive: Technically the member function 't_socket_udp::get_icmp' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/sockets/socket.cpp:197:20: note: Technically the member function 't_socket_udp::get_icmp' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/sockets/socket.h:136:7: note: Technically the member function 't_socket_udp::get_icmp' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/sockets/socket.cpp:89:20: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/socket.cpp:103:20: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/socket.cpp:114:23: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/socket.cpp:129:9: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/socket.cpp:150:11: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/socket.cpp:261:25: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/socket.cpp:298:20: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/socket.cpp:313:26: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/socket.cpp:331:23: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/socket.cpp:355:29: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/socket.cpp:388:20: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/socket.cpp:417:23: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/socket.cpp:197:41: style: Parameter 'icmp' can be declared as reference to const [constParameterReference] twinkle-1.10.2/src/sockets/socket.cpp:261:17: style: Variable 'ipbuf' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/stun/stun_transaction.cpp:392:21: warning: Member variable 't_stun_transaction::timer_req_timeout' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/stun/stun_transaction.cpp:401:2: warning: Class 't_stun_transaction' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] twinkle-1.10.2/src/stun/stun_transaction.cpp:401:2: warning: Class 't_stun_transaction' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] twinkle-1.10.2/src/stun/stun_transaction.cpp:592:3: warning: Class 't_media_stun_trans' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] twinkle-1.10.2/src/stun/stun_transaction.cpp:592:3: warning: Class 't_media_stun_trans' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] twinkle-1.10.2/src/stun/stun_transaction.cpp:353:23: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/stun/stun_transaction.cpp:392:67: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/stun/stun_transaction.cpp:509:45: style: Parameter 'resp' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/stun/udp.cxx:47:7: error: Resource leak: fd [resourceLeak] twinkle-1.10.2/src/stun/udp.cxx:51:11: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/stun/udp.cxx:67:21: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/stun/udp.cxx:130:21: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/stun/udp.cxx:131:20: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/stun/udp.cxx:210:32: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/stun/udp.cxx:183:35: style:inconclusive: Function 'sendMessage' argument 2 names different: declaration 'msg' definition 'buf'. [funcArgNamesDifferent] twinkle-1.10.2/src/stun/udp.h:89:35: note: Function 'sendMessage' argument 2 names different: declaration 'msg' definition 'buf'. twinkle-1.10.2/src/stun/udp.cxx:183:35: note: Function 'sendMessage' argument 2 names different: declaration 'msg' definition 'buf'. twinkle-1.10.2/src/stun/udp.cxx:183:44: style:inconclusive: Function 'sendMessage' argument 3 names different: declaration 'len' definition 'l'. [funcArgNamesDifferent] twinkle-1.10.2/src/stun/udp.h:89:44: note: Function 'sendMessage' argument 3 names different: declaration 'len' definition 'l'. twinkle-1.10.2/src/stun/udp.cxx:183:44: note: Function 'sendMessage' argument 3 names different: declaration 'len' definition 'l'. twinkle-1.10.2/src/stun/udp.cxx:183:35: style: Parameter 'buf' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/sockets/url.cpp:428:8: warning: Member variable 't_url::user_url' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/sockets/url.h:274:7: style:inconclusive: Technically the member function 't_display_url::is_valid' can be const. [functionConst] twinkle-1.10.2/src/sockets/url.cpp:891:21: note: Technically the member function 't_display_url::is_valid' can be const. twinkle-1.10.2/src/sockets/url.h:274:7: note: Technically the member function 't_display_url::is_valid' can be const. twinkle-1.10.2/src/sockets/url.cpp:50:17: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/url.cpp:110:21: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/url.cpp:125:25: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/url.cpp:523:11: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/url.cpp:545:22: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sockets/url.cpp:46:18: style: Variable 'h' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/sockets/url.cpp:54:18: style: Variable 'h' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/sockets/url.cpp:77:18: style: Variable 'h' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/sockets/url.cpp:537:18: style: Variable 'h' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/sockets/url.cpp:57:6: performance: Passing the result of c_str() to a function that takes std::string as argument no. 1 is slow and redundant. [stlcstrParam] twinkle-1.10.2/src/sockets/url.cpp:521:6: performance: Passing the result of c_str() to a function that takes std::string as argument no. 1 is slow and redundant. [stlcstrParam] twinkle-1.10.2/src/sockets/url.cpp:543:6: performance: Passing the result of c_str() to a function that takes std::string as argument no. 1 is slow and redundant. [stlcstrParam] twinkle-1.10.2/src/sockets/url.cpp:567:15: style: Unused variable: ip_port [unusedVariable] twinkle-1.10.2/src/sockets/url.cpp:581:12: style: Unused variable: ip_port [unusedVariable] twinkle-1.10.2/src/sockets/url.cpp:354:29: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/sockets/url.cpp:564:25: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/sockets/url.cpp:570:34: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/sockets/url.cpp:584:27: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/session.cpp:497:26: style: Obsolescent function 'gethostbyname' called. It is recommended to use 'getaddrinfo' instead. [prohibitedgethostbynameCalled] twinkle-1.10.2/src/session.cpp:73:12: warning: Member variable 't_session::dst_rtp_port' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/session.cpp:73:12: warning: Member variable 't_session::dst_zrtp_support' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/session.h:79:7: style: Unused private function: 't_session::is_3way' [unusedPrivateFunction] twinkle-1.10.2/src/session.h:82:13: style: Unused private function: 't_session::get_peer_3way' [unusedPrivateFunction] twinkle-1.10.2/src/session.cpp:461:4: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/session.cpp:468:4: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/session.cpp:474:4: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/session.cpp:479:4: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/session.cpp:552:5: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/session.cpp:562:5: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/session.cpp:578:4: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/session.cpp:585:4: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/session.cpp:591:4: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/session.cpp:596:4: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/session.cpp:73:48: performance: Function parameter '_receive_host' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/session.cpp:36:41: style: Parameter 'sdp' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/session.cpp:64:10: style: Variable 'peer_line' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/session.cpp:42:28: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/session.cpp:295:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/session.cpp:376:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/session.cpp:546:41: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/sub_refer.cpp:170:38: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sub_refer.cpp:190:7: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sub_refer.cpp:199:39: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/sub_refer.cpp:129:16: performance: Function parameter 'reason' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/sub_refer.cpp:128:43: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/sub_refer.cpp:199:14: style: Variable 'sipfrag' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/subscription.h:123:7: performance:inconclusive: Technically the member function 't_subscription::remove_client_request' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/subscription.cpp:56:22: note: Technically the member function 't_subscription::remove_client_request' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/subscription.h:123:7: note: Technically the member function 't_subscription::remove_client_request' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/subscription.cpp:109:40: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/subscription.cpp:115:40: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/subscription_dialog.h:51:15: style: The function 'send_request' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/abstract_dialog.h:114:15: note: Virtual function in base class twinkle-1.10.2/src/subscription_dialog.h:51:15: note: Function in derived class twinkle-1.10.2/src/subscription_dialog.h:83:11: style: The destructor '~t_subscription_dialog' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/abstract_dialog.h:171:11: note: Virtual destructor in base class twinkle-1.10.2/src/subscription_dialog.h:83:11: note: Destructor in derived class twinkle-1.10.2/src/subscription_dialog.h:85:21: style: The function 'create_request' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/abstract_dialog.h:178:21: note: Virtual function in base class twinkle-1.10.2/src/subscription_dialog.h:85:21: note: Function in derived class twinkle-1.10.2/src/subscription_dialog.h:87:33: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/abstract_dialog.h:184:29: note: Virtual function in base class twinkle-1.10.2/src/subscription_dialog.h:87:33: note: Function in derived class twinkle-1.10.2/src/subscription_dialog.h:89:15: style: The function 'resend_request_auth' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/abstract_dialog.h:202:15: note: Virtual function in base class twinkle-1.10.2/src/subscription_dialog.h:89:15: note: Function in derived class twinkle-1.10.2/src/subscription_dialog.h:91:15: style: The function 'redirect_request' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/abstract_dialog.h:210:15: note: Virtual function in base class twinkle-1.10.2/src/subscription_dialog.h:91:15: note: Function in derived class twinkle-1.10.2/src/subscription_dialog.h:93:15: style: The function 'failover_request' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/abstract_dialog.h:218:15: note: Virtual function in base class twinkle-1.10.2/src/subscription_dialog.h:93:15: note: Function in derived class twinkle-1.10.2/src/subscription_dialog.h:95:15: style: The function 'recvd_response' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/abstract_dialog.h:226:15: note: Virtual function in base class twinkle-1.10.2/src/subscription_dialog.h:95:15: note: Function in derived class twinkle-1.10.2/src/subscription_dialog.h:97:15: style: The function 'recvd_request' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/abstract_dialog.h:234:15: note: Virtual function in base class twinkle-1.10.2/src/subscription_dialog.h:97:15: note: Function in derived class twinkle-1.10.2/src/mwi/mwi_dialog.h:31:24: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/subscription_dialog.h:87:33: note: Virtual function in base class twinkle-1.10.2/src/mwi/mwi_dialog.h:31:24: note: Function in derived class twinkle-1.10.2/src/presence/presence_dialog.h:43:29: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] twinkle-1.10.2/src/subscription_dialog.h:87:33: note: Virtual function in base class twinkle-1.10.2/src/presence/presence_dialog.h:43:29: note: Function in derived class twinkle-1.10.2/src/subscription_dialog.cpp:240:10: style: Variable 'user_config' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/timekeeper.cpp:238:2: performance: Variable 'sub_event_type' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/timekeeper.cpp:239:2: performance: Variable 'sub_event_id' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/timekeeper.h:232:7: performance:inconclusive: Technically the member function 't_timekeeper::start' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/timekeeper.cpp:370:20: note: Technically the member function 't_timekeeper::start' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/timekeeper.h:232:7: note: Technically the member function 't_timekeeper::start' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/timekeeper.cpp:747:15: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/timekeeper.cpp:751:14: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/timekeeper.cpp:521:9: style: The scope of the variable 'remain_msec' can be reduced. [variableScope] twinkle-1.10.2/src/timekeeper.cpp:718:13: style: The scope of the variable 'event' can be reduced. [variableScope] twinkle-1.10.2/src/timekeeper.cpp:719:23: style: Variable 'ev_start' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/timekeeper.cpp:720:22: style: Variable 'ev_stop' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/timekeeper.cpp:391:30: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/timekeeper.cpp:491:54: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/timekeeper.cpp:540:3: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/timekeeper.cpp:593:2: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/timekeeper.cpp:693:3: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/transaction.cpp:62:12: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/transaction.cpp:88:24: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/transaction.cpp:92:10: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/transaction.cpp:1165:9: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/transaction.cpp:792:9: style: The scope of the variable 'tid_cancel' can be reduced. [variableScope] twinkle-1.10.2/src/transaction.cpp:126:61: performance: Function parameter 'reason' should be passed by const reference. [passedByValue] twinkle-1.10.2/src/transaction.cpp:172:9: style: Variable 'req_top_via' can be declared as reference to const [constVariableReference] twinkle-1.10.2/src/transaction.cpp:173:9: style: Variable 'resp_top_via' can be declared as reference to const [constVariableReference] twinkle-1.10.2/src/transaction.cpp:195:9: style: Variable 'req_top_via' can be declared as reference to const [constVariableReference] twinkle-1.10.2/src/transaction.cpp:855:9: style: Variable 'orig_top_via' can be declared as reference to const [constVariableReference] twinkle-1.10.2/src/transaction.cpp:856:9: style: Variable 'recv_top_via' can be declared as reference to const [constVariableReference] twinkle-1.10.2/src/transaction.cpp:55:41: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/transaction.cpp:791:18: style: Variable 't' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/transaction.cpp:1160:42: style: Parameter 'ack_request' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/transaction.cpp:76:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/stun/stun.cxx:69:32: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] twinkle-1.10.2/src/stun/stun.cxx:1351:39: style:inconclusive: Boolean expression 'req.hasMessageIntegrity' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] twinkle-1.10.2/src/stun/stun.cxx:937:8: style: Obsolescent function 'gethostbyname' called. It is recommended to use 'getaddrinfo' instead. [prohibitedgethostbynameCalled] twinkle-1.10.2/src/stun/stun.cxx:1928:4: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled] twinkle-1.10.2/src/stun/stun.cxx:1551:15: style: Expression is always true because 'else if' condition is opposite to previous condition at line 1546. [multiCondition] twinkle-1.10.2/src/stun/stun.cxx:1546:10: note: first condition twinkle-1.10.2/src/stun/stun.cxx:1551:15: note: else if condition is opposite to first condition twinkle-1.10.2/src/stun/stun.cxx:947:20: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/stun/stun.cxx:1786:28: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/stun/stun.cxx:1806:35: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/stun/stun.cxx:877:15: style: Redundant initialization for 'portNum'. The initialized value is overwritten before it is read. [redundantInitialization] twinkle-1.10.2/src/stun/stun.cxx:870:16: note: portNum is initialized twinkle-1.10.2/src/stun/stun.cxx:877:15: note: portNum is overwritten twinkle-1.10.2/src/stun/stun.cxx:1490:9: style: The scope of the variable 'ok' can be reduced. [variableScope] twinkle-1.10.2/src/stun/stun.cxx:1491:9: style: The scope of the variable 'recvAltIp' can be reduced. [variableScope] twinkle-1.10.2/src/stun/stun.cxx:1492:9: style: The scope of the variable 'recvAltPort' can be reduced. [variableScope] twinkle-1.10.2/src/stun/stun.cxx:187:64: style:inconclusive: Function 'stunParseMessage' argument 3 names different: declaration 'message' definition 'msg'. [funcArgNamesDifferent] twinkle-1.10.2/src/stun/stun.h:227:32: note: Function 'stunParseMessage' argument 3 names different: declaration 'message' definition 'msg'. twinkle-1.10.2/src/stun/stun.cxx:187:64: note: Function 'stunParseMessage' argument 3 names different: declaration 'message' definition 'msg'. twinkle-1.10.2/src/stun/stun.cxx:545:39: style:inconclusive: Function 'stunEncodeMessage' argument 1 names different: declaration 'message' definition 'msg'. [funcArgNamesDifferent] twinkle-1.10.2/src/stun/stun.h:236:39: note: Function 'stunEncodeMessage' argument 1 names different: declaration 'message' definition 'msg'. twinkle-1.10.2/src/stun/stun.cxx:545:39: note: Function 'stunEncodeMessage' argument 1 names different: declaration 'message' definition 'msg'. twinkle-1.10.2/src/stun/stun.cxx:718:77: style:inconclusive: Function 'computeHmac' argument 5 names different: declaration 'keySize' definition 'sizeKey'. [funcArgNamesDifferent] twinkle-1.10.2/src/stun/stun.cxx:50:77: note: Function 'computeHmac' argument 5 names different: declaration 'keySize' definition 'sizeKey'. twinkle-1.10.2/src/stun/stun.cxx:718:77: note: Function 'computeHmac' argument 5 names different: declaration 'keySize' definition 'sizeKey'. twinkle-1.10.2/src/stun/stun.cxx:759:40: style:inconclusive: Function 'stunCreateUserName' argument 1 names different: declaration 'addr' definition 'source'. [funcArgNamesDifferent] twinkle-1.10.2/src/stun/stun.h:243:40: note: Function 'stunCreateUserName' argument 1 names different: declaration 'addr' definition 'source'. twinkle-1.10.2/src/stun/stun.cxx:759:40: note: Function 'stunCreateUserName' argument 1 names different: declaration 'addr' definition 'source'. twinkle-1.10.2/src/stun/stun.cxx:959:28: style:inconclusive: Function 'stunParseServerName' argument 1 names different: declaration 'serverName' definition 'name'. [funcArgNamesDifferent] twinkle-1.10.2/src/stun/stun.h:273:28: note: Function 'stunParseServerName' argument 1 names different: declaration 'serverName' definition 'name'. twinkle-1.10.2/src/stun/stun.cxx:959:28: note: Function 'stunParseServerName' argument 1 names different: declaration 'serverName' definition 'name'. twinkle-1.10.2/src/stun/stun.cxx:959:48: style:inconclusive: Function 'stunParseServerName' argument 2 names different: declaration 'stunServerAddr' definition 'addr'. [funcArgNamesDifferent] twinkle-1.10.2/src/stun/stun.h:273:54: note: Function 'stunParseServerName' argument 2 names different: declaration 'stunServerAddr' definition 'addr'. twinkle-1.10.2/src/stun/stun.cxx:959:48: note: Function 'stunParseServerName' argument 2 names different: declaration 'stunServerAddr' definition 'addr'. twinkle-1.10.2/src/stun/stun.cxx:1764:47: style:inconclusive: Function 'stunFindLocalInterfaces' argument 2 names different: declaration 'maxSize' definition 'maxRet'. [funcArgNamesDifferent] twinkle-1.10.2/src/stun/stun.h:299:48: note: Function 'stunFindLocalInterfaces' argument 2 names different: declaration 'maxSize' definition 'maxRet'. twinkle-1.10.2/src/stun/stun.cxx:1764:47: note: Function 'stunFindLocalInterfaces' argument 2 names different: declaration 'maxSize' definition 'maxRet'. twinkle-1.10.2/src/stun/stun.cxx:1947:72: style:inconclusive: Function 'stunTest' argument 4 names different: declaration 'srcAddr' definition 'sAddr'. [funcArgNamesDifferent] twinkle-1.10.2/src/stun/stun.h:302:72: note: Function 'stunTest' argument 4 names different: declaration 'srcAddr' definition 'sAddr'. twinkle-1.10.2/src/stun/stun.cxx:1947:72: note: Function 'stunTest' argument 4 names different: declaration 'srcAddr' definition 'sAddr'. twinkle-1.10.2/src/stun/stun.cxx:2337:55: style:inconclusive: Function 'stunOpenStunSocket' argument 2 names different: declaration 'mappedAddr' definition 'mapAddr'. [funcArgNamesDifferent] twinkle-1.10.2/src/stun/stun.h:335:31: note: Function 'stunOpenStunSocket' argument 2 names different: declaration 'mappedAddr' definition 'mapAddr'. twinkle-1.10.2/src/stun/stun.cxx:2337:55: note: Function 'stunOpenStunSocket' argument 2 names different: declaration 'mappedAddr' definition 'mapAddr'. twinkle-1.10.2/src/stun/stun.cxx:2404:59: style:inconclusive: Function 'stunOpenStunSocketPair' argument 2 names different: declaration 'mappedAddr' definition 'mapAddr'. [funcArgNamesDifferent] twinkle-1.10.2/src/stun/stun.h:341:59: note: Function 'stunOpenStunSocketPair' argument 2 names different: declaration 'mappedAddr' definition 'mapAddr'. twinkle-1.10.2/src/stun/stun.cxx:2404:59: note: Function 'stunOpenStunSocketPair' argument 2 names different: declaration 'mappedAddr' definition 'mapAddr'. twinkle-1.10.2/src/stun/stun.cxx:2406:25: style:inconclusive: Function 'stunOpenStunSocketPair' argument 5 names different: declaration 'srcPort' definition 'port'. [funcArgNamesDifferent] twinkle-1.10.2/src/stun/stun.h:343:25: note: Function 'stunOpenStunSocketPair' argument 5 names different: declaration 'srcPort' definition 'port'. twinkle-1.10.2/src/stun/stun.cxx:2406:25: note: Function 'stunOpenStunSocketPair' argument 5 names different: declaration 'srcPort' definition 'port'. twinkle-1.10.2/src/stun/stun.cxx:1566:24: style: Local variable 'msg' shadows outer variable [shadowVariable] twinkle-1.10.2/src/stun/stun.cxx:1487:9: note: Shadowed declaration twinkle-1.10.2/src/stun/stun.cxx:1566:24: note: Shadow variable twinkle-1.10.2/src/stun/stun.cxx:1567:23: style: Local variable 'msgLen' shadows outer variable [shadowVariable] twinkle-1.10.2/src/stun/stun.cxx:1488:8: note: Shadowed declaration twinkle-1.10.2/src/stun/stun.cxx:1567:23: note: Shadow variable twinkle-1.10.2/src/stun/stun.cxx:1156:37: style: Parameter 'from' can be declared as reference to const [constParameterReference] twinkle-1.10.2/src/stun/stun.cxx:1157:37: style: Parameter 'secondary' can be declared as reference to const [constParameterReference] twinkle-1.10.2/src/stun/stun.cxx:1158:37: style: Parameter 'myAddr' can be declared as reference to const [constParameterReference] twinkle-1.10.2/src/stun/stun.cxx:1159:37: style: Parameter 'altAddr' can be declared as reference to const [constParameterReference] twinkle-1.10.2/src/stun/stun.cxx:1868:46: style: Parameter 'dest' can be declared as reference to const [constParameterReference] twinkle-1.10.2/src/stun/stun.cxx:86:34: style: Parameter 'body' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/stun/stun.cxx:147:27: style: Parameter 'body' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/stun/stun.cxx:171:30: style: Parameter 'body' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/stun/stun.cxx:216:19: style: Variable 'attr' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/stun/stun.cxx:741:16: style: Variable 'hexmap' can be declared as const array [constVariable] twinkle-1.10.2/src/stun/stun.cxx:777:9: style: Variable 'key' can be declared as const array [constVariable] twinkle-1.10.2/src/stun/stun.cxx:800:9: style: Variable 'key' can be declared as const array [constVariable] twinkle-1.10.2/src/stun/stun.cxx:858:26: style: Parameter 'peerName' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/stun/stun.cxx:868:10: style: Variable 'port' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/stun/stun.cxx:1235:36: style: Variable 'hmac' can be declared as const array [constVariable] twinkle-1.10.2/src/stun/stun.cxx:1521:26: style: Variable 'relay' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/stun/stun.cxx:1786:21: style: Variable 'ifr' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/stun/stun.cxx:1806:27: style: Variable 'addr' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/stun/stun.cxx:2338:41: style: Parameter 'srcAddr' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/stun/stun.cxx:2406:45: style: Parameter 'srcAddr' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/stun/stun.cxx:1246:38: error: Uninitialized variable: hmac [uninitvar] twinkle-1.10.2/src/stun/stun.cxx:1779:10: style: Variable 'e' is assigned a value that is never used. [unreadVariable] twinkle-1.10.2/src/stun/stun.cxx:1896:17: style: Variable 'discard' is assigned a value that is never used. [unreadVariable] twinkle-1.10.2/src/stun/stun.cxx:2390:29: style: Variable 'changedAddr' is assigned a value that is never used. [unreadVariable] twinkle-1.10.2/src/stun/stun.cxx:2424:15: style: Variable 'msgLen' is assigned a value that is never used. [unreadVariable] twinkle-1.10.2/src/stun/stun.cxx:2485:32: style: Variable 'changedAddr' is assigned a value that is never used. [unreadVariable] twinkle-1.10.2/src/transaction_mgr.h:85:14: performance:inconclusive: Technically the member function 't_transaction_mgr::start_timer' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/transaction_mgr.cpp:638:32: note: Technically the member function 't_transaction_mgr::start_timer' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/transaction_mgr.h:85:14: note: Technically the member function 't_transaction_mgr::start_timer' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/transaction_mgr.h:87:14: performance:inconclusive: Technically the member function 't_transaction_mgr::start_stun_timer' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/transaction_mgr.cpp:650:32: note: Technically the member function 't_transaction_mgr::start_stun_timer' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/transaction_mgr.h:87:14: note: Technically the member function 't_transaction_mgr::start_stun_timer' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/transaction_mgr.h:91:7: performance:inconclusive: Technically the member function 't_transaction_mgr::stop_timer' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/transaction_mgr.cpp:662:25: note: Technically the member function 't_transaction_mgr::stop_timer' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/transaction_mgr.h:91:7: note: Technically the member function 't_transaction_mgr::stop_timer' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/transaction_mgr.cpp:144:34: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/transaction_mgr.cpp:158:34: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/transaction_mgr.cpp:165:34: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/transaction_mgr.cpp:172:34: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/transaction_mgr.cpp:185:32: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/transaction_mgr.cpp:199:32: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/transaction_mgr.cpp:287:13: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/transaction_mgr.cpp:293:17: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/transaction_mgr.cpp:327:14: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/transaction_mgr.cpp:366:13: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/transaction_mgr.cpp:422:14: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/transaction_mgr.cpp:457:15: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/transaction_mgr.cpp:484:20: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/transaction_mgr.cpp:278:15: style: The scope of the variable 'ts_invite' can be reduced. [variableScope] twinkle-1.10.2/src/transaction_mgr.cpp:667:13: style: The scope of the variable 'event' can be reduced. [variableScope] twinkle-1.10.2/src/transaction_mgr.cpp:134:58: style: Parameter 'user_config' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/transaction_mgr.cpp:148:66: style: Parameter 'user_config' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/transaction_mgr.cpp:276:63: style: Parameter 'e' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/transaction_mgr.cpp:357:57: style: Parameter 'e' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/transaction_mgr.cpp:369:17: style: Variable 't1' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/transaction_mgr.cpp:394:21: style: Variable 't2' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/transaction_mgr.cpp:446:63: style: Parameter 'e' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/transaction_mgr.cpp:448:21: style: Variable 'tmr_trans' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/transaction_mgr.cpp:449:20: style: Variable 'tmr_stun_trans' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/transaction_mgr.cpp:505:65: style: Parameter 'e' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/transaction_mgr.cpp:521:73: style: Parameter 'e' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/transaction_mgr.cpp:525:20: style: Variable 'sst' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/transaction_mgr.cpp:526:22: style: Variable 'mst' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/transaction_mgr.cpp:576:75: style: Parameter 'e' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/transaction_mgr.cpp:619:63: style: Parameter 'e' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/transaction_mgr.cpp:37:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/transaction_mgr.cpp:56:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/transaction_mgr.cpp:67:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/transaction_mgr.cpp:79:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/transaction_mgr.cpp:98:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/transaction_mgr.cpp:117:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/transaction_mgr.cpp:128:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/transaction_mgr.cpp:77:4: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/transaction_mgr.cpp:229:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/transaction_mgr.cpp:245:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/transaction_mgr.cpp:261:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] twinkle-1.10.2/src/transaction_layer.h:107:7: performance:inconclusive: Technically the member function 't_transaction_layer::send_request' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/transaction_layer.cpp:200:27: note: Technically the member function 't_transaction_layer::send_request' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/transaction_layer.h:107:7: note: Technically the member function 't_transaction_layer::send_request' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/transaction_layer.h:108:7: performance:inconclusive: Technically the member function 't_transaction_layer::send_request' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/transaction_layer.cpp:204:27: note: Technically the member function 't_transaction_layer::send_request' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/transaction_layer.h:108:7: note: Technically the member function 't_transaction_layer::send_request' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/transaction_layer.h:111:7: performance:inconclusive: Technically the member function 't_transaction_layer::send_response' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/transaction_layer.cpp:210:27: note: Technically the member function 't_transaction_layer::send_response' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/transaction_layer.h:111:7: note: Technically the member function 't_transaction_layer::send_response' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/transaction_layer.cpp:201:40: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/transaction_layer.cpp:213:27: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/transaction_layer.cpp:236:14: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/transaction_layer.cpp:244:19: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/transaction_layer.cpp:248:20: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/transaction_layer.cpp:261:17: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/transaction_layer.cpp:268:19: style: C-style pointer casting [cstyleCast] twinkle-1.10.2/src/transaction_layer.cpp:217:13: style: The scope of the variable 'event' can be reduced. [variableScope] twinkle-1.10.2/src/transaction_layer.cpp:185:72: style: Parameter 'event' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/transaction_layer.cpp:218:17: style: Variable 'ev_user' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/transaction_layer.cpp:220:20: style: Variable 'ev_failure' can be declared as pointer to const [constVariablePointer] twinkle-1.10.2/src/transaction_layer.cpp:113:57: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] twinkle-1.10.2/src/sys_settings.cpp:1410:25: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled] twinkle-1.10.2/src/sys_settings.cpp:1426:11: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled] twinkle-1.10.2/src/sys_settings.cpp:223:17: warning: Member variable 't_sys_settings::ui_session_main_hidden' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/sys_settings.cpp:223:17: warning: Member variable 't_sys_settings::ui_session_main_state' is not initialized in the constructor. [uninitMemberVar] twinkle-1.10.2/src/sys_settings.cpp:225:2: performance: Variable 'dir_share' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/sys_settings.cpp:226:2: performance: Variable 'filename' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] twinkle-1.10.2/src/sys_settings.h:403:9: performance:inconclusive: Technically the member function 't_sys_settings::get_product_date' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/sys_settings.cpp:1119:24: note: Technically the member function 't_sys_settings::get_product_date' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/sys_settings.h:403:9: note: Technically the member function 't_sys_settings::get_product_date' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/sys_settings.h:409:9: performance:inconclusive: Technically the member function 't_sys_settings::get_options_built' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/sys_settings.cpp:1136:24: note: Technically the member function 't_sys_settings::get_options_built' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/sys_settings.h:409:9: note: Technically the member function 't_sys_settings::get_options_built' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/sys_settings.h:442:9: performance:inconclusive: Technically the member function 't_sys_settings::get_dir_user' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/sys_settings.cpp:1269:24: note: Technically the member function 't_sys_settings::get_dir_user' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/sys_settings.h:442:9: note: Technically the member function 't_sys_settings::get_dir_user' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/sys_settings.h:518:23: performance:inconclusive: Technically the member function 't_sys_settings::get_oss_devices' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/sys_settings.cpp:1837:38: note: Technically the member function 't_sys_settings::get_oss_devices' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/sys_settings.h:518:23: note: Technically the member function 't_sys_settings::get_oss_devices' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/sys_settings.h:529:7: performance:inconclusive: Technically the member function 't_sys_settings::equal_audio_dev' can be static (but you may consider moving to unnamed namespace). [functionStatic] twinkle-1.10.2/src/sys_settings.cpp:1945:22: note: Technically the member function 't_sys_settings::equal_audio_dev' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/sys_settings.h:529:7: note: Technically the member function 't_sys_settings::equal_audio_dev' can be static (but you may consider moving to unnamed namespace). twinkle-1.10.2/src/util.cpp:340:8: style: Array index 'i' is used before limits check. [arrayIndexThenCheck] twinkle-1.10.2/src/util.cpp:369:8: style: Array index 'i' is used before limits check. [arrayIndexThenCheck] twinkle-1.10.2/src/util.cpp:53:6: style: The scope of the variable 'x' can be reduced. [variableScope] twinkle-1.10.2/src/util.cpp:101:22: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] twinkle-1.10.2/src/util.cpp:516:8: warning: Either the condition 'iget_active_line() == current' is always true because 'phone->get_active_line()' and 'current' represent the same value. [knownConditionTrueFalse] twinkle-1.10.2/src/userintf.cpp:1197:38: note: 'current' is assigned value 'phone->get_active_line()' here. twinkle-1.10.2/src/userintf.cpp:1207:31: note: The comparison 'phone->get_active_line() == current' is always true because 'phone->get_active_line()' and 'current' represent the same value. 2.13.0 twinkle-1.10.2/src/util.cpp:516:8: warning: Either the condition 'i