2022-06-25 12:32 ftp://ftp.de.debian.org/debian/pool/main/t/teg/teg_0.12.0.orig.tar.gz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j2 platform: Linux-5.4.0-110-generic-x86_64-with-glibc2.29 python: 3.8.10 client-version: 1.3.24 compiler: g++ (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0 cppcheck: head 2.8 head-info: 63e567e (2022-06-25 08:38:17 +0200) count: 52 52 elapsed-time: 1.4 1.5 head-timing-info: Overall time: 0s old-timing-info: Overall time: 0s head results: teg-0.12.0/client/gui-gnome/callbacks.c:84:2: error: syntax error [syntaxError] teg-0.12.0/client/gui-gnome/armies.c:315:8: style: Variable 'item' is assigned a value that is never used. [unreadVariable] teg-0.12.0/client/gui-gnome/armies.c:330:9: style: Variable 'item' is assigned a value that is never used. [unreadVariable] teg-0.12.0/client/gui-gnome/connect.c:85:2: error: syntax error [syntaxError] teg-0.12.0/client/gui-gnome/g_scores.c:338:34: style:inconclusive: Function 'gui_scores_embed' argument 1 names different: declaration 'hbox' definition 'frame'. [funcArgNamesDifferent] teg-0.12.0/client/gui-gnome/g_scores.h:30:34: note: Function 'gui_scores_embed' argument 1 names different: declaration 'hbox' definition 'frame'. teg-0.12.0/client/gui-gnome/g_scores.c:338:34: note: Function 'gui_scores_embed' argument 1 names different: declaration 'hbox' definition 'frame'. teg-0.12.0/client/gui-gnome/g_scores.c:341:16: style: Local variable 'store' shadows outer variable [shadowVariable] teg-0.12.0/client/gui-gnome/g_scores.c:43:22: note: Shadowed declaration teg-0.12.0/client/gui-gnome/g_scores.c:341:16: note: Shadow variable teg-0.12.0/client/gui-gnome/g_country.c:445:87: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] teg-0.12.0/client/gui-gnome/g_country.c:459:6: style: Local variable 'x' shadows outer variable [shadowVariable] teg-0.12.0/client/gui-gnome/g_country.c:49:15: note: Shadowed declaration teg-0.12.0/client/gui-gnome/g_country.c:459:6: note: Shadow variable teg-0.12.0/client/gui-gnome/g_country.c:459:9: style: Local variable 'y' shadows outer variable [shadowVariable] teg-0.12.0/client/gui-gnome/g_country.c:49:18: note: Shadowed declaration teg-0.12.0/client/gui-gnome/g_country.c:459:9: note: Shadow variable teg-0.12.0/client/gui-gnome/mission.c:166:48: style:inconclusive: Function 'mission_view_fake_number' argument 1 names different: declaration 'dialog' definition 'frame'. [funcArgNamesDifferent] teg-0.12.0/client/gui-gnome/mission.h:27:48: note: Function 'mission_view_fake_number' argument 1 names different: declaration 'dialog' definition 'frame'. teg-0.12.0/client/gui-gnome/mission.c:166:48: note: Function 'mission_view_fake_number' argument 1 names different: declaration 'dialog' definition 'frame'. teg-0.12.0/client/gui-gnome/status.c:580:12: style: Local variable 'pJ' shadows outer variable [shadowVariable] teg-0.12.0/client/gui-gnome/status.c:529:11: note: Shadowed declaration teg-0.12.0/client/gui-gnome/status.c:580:12: note: Shadow variable teg-0.12.0/client/gui-gnome/status.c:689:8: style: Local variable 'buffer' shadows outer variable [shadowVariable] teg-0.12.0/client/gui-gnome/status.c:604:7: note: Shadowed declaration teg-0.12.0/client/gui-gnome/status.c:689:8: note: Shadow variable teg-0.12.0/client/gui-gnome/tegcanvasimage.c:295:21: style:inconclusive: Function 'teg_canvas_image_get_property' argument 2 names different: declaration 'param_id' definition 'prop_id'. [funcArgNamesDifferent] teg-0.12.0/client/gui-gnome/tegcanvasimage.c:45:21: note: Function 'teg_canvas_image_get_property' argument 2 names different: declaration 'param_id' definition 'prop_id'. teg-0.12.0/client/gui-gnome/tegcanvasimage.c:295:21: note: Function 'teg_canvas_image_get_property' argument 2 names different: declaration 'param_id' definition 'prop_id'. teg-0.12.0/client/gui-gnome/tegcanvasimage.c:363:23: style:inconclusive: Function 'teg_canvas_image_set_property' argument 2 names different: declaration 'param_id' definition 'prop_id'. [funcArgNamesDifferent] teg-0.12.0/client/gui-gnome/tegcanvasimage.c:49:23: note: Function 'teg_canvas_image_set_property' argument 2 names different: declaration 'param_id' definition 'prop_id'. teg-0.12.0/client/gui-gnome/tegcanvasimage.c:363:23: note: Function 'teg_canvas_image_set_property' argument 2 names different: declaration 'param_id' definition 'prop_id'. teg-0.12.0/client/gui-gnome/tegcanvasimage.c:628:21: style:inconclusive: Function 'teg_canvas_image_model_get_property' argument 2 names different: declaration 'param_id' definition 'prop_id'. [funcArgNamesDifferent] teg-0.12.0/client/gui-gnome/tegcanvasimage.c:539:21: note: Function 'teg_canvas_image_model_get_property' argument 2 names different: declaration 'param_id' definition 'prop_id'. teg-0.12.0/client/gui-gnome/tegcanvasimage.c:628:21: note: Function 'teg_canvas_image_model_get_property' argument 2 names different: declaration 'param_id' definition 'prop_id'. teg-0.12.0/client/gui-gnome/tegcanvasimage.c:640:23: style:inconclusive: Function 'teg_canvas_image_model_set_property' argument 2 names different: declaration 'param_id' definition 'prop_id'. [funcArgNamesDifferent] teg-0.12.0/client/gui-gnome/tegcanvasimage.c:543:23: note: Function 'teg_canvas_image_model_set_property' argument 2 names different: declaration 'param_id' definition 'prop_id'. teg-0.12.0/client/gui-gnome/tegcanvasimage.c:640:23: note: Function 'teg_canvas_image_model_set_property' argument 2 names different: declaration 'param_id' definition 'prop_id'. teg-0.12.0/client/inputfd.c:144:30: style:inconclusive: Function 'clitok_kick' argument 1 names different: declaration 'str' definition 'name'. [funcArgNamesDifferent] teg-0.12.0/client/inputfd.c:64:30: note: Function 'clitok_kick' argument 1 names different: declaration 'str' definition 'name'. teg-0.12.0/client/inputfd.c:144:30: note: Function 'clitok_kick' argument 1 names different: declaration 'str' definition 'name'. teg-0.12.0/client/outputfd.c:215:35: style:inconclusive: Function 'out_set_typeofgame' argument 1 names different: declaration 'a' definition 'conqworld'. [funcArgNamesDifferent] teg-0.12.0/client/outputfd.h:73:35: note: Function 'out_set_typeofgame' argument 1 names different: declaration 'a' definition 'conqworld'. teg-0.12.0/client/outputfd.c:215:35: note: Function 'out_set_typeofgame' argument 1 names different: declaration 'a' definition 'conqworld'. teg-0.12.0/client/outputfd.c:215:50: style:inconclusive: Function 'out_set_typeofgame' argument 2 names different: declaration 'b' definition 'fog_of_war'. [funcArgNamesDifferent] teg-0.12.0/client/outputfd.h:73:42: note: Function 'out_set_typeofgame' argument 2 names different: declaration 'b' definition 'fog_of_war'. teg-0.12.0/client/outputfd.c:215:50: note: Function 'out_set_typeofgame' argument 2 names different: declaration 'b' definition 'fog_of_war'. teg-0.12.0/client/outputfd.c:215:66: style:inconclusive: Function 'out_set_typeofgame' argument 3 names different: declaration 'c' definition 'with_common'. [funcArgNamesDifferent] teg-0.12.0/client/outputfd.h:73:49: note: Function 'out_set_typeofgame' argument 3 names different: declaration 'c' definition 'with_common'. teg-0.12.0/client/outputfd.c:215:66: note: Function 'out_set_typeofgame' argument 3 names different: declaration 'c' definition 'with_common'. teg-0.12.0/client/outputfd.c:215:83: style:inconclusive: Function 'out_set_typeofgame' argument 4 names different: declaration 'ar1' definition 'armies1'. [funcArgNamesDifferent] teg-0.12.0/client/outputfd.h:73:56: note: Function 'out_set_typeofgame' argument 4 names different: declaration 'ar1' definition 'armies1'. teg-0.12.0/client/outputfd.c:215:83: note: Function 'out_set_typeofgame' argument 4 names different: declaration 'ar1' definition 'armies1'. teg-0.12.0/client/outputfd.c:215:96: style:inconclusive: Function 'out_set_typeofgame' argument 5 names different: declaration 'ar2' definition 'armies2'. [funcArgNamesDifferent] teg-0.12.0/client/outputfd.h:73:65: note: Function 'out_set_typeofgame' argument 5 names different: declaration 'ar2' definition 'armies2'. teg-0.12.0/client/outputfd.c:215:96: note: Function 'out_set_typeofgame' argument 5 names different: declaration 'ar2' definition 'armies2'. teg-0.12.0/client/player.c:75:26: style:inconclusive: Function 'player_del' argument 1 names different: declaration 'j' definition 'pJ'. [funcArgNamesDifferent] teg-0.12.0/client/player.h:71:26: note: Function 'player_del' argument 1 names different: declaration 'j' definition 'pJ'. teg-0.12.0/client/player.c:75:26: note: Function 'player_del' argument 1 names different: declaration 'j' definition 'pJ'. teg-0.12.0/client/themes.c:786:14: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled] teg-0.12.0/client/themes.c:269:9: style: Local variable 'ret' shadows outer variable [shadowVariable] teg-0.12.0/client/themes.c:234:9: note: Shadowed declaration teg-0.12.0/client/themes.c:269:9: note: Shadow variable teg-0.12.0/common/cont.c:52:36: style:inconclusive: Function 'cont_get_name' argument 1 names different: declaration 'cont_number' definition 'i'. [funcArgNamesDifferent] teg-0.12.0/common/cont.h:74:36: note: Function 'cont_get_name' argument 1 names different: declaration 'cont_number' definition 'i'. teg-0.12.0/common/cont.c:52:36: note: Function 'cont_get_name' argument 1 names different: declaration 'cont_number' definition 'i'. teg-0.12.0/common/country.c:128:31: style:inconclusive: Function 'countries_get_name' argument 1 names different: declaration 'country' definition 'i'. [funcArgNamesDifferent] teg-0.12.0/common/country.h:71:31: note: Function 'countries_get_name' argument 1 names different: declaration 'country' definition 'i'. teg-0.12.0/common/country.c:128:31: note: Function 'countries_get_name' argument 1 names different: declaration 'country' definition 'i'. teg-0.12.0/common/net.c:51:2: error: syntax error [syntaxError] teg-0.12.0/common/parser.c:55:52: style:inconclusive: Function 'parser_character_class' argument 2 names different: declaration 'equals' definition 'igualador'. [funcArgNamesDifferent] teg-0.12.0/common/parser_private.h:38:52: note: Function 'parser_character_class' argument 2 names different: declaration 'equals' definition 'igualador'. teg-0.12.0/common/parser.c:55:52: note: Function 'parser_character_class' argument 2 names different: declaration 'equals' definition 'igualador'. teg-0.12.0/common/parser.c:56:52: style:inconclusive: Function 'parser_character_class' argument 3 names different: declaration 'separators' definition 'separador'. [funcArgNamesDifferent] teg-0.12.0/common/parser_private.h:39:52: note: Function 'parser_character_class' argument 3 names different: declaration 'separators' definition 'separador'. teg-0.12.0/common/parser.c:56:52: note: Function 'parser_character_class' argument 3 names different: declaration 'separators' definition 'separador'. teg-0.12.0/robot/ai_msg.c:170:41: style:inconclusive: Function 'ai_msg' argument 2 names different: declaration 'n' definition 'name'. [funcArgNamesDifferent] teg-0.12.0/robot/ai_msg.h:44:41: note: Function 'ai_msg' argument 2 names different: declaration 'n' definition 'name'. teg-0.12.0/robot/ai_msg.c:170:41: note: Function 'ai_msg' argument 2 names different: declaration 'n' definition 'name'. teg-0.12.0/server/console.c:111:2: warning: %u in format string (no. 3) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] teg-0.12.0/server/console.c:111:2: warning: %u in format string (no. 4) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] teg-0.12.0/server/console.c:111:2: warning: %u in format string (no. 5) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] teg-0.12.0/server/console.c:111:2: warning: %u in format string (no. 6) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] teg-0.12.0/server/console.c:330:16: style: Variable 'ts' is assigned a value that is never used. [unreadVariable] teg-0.12.0/server/fow.c:152:29: style:inconclusive: Function 'fow_2_netall_printf' argument 1 names different: declaration 'country1' definition 'src'. [funcArgNamesDifferent] teg-0.12.0/server/fow.h:43:29: note: Function 'fow_2_netall_printf' argument 1 names different: declaration 'country1' definition 'src'. teg-0.12.0/server/fow.c:152:29: note: Function 'fow_2_netall_printf' argument 1 names different: declaration 'country1' definition 'src'. teg-0.12.0/server/fow.c:152:38: style:inconclusive: Function 'fow_2_netall_printf' argument 2 names different: declaration 'country2' definition 'dst'. [funcArgNamesDifferent] teg-0.12.0/server/fow.h:43:43: note: Function 'fow_2_netall_printf' argument 2 names different: declaration 'country2' definition 'dst'. teg-0.12.0/server/fow.c:152:38: note: Function 'fow_2_netall_printf' argument 2 names different: declaration 'country2' definition 'dst'. teg-0.12.0/server/helper.c:331:4: error: syntax error [syntaxError] teg-0.12.0/server/main.c:262:14: error: syntax error [syntaxError] teg-0.12.0/server/player.c:63:47: style:inconclusive: Function 'player_whois' argument 2 names different: declaration 'j' definition 'pJ'. [funcArgNamesDifferent] teg-0.12.0/server/player.h:103:47: note: Function 'player_whois' argument 2 names different: declaration 'j' definition 'pJ'. teg-0.12.0/server/player.c:63:47: note: Function 'player_whois' argument 2 names different: declaration 'j' definition 'pJ'. teg-0.12.0/server/player.c:108:33: style:inconclusive: Function 'player_initplayer' argument 1 names different: declaration 'j' definition 'pJ'. [funcArgNamesDifferent] teg-0.12.0/server/player.h:76:33: note: Function 'player_initplayer' argument 1 names different: declaration 'j' definition 'pJ'. teg-0.12.0/server/player.c:108:33: note: Function 'player_initplayer' argument 1 names different: declaration 'j' definition 'pJ'. teg-0.12.0/server/player.c:169:30: style:inconclusive: Function 'player_ins' argument 1 names different: declaration 'j' definition 'pJ'. [funcArgNamesDifferent] teg-0.12.0/server/player.h:82:30: note: Function 'player_ins' argument 1 names different: declaration 'j' definition 'pJ'. teg-0.12.0/server/player.c:169:30: note: Function 'player_ins' argument 1 names different: declaration 'j' definition 'pJ'. teg-0.12.0/server/player.c:307:31: style:inconclusive: Function 'player_del_hard' argument 1 names different: declaration 'j' definition 'pJ'. [funcArgNamesDifferent] teg-0.12.0/server/player.h:91:31: note: Function 'player_del_hard' argument 1 names different: declaration 'j' definition 'pJ'. teg-0.12.0/server/player.c:307:31: note: Function 'player_del_hard' argument 1 names different: declaration 'j' definition 'pJ'. teg-0.12.0/server/player.c:414:61: style:inconclusive: Function 'player_esta_xxx_plus' argument 3 names different: declaration 'exact' definition 'strict'. [funcArgNamesDifferent] teg-0.12.0/server/player.h:124:61: note: Function 'player_esta_xxx_plus' argument 3 names different: declaration 'exact' definition 'strict'. teg-0.12.0/server/player.c:414:61: note: Function 'player_esta_xxx_plus' argument 3 names different: declaration 'exact' definition 'strict'. teg-0.12.0/server/player.c:468:33: style:inconclusive: Function 'player_clear_turn' argument 1 names different: declaration 'j' definition 'pJ'. [funcArgNamesDifferent] teg-0.12.0/server/player.h:133:33: note: Function 'player_clear_turn' argument 1 names different: declaration 'j' definition 'pJ'. teg-0.12.0/server/player.c:468:33: note: Function 'player_clear_turn' argument 1 names different: declaration 'j' definition 'pJ'. teg-0.12.0/server/play.c:250:44: style:inconclusive: Function 'token_turn' argument 2 names different: declaration 'str' definition 'unused'. [funcArgNamesDifferent] teg-0.12.0/server/play.c:70:44: note: Function 'token_turn' argument 2 names different: declaration 'str' definition 'unused'. teg-0.12.0/server/play.c:250:44: note: Function 'token_turn' argument 2 names different: declaration 'str' definition 'unused'. teg-0.12.0/server/play.c:729:9: style: Local variable 'buffer' shadows outer variable [shadowVariable] teg-0.12.0/server/play.c:575:7: note: Shadowed declaration teg-0.12.0/server/play.c:729:9: note: Shadow variable teg-0.12.0/server/player_check.cpp:77:26: style: Variable 'countries[2].next.Flink' is assigned a value that is never used. [unreadVariable] teg-0.12.0/server/turno.c:37:40: style:inconclusive: Function 'turno_2nextplayer' argument 1 names different: declaration 'j' definition 'ppJ'. [funcArgNamesDifferent] teg-0.12.0/server/turno.h:37:40: note: Function 'turno_2nextplayer' argument 1 names different: declaration 'j' definition 'ppJ'. teg-0.12.0/server/turno.c:37:40: note: Function 'turno_2nextplayer' argument 1 names different: declaration 'j' definition 'ppJ'. teg-0.12.0/server/xmlscores.c:210:6: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] teg-0.12.0/server/xmlscores.c:270:45: style:inconclusive: Function 'scores_dump' argument 2 names different: declaration 'buflen' definition 'len'. [funcArgNamesDifferent] teg-0.12.0/server/xmlscores.h:40:45: note: Function 'scores_dump' argument 2 names different: declaration 'buflen' definition 'len'. teg-0.12.0/server/xmlscores.c:270:45: note: Function 'scores_dump' argument 2 names different: declaration 'buflen' definition 'len'. diff: DONE