2025-11-16 23:14 ftp://ftp.de.debian.org/debian/pool/main/s/stiff/stiff_2.4.0.orig.tar.gz cppcheck-options: --library=posix --library=gnu --library=bsd --inconclusive --enable=style,information --inline-suppr --template=daca2 --disable=missingInclude --suppress=unmatchedSuppression --check-library --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=normalCheckLevelConditionExpressions -D__GNUC__ --platform=unix64 -j4 platform: Linux-6.12.48+deb13-amd64-x86_64-with-glibc2.41 python: 3.13.5 client-version: 1.3.67 compiler: g++ (Debian 14.2.0-19) 14.2.0 cppcheck: head 2.18.0 head-info: 2ad4620 (2025-11-14 19:45:56 +0100) count: 223 216 elapsed-time: 1.1 1.2 head-timing-info: old-timing-info: head results: stiff-2.4.0/src/datamem.c:106:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable O_RDWR [valueFlowBailoutIncompleteVar] stiff-2.4.0/src/field.c:76:3: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NORM [valueFlowBailoutIncompleteVar] stiff-2.4.0/src/field.c:171:3: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable QUIET [valueFlowBailoutIncompleteVar] stiff-2.4.0/src/datamem.c:158:7: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] stiff-2.4.0/src/datamem.c:109:11: warning: Either the condition '(fd=open(*swapname,O_RDWR|O_CREAT|O_TRUNC,0666))==-1' is redundant or lseek() argument nr 1 can have invalid value. The value is -1 but the valid values are '0:'. [invalidFunctionArg] stiff-2.4.0/src/datamem.c:106:60: note: Assuming that condition '(fd=open(*swapname,O_RDWR|O_CREAT|O_TRUNC,0666))==-1' is not redundant stiff-2.4.0/src/datamem.c:109:11: note: Invalid argument stiff-2.4.0/src/datamem.c:110:11: warning: Either the condition '(fd=open(*swapname,O_RDWR|O_CREAT|O_TRUNC,0666))==-1' is redundant or write() argument nr 1 can have invalid value. The value is -1 but the valid values are '0:'. [invalidFunctionArg] stiff-2.4.0/src/datamem.c:106:60: note: Assuming that condition '(fd=open(*swapname,O_RDWR|O_CREAT|O_TRUNC,0666))==-1' is not redundant stiff-2.4.0/src/datamem.c:110:11: note: Invalid argument stiff-2.4.0/src/datamem.c:112:11: warning: Either the condition '(fd=open(*swapname,O_RDWR|O_CREAT|O_TRUNC,0666))==-1' is redundant or close() argument nr 1 can have invalid value. The value is -1 but the valid values are '0:'. [invalidFunctionArg] stiff-2.4.0/src/datamem.c:106:60: note: Assuming that condition '(fd=open(*swapname,O_RDWR|O_CREAT|O_TRUNC,0666))==-1' is not redundant stiff-2.4.0/src/datamem.c:112:11: note: Invalid argument stiff-2.4.0/src/datamem.c:102:5: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/datamem.c:137:23: style:inconclusive: Function 'free_data' argument 1 names different: declaration 'pixbuf' definition 'data'. [funcArgNamesDifferent] stiff-2.4.0/src/datamem.h:31:30: note: Function 'free_data' argument 1 names different: declaration 'pixbuf' definition 'data'. stiff-2.4.0/src/datamem.c:137:23: note: Function 'free_data' argument 1 names different: declaration 'pixbuf' definition 'data'. stiff-2.4.0/src/datamem.c:221:27: style: Parameter 'dirname' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/field.c:159:14: style: Pointer expression 'extname' converted to bool is always true. [knownPointerToBool] stiff-2.4.0/src/field.c:151:16: style: Variable 'tab' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/field.c:151:22: style: Variable 'tabo' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/fits/fitscat.c:135:45: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] stiff-2.4.0/src/fits/fitscat.c:229:7: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] stiff-2.4.0/src/fits/fitscat.c:228:14: note: outer condition: tabin->headbuf stiff-2.4.0/src/fits/fitscat.c:229:7: note: identical inner condition: tabin->headbuf stiff-2.4.0/src/fits/fitscat.c:232:7: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] stiff-2.4.0/src/fits/fitscat.c:231:14: note: outer condition: tabin->bodybuf stiff-2.4.0/src/fits/fitscat.c:232:7: note: identical inner condition: tabin->bodybuf stiff-2.4.0/src/fits/fitscat.c:91:7: warning: %ld in format string (no. 1) requires 'long' but the argument type is 'unsigned long'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitscat.c:127:5: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitscat.c:224:5: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitscat.c:227:7: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitscat.c:229:7: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitscat.c:232:7: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitscat.c:281:3: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitscat.c:290:3: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitscat.c:323:3: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitscat.c:342:5: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitscat.c:380:3: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitscat.c:57:15: style: Variable 'tab' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/fits/fitscat.c:114:44: style: Parameter 'str' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/fits/fitscat.c:214:15: style: Variable 'tabin' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/fits/fitscat.c:138:29: error: Undefined behavior: Variable 'str2' is used as parameter and destination in sprintf(). [sprintfOverlappingData] stiff-2.4.0/src/fits/fitscleanup.c:159:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable signum [valueFlowBailoutIncompleteVar] stiff-2.4.0/src/fits/fitscleanup.c:196:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stiff-2.4.0/src/fits/fitscleanup.c:92:5: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitscleanup.c:96:5: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitscleanup.c:98:3: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitscleanup.c:136:11: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitscleanup.c:96:5: error: Common realloc mistake: 'cleanup_filename' nulled but not freed upon failure [memleakOnRealloc] stiff-2.4.0/src/fits/fitscleanup.c:87:32: style: Parameter 'filename' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/fits/fitscleanup.c:114:35: style: Parameter 'filename' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/fits/fitscheck.c:335:10: style: Condition 'sum' is always true [knownConditionTrueFalse] stiff-2.4.0/src/fits/fitscheck.c:333:9: note: Assignment 'sum=~sum', assigned value is greater than 0 stiff-2.4.0/src/fits/fitscheck.c:335:10: note: Condition 'sum' is always true stiff-2.4.0/src/fits/fitscheck.c:225:7: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitscheck.c:244:5: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitscheck.c:275:3: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitscheck.c:286:3: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitscheck.c:102:36: style: Parameter 'str' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/fits/fitscheck.c:106:20: style: Variable 'sbuf' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/fits/fitscheck.c:160:20: style: Variable 'sbuf' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/fits/fitsconv.c:98:7: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stdout [valueFlowBailoutIncompleteVar] stiff-2.4.0/src/fits/fitsconv.c:81:3: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitsconv.c:114:9: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitsconv.c:120:7: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitshead.c:178:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable COMPRESS_NONE [valueFlowBailoutIncompleteVar] stiff-2.4.0/src/fits/fitsbody.c:528:9: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitsbody.c:578:9: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitsbody.c:708:9: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitsbody.c:758:9: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitsbody.c:1086:30: style: Floating-point cast causes loss of precision. [suspiciousFloatingPointCast] stiff-2.4.0/src/fits/fitsbody.c:96:22: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] stiff-2.4.0/src/fits/fitsbody.c:99:17: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] stiff-2.4.0/src/fits/fitsbody.c:102:14: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] stiff-2.4.0/src/fits/fitsbody.c:145:12: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] stiff-2.4.0/src/fits/fitsbody.c:346:19: portability:inconclusive: Casting from double * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] stiff-2.4.0/src/fits/fitsbody.c:495:13: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] stiff-2.4.0/src/fits/fitsbody.c:505:13: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] stiff-2.4.0/src/fits/fitsbody.c:513:13: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] stiff-2.4.0/src/fits/fitsbody.c:830:15: portability:inconclusive: Casting from double * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] stiff-2.4.0/src/fits/fitsbody.c:921:31: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] stiff-2.4.0/src/fits/fitsbody.c:932:32: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] stiff-2.4.0/src/fits/fitsbody.c:1083:31: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] stiff-2.4.0/src/fits/fitsbody.c:1094:32: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] stiff-2.4.0/src/fits/fitsbody.c:815:42: style: Parameter 'ptr' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/fits/fitsbody.c:977:44: style: Parameter 'ptr' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/fits/fitsbody.c:1182:23: style: Parameter 'dirname' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/fits/fitsmisc.c:53:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stiff-2.4.0/src/fits/fitsmisc.c:88:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stiff-2.4.0/src/fits/fitsmisc.c:86:8: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] stiff-2.4.0/src/fits/fitsmisc.c:80:23: style: Parameter 'msg1' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/fits/fitsmisc.c:80:35: style: Parameter 'msg2' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/fits/fitsmisc.c:83:15: style: Variable 'tm' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/fits/fitsmisc.c:200:20: style: Parameter 'cs' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/fits/fitsmisc.c:200:30: style: Parameter 'ct' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/fits/fitsmisc.c:228:19: style: Parameter 'str' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/fits/fitsmisc.c:254:20: style: Parameter 'str' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/fits/fitsread.c:137:7: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitsread.c:151:3: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitshead.c:68:3: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitshead.c:86:5: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitshead.c:131:5: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitshead.c:236:5: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitshead.c:302:7: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitshead.c:586:5: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitshead.c:617:7: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitshead.c:752:5: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] stiff-2.4.0/src/fits/fitshead.c:419:21: style: Variable 'str2lim' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/fits/fitshead.c:825:11: style: Variable 'control' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/fits/fitshead.c:428:57: error: Uninitialized variable: &j [uninitvar] stiff-2.4.0/src/fits/fitsutil.c:561:28: error: Array 'str[81]' accessed at index 82, which is out of bounds. [arrayIndexOutOfBounds] stiff-2.4.0/src/fits/fitsutil.c:550:4: note: After for loop, i has value 80 stiff-2.4.0/src/fits/fitsutil.c:559:30: note: Compound assignment '+=', assigned value is 82 stiff-2.4.0/src/fits/fitsutil.c:561:28: note: Array index out of bounds stiff-2.4.0/src/fits/fitsutil.c:373:18: warning:inconclusive: Width 1 given in format string (no. 1) is smaller than destination buffer 's[4]'. [invalidScanfFormatWidth_smaller] stiff-2.4.0/src/fits/fitsutil.c:199:20: style:inconclusive: Function 'fitspick' argument 1 names different: declaration 'fitsbuf' definition 'fitsline'. [funcArgNamesDifferent] stiff-2.4.0/src/fits/fitscat.h:285:18: note: Function 'fitspick' argument 1 names different: declaration 'fitsbuf' definition 'fitsline'. stiff-2.4.0/src/fits/fitsutil.c:199:20: note: Function 'fitspick' argument 1 names different: declaration 'fitsbuf' definition 'fitsline'. stiff-2.4.0/src/fits/fitsutil.c:57:49: style: Parameter 'comment' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/fits/fitsutil.c:170:41: style: Parameter 'str' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/fits/fitsutil.c:203:10: style: Variable 'fptr' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/fits/fitsutil.c:345:16: style: Variable 'st2' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/fits/fitsutil.c:444:10: style: Variable 'cp1' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/fits/fitsutil.c:482:18: style: Variable 'cstr1' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/fits/fitstab.c:307:4: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] stiff-2.4.0/src/fits/fitstab.c:212:8: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] stiff-2.4.0/src/fits/fitstab.c:211:15: note: outer condition: tabin->headbuf stiff-2.4.0/src/fits/fitstab.c:212:8: note: identical inner condition: tabin->headbuf stiff-2.4.0/src/fits/fitstab.c:214:8: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] stiff-2.4.0/src/fits/fitstab.c:213:15: note: outer condition: tabin->bodybuf stiff-2.4.0/src/fits/fitstab.c:214:8: note: identical inner condition: tabin->bodybuf stiff-2.4.0/src/fits/fitstab.c:291:6: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] stiff-2.4.0/src/fits/fitstab.c:290:13: note: outer condition: tabin->headbuf stiff-2.4.0/src/fits/fitstab.c:291:6: note: identical inner condition: tabin->headbuf stiff-2.4.0/src/fits/fitstab.c:293:6: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] stiff-2.4.0/src/fits/fitstab.c:292:13: note: outer condition: tabin->bodybuf stiff-2.4.0/src/fits/fitstab.c:293:6: note: identical inner condition: tabin->bodybuf stiff-2.4.0/src/fits/fitstab.c:207:6: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitstab.c:210:8: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitstab.c:212:8: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitstab.c:214:8: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitstab.c:286:4: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitstab.c:289:6: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitstab.c:291:6: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitstab.c:293:6: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitstab.c:444:3: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitstab.c:448:3: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitstab.c:456:3: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitstab.c:706:3: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitstab.c:708:5: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitstab.c:57:15: style: Variable 'key' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/fits/fitstab.c:426:26: style: Parameter 'tabname' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/fits/fitstab.c:578:15: style: Variable 'keytab' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/fits/fitstab.c:635:46: style: Parameter 'tabname' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/fits/fitstab.c:701:15: style: Variable 'tab' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/fits/fitstab.c:307:10: style: Variable 'tabin' is assigned a value that is never used. [unreadVariable] stiff-2.4.0/src/main.c:65:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] stiff-2.4.0/src/image.c:142:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FLIP_X [valueFlowBailoutIncompleteVar] stiff-2.4.0/src/image.c:458:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FLIP_X [valueFlowBailoutIncompleteVar] stiff-2.4.0/src/image.c:1223:5: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NORM [valueFlowBailoutIncompleteVar] stiff-2.4.0/src/main.c:130:28: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] stiff-2.4.0/src/fits/fitswrite.c:115:5: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitswrite.c:133:9: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitswrite.c:192:9: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitswrite.c:295:3: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitswrite.c:418:59: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] stiff-2.4.0/src/fits/fitswrite.c:423:59: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] stiff-2.4.0/src/fits/fitswrite.c:504:59: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] stiff-2.4.0/src/fits/fitswrite.c:509:59: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] stiff-2.4.0/src/fits/fitswrite.c:379:3: style: Variable 'pos' is reassigned a value before the old one has been used. [redundantAssignment] stiff-2.4.0/src/fits/fitswrite.c:378:7: note: pos is assigned stiff-2.4.0/src/fits/fitswrite.c:379:3: note: pos is overwritten stiff-2.4.0/src/fits/fitswrite.c:451:34: style: Pointer expression 'printf' converted to bool is always true. [knownPointerToBool] stiff-2.4.0/src/fits/fitswrite.c:537:34: style: Pointer expression 'printf' converted to bool is always true. [knownPointerToBool] stiff-2.4.0/src/fits/fitswrite.c:103:40: style: Variable 'ptr' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/fits/fitswrite.c:256:17: style: Variable 'padbuf' can be declared as const array [constVariable] stiff-2.4.0/src/fits/fitswrite.c:324:18: style: Variable 'pin' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/makeit.c:79:3: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NORM [valueFlowBailoutIncompleteVar] stiff-2.4.0/src/makeit.c:73:8: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] stiff-2.4.0/src/makeit.c:184:8: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] stiff-2.4.0/src/makeit.c:219:9: style: Local variable 'error' shadows outer function [shadowFunction] stiff-2.4.0/src/fits/fitscat.h:221:3: note: Shadowed declaration stiff-2.4.0/src/makeit.c:219:9: note: Shadow variable stiff-2.4.0/src/makeit.c:59:16: style: Variable 'tm' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/makeit.c:64:5: style: Variable 'rfilename' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/makeit.c:217:24: style: Parameter 'msg1' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/makeit.c:217:36: style: Parameter 'msg2' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/makeit.c:245:9: style: Variable 'dummy' is assigned a value that is never used. [unreadVariable] stiff-2.4.0/src/prefs.c:511:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FORMAT_AUTO [valueFlowBailoutIncompleteVar] stiff-2.4.0/src/tiff.c:176:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TIFFTAG_IMAGEWIDTH [valueFlowBailoutIncompleteVar] stiff-2.4.0/src/image.c:826:16: portability: Casting between unsigned char * and float * which have an incompatible binary data representation. [invalidPointerCast] stiff-2.4.0/src/image.c:752:15: style: Variable 'datat' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/image.c:1113:30: style: Parameter 'fitshead' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/image.c:1203:11: style: Variable 'rfilename' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/image.c:1367:31: style: Variable 'amedian' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/image.c:147:10: style: int result is assigned to long variable. If the variable is long to avoid loss of information, then you have loss of information. [truncLongCastAssignment] stiff-2.4.0/src/image.c:87:19: style: Unused variable: extrapix [unusedVariable] stiff-2.4.0/src/image.c:401:12: style: Unused variable: i [unusedVariable] stiff-2.4.0/src/tiff.c:247:5: warning: Return value of function getlogin_r() is not used. [ignoredReturnValue] stiff-2.4.0/src/tiff.c:229:8: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] stiff-2.4.0/src/tiff.c:245:7: style: Condition '!psuser' is always true [knownConditionTrueFalse] stiff-2.4.0/src/tiff.c:236:0: note: Assignment 'psuser=NULL', assigned value is 0 stiff-2.4.0/src/tiff.c:245:7: note: Condition '!psuser' is always true stiff-2.4.0/src/tiff.c:252:7: style: Condition '!pshost' is always true [knownConditionTrueFalse] stiff-2.4.0/src/tiff.c:236:21: note: Assignment 'pshost=NULL', assigned value is 0 stiff-2.4.0/src/tiff.c:252:7: note: Condition '!pshost' is always true stiff-2.4.0/src/tiff.c:141:34: warning: Function 'create_tiffdir' argument order different: declaration 'image, width, height, bpp, nchan, tilesize, minvalue, maxvalue, compress_type, compress_quality, copyright, description' definition 'image, width, height, nchan, bpp, tilesize, minvalue, maxvalue, compress_type, compress_quality, copyright, description' [funcArgOrderDifferent] stiff-2.4.0/src/tiff.h:55:42: note: Function 'create_tiffdir' argument order different: declaration 'image, width, height, bpp, nchan, tilesize, minvalue, maxvalue, compress_type, compress_quality, copyright, description' definition 'image, width, height, nchan, bpp, tilesize, minvalue, maxvalue, compress_type, compress_quality, copyright, description' stiff-2.4.0/src/tiff.c:141:34: note: Function 'create_tiffdir' argument order different: declaration 'image, width, height, bpp, nchan, tilesize, minvalue, maxvalue, compress_type, compress_quality, copyright, description' definition 'image, width, height, nchan, bpp, tilesize, minvalue, maxvalue, compress_type, compress_quality, copyright, description' stiff-2.4.0/src/fits/fitskey.c:137:3: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitskey.c:141:5: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitskey.c:196:3: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitskey.c:251:3: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitskey.c:257:3: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitskey.c:335:5: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitskey.c:351:9: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitskey.c:367:7: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitskey.c:374:3: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitskey.c:525:3: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitskey.c:528:5: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitskey.c:658:3: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitskey.c:672:5: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitskey.c:786:3: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitskey.c:789:3: portability: %lld in format string (no. 1) requires 'long long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] stiff-2.4.0/src/fits/fitskey.c:890:5: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] stiff-2.4.0/src/fits/fitskey.c:910:5: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] stiff-2.4.0/src/fits/fitskey.c:124:15: style: Variable 'keyin' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/fits/fitskey.c:191:26: style: Parameter 'keyname' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/fits/fitskey.c:301:11: style: Variable 'mask2' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/fits/fitskey.c:494:46: style: Parameter 'keyname' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/fits/fitskey.c:521:15: style: Variable 'key' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/fits/fitskey.c:600:11: style: Variable 'mask2' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/fits/fitskey.c:618:23: style: Variable 'map' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/fits/fitskey.c:620:12: style: Variable 'skycathead' can be declared as const array [constVariable] stiff-2.4.0/src/fits/fitskey.c:629:16: style: Variable 'skycattail' can be declared as const array [constVariable] stiff-2.4.0/src/xml.c:133:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stdout [valueFlowBailoutIncompleteVar] stiff-2.4.0/src/xml.c:459:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stdout [valueFlowBailoutIncompleteVar] stiff-2.4.0/src/xml.c:240:5: warning: Return value of function getlogin_r() is not used. [ignoredReturnValue] stiff-2.4.0/src/xml.c:219:10: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] stiff-2.4.0/src/xml.c:238:7: style: Condition '!psuser' is always true [knownConditionTrueFalse] stiff-2.4.0/src/xml.c:228:19: note: Assignment 'psuser=pshost=pspath=NULL', assigned value is 0 stiff-2.4.0/src/xml.c:238:7: note: Condition '!psuser' is always true stiff-2.4.0/src/xml.c:164:15: style: Variable 'rfilename' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/xml.c:206:38: style: Parameter 'error' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/xml.c:208:16: style: Variable 'tm' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/xml.c:212:5: style: Variable 'pspath' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/xml.c:212:13: style: Variable 'psuser' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/xml.c:212:22: style: Variable 'pshost' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/xml.c:451:27: style: Parameter 'filename' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/xml.c:492:56: style: Parameter 'unit' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/xml.c:493:10: style: Parameter 'ucd' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/xml.c:493:21: style: Parameter 'format' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/prefs.c:193:25: warning: Either the condition '!value' is redundant or there is possible null pointer dereference: value. [nullPointerRedundantCheck] stiff-2.4.0/src/prefs.c:191:17: note: Assuming that condition '!value' is not redundant stiff-2.4.0/src/prefs.c:193:25: note: Null pointer dereference stiff-2.4.0/src/prefs.c:203:25: warning: Either the condition '!value' is redundant or there is possible null pointer dereference: value. [nullPointerRedundantCheck] stiff-2.4.0/src/prefs.c:201:17: note: Assuming that condition '!value' is not redundant stiff-2.4.0/src/prefs.c:203:25: note: Null pointer dereference stiff-2.4.0/src/prefs.c:213:43: warning: Either the condition '!value' is redundant or there is possible null pointer dereference: value. [nullPointerRedundantCheck] stiff-2.4.0/src/prefs.c:211:17: note: Assuming that condition '!value' is not redundant stiff-2.4.0/src/prefs.c:213:43: note: Null pointer dereference stiff-2.4.0/src/prefs.c:219:43: warning: Either the condition '!value' is redundant or there is possible null pointer dereference: value. [nullPointerRedundantCheck] stiff-2.4.0/src/prefs.c:217:17: note: Assuming that condition '!value' is not redundant stiff-2.4.0/src/prefs.c:219:43: note: Null pointer dereference stiff-2.4.0/src/prefs.c:543:18: style: Variable 'prefs.nmax_val' is reassigned a value before the old one has been used. [redundantAssignment] stiff-2.4.0/src/prefs.c:540:18: note: prefs.nmax_val is assigned stiff-2.4.0/src/prefs.c:543:18: note: prefs.nmax_val is overwritten stiff-2.4.0/src/prefs.c:353:30: style:inconclusive: Function 'findkeys' argument 2 names different: declaration 'key' definition 'keyw'. [funcArgNamesDifferent] stiff-2.4.0/src/key.h:54:30: note: Function 'findkeys' argument 2 names different: declaration 'key' definition 'keyw'. stiff-2.4.0/src/prefs.c:353:30: note: Function 'findkeys' argument 2 names different: declaration 'key' definition 'keyw'. stiff-2.4.0/src/prefs.c:82:19: style: Variable 'cp' can be declared as pointer to const [constVariablePointer] stiff-2.4.0/src/prefs.c:370:20: style: Parameter 'cs' can be declared as pointer to const [constParameterPointer] stiff-2.4.0/src/prefs.c:370:30: style: Parameter 'ct' can be declared as pointer to const [constParameterPointer] diff: head stiff-2.4.0/src/field.c:151:22: style: Variable 'tabo' can be declared as pointer to const [constVariablePointer] head stiff-2.4.0/src/fits/fitscat.c:214:15: style: Variable 'tabin' can be declared as pointer to const [constVariablePointer] head stiff-2.4.0/src/fits/fitscat.c:57:15: style: Variable 'tab' can be declared as pointer to const [constVariablePointer] head stiff-2.4.0/src/fits/fitskey.c:521:15: style: Variable 'key' can be declared as pointer to const [constVariablePointer] head stiff-2.4.0/src/fits/fitskey.c:618:23: style: Variable 'map' can be declared as pointer to const [constVariablePointer] head stiff-2.4.0/src/fits/fitstab.c:57:15: style: Variable 'key' can be declared as pointer to const [constVariablePointer] head stiff-2.4.0/src/fits/fitstab.c:701:15: style: Variable 'tab' can be declared as pointer to const [constVariablePointer] DONE