2024-03-25 19:04 ftp://ftp.de.debian.org/debian/pool/main/s/skycat/skycat_3.1.2+starlink1~b+dfsg.orig.tar.gz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --inline-suppr --disable=missingInclude --suppress=unmatchedSuppression --template=daca2 --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=valueFlowBailoutIncompleteVar -D__GNUC__ --platform=unix64 -j4 platform: Linux-6.1.0-0.deb11.6-amd64-x86_64-with-glibc2.31 python: 3.9.2 client-version: 1.3.45 compiler: g++ (Debian 10.2.1-6) 10.2.1 20210110 cppcheck: head 2.13.0 head-info: b967620 (2024-03-25 18:58:14 +0100) count: 1594 1571 elapsed-time: 2.5 3.5 head-timing-info: Tokenizer::simplifyTokens1::ValueFlow: 0.017702s (avg. 0.017702s - 1 result(s)) valueFlowCondition(SimpleConditionHandler{}, tokenlist, symboldatabase, errorLogger, settings, skippedFunctions): 0.006163s (avg. 0.00205433s - 3 result(s)) valueFlowAfterAssign(tokenlist, symboldatabase, errorLogger, settings, skippedFunctions): 0.003811s (avg. 0.00127033s - 3 result(s)) Tokenizer::simplifyTokens1::createSymbolDatabase: 0.003274s (avg. 0.003274s - 1 result(s)) valueFlowCondition(SymbolicConditionHandler{}, tokenlist, symboldatabase, errorLogger, settings, skippedFunctions): 0.002292s (avg. 0.000764s - 3 result(s)) Overall time: 0.028862s old-timing-info: Tokenizer::simplifyTokens1::ValueFlow: 0.070323s (avg. 0.070323s - 1 result(s)) valueFlowLifetime(tokenlist, errorLogger, settings): 0.020869s (avg. 0.0041738s - 5 result(s)) valueFlowCondition(SimpleConditionHandler{}, tokenlist, symboldatabase, errorLogger, settings, skippedFunctions): 0.014646s (avg. 0.0036615s - 4 result(s)) valueFlowAfterAssign(tokenlist, symboldatabase, errorLogger, settings, skippedFunctions): 0.014145s (avg. 0.00353625s - 4 result(s)) valueFlowForLoop(tokenlist, symboldatabase, errorLogger, settings): 0.005822s (avg. 0.0014555s - 4 result(s)) Overall time: 0.091058s head results: skycat-3.1.2-starlink-1b/astrotcl/generic/Astrotcl.C:41:32: error: There is an unknown macro here somewhere. Configuration is required. If PACKAGE_VERSION is a macro then please configure it. [unknownMacro] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageCoords.h:59:10: style:inconclusive: Technically the member function 'ImageCoords::print' can be const. [functionConst] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageCoords.C:49:19: note: Technically the member function 'ImageCoords::print' can be const. skycat-3.1.2-starlink-1b/astrotcl/generic/ImageCoords.h:59:10: note: Technically the member function 'ImageCoords::print' can be const. skycat-3.1.2-starlink-1b/astrotcl/generic/ImageCoords.h:62:10: style:inconclusive: Technically the member function 'ImageCoords::get' can be const. [functionConst] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageCoords.C:58:19: note: Technically the member function 'ImageCoords::get' can be const. skycat-3.1.2-starlink-1b/astrotcl/generic/ImageCoords.h:62:10: note: Technically the member function 'ImageCoords::get' can be const. skycat-3.1.2-starlink-1b/astrotcl/generic/ImageCoords.C:93:12: style: Local variable 'x' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageCoords.h:80:12: note: Shadowed declaration skycat-3.1.2-starlink-1b/astrotcl/generic/ImageCoords.C:93:12: note: Shadow variable skycat-3.1.2-starlink-1b/astrotcl/generic/ImageCoords.C:94:12: style: Local variable 'y' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageCoords.h:81:12: note: Shadowed declaration skycat-3.1.2-starlink-1b/astrotcl/generic/ImageCoords.C:94:12: note: Shadow variable skycat-3.1.2-starlink-1b/astrotcl/generic/ImageCoords.C:134:12: style: Local variable 'x' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageCoords.h:80:12: note: Shadowed declaration skycat-3.1.2-starlink-1b/astrotcl/generic/ImageCoords.C:134:12: note: Shadow variable skycat-3.1.2-starlink-1b/astrotcl/generic/ImageCoords.C:135:12: style: Local variable 'y' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageCoords.h:81:12: note: Shadowed declaration skycat-3.1.2-starlink-1b/astrotcl/generic/ImageCoords.C:135:12: note: Shadow variable skycat-3.1.2-starlink-1b/astrotcl/generic/ImageCoords.C:82:39: style: Parameter 'pos' can be declared as reference to const [constParameterReference] skycat-3.1.2-starlink-1b/astrotcl/generic/HMS.h:40:5: warning: Member variable 'HMS::sign_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/astrotcl/generic/HMS.h:42:5: style: Class 'HMS' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] skycat-3.1.2-starlink-1b/astrotcl/generic/HMS.h:43:5: style: Class 'HMS' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] skycat-3.1.2-starlink-1b/astrotcl/generic/HMS.C:97:12: style: Local variable 'hours' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/astrotcl/generic/HMS.h:52:9: note: Shadowed declaration skycat-3.1.2-starlink-1b/astrotcl/generic/HMS.C:97:12: note: Shadow variable skycat-3.1.2-starlink-1b/astrotcl/generic/HMS.C:98:9: style: Local variable 'min' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/astrotcl/generic/HMS.h:53:9: note: Shadowed declaration skycat-3.1.2-starlink-1b/astrotcl/generic/HMS.C:98:9: note: Shadow variable skycat-3.1.2-starlink-1b/astrotcl/generic/HMS.C:99:12: style: Local variable 'sec' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/astrotcl/generic/HMS.h:54:12: note: Shadowed declaration skycat-3.1.2-starlink-1b/astrotcl/generic/HMS.C:99:12: note: Shadow variable skycat-3.1.2-starlink-1b/astrotcl/generic/HMS.C:100:12: style: Local variable 'val' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/astrotcl/generic/HMS.h:55:12: note: Shadowed declaration skycat-3.1.2-starlink-1b/astrotcl/generic/HMS.C:100:12: note: Shadow variable skycat-3.1.2-starlink-1b/astrotcl/generic/DCompress.h:42:9: performance:inconclusive: Technically the member function 'Compress::compress' can be static (but you may consider moving to unnamed namespace). [functionStatic] skycat-3.1.2-starlink-1b/astrotcl/generic/DCompress.C:55:15: note: Technically the member function 'Compress::compress' can be static (but you may consider moving to unnamed namespace). skycat-3.1.2-starlink-1b/astrotcl/generic/DCompress.h:42:9: note: Technically the member function 'Compress::compress' can be static (but you may consider moving to unnamed namespace). skycat-3.1.2-starlink-1b/astrotcl/generic/DCompress.h:52:9: performance:inconclusive: Technically the member function 'Compress::compress' can be static (but you may consider moving to unnamed namespace). [functionStatic] skycat-3.1.2-starlink-1b/astrotcl/generic/DCompress.C:91:15: note: Technically the member function 'Compress::compress' can be static (but you may consider moving to unnamed namespace). skycat-3.1.2-starlink-1b/astrotcl/generic/DCompress.h:52:9: note: Technically the member function 'Compress::compress' can be static (but you may consider moving to unnamed namespace). skycat-3.1.2-starlink-1b/astrotcl/generic/DCompress.h:73:9: performance:inconclusive: Technically the member function 'Compress::compress' can be static (but you may consider moving to unnamed namespace). [functionStatic] skycat-3.1.2-starlink-1b/astrotcl/generic/DCompress.C:192:15: note: Technically the member function 'Compress::compress' can be static (but you may consider moving to unnamed namespace). skycat-3.1.2-starlink-1b/astrotcl/generic/DCompress.h:73:9: note: Technically the member function 'Compress::compress' can be static (but you may consider moving to unnamed namespace). skycat-3.1.2-starlink-1b/astrotcl/generic/DCompress.C:119:25: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/DCompress.C:123:27: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/DCompress.C:201:15: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/DCompress.C:202:17: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/DCompress.C:55:64: style:inconclusive: Function 'compress' argument 3 names different: declaration 'type' definition 'ctype'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/astrotcl/generic/DCompress.h:42:58: note: Function 'compress' argument 3 names different: declaration 'type' definition 'ctype'. skycat-3.1.2-starlink-1b/astrotcl/generic/DCompress.C:55:64: note: Function 'compress' argument 3 names different: declaration 'type' definition 'ctype'. skycat-3.1.2-starlink-1b/astrotcl/generic/DCompress.C:91:78: style:inconclusive: Function 'compress' argument 3 names different: declaration 'type' definition 'ctype'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/astrotcl/generic/DCompress.h:52:72: note: Function 'compress' argument 3 names different: declaration 'type' definition 'ctype'. skycat-3.1.2-starlink-1b/astrotcl/generic/DCompress.C:91:78: note: Function 'compress' argument 3 names different: declaration 'type' definition 'ctype'. skycat-3.1.2-starlink-1b/astrotcl/generic/DCompress.C:160:55: style:inconclusive: Function 'compress' argument 2 names different: declaration 'type' definition 'ctype'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/astrotcl/generic/DCompress.h:63:49: note: Function 'compress' argument 2 names different: declaration 'type' definition 'ctype'. skycat-3.1.2-starlink-1b/astrotcl/generic/DCompress.C:160:55: note: Function 'compress' argument 2 names different: declaration 'type' definition 'ctype'. skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.C:71:19: warning: 'operator=' should check for assignment to self to avoid problems with dynamic memory. [operatorEqToSelf] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:143:5: style: Class 'WCS' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.h:199:5: style: Class 'ImageIO' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.h:278:57: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.C:134:25: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.C:135:23: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.C:144:29: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.C:145:27: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.C:153:40: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.C:154:38: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.C:127:9: style: Local variable 'data' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.h:149:10: note: Shadowed declaration skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.C:127:9: note: Shadow variable skycat-3.1.2-starlink-1b/astrotcl/generic/TclWorldCoords.C:71:38: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:61:14: style: The destructor '~SAOWCS' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:42:14: note: Virtual destructor in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:61:14: note: Destructor in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:64:25: style: The function 'classname' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:45:25: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:64:25: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:67:9: style: The function 'isWcs' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:48:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:67:9: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:70:11: style: The function 'pix2wcs' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:51:19: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:70:11: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:73:9: style: The function 'pix2wcs' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:54:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:73:9: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:76:9: style: The function 'wcs2pix' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:57:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:76:9: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:79:9: style: The function 'wcs2pixDist' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:60:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:79:9: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:82:9: style: The function 'pix2wcsDist' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:63:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:82:9: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:85:9: style: The function 'set' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:66:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:85:9: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:94:9: style: The function 'shift' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:78:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:94:9: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:97:9: style: The function 'deltset' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:75:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:97:9: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:100:12: style: The function 'equinox' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:81:20: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:100:12: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:101:17: style: The function 'equinoxStr' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:84:25: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:101:17: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:104:12: style: The function 'epoch' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:87:20: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:104:12: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:107:12: style: The function 'rotate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:90:20: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:107:12: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:110:12: style: The function 'width' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:93:20: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:110:12: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:111:12: style: The function 'height' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:94:20: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:111:12: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:112:12: style: The function 'radius' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:95:20: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:112:12: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:115:12: style: The function 'secPix' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:98:20: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:115:12: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:116:12: style: The function 'xSecPix' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:99:20: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:116:12: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:117:12: style: The function 'ySecPix' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:100:20: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:117:12: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:120:17: style: The function 'center' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:103:25: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:120:17: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:123:9: style: The function 'pixWidth' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:106:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:123:9: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:124:9: style: The function 'pixHeight' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:107:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:124:9: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:127:12: style: The function 'dist' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:110:20: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:127:12: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:132:12: style: The function 'xRefPix' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:113:20: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:132:12: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:133:12: style: The function 'yRefPix' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:114:20: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:133:12: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:136:17: style: The function 'projection' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:117:25: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:136:17: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.C:50:10: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.C:234:12: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.C:236:12: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.C:294:31: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.C:69:11: warning: 'operator=' should check for assignment to self to avoid problems with dynamic memory. [operatorEqToSelf] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:34:9: style:inconclusive: Member variable 'WCSRep::refcnt_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.C:32:7: note: Member variable 'WCSRep::refcnt_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:34:9: note: Member variable 'WCSRep::refcnt_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/astrotcl/generic/slasubs.c:52:9: style: Parameter 'v' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/astrotcl/generic/cotr.c:60:9: style: Parameter 'Euler_angles' can be declared as const array [constParameter] skycat-3.1.2-starlink-1b/astrotcl/generic/cotr.c:137:9: style: Parameter 'o' can be declared as const array [constParameter] skycat-3.1.2-starlink-1b/astrotcl/generic/cotr.c:158:9: style: Parameter 'o' can be declared as const array [constParameter] skycat-3.1.2-starlink-1b/astrotcl/generic/cotr.c:177:9: style: Parameter 'u' can be declared as const array [constParameter] skycat-3.1.2-starlink-1b/astrotcl/generic/cotr.c:213:9: style: Parameter 'u' can be declared as const array [constParameter] skycat-3.1.2-starlink-1b/astrotcl/generic/cotr.c:239:9: style: Parameter 'u1' can be declared as const array [constParameter] skycat-3.1.2-starlink-1b/astrotcl/generic/cotr.c:266:9: style: Parameter 'u1' can be declared as const array [constParameter] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:31:9: style:inconclusive: Member variable 'WorldCoords::ra_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:218:19: note: Member variable 'WorldCoords::ra_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:31:9: note: Member variable 'WorldCoords::ra_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:31:14: style:inconclusive: Member variable 'WorldCoords::dec_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:238:19: note: Member variable 'WorldCoords::dec_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:31:14: note: Member variable 'WorldCoords::dec_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:241:5: performance: Variable 'ra_' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:93:10: style:inconclusive: Technically the member function 'WorldCoords::print' can be const. [functionConst] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:270:19: note: Technically the member function 'WorldCoords::print' can be const. skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:93:10: note: Technically the member function 'WorldCoords::print' can be const. skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:100:10: style:inconclusive: Technically the member function 'WorldCoords::print' can be const. [functionConst] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:329:19: note: Technically the member function 'WorldCoords::print' can be const. skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:100:10: note: Technically the member function 'WorldCoords::print' can be const. skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:106:10: style:inconclusive: Technically the member function 'WorldCoords::get' can be const. [functionConst] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:365:19: note: Technically the member function 'WorldCoords::get' can be const. skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:106:10: note: Technically the member function 'WorldCoords::get' can be const. skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:44:17: style: Virtual function 'checkRange' is called from constructor 'WorldCoords(const HMS&ra,const HMS&dec,double equinox=2000.0)' at line 139. Dynamic binding is not used. [virtualCallInConstructor] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:139:15: note: Calling checkRange skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:44:17: note: checkRange is a virtual function skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:44:17: style: Virtual function 'checkRange' is called from constructor 'WorldCoords(double ra,double dec,double equinox=2000.0)' at line 162. Dynamic binding is not used. [virtualCallInConstructor] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:162:16: note: Calling checkRange skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:44:17: note: checkRange is a virtual function skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:44:17: style: Virtual function 'checkRange' is called from constructor 'WorldCoords(double rh,int rm,double rs,double dd,int dm,double ds,double equinox=2000.0)' at line 186. Dynamic binding is not used. [virtualCallInConstructor] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:186:15: note: Calling checkRange skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:44:17: note: checkRange is a virtual function skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:44:17: style: Virtual function 'checkRange' is called from constructor 'WorldCoords(const char*ra,const char*dec,double equinox=2000.0,int hflag=0)' at line 230. Dynamic binding is not used. [virtualCallInConstructor] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:230:15: note: Calling checkRange skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:44:17: note: checkRange is a virtual function skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:44:17: style: Virtual function 'checkRange' is called from constructor 'WorldCoords(const char*ra,const char*dec,const char*equinoxStr,int hflag=0)' at line 256. Dynamic binding is not used. [virtualCallInConstructor] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:256:12: note: Calling checkRange skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:44:17: note: checkRange is a virtual function skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:112:24: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:115:24: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/world_coords.C:100:37: style: Parameter 'ra' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/astrotcl/generic/world_coords.C:100:47: style: Parameter 'dec' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/astrotcl/generic/world_coords.C:109:18: style: Parameter 'wc' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:440:37: style: The scope of the variable 'sind' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:440:42: style: The scope of the variable 'sinpa' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:440:48: style: The scope of the variable 'cospa' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:529:12: style: The scope of the variable 'ra' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:535:12: style: The scope of the variable 'cosdec' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:103:45: style:inconclusive: Function 'convertEquinox' argument 1 names different: declaration 'from_equinox' definition 'fromEquinoxStr'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:41:36: note: Function 'convertEquinox' argument 1 names different: declaration 'from_equinox' definition 'fromEquinoxStr'. skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:103:45: note: Function 'convertEquinox' argument 1 names different: declaration 'from_equinox' definition 'fromEquinoxStr'. skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:103:73: style:inconclusive: Function 'convertEquinox' argument 2 names different: declaration 'to_equinox' definition 'toEquinoxStr'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:41:62: note: Function 'convertEquinox' argument 2 names different: declaration 'to_equinox' definition 'toEquinoxStr'. skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:103:73: note: Function 'convertEquinox' argument 2 names different: declaration 'to_equinox' definition 'toEquinoxStr'. skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:217:38: style:inconclusive: Function 'WorldCoords' argument 1 names different: declaration 'ra' definition 'ra_str'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:72:29: note: Function 'WorldCoords' argument 1 names different: declaration 'ra' definition 'ra_str'. skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:217:38: note: Function 'WorldCoords' argument 1 names different: declaration 'ra' definition 'ra_str'. skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:217:58: style:inconclusive: Function 'WorldCoords' argument 2 names different: declaration 'dec' definition 'dec_str'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:72:45: note: Function 'WorldCoords' argument 2 names different: declaration 'dec' definition 'dec_str'. skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:217:58: note: Function 'WorldCoords' argument 2 names different: declaration 'dec' definition 'dec_str'. skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:237:38: style:inconclusive: Function 'WorldCoords' argument 1 names different: declaration 'ra' definition 'ra_str'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:76:29: note: Function 'WorldCoords' argument 1 names different: declaration 'ra' definition 'ra_str'. skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:237:38: note: Function 'WorldCoords' argument 1 names different: declaration 'ra' definition 'ra_str'. skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:237:58: style:inconclusive: Function 'WorldCoords' argument 2 names different: declaration 'dec' definition 'dec_str'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:76:45: note: Function 'WorldCoords' argument 2 names different: declaration 'dec' definition 'dec_str'. skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:237:58: note: Function 'WorldCoords' argument 2 names different: declaration 'dec' definition 'dec_str'. skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:39:12: style: Local variable 'ra' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:149:16: note: Shadowed declaration skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:39:12: note: Shadow variable skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:39:28: style: Local variable 'dec' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:150:16: note: Shadowed declaration skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:39:28: note: Shadow variable skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:529:12: style: Local variable 'ra' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:149:16: note: Shadowed declaration skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:529:12: note: Shadow variable skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:529:28: style: Local variable 'dec' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:150:16: note: Shadowed declaration skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:529:28: note: Shadow variable skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:589:12: style: Local variable 'ra' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:149:16: note: Shadowed declaration skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:589:12: note: Shadow variable skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:590:12: style: Local variable 'dec' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.h:150:16: note: Shadowed declaration skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:590:12: note: Shadow variable skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:477:39: style: Parameter 'pos' can be declared as reference to const [constParameterReference] skycat-3.1.2-starlink-1b/astrotcl/generic/WorldCoords.C:489:39: style: Parameter 'pos' can be declared as reference to const [constParameterReference] skycat-3.1.2-starlink-1b/astrotcl/press/gzip_util.c:108:7: style: Variable 's' is assigned a value that is never used. [unreadVariable] skycat-3.1.2-starlink-1b/astrotcl/press/gzip.c:132:21: style: Obsolescent function 'vfork' called. It is recommended to use 'fork' instead. [prohibitedvforkCalled] skycat-3.1.2-starlink-1b/astrotcl/press/gzip.c:340:14: style: Variable 'orig_crc' is assigned a value that is never used. [unreadVariable] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1015:52: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:131:5: performance: Variable 'primaryHeader_' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:124:6: style: The destructor '~FitsIO' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.h:98:14: note: Virtual destructor in base class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:124:6: note: Destructor in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:127:21: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.h:175:25: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:127:21: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:130:9: style: The function 'wcsinit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.h:103:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:130:9: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:133:17: style: The function 'classname' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.h:110:25: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:133:17: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:140:9: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.h:129:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:140:9: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:167:9: style: The function 'get' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.h:113:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:167:9: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:168:9: style: The function 'get' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.h:114:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:168:9: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:169:9: style: The function 'get' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.h:115:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:169:9: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:170:9: style: The function 'get' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.h:116:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:170:9: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:171:9: style: The function 'get' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.h:117:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:171:9: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:172:9: style: The function 'get' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.h:118:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:172:9: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:173:9: style: The function 'get' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.h:119:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:173:9: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:174:9: style: The function 'get' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.h:120:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:174:9: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:177:11: style: The function 'get' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.h:123:19: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:177:11: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:198:9: style: The function 'getFitsHeader' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.h:126:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:198:9: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:227:17: style: The function 'setHDU' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.h:178:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:227:17: note: Function in derived class skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:177:14: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:178:7: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:181:15: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:182:7: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:185:7: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:187:29: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:191:28: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:333:37: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:345:16: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:389:23: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:501:20: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:616:21: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:622:25: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:770:15: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:783:31: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:798:28: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:799:28: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:807:30: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:812:31: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:820:13: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:981:24: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:989:15: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1041:12: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1046:23: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1069:12: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1119:32: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1120:32: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1128:27: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1129:27: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1136:28: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1137:28: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1156:14: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1242:42: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1256:40: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1270:43: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1307:41: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1317:40: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1327:38: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1337:39: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1347:43: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1357:39: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1367:40: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1377:41: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1394:41: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1413:41: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1443:40: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1453:39: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1463:37: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1473:38: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1483:38: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1493:40: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1503:39: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1520:40: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1745:54: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1864:17: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1872:43: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1907:55: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1958:56: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:275:13: style: The scope of the variable 'count' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:365:48: style:inconclusive: Function 'read' argument 2 names different: declaration 'memOptions' definition 'mem_options'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:137:51: note: Function 'read' argument 2 names different: declaration 'memOptions' definition 'mem_options'. skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:365:48: note: Function 'read' argument 2 names different: declaration 'memOptions' definition 'mem_options'. skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:719:33: style: Parameter 'header' can be declared as reference to const [constParameterReference] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:719:46: style: Parameter 'data' can be declared as reference to const [constParameterReference] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:831:65: style: Parameter 'value' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1427:11: style: Variable 's' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:520:24: style: Variable 'ii' is assigned a value that is never used. [unreadVariable] skycat-3.1.2-starlink-1b/astrotcl/generic/FitsIO.C:1957:7: style: Unused variable: c [unusedVariable] skycat-3.1.2-starlink-1b/astrotcl/press/h_decomp.c:1008:6: warning:inconclusive: Found suspicious operator '*', result is not used. [constStatement] skycat-3.1.2-starlink-1b/astrotcl/press/h_decomp.c:853:11: style: Parameter 'datatype' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/astrotcl/press/h_decomp.c:1008:13: warning: In expression like '*A++' the result of '*' is unused. Did you intend to write '(*A)++;'? [clarifyStatement] skycat-3.1.2-starlink-1b/astrotcl/press/h_press.c:1187:5: error: Memory leak: scratch [memleak] skycat-3.1.2-starlink-1b/astrotcl/press/h_press.c:112:34: style: Parameter 'i' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/astrotcl/press/h_press.c:764:11: style: Parameter 'format' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/astrotcl/press/h_press.c:1332:10: style: Parameter 'a' can be declared as const array [constParameter] skycat-3.1.2-starlink-1b/astrotcl/press/h_press.c:1407:8: style: Variable 'k' is assigned a value that is never used. [unreadVariable] skycat-3.1.2-starlink-1b/astrotcl/press/h_press.c:1502:8: style: Variable 'k' is assigned a value that is never used. [unreadVariable] skycat-3.1.2-starlink-1b/astrotcl/press/hcomp.c:88:12: style: Parameter 'format' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/astrotcl/press/hcomp.c:148:10: style: Parameter 'a' can be declared as const array [constParameter] skycat-3.1.2-starlink-1b/astrotcl/press/gzip_inflate.c:307:8: style: Parameter 'd' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/astrotcl/press/gzip_inflate.c:309:8: style: Parameter 'e' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/astrotcl/press/hinv.c:193:8: style: Variable 'bit2' is assigned a value that is never used. [unreadVariable] skycat-3.1.2-starlink-1b/astrotcl/press/htrans.c:43:15: portability: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS] skycat-3.1.2-starlink-1b/astrotcl/press/htrans.c:89:9: style: Variable 's00' is assigned a value that is never used. [unreadVariable] skycat-3.1.2-starlink-1b/astrotcl/press/htrans.c:90:9: style: Variable 's10' is assigned a value that is never used. [unreadVariable] skycat-3.1.2-starlink-1b/astrotcl/press/local_press.c:149:11: style: Parameter 'buffer' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/astrotcl/press/local_press.c:222:11: style: Parameter 'buffer' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/astrotcl/press/msg.c:81:11: style: Variable 'm1' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/astrotcl/press/msg.c:82:11: style: Variable 'm2' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/astrotcl/press/msg.c:113:7: style: Parameter 'msg2' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/astrotcl/press/msg.c:184:7: style: Parameter 'msgs' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/astrotcl/press/msg.c:224:12: style: Parameter 'prefix' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/astrotcl/press/msg.c:233:11: style: Variable 'errno_arg' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/astrotcl/press/msg.c:234:11: style: Variable 'format' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/astrotcl/press/msg.c:323:1: error: va_list 'args' was opened but not closed by va_end(). [va_end_missing] skycat-3.1.2-starlink-1b/astrotcl/press/press.c:301:45: error: va_list 'args' used before va_start() was called. [va_list_usedBeforeStarted] skycat-3.1.2-starlink-1b/astrotcl/press/press.c:302:34: error: va_list 'args' used before va_start() was called. [va_list_usedBeforeStarted] skycat-3.1.2-starlink-1b/astrotcl/press/press.c:303:33: error: va_list 'args' used before va_start() was called. [va_list_usedBeforeStarted] skycat-3.1.2-starlink-1b/astrotcl/press/press.c:304:34: error: va_list 'args' used before va_start() was called. [va_list_usedBeforeStarted] skycat-3.1.2-starlink-1b/astrotcl/press/press.c:305:30: error: va_list 'args' used before va_start() was called. [va_list_usedBeforeStarted] skycat-3.1.2-starlink-1b/astrotcl/press/press.c:306:30: error: va_list 'args' used before va_start() was called. [va_list_usedBeforeStarted] skycat-3.1.2-starlink-1b/astrotcl/press/press.c:307:2: error: va_list 'args' used before va_start() was called. [va_list_usedBeforeStarted] skycat-3.1.2-starlink-1b/astrotcl/press/press.c:311:45: error: va_list 'args' used before va_start() was called. [va_list_usedBeforeStarted] skycat-3.1.2-starlink-1b/astrotcl/press/press.c:312:33: error: va_list 'args' used before va_start() was called. [va_list_usedBeforeStarted] skycat-3.1.2-starlink-1b/astrotcl/press/press.c:313:2: error: va_list 'args' used before va_start() was called. [va_list_usedBeforeStarted] skycat-3.1.2-starlink-1b/astrotcl/press/press.c:318:35: error: va_list 'args' used before va_start() was called. [va_list_usedBeforeStarted] skycat-3.1.2-starlink-1b/astrotcl/press/press.c:319:2: error: va_list 'args' used before va_start() was called. [va_list_usedBeforeStarted] skycat-3.1.2-starlink-1b/astrotcl/press/press.c:323:2: error: va_list 'args' used before va_start() was called. [va_list_usedBeforeStarted] skycat-3.1.2-starlink-1b/astrotcl/tests/tCompress.C:31:1: error: syntax error [syntaxError] skycat-3.1.2-starlink-1b/astrotcl/press/ulda.c:95:18: style: Variable 'fmt1' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/astrotcl/press/ulda.c:96:18: style: Variable 'fmt2' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/astrotcl/press/ulda.c:97:18: style: Variable 'fmt3' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/astrotcl/press/ulda.c:98:18: style: Variable 'fmt4' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/astrotcl/press/ulda.c:99:18: style: Variable 'fmt5' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/astrotcl/press/ulda.c:40:10: style: struct member 'ulda_header::uh_recno' is never used. [unusedStructMember] skycat-3.1.2-starlink-1b/astrotcl/press/ulda.c:57:17: style: struct member 'ulda_header::uh_usage' is never used. [unusedStructMember] skycat-3.1.2-starlink-1b/astrotcl/tests/tFitsIO.C:21:1: error: syntax error [syntaxError] skycat-3.1.2-starlink-1b/astrotcl/tests/tHMS.C:21:1: error: syntax error [syntaxError] skycat-3.1.2-starlink-1b/astrotcl/tests/tImageCoords.C:20:1: error: syntax error [syntaxError] skycat-3.1.2-starlink-1b/astrotcl/tests/tWorldCoords.C:20:1: error: syntax error [syntaxError] skycat-3.1.2-starlink-1b/astrotcl/tests/tWorldOrImageCoords.C:27:1: error: syntax error [syntaxError] skycat-3.1.2-starlink-1b/astrotcl/press/ux_press.c:501:20: style: Condition 'block_compress' is always true [knownConditionTrueFalse] skycat-3.1.2-starlink-1b/astrotcl/press/ux_press.c:487:22: note: Assignment 'block_compress=0x80', assigned value is 128 skycat-3.1.2-starlink-1b/astrotcl/press/ux_press.c:489:5: note: Assuming condition is false skycat-3.1.2-starlink-1b/astrotcl/press/ux_press.c:501:20: note: Condition 'block_compress' is always true skycat-3.1.2-starlink-1b/astrotcl/press/ux_press.c:211:16: style: Local variable 'offset' shadows outer variable [shadowVariable] skycat-3.1.2-starlink-1b/astrotcl/press/ux_press.c:66:13: note: Shadowed declaration skycat-3.1.2-starlink-1b/astrotcl/press/ux_press.c:211:16: note: Shadow variable skycat-3.1.2-starlink-1b/astrotcl/press/ux_press.c:318:10: style: Local variable 'r_off' shadows outer variable [shadowVariable] skycat-3.1.2-starlink-1b/astrotcl/press/ux_press.c:68:14: note: Shadowed declaration skycat-3.1.2-starlink-1b/astrotcl/press/ux_press.c:318:10: note: Shadow variable skycat-3.1.2-starlink-1b/astrotcl/press/ux_press.c:373:11: style: Variable 'bits' is assigned a value that is never used. [unreadVariable] skycat-3.1.2-starlink-1b/astrotcl/press/ux_press.c:476:16: style: Variable 'i' is assigned a value that is never used. [unreadVariable] skycat-3.1.2-starlink-1b/cat/generic/AstroQuery.C:54:13: warning: Member variable 'AstroQuery::sortOrder_' is not initialized in the copy constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/cat/generic/AstroQuery.C:29:13: warning: Member variable 'AstroQuery::sortOrder_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/cat/generic/AstroQuery.C:196:30: style:inconclusive: Function 'colNames' argument 1 names different: declaration 'n' definition 'numCols'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/cat/generic/AstroQuery.h:102:22: note: Function 'colNames' argument 1 names different: declaration 'n' definition 'numCols'. skycat-3.1.2-starlink-1b/cat/generic/AstroQuery.C:196:30: note: Function 'colNames' argument 1 names different: declaration 'n' definition 'numCols'. skycat-3.1.2-starlink-1b/cat/generic/AstroQuery.C:196:46: style:inconclusive: Function 'colNames' argument 2 names different: declaration 'ar' definition 'colNames'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/cat/generic/AstroQuery.h:102:32: note: Function 'colNames' argument 2 names different: declaration 'ar' definition 'colNames'. skycat-3.1.2-starlink-1b/cat/generic/AstroQuery.C:196:46: note: Function 'colNames' argument 2 names different: declaration 'ar' definition 'colNames'. skycat-3.1.2-starlink-1b/cat/generic/AstroQuery.C:242:31: style:inconclusive: Function 'condition' argument 1 names different: declaration 'numSearchCols' definition 'n'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/cat/generic/AstroQuery.h:118:23: note: Function 'condition' argument 1 names different: declaration 'numSearchCols' definition 'n'. skycat-3.1.2-starlink-1b/cat/generic/AstroQuery.C:242:31: note: Function 'condition' argument 1 names different: declaration 'numSearchCols' definition 'n'. skycat-3.1.2-starlink-1b/cat/generic/AstroQuery.C:242:41: style:inconclusive: Function 'condition' argument 2 names different: declaration 'searchCols' definition 'cols'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/cat/generic/AstroQuery.h:118:45: note: Function 'condition' argument 2 names different: declaration 'searchCols' definition 'cols'. skycat-3.1.2-starlink-1b/cat/generic/AstroQuery.C:242:41: note: Function 'condition' argument 2 names different: declaration 'searchCols' definition 'cols'. skycat-3.1.2-starlink-1b/cat/generic/AstroQuery.C:242:54: style:inconclusive: Function 'condition' argument 3 names different: declaration 'minVals' definition 'low'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/cat/generic/AstroQuery.h:119:11: note: Function 'condition' argument 3 names different: declaration 'minVals' definition 'low'. skycat-3.1.2-starlink-1b/cat/generic/AstroQuery.C:242:54: note: Function 'condition' argument 3 names different: declaration 'minVals' definition 'low'. skycat-3.1.2-starlink-1b/cat/generic/AstroQuery.C:242:66: style:inconclusive: Function 'condition' argument 4 names different: declaration 'maxVals' definition 'high'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/cat/generic/AstroQuery.h:119:26: note: Function 'condition' argument 4 names different: declaration 'maxVals' definition 'high'. skycat-3.1.2-starlink-1b/cat/generic/AstroQuery.C:242:66: note: Function 'condition' argument 4 names different: declaration 'maxVals' definition 'high'. skycat-3.1.2-starlink-1b/astrotcl/press/hsmooth.c:64:13: style: Condition 'dmin(h0-hm))?(hp-h0):(h0-hm))<0)?(((hp-h0)>(h0-hm))?(hp-h0):(h0-hm)):0)<<2' here. skycat-3.1.2-starlink-1b/astrotcl/press/hsmooth.c:58:9: note: dmax is assigned '(((((hp-h0)<(h0-hm))?(hp-h0):(h0-hm))>0)?(((hp-h0)<(h0-hm))?(hp-h0):(h0-hm)):0)<<2' here. skycat-3.1.2-starlink-1b/astrotcl/press/hsmooth.c:64:13: note: Condition 'dmin(h0-hm))?(hp-h0):(h0-hm))<0)?(((hp-h0)>(h0-hm))?(hp-h0):(h0-hm)):0)<<2' here. skycat-3.1.2-starlink-1b/astrotcl/press/hsmooth.c:91:9: note: dmax is assigned '(((((hp-h0)<(h0-hm))?(hp-h0):(h0-hm))>0)?(((hp-h0)<(h0-hm))?(hp-h0):(h0-hm)):0)<<2' here. skycat-3.1.2-starlink-1b/astrotcl/press/hsmooth.c:93:13: note: Condition 'dminappend(entry)!=0' is always false [knownConditionTrueFalse] skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:297:24: note: Calling function 'append' returns 0 skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:297:32: note: Condition 'first->append(entry)!=0' is always false skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:326:31: style: Condition 'first->append(entry)!=0' is always false [knownConditionTrueFalse] skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:326:23: note: Calling function 'append' returns 0 skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:326:31: note: Condition 'first->append(entry)!=0' is always false skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:533:16: style: Condition 'append(e)!=0' is always false [knownConditionTrueFalse] skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:533:12: note: Calling function 'append' returns 0 skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:533:16: note: Condition 'append(e)!=0' is always false skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:818:23: style: Condition 'append(entry)!=0' is always false [knownConditionTrueFalse] skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:818:15: note: Calling function 'append' returns 0 skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:818:23: note: Condition 'append(entry)!=0' is always false skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:700:64: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:749:51: style:inconclusive: Function 'lookup' argument 1 names different: declaration 'catalogName' definition 'name'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.h:89:49: note: Function 'lookup' argument 1 names different: declaration 'catalogName' definition 'name'. skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:749:51: note: Function 'lookup' argument 1 names different: declaration 'catalogName' definition 'name'. skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:799:55: style:inconclusive: Function 'lookupFile' argument 1 names different: declaration 'catalogFileName' definition 'name'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.h:95:53: note: Function 'lookupFile' argument 1 names different: declaration 'catalogFileName' definition 'name'. skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:799:55: note: Function 'lookupFile' argument 1 names different: declaration 'catalogFileName' definition 'name'. skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:271:23: style: Local variable 'first' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.h:108:30: note: Shadowed declaration skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:271:23: note: Shadow variable skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:549:23: style: Local variable 'root' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.h:111:30: note: Shadowed declaration skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:549:23: note: Shadow variable skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:290:9: style: Variable 's' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:319:8: style: Variable 's' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:602:23: style: Variable 'e' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:605:25: style: Variable 'ne' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:651:11: style: Variable 'url' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/cat/generic/CatalogInfo.C:700:11: style: Variable 'ctype' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/cat/generic/TcsCatalogObject.h:102:17: style:inconclusive: Technically the member function 'TcsCatalogObject::id' can be const. [functionConst] skycat-3.1.2-starlink-1b/cat/generic/TcsCatalogObject.h:103:12: style:inconclusive: Technically the member function 'TcsCatalogObject::ra' can be const. [functionConst] skycat-3.1.2-starlink-1b/cat/generic/TcsCatalogObject.h:104:12: style:inconclusive: Technically the member function 'TcsCatalogObject::dec' can be const. [functionConst] skycat-3.1.2-starlink-1b/cat/generic/TcsCatalogObject.h:105:17: style:inconclusive: Technically the member function 'TcsCatalogObject::cooSystem' can be const. [functionConst] skycat-3.1.2-starlink-1b/cat/generic/TcsCatalogObject.h:106:12: style:inconclusive: Technically the member function 'TcsCatalogObject::epoch' can be const. [functionConst] skycat-3.1.2-starlink-1b/cat/generic/TcsCatalogObject.h:107:12: style:inconclusive: Technically the member function 'TcsCatalogObject::pma' can be const. [functionConst] skycat-3.1.2-starlink-1b/cat/generic/TcsCatalogObject.h:108:12: style:inconclusive: Technically the member function 'TcsCatalogObject::pmd' can be const. [functionConst] skycat-3.1.2-starlink-1b/cat/generic/TcsCatalogObject.h:109:12: style:inconclusive: Technically the member function 'TcsCatalogObject::radvel' can be const. [functionConst] skycat-3.1.2-starlink-1b/cat/generic/TcsCatalogObject.h:110:12: style:inconclusive: Technically the member function 'TcsCatalogObject::parallax' can be const. [functionConst] skycat-3.1.2-starlink-1b/cat/generic/TcsCatalogObject.h:111:17: style:inconclusive: Technically the member function 'TcsCatalogObject::cooType' can be const. [functionConst] skycat-3.1.2-starlink-1b/cat/generic/TcsCatalogObject.h:112:17: style:inconclusive: Technically the member function 'TcsCatalogObject::band' can be const. [functionConst] skycat-3.1.2-starlink-1b/cat/generic/TcsCatalogObject.h:113:12: style:inconclusive: Technically the member function 'TcsCatalogObject::mag' can be const. [functionConst] skycat-3.1.2-starlink-1b/cat/generic/TcsCatalogObject.h:114:17: style:inconclusive: Technically the member function 'TcsCatalogObject::more' can be const. [functionConst] skycat-3.1.2-starlink-1b/cat/generic/TcsCatalogObject.h:115:17: style:inconclusive: Technically the member function 'TcsCatalogObject::preview' can be const. [functionConst] skycat-3.1.2-starlink-1b/cat/generic/TcsCatalogObject.h:116:12: style:inconclusive: Technically the member function 'TcsCatalogObject::distance' can be const. [functionConst] skycat-3.1.2-starlink-1b/cat/generic/TcsCatalogObject.h:117:12: style:inconclusive: Technically the member function 'TcsCatalogObject::pa' can be const. [functionConst] skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.h:75:24: warning: The class 'TcsCatalog' defines member function with name 'open' also defined in its parent class 'AstroCatalog'. [duplInheritedMember] skycat-3.1.2-starlink-1b/cat/generic/AstroCatalog.h:78:26: note: Parent function 'AstroCatalog::open' skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.h:75:24: note: Derived function 'TcsCatalog::open' skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.h:88:9: warning: The class 'TcsCatalog' defines member function with name 'hasCol' also defined in its parent class 'AstroCatalog'. [duplInheritedMember] skycat-3.1.2-starlink-1b/cat/generic/AstroCatalog.h:187:9: note: Parent function 'AstroCatalog::hasCol' skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.h:88:9: note: Derived function 'TcsCatalog::hasCol' skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:74:5: style: Class 'TcsQueryResult' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.h:67:5: style: Class 'TcsCatalog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] skycat-3.1.2-starlink-1b/cat/generic/TcsLocalCatalog.h:39:5: style: Class 'TcsLocalCatalog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:54:17: style: The function 'inputColIndex' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/TabTable.h:95:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:54:17: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:57:17: style: The function 'compareRows' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/TabTable.h:170:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:57:17: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:66:18: style: The function 'printTableTop' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/QueryResult.h:56:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:66:18: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:78:14: style: The destructor '~TcsQueryResult' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/QueryResult.h:69:14: note: Virtual destructor in base class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:78:14: note: Destructor in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:81:17: style: The function 'clear' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/TabTable.h:126:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:81:17: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:84:17: style: The function 'init' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/TabTable.h:129:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:84:17: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:88:17: style: The function 'init' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/TabTable.h:133:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:88:17: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:98:17: style: The function 'printRow' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/TabTable.h:219:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:98:17: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:103:20: style: The function 'colNames' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/TabTable.h:233:20: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:103:20: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:104:17: style: The function 'numCols' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/TabTable.h:232:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:104:17: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:107:25: style: The function 'colName' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/TabTable.h:157:25: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:107:25: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:110:17: style: The function 'colIndex' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/TabTable.h:154:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:110:17: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:113:17: style: The function 'id_col' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/QueryResult.h:99:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:113:17: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:114:17: style: The function 'ra_col' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/QueryResult.h:100:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:114:17: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:115:17: style: The function 'dec_col' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/QueryResult.h:101:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:115:17: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:116:17: style: The function 'x_col' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/QueryResult.h:102:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:116:17: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:117:17: style: The function 'y_col' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/QueryResult.h:103:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:117:17: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.h:41:17: style: The function 'getObject' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/AstroCatalog.h:225:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.h:41:17: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.h:52:17: style: The function 'searchClosestStar' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/AstroCatalog.h:264:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.h:52:17: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.h:71:14: style: The destructor '~TcsCatalog' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/AstroCatalog.h:71:14: note: Virtual destructor in base class skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.h:71:14: note: Destructor in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.h:78:9: style: The function 'numCols' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/AstroCatalog.h:177:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.h:78:9: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.h:81:12: style: The function 'colNames' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/AstroCatalog.h:180:20: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.h:81:12: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.h:82:17: style: The function 'colName' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/AstroCatalog.h:181:25: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.h:82:17: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.h:85:9: style: The function 'colIndex' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/AstroCatalog.h:184:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.h:85:9: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsLocalCatalog.h:42:6: style: The destructor '~TcsLocalCatalog' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.h:71:14: note: Virtual destructor in base class skycat-3.1.2-starlink-1b/cat/generic/TcsLocalCatalog.h:42:6: note: Destructor in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsLocalCatalog.h:46:17: style: The function 'query' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/AstroCatalog.h:102:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TcsLocalCatalog.h:46:17: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsLocalCatalog.h:52:17: style: The function 'getInfo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/AstroCatalog.h:54:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TcsLocalCatalog.h:52:17: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TcsLocalCatalog.h:53:17: style: The function 'checkInfo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/AstroCatalog.h:55:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TcsLocalCatalog.h:53:17: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TclTcsCat.h:32:17: style: The function 'saveQueryResult' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/TclAstroCat.h:47:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TclTcsCat.h:32:17: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TclTcsCat.h:35:17: style: The function 'removeQueryResult' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/TclAstroCat.h:50:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TclTcsCat.h:35:17: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TclTcsCat.h:46:9: style: The function 'openCmd' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/TclAstroCat.h:98:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TclTcsCat.h:46:9: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TclTcsCat.h:47:9: style: The function 'checkCmd' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/TclAstroCat.h:76:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TclTcsCat.h:47:9: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TclTcsCat.h:48:9: style: The function 'queryCmd' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/TclAstroCat.h:100:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/cat/generic/TclTcsCat.h:48:9: note: Function in derived class skycat-3.1.2-starlink-1b/cat/generic/TclTcsCat.C:40:41: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/TclTcsCat.C:231:11: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/TclTcsCat.C:223:9: style: The scope of the variable 'i' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/cat/generic/TclTcsCat.C:226:10: style: The scope of the variable 'buf' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/cat/generic/TclTcsCat.C:223:11: style: Variable 'i' is assigned a value that is never used. [unreadVariable] skycat-3.1.2-starlink-1b/cat/generic/TclTcsCat.C:223:18: style: Variable 'j' is assigned a value that is never used. [unreadVariable] skycat-3.1.2-starlink-1b/cat/generic/TclTcsCat.C:224:14: style: Variable 'errs' is assigned a value that is never used. [unreadVariable] skycat-3.1.2-starlink-1b/cat/generic/TclTcsCat.C:222:11: style: Unused variable: s [unusedVariable] skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.C:29:25: warning: The class 'TcsCatalog' defines member function with name 'open' also defined in its parent class 'AstroCatalog'. [duplInheritedMember] skycat-3.1.2-starlink-1b/cat/generic/AstroCatalog.h:78:26: note: Parent function 'AstroCatalog::open' skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.C:29:25: note: Derived function 'TcsCatalog::open' skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.C:113:16: style: Variable 'status' is assigned a value that is never used. [unreadVariable] skycat-3.1.2-starlink-1b/cat/generic/TcsCatalogObject.C:131:37: warning: 'operator=' should check for assignment to self to avoid problems with dynamic memory. [operatorEqToSelf] skycat-3.1.2-starlink-1b/cat/generic/TcsCatalogObject.h:66:10: style:inconclusive: Technically the member function 'TcsCatalogObject::print' can be const. [functionConst] skycat-3.1.2-starlink-1b/cat/generic/TcsCatalogObject.C:267:24: note: Technically the member function 'TcsCatalogObject::print' can be const. skycat-3.1.2-starlink-1b/cat/generic/TcsCatalogObject.h:66:10: note: Technically the member function 'TcsCatalogObject::print' can be const. skycat-3.1.2-starlink-1b/cat/generic/TcsCatalogObject.h:135:9: style:inconclusive: Technically the member function 'TcsCatalogObject::compare' can be const. [functionConst] skycat-3.1.2-starlink-1b/cat/generic/TcsCatalogObject.C:462:23: note: Technically the member function 'TcsCatalogObject::compare' can be const. skycat-3.1.2-starlink-1b/cat/generic/TcsCatalogObject.h:135:9: note: Technically the member function 'TcsCatalogObject::compare' can be const. skycat-3.1.2-starlink-1b/cat/generic/TcsCatalogObject.C:540:66: style: Parameter 'colName' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/cat/generic/TcsLocalCatalog.C:52:7: warning: Class 'TcsLocalCatalog' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] skycat-3.1.2-starlink-1b/cat/generic/TcsLocalCatalog.C:52:7: warning: Class 'TcsLocalCatalog' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] skycat-3.1.2-starlink-1b/cat/generic/TcsLocalCatalog.h:52:17: style: Virtual function 'getInfo' is called from constructor 'TcsLocalCatalog(CatalogInfoEntry*e)' at line 54. Dynamic binding is not used. [virtualCallInConstructor] skycat-3.1.2-starlink-1b/cat/generic/TcsLocalCatalog.C:54:15: note: Calling getInfo skycat-3.1.2-starlink-1b/cat/generic/TcsLocalCatalog.h:52:17: note: getInfo is a virtual function skycat-3.1.2-starlink-1b/cat/generic/TcsLocalCatalog.C:133:20: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/TcsLocalCatalog.C:137:25: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.C:111:29: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:36:10: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:48:10: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:79:13: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:88:13: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:97:20: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:106:21: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:115:13: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:130:13: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:152:19: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:159:12: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:187:19: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:200:12: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:234:10: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:236:21: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:281:19: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:295:12: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:320:19: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:329:12: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:355:19: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:368:12: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:383:13: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:390:13: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:397:21: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:410:13: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:415:13: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:420:13: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:425:13: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:430:13: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:435:13: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:443:13: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:448:13: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:453:13: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:458:13: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:463:13: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:468:13: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:484:19: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:507:13: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:518:23: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:124:14: style:inconclusive: Function 'acGetDescription' argument 1 names different: declaration 'cat' definition 'handle'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.h:62:14: note: Function 'acGetDescription' argument 1 names different: declaration 'cat' definition 'handle'. skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:124:14: note: Function 'acGetDescription' argument 1 names different: declaration 'cat' definition 'handle'. skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:141:14: style:inconclusive: Function 'acGetObject' argument 1 names different: declaration 'cat' definition 'handle'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.h:71:14: note: Function 'acGetObject' argument 1 names different: declaration 'cat' definition 'handle'. skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:141:14: note: Function 'acGetObject' argument 1 names different: declaration 'cat' definition 'handle'. skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:168:14: style:inconclusive: Function 'acGetArea' argument 1 names different: declaration 'cat' definition 'handle'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.h:82:14: note: Function 'acGetArea' argument 1 names different: declaration 'cat' definition 'handle'. skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:168:14: note: Function 'acGetArea' argument 1 names different: declaration 'cat' definition 'handle'. skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:261:14: style:inconclusive: Function 'acCircularSearch' argument 1 names different: declaration 'cat' definition 'handle'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.h:113:14: note: Function 'acCircularSearch' argument 1 names different: declaration 'cat' definition 'handle'. skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:261:14: note: Function 'acCircularSearch' argument 1 names different: declaration 'cat' definition 'handle'. skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:306:14: style:inconclusive: Function 'acSearchClosestStar' argument 1 names different: declaration 'cat' definition 'handle'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.h:134:14: note: Function 'acSearchClosestStar' argument 1 names different: declaration 'cat' definition 'handle'. skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:306:14: note: Function 'acSearchClosestStar' argument 1 names different: declaration 'cat' definition 'handle'. skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:338:18: style:inconclusive: Function 'acCatalogSearch' argument 1 names different: declaration 'cat' definition 'handle'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.h:148:18: note: Function 'acCatalogSearch' argument 1 names different: declaration 'cat' definition 'handle'. skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:338:18: note: Function 'acCatalogSearch' argument 1 names different: declaration 'cat' definition 'handle'. skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:57:23: style: Parameter 'name' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:111:39: style: Parameter 'name' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:142:11: style: Parameter 'id' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:178:11: style: Parameter 'filename' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:271:11: style: Parameter 'filename' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/cat/generic/astro_image.C:36:10: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_image.C:83:10: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_image.C:85:21: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/astro_image.C:45:23: style: Parameter 'name' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/cat/generic/cat_bitmaps.C:16:55: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/cat_bitmaps.C:19:54: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/cat_bitmaps.C:22:56: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/cat_bitmaps.C:25:56: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/cat_bitmaps.C:28:53: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/cat_bitmaps.C:31:57: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/cat_bitmaps.C:34:55: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/cat_bitmaps.C:37:53: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/cat_bitmaps.C:40:54: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/cat_bitmaps.C:43:56: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/tests/tAstroCatalog.C:19:1: error: syntax error [syntaxError] skycat-3.1.2-starlink-1b/cat/tests/tAstroImage.C:20:1: error: syntax error [syntaxError] skycat-3.1.2-starlink-1b/cat/tests/tLocalCatalog.C:19:1: error: syntax error [syntaxError] skycat-3.1.2-starlink-1b/cat/tests/tQueryResult.C:35:1: error: syntax error [syntaxError] skycat-3.1.2-starlink-1b/cat/tests/tTabTable.C:18:1: error: syntax error [syntaxError] skycat-3.1.2-starlink-1b/cat/tests/tTcsCatalog.C:19:1: error: syntax error [syntaxError] skycat-3.1.2-starlink-1b/cat/tests/tTcsLocalCatalog.C:19:1: error: syntax error [syntaxError] skycat-3.1.2-starlink-1b/cat/tests/tastro_image.c:34:11: style: Variable 'filename' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:576:5: warning: Member variable 'ImageDataParams::flipX' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:576:5: warning: Member variable 'ImageDataParams::flipY' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:576:5: warning: Member variable 'ImageDataParams::rotate' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:576:5: warning: Member variable 'ImageDataParams::xScale' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:576:5: warning: Member variable 'ImageDataParams::yScale' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:576:5: warning: Member variable 'ImageDataParams::dataType' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:576:5: warning: Member variable 'ImageDataParams::lowCut' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:576:5: warning: Member variable 'ImageDataParams::highCut' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:576:5: warning: Member variable 'ImageDataParams::colorScale' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:587:5: warning: Member variable 'ImageDataHistogram::area' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/LookupTable.h:141:19: style:inconclusive: Technically the member function 'LookupTable::operator[]' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageDisplay.h:84:9: style:inconclusive: Technically the member function 'ImageDisplay::width' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageDisplay.h:85:9: style:inconclusive: Technically the member function 'ImageDisplay::height' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageDisplay.h:86:9: style:inconclusive: Technically the member function 'ImageDisplay::bitmapPad' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageDisplay.h:87:9: style:inconclusive: Technically the member function 'ImageDisplay::bytesPerLine' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageDisplay.h:88:9: style:inconclusive: Technically the member function 'ImageDisplay::depth' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageDisplay.h:89:9: style:inconclusive: Technically the member function 'ImageDisplay::bitsPerPixel' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageDisplay.h:90:9: style:inconclusive: Technically the member function 'ImageDisplay::bytesPerPixel' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageDisplay.h:93:9: style:inconclusive: Technically the member function 'ImageDisplay::usingXShm' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:444:9: style:inconclusive: Technically the member function 'ImageData::status' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:461:20: style:inconclusive: Technically the member function 'ImageData::image' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:464:25: style:inconclusive: Technically the member function 'ImageData::colorScaleType' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:465:9: performance:inconclusive: Technically the member function 'ImageData::ncolors' can be static (but you may consider moving to unnamed namespace). [functionStatic] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:466:20: performance:inconclusive: Technically the member function 'ImageData::colors' can be static (but you may consider moving to unnamed namespace). [functionStatic] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:467:19: performance:inconclusive: Technically the member function 'ImageData::color0' can be static (but you may consider moving to unnamed namespace). [functionStatic] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:468:19: performance:inconclusive: Technically the member function 'ImageData::colorn' can be static (but you may consider moving to unnamed namespace). [functionStatic] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:471:10: performance:inconclusive: Technically the member function 'ImageData::setBiasInfo' can be static (but you may consider moving to unnamed namespace). [functionStatic] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:474:12: style:inconclusive: Technically the member function 'ImageData::logexpo' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:477:12: style:inconclusive: Technically the member function 'ImageData::sqrtexpo' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:479:9: style:inconclusive: Technically the member function 'ImageData::width' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:480:9: style:inconclusive: Technically the member function 'ImageData::height' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:481:9: style:inconclusive: Technically the member function 'ImageData::dispWidth' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:482:9: style:inconclusive: Technically the member function 'ImageData::dispHeight' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:484:9: style:inconclusive: Technically the member function 'ImageData::xScale' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:485:9: style:inconclusive: Technically the member function 'ImageData::yScale' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:486:9: style:inconclusive: Technically the member function 'ImageData::flipX' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:488:9: style:inconclusive: Technically the member function 'ImageData::flipY' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:490:9: style:inconclusive: Technically the member function 'ImageData::rotate' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:493:12: style:inconclusive: Technically the member function 'ImageData::crpix1' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:494:12: style:inconclusive: Technically the member function 'ImageData::crpix2' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:496:9: style:inconclusive: Technically the member function 'ImageData::startX' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:497:9: style:inconclusive: Technically the member function 'ImageData::startY' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:501:9: style:inconclusive: Technically the member function 'ImageData::binX' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:502:9: style:inconclusive: Technically the member function 'ImageData::binY' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:506:9: style:inconclusive: Technically the member function 'ImageData::prescanX' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:507:9: style:inconclusive: Technically the member function 'ImageData::prescanY' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:511:9: style:inconclusive: Technically the member function 'ImageData::overscanX' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:512:9: style:inconclusive: Technically the member function 'ImageData::overscanY' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:539:9: style:inconclusive: Technically the member function 'ImageData::update_pending' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:542:17: style:inconclusive: Technically the member function 'ImageData::lookupTable' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:591:9: style:inconclusive: Technically the member function 'ImageDataHistogram::size' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ByteImageData.h:36:19: performance:inconclusive: Technically the member function 'ByteImageData::convertToUshort' can be static (but you may consider moving to unnamed namespace). [functionStatic] skycat-3.1.2-starlink-1b/rtd/generic/ByteImageData.h:41:17: style:inconclusive: Technically the member function 'ByteImageData::lookup' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ByteImageData.h:46:26: style:inconclusive: Technically the member function 'ByteImageData::llookup' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/LookupTable.h:47:5: style: Class 'LookupTableRep' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] skycat-3.1.2-starlink-1b/rtd/generic/LookupTable.h:89:5: style: Class 'LookupTable' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] skycat-3.1.2-starlink-1b/rtd/generic/LookupTable.h:95:5: style: Class 'LookupTable' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] skycat-3.1.2-starlink-1b/rtd/generic/ByteImageData.h:64:10: style: The function 'initShortConversion' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:246:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ByteImageData.h:64:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ByteImageData.h:73:25: style: The function 'classname' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:287:25: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ByteImageData.h:73:25: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ByteImageData.h:76:9: style: The function 'dataType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:396:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ByteImageData.h:76:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ByteImageData.h:79:9: style: The function 'isSigned' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:399:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ByteImageData.h:79:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ByteImageData.h:82:16: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:402:24: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ByteImageData.h:82:16: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:43:6: style: The function 'getMinMax' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:249:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:43:6: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:46:7: style: The function 'getValue' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:409:19: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:46:7: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:49:8: style: The function 'getValue' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:424:20: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:49:8: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:52:6: style: The function 'getValues' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:412:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:52:6: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:57:6: style: The function 'getValues' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:417:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:57:6: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:61:6: style: The function 'getValues' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:421:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:61:6: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:67:6: style: The function 'copyImageArea' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:430:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:67:6: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:70:6: style: The function 'rawToXImage' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:230:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:70:6: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:71:6: style: The function 'grow' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:236:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:71:6: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:72:6: style: The function 'shrink' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:233:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:72:6: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:75:6: style: The function 'growAndShrink' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:240:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:75:6: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:78:6: style: The function 'medianFilter' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:390:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:78:6: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:81:6: style: The function 'getPixDist' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:262:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:81:6: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:85:6: style: The function 'initBlankPixel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:553:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:85:6: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:89:6: style: The function 'getHistogram' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:266:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:89:6: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:92:5: style: The function 'haveBlank' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:549:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:92:5: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:93:8: style: The function 'getBlank' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:548:20: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ImageTemplates.h:93:8: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ImageDisplay.h:68:19: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/ColorMapInfo.h:75:21: style:inconclusive: Technically the member function 'ColorMapInfo::rgbcolor' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ColorMapInfo.h:79:10: style:inconclusive: Technically the member function 'ColorMapInfo::interpolate' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ColorMapInfo.C:157:20: note: Technically the member function 'ColorMapInfo::interpolate' can be const. skycat-3.1.2-starlink-1b/rtd/generic/ColorMapInfo.h:79:10: note: Technically the member function 'ColorMapInfo::interpolate' can be const. skycat-3.1.2-starlink-1b/rtd/generic/ColorMapInfo.h:82:10: performance:inconclusive: Technically the member function 'ColorMapInfo::rotate' can be static (but you may consider moving to unnamed namespace). [functionStatic] skycat-3.1.2-starlink-1b/rtd/generic/ColorMapInfo.C:174:20: note: Technically the member function 'ColorMapInfo::rotate' can be static (but you may consider moving to unnamed namespace). skycat-3.1.2-starlink-1b/rtd/generic/ColorMapInfo.h:82:10: note: Technically the member function 'ColorMapInfo::rotate' can be static (but you may consider moving to unnamed namespace). skycat-3.1.2-starlink-1b/rtd/generic/ColorMapInfo.h:85:10: performance:inconclusive: Technically the member function 'ColorMapInfo::shift' can be static (but you may consider moving to unnamed namespace). [functionStatic] skycat-3.1.2-starlink-1b/rtd/generic/ColorMapInfo.C:194:20: note: Technically the member function 'ColorMapInfo::shift' can be static (but you may consider moving to unnamed namespace). skycat-3.1.2-starlink-1b/rtd/generic/ColorMapInfo.h:85:10: note: Technically the member function 'ColorMapInfo::shift' can be static (but you may consider moving to unnamed namespace). skycat-3.1.2-starlink-1b/rtd/generic/ColorMapInfo.C:159:9: style: The scope of the variable 'index' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/rtd/generic/ColorMapInfo.C:176:9: style: The scope of the variable 'index' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/rtd/generic/ColorMapInfo.C:196:9: style: The scope of the variable 'index' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/rtd/generic/ColorMapInfo.C:97:11: style: Local variable 'name' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/rtd/generic/ColorMapInfo.h:73:17: note: Shadowed declaration skycat-3.1.2-starlink-1b/rtd/generic/ColorMapInfo.C:97:11: note: Shadow variable skycat-3.1.2-starlink-1b/rtd/generic/BiasData.h:42:12: style:inconclusive: Technically the member function 'BiasData::status' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/BiasData.C:40:15: note: Technically the member function 'BiasData::status' can be const. skycat-3.1.2-starlink-1b/rtd/generic/BiasData.h:42:12: note: Technically the member function 'BiasData::status' can be const. skycat-3.1.2-starlink-1b/rtd/generic/BiasData.h:47:12: style:inconclusive: Technically the member function 'BiasData::select' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/BiasData.C:244:15: note: Technically the member function 'BiasData::select' can be const. skycat-3.1.2-starlink-1b/rtd/generic/BiasData.h:47:12: note: Technically the member function 'BiasData::select' can be const. skycat-3.1.2-starlink-1b/rtd/generic/BiasData.C:137:9: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/BiasData.C:143:24: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/BiasData.C:144:15: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/BiasData.C:207:12: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/BiasData.C:229:21: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/BiasData.C:99:9: style: Local variable 'on' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/rtd/generic/BiasData.h:39:12: note: Shadowed declaration skycat-3.1.2-starlink-1b/rtd/generic/BiasData.C:99:9: note: Shadow variable skycat-3.1.2-starlink-1b/rtd/generic/BiasData.C:187:9: style: Local variable 'on' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/rtd/generic/BiasData.h:39:12: note: Shadowed declaration skycat-3.1.2-starlink-1b/rtd/generic/BiasData.C:187:9: note: Shadow variable skycat-3.1.2-starlink-1b/rtd/generic/BiasData.C:143:18: style: Variable 'pus' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/rtd/generic/BiasData.C:183:44: style: Parameter 'filename' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/rtd/generic/BiasData.C:144:36: style: Unused variable: ss [unusedVariable] skycat-3.1.2-starlink-1b/rtd/generic/DoubleImageData.h:32:11: style:inconclusive: Technically the member function 'DoubleImageData::scaleToShort' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/DoubleImageData.C:31:24: note: Technically the member function 'DoubleImageData::scaleToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/DoubleImageData.h:32:11: note: Technically the member function 'DoubleImageData::scaleToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/DoubleImageData.h:55:10: style: The function 'initShortConversion' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:246:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/DoubleImageData.h:55:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/DoubleImageData.h:69:10: style: The function 'colorScale' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:393:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/DoubleImageData.h:69:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/DoubleImageData.h:80:25: style: The function 'classname' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:287:25: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/DoubleImageData.h:80:25: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/DoubleImageData.h:83:9: style: The function 'dataType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:396:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/DoubleImageData.h:83:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/DoubleImageData.h:86:9: style: The function 'isSigned' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:399:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/DoubleImageData.h:86:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/DoubleImageData.h:89:16: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:402:24: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/DoubleImageData.h:89:16: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.C:55:20: warning: Member variable 'CompoundImageData::blank_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.C:111:20: warning: Member variable 'CompoundImageData::blank_' is not initialized in the copy constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:38:19: style:inconclusive: Member variable 'CompoundImageData::minY_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.C:116:7: note: Member variable 'CompoundImageData::minY_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:38:19: note: Member variable 'CompoundImageData::minY_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:58:10: style:inconclusive: Technically the member function 'CompoundImageData::getBounds' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.C:141:25: note: Technically the member function 'CompoundImageData::getBounds' can be const. skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:58:10: note: Technically the member function 'CompoundImageData::getBounds' can be const. skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.C:61:5: warning: Class 'CompoundImageData' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:46:10: style: The function 'initShortConversion' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:246:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:46:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:49:18: style: The function 'toXImage' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:224:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:49:18: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:52:10: style: The function 'rawToXImage' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:230:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:52:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:53:10: style: The function 'grow' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:236:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:53:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:54:10: style: The function 'shrink' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:233:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:54:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:55:10: style: The function 'growAndShrink' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:240:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:55:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:71:6: style: The destructor '~CompoundImageData' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:284:14: note: Virtual destructor in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:71:6: note: Destructor in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:74:25: style: The function 'classname' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:287:25: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:74:25: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:77:16: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:402:24: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:77:16: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:80:9: style: The function 'dataType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:396:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:80:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:83:9: style: The function 'isSigned' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:399:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:83:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:86:9: style: The function 'lookupTable' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:543:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:86:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:89:10: style: The function 'setColors' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:469:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:89:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:92:10: style: The function 'setXImage' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:341:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:92:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:96:9: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:294:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:96:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:99:10: style: The function 'restoreParams' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:406:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:99:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:102:10: style: The function 'colorScale' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:393:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:102:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:105:10: style: The function 'setScale' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:344:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:105:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:108:10: style: The function 'rotate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:491:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:108:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:111:10: style: The function 'flipX' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:487:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:111:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:114:10: style: The function 'flipY' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:489:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:114:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:117:10: style: The function 'setCutLevels' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:384:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:117:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:120:10: style: The function 'subsample' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:521:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:120:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:121:10: style: The function 'sampmethod' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:524:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:121:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:122:10: style: The function 'verbose' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:529:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:122:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:123:10: style: The function 'name' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:531:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:123:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:124:10: style: The function 'object' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:533:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:124:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:126:9: style: The function 'getNumImages' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:527:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:126:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:135:10: style: The function 'getMinMax' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:249:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:135:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:138:11: style: The function 'getValue' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:409:19: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:138:11: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:141:12: style: The function 'getValue' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:424:20: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:141:12: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:144:10: style: The function 'getValues' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:412:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:144:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:149:10: style: The function 'getValues' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:417:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:149:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:153:10: style: The function 'getValues' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:421:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:153:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:159:10: style: The function 'copyImageArea' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:430:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:159:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:162:10: style: The function 'updateOffset' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:356:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:162:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:165:10: style: The function 'medianFilter' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:390:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:165:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:168:10: style: The function 'autoSetCutLevels' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:387:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:168:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:171:10: style: The function 'getPixDist' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:262:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:171:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:175:10: style: The function 'initBlankPixel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:553:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:175:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:179:10: style: The function 'getHistogram' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:266:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:179:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:183:12: style: The function 'highCut' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:516:20: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:183:12: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:184:12: style: The function 'lowCut' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:517:20: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:184:12: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:185:12: style: The function 'minValue' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:518:20: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:185:12: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:186:12: style: The function 'maxValue' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:519:20: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:186:12: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:189:9: style: The function 'haveBlank' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:549:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:189:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:190:12: style: The function 'getBlank' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:548:20: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:190:12: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.C:64:27: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.C:204:59: style:inconclusive: Function 'write' argument 2 names different: declaration 'x0' definition 'rx0'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:96:44: note: Function 'write' argument 2 names different: declaration 'x0' definition 'rx0'. skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.C:204:59: note: Function 'write' argument 2 names different: declaration 'x0' definition 'rx0'. skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.C:204:71: style:inconclusive: Function 'write' argument 3 names different: declaration 'y0' definition 'ry0'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:96:55: note: Function 'write' argument 3 names different: declaration 'y0' definition 'ry0'. skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.C:204:71: note: Function 'write' argument 3 names different: declaration 'y0' definition 'ry0'. skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.C:204:83: style:inconclusive: Function 'write' argument 4 names different: declaration 'x1' definition 'rx1'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:96:66: note: Function 'write' argument 4 names different: declaration 'x1' definition 'rx1'. skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.C:204:83: note: Function 'write' argument 4 names different: declaration 'x1' definition 'rx1'. skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.C:204:95: style:inconclusive: Function 'write' argument 5 names different: declaration 'y1' definition 'ry1'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:96:77: note: Function 'write' argument 5 names different: declaration 'y1' definition 'ry1'. skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.C:204:95: note: Function 'write' argument 5 names different: declaration 'y1' definition 'ry1'. skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.C:320:45: style:inconclusive: Function 'setCutLevels' argument 1 names different: declaration 'min' definition 'low'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:117:30: note: Function 'setCutLevels' argument 1 names different: declaration 'min' definition 'low'. skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.C:320:45: note: Function 'setCutLevels' argument 1 names different: declaration 'min' definition 'low'. skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.C:320:57: style:inconclusive: Function 'setCutLevels' argument 2 names different: declaration 'max' definition 'high'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:117:42: note: Function 'setCutLevels' argument 2 names different: declaration 'max' definition 'high'. skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.C:320:57: note: Function 'setCutLevels' argument 2 names different: declaration 'max' definition 'high'. skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.C:141:46: style: Parameter 'imageData' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/rtd/generic/FloatImageData.h:36:11: style:inconclusive: Technically the member function 'FloatImageData::scaleToShort' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/FloatImageData.C:37:23: note: Technically the member function 'FloatImageData::scaleToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/FloatImageData.h:36:11: note: Technically the member function 'FloatImageData::scaleToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/FloatImageData.h:56:10: style: The function 'initShortConversion' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:246:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/FloatImageData.h:56:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/FloatImageData.h:70:10: style: The function 'colorScale' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:393:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/FloatImageData.h:70:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/FloatImageData.h:81:25: style: The function 'classname' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:287:25: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/FloatImageData.h:81:25: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/FloatImageData.h:84:9: style: The function 'dataType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:396:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/FloatImageData.h:84:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/FloatImageData.h:87:9: style: The function 'isSigned' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:399:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/FloatImageData.h:87:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/FloatImageData.h:90:16: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:402:24: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/FloatImageData.h:90:16: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ITTInfo.h:30:11: style:inconclusive: Member variable 'ITTInfo::name_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/ITTInfo.C:47:7: note: Member variable 'ITTInfo::name_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ITTInfo.h:30:11: note: Member variable 'ITTInfo::name_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ITTInfo.h:56:10: style:inconclusive: Technically the member function 'ITTInfo::interpolate' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ITTInfo.C:142:15: note: Technically the member function 'ITTInfo::interpolate' can be const. skycat-3.1.2-starlink-1b/rtd/generic/ITTInfo.h:56:10: note: Technically the member function 'ITTInfo::interpolate' can be const. skycat-3.1.2-starlink-1b/rtd/generic/ITTInfo.h:60:10: style:inconclusive: Technically the member function 'ITTInfo::scale' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ITTInfo.C:162:15: note: Technically the member function 'ITTInfo::scale' can be const. skycat-3.1.2-starlink-1b/rtd/generic/ITTInfo.h:60:10: note: Technically the member function 'ITTInfo::scale' can be const. skycat-3.1.2-starlink-1b/rtd/generic/ITTInfo.C:145:9: style: The scope of the variable 'index' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/rtd/generic/ITTInfo.C:145:16: style: The scope of the variable 'value' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/rtd/generic/ITTInfo.C:166:16: style: The scope of the variable 'value' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/rtd/generic/ITTInfo.C:82:11: style: Local variable 'name' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/rtd/generic/ITTInfo.h:51:17: note: Shadowed declaration skycat-3.1.2-starlink-1b/rtd/generic/ITTInfo.C:82:11: note: Shadow variable skycat-3.1.2-starlink-1b/rtd/generic/ImageColor.h:109:9: style:inconclusive: Technically the member function 'ImageColor::usingPrivateCmap' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageColor.C:118:32: style:inconclusive: Function 'reallocate' argument 1 names different: declaration 'numFreeColors' definition 'numColors'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/rtd/generic/ImageColor.h:85:24: note: Function 'reallocate' argument 1 names different: declaration 'numFreeColors' definition 'numColors'. skycat-3.1.2-starlink-1b/rtd/generic/ImageColor.C:118:32: note: Function 'reallocate' argument 1 names different: declaration 'numFreeColors' definition 'numColors'. skycat-3.1.2-starlink-1b/rtd/generic/ImageColor.C:142:30: style:inconclusive: Function 'allocate' argument 1 names different: declaration 'numFreeColors' definition 'numColors'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/rtd/generic/ImageColor.h:84:22: note: Function 'allocate' argument 1 names different: declaration 'numFreeColors' definition 'numColors'. skycat-3.1.2-starlink-1b/rtd/generic/ImageColor.C:142:30: note: Function 'allocate' argument 1 names different: declaration 'numFreeColors' definition 'numColors'. skycat-3.1.2-starlink-1b/rtd/generic/ImageColor.C:200:19: style: Local variable 'pixelval' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/rtd/generic/ImageColor.h:118:20: note: Shadowed declaration skycat-3.1.2-starlink-1b/rtd/generic/ImageColor.C:200:19: note: Shadow variable skycat-3.1.2-starlink-1b/rtd/generic/ImageColor.C:73:13: style: Variable 'defvis' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/rtd/generic/ImageDisplay.C:189:24: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/ImageDisplay.C:264:21: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/ImageZoom.h:50:9: style:inconclusive: Technically the member function 'ImageZoom::status' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageZoom.C:70:5: warning: Class 'ImageZoom' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] skycat-3.1.2-starlink-1b/rtd/generic/ImageZoom.C:70:5: warning: Class 'ImageZoom' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] skycat-3.1.2-starlink-1b/rtd/generic/ImageZoom.C:51:42: style:inconclusive: Function 'ImageZoom' argument 2 names different: declaration 'copyGC' definition 'gc'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/rtd/generic/ImageZoom.h:39:35: note: Function 'ImageZoom' argument 2 names different: declaration 'copyGC' definition 'gc'. skycat-3.1.2-starlink-1b/rtd/generic/ImageZoom.C:51:42: note: Function 'ImageZoom' argument 2 names different: declaration 'copyGC' definition 'gc'. skycat-3.1.2-starlink-1b/rtd/generic/ImageZoom.C:52:12: style:inconclusive: Function 'ImageZoom' argument 5 names different: declaration 'factor' definition 'zoomFactor'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/rtd/generic/ImageZoom.h:39:70: note: Function 'ImageZoom' argument 5 names different: declaration 'factor' definition 'zoomFactor'. skycat-3.1.2-starlink-1b/rtd/generic/ImageZoom.C:52:12: note: Function 'ImageZoom' argument 5 names different: declaration 'factor' definition 'zoomFactor'. skycat-3.1.2-starlink-1b/rtd/generic/ImageZoom.C:96:37: style: Parameter 'data' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/rtd/generic/ImageZoom.C:102:17: style: Variable 'pixval' is assigned a value that is never used. [unreadVariable] skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:78:5: warning: Member variable 'LongImageData::bias_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:78:5: warning: Member variable 'LongImageData::dbias_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:78:5: warning: Member variable 'LongImageData::scale_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:78:5: warning: Member variable 'LongImageData::scaled_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:46:11: style:inconclusive: Technically the member function 'LongImageData::convertToShort' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.C:51:22: note: Technically the member function 'LongImageData::convertToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:46:11: note: Technically the member function 'LongImageData::convertToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:47:11: style:inconclusive: Technically the member function 'LongImageData::scaleToShort' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.C:78:22: note: Technically the member function 'LongImageData::scaleToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:47:11: note: Technically the member function 'LongImageData::scaleToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:74:10: style: The function 'initShortConversion' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:246:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:74:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:83:25: style: The function 'classname' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:287:25: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:83:25: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:86:9: style: The function 'dataType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:396:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:86:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:89:9: style: The function 'isSigned' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:399:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:89:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:92:16: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:402:24: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:92:16: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.h:68:5: warning: Member variable 'LongLongImageData::bias_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.h:68:5: warning: Member variable 'LongLongImageData::dbias_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.h:68:5: warning: Member variable 'LongLongImageData::scale_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.h:68:5: warning: Member variable 'LongLongImageData::scaled_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.h:36:11: style:inconclusive: Technically the member function 'LongLongImageData::convertToShort' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.C:29:26: note: Technically the member function 'LongLongImageData::convertToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.h:36:11: note: Technically the member function 'LongLongImageData::convertToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.h:37:11: style:inconclusive: Technically the member function 'LongLongImageData::scaleToShort' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.C:56:26: note: Technically the member function 'LongLongImageData::scaleToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.h:37:11: note: Technically the member function 'LongLongImageData::scaleToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.h:64:10: style: The function 'initShortConversion' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:246:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.h:64:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.h:73:9: style: The function 'dataType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:396:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.h:73:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.h:76:9: style: The function 'isSigned' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:399:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.h:76:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.h:79:16: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:402:24: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.h:79:16: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ShortImageData.h:72:5: warning: Member variable 'NativeShortImageData::bias_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/ShortImageData.h:72:5: warning: Member variable 'NativeShortImageData::scale_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/UShortImageData.h:64:5: warning: Member variable 'NativeUShortImageData::bias_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/UShortImageData.h:64:5: warning: Member variable 'NativeUShortImageData::scale_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:78:5: warning: Member variable 'NativeLongImageData::bias_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:78:5: warning: Member variable 'NativeLongImageData::dbias_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:78:5: warning: Member variable 'NativeLongImageData::scale_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:78:5: warning: Member variable 'NativeLongImageData::scaled_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.h:68:5: warning: Member variable 'NativeLongLongImageData::bias_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.h:68:5: warning: Member variable 'NativeLongLongImageData::dbias_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.h:68:5: warning: Member variable 'NativeLongLongImageData::scale_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.h:68:5: warning: Member variable 'NativeLongLongImageData::scaled_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/ShortImageData.h:72:5: warning: Member variable 'ShortImageData::bias_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/ShortImageData.h:72:5: warning: Member variable 'ShortImageData::scale_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/UShortImageData.h:64:5: warning: Member variable 'UShortImageData::bias_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/UShortImageData.h:64:5: warning: Member variable 'UShortImageData::scale_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:113:19: style:inconclusive: Member variable 'ImageData::xImage_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:141:7: note: Member variable 'ImageData::xImage_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:113:19: note: Member variable 'ImageData::xImage_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:174:12: style:inconclusive: Member variable 'ImageData::highCut_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:151:7: note: Member variable 'ImageData::highCut_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:174:12: note: Member variable 'ImageData::highCut_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:167:9: style:inconclusive: Member variable 'ImageData::scaledLowCut_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:152:7: note: Member variable 'ImageData::scaledLowCut_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:167:9: note: Member variable 'ImageData::scaledLowCut_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:166:9: style:inconclusive: Member variable 'ImageData::scaledHighCut_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:153:7: note: Member variable 'ImageData::scaledHighCut_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:166:9: note: Member variable 'ImageData::scaledHighCut_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:161:12: style:inconclusive: Member variable 'ImageData::minValue_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:155:7: note: Member variable 'ImageData::minValue_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:161:12: note: Member variable 'ImageData::minValue_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:210:9: style:inconclusive: Member variable 'ImageData::update_pending_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:176:7: note: Member variable 'ImageData::update_pending_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:210:9: note: Member variable 'ImageData::update_pending_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:143:17: style:inconclusive: Member variable 'ImageData::lookup_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:178:7: note: Member variable 'ImageData::lookup_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:143:17: note: Member variable 'ImageData::lookup_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:113:19: style:inconclusive: Member variable 'ImageData::xImage_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:204:7: note: Member variable 'ImageData::xImage_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:113:19: note: Member variable 'ImageData::xImage_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:136:9: style:inconclusive: Member variable 'ImageData::xImageBytesPerPixel_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:210:7: note: Member variable 'ImageData::xImageBytesPerPixel_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:136:9: note: Member variable 'ImageData::xImageBytesPerPixel_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:174:12: style:inconclusive: Member variable 'ImageData::highCut_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:214:7: note: Member variable 'ImageData::highCut_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:174:12: note: Member variable 'ImageData::highCut_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:167:9: style:inconclusive: Member variable 'ImageData::scaledLowCut_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:215:7: note: Member variable 'ImageData::scaledLowCut_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:167:9: note: Member variable 'ImageData::scaledLowCut_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:166:9: style:inconclusive: Member variable 'ImageData::scaledHighCut_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:216:7: note: Member variable 'ImageData::scaledHighCut_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:166:9: note: Member variable 'ImageData::scaledHighCut_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:161:12: style:inconclusive: Member variable 'ImageData::minValue_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:218:7: note: Member variable 'ImageData::minValue_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:161:12: note: Member variable 'ImageData::minValue_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:210:9: style:inconclusive: Member variable 'ImageData::update_pending_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:239:7: note: Member variable 'ImageData::update_pending_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:210:9: note: Member variable 'ImageData::update_pending_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:143:17: style:inconclusive: Member variable 'ImageData::lookup_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:241:7: note: Member variable 'ImageData::lookup_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:143:17: note: Member variable 'ImageData::lookup_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:252:10: style:inconclusive: Technically the member function 'ImageData::flip' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:763:17: note: Technically the member function 'ImageData::flip' can be const. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:252:10: note: Technically the member function 'ImageData::flip' can be const. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:253:10: style:inconclusive: Technically the member function 'ImageData::flip' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:779:17: note: Technically the member function 'ImageData::flip' can be const. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:253:10: note: Technically the member function 'ImageData::flip' can be const. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:328:10: style:inconclusive: Technically the member function 'ImageData::imageToChipCoords' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:923:17: note: Technically the member function 'ImageData::imageToChipCoords' can be const. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:328:10: note: Technically the member function 'ImageData::imageToChipCoords' can be const. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:331:10: style:inconclusive: Technically the member function 'ImageData::chipToImageCoords' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:934:17: note: Technically the member function 'ImageData::chipToImageCoords' can be const. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:331:10: note: Technically the member function 'ImageData::chipToImageCoords' can be const. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:334:10: style:inconclusive: Technically the member function 'ImageData::imageToChipCoords' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:944:17: note: Technically the member function 'ImageData::imageToChipCoords' can be const. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:334:10: note: Technically the member function 'ImageData::imageToChipCoords' can be const. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:335:10: style:inconclusive: Technically the member function 'ImageData::chipToImageCoords' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:948:17: note: Technically the member function 'ImageData::chipToImageCoords' can be const. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:335:10: note: Technically the member function 'ImageData::chipToImageCoords' can be const. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:338:9: style:inconclusive: Technically the member function 'ImageData::getIndex' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:960:16: note: Technically the member function 'ImageData::getIndex' can be const. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:338:9: note: Technically the member function 'ImageData::getIndex' can be const. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:378:10: style:inconclusive: Technically the member function 'ImageData::getBbox' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:1536:17: note: Technically the member function 'ImageData::getBbox' can be const. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:378:10: note: Technically the member function 'ImageData::getBbox' can be const. skycat-3.1.2-starlink-1b/rtd/generic/XImageData.h:35:19: performance:inconclusive: Technically the member function 'XImageData::convertToUshort' can be static (but you may consider moving to unnamed namespace). [functionStatic] skycat-3.1.2-starlink-1b/rtd/generic/XImageData.h:41:17: style:inconclusive: Technically the member function 'XImageData::lookup' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/XImageData.h:46:26: style:inconclusive: Technically the member function 'XImageData::llookup' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:531:18: style: Virtual function 'name' is called from constructor 'ImageData(const char*name,const ImageIO&,int verbose,int lookup_size=LOOKUP_SIZE)' at line 181. Dynamic binding is not used. [virtualCallInConstructor] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:181:5: note: Calling name skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:531:18: note: name is a virtual function skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:533:18: style: Virtual function 'object' is called from constructor 'ImageData(const char*name,const ImageIO&,int verbose,int lookup_size=LOOKUP_SIZE)' at line 182. Dynamic binding is not used. [virtualCallInConstructor] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:182:5: note: Calling object skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:533:18: note: object is a virtual function skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:531:18: style: Virtual function 'name' is called from copy constructor 'ImageData(const ImageData&)' at line 244. Dynamic binding is not used. [virtualCallInConstructor] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:244:5: note: Calling name skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:531:18: note: name is a virtual function skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:533:18: style: Virtual function 'object' is called from copy constructor 'ImageData(const ImageData&)' at line 245. Dynamic binding is not used. [virtualCallInConstructor] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:245:5: note: Calling object skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:533:18: note: object is a virtual function skycat-3.1.2-starlink-1b/rtd/generic/ShortImageData.h:68:10: style: The function 'initShortConversion' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:246:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ShortImageData.h:68:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ShortImageData.h:76:25: style: The function 'classname' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:287:25: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ShortImageData.h:76:25: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ShortImageData.h:79:9: style: The function 'dataType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:396:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ShortImageData.h:79:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ShortImageData.h:82:9: style: The function 'isSigned' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:399:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ShortImageData.h:82:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ShortImageData.h:85:16: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:402:24: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/ShortImageData.h:85:16: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/UShortImageData.h:60:10: style: The function 'initShortConversion' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:246:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/UShortImageData.h:60:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/UShortImageData.h:68:25: style: The function 'classname' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:287:25: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/UShortImageData.h:68:25: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/UShortImageData.h:71:9: style: The function 'dataType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:396:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/UShortImageData.h:71:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/UShortImageData.h:74:9: style: The function 'isSigned' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:399:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/UShortImageData.h:74:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/UShortImageData.h:77:16: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:402:24: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/UShortImageData.h:77:16: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/XImageData.h:64:10: style: The function 'initShortConversion' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:246:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/XImageData.h:64:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/XImageData.h:78:25: style: The function 'classname' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:287:25: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/XImageData.h:78:25: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/XImageData.h:81:9: style: The function 'dataType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:396:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/XImageData.h:81:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/XImageData.h:84:9: style: The function 'isSigned' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:399:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/XImageData.h:84:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/XImageData.h:87:16: style: The function 'copy' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:402:24: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/XImageData.h:87:16: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/XImageData.h:90:10: style: The function 'colorScale' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:393:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/XImageData.h:90:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:356:27: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:360:18: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:1591:16: style: The scope of the variable 'y0' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:1619:12: style: The scope of the variable 'cx' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:130:34: style:inconclusive: Function 'ImageData' argument 1 names different: declaration 'name' definition 'imageName'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:275:27: note: Function 'ImageData' argument 1 names different: declaration 'name' definition 'imageName'. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:130:34: note: Function 'ImageData' argument 1 names different: declaration 'name' definition 'imageName'. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:344:51: style:inconclusive: Function 'write' argument 2 names different: declaration 'x0' definition 'rx0'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:294:52: note: Function 'write' argument 2 names different: declaration 'x0' definition 'rx0'. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:344:51: note: Function 'write' argument 2 names different: declaration 'x0' definition 'rx0'. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:344:63: style:inconclusive: Function 'write' argument 3 names different: declaration 'y0' definition 'ry0'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:294:63: note: Function 'write' argument 3 names different: declaration 'y0' definition 'ry0'. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:344:63: note: Function 'write' argument 3 names different: declaration 'y0' definition 'ry0'. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:344:75: style:inconclusive: Function 'write' argument 4 names different: declaration 'x1' definition 'rx1'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:294:74: note: Function 'write' argument 4 names different: declaration 'x1' definition 'rx1'. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:344:75: note: Function 'write' argument 4 names different: declaration 'x1' definition 'rx1'. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:344:87: style:inconclusive: Function 'write' argument 5 names different: declaration 'y1' definition 'ry1'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:294:85: note: Function 'write' argument 5 names different: declaration 'y1' definition 'ry1'. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:344:87: note: Function 'write' argument 5 names different: declaration 'y1' definition 'ry1'. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:1050:37: style:inconclusive: Function 'setCutLevels' argument 1 names different: declaration 'min' definition 'low'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:384:38: note: Function 'setCutLevels' argument 1 names different: declaration 'min' definition 'low'. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:1050:37: note: Function 'setCutLevels' argument 1 names different: declaration 'min' definition 'low'. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:1050:49: style:inconclusive: Function 'setCutLevels' argument 2 names different: declaration 'max' definition 'high'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:384:50: note: Function 'setCutLevels' argument 2 names different: declaration 'max' definition 'high'. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:1050:49: note: Function 'setCutLevels' argument 2 names different: declaration 'max' definition 'high'. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:1548:37: style:inconclusive: Function 'getXline4' argument 2 names different: declaration 'x0' definition 'from'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:369:30: note: Function 'getXline4' argument 2 names different: declaration 'x0' definition 'from'. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:1548:37: note: Function 'getXline4' argument 2 names different: declaration 'x0' definition 'from'. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:1548:47: style:inconclusive: Function 'getXline4' argument 3 names different: declaration 'x1' definition 'to'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:369:38: note: Function 'getXline4' argument 3 names different: declaration 'x1' definition 'to'. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:1548:47: note: Function 'getXline4' argument 3 names different: declaration 'x1' definition 'to'. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:1568:37: style:inconclusive: Function 'getXline4' argument 2 names different: declaration 'x0' definition 'from'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:372:30: note: Function 'getXline4' argument 2 names different: declaration 'x0' definition 'from'. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:1568:37: note: Function 'getXline4' argument 2 names different: declaration 'x0' definition 'from'. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:1568:47: style:inconclusive: Function 'getXline4' argument 3 names different: declaration 'x1' definition 'to'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:372:38: note: Function 'getXline4' argument 3 names different: declaration 'x1' definition 'to'. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:1568:47: note: Function 'getXline4' argument 3 names different: declaration 'x1' definition 'to'. skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:357:9: style: Local variable 'header' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:448:10: note: Shadowed declaration skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:357:9: note: Shadow variable skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:395:9: style: Local variable 'data' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:447:10: note: Shadowed declaration skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:395:9: note: Shadow variable skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:432:16: style: Local variable 'image' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:461:20: note: Shadowed declaration skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:432:16: note: Shadow variable skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:518:16: style: Local variable 'image' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:461:20: note: Shadowed declaration skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:518:16: note: Shadow variable skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:1420:9: style: Local variable 'status' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:444:9: note: Shadowed declaration skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:1420:9: note: Shadow variable skycat-3.1.2-starlink-1b/rtd/generic/LookupTable.C:259:38: style: Expression 'exp(x) - 1' can be replaced by 'expm1(x)' to avoid loss of precision. [unpreciseMathCall] skycat-3.1.2-starlink-1b/rtd/generic/LookupTable.C:269:5: style: Expression 'exp(x) - 1' can be replaced by 'expm1(x)' to avoid loss of precision. [unpreciseMathCall] skycat-3.1.2-starlink-1b/rtd/generic/LookupTable.C:83:27: warning: 'operator=' should check for assignment to self to avoid problems with dynamic memory. [operatorEqToSelf] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.C:546:11: style: Variable 's' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/rtd/generic/LookupTable.C:101:7: warning: Class 'LookupTableRep' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] skycat-3.1.2-starlink-1b/rtd/generic/LookupTable.C:101:7: warning: Class 'LookupTableRep' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] skycat-3.1.2-starlink-1b/rtd/generic/LookupTable.C:216:18: style: The scope of the variable 'imagelim' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/rtd/generic/LookupTable.C:307:18: style: The scope of the variable 'imagelim' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/rtd/generic/LookupTable.C:204:34: style: Parameter 'colors' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/rtd/generic/LookupTable.C:247:38: style: Parameter 'colors' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/rtd/generic/LookupTable.C:300:39: style: Parameter 'colors' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/rtd/generic/ShortImageData.h:40:11: style:inconclusive: Technically the member function 'NativeShortImageData::scaleToShort' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/ShortImageData.C:41:23: note: Technically the member function 'NativeShortImageData::scaleToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/ShortImageData.h:40:11: note: Technically the member function 'NativeShortImageData::scaleToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/UShortImageData.h:37:12: style:inconclusive: Technically the member function 'NativeUShortImageData::convertToUshort' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/UShortImageData.C:41:25: note: Technically the member function 'NativeUShortImageData::convertToUshort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/UShortImageData.h:37:12: note: Technically the member function 'NativeUShortImageData::convertToUshort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:46:11: style:inconclusive: Technically the member function 'NativeLongImageData::convertToShort' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.C:51:22: note: Technically the member function 'NativeLongImageData::convertToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:46:11: note: Technically the member function 'NativeLongImageData::convertToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:47:11: style:inconclusive: Technically the member function 'NativeLongImageData::scaleToShort' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.C:78:22: note: Technically the member function 'NativeLongImageData::scaleToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/LongImageData.h:47:11: note: Technically the member function 'NativeLongImageData::scaleToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/FloatImageData.h:36:11: style:inconclusive: Technically the member function 'NativeFloatImageData::scaleToShort' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/FloatImageData.C:37:23: note: Technically the member function 'NativeFloatImageData::scaleToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/FloatImageData.h:36:11: note: Technically the member function 'NativeFloatImageData::scaleToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.h:36:11: style:inconclusive: Technically the member function 'NativeLongLongImageData::convertToShort' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.C:29:26: note: Technically the member function 'NativeLongLongImageData::convertToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.h:36:11: note: Technically the member function 'NativeLongLongImageData::convertToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.h:37:11: style:inconclusive: Technically the member function 'NativeLongLongImageData::scaleToShort' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.C:56:26: note: Technically the member function 'NativeLongLongImageData::scaleToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/LongLongImageData.h:37:11: note: Technically the member function 'NativeLongLongImageData::scaleToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/DoubleImageData.h:32:11: style:inconclusive: Technically the member function 'NativeDoubleImageData::scaleToShort' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/DoubleImageData.C:31:24: note: Technically the member function 'NativeDoubleImageData::scaleToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/DoubleImageData.h:32:11: note: Technically the member function 'NativeDoubleImageData::scaleToShort' can be const. skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.C:32:12: warning: Member variable 'RtdCamera::buffer_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.h:119:17: style:inconclusive: Member variable 'RtdCamera::interp_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.C:38:5: note: Member variable 'RtdCamera::interp_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.h:119:17: note: Member variable 'RtdCamera::interp_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.h:120:24: style:inconclusive: Member variable 'RtdCamera::eventHndl_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.C:42:5: note: Member variable 'RtdCamera::eventHndl_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.h:120:24: note: Member variable 'RtdCamera::eventHndl_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.h:128:11: style:inconclusive: Member variable 'RtdCamera::semId_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.C:45:37: note: Member variable 'RtdCamera::semId_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.h:128:11: note: Member variable 'RtdCamera::semId_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.h:122:18: style:inconclusive: Member variable 'RtdCamera::dbl_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.C:46:5: note: Member variable 'RtdCamera::dbl_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.h:122:18: note: Member variable 'RtdCamera::dbl_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/RtdUtils.h:35:10: style:inconclusive: Technically the member function 'RtdDebugLog::setlog' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.h:81:11: style:inconclusive: Technically the member function 'RtdCamera::attached' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.C:279:16: note: Technically the member function 'RtdCamera::attached' can be const. skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.h:81:11: note: Technically the member function 'RtdCamera::attached' can be const. skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.h:117:11: performance:inconclusive: Technically the member function 'RtdCamera::checkType' can be static (but you may consider moving to unnamed namespace). [functionStatic] skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.C:311:16: note: Technically the member function 'RtdCamera::checkType' can be static (but you may consider moving to unnamed namespace). skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.h:117:11: note: Technically the member function 'RtdCamera::checkType' can be static (but you may consider moving to unnamed namespace). skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.h:137:11: style:inconclusive: Technically the member function 'RtdCamera::connected' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.C:53:5: warning: Class 'RtdCamera' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.C:53:5: warning: Class 'RtdCamera' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.C:56:28: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.C:76:26: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.C:166:24: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.C:169:24: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdImage.h:178:9: portability: Using memset() on struct which contains a floating point number. [memsetClassFloat] skycat-3.1.2-starlink-1b/rtd/generic/RtdRemote.h:94:9: style:inconclusive: Technically the member function 'RtdRemote::status' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/RtdRemote.h:95:9: style:inconclusive: Technically the member function 'RtdRemote::port' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerf.h:88:11: style:inconclusive: Technically the member function 'RtdPerf::isOn' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerf.h:89:11: style:inconclusive: Technically the member function 'RtdPerf::maybeOn' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerf.h:26:5: style: Class 'RtdPerf' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] skycat-3.1.2-starlink-1b/rtd/generic/RtdImage.h:157:5: style: Class 'RtdImageOptions' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] skycat-3.1.2-starlink-1b/rtd/generic/RtdImage.h:523:5: style: Class 'RtdImageCamera' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] skycat-3.1.2-starlink-1b/rtd/generic/RtdImage.h:533:9: style: The function 'display' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/RtdCamera.h:93:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/RtdImage.h:533:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/RtdImage.h:552:9: style: The function 'call' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/RtdRemote.h:68:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/RtdImage.h:552:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/RtdCoords.C:135:29: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdCoords.C:136:32: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdCoords.C:237:17: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerf.h:55:23: style: Parameter 'nam' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/cat/generic/TclQueryUtil.C:310:27: style: Condition 'q.id(id)' is always false [knownConditionTrueFalse] skycat-3.1.2-starlink-1b/cat/generic/TclQueryUtil.C:310:27: note: Calling function 'id' returns 0 skycat-3.1.2-starlink-1b/cat/generic/TclQueryUtil.C:310:27: note: Condition 'q.id(id)' is always false skycat-3.1.2-starlink-1b/cat/generic/TclQueryUtil.C:136:16: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/TclQueryUtil.C:137:24: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/TclQueryUtil.C:142:23: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/TclQueryUtil.C:175:15: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/TclQueryUtil.C:304:11: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/TclQueryUtil.C:346:26: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/TclQueryUtil.C:353:26: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/TclQueryUtil.C:359:33: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/cat/generic/TclQueryUtil.C:136:11: style: Variable 'id' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/cat/generic/TclQueryUtil.C:137:11: style: Variable 'nameServer' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/rtd/generic/RtdHDU.C:325:29: style: Redundant condition: The condition '*p' is redundant since '*p == ' '' is sufficient. [redundantCondition] skycat-3.1.2-starlink-1b/rtd/generic/RtdHDU.C:332:33: style: Redundant condition: The condition '*t' is redundant since '*t == ' '' is sufficient. [redundantCondition] skycat-3.1.2-starlink-1b/rtd/generic/RtdHDU.C:343:33: style: Redundant condition: The condition '*t' is redundant since '*t == ' '' is sufficient. [redundantCondition] skycat-3.1.2-starlink-1b/rtd/generic/RtdHDU.C:326:31: warning: Either the condition 'p' is redundant or there is possible null pointer dereference: p. [nullPointerRedundantCheck] skycat-3.1.2-starlink-1b/rtd/generic/RtdHDU.C:325:21: note: Assuming that condition 'p' is not redundant skycat-3.1.2-starlink-1b/rtd/generic/RtdHDU.C:326:31: note: Null pointer dereference skycat-3.1.2-starlink-1b/rtd/generic/RtdHDU.C:143:18: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdHDU.C:187:18: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdHDU.C:308:29: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdHDU.C:314:12: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdHDU.C:318:12: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdHDU.C:319:12: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdHDU.C:352:15: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdHDU.C:360:11: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdHDU.C:476:51: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdHDU.C:501:12: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdHDU.C:510:11: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdHDU.C:512:11: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdHDU.C:514:11: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdHDU.C:516:11: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdHDU.C:723:12: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdHDU.C:727:11: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdHDU.C:305:21: style: The scope of the variable 'p' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/rtd/generic/RtdImage.C:129:28: error: There is an unknown macro here somewhere. Configuration is required. If PACKAGE_VERSION is a macro then please configure it. [unknownMacro] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerf.C:67:10: warning: Member variable 'RtdPerf::buffer_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerf.C:86:5: warning: Class 'RtdPerf' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerf.C:86:5: warning: Class 'RtdPerf' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerf.C:85:10: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerf.C:86:28: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:33:21: warning: Member variable 'RtdPerformanceTool::evDescs' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.h:39:9: style:inconclusive: Member variable 'RtdPerformanceTool::verbose_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:35:1: note: Member variable 'RtdPerformanceTool::verbose_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.h:39:9: note: Member variable 'RtdPerformanceTool::verbose_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.h:56:10: performance:inconclusive: Technically the member function 'RtdPerformanceTool::generateSummary' can be static (but you may consider moving to unnamed namespace). [functionStatic] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:216:26: note: Technically the member function 'RtdPerformanceTool::generateSummary' can be static (but you may consider moving to unnamed namespace). skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.h:56:10: note: Technically the member function 'RtdPerformanceTool::generateSummary' can be static (but you may consider moving to unnamed namespace). skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.h:60:11: performance:inconclusive: Technically the member function 'RtdPerformanceTool::getProcTime' can be static (but you may consider moving to unnamed namespace). [functionStatic] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:290:27: note: Technically the member function 'RtdPerformanceTool::getProcTime' can be static (but you may consider moving to unnamed namespace). skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.h:60:11: note: Technically the member function 'RtdPerformanceTool::getProcTime' can be static (but you may consider moving to unnamed namespace). skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.h:82:9: style:inconclusive: Technically the member function 'RtdPerformanceTool::active' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:154:13: warning: Either the condition '(fStr=fopen(RTD_PTEST_FNAME,"w"))==NULL' is redundant or there is possible null pointer dereference: fStr. [nullPointerRedundantCheck] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:146:46: note: Assuming that condition '(fStr=fopen(RTD_PTEST_FNAME,"w"))==NULL' is not redundant skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:154:13: note: Null pointer dereference skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:155:13: warning: Either the condition '(fStr=fopen(RTD_PTEST_FNAME,"w"))==NULL' is redundant or there is possible null pointer dereference: fStr. [nullPointerRedundantCheck] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:146:46: note: Assuming that condition '(fStr=fopen(RTD_PTEST_FNAME,"w"))==NULL' is not redundant skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:155:13: note: Null pointer dereference skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:156:13: warning: Either the condition '(fStr=fopen(RTD_PTEST_FNAME,"w"))==NULL' is redundant or there is possible null pointer dereference: fStr. [nullPointerRedundantCheck] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:146:46: note: Assuming that condition '(fStr=fopen(RTD_PTEST_FNAME,"w"))==NULL' is not redundant skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:156:13: note: Null pointer dereference skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:157:13: warning: Either the condition '(fStr=fopen(RTD_PTEST_FNAME,"w"))==NULL' is redundant or there is possible null pointer dereference: fStr. [nullPointerRedundantCheck] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:146:46: note: Assuming that condition '(fStr=fopen(RTD_PTEST_FNAME,"w"))==NULL' is not redundant skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:157:13: note: Null pointer dereference skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:158:13: warning: Either the condition '(fStr=fopen(RTD_PTEST_FNAME,"w"))==NULL' is redundant or there is possible null pointer dereference: fStr. [nullPointerRedundantCheck] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:146:46: note: Assuming that condition '(fStr=fopen(RTD_PTEST_FNAME,"w"))==NULL' is not redundant skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:158:13: note: Null pointer dereference skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:160:13: warning: Either the condition '(fStr=fopen(RTD_PTEST_FNAME,"w"))==NULL' is redundant or there is possible null pointer dereference: fStr. [nullPointerRedundantCheck] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:146:46: note: Assuming that condition '(fStr=fopen(RTD_PTEST_FNAME,"w"))==NULL' is not redundant skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:160:13: note: Null pointer dereference skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:161:13: warning: Either the condition '(fStr=fopen(RTD_PTEST_FNAME,"w"))==NULL' is redundant or there is possible null pointer dereference: fStr. [nullPointerRedundantCheck] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:146:46: note: Assuming that condition '(fStr=fopen(RTD_PTEST_FNAME,"w"))==NULL' is not redundant skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:161:13: note: Null pointer dereference skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:164:13: warning: Either the condition '(fStr=fopen(RTD_PTEST_FNAME,"w"))==NULL' is redundant or there is possible null pointer dereference: fStr. [nullPointerRedundantCheck] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:146:46: note: Assuming that condition '(fStr=fopen(RTD_PTEST_FNAME,"w"))==NULL' is not redundant skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:164:13: note: Null pointer dereference skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:94:35: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:139:4: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:226:20: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:60:42: style: Parameter 'evDesc' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/rtd/generic/RtdPerformanceTool.C:114:9: style: Unused variable: i [unusedVariable] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.C:266:5: warning:inconclusive: The buffer 'fileName' may not be null-terminated after the call to strncpy(). [terminateStrncpy] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.C:599:5: warning:inconclusive: The buffer 'camera_' may not be null-terminated after the call to strncpy(). [terminateStrncpy] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.h:51:20: style:inconclusive: Member variable 'RtdRPTool::master_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.C:145:5: note: Member variable 'RtdRPTool::master_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.h:51:20: note: Member variable 'RtdRPTool::master_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.h:50:14: style:inconclusive: Member variable 'RtdRPTool::display' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.C:147:5: note: Member variable 'RtdRPTool::display' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.h:50:14: note: Member variable 'RtdRPTool::display' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.h:88:12: style:inconclusive: Member variable 'RtdRecorder::fileSize_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.C:351:5: note: Member variable 'RtdRecorder::fileSize_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.h:88:12: note: Member variable 'RtdRecorder::fileSize_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:109:18: style:inconclusive: Technically the member function 'RtdRPFile::fileSize' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:110:15: style:inconclusive: Technically the member function 'RtdRPFile::imageCounter' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:111:15: style:inconclusive: Technically the member function 'RtdRPFile::imageIndex' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:112:15: style:inconclusive: Technically the member function 'RtdRPFile::status' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:115:15: style:inconclusive: Technically the member function 'RtdRPFile::hasTimeInfo' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:116:15: style:inconclusive: Technically the member function 'RtdRPFile::bytesPerPixel' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:117:15: style:inconclusive: Technically the member function 'RtdRPFile::xPixels' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:118:15: style:inconclusive: Technically the member function 'RtdRPFile::yPixels' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:119:15: style:inconclusive: Technically the member function 'RtdRPFile::dataType' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:120:15: style:inconclusive: Technically the member function 'RtdRPFile::numFileImages' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:121:18: style:inconclusive: Technically the member function 'RtdRPFile::maxFileSize' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:122:15: style:inconclusive: Technically the member function 'RtdRPFile::fileFull' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.C:1171:18: warning: The class 'RtdPlayback' defines member function with name 'close' also defined in its parent class 'RtdRPTool'. [duplInheritedMember] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.C:243:16: note: Parent function 'RtdRPTool::close' skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.C:1171:18: note: Derived function 'RtdPlayback::close' skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:138:9: style: The function 'open' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:67:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:138:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:141:9: style: The function 'getNextImage' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:82:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:141:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:142:9: style: The function 'getPrevImage' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:85:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:142:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:143:9: style: The function 'addImage' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:88:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:143:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:144:10: style: The function 'gotoImageIndex' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:91:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:144:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:152:6: style: The destructor '~RtdFITSCube' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:73:14: note: Virtual destructor in base class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:152:6: note: Destructor in derived class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:166:9: style: The function 'open' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:67:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:166:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:169:9: style: The function 'getNextImage' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:82:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:169:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:170:9: style: The function 'getPrevImage' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:85:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:170:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:171:9: style: The function 'addImage' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:88:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:171:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:172:10: style: The function 'gotoImageIndex' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:91:18: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:172:10: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:179:6: style: The destructor '~RtdFITSComp' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:73:14: note: Virtual destructor in base class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:179:6: note: Destructor in derived class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.h:130:9: style: The function 'call' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.h:69:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.h:130:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.h:197:9: style: The function 'call' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.h:69:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.h:197:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.h:201:9: style: The function 'filename' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.h:74:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.h:201:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:169:9: style: The function 'getNextImage' overrides a function in a base class but is identical to the overridden function [uselessOverride] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:82:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:169:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:170:9: style: The function 'getPrevImage' overrides a function in a base class but is identical to the overridden function [uselessOverride] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:85:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:170:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:171:9: style: The function 'addImage' overrides a function in a base class but is identical to the overridden function [uselessOverride] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:88:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:171:9: note: Function in derived class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.C:377:28: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.C:476:16: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.C:479:16: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.C:793:28: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.C:464:10: style: The scope of the variable 'msg' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.C:1028:9: style: The scope of the variable 'direction' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.C:1029:2: style: The scope of the variable 'count' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.C:1030:2: style: The scope of the variable 'incr' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.C:337:18: style: Variable 'im' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.C:688:18: style: Variable 'im' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.C:337:21: style: Variable 'im' is assigned a value that is never used. [unreadVariable] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.C:688:21: style: Variable 'im' is assigned a value that is never used. [unreadVariable] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.C:380:46: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.C:537:8: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.C:540:13: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.C:545:13: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.C:550:13: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.C:558:12: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.C:562:12: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.C:566:12: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.C:33:12: warning: Member variable 'RtdRPFile::imageCounter__' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.C:33:12: warning: Member variable 'RtdRPFile::dataType_' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.C:33:12: warning: Member variable 'RtdRPFile::numFileImages__' is not initialized in the constructor. [uninitMemberVar] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:42:11: style:inconclusive: Member variable 'RtdRPFile::fPtr' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.C:36:5: note: Member variable 'RtdRPFile::fPtr' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:42:11: note: Member variable 'RtdRPFile::fPtr' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:52:13: style:inconclusive: Member variable 'RtdRPFile::timeStamps_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.C:47:5: note: Member variable 'RtdRPFile::timeStamps_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:52:13: note: Member variable 'RtdRPFile::timeStamps_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:51:9: style:inconclusive: Member variable 'RtdRPFile::hasTimeInfo_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.C:48:5: note: Member variable 'RtdRPFile::hasTimeInfo_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:51:9: note: Member variable 'RtdRPFile::hasTimeInfo_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:59:9: style:inconclusive: Member variable 'RtdRPFile::shmSize_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.C:50:5: note: Member variable 'RtdRPFile::shmSize_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:59:9: note: Member variable 'RtdRPFile::shmSize_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:70:10: performance:inconclusive: Technically the member function 'RtdRPFile::checkSubImage' can be static (but you may consider moving to unnamed namespace). [functionStatic] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.C:119:17: note: Technically the member function 'RtdRPFile::checkSubImage' can be static (but you may consider moving to unnamed namespace). skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:70:10: note: Technically the member function 'RtdRPFile::checkSubImage' can be static (but you may consider moving to unnamed namespace). skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:103:12: style:inconclusive: Technically the member function 'RtdRPFile::getTimeIncrement' can be const. [functionConst] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.C:149:19: note: Technically the member function 'RtdRPFile::getTimeIncrement' can be const. skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:103:12: note: Technically the member function 'RtdRPFile::getTimeIncrement' can be const. skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.C:57:7: warning: Class 'RtdRPFile' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.C:57:7: warning: Class 'RtdRPFile' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.C:927:26: style: Condition 'imageIndex_=startIndex_' is not redundant skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.C:927:26: note: Condition 'imageIndex_length_' is less than zero. [unsignedLessThanZero] skycat-3.1.2-starlink-1b/tclutil/generic/Mem_Map.C:78:10: style:inconclusive: Function 'map_it' argument 2 names different: declaration 'len' definition 'len_request'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/tclutil/generic/Mem_Map.h:206:10: note: Function 'map_it' argument 2 names different: declaration 'len' definition 'len_request'. skycat-3.1.2-starlink-1b/tclutil/generic/Mem_Map.C:78:10: note: Function 'map_it' argument 2 names different: declaration 'len' definition 'len_request'. skycat-3.1.2-starlink-1b/tclutil/generic/Mem_Map.C:232:12: style:inconclusive: Function 'Mem_Map' argument 2 names different: declaration 'length' definition 'len'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/tclutil/generic/Mem_Map.h:76:14: note: Function 'Mem_Map' argument 2 names different: declaration 'length' definition 'len'. skycat-3.1.2-starlink-1b/tclutil/generic/Mem_Map.C:232:12: note: Function 'Mem_Map' argument 2 names different: declaration 'length' definition 'len'. skycat-3.1.2-starlink-1b/tclutil/generic/Mem_Map.C:89:7: style: Local variable 'status' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/tclutil/generic/Mem_Map.h:181:9: note: Shadowed declaration skycat-3.1.2-starlink-1b/tclutil/generic/Mem_Map.C:89:7: note: Shadow variable skycat-3.1.2-starlink-1b/tclutil/generic/ShellCommand.h:31:9: style:inconclusive: Technically the member function 'ShellCommand::status' can be const. [functionConst] skycat-3.1.2-starlink-1b/tclutil/generic/ShellCommand.h:35:17: style:inconclusive: Technically the member function 'ShellCommand::stdOut' can be const. [functionConst] skycat-3.1.2-starlink-1b/tclutil/generic/ShellCommand.h:36:17: style:inconclusive: Technically the member function 'ShellCommand::stdErr' can be const. [functionConst] skycat-3.1.2-starlink-1b/tclutil/generic/ShellCommand.h:26:5: style: Class 'ShellCommand' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] skycat-3.1.2-starlink-1b/tclutil/generic/ShellCommand.C:54:2: error: Memory leak: buf [memleak] skycat-3.1.2-starlink-1b/tclutil/generic/ShellCommand.C:100:9: style: Local variable 'status' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/tclutil/generic/ShellCommand.h:31:9: note: Shadowed declaration skycat-3.1.2-starlink-1b/tclutil/generic/ShellCommand.C:100:9: note: Shadow variable skycat-3.1.2-starlink-1b/tclutil/generic/Tclutil.C:49:31: error: There is an unknown macro here somewhere. Configuration is required. If PACKAGE_VERSION is a macro then please configure it. [unknownMacro] skycat-3.1.2-starlink-1b/tclutil/generic/TclCommand.C:46:5: warning: Class 'TclCommand' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] skycat-3.1.2-starlink-1b/tclutil/generic/TclCommand.C:46:5: warning: Class 'TclCommand' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] skycat-3.1.2-starlink-1b/tclutil/generic/TclCommand.h:82:57: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TclCommand.C:58:42: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TclCommand.C:73:10: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TclCommand.C:115:26: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TclCommand.C:139:26: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TclCommand.C:214:28: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TclCommand.C:234:31: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TclCommand.C:297:32: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TclCommand.C:312:28: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TclCommand.C:336:32: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TkWidget.C:49:3: warning: Class 'TkWidget' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] skycat-3.1.2-starlink-1b/tclutil/generic/TkWidget.C:49:3: warning: Class 'TkWidget' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] skycat-3.1.2-starlink-1b/tclutil/generic/TkWidget.h:73:14: style: The destructor '~TkWidget' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/tclutil/generic/TclCommand.h:95:14: note: Virtual destructor in base class skycat-3.1.2-starlink-1b/tclutil/generic/TkWidget.h:73:14: note: Destructor in derived class skycat-3.1.2-starlink-1b/tclutil/generic/TkWidget.h:76:17: style: The function 'call' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/tclutil/generic/TclCommand.h:59:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/tclutil/generic/TkWidget.h:76:17: note: Function in derived class skycat-3.1.2-starlink-1b/tclutil/generic/TkWidget.C:102:37: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TkWidget.C:112:25: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TkWidget.C:147:25: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TkWidget.C:183:19: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TkWidget.C:199:5: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TkWidget.C:202:5: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TkWidget.C:229:25: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TkWidget.C:252:9: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.h:44:20: style:inconclusive: Member variable 'TkImage::master_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.C:66:3: note: Member variable 'TkImage::master_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.h:44:20: note: Member variable 'TkImage::master_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.h:48:9: style:inconclusive: Member variable 'TkImage::refCount_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.C:78:3: note: Member variable 'TkImage::refCount_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.h:48:9: note: Member variable 'TkImage::refCount_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.h:67:9: style:inconclusive: Member variable 'TkImage::update_pending_' is in the wrong place in the initializer list. [initializerList] skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.C:81:3: note: Member variable 'TkImage::update_pending_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.h:67:9: note: Member variable 'TkImage::update_pending_' is in the wrong place in the initializer list. skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.h:99:17: style: The function 'call' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/tclutil/generic/TclCommand.h:59:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.h:99:17: note: Function in derived class skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.h:109:14: style: The destructor '~TkImage' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/tclutil/generic/TclCommand.h:95:14: note: Virtual destructor in base class skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.h:109:14: note: Destructor in derived class skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.h:128:17: style: The function 'deleteCmd' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/tclutil/generic/TclCommand.h:98:17: note: Virtual function in base class skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.h:128:17: note: Function in derived class skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.h:131:51: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.C:100:37: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.C:177:24: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.C:236:24: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.C:272:24: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.C:327:6: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.C:341:60: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.C:344:60: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.C:360:64: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.C:247:57: style: Parameter 'display' can be declared as pointer to const [constParameterPointer] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:676:9: warning:inconclusive: The buffer 'args' may not be null-terminated after the call to strncpy(). [terminateStrncpy] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:680:9: warning:inconclusive: The buffer 'hostname_' may not be null-terminated after the call to strncpy(). [terminateStrncpy] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:712:5: warning:inconclusive: The buffer 'req' may not be null-terminated after the call to strncpy(). [terminateStrncpy] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:906:9: warning:inconclusive: The buffer 'args' may not be null-terminated after the call to strncpy(). [terminateStrncpy] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:910:9: warning:inconclusive: The buffer 'hostname_' may not be null-terminated after the call to strncpy(). [terminateStrncpy] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:216:22: style: Obsolescent function 'gethostbyname' called. It is recommended to use 'getaddrinfo' instead. [prohibitedgethostbynameCalled] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:1135:35: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.h:153:17: style:inconclusive: Technically the member function 'HTTP::result' can be const. [functionConst] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.h:176:9: style:inconclusive: Technically the member function 'HTTP::authorizationRequired' can be const. [functionConst] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.h:186:9: performance:inconclusive: Technically the member function 'HTTP::html_error' can be static (but you may consider moving to unnamed namespace). [functionStatic] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:144:11: note: Technically the member function 'HTTP::html_error' can be static (but you may consider moving to unnamed namespace). skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.h:186:9: note: Technically the member function 'HTTP::html_error' can be static (but you may consider moving to unnamed namespace). skycat-3.1.2-starlink-1b/tclutil/generic/error.C:78:11: style: Variable 's' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:656:9: warning:inconclusive: Width 1000 given in format string (no. 3) is smaller than destination buffer 'args[1024]'. [invalidScanfFormatWidth_smaller] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:657:2: warning:inconclusive: Width 1000 given in format string (no. 2) is smaller than destination buffer 'args[1024]'. [invalidScanfFormatWidth_smaller] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:886:9: warning:inconclusive: Width 1000 given in format string (no. 3) is smaller than destination buffer 'args[1024]'. [invalidScanfFormatWidth_smaller] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:887:2: warning:inconclusive: Width 1000 given in format string (no. 2) is smaller than destination buffer 'args[1024]'. [invalidScanfFormatWidth_smaller] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:291:5: error: Return value of allocation function 'mkstemp' is not stored. [leakReturnValNotUsed] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:207:9: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:235:22: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:1037:12: style: The scope of the variable 'rc' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:1069:16: style: The scope of the variable 'nwritten' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:452:34: style:inconclusive: Function 'authorize' argument 1 names different: declaration 'user' definition 'username'. [funcArgNamesDifferent] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.h:180:39: note: Function 'authorize' argument 1 names different: declaration 'user' definition 'username'. skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:452:34: note: Function 'authorize' argument 1 names different: declaration 'user' definition 'username'. skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:307:9: style: Local variable 'status' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.h:118:9: note: Shadowed declaration skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:307:9: note: Shadow variable skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:742:6: style: Local variable 'status' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.h:118:9: note: Shadowed declaration skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:742:6: note: Shadow variable skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:950:6: style: Local variable 'status' shadows outer function [shadowFunction] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.h:118:9: note: Shadowed declaration skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:950:6: note: Shadow variable skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:216:15: style: Variable 'host' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:484:8: style: Variable 'home' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:563:12: style: Variable 'new_auth_info' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:1109:11: style: Variable 'proxy' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:1125:19: style: Variable 'ptr' can be declared as pointer to const [constVariablePointer] skycat-3.1.2-starlink-1b/tclutil/generic/HTTP.C:487:9: error: Uninitialized variable: filename [legacyUninitvar] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:17:51: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:20:53: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:23:49: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:26:50: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:29:50: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:32:50: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:35:50: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:38:53: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:41:50: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:44:47: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:47:51: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:50:48: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:53:49: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:56:51: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:59:53: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:62:49: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:65:52: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:68:48: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:71:48: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:74:48: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:77:48: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:80:48: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:83:48: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:86:48: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:89:48: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:92:48: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:95:48: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:98:48: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:101:50: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:104:53: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:107:52: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:110:51: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:113:48: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:116:46: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:119:46: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:122:46: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:125:50: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:128:50: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:131:48: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:134:51: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:137:49: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:140:49: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:143:49: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:146:49: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:149:49: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:152:49: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:155:47: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:158:48: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:161:53: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:164:50: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:167:48: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:170:53: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:173:49: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:176:49: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:179:52: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:182:52: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:185:53: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:188:54: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:191:55: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:194:46: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:197:50: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:200:50: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:203:50: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:206:54: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:209:52: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:212:47: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:215:48: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:218:50: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:221:53: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:224:53: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:227:54: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:230:48: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:233:55: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:236:48: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/tclutil_bitmaps.C:239:55: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/tests/tHTTP.C:56:1: error: syntax error [syntaxError] skycat-3.1.2-starlink-1b/tclutil/tests/tShellCommand.C:43:1: error: syntax error [syntaxError] skycat-3.1.2-starlink-1b/tclutil/tests/tMem.C:64:1: error: syntax error [syntaxError] skycat-3.1.2-starlink-1b/tclutil/generic/util.C:287:10: style: Obsolescent function 'gethostbyname' called. It is recommended to use 'getaddrinfo' instead. [prohibitedgethostbynameCalled] skycat-3.1.2-starlink-1b/tclutil/generic/base64.C:55:34: style: Condition 'encode_base64_(pSrc,pDest)==0' is always false [knownConditionTrueFalse] skycat-3.1.2-starlink-1b/tclutil/generic/base64.C:55:20: note: Calling function 'encode_base64_' returns 1 skycat-3.1.2-starlink-1b/tclutil/generic/base64.C:55:34: note: Condition 'encode_base64_(pSrc,pDest)==0' is always false skycat-3.1.2-starlink-1b/tclutil/generic/util.C:56:10: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/util.C:88:13: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/util.C:91:9: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/util.C:260:29: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/util.C:281:13: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/util.C:291:30: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/base64.C:48:14: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/util.C:300:24: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/util.C:325:12: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/util.C:337:21: style: C-style pointer casting [cstyleCast] skycat-3.1.2-starlink-1b/tclutil/generic/util.C:172:20: style: The scope of the variable 'nread' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/tclutil/generic/util.C:202:13: style: The scope of the variable 'rc' can be reduced. [variableScope] skycat-3.1.2-starlink-1b/tclutil/generic/util.C:237:20: style: The scope of the variable 'nwritten' can be reduced. [variableScope] diff: head skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:124:6: style: The destructor '~FitsIO' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/ImageIO.h:98:14: note: Virtual destructor in base class skycat-3.1.2-starlink-1b/astrotcl/generic/Fits_IO.h:124:6: note: Destructor in derived class head skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:61:14: style: The destructor '~SAOWCS' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/astrotcl/generic/WCSRep.h:42:14: note: Virtual destructor in base class skycat-3.1.2-starlink-1b/astrotcl/generic/SAOWCS.h:61:14: note: Destructor in derived class head skycat-3.1.2-starlink-1b/astrotcl/press/gzip_inflate.c:309:8: style: Parameter 'e' can be declared as pointer to const [constParameterPointer] head skycat-3.1.2-starlink-1b/cat/generic/AstroCatalog.C:472:3: style: C-style reference casting [cstyleCast] head skycat-3.1.2-starlink-1b/cat/generic/LocalCatalog.h:59:6: style: The destructor '~LocalCatalog' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/AstroCatalog.h:71:14: note: Virtual destructor in base class skycat-3.1.2-starlink-1b/cat/generic/LocalCatalog.h:59:6: note: Destructor in derived class head skycat-3.1.2-starlink-1b/cat/generic/QueryResult.h:69:14: style: The destructor '~QueryResult' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/TabTable.h:123:14: note: Virtual destructor in base class skycat-3.1.2-starlink-1b/cat/generic/QueryResult.h:69:14: note: Destructor in derived class head skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.h:71:14: style: The destructor '~TcsCatalog' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/AstroCatalog.h:71:14: note: Virtual destructor in base class skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.h:71:14: note: Destructor in derived class head skycat-3.1.2-starlink-1b/cat/generic/TcsCatalogObject.C:131:37: warning: 'operator=' should check for assignment to self to avoid problems with dynamic memory. [operatorEqToSelf] head skycat-3.1.2-starlink-1b/cat/generic/TcsLocalCatalog.h:42:6: style: The destructor '~TcsLocalCatalog' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/TcsCatalog.h:71:14: note: Virtual destructor in base class skycat-3.1.2-starlink-1b/cat/generic/TcsLocalCatalog.h:42:6: note: Destructor in derived class head skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:78:14: style: The destructor '~TcsQueryResult' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/cat/generic/QueryResult.h:69:14: note: Virtual destructor in base class skycat-3.1.2-starlink-1b/cat/generic/TcsQueryResult.h:78:14: note: Destructor in derived class 2.13.0 skycat-3.1.2-starlink-1b/cat/generic/astro_catalog.C:67:9: style: C-style pointer casting [cstyleCast] 2.13.0 skycat-3.1.2-starlink-1b/cat/generic/astro_image.C:55:9: style: C-style pointer casting [cstyleCast] head skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:71:6: style: The destructor '~CompoundImageData' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/ImageData.h:284:14: note: Virtual destructor in base class skycat-3.1.2-starlink-1b/rtd/generic/CompoundImageData.h:71:6: note: Destructor in derived class head skycat-3.1.2-starlink-1b/rtd/generic/RtdCmds.C:453:10: style: The scope of the variable 'buf' can be reduced. [variableScope] head skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.C:725:22: style: Variable 'pu' can be declared as pointer to const [constVariablePointer] head skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.C:761:19: style: Variable 'pu' can be declared as pointer to const [constVariablePointer] head skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:152:6: style: The destructor '~RtdFITSCube' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:73:14: note: Virtual destructor in base class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:152:6: note: Destructor in derived class head skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:179:6: style: The destructor '~RtdFITSComp' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:73:14: note: Virtual destructor in base class skycat-3.1.2-starlink-1b/rtd/generic/RtdRPFile.h:179:6: note: Destructor in derived class head skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.C:1028:9: style: The scope of the variable 'direction' can be reduced. [variableScope] head skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.C:1029:2: style: The scope of the variable 'count' can be reduced. [variableScope] head skycat-3.1.2-starlink-1b/rtd/generic/RtdRPTool.C:1030:2: style: The scope of the variable 'incr' can be reduced. [variableScope] head skycat-3.1.2-starlink-1b/rtd/generic/RtdRemote.C:486:36: style: C-style pointer casting [cstyleCast] head skycat-3.1.2-starlink-1b/rtd/tests/tRtdEvtData.C:126:68: style: Parameter 'shm' can be declared as pointer to const [constParameterPointer] head skycat-3.1.2-starlink-1b/tclutil/generic/Mem.C:378:0: error: Mismatching allocation and deallocation: MemRep::ptr [mismatchAllocDealloc] head skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.C:247:57: style: Parameter 'display' can be declared as pointer to const [constParameterPointer] head skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.h:109:14: style: The destructor '~TkImage' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/tclutil/generic/TclCommand.h:95:14: note: Virtual destructor in base class skycat-3.1.2-starlink-1b/tclutil/generic/TkImage.h:109:14: note: Destructor in derived class head skycat-3.1.2-starlink-1b/tclutil/generic/TkWidget.h:73:14: style: The destructor '~TkWidget' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] skycat-3.1.2-starlink-1b/tclutil/generic/TclCommand.h:95:14: note: Virtual destructor in base class skycat-3.1.2-starlink-1b/tclutil/generic/TkWidget.h:73:14: note: Destructor in derived class DONE