2024-04-22 04:18 ftp://ftp.de.debian.org/debian/pool/main/s/sioyek/sioyek_2.0.0+dfsg.orig.tar.xz cppcheck-options: --library=posix --library=gnu --library=bsd --library=sqlite3 --library=qt --inconclusive --enable=style,information --inline-suppr --template=daca2 --disable=missingInclude --suppress=unmatchedSuppression --check-library --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning -D__GNUC__ --platform=unix64 -j4 platform: Linux-6.1.0-20-amd64-x86_64-with-glibc2.36 python: 3.11.2 client-version: 1.3.56 compiler: g++ (Debian 12.2.0-14) 12.2.0 cppcheck: head 2.14.0 head-info: ea2e716 (2024-04-21 15:59:20 +0200) count: 591 591 elapsed-time: 4.0 4.1 head-timing-info: old-timing-info: head results: sioyek-2.0.0/pdf_viewer/OpenWithApplication.cpp:4:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FileOpen [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/RunGuard.cpp:14:67: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Sha1 [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/RunGuard.cpp:57:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UserAccessOption [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/RunGuard.cpp:113:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WriteOnly [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/checksum.cpp:11:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/checksum.cpp:54:100: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Md5 [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/RunGuard.cpp:38:10: style: Local variable 'isPrimary' shadows outer function [shadowFunction] sioyek-2.0.0/pdf_viewer/RunGuard.h:60:10: note: Shadowed declaration sioyek-2.0.0/pdf_viewer/RunGuard.cpp:38:10: note: Shadow variable sioyek-2.0.0/pdf_viewer/checksum.h:18:2: style: Class 'CachedChecksummer' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] sioyek-2.0.0/pdf_viewer/checksum.cpp:62:69: performance: Function parameter 'checksum' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/checksum.cpp:66:66: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/coordinates.h:68:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable dim [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/coordinates.h:108:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable dim [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/coordinates.h:117:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable dim [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/coordinates.h:126:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable dim [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/coordinates.h:81:4: style:inconclusive: Technically the member function 'Vec::x' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/coordinates.h:85:4: style:inconclusive: Technically the member function 'Vec::y' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/coordinates.h:89:4: style:inconclusive: Technically the member function 'Vec::width' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/coordinates.h:93:4: style:inconclusive: Technically the member function 'Vec::height' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/coordinates.h:38:2: style: Struct 'Vec' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] sioyek-2.0.0/pdf_viewer/coordinates.h:43:2: style: Struct 'Vec' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] sioyek-2.0.0/pdf_viewer/coordinates.h:48:2: style: Struct 'Vec' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] sioyek-2.0.0/pdf_viewer/coordinates.h:53:2: style: Struct 'Vec' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] sioyek-2.0.0/pdf_viewer/coordinates.h:63:2: style: Struct 'Vec' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] sioyek-2.0.0/pdf_viewer/book.cpp:4:36: style: Parameter 'lhs' can be declared as reference to const [constParameterReference] sioyek-2.0.0/pdf_viewer/utf8/unchecked.h:137:67: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SURROGATE_OFFSET [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/utf8/unchecked.h:150:80: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LEAD_OFFSET [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/config.cpp:147:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable N [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/config.cpp:159:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable N [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/config.cpp:180:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable N [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/config.cpp:212:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable wcout [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/config.cpp:226:65: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/config.cpp:272:65: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/config.cpp:313:100: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable bool_validator [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/config.cpp:445:8: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable wcout [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/database.cpp:38:8: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/database.cpp:53:8: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/database.cpp:277:8: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/database.cpp:290:8: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/database.cpp:1057:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WriteOnly [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/database.cpp:1083:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/document.cpp:529:8: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/ui.h:315:61: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Stretch [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/document.cpp:564:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/ui.h:376:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AlignVCenter [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/document.cpp:614:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable wcerr [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/ui.h:518:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AlignVCenter [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/document.cpp:687:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable wcout [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/ui.h:576:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SingleSelection [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/document.cpp:783:8: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/document_view.cpp:135:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable src_offset_y [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/document.cpp:860:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable second [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/document_view.cpp:662:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom_level [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/document.cpp:1010:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable wcout [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/document_view.cpp:924:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable y1 [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/document.cpp:1148:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable second [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/document_view.cpp:1057:55: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable y0 [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/document.cpp:1348:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable second [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/document_view.cpp:1124:65: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable uri [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/document.cpp:1547:68: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PDF_ANNOT_HIGHLIGHT [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/ui.h:74:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CaseInsensitive [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/document.cpp:2135:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FZ_STEXT_BLOCK_TEXT [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/ui.h:166:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KeyPress [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/document.cpp:2279:53: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable icase [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/ui.h:247:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Key_Delete [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/database.h:12:1: style: The class 'DatabaseManager' does not declare a constructor although it has private member variables which likely require initialization. [noConstructor] sioyek-2.0.0/pdf_viewer/coordinates.h:81:4: style:inconclusive: Technically the member function 'Vec < float , 2 >::x' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/coordinates.h:85:4: style:inconclusive: Technically the member function 'Vec < float , 2 >::y' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/coordinates.h:89:4: style:inconclusive: Technically the member function 'Vec < float , 2 >::width' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/coordinates.h:93:4: style:inconclusive: Technically the member function 'Vec < float , 2 >::height' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/utf8/checked.h:44:9: style: Class 'invalid_code_point' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] sioyek-2.0.0/pdf_viewer/utf8/checked.h:52:9: style: Class 'invalid_utf8' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] sioyek-2.0.0/pdf_viewer/utf8/checked.h:60:9: style: Class 'invalid_utf16' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] sioyek-2.0.0/pdf_viewer/coordinates.h:38:2: style: Struct 'Vec < float , 2 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] sioyek-2.0.0/pdf_viewer/coordinates.h:43:2: style: Struct 'Vec < float , 2 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] sioyek-2.0.0/pdf_viewer/coordinates.h:48:2: style: Struct 'Vec < float , 2 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] sioyek-2.0.0/pdf_viewer/coordinates.h:53:2: style: Struct 'Vec < float , 2 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] sioyek-2.0.0/pdf_viewer/coordinates.h:63:2: style: Struct 'Vec < float , 2 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] sioyek-2.0.0/pdf_viewer/database.cpp:291:3: error: Resource leak: local_db [resourceLeak] sioyek-2.0.0/pdf_viewer/database.cpp:302:4: error: Resource leak: local_db [resourceLeak] sioyek-2.0.0/pdf_viewer/database.cpp:303:4: error: Resource leak: global_db [resourceLeak] sioyek-2.0.0/pdf_viewer/database.cpp:311:2: error: Resource leak: local_db [resourceLeak] sioyek-2.0.0/pdf_viewer/database.cpp:35:38: style: C-style pointer casting [cstyleCast] sioyek-2.0.0/pdf_viewer/database.cpp:50:35: style: C-style pointer casting [cstyleCast] sioyek-2.0.0/pdf_viewer/database.cpp:62:27: style: C-style pointer casting [cstyleCast] sioyek-2.0.0/pdf_viewer/database.cpp:74:52: style: C-style pointer casting [cstyleCast] sioyek-2.0.0/pdf_viewer/database.cpp:87:55: style: C-style pointer casting [cstyleCast] sioyek-2.0.0/pdf_viewer/database.cpp:103:56: style: C-style pointer casting [cstyleCast] sioyek-2.0.0/pdf_viewer/database.cpp:128:31: style: C-style pointer casting [cstyleCast] sioyek-2.0.0/pdf_viewer/database.cpp:140:35: style: C-style pointer casting [cstyleCast] sioyek-2.0.0/pdf_viewer/database.cpp:151:34: style: C-style pointer casting [cstyleCast] sioyek-2.0.0/pdf_viewer/database.cpp:162:60: style: C-style pointer casting [cstyleCast] sioyek-2.0.0/pdf_viewer/database.cpp:174:32: style: C-style pointer casting [cstyleCast] sioyek-2.0.0/pdf_viewer/database.cpp:196:29: style: C-style pointer casting [cstyleCast] sioyek-2.0.0/pdf_viewer/database.cpp:457:54: style:inconclusive: Function 'insert_mark' argument 1 names different: declaration 'checksum' definition 'document_path'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/database.h:26:38: note: Function 'insert_mark' argument 1 names different: declaration 'checksum' definition 'document_path'. sioyek-2.0.0/pdf_viewer/database.cpp:457:54: note: Function 'insert_mark' argument 1 names different: declaration 'checksum' definition 'document_path'. sioyek-2.0.0/pdf_viewer/config.cpp:287:2: performance: Variable 'user_config_paths' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] sioyek-2.0.0/pdf_viewer/database.cpp:482:58: style:inconclusive: Function 'insert_bookmark' argument 1 names different: declaration 'checksum' definition 'document_path'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/database.h:30:42: note: Function 'insert_bookmark' argument 1 names different: declaration 'checksum' definition 'document_path'. sioyek-2.0.0/pdf_viewer/database.cpp:482:58: note: Function 'insert_bookmark' argument 1 names different: declaration 'checksum' definition 'document_path'. sioyek-2.0.0/pdf_viewer/database.cpp:494:59: style:inconclusive: Function 'insert_highlight' argument 1 names different: declaration 'checksum' definition 'document_path'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/database.h:46:43: note: Function 'insert_highlight' argument 1 names different: declaration 'checksum' definition 'document_path'. sioyek-2.0.0/pdf_viewer/database.cpp:494:59: note: Function 'insert_highlight' argument 1 names different: declaration 'checksum' definition 'document_path'. sioyek-2.0.0/pdf_viewer/database.cpp:517:56: warning: Function 'insert_portal' argument order different: declaration 'src_checksum, dst_checksum, dst_offset_y, dst_offset_x, dst_zoom_level, src_offset_y' definition 'src_document_path, dst_document_path, dst_offset_x, dst_offset_y, dst_zoom_level, src_offset_y' [funcArgOrderDifferent] sioyek-2.0.0/pdf_viewer/database.h:32:40: note: Function 'insert_portal' argument order different: declaration 'src_checksum, dst_checksum, dst_offset_y, dst_offset_x, dst_zoom_level, src_offset_y' definition 'src_document_path, dst_document_path, dst_offset_x, dst_offset_y, dst_zoom_level, src_offset_y' sioyek-2.0.0/pdf_viewer/database.cpp:517:56: note: Function 'insert_portal' argument order different: declaration 'src_checksum, dst_checksum, dst_offset_y, dst_offset_x, dst_zoom_level, src_offset_y' definition 'src_document_path, dst_document_path, dst_offset_x, dst_offset_y, dst_zoom_level, src_offset_y' sioyek-2.0.0/pdf_viewer/database.cpp:530:56: style:inconclusive: Function 'update_portal' argument 1 names different: declaration 'checksum' definition 'src_document_path'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/database.h:38:40: note: Function 'update_portal' argument 1 names different: declaration 'checksum' definition 'src_document_path'. sioyek-2.0.0/pdf_viewer/database.cpp:530:56: note: Function 'update_portal' argument 1 names different: declaration 'checksum' definition 'src_document_path'. sioyek-2.0.0/pdf_viewer/config.h:54:22: style:inconclusive: Technically the member function 'ConfigManager::get_configs' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/config.cpp:563:36: note: Technically the member function 'ConfigManager::get_configs' can be const. sioyek-2.0.0/pdf_viewer/config.h:54:22: note: Technically the member function 'ConfigManager::get_configs' can be const. sioyek-2.0.0/pdf_viewer/database.cpp:544:54: style:inconclusive: Function 'delete_link' argument 1 names different: declaration 'src_checksum' definition 'src_document_path'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/database.h:34:38: note: Function 'delete_link' argument 1 names different: declaration 'src_checksum' definition 'src_document_path'. sioyek-2.0.0/pdf_viewer/database.cpp:544:54: note: Function 'delete_link' argument 1 names different: declaration 'src_checksum' definition 'src_document_path'. sioyek-2.0.0/pdf_viewer/database.cpp:556:58: style:inconclusive: Function 'delete_bookmark' argument 1 names different: declaration 'src_checksum' definition 'src_document_path'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/database.h:35:42: note: Function 'delete_bookmark' argument 1 names different: declaration 'src_checksum' definition 'src_document_path'. sioyek-2.0.0/pdf_viewer/database.cpp:556:58: note: Function 'delete_bookmark' argument 1 names different: declaration 'src_checksum' definition 'src_document_path'. sioyek-2.0.0/pdf_viewer/database.cpp:568:59: style:inconclusive: Function 'delete_highlight' argument 1 names different: declaration 'checksum' definition 'src_document_path'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/database.h:43:43: note: Function 'delete_highlight' argument 1 names different: declaration 'checksum' definition 'src_document_path'. sioyek-2.0.0/pdf_viewer/database.cpp:568:59: note: Function 'delete_highlight' argument 1 names different: declaration 'checksum' definition 'src_document_path'. sioyek-2.0.0/pdf_viewer/database.cpp:584:54: style:inconclusive: Function 'update_mark' argument 1 names different: declaration 'checksum' definition 'document_path'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/database.h:27:38: note: Function 'update_mark' argument 1 names different: declaration 'checksum' definition 'document_path'. sioyek-2.0.0/pdf_viewer/database.cpp:584:54: note: Function 'update_mark' argument 1 names different: declaration 'checksum' definition 'document_path'. sioyek-2.0.0/pdf_viewer/database.cpp:661:54: style:inconclusive: Function 'select_mark' argument 1 names different: declaration 'checksum' definition 'book_path'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/database.h:29:38: note: Function 'select_mark' argument 1 names different: declaration 'checksum' definition 'book_path'. sioyek-2.0.0/pdf_viewer/database.cpp:661:54: note: Function 'select_mark' argument 1 names different: declaration 'checksum' definition 'book_path'. sioyek-2.0.0/pdf_viewer/database.cpp:683:58: style:inconclusive: Function 'select_bookmark' argument 1 names different: declaration 'checksum' definition 'book_path'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/database.h:31:42: note: Function 'select_bookmark' argument 1 names different: declaration 'checksum' definition 'book_path'. sioyek-2.0.0/pdf_viewer/database.cpp:683:58: note: Function 'select_bookmark' argument 1 names different: declaration 'checksum' definition 'book_path'. sioyek-2.0.0/pdf_viewer/database.cpp:727:59: style:inconclusive: Function 'select_highlight' argument 1 names different: declaration 'checksum' definition 'book_path'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/database.h:44:43: note: Function 'select_highlight' argument 1 names different: declaration 'checksum' definition 'book_path'. sioyek-2.0.0/pdf_viewer/database.cpp:727:59: note: Function 'select_highlight' argument 1 names different: declaration 'checksum' definition 'book_path'. sioyek-2.0.0/pdf_viewer/database.cpp:738:69: style:inconclusive: Function 'select_highlight_with_type' argument 1 names different: declaration 'checksum' definition 'book_path'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/database.h:45:53: note: Function 'select_highlight_with_type' argument 1 names different: declaration 'checksum' definition 'book_path'. sioyek-2.0.0/pdf_viewer/database.cpp:738:69: note: Function 'select_highlight_with_type' argument 1 names different: declaration 'checksum' definition 'book_path'. sioyek-2.0.0/pdf_viewer/database.cpp:771:55: style:inconclusive: Function 'select_links' argument 1 names different: declaration 'src_checksum' definition 'src_document_path'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/database.h:33:39: note: Function 'select_links' argument 1 names different: declaration 'src_checksum' definition 'src_document_path'. sioyek-2.0.0/pdf_viewer/database.cpp:771:55: note: Function 'select_links' argument 1 names different: declaration 'src_checksum' definition 'src_document_path'. sioyek-2.0.0/pdf_viewer/path.h:13:2: style: Class 'Path' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] sioyek-2.0.0/pdf_viewer/config.h:54:22: performance: Function 'get_configs()' should return member 'configs' by const reference. [returnByReference] sioyek-2.0.0/pdf_viewer/utils.h:93:86: performance: Function parameter 'flat_chars' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/utils.h:150:59: performance: Function parameter 'sorted_list' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/utils.h:195:56: performance: Function parameter 'chars' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/database.cpp:966:40: performance: Function parameter 'objects' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/database.cpp:991:48: performance: Function parameter 'json_file_path' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/database.cpp:1080:48: performance: Function parameter 'json_file_path' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/database.cpp:1157:45: performance: Function parameter 'table_name' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/database.cpp:1158:27: performance: Function parameter 'selections' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/database.cpp:1159:92: performance: Function parameter 'values' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/config.cpp:504:14: style: Condition 'conf!=nullptr' is always true [knownConditionTrueFalse] sioyek-2.0.0/pdf_viewer/config.cpp:511:8: style: Condition 'conf' is always true [knownConditionTrueFalse] sioyek-2.0.0/pdf_viewer/database.cpp:30:32: style: Parameter 'notused' can be declared as pointer to const. However it seems that 'null_callback' is a callback function, if 'notused' is declared with const you might also need to cast function pointer(s). [constParameterCallback] sioyek-2.0.0/pdf_viewer/database.cpp:801:67: note: You might need to cast the function pointer here sioyek-2.0.0/pdf_viewer/database.cpp:30:32: note: Parameter 'notused' can be declared as pointer to const sioyek-2.0.0/pdf_viewer/config.cpp:119:13: style: C-style pointer casting [cstyleCast] sioyek-2.0.0/pdf_viewer/config.cpp:123:13: style: C-style pointer casting [cstyleCast] sioyek-2.0.0/pdf_viewer/config.cpp:127:13: style: C-style pointer casting [cstyleCast] sioyek-2.0.0/pdf_viewer/config.cpp:148:16: style: C-style pointer casting [cstyleCast] sioyek-2.0.0/pdf_viewer/database.cpp:890:10: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/config.cpp:155:11: style: C-style pointer casting [cstyleCast] sioyek-2.0.0/pdf_viewer/database.cpp:895:14: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/config.cpp:170:15: style: C-style pointer casting [cstyleCast] sioyek-2.0.0/pdf_viewer/database.cpp:900:15: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/config.cpp:192:13: style: C-style pointer casting [cstyleCast] sioyek-2.0.0/pdf_viewer/database.cpp:1068:31: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/config.h:43:35: performance: Function parameter 'name' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/config.cpp:200:62: performance: Function parameter 'config_name' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/config.cpp:567:52: performance: Function parameter 'config_name' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/config.cpp:202:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/database.cpp:836:27: style: Variable 'uchecksum' is assigned a value that is never used. [unreadVariable] sioyek-2.0.0/pdf_viewer/input.cpp:216:8: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable wcout [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/input.cpp:274:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Key_F1 [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/input.cpp:369:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable wcout [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/input.cpp:522:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Key_9 [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/input.cpp:549:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Key_Backtab [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/input.cpp:680:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Key_Up [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main.cpp:359:76: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AppDataLocation [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main.cpp:397:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable wcout [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main.cpp:410:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable wcout [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main.cpp:502:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable wcout [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main.cpp:657:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WindowMinimized [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main.cpp:663:8: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/document_view.cpp:350:2: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] sioyek-2.0.0/pdf_viewer/ui.h:364:3: performance: Variable 'item_strings' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] sioyek-2.0.0/pdf_viewer/ui.h:571:3: performance: Variable 'string_elements' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] sioyek-2.0.0/pdf_viewer/ui.h:62:3: warning:inconclusive: Class 'ConfigFileChangeListener' which has virtual members does not have a virtual destructor. [virtualDestructor] sioyek-2.0.0/pdf_viewer/document_view.h:61:8: style:inconclusive: Technically the member function 'DocumentView::get_zoom_level' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document_view.cpp:51:21: note: Technically the member function 'DocumentView::get_zoom_level' can be const. sioyek-2.0.0/pdf_viewer/document_view.h:61:8: note: Technically the member function 'DocumentView::get_zoom_level' can be const. sioyek-2.0.0/pdf_viewer/document_view.h:65:7: performance:inconclusive: Technically the member function 'DocumentView::handle_escape' can be static (but you may consider moving to unnamed namespace). [functionStatic] sioyek-2.0.0/pdf_viewer/document_view.cpp:85:20: note: Technically the member function 'DocumentView::handle_escape' can be static (but you may consider moving to unnamed namespace). sioyek-2.0.0/pdf_viewer/document_view.h:65:7: note: Technically the member function 'DocumentView::handle_escape' can be static (but you may consider moving to unnamed namespace). sioyek-2.0.0/pdf_viewer/document_view.h:74:12: style:inconclusive: Technically the member function 'DocumentView::get_highlight_with_index' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document_view.cpp:186:25: note: Technically the member function 'DocumentView::get_highlight_with_index' can be const. sioyek-2.0.0/pdf_viewer/document_view.h:74:12: note: Technically the member function 'DocumentView::get_highlight_with_index' can be const. sioyek-2.0.0/pdf_viewer/document_view.h:78:8: style:inconclusive: Technically the member function 'DocumentView::get_offset_x' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document_view.cpp:202:21: note: Technically the member function 'DocumentView::get_offset_x' can be const. sioyek-2.0.0/pdf_viewer/document_view.h:78:8: note: Technically the member function 'DocumentView::get_offset_x' can be const. sioyek-2.0.0/pdf_viewer/document_view.h:79:8: style:inconclusive: Technically the member function 'DocumentView::get_offset_y' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document_view.cpp:206:21: note: Technically the member function 'DocumentView::get_offset_y' can be const. sioyek-2.0.0/pdf_viewer/document_view.h:79:8: note: Technically the member function 'DocumentView::get_offset_y' can be const. sioyek-2.0.0/pdf_viewer/document_view.h:81:6: style:inconclusive: Technically the member function 'DocumentView::get_view_height' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document_view.cpp:214:19: note: Technically the member function 'DocumentView::get_view_height' can be const. sioyek-2.0.0/pdf_viewer/document_view.h:81:6: note: Technically the member function 'DocumentView::get_view_height' can be const. sioyek-2.0.0/pdf_viewer/document_view.h:82:6: style:inconclusive: Technically the member function 'DocumentView::get_view_width' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document_view.cpp:218:19: note: Technically the member function 'DocumentView::get_view_width' can be const. sioyek-2.0.0/pdf_viewer/document_view.h:82:6: note: Technically the member function 'DocumentView::get_view_width' can be const. sioyek-2.0.0/pdf_viewer/document_view.h:93:7: style:inconclusive: Technically the member function 'DocumentView::absolute_to_window_pos' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document_view.cpp:325:20: note: Technically the member function 'DocumentView::absolute_to_window_pos' can be const. sioyek-2.0.0/pdf_viewer/document_view.h:93:7: note: Technically the member function 'DocumentView::absolute_to_window_pos' can be const. sioyek-2.0.0/pdf_viewer/document_view.h:102:22: style:inconclusive: Technically the member function 'DocumentView::window_to_absolute_document_pos' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document_view.cpp:423:35: note: Technically the member function 'DocumentView::window_to_absolute_document_pos' can be const. sioyek-2.0.0/pdf_viewer/document_view.h:102:22: note: Technically the member function 'DocumentView::window_to_absolute_document_pos' can be const. sioyek-2.0.0/pdf_viewer/document_view.h:103:22: style:inconclusive: Technically the member function 'DocumentView::window_to_normalized_window_pos' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document_view.cpp:429:35: note: Technically the member function 'DocumentView::window_to_normalized_window_pos' can be const. sioyek-2.0.0/pdf_viewer/document_view.h:103:22: note: Technically the member function 'DocumentView::window_to_normalized_window_pos' can be const. sioyek-2.0.0/pdf_viewer/document_view.h:123:7: style:inconclusive: Technically the member function 'DocumentView::get_absolute_delta_from_doc_delta' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document_view.cpp:537:20: note: Technically the member function 'DocumentView::get_absolute_delta_from_doc_delta' can be const. sioyek-2.0.0/pdf_viewer/document_view.h:123:7: note: Technically the member function 'DocumentView::get_absolute_delta_from_doc_delta' can be const. sioyek-2.0.0/pdf_viewer/document_view.h:142:7: performance:inconclusive: Technically the member function 'DocumentView::get_page_chapter_index' can be static (but you may consider moving to unnamed namespace). [functionStatic] sioyek-2.0.0/pdf_viewer/document_view.cpp:856:20: note: Technically the member function 'DocumentView::get_page_chapter_index' can be static (but you may consider moving to unnamed namespace). sioyek-2.0.0/pdf_viewer/document_view.h:142:7: note: Technically the member function 'DocumentView::get_page_chapter_index' can be static (but you may consider moving to unnamed namespace). sioyek-2.0.0/pdf_viewer/document_view.h:144:8: style:inconclusive: Technically the member function 'DocumentView::view_height_in_document_space' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document_view.cpp:905:21: note: Technically the member function 'DocumentView::view_height_in_document_space' can be const. sioyek-2.0.0/pdf_viewer/document_view.h:144:8: note: Technically the member function 'DocumentView::view_height_in_document_space' can be const. sioyek-2.0.0/pdf_viewer/document_view.h:148:25: style:inconclusive: Technically the member function 'DocumentView::get_ruler_rect' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document_view.cpp:931:38: note: Technically the member function 'DocumentView::get_ruler_rect' can be const. sioyek-2.0.0/pdf_viewer/document_view.h:148:25: note: Technically the member function 'DocumentView::get_ruler_rect' can be const. sioyek-2.0.0/pdf_viewer/document_view.h:170:7: style:inconclusive: Technically the member function 'DocumentView::get_is_auto_resize_mode' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document_view.cpp:1187:20: note: Technically the member function 'DocumentView::get_is_auto_resize_mode' can be const. sioyek-2.0.0/pdf_viewer/document_view.h:170:7: note: Technically the member function 'DocumentView::get_is_auto_resize_mode' can be const. sioyek-2.0.0/pdf_viewer/ui.h:545:10: style: The function 'get_view_stylesheet_type_name' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] sioyek-2.0.0/pdf_viewer/ui.h:145:18: note: Virtual function in base class sioyek-2.0.0/pdf_viewer/ui.h:545:10: note: Function in derived class sioyek-2.0.0/pdf_viewer/ui.h:549:7: style: The function 'on_select' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] sioyek-2.0.0/pdf_viewer/ui.h:131:15: note: Virtual function in base class sioyek-2.0.0/pdf_viewer/ui.h:549:7: note: Function in derived class sioyek-2.0.0/pdf_viewer/ui.h:588:15: style: The function 'on_text_change' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] sioyek-2.0.0/pdf_viewer/ui.h:141:15: note: Virtual function in base class sioyek-2.0.0/pdf_viewer/ui.h:588:15: note: Function in derived class sioyek-2.0.0/pdf_viewer/ui.h:637:10: style: The function 'get_view_stylesheet_type_name' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] sioyek-2.0.0/pdf_viewer/ui.h:145:18: note: Virtual function in base class sioyek-2.0.0/pdf_viewer/ui.h:637:10: note: Function in derived class sioyek-2.0.0/pdf_viewer/ui.h:662:15: style: The function 'on_text_change' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] sioyek-2.0.0/pdf_viewer/ui.h:141:15: note: Virtual function in base class sioyek-2.0.0/pdf_viewer/ui.h:662:15: note: Function in derived class sioyek-2.0.0/pdf_viewer/ui.h:710:7: style: The function 'on_select' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] sioyek-2.0.0/pdf_viewer/ui.h:131:15: note: Virtual function in base class sioyek-2.0.0/pdf_viewer/ui.h:710:7: note: Function in derived class sioyek-2.0.0/pdf_viewer/fts_fuzzy_match.h:84:70: style:inconclusive: Function 'fuzzy_match_recursive' argument 6 names different: declaration 'newMatches' definition 'matches'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/fts_fuzzy_match.h:54:52: note: Function 'fuzzy_match_recursive' argument 6 names different: declaration 'newMatches' definition 'matches'. sioyek-2.0.0/pdf_viewer/fts_fuzzy_match.h:84:70: note: Function 'fuzzy_match_recursive' argument 6 names different: declaration 'newMatches' definition 'matches'. sioyek-2.0.0/pdf_viewer/document_view.cpp:268:56: style:inconclusive: Function 'get_highlight_index_in_pos' argument 1 names different: declaration 'pos' definition 'window_pos'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/document_view.h:87:43: note: Function 'get_highlight_index_in_pos' argument 1 names different: declaration 'pos' definition 'window_pos'. sioyek-2.0.0/pdf_viewer/document_view.cpp:268:56: note: Function 'get_highlight_index_in_pos' argument 1 names different: declaration 'pos' definition 'window_pos'. sioyek-2.0.0/pdf_viewer/document_view.cpp:340:70: style:inconclusive: Function 'document_to_window_pos' argument 1 names different: declaration 'pos' definition 'doc_pos'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/document_view.h:96:57: note: Function 'document_to_window_pos' argument 1 names different: declaration 'pos' definition 'doc_pos'. sioyek-2.0.0/pdf_viewer/document_view.cpp:340:70: note: Function 'document_to_window_pos' argument 1 names different: declaration 'pos' definition 'doc_pos'. sioyek-2.0.0/pdf_viewer/document_view.cpp:537:60: style:inconclusive: Function 'get_absolute_delta_from_doc_delta' argument 1 names different: declaration 'doc_dx' definition 'dx'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/document_view.h:123:47: note: Function 'get_absolute_delta_from_doc_delta' argument 1 names different: declaration 'doc_dx' definition 'dx'. sioyek-2.0.0/pdf_viewer/document_view.cpp:537:60: note: Function 'get_absolute_delta_from_doc_delta' argument 1 names different: declaration 'doc_dx' definition 'dx'. sioyek-2.0.0/pdf_viewer/document_view.cpp:537:70: style:inconclusive: Function 'get_absolute_delta_from_doc_delta' argument 2 names different: declaration 'doc_dy' definition 'dy'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/document_view.h:123:61: note: Function 'get_absolute_delta_from_doc_delta' argument 2 names different: declaration 'doc_dy' definition 'dy'. sioyek-2.0.0/pdf_viewer/document_view.cpp:537:70: note: Function 'get_absolute_delta_from_doc_delta' argument 2 names different: declaration 'doc_dy' definition 'dy'. sioyek-2.0.0/pdf_viewer/document_view.cpp:634:7: style:inconclusive: Function 'open_document' argument 5 names different: declaration 'foce_load_dimensions' definition 'force_load_dimensions'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/document_view.h:129:153: note: Function 'open_document' argument 5 names different: declaration 'foce_load_dimensions' definition 'force_load_dimensions'. sioyek-2.0.0/pdf_viewer/document_view.cpp:634:7: note: Function 'open_document' argument 5 names different: declaration 'foce_load_dimensions' definition 'force_load_dimensions'. sioyek-2.0.0/pdf_viewer/document_view.cpp:856:75: style:inconclusive: Function 'get_page_chapter_index' argument 2 names different: declaration 'toc_nodes' definition 'nodes'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/document_view.h:142:62: note: Function 'get_page_chapter_index' argument 2 names different: declaration 'toc_nodes' definition 'nodes'. sioyek-2.0.0/pdf_viewer/document_view.cpp:856:75: note: Function 'get_page_chapter_index' argument 2 names different: declaration 'toc_nodes' definition 'nodes'. sioyek-2.0.0/pdf_viewer/document_view.cpp:990:16: style:inconclusive: Function 'get_text_selection' argument 5 names different: declaration 'text_selection' definition 'selected_text'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/document_view.h:88:179: note: Function 'get_text_selection' argument 5 names different: declaration 'text_selection' definition 'selected_text'. sioyek-2.0.0/pdf_viewer/document_view.cpp:990:16: note: Function 'get_text_selection' argument 5 names different: declaration 'text_selection' definition 'selected_text'. sioyek-2.0.0/pdf_viewer/document_view.cpp:1063:53: style:inconclusive: Function 'get_line_index_of_pos' argument 1 names different: declaration 'docpos' definition 'line_doc_pos'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/document_view.h:163:40: note: Function 'get_line_index_of_pos' argument 1 names different: declaration 'docpos' definition 'line_doc_pos'. sioyek-2.0.0/pdf_viewer/document_view.cpp:1063:53: note: Function 'get_line_index_of_pos' argument 1 names different: declaration 'docpos' definition 'line_doc_pos'. sioyek-2.0.0/pdf_viewer/document_view.cpp:671:32: style: Local variable 'prev_state' shadows outer argument [shadowArgument] sioyek-2.0.0/pdf_viewer/document_view.cpp:633:33: note: Shadowed declaration sioyek-2.0.0/pdf_viewer/document_view.cpp:671:32: note: Shadow variable sioyek-2.0.0/pdf_viewer/document_view.cpp:1026:8: style: Local variable 'offset_y' shadows outer variable [shadowVariable] sioyek-2.0.0/pdf_viewer/document_view.h:45:8: note: Shadowed declaration sioyek-2.0.0/pdf_viewer/document_view.cpp:1026:8: note: Shadow variable sioyek-2.0.0/pdf_viewer/document_view.cpp:1032:8: style: Local variable 'offset_y' shadows outer variable [shadowVariable] sioyek-2.0.0/pdf_viewer/document_view.h:45:8: note: Shadowed declaration sioyek-2.0.0/pdf_viewer/document_view.cpp:1032:8: note: Shadow variable sioyek-2.0.0/pdf_viewer/ui.h:300:20: performance: Function parameter 'selected_index' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/ui.h:353:29: performance: Function parameter 'std_string_list' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/ui.h:354:29: performance: Function parameter 'std_string_list_right' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/ui.h:457:54: performance: Function parameter 'std_string_list' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/ui.h:522:71: performance: Function parameter 'command_names' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/ui.h:565:15: performance: Function parameter 'elements' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/ui.h:641:83: performance: Function parameter 'last_path' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/ui.h:682:53: performance: Function parameter 'prefix' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/document_view.cpp:34:15: performance: Function parameter 'path' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/document_view.cpp:194:47: performance: Function parameter 'hl' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/document_view.cpp:294:46: performance: Function parameter 'desc' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/document_view.cpp:856:75: performance: Function parameter 'nodes' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/document_view.cpp:1129:14: performance: Range variable 'generic_item_text' should be declared as const reference. [iterateByValue] sioyek-2.0.0/pdf_viewer/document_view.cpp:158:38: style: Parameter 'link' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/document_view.cpp:1158:14: style: Variable 'vec' can be declared as pointer to const [constVariablePointer] sioyek-2.0.0/pdf_viewer/ui.h:374:19: style: Variable 'name_item' can be declared as pointer to const [constVariablePointer] sioyek-2.0.0/pdf_viewer/ui.h:516:18: style: Variable 'name_item' can be declared as pointer to const [constVariablePointer] sioyek-2.0.0/pdf_viewer/ui.h:367:18: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/ui.h:468:18: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/document_view.cpp:64:9: warning: Uninitialized variable: res.book_state [uninitvar] sioyek-2.0.0/pdf_viewer/document_view.cpp:58:6: note: Assuming condition is false sioyek-2.0.0/pdf_viewer/document_view.cpp:64:9: note: Uninitialized variable: res.book_state sioyek-2.0.0/pdf_viewer/document_view.cpp:76:9: warning: Uninitialized variable: res.book_state [uninitvar] sioyek-2.0.0/pdf_viewer/document_view.cpp:70:6: note: Assuming condition is false sioyek-2.0.0/pdf_viewer/document_view.cpp:76:9: note: Uninitialized variable: res.book_state sioyek-2.0.0/pdf_viewer/document_view.cpp:64:9: error: Uninitialized struct member: res.book_state [uninitStructMember] sioyek-2.0.0/pdf_viewer/document_view.cpp:76:9: error: Uninitialized struct member: res.book_state [uninitStructMember] sioyek-2.0.0/pdf_viewer/document_view.cpp:1066:17: style: Variable 'page_width' is assigned a value that is never used. [unreadVariable] sioyek-2.0.0/pdf_viewer/document_view.cpp:1086:35: style: Variable 'line_rects' is assigned a value that is never used. [unreadVariable] sioyek-2.0.0/pdf_viewer/document_view.cpp:1155:14: style: Variable 'index' is assigned a value that is never used. [unreadVariable] sioyek-2.0.0/pdf_viewer/ui.h:267:19: style: Variable 'ss' is assigned a value that is never used. [unreadVariable] sioyek-2.0.0/pdf_viewer/document.cpp:313:2: performance: Variable 'last_update_time' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] sioyek-2.0.0/pdf_viewer/document.h:97:6: style:inconclusive: Technically the member function 'Document::get_mark_index' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document.cpp:31:15: note: Technically the member function 'Document::get_mark_index' can be const. sioyek-2.0.0/pdf_viewer/document.h:97:6: note: Technically the member function 'Document::get_mark_index' can be const. sioyek-2.0.0/pdf_viewer/document.h:108:7: performance:inconclusive: Technically the member function 'Document::clear_toc_node' can be static (but you may consider moving to unnamed namespace). [functionStatic] sioyek-2.0.0/pdf_viewer/document.cpp:2196:16: note: Technically the member function 'Document::clear_toc_node' can be static (but you may consider moving to unnamed namespace). sioyek-2.0.0/pdf_viewer/document.h:108:7: note: Technically the member function 'Document::clear_toc_node' can be static (but you may consider moving to unnamed namespace). sioyek-2.0.0/pdf_viewer/document.h:125:7: style:inconclusive: Technically the member function 'Document::get_is_indexing' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document.cpp:124:16: note: Technically the member function 'Document::get_is_indexing' can be const. sioyek-2.0.0/pdf_viewer/document.h:125:7: note: Technically the member function 'Document::get_is_indexing' can be const. sioyek-2.0.0/pdf_viewer/document.h:129:15: style:inconclusive: Technically the member function 'Document::get_path' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document.cpp:141:24: note: Technically the member function 'Document::get_path' can be const. sioyek-2.0.0/pdf_viewer/document.h:129:15: note: Technically the member function 'Document::get_path' can be const. sioyek-2.0.0/pdf_viewer/document.h:134:6: performance:inconclusive: Technically the member function 'Document::find_closest_bookmark_index' can be static (but you may consider moving to unnamed namespace). [functionStatic] sioyek-2.0.0/pdf_viewer/document.cpp:156:15: note: Technically the member function 'Document::find_closest_bookmark_index' can be static (but you may consider moving to unnamed namespace). sioyek-2.0.0/pdf_viewer/document.h:134:6: note: Technically the member function 'Document::find_closest_bookmark_index' can be static (but you may consider moving to unnamed namespace). sioyek-2.0.0/pdf_viewer/document.h:135:6: performance:inconclusive: Technically the member function 'Document::find_closest_highlight_index' can be static (but you may consider moving to unnamed namespace). [functionStatic] sioyek-2.0.0/pdf_viewer/document.cpp:165:15: note: Technically the member function 'Document::find_closest_highlight_index' can be static (but you may consider moving to unnamed namespace). sioyek-2.0.0/pdf_viewer/document.h:135:6: note: Technically the member function 'Document::find_closest_highlight_index' can be static (but you may consider moving to unnamed namespace). sioyek-2.0.0/pdf_viewer/document.h:137:24: style:inconclusive: Technically the member function 'Document::find_closest_portal' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document.cpp:203:33: note: Technically the member function 'Document::find_closest_portal' can be const. sioyek-2.0.0/pdf_viewer/document.h:137:24: note: Technically the member function 'Document::find_closest_portal' can be const. sioyek-2.0.0/pdf_viewer/document.h:155:31: style:inconclusive: Technically the member function 'Document::get_toc' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document.cpp:337:40: note: Technically the member function 'Document::get_toc' can be const. sioyek-2.0.0/pdf_viewer/document.h:155:31: note: Technically the member function 'Document::get_toc' can be const. sioyek-2.0.0/pdf_viewer/document.h:156:7: style:inconclusive: Technically the member function 'Document::has_toc' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document.cpp:346:16: note: Technically the member function 'Document::has_toc' can be const. sioyek-2.0.0/pdf_viewer/document.h:156:7: note: Technically the member function 'Document::has_toc' can be const. sioyek-2.0.0/pdf_viewer/document.h:157:35: style:inconclusive: Technically the member function 'Document::get_flat_toc_names' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document.cpp:350:44: note: Technically the member function 'Document::get_flat_toc_names' can be const. sioyek-2.0.0/pdf_viewer/document.h:157:35: note: Technically the member function 'Document::get_flat_toc_names' can be const. sioyek-2.0.0/pdf_viewer/document.h:158:26: style:inconclusive: Technically the member function 'Document::get_flat_toc_pages' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document.cpp:354:35: note: Technically the member function 'Document::get_flat_toc_pages' can be const. sioyek-2.0.0/pdf_viewer/document.h:158:26: note: Technically the member function 'Document::get_flat_toc_pages' can be const. sioyek-2.0.0/pdf_viewer/document.h:162:15: style:inconclusive: Technically the member function 'Document::get_milies_since_last_document_update_time' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document.cpp:540:24: note: Technically the member function 'Document::get_milies_since_last_document_update_time' can be const. sioyek-2.0.0/pdf_viewer/document.h:162:15: note: Technically the member function 'Document::get_milies_since_last_document_update_time' can be const. sioyek-2.0.0/pdf_viewer/document.h:166:8: style:inconclusive: Technically the member function 'Document::get_page_width' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document.cpp:368:17: note: Technically the member function 'Document::get_page_width' can be const. sioyek-2.0.0/pdf_viewer/document.h:166:8: note: Technically the member function 'Document::get_page_width' can be const. sioyek-2.0.0/pdf_viewer/document.h:184:30: performance:inconclusive: Technically the member function 'Document::get_text_at_position' can be static (but you may consider moving to unnamed namespace). [functionStatic] sioyek-2.0.0/pdf_viewer/document.cpp:1264:39: note: Technically the member function 'Document::get_text_at_position' can be static (but you may consider moving to unnamed namespace). sioyek-2.0.0/pdf_viewer/document.h:184:30: note: Technically the member function 'Document::get_text_at_position' can be static (but you may consider moving to unnamed namespace). sioyek-2.0.0/pdf_viewer/document.h:185:30: performance:inconclusive: Technically the member function 'Document::get_reference_text_at_position' can be static (but you may consider moving to unnamed namespace). [functionStatic] sioyek-2.0.0/pdf_viewer/document.cpp:1187:39: note: Technically the member function 'Document::get_reference_text_at_position' can be static (but you may consider moving to unnamed namespace). sioyek-2.0.0/pdf_viewer/document.h:185:30: note: Technically the member function 'Document::get_reference_text_at_position' can be static (but you may consider moving to unnamed namespace). sioyek-2.0.0/pdf_viewer/document.h:186:30: performance:inconclusive: Technically the member function 'Document::get_paper_name_at_position' can be static (but you may consider moving to unnamed namespace). [functionStatic] sioyek-2.0.0/pdf_viewer/document.cpp:1296:39: note: Technically the member function 'Document::get_paper_name_at_position' can be static (but you may consider moving to unnamed namespace). sioyek-2.0.0/pdf_viewer/document.h:186:30: note: Technically the member function 'Document::get_paper_name_at_position' can be static (but you may consider moving to unnamed namespace). sioyek-2.0.0/pdf_viewer/document.h:189:30: performance:inconclusive: Technically the member function 'Document::get_regex_match_at_position' can be static (but you may consider moving to unnamed namespace). [functionStatic] sioyek-2.0.0/pdf_viewer/document.cpp:1089:39: note: Technically the member function 'Document::get_regex_match_at_position' can be static (but you may consider moving to unnamed namespace). sioyek-2.0.0/pdf_viewer/document.h:189:30: note: Technically the member function 'Document::get_regex_match_at_position' can be static (but you may consider moving to unnamed namespace). sioyek-2.0.0/pdf_viewer/document.h:197:7: style:inconclusive: Technically the member function 'Document::can_use_highlights' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document.cpp:1161:16: note: Technically the member function 'Document::can_use_highlights' can be const. sioyek-2.0.0/pdf_viewer/document.h:197:7: note: Technically the member function 'Document::can_use_highlights' can be const. sioyek-2.0.0/pdf_viewer/document.h:211:6: style:inconclusive: Technically the member function 'Document::get_page_offset' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document.cpp:871:15: note: Technically the member function 'Document::get_page_offset' can be const. sioyek-2.0.0/pdf_viewer/document.h:211:6: note: Technically the member function 'Document::get_page_offset' can be const. sioyek-2.0.0/pdf_viewer/document.h:217:7: style:inconclusive: Technically the member function 'Document::needs_password' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document.cpp:1764:16: note: Technically the member function 'Document::needs_password' can be const. sioyek-2.0.0/pdf_viewer/document.h:217:7: note: Technically the member function 'Document::needs_password' can be const. sioyek-2.0.0/pdf_viewer/document.h:228:6: performance:inconclusive: Technically the member function 'Document::add_stext_page_to_created_toc' can be static (but you may consider moving to unnamed namespace). [functionStatic] sioyek-2.0.0/pdf_viewer/document.cpp:1893:15: note: Technically the member function 'Document::add_stext_page_to_created_toc' can be static (but you may consider moving to unnamed namespace). sioyek-2.0.0/pdf_viewer/document.h:228:6: note: Technically the member function 'Document::add_stext_page_to_created_toc' can be static (but you may consider moving to unnamed namespace). sioyek-2.0.0/pdf_viewer/document.h:233:8: style:inconclusive: Technically the member function 'Document::document_to_absolute_y' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document.cpp:1946:17: note: Technically the member function 'Document::document_to_absolute_y' can be const. sioyek-2.0.0/pdf_viewer/document.h:233:8: note: Technically the member function 'Document::document_to_absolute_y' can be const. sioyek-2.0.0/pdf_viewer/document.h:241:7: style:inconclusive: Technically the member function 'Document::is_super_fast_index_ready' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document.cpp:2210:16: note: Technically the member function 'Document::is_super_fast_index_ready' can be const. sioyek-2.0.0/pdf_viewer/document.h:241:7: note: Technically the member function 'Document::is_super_fast_index_ready' can be const. sioyek-2.0.0/pdf_viewer/document.h:262:53: style:inconclusive: Technically the member function 'DocumentManager::get_cached_documents' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/document.cpp:806:69: note: Technically the member function 'DocumentManager::get_cached_documents' can be const. sioyek-2.0.0/pdf_viewer/document.h:262:53: note: Technically the member function 'DocumentManager::get_cached_documents' can be const. sioyek-2.0.0/pdf_viewer/document.h:129:15: performance: Function 'get_path()' should return member 'file_name' by const reference. [returnByReference] sioyek-2.0.0/pdf_viewer/document.cpp:1444:21: style: Condition 'char_end' is always true [knownConditionTrueFalse] sioyek-2.0.0/pdf_viewer/document.cpp:1440:11: warning: Either the condition 'char_begin' is redundant or there is possible null pointer dereference: char_begin. [nullPointerRedundantCheck] sioyek-2.0.0/pdf_viewer/document.cpp:1444:7: note: Assuming that condition 'char_begin' is not redundant sioyek-2.0.0/pdf_viewer/document.cpp:1440:11: note: Null pointer dereference sioyek-2.0.0/pdf_viewer/document.cpp:668:8: style: The scope of the variable 'acc_height' can be reduced. [variableScope] sioyek-2.0.0/pdf_viewer/document.cpp:880:6: style: The scope of the variable 'page_number' can be reduced. [variableScope] sioyek-2.0.0/pdf_viewer/document.cpp:1123:17: style: The scope of the variable 'current_type' can be reduced. [variableScope] sioyek-2.0.0/pdf_viewer/document.cpp:2298:24: style: The scope of the variable 'match_rects' can be reduced. [variableScope] sioyek-2.0.0/pdf_viewer/document.cpp:2299:24: style: The scope of the variable 'compressed_match_rects' can be reduced. [variableScope] sioyek-2.0.0/pdf_viewer/document.cpp:195:43: style: Unsigned expression 'i' can't be negative so it is unnecessary to test it. [unsignedPositive] sioyek-2.0.0/pdf_viewer/document.cpp:73:67: style:inconclusive: Function 'fill_highlight_rects' argument 2 names different: declaration 'doc' definition 'doc_'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/document.h:121:58: note: Function 'fill_highlight_rects' argument 2 names different: declaration 'doc' definition 'doc_'. sioyek-2.0.0/pdf_viewer/document.cpp:73:67: note: Function 'fill_highlight_rects' argument 2 names different: declaration 'doc' definition 'doc_'. sioyek-2.0.0/pdf_viewer/document.cpp:128:34: style:inconclusive: Function 'add_portal' argument 1 names different: declaration 'link' definition 'portal'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/document.h:128:25: note: Function 'add_portal' argument 1 names different: declaration 'link' definition 'portal'. sioyek-2.0.0/pdf_viewer/document.cpp:128:34: note: Function 'add_portal' argument 1 names different: declaration 'link' definition 'portal'. sioyek-2.0.0/pdf_viewer/document.cpp:215:37: style:inconclusive: Function 'update_portal' argument 1 names different: declaration 'new_link' definition 'new_portal'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/document.h:138:28: note: Function 'update_portal' argument 1 names different: declaration 'new_link' definition 'new_portal'. sioyek-2.0.0/pdf_viewer/document.cpp:215:37: note: Function 'update_portal' argument 1 names different: declaration 'new_link' definition 'new_portal'. sioyek-2.0.0/pdf_viewer/document.cpp:307:82: style:inconclusive: Function 'Document' argument 3 names different: declaration 'db_manager' definition 'db'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/document.h:106:73: note: Function 'Document' argument 3 names different: declaration 'db_manager' definition 'db'. sioyek-2.0.0/pdf_viewer/document.cpp:307:82: note: Function 'Document' argument 3 names different: declaration 'db_manager' definition 'db'. sioyek-2.0.0/pdf_viewer/document.cpp:325:60: style:inconclusive: Function 'count_chapter_pages_accum' argument 1 names different: declaration 'page_counts' definition 'accum_page_counts'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/document.h:124:51: note: Function 'count_chapter_pages_accum' argument 1 names different: declaration 'page_counts' definition 'accum_page_counts'. sioyek-2.0.0/pdf_viewer/document.cpp:325:60: note: Function 'count_chapter_pages_accum' argument 1 names different: declaration 'page_counts' definition 'accum_page_counts'. sioyek-2.0.0/pdf_viewer/document.cpp:788:78: style:inconclusive: Function 'DocumentManager' argument 2 names different: declaration 'db_manager' definition 'db'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/document.h:258:62: note: Function 'DocumentManager' argument 2 names different: declaration 'db_manager' definition 'db'. sioyek-2.0.0/pdf_viewer/document.cpp:788:78: note: Function 'DocumentManager' argument 2 names different: declaration 'db_manager' definition 'db'. sioyek-2.0.0/pdf_viewer/document.cpp:821:100: style:inconclusive: Function 'get_stext_with_page_number' argument 3 names different: declaration 'doc' definition 'doc_'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/document.h:126:91: note: Function 'get_stext_with_page_number' argument 3 names different: declaration 'doc' definition 'doc_'. sioyek-2.0.0/pdf_viewer/document.cpp:821:100: note: Function 'get_stext_with_page_number' argument 3 names different: declaration 'doc' definition 'doc_'. sioyek-2.0.0/pdf_viewer/document.cpp:894:64: style:inconclusive: Function 'absolute_to_page_pos' argument 1 names different: declaration 'absolute_pos' definition 'absp'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/document.h:175:55: note: Function 'absolute_to_page_pos' argument 1 names different: declaration 'absolute_pos' definition 'absp'. sioyek-2.0.0/pdf_viewer/document.cpp:894:64: note: Function 'absolute_to_page_pos' argument 1 names different: declaration 'absolute_pos' definition 'absp'. sioyek-2.0.0/pdf_viewer/document.cpp:1367:15: style:inconclusive: Function 'get_text_selection' argument 7 names different: declaration 'doc' definition 'doc_'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/document.h:209:16: note: Function 'get_text_selection' argument 7 names different: declaration 'doc' definition 'doc_'. sioyek-2.0.0/pdf_viewer/document.cpp:1367:15: note: Function 'get_text_selection' argument 7 names different: declaration 'doc' definition 'doc_'. sioyek-2.0.0/pdf_viewer/document.cpp:1812:46: style:inconclusive: Function 'get_page_rect_no_cache' argument 1 names different: declaration 'page' definition 'page_number'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/document.h:222:37: note: Function 'get_page_rect_no_cache' argument 1 names different: declaration 'page' definition 'page_number'. sioyek-2.0.0/pdf_viewer/document.cpp:1812:46: note: Function 'get_page_rect_no_cache' argument 1 names different: declaration 'page' definition 'page_number'. sioyek-2.0.0/pdf_viewer/document.cpp:1874:66: style:inconclusive: Function 'get_link_in_pos' argument 2 names different: declaration 'x' definition 'doc_x'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/document.h:223:57: note: Function 'get_link_in_pos' argument 2 names different: declaration 'x' definition 'doc_x'. sioyek-2.0.0/pdf_viewer/document.cpp:1874:66: note: Function 'get_link_in_pos' argument 2 names different: declaration 'x' definition 'doc_x'. sioyek-2.0.0/pdf_viewer/document.cpp:1874:79: style:inconclusive: Function 'get_link_in_pos' argument 3 names different: declaration 'y' definition 'doc_y'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/document.h:223:66: note: Function 'get_link_in_pos' argument 3 names different: declaration 'y' definition 'doc_y'. sioyek-2.0.0/pdf_viewer/document.cpp:1874:79: note: Function 'get_link_in_pos' argument 3 names different: declaration 'y' definition 'doc_y'. sioyek-2.0.0/pdf_viewer/document.cpp:1896:25: style:inconclusive: Function 'add_stext_page_to_created_toc' argument 4 names different: declaration 'top_level_node' definition 'top_level_nodes'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/document.h:231:26: note: Function 'add_stext_page_to_created_toc' argument 4 names different: declaration 'top_level_node' definition 'top_level_nodes'. sioyek-2.0.0/pdf_viewer/document.cpp:1896:25: note: Function 'add_stext_page_to_created_toc' argument 4 names different: declaration 'top_level_node' definition 'top_level_nodes'. sioyek-2.0.0/pdf_viewer/document.cpp:2109:91: style:inconclusive: Function 'get_page_lines' argument 2 names different: declaration 'line_texts' definition 'out_line_texts'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/document.h:239:82: note: Function 'get_page_lines' argument 2 names different: declaration 'line_texts' definition 'out_line_texts'. sioyek-2.0.0/pdf_viewer/document.cpp:2109:91: note: Function 'get_page_lines' argument 2 names different: declaration 'line_texts' definition 'out_line_texts'. sioyek-2.0.0/pdf_viewer/document.cpp:320:7: style: Local variable 'num_pages' shadows outer function [shadowFunction] sioyek-2.0.0/pdf_viewer/document.h:173:6: note: Shadowed declaration sioyek-2.0.0/pdf_viewer/document.cpp:320:7: note: Shadow variable sioyek-2.0.0/pdf_viewer/document.cpp:1859:12: style: Local variable 'portals' shadows outer variable [shadowVariable] sioyek-2.0.0/pdf_viewer/document.h:35:22: note: Shadowed declaration sioyek-2.0.0/pdf_viewer/document.cpp:1859:12: note: Shadow variable sioyek-2.0.0/pdf_viewer/document.cpp:1878:12: style: Local variable 'portals' shadows outer variable [shadowVariable] sioyek-2.0.0/pdf_viewer/document.h:35:22: note: Shadowed declaration sioyek-2.0.0/pdf_viewer/document.cpp:1878:12: note: Shadow variable sioyek-2.0.0/pdf_viewer/document.cpp:158:77: performance: Function parameter 'bm' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/document.cpp:167:80: performance: Function parameter 'hl' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/document.cpp:194:43: performance: Function parameter 'hl' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/document.cpp:204:64: performance: Function parameter 'l' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/document.cpp:215:37: performance: Function parameter 'new_portal' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/document.cpp:568:35: performance: Function parameter 'password' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/document.cpp:599:81: performance: Function parameter 'password' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/document.cpp:1505:47: performance: Function parameter 'new_file_path' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/document.cpp:1528:12: performance: Range variable 'highlight' should be declared as const reference. [iterateByValue] sioyek-2.0.0/pdf_viewer/document.cpp:1561:12: performance: Range variable 'bookmark' should be declared as const reference. [iterateByValue] sioyek-2.0.0/pdf_viewer/document.cpp:1725:12: performance: Range variable 'hl' should be declared as const reference. [iterateByValue] sioyek-2.0.0/pdf_viewer/document.cpp:1747:12: performance: Range variable 'hl' should be declared as const reference. [iterateByValue] sioyek-2.0.0/pdf_viewer/document.cpp:1893:60: style: Parameter 'stext_page' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/document.cpp:2119:18: style: Variable 'stext_page' can be declared as pointer to const [constVariablePointer] sioyek-2.0.0/pdf_viewer/document.cpp:217:55: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/document.cpp:252:7: style: Consider using std::copy_if algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/document.cpp:1540:35: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/document.cpp:1474:21: style: Variable 'word_selecting' is assigned a value that is never used. [unreadVariable] sioyek-2.0.0/pdf_viewer/document.cpp:1703:39: style: Unused variable: word_rects_with_page [unusedVariable] sioyek-2.0.0/pdf_viewer/input.h:32:2: style: Class 'CommandManager' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] sioyek-2.0.0/pdf_viewer/main_widget.h:245:2: style: Class 'MainWidget' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] sioyek-2.0.0/pdf_viewer/main.cpp:424:20: style: C-style pointer casting [cstyleCast] sioyek-2.0.0/pdf_viewer/main.cpp:429:20: style: C-style pointer casting [cstyleCast] sioyek-2.0.0/pdf_viewer/main.cpp:624:7: style: Local variable 'page' shadows outer variable [shadowVariable] sioyek-2.0.0/pdf_viewer/main.cpp:488:24: note: Shadowed declaration sioyek-2.0.0/pdf_viewer/main.cpp:624:7: note: Shadow variable sioyek-2.0.0/pdf_viewer/input.h:69:92: performance: Function parameter 'seq' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/main.cpp:438:15: performance: Range variable 'user_path' should be declared as const reference. [iterateByValue] sioyek-2.0.0/pdf_viewer/input.cpp:509:2: performance: Variable 'user_key_paths' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] sioyek-2.0.0/pdf_viewer/input.h:33:17: style:inconclusive: Technically the member function 'CommandManager::get_command_with_name' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/input.cpp:197:32: note: Technically the member function 'CommandManager::get_command_with_name' can be const. sioyek-2.0.0/pdf_viewer/input.h:33:17: note: Technically the member function 'CommandManager::get_command_with_name' can be const. sioyek-2.0.0/pdf_viewer/input.h:34:14: style:inconclusive: Technically the member function 'CommandManager::get_all_command_names' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/input.cpp:206:29: note: Technically the member function 'CommandManager::get_all_command_names' can be const. sioyek-2.0.0/pdf_viewer/input.h:34:14: note: Technically the member function 'CommandManager::get_all_command_names' can be const. sioyek-2.0.0/pdf_viewer/input.h:55:7: style:inconclusive: Technically the member function 'InputParseTreeNode::is_same' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/input.cpp:617:26: note: Technically the member function 'InputParseTreeNode::is_same' can be const. sioyek-2.0.0/pdf_viewer/input.h:55:7: note: Technically the member function 'InputParseTreeNode::is_same' can be const. sioyek-2.0.0/pdf_viewer/input.h:56:7: style:inconclusive: Technically the member function 'InputParseTreeNode::matches' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/input.cpp:626:26: note: Technically the member function 'InputParseTreeNode::matches' can be const. sioyek-2.0.0/pdf_viewer/input.h:56:7: note: Technically the member function 'InputParseTreeNode::matches' can be const. sioyek-2.0.0/pdf_viewer/input.h:70:14: performance:inconclusive: Technically the member function 'InputHandler::get_key_name_from_key_code' can be static (but you may consider moving to unnamed namespace). [functionStatic] sioyek-2.0.0/pdf_viewer/input.cpp:677:27: note: Technically the member function 'InputHandler::get_key_name_from_key_code' can be static (but you may consider moving to unnamed namespace). sioyek-2.0.0/pdf_viewer/input.h:70:14: note: Technically the member function 'InputHandler::get_key_name_from_key_code' can be static (but you may consider moving to unnamed namespace). sioyek-2.0.0/pdf_viewer/input.cpp:678:14: style: The scope of the variable 'result' can be reduced. [variableScope] sioyek-2.0.0/pdf_viewer/input.cpp:513:52: style:inconclusive: Function 'reload_config_files' argument 1 names different: declaration 'default_path' definition 'default_config_path'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/input.h:78:39: note: Function 'reload_config_files' argument 1 names different: declaration 'default_path' definition 'default_config_path'. sioyek-2.0.0/pdf_viewer/input.cpp:513:52: note: Function 'reload_config_files' argument 1 names different: declaration 'default_path' definition 'default_config_path'. sioyek-2.0.0/pdf_viewer/input.cpp:513:98: style:inconclusive: Function 'reload_config_files' argument 2 names different: declaration 'user_path' definition 'user_config_paths'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/input.h:78:78: note: Function 'reload_config_files' argument 2 names different: declaration 'user_path' definition 'user_config_paths'. sioyek-2.0.0/pdf_viewer/input.cpp:513:98: note: Function 'reload_config_files' argument 2 names different: declaration 'user_path' definition 'user_config_paths'. sioyek-2.0.0/pdf_viewer/input.cpp:653:65: style:inconclusive: Function 'add_command_key_mappings' argument 1 names different: declaration 'root' definition 'thisroot'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/input.h:72:52: note: Function 'add_command_key_mappings' argument 1 names different: declaration 'root' definition 'thisroot'. sioyek-2.0.0/pdf_viewer/input.cpp:653:65: note: Function 'add_command_key_mappings' argument 1 names different: declaration 'root' definition 'thisroot'. sioyek-2.0.0/pdf_viewer/main.cpp:287:23: style: Variable 'exe_path' is assigned a value that is never used. [unreadVariable] sioyek-2.0.0/pdf_viewer/input.cpp:189:12: performance: Range variable 'conf' should be declared as const reference. [iterateByValue] sioyek-2.0.0/pdf_viewer/input.cpp:197:66: performance: Function parameter 'name' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/input.cpp:214:41: performance: Function parameter 'node' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/input.cpp:307:30: performance: Function parameter 'line' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/input.cpp:499:12: performance: Range variable 'upath' should be declared as const reference. [iterateByValue] sioyek-2.0.0/pdf_viewer/input.cpp:711:105: performance: Function parameter 'seq' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/main.cpp:360:31: style: Variable 'all_config_paths' is assigned a value that is never used. [unreadVariable] sioyek-2.0.0/pdf_viewer/input.cpp:199:25: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/input.cpp:209:7: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/input.cpp:360:32: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/input.cpp:243:10: error: Uninitialized variables: res.command, res.defining_file_line [uninitvar] sioyek-2.0.0/pdf_viewer/input.cpp:243:10: error: Uninitialized struct member: res.command [uninitStructMember] sioyek-2.0.0/pdf_viewer/input.cpp:243:10: error: Uninitialized struct member: res.defining_file_line [uninitStructMember] sioyek-2.0.0/pdf_viewer/input.cpp:491:17: style: Variable 'default_infile' is assigned a value that is never used. [unreadVariable] sioyek-2.0.0/pdf_viewer/input.cpp:536:23: style: Variable 'text' is assigned a value that is never used. [unreadVariable] sioyek-2.0.0/pdf_viewer/new_file_checker.cpp:8:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Files [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/new_file_checker.cpp:64:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Dirs [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/new_file_checker.cpp:80:64: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable directoryChanged [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_renderer.cpp:20:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable timeout [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_renderer.cpp:75:8: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable wcout [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_renderer.cpp:105:8: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable wcout [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_renderer.cpp:135:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_TEXTURE_2D [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_renderer.cpp:288:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_renderer.cpp:387:8: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable wcout [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_renderer.cpp:401:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable wcout [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_renderer.cpp:452:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable fz_identity [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/path.cpp:90:21: performance: Function parameter 'src' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/path.cpp:90:31: performance: Function parameter 'dst' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/pdf_renderer.cpp:51:44: performance: Function parameter 'document_path' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/pdf_renderer.cpp:78:44: performance: Function parameter 'document_path' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/pdf_renderer.cpp:80:15: performance: Function parameter 'term' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/pdf_renderer.cpp:111:53: performance: Function parameter 'path' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/pdf_renderer.cpp:177:60: performance: Function parameter 'doc_path' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/pdf_renderer.cpp:490:45: performance: Function parameter 'path' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/pdf_renderer.cpp:490:63: performance: Function parameter 'password' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/pdf_renderer.cpp:121:72: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/pdf_renderer.cpp:309:22: style: Variable 'total_results' is assigned a value that is never used. [unreadVariable] sioyek-2.0.0/pdf_viewer/pdf_renderer.cpp:339:19: style: Variable 'total_results' is assigned a value that is never used. [unreadVariable] sioyek-2.0.0/pdf_viewer/main_widget.cpp:200:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable x [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:307:65: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:340:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WA_DeleteOnClose [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:525:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:563:68: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable requires_symbol [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:939:131: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable y0 [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:1024:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable wcout [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:1225:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:1241:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Key_Escape [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:1402:55: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable x [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:1559:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable book_state [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:1647:127: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:1685:97: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ShiftModifier [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:1747:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LeftButton [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:1759:97: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ShiftModifier [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:1799:83: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ControlModifier [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:1971:69: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:2924:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ShiftModifier [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3036:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable uri [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3279:63: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WindowMaximized [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3298:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable second [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3406:72: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SkipEmptyParts [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3955:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WindowStateChange [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:4042:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FramelessWindowHint [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:4069:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable requires_text [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:4216:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable requires_text [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:4425:53: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable dst [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/main_widget.cpp:4482:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable x0 [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/new_file_checker.cpp:76:2: performance: Variable 'path' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] sioyek-2.0.0/pdf_viewer/new_file_checker.h:15:7: performance:inconclusive: Technically the member function 'NewFileChecker::get_dir_files_helper' can be static (but you may consider moving to unnamed namespace). [functionStatic] sioyek-2.0.0/pdf_viewer/new_file_checker.cpp:5:22: note: Technically the member function 'NewFileChecker::get_dir_files_helper' can be static (but you may consider moving to unnamed namespace). sioyek-2.0.0/pdf_viewer/new_file_checker.h:15:7: note: Technically the member function 'NewFileChecker::get_dir_files_helper' can be static (but you may consider moving to unnamed namespace). sioyek-2.0.0/pdf_viewer/new_file_checker.cpp:42:12: performance: Range variable 'new_file' should be declared as const reference. [iterateByValue] sioyek-2.0.0/pdf_viewer/new_file_checker.cpp:45:13: performance: Range variable 'prev_file' should be declared as const reference. [iterateByValue] sioyek-2.0.0/pdf_viewer/new_file_checker.cpp:74:45: performance: Function parameter 'dirpath' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/new_file_checker.cpp:46:31: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:83:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_VERTEX_SHADER [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:217:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_ARRAY_BUFFER [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:257:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_CULL_FACE [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:339:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_BLEND [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:392:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CoreProfile [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:487:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable y0 [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:575:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_BLEND [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:667:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_TEXTURE_2D [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:711:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_CULL_FACE [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:1019:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:1128:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LeftButton [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:1165:81: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ControlModifier [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:1207:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable doc [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:1444:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable doc [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:1498:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_STENCIL_TEST [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:1503:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_NEVER [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:1510:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_EQUAL [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:1519:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_STENCIL_TEST [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:1531:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_CULL_FACE [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:1596:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GL_ARRAY_BUFFER [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:1616:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable OpaqueMode [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:1662:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable doc [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/utils.cpp:85:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AlignVCenter [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/utils.cpp:164:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Selection [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/utils.cpp:227:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Ok [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/utils.cpp:326:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FZ_STEXT_BLOCK_TEXT [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/utils.cpp:364:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FZ_STEXT_BLOCK_TEXT [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/utils.cpp:417:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable x0 [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/utils.cpp:434:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable x0 [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/utils.cpp:725:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable y1 [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/utils.cpp:844:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable errorOccurred [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/utils.cpp:1078:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable y0 [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/utils.cpp:1110:65: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable y [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/utils.cpp:1134:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FZ_STEXT_BLOCK_TEXT [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/utils.cpp:1454:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WriteOnly [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/utils.cpp:1677:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable finished [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/utils.cpp:1799:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable binary [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/utils.cpp:1926:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable y0 [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/utils.cpp:2064:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable x0 [valueFlowBailoutIncompleteVar] sioyek-2.0.0/pdf_viewer/ui.cpp:8:7: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] sioyek-2.0.0/pdf_viewer/ui.cpp:11:2: note: Found duplicate branches for 'if' and 'else'. sioyek-2.0.0/pdf_viewer/ui.cpp:8:7: note: Found duplicate branches for 'if' and 'else'. sioyek-2.0.0/pdf_viewer/ui.cpp:4:51: performance: Function parameter 'command_name' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/utils.cpp:1889:8: style:inconclusive: Technically the member function 'Range::size' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:1364:2: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] sioyek-2.0.0/pdf_viewer/utils.cpp:2120:27: style: Condition 'command.find(L"%5")!=-1' is always true [knownConditionTrueFalse] sioyek-2.0.0/pdf_viewer/utils.cpp:2120:68: style: Condition 'command.find(L"command_text")!=-1' is always true [knownConditionTrueFalse] sioyek-2.0.0/pdf_viewer/utils.cpp:2127:40: style: Condition 'command.find(L"%{selected_rect}")!=-1' is always true [knownConditionTrueFalse] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:381:22: warning: Member variable 'PdfViewOpenGLWidget::is_searching' is not initialized in the constructor. [uninitMemberVar] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:388:2: performance: Variable 'creation_time' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] sioyek-2.0.0/pdf_viewer/utils.cpp:1923:2: style: Statements following 'return' will never be executed. [unreachableCode] sioyek-2.0.0/pdf_viewer/utils.cpp:1356:8: style: The scope of the variable 'additional_distance' can be reduced. [variableScope] sioyek-2.0.0/pdf_viewer/utils.cpp:1991:6: style: The scope of the variable 'first_percentile_index' can be reduced. [variableScope] sioyek-2.0.0/pdf_viewer/utils.cpp:874:40: style:inconclusive: Function 'open_file_url' argument 1 names different: declaration 'file_url' definition 'url_string'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/utils.h:103:40: note: Function 'open_file_url' argument 1 names different: declaration 'file_url' definition 'url_string'. sioyek-2.0.0/pdf_viewer/utils.cpp:874:40: note: Function 'open_file_url' argument 1 names different: declaration 'file_url' definition 'url_string'. sioyek-2.0.0/pdf_viewer/utils.cpp:883:39: style:inconclusive: Function 'open_web_url' argument 1 names different: declaration 'web_url' definition 'url_string'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/utils.h:104:39: note: Function 'open_web_url' argument 1 names different: declaration 'web_url' definition 'url_string'. sioyek-2.0.0/pdf_viewer/utils.cpp:883:39: note: Function 'open_web_url' argument 1 names different: declaration 'web_url' definition 'url_string'. sioyek-2.0.0/pdf_viewer/utils.cpp:1326:110: style:inconclusive: Function 'get_line_begins_and_ends_from_histogram' argument 2 names different: declaration 'begins' definition 'res_begins'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/utils.h:147:110: note: Function 'get_line_begins_and_ends_from_histogram' argument 2 names different: declaration 'begins' definition 'res_begins'. sioyek-2.0.0/pdf_viewer/utils.cpp:1326:110: note: Function 'get_line_begins_and_ends_from_histogram' argument 2 names different: declaration 'begins' definition 'res_begins'. sioyek-2.0.0/pdf_viewer/utils.cpp:1326:149: style:inconclusive: Function 'get_line_begins_and_ends_from_histogram' argument 3 names different: declaration 'ends' definition 'res'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/utils.h:147:145: note: Function 'get_line_begins_and_ends_from_histogram' argument 3 names different: declaration 'ends' definition 'res'. sioyek-2.0.0/pdf_viewer/utils.cpp:1326:149: note: Function 'get_line_begins_and_ends_from_histogram' argument 3 names different: declaration 'ends' definition 'res'. sioyek-2.0.0/pdf_viewer/utils.cpp:1376:61: style:inconclusive: Function 'find_best_vertical_line_location' argument 2 names different: declaration 'relative_click_x' definition 'doc_x'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/utils.h:112:61: note: Function 'find_best_vertical_line_location' argument 2 names different: declaration 'relative_click_x' definition 'doc_x'. sioyek-2.0.0/pdf_viewer/utils.cpp:1376:61: note: Function 'find_best_vertical_line_location' argument 2 names different: declaration 'relative_click_x' definition 'doc_x'. sioyek-2.0.0/pdf_viewer/utils.cpp:1376:72: style:inconclusive: Function 'find_best_vertical_line_location' argument 3 names different: declaration 'relative_click_y' definition 'doc_y'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/utils.h:112:83: note: Function 'find_best_vertical_line_location' argument 3 names different: declaration 'relative_click_y' definition 'doc_y'. sioyek-2.0.0/pdf_viewer/utils.cpp:1376:72: note: Function 'find_best_vertical_line_location' argument 3 names different: declaration 'relative_click_y' definition 'doc_y'. sioyek-2.0.0/pdf_viewer/utils.cpp:2021:53: style:inconclusive: Function 'merge_lines' argument 1 names different: declaration 'lines' definition 'lines_'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/utils.h:184:53: note: Function 'merge_lines' argument 1 names different: declaration 'lines' definition 'lines_'. sioyek-2.0.0/pdf_viewer/utils.cpp:2021:53: note: Function 'merge_lines' argument 1 names different: declaration 'lines' definition 'lines_'. sioyek-2.0.0/pdf_viewer/utils.cpp:554:13: style: Local variable 'i' shadows outer variable [shadowVariable] sioyek-2.0.0/pdf_viewer/utils.cpp:550:11: note: Shadowed declaration sioyek-2.0.0/pdf_viewer/utils.cpp:554:13: note: Shadow variable sioyek-2.0.0/pdf_viewer/utils.cpp:1361:15: style: Local variable 'i' shadows outer variable [shadowVariable] sioyek-2.0.0/pdf_viewer/utils.cpp:1341:9: note: Shadowed declaration sioyek-2.0.0/pdf_viewer/utils.cpp:1361:15: note: Shadow variable sioyek-2.0.0/pdf_viewer/utils.cpp:1367:15: style: Local variable 'i' shadows outer variable [shadowVariable] sioyek-2.0.0/pdf_viewer/utils.cpp:1341:9: note: Shadowed declaration sioyek-2.0.0/pdf_viewer/utils.cpp:1367:15: note: Shadow variable sioyek-2.0.0/pdf_viewer/utils.cpp:119:60: performance: Function parameter 'uri' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/utils.cpp:583:86: performance: Function parameter 'flat_chars' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/utils.cpp:810:31: performance: Function parameter 'command' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/utils.cpp:810:52: performance: Function parameter 'parameters' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/utils.cpp:1168:16: performance: Range variable 'index' should be declared as const reference. [iterateByValue] sioyek-2.0.0/pdf_viewer/utils.cpp:1308:36: performance: Function parameter 'values' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/utils.cpp:1317:41: performance: Function parameter 'values' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/utils.cpp:1326:72: performance: Function parameter 'histogram' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/utils.cpp:1483:57: performance: Function parameter 'key' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/utils.cpp:1492:49: performance: Function parameter 'key' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/utils.cpp:1672:53: performance: Function parameter 'current_version' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/utils.cpp:1711:30: performance: Function parameter 'path' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/utils.cpp:1798:29: performance: Function parameter 'src_path' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/utils.cpp:1798:52: performance: Function parameter 'dst_path' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/utils.cpp:1919:25: performance: Function parameter 'char_counts' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/utils.cpp:2133:40: performance: Function parameter 'command_string' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/utils.cpp:2170:56: performance: Function parameter 'chars' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/utils.cpp:1021:41: style: Parameter 'input_string' can be declared as reference to const [constParameterReference] sioyek-2.0.0/pdf_viewer/utils.cpp:308:39: style: Parameter 'line' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/utils.cpp:320:39: style: Parameter 'stext_page' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/utils.cpp:363:48: style: Parameter 'block' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/utils.cpp:374:52: style: Parameter 'stext_page' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/utils.cpp:386:43: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/utils.cpp:390:42: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/utils.cpp:394:42: style: Parameter 'prev_char' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/utils.cpp:603:39: style: Parameter 'last_char' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/utils.cpp:603:65: style: Parameter 'current_char' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/utils.cpp:614:34: style: Parameter 'last_char' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/utils.cpp:614:60: style: Parameter 'current_char' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/utils.cpp:629:56: style: Parameter 'line' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/utils.cpp:1123:38: style: Parameter 'page' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/utils.cpp:2012:35: style: Parameter 'line' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/utils.cpp:48:7: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/utils.cpp:368:16: style: Consider using std::copy algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/utils.cpp:480:12: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/utils.cpp:511:8: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/utils.cpp:519:8: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/utils.cpp:1311:7: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/utils.cpp:1320:7: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/utils.cpp:1338:24: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/utils.cpp:1420:2: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/utils.cpp:1818:7: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/utils.cpp:470:28: style: Unused variable: res [unusedVariable] sioyek-2.0.0/pdf_viewer/utils.cpp:1023:15: style: Unused variable: result [unusedVariable] sioyek-2.0.0/pdf_viewer/utils.cpp:1356:28: style: Variable 'additional_distance' is assigned a value that is never used. [unreadVariable] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:1694:3: style:inconclusive: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:331:8: style: The scope of the variable 'line_data' can be reduced. [variableScope] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:574:8: style: The scope of the variable 'white_color' can be reduced. [variableScope] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:78:46: style:inconclusive: Function 'LoadShaders' argument 1 names different: declaration 'vertex_file_path_' definition 'vertex_file_path'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.h:154:26: note: Function 'LoadShaders' argument 1 names different: declaration 'vertex_file_path_' definition 'vertex_file_path'. sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:78:46: note: Function 'LoadShaders' argument 1 names different: declaration 'vertex_file_path_' definition 'vertex_file_path'. sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:78:69: style:inconclusive: Function 'LoadShaders' argument 2 names different: declaration 'fragment_file_path_' definition 'fragment_file_path'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.h:154:50: note: Function 'LoadShaders' argument 2 names different: declaration 'fragment_file_path_' definition 'fragment_file_path'. sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:78:69: note: Function 'LoadShaders' argument 2 names different: declaration 'fragment_file_path_' definition 'fragment_file_path'. sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:244:68: style:inconclusive: Function 'render_line_window' argument 2 names different: declaration 'vertical_pos' definition 'gl_vertical_pos'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.h:159:48: note: Function 'render_line_window' argument 2 names different: declaration 'vertical_pos' definition 'gl_vertical_pos'. sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:244:68: note: Function 'render_line_window' argument 2 names different: declaration 'vertical_pos' definition 'gl_vertical_pos'. sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:425:52: style:inconclusive: Function 'set_highlight_links' argument 1 names different: declaration 'should_highlight_links' definition 'should_highlight'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.h:195:32: note: Function 'set_highlight_links' argument 1 names different: declaration 'should_highlight_links' definition 'should_highlight'. sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:425:52: note: Function 'set_highlight_links' argument 1 names different: declaration 'should_highlight_links' definition 'should_highlight'. sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:1138:58: style:inconclusive: Function 'mouseReleaseEvent' argument 1 names different: declaration 'mevent' definition 'mouse_event'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.h:218:38: note: Function 'mouseReleaseEvent' argument 1 names different: declaration 'mevent' definition 'mouse_event'. sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:1138:58: note: Function 'mouseReleaseEvent' argument 1 names different: declaration 'mevent' definition 'mouse_event'. sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:1204:74: style:inconclusive: Function 'set_overview_page' argument 1 names different: declaration 'overview_page' definition 'overview'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.h:221:54: note: Function 'set_overview_page' argument 1 names different: declaration 'overview_page' definition 'overview'. sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:1204:74: note: Function 'set_overview_page' argument 1 names different: declaration 'overview_page' definition 'overview'. sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:1646:61: style:inconclusive: Function 'set_typing_rect' argument 2 names different: declaration 'rect' definition 'highlight_rect'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.h:259:41: note: Function 'set_typing_rect' argument 2 names different: declaration 'rect' definition 'highlight_rect'. sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:1646:61: note: Function 'set_typing_rect' argument 2 names different: declaration 'rect' definition 'highlight_rect'. sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:78:46: performance: Function parameter 'vertex_file_path' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:78:69: performance: Function parameter 'fragment_file_path' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:1697:10: error: Uninitialized variable: res [uninitvar] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:1697:10: error: Uninitialized struct member: res.x [uninitStructMember] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:1697:10: error: Uninitialized struct member: res.y [uninitStructMember] sioyek-2.0.0/pdf_viewer/pdf_view_opengl_widget.cpp:1676:22: style: Variable 'res' is not assigned a value. [unassignedVariable] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3404:11: warning: Return value of function qtext.arg() is not used. [ignoredReturnValue] sioyek-2.0.0/pdf_viewer/main_widget.cpp:4075:2: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] sioyek-2.0.0/pdf_viewer/main_widget.cpp:4516:9: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] sioyek-2.0.0/pdf_viewer/main_widget.h:38:18: style:inconclusive: Member variable 'MainWidget::command_manager' is in the wrong place in the initializer list. [initializerList] sioyek-2.0.0/pdf_viewer/main_widget.cpp:336:5: note: Member variable 'MainWidget::command_manager' is in the wrong place in the initializer list. sioyek-2.0.0/pdf_viewer/main_widget.h:38:18: note: Member variable 'MainWidget::command_manager' is in the wrong place in the initializer list. sioyek-2.0.0/pdf_viewer/coordinates.h:81:4: style:inconclusive: Technically the member function 'Vec < int , 2 >::x' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/coordinates.h:85:4: style:inconclusive: Technically the member function 'Vec < int , 2 >::y' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/coordinates.h:89:4: style:inconclusive: Technically the member function 'Vec < int , 2 >::width' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/coordinates.h:93:4: style:inconclusive: Technically the member function 'Vec < int , 2 >::height' can be const. [functionConst] sioyek-2.0.0/pdf_viewer/coordinates.h:38:2: style: Struct 'Vec < int , 2 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] sioyek-2.0.0/pdf_viewer/coordinates.h:43:2: style: Struct 'Vec < int , 2 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] sioyek-2.0.0/pdf_viewer/coordinates.h:48:2: style: Struct 'Vec < int , 2 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] sioyek-2.0.0/pdf_viewer/coordinates.h:53:2: style: Struct 'Vec < int , 2 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] sioyek-2.0.0/pdf_viewer/coordinates.h:63:2: style: Struct 'Vec < int , 2 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] sioyek-2.0.0/pdf_viewer/ui.h:452:10: style: The function 'get_view_stylesheet_type_name' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] sioyek-2.0.0/pdf_viewer/ui.h:145:18: note: Virtual function in base class sioyek-2.0.0/pdf_viewer/ui.h:452:10: note: Function in derived class sioyek-2.0.0/pdf_viewer/ui.h:486:7: style: The function 'on_select' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] sioyek-2.0.0/pdf_viewer/ui.h:131:15: note: Virtual function in base class sioyek-2.0.0/pdf_viewer/ui.h:486:7: note: Function in derived class sioyek-2.0.0/pdf_viewer/ui.h:348:10: style: The function 'get_view_stylesheet_type_name' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] sioyek-2.0.0/pdf_viewer/ui.h:145:18: note: Virtual function in base class sioyek-2.0.0/pdf_viewer/ui.h:348:10: note: Function in derived class sioyek-2.0.0/pdf_viewer/ui.h:411:23: style: The function 'get_selected_text' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] sioyek-2.0.0/pdf_viewer/ui.h:160:23: note: Virtual function in base class sioyek-2.0.0/pdf_viewer/ui.h:411:23: note: Function in derived class sioyek-2.0.0/pdf_viewer/ui.h:431:7: style: The function 'on_select' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] sioyek-2.0.0/pdf_viewer/ui.h:131:15: note: Virtual function in base class sioyek-2.0.0/pdf_viewer/ui.h:431:7: note: Function in derived class sioyek-2.0.0/pdf_viewer/ui.h:293:10: style: The function 'get_view_stylesheet_type_name' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] sioyek-2.0.0/pdf_viewer/ui.h:145:18: note: Virtual function in base class sioyek-2.0.0/pdf_viewer/ui.h:293:10: note: Function in derived class sioyek-2.0.0/pdf_viewer/ui.h:321:7: style: The function 'on_select' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] sioyek-2.0.0/pdf_viewer/ui.h:131:15: note: Virtual function in base class sioyek-2.0.0/pdf_viewer/ui.h:321:7: note: Function in derived class sioyek-2.0.0/pdf_viewer/main_widget.cpp:960:31: warning: Either the condition 'link_owner' is redundant or there is possible null pointer dereference: link_owner. [nullPointerRedundantCheck] sioyek-2.0.0/pdf_viewer/main_widget.cpp:956:9: note: Assuming that condition 'link_owner' is not redundant sioyek-2.0.0/pdf_viewer/main_widget.cpp:960:31: note: Null pointer dereference sioyek-2.0.0/pdf_viewer/main_widget.cpp:1086:9: warning: Either the condition 'main_document_view' is redundant or there is possible null pointer dereference: main_document_view. [nullPointerRedundantCheck] sioyek-2.0.0/pdf_viewer/main_widget.cpp:1082:9: note: Assuming that condition 'main_document_view' is not redundant sioyek-2.0.0/pdf_viewer/main_widget.cpp:1086:9: note: Null pointer dereference sioyek-2.0.0/pdf_viewer/main_widget.cpp:244:37: style: Redundant initialization for 'link'. The initialized value is overwritten before it is read. [redundantInitialization] sioyek-2.0.0/pdf_viewer/main_widget.cpp:191:33: note: link is initialized sioyek-2.0.0/pdf_viewer/main_widget.cpp:244:37: note: link is overwritten sioyek-2.0.0/pdf_viewer/main_widget.cpp:889:9: style: The scope of the variable 'target_page' can be reduced. [variableScope] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3160:26: style: The scope of the variable 'visible_pages' can be reduced. [variableScope] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3843:15: style: The scope of the variable 'first_page_width' can be reduced. [variableScope] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3844:15: style: The scope of the variable 'first_page_height' can be reduced. [variableScope] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3899:10: style: The scope of the variable 'config_string_multi' can be reduced. [variableScope] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3900:10: style: The scope of the variable 'config_string_single' can be reduced. [variableScope] sioyek-2.0.0/pdf_viewer/main_widget.cpp:1061:55: style:inconclusive: Function 'open_document' argument 1 names different: declaration 'checksum' definition 'lvs'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/main_widget.h:262:44: note: Function 'open_document' argument 1 names different: declaration 'checksum' definition 'lvs'. sioyek-2.0.0/pdf_viewer/main_widget.cpp:1061:55: note: Function 'open_document' argument 1 names different: declaration 'checksum' definition 'lvs'. sioyek-2.0.0/pdf_viewer/main_widget.cpp:1071:61: style:inconclusive: Function 'open_document_with_hash' argument 1 names different: declaration 'hash' definition 'path'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/main_widget.h:259:50: note: Function 'open_document_with_hash' argument 1 names different: declaration 'hash' definition 'path'. sioyek-2.0.0/pdf_viewer/main_widget.cpp:1071:61: note: Function 'open_document_with_hash' argument 1 names different: declaration 'hash' definition 'path'. sioyek-2.0.0/pdf_viewer/main_widget.cpp:1134:56: style:inconclusive: Function 'open_document_at_location' argument 1 names different: declaration 'path' definition 'path_'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/main_widget.h:260:45: note: Function 'open_document_at_location' argument 1 names different: declaration 'path' definition 'path_'. sioyek-2.0.0/pdf_viewer/main_widget.cpp:1134:56: note: Function 'open_document_at_location' argument 1 names different: declaration 'path' definition 'path_'. sioyek-2.0.0/pdf_viewer/main_widget.cpp:1606:41: style:inconclusive: Function 'handle_click' argument 1 names different: declaration 'pos' definition 'click_pos'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/main_widget.h:182:30: note: Function 'handle_click' argument 1 names different: declaration 'pos' definition 'click_pos'. sioyek-2.0.0/pdf_viewer/main_widget.cpp:1606:41: note: Function 'handle_click' argument 1 names different: declaration 'pos' definition 'click_pos'. sioyek-2.0.0/pdf_viewer/main_widget.cpp:1631:64: style:inconclusive: Function 'find_location_of_text_under_pointer' argument 1 names different: declaration 'pos' definition 'pointer_pos'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/main_widget.h:283:53: note: Function 'find_location_of_text_under_pointer' argument 1 names different: declaration 'pos' definition 'pointer_pos'. sioyek-2.0.0/pdf_viewer/main_widget.cpp:1631:64: note: Function 'find_location_of_text_under_pointer' argument 1 names different: declaration 'pos' definition 'pointer_pos'. sioyek-2.0.0/pdf_viewer/main_widget.cpp:3717:10: style:inconclusive: Function 'open_document' argument 5 names different: declaration 'foce_load_dimensions' definition 'force_load_dimensions'. [funcArgNamesDifferent] sioyek-2.0.0/pdf_viewer/main_widget.h:145:153: note: Function 'open_document' argument 5 names different: declaration 'foce_load_dimensions' definition 'force_load_dimensions'. sioyek-2.0.0/pdf_viewer/main_widget.cpp:3717:10: note: Function 'open_document' argument 5 names different: declaration 'foce_load_dimensions' definition 'force_load_dimensions'. sioyek-2.0.0/pdf_viewer/main_widget.cpp:1074:14: style: Local variable 'path' shadows outer argument [shadowArgument] sioyek-2.0.0/pdf_viewer/main_widget.cpp:1071:61: note: Shadowed declaration sioyek-2.0.0/pdf_viewer/main_widget.cpp:1074:14: note: Shadow variable sioyek-2.0.0/pdf_viewer/main_widget.cpp:1803:10: style: Local variable 'is_visual_mark_mode' shadows outer function [shadowFunction] sioyek-2.0.0/pdf_viewer/main_widget.h:220:7: note: Shadowed declaration sioyek-2.0.0/pdf_viewer/main_widget.cpp:1803:10: note: Shadow variable sioyek-2.0.0/pdf_viewer/main_widget.cpp:2278:16: style: Local variable 'doc' shadows outer function [shadowFunction] sioyek-2.0.0/pdf_viewer/main_widget.h:232:12: note: Shadowed declaration sioyek-2.0.0/pdf_viewer/main_widget.cpp:2278:16: note: Shadow variable sioyek-2.0.0/pdf_viewer/main_widget.cpp:3495:26: style: Local variable 'command_parts_' shadows outer variable [shadowVariable] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3406:17: note: Shadowed declaration sioyek-2.0.0/pdf_viewer/main_widget.cpp:3495:26: note: Shadow variable sioyek-2.0.0/pdf_viewer/main_widget.cpp:3607:13: style: Local variable 'main_window_width' shadows outer variable [shadowVariable] sioyek-2.0.0/pdf_viewer/main_widget.h:112:6: note: Shadowed declaration sioyek-2.0.0/pdf_viewer/main_widget.cpp:3607:13: note: Shadow variable sioyek-2.0.0/pdf_viewer/main_widget.cpp:3608:13: style: Local variable 'main_window_height' shadows outer variable [shadowVariable] sioyek-2.0.0/pdf_viewer/main_widget.h:113:6: note: Shadowed declaration sioyek-2.0.0/pdf_viewer/main_widget.cpp:3608:13: note: Shadow variable sioyek-2.0.0/pdf_viewer/main_widget.cpp:3638:9: style: Local variable 'main_window_width' shadows outer variable [shadowVariable] sioyek-2.0.0/pdf_viewer/main_widget.h:112:6: note: Shadowed declaration sioyek-2.0.0/pdf_viewer/main_widget.cpp:3638:9: note: Shadow variable sioyek-2.0.0/pdf_viewer/main_widget.cpp:3673:9: style: Local variable 'main_window_width' shadows outer variable [shadowVariable] sioyek-2.0.0/pdf_viewer/main_widget.h:112:6: note: Shadowed declaration sioyek-2.0.0/pdf_viewer/main_widget.cpp:3673:9: note: Shadow variable sioyek-2.0.0/pdf_viewer/main_widget.cpp:4247:24: style: Local variable 'doc' shadows outer function [shadowFunction] sioyek-2.0.0/pdf_viewer/main_widget.h:232:12: note: Shadowed declaration sioyek-2.0.0/pdf_viewer/main_widget.cpp:4247:24: note: Shadow variable sioyek-2.0.0/pdf_viewer/main_widget.cpp:399:39: performance: Function parameter 'command_name' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/main_widget.cpp:1595:65: performance: Function parameter 'new_view_state' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/main_widget.cpp:2523:19: performance: Range variable 'highlight' should be declared as const reference. [iterateByValue] sioyek-2.0.0/pdf_viewer/main_widget.cpp:2737:19: performance: Range variable 'path' should be declared as const reference. [iterateByValue] sioyek-2.0.0/pdf_viewer/main_widget.cpp:2756:19: performance: Range variable 'path' should be declared as const reference. [iterateByValue] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3084:59: performance: Function parameter 'text' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3393:47: performance: Function parameter 'command' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3393:69: performance: Function parameter 'text' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3503:60: performance: Function parameter 'paper_name' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3778:69: performance: Function parameter 'tag' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3797:61: performance: Function parameter 'tag' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/main_widget.cpp:4133:80: performance: Function parameter 'text' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/main_widget.cpp:4189:50: performance: Function parameter 'new_status_string' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/main_widget.cpp:4241:42: performance: Function parameter 'source_path' should be passed by const reference. [passedByValue] sioyek-2.0.0/pdf_viewer/main_widget.cpp:4345:15: performance: Range variable 'command' should be declared as const reference. [iterateByValue] sioyek-2.0.0/pdf_viewer/main_widget.cpp:4509:27: style: Variable 'prev' can be declared as reference to const [constVariableReference] sioyek-2.0.0/pdf_viewer/main_widget.cpp:2326:118: style: Parameter 'page_value' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/main_widget.cpp:2341:34: style: Variable 'toc_node' can be declared as pointer to const [constVariablePointer] sioyek-2.0.0/pdf_viewer/main_widget.cpp:2374:13: style: Parameter 'window_id' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/main_widget.cpp:2412:21: style: Parameter 'doc_hash' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/main_widget.cpp:2419:22: style: Parameter 'doc_hash' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/main_widget.cpp:2469:24: style: Parameter 'offset_value' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/main_widget.cpp:2477:28: style: Parameter 'offset_value' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/main_widget.cpp:2536:28: style: Parameter 'hl' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/main_widget.cpp:2544:32: style: Parameter 'hl' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/main_widget.cpp:2574:28: style: Parameter 'book_state' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/main_widget.cpp:2581:28: style: Parameter 'book_state' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/main_widget.cpp:2621:28: style: Parameter 'book_state' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/main_widget.cpp:2744:31: style: Parameter 'path' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/main_widget.cpp:2763:31: style: Parameter 'path' can be declared as pointer to const [constParameterPointer] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3811:41: error: Out of bounds access in expression 'all_word_chars[index]' because 'all_word_chars' is empty. [containerOutOfBounds] sioyek-2.0.0/pdf_viewer/main_widget.cpp:307:24: performance: Passing the result of c_str() to a stream is slow and redundant. [stlcstrStream] sioyek-2.0.0/pdf_viewer/main_widget.cpp:1966:22: performance: Passing the result of c_str() to a function that takes std::string as argument no. 1 is slow and redundant. [stlcstrParam] sioyek-2.0.0/pdf_viewer/main_widget.cpp:2687:9: performance: Passing the result of c_str() to a function that takes std::wstring as argument no. 1 is slow and redundant. [stlcstrParam] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3212:13: performance: Passing the result of c_str() to a function that takes std::wstring as argument no. 1 is slow and redundant. [stlcstrParam] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3226:13: performance: Passing the result of c_str() to a function that takes std::wstring as argument no. 1 is slow and redundant. [stlcstrParam] sioyek-2.0.0/pdf_viewer/main_widget.cpp:2738:33: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/main_widget.cpp:2757:32: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3762:30: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3789:17: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3788:27: style: Iterating over container 'word_char_rects' that is always empty. [knownEmptyContainer] sioyek-2.0.0/pdf_viewer/main_widget.cpp:165:21: style: Variable 'page_height' is assigned a value that is never used. [unreadVariable] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3495:41: style: Variable 'command_parts_' is assigned a value that is never used. [unreadVariable] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3904:31: style: Variable 'helper_window_size_w' is assigned a value that is never used. [unreadVariable] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3905:31: style: Variable 'helper_window_size_h' is assigned a value that is never used. [unreadVariable] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3908:31: style: Variable 'helper_window_move_x' is assigned a value that is never used. [unreadVariable] sioyek-2.0.0/pdf_viewer/main_widget.cpp:3909:31: style: Variable 'helper_window_move_y' is assigned a value that is never used. [unreadVariable] sioyek-2.0.0/pdf_viewer/main_widget.cpp:4175:34: style: Variable 'res' is assigned a value that is never used. [unreadVariable] sioyek-2.0.0/pdf_viewer/main_widget.cpp:4306:23: style: Variable 'w' is assigned a value that is never used. [unreadVariable] sioyek-2.0.0/pdf_viewer/main_widget.cpp:4302:37: style: Variable 'srect_' is assigned a value that is never used. [unreadVariable] diff: DONE