2022-06-30 21:36
ftp://ftp.de.debian.org/debian/pool/main/s/sidplay/sidplay_2.0.9.orig.tar.gz
cppcheck-options: --library=posix --library=gnu  --showtime=top5 --check-library --inconclusive --enable=style,information --inline-suppr --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j1
platform: Linux-5.4.0-121-generic-x86_64-with-glibc2.29
python: 3.8.10
client-version: 1.3.25
compiler: g++ (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
cppcheck: head 2.8
head-info: 27578e9 (2022-06-30 13:50:31 +0200)
count: 31 31
elapsed-time: 8.7 15.7
head-timing-info:
 Tokenizer::simplifyTokens1: 8.57418s (avg. 1.07177s - 8 result(s))
 Tokenizer::simplifyTokens1::ValueFlow: 8.46128s (avg. 1.05766s - 8 result(s))
 Tokenizer::simplifyTokens1::createSymbolDatabase: 0.061214s (avg. 0.00765175s - 8 result(s))
 Tokenizer::createTokens: 0.020868s (avg. 0.0013912s - 15 result(s))
 Tokenizer::simplifyTokens1::setValueType: 0.009862s (avg. 0.00123275s - 8 result(s))
 Overall time: 17.1849s

old-timing-info:
 Tokenizer::simplifyTokens1: 15.6264s (avg. 1.9533s - 8 result(s))
 Tokenizer::simplifyTokens1::ValueFlow: 15.5013s (avg. 1.93766s - 8 result(s))
 Tokenizer::simplifyTokens1::createSymbolDatabase: 0.068721s (avg. 0.00859013s - 8 result(s))
 Tokenizer::createTokens: 0.022393s (avg. 0.00149287s - 15 result(s))
 Tokenizer::simplifyTokens1::setValueType: 0.010075s (avg. 0.00125938s - 8 result(s))
 Overall time: 31.2911s

head results:
sidplay-2.0.9/src/IniConfig.h:102:11: performance:inconclusive: Technically the member function 'IniConfig::readString' can be static (but you may consider moving to unnamed namespace). [functionStatic]
sidplay-2.0.9/src/IniConfig.cpp:137:17: note: Technically the member function 'IniConfig::readString' can be static (but you may consider moving to unnamed namespace).
sidplay-2.0.9/src/IniConfig.h:102:11: note: Technically the member function 'IniConfig::readString' can be static (but you may consider moving to unnamed namespace).
sidplay-2.0.9/src/IniConfig.h:117:5: style:inconclusive: Technically the member function 'IniConfig::operatorbool' can be const. [functionConst]
sidplay-2.0.9/src/IniConfig.h:120:30: style:inconclusive: Technically the member function 'IniConfig::sidplay2' can be const. [functionConst]
sidplay-2.0.9/src/IniConfig.h:121:30: style:inconclusive: Technically the member function 'IniConfig::console' can be const. [functionConst]
sidplay-2.0.9/src/IniConfig.h:122:30: style:inconclusive: Technically the member function 'IniConfig::audio' can be const. [functionConst]
sidplay-2.0.9/src/IniConfig.h:123:30: style:inconclusive: Technically the member function 'IniConfig::emulation' can be const. [functionConst]
sidplay-2.0.9/src/IniConfig.cpp:151:11: style: C-style pointer casting [cstyleCast]
sidplay-2.0.9/src/IniConfig.cpp:388:20: style: C-style pointer casting [cstyleCast]
sidplay-2.0.9/src/IniConfig.cpp:394:16: style: C-style pointer casting [cstyleCast]
sidplay-2.0.9/src/IniConfig.cpp:400:18: style: C-style pointer casting [cstyleCast]
sidplay-2.0.9/src/IniConfig.cpp:209:57: style:inconclusive: Function 'readTime' argument 3 names different: declaration 'time' definition 'value'. [funcArgNamesDifferent]
sidplay-2.0.9/src/IniConfig.h:105:54: note: Function 'readTime' argument 3 names different: declaration 'time' definition 'value'.
sidplay-2.0.9/src/IniConfig.cpp:209:57: note: Function 'readTime' argument 3 names different: declaration 'time' definition 'value'.
sidplay-2.0.9/src/player.h:211:5: style: Class 'ConsolePlayer' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
sidplay-2.0.9/src/audio/null/null.h:56:11: style: The function 'open' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride]
sidplay-2.0.9/src/audio/AudioBase.h:58:19: note: Virtual function in base class
sidplay-2.0.9/src/audio/null/null.h:56:11: note: Function in derived class
sidplay-2.0.9/src/audio/null/null.h:57:11: style: The function 'close' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride]
sidplay-2.0.9/src/audio/AudioBase.h:64:19: note: Virtual function in base class
sidplay-2.0.9/src/audio/null/null.h:57:11: note: Function in derived class
sidplay-2.0.9/src/audio/null/null.h:58:11: style: The function 'reset' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride]
sidplay-2.0.9/src/audio/AudioBase.h:62:19: note: Virtual function in base class
sidplay-2.0.9/src/audio/null/null.h:58:11: note: Function in derived class
sidplay-2.0.9/src/audio/null/null.h:59:11: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride]
sidplay-2.0.9/src/audio/AudioBase.h:63:19: note: Virtual function in base class
sidplay-2.0.9/src/audio/null/null.h:59:11: note: Function in derived class
sidplay-2.0.9/src/audio/null/null.h:60:11: style: The function 'pause' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride]
sidplay-2.0.9/src/audio/AudioBase.h:65:19: note: Virtual function in base class
sidplay-2.0.9/src/audio/null/null.h:60:11: note: Function in derived class
sidplay-2.0.9/src/audio/wav/WavFile.h:96:11: style: The function 'open' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride]
sidplay-2.0.9/src/audio/AudioBase.h:58:19: note: Virtual function in base class
sidplay-2.0.9/src/audio/wav/WavFile.h:96:11: note: Function in derived class
sidplay-2.0.9/src/audio/wav/WavFile.h:103:11: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride]
sidplay-2.0.9/src/audio/AudioBase.h:63:19: note: Virtual function in base class
sidplay-2.0.9/src/audio/wav/WavFile.h:103:11: note: Function in derived class
sidplay-2.0.9/src/audio/wav/WavFile.h:104:11: style: The function 'close' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride]
sidplay-2.0.9/src/audio/AudioBase.h:64:19: note: Virtual function in base class
sidplay-2.0.9/src/audio/wav/WavFile.h:104:11: note: Function in derived class
sidplay-2.0.9/src/audio/wav/WavFile.h:105:11: style: The function 'pause' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride]
sidplay-2.0.9/src/audio/AudioBase.h:65:19: note: Virtual function in base class
sidplay-2.0.9/src/audio/wav/WavFile.h:105:11: note: Function in derived class
sidplay-2.0.9/src/audio/wav/WavFile.h:106:17: style: The function 'extension' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride]
sidplay-2.0.9/src/audio/AudioBase.h:66:25: note: Virtual function in base class
sidplay-2.0.9/src/audio/wav/WavFile.h:106:17: note: Function in derived class
sidplay-2.0.9/src/audio/wav/WavFile.h:110:11: style: The function 'reset' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride]
sidplay-2.0.9/src/audio/AudioBase.h:62:19: note: Virtual function in base class
sidplay-2.0.9/src/audio/wav/WavFile.h:110:11: note: Function in derived class
sidplay-2.0.9/src/audio/null/null.cpp:115:15: style: C-style pointer casting [cstyleCast]
sidplay-2.0.9/src/audio/wav/WavFile.cpp:83:10: warning: Member variable 'WavFile::byteCount' is not initialized in the constructor. [uninitMemberVar]
sidplay-2.0.9/src/audio/wav/WavFile.cpp:173:20: style: C-style pointer casting [cstyleCast]
sidplay-2.0.9/src/audio/wav/WavFile.cpp:188:19: style: C-style pointer casting [cstyleCast]
sidplay-2.0.9/src/player.cpp:493:26: style:inconclusive: Boolean expression 'm_timer.start>=m_timer.stop' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean]
sidplay-2.0.9/src/player.cpp:325:31: style: The statement 'if (m_engCfg.playback!=sid2_stereo) m_engCfg.playback=sid2_stereo' is logically equivalent to 'm_engCfg.playback=sid2_stereo'. [duplicateConditionalAssign]
sidplay-2.0.9/src/player.cpp:326:32: note: Assignment 'm_engCfg.playback=sid2_stereo'
sidplay-2.0.9/src/player.cpp:325:31: note: Condition 'm_engCfg.playback!=sid2_stereo' is redundant
sidplay-2.0.9/src/player.cpp:696:9: style: The scope of the variable 'action' can be reduced. [variableScope]
sidplay-2.0.9/src/player.cpp:422:1: style: Label 'createSidEmu_error' is not used. [unusedLabel]
diff:


DONE