2022-06-25 00:49 ftp://ftp.de.debian.org/debian/pool/main/r/roxterm/roxterm_2.9.5.orig.tar.bz2 cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j1 platform: Linux-5.4.0-121-generic-x86_64-with-glibc2.29 python: 3.8.10 client-version: 1.3.24 compiler: g++ (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0 cppcheck: head 2.8 head-info: 11860cc (2022-06-24 13:55:04 +0200) count: 65 65 elapsed-time: 18.3 20.9 head-timing-info: Tokenizer::simplifyTokens1: 5.2223s (avg. 0.180079s - 29 result(s)) Tokenizer::simplifyTokens1::ValueFlow: 4.6266s (avg. 0.159538s - 29 result(s)) Tokenizer::simplifyTokens1::createSymbolDatabase: 0.280951s (avg. 0.00968797s - 29 result(s)) UnusedVar::runChecks: 0.114419s (avg. 0.00394548s - 29 result(s)) Check function usage::runChecks: 0.097679s (avg. 0.00336824s - 29 result(s)) Overall time: 10.8492s old-timing-info: Tokenizer::simplifyTokens1: 6.0789s (avg. 0.209617s - 29 result(s)) Tokenizer::simplifyTokens1::ValueFlow: 5.49098s (avg. 0.189344s - 29 result(s)) Tokenizer::simplifyTokens1::createSymbolDatabase: 0.281135s (avg. 0.00969431s - 29 result(s)) UnusedVar::runChecks: 0.146256s (avg. 0.00504331s - 29 result(s)) Tokenizer::createTokens: 0.09565s (avg. 0.00329828s - 29 result(s)) Overall time: 12.5863s head results: roxterm-2.9.5/src/colourgui.c:699:39: style:inconclusive: Function 'colourgui_open' argument 1 names different: declaration 'colour_scheme_name' definition 'scheme_name'. [funcArgNamesDifferent] roxterm-2.9.5/src/colourgui.h:33:39: note: Function 'colourgui_open' argument 1 names different: declaration 'colour_scheme_name' definition 'scheme_name'. roxterm-2.9.5/src/colourgui.c:699:39: note: Function 'colourgui_open' argument 1 names different: declaration 'colour_scheme_name' definition 'scheme_name'. roxterm-2.9.5/src/colourscheme.c:68:51: style:inconclusive: Function 'colour_scheme_lookup_and_ref' argument 1 names different: declaration 'scheme' definition 'scheme_name'. [funcArgNamesDifferent] roxterm-2.9.5/src/colourscheme.h:27:51: note: Function 'colour_scheme_lookup_and_ref' argument 1 names different: declaration 'scheme' definition 'scheme_name'. roxterm-2.9.5/src/colourscheme.c:68:51: note: Function 'colour_scheme_lookup_and_ref' argument 1 names different: declaration 'scheme' definition 'scheme_name'. roxterm-2.9.5/src/configlet.c:170:74: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/configlet.c:173:29: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/configlet.c:592:74: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/configlet.c:623:74: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/configlet.c:626:21: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/configlet.c:867:25: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/encodings.c:56:61: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/menutree.c:502:37: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/menutree.c:507:49: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/menutree.c:522:55: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/menutree.c:530:34: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/menutree.c:539:34: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/menutree.c:551:53: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/menutree.c:573:63: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/menutree.c:596:13: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/menutree.c:602:13: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/menutree.c:619:30: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/menutree.c:626:49: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/menutree.c:642:24: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/menutree.c:853:17: style:inconclusive: Function 'menutree_change_tab_title' argument 2 names different: declaration 'widget' definition 'menu_item'. [funcArgNamesDifferent] roxterm-2.9.5/src/menutree.h:219:16: note: Function 'menutree_change_tab_title' argument 2 names different: declaration 'widget' definition 'menu_item'. roxterm-2.9.5/src/menutree.c:853:17: note: Function 'menutree_change_tab_title' argument 2 names different: declaration 'widget' definition 'menu_item'. roxterm-2.9.5/src/menutree.c:806:18: style: Variable 'position' is assigned a value that is never used. [unreadVariable] roxterm-2.9.5/src/multitab-close-button.c:116:54: style:inconclusive: Function 'multitab_close_button_set_image' argument 1 names different: declaration 'btn' definition 'self'. [funcArgNamesDifferent] roxterm-2.9.5/src/multitab-close-button.h:70:54: note: Function 'multitab_close_button_set_image' argument 1 names different: declaration 'btn' definition 'self'. roxterm-2.9.5/src/multitab-close-button.c:116:54: note: Function 'multitab_close_button_set_image' argument 1 names different: declaration 'btn' definition 'self'. roxterm-2.9.5/src/multitab-label.c:346:43: style:inconclusive: Function 'multitab_label_set_parent' argument 1 names different: declaration 'label' definition 'self'. [funcArgNamesDifferent] roxterm-2.9.5/src/multitab-label.h:90:43: note: Function 'multitab_label_set_parent' argument 1 names different: declaration 'label' definition 'self'. roxterm-2.9.5/src/multitab-label.c:346:43: note: Function 'multitab_label_set_parent' argument 1 names different: declaration 'label' definition 'self'. roxterm-2.9.5/src/multitab-label.c:359:41: style:inconclusive: Function 'multitab_label_set_text' argument 1 names different: declaration 'label' definition 'self'. [funcArgNamesDifferent] roxterm-2.9.5/src/multitab-label.h:94:41: note: Function 'multitab_label_set_text' argument 1 names different: declaration 'label' definition 'self'. roxterm-2.9.5/src/multitab-label.c:359:41: note: Function 'multitab_label_set_text' argument 1 names different: declaration 'label' definition 'self'. roxterm-2.9.5/src/multitab-label.c:365:41: style:inconclusive: Function 'multitab_label_get_text' argument 1 names different: declaration 'label' definition 'self'. [funcArgNamesDifferent] roxterm-2.9.5/src/multitab-label.h:97:41: note: Function 'multitab_label_get_text' argument 1 names different: declaration 'label' definition 'self'. roxterm-2.9.5/src/multitab-label.c:365:41: note: Function 'multitab_label_get_text' argument 1 names different: declaration 'label' definition 'self'. roxterm-2.9.5/src/multitab-label.c:371:47: style:inconclusive: Function 'multitab_label_draw_attention' argument 1 names different: declaration 'label' definition 'self'. [funcArgNamesDifferent] roxterm-2.9.5/src/multitab-label.h:100:47: note: Function 'multitab_label_draw_attention' argument 1 names different: declaration 'label' definition 'self'. roxterm-2.9.5/src/multitab-label.c:371:47: note: Function 'multitab_label_draw_attention' argument 1 names different: declaration 'label' definition 'self'. roxterm-2.9.5/src/multitab-label.c:380:49: style:inconclusive: Function 'multitab_label_cancel_attention' argument 1 names different: declaration 'label' definition 'self'. [funcArgNamesDifferent] roxterm-2.9.5/src/multitab-label.h:103:49: note: Function 'multitab_label_cancel_attention' argument 1 names different: declaration 'label' definition 'self'. roxterm-2.9.5/src/multitab-label.c:380:49: note: Function 'multitab_label_cancel_attention' argument 1 names different: declaration 'label' definition 'self'. roxterm-2.9.5/src/multitab-label.c:395:52: style:inconclusive: Function 'multitab_label_set_attention_color' argument 1 names different: declaration 'label' definition 'self'. [funcArgNamesDifferent] roxterm-2.9.5/src/multitab-label.h:106:52: note: Function 'multitab_label_set_attention_color' argument 1 names different: declaration 'label' definition 'self'. roxterm-2.9.5/src/multitab-label.c:395:52: note: Function 'multitab_label_set_attention_color' argument 1 names different: declaration 'label' definition 'self'. roxterm-2.9.5/src/multitab-label.c:411:52: style:inconclusive: Function 'multitab_label_get_attention_color' argument 1 names different: declaration 'label' definition 'self'. [funcArgNamesDifferent] roxterm-2.9.5/src/multitab-label.h:110:52: note: Function 'multitab_label_get_attention_color' argument 1 names different: declaration 'label' definition 'self'. roxterm-2.9.5/src/multitab-label.c:411:52: note: Function 'multitab_label_get_attention_color' argument 1 names different: declaration 'label' definition 'self'. roxterm-2.9.5/src/multitab-label.c:417:43: style:inconclusive: Function 'multitab_label_set_single' argument 1 names different: declaration 'label' definition 'self'. [funcArgNamesDifferent] roxterm-2.9.5/src/multitab-label.h:114:43: note: Function 'multitab_label_set_single' argument 1 names different: declaration 'label' definition 'self'. roxterm-2.9.5/src/multitab-label.c:417:43: note: Function 'multitab_label_set_single' argument 1 names different: declaration 'label' definition 'self'. roxterm-2.9.5/src/multitab-label.c:433:48: style:inconclusive: Function 'multitab_label_set_fixed_width' argument 1 names different: declaration 'label' definition 'self'. [funcArgNamesDifferent] roxterm-2.9.5/src/multitab-label.h:118:48: note: Function 'multitab_label_set_fixed_width' argument 1 names different: declaration 'label' definition 'self'. roxterm-2.9.5/src/multitab-label.c:433:48: note: Function 'multitab_label_set_fixed_width' argument 1 names different: declaration 'label' definition 'self'. roxterm-2.9.5/src/multitab.c:2209:13: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] roxterm-2.9.5/src/multitab.c:2424:47: style:inconclusive: Function 'multi_win_menu_connect_data' argument 8 names different: declaration 'short_pupup_id' definition 'short_popup_id'. [funcArgNamesDifferent] roxterm-2.9.5/src/multitab.h:321:47: note: Function 'multi_win_menu_connect_data' argument 8 names different: declaration 'short_pupup_id' definition 'short_popup_id'. roxterm-2.9.5/src/multitab.c:2424:47: note: Function 'multi_win_menu_connect_data' argument 8 names different: declaration 'short_pupup_id' definition 'short_popup_id'. roxterm-2.9.5/src/multitab.c:977:59: style: Parameter 'tree' can be declared as pointer to const [constParameter] roxterm-2.9.5/src/multitab.c:2209:17: style: Variable 'tab' is assigned a value that is never used. [unreadVariable] roxterm-2.9.5/src/options.c:141:23: style:inconclusive: Function 'options_lookup_int_with_default' argument 3 names different: declaration 'd' definition 'default_value'. [funcArgNamesDifferent] roxterm-2.9.5/src/options.h:77:77: note: Function 'options_lookup_int_with_default' argument 3 names different: declaration 'd' definition 'default_value'. roxterm-2.9.5/src/options.c:141:23: note: Function 'options_lookup_int_with_default' argument 3 names different: declaration 'd' definition 'default_value'. roxterm-2.9.5/src/optsfile.c:353:7: style: Condition 'err' is always true [knownConditionTrueFalse] roxterm-2.9.5/src/optsfile.c:219:49: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/optsfile.c:334:60: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/optsfile.c:439:61: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/optsfile.c:454:65: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/optsfile.c:486:68: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/optsfile.c:489:66: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/optsfile.c:197:47: style:inconclusive: Function 'options_file_build_filename' argument 1 names different: declaration 'filename' definition 'first_element'. [funcArgNamesDifferent] roxterm-2.9.5/src/optsfile.h:44:47: note: Function 'options_file_build_filename' argument 1 names different: declaration 'filename' definition 'first_element'. roxterm-2.9.5/src/optsfile.c:197:47: note: Function 'options_file_build_filename' argument 1 names different: declaration 'filename' definition 'first_element'. roxterm-2.9.5/src/optsfile.c:310:52: style:inconclusive: Function 'options_file_filename_for_saving' argument 1 names different: declaration 'filename' definition 'leafname'. [funcArgNamesDifferent] roxterm-2.9.5/src/optsfile.h:48:52: note: Function 'options_file_filename_for_saving' argument 1 names different: declaration 'filename' definition 'leafname'. roxterm-2.9.5/src/optsfile.c:310:52: note: Function 'options_file_filename_for_saving' argument 1 names different: declaration 'filename' definition 'leafname'. roxterm-2.9.5/src/profilegui.c:448:22: warning: Redundant assignment of 'first_file' to itself. [selfAssignment] roxterm-2.9.5/src/profilegui.c:525:26: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/profilegui.c:535:33: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/profilegui.c:545:24: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] roxterm-2.9.5/src/roxterm.c:604:28: portability: Non reentrant function 'getpwuid' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getpwuid_r'. [prohibitedgetpwuidCalled] roxterm-2.9.5/src/roxterm.c:4378:13: style: Condition '!geom' is always false [knownConditionTrueFalse] roxterm-2.9.5/src/roxterm.c:870:15: style: Variable 'reply' is reassigned a value before the old one has been used. [redundantAssignment] roxterm-2.9.5/src/roxterm.c:849:19: note: reply is assigned roxterm-2.9.5/src/roxterm.c:870:15: note: reply is overwritten roxterm-2.9.5/src/roxterm.c:3600:54: style: Parameter 'profile' can be declared as pointer to const [constParameter] roxterm-2.9.5/src/roxterm.c:3870:52: style: Parameter 'scheme' can be declared as pointer to const [constParameter] roxterm-2.9.5/src/roxterm.c:577:9: style: Variable 'n' is assigned a value that is never used. [unreadVariable] roxterm-2.9.5/src/roxterm.c:2285:17: style: Variable 'sep' is assigned a value that is never used. [unreadVariable] roxterm-2.9.5/src/roxterm.c:4258:15: style: Variable 'g' is assigned a value that is never used. [unreadVariable] roxterm-2.9.5/src/roxterm.c:4543:13: style: Variable 'win' is assigned a value that is never used. [unreadVariable] roxterm-2.9.5/src/roxterm.c:4550:13: style: Variable 'win' is assigned a value that is never used. [unreadVariable] roxterm-2.9.5/src/roxterm.c:4572:13: style: Variable 'win' is assigned a value that is never used. [unreadVariable] roxterm-2.9.5/src/search.c:236:50: style: Parameter 'widget' can be declared as pointer to const [constParameter] roxterm-2.9.5/src/shortcuts.c:135:37: style:inconclusive: Function 'shortcuts_open' argument 1 names different: declaration 'scheme_name' definition 'scheme'. [funcArgNamesDifferent] roxterm-2.9.5/src/shortcuts.h:36:37: note: Function 'shortcuts_open' argument 1 names different: declaration 'scheme_name' definition 'scheme'. roxterm-2.9.5/src/shortcuts.c:135:37: note: Function 'shortcuts_open' argument 1 names different: declaration 'scheme_name' definition 'scheme'. roxterm-2.9.5/src/shortcuts.c:256:31: style:inconclusive: Function 'shortcuts_unref' argument 1 names different: declaration 'scheme' definition 'shortcuts'. [funcArgNamesDifferent] roxterm-2.9.5/src/shortcuts.h:38:31: note: Function 'shortcuts_unref' argument 1 names different: declaration 'scheme' definition 'shortcuts'. roxterm-2.9.5/src/shortcuts.c:256:31: note: Function 'shortcuts_unref' argument 1 names different: declaration 'scheme' definition 'shortcuts'. diff: head roxterm-2.9.5/src/multitab.c:977:59: style: Parameter 'tree' can be declared as pointer to const [constParameter] 2.8 roxterm-2.9.5/src/multitab.c:977:59: style: Parameter 'tree' can be declared with const [constParameter] head roxterm-2.9.5/src/roxterm.c:3600:54: style: Parameter 'profile' can be declared as pointer to const [constParameter] 2.8 roxterm-2.9.5/src/roxterm.c:3600:54: style: Parameter 'profile' can be declared with const [constParameter] head roxterm-2.9.5/src/roxterm.c:3870:52: style: Parameter 'scheme' can be declared as pointer to const [constParameter] 2.8 roxterm-2.9.5/src/roxterm.c:3870:52: style: Parameter 'scheme' can be declared with const [constParameter] head roxterm-2.9.5/src/search.c:236:50: style: Parameter 'widget' can be declared as pointer to const [constParameter] 2.8 roxterm-2.9.5/src/search.c:236:50: style: Parameter 'widget' can be declared with const [constParameter] DONE