2025-08-28 21:36 ftp://ftp.de.debian.org/debian/pool/main/r/rawtherapee/rawtherapee_5.12.orig.tar.xz cppcheck-options: --library=posix --library=gnu --library=bsd --library=zlib --library=gtk --library=openmp --library=libsigc++ --inconclusive --enable=style,information --inline-suppr --template=daca2 --disable=missingInclude --suppress=unmatchedSuppression --check-library --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=normalCheckLevelConditionExpressions -D__GNUC__ --platform=unix64 -j4 platform: Linux-6.12.41+deb13-amd64-x86_64-with-glibc2.41 python: 3.13.5 client-version: 1.3.67 compiler: g++ (Debian 14.2.0-19) 14.2.0 cppcheck: head 2.18.0 head-info: b4f07cd (2025-08-28 18:21:59 +0200) count: 2487 3960 elapsed-time: 296.8 629.1 head-timing-info: old-timing-info: head results: rawtherapee-5.12/rtengine/metadata.h:102:0: error: failed to evaluate #if condition, undefined function-like macro invocation: EXIV2_TEST_VERSION( ... ) [preprocessorErrorDirective] rawtherapee-5.12/rtengine/metadata.h:102:2: error: failed to evaluate #if condition, undefined function-like macro invocation: EXIV2_TEST_VERSION( ... ) [preprocessorErrorDirective] rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:19:47: debug: Function::addArguments found argument 'Product' with varid 0. [varid0] rawtherapee-5.12/rtengine/alpha.cc:30:55: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FORMAT_A8 [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/alpha.cc:51:55: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FORMAT_A8 [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/sleef.h:382:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable 0.794662735614792836713604629039764404296875e [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/sleef.h:411:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable 0.794662735614792836713604629039764404296875e [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/sleef.h:443:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable 0.794662735614792836713604629039764404296875e [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/sleef.h:486:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable 0.794662735614792836713604629039764404296875e [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/sleef.h:551:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable 0.28235290563031577122588448175013436025525412068e [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/sleef.h:603:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable 0.28235290563031577122588448175013436025525412068e [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/sleef.h:648:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable 0.28235290563031577122588448175013436025525412068e [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:47:8: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Preconditioner [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:805:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/ashift_dt.c:21:1: error: Code 'using namespace std' is invalid C code. [syntaxError] rawtherapee-5.12/rtengine/ashift_nmsimplex.c:222:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NMS_ALPHA [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/ashift_lsd.c:205:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/ashift_lsd.c:242:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DBL_MIN [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/ashift_lsd.c:1532:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DBL_MAX [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/ashift_nmsimplex.c:119:5: warning: If memory allocation fails, then there is a possible null pointer dereference: v [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/ashift_nmsimplex.c:109:24: note: Assuming allocation function fails rawtherapee-5.12/rtengine/ashift_nmsimplex.c:109:7: note: Assignment 'v=(double**)malloc((n+1)*sizeof(double*))', assigned value is 0 rawtherapee-5.12/rtengine/ashift_nmsimplex.c:119:5: note: Null pointer dereference rawtherapee-5.12/rtengine/ashift_nmsimplex.c:130:5: warning: If memory allocation fails, then there is a possible null pointer dereference: v [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/ashift_nmsimplex.c:109:24: note: Assuming allocation function fails rawtherapee-5.12/rtengine/ashift_nmsimplex.c:109:7: note: Assignment 'v=(double**)malloc((n+1)*sizeof(double*))', assigned value is 0 rawtherapee-5.12/rtengine/ashift_nmsimplex.c:130:5: note: Null pointer dereference rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:251:36: style:inconclusive: Technically the member function 'MultiDiagonalSymmetricMatrix::VectorProduct' can be const. [functionConst] rawtherapee-5.12/rtengine/EdgePreservingDecomposition.h:109:10: note: Technically the member function 'MultiDiagonalSymmetricMatrix::VectorProduct' can be const. rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:251:36: note: Technically the member function 'MultiDiagonalSymmetricMatrix::VectorProduct' can be const. rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:520:36: style:inconclusive: Technically the member function 'MultiDiagonalSymmetricMatrix::CholeskyBackSolve' can be const. [functionConst] rawtherapee-5.12/rtengine/EdgePreservingDecomposition.h:127:10: note: Technically the member function 'MultiDiagonalSymmetricMatrix::CholeskyBackSolve' can be const. rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:520:36: note: Technically the member function 'MultiDiagonalSymmetricMatrix::CholeskyBackSolve' can be const. rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:25:24: error: If memory allocation fails: pointer addition with NULL pointer. [nullPointerArithmeticOutOfMemory] rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:24:35: note: Assuming allocation function fails rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:24:21: note: Assignment 'buffer=(float*)malloc(2*n*sizeof(float)+128)', assigned value is 0 rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:25:24: note: Null pointer addition rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:55:24: error:inconclusive: If memory allocation fails: pointer addition with NULL pointer. [nullPointerArithmeticOutOfMemory] rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:24:35: note: Assuming allocation function fails rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:24:21: note: Assignment 'buffer=(float*)malloc(2*n*sizeof(float)+128)', assigned value is 0 rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:55:24: note: Null pointer addition rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:24:21: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:172:18: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:814:88: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:255:9: style: The scope of the variable 'lm' can be reduced. [variableScope] rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:19:63: style:inconclusive: Function 'SparseConjugateGradient' argument 2 names different: declaration 'b' definition 'x'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/EdgePreservingDecomposition.h:75:86: note: Function 'SparseConjugateGradient' argument 2 names different: declaration 'b' definition 'x'. rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:19:63: note: Function 'SparseConjugateGradient' argument 2 names different: declaration 'b' definition 'x'. rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:19:72: style:inconclusive: Function 'SparseConjugateGradient' argument 3 names different: declaration 'n' definition 'Pass'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/EdgePreservingDecomposition.h:75:93: note: Function 'SparseConjugateGradient' argument 3 names different: declaration 'n' definition 'Pass'. rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:19:72: note: Function 'SparseConjugateGradient' argument 3 names different: declaration 'n' definition 'Pass'. rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:251:91: style: Parameter 'x' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:320:24: style: Variable 'a' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:410:19: style: Variable 'icStartRows' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:520:89: style: Parameter 'b' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:525:19: style: Variable 's' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtengine/EdgePreservingDecomposition.cc:695:20: style: Variable 'rg' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtengine/sleef.h:53:85: portability: Shifting signed 64-bit value by 63 bits is implementation-defined behaviour [shiftTooManyBitsSigned] rawtherapee-5.12/rtengine/sleef.h:68:11: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] rawtherapee-5.12/rtengine/sleef.h:933:77: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] rawtherapee-5.12/rtengine/sleef.h:955:11: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] rawtherapee-5.12/rtengine/boxblur.cc:228:32: style: Local variable 'rowBuffer' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/boxblur.cc:167:24: note: Shadowed declaration rawtherapee-5.12/rtengine/boxblur.cc:228:32: note: Shadow variable rawtherapee-5.12/rtengine/camconst.cc:41:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/camconst.cc:90:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/camconst.cc:259:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/camconst.cc:708:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/camconst.cc:885:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_EXISTS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/cJSON.c:755:45: style: Condition '(input_end-input_pointer)<1' is always false [knownConditionTrueFalse] rawtherapee-5.12/rtengine/cJSON.c:745:26: note: Assuming that condition 'input_pointerlevels' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2497:12: note: Assuming that condition 'img->levels' is not redundant rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2499:16: note: Condition 'img->levels' is always true rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:686:22: warning: If memory allocation fails, then there is a possible null pointer dereference: dst [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:3452:67: note: Assuming allocation function fails rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:3452:60: note: Assignment 'hdrBuf=static_cast(malloc(hdr.mdatHdrSize*2))', assigned value is 0 rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:3463:67: note: Calling function 'read', 1st argument 'hdrBuf' value is 0 rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:686:22: note: Null pointer dereference rawtherapee-5.12/rtengine/dcraw.h:486:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2737:31: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:1804:24: style: Checking if unsigned expression 'subband->width' is less than zero. [unsignedLessThanZero] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:133:48: style: Variable 'd' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:641:42: style: Parameter 's' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:956:18: style: Variable 'symb' can be declared as const array [constVariable] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:1768:38: style: Parameter 'band' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:1812:24: style: Variable 'qStepTblPtr' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:1852:19: style: Variable 'band0Buf' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:1853:19: style: Variable 'band1Buf' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:1854:19: style: Variable 'band2Buf' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:1855:19: style: Variable 'band3Buf' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2324:35: style: Parameter 'image' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2692:85: style: Parameter 'lineBuf0' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2713:29: style: Parameter 'img' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2799:51: style: Parameter 'hdr' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2824:14: style: Parameter 'tile' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/dcraw.h:470:25: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/myfile.h:57:28: style: Parameter 'f' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/myfile.h:62:26: style: Parameter 'f' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:358:49: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:1116:68: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:1514:73: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:1529:73: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:1832:59: warning: Shifting 32-bit value by 32 bits is undefined behaviour. See condition at line 1831. [shiftTooManyBits] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:1831:33: note: Assuming that condition 'subband->qParam/6>=6' is not redundant rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:1832:59: note: Shift rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2755:63: warning: Shifting 32-bit value by 32 bits is undefined behaviour. See condition at line 2754. [shiftTooManyBits] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2754:34: note: Assuming that condition 'quantVal/6>=6' is not redundant rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2755:63: note: Shift rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2774:63: warning: Shifting 32-bit value by 32 bits is undefined behaviour. See condition at line 2773. [shiftTooManyBits] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2773:34: note: Assuming that condition 'quantVal/6>=6' is not redundant rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2774:63: note: Shift rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2789:63: warning: Shifting 32-bit value by 32 bits is undefined behaviour. See condition at line 2788. [shiftTooManyBits] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2788:34: note: Assuming that condition '*qpTable/6>=6' is not redundant rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2789:63: note: Shift rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:1832:59: warning: Either the condition 'subband->qParam/6>=6' is redundant or there is signed integer overflow for expression '1<<(subband->qParam/6+26)'. [integerOverflowCond] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:1831:33: note: Assuming that condition 'subband->qParam/6>=6' is not redundant rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:1832:59: note: Integer overflow rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2755:63: warning: Either the condition 'quantVal/6>=6' is redundant or there is signed integer overflow for expression '1<<(quantVal/6+26)'. [integerOverflowCond] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2754:34: note: Assuming that condition 'quantVal/6>=6' is not redundant rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2755:63: note: Integer overflow rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2774:63: warning: Either the condition 'quantVal/6>=6' is redundant or there is signed integer overflow for expression '1<<(quantVal/6+26)'. [integerOverflowCond] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2773:34: note: Assuming that condition 'quantVal/6>=6' is not redundant rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2774:63: note: Integer overflow rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2789:63: warning: Either the condition '*qpTable/6>=6' is redundant or there is signed integer overflow for expression '1<<(*qpTable/6+26)'. [integerOverflowCond] rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2788:34: note: Assuming that condition '*qpTable/6>=6' is not redundant rawtherapee-5.12/rtengine/canon_cr3_decoder.cc:2789:63: note: Integer overflow rawtherapee-5.12/rtengine/cplx_wavelet_level.h:183:24: style:inconclusive: Technically the member function 'rtengine::wavelet_level < float >::destroy' can be const. [functionConst] rawtherapee-5.12/rtengine/cplx_wavelet_level.h:48:10: note: Technically the member function 'rtengine::wavelet_level < float >::destroy' can be const. rawtherapee-5.12/rtengine/cplx_wavelet_level.h:183:24: note: Technically the member function 'rtengine::wavelet_level < float >::destroy' can be const. rawtherapee-5.12/rtengine/cplx_wavelet_level.h:238:45: style:inconclusive: Technically the member function 'rtengine::wavelet_level < float >::SynthesisFilterHaarHorizontal' can be const. [functionConst] rawtherapee-5.12/rtengine/cplx_wavelet_level.h:54:10: note: Technically the member function 'rtengine::wavelet_level < float >::SynthesisFilterHaarHorizontal' can be const. rawtherapee-5.12/rtengine/cplx_wavelet_level.h:238:45: note: Technically the member function 'rtengine::wavelet_level < float >::SynthesisFilterHaarHorizontal' can be const. rawtherapee-5.12/rtengine/cplx_wavelet_level.h:260:45: style:inconclusive: Technically the member function 'rtengine::wavelet_level < float >::SynthesisFilterHaarVertical' can be const. [functionConst] rawtherapee-5.12/rtengine/cplx_wavelet_level.h:55:10: note: Technically the member function 'rtengine::wavelet_level < float >::SynthesisFilterHaarVertical' can be const. rawtherapee-5.12/rtengine/cplx_wavelet_level.h:260:45: note: Technically the member function 'rtengine::wavelet_level < float >::SynthesisFilterHaarVertical' can be const. rawtherapee-5.12/rtengine/cplx_wavelet_level.h:581:45: style:inconclusive: Technically the member function 'rtengine::wavelet_level < float >::SynthesisFilterSubsampVertical' can be const. [functionConst] rawtherapee-5.12/rtengine/cplx_wavelet_level.h:71:10: note: Technically the member function 'rtengine::wavelet_level < float >::SynthesisFilterSubsampVertical' can be const. rawtherapee-5.12/rtengine/cplx_wavelet_level.h:581:45: note: Technically the member function 'rtengine::wavelet_level < float >::SynthesisFilterSubsampVertical' can be const. rawtherapee-5.12/rtengine/cplx_wavelet_level.h:444:235: style:inconclusive: Function 'SynthesisFilterSubsampHorizontal' argument 8 names different: declaration 'scrwidth' definition 'srcwidth'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/cplx_wavelet_level.h:67:122: note: Function 'SynthesisFilterSubsampHorizontal' argument 8 names different: declaration 'scrwidth' definition 'srcwidth'. rawtherapee-5.12/rtengine/cplx_wavelet_level.h:444:235: note: Function 'SynthesisFilterSubsampHorizontal' argument 8 names different: declaration 'scrwidth' definition 'srcwidth'. rawtherapee-5.12/rtengine/cplx_wavelet_level.h:676:134: style:inconclusive: Function 'decompose_level' argument 5 names different: declaration 'len' definition 'taps'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/cplx_wavelet_level.h:149:78: note: Function 'decompose_level' argument 5 names different: declaration 'len' definition 'taps'. rawtherapee-5.12/rtengine/cplx_wavelet_level.h:676:134: note: Function 'decompose_level' argument 5 names different: declaration 'len' definition 'taps'. rawtherapee-5.12/rtengine/cplx_wavelet_level.h:164:10: style: Local variable 'subbands' shadows outer function [shadowFunction] rawtherapee-5.12/rtengine/cplx_wavelet_level.h:118:10: note: Shadowed declaration rawtherapee-5.12/rtengine/cplx_wavelet_level.h:164:10: note: Shadow variable rawtherapee-5.12/rtengine/cplx_wavelet_level.h:296:138: style: Parameter 'filterLo' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/cplx_wavelet_level.h:296:164: style: Parameter 'filterHi' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/cplx_wavelet_level.h:402:157: style: Parameter 'filterLo' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/cplx_wavelet_level.h:402:184: style: Parameter 'filterHi' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/cplx_wavelet_level.h:444:154: style: Parameter 'filterLo' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/cplx_wavelet_level.h:444:181: style: Parameter 'filterHi' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/cplx_wavelet_level.h:581:152: style: Parameter 'filterLo' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/cplx_wavelet_level.h:581:179: style: Parameter 'filterHi' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/colortemp.cc:4230:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DBL_MIN [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/dcraw.c:2294:1: error: There is an unknown macro here somewhere. Configuration is required. If METHODDEF is a macro then please configure it. [unknownMacro] rawtherapee-5.12/rtengine/iimage.h:295:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable T [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:347:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable T [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:364:58: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable T [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:372:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable T [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:612:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable T [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:619:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable T [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/color.h:180:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MAXVALF [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/color.h:990:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RT_PI [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/linalgebra.h:169:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable T [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/linalgebra.h:177:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable T [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/linalgebra.h:192:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable T [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/color.cc:457:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sRGBGammaCurve [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/color.cc:2321:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:1373:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable width [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:1395:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:1443:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable width [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:1471:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:1533:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable width [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:1604:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable width [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:1641:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable width [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:1656:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:1685:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:1712:53: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:1750:53: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:1781:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable width [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:1827:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:1856:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:1865:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:678:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable width [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:701:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:779:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:813:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:883:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable width [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:939:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable width [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:972:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:1004:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:1033:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:1059:53: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:1097:53: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:1128:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable width [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:1174:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:1214:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:1230:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:1251:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/jpeg.h:17:1: error: There is an unknown macro here somewhere. Configuration is required. If GLOBAL is a macro then please configure it. [unknownMacro] rawtherapee-5.12/rtengine/mytime.h:60:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CLOCK_REALTIME [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/array2D.h:284:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable num [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/array2D.h:291:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable num [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/diagonalcurves.cc:30:58: style:inconclusive: Function 'DiagonalCurve' argument 1 names different: declaration 'points' definition 'p'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/curves.h:493:55: note: Function 'DiagonalCurve' argument 1 names different: declaration 'points' definition 'p'. rawtherapee-5.12/rtengine/diagonalcurves.cc:30:58: note: Function 'DiagonalCurve' argument 1 names different: declaration 'points' definition 'p'. rawtherapee-5.12/rtengine/diagonalcurves.cc:30:65: style:inconclusive: Function 'DiagonalCurve' argument 2 names different: declaration 'ppn' definition 'poly_pn'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/curves.h:493:67: note: Function 'DiagonalCurve' argument 2 names different: declaration 'ppn' definition 'poly_pn'. rawtherapee-5.12/rtengine/diagonalcurves.cc:30:65: note: Function 'DiagonalCurve' argument 2 names different: declaration 'ppn' definition 'poly_pn'. rawtherapee-5.12/rtengine/diagonalcurves.cc:390:56: style: Parameter 'x' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/diagonalcurves.cc:390:67: style: Parameter 'y' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/diagonalcurves.cc:506:50: warning: Either the condition 'it==poly_x.end()' is redundant or there is possible dereference of an invalid iterator: it+1. [derefInvalidIteratorRedundantCheck] rawtherapee-5.12/rtengine/diagonalcurves.cc:502:16: note: Assuming that condition 'it==poly_x.end()' is not redundant rawtherapee-5.12/rtengine/diagonalcurves.cc:506:50: note: Dereference of an invalid iterator rawtherapee-5.12/rtengine/procparams.h:2968:5: style: Class 'PartialProfile' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] rawtherapee-5.12/rtengine/colortemp.h:84:24: performance: Function 'getMethod()' should return member 'method' by const reference. [returnByReference] rawtherapee-5.12/rtengine/dynamicprofile.cc:57:72: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable REGEX_CASELESS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/dynamicprofile.cc:178:67: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable rtdir [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/dynamicprofile.cc:276:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable rtdir [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iimage.h:81:10: performance:inconclusive: Technically the member function 'rtengine::ImageDatas::convertTo' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/iimage.h:101:10: performance:inconclusive: Technically the member function 'rtengine::ImageDatas::readData' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/iimage.h:103:10: performance:inconclusive: Technically the member function 'rtengine::ImageDatas::writeData' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/iimage.h:1358:14: style:inconclusive: Technically the member function 'rtengine::ChunkyRGBData < unsigned char >::getData' can be const. [functionConst] rawtherapee-5.12/rtengine/iimage.h:1436:24: debug: CheckClass::isMemberVar found used member variable 'width' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:1533:13: debug: CheckClass::isMemberVar found used member variable 'width' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:1533:28: debug: CheckClass::isMemberVar found used member variable 'height' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:1535:33: debug: CheckClass::isMemberVar found used member variable 'height' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:1536:37: debug: CheckClass::isMemberVar found used member variable 'width' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:1656:33: debug: CheckClass::isMemberVar found used member variable 'height' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:1657:37: debug: CheckClass::isMemberVar found used member variable 'width' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:1685:33: debug: CheckClass::isMemberVar found used member variable 'height' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:1686:37: debug: CheckClass::isMemberVar found used member variable 'width' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:1781:17: debug: CheckClass::isMemberVar found used member variable 'width' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:1782:17: debug: CheckClass::isMemberVar found used member variable 'height' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:1856:29: debug: CheckClass::isMemberVar found used member variable 'height' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:1865:29: debug: CheckClass::isMemberVar found used member variable 'height' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:772:24: debug: CheckClass::isMemberVar found used member variable 'width' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:883:13: debug: CheckClass::isMemberVar found used member variable 'width' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:883:28: debug: CheckClass::isMemberVar found used member variable 'height' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:885:33: debug: CheckClass::isMemberVar found used member variable 'height' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:886:37: debug: CheckClass::isMemberVar found used member variable 'width' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:1004:33: debug: CheckClass::isMemberVar found used member variable 'height' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:1005:37: debug: CheckClass::isMemberVar found used member variable 'width' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:1033:33: debug: CheckClass::isMemberVar found used member variable 'height' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:1034:37: debug: CheckClass::isMemberVar found used member variable 'width' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:1128:17: debug: CheckClass::isMemberVar found used member variable 'width' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:1129:17: debug: CheckClass::isMemberVar found used member variable 'height' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:1214:48: debug: CheckClass::isMemberVar found used member variable 'width' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:1214:62: debug: CheckClass::isMemberVar found used member variable 'height' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:1230:29: debug: CheckClass::isMemberVar found used member variable 'height' with varid 0 [varid0] rawtherapee-5.12/rtengine/iimage.h:1251:29: debug: CheckClass::isMemberVar found used member variable 'height' with varid 0 [varid0] rawtherapee-5.12/rtengine/alignedbuffer.h:57:18: warning: Class 'AlignedBuffer < unsigned char >' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] rawtherapee-5.12/rtengine/alignedbuffer.h:57:18: warning: Class 'AlignedBuffer < unsigned char >' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] rawtherapee-5.12/rtengine/alignedbuffer.h:57:18: warning: Class 'AlignedBuffer < float >' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] rawtherapee-5.12/rtengine/alignedbuffer.h:57:18: warning: Class 'AlignedBuffer < float >' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] rawtherapee-5.12/rtengine/alignedbuffer.h:57:18: warning: Class 'AlignedBuffer < unsigned short >' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] rawtherapee-5.12/rtengine/alignedbuffer.h:57:18: warning: Class 'AlignedBuffer < unsigned short >' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] rawtherapee-5.12/rtengine/iimage.h:282:10: style: Virtual function 'allocate' is called from constructor 'PlanarWhateverData(int w,int h)' at line 249. Dynamic binding is not used. [virtualCallInConstructor] rawtherapee-5.12/rtengine/iimage.h:249:9: note: Calling allocate rawtherapee-5.12/rtengine/iimage.h:282:10: note: allocate is a virtual function rawtherapee-5.12/rtengine/iimage.h:609:10: warning: The class 'PlanarWhateverData' defines member function with name 'readData' also defined in its parent class 'ImageDatas'. [duplInheritedMember] rawtherapee-5.12/rtengine/iimage.h:101:10: note: Parent function 'ImageDatas::readData' rawtherapee-5.12/rtengine/iimage.h:609:10: note: Derived function 'PlanarWhateverData::readData' rawtherapee-5.12/rtengine/iimage.h:616:10: warning: The class 'PlanarWhateverData' defines member function with name 'writeData' also defined in its parent class 'ImageDatas'. [duplInheritedMember] rawtherapee-5.12/rtengine/iimage.h:103:10: note: Parent function 'ImageDatas::writeData' rawtherapee-5.12/rtengine/iimage.h:616:10: note: Derived function 'PlanarWhateverData::writeData' rawtherapee-5.12/rtengine/iimage.h:1228:10: warning: The class 'PlanarRGBData < float >' defines member function with name 'readData' also defined in its parent class 'ImageDatas'. [duplInheritedMember] rawtherapee-5.12/rtengine/iimage.h:101:10: note: Parent function 'ImageDatas::readData' rawtherapee-5.12/rtengine/iimage.h:1228:10: note: Derived function 'PlanarRGBData < float >::readData' rawtherapee-5.12/rtengine/iimage.h:1249:10: warning: The class 'PlanarRGBData < float >' defines member function with name 'writeData' also defined in its parent class 'ImageDatas'. [duplInheritedMember] rawtherapee-5.12/rtengine/iimage.h:103:10: note: Parent function 'ImageDatas::writeData' rawtherapee-5.12/rtengine/iimage.h:1249:10: note: Derived function 'PlanarRGBData < float >::writeData' rawtherapee-5.12/rtengine/iimage.h:1228:10: warning: The class 'PlanarRGBData < unsigned short >' defines member function with name 'readData' also defined in its parent class 'ImageDatas'. [duplInheritedMember] rawtherapee-5.12/rtengine/iimage.h:101:10: note: Parent function 'ImageDatas::readData' rawtherapee-5.12/rtengine/iimage.h:1228:10: note: Derived function 'PlanarRGBData < unsigned short >::readData' rawtherapee-5.12/rtengine/iimage.h:1249:10: warning: The class 'PlanarRGBData < unsigned short >' defines member function with name 'writeData' also defined in its parent class 'ImageDatas'. [duplInheritedMember] rawtherapee-5.12/rtengine/iimage.h:103:10: note: Parent function 'ImageDatas::writeData' rawtherapee-5.12/rtengine/iimage.h:1249:10: note: Derived function 'PlanarRGBData < unsigned short >::writeData' rawtherapee-5.12/rtengine/iimage.h:1854:10: warning: The class 'ChunkyRGBData < unsigned char >' defines member function with name 'readData' also defined in its parent class 'ImageDatas'. [duplInheritedMember] rawtherapee-5.12/rtengine/iimage.h:101:10: note: Parent function 'ImageDatas::readData' rawtherapee-5.12/rtengine/iimage.h:1854:10: note: Derived function 'ChunkyRGBData < unsigned char >::readData' rawtherapee-5.12/rtengine/iimage.h:1863:10: warning: The class 'ChunkyRGBData < unsigned char >' defines member function with name 'writeData' also defined in its parent class 'ImageDatas'. [duplInheritedMember] rawtherapee-5.12/rtengine/iimage.h:103:10: note: Parent function 'ImageDatas::writeData' rawtherapee-5.12/rtengine/iimage.h:1863:10: note: Derived function 'ChunkyRGBData < unsigned char >::writeData' rawtherapee-5.12/rtengine/procevents.h:1190:5: style: Class 'ProcEvent' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] rawtherapee-5.12/rtengine/alignedbuffer.h:47:5: style: Class 'AlignedBuffer < unsigned char >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] rawtherapee-5.12/rtengine/alignedbuffer.h:47:5: style: Class 'AlignedBuffer < float >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] rawtherapee-5.12/rtengine/alignedbuffer.h:47:5: style: Class 'AlignedBuffer < unsigned short >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] rawtherapee-5.12/rtengine/iimage.h:327:25: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/iimage.h:331:20: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/iimage.h:755:28: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/iimage.h:756:28: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/iimage.h:757:28: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/iimage.h:761:20: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/iimage.h:762:20: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/iimage.h:763:20: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/iimage.h:755:28: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] rawtherapee-5.12/rtengine/iimage.h:756:28: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] rawtherapee-5.12/rtengine/iimage.h:757:28: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] rawtherapee-5.12/rtengine/iimage.h:761:20: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] rawtherapee-5.12/rtengine/iimage.h:762:20: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] rawtherapee-5.12/rtengine/iimage.h:763:20: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] rawtherapee-5.12/rtengine/dynamicprofile.h:47:48: performance:inconclusive: Function parameter 'v' should be passed by const reference. However it seems that 'Optional' is a callback function. [passedByValueCallback] rawtherapee-5.12/rtengine/dynamicprofile.h:44:12: note: Function pointer used here. rawtherapee-5.12/rtengine/dynamicprofile.h:47:48: note: Function parameter 'v' should be passed by const reference. However it seems that 'Optional' is a callback function. rawtherapee-5.12/rtengine/dynamicprofile.cc:110:34: style: Variable 'e' can be declared as reference to const [constVariableReference] rawtherapee-5.12/rtengine/dynamicprofile.cc:127:34: style: Variable 'e' can be declared as reference to const [constVariableReference] rawtherapee-5.12/rtengine/dynamicprofile.cc:184:27: style: Variable 'e' can be declared as reference to const [constVariableReference] rawtherapee-5.12/rtengine/iimage.h:101:27: style: Parameter 'fh' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/iimage.h:103:27: style: Parameter 'fh' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/flatcurves.cc:42:13: warning: Class 'FlatCurve' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] rawtherapee-5.12/rtengine/flatcurves.cc:42:13: warning: Class 'FlatCurve' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] rawtherapee-5.12/rtengine/flatcurves.cc:26:50: style:inconclusive: Function 'FlatCurve' argument 1 names different: declaration 'points' definition 'p'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/curves.h:518:51: note: Function 'FlatCurve' argument 1 names different: declaration 'points' definition 'p'. rawtherapee-5.12/rtengine/flatcurves.cc:26:50: note: Function 'FlatCurve' argument 1 names different: declaration 'points' definition 'p'. rawtherapee-5.12/rtengine/flatcurves.cc:26:74: style:inconclusive: Function 'FlatCurve' argument 3 names different: declaration 'ppn' definition 'poly_pn'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/curves.h:518:87: note: Function 'FlatCurve' argument 3 names different: declaration 'ppn' definition 'poly_pn'. rawtherapee-5.12/rtengine/flatcurves.cc:26:74: note: Function 'FlatCurve' argument 3 names different: declaration 'ppn' definition 'poly_pn'. rawtherapee-5.12/rtengine/fujicompressed.cc:102:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable grads [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/fujicompressed.cc:112:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable fuji_block_width [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/fujicompressed.cc:227:57: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable _ltotal [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/fujicompressed.cc:280:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable raw_image [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/fujicompressed.cc:337:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable raw_image [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/fujicompressed.cc:461:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable q_base [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/fujicompressed.cc:552:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable q_base [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/fujicompressed.cc:675:71: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable _R2 [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/fujicompressed.cc:840:76: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable _R2 [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/fujicompressed.cc:978:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable fuji_lossless [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/fujicompressed.cc:1070:59: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable fuji_total_blocks [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/fujicompressed.cc:1121:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable fuji_total_lines [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/fujicompressed.cc:1149:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ifp [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/fujicompressed.cc:1261:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable raw_width [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/fujicompressed.cc:227:68: warning: If memory allocation fails, then there is a possible null pointer dereference: params [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/fujicompressed.cc:981:55: note: Assuming allocation function fails rawtherapee-5.12/rtengine/fujicompressed.cc:981:23: note: Assignment 'info_common=(fuji_compressed_params*)malloc(buf_size)', assigned value is 0 rawtherapee-5.12/rtengine/fujicompressed.cc:987:29: note: Calling function 'init_fuji_block', 2nd argument 'info_common' value is 0 rawtherapee-5.12/rtengine/fujicompressed.cc:227:68: note: Null pointer dereference rawtherapee-5.12/rtengine/fujicompressed.cc:982:16: warning: If memory allocation fails, then there is a possible null pointer dereference: info_common [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/fujicompressed.cc:981:55: note: Assuming allocation function fails rawtherapee-5.12/rtengine/fujicompressed.cc:981:23: note: Assignment 'info_common=(fuji_compressed_params*)malloc(buf_size)', assigned value is 0 rawtherapee-5.12/rtengine/fujicompressed.cc:982:16: note: Null pointer dereference rawtherapee-5.12/rtengine/fujicompressed.cc:983:9: warning: If memory allocation fails, then there is a possible null pointer dereference: info_common [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/fujicompressed.cc:981:55: note: Assuming allocation function fails rawtherapee-5.12/rtengine/fujicompressed.cc:981:23: note: Assignment 'info_common=(fuji_compressed_params*)malloc(buf_size)', assigned value is 0 rawtherapee-5.12/rtengine/fujicompressed.cc:983:9: note: Null pointer dereference rawtherapee-5.12/rtengine/fujicompressed.cc:984:9: warning: If memory allocation fails, then there is a possible null pointer dereference: info_common [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/fujicompressed.cc:981:55: note: Assuming allocation function fails rawtherapee-5.12/rtengine/fujicompressed.cc:981:23: note: Assignment 'info_common=(fuji_compressed_params*)malloc(buf_size)', assigned value is 0 rawtherapee-5.12/rtengine/fujicompressed.cc:984:9: note: Null pointer dereference rawtherapee-5.12/rtengine/fujicompressed.cc:988:36: warning: If memory allocation fails, then there is a possible null pointer dereference: info_common [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/fujicompressed.cc:981:55: note: Assuming allocation function fails rawtherapee-5.12/rtengine/fujicompressed.cc:981:23: note: Assignment 'info_common=(fuji_compressed_params*)malloc(buf_size)', assigned value is 0 rawtherapee-5.12/rtengine/fujicompressed.cc:988:36: note: Null pointer dereference rawtherapee-5.12/rtengine/fujicompressed.cc:1077:15: warning:inconclusive: If memory allocation fails, then there is a possible null pointer dereference: block_sizes [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/fujicompressed.cc:1070:38: note: Assuming allocation function fails rawtherapee-5.12/rtengine/fujicompressed.cc:1070:19: note: Assignment 'block_sizes=(unsigned int*)malloc(sizeof(unsigned int)*fuji_total_blocks)', assigned value is 0 rawtherapee-5.12/rtengine/fujicompressed.cc:1077:15: note: Null pointer dereference rawtherapee-5.12/rtengine/fujicompressed.cc:1093:15: warning:inconclusive: If memory allocation fails, then there is a possible null pointer dereference: q_bases [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/fujicompressed.cc:1090:34: note: Assuming allocation function fails rawtherapee-5.12/rtengine/fujicompressed.cc:1090:19: note: Assignment 'q_bases=(uchar*)malloc(total_q_bases)', assigned value is 0 rawtherapee-5.12/rtengine/fujicompressed.cc:1093:15: note: Null pointer dereference rawtherapee-5.12/rtengine/fujicompressed.cc:1268:32: warning:inconclusive: If memory allocation fails, then there is a possible null pointer dereference: buf [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/fujicompressed.cc:1263:47: note: Assuming allocation function fails rawtherapee-5.12/rtengine/fujicompressed.cc:1263:24: note: Assignment 'buf=(unsigned char*)malloc(linelen)', assigned value is 0 rawtherapee-5.12/rtengine/fujicompressed.cc:1268:32: note: Null pointer dereference rawtherapee-5.12/rtengine/fujicompressed.cc:983:61: error: If memory allocation fails: pointer addition with NULL pointer. [nullPointerArithmeticOutOfMemory] rawtherapee-5.12/rtengine/fujicompressed.cc:981:55: note: Assuming allocation function fails rawtherapee-5.12/rtengine/fujicompressed.cc:981:23: note: Assignment 'info_common=(fuji_compressed_params*)malloc(buf_size)', assigned value is 0 rawtherapee-5.12/rtengine/fujicompressed.cc:983:61: note: Null pointer addition rawtherapee-5.12/rtengine/fujicompressed.cc:138:33: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/fujicompressed.cc:152:33: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/fujicompressed.cc:227:23: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/fujicompressed.cc:243:21: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/fujicompressed.cc:981:23: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/fujicompressed.cc:1070:19: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/fujicompressed.cc:1072:25: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/fujicompressed.cc:1090:19: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/fujicompressed.cc:1263:24: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/fujicompressed.cc:983:38: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/fujicompressed.cc:1103:36: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/fujicompressed.cc:1272:17: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/fujicompressed.cc:45:34: style: Parameter 'q_point' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/fujicompressed.cc:276:13: style: Variable 'line_buf' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtengine/fujicompressed.cc:327:13: style: Variable 'line_buf' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtengine/fujicompressed.cc:1048:38: style: Parameter 's' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/fujicompressed.cc:1216:47: style: Parameter 'src' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/fujicompressed.cc:1224:51: style: Parameter 'src' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/gauss.cc:1357:16: style: Local variable 'temp2Hm1' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/gauss.cc:1301:12: note: Shadowed declaration rawtherapee-5.12/rtengine/gauss.cc:1357:16: note: Shadow variable rawtherapee-5.12/rtengine/gauss.cc:1358:16: style: Local variable 'temp2H' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/gauss.cc:1301:31: note: Shadowed declaration rawtherapee-5.12/rtengine/gauss.cc:1358:16: note: Shadow variable rawtherapee-5.12/rtengine/gauss.cc:1359:16: style: Local variable 'temp2Hp1' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/gauss.cc:1301:48: note: Shadowed declaration rawtherapee-5.12/rtengine/gauss.cc:1359:16: note: Shadow variable rawtherapee-5.12/rtengine/gauss.cc:1274:16: style: Local variable 'temp2Hm1' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/gauss.cc:1218:12: note: Shadowed declaration rawtherapee-5.12/rtengine/gauss.cc:1274:16: note: Shadow variable rawtherapee-5.12/rtengine/gauss.cc:1275:16: style: Local variable 'temp2H' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/gauss.cc:1218:31: note: Shadowed declaration rawtherapee-5.12/rtengine/gauss.cc:1275:16: note: Shadow variable rawtherapee-5.12/rtengine/gauss.cc:1276:16: style: Local variable 'temp2Hp1' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/gauss.cc:1218:48: note: Shadowed declaration rawtherapee-5.12/rtengine/gauss.cc:1276:16: note: Shadow variable rawtherapee-5.12/rtengine/gauss.cc:1190:16: style: Local variable 'temp2Hm1' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/gauss.cc:1134:12: note: Shadowed declaration rawtherapee-5.12/rtengine/gauss.cc:1190:16: note: Shadow variable rawtherapee-5.12/rtengine/gauss.cc:1191:16: style: Local variable 'temp2H' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/gauss.cc:1134:31: note: Shadowed declaration rawtherapee-5.12/rtengine/gauss.cc:1191:16: note: Shadow variable rawtherapee-5.12/rtengine/gauss.cc:1192:16: style: Local variable 'temp2Hp1' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/gauss.cc:1134:48: note: Shadowed declaration rawtherapee-5.12/rtengine/gauss.cc:1192:16: note: Shadow variable rawtherapee-5.12/rtengine/iccjpeg.cc:77:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JPEG_APP0 [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iccjpeg.cc:119:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JPEG_APP0 [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iccjpeg.cc:130:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable JPEG_APP0 [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iccjpeg.cc:235:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable nothrow [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iccstore.cc:83:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_IS_REGULAR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iccstore.cc:144:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_IS_REGULAR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iccstore.cc:186:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable INTENT_PERCEPTUAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iccstore.cc:220:73: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cmsSigDeviceMfgDescTag [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iccstore.cc:237:82: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cmsSigDeviceModelDescTag [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iccstore.cc:279:73: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cmsSigProfileDescriptionTag [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iccstore.cc:373:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cmsSigRedTRCTag [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iccstore.cc:459:78: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable rtdir [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iccstore.cc:646:61: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cmsSigDisplayClass [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iccstore.cc:689:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LCMS_USED_AS_INPUT [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iccstore.cc:696:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LCMS_USED_AS_OUTPUT [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iccstore.cc:703:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LCMS_USED_AS_PROOF [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iccstore.cc:795:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cmsSigRgbData [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/iccstore.cc:836:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/array2D.h:269:5: style:inconclusive: Technically the member function 'array2D::operatorbool' can be const. [functionConst] rawtherapee-5.12/rtengine/curves.cc:47:27: warning: Either the condition 'dCurve' is redundant or there is possible null pointer dereference: diagCurve. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/curves.cc:370:13: note: Assuming that condition 'dCurve' is not redundant rawtherapee-5.12/rtengine/curves.cc:375:30: note: Calling function 'fillCurveArray', 1st argument 'dCurve.get()' value is 0 rawtherapee-5.12/rtengine/curves.cc:47:27: note: Null pointer dereference rawtherapee-5.12/rtengine/curves.cc:3182:9: warning: If memory allocation fails, then there is a possible null pointer dereference: A [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/curves.cc:3175:33: note: Assuming allocation function fails rawtherapee-5.12/rtengine/curves.cc:3175:17: note: Assignment 'A=(float**)std::malloc(2*len*sizeof(*A))', assigned value is 0 rawtherapee-5.12/rtengine/curves.cc:3182:9: note: Null pointer dereference rawtherapee-5.12/rtengine/curves.cc:3186:9: warning: If memory allocation fails, then there is a possible null pointer dereference: b [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/curves.cc:3177:31: note: Assuming allocation function fails rawtherapee-5.12/rtengine/curves.cc:3177:16: note: Assignment 'b=(float*)std::calloc(1,2*len*sizeof(*b))', assigned value is 0 rawtherapee-5.12/rtengine/curves.cc:3186:9: note: Null pointer dereference rawtherapee-5.12/rtengine/curves.cc:3187:9: warning: If memory allocation fails, then there is a possible null pointer dereference: d [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/curves.cc:3179:31: note: Assuming allocation function fails rawtherapee-5.12/rtengine/curves.cc:3179:16: note: Assignment 'd=(float*)std::calloc(1,2*len*sizeof(*d))', assigned value is 0 rawtherapee-5.12/rtengine/curves.cc:3187:9: note: Null pointer dereference rawtherapee-5.12/rtengine/curves.cc:3191:9: warning: If memory allocation fails, then there is a possible null pointer dereference: A [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/curves.cc:3175:33: note: Assuming allocation function fails rawtherapee-5.12/rtengine/curves.cc:3175:17: note: Assignment 'A=(float**)std::malloc(2*len*sizeof(*A))', assigned value is 0 rawtherapee-5.12/rtengine/curves.cc:3191:9: note: Null pointer dereference rawtherapee-5.12/rtengine/curves.cc:3191:24: warning: If memory allocation fails, then there is a possible null pointer dereference: d [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/curves.cc:3179:31: note: Assuming allocation function fails rawtherapee-5.12/rtengine/curves.cc:3179:16: note: Assignment 'd=(float*)std::calloc(1,2*len*sizeof(*d))', assigned value is 0 rawtherapee-5.12/rtengine/curves.cc:3191:24: note: Null pointer dereference rawtherapee-5.12/rtengine/curves.cc:3191:35: warning: If memory allocation fails, then there is a possible null pointer dereference: d [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/curves.cc:3179:31: note: Assuming allocation function fails rawtherapee-5.12/rtengine/curves.cc:3179:16: note: Assignment 'd=(float*)std::calloc(1,2*len*sizeof(*d))', assigned value is 0 rawtherapee-5.12/rtengine/curves.cc:3191:35: note: Null pointer dereference rawtherapee-5.12/rtengine/curves.cc:3198:9: warning: If memory allocation fails, then there is a possible null pointer dereference: A [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/curves.cc:3175:33: note: Assuming allocation function fails rawtherapee-5.12/rtengine/curves.cc:3175:17: note: Assignment 'A=(float**)std::malloc(2*len*sizeof(*A))', assigned value is 0 rawtherapee-5.12/rtengine/curves.cc:3198:9: note: Null pointer dereference rawtherapee-5.12/rtengine/curves.cc:3198:30: warning: If memory allocation fails, then there is a possible null pointer dereference: b [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/curves.cc:3177:31: note: Assuming allocation function fails rawtherapee-5.12/rtengine/curves.cc:3177:16: note: Assignment 'b=(float*)std::calloc(1,2*len*sizeof(*b))', assigned value is 0 rawtherapee-5.12/rtengine/curves.cc:3198:30: note: Null pointer dereference rawtherapee-5.12/rtengine/curves.cc:3198:41: warning: If memory allocation fails, then there is a possible null pointer dereference: b [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/curves.cc:3177:31: note: Assuming allocation function fails rawtherapee-5.12/rtengine/curves.cc:3177:16: note: Assignment 'b=(float*)std::calloc(1,2*len*sizeof(*b))', assigned value is 0 rawtherapee-5.12/rtengine/curves.cc:3198:41: note: Null pointer dereference rawtherapee-5.12/rtengine/curves.cc:3175:17: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/curves.cc:3176:17: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/curves.cc:3177:16: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/curves.cc:3178:16: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/curves.cc:3179:16: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/curves.cc:3287:39: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/curves.cc:3127:20: style: The scope of the variable 'currY' can be reduced. [variableScope] rawtherapee-5.12/rtengine/curves.cc:230:69: style:inconclusive: Function 'curveLightBrightColor' argument 1 names different: declaration 'curvePoints' definition 'curvePoints1'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/curves.h:392:36: note: Function 'curveLightBrightColor' argument 1 names different: declaration 'curvePoints' definition 'curvePoints1'. rawtherapee-5.12/rtengine/curves.cc:230:69: note: Function 'curveLightBrightColor' argument 1 names different: declaration 'curvePoints' definition 'curvePoints1'. rawtherapee-5.12/rtengine/curves.cc:233:27: style:inconclusive: Function 'curveLightBrightColor' argument 8 names different: declaration 'outColCurve1' definition 'customColCurve1'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/curves.h:397:27: note: Function 'curveLightBrightColor' argument 8 names different: declaration 'outColCurve1' definition 'customColCurve1'. rawtherapee-5.12/rtengine/curves.cc:233:27: note: Function 'curveLightBrightColor' argument 8 names different: declaration 'outColCurve1' definition 'customColCurve1'. rawtherapee-5.12/rtengine/curves.cc:233:62: style:inconclusive: Function 'curveLightBrightColor' argument 9 names different: declaration 'outColCurve2' definition 'customColCurve2'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/curves.h:398:27: note: Function 'curveLightBrightColor' argument 9 names different: declaration 'outColCurve2' definition 'customColCurve2'. rawtherapee-5.12/rtengine/curves.cc:233:62: note: Function 'curveLightBrightColor' argument 9 names different: declaration 'outColCurve2' definition 'customColCurve2'. rawtherapee-5.12/rtengine/curves.cc:233:97: style:inconclusive: Function 'curveLightBrightColor' argument 10 names different: declaration 'outColCurve3' definition 'customColCurve3'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/curves.h:399:27: note: Function 'curveLightBrightColor' argument 10 names different: declaration 'outColCurve3' definition 'customColCurve3'. rawtherapee-5.12/rtengine/curves.cc:233:97: note: Function 'curveLightBrightColor' argument 10 names different: declaration 'outColCurve3' definition 'customColCurve3'. rawtherapee-5.12/rtengine/curves.cc:380:90: style:inconclusive: Function 'complexsgnCurve' argument 4 names different: declaration 'clcutili' definition 'cclutili'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/curves.h:381:87: note: Function 'complexsgnCurve' argument 4 names different: declaration 'clcutili' definition 'cclutili'. rawtherapee-5.12/rtengine/curves.cc:380:90: note: Function 'complexsgnCurve' argument 4 names different: declaration 'clcutili' definition 'cclutili'. rawtherapee-5.12/rtengine/curves.cc:451:21: style:inconclusive: Function 'complexCurve' argument 15 names different: declaration 'outToneCurve' definition 'customToneCurve1'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/curves.h:366:148: note: Function 'complexCurve' argument 15 names different: declaration 'outToneCurve' definition 'customToneCurve1'. rawtherapee-5.12/rtengine/curves.cc:451:21: note: Function 'complexCurve' argument 15 names different: declaration 'outToneCurve' definition 'customToneCurve1'. rawtherapee-5.12/rtengine/curves.cc:452:21: style:inconclusive: Function 'complexCurve' argument 16 names different: declaration 'outToneCurve2' definition 'customToneCurve2'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/curves.h:366:174: note: Function 'complexCurve' argument 16 names different: declaration 'outToneCurve2' definition 'customToneCurve2'. rawtherapee-5.12/rtengine/curves.cc:452:21: note: Function 'complexCurve' argument 16 names different: declaration 'outToneCurve2' definition 'customToneCurve2'. rawtherapee-5.12/rtengine/curves.cc:3377:83: style:inconclusive: Function 'BatchApply' argument 3 names different: declaration 'r' definition 'rc'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/curves.h:1837:66: note: Function 'BatchApply' argument 3 names different: declaration 'r' definition 'rc'. rawtherapee-5.12/rtengine/curves.cc:3377:83: note: Function 'BatchApply' argument 3 names different: declaration 'r' definition 'rc'. rawtherapee-5.12/rtengine/curves.cc:3377:94: style:inconclusive: Function 'BatchApply' argument 4 names different: declaration 'g' definition 'gc'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/curves.h:1837:76: note: Function 'BatchApply' argument 4 names different: declaration 'g' definition 'gc'. rawtherapee-5.12/rtengine/curves.cc:3377:94: note: Function 'BatchApply' argument 4 names different: declaration 'g' definition 'gc'. rawtherapee-5.12/rtengine/curves.cc:3377:105: style:inconclusive: Function 'BatchApply' argument 5 names different: declaration 'b' definition 'bc'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/curves.h:1837:86: note: Function 'BatchApply' argument 5 names different: declaration 'b' definition 'bc'. rawtherapee-5.12/rtengine/curves.cc:3377:105: note: Function 'BatchApply' argument 5 names different: declaration 'b' definition 'bc'. rawtherapee-5.12/rtengine/curves.cc:149:18: style: Local variable 'increment' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/curves.h:436:12: note: Shadowed declaration rawtherapee-5.12/rtengine/curves.cc:149:18: note: Shadow variable rawtherapee-5.12/rtengine/curves.cc:3306:57: style: Parameter 'range' can be declared as const array [constParameter] rawtherapee-5.12/rtengine/color.h:1120:63: warning: Invalid log() argument nr 1. The value is 0 but the valid values are '4.94066e-324:'. [invalidFunctionArg] rawtherapee-5.12/rtengine/color.cc:241:26: note: Assignment 'i=0', assigned value is 0 rawtherapee-5.12/rtengine/color.cc:243:65: note: Calling function 'gamma2', 1st argument 'i/65535.0' value is 0.0 rawtherapee-5.12/rtengine/color.h:1120:63: note: Invalid argument rawtherapee-5.12/rtengine/color.h:1148:62: warning: Invalid log() argument nr 1. The value is 0 but the valid values are '4.94066e-324:'. [invalidFunctionArg] rawtherapee-5.12/rtengine/color.cc:310:30: note: Assignment 'i=0', assigned value is 0 rawtherapee-5.12/rtengine/color.cc:311:63: note: Calling function 'gamma55', 1st argument 'i/65535.0' value is 0.0 rawtherapee-5.12/rtengine/color.h:1148:62: note: Invalid argument rawtherapee-5.12/rtengine/color.h:1170:60: warning: Invalid log() argument nr 1. The value is 0 but the valid values are '4.94066e-324:'. [invalidFunctionArg] rawtherapee-5.12/rtengine/color.cc:303:30: note: Assignment 'i=0', assigned value is 0 rawtherapee-5.12/rtengine/color.cc:304:62: note: Calling function 'gamma4', 1st argument 'i/65535.0' value is 0.0 rawtherapee-5.12/rtengine/color.h:1170:60: note: Invalid argument rawtherapee-5.12/rtengine/color.h:1192:89: warning: Invalid log() argument nr 1. The value is 0 but the valid values are '4.94066e-324:'. [invalidFunctionArg] rawtherapee-5.12/rtengine/color.cc:352:22: note: Assignment 'i=0', assigned value is 0 rawtherapee-5.12/rtengine/color.cc:353:54: note: Calling function 'gamma709', 1st argument 'i/65535.0' value is 0.0 rawtherapee-5.12/rtengine/color.h:1192:89: note: Invalid argument rawtherapee-5.12/rtengine/color.h:1214:62: warning: Invalid log() argument nr 1. The value is 0 but the valid values are '4.94066e-324:'. [invalidFunctionArg] rawtherapee-5.12/rtengine/color.cc:416:22: note: Assignment 'i=0', assigned value is 0 rawtherapee-5.12/rtengine/color.cc:417:47: note: Calling function 'gamma24_17', 1st argument 'i/65535.0' value is 0.0 rawtherapee-5.12/rtengine/color.h:1214:62: note: Invalid argument rawtherapee-5.12/rtengine/color.h:1236:62: warning: Invalid log() argument nr 1. The value is 0 but the valid values are '4.94066e-324:'. [invalidFunctionArg] rawtherapee-5.12/rtengine/color.cc:296:30: note: Assignment 'i=0', assigned value is 0 rawtherapee-5.12/rtengine/color.cc:297:66: note: Calling function 'gamma26_11', 1st argument 'i/65535.0' value is 0.0 rawtherapee-5.12/rtengine/color.h:1236:62: note: Invalid argument rawtherapee-5.12/rtengine/color.h:1256:61: warning: Invalid log() argument nr 1. The value is 0 but the valid values are '4.94066e-324:'. [invalidFunctionArg] rawtherapee-5.12/rtengine/color.cc:368:22: note: Assignment 'i=0', assigned value is 0 rawtherapee-5.12/rtengine/color.cc:369:55: note: Calling function 'gamma13_2', 1st argument 'i/65535.0' value is 0.0 rawtherapee-5.12/rtengine/color.h:1256:61: note: Invalid argument rawtherapee-5.12/rtengine/color.h:1266:61: warning: Invalid log() argument nr 1. The value is 0 but the valid values are '4.94066e-324:'. [invalidFunctionArg] rawtherapee-5.12/rtengine/color.cc:384:22: note: Assignment 'i=0', assigned value is 0 rawtherapee-5.12/rtengine/color.cc:385:57: note: Calling function 'gamma115_2', 1st argument 'i/65535.0' value is 0.0 rawtherapee-5.12/rtengine/color.h:1266:61: note: Invalid argument rawtherapee-5.12/rtengine/color.h:1276:61: warning: Invalid log() argument nr 1. The value is 0 but the valid values are '4.94066e-324:'. [invalidFunctionArg] rawtherapee-5.12/rtengine/color.cc:400:22: note: Assignment 'i=0', assigned value is 0 rawtherapee-5.12/rtengine/color.cc:401:57: note: Calling function 'gamma145_3', 1st argument 'i/65535.0' value is 0.0 rawtherapee-5.12/rtengine/color.h:1276:61: note: Invalid argument rawtherapee-5.12/rtengine/linalgebra.h:77:5: style: Class 'Mat33' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] rawtherapee-5.12/rtengine/linalgebra.h:32:5: style: Class 'Vec3 < float >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] rawtherapee-5.12/rtengine/color.cc:3373:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3385:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3397:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3409:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3419:15: style: Condition 'i<50' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3432:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3444:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3456:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3468:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3478:15: style: Condition 'i<50' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3491:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3503:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3515:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3527:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3537:15: style: Condition 'i<50' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3550:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3562:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3574:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3584:15: style: Condition 'i<50' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3594:15: style: Condition 'i<50' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3607:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3619:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3631:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3643:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3653:15: style: Condition 'i<50' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3671:15: style: Condition 'i<50' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3683:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3696:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3709:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3722:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3735:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3745:15: style: Condition 'i<50' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3755:15: style: Condition 'i<50' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3769:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3782:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3795:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3808:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3821:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3834:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3844:15: style: Condition 'i<50' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3854:15: style: Condition 'i<50' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3868:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3881:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3894:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3907:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3920:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3933:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3943:15: style: Condition 'i<50' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3953:15: style: Condition 'i<50' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3969:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3984:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:3999:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4014:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4027:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4040:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4050:15: style: Condition 'i<50' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4060:15: style: Condition 'i<50' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4077:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4092:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4107:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4122:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4135:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4148:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4159:15: style: Condition 'i<50' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4168:15: style: Condition 'i<50' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4182:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4197:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4212:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4227:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4240:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4253:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4263:15: style: Condition 'i<50' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4273:15: style: Condition 'i<50' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4290:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4305:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4320:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4335:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4348:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4361:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4378:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4393:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4408:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4423:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4436:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4449:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4465:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4480:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4495:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4510:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4523:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4536:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4551:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4563:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4575:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4587:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4601:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4615:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4629:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4641:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4651:15: style: Condition 'i<50' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4663:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4675:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4689:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4703:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4718:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4732:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4758:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4770:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4782:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4796:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4811:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4821:15: style: Condition 'i<50' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4831:15: style: Condition 'i<50' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4843:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4857:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4871:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4885:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4899:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4909:15: style: Condition 'i<50' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4922:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4934:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4946:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4960:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4974:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4984:15: style: Condition 'i<50' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:4997:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5009:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5021:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5033:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5045:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5058:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5070:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5082:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5096:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5110:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5123:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5135:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5149:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5163:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5175:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5188:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5200:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5214:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5228:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5240:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5256:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5268:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5280:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5304:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5317:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5341:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5353:22: style: Condition 'i<90' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5369:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5383:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5397:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5411:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5425:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5439:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5456:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5470:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5484:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5498:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5512:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5526:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5542:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5556:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5570:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5584:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5598:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5612:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5629:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5643:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5657:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5671:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5685:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5699:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5716:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5730:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5744:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5758:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5772:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5786:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5827:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5841:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5855:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5869:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5913:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5927:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5941:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/color.cc:5955:22: style: Condition 'i<140' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/iimage.cc:51:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable igammatab_srgb [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/color.cc:2541:11: style: The scope of the variable 'epsil' can be reduced. [variableScope] rawtherapee-5.12/rtengine/color.cc:1437:155: style:inconclusive: Function 'interpolateRGBColor' argument 8 names different: declaration 'channels' definition 'toDo'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/color.h:872:117: note: Function 'interpolateRGBColor' argument 8 names different: declaration 'channels' definition 'toDo'. rawtherapee-5.12/rtengine/color.cc:1437:155: note: Function 'interpolateRGBColor' argument 8 names different: declaration 'channels' definition 'toDo'. rawtherapee-5.12/rtengine/color.cc:1726:28: style:inconclusive: Function 'RGB2Lab' argument 1 names different: declaration 'X' definition 'R'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/color.h:672:32: note: Function 'RGB2Lab' argument 1 names different: declaration 'X' definition 'R'. rawtherapee-5.12/rtengine/color.cc:1726:28: note: Function 'RGB2Lab' argument 1 names different: declaration 'X' definition 'R'. rawtherapee-5.12/rtengine/color.cc:1726:38: style:inconclusive: Function 'RGB2Lab' argument 2 names different: declaration 'Y' definition 'G'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/color.h:672:42: note: Function 'RGB2Lab' argument 2 names different: declaration 'Y' definition 'G'. rawtherapee-5.12/rtengine/color.cc:1726:38: note: Function 'RGB2Lab' argument 2 names different: declaration 'Y' definition 'G'. rawtherapee-5.12/rtengine/color.cc:1726:48: style:inconclusive: Function 'RGB2Lab' argument 3 names different: declaration 'Z' definition 'B'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/color.h:672:52: note: Function 'RGB2Lab' argument 3 names different: declaration 'Z' definition 'B'. rawtherapee-5.12/rtengine/color.cc:1726:48: note: Function 'RGB2Lab' argument 3 names different: declaration 'Z' definition 'B'. rawtherapee-5.12/rtengine/color.cc:1874:27: style:inconclusive: Function 'XYZ2Lab' argument 1 names different: declaration 'x' definition 'X'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/color.h:671:31: note: Function 'XYZ2Lab' argument 1 names different: declaration 'x' definition 'X'. rawtherapee-5.12/rtengine/color.cc:1874:27: note: Function 'XYZ2Lab' argument 1 names different: declaration 'x' definition 'X'. rawtherapee-5.12/rtengine/color.cc:1874:36: style:inconclusive: Function 'XYZ2Lab' argument 2 names different: declaration 'y' definition 'Y'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/color.h:671:40: note: Function 'XYZ2Lab' argument 2 names different: declaration 'y' definition 'Y'. rawtherapee-5.12/rtengine/color.cc:1874:36: note: Function 'XYZ2Lab' argument 2 names different: declaration 'y' definition 'Y'. rawtherapee-5.12/rtengine/color.cc:1874:45: style:inconclusive: Function 'XYZ2Lab' argument 3 names different: declaration 'z' definition 'Z'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/color.h:671:49: note: Function 'XYZ2Lab' argument 3 names different: declaration 'z' definition 'Z'. rawtherapee-5.12/rtengine/color.cc:1874:45: note: Function 'XYZ2Lab' argument 3 names different: declaration 'z' definition 'Z'. rawtherapee-5.12/rtengine/color.cc:1907:27: style:inconclusive: Function 'Yuv2Lab' argument 1 names different: declaration 'Y' definition 'Yin'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/color.h:697:31: note: Function 'Yuv2Lab' argument 1 names different: declaration 'Y' definition 'Yin'. rawtherapee-5.12/rtengine/color.cc:1907:27: note: Function 'Yuv2Lab' argument 1 names different: declaration 'Y' definition 'Yin'. rawtherapee-5.12/rtengine/color.cc:2094:47: style:inconclusive: Function 'eval_ACEScct_curve' argument 2 names different: declaration 'inverse' definition 'forward'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/color.h:1416:51: note: Function 'eval_ACEScct_curve' argument 2 names different: declaration 'inverse' definition 'forward'. rawtherapee-5.12/rtengine/color.cc:2094:47: note: Function 'eval_ACEScct_curve' argument 2 names different: declaration 'inverse' definition 'forward'. rawtherapee-5.12/rtengine/color.cc:2699:111: style:inconclusive: Function 'AllMunsellLch' argument 7 names different: declaration 'correctionHueChroma' definition 'correctionHuechroma'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/color.h:1456:116: note: Function 'AllMunsellLch' argument 7 names different: declaration 'correctionHueChroma' definition 'correctionHuechroma'. rawtherapee-5.12/rtengine/color.cc:2699:111: note: Function 'AllMunsellLch' argument 7 names different: declaration 'correctionHueChroma' definition 'correctionHuechroma'. rawtherapee-5.12/rtengine/color.cc:2756:83: style:inconclusive: Function 'AllMunsellLch' argument 5 names different: declaration 'correctionHueChroma' definition 'correctionHuechroma'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/color.h:1457:88: note: Function 'AllMunsellLch' argument 5 names different: declaration 'correctionHueChroma' definition 'correctionHuechroma'. rawtherapee-5.12/rtengine/color.cc:2756:83: note: Function 'AllMunsellLch' argument 5 names different: declaration 'correctionHueChroma' definition 'correctionHuechroma'. rawtherapee-5.12/rtengine/color.cc:2166:41: style: Parameter 'in' can be declared as const array [constParameterReference] rawtherapee-5.12/rtengine/color.cc:1726:28: style: Parameter 'R' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/color.cc:1726:38: style: Parameter 'G' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/color.cc:1726:48: style: Parameter 'B' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/color.cc:1829:33: style: Parameter 'L' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/color.cc:1829:43: style: Parameter 'a' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/color.cc:1829:53: style: Parameter 'b' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/color.cc:2289:37: style: Parameter 'p' can be declared as const array [constParameter] rawtherapee-5.12/rtengine/colortemp.cc:4687:13: style: The scope of the variable 'numero_color' can be reduced. [variableScope] rawtherapee-5.12/rtengine/colortemp.cc:4588:36: style:inconclusive: Function 'temp2mulxyz' argument 1 names different: declaration 'tem' definition 'temp'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/colortemp.h:113:37: note: Function 'temp2mulxyz' argument 1 names different: declaration 'tem' definition 'temp'. rawtherapee-5.12/rtengine/colortemp.cc:4588:36: note: Function 'temp2mulxyz' argument 1 names different: declaration 'tem' definition 'temp'. rawtherapee-5.12/rtengine/colortemp.cc:228:14: warning: Uninitialized variable: tmpg [uninitvar] rawtherapee-5.12/rtengine/colortemp.cc:216:30: note: Assuming condition is false rawtherapee-5.12/rtengine/colortemp.cc:228:14: note: Uninitialized variable: tmpg rawtherapee-5.12/rtengine/colortemp.cc:228:21: warning: Uninitialized variable: tmpr [uninitvar] rawtherapee-5.12/rtengine/colortemp.cc:216:30: note: Assuming condition is false rawtherapee-5.12/rtengine/colortemp.cc:228:21: note: Uninitialized variable: tmpr rawtherapee-5.12/rtengine/colortemp.cc:5449:16: style: struct member 'WbTxyz::XX' is never used. [unusedStructMember] rawtherapee-5.12/rtengine/colortemp.cc:5450:16: style: struct member 'WbTxyz::ZZ' is never used. [unusedStructMember] rawtherapee-5.12/rtengine/klt/error.cc:28:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/klt/error.cc:50:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/klt/convolve.cc:141:21: performance: Function parameter 'kernel' should be passed by const reference. [passedByValue] rawtherapee-5.12/rtengine/klt/convolve.cc:193:21: performance: Function parameter 'kernel' should be passed by const reference. [passedByValue] rawtherapee-5.12/rtengine/klt/convolve.cc:42:18: style: Variable 'ptrend' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtengine/klt/convolve.cc:146:6: style: Variable 'ppp' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtengine/klt/klt.cc:250:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/klt/klt_util.cc:84:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/klt/klt.cc:343:26: style: Expression 'log(1 + x)' can be replaced by 'log1p(x)' to avoid loss of precision. [unpreciseMathCall] rawtherapee-5.12/rtengine/klt/klt.cc:101:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:101:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:102:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:102:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:103:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:103:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:104:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:104:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:105:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:105:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:106:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:106:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:107:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:107:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:108:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:108:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:109:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:109:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:110:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:110:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:111:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:111:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:112:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:112:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:113:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:113:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:114:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:114:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:115:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:115:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:116:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:116:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:117:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:117:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:118:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:118:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:119:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:119:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:120:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:120:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:122:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:122:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:123:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:123:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:124:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:124:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:125:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:125:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:126:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:126:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:127:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:127:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:128:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:128:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:160:3: warning: If memory allocation fails, then there is a possible null pointer dereference: fl [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:157:33: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:157:8: note: Assignment 'fl=(struct KLT_FeatureListRec*)std::malloc(nbytes)', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:160:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:163:3: warning: If memory allocation fails, then there is a possible null pointer dereference: fl [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:157:33: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:157:8: note: Assignment 'fl=(struct KLT_FeatureListRec*)std::malloc(nbytes)', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:163:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:164:26: warning: If memory allocation fails, then there is a possible null pointer dereference: fl [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:157:33: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:157:8: note: Assignment 'fl=(struct KLT_FeatureListRec*)std::malloc(nbytes)', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:164:26: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:166:5: warning: If memory allocation fails, then there is a possible null pointer dereference: fl [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:157:33: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:157:8: note: Assignment 'fl=(struct KLT_FeatureListRec*)std::malloc(nbytes)', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:166:5: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:167:5: warning: If memory allocation fails, then there is a possible null pointer dereference: fl [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:157:33: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:157:8: note: Assignment 'fl=(struct KLT_FeatureListRec*)std::malloc(nbytes)', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:167:5: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:168:5: warning: If memory allocation fails, then there is a possible null pointer dereference: fl [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:157:33: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:157:8: note: Assignment 'fl=(struct KLT_FeatureListRec*)std::malloc(nbytes)', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:168:5: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:169:5: warning: If memory allocation fails, then there is a possible null pointer dereference: fl [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:157:33: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:157:8: note: Assignment 'fl=(struct KLT_FeatureListRec*)std::malloc(nbytes)', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:169:5: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:195:3: warning: If memory allocation fails, then there is a possible null pointer dereference: fh [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:192:36: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:192:8: note: Assignment 'fh=(struct KLT_FeatureHistoryRec*)std::malloc(nbytes)', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:195:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:198:3: warning: If memory allocation fails, then there is a possible null pointer dereference: fh [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:192:36: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:192:8: note: Assignment 'fh=(struct KLT_FeatureHistoryRec*)std::malloc(nbytes)', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:198:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:199:26: warning: If memory allocation fails, then there is a possible null pointer dereference: fh [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:192:36: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:192:8: note: Assignment 'fh=(struct KLT_FeatureHistoryRec*)std::malloc(nbytes)', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:199:26: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:201:5: warning: If memory allocation fails, then there is a possible null pointer dereference: fh [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:192:36: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:192:8: note: Assignment 'fh=(struct KLT_FeatureHistoryRec*)std::malloc(nbytes)', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:201:5: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:226:3: warning: If memory allocation fails, then there is a possible null pointer dereference: ft [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:223:34: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:223:8: note: Assignment 'ft=(struct KLT_FeatureTableRec*)std::malloc(nbytes)', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:226:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:227:3: warning: If memory allocation fails, then there is a possible null pointer dereference: ft [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:223:34: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:223:8: note: Assignment 'ft=(struct KLT_FeatureTableRec*)std::malloc(nbytes)', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:227:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:230:3: warning: If memory allocation fails, then there is a possible null pointer dereference: ft [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:223:34: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:223:8: note: Assignment 'ft=(struct KLT_FeatureTableRec*)std::malloc(nbytes)', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:230:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:235:7: warning: If memory allocation fails, then there is a possible null pointer dereference: ft [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:223:34: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:223:8: note: Assignment 'ft=(struct KLT_FeatureTableRec*)std::malloc(nbytes)', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:235:7: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:300:7: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:131:22: note: Calling function 'KLTChangeTCPyramid', 1st argument 'tc' value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:300:7: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:305:7: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:131:22: note: Calling function 'KLTChangeTCPyramid', 1st argument 'tc' value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:305:7: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:310:7: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:131:22: note: Calling function 'KLTChangeTCPyramid', 1st argument 'tc' value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:310:7: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:315:7: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:131:22: note: Calling function 'KLTChangeTCPyramid', 1st argument 'tc' value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:315:7: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:320:26: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:131:22: note: Calling function 'KLTChangeTCPyramid', 1st argument 'tc' value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:320:26: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:320:43: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:131:22: note: Calling function 'KLTChangeTCPyramid', 1st argument 'tc' value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:320:43: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:357:11: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:135:21: note: Calling function 'KLTUpdateTCBorder', 1st argument 'tc' value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:408:37: note: Calling function '_pyramidSigma', 1st argument 'tc' value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:357:11: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:357:36: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:135:21: note: Calling function 'KLTUpdateTCBorder', 1st argument 'tc' value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:408:37: note: Calling function '_pyramidSigma', 1st argument 'tc' value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:357:36: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:373:20: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:135:21: note: Calling function 'KLTUpdateTCBorder', 1st argument 'tc' value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:373:20: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:376:12: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:135:21: note: Calling function 'KLTUpdateTCBorder', 1st argument 'tc' value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:376:12: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:382:7: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:135:21: note: Calling function 'KLTUpdateTCBorder', 1st argument 'tc' value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:382:7: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:387:7: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:135:21: note: Calling function 'KLTUpdateTCBorder', 1st argument 'tc' value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:387:7: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:392:7: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:135:21: note: Calling function 'KLTUpdateTCBorder', 1st argument 'tc' value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:392:7: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:397:7: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:135:21: note: Calling function 'KLTUpdateTCBorder', 1st argument 'tc' value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:397:7: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:402:19: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:135:21: note: Calling function 'KLTUpdateTCBorder', 1st argument 'tc' value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:402:19: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:402:37: warning: If memory allocation fails, then there is a possible null pointer dereference: tc [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:98:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:98:8: note: Assignment 'tc=(struct KLT_TrackingContextRec*)std::malloc(sizeof(struct KLT_TrackingContextRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:135:21: note: Calling function 'KLTUpdateTCBorder', 1st argument 'tc' value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:402:37: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/klt.cc:163:37: error: If memory allocation fails: pointer addition with NULL pointer. [nullPointerArithmeticOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:157:33: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:157:8: note: Assignment 'fl=(struct KLT_FeatureListRec*)std::malloc(nbytes)', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:163:37: note: Null pointer addition rawtherapee-5.12/rtengine/klt/klt.cc:198:37: error: If memory allocation fails: pointer addition with NULL pointer. [nullPointerArithmeticOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:192:36: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:192:8: note: Assignment 'fh=(struct KLT_FeatureHistoryRec*)std::malloc(nbytes)', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:198:37: note: Null pointer addition rawtherapee-5.12/rtengine/klt/klt.cc:235:33: error: If memory allocation fails: pointer addition with NULL pointer. [nullPointerArithmeticOutOfMemory] rawtherapee-5.12/rtengine/klt/klt.cc:232:31: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/klt.cc:232:11: note: Assignment 'first=(struct KLT_FeatureRec*)std::malloc(nFrames*nFeatures*sizeof(struct KLT_FeatureRec))', assigned value is 0 rawtherapee-5.12/rtengine/klt/klt.cc:235:33: note: Null pointer addition rawtherapee-5.12/rtengine/klt/klt.cc:74:8: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/klt.cc:81:14: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/klt.cc:84:10: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/klt.cc:98:8: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/klt.cc:157:8: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/klt.cc:164:11: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/klt.cc:192:8: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/klt.cc:199:11: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/klt.cc:223:8: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/klt.cc:230:17: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/klt.cc:232:11: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/klt.cc:449:21: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/klt.cc:451:21: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/klt.cc:453:21: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/klt.cc:498:19: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/klt.cc:499:19: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/klt.cc:500:19: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/klt.cc:163:17: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/klt/klt.cc:198:17: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/klt/klt.cc:369:9: style: The scope of the variable 'val' can be reduced. [variableScope] rawtherapee-5.12/rtengine/klt/klt_util.cc:42:14: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/klt_util.cc:120:13: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/klt_util.cc:153:13: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/klt_util.cc:49:20: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/klt/klt_util.cc:150:9: style: The scope of the variable 'tmp' can be reduced. [variableScope] rawtherapee-5.12/rtengine/klt/klt_util.cc:107:10: style: Variable 'ptr' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtengine/klt/klt_util.cc:147:10: style: Variable 'ptr' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtengine/klt/main.cpp:14:26: style: Parameter 'argv' can be declared as const array [constParameter] rawtherapee-5.12/rtengine/klt/pnmio.cc:29:5: warning: fscanf() without field width limits can crash with huge input data. [invalidscanf] rawtherapee-5.12/rtengine/klt/pnmio.cc:192:11: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/pnmio.cc:24:7: style: The scope of the variable 'i' can be reduced. [variableScope] rawtherapee-5.12/rtengine/klt/pnmio.cc:185:7: style: The scope of the variable 'i' can be reduced. [variableScope] rawtherapee-5.12/rtengine/klt/pyramid.cc:45:13: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/pyramid.cc:56:20: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/pyramid.cc:54:18: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/klt/pyramid.cc:55:20: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/klt/pyramid.cc:101:7: style: The scope of the variable 'oldncols' can be reduced. [variableScope] rawtherapee-5.12/rtengine/klt/pyramid.cc:92:19: style:inconclusive: Function '_KLTComputePyramid' argument 1 names different: declaration 'floatimg' definition 'img'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/klt/pyramid.h:25:19: note: Function '_KLTComputePyramid' argument 1 names different: declaration 'floatimg' definition 'img'. rawtherapee-5.12/rtengine/klt/pyramid.cc:92:19: note: Function '_KLTComputePyramid' argument 1 names different: declaration 'floatimg' definition 'img'. rawtherapee-5.12/rtengine/klt/selectGoodFeatures.cc:478:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/klt/selectGoodFeatures.cc:522:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/klt/selectGoodFeatures.cc:153:10: warning: If memory allocation fails, then there is a possible null pointer dereference: featuremap [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/selectGoodFeatures.cc:152:32: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/selectGoodFeatures.cc:152:16: note: Assignment 'featuremap=(unsigned char*)malloc(ncols*nrows*sizeof(unsigned char))', assigned value is 0 rawtherapee-5.12/rtengine/klt/selectGoodFeatures.cc:153:10: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/selectGoodFeatures.cc:152:16: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/selectGoodFeatures.cc:338:15: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/selectGoodFeatures.cc:343:17: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/selectGoodFeatures.cc:344:14: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/selectGoodFeatures.cc:345:14: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/selectGoodFeatures.cc:144:13: style: The scope of the variable 'val' can be reduced. [variableScope] rawtherapee-5.12/rtengine/klt/selectGoodFeatures.cc:146:8: style: Variable 'ptr' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtengine/klt/writeFeatures.cc:52:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/klt/writeFeatures.cc:108:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/klt/writeFeatures.cc:248:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/klt/writeFeatures.cc:327:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/klt/writeFeatures.cc:356:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/klt/writeFeatures.cc:394:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/klt/writeFeatures.cc:433:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/klt/writeFeatures.cc:637:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/klt/writeFeatures.cc:699:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/klt/writeFeatures.cc:762:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/klt/writeFeatures.cc:537:3: warning: fscanf() without field width limits can crash with huge input data. [invalidscanf] rawtherapee-5.12/rtengine/klt/writeFeatures.cc:549:3: warning: fscanf() without field width limits can crash with huge input data. [invalidscanf] rawtherapee-5.12/rtengine/klt/writeFeatures.cc:560:5: warning: fscanf() without field width limits can crash with huge input data. [invalidscanf] rawtherapee-5.12/rtengine/klt/writeFeatures.cc:566:5: warning: fscanf() without field width limits can crash with huge input data. [invalidscanf] rawtherapee-5.12/rtengine/klt/writeFeatures.cc:572:5: warning: fscanf() without field width limits can crash with huge input data. [invalidscanf] rawtherapee-5.12/rtengine/klt/writeFeatures.cc:56:12: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/writeFeatures.cc:57:12: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/writeFeatures.cc:58:12: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/writeFeatures.cc:39:19: style:inconclusive: Function 'KLTWriteFeatureListToPPM' argument 1 names different: declaration 'fl' definition 'featurelist'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/klt/klt.h:208:19: note: Function 'KLTWriteFeatureListToPPM' argument 1 names different: declaration 'fl' definition 'featurelist'. rawtherapee-5.12/rtengine/klt/writeFeatures.cc:39:19: note: Function 'KLTWriteFeatureListToPPM' argument 1 names different: declaration 'fl' definition 'featurelist'. rawtherapee-5.12/rtengine/klt/writeFeatures.cc:347:15: style:inconclusive: Function 'KLTWriteFeatureList' argument 2 names different: declaration 'filename' definition 'fname'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/klt/klt.h:215:15: note: Function 'KLTWriteFeatureList' argument 2 names different: declaration 'filename' definition 'fname'. rawtherapee-5.12/rtengine/klt/writeFeatures.cc:347:15: note: Function 'KLTWriteFeatureList' argument 2 names different: declaration 'filename' definition 'fname'. rawtherapee-5.12/rtengine/klt/writeFeatures.cc:385:15: style:inconclusive: Function 'KLTWriteFeatureHistory' argument 2 names different: declaration 'filename' definition 'fname'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/klt/klt.h:219:15: note: Function 'KLTWriteFeatureHistory' argument 2 names different: declaration 'filename' definition 'fname'. rawtherapee-5.12/rtengine/klt/writeFeatures.cc:385:15: note: Function 'KLTWriteFeatureHistory' argument 2 names different: declaration 'filename' definition 'fname'. rawtherapee-5.12/rtengine/klt/writeFeatures.cc:424:15: style:inconclusive: Function 'KLTWriteFeatureTable' argument 2 names different: declaration 'filename' definition 'fname'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/klt/klt.h:223:15: note: Function 'KLTWriteFeatureTable' argument 2 names different: declaration 'filename' definition 'fname'. rawtherapee-5.12/rtengine/klt/writeFeatures.cc:424:15: note: Function 'KLTWriteFeatureTable' argument 2 names different: declaration 'filename' definition 'fname'. rawtherapee-5.12/rtengine/klt/writeFeatures.cc:619:19: style:inconclusive: Function 'KLTReadFeatureList' argument 1 names different: declaration 'fl' definition 'fl_in'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/klt/klt.h:226:19: note: Function 'KLTReadFeatureList' argument 1 names different: declaration 'fl' definition 'fl_in'. rawtherapee-5.12/rtengine/klt/writeFeatures.cc:619:19: note: Function 'KLTReadFeatureList' argument 1 names different: declaration 'fl' definition 'fl_in'. rawtherapee-5.12/rtengine/klt/writeFeatures.cc:620:15: style:inconclusive: Function 'KLTReadFeatureList' argument 2 names different: declaration 'filename' definition 'fname'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/klt/klt.h:227:15: note: Function 'KLTReadFeatureList' argument 2 names different: declaration 'filename' definition 'fname'. rawtherapee-5.12/rtengine/klt/writeFeatures.cc:620:15: note: Function 'KLTReadFeatureList' argument 2 names different: declaration 'filename' definition 'fname'. rawtherapee-5.12/rtengine/klt/writeFeatures.cc:682:22: style:inconclusive: Function 'KLTReadFeatureHistory' argument 1 names different: declaration 'fh' definition 'fh_in'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/klt/klt.h:229:22: note: Function 'KLTReadFeatureHistory' argument 1 names different: declaration 'fh' definition 'fh_in'. rawtherapee-5.12/rtengine/klt/writeFeatures.cc:682:22: note: Function 'KLTReadFeatureHistory' argument 1 names different: declaration 'fh' definition 'fh_in'. rawtherapee-5.12/rtengine/klt/writeFeatures.cc:683:15: style:inconclusive: Function 'KLTReadFeatureHistory' argument 2 names different: declaration 'filename' definition 'fname'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/klt/klt.h:230:15: note: Function 'KLTReadFeatureHistory' argument 2 names different: declaration 'filename' definition 'fname'. rawtherapee-5.12/rtengine/klt/writeFeatures.cc:683:15: note: Function 'KLTReadFeatureHistory' argument 2 names different: declaration 'filename' definition 'fname'. rawtherapee-5.12/rtengine/klt/writeFeatures.cc:744:20: style:inconclusive: Function 'KLTReadFeatureTable' argument 1 names different: declaration 'ft' definition 'ft_in'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/klt/klt.h:232:20: note: Function 'KLTReadFeatureTable' argument 1 names different: declaration 'ft' definition 'ft_in'. rawtherapee-5.12/rtengine/klt/writeFeatures.cc:744:20: note: Function 'KLTReadFeatureTable' argument 1 names different: declaration 'ft' definition 'ft_in'. rawtherapee-5.12/rtengine/klt/writeFeatures.cc:745:15: style:inconclusive: Function 'KLTReadFeatureTable' argument 2 names different: declaration 'filename' definition 'fname'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/klt/klt.h:233:15: note: Function 'KLTReadFeatureTable' argument 2 names different: declaration 'filename' definition 'fname'. rawtherapee-5.12/rtengine/klt/writeFeatures.cc:745:15: note: Function 'KLTReadFeatureTable' argument 2 names different: declaration 'filename' definition 'fname'. rawtherapee-5.12/rtengine/klt/writeFeatures.cc:40:18: style: Parameter 'greyimg' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/klt/trackFeatures.cc:44:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/klt/trackFeatures.cc:1262:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/labimage.cc:113:16: style:inconclusive: Technically the member function 'rtengine::LabImage::deleteLab' can be const. [functionConst] rawtherapee-5.12/rtengine/labimage.h:45:10: note: Technically the member function 'rtengine::LabImage::deleteLab' can be const. rawtherapee-5.12/rtengine/labimage.cc:113:16: note: Technically the member function 'rtengine::LabImage::deleteLab' can be const. rawtherapee-5.12/rtengine/labimage.cc:63:39: style:inconclusive: Function 'getPipetteData' argument 1 names different: declaration 'L' definition 'v1'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/labimage.h:44:33: note: Function 'getPipetteData' argument 1 names different: declaration 'L' definition 'v1'. rawtherapee-5.12/rtengine/labimage.cc:63:39: note: Function 'getPipetteData' argument 1 names different: declaration 'L' definition 'v1'. rawtherapee-5.12/rtengine/labimage.cc:63:50: style:inconclusive: Function 'getPipetteData' argument 2 names different: declaration 'a' definition 'v2'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/labimage.h:44:43: note: Function 'getPipetteData' argument 2 names different: declaration 'a' definition 'v2'. rawtherapee-5.12/rtengine/labimage.cc:63:50: note: Function 'getPipetteData' argument 2 names different: declaration 'a' definition 'v2'. rawtherapee-5.12/rtengine/labimage.cc:63:61: style:inconclusive: Function 'getPipetteData' argument 3 names different: declaration 'b' definition 'v3'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/labimage.h:44:53: note: Function 'getPipetteData' argument 3 names different: declaration 'b' definition 'v3'. rawtherapee-5.12/rtengine/labimage.cc:63:61: note: Function 'getPipetteData' argument 3 names different: declaration 'b' definition 'v3'. rawtherapee-5.12/rtengine/lcp.cc:217:60: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable XML_STATUS_ERROR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/lcp.cc:517:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/lcp.cc:877:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_EXISTS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/lcp.cc:969:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/cache.h:203:69: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/lcp.cc:875:26: performance:inconclusive: Technically the member function 'rtengine::LCPStore::isValidLCPFileName' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/lcp.h:155:10: note: Technically the member function 'rtengine::LCPStore::isValidLCPFileName' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/lcp.cc:875:26: note: Technically the member function 'rtengine::LCPStore::isValidLCPFileName' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/lcp.cc:905:35: performance:inconclusive: Technically the member function 'rtengine::LCPStore::getDefaultCommonDirectory' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/lcp.h:157:19: note: Technically the member function 'rtengine::LCPStore::getDefaultCommonDirectory' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/lcp.cc:905:35: note: Technically the member function 'rtengine::LCPStore::getDefaultCommonDirectory' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/lcp.cc:242:12: warning: Class 'LCPProfile' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] rawtherapee-5.12/rtengine/lcp.cc:242:12: warning: Class 'LCPProfile' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] rawtherapee-5.12/rtengine/lcp.cc:624:31: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtengine/klt/trackFeatures.cc:536:3: warning: If memory allocation fails, then there is a possible null pointer dereference: m [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/trackFeatures.cc:535:24: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/trackFeatures.cc:535:7: note: Assignment 'm=(float**)malloc((unsigned long)(nr*sizeof(float*)))', assigned value is 0 rawtherapee-5.12/rtengine/klt/trackFeatures.cc:536:3: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/trackFeatures.cc:537:27: warning: If memory allocation fails, then there is a possible null pointer dereference: m [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/trackFeatures.cc:535:24: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/trackFeatures.cc:535:7: note: Assignment 'm=(float**)malloc((unsigned long)(nr*sizeof(float*)))', assigned value is 0 rawtherapee-5.12/rtengine/klt/trackFeatures.cc:537:27: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/trackFeatures.cc:537:34: warning: If memory allocation fails, then there is a possible null pointer dereference: m [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/trackFeatures.cc:535:24: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/trackFeatures.cc:535:7: note: Assignment 'm=(float**)malloc((unsigned long)(nr*sizeof(float*)))', assigned value is 0 rawtherapee-5.12/rtengine/klt/trackFeatures.cc:537:34: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/trackFeatures.cc:560:21: warning: If memory allocation fails, then there is a possible null pointer dereference: ipiv [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/trackFeatures.cc:559:21: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/trackFeatures.cc:559:8: note: Assignment 'ipiv=(int*)malloc((unsigned long)(n*sizeof(int)))', assigned value is 0 rawtherapee-5.12/rtengine/klt/trackFeatures.cc:560:21: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/trackFeatures.cc:564:11: warning:inconclusive: If memory allocation fails, then there is a possible null pointer dereference: ipiv [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/trackFeatures.cc:559:21: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/trackFeatures.cc:559:8: note: Assignment 'ipiv=(int*)malloc((unsigned long)(n*sizeof(int)))', assigned value is 0 rawtherapee-5.12/rtengine/klt/trackFeatures.cc:564:11: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/trackFeatures.cc:576:8: warning:inconclusive: If memory allocation fails, then there is a possible null pointer dereference: ipiv [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/klt/trackFeatures.cc:559:21: note: Assuming allocation function fails rawtherapee-5.12/rtengine/klt/trackFeatures.cc:559:8: note: Assignment 'ipiv=(int*)malloc((unsigned long)(n*sizeof(int)))', assigned value is 0 rawtherapee-5.12/rtengine/klt/trackFeatures.cc:576:8: note: Null pointer dereference rawtherapee-5.12/rtengine/klt/trackFeatures.cc:319:8: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/trackFeatures.cc:535:7: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/trackFeatures.cc:536:10: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/trackFeatures.cc:557:9: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/trackFeatures.cc:558:9: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/trackFeatures.cc:559:8: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/trackFeatures.cc:1295:14: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/trackFeatures.cc:1296:20: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/trackFeatures.cc:1297:20: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/klt/trackFeatures.cc:236:9: style: The scope of the variable 'gx' can be reduced. [variableScope] rawtherapee-5.12/rtengine/klt/trackFeatures.cc:236:13: style: The scope of the variable 'gy' can be reduced. [variableScope] rawtherapee-5.12/rtengine/klt/trackFeatures.cc:266:9: style: The scope of the variable 'diff' can be reduced. [variableScope] rawtherapee-5.12/rtengine/klt/trackFeatures.cc:553:9: style: The scope of the variable 'big' can be reduced. [variableScope] rawtherapee-5.12/rtengine/klt/trackFeatures.cc:553:17: style: The scope of the variable 'pivinv' can be reduced. [variableScope] rawtherapee-5.12/rtengine/klt/trackFeatures.cc:1450:10: style: The scope of the variable 'border' can be reduced. [variableScope] rawtherapee-5.12/rtengine/klt/trackFeatures.cc:1249:24: style:inconclusive: Function 'KLTTrackFeatures' argument 6 names different: declaration 'fl' definition 'featurelist'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/klt/klt.h:163:19: note: Function 'KLTTrackFeatures' argument 6 names different: declaration 'fl' definition 'featurelist'. rawtherapee-5.12/rtengine/klt/trackFeatures.cc:1249:24: note: Function 'KLTTrackFeatures' argument 6 names different: declaration 'fl' definition 'featurelist'. rawtherapee-5.12/rtengine/myfile.cc:226:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable s [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/myfile.cc:142:5: portability: Using memset() on struct which contains a floating point number. [memsetClassFloat] rawtherapee-5.12/rtengine/myfile.cc:165:5: portability: Using memset() on struct which contains a floating point number. [memsetClassFloat] rawtherapee-5.12/rtengine/myfile.cc:183:5: portability: Using memset() on struct which contains a floating point number. [memsetClassFloat] rawtherapee-5.12/rtengine/myfile.cc:187:13: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/myfile.cc:239:15: style: Local variable 'f' shadows outer argument [shadowArgument] rawtherapee-5.12/rtengine/myfile.cc:210:31: note: Shadowed declaration rawtherapee-5.12/rtengine/myfile.cc:239:15: note: Shadow variable rawtherapee-5.12/rtengine/myfile.cc:179:46: style: Parameter 'buf' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/panasonic_decoders.cc:308:12: error: Buffer is accessed out of bounds: initial [bufferAccessOutOfBounds] rawtherapee-5.12/rtengine/panasonic_decoders.cc:56:14: style:inconclusive: Technically the member function '::pana8_bufio_t::size' can be const. [functionConst] rawtherapee-5.12/rtengine/panasonic_decoders.cc:382:24: style:inconclusive: Technically the member function '::pana8_param_t::gammaCurve' can be const. [functionConst] rawtherapee-5.12/rtengine/panasonic_decoders.cc:91:13: note: Technically the member function '::pana8_param_t::gammaCurve' can be const. rawtherapee-5.12/rtengine/panasonic_decoders.cc:382:24: note: Technically the member function '::pana8_param_t::gammaCurve' can be const. rawtherapee-5.12/rtengine/panasonic_decoders.cc:290:25: style:inconclusive: Technically the member function '::pana8_param_t::GetDBit' can be const. [functionConst] rawtherapee-5.12/rtengine/panasonic_decoders.cc:95:14: note: Technically the member function '::pana8_param_t::GetDBit' can be const. rawtherapee-5.12/rtengine/panasonic_decoders.cc:290:25: note: Technically the member function '::pana8_param_t::GetDBit' can be const. rawtherapee-5.12/rtengine/panasonic_decoders.cc:90:5: style: Struct 'pana8_param_t' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] rawtherapee-5.12/rtengine/panasonic_decoders.cc:519:23: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:519:23: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:519:43: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:519:43: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:520:25: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:520:25: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:520:53: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:520:53: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:520:73: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:520:73: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:521:23: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:521:23: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:522:24: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:522:24: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:522:50: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:522:50: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:523:23: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:523:23: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:523:43: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:523:43: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:524:24: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:524:24: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:524:52: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:524:52: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:525:23: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:525:23: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:526:24: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:526:24: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:526:50: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:526:50: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:527:24: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:527:24: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:527:53: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:527:53: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:528:24: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:528:24: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:528:45: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:528:45: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:529:24: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:529:24: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:530:25: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:530:25: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:530:52: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:530:52: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:531:26: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:531:26: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:531:55: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:531:55: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:532:25: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:532:25: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:532:46: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:517:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:532:46: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:541:23: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:541:23: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:541:43: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:541:43: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:542:25: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:542:25: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:542:52: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:542:52: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:544:23: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:544:23: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:545:24: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:545:24: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:545:52: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:545:52: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:546:24: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:546:24: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:546:52: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:546:52: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:547:24: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:547:24: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:547:52: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:547:52: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:549:23: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:549:23: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:550:24: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:550:24: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:550:51: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:550:51: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:551:24: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:551:24: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:551:51: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:551:51: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:552:24: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:552:24: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:552:51: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:552:51: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:554:24: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:554:24: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:555:25: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:555:25: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:555:52: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:555:52: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:556:25: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:556:25: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:556:53: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:556:53: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:557:25: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:557:25: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:557:53: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:557:53: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:559:23: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:559:23: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:560:23: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:560:23: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:561:23: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:561:23: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:562:23: warning: Either the condition '!buffer' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/panasonic_decoders.cc:539:9: note: Assuming that condition '!buffer' is not redundant rawtherapee-5.12/rtengine/panasonic_decoders.cc:562:23: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:663:15: warning: If memory allocation fails, then there is a possible null pointer dereference: iobuf [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/panasonic_decoders.cc:658:51: note: Assuming allocation function fails rawtherapee-5.12/rtengine/panasonic_decoders.cc:658:28: note: Assignment 'iobuf=(unsigned char*)malloc(rowbytes*rowstep)', assigned value is 0 rawtherapee-5.12/rtengine/panasonic_decoders.cc:663:15: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:726:16: warning: If memory allocation fails, then there is a possible null pointer dereference: iobuf [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/panasonic_decoders.cc:722:51: note: Assuming allocation function fails rawtherapee-5.12/rtengine/panasonic_decoders.cc:722:28: note: Assignment 'iobuf=(unsigned char*)malloc(rowbytes*rowstep)', assigned value is 0 rawtherapee-5.12/rtengine/panasonic_decoders.cc:726:16: note: Null pointer dereference rawtherapee-5.12/rtengine/panasonic_decoders.cc:159:77: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/panasonic_decoders.cc:203:35: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/panasonic_decoders.cc:658:28: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/panasonic_decoders.cc:722:28: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/panasonic_decoders.cc:802:34: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtengine/panasonic_decoders.cc:232:39: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/panasonic_decoders.cc:255:40: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/panasonic_decoders.cc:257:37: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/panasonic_decoders.cc:264:32: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/panasonic_decoders.cc:170:13: style: The scope of the variable 'bittail' can be reduced. [variableScope] rawtherapee-5.12/rtengine/panasonic_decoders.cc:171:13: style: The scope of the variable 'bitportion' can be reduced. [variableScope] rawtherapee-5.12/rtengine/panasonic_decoders.cc:172:14: style: The scope of the variable 'inqword' can be reduced. [variableScope] rawtherapee-5.12/rtengine/panasonic_decoders.cc:221:38: portability: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS] rawtherapee-5.12/rtengine/panasonic_decoders.cc:485:69: portability: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS] rawtherapee-5.12/rtengine/panasonic_decoders.cc:632:49: portability: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS] rawtherapee-5.12/rtengine/panasonic_decoders.cc:300:50: style:inconclusive: Function 'pana8_param_t' argument 1 names different: declaration 'init' definition 'meta'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/panasonic_decoders.cc:90:39: note: Function 'pana8_param_t' argument 1 names different: declaration 'init' definition 'meta'. rawtherapee-5.12/rtengine/panasonic_decoders.cc:300:50: note: Function 'pana8_param_t' argument 1 names different: declaration 'init' definition 'meta'. rawtherapee-5.12/rtengine/panasonic_decoders.cc:382:44: style:inconclusive: Function 'gammaCurve' argument 1 names different: declaration 'i' definition 'idx'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/panasonic_decoders.cc:91:33: note: Function 'gammaCurve' argument 1 names different: declaration 'i' definition 'idx'. rawtherapee-5.12/rtengine/panasonic_decoders.cc:382:44: note: Function 'gammaCurve' argument 1 names different: declaration 'i' definition 'idx'. rawtherapee-5.12/rtengine/panasonic_decoders.cc:264:23: style: Variable 'srcrow' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtengine/panasonic_decoders.cc:453:18: style: Variable 'b' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtengine/panasonic_decoders.cc:705:71: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] rawtherapee-5.12/rtengine/iccstore.cc:685:18: style:inconclusive: Technically the member function 'rtengine::ICCStore::Implementation::getInputIntents' can be const. [functionConst] rawtherapee-5.12/rtengine/iccstore.cc:692:18: style:inconclusive: Technically the member function 'rtengine::ICCStore::Implementation::getOutputIntents' can be const. [functionConst] rawtherapee-5.12/rtengine/iccstore.cc:699:18: style:inconclusive: Technically the member function 'rtengine::ICCStore::Implementation::getProofIntents' can be const. [functionConst] rawtherapee-5.12/rtengine/iccstore.cc:732:32: style:inconclusive: Technically the member function 'rtengine::ICCStore::Implementation::getWorkingProfiles' can be const. [functionConst] rawtherapee-5.12/rtengine/iccstore.cc:780:10: performance:inconclusive: Technically the member function 'rtengine::ICCStore::Implementation::computeWorkingSpaceMatrix' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/iccstore.cc:1219:12: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/iccstore.cc:1223:16: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/iccstore.cc:1241:12: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/iccstore.cc:1245:12: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtengine/iccstore.cc:152:35: style: Local variable 'profile' shadows outer argument [shadowArgument] rawtherapee-5.12/rtengine/iccstore.cc:116:26: note: Shadowed declaration rawtherapee-5.12/rtengine/iccstore.cc:152:35: note: Shadow variable rawtherapee-5.12/rtengine/iccstore.cc:559:46: style: Local variable 'r' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iccstore.cc:537:42: note: Shadowed declaration rawtherapee-5.12/rtengine/iccstore.cc:559:46: note: Shadow variable rawtherapee-5.12/rtengine/iccstore.cc:586:46: style: Local variable 'r' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iccstore.cc:575:42: note: Shadowed declaration rawtherapee-5.12/rtengine/iccstore.cc:586:46: note: Shadow variable rawtherapee-5.12/rtengine/iccstore.cc:679:17: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtengine/iccstore.cc:740:17: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtengine/profilestore.cc:58:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable STORESTATE_NOTINITIALIZED [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/profilestore.cc:70:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable STORESTATE_NOTINITIALIZED [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/profilestore.cc:131:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable useBundledProfiles [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/profilestore.cc:186:63: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_EXISTS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/profilestore.cc:295:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable STORESTATE_NOTINITIALIZED [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/profilestore.cc:363:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable STORESTATE_NOTINITIALIZED [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/profilestore.cc:379:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable STORESTATE_NOTINITIALIZED [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/profilestore.cc:410:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable STORESTATE_NOTINITIALIZED [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/profilestore.cc:435:84: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable defProfImg [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/profilestore.cc:455:84: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable defProfImg [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/profilestore.cc:516:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable STORESTATE_NOTINITIALIZED [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/profilestore.cc:37:15: warning: Member variable 'DynamicProfileRules::rulesLoaded' is not initialized in the constructor. Maybe it should be initialized directly in the class DynamicProfileRules? [uninitDerivedMemberVar] rawtherapee-5.12/rtengine/profilestore.h:130:14: style:inconclusive: Technically the member function 'ProfileStore::SortProfiles::operator()' can be const. [functionConst] rawtherapee-5.12/rtengine/profilestore.cc:498:58: style: Parameter 'listener' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtengine/profilestore.cc:275:33: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtengine/profilestore.cc:344:85: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtengine/procparams.cc:64:81: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_DIR_SEPARATOR_S [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/procparams.cc:81:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/procparams.cc:119:69: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_DIR_SEPARATOR_S [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/procparams.cc:5129:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable spotmet [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/procparams.cc:6729:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PPVERSION [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/procparams.cc:6744:53: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RTVERSION [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/procparams.cc:8667:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LC_NUMERIC [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/procparams.cc:12104:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DEFPROFILE_INTERNAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/rt_algo.cc:223:20: style: The comparison 'numThreads == 1' is always true. [knownConditionTrueFalse] rawtherapee-5.12/rtengine/rt_algo.cc:184:25: note: 'numThreads' is assigned value '1' here. rawtherapee-5.12/rtengine/rt_algo.cc:223:20: note: The comparison 'numThreads == 1' is always true. rawtherapee-5.12/rtengine/rt_algo.cc:312:37: error: Division by zero. [zerodiv] rawtherapee-5.12/rtengine/rt_algo.cc:309:25: note: Assignment 'pass=0', assigned value is 0 rawtherapee-5.12/rtengine/rt_algo.cc:311:40: note: Assignment 'skip=pass==0?tilesize:tilesize/4', assigned value is 0 rawtherapee-5.12/rtengine/rt_algo.cc:312:37: note: Division by zero rawtherapee-5.12/rtengine/rt_algo.cc:313:37: error: Division by zero. [zerodiv] rawtherapee-5.12/rtengine/rt_algo.cc:309:25: note: Assignment 'pass=0', assigned value is 0 rawtherapee-5.12/rtengine/rt_algo.cc:311:40: note: Assignment 'skip=pass==0?tilesize:tilesize/4', assigned value is 0 rawtherapee-5.12/rtengine/rt_algo.cc:313:37: note: Division by zero rawtherapee-5.12/rtengine/rt_algo.cc:167:124: style:inconclusive: Function 'findMinMaxPercentile' argument 7 names different: declaration 'multiThread' definition 'multithread'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/rt_algo.h:26:124: note: Function 'findMinMaxPercentile' argument 7 names different: declaration 'multiThread' definition 'multithread'. rawtherapee-5.12/rtengine/rt_algo.cc:167:124: note: Function 'findMinMaxPercentile' argument 7 names different: declaration 'multiThread' definition 'multithread'. rawtherapee-5.12/rtengine/rt_algo.cc:303:136: style:inconclusive: Function 'buildBlendMask' argument 7 names different: declaration 'clipmask' definition 'clipMask'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/rt_algo.h:27:144: note: Function 'buildBlendMask' argument 7 names different: declaration 'clipmask' definition 'clipMask'. rawtherapee-5.12/rtengine/rt_algo.cc:303:136: note: Function 'buildBlendMask' argument 7 names different: declaration 'clipmask' definition 'clipMask'. rawtherapee-5.12/rtengine/rt_algo.cc:364:31: style: Local variable 'numTilesH' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/rt_algo.cc:313:23: note: Shadowed declaration rawtherapee-5.12/rtengine/rt_algo.cc:364:31: note: Shadow variable rawtherapee-5.12/rtengine/rt_algo.cc:365:31: style: Local variable 'numTilesW' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/rt_algo.cc:312:23: note: Shadowed declaration rawtherapee-5.12/rtengine/rt_algo.cc:365:31: note: Shadow variable rawtherapee-5.12/rtengine/rt_algo.cc:367:53: style: Local variable 'variances' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/rt_algo.cc:314:45: note: Shadowed declaration rawtherapee-5.12/rtengine/rt_algo.cc:367:53: note: Shadow variable rawtherapee-5.12/rtengine/rt_algo.cc:386:27: style: Local variable 'minvar' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/rt_algo.cc:336:19: note: Shadowed declaration rawtherapee-5.12/rtengine/rt_algo.cc:386:27: note: Shadow variable rawtherapee-5.12/rtengine/rt_algo.cc:387:25: style: Local variable 'minI' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/rt_algo.cc:337:17: note: Shadowed declaration rawtherapee-5.12/rtengine/rt_algo.cc:387:25: note: Shadow variable rawtherapee-5.12/rtengine/rt_algo.cc:387:35: style: Local variable 'minJ' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/rt_algo.cc:337:27: note: Shadowed declaration rawtherapee-5.12/rtengine/rt_algo.cc:387:35: note: Shadow variable rawtherapee-5.12/rtengine/utils.cc:231:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable in [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtengine/utils.cc:248:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/adjuster.cc:78:84: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ALIGN_CENTER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/adjuster.cc:199:83: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ALIGN_CENTER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/adjuster.cc:306:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_CONTROL_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/adjuster.cc:505:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ALIGN_START [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/aspectratios.cc:63:16: style: Consider using std::copy algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/guiutils.h:203:10: performance:inconclusive: Either there is a missing 'override', or the member function 'ExpanderBox::show' can be static. [functionStatic] rawtherapee-5.12/rtgui/guiutils.h:205:10: performance:inconclusive: Either there is a missing 'override', or the member function 'ExpanderBox::hide' can be static. [functionStatic] rawtherapee-5.12/rtgui/guiutils.h:206:10: performance:inconclusive: Either there is a missing 'override', or the member function 'ExpanderBox::set_visible' can be static. [functionStatic] rawtherapee-5.12/rtgui/guiutils.h:697:10: style:inconclusive: Technically the member function 'BackBuffer::isDirty' can be const. [functionConst] rawtherapee-5.12/rtgui/guiutils.h:702:10: style:inconclusive: Technically the member function 'BackBuffer::surfaceCreated' can be const. [functionConst] rawtherapee-5.12/rtgui/guiutils.h:706:40: style:inconclusive: Technically the member function 'BackBuffer::getSurface' can be const. [functionConst] rawtherapee-5.12/rtgui/guiutils.h:622:5: style: Class 'GradientMilestone' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] rawtherapee-5.12/rtgui/batchqueuebuttonset.cc:40:84: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ICON_SIZE_BUTTON [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/batchqueue.cc:106:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/batchqueue.cc:118:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable THLOC_BATCHQUEUE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/batchqueue.cc:231:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_CONTROL_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/batchqueue.cc:302:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable binary [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/batchqueue.cc:348:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable binary [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/batchqueue.cc:1035:89: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_FILE_ATTRIBUTE_TIME_MODIFIED [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/batchqueue.cc:1097:56: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_EXISTS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/batchqueueentry.cc:63:83: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ICON_SIZE_SMALL_TOOLBAR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/batchqueueentry.cc:124:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ANTIALIAS_SUBPIXEL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbbrowserbase.h:166:15: style:inconclusive: Either there is a missing 'override', or the member function 'ThumbBrowserBase::getLocation' can be const. [functionConst] rawtherapee-5.12/rtgui/thumbbrowserbase.h:206:48: style:inconclusive: Either there is a missing 'override', or the member function 'ThumbBrowserBase::getEntries' can be const. [functionConst] rawtherapee-5.12/rtgui/thumbbrowserbase.h:76:41: style:inconclusive: Either there is a missing 'override', or the member function 'ThumbBrowserBase::Internal::getStyle' can be const. [functionConst] rawtherapee-5.12/rtgui/thumbbrowserbase.h:79:19: style:inconclusive: Either there is a missing 'override', or the member function 'ThumbBrowserBase::Internal::getNormalTextColor' can be const. [functionConst] rawtherapee-5.12/rtgui/thumbbrowserbase.h:82:19: style:inconclusive: Either there is a missing 'override', or the member function 'ThumbBrowserBase::Internal::getSelectedTextColor' can be const. [functionConst] rawtherapee-5.12/rtgui/thumbbrowserbase.h:85:19: style:inconclusive: Either there is a missing 'override', or the member function 'ThumbBrowserBase::Internal::getNormalBgColor' can be const. [functionConst] rawtherapee-5.12/rtgui/thumbbrowserbase.h:88:19: style:inconclusive: Either there is a missing 'override', or the member function 'ThumbBrowserBase::Internal::getSelectedBgColor' can be const. [functionConst] rawtherapee-5.12/rtgui/thumbbrowserbase.h:96:14: style:inconclusive: Either there is a missing 'override', or the member function 'ThumbBrowserBase::Internal::isDirty' can be const. [functionConst] rawtherapee-5.12/rtgui/thumbnail.h:86:13: style: Struct 'Property < int >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] rawtherapee-5.12/rtgui/thumbnail.h:86:13: style: Struct 'Property < bool >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] rawtherapee-5.12/rtgui/batchqueueentry.cc:37:60: style:inconclusive: Function 'BatchQueueEntry' argument 1 names different: declaration 'job' definition 'pjob'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/batchqueueentry.h:78:47: note: Function 'BatchQueueEntry' argument 1 names different: declaration 'job' definition 'pjob'. rawtherapee-5.12/rtgui/batchqueueentry.cc:37:60: note: Function 'BatchQueueEntry' argument 1 names different: declaration 'job' definition 'pjob'. rawtherapee-5.12/rtgui/batchqueue.cc:471:16: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] rawtherapee-5.12/rtgui/filebrowser.h:175:9: style:inconclusive: Either there is a missing 'override', or the member function 'FileBrowser::getNumFiltered' can be const. [functionConst] rawtherapee-5.12/rtgui/filecatalog.h:209:19: style:inconclusive: Either there is a missing 'override', or the member function 'FileCatalog::lastSelectedDir' can be const. [functionConst] rawtherapee-5.12/rtgui/filebrowser.h:191:10: warning: The class 'FileBrowser' defines member function with name 'enableTabMode' also defined in its parent class 'ThumbBrowserBase'. [duplInheritedMember] rawtherapee-5.12/rtgui/thumbbrowserbase.h:223:10: note: Parent function 'ThumbBrowserBase::enableTabMode' rawtherapee-5.12/rtgui/filebrowser.h:191:10: note: Derived function 'FileBrowser::enableTabMode' rawtherapee-5.12/rtgui/partialpastedlg.h:261:10: style: The function 'partialSpotUpdated' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] rawtherapee-5.12/rtgui/partialpastedlg.h:52:18: note: Virtual function in base class rawtherapee-5.12/rtgui/partialpastedlg.h:261:10: note: Function in derived class rawtherapee-5.12/rtgui/batchqueue.cc:645:13: style: Local variable 'sequence' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/batchqueue.h:111:9: note: Shadowed declaration rawtherapee-5.12/rtgui/batchqueue.cc:645:13: note: Shadow variable rawtherapee-5.12/rtgui/batchqueue.cc:644:15: style: Variable 'entry' can be declared as reference to const [constVariableReference] rawtherapee-5.12/rtgui/batchqueue.cc:321:24: style: Variable 'entry' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/batchqueue.cc:468:16: style: Variable 'timeinfo' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/batchqueue.cc:961:34: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/progressconnector.h:105:128: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable THREAD_PRIORITY_NORMAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/batchqueuepanel.cc:28:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_IS_DIR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/batchqueuepanel.cc:45:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/batchqueuepanel.cc:235:75: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ICON_SIZE_LARGE_TOOLBAR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/batchqueuepanel.cc:477:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_CONTROL_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/batchqueuepanel.cc:510:91: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_CHOOSER_ACTION_SELECT_FOLDER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/progressconnector.h:109:7: style:inconclusive: Technically the member function 'ProgressConnector::returnValue' can be const. [functionConst] rawtherapee-5.12/rtgui/splash.h:54:10: style:inconclusive: Either there is a missing 'override', or the member function 'Splash::hasReleaseNotes' can be const. [functionConst] rawtherapee-5.12/rtgui/rtwindow.h:134:10: style:inconclusive: Either there is a missing 'override', or the member function 'RTWindow::getIsFullscreen' can be const. [functionConst] rawtherapee-5.12/rtgui/batchqueuepanel.cc:224:25: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtgui/framing.h:83:9: debug: Failed to parse 'using CallbackFunc = void ( Framing :: * ) ( ) ;'. The checking continues anyway. [simplifyUsing] rawtherapee-5.12/rtgui/bayerpreprocess.cc:36:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DARKFRAME [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/bayerpreprocess.cc:137:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvPreProcessGEquilThresh [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/toolpanel.h:160:19: style:inconclusive: Either there is a missing 'override', or the member function 'ToolPanel::getToolName' can be const. [functionConst] rawtherapee-5.12/rtgui/paramsedited.h:1233:9: style: Struct 'LocallabSpotEdited' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] rawtherapee-5.12/rtgui/toolpanel.h:90:5: style: Class 'ToolPanel' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] rawtherapee-5.12/rtgui/thresholdselector.h:247:108: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TS_BOTTOMLEFT [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/batchtoolpanelcoord.cc:457:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvCTHFlip [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/batchtoolpanelcoord.cc:685:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvProfileChanged [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/batchtoolpanelcoord.cc:765:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable temperature [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/bayerprocess.cc:39:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DARKFRAME [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/bayerprocess.cc:359:159: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCB [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/bayerprocess.cc:539:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvDemosaicDCBIter [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/bayerprocess.cc:564:74: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCB [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/bayerprocess.cc:621:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvRawImageNum [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/bayerprocess.cc:629:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvDemosaicDCBEnhanced [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/bayerprocess.cc:735:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvPixelShiftMotionMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/framing.h:85:9: warning: Member variable 'DimensionGui::box' is not initialized in the constructor. [uninitMemberVar] rawtherapee-5.12/rtgui/framing.h:85:9: warning: Member variable 'DimensionGui::value' is not initialized in the constructor. [uninitMemberVar] rawtherapee-5.12/rtgui/framing.h:85:9: warning: Member variable 'DimensionGui::isDirty' is not initialized in the constructor. [uninitMemberVar] rawtherapee-5.12/rtgui/labgrid.h:75:9: warning: Member variable 'FunctionParams::x_min' is not initialized in the constructor. [uninitMemberVar] rawtherapee-5.12/rtgui/labgrid.h:75:9: warning: Member variable 'FunctionParams::x_max' is not initialized in the constructor. [uninitMemberVar] rawtherapee-5.12/rtgui/labgrid.h:75:9: warning: Member variable 'FunctionParams::y_min' is not initialized in the constructor. [uninitMemberVar] rawtherapee-5.12/rtgui/labgrid.h:75:9: warning: Member variable 'FunctionParams::y_max' is not initialized in the constructor. [uninitMemberVar] rawtherapee-5.12/rtgui/bayerrawexposure.cc:34:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DARKFRAME [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/bayerrawexposure.cc:179:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvPreProcessExpBlackzero [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/bayerrawexposure.cc:203:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvPreProcessExptwoGreen [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/curvelistener.h:39:10: style:inconclusive: Technically the member function 'CurveListener::isMulti' can be const. [functionConst] rawtherapee-5.12/rtgui/thresholdselector.h:213:10: style:inconclusive: Either there is a missing 'override', or the member function 'ThresholdSelector::isStartAtOne' can be const. [functionConst] rawtherapee-5.12/rtgui/thresholdselector.h:217:10: style:inconclusive: Either there is a missing 'override', or the member function 'ThresholdSelector::isDouble' can be const. [functionConst] rawtherapee-5.12/rtgui/thresholdselector.h:222:18: style:inconclusive: Either there is a missing 'override', or the member function 'ThresholdSelector::getPrecision' can be const. [functionConst] rawtherapee-5.12/rtgui/popupcommon.h:111:54: style:inconclusive: Technically the member function 'PopUpCommon::signal_changed' can be const. [functionConst] rawtherapee-5.12/rtgui/popupcommon.h:59:25: note: Technically the member function 'PopUpCommon::signal_changed' can be const. rawtherapee-5.12/rtgui/popupcommon.h:111:54: note: Technically the member function 'PopUpCommon::signal_changed' can be const. rawtherapee-5.12/rtgui/popupcommon.h:116:60: style:inconclusive: Technically the member function 'PopUpCommon::signal_item_selected' can be const. [functionConst] rawtherapee-5.12/rtgui/popupcommon.h:60:31: note: Technically the member function 'PopUpCommon::signal_item_selected' can be const. rawtherapee-5.12/rtgui/popupcommon.h:116:60: note: Technically the member function 'PopUpCommon::signal_item_selected' can be const. rawtherapee-5.12/rtgui/mycurve.h:116:10: performance:inconclusive: Either there is a missing 'override', or the member function 'MyCurve::updateBackgroundHistogram' can be static. [functionStatic] rawtherapee-5.12/rtgui/curveeditorgroup.h:130:9: style:inconclusive: Technically the member function 'CurveEditorSubGroup::getValUnchanged' can be const. [functionConst] rawtherapee-5.12/rtgui/curveeditorgroup.h:134:9: style:inconclusive: Technically the member function 'CurveEditorSubGroup::getValLinear' can be const. [functionConst] rawtherapee-5.12/rtgui/toolbar.h:84:14: style:inconclusive: Either there is a missing 'override', or the member function 'ToolBar::getTool' can be const. [functionConst] rawtherapee-5.12/rtgui/toolbar.h:89:10: style:inconclusive: Either there is a missing 'override', or the member function 'ToolBar::showColorPickers' can be const. [functionConst] rawtherapee-5.12/rtgui/toolpanelcoord.h:345:10: style:inconclusive: Either there is a missing 'override', or the member function 'ToolPanelCoordinator::getChangedState' can be const. [functionConst] rawtherapee-5.12/rtgui/popupbutton.h:34:10: warning: The class 'PopUpButton' defines member function with name 'show' also defined in its parent class 'PopUpCommon'. [duplInheritedMember] rawtherapee-5.12/rtgui/popupcommon.h:75:10: note: Parent function 'PopUpCommon::show' rawtherapee-5.12/rtgui/popupbutton.h:34:10: note: Derived function 'PopUpButton::show' rawtherapee-5.12/rtgui/popupbutton.h:35:10: warning: The class 'PopUpButton' defines member function with name 'set_tooltip_text' also defined in its parent class 'PopUpCommon'. [duplInheritedMember] rawtherapee-5.12/rtgui/popupcommon.h:76:10: note: Parent function 'PopUpCommon::set_tooltip_text' rawtherapee-5.12/rtgui/popupbutton.h:35:10: note: Derived function 'PopUpButton::set_tooltip_text' rawtherapee-5.12/rtgui/controllines.h:111:10: warning: The class 'ControlLineManager' defines member function with name 'setEditProvider' also defined in its parent class 'EditSubscriber'. [duplInheritedMember] rawtherapee-5.12/rtgui/editcallbacks.h:61:24: note: Parent function 'EditSubscriber::setEditProvider' rawtherapee-5.12/rtgui/controllines.h:111:10: note: Derived function 'ControlLineManager::setEditProvider' rawtherapee-5.12/rtgui/popupbutton.h:33:5: style: Class 'PopUpButton' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] rawtherapee-5.12/rtgui/toolpanelcoord.h:324:5: style: Class 'ToolPanelCoordinator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] rawtherapee-5.12/rtgui/framing.h:43:6: style: The destructor '~Framing' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] rawtherapee-5.12/rtgui/adjuster.h:30:14: note: Virtual destructor in base class rawtherapee-5.12/rtgui/framing.h:43:6: note: Destructor in derived class rawtherapee-5.12/rtgui/controlspotpanel.h:120:6: style: The destructor '~ControlSpotPanel' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] rawtherapee-5.12/rtgui/adjuster.h:30:14: note: Virtual destructor in base class rawtherapee-5.12/rtgui/controlspotpanel.h:120:6: note: Destructor in derived class rawtherapee-5.12/rtgui/locallabtools.h:182:14: style: The destructor '~LocallabTool' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] rawtherapee-5.12/rtgui/toolpanel.h:91:14: note: Virtual destructor in base class rawtherapee-5.12/rtgui/locallabtools.h:182:14: note: Destructor in derived class rawtherapee-5.12/rtgui/locallabtools.h:385:6: style: The destructor '~LocallabColor' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] rawtherapee-5.12/rtgui/locallabtools.h:182:14: note: Virtual destructor in base class rawtherapee-5.12/rtgui/locallabtools.h:385:6: note: Destructor in derived class rawtherapee-5.12/rtgui/locallabtools.h:521:6: style: The destructor '~LocallabExposure' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] rawtherapee-5.12/rtgui/locallabtools.h:182:14: note: Virtual destructor in base class rawtherapee-5.12/rtgui/locallabtools.h:521:6: note: Destructor in derived class rawtherapee-5.12/rtgui/locallabtools.h:671:6: style: The destructor '~LocallabShadow' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] rawtherapee-5.12/rtgui/locallabtools.h:182:14: note: Virtual destructor in base class rawtherapee-5.12/rtgui/locallabtools.h:671:6: note: Destructor in derived class rawtherapee-5.12/rtgui/locallabtools.h:774:6: style: The destructor '~LocallabVibrance' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] rawtherapee-5.12/rtgui/locallabtools.h:182:14: note: Virtual destructor in base class rawtherapee-5.12/rtgui/locallabtools.h:774:6: note: Destructor in derived class rawtherapee-5.12/rtgui/locallabtools.h:1000:6: style: The destructor '~LocallabBlur' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] rawtherapee-5.12/rtgui/locallabtools.h:182:14: note: Virtual destructor in base class rawtherapee-5.12/rtgui/locallabtools.h:1000:6: note: Destructor in derived class rawtherapee-5.12/rtgui/locallabtools.h:1101:6: style: The destructor '~LocallabTone' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] rawtherapee-5.12/rtgui/locallabtools.h:182:14: note: Virtual destructor in base class rawtherapee-5.12/rtgui/locallabtools.h:1101:6: note: Destructor in derived class rawtherapee-5.12/rtgui/locallabtools.h:1205:6: style: The destructor '~LocallabRetinex' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] rawtherapee-5.12/rtgui/locallabtools.h:182:14: note: Virtual destructor in base class rawtherapee-5.12/rtgui/locallabtools.h:1205:6: note: Destructor in derived class rawtherapee-5.12/rtgui/locallabtools.h:1411:6: style: The destructor '~LocallabContrast' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] rawtherapee-5.12/rtgui/locallabtools.h:182:14: note: Virtual destructor in base class rawtherapee-5.12/rtgui/locallabtools.h:1411:6: note: Destructor in derived class rawtherapee-5.12/rtgui/locallabtools.h:1516:6: style: The destructor '~LocallabCBDL' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] rawtherapee-5.12/rtgui/locallabtools.h:182:14: note: Virtual destructor in base class rawtherapee-5.12/rtgui/locallabtools.h:1516:6: note: Destructor in derived class rawtherapee-5.12/rtgui/locallabtools.h:1630:6: style: The destructor '~LocallabLog' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] rawtherapee-5.12/rtgui/locallabtools.h:182:14: note: Virtual destructor in base class rawtherapee-5.12/rtgui/locallabtools.h:1630:6: note: Destructor in derived class rawtherapee-5.12/rtgui/locallabtools.h:1726:6: style: The destructor '~LocallabMask' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] rawtherapee-5.12/rtgui/locallabtools.h:182:14: note: Virtual destructor in base class rawtherapee-5.12/rtgui/locallabtools.h:1726:6: note: Destructor in derived class rawtherapee-5.12/rtgui/locallabtools.h:2055:6: style: The destructor '~Locallabcie' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] rawtherapee-5.12/rtgui/thresholdadjuster.h:36:14: note: Virtual destructor in base class rawtherapee-5.12/rtgui/locallabtools.h:2055:6: note: Destructor in derived class rawtherapee-5.12/rtgui/controllines.h:96:6: style: The destructor '~ControlLineManager' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] rawtherapee-5.12/rtgui/editcallbacks.h:59:14: note: Virtual destructor in base class rawtherapee-5.12/rtgui/controllines.h:96:6: note: Destructor in derived class rawtherapee-5.12/rtgui/spot.h:105:6: style: The destructor '~Spot' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] rawtherapee-5.12/rtgui/toolpanel.h:91:14: note: Virtual destructor in base class rawtherapee-5.12/rtgui/spot.h:105:6: note: Destructor in derived class rawtherapee-5.12/rtgui/mycurve.h:116:44: style: Parameter 'hist' can be declared as reference to const [constParameterReference] rawtherapee-5.12/rtgui/blackwhite.cc:52:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PACK_SHRINK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/blackwhite.cc:608:68: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable STD_BW [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/blackwhite.cc:669:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvBWMethodalg [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/blackwhite.cc:793:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvBWsetting [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/blackwhite.cc:815:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvBWfilter [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/blackwhite.cc:860:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvBWmethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/blackwhite.cc:1135:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvBWred [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/bqentryupdater.cc:95:141: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable THREAD_PRIORITY_LOW [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/bqentryupdater.cc:153:29: style: Condition '!isEmpty' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtgui/bqentryupdater.cc:117:12: note: Assuming that condition 'isEmpty' is not redundant rawtherapee-5.12/rtgui/bqentryupdater.cc:153:29: note: Condition '!isEmpty' is always true rawtherapee-5.12/rtgui/bqentryupdater.cc:201:9: style: Condition '!stopped' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtgui/bqentryupdater.cc:197:20: note: Assuming that condition 'stopped' is not redundant rawtherapee-5.12/rtgui/bqentryupdater.cc:201:9: note: Condition '!stopped' is always true rawtherapee-5.12/rtgui/bqentryupdater.cc:207:13: style: Condition '!stopped' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtgui/bqentryupdater.cc:197:20: note: Assuming that condition 'stopped' is not redundant rawtherapee-5.12/rtgui/bqentryupdater.cc:207:13: note: Condition '!stopped' is always true rawtherapee-5.12/rtgui/bqentryupdater.cc:170:65: style: Parameter 'listener' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtgui/bqentryupdater.cc:64:57: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/bqentryupdater.cc:184:42: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/cacheimagedata.cc:81:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LC_NUMERIC [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cacheimagedata.cc:282:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_EXISTS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cachemanager.cc:65:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cachemanager.cc:101:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable metadata_xmp_sync [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cachemanager.cc:206:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cachemanager.cc:281:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cachemanager.cc:305:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cachemanager.cc:335:73: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CHECKSUM_MD5 [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cachemanager.cc:62:15: style: Consider using std::any_of, std::all_of, std::none_of, or std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/checkbox.cc:66:16: style:inconclusive: Either there is a missing 'override', or the member function 'CheckBox::getLastActive' can be const. [functionConst] rawtherapee-5.12/rtgui/checkbox.h:58:10: note: Either there is a missing 'override', or the member function 'CheckBox::getLastActive' can be const. rawtherapee-5.12/rtgui/checkbox.cc:66:16: note: Either there is a missing 'override', or the member function 'CheckBox::getLastActive' can be const. rawtherapee-5.12/rtgui/chmixer.cc:45:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ALIGN_START [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/chmixer.cc:183:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvChMixer [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/coarsepanel.cc:34:77: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ICON_SIZE_LARGE_TOOLBAR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/colorappearance.cc:225:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LUMINANCECURVE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/colorappearance.cc:1209:72: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LIGHT [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/colorappearance.cc:1582:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvCATCurveMode1 [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/colorappearance.cc:1598:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvCATCurveMode2 [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/colorappearance.cc:1627:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvCATCurveMode3 [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/colorappearance.cc:1895:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvCATtempout [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/colorappearance.cc:1959:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvCATDegree [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/colorappearance.cc:2128:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvCATsurr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/colorappearance.cc:2137:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvCATMethodsur [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/colorappearance.cc:2160:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvCATMethodWB [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/colorappearance.cc:2274:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvCATMethodalg [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/coloredbar.cc:78:73: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FORMAT_RGB24 [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/coloredbar.cc:169:18: style:inconclusive: Technically the member function 'ColoredBar::canGetColors' can be const. [functionConst] rawtherapee-5.12/rtgui/coloredbar.h:53:10: note: Technically the member function 'ColoredBar::canGetColors' can be const. rawtherapee-5.12/rtgui/coloredbar.cc:169:18: note: Technically the member function 'ColoredBar::canGetColors' can be const. rawtherapee-5.12/rtgui/colortoning.cc:25:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FCT_Linear [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/colortoning.cc:57:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PACK_SHRINK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/colortoning.cc:650:73: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LABGRID_CORR_MAX [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/colortoning.cc:723:55: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LABGRID_CORR_MAX [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/colortoning.cc:838:81: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LABGRID_CORR_MAX [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/colortoning.cc:994:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvColorToningTwocolor [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/colortoning.cc:1185:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvColorToningMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/colortoning.cc:1349:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvColorToningredlow [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/colorappearance.cc:862:23: style:inconclusive: Either there is a missing 'override', or the member function 'ColorAppearance::bgTTipQuery' can be const. [functionConst] rawtherapee-5.12/rtgui/colorappearance.h:115:10: note: Either there is a missing 'override', or the member function 'ColorAppearance::bgTTipQuery' can be const. rawtherapee-5.12/rtgui/colorappearance.cc:862:23: note: Either there is a missing 'override', or the member function 'ColorAppearance::bgTTipQuery' can be const. rawtherapee-5.12/rtgui/colorappearance.cc:867:23: style:inconclusive: Either there is a missing 'override', or the member function 'ColorAppearance::srTTipQuery' can be const. [functionConst] rawtherapee-5.12/rtgui/colorappearance.h:116:10: note: Either there is a missing 'override', or the member function 'ColorAppearance::srTTipQuery' can be const. rawtherapee-5.12/rtgui/colorappearance.cc:867:23: note: Either there is a missing 'override', or the member function 'ColorAppearance::srTTipQuery' can be const. rawtherapee-5.12/rtgui/colortoning.cc:1212:20: style: Local variable 'strength' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/colortoning.h:116:15: note: Shadowed declaration rawtherapee-5.12/rtgui/colortoning.cc:1212:20: note: Shadow variable rawtherapee-5.12/rtgui/colortoning.cc:1227:20: style: Local variable 'strength' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/colortoning.h:116:15: note: Shadowed declaration rawtherapee-5.12/rtgui/colortoning.cc:1227:20: note: Shadow variable rawtherapee-5.12/rtgui/colorappearance.cc:1884:44: style:inconclusive: Function 'wbCamChanged' argument 1 names different: declaration 'tem' definition 'temp'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/colorappearance.h:69:30: note: Function 'wbCamChanged' argument 1 names different: declaration 'tem' definition 'temp'. rawtherapee-5.12/rtgui/colorappearance.cc:1884:44: note: Function 'wbCamChanged' argument 1 names different: declaration 'tem' definition 'temp'. rawtherapee-5.12/rtgui/colorappearance.cc:1919:41: style:inconclusive: Function 'ybCamChanged' argument 1 names different: declaration 'yb' definition 'ybsc'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/colorappearance.h:71:28: note: Function 'ybCamChanged' argument 1 names different: declaration 'yb' definition 'ybsc'. rawtherapee-5.12/rtgui/colorappearance.cc:1919:41: note: Function 'ybCamChanged' argument 1 names different: declaration 'yb' definition 'ybsc'. rawtherapee-5.12/rtgui/colorappearance.cc:816:58: style: Parameter 'tpOpen' can be declared as reference to const [constParameterReference] rawtherapee-5.12/rtgui/controllines.cc:57:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable OBJECT_COUNT [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controllines.cc:73:63: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable OBJECT_COUNT [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controllines.cc:96:63: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ICON_SIZE_BUTTON [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controllines.cc:160:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PICKING [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controllines.cc:180:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NONE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controllines.cc:197:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NONE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controllines.cc:209:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NONE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controllines.cc:247:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NONE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controllines.cc:267:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DRAGGING [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controllines.cc:337:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NONE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controllines.cc:373:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_CONTROL_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controllines.cc:436:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IMAGE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controllines.cc:536:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable HORIZONTAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controllines.cc:581:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable OBJECT_COUNT [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controllines.cc:605:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable x1 [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/compressgamut.cc:37:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable COMPR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controllines.cc:409:26: warning: The class 'ControlLineManager' defines member function with name 'setEditProvider' also defined in its parent class 'EditSubscriber'. [duplInheritedMember] rawtherapee-5.12/rtgui/editcallbacks.h:61:24: note: Parent function 'EditSubscriber::setEditProvider' rawtherapee-5.12/rtgui/controllines.cc:409:26: note: Derived function 'ControlLineManager::setEditProvider' rawtherapee-5.12/rtgui/controllines.cc:277:20: style: Variable 'control_line' can be declared as reference to const [constVariableReference] rawtherapee-5.12/rtgui/controllines.cc:195:23: style: Variable 'provider' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/controllines.cc:253:23: style: Variable 'provider' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/controllines.cc:364:23: style: Variable 'provider' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/coordinateadjuster.cc:129:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_HORIZONTAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/coordinateadjuster.cc:227:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CA_STATUS_IDLE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/coordinateadjuster.cc:159:54: style: Parameter 'pos' can be declared as reference to const [constParameterReference] rawtherapee-5.12/rtgui/coordinateadjuster.cc:181:67: style: Parameter 'pos' can be declared as reference to const [constParameterReference] rawtherapee-5.12/rtgui/crop.cc:115:77: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ALIGN_CENTER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controlspotpanel.cc:121:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AUTOEXP [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controlspotpanel.cc:653:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLocallabSpotCreated [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controlspotpanel.cc:675:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLocallabSpotDeleted [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controlspotpanel.cc:733:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLocallabSpotName [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controlspotpanel.cc:759:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_CONTROL_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controlspotpanel.cc:813:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CONTROL_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controlspotpanel.cc:826:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CONTROL_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controlspotpanel.cc:919:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLocallabSpotSelectedWithMask [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controlspotpanel.cc:944:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLocallabSpotShape [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controlspotpanel.cc:1109:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLocallabSpotSpotMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controlspotpanel.cc:1217:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLocallabSpotShapeMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controlspotpanel.cc:1239:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLocallabSpotQualityMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controlspotpanel.cc:1293:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLocallabSpotwavMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controlspotpanel.cc:1469:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLocallabSpotSensiexclu [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controlspotpanel.cc:1957:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controlspotpanel.cc:2102:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IMAGE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controlspotpanel.cc:2419:76: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NORMAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controlspotpanel.cc:2589:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLocallabSpotCenter [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controlspotpanel.cc:2680:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable None [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/controlspotpanel.cc:3068:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PACK_SHRINK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/crop.cc:810:12: style: Redundant initialization for 'W2'. The initialized value is overwritten before it is read. [redundantInitialization] rawtherapee-5.12/rtgui/crop.cc:789:25: note: W2 is initialized rawtherapee-5.12/rtgui/crop.cc:810:12: note: W2 is overwritten rawtherapee-5.12/rtgui/crop.cc:796:12: style: Redundant initialization for 'H1'. The initialized value is overwritten before it is read. [redundantInitialization] rawtherapee-5.12/rtgui/crop.cc:790:16: note: H1 is initialized rawtherapee-5.12/rtgui/crop.cc:796:12: note: H1 is overwritten rawtherapee-5.12/rtgui/crop.cc:811:12: style: Redundant initialization for 'X2'. The initialized value is overwritten before it is read. [redundantInitialization] rawtherapee-5.12/rtgui/crop.cc:791:25: note: X2 is initialized rawtherapee-5.12/rtgui/crop.cc:811:12: note: X2 is overwritten rawtherapee-5.12/rtgui/crop.cc:797:12: style: Redundant initialization for 'Y1'. The initialized value is overwritten before it is read. [redundantInitialization] rawtherapee-5.12/rtgui/crop.cc:792:16: note: Y1 is initialized rawtherapee-5.12/rtgui/crop.cc:797:12: note: Y1 is overwritten rawtherapee-5.12/rtgui/crop.cc:916:28: style:inconclusive: Function 'sizeChanged' argument 1 names different: declaration 'w' definition 'x'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:65:30: note: Function 'sizeChanged' argument 1 names different: declaration 'w' definition 'x'. rawtherapee-5.12/rtgui/crop.cc:916:28: note: Function 'sizeChanged' argument 1 names different: declaration 'w' definition 'x'. rawtherapee-5.12/rtgui/crop.cc:916:35: style:inconclusive: Function 'sizeChanged' argument 2 names different: declaration 'h' definition 'y'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:65:37: note: Function 'sizeChanged' argument 2 names different: declaration 'h' definition 'y'. rawtherapee-5.12/rtgui/crop.cc:916:35: note: Function 'sizeChanged' argument 2 names different: declaration 'h' definition 'y'. rawtherapee-5.12/rtgui/crop.cc:963:28: style:inconclusive: Function 'cropMoved' argument 1 names different: declaration 'x' definition 'X'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:70:35: note: Function 'cropMoved' argument 1 names different: declaration 'x' definition 'X'. rawtherapee-5.12/rtgui/crop.cc:963:28: note: Function 'cropMoved' argument 1 names different: declaration 'x' definition 'X'. rawtherapee-5.12/rtgui/crop.cc:963:36: style:inconclusive: Function 'cropMoved' argument 2 names different: declaration 'y' definition 'Y'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:70:43: note: Function 'cropMoved' argument 2 names different: declaration 'y' definition 'Y'. rawtherapee-5.12/rtgui/crop.cc:963:36: note: Function 'cropMoved' argument 2 names different: declaration 'y' definition 'Y'. rawtherapee-5.12/rtgui/crop.cc:963:44: style:inconclusive: Function 'cropMoved' argument 3 names different: declaration 'w' definition 'W'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:70:51: note: Function 'cropMoved' argument 3 names different: declaration 'w' definition 'W'. rawtherapee-5.12/rtgui/crop.cc:963:44: note: Function 'cropMoved' argument 3 names different: declaration 'w' definition 'W'. rawtherapee-5.12/rtgui/crop.cc:963:52: style:inconclusive: Function 'cropMoved' argument 4 names different: declaration 'h' definition 'H'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:70:59: note: Function 'cropMoved' argument 4 names different: declaration 'h' definition 'H'. rawtherapee-5.12/rtgui/crop.cc:963:52: note: Function 'cropMoved' argument 4 names different: declaration 'h' definition 'H'. rawtherapee-5.12/rtgui/crop.cc:1002:36: style:inconclusive: Function 'cropWidth1Resized' argument 1 names different: declaration 'x' definition 'X'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:71:35: note: Function 'cropWidth1Resized' argument 1 names different: declaration 'x' definition 'X'. rawtherapee-5.12/rtgui/crop.cc:1002:36: note: Function 'cropWidth1Resized' argument 1 names different: declaration 'x' definition 'X'. rawtherapee-5.12/rtgui/crop.cc:1002:44: style:inconclusive: Function 'cropWidth1Resized' argument 2 names different: declaration 'y' definition 'Y'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:71:43: note: Function 'cropWidth1Resized' argument 2 names different: declaration 'y' definition 'Y'. rawtherapee-5.12/rtgui/crop.cc:1002:44: note: Function 'cropWidth1Resized' argument 2 names different: declaration 'y' definition 'Y'. rawtherapee-5.12/rtgui/crop.cc:1002:52: style:inconclusive: Function 'cropWidth1Resized' argument 3 names different: declaration 'w' definition 'W'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:71:51: note: Function 'cropWidth1Resized' argument 3 names different: declaration 'w' definition 'W'. rawtherapee-5.12/rtgui/crop.cc:1002:52: note: Function 'cropWidth1Resized' argument 3 names different: declaration 'w' definition 'W'. rawtherapee-5.12/rtgui/crop.cc:1002:60: style:inconclusive: Function 'cropWidth1Resized' argument 4 names different: declaration 'h' definition 'H'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:71:59: note: Function 'cropWidth1Resized' argument 4 names different: declaration 'h' definition 'H'. rawtherapee-5.12/rtgui/crop.cc:1002:60: note: Function 'cropWidth1Resized' argument 4 names different: declaration 'h' definition 'H'. rawtherapee-5.12/rtgui/crop.cc:1051:36: style:inconclusive: Function 'cropWidth2Resized' argument 1 names different: declaration 'x' definition 'X'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:72:35: note: Function 'cropWidth2Resized' argument 1 names different: declaration 'x' definition 'X'. rawtherapee-5.12/rtgui/crop.cc:1051:36: note: Function 'cropWidth2Resized' argument 1 names different: declaration 'x' definition 'X'. rawtherapee-5.12/rtgui/crop.cc:1051:44: style:inconclusive: Function 'cropWidth2Resized' argument 2 names different: declaration 'y' definition 'Y'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:72:43: note: Function 'cropWidth2Resized' argument 2 names different: declaration 'y' definition 'Y'. rawtherapee-5.12/rtgui/crop.cc:1051:44: note: Function 'cropWidth2Resized' argument 2 names different: declaration 'y' definition 'Y'. rawtherapee-5.12/rtgui/crop.cc:1051:52: style:inconclusive: Function 'cropWidth2Resized' argument 3 names different: declaration 'w' definition 'W'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:72:51: note: Function 'cropWidth2Resized' argument 3 names different: declaration 'w' definition 'W'. rawtherapee-5.12/rtgui/crop.cc:1051:52: note: Function 'cropWidth2Resized' argument 3 names different: declaration 'w' definition 'W'. rawtherapee-5.12/rtgui/crop.cc:1051:60: style:inconclusive: Function 'cropWidth2Resized' argument 4 names different: declaration 'h' definition 'H'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:72:59: note: Function 'cropWidth2Resized' argument 4 names different: declaration 'h' definition 'H'. rawtherapee-5.12/rtgui/crop.cc:1051:60: note: Function 'cropWidth2Resized' argument 4 names different: declaration 'h' definition 'H'. rawtherapee-5.12/rtgui/crop.cc:1097:37: style:inconclusive: Function 'cropHeight1Resized' argument 1 names different: declaration 'x' definition 'X'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:73:35: note: Function 'cropHeight1Resized' argument 1 names different: declaration 'x' definition 'X'. rawtherapee-5.12/rtgui/crop.cc:1097:37: note: Function 'cropHeight1Resized' argument 1 names different: declaration 'x' definition 'X'. rawtherapee-5.12/rtgui/crop.cc:1097:45: style:inconclusive: Function 'cropHeight1Resized' argument 2 names different: declaration 'y' definition 'Y'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:73:43: note: Function 'cropHeight1Resized' argument 2 names different: declaration 'y' definition 'Y'. rawtherapee-5.12/rtgui/crop.cc:1097:45: note: Function 'cropHeight1Resized' argument 2 names different: declaration 'y' definition 'Y'. rawtherapee-5.12/rtgui/crop.cc:1097:53: style:inconclusive: Function 'cropHeight1Resized' argument 3 names different: declaration 'w' definition 'W'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:73:51: note: Function 'cropHeight1Resized' argument 3 names different: declaration 'w' definition 'W'. rawtherapee-5.12/rtgui/crop.cc:1097:53: note: Function 'cropHeight1Resized' argument 3 names different: declaration 'w' definition 'W'. rawtherapee-5.12/rtgui/crop.cc:1097:61: style:inconclusive: Function 'cropHeight1Resized' argument 4 names different: declaration 'h' definition 'H'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:73:59: note: Function 'cropHeight1Resized' argument 4 names different: declaration 'h' definition 'H'. rawtherapee-5.12/rtgui/crop.cc:1097:61: note: Function 'cropHeight1Resized' argument 4 names different: declaration 'h' definition 'H'. rawtherapee-5.12/rtgui/crop.cc:1146:37: style:inconclusive: Function 'cropHeight2Resized' argument 1 names different: declaration 'x' definition 'X'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:74:35: note: Function 'cropHeight2Resized' argument 1 names different: declaration 'x' definition 'X'. rawtherapee-5.12/rtgui/crop.cc:1146:37: note: Function 'cropHeight2Resized' argument 1 names different: declaration 'x' definition 'X'. rawtherapee-5.12/rtgui/crop.cc:1146:45: style:inconclusive: Function 'cropHeight2Resized' argument 2 names different: declaration 'y' definition 'Y'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:74:43: note: Function 'cropHeight2Resized' argument 2 names different: declaration 'y' definition 'Y'. rawtherapee-5.12/rtgui/crop.cc:1146:45: note: Function 'cropHeight2Resized' argument 2 names different: declaration 'y' definition 'Y'. rawtherapee-5.12/rtgui/crop.cc:1146:53: style:inconclusive: Function 'cropHeight2Resized' argument 3 names different: declaration 'w' definition 'W'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:74:51: note: Function 'cropHeight2Resized' argument 3 names different: declaration 'w' definition 'W'. rawtherapee-5.12/rtgui/crop.cc:1146:53: note: Function 'cropHeight2Resized' argument 3 names different: declaration 'w' definition 'W'. rawtherapee-5.12/rtgui/crop.cc:1146:61: style:inconclusive: Function 'cropHeight2Resized' argument 4 names different: declaration 'h' definition 'H'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:74:59: note: Function 'cropHeight2Resized' argument 4 names different: declaration 'h' definition 'H'. rawtherapee-5.12/rtgui/crop.cc:1146:61: note: Function 'cropHeight2Resized' argument 4 names different: declaration 'h' definition 'H'. rawtherapee-5.12/rtgui/crop.cc:1192:37: style:inconclusive: Function 'cropTopLeftResized' argument 1 names different: declaration 'x' definition 'X'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:75:39: note: Function 'cropTopLeftResized' argument 1 names different: declaration 'x' definition 'X'. rawtherapee-5.12/rtgui/crop.cc:1192:37: note: Function 'cropTopLeftResized' argument 1 names different: declaration 'x' definition 'X'. rawtherapee-5.12/rtgui/crop.cc:1192:45: style:inconclusive: Function 'cropTopLeftResized' argument 2 names different: declaration 'y' definition 'Y'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:75:47: note: Function 'cropTopLeftResized' argument 2 names different: declaration 'y' definition 'Y'. rawtherapee-5.12/rtgui/crop.cc:1192:45: note: Function 'cropTopLeftResized' argument 2 names different: declaration 'y' definition 'Y'. rawtherapee-5.12/rtgui/crop.cc:1192:53: style:inconclusive: Function 'cropTopLeftResized' argument 3 names different: declaration 'w' definition 'W'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:75:55: note: Function 'cropTopLeftResized' argument 3 names different: declaration 'w' definition 'W'. rawtherapee-5.12/rtgui/crop.cc:1192:53: note: Function 'cropTopLeftResized' argument 3 names different: declaration 'w' definition 'W'. rawtherapee-5.12/rtgui/crop.cc:1192:61: style:inconclusive: Function 'cropTopLeftResized' argument 4 names different: declaration 'h' definition 'H'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:75:63: note: Function 'cropTopLeftResized' argument 4 names different: declaration 'h' definition 'H'. rawtherapee-5.12/rtgui/crop.cc:1192:61: note: Function 'cropTopLeftResized' argument 4 names different: declaration 'h' definition 'H'. rawtherapee-5.12/rtgui/crop.cc:1240:38: style:inconclusive: Function 'cropTopRightResized' argument 1 names different: declaration 'x' definition 'X'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:76:39: note: Function 'cropTopRightResized' argument 1 names different: declaration 'x' definition 'X'. rawtherapee-5.12/rtgui/crop.cc:1240:38: note: Function 'cropTopRightResized' argument 1 names different: declaration 'x' definition 'X'. rawtherapee-5.12/rtgui/crop.cc:1240:46: style:inconclusive: Function 'cropTopRightResized' argument 2 names different: declaration 'y' definition 'Y'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:76:47: note: Function 'cropTopRightResized' argument 2 names different: declaration 'y' definition 'Y'. rawtherapee-5.12/rtgui/crop.cc:1240:46: note: Function 'cropTopRightResized' argument 2 names different: declaration 'y' definition 'Y'. rawtherapee-5.12/rtgui/crop.cc:1240:54: style:inconclusive: Function 'cropTopRightResized' argument 3 names different: declaration 'w' definition 'W'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:76:55: note: Function 'cropTopRightResized' argument 3 names different: declaration 'w' definition 'W'. rawtherapee-5.12/rtgui/crop.cc:1240:54: note: Function 'cropTopRightResized' argument 3 names different: declaration 'w' definition 'W'. rawtherapee-5.12/rtgui/crop.cc:1240:62: style:inconclusive: Function 'cropTopRightResized' argument 4 names different: declaration 'h' definition 'H'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:76:63: note: Function 'cropTopRightResized' argument 4 names different: declaration 'h' definition 'H'. rawtherapee-5.12/rtgui/crop.cc:1240:62: note: Function 'cropTopRightResized' argument 4 names different: declaration 'h' definition 'H'. rawtherapee-5.12/rtgui/crop.cc:1286:40: style:inconclusive: Function 'cropBottomLeftResized' argument 1 names different: declaration 'x' definition 'X'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:77:39: note: Function 'cropBottomLeftResized' argument 1 names different: declaration 'x' definition 'X'. rawtherapee-5.12/rtgui/crop.cc:1286:40: note: Function 'cropBottomLeftResized' argument 1 names different: declaration 'x' definition 'X'. rawtherapee-5.12/rtgui/crop.cc:1286:48: style:inconclusive: Function 'cropBottomLeftResized' argument 2 names different: declaration 'y' definition 'Y'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:77:47: note: Function 'cropBottomLeftResized' argument 2 names different: declaration 'y' definition 'Y'. rawtherapee-5.12/rtgui/crop.cc:1286:48: note: Function 'cropBottomLeftResized' argument 2 names different: declaration 'y' definition 'Y'. rawtherapee-5.12/rtgui/crop.cc:1286:56: style:inconclusive: Function 'cropBottomLeftResized' argument 3 names different: declaration 'w' definition 'W'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:77:55: note: Function 'cropBottomLeftResized' argument 3 names different: declaration 'w' definition 'W'. rawtherapee-5.12/rtgui/crop.cc:1286:56: note: Function 'cropBottomLeftResized' argument 3 names different: declaration 'w' definition 'W'. rawtherapee-5.12/rtgui/crop.cc:1286:64: style:inconclusive: Function 'cropBottomLeftResized' argument 4 names different: declaration 'h' definition 'H'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:77:63: note: Function 'cropBottomLeftResized' argument 4 names different: declaration 'h' definition 'H'. rawtherapee-5.12/rtgui/crop.cc:1286:64: note: Function 'cropBottomLeftResized' argument 4 names different: declaration 'h' definition 'H'. rawtherapee-5.12/rtgui/crop.cc:1332:41: style:inconclusive: Function 'cropBottomRightResized' argument 1 names different: declaration 'x' definition 'X'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:78:39: note: Function 'cropBottomRightResized' argument 1 names different: declaration 'x' definition 'X'. rawtherapee-5.12/rtgui/crop.cc:1332:41: note: Function 'cropBottomRightResized' argument 1 names different: declaration 'x' definition 'X'. rawtherapee-5.12/rtgui/crop.cc:1332:49: style:inconclusive: Function 'cropBottomRightResized' argument 2 names different: declaration 'y' definition 'Y'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:78:47: note: Function 'cropBottomRightResized' argument 2 names different: declaration 'y' definition 'Y'. rawtherapee-5.12/rtgui/crop.cc:1332:49: note: Function 'cropBottomRightResized' argument 2 names different: declaration 'y' definition 'Y'. rawtherapee-5.12/rtgui/crop.cc:1332:57: style:inconclusive: Function 'cropBottomRightResized' argument 3 names different: declaration 'w' definition 'W'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:78:55: note: Function 'cropBottomRightResized' argument 3 names different: declaration 'w' definition 'W'. rawtherapee-5.12/rtgui/crop.cc:1332:57: note: Function 'cropBottomRightResized' argument 3 names different: declaration 'w' definition 'W'. rawtherapee-5.12/rtgui/crop.cc:1332:65: style:inconclusive: Function 'cropBottomRightResized' argument 4 names different: declaration 'h' definition 'H'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crop.h:78:63: note: Function 'cropBottomRightResized' argument 4 names different: declaration 'h' definition 'H'. rawtherapee-5.12/rtgui/crop.cc:1332:65: note: Function 'cropBottomRightResized' argument 4 names different: declaration 'h' definition 'H'. rawtherapee-5.12/rtgui/crop.cc:73:26: style: Local variable 'ratio' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/crop.h:104:21: note: Shadowed declaration rawtherapee-5.12/rtgui/crop.cc:73:26: note: Shadow variable rawtherapee-5.12/rtgui/crop.cc:368:17: style: Local variable 'maxw' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/crop.h:123:9: note: Shadowed declaration rawtherapee-5.12/rtgui/crop.cc:368:17: note: Shadow variable rawtherapee-5.12/rtgui/crop.cc:368:23: style: Local variable 'maxh' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/crop.h:123:15: note: Shadowed declaration rawtherapee-5.12/rtgui/crop.cc:368:23: note: Shadow variable rawtherapee-5.12/rtgui/crop.cc:74:17: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/crophandler.cc:201:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable M_HIGHQUAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/crophandler.cc:379:104: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable INTERP_TILES [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/crophandler.cc:444:74: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable fullUpdate [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/crophandler.cc:209:20: style:inconclusive: Either there is a missing 'override', or the member function 'CropHandler::getZoomFactor' can be const. [functionConst] rawtherapee-5.12/rtgui/crophandler.h:65:13: note: Either there is a missing 'override', or the member function 'CropHandler::getZoomFactor' can be const. rawtherapee-5.12/rtgui/crophandler.cc:209:20: note: Either there is a missing 'override', or the member function 'CropHandler::getZoomFactor' can be const. rawtherapee-5.12/rtgui/crophandler.cc:472:19: style:inconclusive: Either there is a missing 'override', or the member function 'CropHandler::getEnabled' can be const. [functionConst] rawtherapee-5.12/rtgui/crophandler.h:80:13: note: Either there is a missing 'override', or the member function 'CropHandler::getEnabled' can be const. rawtherapee-5.12/rtgui/crophandler.cc:472:19: note: Either there is a missing 'override', or the member function 'CropHandler::getEnabled' can be const. rawtherapee-5.12/rtgui/editbuffer.h:76:35: style:inconclusive: Technically the member function 'ObjectMOBuffer::getObjectMode' can be const. [functionConst] rawtherapee-5.12/rtgui/editbuffer.h:62:16: note: Technically the member function 'ObjectMOBuffer::getObjectMode' can be const. rawtherapee-5.12/rtgui/editbuffer.h:76:35: note: Technically the member function 'ObjectMOBuffer::getObjectMode' can be const. rawtherapee-5.12/rtgui/crophandler.cc:113:35: style:inconclusive: Function 'sizeChanged' argument 1 names different: declaration 'w' definition 'x'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crophandler.h:104:31: note: Function 'sizeChanged' argument 1 names different: declaration 'w' definition 'x'. rawtherapee-5.12/rtgui/crophandler.cc:113:35: note: Function 'sizeChanged' argument 1 names different: declaration 'w' definition 'x'. rawtherapee-5.12/rtgui/crophandler.cc:113:42: style:inconclusive: Function 'sizeChanged' argument 2 names different: declaration 'h' definition 'y'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crophandler.h:104:38: note: Function 'sizeChanged' argument 2 names different: declaration 'h' definition 'y'. rawtherapee-5.12/rtgui/crophandler.cc:113:42: note: Function 'sizeChanged' argument 2 names different: declaration 'h' definition 'y'. rawtherapee-5.12/rtgui/crophandler.cc:253:57: style:inconclusive: Function 'setAnchorPosition' argument 3 names different: declaration 'update' definition 'update_'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crophandler.h:72:51: note: Function 'setAnchorPosition' argument 3 names different: declaration 'update' definition 'update_'. rawtherapee-5.12/rtgui/crophandler.cc:253:57: note: Function 'setAnchorPosition' argument 3 names different: declaration 'update' definition 'update_'. rawtherapee-5.12/rtgui/crophandler.cc:265:60: style:inconclusive: Function 'moveAnchor' argument 3 names different: declaration 'update' definition 'update_'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crophandler.h:73:57: note: Function 'moveAnchor' argument 3 names different: declaration 'update' definition 'update_'. rawtherapee-5.12/rtgui/crophandler.cc:265:60: note: Function 'moveAnchor' argument 3 names different: declaration 'update' definition 'update_'. rawtherapee-5.12/rtgui/crophandler.cc:277:38: style:inconclusive: Function 'centerAnchor' argument 1 names different: declaration 'update' definition 'update_'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crophandler.h:74:33: note: Function 'centerAnchor' argument 1 names different: declaration 'update' definition 'update_'. rawtherapee-5.12/rtgui/crophandler.cc:277:38: note: Function 'centerAnchor' argument 1 names different: declaration 'update' definition 'update_'. rawtherapee-5.12/rtgui/crophandler.cc:303:14: style:inconclusive: Function 'setDetailedCrop' argument 2 names different: declaration 'imworking' definition 'imtrue'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crophandler.h:92:28: note: Function 'setDetailedCrop' argument 2 names different: declaration 'imworking' definition 'imtrue'. rawtherapee-5.12/rtgui/crophandler.cc:303:14: note: Function 'setDetailedCrop' argument 2 names different: declaration 'imworking' definition 'imtrue'. rawtherapee-5.12/rtgui/crophandler.cc:306:9: style:inconclusive: Function 'setDetailedCrop' argument 5 names different: declaration 'cx' definition 'ax'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crophandler.h:95:13: note: Function 'setDetailedCrop' argument 5 names different: declaration 'cx' definition 'ax'. rawtherapee-5.12/rtgui/crophandler.cc:306:9: note: Function 'setDetailedCrop' argument 5 names different: declaration 'cx' definition 'ax'. rawtherapee-5.12/rtgui/crophandler.cc:307:9: style:inconclusive: Function 'setDetailedCrop' argument 6 names different: declaration 'cy' definition 'ay'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crophandler.h:96:13: note: Function 'setDetailedCrop' argument 6 names different: declaration 'cy' definition 'ay'. rawtherapee-5.12/rtgui/crophandler.cc:307:9: note: Function 'setDetailedCrop' argument 6 names different: declaration 'cy' definition 'ay'. rawtherapee-5.12/rtgui/crophandler.cc:308:9: style:inconclusive: Function 'setDetailedCrop' argument 7 names different: declaration 'cw' definition 'aw'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crophandler.h:97:13: note: Function 'setDetailedCrop' argument 7 names different: declaration 'cw' definition 'aw'. rawtherapee-5.12/rtgui/crophandler.cc:308:9: note: Function 'setDetailedCrop' argument 7 names different: declaration 'cw' definition 'aw'. rawtherapee-5.12/rtgui/crophandler.cc:309:9: style:inconclusive: Function 'setDetailedCrop' argument 8 names different: declaration 'ch' definition 'ah'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crophandler.h:98:13: note: Function 'setDetailedCrop' argument 8 names different: declaration 'ch' definition 'ah'. rawtherapee-5.12/rtgui/crophandler.cc:309:9: note: Function 'setDetailedCrop' argument 8 names different: declaration 'ch' definition 'ah'. rawtherapee-5.12/rtgui/crophandler.cc:310:9: style:inconclusive: Function 'setDetailedCrop' argument 9 names different: declaration 'skip' definition 'askip'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/crophandler.h:99:13: note: Function 'setDetailedCrop' argument 9 names different: declaration 'skip' definition 'askip'. rawtherapee-5.12/rtgui/crophandler.cc:310:9: note: Function 'setDetailedCrop' argument 9 names different: declaration 'skip' definition 'askip'. rawtherapee-5.12/rtgui/controlspotpanel.cc:2930:62: style:inconclusive: Boolean expression '!isblur' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] rawtherapee-5.12/rtgui/controlspotpanel.cc:2930:62: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] rawtherapee-5.12/rtgui/controlspotpanel.cc:2193:15: style: Local variable 'centerX_' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/controlspotpanel.h:404:21: note: Shadowed declaration rawtherapee-5.12/rtgui/controlspotpanel.cc:2193:15: note: Shadow variable rawtherapee-5.12/rtgui/controlspotpanel.cc:2194:15: style: Local variable 'centerY_' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/controlspotpanel.h:405:21: note: Shadowed declaration rawtherapee-5.12/rtgui/controlspotpanel.cc:2194:15: note: Shadow variable rawtherapee-5.12/rtgui/controlspotpanel.cc:2195:15: style: Local variable 'circrad_' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/controlspotpanel.h:406:21: note: Shadowed declaration rawtherapee-5.12/rtgui/controlspotpanel.cc:2195:15: note: Shadow variable rawtherapee-5.12/rtgui/controlspotpanel.cc:2196:15: style: Local variable 'locX_' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/controlspotpanel.h:400:21: note: Shadowed declaration rawtherapee-5.12/rtgui/controlspotpanel.cc:2196:15: note: Shadow variable rawtherapee-5.12/rtgui/controlspotpanel.cc:2197:15: style: Local variable 'locXL_' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/controlspotpanel.h:401:21: note: Shadowed declaration rawtherapee-5.12/rtgui/controlspotpanel.cc:2197:15: note: Shadow variable rawtherapee-5.12/rtgui/controlspotpanel.cc:2198:15: style: Local variable 'locY_' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/controlspotpanel.h:402:21: note: Shadowed declaration rawtherapee-5.12/rtgui/controlspotpanel.cc:2198:15: note: Shadow variable rawtherapee-5.12/rtgui/controlspotpanel.cc:2199:15: style: Local variable 'locYT_' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/controlspotpanel.h:403:21: note: Shadowed declaration rawtherapee-5.12/rtgui/controlspotpanel.cc:2199:15: note: Shadow variable rawtherapee-5.12/rtgui/controlspotpanel.cc:2200:15: style: Local variable 'shape_' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/controlspotpanel.h:383:27: note: Shadowed declaration rawtherapee-5.12/rtgui/controlspotpanel.cc:2200:15: note: Shadow variable rawtherapee-5.12/rtgui/controlspotpanel.cc:2697:16: style: Variable 'row' can be declared as reference to const [constVariableReference] rawtherapee-5.12/rtgui/controlspotpanel.cc:2402:23: style: Variable 'editProvider_' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/cursormanager.cc:45:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ICON_SIZE_MENU [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:92:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WEIGHT_BOLD [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:333:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_SCROLL_SMOOTH [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:377:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_2BUTTON_PRESS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:853:108: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_SHIFT_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:895:106: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:1191:71: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:1482:140: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2067:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2130:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable is_major [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2143:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2166:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2183:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2200:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2219:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2239:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2324:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2386:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2404:74: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2420:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2429:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2438:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2446:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2452:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2457:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2462:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2467:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2472:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2477:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2487:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WEIGHT_BOLD [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2527:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RT_PI [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2610:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2661:103: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable zoom [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/curveeditor.cc:84:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Linear [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/curveeditor.cc:103:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Spline [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/curveeditor.cc:125:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_NURBS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/curveeditor.cc:204:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FCT_Linear [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/curveeditor.cc:215:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FCT_MinMaxCPoints [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/curveeditor.cc:228:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FCT_MinMaxCPoints [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/curveeditor.cc:253:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Linear [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/curveeditor.cc:409:18: style:inconclusive: Either there is a missing 'override', or the member function 'CurveEditor::getLeftBarCallerId' can be const. [functionConst] rawtherapee-5.12/rtgui/curveeditor.h:107:9: note: Either there is a missing 'override', or the member function 'CurveEditor::getLeftBarCallerId' can be const. rawtherapee-5.12/rtgui/curveeditor.cc:409:18: note: Either there is a missing 'override', or the member function 'CurveEditor::getLeftBarCallerId' can be const. rawtherapee-5.12/rtgui/curveeditor.cc:414:18: style:inconclusive: Either there is a missing 'override', or the member function 'CurveEditor::getBottomBarCallerId' can be const. [functionConst] rawtherapee-5.12/rtgui/curveeditor.h:108:9: note: Either there is a missing 'override', or the member function 'CurveEditor::getBottomBarCallerId' can be const. rawtherapee-5.12/rtgui/curveeditor.cc:414:18: note: Either there is a missing 'override', or the member function 'CurveEditor::getBottomBarCallerId' can be const. rawtherapee-5.12/rtgui/curveeditor.cc:419:18: style:inconclusive: Either there is a missing 'override', or the member function 'CurveEditor::getCurveCallerId' can be const. [functionConst] rawtherapee-5.12/rtgui/curveeditor.h:109:9: note: Either there is a missing 'override', or the member function 'CurveEditor::getCurveCallerId' can be const. rawtherapee-5.12/rtgui/curveeditor.cc:419:18: note: Either there is a missing 'override', or the member function 'CurveEditor::getCurveCallerId' can be const. rawtherapee-5.12/rtgui/curveeditor.cc:434:33: style:inconclusive: Either there is a missing 'override', or the member function 'CurveEditor::signal_curvegraph_enter' can be const. [functionConst] rawtherapee-5.12/rtgui/curveeditor.h:126:24: note: Either there is a missing 'override', or the member function 'CurveEditor::signal_curvegraph_enter' can be const. rawtherapee-5.12/rtgui/curveeditor.cc:434:33: note: Either there is a missing 'override', or the member function 'CurveEditor::signal_curvegraph_enter' can be const. rawtherapee-5.12/rtgui/curveeditor.cc:439:33: style:inconclusive: Either there is a missing 'override', or the member function 'CurveEditor::signal_curvegraph_leave' can be const. [functionConst] rawtherapee-5.12/rtgui/curveeditor.h:127:24: note: Either there is a missing 'override', or the member function 'CurveEditor::signal_curvegraph_leave' can be const. rawtherapee-5.12/rtgui/curveeditor.cc:439:33: note: Either there is a missing 'override', or the member function 'CurveEditor::signal_curvegraph_leave' can be const. rawtherapee-5.12/rtgui/curveeditor.cc:444:33: style:inconclusive: Either there is a missing 'override', or the member function 'CurveEditor::signal_curvepoint_click' can be const. [functionConst] rawtherapee-5.12/rtgui/curveeditor.h:128:24: note: Either there is a missing 'override', or the member function 'CurveEditor::signal_curvepoint_click' can be const. rawtherapee-5.12/rtgui/curveeditor.cc:444:33: note: Either there is a missing 'override', or the member function 'CurveEditor::signal_curvepoint_click' can be const. rawtherapee-5.12/rtgui/curveeditor.cc:449:33: style:inconclusive: Either there is a missing 'override', or the member function 'CurveEditor::signal_curvepoint_release' can be const. [functionConst] rawtherapee-5.12/rtgui/curveeditor.h:129:24: note: Either there is a missing 'override', or the member function 'CurveEditor::signal_curvepoint_release' can be const. rawtherapee-5.12/rtgui/curveeditor.cc:449:33: note: Either there is a missing 'override', or the member function 'CurveEditor::signal_curvepoint_release' can be const. rawtherapee-5.12/rtgui/popuptogglebutton.h:34:10: warning: The class 'PopUpToggleButton' defines member function with name 'show' also defined in its parent class 'PopUpCommon'. [duplInheritedMember] rawtherapee-5.12/rtgui/popupcommon.h:75:10: note: Parent function 'PopUpCommon::show' rawtherapee-5.12/rtgui/popuptogglebutton.h:34:10: note: Derived function 'PopUpToggleButton::show' rawtherapee-5.12/rtgui/popuptogglebutton.h:35:10: warning: The class 'PopUpToggleButton' defines member function with name 'set_tooltip_text' also defined in its parent class 'PopUpCommon'. [duplInheritedMember] rawtherapee-5.12/rtgui/popupcommon.h:76:10: note: Parent function 'PopUpCommon::set_tooltip_text' rawtherapee-5.12/rtgui/popuptogglebutton.h:35:10: note: Derived function 'PopUpToggleButton::set_tooltip_text' rawtherapee-5.12/rtgui/curveeditor.cc:33:5: style: Class 'CurveTypePopUpButton' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] rawtherapee-5.12/rtgui/curveeditor.h:110:36: performance: Function 'getBottomBarBgGradient()' should return member 'bottomBarBgGradient' by const reference. [returnByReference] rawtherapee-5.12/rtgui/curveeditor.h:111:36: performance: Function 'getLeftBarBgGradient()' should return member 'leftBarBgGradient' by const reference. [returnByReference] rawtherapee-5.12/rtgui/curveeditorgroup.cc:39:79: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ALIGN_START [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/curveeditorgroup.cc:132:79: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ALIGN_START [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/curveeditorgroup.cc:437:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ALIGN_START [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/curveeditorgroup.cc:476:100: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_CHOOSER_ACTION_SAVE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/curveeditorgroup.cc:521:100: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_CHOOSER_ACTION_OPEN [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/curveeditorgroup.cc:427:27: performance:inconclusive: Technically the member function 'CurveEditorSubGroup::initButton' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtgui/curveeditorgroup.h:125:10: note: Technically the member function 'CurveEditorSubGroup::initButton' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtgui/curveeditorgroup.cc:427:27: note: Technically the member function 'CurveEditorSubGroup::initButton' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtgui/curveeditorgroup.cc:453:27: performance:inconclusive: Technically the member function 'CurveEditorSubGroup::updateEditButton' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtgui/curveeditorgroup.h:138:10: note: Technically the member function 'CurveEditorSubGroup::updateEditButton' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtgui/curveeditorgroup.cc:453:27: note: Technically the member function 'CurveEditorSubGroup::updateEditButton' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtgui/curveeditorgroup.cc:419:16: warning: Class 'CurveEditorSubGroup' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] rawtherapee-5.12/rtgui/curveeditorgroup.cc:419:16: warning: Class 'CurveEditorSubGroup' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] rawtherapee-5.12/rtgui/curveeditorgroup.cc:453:57: style: Parameter 'curve' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtgui/darkframe.cc:39:87: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_CHOOSER_ACTION_OPEN [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/darkframe.cc:90:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_EXISTS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/darkframe.cc:198:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvPreProcessAutoDF [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/defringe.cc:68:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PACK_SHRINK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dehaze.cc:37:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable HDR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/cropwindow.cc:2163:20: style:inconclusive: Either there is a missing 'override', or the member function 'CropWindow::getZoom' can be const. [functionConst] rawtherapee-5.12/rtgui/cropwindow.h:199:12: note: Either there is a missing 'override', or the member function 'CropWindow::getZoom' can be const. rawtherapee-5.12/rtgui/cropwindow.cc:2163:20: note: Either there is a missing 'override', or the member function 'CropWindow::getZoom' can be const. rawtherapee-5.12/rtgui/cropwindow.cc:2169:18: style:inconclusive: Either there is a missing 'override', or the member function 'CropWindow::isMinZoom' can be const. [functionConst] rawtherapee-5.12/rtgui/cropwindow.h:200:10: note: Either there is a missing 'override', or the member function 'CropWindow::isMinZoom' can be const. rawtherapee-5.12/rtgui/cropwindow.cc:2169:18: note: Either there is a missing 'override', or the member function 'CropWindow::isMinZoom' can be const. rawtherapee-5.12/rtgui/cropwindow.cc:2174:18: style:inconclusive: Either there is a missing 'override', or the member function 'CropWindow::isMaxZoom' can be const. [functionConst] rawtherapee-5.12/rtgui/cropwindow.h:201:10: note: Either there is a missing 'override', or the member function 'CropWindow::isMaxZoom' can be const. rawtherapee-5.12/rtgui/cropwindow.cc:2174:18: note: Either there is a missing 'override', or the member function 'CropWindow::isMaxZoom' can be const. rawtherapee-5.12/rtgui/cropwindow.cc:298:18: style:inconclusive: Either there is a missing 'override', or the member function 'CropWindow::isInside' can be const. [functionConst] rawtherapee-5.12/rtgui/cropwindow.h:204:10: note: Either there is a missing 'override', or the member function 'CropWindow::isInside' can be const. rawtherapee-5.12/rtgui/cropwindow.cc:298:18: note: Either there is a missing 'override', or the member function 'CropWindow::isInside' can be const. rawtherapee-5.12/rtgui/pointermotionlistener.h:51:24: style:inconclusive: Technically the member function 'PointerMotionListener::signal_cycle_rgb' can be const. [functionConst] rawtherapee-5.12/rtgui/pointermotionlistener.h:55:24: style:inconclusive: Technically the member function 'PointerMotionListener::signal_cycle_hsv' can be const. [functionConst] rawtherapee-5.12/rtgui/cropwindow.cc:1576:50: error: If memory allocation fails: pointer addition with NULL pointer. [nullPointerArithmeticOutOfMemory] rawtherapee-5.12/rtgui/cropwindow.cc:1558:49: note: Assuming allocation function fails rawtherapee-5.12/rtgui/cropwindow.cc:1558:35: note: Assignment 'tmpL=(float*)malloc(bHeight*bWidth*sizeof(float))', assigned value is 0 rawtherapee-5.12/rtgui/cropwindow.cc:1576:50: note: Null pointer addition rawtherapee-5.12/rtgui/cropwindow.cc:1558:35: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtgui/cropwindow.cc:1560:38: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtgui/cropwindow.cc:1561:40: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtgui/cropwindow.cc:1562:41: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtgui/cropwindow.cc:288:46: style:inconclusive: Function 'getCropAnchorPosition' argument 1 names different: declaration 'w' definition 'x'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/cropwindow.h:226:38: note: Function 'getCropAnchorPosition' argument 1 names different: declaration 'w' definition 'x'. rawtherapee-5.12/rtgui/cropwindow.cc:288:46: note: Function 'getCropAnchorPosition' argument 1 names different: declaration 'w' definition 'x'. rawtherapee-5.12/rtgui/cropwindow.cc:288:54: style:inconclusive: Function 'getCropAnchorPosition' argument 2 names different: declaration 'h' definition 'y'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/cropwindow.h:226:46: note: Function 'getCropAnchorPosition' argument 2 names different: declaration 'h' definition 'y'. rawtherapee-5.12/rtgui/cropwindow.cc:288:54: note: Function 'getCropAnchorPosition' argument 2 names different: declaration 'h' definition 'y'. rawtherapee-5.12/rtgui/cropwindow.cc:293:45: style:inconclusive: Function 'setCropAnchorPosition' argument 1 names different: declaration 'w' definition 'x'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/cropwindow.h:227:37: note: Function 'setCropAnchorPosition' argument 1 names different: declaration 'w' definition 'x'. rawtherapee-5.12/rtgui/cropwindow.cc:293:45: note: Function 'setCropAnchorPosition' argument 1 names different: declaration 'w' definition 'x'. rawtherapee-5.12/rtgui/cropwindow.cc:293:52: style:inconclusive: Function 'setCropAnchorPosition' argument 2 names different: declaration 'h' definition 'y'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/cropwindow.h:227:44: note: Function 'setCropAnchorPosition' argument 2 names different: declaration 'h' definition 'y'. rawtherapee-5.12/rtgui/cropwindow.cc:293:52: note: Function 'setCropAnchorPosition' argument 2 names different: declaration 'h' definition 'y'. rawtherapee-5.12/rtgui/cropwindow.cc:368:47: style:inconclusive: Function 'buttonPress' argument 2 names different: declaration 'num' definition 'type'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/cropwindow.h:208:41: note: Function 'buttonPress' argument 2 names different: declaration 'num' definition 'type'. rawtherapee-5.12/rtgui/cropwindow.cc:368:47: note: Function 'buttonPress' argument 2 names different: declaration 'num' definition 'type'. rawtherapee-5.12/rtgui/cropwindow.cc:368:57: style:inconclusive: Function 'buttonPress' argument 3 names different: declaration 'state' definition 'bstate'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/cropwindow.h:208:50: note: Function 'buttonPress' argument 3 names different: declaration 'state' definition 'bstate'. rawtherapee-5.12/rtgui/cropwindow.cc:368:57: note: Function 'buttonPress' argument 3 names different: declaration 'state' definition 'bstate'. rawtherapee-5.12/rtgui/cropwindow.cc:686:58: style:inconclusive: Function 'buttonRelease' argument 3 names different: declaration 'state' definition 'bstate'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/cropwindow.h:209:50: note: Function 'buttonRelease' argument 3 names different: declaration 'state' definition 'bstate'. rawtherapee-5.12/rtgui/cropwindow.cc:686:58: note: Function 'buttonRelease' argument 3 names different: declaration 'state' definition 'bstate'. rawtherapee-5.12/rtgui/cropwindow.cc:573:37: style: Local variable 'editSubscriber' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/cropwindow.cc:372:16: note: Shadowed declaration rawtherapee-5.12/rtgui/cropwindow.cc:573:37: note: Shadow variable rawtherapee-5.12/rtgui/cropwindow.cc:608:29: style: Local variable 'editSubscriber' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/cropwindow.cc:372:16: note: Shadowed declaration rawtherapee-5.12/rtgui/cropwindow.cc:608:29: note: Shadow variable rawtherapee-5.12/rtgui/cropwindow.cc:628:29: style: Local variable 'editSubscriber' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/cropwindow.cc:372:16: note: Shadowed declaration rawtherapee-5.12/rtgui/cropwindow.cc:628:29: note: Shadow variable rawtherapee-5.12/rtgui/cropwindow.cc:1159:25: style: Variable 'pix' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/cropwindow.cc:1321:21: style: Variable 'editSubscriber' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/cropwindow.cc:1704:45: style: Variable 'currtmpWSl' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/cropwindow.cc:1717:45: style: Variable 'currtmpWSl' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/cropwindow.cc:1731:49: style: Variable 'currtmpWSl' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/cropwindow.cc:1745:45: style: Variable 'currtmpWSl' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/cropwindow.cc:1758:45: style: Variable 'currtmpWSl' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/cropwindow.cc:2025:25: style: Variable 'editSubscriber' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/cropwindow.cc:665:50: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/cropwindow.cc:1206:44: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/diagonalcurveeditorsubgroup.cc:45:113: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable POS_TOP [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/diagonalcurveeditorsubgroup.cc:395:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Spline [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/diagonalcurveeditorsubgroup.cc:458:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Spline [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/diagonalcurveeditorsubgroup.cc:530:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Spline [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/diagonalcurveeditorsubgroup.cc:559:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Spline [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/diagonalcurveeditorsubgroup.cc:583:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Spline [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/diagonalcurveeditorsubgroup.cc:637:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Spline [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/diagonalcurveeditorsubgroup.cc:726:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Spline [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/diagonalcurveeditorsubgroup.cc:820:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Linear [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/diagonalcurveeditorsubgroup.cc:864:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Linear [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/diagonalcurveeditorsubgroup.cc:917:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Spline [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/diagonalcurveeditorsubgroup.cc:1080:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Spline [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/diagonalcurveeditorsubgroup.cc:1121:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Spline [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/diagonalcurveeditorsubgroup.cc:1149:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Parametric [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/diagonalcurveeditorsubgroup.cc:1202:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_NURBS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/diagonalcurveeditorsubgroup.cc:1242:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Parametric [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/diagonalcurveeditorsubgroup.cc:1252:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Parametric [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/diagonalcurveeditorsubgroup.cc:1263:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_NOTIFY_INFERIOR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/diagonalcurveeditorsubgroup.cc:1277:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_NOTIFY_INFERIOR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dirbrowser.cc:45:55: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_EXISTS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dirbrowser.cc:103:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dirbrowser.cc:139:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ICON_SIZE_SMALL_TOOLBAR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dirbrowser.cc:286:87: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SORT_ASCENDING [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dirbrowser.cc:345:76: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_EXISTS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dirbrowser.cc:389:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_IS_DIR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dirbrowser.cc:496:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_MONITOR_EVENT_MOVED [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/diagonalcurveeditorsubgroup.cc:947:25: style: The scope of the variable 'curve' can be reduced. [variableScope] rawtherapee-5.12/rtgui/dirbrowser.cc:402:17: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] rawtherapee-5.12/rtgui/dirbrowser.cc:451:15: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] rawtherapee-5.12/rtgui/dirbrowser.cc:521:5: error: Return value of allocation function 'open' is not stored. [leakReturnValNotUsed] rawtherapee-5.12/rtgui/dirbrowser.cc:395:61: style:inconclusive: Function 'expandToDir' argument 1 names different: declaration 'dirName' definition 'absDirPath'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/dirbrowser.h:82:53: note: Function 'expandToDir' argument 1 names different: declaration 'dirName' definition 'absDirPath'. rawtherapee-5.12/rtgui/dirbrowser.cc:395:61: note: Function 'expandToDir' argument 1 names different: declaration 'dirName' definition 'absDirPath'. rawtherapee-5.12/rtgui/dirbrowser.cc:462:45: style:inconclusive: Function 'open' argument 1 names different: declaration 'dirName' definition 'dirname'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/dirbrowser.h:97:47: note: Function 'open' argument 1 names different: declaration 'dirName' definition 'dirname'. rawtherapee-5.12/rtgui/dirbrowser.cc:462:45: note: Function 'open' argument 1 names different: declaration 'dirName' definition 'dirname'. rawtherapee-5.12/rtgui/dirpyrequalizer.cc:58:57: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dirpyrequalizer.cc:321:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvDirPyrEqualizerHueskin [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dirpyrequalizer.cc:348:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvcbdlMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dirpyrdenoise.cc:43:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ALLNORAW [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dirpyrdenoise.cc:787:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvDPDNmet [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dirpyrdenoise.cc:803:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvDPDNLmet [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dirpyrdenoise.cc:859:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvDPDNCmet [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dirpyrdenoise.cc:905:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvDPDNC2met [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dirpyrdenoise.cc:914:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvDPDNsmet [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dirpyrdenoise.cc:923:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvDPDNmedmet [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dirpyrdenoise.cc:936:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvDPDNrgbmet [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dirpyrdenoise.cc:953:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvDPDNmetmed [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dirpyrdenoise.cc:993:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvDPDNLdetail [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/distortion.cc:38:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TRANSFORM [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/distortion.cc:90:93: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DEFAULT_FOCAL_LENGTH [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dynamicprofilepanel.cc:41:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PACK_SHRINK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dynamicprofilepanel.cc:214:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PACK_SHRINK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dynamicprofilepanel.cc:221:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PACK_SHRINK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dynamicprofilepanel.cc:241:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dynamicprofilepanel.cc:462:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable fixed [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/dynamicprofilepanel.cc:647:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editbuffer.cc:46:64: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FORMAT_A8 [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editbuffer.cc:91:100: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FORMAT_RGB16_565 [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editbuffer.cc:112:98: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable uint8_t [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editbuffer.cc:121:22: style:inconclusive: Technically the member function 'ObjectMOBuffer::bufferCreated' can be const. [functionConst] rawtherapee-5.12/rtgui/editbuffer.h:67:10: note: Technically the member function 'ObjectMOBuffer::bufferCreated' can be const. rawtherapee-5.12/rtgui/editbuffer.cc:121:22: note: Technically the member function 'ObjectMOBuffer::bufferCreated' can be const. rawtherapee-5.12/rtgui/editbuffer.cc:123:21: style: Variable 'subscriber' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/dynamicprofilepanel.cc:379:16: style: Variable 'r' can be declared as reference to const [constVariableReference] rawtherapee-5.12/rtgui/dynamicprofilepanel.cc:640:15: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/editcallbacks.cc:265:47: style:inconclusive: Technically the member function 'EditSubscriber::getVisibleGeometry' can be const. [functionConst] rawtherapee-5.12/rtgui/editcallbacks.h:151:35: note: Technically the member function 'EditSubscriber::getVisibleGeometry' can be const. rawtherapee-5.12/rtgui/editcallbacks.cc:265:47: note: Technically the member function 'EditSubscriber::getVisibleGeometry' can be const. rawtherapee-5.12/rtgui/editcallbacks.cc:270:47: style:inconclusive: Technically the member function 'EditSubscriber::getMouseOverGeometry' can be const. [functionConst] rawtherapee-5.12/rtgui/editcallbacks.h:154:35: note: Technically the member function 'EditSubscriber::getMouseOverGeometry' can be const. rawtherapee-5.12/rtgui/editcallbacks.cc:270:47: note: Technically the member function 'EditSubscriber::getMouseOverGeometry' can be const. rawtherapee-5.12/rtgui/editcallbacks.cc:275:23: performance:inconclusive: Technically the member function 'EditDataProvider::getPipetteRectSize' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtgui/editcallbacks.h:197:9: note: Technically the member function 'EditDataProvider::getPipetteRectSize' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtgui/editcallbacks.cc:275:23: note: Technically the member function 'EditDataProvider::getPipetteRectSize' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtgui/editwidgets.cc:35:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flags [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editwidgets.cc:56:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable flags [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editwindow.cc:85:55: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editwindow.cc:182:55: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_WINDOW_STATE_MAXIMIZED [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editwindow.cc:214:71: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ICON_SIZE_BUTTON [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editwindow.cc:295:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_CONTROL_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/delayed.h:100:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ts [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editorpanel.h:98:10: style:inconclusive: Either there is a missing 'override', or the member function 'EditorPanel::isRealized' can be const. [functionConst] rawtherapee-5.12/rtgui/progressconnector.h:109:7: style:inconclusive: Technically the member function 'ProgressConnector < int >::returnValue' can be const. [functionConst] rawtherapee-5.12/rtgui/editwindow.cc:189:53: style:inconclusive: Function 'on_mainNB_switch_page' argument 1 names different: declaration 'page' definition 'widget'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/editwindow.h:76:45: note: Function 'on_mainNB_switch_page' argument 1 names different: declaration 'page' definition 'widget'. rawtherapee-5.12/rtgui/editwindow.cc:189:53: note: Function 'on_mainNB_switch_page' argument 1 names different: declaration 'page' definition 'widget'. rawtherapee-5.12/rtgui/editwindow.cc:253:22: style: Variable 'ep1' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/editwindow.cc:405:22: style: Variable 'w' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/editwindow.cc:388:48: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/editorpanel.cc:108:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_NONE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editorpanel.cc:391:86: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ALIGN_FILL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editorpanel.cc:425:96: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ALIGN_FILL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editorpanel.cc:433:88: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ICON_SIZE_LARGE_TOOLBAR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editorpanel.cc:519:79: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable INTENT_RELATIVE_COLORIMETRIC [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editorpanel.cc:598:59: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvMonitorTransform [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editorpanel.cc:632:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable POS_RIGHT [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editorpanel.cc:715:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editorpanel.cc:1346:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_EXISTS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editorpanel.cc:1360:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_EXISTS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editorpanel.cc:1402:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ST_BAYER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editorpanel.cc:1503:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_BUTTONS_OK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editorpanel.cc:1721:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_CONTROL_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editorpanel.cc:2025:84: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable saveAsTIFF [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editorpanel.cc:2091:127: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TR_NONE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editorpanel.cc:2111:56: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_IS_DIR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editorpanel.cc:2222:82: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NoProfileString [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editorpanel.cc:2383:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_EXISTS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editorpanel.cc:2421:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_IS_REGULAR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editorpanel.cc:2496:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvProfileChanged [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editorpanel.cc:2550:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RELIEF_NONE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editorpanel.cc:2785:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editorpanel.cc:2849:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable POS_LEFT [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/eventmapper.cc:27:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NUMOFEVENTS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/eventmapper.cc:63:24: style: The scope of the variable 'empty' can be reduced. [variableScope] rawtherapee-5.12/rtgui/exifpanel.cc:355:48: debug: Function::addArguments found argument 'a' with varid 0. [varid0] rawtherapee-5.12/rtgui/exifpanel.cc:355:70: debug: Function::addArguments found argument 'b' with varid 0. [varid0] rawtherapee-5.12/rtgui/exifpanel.cc:380:45: debug: Function::addArguments found argument 'key' with varid 0. [varid0] rawtherapee-5.12/rtgui/exifpanel.cc:46:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable basicExifKeys [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/exifpanel.cc:282:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/exifpanel.cc:361:67: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/exifpanel.cc:382:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable key [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/exifpanel.cc:645:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/exifpanel.cc:656:60: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable REGEX_CASELESS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/exifpanel.cc:667:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable REGEX_CASELESS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/exifpanel.cc:678:65: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable REGEX_CASELESS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/exifpanel.cc:689:67: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable REGEX_CASELESS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/exifpanel.cc:726:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable signedRational [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/exifpanel.cc:382:27: debug: CheckClass::isMemberVar found used member variable 'order_' with varid 0 [varid0] rawtherapee-5.12/rtgui/exifpanel.cc:577:25: style: The scope of the variable 'key' can be reduced. [variableScope] rawtherapee-5.12/rtgui/exifpanel.cc:197:123: style:inconclusive: Function 'addTag' argument 3 names different: declaration 'value' definition 'exifValue'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/exifpanel.h:105:116: note: Function 'addTag' argument 3 names different: declaration 'value' definition 'exifValue'. rawtherapee-5.12/rtgui/exifpanel.cc:197:123: note: Function 'addTag' argument 3 names different: declaration 'value' definition 'exifValue'. rawtherapee-5.12/rtgui/exifpanel.cc:707:84: style:inconclusive: Function 'onEditExifTagValue' argument 2 names different: declaration 'value' definition 'val'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/exifpanel.h:125:77: note: Function 'onEditExifTagValue' argument 2 names different: declaration 'value' definition 'val'. rawtherapee-5.12/rtgui/exifpanel.cc:707:84: note: Function 'onEditExifTagValue' argument 2 names different: declaration 'value' definition 'val'. rawtherapee-5.12/rtgui/exifpanel.cc:718:14: style: Local variable 'it' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/exifpanel.cc:709:10: note: Shadowed declaration rawtherapee-5.12/rtgui/exifpanel.cc:718:14: note: Shadow variable rawtherapee-5.12/rtgui/exifpanel.cc:544:20: style: Variable 'c' can be declared as reference to const [constVariableReference] rawtherapee-5.12/rtgui/exifpanel.cc:576:20: style: Variable 'entry' can be declared as reference to const [constVariableReference] rawtherapee-5.12/rtgui/exifpanel.cc:732:30: style: Variable 'exc' can be declared as reference to const [constVariableReference] rawtherapee-5.12/rtgui/exifpanel.cc:47:22: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/exifpanel.cc:389:50: style: struct member 'KeyLt::order_' is never used. [unusedStructMember] rawtherapee-5.12/rtgui/exifpanel.cc:259:39: style: Variable 'sel' is assigned a value that is never used. [unreadVariable] rawtherapee-5.12/rtgui/editorpanel.cc:2808:19: performance:inconclusive: Either there is a missing 'override', or the member function 'EditorPanel::updateProfiles' can be static. [functionStatic] rawtherapee-5.12/rtgui/editorpanel.h:198:10: note: Either there is a missing 'override', or the member function 'EditorPanel::updateProfiles' can be static. rawtherapee-5.12/rtgui/editorpanel.cc:2808:19: note: Either there is a missing 'override', or the member function 'EditorPanel::updateProfiles' can be static. rawtherapee-5.12/rtgui/rtappchooserdialog.h:34:5: style: Class 'RTAppChooserDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] rawtherapee-5.12/rtgui/editorpanel.cc:1506:27: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtgui/editorpanel.cc:2093:52: error:inconclusive: Division by zero. [zerodiv] rawtherapee-5.12/rtgui/editorpanel.cc:2090:28: note: Assignment 'fullH=0', assigned value is 0 rawtherapee-5.12/rtgui/editorpanel.cc:2093:52: note: Division by zero rawtherapee-5.12/rtgui/editorpanel.cc:1514:48: style:inconclusive: Function 'refreshProcessingState' argument 1 names different: declaration 'inProcessing' definition 'inProcessingP'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/editorpanel.h:110:39: note: Function 'refreshProcessingState' argument 1 names different: declaration 'inProcessing' definition 'inProcessingP'. rawtherapee-5.12/rtgui/editorpanel.cc:1514:48: note: Function 'refreshProcessingState' argument 1 names different: declaration 'inProcessing' definition 'inProcessingP'. rawtherapee-5.12/rtgui/editorpanel.cc:2456:50: style:inconclusive: Function 'onAppChooserDialogResponse' argument 1 names different: declaration 'resposneId' definition 'responseId'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/editorpanel.h:220:41: note: Function 'onAppChooserDialogResponse' argument 1 names different: declaration 'resposneId' definition 'responseId'. rawtherapee-5.12/rtgui/editorpanel.cc:2456:50: note: Function 'onAppChooserDialogResponse' argument 1 names different: declaration 'resposneId' definition 'responseId'. rawtherapee-5.12/rtgui/editorpanel.cc:997:25: style: Local variable 'vsep3' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/editorpanel.cc:826:21: note: Shadowed declaration rawtherapee-5.12/rtgui/editorpanel.cc:997:25: note: Shadow variable rawtherapee-5.12/rtgui/editorpanel.cc:2280:9: style: Local variable 'err' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/editorpanel.h:305:9: note: Shadowed declaration rawtherapee-5.12/rtgui/editorpanel.cc:2280:9: note: Shadow variable rawtherapee-5.12/rtgui/exportpanel.cc:34:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/editorpanel.cc:59:55: performance:inconclusive: Function parameter 'str' should be passed by const reference. [passedByValue] rawtherapee-5.12/rtgui/editorpanel.cc:2052:106: performance:inconclusive: Function parameter 'fname' should be passed by const reference. However it seems that 'idle_imageSaved' is a callback function. [passedByValueCallback] rawtherapee-5.12/rtgui/editorpanel.cc:2032:76: note: Function pointer used here. rawtherapee-5.12/rtgui/editorpanel.cc:2052:106: note: Function parameter 'fname' should be passed by const reference. However it seems that 'idle_imageSaved' is a callback function. rawtherapee-5.12/rtgui/editorpanel.cc:2052:124: performance: Function parameter 'sf' should be passed by const reference. However it seems that 'idle_imageSaved' is a callback function. [passedByValueCallback] rawtherapee-5.12/rtgui/editorpanel.cc:2032:76: note: Function pointer used here. rawtherapee-5.12/rtgui/editorpanel.cc:2052:124: note: Function parameter 'sf' should be passed by const reference. However it seems that 'idle_imageSaved' is a callback function. rawtherapee-5.12/rtgui/exportpanel.cc:380:19: performance:inconclusive: Either there is a missing 'override', or the member function 'ExportPanel::LoadSettings' can be static. [functionStatic] rawtherapee-5.12/rtgui/exportpanel.h:113:10: note: Either there is a missing 'override', or the member function 'ExportPanel::LoadSettings' can be static. rawtherapee-5.12/rtgui/exportpanel.cc:380:19: note: Either there is a missing 'override', or the member function 'ExportPanel::LoadSettings' can be static. rawtherapee-5.12/rtgui/exportpanel.cc:385:19: performance:inconclusive: Either there is a missing 'override', or the member function 'ExportPanel::SaveSettings' can be static. [functionStatic] rawtherapee-5.12/rtgui/exportpanel.h:114:10: note: Either there is a missing 'override', or the member function 'ExportPanel::SaveSettings' can be static. rawtherapee-5.12/rtgui/exportpanel.cc:385:19: note: Either there is a missing 'override', or the member function 'ExportPanel::SaveSettings' can be static. rawtherapee-5.12/rtgui/editorpanel.cc:2377:23: style: Variable 'sf.saveParams' is assigned a value that is never used. [unreadVariable] rawtherapee-5.12/rtgui/externaleditorpreferences.cc:45:55: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TREE_VIEW_COLUMN_FIXED [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/externaleditorpreferences.cc:137:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/externaleditorpreferences.cc:313:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_FILTER_MIME_TYPE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/externaleditorpreferences.cc:229:9: style:inconclusive: Function 'onAppChooserDialogResponse' argument 1 names different: declaration 'responseId' definition 'response_id'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/externaleditorpreferences.h:147:41: note: Function 'onAppChooserDialogResponse' argument 1 names different: declaration 'responseId' definition 'response_id'. rawtherapee-5.12/rtgui/externaleditorpreferences.cc:229:9: note: Function 'onAppChooserDialogResponse' argument 1 names different: declaration 'responseId' definition 'response_id'. rawtherapee-5.12/rtgui/externaleditorpreferences.cc:248:13: style:inconclusive: Function 'onFileChooserDialogResponse' argument 1 names different: declaration 'responseId' definition 'response_id'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/externaleditorpreferences.h:152:42: note: Function 'onFileChooserDialogResponse' argument 1 names different: declaration 'responseId' definition 'response_id'. rawtherapee-5.12/rtgui/externaleditorpreferences.cc:248:13: note: Function 'onFileChooserDialogResponse' argument 1 names different: declaration 'responseId' definition 'response_id'. rawtherapee-5.12/rtgui/extprog.cc:48:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_EXISTS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/extprog.cc:213:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/extprog.cc:232:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/extprog.cc:350:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/extprog.cc:46:5: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/extprog.cc:63:17: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/fattaltonemap.cc:39:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable HDR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/fattaltonemap.cc:116:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvTMFattalThreshold [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/favoritbrowser.cc:26:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filebrowserentry.cc:85:78: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ICON_SIZE_SMALL_TOOLBAR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filebrowserentry.cc:178:83: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable crop [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filebrowserentry.cc:247:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_PRIORITY_LOW [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filebrowserentry.cc:462:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_SHIFT_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filebrowserentry.cc:766:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RT_PI [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filebrowser.cc:444:103: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ACCEL_VISIBLE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filebrowser.cc:871:85: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_CHOOSER_ACTION_OPEN [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filebrowser.cc:1125:72: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable pparams [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filebrowser.cc:1182:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_CONTROL_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filebrowser.cc:1395:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable THLOC_EDITOR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filebrowser.cc:1405:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable THLOC_EDITOR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filebrowser.cc:1417:67: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_KEY_f [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filebrowser.cc:1468:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RESPONSE_OK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filebrowser.cc:1575:61: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filebrowser.cc:2070:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PSET_FOLDER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filebrowserentry.cc:251:68: style:inconclusive: Function '_updateImage' argument 2 names different: declaration 'scale' definition 's'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/filebrowserentry.h:106:54: note: Function '_updateImage' argument 2 names different: declaration 'scale' definition 's'. rawtherapee-5.12/rtgui/filebrowserentry.cc:251:68: note: Function '_updateImage' argument 2 names different: declaration 'scale' definition 's'. rawtherapee-5.12/rtgui/filebrowserentry.cc:760:75: style:inconclusive: Function 'drawStraightenGuide' argument 1 names different: declaration 'c' definition 'cr'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/filebrowserentry.h:70:61: note: Function 'drawStraightenGuide' argument 1 names different: declaration 'c' definition 'cr'. rawtherapee-5.12/rtgui/filebrowserentry.cc:760:75: note: Function 'drawStraightenGuide' argument 1 names different: declaration 'c' definition 'cr'. rawtherapee-5.12/rtgui/filecatalog.cc:71:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filecatalog.cc:591:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_FILE_ATTRIBUTE_STANDARD_NAME [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filecatalog.cc:700:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filecatalog.cc:776:83: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ALIGN_CENTER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filecatalog.cc:1032:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RESPONSE_YES [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filecatalog.cc:1078:73: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_CHOOSER_ACTION_SELECT_FOLDER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filecatalog.cc:1328:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RESPONSE_OK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filecatalog.cc:1632:53: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PACK_SHRINK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filecatalog.cc:1779:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_IS_DIR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filecatalog.cc:1834:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_MONITOR_EVENT_CREATED [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filecatalog.cc:1875:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filecatalog.cc:2019:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_SHIFT_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filecatalog.cc:2047:53: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PACK_EXPAND_WIDGET [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filecatalog.cc:2100:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_IS_DIR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filecatalog.cc:2112:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_SHIFT_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filecatalog.cc:2276:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_CONTROL_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filecatalog.cc:2613:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_CONTROL_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/filebrowser.cc:2026:46: style:inconclusive: Either there is a missing 'override', or the member function 'FileBrowser::trash_changed' can be const. [functionConst] rawtherapee-5.12/rtgui/filebrowser.h:222:24: note: Either there is a missing 'override', or the member function 'FileBrowser::trash_changed' can be const. rawtherapee-5.12/rtgui/filebrowser.cc:2026:46: note: Either there is a missing 'override', or the member function 'FileBrowser::trash_changed' can be const. rawtherapee-5.12/rtgui/filebrowser.cc:1412:19: warning: The class 'FileBrowser' defines member function with name 'enableTabMode' also defined in its parent class 'ThumbBrowserBase'. [duplInheritedMember] rawtherapee-5.12/rtgui/thumbbrowserbase.h:223:10: note: Parent function 'ThumbBrowserBase::enableTabMode' rawtherapee-5.12/rtgui/filebrowser.cc:1412:19: note: Derived function 'FileBrowser::enableTabMode' rawtherapee-5.12/rtgui/filebrowser.cc:1082:13: style: Condition '!mselected.empty()' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtgui/filebrowser.cc:1078:36: note: Assuming that condition 'mselected.empty()' is not redundant rawtherapee-5.12/rtgui/filebrowser.cc:1082:13: note: Condition '!mselected.empty()' is always true rawtherapee-5.12/rtgui/filebrowser.cc:1096:13: style: Condition '!mselected.empty()' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtgui/filebrowser.cc:1078:36: note: Assuming that condition 'mselected.empty()' is not redundant rawtherapee-5.12/rtgui/filebrowser.cc:1096:13: note: Condition '!mselected.empty()' is always true rawtherapee-5.12/rtgui/filebrowser.cc:1131:17: style: Condition '!mselected.empty()' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtgui/filebrowser.cc:1118:36: note: Assuming that condition 'mselected.empty()' is not redundant rawtherapee-5.12/rtgui/filebrowser.cc:1131:17: note: Condition '!mselected.empty()' is always true rawtherapee-5.12/rtgui/filebrowser.cc:1149:17: style: Condition '!mselected.empty()' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtgui/filebrowser.cc:1118:36: note: Assuming that condition 'mselected.empty()' is not redundant rawtherapee-5.12/rtgui/filebrowser.cc:1135:31: note: Assuming container is not empty rawtherapee-5.12/rtgui/filebrowser.cc:1149:17: note: Condition '!mselected.empty()' is always true rawtherapee-5.12/rtgui/filebrowser.cc:1869:23: style: Condition 'i>0' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtgui/filebrowser.cc:1867:25: note: Assignment 'i=1', assigned value is 1 rawtherapee-5.12/rtgui/filebrowser.cc:1869:23: note: Condition 'i>0' is always true rawtherapee-5.12/rtgui/filebrowser.cc:1542:55: style:inconclusive: Function 'checkFilter' argument 1 names different: declaration 'entry' definition 'entryb'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/filebrowser.h:182:46: note: Function 'checkFilter' argument 1 names different: declaration 'entry' definition 'entryb'. rawtherapee-5.12/rtgui/filebrowser.cc:1542:55: note: Function 'checkFilter' argument 1 names different: declaration 'entry' definition 'entryb'. rawtherapee-5.12/rtgui/filebrowser.cc:1974:83: style:inconclusive: Function 'openNextPreviousEditorImage' argument 2 names different: declaration 'eNextPrevious' definition 'nextPrevious'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/filebrowser.h:204:73: note: Function 'openNextPreviousEditorImage' argument 2 names different: declaration 'eNextPrevious' definition 'nextPrevious'. rawtherapee-5.12/rtgui/filebrowser.cc:1974:83: note: Function 'openNextPreviousEditorImage' argument 2 names different: declaration 'eNextPrevious' definition 'nextPrevious'. rawtherapee-5.12/rtgui/filebrowser.cc:1024:24: style: Local variable 'rank' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/filebrowser.h:74:20: note: Shadowed declaration rawtherapee-5.12/rtgui/filebrowser.cc:1024:24: note: Shadow variable rawtherapee-5.12/rtgui/filebrowser.cc:2161:67: performance: Function parameter 'mselected' should be passed by const reference. [passedByValue] rawtherapee-5.12/rtgui/filebrowser.cc:1805:60: warning: Either the condition 'i=3' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtgui/guiutils.cc:542:22: note: Assuming that condition 'level==2' is not redundant rawtherapee-5.12/rtgui/guiutils.cc:544:22: note: Condition 'level>=3' is always true rawtherapee-5.12/rtgui/guiutils.cc:1055:58: style:inconclusive: Function 'get_preferred_height_vfunc' argument 1 names different: declaration 'minimum_height' definition 'minimumHeight'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/guiutils.h:347:43: note: Function 'get_preferred_height_vfunc' argument 1 names different: declaration 'minimum_height' definition 'minimumHeight'. rawtherapee-5.12/rtgui/guiutils.cc:1055:58: note: Function 'get_preferred_height_vfunc' argument 1 names different: declaration 'minimum_height' definition 'minimumHeight'. rawtherapee-5.12/rtgui/guiutils.cc:1055:78: style:inconclusive: Function 'get_preferred_height_vfunc' argument 2 names different: declaration 'natural_height' definition 'naturalHeight'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/guiutils.h:347:64: note: Function 'get_preferred_height_vfunc' argument 2 names different: declaration 'natural_height' definition 'naturalHeight'. rawtherapee-5.12/rtgui/guiutils.cc:1055:78: note: Function 'get_preferred_height_vfunc' argument 2 names different: declaration 'natural_height' definition 'naturalHeight'. rawtherapee-5.12/rtgui/guiutils.cc:1637:71: style:inconclusive: Function 'MyImageMenuItem' argument 2 names different: declaration 'image' definition 'itemImage'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/guiutils.h:576:59: note: Function 'MyImageMenuItem' argument 2 names different: declaration 'image' definition 'itemImage'. rawtherapee-5.12/rtgui/guiutils.cc:1637:71: note: Function 'MyImageMenuItem' argument 2 names different: declaration 'image' definition 'itemImage'. rawtherapee-5.12/rtgui/guiutils.cc:1695:28: style:inconclusive: Function 'BackBuffer' argument 1 names different: declaration 'w' definition 'width'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/guiutils.h:668:20: note: Function 'BackBuffer' argument 1 names different: declaration 'w' definition 'width'. rawtherapee-5.12/rtgui/guiutils.cc:1695:28: note: Function 'BackBuffer' argument 1 names different: declaration 'w' definition 'width'. rawtherapee-5.12/rtgui/guiutils.cc:1695:39: style:inconclusive: Function 'BackBuffer' argument 2 names different: declaration 'h' definition 'height'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/guiutils.h:668:27: note: Function 'BackBuffer' argument 2 names different: declaration 'h' definition 'height'. rawtherapee-5.12/rtgui/guiutils.cc:1695:39: note: Function 'BackBuffer' argument 2 names different: declaration 'h' definition 'height'. rawtherapee-5.12/rtgui/guiutils.cc:1850:80: style:inconclusive: Function 'copySurface' argument 2 names different: declaration 'rectangle' definition 'destRectangle'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/guiutils.h:684:72: note: Function 'copySurface' argument 2 names different: declaration 'rectangle' definition 'destRectangle'. rawtherapee-5.12/rtgui/guiutils.cc:1850:80: note: Function 'copySurface' argument 2 names different: declaration 'rectangle' definition 'destRectangle'. rawtherapee-5.12/rtgui/guiutils.cc:1886:74: style:inconclusive: Function 'copySurface' argument 2 names different: declaration 'rectangle' definition 'destRectangle'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/guiutils.h:685:66: note: Function 'copySurface' argument 2 names different: declaration 'rectangle' definition 'destRectangle'. rawtherapee-5.12/rtgui/guiutils.cc:1886:74: note: Function 'copySurface' argument 2 names different: declaration 'rectangle' definition 'destRectangle'. rawtherapee-5.12/rtgui/guiutils.cc:1924:94: style:inconclusive: Function 'copySurface' argument 2 names different: declaration 'rectangle' definition 'destRectangle'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/guiutils.h:686:86: note: Function 'copySurface' argument 2 names different: declaration 'rectangle' definition 'destRectangle'. rawtherapee-5.12/rtgui/guiutils.cc:1924:94: note: Function 'copySurface' argument 2 names different: declaration 'rectangle' definition 'destRectangle'. rawtherapee-5.12/rtgui/hsvequalizer.cc:72:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PACK_SHRINK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/iccprofilecreator.cc:83:75: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ALIGN_BASELINE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/iccprofilecreator.cc:742:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/iccprofilecreator.cc:621:71: style:inconclusive: Function 'getGamma' argument 2 names different: declaration 'gamma' definition 'presetGamma'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/iccprofilecreator.h:101:56: note: Function 'getGamma' argument 2 names different: declaration 'gamma' definition 'presetGamma'. rawtherapee-5.12/rtgui/iccprofilecreator.cc:621:71: note: Function 'getGamma' argument 2 names different: declaration 'gamma' definition 'presetGamma'. rawtherapee-5.12/rtgui/iccprofilecreator.cc:621:92: style:inconclusive: Function 'getGamma' argument 3 names different: declaration 'slope' definition 'presetSlope'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/iccprofilecreator.h:101:71: note: Function 'getGamma' argument 3 names different: declaration 'slope' definition 'presetSlope'. rawtherapee-5.12/rtgui/iccprofilecreator.cc:621:92: note: Function 'getGamma' argument 3 names different: declaration 'slope' definition 'presetSlope'. rawtherapee-5.12/rtgui/iccprofilecreator.cc:420:12: style: Local variable 'gamma' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/iccprofilecreator.h:52:12: note: Shadowed declaration rawtherapee-5.12/rtgui/iccprofilecreator.cc:420:12: note: Shadow variable rawtherapee-5.12/rtgui/iccprofilecreator.cc:421:12: style: Local variable 'slope' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/iccprofilecreator.h:53:12: note: Shadowed declaration rawtherapee-5.12/rtgui/iccprofilecreator.cc:421:12: note: Shadow variable rawtherapee-5.12/rtgui/imagearea.cc:49:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LEAVE_NOTIFY_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/imagearea.cc:81:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EXPOSURE_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/imagearea.cc:157:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WEIGHT_BOLD [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/imagearea.cc:546:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable M_HIGHQUAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/imagearea.cc:789:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SIZE_REQUEST_CONSTANT_SIZE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/imagearea.cc:777:16: style:inconclusive: Either there is a missing 'override', or the member function 'ImageArea::getSpotWBRectSize' can be const. [functionConst] rawtherapee-5.12/rtgui/imagearea.h:140:10: note: Either there is a missing 'override', or the member function 'ImageArea::getSpotWBRectSize' can be const. rawtherapee-5.12/rtgui/imagearea.cc:777:16: note: Either there is a missing 'override', or the member function 'ImageArea::getSpotWBRectSize' can be const. rawtherapee-5.12/rtgui/imagearea.cc:89:46: style: Parameter 'req' can be declared as reference to const. However it seems that 'on_resized' is a callback function, if 'req' is declared with const you might also need to cast function pointer(s). [constParameterCallback] rawtherapee-5.12/rtgui/imagearea.cc:51:70: note: You might need to cast the function pointer here rawtherapee-5.12/rtgui/imagearea.cc:89:46: note: Parameter 'req' can be declared as reference to const rawtherapee-5.12/rtgui/imagearea.cc:380:22: style: Variable 'oldSubscriber' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/imagearea.cc:211:39: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/imageareapanel.cc:23:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/icmpanel.cc:48:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GAMMA [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/icmpanel.cc:688:74: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable REC2020 [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/icmpanel.cc:733:61: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable INTENT_PERCEPTUAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/icmpanel.cc:1012:158: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable STATE_INSENSITIVE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/icmpanel.cc:1461:61: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_EXISTS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/icmpanel.cc:1702:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvWProfile [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/icmpanel.cc:1744:119: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DEFAULT [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/icmpanel.cc:2048:78: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable D65 [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/icmpanel.cc:2316:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvDCPIlluminant [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/icmpanel.cc:2450:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvIProfile [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/icmpanel.cc:2463:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvOProfile [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/icmpanel.cc:2496:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvOIntent [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/icmpanel.cc:2705:92: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_CHOOSER_ACTION_SAVE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/icmpanel.cc:2766:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PACK_SHRINK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/indclippedpanel.cc:34:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RELIEF_NONE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/inspector.cc:33:64: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_EXISTS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/inspector.cc:98:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KEY_PRESS_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/inspector.cc:231:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_WINDOW_STATE_FULLSCREEN [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/inspector.cc:241:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_BUTTON_PRESS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/inspector.cc:282:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_MOD1_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/inspector.cc:526:88: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable INTERP_BILINEAR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/inspector.cc:686:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SIZE_REQUEST_CONSTANT_SIZE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/inspector.cc:243:13: style: The statement 'if (!pinned) pinned=true' is logically equivalent to 'pinned=true'. [duplicateConditionalAssign] rawtherapee-5.12/rtgui/inspector.cc:245:20: note: Assignment 'pinned=true' rawtherapee-5.12/rtgui/inspector.cc:243:13: note: Condition '!pinned' is redundant rawtherapee-5.12/rtgui/inspector.cc:417:9: style: The statement 'if (!active) active=true' is logically equivalent to 'active=true'. [duplicateConditionalAssign] rawtherapee-5.12/rtgui/inspector.cc:418:16: note: Assignment 'active=true' rawtherapee-5.12/rtgui/inspector.cc:417:9: note: Condition '!active' is redundant rawtherapee-5.12/rtgui/inspector.cc:31:55: style:inconclusive: Function 'InspectorBuffer' argument 1 names different: declaration 'imgagePath' definition 'imagePath'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/inspector.h:38:51: note: Function 'InspectorBuffer' argument 1 names different: declaration 'imgagePath' definition 'imagePath'. rawtherapee-5.12/rtgui/inspector.cc:31:55: note: Function 'InspectorBuffer' argument 1 names different: declaration 'imgagePath' definition 'imagePath'. rawtherapee-5.12/rtgui/inspector.cc:372:13: style: Local variable 'imW' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/inspector.cc:360:9: note: Shadowed declaration rawtherapee-5.12/rtgui/inspector.cc:372:13: note: Shadow variable rawtherapee-5.12/rtgui/inspector.cc:373:13: style: Local variable 'imH' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/inspector.cc:361:9: note: Shadowed declaration rawtherapee-5.12/rtgui/inspector.cc:373:13: note: Shadow variable rawtherapee-5.12/rtgui/iptcpanel.cc:83:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/iptcpanel.cc:506:19: style: Variable 'iptc' can be declared as reference to const [constVariableReference] rawtherapee-5.12/rtgui/labcurve.cc:41:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LUMINANCECURVE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/labcurve.cc:591:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLBrightness [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/labgrid.cc:102:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EXPOSURE_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/labgrid.cc:219:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LINE_CAP_SQUARE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/labgrid.cc:518:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_2BUTTON_PRESS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/labgrid.cc:603:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NONE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/labgrid.cc:631:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SIZE_REQUEST_HEIGHT_FOR_WIDTH [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/labgrid.cc:714:64: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ICON_SIZE_BUTTON [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/labgrid.cc:734:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_CONTROL_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/lensgeom.cc:37:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TRANSFORM [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/lensgeom.cc:138:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/labgrid.cc:489:13: style: The if condition is the same as the previous if condition [duplicateCondition] rawtherapee-5.12/rtgui/labgrid.cc:479:13: note: First condition rawtherapee-5.12/rtgui/labgrid.cc:489:13: note: Second condition rawtherapee-5.12/rtgui/labgrid.cc:495:13: style: The if condition is the same as the previous if condition [duplicateCondition] rawtherapee-5.12/rtgui/labgrid.cc:489:13: note: First condition rawtherapee-5.12/rtgui/labgrid.cc:495:13: note: Second condition rawtherapee-5.12/rtgui/labgrid.cc:540:12: style: Condition 'mous_enabled' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtgui/labgrid.cc:516:32: note: Assuming that condition 'mous_enabled' is not redundant rawtherapee-5.12/rtgui/labgrid.cc:540:12: note: Condition 'mous_enabled' is always true rawtherapee-5.12/rtgui/labgrid.cc:711:18: style: Local variable 'reset' shadows outer function [shadowFunction] rawtherapee-5.12/rtgui/labgrid.h:187:10: note: Shadowed declaration rawtherapee-5.12/rtgui/labgrid.cc:711:18: note: Shadow variable rawtherapee-5.12/rtgui/labgrid.cc:708:38: performance:inconclusive: Function parameter 'evt' should be passed by const reference. [passedByValue] rawtherapee-5.12/rtgui/lensprofile.cc:84:76: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ALIGN_CENTER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/lensprofile.cc:245:68: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LCP [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/lensprofile.cc:335:67: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LCP [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/lensprofile.cc:441:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLCPUseDist [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/lensprofile.cc:454:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLCPUseVign [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/lensprofile.cc:467:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLCPUseCA [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/lensprofile.cc:476:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable POS_TOP [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/lensprofile.cc:495:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLensCorrLensfunCamera [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/lensprofile.cc:515:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLensCorrLensfunLens [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/lensprofile.cc:628:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLensCorrMode [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/lensprofile.cc:663:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/lensprofile.cc:693:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/localcontrast.cc:43:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LUMINANCECURVE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/lensprofile.cc:220:22: style: Local variable 'metadataCorrection' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/lensprofile.h:118:55: note: Shadowed declaration rawtherapee-5.12/rtgui/lensprofile.cc:220:22: note: Shadow variable rawtherapee-5.12/rtgui/locallab.cc:43:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallab.cc:158:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:55:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NORMAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:171:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:263:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabToolAdded [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:287:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabToolRemovedWithRefresh [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:419:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_BUTTON_PRIMARY [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:429:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_BUTTON_SECONDARY [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:450:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:581:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AUTOEXP [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:1314:63: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LABGRIDL_CORR_MAX [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:1497:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LABGRIDL_CORR_MAX [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:1660:67: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LABGRIDL_CORR_MAX [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:1708:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Evlocallablightness [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:1946:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabcsThresholdcol [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:2151:71: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LABGRIDL_CORR_MAX [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:2396:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLocallabgridMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:2412:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:2433:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabqualitycurveMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:2443:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLocallabtoneMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:2470:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLocallabmerMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:2480:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLocallabmergecolMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:2499:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:2517:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:2608:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Expert [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:2786:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:3512:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Evlocallablaplacexp [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:4017:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabexpMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:4027:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabexnoiseMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:4075:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:4106:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:4125:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:4241:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Normal [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:4367:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AUTOEXP [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:5312:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabdetailSH [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:5778:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:5794:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Expert [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:5828:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:5855:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:5883:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:5924:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:5943:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:6012:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Expert [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:6085:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Expert [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:6193:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AUTOEXP [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:6730:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabSaturated [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:6875:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabPastSatThreshold [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:7203:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:7259:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:7454:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Evlocallabstreng [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:7477:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Simple [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:7616:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:7636:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:7654:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Expert [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:7780:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AUTOEXP [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:8894:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Evlocallabradius [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:9289:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabcsThresholdblur [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:9652:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabblMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:9753:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabmedMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:9763:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabblurMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:9773:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabchroMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:9783:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabquaMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:9813:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:9841:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmasktypMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools.cc:9911:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Expert [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallab.cc:1333:9: style: The scope of the variable 'bw' can be reduced. [variableScope] rawtherapee-5.12/rtgui/locallab.cc:1334:12: style: The scope of the variable 'bwvalue' can be reduced. [variableScope] rawtherapee-5.12/rtgui/locallab.cc:69:16: style: Variable 'r' can be declared as reference to const [constVariableReference] rawtherapee-5.12/rtgui/locallab.cc:97:42: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/locallab.cc:848:16: error: Uninitialized struct member: r.spotMethod [uninitStructMember] rawtherapee-5.12/rtgui/locallab.cc:848:37: error: Uninitialized struct member: r.spotMethod [uninitStructMember] rawtherapee-5.12/rtgui/locallabtools.cc:4178:24: performance:inconclusive: Either there is a missing 'override', or the member function 'LocallabExposure::updateExposureGUI2' can be static. [functionStatic] rawtherapee-5.12/rtgui/locallabtools.h:563:10: note: Either there is a missing 'override', or the member function 'LocallabExposure::updateExposureGUI2' can be static. rawtherapee-5.12/rtgui/locallabtools.cc:4178:24: note: Either there is a missing 'override', or the member function 'LocallabExposure::updateExposureGUI2' can be static. rawtherapee-5.12/rtgui/lockablecolorpicker.cc:62:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SCALE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/lockablecolorpicker.cc:334:49: style:inconclusive: Function 'setValidity' argument 1 names different: declaration 'isValid' definition 'validity'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/lockablecolorpicker.h:97:32: note: Function 'setValidity' argument 1 names different: declaration 'isValid' definition 'validity'. rawtherapee-5.12/rtgui/lockablecolorpicker.cc:334:49: note: Function 'setValidity' argument 1 names different: declaration 'isValid' definition 'validity'. rawtherapee-5.12/rtgui/locallabtools2.cc:162:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AUTOEXP [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:611:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Evlocallabamount [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:661:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabCCmasktmshape [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:675:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLocenatonemap [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:830:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:937:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AUTOEXP [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:1554:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Evlocallabdehaz [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:1958:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabretinexMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:2003:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:2057:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:2129:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:2335:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Evlocallabsharcontrast [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:2495:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Expert [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:2521:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:2636:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AUTOEXP [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:3725:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Evlocallablcradius [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:4109:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabcsThreshold [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:4424:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallablocalcontMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:4495:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallablocaledgMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:4523:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallablocalneiMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:4631:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:4679:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Expert [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:4788:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:5217:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Evlocallabchromacbdl [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:5501:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:5637:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AUTOEXP [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:6509:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:6609:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Evlocallabrepar [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:6888:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Evlocallabsursour [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:6899:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Evlocallabsurround [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:7066:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Expert [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:7137:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AUTOEXP [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:7611:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Evlocallabsensimask [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:7729:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabcsThresholdmask [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:7786:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Simple [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:7966:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:8296:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AUTOEXP [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:9739:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabshowmaskMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:10618:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLocallabtoneMethodcie [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:10628:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLocallabtoneMethodcie2 [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:11352:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Expert [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:11544:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Expert [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:11600:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Evlocallabsursourcie [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:11772:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Expert [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:11811:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Evlocallabsurroundcie [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:11842:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Simple [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:11876:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Expert [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:12690:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Simple [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:13143:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Evlocallabshapejz [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:13246:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvlocallabcsThresholdjz [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:13270:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Evlocallabreparcie [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/lwbutton.cc:107:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Normal [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/lwbutton.cc:133:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Normal [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/lwbutton.cc:163:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Normal [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/lwbutton.cc:190:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ANTIALIAS_SUBPIXEL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/lwbuttonset.cc:171:19: style:inconclusive: Technically the member function 'LWButtonSet::setColors' can be const. [functionConst] rawtherapee-5.12/rtgui/lwbuttonset.h:41:13: note: Technically the member function 'LWButtonSet::setColors' can be const. rawtherapee-5.12/rtgui/lwbuttonset.cc:171:19: note: Technically the member function 'LWButtonSet::setColors' can be const. rawtherapee-5.12/rtgui/lwbuttonset.cc:120:19: style:inconclusive: Technically the member function 'LWButtonSet::motionNotify' can be const. [functionConst] rawtherapee-5.12/rtgui/lwbuttonset.h:42:13: note: Technically the member function 'LWButtonSet::motionNotify' can be const. rawtherapee-5.12/rtgui/lwbuttonset.cc:120:19: note: Technically the member function 'LWButtonSet::motionNotify' can be const. rawtherapee-5.12/rtgui/lwbuttonset.cc:129:19: style:inconclusive: Technically the member function 'LWButtonSet::pressNotify' can be const. [functionConst] rawtherapee-5.12/rtgui/lwbuttonset.h:43:13: note: Technically the member function 'LWButtonSet::pressNotify' can be const. rawtherapee-5.12/rtgui/lwbuttonset.cc:129:19: note: Technically the member function 'LWButtonSet::pressNotify' can be const. rawtherapee-5.12/rtgui/lwbuttonset.cc:138:19: style:inconclusive: Technically the member function 'LWButtonSet::releaseNotify' can be const. [functionConst] rawtherapee-5.12/rtgui/lwbuttonset.h:44:13: note: Technically the member function 'LWButtonSet::releaseNotify' can be const. rawtherapee-5.12/rtgui/lwbuttonset.cc:138:19: note: Technically the member function 'LWButtonSet::releaseNotify' can be const. rawtherapee-5.12/rtgui/lwbuttonset.cc:158:19: style:inconclusive: Technically the member function 'LWButtonSet::setButtonListener' can be const. [functionConst] rawtherapee-5.12/rtgui/lwbuttonset.h:50:13: note: Technically the member function 'LWButtonSet::setButtonListener' can be const. rawtherapee-5.12/rtgui/lwbuttonset.cc:158:19: note: Technically the member function 'LWButtonSet::setButtonListener' can be const. rawtherapee-5.12/rtgui/lwbuttonset.cc:113:19: style:inconclusive: Technically the member function 'LWButtonSet::redraw' can be const. [functionConst] rawtherapee-5.12/rtgui/lwbuttonset.h:51:13: note: Technically the member function 'LWButtonSet::redraw' can be const. rawtherapee-5.12/rtgui/lwbuttonset.cc:113:19: note: Technically the member function 'LWButtonSet::redraw' can be const. rawtherapee-5.12/rtgui/lwbuttonset.cc:150:5: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/main-cli.cc:88:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LC_ALL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/main-cli.cc:290:71: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_IS_DIR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/locallabtools2.cc:7029:19: performance:inconclusive: Either there is a missing 'override', or the member function 'LocallabLog::updateLogGUI2' can be static. [functionStatic] rawtherapee-5.12/rtgui/locallabtools.h:1673:10: note: Either there is a missing 'override', or the member function 'LocallabLog::updateLogGUI2' can be static. rawtherapee-5.12/rtgui/locallabtools2.cc:7029:19: note: Either there is a missing 'override', or the member function 'LocallabLog::updateLogGUI2' can be static. rawtherapee-5.12/rtgui/main.cc:130:57: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RTVERSION [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/main.cc:208:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/main.cc:351:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LC_ALL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/main.cc:270:13: style: Condition '!init_rt()' is always false [knownConditionTrueFalse] rawtherapee-5.12/rtgui/main.cc:270:21: note: Calling function 'init_rt' returns 1 rawtherapee-5.12/rtgui/main.cc:270:13: note: Condition '!init_rt()' is always false rawtherapee-5.12/rtgui/main.cc:534:42: style: Condition 'init_rt()' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtgui/main.cc:534:42: note: Calling function 'init_rt' returns 1 rawtherapee-5.12/rtgui/main.cc:534:42: note: Condition 'init_rt()' is always true rawtherapee-5.12/rtgui/metadatapanel.cc:31:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/multilangmgr.cc:156:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/multilangmgr.cc:225:70: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/multilangmgr.cc:261:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/mycurve.cc:58:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable POINTER_MOTION_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/mycurve.cc:90:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SIZE_REQUEST_HEIGHT_FOR_WIDTH [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/mycurve.cc:80:35: style: Variable 'newRequestedH' is assigned a value that is never used. [unreadVariable] rawtherapee-5.12/rtgui/multilangmgr.cc:119:39: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/mydiagonalcurve.cc:56:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Spline [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/mydiagonalcurve.cc:77:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Parametric [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/mydiagonalcurve.cc:167:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Parametric [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/mydiagonalcurve.cc:269:82: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable STATE_FLAG_NORMAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/mydiagonalcurve.cc:575:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Parametric [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/mydiagonalcurve.cc:1034:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Linear [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/mydiagonalcurve.cc:1089:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Parametric [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/mydiagonalcurve.cc:1164:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Parametric [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/mydiagonalcurve.cc:1189:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Parametric [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/mydiagonalcurve.cc:1311:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MOTION_NOTIFY [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/mydiagonalcurve.cc:1380:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Parametric [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/mydiagonalcurve.cc:1404:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Parametric [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/mydiagonalcurve.cc:1441:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Parametric [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/myflatcurve.cc:67:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FCT_MinMaxCPoints [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/myflatcurve.cc:148:82: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable STATE_FLAG_NORMAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/myflatcurve.cc:641:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_CONTROL_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/myflatcurve.cc:1239:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BUTTON_PRESS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/myflatcurve.cc:1278:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BUTTON_PRESS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/myflatcurve.cc:1364:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BUTTON_PRESS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/myflatcurve.cc:1607:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MOTION_NOTIFY [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/myflatcurve.cc:1753:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FCT_Linear [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/myflatcurve.cc:1781:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FCT_MinMaxCPoints [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/myflatcurve.cc:462:45: style: Condition 'i==edited_point' is always false [knownConditionTrueFalse] rawtherapee-5.12/rtgui/myflatcurve.cc:1598:109: style:inconclusive: Function 'getCursorPosition' argument 5 names different: declaration 'modifier' definition 'modifierKey'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/myflatcurve.h:106:100: note: Function 'getCursorPosition' argument 5 names different: declaration 'modifier' definition 'modifierKey'. rawtherapee-5.12/rtgui/myflatcurve.cc:1598:109: note: Function 'getCursorPosition' argument 5 names different: declaration 'modifier' definition 'modifierKey'. rawtherapee-5.12/rtgui/myflatcurve.cc:1316:12: style: Variable 'num' is assigned a value that is never used. [unreadVariable] rawtherapee-5.12/rtgui/navigator.cc:93:53: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/navigator.cc:348:142: style:inconclusive: Function 'pointerMoved' argument 8 names different: declaration 'raw' definition 'isRaw'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/navigator.h:64:134: note: Function 'pointerMoved' argument 8 names different: declaration 'raw' definition 'isRaw'. rawtherapee-5.12/rtgui/navigator.cc:348:142: note: Function 'pointerMoved' argument 8 names different: declaration 'raw' definition 'isRaw'. rawtherapee-5.12/rtgui/options.cc:80:72: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_EXISTS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/options.cc:91:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_EXISTS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/options.cc:164:78: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_EXISTS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/options.cc:268:59: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_EXISTS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/options.cc:355:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SORT_ASCENDING [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/options.cc:744:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LC_NUMERIC [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/options.cc:2439:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RTVERSION [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/options.cc:2906:92: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CACHEFOLDERNAME [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/options.h:56:5: warning: Member variable 'ExternalEditor::native_command' is not initialized in the constructor. [uninitMemberVar] rawtherapee-5.12/rtgui/options.cc:89:15: performance:inconclusive: Technically the member function 'Options::checkDirPath' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtgui/options.h:168:10: note: Technically the member function 'Options::checkDirPath' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtgui/options.cc:89:15: note: Technically the member function 'Options::checkDirPath' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtgui/options.cc:2394:15: performance:inconclusive: Technically the member function 'Options::safeDirGet' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtgui/options.h:183:10: note: Technically the member function 'Options::safeDirGet' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtgui/options.cc:2394:15: note: Technically the member function 'Options::safeDirGet' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtgui/options.cc:3122:24: style:inconclusive: Technically the member function 'Options::getUserProfilePath' can be const. [functionConst] rawtherapee-5.12/rtgui/options.h:536:19: note: Technically the member function 'Options::getUserProfilePath' can be const. rawtherapee-5.12/rtgui/options.cc:3122:24: note: Technically the member function 'Options::getUserProfilePath' can be const. rawtherapee-5.12/rtgui/options.cc:3127:24: style:inconclusive: Technically the member function 'Options::getGlobalProfilePath' can be const. [functionConst] rawtherapee-5.12/rtgui/options.h:537:19: note: Technically the member function 'Options::getGlobalProfilePath' can be const. rawtherapee-5.12/rtgui/options.cc:3127:24: note: Technically the member function 'Options::getGlobalProfilePath' can be const. rawtherapee-5.12/rtgui/options.cc:3076:15: style:inconclusive: Technically the member function 'Options::is_parse_extention' can be const. [functionConst] rawtherapee-5.12/rtgui/options.h:539:10: note: Technically the member function 'Options::is_parse_extention' can be const. rawtherapee-5.12/rtgui/options.cc:3076:15: note: Technically the member function 'Options::is_parse_extention' can be const. rawtherapee-5.12/rtgui/options.cc:3097:15: style:inconclusive: Technically the member function 'Options::has_retained_extention' can be const. [functionConst] rawtherapee-5.12/rtgui/options.h:540:10: note: Technically the member function 'Options::has_retained_extention' can be const. rawtherapee-5.12/rtgui/options.cc:3097:15: note: Technically the member function 'Options::has_retained_extention' can be const. rawtherapee-5.12/rtgui/options.cc:3103:15: style:inconclusive: Technically the member function 'Options::is_new_version' can be const. [functionConst] rawtherapee-5.12/rtgui/options.h:541:10: note: Technically the member function 'Options::is_new_version' can be const. rawtherapee-5.12/rtgui/options.cc:3103:15: note: Technically the member function 'Options::is_new_version' can be const. rawtherapee-5.12/rtgui/options.cc:3117:15: style:inconclusive: Technically the member function 'Options::is_extention_enabled' can be const. [functionConst] rawtherapee-5.12/rtgui/options.h:542:10: note: Technically the member function 'Options::is_extention_enabled' can be const. rawtherapee-5.12/rtgui/options.cc:3117:15: note: Technically the member function 'Options::is_extention_enabled' can be const. rawtherapee-5.12/rtgui/options.cc:3132:15: style:inconclusive: Technically the member function 'Options::is_defProfRawMissing' can be const. [functionConst] rawtherapee-5.12/rtgui/options.h:543:10: note: Technically the member function 'Options::is_defProfRawMissing' can be const. rawtherapee-5.12/rtgui/options.cc:3132:15: note: Technically the member function 'Options::is_defProfRawMissing' can be const. rawtherapee-5.12/rtgui/options.cc:3156:15: style:inconclusive: Technically the member function 'Options::is_bundledDefProfRawMissing' can be const. [functionConst] rawtherapee-5.12/rtgui/options.h:544:10: note: Technically the member function 'Options::is_bundledDefProfRawMissing' can be const. rawtherapee-5.12/rtgui/options.cc:3156:15: note: Technically the member function 'Options::is_bundledDefProfRawMissing' can be const. rawtherapee-5.12/rtgui/options.cc:3136:15: style:inconclusive: Technically the member function 'Options::is_defProfImgMissing' can be const. [functionConst] rawtherapee-5.12/rtgui/options.h:545:10: note: Technically the member function 'Options::is_defProfImgMissing' can be const. rawtherapee-5.12/rtgui/options.cc:3136:15: note: Technically the member function 'Options::is_defProfImgMissing' can be const. rawtherapee-5.12/rtgui/options.cc:3160:15: style:inconclusive: Technically the member function 'Options::is_bundledDefProfImgMissing' can be const. [functionConst] rawtherapee-5.12/rtgui/options.h:546:10: note: Technically the member function 'Options::is_bundledDefProfImgMissing' can be const. rawtherapee-5.12/rtgui/options.cc:3160:15: note: Technically the member function 'Options::is_bundledDefProfImgMissing' can be const. rawtherapee-5.12/rtgui/options.cc:724:37: style: Parameter 'other' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtgui/options.cc:1296:48: performance: Searching before insertion is not necessary. Instead of 'checkedExtensions[i]=1' consider using 'checkedExtensions.try_emplace(i, 1);'. [stlFindInsert] rawtherapee-5.12/rtgui/options.cc:3085:44: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/options.cc:3108:16: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/partialpastedlg.cc:39:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/partialpastedlg.cc:326:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/partialpastedlg.cc:1307:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AllSelection [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/partialpastedlg.cc:126:16: style: Variable 'spot' can be declared as reference to const [constVariableReference] rawtherapee-5.12/rtgui/partialpastedlg.cc:167:16: style: Variable 'spot' can be declared as reference to const [constVariableReference] rawtherapee-5.12/rtgui/partialpastedlg.cc:127:18: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/partialpastedlg.cc:169:13: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/pcvignette.cc:89:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvPCVignetteStrength [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/pdsharpening.cc:42:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CAPTURESHARPEN [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/perspective.cc:76:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/perspective.cc:94:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TRANSFORM [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/perspective.cc:376:70: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DEFAULT_CAMERA_CROP_FACTOR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/perspective.cc:436:61: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DEFAULT_CAMERA_CROP_FACTOR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/perspective.cc:720:53: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DEFAULT_CAMERA_CROP_FACTOR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/placesbrowser.cc:34:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/placesbrowser.cc:399:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_USER_DIRECTORY_PICTURES [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/placesbrowser.cc:263:69: style:inconclusive: Function 'volumeChanged' argument 1 names different: declaration 'v' definition 'm'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/placesbrowser.h:69:58: note: Function 'volumeChanged' argument 1 names different: declaration 'v' definition 'm'. rawtherapee-5.12/rtgui/placesbrowser.cc:263:69: note: Function 'volumeChanged' argument 1 names different: declaration 'v' definition 'm'. rawtherapee-5.12/rtgui/placesbrowser.cc:269:67: style:inconclusive: Function 'driveChanged' argument 1 names different: declaration 'd' definition 'm'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/placesbrowser.h:70:56: note: Function 'driveChanged' argument 1 names different: declaration 'd' definition 'm'. rawtherapee-5.12/rtgui/placesbrowser.cc:269:67: note: Function 'driveChanged' argument 1 names different: declaration 'd' definition 'm'. rawtherapee-5.12/rtgui/placesbrowser.cc:286:87: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/placesbrowser.cc:294:86: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/popupbutton.cc:63:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_SHIFT_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/popupbutton.cc:42:19: warning: The class 'PopUpButton' defines member function with name 'show' also defined in its parent class 'PopUpCommon'. [duplInheritedMember] rawtherapee-5.12/rtgui/popupcommon.h:75:10: note: Parent function 'PopUpCommon::show' rawtherapee-5.12/rtgui/popupbutton.cc:42:19: note: Derived function 'PopUpButton::show' rawtherapee-5.12/rtgui/popupbutton.cc:46:19: warning: The class 'PopUpButton' defines member function with name 'set_tooltip_text' also defined in its parent class 'PopUpCommon'. [duplInheritedMember] rawtherapee-5.12/rtgui/popupcommon.h:76:10: note: Parent function 'PopUpCommon::set_tooltip_text' rawtherapee-5.12/rtgui/popupbutton.cc:46:19: note: Derived function 'PopUpButton::set_tooltip_text' rawtherapee-5.12/rtgui/popupcommon.cc:38:81: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ALIGN_CENTER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/popupcommon.cc:98:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ICON_SIZE_BUTTON [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/popupcommon.cc:200:56: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ICON_SIZE_BUTTON [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/popuptogglebutton.cc:34:25: warning: The class 'PopUpToggleButton' defines member function with name 'show' also defined in its parent class 'PopUpCommon'. [duplInheritedMember] rawtherapee-5.12/rtgui/popupcommon.h:75:10: note: Parent function 'PopUpCommon::show' rawtherapee-5.12/rtgui/popuptogglebutton.cc:34:25: note: Derived function 'PopUpToggleButton::show' rawtherapee-5.12/rtgui/popuptogglebutton.cc:38:25: warning: The class 'PopUpToggleButton' defines member function with name 'set_tooltip_text' also defined in its parent class 'PopUpCommon'. [duplInheritedMember] rawtherapee-5.12/rtgui/popupcommon.h:76:10: note: Parent function 'PopUpCommon::set_tooltip_text' rawtherapee-5.12/rtgui/popuptogglebutton.cc:38:25: note: Derived function 'PopUpToggleButton::set_tooltip_text' rawtherapee-5.12/rtgui/popupcommon.cc:30:40: style:inconclusive: Function 'PopUpCommon' argument 1 names different: declaration 'button' definition 'thisButton'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/popupcommon.h:63:40: note: Function 'PopUpCommon' argument 1 names different: declaration 'button' definition 'thisButton'. rawtherapee-5.12/rtgui/popupcommon.cc:30:40: note: Function 'PopUpCommon' argument 1 names different: declaration 'button' definition 'thisButton'. rawtherapee-5.12/rtgui/popupcommon.cc:78:50: style:inconclusive: Function 'addEntry' argument 1 names different: declaration 'iconName' definition 'fileName'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/popupcommon.h:65:41: note: Function 'addEntry' argument 1 names different: declaration 'iconName' definition 'fileName'. rawtherapee-5.12/rtgui/popupcommon.cc:78:50: note: Function 'addEntry' argument 1 names different: declaration 'iconName' definition 'fileName'. rawtherapee-5.12/rtgui/popupcommon.cc:206:46: style:inconclusive: Function 'entrySelected' argument 1 names different: declaration 'menuItem' definition 'widget'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/popupcommon.h:99:37: note: Function 'entrySelected' argument 1 names different: declaration 'menuItem' definition 'widget'. rawtherapee-5.12/rtgui/popupcommon.cc:206:46: note: Function 'entrySelected' argument 1 names different: declaration 'menuItem' definition 'widget'. rawtherapee-5.12/rtgui/popupcommon.cc:238:43: style:inconclusive: Function 'setItemSensitivity' argument 1 names different: declaration 'i' definition 'index'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/popupcommon.h:77:34: note: Function 'setItemSensitivity' argument 1 names different: declaration 'i' definition 'index'. rawtherapee-5.12/rtgui/popupcommon.cc:238:43: note: Function 'setItemSensitivity' argument 1 names different: declaration 'i' definition 'index'. rawtherapee-5.12/rtgui/popupcommon.cc:206:46: style: Parameter 'widget' can be declared as pointer to const. However it seems that 'entrySelected' is a callback function, if 'widget' is declared with const you might also need to cast function pointer(s). [constParameterCallback] rawtherapee-5.12/rtgui/popupcommon.cc:135:75: note: You might need to cast the function pointer here rawtherapee-5.12/rtgui/popupcommon.cc:206:46: note: Parameter 'widget' can be declared as pointer to const rawtherapee-5.12/rtgui/popupcommon.cc:294:14: style: Variable 'item' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/preprocess.cc:44:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PACK_SHRINK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/preprocess.cc:99:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvPreProcessHotDeadThresh [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/preprocess.cc:120:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvPreProcessHotPixel [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/preprocess.cc:140:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvPreProcessDeadPixel [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/preferences.cc:51:81: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ALIGN_START [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/preferences.cc:98:59: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SCALE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/preferences.cc:167:57: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable POLICY_AUTOMATIC [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/preferences.cc:542:61: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable POLICY_NEVER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/preferences.cc:551:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable POLICY_AUTOMATIC [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/preferences.cc:563:63: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable POLICY_AUTOMATIC [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/preferences.cc:806:59: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable POLICY_AUTOMATIC [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/preferences.cc:902:56: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable POLICY_AUTOMATIC [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/preferences.cc:1087:55: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable POLICY_AUTOMATIC [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/preferences.cc:1450:59: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable POLICY_AUTOMATIC [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/preferences.cc:1718:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable POLICY_AUTOMATIC [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/preferences.cc:1790:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_IS_DIR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/preferences.cc:1819:77: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_IS_DIR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/preferences.cc:1883:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SCALE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/preferences.cc:2155:65: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_IS_DIR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/preferences.cc:2419:74: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SCALE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/preferences.cc:2467:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PSET_FOLDER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/preferences.cc:2490:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PSET_FOLDER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/preferences.cc:2589:70: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_STYLE_PROVIDER_PRIORITY_USER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/preferences.cc:2605:58: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SCALE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/preferences.cc:2620:69: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_STYLE_PROVIDER_PRIORITY_USER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/preprocesswb.cc:40:86: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PACK_SHRINK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/previewhandler.cc:179:86: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable INTERP_NEAREST [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/previewhandler.cc:197:129: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable INTERP_BILINEAR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/previewhandler.cc:212:50: style:inconclusive: Either there is a missing 'override', or the member function 'PreviewHandler::getCropParams' can be const. [functionConst] rawtherapee-5.12/rtgui/previewhandler.h:86:41: note: Either there is a missing 'override', or the member function 'PreviewHandler::getCropParams' can be const. rawtherapee-5.12/rtgui/previewhandler.cc:212:50: note: Either there is a missing 'override', or the member function 'PreviewHandler::getCropParams' can be const. rawtherapee-5.12/rtgui/previewhandler.cc:52:50: style:inconclusive: Function 'setImage' argument 1 names different: declaration 'img' definition 'i'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/previewhandler.h:76:38: note: Function 'setImage' argument 1 names different: declaration 'img' definition 'i'. rawtherapee-5.12/rtgui/previewhandler.cc:52:50: note: Function 'setImage' argument 1 names different: declaration 'img' definition 'i'. rawtherapee-5.12/rtgui/previewhandler.cc:89:40: style:inconclusive: Function 'delImage' argument 1 names different: declaration 'img' definition 'i'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/previewhandler.h:77:38: note: Function 'delImage' argument 1 names different: declaration 'img' definition 'i'. rawtherapee-5.12/rtgui/previewhandler.cc:89:40: note: Function 'delImage' argument 1 names different: declaration 'img' definition 'i'. rawtherapee-5.12/rtgui/previewhandler.cc:185:94: style:inconclusive: Function 'getRoughImage' argument 3 names different: declaration 'zoom' definition 'zoom_'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/previewhandler.h:85:92: note: Function 'getRoughImage' argument 3 names different: declaration 'zoom' definition 'zoom_'. rawtherapee-5.12/rtgui/previewhandler.cc:185:94: note: Function 'getRoughImage' argument 3 names different: declaration 'zoom' definition 'zoom_'. rawtherapee-5.12/rtgui/preferences.cc:194:22: style: Local variable 'addc' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/preferences.h:259:52: note: Shadowed declaration rawtherapee-5.12/rtgui/preferences.cc:194:22: note: Shadow variable rawtherapee-5.12/rtgui/preferences.cc:197:22: style: Local variable 'setc' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/preferences.h:259:58: note: Shadowed declaration rawtherapee-5.12/rtgui/preferences.cc:197:22: note: Shadow variable rawtherapee-5.12/rtgui/preferences.cc:2678:15: style: Variable 'editors' can be declared as reference to const [constVariableReference] rawtherapee-5.12/rtgui/preferences.cc:2679:15: style: Variable 'meditors' can be declared as reference to const [constVariableReference] rawtherapee-5.12/rtgui/preferences.cc:2201:21: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/preferences.cc:2718:53: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/previewloader.cc:130:57: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_EXISTS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/previewloader.cc:141:31: style: Variable 'e' can be declared as reference to const [constVariableReference] rawtherapee-5.12/rtgui/previewmodepanel.cc:38:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RELIEF_NONE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/previewmodepanel.cc:167:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ICON_SIZE_LARGE_TOOLBAR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/previewmodepanel.cc:266:58: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ICON_SIZE_LARGE_TOOLBAR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/previewwindow.cc:41:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable POINTER_MOTION_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/previewwindow.cc:69:74: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FORMAT_ARGB32 [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/previewwindow.cc:168:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LINE_JOIN_MITER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/previewwindow.cc:305:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SIZE_REQUEST_CONSTANT_SIZE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/previewwindow.cc:120:50: style: Parameter 'req' can be declared as reference to const. However it seems that 'on_resized' is a callback function, if 'req' is declared with const you might also need to cast function pointer(s). [constParameterCallback] rawtherapee-5.12/rtgui/previewwindow.cc:34:82: note: You might need to cast the function pointer here rawtherapee-5.12/rtgui/previewwindow.cc:120:50: note: Parameter 'req' can be declared as reference to const rawtherapee-5.12/rtgui/profilepanel.cc:65:77: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ALIGN_FILL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/profilepanel.cc:179:94: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PSET_FILE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/profilepanel.cc:192:100: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PSET_FILE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/profilepanel.cc:298:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CONTROL_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/profilepanel.cc:432:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CONTROL_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/profilepanel.cc:469:99: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_CHOOSER_ACTION_OPEN [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/profilepanel.cc:665:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CONTROL_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/profilepanel.cc:738:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvProfileChanged [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/profilepanel.cc:754:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PSET_FOLDER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/profilepanel.cc:793:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvProfileChanged [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/profilepanel.cc:887:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvPhotoLoaded [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/profilepanel.cc:786:45: style:inconclusive: Function 'procParamsChanged' argument 1 names different: declaration 'params' definition 'p'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/profilepanel.h:117:49: note: Function 'procParamsChanged' argument 1 names different: declaration 'params' definition 'p'. rawtherapee-5.12/rtgui/profilepanel.cc:786:45: note: Function 'procParamsChanged' argument 1 names different: declaration 'params' definition 'p'. rawtherapee-5.12/rtgui/profilepanel.cc:730:73: performance:inconclusive: Function parameter 'profname' should be passed by const reference. [passedByValue] rawtherapee-5.12/rtgui/profilestorecombobox.cc:30:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ELLIPSIZE_END [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/profilestorecombobox.cc:69:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PSET_FOLDER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/profilestorecombobox.cc:143:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ELLIPSIZE_MIDDLE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/profilestorecombobox.cc:155:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PSET_FOLDER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/profilestorecombobox.cc:190:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PSET_FOLDER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/profilestorecombobox.cc:273:75: style:inconclusive: Function 'setActiveRowFromFullPath' argument 1 names different: declaration 'oldPath' definition 'path'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/profilestorecombobox.h:84:57: note: Function 'setActiveRowFromFullPath' argument 1 names different: declaration 'oldPath' definition 'path'. rawtherapee-5.12/rtgui/profilestorecombobox.cc:273:75: note: Function 'setActiveRowFromFullPath' argument 1 names different: declaration 'oldPath' definition 'path'. rawtherapee-5.12/rtgui/prsharpening.cc:32:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RESIZE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/prsharpening.cc:334:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvPrShrAmount [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/prsharpening.cc:453:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvPrShrMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/prsharpening.cc:474:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvPrShrThresh [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/rawcacorrection.cc:36:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DARKFRAME [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/rawcacorrection.cc:136:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvPreProcessCARed [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/rawcacorrection.cc:153:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvPreProcessAutoCA [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/recentbrowser.cc:27:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/rawexposure.cc:41:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PACK_SHRINK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/rawexposure.cc:74:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvPreProcessExpCorrLinear [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/renamedlg.cc:30:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ALIGN_START [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/resize.cc:37:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RESIZE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/resize.cc:385:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvResizeAppliesTo [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/resize.cc:393:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvResizeMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/resize.cc:771:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PACK_SHRINK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/resize.cc:426:30: style:inconclusive: Function 'sizeChanged' argument 1 names different: declaration 'w' definition 'mw'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/resize.h:56:32: note: Function 'sizeChanged' argument 1 names different: declaration 'w' definition 'mw'. rawtherapee-5.12/rtgui/resize.cc:426:30: note: Function 'sizeChanged' argument 1 names different: declaration 'w' definition 'mw'. rawtherapee-5.12/rtgui/resize.cc:426:38: style:inconclusive: Function 'sizeChanged' argument 2 names different: declaration 'h' definition 'mh'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/resize.h:56:39: note: Function 'sizeChanged' argument 2 names different: declaration 'h' definition 'mh'. rawtherapee-5.12/rtgui/resize.cc:426:38: note: Function 'sizeChanged' argument 2 names different: declaration 'h' definition 'mh'. rawtherapee-5.12/rtgui/retinex.cc:32:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DEMOSAIC [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/retinex.cc:1136:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvretinexMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/retinex.cc:1171:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvmapMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/retinex.cc:1223:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvviewMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/retinex.cc:1253:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvretinexColorSpace [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/retinex.cc:1272:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Evretinexgamma [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/retinex.cc:1405:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvLneigh [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/rgbcurves.cc:41:66: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_HORIZONTAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/rgbcurves.cc:209:17: performance:inconclusive: Either there is a missing 'override', or the member function 'RGBCurves::updateCurveBackgroundHistogram' can be static. [functionStatic] rawtherapee-5.12/rtgui/rgbcurves.h:60:10: note: Either there is a missing 'override', or the member function 'RGBCurves::updateCurveBackgroundHistogram' can be static. rawtherapee-5.12/rtgui/rgbcurves.cc:209:17: note: Either there is a missing 'override', or the member function 'RGBCurves::updateCurveBackgroundHistogram' can be static. rawtherapee-5.12/rtgui/rotate.cc:50:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PACK_SHRINK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/rtsurface.cc:37:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ICON_SIZE_INVALID [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/rtsurface.cc:155:17: style:inconclusive: Technically the member function 'RTSurface::hasSurface' can be const. [functionConst] rawtherapee-5.12/rtgui/rtsurface.h:52:10: note: Technically the member function 'RTSurface::hasSurface' can be const. rawtherapee-5.12/rtgui/rtsurface.cc:155:17: note: Technically the member function 'RTSurface::hasSurface' can be const. rawtherapee-5.12/rtgui/rtsurface.cc:91:9: style: The scope of the variable 'w' can be reduced. [variableScope] rawtherapee-5.12/rtgui/rtsurface.cc:91:12: style: The scope of the variable 'h' can be reduced. [variableScope] rawtherapee-5.12/rtgui/rtsurface.cc:124:9: style: The scope of the variable 'w' can be reduced. [variableScope] rawtherapee-5.12/rtgui/rtsurface.cc:124:12: style: The scope of the variable 'h' can be reduced. [variableScope] rawtherapee-5.12/rtgui/rtscalable.cc:74:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/rtscalable.cc:127:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_EXISTS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/rtscalable.cc:154:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_EXISTS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/rtsurface.cc:98:27: style: Variable 'h' is assigned a value that is never used. [unreadVariable] rawtherapee-5.12/rtgui/rtsurface.cc:131:23: style: Variable 'w' is assigned a value that is never used. [unreadVariable] rawtherapee-5.12/rtgui/rtscalable.cc:167:56: style: C-style pointer casting [cstyleCast] rawtherapee-5.12/rtgui/rtscalable.cc:50:89: style:inconclusive: Function 'loadSurfaceFromIcon' argument 1 names different: declaration 'icon_name' definition 'iconName'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/rtscalable.h:60:88: note: Function 'loadSurfaceFromIcon' argument 1 names different: declaration 'icon_name' definition 'iconName'. rawtherapee-5.12/rtgui/rtscalable.cc:50:89: note: Function 'loadSurfaceFromIcon' argument 1 names different: declaration 'icon_name' definition 'iconName'. rawtherapee-5.12/rtgui/rtscalable.cc:63:23: style: Variable 'hSize' is assigned a value that is never used. [unreadVariable] rawtherapee-5.12/rtgui/saveasdlg.cc:39:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_IS_DIR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/saveasdlg.cc:53:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_CHOOSER_ACTION_SAVE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/saveasdlg.cc:294:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RESPONSE_OK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/saveasdlg.cc:306:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RESPONSE_CANCEL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/saveasdlg.cc:367:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_CONTROL_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/saveasdlg.cc:222:29: style:inconclusive: Either there is a missing 'override', or the member function 'SaveAsDialog::getFileName' can be const. [functionConst] rawtherapee-5.12/rtgui/saveasdlg.h:50:21: note: Either there is a missing 'override', or the member function 'SaveAsDialog::getFileName' can be const. rawtherapee-5.12/rtgui/saveasdlg.cc:222:29: note: Either there is a missing 'override', or the member function 'SaveAsDialog::getFileName' can be const. rawtherapee-5.12/rtgui/saveasdlg.cc:348:61: style:inconclusive: Function 'setInitialFileName' argument 1 names different: declaration 'iname' definition 'fname'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/saveasdlg.h:60:52: note: Function 'setInitialFileName' argument 1 names different: declaration 'iname' definition 'fname'. rawtherapee-5.12/rtgui/saveasdlg.cc:348:61: note: Function 'setInitialFileName' argument 1 names different: declaration 'iname' definition 'fname'. rawtherapee-5.12/rtgui/rtwindow.cc:123:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_EXISTS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/rtwindow.cc:482:57: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_WINDOW_STATE_MAXIMIZED [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/rtwindow.cc:537:77: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ICON_SIZE_LARGE_TOOLBAR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/rtwindow.cc:632:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_CONTROL_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/rtwindow.cc:873:64: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_CURRENT_TIME [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/rtwindow.cc:1223:86: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ALIGN_CENTER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/saveformatpanel.cc:51:70: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ALIGN_CENTER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/saveformatpanel.cc:148:55: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable format [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/saveformatpanel.cc:176:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable second [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/saveformatpanel.cc:196:56: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable format [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/saveformatpanel.cc:226:58: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable format [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/rtwindow.cc:1187:16: style:inconclusive: Either there is a missing 'override', or the member function 'RTWindow::isEditorPanel' can be const. [functionConst] rawtherapee-5.12/rtgui/rtwindow.h:70:10: note: Either there is a missing 'override', or the member function 'RTWindow::isEditorPanel' can be const. rawtherapee-5.12/rtgui/rtwindow.cc:1187:16: note: Either there is a missing 'override', or the member function 'RTWindow::isEditorPanel' can be const. rawtherapee-5.12/rtgui/rtwindow.cc:247:17: style: Local variable 'error' shadows outer function [shadowFunction] rawtherapee-5.12/rtgui/rtwindow.h:110:10: note: Shadowed declaration rawtherapee-5.12/rtgui/rtwindow.cc:247:17: note: Shadow variable rawtherapee-5.12/rtgui/rtwindow.cc:782:26: style: Variable 'w' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/rtwindow.cc:850:26: style: Variable 'w' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/shadowshighlights.cc:33:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LUMINANCECURVE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/shadowshighlights.cc:164:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvSHHighlights [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/sharpenedge.cc:48:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PACK_SHRINK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/sharpenedge.cc:139:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvSharpenEdgePasses [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/sharpening.cc:31:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SHARPENING [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/sharpening.cc:338:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvShrAmount [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/sharpening.cc:377:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvShrThresh [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/sharpening.cc:485:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvShrMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/sharpenmicro.cc:38:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SHARPENING [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/sharpenmicro.cc:151:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvSharpenMicroAmount [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/shcselector.cc:38:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_STYLE_CLASS_TROUGH [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/shcselector.cc:50:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SIZE_REQUEST_CONSTANT_SIZE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/shcselector.cc:113:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable POINTER_MOTION_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/shcselector.cc:126:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable OPERATOR_OVER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/softlight.cc:37:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LUMINANCECURVE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/splash.cc:41:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ANTIALIAS_SUBPIXEL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/splash.cc:75:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SIZE_REQUEST_CONSTANT_SIZE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/splash.cc:110:55: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PACK_SHRINK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/spot.cc:75:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RELIEF_NONE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/spot.cc:227:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NORMAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/spot.cc:244:57: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PACK_SHRINK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/spot.cc:354:168: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DP_CENTERCENTER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/spot.cc:441:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NORMAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/spot.cc:494:72: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ACTIVE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/spot.cc:566:74: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ACTIVE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/spot.cc:614:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_CONTROL_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/spot.cc:646:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PRELIGHT [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/spot.cc:662:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_SHIFT_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/spot.cc:678:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_CONTROL_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/spot.cc:702:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ACTIVE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/spot.cc:734:96: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DRAGGED [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thresholdadjuster.cc:37:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thresholdadjuster.cc:50:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thresholdadjuster.cc:65:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thresholdadjuster.cc:89:60: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ALIGN_START [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thresholdadjuster.cc:168:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_CONTROL_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thresholdadjuster.cc:315:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PACK_SHRINK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thresholdadjuster.cc:321:25: performance:inconclusive: Either there is a missing 'override', or the member function 'ThresholdAdjuster::refreshLabelStyle' can be static. [functionStatic] rawtherapee-5.12/rtgui/thresholdadjuster.h:74:10: note: Either there is a missing 'override', or the member function 'ThresholdAdjuster::refreshLabelStyle' can be static. rawtherapee-5.12/rtgui/thresholdadjuster.cc:321:25: note: Either there is a missing 'override', or the member function 'ThresholdAdjuster::refreshLabelStyle' can be static. rawtherapee-5.12/rtgui/thresholdadjuster.cc:129:44: style:inconclusive: Function 'setDefault' argument 1 names different: declaration 'defBottom' definition 'bottom'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/thresholdadjuster.h:130:29: note: Function 'setDefault' argument 1 names different: declaration 'defBottom' definition 'bottom'. rawtherapee-5.12/rtgui/thresholdadjuster.cc:129:44: note: Function 'setDefault' argument 1 names different: declaration 'defBottom' definition 'bottom'. rawtherapee-5.12/rtgui/thresholdadjuster.cc:129:59: style:inconclusive: Function 'setDefault' argument 2 names different: declaration 'defTop' definition 'top'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/thresholdadjuster.h:130:47: note: Function 'setDefault' argument 2 names different: declaration 'defTop' definition 'top'. rawtherapee-5.12/rtgui/thresholdadjuster.cc:129:59: note: Function 'setDefault' argument 2 names different: declaration 'defTop' definition 'top'. rawtherapee-5.12/rtgui/thresholdadjuster.cc:137:44: style:inconclusive: Function 'setDefault' argument 1 names different: declaration 'defBottomLeft' definition 'bottomLeft'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/thresholdadjuster.h:131:29: note: Function 'setDefault' argument 1 names different: declaration 'defBottomLeft' definition 'bottomLeft'. rawtherapee-5.12/rtgui/thresholdadjuster.cc:137:44: note: Function 'setDefault' argument 1 names different: declaration 'defBottomLeft' definition 'bottomLeft'. rawtherapee-5.12/rtgui/thresholdadjuster.cc:137:63: style:inconclusive: Function 'setDefault' argument 2 names different: declaration 'defTopLeft' definition 'topLeft'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/thresholdadjuster.h:131:51: note: Function 'setDefault' argument 2 names different: declaration 'defTopLeft' definition 'topLeft'. rawtherapee-5.12/rtgui/thresholdadjuster.cc:137:63: note: Function 'setDefault' argument 2 names different: declaration 'defTopLeft' definition 'topLeft'. rawtherapee-5.12/rtgui/thresholdadjuster.cc:137:79: style:inconclusive: Function 'setDefault' argument 3 names different: declaration 'defBottomRight' definition 'bottomRight'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/thresholdadjuster.h:131:70: note: Function 'setDefault' argument 3 names different: declaration 'defBottomRight' definition 'bottomRight'. rawtherapee-5.12/rtgui/thresholdadjuster.cc:137:79: note: Function 'setDefault' argument 3 names different: declaration 'defBottomRight' definition 'bottomRight'. rawtherapee-5.12/rtgui/thresholdadjuster.cc:137:99: style:inconclusive: Function 'setDefault' argument 4 names different: declaration 'defTopRight' definition 'topRight'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/thresholdadjuster.h:131:93: note: Function 'setDefault' argument 4 names different: declaration 'defTopRight' definition 'topRight'. rawtherapee-5.12/rtgui/thresholdadjuster.cc:137:99: note: Function 'setDefault' argument 4 names different: declaration 'defTopRight' definition 'topRight'. rawtherapee-5.12/rtgui/spot.cc:335:14: style: The comparison 'i == MO_TARGET_DISK' is always true because 'i' and 'MO_TARGET_DISK' represent the same value. [knownConditionTrueFalse] rawtherapee-5.12/rtgui/spot.cc:334:16: note: 'i' is assigned value '0' here. rawtherapee-5.12/rtgui/spot.cc:335:14: note: The comparison 'i == MO_TARGET_DISK' is always true because 'i' and 'MO_TARGET_DISK' represent the same value. rawtherapee-5.12/rtgui/spot.cc:362:14: style: Same expression on both sides of '-' because 'j' and 'visibleOffset' represent the same value. [duplicateExpression] rawtherapee-5.12/rtgui/spot.cc:361:25: note: 'visibleOffset' is assigned value 'j' here. rawtherapee-5.12/rtgui/spot.cc:362:14: note: Same expression on both sides of '-' because 'j' and 'visibleOffset' represent the same value. rawtherapee-5.12/rtgui/spot.cc:662:42: style: Same expression on both sides of '|'. [duplicateExpression] rawtherapee-5.12/rtgui/spot.cc:684:49: style: Same expression on both sides of '|'. [duplicateExpression] rawtherapee-5.12/rtgui/spot.cc:480:23: style: Variable 'editProvider' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/spot.cc:561:23: style: Variable 'editProvider' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/spot.cc:656:23: style: Variable 'editProvider' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/spot.cc:672:23: style: Variable 'editProvider' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/spot.cc:694:15: style: Variable 'loGeom' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/spot.cc:722:15: style: Variable 'loGeom' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/spot.cc:805:15: style: Variable 'loGeom' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/spot.cc:832:23: style: Variable 'editProvider' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/spot.cc:510:15: style: Consider using std::distance algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/thresholdselector.cc:36:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TS_BOTTOMLEFT [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thresholdselector.cc:60:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TS_BOTTOMLEFT [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thresholdselector.cc:97:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TS_BOTTOMLEFT [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thresholdselector.cc:144:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_STYLE_CLASS_TROUGH [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thresholdselector.cc:156:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SIZE_REQUEST_CONSTANT_SIZE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thresholdselector.cc:210:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TS_TOPLEFT [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thresholdselector.cc:233:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TS_BOTTOMLEFT [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thresholdselector.cc:246:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable POINTER_MOTION_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thresholdselector.cc:261:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable OPERATOR_OVER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thresholdselector.cc:493:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TS_BOTTOMLEFT [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thresholdselector.cc:563:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TS_TOPLEFT [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thresholdselector.cc:594:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TS_BOTTOMLEFT [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thresholdselector.cc:655:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SHIFT_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thresholdselector.cc:703:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TS_BOTTOMLEFT [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thresholdselector.cc:740:144: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TS_TOPLEFT [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thresholdselector.cc:783:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TS_BOTTOMLEFT [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thresholdselector.cc:776:39: style:inconclusive: Either there is a missing 'override', or the member function 'ThresholdSelector::signal_value_changed' can be const. [functionConst] rawtherapee-5.12/rtgui/thresholdselector.h:133:24: note: Either there is a missing 'override', or the member function 'ThresholdSelector::signal_value_changed' can be const. rawtherapee-5.12/rtgui/thresholdselector.cc:776:39: note: Either there is a missing 'override', or the member function 'ThresholdSelector::signal_value_changed' can be const. rawtherapee-5.12/rtgui/thresholdselector.cc:728:25: style:inconclusive: Either there is a missing 'override', or the member function 'ThresholdSelector::getSeparatedSliders' can be const. [functionConst] rawtherapee-5.12/rtgui/thresholdselector.h:211:10: note: Either there is a missing 'override', or the member function 'ThresholdSelector::getSeparatedSliders' can be const. rawtherapee-5.12/rtgui/thresholdselector.cc:728:25: note: Either there is a missing 'override', or the member function 'ThresholdSelector::getSeparatedSliders' can be const. rawtherapee-5.12/rtgui/thumbbrowserbase.cc:38:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_HORIZONTAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbbrowserbase.cc:99:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_SCROLL_SMOOTH [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbbrowserbase.cc:136:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_SCROLL_UP [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbbrowserbase.cc:569:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TB_Horizontal [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbbrowserbase.cc:639:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TB_Horizontal [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbbrowserbase.cc:832:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable STATE_FLAG_NORMAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbbrowserbase.cc:842:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ANTIALIAS_SUBPIXEL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbbrowserbase.cc:966:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_BUTTON_PRESS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbbrowserbase.cc:1004:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ANTIALIAS_NONE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbbrowserbase.cc:1029:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SIZE_REQUEST_CONSTANT_SIZE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbbrowserbase.cc:1212:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable THLOC_FILEBROWSER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbbrowserentrybase.cc:231:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ANTIALIAS_SUBPIXEL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbbrowserentrybase.cc:446:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WEIGHT_BOLD [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbbrowserentrybase.cc:510:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WFNAME_NONE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbbrowserentrybase.cc:576:69: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RT_PI [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbbrowserentrybase.cc:175:12: warning: Class 'ThumbBrowserEntryBase' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] rawtherapee-5.12/rtgui/thumbbrowserentrybase.cc:175:12: warning: Class 'ThumbBrowserEntryBase' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] rawtherapee-5.12/rtgui/thumbbrowserentrybase.cc:429:48: style:inconclusive: Function 'getTextSizes' argument 1 names different: declaration 'w' definition 'infow'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/thumbbrowserentrybase.h:94:29: note: Function 'getTextSizes' argument 1 names different: declaration 'w' definition 'infow'. rawtherapee-5.12/rtgui/thumbbrowserentrybase.cc:429:48: note: Function 'getTextSizes' argument 1 names different: declaration 'w' definition 'infow'. rawtherapee-5.12/rtgui/thumbbrowserentrybase.cc:429:60: style:inconclusive: Function 'getTextSizes' argument 2 names different: declaration 'h' definition 'infoh'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/thumbbrowserentrybase.h:94:37: note: Function 'getTextSizes' argument 2 names different: declaration 'h' definition 'infoh'. rawtherapee-5.12/rtgui/thumbbrowserentrybase.cc:429:60: note: Function 'getTextSizes' argument 2 names different: declaration 'h' definition 'infoh'. rawtherapee-5.12/rtgui/thumbbrowserentrybase.cc:569:70: style:inconclusive: Function 'drawFrame' argument 1 names different: declaration 'cr' definition 'cc'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/thumbbrowserentrybase.h:93:51: note: Function 'drawFrame' argument 1 names different: declaration 'cr' definition 'cc'. rawtherapee-5.12/rtgui/thumbbrowserentrybase.cc:569:70: note: Function 'drawFrame' argument 1 names different: declaration 'cr' definition 'cc'. rawtherapee-5.12/rtgui/thumbbrowserentrybase.cc:622:29: warning: Uninitialized variable: bbWidth [uninitvar] rawtherapee-5.12/rtgui/thumbbrowserentrybase.cc:616:9: note: Assuming condition is false rawtherapee-5.12/rtgui/thumbbrowserentrybase.cc:622:29: note: Uninitialized variable: bbWidth rawtherapee-5.12/rtgui/thumbbrowserentrybase.cc:622:54: warning: Uninitialized variable: bbHeight [uninitvar] rawtherapee-5.12/rtgui/thumbbrowserentrybase.cc:616:9: note: Assuming condition is false rawtherapee-5.12/rtgui/thumbbrowserentrybase.cc:622:54: note: Uninitialized variable: bbHeight rawtherapee-5.12/rtgui/thumbbrowserbase.cc:1013:53: style: Condition '!dirty' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtgui/thumbbrowserbase.cc:997:13: note: Assignment 'dirty=false', assigned value is 0 rawtherapee-5.12/rtgui/thumbbrowserbase.cc:1013:53: note: Condition '!dirty' is always true rawtherapee-5.12/rtgui/thumbbrowserbase.cc:1167:9: style: Local variable 'previewHeight' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/thumbbrowserbase.h:181:9: note: Shadowed declaration rawtherapee-5.12/rtgui/thumbbrowserbase.cc:1167:9: note: Shadow variable rawtherapee-5.12/rtgui/thumbbrowserbase.cc:552:62: style: Parameter 'req' can be declared as reference to const. However it seems that 'internalAreaResized' is a callback function, if 'req' is declared with const you might also need to cast function pointer(s). [constParameterCallback] rawtherapee-5.12/rtgui/thumbbrowserbase.cc:57:86: note: You might need to cast the function pointer here rawtherapee-5.12/rtgui/thumbbrowserbase.cc:552:62: note: Parameter 'req' can be declared as reference to const rawtherapee-5.12/rtgui/thumbbrowserbase.cc:249:89: style: Parameter 'entry' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtgui/thumbbrowserbase.cc:756:27: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/thumbbrowserbase.cc:1292:31: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/thumbimageupdater.cc:169:71: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable crop [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbimageupdater.cc:122:40: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/thumbimageupdater.cc:131:41: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/md5helper.h:57:74: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CHECKSUM_MD5 [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbnail.cc:79:53: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RTVERSION [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbnail.cc:219:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbnail.cc:268:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbnail.cc:394:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ST_NONE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbnail.cc:527:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbnail.cc:894:63: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TI_Nearest [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbnail.cc:924:125: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TI_Bilinear [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbnail.cc:1036:56: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable tm_year [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbnail.cc:1404:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbnail.cc:1486:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbnail.cc:1493:86: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable READ_WRITE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/tonecurve.cc:41:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AUTOEXP [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/tonecurve.cc:378:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable STD [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/tonecurve.cc:522:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvHRMethod [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/tonecurve.cc:610:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvToneCurveMode1 [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/tonecurve.cc:627:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvToneCurveMode2 [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/tonecurve.cc:676:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvExpComp [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/tonecurve.cc:1099:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DCT_Linear [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/thumbnail.cc:1289:17: performance:inconclusive: Technically the member function 'Thumbnail::openDefaultViewer' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtgui/thumbnail.h:197:21: note: Technically the member function 'Thumbnail::openDefaultViewer' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtgui/thumbnail.cc:1289:17: note: Technically the member function 'Thumbnail::openDefaultViewer' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtgui/thumbnail.cc:1221:12: warning: Class 'Thumbnail' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] rawtherapee-5.12/rtgui/thumbnail.cc:1221:12: warning: Class 'Thumbnail' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] rawtherapee-5.12/rtgui/thumbnail.cc:113:5: style: Struct 'ColorMapper' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] rawtherapee-5.12/rtgui/thumbnail.cc:493:56: style: Condition 'cfs' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtgui/thumbnail.cc:1436:35: style: Condition 'forceUpdate' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtgui/thumbnail.cc:1433:13: note: Assuming that condition '!forceUpdate' is not redundant rawtherapee-5.12/rtgui/thumbnail.cc:1436:35: note: Condition 'forceUpdate' is always true rawtherapee-5.12/rtgui/thumbnail.cc:1451:35: style: Condition 'forceUpdate' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtgui/thumbnail.cc:1448:13: note: Assuming that condition '!forceUpdate' is not redundant rawtherapee-5.12/rtgui/thumbnail.cc:1451:35: note: Condition 'forceUpdate' is always true rawtherapee-5.12/rtgui/thumbnail.cc:482:27: style: Local variable 'cfs' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/thumbnail.h:53:21: note: Shadowed declaration rawtherapee-5.12/rtgui/thumbnail.cc:482:27: note: Shadow variable rawtherapee-5.12/rtgui/thumbnail.cc:113:44: performance: Function parameter 'colors' should be passed by const reference. [passedByValue] rawtherapee-5.12/rtgui/toneequalizer.cc:33:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AUTOEXP [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/toneequalizer.cc:160:19: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/toolbar.cc:30:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ICON_SIZE_LARGE_TOOLBAR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/toolbar.cc:507:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_CONTROL_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/toollocationpref.cc:359:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/toollocationpref.cc:565:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SELECTION_MULTIPLE [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/toollocationpref.cc:688:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/toollocationpref.cc:730:70: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable POS_RIGHT [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/toolpanel.cc:30:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/toolpanel.cc:40:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/toolpanel.cc:52:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SIZE_REQUEST_HEIGHT_FOR_WIDTH [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/toolpanel.cc:67:53: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ALIGN_CENTER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/toollocationpref.cc:678:49: performance:inconclusive: Technically the member function 'ToolLocationPreference::Impl::toolNamesToTools' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtgui/toollocationpref.cc:502:23: note: Technically the member function 'ToolLocationPreference::Impl::toolNamesToTools' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtgui/toollocationpref.cc:678:49: note: Technically the member function 'ToolLocationPreference::Impl::toolNamesToTools' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtgui/toolpanel.cc:146:41: style:inconclusive: Function 'setEnabled' argument 1 names different: declaration 'isActive' definition 'isEnabled'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/toolpanel.h:238:26: note: Function 'setEnabled' argument 1 names different: declaration 'isActive' definition 'isEnabled'. rawtherapee-5.12/rtgui/toolpanel.cc:146:41: note: Function 'setEnabled' argument 1 names different: declaration 'isActive' definition 'isEnabled'. rawtherapee-5.12/rtgui/toolpanel.cc:55:71: performance:inconclusive: Function parameter 'toolName' should be passed by const reference. [passedByValue] rawtherapee-5.12/rtgui/toolpanel.cc:55:95: performance:inconclusive: Function parameter 'UILabel' should be passed by const reference. [passedByValue] rawtherapee-5.12/rtgui/vibrance.cc:46:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PACK_SHRINK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/vibrance.cc:292:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvVibrancePastels [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/vibrance.cc:310:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvVibrancePastSatThreshold [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/vignetting.cc:123:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvVignettingAmount [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/toolpanelcoord.cc:466:56: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ORIENTATION_VERTICAL [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/toolpanelcoord.cc:797:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/toolpanelcoord.cc:859:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/toolpanelcoord.cc:1142:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvCTHFlip [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/toolpanelcoord.cc:1263:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvHistoryBrowsed [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/toolpanelcoord.cc:1677:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DEFAULT_CAMERA_FOCAL_LENGTH [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/toolpanelcoord.cc:1797:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/toolpanelcoord.cc:1820:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_MOD1_MASK [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/toolpanelcoord.cc:1870:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable POLICY_AUTOMATIC [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/wavelet.cc:226:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DIRPYREQUALIZER [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/wavelet.cc:1755:65: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LABGRID_CORR_MAX [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/wavelet.cc:2221:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LABGRID_CORR_MAX [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/wavelet.cc:2682:73: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LABGRID_CORR_MAX [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/wavelet.cc:2901:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvWavHueskin [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/wavelet.cc:2942:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvWavHSmet [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/wavelet.cc:3012:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvWavCHmet [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/wavelet.cc:3065:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvWavEDmet [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/wavelet.cc:3080:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvWavNPmet [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/wavelet.cc:3113:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvWavBAmet [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/wavelet.cc:3145:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvWavTMmet [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/wavelet.cc:3160:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvWavBackmet [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/wavelet.cc:3192:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvWavCLmet [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/wavelet.cc:3446:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvWavTilesmet [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/wavelet.cc:3459:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvWavdaubcoeffmet [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/wavelet.cc:3473:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvWavedgreinf [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/wavelet.cc:3487:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvWavDirmeto [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/wavelet.cc:3513:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvWavLmet [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/wavelet.cc:3646:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvWavtiles [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/wavelet.cc:4397:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NUMOFEVENTS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/toolpanelcoord.cc:1406:30: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] rawtherapee-5.12/rtgui/toolpanelcoord.cc:786:39: style:inconclusive: Function 'updateFavoritesPanel' argument 1 names different: declaration 'favorites' definition 'favoritesNames'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/toolpanelcoord.h:482:43: note: Function 'updateFavoritesPanel' argument 1 names different: declaration 'favorites' definition 'favoritesNames'. rawtherapee-5.12/rtgui/toolpanelcoord.cc:786:39: note: Function 'updateFavoritesPanel' argument 1 names different: declaration 'favorites' definition 'favoritesNames'. rawtherapee-5.12/rtgui/toolpanelcoord.cc:1370:81: style:inconclusive: Function 'initImage' argument 2 names different: declaration 'israw' definition 'raw'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/toolpanelcoord.h:397:63: note: Function 'initImage' argument 2 names different: declaration 'israw' definition 'raw'. rawtherapee-5.12/rtgui/toolpanelcoord.cc:1370:81: note: Function 'initImage' argument 2 names different: declaration 'israw' definition 'raw'. rawtherapee-5.12/rtgui/toolpanelcoord.cc:2123:79: style:inconclusive: Function 'getFoldableToolPanel' argument 1 names different: declaration 'tool' definition 'toolTree'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/toolpanelcoord.h:480:61: note: Function 'getFoldableToolPanel' argument 1 names different: declaration 'tool' definition 'toolTree'. rawtherapee-5.12/rtgui/toolpanelcoord.cc:2123:79: note: Function 'getFoldableToolPanel' argument 1 names different: declaration 'tool' definition 'toolTree'. rawtherapee-5.12/rtgui/toolpanelcoord.cc:1902:52: style: Parameter 'tool' can be declared as pointer to const [constParameterPointer] rawtherapee-5.12/rtgui/toolpanelcoord.cc:1903:19: style: Variable 'fav' can be declared as pointer to const [constVariablePointer] rawtherapee-5.12/rtgui/toolpanelcoord.cc:445:35: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/toolpanelcoord.cc:609:40: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/toolpanelcoord.cc:620:40: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/toolpanelcoord.cc:1903:9: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] rawtherapee-5.12/rtgui/whitebalance.cc:127:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CAMERA [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/whitebalance.cc:511:59: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AUTO [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/whitebalance.cc:570:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TEN_DEGREES [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/whitebalance.cc:620:71: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AUTO [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/whitebalance.cc:761:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TEN_DEGREES [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/whitebalance.cc:1131:112: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ppLabel [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/whitebalance.cc:1142:112: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ppLabel [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/whitebalance.cc:1248:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TEMP_CORRELATION_RAW [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/whitebalance.cc:1064:31: style:inconclusive: Function 'setWB' argument 1 names different: declaration 'temp' definition 'vtemp'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/whitebalance.h:142:21: note: Function 'setWB' argument 1 names different: declaration 'temp' definition 'vtemp'. rawtherapee-5.12/rtgui/whitebalance.cc:1064:31: note: Function 'setWB' argument 1 names different: declaration 'temp' definition 'vtemp'. rawtherapee-5.12/rtgui/whitebalance.cc:1064:45: style:inconclusive: Function 'setWB' argument 2 names different: declaration 'green' definition 'vgreen'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/whitebalance.h:142:34: note: Function 'setWB' argument 2 names different: declaration 'green' definition 'vgreen'. rawtherapee-5.12/rtgui/whitebalance.cc:1064:45: note: Function 'setWB' argument 2 names different: declaration 'green' definition 'vgreen'. rawtherapee-5.12/rtgui/whitebalance.cc:1192:46: style:inconclusive: Function 'WBChanged' argument 2 names different: declaration 'temp' definition 'temperature'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/whitebalance.h:144:47: note: Function 'WBChanged' argument 2 names different: declaration 'temp' definition 'temperature'. rawtherapee-5.12/rtgui/whitebalance.cc:1192:46: note: Function 'WBChanged' argument 2 names different: declaration 'temp' definition 'temperature'. rawtherapee-5.12/rtgui/whitebalance.cc:1192:66: style:inconclusive: Function 'WBChanged' argument 3 names different: declaration 'green' definition 'greenVal'. [funcArgNamesDifferent] rawtherapee-5.12/rtgui/whitebalance.h:144:60: note: Function 'WBChanged' argument 3 names different: declaration 'green' definition 'greenVal'. rawtherapee-5.12/rtgui/whitebalance.cc:1192:66: note: Function 'WBChanged' argument 3 names different: declaration 'green' definition 'greenVal'. rawtherapee-5.12/rtgui/xtransprocess.cc:35:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DEMOSAIC [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/xtransprocess.cc:146:171: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FOUR_PASS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/xtransprocess.cc:215:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvDemosaicFalseColorIter [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/xtransprocess.cc:259:75: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FOUR_PASS [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/xtransrawexposure.cc:35:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DARKFRAME [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/xtransrawexposure.cc:143:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EvPreProcessExpBlackRed [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/wavelet.cc:2877:13: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled] rawtherapee-5.12/rtgui/zoompanel.cc:28:78: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ICON_SIZE_LARGE_TOOLBAR [valueFlowBailoutIncompleteVar] rawtherapee-5.12/rtgui/wavelet.cc:3069:15: style:inconclusive: Either there is a missing 'override', or the member function 'Wavelet::NPmethodUpdateUI' can be const. [functionConst] rawtherapee-5.12/rtgui/wavelet.h:176:10: note: Either there is a missing 'override', or the member function 'Wavelet::NPmethodUpdateUI' can be const. rawtherapee-5.12/rtgui/wavelet.cc:3069:15: note: Either there is a missing 'override', or the member function 'Wavelet::NPmethodUpdateUI' can be const. rawtherapee-5.12/rtgui/wavelet.cc:3621:15: performance:inconclusive: Either there is a missing 'override', or the member function 'Wavelet::adjusterUpdateUI' can be static. [functionStatic] rawtherapee-5.12/rtgui/wavelet.h:186:10: note: Either there is a missing 'override', or the member function 'Wavelet::adjusterUpdateUI' can be static. rawtherapee-5.12/rtgui/wavelet.cc:3621:15: note: Either there is a missing 'override', or the member function 'Wavelet::adjusterUpdateUI' can be static. rawtherapee-5.12/tools/gimp-plugin/file-rawtherapee.c:63:1: error: There is an unknown macro here somewhere. Configuration is required. If MAIN is a macro then please configure it. [unknownMacro] rawtherapee-5.12/rtgui/paramsedited.cc:1232:21: style: Local variable 'i' shadows outer variable [shadowVariable] rawtherapee-5.12/rtgui/paramsedited.cc:915:17: note: Shadowed declaration rawtherapee-5.12/rtgui/paramsedited.cc:1232:21: note: Shadow variable rawtherapee-5.12/rtengine/procparams.cc:3288:31: warning: Member variable 'LocallabSpot::labgridcieALow' is not initialized in the constructor. [uninitMemberVar] rawtherapee-5.12/rtengine/procparams.cc:3288:31: warning: Member variable 'LocallabSpot::labgridcieBLow' is not initialized in the constructor. [uninitMemberVar] rawtherapee-5.12/rtengine/procparams.cc:3288:31: warning: Member variable 'LocallabSpot::labgridcieAHigh' is not initialized in the constructor. [uninitMemberVar] rawtherapee-5.12/rtengine/procparams.cc:3288:31: warning: Member variable 'LocallabSpot::labgridcieBHigh' is not initialized in the constructor. [uninitMemberVar] rawtherapee-5.12/rtengine/procparams.cc:3288:31: warning: Member variable 'LocallabSpot::labgridcieGx' is not initialized in the constructor. [uninitMemberVar] rawtherapee-5.12/rtengine/procparams.cc:3288:31: warning: Member variable 'LocallabSpot::labgridcieGy' is not initialized in the constructor. [uninitMemberVar] rawtherapee-5.12/rtengine/procparams.cc:3288:31: warning: Member variable 'LocallabSpot::labgridcieWx' is not initialized in the constructor. [uninitMemberVar] rawtherapee-5.12/rtengine/procparams.cc:3288:31: warning: Member variable 'LocallabSpot::labgridcieWy' is not initialized in the constructor. [uninitMemberVar] rawtherapee-5.12/rtengine/procparams.cc:3288:31: warning: Member variable 'LocallabSpot::labgridcieMx' is not initialized in the constructor. [uninitMemberVar] rawtherapee-5.12/rtengine/procparams.cc:3288:31: warning: Member variable 'LocallabSpot::labgridcieMy' is not initialized in the constructor. [uninitMemberVar] rawtherapee-5.12/rtengine/procparams.cc:2290:49: performance:inconclusive: Technically the member function 'rtengine::procparams::LensProfParams::getMethodStrings' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/procparams.h:1019:37: note: Technically the member function 'rtengine::procparams::LensProfParams::getMethodStrings' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/procparams.cc:2290:49: note: Technically the member function 'rtengine::procparams::LensProfParams::getMethodStrings' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/procparams.cc:12012:17: performance:inconclusive: Technically the member function 'rtengine::procparams::ProcParams::write' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/procparams.h:2952:9: note: Technically the member function 'rtengine::procparams::ProcParams::write' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/procparams.cc:12012:17: note: Technically the member function 'rtengine::procparams::ProcParams::write' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/procparams.h:2978:19: style: Class 'PartialProfile' is unsafe, 'PartialProfile::pedited' can leak by wrong usage. [unsafeClassCanLeak] rawtherapee-5.12/rtengine/procparams.cc:555:41: warning: Either the condition '!pedited' is redundant or there is possible null pointer dereference: pedited. [nullPointerRedundantCheck] rawtherapee-5.12/rtengine/procparams.cc:557:19: note: Assuming that condition '!pedited' is not redundant rawtherapee-5.12/rtengine/procparams.cc:555:41: note: Null pointer dereference rawtherapee-5.12/rtengine/procparams.cc:12124:59: style:inconclusive: Function 'applyTo' argument 2 names different: declaration 'fromLastSaved' definition 'fromLastSave'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/procparams.h:2975:47: note: Function 'applyTo' argument 2 names different: declaration 'fromLastSaved' definition 'fromLastSave'. rawtherapee-5.12/rtengine/procparams.cc:12124:59: note: Function 'applyTo' argument 2 names different: declaration 'fromLastSaved' definition 'fromLastSave'. rawtherapee-5.12/rtengine/procparams.cc:7221:53: style: Local variable 'spot' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/procparams.h:2885:29: note: Shadowed declaration rawtherapee-5.12/rtengine/procparams.cc:7221:53: note: Shadow variable rawtherapee-5.12/rtengine/procparams.cc:9560:46: style: Local variable 'spot' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/procparams.h:2885:29: note: Shadowed declaration rawtherapee-5.12/rtengine/procparams.cc:9560:46: note: Shadow variable rawtherapee-5.12/rtengine/procparams.cc:130:150: performance:inconclusive: Function parameter 'embedded_fname' should be passed by const reference. [passedByValue] rawtherapee-5.12/rtengine/procparams.cc:3270:24: style: Parameter 'opacityCurveLUTSH' can be declared as reference to const [constParameterReference] rawtherapee-5.12/rtengine/procparams.cc:8618:24: style: Variable 'p' can be declared as reference to const [constVariableReference] rawtherapee-5.12/rtengine/procparams.cc:8632:24: style: Variable 'p' can be declared as reference to const [constVariableReference] rawtherapee-5.12/rtengine/procparams.cc:1191:18: error: Uninitialized variable: v [legacyUninitvar] rawtherapee-5.12/rtengine/procparams.cc:1233:18: error: Uninitialized variable: v [legacyUninitvar] rawtherapee-5.12/rtengine/procparams.cc:1275:19: error: Uninitialized variable: v [legacyUninitvar] diff: 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:1072:52: style: Floating-point cast causes loss of precision. [suspiciousFloatingPointCast] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:1073:50: style: Floating-point cast causes loss of precision. [suspiciousFloatingPointCast] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:1079:52: style: Floating-point cast causes loss of precision. [suspiciousFloatingPointCast] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:1080:50: style: Floating-point cast causes loss of precision. [suspiciousFloatingPointCast] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:1179:38: style: Local variable 'c' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/CA_correct_RT.cc:1142:33: note: Shadowed declaration rawtherapee-5.12/rtengine/CA_correct_RT.cc:1179:38: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:126:9: style:inconclusive: Function 'CA_correct_RT' argument 6 names different: declaration 'border' definition 'border_crop'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/rawimagesource.h:253:13: note: Function 'CA_correct_RT' argument 6 names different: declaration 'border' definition 'border_crop'. rawtherapee-5.12/rtengine/CA_correct_RT.cc:126:9: note: Function 'CA_correct_RT' argument 6 names different: declaration 'border' definition 'border_crop'. 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:141:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:190:19: style: Local variable 'border' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/rawimagesource.h:73:9: note: Shadowed declaration rawtherapee-5.12/rtengine/CA_correct_RT.cc:190:19: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:203:32: error: If memory allocation fails: pointer addition with NULL pointer. [nullPointerArithmeticOutOfMemory] rawtherapee-5.12/rtengine/CA_correct_RT.cc:200:45: note: Assuming allocation function fails rawtherapee-5.12/rtengine/CA_correct_RT.cc:200:37: note: Assignment 'buffer=static_cast(std::malloc((height*width+vblsz*hblsz*(2*2+1))*sizeof(float)))', assigned value is 0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:203:32: note: Null pointer addition 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:206:35: error: If memory allocation fails: pointer addition with NULL pointer. [nullPointerArithmeticOutOfMemory] rawtherapee-5.12/rtengine/CA_correct_RT.cc:200:45: note: Assuming allocation function fails rawtherapee-5.12/rtengine/CA_correct_RT.cc:200:37: note: Assignment 'buffer=static_cast(std::malloc((height*width+vblsz*hblsz*(2*2+1))*sizeof(float)))', assigned value is 0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:206:35: note: Null pointer addition 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:233:15: style: The scope of the variable 'blockave' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:235:15: style: The scope of the variable 'blockdenom' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:239:13: style: The scope of the variable 'polyord' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:239:26: style: The scope of the variable 'numpar' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:252:17: style: The scope of the variable 'shifthfloor' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:252:33: style: The scope of the variable 'shiftvfloor' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:252:49: style: The scope of the variable 'shifthceil' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:252:64: style: The scope of the variable 'shiftvceil' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:256:19: style: The scope of the variable 'shifthfrac' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:256:34: style: The scope of the variable 'shiftvfrac' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:261:38: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:269:22: portability: Casting between char * const and float * which have an incompatible binary data representation. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:269:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:270:22: portability: Casting between char * const and float * which have an incompatible binary data representation. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:270:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:270:37: error: Pointer addition with NULL pointer. [nullPointerArithmetic] rawtherapee-5.12/rtengine/CA_correct_RT.cc:261:53: note: Assuming allocation function fails rawtherapee-5.12/rtengine/CA_correct_RT.cc:261:38: note: Assignment 'bufferThr=(char*)std::malloc((autoCA&&!fitParamsSet)?buffersize:buffersizePassTwo)', assigned value is 0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:263:33: note: Assignment 'data=(char*)((unsigned long(bufferThr)+unsigned long(63))/64*64)', assigned value is 0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:270:37: note: Null pointer addition 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:271:22: portability: Casting between char * const and float * which have an incompatible binary data representation. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:271:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:271:37: error: Pointer addition with NULL pointer. [nullPointerArithmetic] rawtherapee-5.12/rtengine/CA_correct_RT.cc:261:53: note: Assuming allocation function fails rawtherapee-5.12/rtengine/CA_correct_RT.cc:261:38: note: Assignment 'bufferThr=(char*)std::malloc((autoCA&&!fitParamsSet)?buffersize:buffersizePassTwo)', assigned value is 0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:263:33: note: Assignment 'data=(char*)((unsigned long(bufferThr)+unsigned long(63))/64*64)', assigned value is 0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:271:37: note: Null pointer addition 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:276:34: portability: Casting between char * const and float * which have an incompatible binary data representation. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:276:34: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:278:34: portability: Casting between char * const and float * which have an incompatible binary data representation. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:278:34: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:280:34: portability: Casting between char * const and float * which have an incompatible binary data representation. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:280:34: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:282:34: portability: Casting between char * const and float * which have an incompatible binary data representation. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:282:34: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:284:34: portability: Casting between char * const and float * which have an incompatible binary data representation. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:284:34: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:286:34: portability: Casting between char * const and float * which have an incompatible binary data representation. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:286:34: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:474:37: style: Local variable 'indx' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/CA_correct_RT.cc:437:33: note: Shadowed declaration rawtherapee-5.12/rtengine/CA_correct_RT.cc:474:37: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:843:34: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/CA_correct_RT.cc:845:34: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:2036:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::RGBtile_denoise' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:528:10: note: Technically the member function 'rtengine::ImProcFunctions::RGBtile_denoise' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/FTblockDN.cc:2036:23: note: Technically the member function 'rtengine::ImProcFunctions::RGBtile_denoise' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:2066:49: style: Parameter 'bloxrow_L' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:2098:24: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::Mad' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:551:11: note: Technically the member function 'rtengine::ImProcFunctions::Mad' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/FTblockDN.cc:2098:24: note: Technically the member function 'rtengine::ImProcFunctions::Mad' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:2127:24: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::MadRgb' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:552:11: note: Technically the member function 'rtengine::ImProcFunctions::MadRgb' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/FTblockDN.cc:2127:24: note: Technically the member function 'rtengine::ImProcFunctions::MadRgb' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:2231:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable nothrow [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:2382:180: style: Parameter 'variC' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:2427:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable nothrow [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:2596:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable nothrow [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:2662:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable nothrow [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:2693:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::ShrinkAllL' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:541:10: note: Technically the member function 'rtengine::ImProcFunctions::ShrinkAllL' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/FTblockDN.cc:2693:23: note: Technically the member function 'rtengine::ImProcFunctions::ShrinkAllL' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:2694:37: style: Parameter 'madL' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:2694:51: style: Parameter 'vari' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:2785:17: style: Parameter 'noisevarchrom' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:2786:40: style: Parameter 'madL' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:2786:55: style: Parameter 'variC' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:2786:81: style: Parameter 'madaab' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:3063:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::RGB_denoise_infoGamCurve' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:526:10: note: Technically the member function 'rtengine::ImProcFunctions::RGB_denoise_infoGamCurve' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/FTblockDN.cc:3063:23: note: Technically the member function 'rtengine::ImProcFunctions::RGB_denoise_infoGamCurve' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:3086:23: style:inconclusive: Technically the member function 'rtengine::ImProcFunctions::calcautodn_info' can be const. [functionConst] rawtherapee-5.12/rtengine/improcfun.h:550:10: note: Technically the member function 'rtengine::ImProcFunctions::calcautodn_info' can be const. rawtherapee-5.12/rtengine/FTblockDN.cc:3086:23: note: Technically the member function 'rtengine::ImProcFunctions::calcautodn_info' can be const. 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:3378:25: style: Variable 'realred' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:3384:26: style: Variable 'realblue' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:433:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::Median_Denoise' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:524:10: note: Technically the member function 'rtengine::ImProcFunctions::Median_Denoise' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/FTblockDN.cc:433:23: note: Technically the member function 'rtengine::ImProcFunctions::Median_Denoise' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:440:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::Tile_calc' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:497:10: note: Technically the member function 'rtengine::ImProcFunctions::Tile_calc' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/FTblockDN.cc:440:23: note: Technically the member function 'rtengine::ImProcFunctions::Tile_calc' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:483:111: style: Parameter 'ch_M' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:483:124: style: Parameter 'max_r' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:483:138: style: Parameter 'max_b' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:722:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable rgbDenoiseThreadLimit [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/FTblockDN.cc:755:17: style: The scope of the variable 'min_numblox_W' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/StopWatch.h:39:14: warning: Member variable 'StopWatch::stopTime' is not initialized in the constructor. [uninitMemberVar] 2.18.0 rawtherapee-5.12/rtengine/StopWatch.h:58:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/ahd_demosaic_RT.cc:50:11: style: Local variable 'xyz_cam' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/rawimagesource.h:69:12: note: Shadowed declaration rawtherapee-5.12/rtengine/ahd_demosaic_RT.cc:50:11: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/ahd_demosaic_RT.cc:94:17: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/alignedbuffer.h:47:5: style: Class 'AlignedBuffer < double >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.18.0 rawtherapee-5.12/rtengine/alignedbuffer.h:47:5: style: Class 'AlignedBuffer < float * >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.18.0 rawtherapee-5.12/rtengine/alignedbuffer.h:47:5: style: Class 'AlignedBuffer < int >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.18.0 rawtherapee-5.12/rtengine/alignedbuffer.h:47:5: style: Class 'AlignedBuffer < std :: uint16_t >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head rawtherapee-5.12/rtengine/alignedbuffer.h:57:18: warning: Class 'AlignedBuffer < float >' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] head rawtherapee-5.12/rtengine/alignedbuffer.h:57:18: warning: Class 'AlignedBuffer < float >' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] head rawtherapee-5.12/rtengine/alignedbuffer.h:57:18: warning: Class 'AlignedBuffer < unsigned char >' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] head rawtherapee-5.12/rtengine/alignedbuffer.h:57:18: warning: Class 'AlignedBuffer < unsigned char >' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] head rawtherapee-5.12/rtengine/alignedbuffer.h:57:18: warning: Class 'AlignedBuffer < unsigned short >' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] head rawtherapee-5.12/rtengine/alignedbuffer.h:57:18: warning: Class 'AlignedBuffer < unsigned short >' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:138:24: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:143:35: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:145:35: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:145:56: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:145:56: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:145:72: error: Pointer addition with NULL pointer. [nullPointerArithmetic] rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:138:39: note: Assuming allocation function fails rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:138:24: note: Assignment 'buffer=(char*)calloc(14*sizeof(float)*ts*ts+sizeof(char)*ts*tsh+18*cldf*64+63,1)', assigned value is 0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:140:22: note: Assignment 'data=(char*)((unsigned long(buffer)+unsigned long(63))/64*64)', assigned value is 0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:143:33: note: rgbgreen is assigned '(float(*))data' here. rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:145:72: note: Null pointer addition 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:147:35: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:147:56: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:147:56: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:148:35: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:148:56: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:148:56: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:150:35: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:150:56: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:150:56: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:152:35: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:152:56: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:152:56: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:154:35: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:154:56: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:154:56: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:156:35: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:156:56: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:156:56: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:158:35: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:158:56: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:158:56: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:160:35: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:160:56: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:160:56: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:166:35: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:166:56: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:166:56: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:170:35: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:170:56: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:170:56: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:172:35: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:174:35: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:174:56: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:174:56: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:176:35: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:176:56: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:176:56: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:177:35: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:177:56: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:177:56: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:179:35: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:179:56: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:179:56: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:184:35: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:184:56: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:184:56: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:186:56: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:186:56: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:187:35: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:188:27: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:188:39: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/amaze_demosaic_RT.cc:54:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/array2D.h:269:5: style:inconclusive: Technically the member function 'array2D < double >::operatorbool' can be const. [functionConst] 2.18.0 rawtherapee-5.12/rtengine/array2D.h:269:5: style:inconclusive: Technically the member function 'array2D < float >::operatorbool' can be const. [functionConst] 2.18.0 rawtherapee-5.12/rtengine/array2D.h:269:5: style:inconclusive: Technically the member function 'array2D < int >::operatorbool' can be const. [functionConst] 2.18.0 rawtherapee-5.12/rtengine/array2D.h:269:5: style:inconclusive: Technically the member function 'array2D < uint8_t >::operatorbool' can be const. [functionConst] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:1173:63: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:1173:89: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:1230:8: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:1233:8: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:1281:51: style: Parameter 'out' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:1395:15: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:1418:20: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:1541:33: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:1563:14: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:1678:19: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:1679:10: warning: If memory allocation fails, then there is a possible null pointer dereference: best_set [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/ashift_dt.c:1678:32: note: Assuming allocation function fails rawtherapee-5.12/rtengine/ashift_dt.c:1678:19: note: Assignment 'best_set=(int*)std::malloc(set_size)', assigned value is 0 rawtherapee-5.12/rtengine/ashift_dt.c:1679:10: note: Null pointer dereference 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:1680:21: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:1698:15: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:1699:42: warning: If memory allocation fails, then there is a possible null pointer dereference: perm [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/ashift_dt.c:1698:28: note: Assuming allocation function fails rawtherapee-5.12/rtengine/ashift_dt.c:1698:15: note: Assignment 'perm=(int*)std::malloc((set_count+1)*sizeof(int))', assigned value is 0 rawtherapee-5.12/rtengine/ashift_dt.c:1699:42: note: Null pointer dereference 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:1703:16: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:1846:33: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:1856:20: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:1858:20: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:1970:37: style: Parameter 'params' can be declared as pointer to const. However it seems that 'model_fitness' is a callback function, if 'params' is declared with const you might also need to cast function pointer(s). [constParameterCallback] rawtherapee-5.12/rtengine/ashift_dt.c:2263:22: note: You might need to cast the function pointer here rawtherapee-5.12/rtengine/ashift_dt.c:1970:37: note: Parameter 'params' can be declared as pointer to const 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:1972:37: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:1989:9: style: The scope of the variable 'rotation_range' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:1995:9: style: The scope of the variable 'camera_pitch_range' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:1996:9: style: The scope of the variable 'camera_yaw_range' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:2047:14: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:2074:18: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:2075:18: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:2119:33: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:2178:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NAN [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:2263:109: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:2275:10: style: Variable 'pcount' is reassigned a value before the old one has been used. [redundantAssignment] rawtherapee-5.12/rtengine/ashift_dt.c:2224:11: note: pcount is assigned rawtherapee-5.12/rtengine/ashift_dt.c:2275:10: note: pcount is overwritten 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:2835:33: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:2841:10: style: Variable 'b' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:2852:5: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:2913:33: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:2929:7: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:711:11: style: The scope of the variable 'mwork' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:839:17: warning: Redundant code: Found unused function. [constStatement] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:865:12: style: Variable 'm3[2][2]' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:909:16: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:909:36: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_dt.c:925:51: style: Parameter 'data' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:1083:9: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:1139:24: style: The scope of the variable 'bin_term' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:1139:33: style: The scope of the variable 'mult_term' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:1378:9: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:1482:7: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:1632:23: style: The scope of the variable 'weight' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:1676:20: style: The scope of the variable 'l' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:1676:22: style: The scope of the variable 'w' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:1676:30: style: The scope of the variable 'weight' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:2170:9: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:2238:9: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:2244:9: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:2245:9: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:2261:13: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:2268:9: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:297:9: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:298:9: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:313:13: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:322:21: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:341:21: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:341:41: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:400:9: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:401:9: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:415:11: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:417:17: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:475:11: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:477:17: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:526:9: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:527:9: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:541:11: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:543:17: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:568:11: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:595:10: style: The scope of the variable 'val' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:661:10: style: The scope of the variable 'yc' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:661:7: style: The scope of the variable 'xc' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:662:16: style: The scope of the variable 'xx' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:662:19: style: The scope of the variable 'yy' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:802:31: style: Local variable 'norm2' shadows outer function [shadowFunction] rawtherapee-5.12/rtengine/rt_math.h:131:10: note: Shadowed declaration rawtherapee-5.12/rtengine/ashift_lsd.c:802:31: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:833:10: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:834:12: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:835:15: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:837:15: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:928:9: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_lsd.c:929:9: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_nmsimplex.c:104:10: style: The scope of the variable 'fsum' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ashift_nmsimplex.c:104:16: style: The scope of the variable 'favg' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ashift_nmsimplex.c:104:22: style: The scope of the variable 's' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ashift_nmsimplex.c:109:7: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_nmsimplex.c:110:7: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_nmsimplex.c:111:8: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_nmsimplex.c:112:8: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_nmsimplex.c:113:8: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_nmsimplex.c:114:8: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_nmsimplex.c:119:12: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ashift_nmsimplex.c:119:5: warning: If memory allocation fails, then there is a possible null pointer dereference: v [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/ashift_nmsimplex.c:109:24: note: Assuming allocation function fails rawtherapee-5.12/rtengine/ashift_nmsimplex.c:109:7: note: Assignment 'v=(double**)std::malloc((n+1)*sizeof(double*))', assigned value is 0 rawtherapee-5.12/rtengine/ashift_nmsimplex.c:119:5: note: Null pointer dereference 2.18.0 rawtherapee-5.12/rtengine/ashift_nmsimplex.c:130:5: warning: If memory allocation fails, then there is a possible null pointer dereference: v [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/ashift_nmsimplex.c:109:24: note: Assuming allocation function fails rawtherapee-5.12/rtengine/ashift_nmsimplex.c:109:7: note: Assignment 'v=(double**)std::malloc((n+1)*sizeof(double*))', assigned value is 0 rawtherapee-5.12/rtengine/ashift_nmsimplex.c:130:5: note: Null pointer dereference 2.18.0 rawtherapee-5.12/rtengine/ashift_nmsimplex.c:85:7: style: The scope of the variable 'vh' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ashift_nmsimplex.c:86:7: style: The scope of the variable 'vg' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ashift_nmsimplex.c:95:10: style: The scope of the variable 'fr' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/badpixels.cc:441:49: style: Variable 'distance2PixelFound' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/bayer_bilinear_demosaic.cc:30:121: style: Parameter 'red' can be declared as reference to const [constParameterReference] 2.18.0 rawtherapee-5.12/rtengine/bayer_bilinear_demosaic.cc:30:165: style: Parameter 'blue' can be declared as reference to const [constParameterReference] 2.18.0 rawtherapee-5.12/rtengine/capturesharpening.cc:1084:25: style: Variable 'L' can be declared as reference to const [constVariableReference] 2.18.0 rawtherapee-5.12/rtengine/capturesharpening.cc:1100:26: style: float result is assigned to double & variable. If the variable is double & to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 rawtherapee-5.12/rtengine/capturesharpening.cc:1129:21: style: Variable 'L' can be declared as reference to const [constVariableReference] 2.18.0 rawtherapee-5.12/rtengine/capturesharpening.cc:1130:21: style: Variable 'YOld' can be declared as reference to const [constVariableReference] 2.18.0 rawtherapee-5.12/rtengine/capturesharpening.cc:1131:21: style: Variable 'YNew' can be declared as reference to const [constVariableReference] 2.18.0 rawtherapee-5.12/rtengine/capturesharpening.cc:1149:22: style: float result is assigned to double & variable. If the variable is double & to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 rawtherapee-5.12/rtengine/cfa_linedn_RT.cc:342:22: performance:inconclusive: Technically the member function 'rtengine::RawImageSource::ddct8x8s' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/rawimagesource.h:263:10: note: Technically the member function 'rtengine::RawImageSource::ddct8x8s' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/cfa_linedn_RT.cc:342:22: note: Technically the member function 'rtengine::RawImageSource::ddct8x8s' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/cfa_linedn_RT.cc:41:45: style:inconclusive: Function 'cfa_linedn' argument 1 names different: declaration 'linenoiselevel' definition 'noise'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/rawimagesource.h:270:28: note: Function 'cfa_linedn' argument 1 names different: declaration 'linenoiselevel' definition 'noise'. rawtherapee-5.12/rtengine/cfa_linedn_RT.cc:41:45: note: Function 'cfa_linedn' argument 1 names different: declaration 'linenoiselevel' definition 'noise'. 2.18.0 rawtherapee-5.12/rtengine/cfa_linedn_RT.cc:64:11: style: The scope of the variable 'noisevarm4' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/cfa_linedn_RT.cc:65:25: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/cfa_linedn_RT.cc:72:24: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/cfa_linedn_RT.cc:73:33: error: If memory allocation fails: pointer addition with NULL pointer. [nullPointerArithmeticOutOfMemory] rawtherapee-5.12/rtengine/cfa_linedn_RT.cc:72:38: note: Assuming allocation function fails rawtherapee-5.12/rtengine/cfa_linedn_RT.cc:72:24: note: Assignment 'cfain=(float*)std::malloc(3*224*224*sizeof(float)+2*16*sizeof(float))', assigned value is 0 rawtherapee-5.12/rtengine/cfa_linedn_RT.cc:73:33: note: Null pointer addition 2.18.0 rawtherapee-5.12/rtengine/cfa_linedn_RT.cc:74:31: error: If memory allocation fails: pointer addition with NULL pointer. [nullPointerArithmeticOutOfMemory] rawtherapee-5.12/rtengine/cfa_linedn_RT.cc:72:38: note: Assuming allocation function fails rawtherapee-5.12/rtengine/cfa_linedn_RT.cc:72:24: note: Assignment 'cfain=(float*)std::malloc(3*224*224*sizeof(float)+2*16*sizeof(float))', assigned value is 0 rawtherapee-5.12/rtengine/cfa_linedn_RT.cc:74:31: note: Null pointer addition 2.18.0 rawtherapee-5.12/rtengine/cfa_linedn_RT.cc:86:17: warning: If memory allocation fails, then there is a possible null pointer dereference: RawDataTmp [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/cfa_linedn_RT.cc:65:39: note: Assuming allocation function fails rawtherapee-5.12/rtengine/cfa_linedn_RT.cc:65:25: note: Assignment 'RawDataTmp=(float*)std::malloc(static_cast(width)*height*sizeof(float))', assigned value is 0 rawtherapee-5.12/rtengine/cfa_linedn_RT.cc:86:17: note: Null pointer dereference 2.18.0 rawtherapee-5.12/rtengine/clutstore.cc:285:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/clutstore.cc:300:19: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] 2.18.0 rawtherapee-5.12/rtengine/clutstore.cc:30:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_EXISTS [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/clutstore.cc:322:58: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable clutsDir [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/color.h:1287:48: warning: Invalid log() argument nr 1. The value is 0 but the valid values are '4.94066e-324:'. [invalidFunctionArg] rawtherapee-5.12/rtengine/ipretinex.cc:96:22: note: Assignment 'i=0', assigned value is 0 rawtherapee-5.12/rtengine/ipretinex.cc:97:59: note: Calling function 'gammareti', 1st argument 'i/65535.0' value is 0.0 rawtherapee-5.12/rtengine/color.h:1287:48: note: Invalid argument 2.18.0 rawtherapee-5.12/rtengine/color.h:1287:48: warning: Invalid std::log() argument nr 1. The value is 0 but the valid values are '4.94066e-324:'. [invalidFunctionArg] rawtherapee-5.12/rtengine/iplocallab.cc:410:22: note: Assignment 'i=0', assigned value is 0 rawtherapee-5.12/rtengine/iplocallab.cc:411:59: note: Calling function 'gammareti', 1st argument 'i/65535.0' value is 0.0 rawtherapee-5.12/rtengine/color.h:1287:48: note: Invalid argument 2.18.0 rawtherapee-5.12/rtengine/cplx_wavelet_dec.h:198:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable nothrow [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/cplx_wavelet_level.h:201:24: style:inconclusive: Technically the member function 'rtengine::wavelet_level < float >::AnalysisFilterHaarHorizontal' can be const. [functionConst] rawtherapee-5.12/rtengine/cplx_wavelet_level.h:53:10: note: Technically the member function 'rtengine::wavelet_level < float >::AnalysisFilterHaarHorizontal' can be const. rawtherapee-5.12/rtengine/cplx_wavelet_level.h:201:24: note: Technically the member function 'rtengine::wavelet_level < float >::AnalysisFilterHaarHorizontal' can be const. 2.18.0 rawtherapee-5.12/rtengine/cplx_wavelet_level.h:217:45: style:inconclusive: Technically the member function 'rtengine::wavelet_level < float >::AnalysisFilterHaarVertical' can be const. [functionConst] rawtherapee-5.12/rtengine/cplx_wavelet_level.h:52:10: note: Technically the member function 'rtengine::wavelet_level < float >::AnalysisFilterHaarVertical' can be const. rawtherapee-5.12/rtengine/cplx_wavelet_level.h:217:45: note: Technically the member function 'rtengine::wavelet_level < float >::AnalysisFilterHaarVertical' can be const. 2.18.0 rawtherapee-5.12/rtengine/cplx_wavelet_level.h:296:24: style:inconclusive: Technically the member function 'rtengine::wavelet_level < float >::AnalysisFilterSubsampHorizontal' can be const. [functionConst] rawtherapee-5.12/rtengine/cplx_wavelet_level.h:57:10: note: Technically the member function 'rtengine::wavelet_level < float >::AnalysisFilterSubsampHorizontal' can be const. rawtherapee-5.12/rtengine/cplx_wavelet_level.h:296:24: note: Technically the member function 'rtengine::wavelet_level < float >::AnalysisFilterSubsampHorizontal' can be const. 2.18.0 rawtherapee-5.12/rtengine/cplx_wavelet_level.h:402:45: style:inconclusive: Technically the member function 'rtengine::wavelet_level < float >::AnalysisFilterSubsampVertical' can be const. [functionConst] rawtherapee-5.12/rtengine/cplx_wavelet_level.h:63:10: note: Technically the member function 'rtengine::wavelet_level < float >::AnalysisFilterSubsampVertical' can be const. rawtherapee-5.12/rtengine/cplx_wavelet_level.h:402:45: note: Technically the member function 'rtengine::wavelet_level < float >::AnalysisFilterSubsampVertical' can be const. 2.18.0 rawtherapee-5.12/rtengine/cplx_wavelet_level.h:444:45: style:inconclusive: Technically the member function 'rtengine::wavelet_level < float >::SynthesisFilterSubsampHorizontal' can be const. [functionConst] rawtherapee-5.12/rtengine/cplx_wavelet_level.h:66:10: note: Technically the member function 'rtengine::wavelet_level < float >::SynthesisFilterSubsampHorizontal' can be const. rawtherapee-5.12/rtengine/cplx_wavelet_level.h:444:45: note: Technically the member function 'rtengine::wavelet_level < float >::SynthesisFilterSubsampHorizontal' can be const. 2.18.0 rawtherapee-5.12/rtengine/dcp.cc:1185:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/dcp.cc:1519:18: style:inconclusive: Technically the member function 'rtengine::DCPProfile::setStep2ApplyState' can be const. [functionConst] rawtherapee-5.12/rtengine/dcp.h:77:10: note: Technically the member function 'rtengine::DCPProfile::setStep2ApplyState' can be const. rawtherapee-5.12/rtengine/dcp.cc:1519:18: note: Technically the member function 'rtengine::DCPProfile::setStep2ApplyState' can be const. 2.18.0 rawtherapee-5.12/rtengine/dcp.cc:1571:40: style:inconclusive: Function 'step2ApplyTile' argument 1 names different: declaration 'r' definition 'rc'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/dcp.h:78:32: note: Function 'step2ApplyTile' argument 1 names different: declaration 'r' definition 'rc'. rawtherapee-5.12/rtengine/dcp.cc:1571:40: note: Function 'step2ApplyTile' argument 1 names different: declaration 'r' definition 'rc'. 2.18.0 rawtherapee-5.12/rtengine/dcp.cc:1571:51: style:inconclusive: Function 'step2ApplyTile' argument 2 names different: declaration 'g' definition 'gc'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/dcp.h:78:42: note: Function 'step2ApplyTile' argument 2 names different: declaration 'g' definition 'gc'. rawtherapee-5.12/rtengine/dcp.cc:1571:51: note: Function 'step2ApplyTile' argument 2 names different: declaration 'g' definition 'gc'. 2.18.0 rawtherapee-5.12/rtengine/dcp.cc:1571:62: style:inconclusive: Function 'step2ApplyTile' argument 3 names different: declaration 'b' definition 'bc'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/dcp.h:78:52: note: Function 'step2ApplyTile' argument 3 names different: declaration 'b' definition 'bc'. rawtherapee-5.12/rtengine/dcp.cc:1571:62: note: Function 'step2ApplyTile' argument 3 names different: declaration 'b' definition 'bc'. 2.18.0 rawtherapee-5.12/rtengine/dcp.cc:2005:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable hue_shift [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/dcp.cc:2045:67: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable hue_shift [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/dcp.cc:2148:16: style: Variable 'p' can be declared as reference to const [constVariableReference] 2.18.0 rawtherapee-5.12/rtengine/dcp.cc:2160:69: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable rtdir [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/dcp.cc:2182:35: style: Variable 'exception' can be declared as reference to const [constVariableReference] 2.18.0 rawtherapee-5.12/rtengine/dcp.cc:2219:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_EXISTS [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/dcp.cc:2257:58: style:inconclusive: Function 'getStdProfile' argument 1 names different: declaration 'camShortName' definition 'requested_cam_short_name'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/dcp.h:165:52: note: Function 'getStdProfile' argument 1 names different: declaration 'camShortName' definition 'requested_cam_short_name'. rawtherapee-5.12/rtengine/dcp.cc:2257:58: note: Function 'getStdProfile' argument 1 names different: declaration 'camShortName' definition 'requested_cam_short_name'. 2.18.0 rawtherapee-5.12/rtengine/dcp.cc:2269:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TEST_EXISTS [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/dcp.cc:410:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/dcp.cc:478:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/dcp.cc:524:17: performance: Returning the result of c_str() in a function that returns std::string is slow and redundant. [stlcstrReturn] 2.18.0 rawtherapee-5.12/rtengine/dcp.cc:52:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/dcp.cc:718:19: style:inconclusive: Technically the member function '::DCPMetadata::get2' can be const. [functionConst] 2.18.0 rawtherapee-5.12/rtengine/dcp.cc:725:19: style:inconclusive: Technically the member function '::DCPMetadata::get4' can be const. [functionConst] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:107:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EUID_None [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1116:46: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1170:96: error: Uninitialized variable: lastsav [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1172:106: error: Uninitialized variable: mini [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1172:112: error: Uninitialized variable: maxi [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1172:118: error: Uninitialized variable: Tmean [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1172:125: error: Uninitialized variable: Tsigma [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1172:133: error: Uninitialized variable: Tmin [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1172:139: error: Uninitialized variable: Tmax [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1172:92: error: Uninitialized variable: minCD [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1172:99: error: Uninitialized variable: maxCD [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1173:106: error: Uninitialized variable: meanx [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1173:113: error: Uninitialized variable: meany [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1173:120: error: Uninitialized variable: meanxe [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1173:76: error: Uninitialized variable: rdx [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1173:81: error: Uninitialized variable: rdy [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1173:86: error: Uninitialized variable: grx [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1173:91: error: Uninitialized variable: gry [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1173:96: error: Uninitialized variable: blx [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1175:25: error: Uninitialized variable: ghsbpwp [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1175:34: error: Uninitialized variable: ghsbpwpvalue [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1178:291: style: Same expression 'parent->localllcMask==4' found multiple times in chain of '||' operators. [duplicateExpression] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1208:46: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1503:40: style: Variable 'WaveParams.expcontrast' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1504:38: style: Variable 'WaveParams.expchroma' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1505:36: style: Variable 'WaveParams.expedge' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1506:37: style: Variable 'WaveParams.expfinal' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1507:38: style: Variable 'WaveParams.exptoning' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1508:37: style: Variable 'WaveParams.expnoise' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1632:26: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] rawtherapee-5.12/rtengine/dcrop.cc:1629:91: note: outer condition: params.icm.trcExp rawtherapee-5.12/rtengine/dcrop.cc:1632:26: note: identical inner condition: params.icm.trcExp 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1680:37: style: Local variable 'params' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/dcrop.cc:150:17: note: Shadowed declaration rawtherapee-5.12/rtengine/dcrop.cc:1680:37: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1699:41: style: Local variable 'params' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/dcrop.cc:150:17: note: Shadowed declaration rawtherapee-5.12/rtengine/dcrop.cc:1699:41: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:1984:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ET_PIPETTE [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/dcrop.cc:781:32: warning: Return value of function fattalCrop.release() is not used. [ignoredReturnValue] 2.18.0 rawtherapee-5.12/rtengine/demosaic_algos.cc:1043:22: performance:inconclusive: Technically the member function 'rtengine::RawImageSource::copy_to_buffer' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/rawimagesource.h:291:10: note: Technically the member function 'rtengine::RawImageSource::copy_to_buffer' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/demosaic_algos.cc:1043:22: note: Technically the member function 'rtengine::RawImageSource::copy_to_buffer' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/demosaic_algos.cc:1054:22: performance:inconclusive: Technically the member function 'rtengine::RawImageSource::restore_from_buffer' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/rawimagesource.h:299:10: note: Technically the member function 'rtengine::RawImageSource::restore_from_buffer' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/demosaic_algos.cc:1054:22: note: Technically the member function 'rtengine::RawImageSource::restore_from_buffer' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/demosaic_algos.cc:1162:20: style: Variable 'pix' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/demosaic_algos.cc:1177:65: style: Parameter 'map' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/demosaic_algos.cc:1257:66: style: Parameter 'map' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/demosaic_algos.cc:1297:65: style: Parameter 'map' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/demosaic_algos.cc:1418:9: style: The scope of the variable 'numTiles' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/demosaic_algos.cc:1419:9: style: The scope of the variable 'tilesDone' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/demosaic_algos.cc:1427:21: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/demosaic_algos.cc:1431:26: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/demosaic_algos.cc:1432:26: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/demosaic_algos.cc:1432:41: portability:inconclusive: Casting from float * * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/demosaic_algos.cc:1432:41: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/demosaic_algos.cc:1434:38: portability:inconclusive: Casting from float * * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/demosaic_algos.cc:1434:38: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/demosaic_algos.cc:621:23: error: If memory allocation fails: pointer addition with NULL pointer. [nullPointerArithmeticOutOfMemory] rawtherapee-5.12/rtengine/demosaic_algos.cc:619:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/demosaic_algos.cc:619:19: note: Assignment 'rgbarray=(float(*))std::calloc(width*height*3,sizeof(float))', assigned value is 0 rawtherapee-5.12/rtengine/demosaic_algos.cc:621:23: note: Null pointer addition 2.18.0 rawtherapee-5.12/rtengine/demosaic_algos.cc:622:23: error: If memory allocation fails: pointer addition with NULL pointer. [nullPointerArithmeticOutOfMemory] rawtherapee-5.12/rtengine/demosaic_algos.cc:619:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/demosaic_algos.cc:619:19: note: Assignment 'rgbarray=(float(*))std::calloc(width*height*3,sizeof(float))', assigned value is 0 rawtherapee-5.12/rtengine/demosaic_algos.cc:622:23: note: Null pointer addition 2.18.0 rawtherapee-5.12/rtengine/demosaic_algos.cc:626:23: error: If memory allocation fails: pointer addition with NULL pointer. [nullPointerArithmeticOutOfMemory] rawtherapee-5.12/rtengine/demosaic_algos.cc:624:37: note: Assuming allocation function fails rawtherapee-5.12/rtengine/demosaic_algos.cc:624:19: note: Assignment 'chrarray=(float(*))std::calloc(width*height*2,sizeof(float))', assigned value is 0 rawtherapee-5.12/rtengine/demosaic_algos.cc:626:23: note: Null pointer addition 2.18.0 rawtherapee-5.12/rtengine/demosaic_algos.cc:963:29: style:inconclusive: Technically the member function 'rtengine::RawImageSource::dcb_initTileLimits' can be const. [functionConst] rawtherapee-5.12/rtengine/rawimagesource.h:288:10: note: Technically the member function 'rtengine::RawImageSource::dcb_initTileLimits' can be const. rawtherapee-5.12/rtengine/demosaic_algos.cc:963:29: note: Technically the member function 'rtengine::RawImageSource::dcb_initTileLimits' can be const. 2.18.0 rawtherapee-5.12/rtengine/demosaic_algos.cc:998:22: style:inconclusive: Technically the member function 'rtengine::RawImageSource::fill_border' can be const. [functionConst] rawtherapee-5.12/rtengine/rawimagesource.h:290:10: note: Technically the member function 'rtengine::RawImageSource::fill_border' can be const. rawtherapee-5.12/rtengine/demosaic_algos.cc:998:22: note: Technically the member function 'rtengine::RawImageSource::fill_border' can be const. 2.18.0 rawtherapee-5.12/rtengine/dfmanager.cc:129:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable INFINITY [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/dfmanager.cc:291:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/dfmanager.cc:358:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/dfmanager.cc:367:33: style: Variable 'e' can be declared as reference to const [constVariableReference] 2.18.0 rawtherapee-5.12/rtengine/dfmanager.cc:463:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/dfmanager.cc:494:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/dfmanager.cc:551:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TYPE_DIRECTORY [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/dfmanager.cc:636:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RT_INFINITY [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/dfmanager.cc:64:5: warning:inconclusive: Member variable 'dfInfo::badPixels' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] 2.18.0 rawtherapee-5.12/rtengine/dfmanager.cc:64:5: warning:inconclusive: Member variable 'dfInfo::pathNames' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] 2.18.0 rawtherapee-5.12/rtengine/dfmanager.cc:652:69: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/dfmanager.cc:95:24: warning:inconclusive: Member variable 'dfInfo::badPixels' is not assigned a value in 'dfInfo::operator='. [operatorEqVarError] 2.18.0 rawtherapee-5.12/rtengine/dfmanager.cc:95:24: warning:inconclusive: Member variable 'dfInfo::pathNames' is not assigned a value in 'dfInfo::operator='. [operatorEqVarError] 2.18.0 rawtherapee-5.12/rtengine/dirpyr_equalizer.cc:373:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::dirpyr_equalizer' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:559:10: note: Technically the member function 'rtengine::ImProcFunctions::dirpyr_equalizer' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/dirpyr_equalizer.cc:373:23: note: Technically the member function 'rtengine::ImProcFunctions::dirpyr_equalizer' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/dirpyr_equalizer.cc:373:275: style:inconclusive: Function 'dirpyr_equalizer' argument 13 names different: declaration 'scale' definition 'scaleprev'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:559:250: note: Function 'dirpyr_equalizer' argument 13 names different: declaration 'scale' definition 'scaleprev'. rawtherapee-5.12/rtengine/dirpyr_equalizer.cc:373:275: note: Function 'dirpyr_equalizer' argument 13 names different: declaration 'scale' definition 'scaleprev'. 2.18.0 rawtherapee-5.12/rtengine/dirpyr_equalizer.cc:467:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::dirpyr_equalizercam' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:560:10: note: Technically the member function 'rtengine::ImProcFunctions::dirpyr_equalizercam' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/dirpyr_equalizer.cc:467:23: note: Technically the member function 'rtengine::ImProcFunctions::dirpyr_equalizercam' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/dirpyr_equalizer.cc:467:287: style:inconclusive: Function 'dirpyr_equalizercam' argument 14 names different: declaration 'scale' definition 'scaleprev'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:560:275: note: Function 'dirpyr_equalizercam' argument 14 names different: declaration 'scale' definition 'scaleprev'. rawtherapee-5.12/rtengine/dirpyr_equalizer.cc:467:287: note: Function 'dirpyr_equalizercam' argument 14 names different: declaration 'scale' definition 'scaleprev'. 2.18.0 rawtherapee-5.12/rtengine/dirpyr_equalizer.cc:528:308: style:inconclusive: Function 'cbdl_local_temp' argument 17 names different: declaration 'scale' definition 'scaleprev'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:558:296: note: Function 'cbdl_local_temp' argument 17 names different: declaration 'scale' definition 'scaleprev'. rawtherapee-5.12/rtengine/dirpyr_equalizer.cc:528:308: note: Function 'cbdl_local_temp' argument 17 names different: declaration 'scale' definition 'scaleprev'. 2.18.0 rawtherapee-5.12/rtengine/dual_demosaic_RT.cc:108:14: style: float result is assigned to double & variable. If the variable is double & to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 rawtherapee-5.12/rtengine/dual_demosaic_RT.cc:49:112: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable measure [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/eahd_demosaic.cc:276:13: style: Variable 'mod' can be declared as const array [constVariable] 2.18.0 rawtherapee-5.12/rtengine/eahd_demosaic.cc:39:29: style:inconclusive: Technically the member function 'rtengine::RawImageSource::interpolate_row_g' can be const. [functionConst] rawtherapee-5.12/rtengine/rawimagesource.h:243:18: note: Technically the member function 'rtengine::RawImageSource::interpolate_row_g' can be const. rawtherapee-5.12/rtengine/eahd_demosaic.cc:39:29: note: Technically the member function 'rtengine::RawImageSource::interpolate_row_g' can be const. 2.18.0 rawtherapee-5.12/rtengine/eahd_demosaic.cc:96:29: style:inconclusive: Technically the member function 'rtengine::RawImageSource::interpolate_row_rb' can be const. [functionConst] rawtherapee-5.12/rtengine/rawimagesource.h:244:18: note: Technically the member function 'rtengine::RawImageSource::interpolate_row_rb' can be const. rawtherapee-5.12/rtengine/eahd_demosaic.cc:96:29: note: Technically the member function 'rtengine::RawImageSource::interpolate_row_rb' can be const. 2.18.0 rawtherapee-5.12/rtengine/eahd_demosaic.cc:96:89: style: Parameter 'cg' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/fast_demo.cc:93:18: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/fast_demo.cc:97:21: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/fast_demo.cc:98:21: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/fast_demo.cc:98:42: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/fast_demo.cc:98:42: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/fast_demo.cc:98:59: error: Pointer addition with NULL pointer. [nullPointerArithmetic] rawtherapee-5.12/rtengine/fast_demo.cc:93:33: note: Assuming allocation function fails rawtherapee-5.12/rtengine/fast_demo.cc:93:18: note: Assignment 'buffer=(char*)std::calloc(3*sizeof(float)*224*224+3*1*64+63,1)', assigned value is 0 rawtherapee-5.12/rtengine/fast_demo.cc:95:16: note: Assignment 'data=(char*)((unsigned long(buffer)+unsigned long(63))/64*64)', assigned value is 0 rawtherapee-5.12/rtengine/fast_demo.cc:97:19: note: greentile is assigned '(float(*))data' here. rawtherapee-5.12/rtengine/fast_demo.cc:98:59: note: Null pointer addition 2.18.0 rawtherapee-5.12/rtengine/fast_demo.cc:99:21: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/fast_demo.cc:99:42: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/fast_demo.cc:99:42: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/ffmanager.cc:100:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable INFINITY [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/ffmanager.cc:231:17: warning: If memory allocation fails, then there is a possible null pointer dereference: cfatmp [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/ffmanager.cc:217:44: note: Assuming allocation function fails rawtherapee-5.12/rtengine/ffmanager.cc:217:25: note: Assignment 'cfatmp=(float(*))malloc(H*W*sizeof(*cfatmp))', assigned value is 0 rawtherapee-5.12/rtengine/ffmanager.cc:231:17: note: Null pointer dereference 2.18.0 rawtherapee-5.12/rtengine/ffmanager.cc:235:29: warning: If memory allocation fails, then there is a possible null pointer dereference: cfatmp [nullPointerOutOfMemory] rawtherapee-5.12/rtengine/ffmanager.cc:217:44: note: Assuming allocation function fails rawtherapee-5.12/rtengine/ffmanager.cc:217:25: note: Assignment 'cfatmp=(float(*))malloc(H*W*sizeof(*cfatmp))', assigned value is 0 rawtherapee-5.12/rtengine/ffmanager.cc:235:29: note: Null pointer dereference 2.18.0 rawtherapee-5.12/rtengine/ffmanager.cc:272:34: style: Variable 'e' can be declared as reference to const [constVariableReference] 2.18.0 rawtherapee-5.12/rtengine/ffmanager.cc:325:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FILE_TYPE_DIRECTORY [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/ffmanager.cc:35:24: warning:inconclusive: Member variable 'ffInfo::pathNames' is not assigned a value in 'ffInfo::operator='. [operatorEqVarError] 2.18.0 rawtherapee-5.12/rtengine/ffmanager.cc:376:46: style:inconclusive: Function 'getStat' argument 2 names different: declaration 'totTemplate' definition 'totTemplates'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/ffmanager.h:82:39: note: Function 'getStat' argument 2 names different: declaration 'totTemplate' definition 'totTemplates'. rawtherapee-5.12/rtengine/ffmanager.cc:376:46: note: Function 'getStat' argument 2 names different: declaration 'totTemplate' definition 'totTemplates'. 2.18.0 rawtherapee-5.12/rtengine/ffmanager.cc:438:118: style:inconclusive: Function 'searchFlatField' argument 4 names different: declaration 'focallength' definition 'focal'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/ffmanager.h:83:111: note: Function 'searchFlatField' argument 4 names different: declaration 'focallength' definition 'focal'. rawtherapee-5.12/rtengine/ffmanager.cc:438:118: note: Function 'searchFlatField' argument 4 names different: declaration 'focallength' definition 'focal'. 2.18.0 rawtherapee-5.12/rtengine/ffmanager.cc:449:59: performance:inconclusive: Function parameter 'filename' should be passed by const reference. [passedByValue] 2.18.0 rawtherapee-5.12/rtengine/ffmanager.cc:452:63: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] 2.18.0 rawtherapee-5.12/rtengine/ffmanager.cc:97:92: style:inconclusive: Function 'distance' argument 3 names different: declaration 'lens' definition 'len'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/ffmanager.h:58:88: note: Function 'distance' argument 3 names different: declaration 'lens' definition 'len'. rawtherapee-5.12/rtengine/ffmanager.cc:97:92: note: Function 'distance' argument 3 names different: declaration 'lens' definition 'len'. 2.18.0 rawtherapee-5.12/rtengine/ffmanager.h:49:5: warning:inconclusive: Member variable 'ffInfo::pathNames' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] 2.18.0 rawtherapee-5.12/rtengine/ffmanager.h:61:17: style:inconclusive: Technically the member function 'rtengine::ffInfo::key' can be const. [functionConst] 2.18.0 rawtherapee-5.12/rtengine/ffmanager.h:78:19: style:inconclusive: Technically the member function 'rtengine::FFManager::getPathname' can be const. [functionConst] 2.18.0 rawtherapee-5.12/rtengine/ffmanager.h:84:52: performance:inconclusive: Function parameter 'filename' should be passed by const reference. [passedByValue] 2.18.0 rawtherapee-5.12/rtengine/filmnegativeproc.cc:180:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/filmnegativeproc.cc:271:16: style: Variable 'rlinein' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/filmnegativeproc.cc:272:16: style: Variable 'glinein' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/filmnegativeproc.cc:273:16: style: Variable 'blinein' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/filmnegativeproc.cc:321:59: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable V1 [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/filmnegativeproc.cc:387:33: style:inconclusive: Technically the member function 'rtengine::ImProcFunctions::filmNegativeProcess' can be const. [functionConst] rawtherapee-5.12/rtengine/improcfun.h:197:10: note: Technically the member function 'rtengine::ImProcFunctions::filmNegativeProcess' can be const. rawtherapee-5.12/rtengine/filmnegativeproc.cc:387:33: note: Technically the member function 'rtengine::ImProcFunctions::filmNegativeProcess' can be const. 2.18.0 rawtherapee-5.12/rtengine/filmnegativeproc.cc:442:27: performance:inconclusive: Technically the member function 'rtengine::Thumbnail::processFilmNegative' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/rtthumbnail.h:82:10: note: Technically the member function 'rtengine::Thumbnail::processFilmNegative' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/filmnegativeproc.cc:442:27: note: Technically the member function 'rtengine::Thumbnail::processFilmNegative' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/filmnegativeproc.cc:462:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/filmnegativeproc.cc:535:27: style:inconclusive: Technically the member function 'rtengine::Thumbnail::processFilmNegativeV2' can be const. [functionConst] rawtherapee-5.12/rtengine/rtthumbnail.h:83:10: note: Technically the member function 'rtengine::Thumbnail::processFilmNegativeV2' can be const. rawtherapee-5.12/rtengine/filmnegativeproc.cc:535:27: note: Technically the member function 'rtengine::Thumbnail::processFilmNegativeV2' can be const. 2.18.0 rawtherapee-5.12/rtengine/filmnegativeproc.cc:563:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/filmnegativeproc.cc:75:51: performance: Function parameter 'currWB' should be passed by const reference. [passedByValue] 2.18.0 rawtherapee-5.12/rtengine/filmnegativeproc.cc:82:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable verbose [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/flatcurves.cc:42:13: warning: Class 'FlatCurve' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] head rawtherapee-5.12/rtengine/flatcurves.cc:42:13: warning: Class 'FlatCurve' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] 2.18.0 rawtherapee-5.12/rtengine/flatcurves.cc:42:13: warning: Class 'FlatCurve' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] head rawtherapee-5.12/rtengine/flatcurves.cc:42:13: warning: Class 'FlatCurve' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] 2.18.0 rawtherapee-5.12/rtengine/gamutwarning.cc:126:27: performance:inconclusive: Technically the member function 'rtengine::GamutWarning::mark' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/gamutwarning.h:46:10: note: Technically the member function 'rtengine::GamutWarning::mark' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/gamutwarning.cc:126:27: note: Technically the member function 'rtengine::GamutWarning::mark' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/gamutwarning.cc:126:51: style:inconclusive: Function 'mark' argument 2 names different: declaration 'i' definition 'y'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/gamutwarning.h:46:34: note: Function 'mark' argument 2 names different: declaration 'i' definition 'y'. rawtherapee-5.12/rtengine/gamutwarning.cc:126:51: note: Function 'mark' argument 2 names different: declaration 'i' definition 'y'. 2.18.0 rawtherapee-5.12/rtengine/gamutwarning.cc:126:58: style:inconclusive: Function 'mark' argument 3 names different: declaration 'j' definition 'x'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/gamutwarning.h:46:41: note: Function 'mark' argument 3 names different: declaration 'j' definition 'x'. rawtherapee-5.12/rtengine/gamutwarning.cc:126:58: note: Function 'mark' argument 3 names different: declaration 'j' definition 'x'. 2.18.0 rawtherapee-5.12/rtengine/gamutwarning.cc:35:99: style:inconclusive: Function 'GamutWarning' argument 4 names different: declaration 'bpc' definition 'gamutbpc'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/gamutwarning.h:41:89: note: Function 'GamutWarning' argument 4 names different: declaration 'bpc' definition 'gamutbpc'. rawtherapee-5.12/rtengine/gamutwarning.cc:35:99: note: Function 'GamutWarning' argument 4 names different: declaration 'bpc' definition 'gamutbpc'. 2.18.0 rawtherapee-5.12/rtengine/gamutwarning.cc:40:71: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LCMS_USED_AS_OUTPUT [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/gamutwarning.cc:59:13: style: Condition 'softproof2ref' is always true [knownConditionTrueFalse] 2.18.0 rawtherapee-5.12/rtengine/green_equil_RT.cc:91:72: style:inconclusive: Function 'green_equilibrate' argument 1 names different: declaration 'greenthresh' definition 'thresh'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/rawimagesource.h:273:61: note: Function 'green_equilibrate' argument 1 names different: declaration 'greenthresh' definition 'thresh'. rawtherapee-5.12/rtengine/green_equil_RT.cc:91:72: note: Function 'green_equilibrate' argument 1 names different: declaration 'greenthresh' definition 'thresh'. 2.18.0 rawtherapee-5.12/rtengine/guidedfilter.cc:165:39: style: Parameter 'd' can be declared as reference to const [constParameterReference] 2.18.0 rawtherapee-5.12/rtengine/guidedfilter.cc:165:58: style: Parameter 's' can be declared as reference to const [constParameterReference] 2.18.0 rawtherapee-5.12/rtengine/hilite_recon.cc:1348:55: style: Parameter 'scale_mul' can be declared as const array [constParameter] 2.18.0 rawtherapee-5.12/rtengine/hilite_recon.cc:1353:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/hilite_recon.cc:1519:14: style: Local variable 'tmp' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/hilite_recon.cc:1440:29: note: Shadowed declaration rawtherapee-5.12/rtengine/hilite_recon.cc:1519:14: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/hilite_recon.cc:1549:11: style: Variable 'chrominance' can be declared as const array [constVariable] 2.18.0 rawtherapee-5.12/rtengine/histmatching.cc:237:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:1063:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable g_ [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:1374:15: style: Variable 'width' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:1374:9: style: Assignment of function parameter has no effect outside the function. [uselessAssignmentArg] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:1377:16: style: Variable 'height' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:1377:9: style: Assignment of function parameter has no effect outside the function. [uselessAssignmentArg] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:1399:15: style: Variable 'width' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:1400:16: style: Variable 'height' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:1422:13: style: Assignment of function parameter has no effect outside the function. [uselessAssignmentArg] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:1422:19: style: Variable 'width' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:1422:21: style: Assignment of function parameter has no effect outside the function. [uselessAssignmentArg] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:1422:28: style: Variable 'height' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:1716:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable g_ [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:266:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable width [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:267:9: style: Assignment of function parameter has no effect outside the function. [uselessAssignmentArg] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:270:9: style: Assignment of function parameter has no effect outside the function. [uselessAssignmentArg] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:282:10: style: Virtual function 'allocate' is called from constructor 'PlanarWhateverData < float >(int w,int h)' at line 249. Dynamic binding is not used. [virtualCallInConstructor] rawtherapee-5.12/rtengine/iimage.h:249:9: note: Calling allocate rawtherapee-5.12/rtengine/iimage.h:282:10: note: allocate is a virtual function 2.18.0 rawtherapee-5.12/rtengine/iimage.h:284:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:319:19: style: Variable 'width' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:319:28: style: Variable 'height' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:327:25: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:331:20: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:340:24: debug: CheckClass::isMemberVar found used member variable 'width' with varid 0 [varid0] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:346:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:376:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:438:13: debug: CheckClass::isMemberVar found used member variable 'width' with varid 0 [varid0] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:438:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable width [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:438:28: debug: CheckClass::isMemberVar found used member variable 'height' with varid 0 [varid0] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:440:33: debug: CheckClass::isMemberVar found used member variable 'height' with varid 0 [varid0] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:441:37: debug: CheckClass::isMemberVar found used member variable 'width' with varid 0 [varid0] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:498:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable width [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:523:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:554:17: debug: CheckClass::isMemberVar found used member variable 'width' with varid 0 [varid0] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:554:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable width [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:555:17: debug: CheckClass::isMemberVar found used member variable 'height' with varid 0 [varid0] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:599:48: debug: CheckClass::isMemberVar found used member variable 'width' with varid 0 [varid0] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:599:62: debug: CheckClass::isMemberVar found used member variable 'height' with varid 0 [varid0] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:599:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:609:10: warning: The class 'PlanarWhateverData < float >' defines member function with name 'readData' also defined in its parent class 'ImageDatas'. [duplInheritedMember] rawtherapee-5.12/rtengine/iimage.h:101:10: note: Parent function 'ImageDatas::readData' rawtherapee-5.12/rtengine/iimage.h:609:10: note: Derived function 'PlanarWhateverData < float >::readData' 2.18.0 rawtherapee-5.12/rtengine/iimage.h:611:29: debug: CheckClass::isMemberVar found used member variable 'height' with varid 0 [varid0] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:611:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:616:10: warning: The class 'PlanarWhateverData < float >' defines member function with name 'writeData' also defined in its parent class 'ImageDatas'. [duplInheritedMember] rawtherapee-5.12/rtengine/iimage.h:103:10: note: Parent function 'ImageDatas::writeData' rawtherapee-5.12/rtengine/iimage.h:616:10: note: Derived function 'PlanarWhateverData < float >::writeData' 2.18.0 rawtherapee-5.12/rtengine/iimage.h:618:29: debug: CheckClass::isMemberVar found used member variable 'height' with varid 0 [varid0] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:618:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:624:29: debug: CheckClass::isMemberVar found used member variable 'height' with varid 0 [varid0] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:624:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:625:33: debug: CheckClass::isMemberVar found used member variable 'width' with varid 0 [varid0] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:679:9: style: Assignment of function parameter has no effect outside the function. [uselessAssignmentArg] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:682:9: style: Assignment of function parameter has no effect outside the function. [uselessAssignmentArg] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:746:19: style: Variable 'width' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:746:28: style: Variable 'height' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/iimage.h:989:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable tempG [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/image16.cc:106:45: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/image16.cc:56:22: style:inconclusive: Function 'Image16' argument 1 names different: declaration 'width' definition 'w'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/image16.h:38:17: note: Function 'Image16' argument 1 names different: declaration 'width' definition 'w'. rawtherapee-5.12/rtengine/image16.cc:56:22: note: Function 'Image16' argument 1 names different: declaration 'width' definition 'w'. 2.18.0 rawtherapee-5.12/rtengine/image16.cc:56:29: style:inconclusive: Function 'Image16' argument 2 names different: declaration 'height' definition 'h'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/image16.h:38:28: note: Function 'Image16' argument 2 names different: declaration 'height' definition 'h'. rawtherapee-5.12/rtengine/image16.cc:56:29: note: Function 'Image16' argument 2 names different: declaration 'height' definition 'h'. 2.18.0 rawtherapee-5.12/rtengine/image16.cc:68:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable data [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/image16.cc:73:54: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/image16.cc:82:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable data [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/image16.h:48:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sImage16 [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/image8.cc:34:21: style:inconclusive: Function 'Image8' argument 1 names different: declaration 'width' definition 'w'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/image8.h:36:17: note: Function 'Image8' argument 1 names different: declaration 'width' definition 'w'. rawtherapee-5.12/rtengine/image8.cc:34:21: note: Function 'Image8' argument 1 names different: declaration 'width' definition 'w'. 2.18.0 rawtherapee-5.12/rtengine/image8.cc:34:28: style:inconclusive: Function 'Image8' argument 2 names different: declaration 'height' definition 'h'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/image8.h:36:28: note: Function 'Image8' argument 2 names different: declaration 'height' definition 'h'. rawtherapee-5.12/rtengine/image8.cc:34:28: note: Function 'Image8' argument 2 names different: declaration 'height' definition 'h'. 2.18.0 rawtherapee-5.12/rtengine/image8.cc:46:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable data [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/image8.cc:53:35: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/image8.cc:64:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable data [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/image8.cc:80:41: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/image8.h:45:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sImage8 [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/imagedata.cc:1162:54: performance: Function parameter 's' should be passed by const reference. [passedByValue] 2.18.0 rawtherapee-5.12/rtengine/imagedata.cc:1162:54: style:inconclusive: Function 'shutterFromString' argument 1 names different: declaration 'shutter' definition 's'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/rtengine.h:150:50: note: Function 'shutterFromString' argument 1 names different: declaration 'shutter' definition 's'. rawtherapee-5.12/rtengine/imagedata.cc:1162:54: note: Function 'shutterFromString' argument 1 names different: declaration 'shutter' definition 's'. 2.18.0 rawtherapee-5.12/rtengine/imagedata.cc:1166:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/imagedata.cc:1177:55: performance: Function parameter 's' should be passed by const reference. [passedByValue] 2.18.0 rawtherapee-5.12/rtengine/imagedata.cc:1177:55: style:inconclusive: Function 'apertureFromString' argument 1 names different: declaration 'shutter' definition 's'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/rtengine.h:148:51: note: Function 'apertureFromString' argument 1 names different: declaration 'shutter' definition 's'. rawtherapee-5.12/rtengine/imagedata.cc:1177:55: note: Function 'apertureFromString' argument 1 names different: declaration 'shutter' definition 's'. 2.18.0 rawtherapee-5.12/rtengine/imagedata.cc:1193:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/imagedata.cc:1209:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/imagedata.cc:123:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable T [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/imagedata.cc:134:5: style: Class 'TagValueReader' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.18.0 rawtherapee-5.12/rtengine/imagedata.cc:138:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable invalidByteOrder [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/imagedata.cc:162:16: debug: Failed to instantiate template "readValue". The checking continues anyway. [templateInstantiation] 2.18.0 rawtherapee-5.12/rtengine/imagedata.cc:357:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/imagedata.cc:418:30: performance: Inefficient usage of string::find() in condition; string::starts_with() could be faster. [stlIfStrFind] 2.18.0 rawtherapee-5.12/rtengine/imagedata.cc:746:22: style: Local variable 'line' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/imagedata.cc:734:25: note: Shadowed declaration rawtherapee-5.12/rtengine/imagedata.cc:746:22: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/imagedata.cc:89:44: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] 2.18.0 rawtherapee-5.12/rtengine/imagedata.h:93:17: performance: Function 'getSerialNumber()' should return member 'serial' by const reference. [returnByReference] 2.18.0 rawtherapee-5.12/rtengine/imagefloat.cc:117:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable data [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/imagefloat.cc:124:30: portability: Casting between unsigned char * and float * which have an incompatible binary data representation. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/imagefloat.cc:124:30: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/imagefloat.cc:133:33: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/imagefloat.cc:142:35: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/imagefloat.cc:369:13: debug: CheckClass::isMemberVar found used member variable 'r' with varid 0 [varid0] 2.18.0 rawtherapee-5.12/rtengine/imagefloat.cc:40:29: style:inconclusive: Function 'Imagefloat' argument 1 names different: declaration 'width' definition 'w'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/imagefloat.h:43:21: note: Function 'Imagefloat' argument 1 names different: declaration 'width' definition 'w'. rawtherapee-5.12/rtengine/imagefloat.cc:40:29: note: Function 'Imagefloat' argument 1 names different: declaration 'width' definition 'w'. 2.18.0 rawtherapee-5.12/rtengine/imagefloat.cc:40:36: style:inconclusive: Function 'Imagefloat' argument 2 names different: declaration 'height' definition 'h'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/imagefloat.h:43:32: note: Function 'Imagefloat' argument 2 names different: declaration 'height' definition 'h'. rawtherapee-5.12/rtengine/imagefloat.cc:40:36: note: Function 'Imagefloat' argument 2 names different: declaration 'height' definition 'h'. 2.18.0 rawtherapee-5.12/rtengine/imagefloat.cc:468:20: style: Variable 'pRGB' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/imagefloat.cc:469:27: style: Variable 'pL' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/imagefloat.cc:469:32: style: Variable 'pa' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/imagefloat.cc:469:37: style: Variable 'pb' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/imagefloat.cc:53:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable data [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/imagefloat.cc:63:35: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/imagefloat.cc:76:32: portability: Casting between const unsigned char * and const float * which have an incompatible binary data representation. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/imagefloat.cc:76:32: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/imagefloat.cc:90:32: portability: Casting between const unsigned char * and const float * which have an incompatible binary data representation. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/imagefloat.cc:90:32: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/imagefloat.h:100:21: performance:inconclusive: Technically the member function 'rtengine::Imagefloat::DNG_FloatToHalf' can be static (but you may consider moving to unnamed namespace). [functionStatic] 2.18.0 rawtherapee-5.12/rtengine/imagefloat.h:140:26: performance:inconclusive: Technically the member function 'rtengine::Imagefloat::DNG_HalfToFloat' can be static (but you may consider moving to unnamed namespace). [functionStatic] 2.18.0 rawtherapee-5.12/rtengine/imagefloat.h:153:43: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] 2.18.0 rawtherapee-5.12/rtengine/imagefloat.h:167:43: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] 2.18.0 rawtherapee-5.12/rtengine/imagefloat.h:178:36: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] 2.18.0 rawtherapee-5.12/rtengine/imagefloat.h:182:26: performance:inconclusive: Technically the member function 'rtengine::Imagefloat::DNG_FP24ToFloat' can be static (but you may consider moving to unnamed namespace). [functionStatic] 2.18.0 rawtherapee-5.12/rtengine/imagefloat.h:190:42: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] 2.18.0 rawtherapee-5.12/rtengine/imagefloat.h:203:43: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] 2.18.0 rawtherapee-5.12/rtengine/imagefloat.h:213:35: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] 2.18.0 rawtherapee-5.12/rtengine/imagesource.cc:225:16: style: Condition '!isRAW()' is always true [knownConditionTrueFalse] rawtherapee-5.12/rtengine/imagesource.cc:62:14: note: Assuming that condition 'isRAW()' is not redundant rawtherapee-5.12/rtengine/imagesource.cc:225:16: note: Condition '!isRAW()' is always true 2.18.0 rawtherapee-5.12/rtengine/imagesource.cc:230:11: style: The scope of the variable 'greenitc_low' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/imagesource.cc:231:11: style: The scope of the variable 'tempitc_low' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/imagesource.cc:240:18: style: Variable 'greenitc' is reassigned a value before the old one has been used. [redundantAssignment] rawtherapee-5.12/rtengine/imagesource.cc:234:18: note: greenitc is assigned rawtherapee-5.12/rtengine/imagesource.cc:240:18: note: greenitc is overwritten 2.18.0 rawtherapee-5.12/rtengine/imagesource.cc:60:12: style: The scope of the variable 'green_thres' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/imagesource.cc:90:20: style: Local variable 'greenref' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/imagesource.cc:66:16: note: Shadowed declaration rawtherapee-5.12/rtengine/imagesource.cc:90:20: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/imagesource.cc:91:18: style: The scope of the variable 'pargref' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/imagesource.cc:92:18: style: The scope of the variable 'pargre' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1034:29: style: Local variable 'fw' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improccoordinator.h:179:9: note: Shadowed declaration rawtherapee-5.12/rtengine/improccoordinator.cc:1034:29: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1034:33: style: Local variable 'fh' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improccoordinator.h:179:13: note: Shadowed declaration rawtherapee-5.12/rtengine/improccoordinator.cc:1034:33: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1034:37: style: Local variable 'tr' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improccoordinator.h:179:17: note: Shadowed declaration rawtherapee-5.12/rtengine/improccoordinator.cc:1034:37: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1151:25: style: The scope of the variable 'meantme' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1151:34: style: The scope of the variable 'stdtme' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1151:42: style: The scope of the variable 'meanretie' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1151:53: style: The scope of the variable 'stdretie' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1320:23: style: The scope of the variable 'locx' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1320:28: style: Variable 'locx' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1321:23: style: The scope of the variable 'locy' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1321:28: style: Variable 'locy' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1322:23: style: The scope of the variable 'locxl' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1322:29: style: Variable 'locxl' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1323:23: style: The scope of the variable 'locyt' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1323:29: style: Variable 'locyt' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1324:23: style: The scope of the variable 'centx' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1324:29: style: Variable 'centx' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1325:23: style: The scope of the variable 'centy' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1325:29: style: Variable 'centy' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1414:38: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1468:93: error: Uninitialized variable: lastsav [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1469:31: error: Uninitialized variable: minCD [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1469:38: error: Uninitialized variable: maxCD [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1469:45: error: Uninitialized variable: mini [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1469:51: error: Uninitialized variable: maxi [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1469:57: error: Uninitialized variable: Tmean [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1469:64: error: Uninitialized variable: Tsigma [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1469:72: error: Uninitialized variable: Tmin [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1469:78: error: Uninitialized variable: Tmax [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1470:109: error: Uninitialized variable: meanx [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1470:116: error: Uninitialized variable: meany [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1470:123: error: Uninitialized variable: meanxe [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1470:79: error: Uninitialized variable: rdx [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1470:84: error: Uninitialized variable: rdy [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1470:89: error: Uninitialized variable: grx [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1470:94: error: Uninitialized variable: gry [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1470:99: error: Uninitialized variable: blx [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1480:24: style: The comparison 'ill == 2' is always true. [knownConditionTrueFalse] rawtherapee-5.12/rtengine/improccoordinator.cc:1315:27: note: 'ill' is assigned value '2' here. rawtherapee-5.12/rtengine/improccoordinator.cc:1480:24: note: The comparison 'ill == 2' is always true. 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1577:39: error: Uninitialized struct member: loccielc.primlc [uninitStructMember] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1577:39: error: Uninitialized variable: loccielc.primlc [uninitvar] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1618:22: style: Local variable 'iscolor' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improccoordinator.cc:435:14: note: Shadowed declaration rawtherapee-5.12/rtengine/improccoordinator.cc:1618:22: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1795:44: style: Floating-point cast causes loss of precision. [suspiciousFloatingPointCast] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1795:57: style: Floating-point cast causes loss of precision. [suspiciousFloatingPointCast] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1795:70: style: Floating-point cast causes loss of precision. [suspiciousFloatingPointCast] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1931:44: style: Variable 'WaveParams.expcontrast' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1932:42: style: Variable 'WaveParams.expchroma' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1933:40: style: Variable 'WaveParams.expedge' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1934:41: style: Variable 'WaveParams.expfinal' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1935:42: style: Variable 'WaveParams.exptoning' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:1936:41: style: Variable 'WaveParams.expnoise' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:2106:31: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] rawtherapee-5.12/rtengine/improccoordinator.cc:2101:97: note: outer condition: params->icm.trcExp rawtherapee-5.12/rtengine/improccoordinator.cc:2106:31: note: identical inner condition: params->icm.trcExp 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:2144:41: style: Local variable 'params' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improccoordinator.h:232:39: note: Shadowed declaration rawtherapee-5.12/rtengine/improccoordinator.cc:2144:41: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:2162:41: style: Local variable 'params' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improccoordinator.h:232:39: note: Shadowed declaration rawtherapee-5.12/rtengine/improccoordinator.cc:2162:41: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:2226:27: style: The scope of the variable 'r_x' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:2227:27: style: The scope of the variable 'r_y' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:2228:27: style: The scope of the variable 'b_x' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:2229:27: style: The scope of the variable 'b_y' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:2230:27: style: The scope of the variable 'g_x' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:2231:27: style: The scope of the variable 'g_y' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:2329:24: style: The scope of the variable 'fcomp' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:2590:25: style:inconclusive: Technically the member function 'rtengine::ImProcCoordinator::allocCache' can be const. [functionConst] rawtherapee-5.12/rtengine/improccoordinator.h:217:10: note: Technically the member function 'rtengine::ImProcCoordinator::allocCache' can be const. rawtherapee-5.12/rtengine/improccoordinator.cc:2590:25: note: Technically the member function 'rtengine::ImProcCoordinator::allocCache' can be const. 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:2893:16: style: Variable 'L_row' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:2971:53: style:inconclusive: Function 'getSpotWB' argument 3 names different: declaration 'rectSize' definition 'rect'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improccoordinator.h:446:41: note: Function 'getSpotWB' argument 3 names different: declaration 'rectSize' definition 'rect'. rawtherapee-5.12/rtengine/improccoordinator.cc:2971:53: note: Function 'getSpotWB' argument 3 names different: declaration 'rectSize' definition 'rect'. 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:2971:81: style:inconclusive: Function 'getSpotWB' argument 5 names different: declaration 'green' definition 'tgreen'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improccoordinator.h:446:73: note: Function 'getSpotWB' argument 5 names different: declaration 'green' definition 'tgreen'. rawtherapee-5.12/rtengine/improccoordinator.cc:2971:81: note: Function 'getSpotWB' argument 5 names different: declaration 'green' definition 'tgreen'. 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:2987:13: style: Local variable 'tr' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improccoordinator.h:179:17: note: Shadowed declaration rawtherapee-5.12/rtengine/improccoordinator.cc:2987:13: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:3012:21: style: Variable 'pLCPMap' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:3085:9: style: Local variable 'tr' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improccoordinator.h:179:17: note: Shadowed declaration rawtherapee-5.12/rtengine/improccoordinator.cc:3085:9: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:3099:15: style: Local variable 'currWB' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improccoordinator.h:76:15: note: Shadowed declaration rawtherapee-5.12/rtengine/improccoordinator.cc:3099:15: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:3129:21: style: Local variable 'ipf' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improccoordinator.h:266:21: note: Shadowed declaration rawtherapee-5.12/rtengine/improccoordinator.cc:3129:21: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:3223:115: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable THREAD_PRIORITY_NORMAL [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:3299:26: warning: Return value of function paramsBackup.release() is not used. [ignoredReturnValue] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:3345:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable prevdemo [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:3350:48: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:341:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable prevdemo [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:347:44: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:388:15: style: The scope of the variable 'reddeha' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:389:15: style: The scope of the variable 'greendeha' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:390:15: style: The scope of the variable 'bluedeha' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:576:17: style: The scope of the variable 'nocam' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:577:17: style: The scope of the variable 'kcam' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:583:20: style: The scope of the variable 'greenitc' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:585:18: style: The scope of the variable 'extra' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:586:18: style: The scope of the variable 'forcewbgrey' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:60:20: warning: Member variable 'ImProcCoordinator::ablxListener' is not initialized in the constructor. [uninitMemberVar] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:700:17: style: The scope of the variable 'met' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:756:17: style: Local variable 'tr' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improccoordinator.h:179:17: note: Shadowed declaration rawtherapee-5.12/rtengine/improccoordinator.cc:756:17: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/improccoordinator.cc:769:30: style: Local variable 'pp' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improccoordinator.cc:762:26: note: Shadowed declaration rawtherapee-5.12/rtengine/improccoordinator.cc:769:30: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:1179:30: style: Variable 'Cpro' is reassigned a value before the old one has been used. [redundantAssignment] rawtherapee-5.12/rtengine/improcfun.cc:1143:26: note: Cpro is assigned rawtherapee-5.12/rtengine/improcfun.cc:1179:30: note: Cpro is overwritten 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:1247:30: style: Variable 'Cpro' is reassigned a value before the old one has been used. [redundantAssignment] rawtherapee-5.12/rtengine/improcfun.cc:1227:30: note: Cpro is assigned rawtherapee-5.12/rtengine/improcfun.cc:1247:30: note: Cpro is overwritten 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:1267:31: style: The scope of the variable 'reduc' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:1267:37: style: Variable 'reduc' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:1298:31: style: The scope of the variable 'reduc' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:1298:37: style: Variable 'reduc' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:1490:35: style: Local variable 'x' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improcfun.cc:1124:27: note: Shadowed declaration rawtherapee-5.12/rtengine/improcfun.cc:1490:35: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:1490:38: style: Local variable 'y' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improcfun.cc:1124:30: note: Shadowed declaration rawtherapee-5.12/rtengine/improcfun.cc:1490:38: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:1490:41: style: Local variable 'z' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improcfun.cc:1124:33: note: Shadowed declaration rawtherapee-5.12/rtengine/improcfun.cc:1490:41: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:1889:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::moyeqt' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:222:10: note: Technically the member function 'rtengine::ImProcFunctions::moyeqt' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/improcfun.cc:1889:23: note: Technically the member function 'rtengine::ImProcFunctions::moyeqt' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:1958:134: style:inconclusive: Function 'rgbProc' argument 16 names different: declaration 'clcurve' definition 'clToningcurve'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:204:81: note: Function 'rgbProc' argument 16 names different: declaration 'clcurve' definition 'clToningcurve'. rawtherapee-5.12/rtengine/improcfun.cc:1958:134: note: Function 'rgbProc' argument 16 names different: declaration 'clcurve' definition 'clToningcurve'. 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:1958:161: style:inconclusive: Function 'rgbProc' argument 17 names different: declaration 'cl2curve' definition 'cl2Toningcurve'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:204:102: note: Function 'rgbProc' argument 17 names different: declaration 'cl2curve' definition 'cl2Toningcurve'. rawtherapee-5.12/rtengine/improcfun.cc:1958:161: note: Function 'rgbProc' argument 17 names different: declaration 'cl2curve' definition 'cl2Toningcurve'. 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:1971:134: style:inconclusive: Function 'rgbProc' argument 16 names different: declaration 'clcurve' definition 'clToningcurve'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:210:81: note: Function 'rgbProc' argument 16 names different: declaration 'clcurve' definition 'clToningcurve'. rawtherapee-5.12/rtengine/improcfun.cc:1971:134: note: Function 'rgbProc' argument 16 names different: declaration 'clcurve' definition 'clToningcurve'. 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:1971:161: style:inconclusive: Function 'rgbProc' argument 17 names different: declaration 'cl2curve' definition 'cl2Toningcurve'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:210:102: note: Function 'rgbProc' argument 17 names different: declaration 'cl2curve' definition 'cl2Toningcurve'. rawtherapee-5.12/rtengine/improcfun.cc:1971:161: note: Function 'rgbProc' argument 17 names different: declaration 'cl2curve' definition 'cl2Toningcurve'. 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:1980:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:222:202: performance: Function parameter 'ptcApplyState' should be passed by const reference. [passedByValue] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:2341:32: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:2344:30: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:2345:30: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:2345:42: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:2345:42: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:2346:30: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:2346:42: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:2346:42: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:2350:34: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:2353:31: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:268:110: style: Parameter 'gtemp' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:268:124: style: Parameter 'btemp' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:268:96: style: Parameter 'rtemp' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:2766:49: style: Local variable 'preserv' shadows outer function [shadowFunction] rawtherapee-5.12/rtengine/improcfun.h:593:10: note: Shadowed declaration rawtherapee-5.12/rtengine/improcfun.cc:2766:49: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:336:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cmsFLAGS_SOFTPROOFING [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:3378:45: style: Local variable 'preserv' shadows outer function [shadowFunction] rawtherapee-5.12/rtengine/improcfun.h:593:10: note: Shadowed declaration rawtherapee-5.12/rtengine/improcfun.cc:3378:45: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:3594:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::retreavergb' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:221:10: note: Technically the member function 'rtengine::ImProcFunctions::retreavergb' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/improcfun.cc:3594:23: note: Technically the member function 'rtengine::ImProcFunctions::retreavergb' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:3635:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::secondeg_end' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:219:10: note: Technically the member function 'rtengine::ImProcFunctions::secondeg_end' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/improcfun.cc:3635:23: note: Technically the member function 'rtengine::ImProcFunctions::secondeg_end' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:3656:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::secondeg_begin' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:218:10: note: Technically the member function 'rtengine::ImProcFunctions::secondeg_begin' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/improcfun.cc:3656:23: note: Technically the member function 'rtengine::ImProcFunctions::secondeg_begin' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:3909:127: style:inconclusive: Function 'toning2col' argument 9 names different: declaration 'rl' definition 'krl'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:215:114: note: Function 'toning2col' argument 9 names different: declaration 'rl' definition 'krl'. rawtherapee-5.12/rtengine/improcfun.cc:3909:127: note: Function 'toning2col' argument 9 names different: declaration 'rl' definition 'krl'. 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:3909:138: style:inconclusive: Function 'toning2col' argument 10 names different: declaration 'gl' definition 'kgl'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:215:124: note: Function 'toning2col' argument 10 names different: declaration 'gl' definition 'kgl'. rawtherapee-5.12/rtengine/improcfun.cc:3909:138: note: Function 'toning2col' argument 10 names different: declaration 'gl' definition 'kgl'. 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:3909:149: style:inconclusive: Function 'toning2col' argument 11 names different: declaration 'bl' definition 'kbl'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:215:134: note: Function 'toning2col' argument 11 names different: declaration 'bl' definition 'kbl'. rawtherapee-5.12/rtengine/improcfun.cc:3909:149: note: Function 'toning2col' argument 11 names different: declaration 'bl' definition 'kbl'. 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:3909:160: style:inconclusive: Function 'toning2col' argument 12 names different: declaration 'rh' definition 'krh'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:215:144: note: Function 'toning2col' argument 12 names different: declaration 'rh' definition 'krh'. rawtherapee-5.12/rtengine/improcfun.cc:3909:160: note: Function 'toning2col' argument 12 names different: declaration 'rh' definition 'krh'. 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:3909:171: style:inconclusive: Function 'toning2col' argument 13 names different: declaration 'gh' definition 'kgh'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:215:154: note: Function 'toning2col' argument 13 names different: declaration 'gh' definition 'kgh'. rawtherapee-5.12/rtengine/improcfun.cc:3909:171: note: Function 'toning2col' argument 13 names different: declaration 'gh' definition 'kgh'. 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:3909:182: style:inconclusive: Function 'toning2col' argument 14 names different: declaration 'bh' definition 'kbh'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:215:164: note: Function 'toning2col' argument 14 names different: declaration 'bh' definition 'kbh'. rawtherapee-5.12/rtengine/improcfun.cc:3909:182: note: Function 'toning2col' argument 14 names different: declaration 'bh' definition 'kbh'. 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:4001:11: style: Local variable 'preserv' shadows outer function [shadowFunction] rawtherapee-5.12/rtengine/improcfun.h:593:10: note: Shadowed declaration rawtherapee-5.12/rtengine/improcfun.cc:4001:11: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:4082:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::luminanceCurve' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:224:10: note: Technically the member function 'rtengine::ImProcFunctions::luminanceCurve' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/improcfun.cc:4082:23: note: Technically the member function 'rtengine::ImProcFunctions::luminanceCurve' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:4102:188: style:inconclusive: Function 'chromiLuminanceCurve' argument 8 names different: declaration 'satclcurve' definition 'lhskcurve'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:234:175: note: Function 'chromiLuminanceCurve' argument 8 names different: declaration 'satclcurve' definition 'lhskcurve'. rawtherapee-5.12/rtengine/improcfun.cc:4102:188: note: Function 'chromiLuminanceCurve' argument 8 names different: declaration 'satclcurve' definition 'lhskcurve'. 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:4102:340: style:inconclusive: Function 'chromiLuminanceCurve' argument 18 names different: declaration 'histLurve' definition 'histLCurve'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:234:327: note: Function 'chromiLuminanceCurve' argument 18 names different: declaration 'histLurve' definition 'histLCurve'. rawtherapee-5.12/rtengine/improcfun.cc:4102:340: note: Function 'chromiLuminanceCurve' argument 18 names different: declaration 'histLurve' definition 'histLCurve'. 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:4108:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EUID_None [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:451:104: style:inconclusive: Function 'firstAnalysis' argument 3 names different: declaration 'vhist16' definition 'histogram'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:200:102: note: Function 'firstAnalysis' argument 3 names different: declaration 'vhist16' definition 'histogram'. rawtherapee-5.12/rtengine/improcfun.cc:451:104: note: Function 'firstAnalysis' argument 3 names different: declaration 'vhist16' definition 'histogram'. 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:451:61: style:inconclusive: Function 'firstAnalysis' argument 1 names different: declaration 'working' definition 'original'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:200:48: note: Function 'firstAnalysis' argument 1 names different: declaration 'working' definition 'original'. rawtherapee-5.12/rtengine/improcfun.cc:451:61: note: Function 'firstAnalysis' argument 1 names different: declaration 'working' definition 'original'. 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:4567:31: style: Local variable 'scale' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improcfun.h:143:12: note: Shadowed declaration rawtherapee-5.12/rtengine/improcfun.cc:4567:31: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:4610:31: style: Local variable 'scale' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improcfun.h:143:12: note: Shadowed declaration rawtherapee-5.12/rtengine/improcfun.cc:4610:31: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:462:11: style: Variable 'lumimulf' can be declared as const array [constVariable] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:4671:31: style: Local variable 'scale' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improcfun.h:143:12: note: Shadowed declaration rawtherapee-5.12/rtengine/improcfun.cc:4671:31: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:4852:112: style: Same expression 'clut' found multiple times in chain of '||' operators because 'clut' and 'clcutili' represent the same value. [knownConditionTrueFalse] rawtherapee-5.12/rtengine/improcfun.cc:4273:23: note: 'clut' is assigned value 'clcutili' here. rawtherapee-5.12/rtengine/improcfun.cc:4852:112: note: Same expression 'clut' found multiple times in chain of '||' operators because 'clut' and 'clcutili' represent the same value. 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:5067:23: style:inconclusive: Technically the member function 'rtengine::ImProcFunctions::EPDToneMapCIE' can be const. [functionConst] rawtherapee-5.12/rtengine/improcfun.h:293:10: note: Technically the member function 'rtengine::ImProcFunctions::EPDToneMapCIE' can be const. rawtherapee-5.12/rtengine/improcfun.cc:5067:23: note: Technically the member function 'rtengine::ImProcFunctions::EPDToneMapCIE' can be const. 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:5185:12: style: Variable 'a' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:5186:12: style: Variable 'b' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:520:103: style:inconclusive: Function 'ciecam_02float' argument 8 names different: declaration 'customColCurve' definition 'customColCurve2'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:229:90: note: Function 'ciecam_02float' argument 8 names different: declaration 'customColCurve' definition 'customColCurve2'. rawtherapee-5.12/rtengine/improcfun.cc:520:103: note: Function 'ciecam_02float' argument 8 names different: declaration 'customColCurve' definition 'customColCurve2'. 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:5273:23: style:inconclusive: Technically the member function 'rtengine::ImProcFunctions::EPDToneMap' can be const. [functionConst] rawtherapee-5.12/rtengine/improcfun.h:291:10: note: Technically the member function 'rtengine::ImProcFunctions::EPDToneMap' can be const. rawtherapee-5.12/rtengine/improcfun.cc:5273:23: note: Technically the member function 'rtengine::ImProcFunctions::EPDToneMap' can be const. 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:5527:22: style: Floating-point cast causes loss of precision. [suspiciousFloatingPointCast] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:5537:17: style: float result is assigned to double variable. If the variable is double to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:5710:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::rgb2lab' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:600:10: note: Technically the member function 'rtengine::ImProcFunctions::rgb2lab' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/improcfun.cc:5710:23: note: Technically the member function 'rtengine::ImProcFunctions::rgb2lab' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:5741:196: style:inconclusive: Function 'rgb2lab' argument 11 names different: declaration 'multithread' definition 'multiThread'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:147:190: note: Function 'rgb2lab' argument 11 names different: declaration 'multithread' definition 'multiThread'. rawtherapee-5.12/rtengine/improcfun.cc:5741:196: note: Function 'rgb2lab' argument 11 names different: declaration 'multithread' definition 'multiThread'. 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:5780:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cmsFLAGS_NOOPTIMIZE [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:5869:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::lab2rgb' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:601:10: note: Technically the member function 'rtengine::ImProcFunctions::lab2rgb' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/improcfun.cc:5869:23: note: Technically the member function 'rtengine::ImProcFunctions::lab2rgb' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:5939:23: style:inconclusive: Technically the member function 'rtengine::ImProcFunctions::colorToningLabGrid' can be const. [functionConst] rawtherapee-5.12/rtengine/improcfun.h:575:10: note: Technically the member function 'rtengine::ImProcFunctions::colorToningLabGrid' can be const. rawtherapee-5.12/rtengine/improcfun.cc:5939:23: note: Technically the member function 'rtengine::ImProcFunctions::colorToningLabGrid' can be const. 2.18.0 rawtherapee-5.12/rtengine/improcfun.cc:785:20: style: The scope of the variable 'sum' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipdehaze.cc:106:113: style: Parameter 'dst' can be declared as reference to const [constParameterReference] 2.18.0 rawtherapee-5.12/rtengine/ipdehaze.cc:165:123: style: Parameter 'dst' can be declared as reference to const [constParameterReference] 2.18.0 rawtherapee-5.12/rtengine/ipdehaze.cc:219:17: style: Redundant initialization for 'darklim'. The initialized value is overwritten before it is read. [redundantInitialization] rawtherapee-5.12/rtengine/ipdehaze.cc:201:19: note: darklim is initialized rawtherapee-5.12/rtengine/ipdehaze.cc:219:17: note: darklim is overwritten 2.18.0 rawtherapee-5.12/rtengine/ipdehaze.cc:234:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/ipdehaze.cc:243:20: style: Variable 'p' can be declared as reference to const [constVariableReference] 2.18.0 rawtherapee-5.12/rtengine/ipdehaze.cc:256:20: style: Redundant initialization for 'bright_lim'. The initialized value is overwritten before it is read. [redundantInitialization] rawtherapee-5.12/rtengine/ipdehaze.cc:238:22: note: bright_lim is initialized rawtherapee-5.12/rtengine/ipdehaze.cc:256:20: note: bright_lim is overwritten 2.18.0 rawtherapee-5.12/rtengine/ipdehaze.cc:262:16: style: Variable 'p' can be declared as reference to const [constVariableReference] 2.18.0 rawtherapee-5.12/rtengine/ipdehaze.cc:308:42: style:inconclusive: Function 'dehaze' argument 1 names different: declaration 'rgb' definition 'img'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:571:29: note: Function 'dehaze' argument 1 names different: declaration 'rgb' definition 'img'. rawtherapee-5.12/rtengine/ipdehaze.cc:308:42: note: Function 'dehaze' argument 1 names different: declaration 'rgb' definition 'img'. 2.18.0 rawtherapee-5.12/rtengine/ipdehaze.cc:359:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/ipdehaze.cc:457:45: style:inconclusive: Function 'dehazeloc' argument 1 names different: declaration 'rgb' definition 'img'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:572:32: note: Function 'dehazeloc' argument 1 names different: declaration 'rgb' definition 'img'. rawtherapee-5.12/rtengine/ipdehaze.cc:457:45: note: Function 'dehazeloc' argument 1 names different: declaration 'rgb' definition 'img'. 2.18.0 rawtherapee-5.12/rtengine/ipdehaze.cc:479:9: style: The scope of the variable 'whit' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipdehaze.cc:519:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/ipgrain.cc:143:12: performance:inconclusive: Technically the member function 'rtengine::::GrainEvaluator::dot' can be static (but you may consider moving to unnamed namespace). [functionStatic] 2.18.0 rawtherapee-5.12/rtengine/ipgrain.cc:148:11: performance:inconclusive: Technically the member function 'rtengine::::GrainEvaluator::FASTFLOOR' can be static (but you may consider moving to unnamed namespace). [functionStatic] 2.18.0 rawtherapee-5.12/rtengine/ipgrain.cc:298:23: style: Variable 'f' can be declared as const array [constVariable] 2.18.0 rawtherapee-5.12/rtengine/ipgrain.cc:299:23: style: Variable 'a' can be declared as const array [constVariable] 2.18.0 rawtherapee-5.12/rtengine/ipgrain.cc:308:11: performance:inconclusive: Technically the member function 'rtengine::::GrainEvaluator::paper_resp' can be static (but you may consider moving to unnamed namespace). [functionStatic] 2.18.0 rawtherapee-5.12/rtengine/ipgrain.cc:319:11: performance:inconclusive: Technically the member function 'rtengine::::GrainEvaluator::paper_resp_inverse' can be static (but you may consider moving to unnamed namespace). [functionStatic] 2.18.0 rawtherapee-5.12/rtengine/ipgrain.cc:344:11: style:inconclusive: Technically the member function 'rtengine::::GrainEvaluator::lut_lookup' can be const. [functionConst] 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:1649:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cmsSigRedTRCTag [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:1655:24: style: Variable 'redT' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:1656:24: style: Variable 'greenT' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:1657:24: style: Variable 'blueT' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:1697:24: style: Local variable 'p' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplab2rgb.cc:951:12: note: Shadowed declaration rawtherapee-5.12/rtengine/iplab2rgb.cc:1697:24: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:205:24: style: Variable 'rL' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:206:24: style: Variable 'ra' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:207:24: style: Variable 'rb' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:274:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cmsFLAGS_NOOPTIMIZE [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:282:24: style: The scope of the variable 'data' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:302:24: style: Variable 'rL' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:303:24: style: Variable 'ra' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:304:24: style: Variable 'rb' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:366:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cmsFLAGS_NOOPTIMIZE [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:389:20: style: Variable 'rL' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:390:20: style: Variable 'ra' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:391:20: style: Variable 'rb' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:417:23: style:inconclusive: Technically the member function 'rtengine::ImProcFunctions::preserv' can be const. [functionConst] rawtherapee-5.12/rtengine/improcfun.h:593:10: note: Technically the member function 'rtengine::ImProcFunctions::preserv' can be const. rawtherapee-5.12/rtengine/iplab2rgb.cc:417:23: note: Technically the member function 'rtengine::ImProcFunctions::preserv' can be const. 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:43:53: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MAXVALF [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:560:13: style: Redundant initialization for 'out'. The initialized value is overwritten before it is read. [redundantInitialization] rawtherapee-5.12/rtengine/iplab2rgb.cc:557:16: note: out is initialized rawtherapee-5.12/rtengine/iplab2rgb.cc:560:13: note: out is overwritten 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:569:12: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] rawtherapee-5.12/rtengine/iplab2rgb.cc:571:7: note: Found duplicate branches for 'if' and 'else'. rawtherapee-5.12/rtengine/iplab2rgb.cc:569:12: note: Found duplicate branches for 'if' and 'else'. 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:632:141: style: Parameter 'meanxe' can be declared as reference to const [constParameterReference] 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:632:156: style: Parameter 'meanye' can be declared as reference to const [constParameterReference] 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:637:12: style: The scope of the variable 'wb2' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:76:16: style: Variable 'rL' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:77:16: style: Variable 'ra' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/iplab2rgb.cc:78:16: style: Variable 'rb' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/iplabregions.cc:139:27: style: Variable 'hm' can be declared as reference to const [constVariableReference] 2.18.0 rawtherapee-5.12/rtengine/iplabregions.cc:140:27: style: Variable 'cm' can be declared as reference to const [constVariableReference] 2.18.0 rawtherapee-5.12/rtengine/iplabregions.cc:141:27: style: Variable 'lm' can be declared as reference to const [constVariableReference] 2.18.0 rawtherapee-5.12/rtengine/iplabregions.cc:150:57: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable maskBlur [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iplabregions.cc:78:15: style: Variable 'r' can be declared as reference to const [constVariableReference] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:10005:23: style: The scope of the variable 'factorx' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:10056:44: style: Parameter 'dataor' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:10056:60: style: Parameter 'datain' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:10072:29: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:10073:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:10079:29: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:10084:25: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:10130:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::fftw_convol_blur' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:330:10: note: Technically the member function 'rtengine::ImProcFunctions::fftw_convol_blur' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iplocallab.cc:10130:23: note: Technically the member function 'rtengine::ImProcFunctions::fftw_convol_blur' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:10171:11: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:10175:16: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:10176:19: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:10297:26: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:10298:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:10304:27: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:10336:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::fftw_tile_blur' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:332:10: note: Technically the member function 'rtengine::ImProcFunctions::fftw_tile_blur' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iplocallab.cc:10336:23: note: Technically the member function 'rtengine::ImProcFunctions::fftw_tile_blur' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:10356:169: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FFTW_MEASURE [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:10640:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::Compresslevels' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:288:10: note: Technically the member function 'rtengine::ImProcFunctions::Compresslevels' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iplocallab.cc:10640:23: note: Technically the member function 'rtengine::ImProcFunctions::Compresslevels' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:11317:25: style: float result is assigned to double variable. If the variable is double to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:11758:13: style: Local variable 'W_Level' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:11215:9: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:11758:13: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:11759:13: style: Local variable 'H_Level' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:11216:9: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:11759:13: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:11760:16: style: Local variable 'wav_L0' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:11217:12: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:11760:16: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:11831:145: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FFTW_MEASURE [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:1190:119: style: Same expression 'llSHMaskinv==0' found multiple times in chain of '&&' operators. [duplicateExpression] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:12221:22: style: Variable 'edge' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:12238:23: style: The scope of the variable 'mxsl' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:12276:27: style: Variable 'nvlh' can be declared as const array [constVariable] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:12277:27: style: Variable 'nvll' can be declared as const array [constVariable] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:12412:23: style: The scope of the variable 'maxccoarse' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:12946:26: style: Variable 'edge' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:12965:27: style: The scope of the variable 'mxsl' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:13006:31: style: Variable 'nvlh' can be declared as const array [constVariable] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:13007:31: style: Variable 'nvll' can be declared as const array [constVariable] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:13140:27: style: The scope of the variable 'maxccoarse' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:13584:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::clarimerge' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:232:10: note: Technically the member function 'rtengine::ImProcFunctions::clarimerge' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iplocallab.cc:13584:23: note: Technically the member function 'rtengine::ImProcFunctions::clarimerge' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:13866:37: style: The scope of the variable 'chr' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:13886:28: style: Redundant initialization for 'Lprov1'. The initialized value is overwritten before it is read. [redundantInitialization] rawtherapee-5.12/rtengine/iplocallab.cc:13854:34: note: Lprov1 is initialized rawtherapee-5.12/rtengine/iplocallab.cc:13886:28: note: Lprov1 is overwritten 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14533:29: style: Expression 'log(1 + x)' can be replaced by 'log1p(x)' to avoid loss of precision. [unpreciseMathCall] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14535:21: style: Expression 'log(1 + x)' can be replaced by 'log1p(x)' to avoid loss of precision. [unpreciseMathCall] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14609:29: style: Expression 'log(1 + x)' can be replaced by 'log1p(x)' to avoid loss of precision. [unpreciseMathCall] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14611:21: style: Expression 'log(1 + x)' can be replaced by 'log1p(x)' to avoid loss of precision. [unpreciseMathCall] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14696:12: error: Uninitialized struct member: c.HPT [uninitStructMember] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14696:12: error: Uninitialized struct member: c.LPT [uninitStructMember] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14696:12: error: Uninitialized struct member: c.SPT [uninitStructMember] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14696:12: error: Uninitialized struct member: c.a1 [uninitStructMember] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14696:12: error: Uninitialized struct member: c.a2 [uninitStructMember] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14696:12: error: Uninitialized struct member: c.a3 [uninitStructMember] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14696:12: error: Uninitialized struct member: c.a4 [uninitStructMember] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14696:12: error: Uninitialized struct member: c.b1 [uninitStructMember] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14696:12: error: Uninitialized struct member: c.b2 [uninitStructMember] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14696:12: error: Uninitialized struct member: c.b3 [uninitStructMember] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14696:12: error: Uninitialized struct member: c.b4 [uninitStructMember] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14696:12: error: Uninitialized struct member: c.c2 [uninitStructMember] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14696:12: error: Uninitialized struct member: c.c3 [uninitStructMember] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14696:12: error: Uninitialized struct member: c.d2 [uninitStructMember] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14696:12: error: Uninitialized struct member: c.d3 [uninitStructMember] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14696:12: error: Uninitialized struct member: c.e2 [uninitStructMember] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14696:12: error: Uninitialized struct member: c.e3 [uninitStructMember] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14696:12: error: Uninitialized struct member: c.q [uninitStructMember] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14696:12: error: Uninitialized struct member: c.q0 [uninitStructMember] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14696:12: error: Uninitialized struct member: c.q1 [uninitStructMember] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14696:12: error: Uninitialized struct member: c.qlp [uninitStructMember] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14696:12: error: Uninitialized struct member: c.qwp [uninitStructMember] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14696:12: warning: Uninitialized variables: c.LPT, c.SPT, c.HPT [uninitvar] rawtherapee-5.12/rtengine/iplocallab.cc:14531:16: note: Assuming condition is true rawtherapee-5.12/rtengine/iplocallab.cc:14696:12: note: Uninitialized variables: c.LPT, c.SPT, c.HPT 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14700:114: performance: Function parameter 'c' should be passed by const reference. [passedByValue] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:14895:11: style: The scope of the variable 'epsi0' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:15165:27: style: Local variable 'rad' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:15074:19: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:15165:27: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:16160:31: style: Local variable 'rad' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:16108:23: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:16160:31: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:16612:23: style: The scope of the variable 'divchro' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:17787:39: style: Local variable 'dummy' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:17711:25: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:17787:39: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:17788:29: style: Local variable 'ill' shadows outer argument [shadowArgument] rawtherapee-5.12/rtengine/iplocallab.cc:14855:240: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:17788:29: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:17790:31: style: Local variable 'rdx' shadows outer argument [shadowArgument] rawtherapee-5.12/rtengine/iplocallab.cc:14855:101: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:17790:31: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:17790:36: style: Local variable 'rdy' shadows outer argument [shadowArgument] rawtherapee-5.12/rtengine/iplocallab.cc:14855:113: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:17790:36: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:17790:41: style: Local variable 'grx' shadows outer argument [shadowArgument] rawtherapee-5.12/rtengine/iplocallab.cc:14855:125: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:17790:41: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:17790:46: style: Local variable 'gry' shadows outer argument [shadowArgument] rawtherapee-5.12/rtengine/iplocallab.cc:14855:137: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:17790:46: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:17790:51: style: Local variable 'blx' shadows outer argument [shadowArgument] rawtherapee-5.12/rtengine/iplocallab.cc:14855:149: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:17790:51: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:17790:56: style: Local variable 'bly' shadows outer argument [shadowArgument] rawtherapee-5.12/rtengine/iplocallab.cc:14855:161: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:17790:56: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:17791:31: style: Local variable 'meanx' shadows outer argument [shadowArgument] rawtherapee-5.12/rtengine/iplocallab.cc:14855:173: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:17791:31: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:17791:38: style: Local variable 'meany' shadows outer argument [shadowArgument] rawtherapee-5.12/rtengine/iplocallab.cc:14855:187: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:17791:38: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:17791:45: style: Local variable 'meanxe' shadows outer argument [shadowArgument] rawtherapee-5.12/rtengine/iplocallab.cc:14855:201: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:17791:45: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:17791:53: style: Local variable 'meanye' shadows outer argument [shadowArgument] rawtherapee-5.12/rtengine/iplocallab.cc:14855:216: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:17791:53: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:17854:31: style: The scope of the variable 'gamma1' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:17988:49: style: Local variable 'radius' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:14919:17: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:17988:49: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:18062:49: style: Local variable 'B' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:17810:31: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:18062:49: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:18166:31: style: Local variable 'rad' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:17705:19: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:18166:31: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:18167:31: style: The scope of the variable 'stren' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:18718:27: style: Local variable 'gamma' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:18587:19: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:18718:27: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:18756:31: style: Local variable 'rad' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:18585:19: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:18756:31: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:18939:35: style: Variable 'mergfile' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:19548:39: style: Local variable 'rad' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:19401:23: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:19548:39: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2035:290: style: Same expression 'llSHMask==0' found multiple times in chain of '&&' operators. [duplicateExpression] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2036:275: style: Same expression 'llSHMask==0' found multiple times in chain of '&&' operators. [duplicateExpression] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2037:237: style: Same expression 'lllcMask==0' found multiple times in chain of '&&' operators. [duplicateExpression] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2040:260: style: Same expression 'llcbMask==0' found multiple times in chain of '&&' operators. [duplicateExpression] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2041:240: style: Same expression 'llcbMask==0' found multiple times in chain of '&&' operators. [duplicateExpression] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2042:217: style: Same expression 'llcbMask==0' found multiple times in chain of '&&' operators. [duplicateExpression] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2043:257: style: Same expression 'llcbMask==0' found multiple times in chain of '&&' operators. [duplicateExpression] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2044:255: style: Same expression 'llcbMask==0' found multiple times in chain of '&&' operators. [duplicateExpression] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:21477:18: style: Local variable 'delt' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:15225:10: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:21477:18: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:21552:28: style: The scope of the variable 'wip' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:21557:28: style: The scope of the variable 'wp' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:21574:35: style: Local variable 'dummy' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:21476:25: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:21574:35: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:21662:50: warning: Redundant code: Found unused member access. [constStatement] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:21677:61: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:21677:61: style:inconclusive: Boolean expression 'params->locallab.spots.at(sp).logcie' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:21698:26: style: The scope of the variable 'ksr' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:21699:26: style: The scope of the variable 'ksb' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:21700:26: style: The scope of the variable 'ksg' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:21935:30: style: Local variable 'scale' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improcfun.h:143:12: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:21935:30: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:22144:11: style: The scope of the variable 'epsi' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2317:24: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::sigmoid_main' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:439:10: note: Technically the member function 'rtengine::ImProcFunctions::sigmoid_main' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iplocallab.cc:2317:24: note: Technically the member function 'rtengine::ImProcFunctions::sigmoid_main' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2336:11: style: Local variable 'display_black_target' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:2221:13: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:2336:11: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2360:24: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::sigmoid_QJ' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:440:10: note: Technically the member function 'rtengine::ImProcFunctions::sigmoid_QJ' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iplocallab.cc:2360:24: note: Technically the member function 'rtengine::ImProcFunctions::sigmoid_QJ' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2368:11: style: Local variable 'display_black_target' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:2221:13: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:2368:11: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2373:11: style: Redundant initialization for 'value'. The initialized value is overwritten before it is read. [redundantInitialization] rawtherapee-5.12/rtengine/iplocallab.cc:2372:17: note: value is initialized rawtherapee-5.12/rtengine/iplocallab.cc:2373:11: note: value is overwritten 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2437:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::mean_sig' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:356:10: note: Technically the member function 'rtengine::ImProcFunctions::mean_sig' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iplocallab.cc:2437:23: note: Technically the member function 'rtengine::ImProcFunctions::mean_sig' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2544:11: style: The scope of the variable 'ac' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2545:11: style: The scope of the variable 'bc' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2730:120: style: Parameter 'Autogr' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2730:151: style: Parameter 'whits' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2730:164: style: Parameter 'blacks' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2730:177: style: Parameter 'whitslog' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2730:193: style: Parameter 'blackslog' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2740:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable img [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2761:9: style: The scope of the variable 'whit' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2762:9: style: The scope of the variable 'blac' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2768:9: style: The scope of the variable 'whitlog' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2769:9: style: The scope of the variable 'blaclog' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2868:16: style: The scope of the variable 'fcomp' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2900:25: style: Local variable 'params' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improcfun.h:142:35: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:2900:25: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:2950:25: style: Local variable 'params' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improcfun.h:142:35: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:2950:25: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:3022:24: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::rolloff_freeman_function' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:437:11: note: Technically the member function 'rtengine::ImProcFunctions::rolloff_freeman_function' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iplocallab.cc:3022:24: note: Technically the member function 'rtengine::ImProcFunctions::rolloff_freeman_function' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:3028:24: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::scene_referred_contrast' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:438:11: note: Technically the member function 'rtengine::ImProcFunctions::scene_referred_contrast' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iplocallab.cc:3028:24: note: Technically the member function 'rtengine::ImProcFunctions::scene_referred_contrast' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:3144:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::loccont' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:321:10: note: Technically the member function 'rtengine::ImProcFunctions::loccont' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iplocallab.cc:3144:23: note: Technically the member function 'rtengine::ImProcFunctions::loccont' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:3183:25: style: Local variable 'params' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improcfun.h:142:35: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:3183:25: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:3257:230: style:inconclusive: Function 'ciecamloc_02float' argument 19 names different: declaration 'lochhCurve' definition 'lochhCurvejz'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:225:397: note: Function 'ciecamloc_02float' argument 19 names different: declaration 'lochhCurve' definition 'lochhCurvejz'. rawtherapee-5.12/rtengine/iplocallab.cc:3257:230: note: Function 'ciecamloc_02float' argument 19 names different: declaration 'lochhCurve' definition 'lochhCurvejz'. 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:3257:262: style:inconclusive: Function 'ciecamloc_02float' argument 20 names different: declaration 'loclhCurve' definition 'loclhCurvejz'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:225:427: note: Function 'ciecamloc_02float' argument 20 names different: declaration 'loclhCurve' definition 'loclhCurvejz'. rawtherapee-5.12/rtengine/iplocallab.cc:3257:262: note: Function 'ciecamloc_02float' argument 20 names different: declaration 'loclhCurve' definition 'loclhCurvejz'. 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:3258:118: style:inconclusive: Function 'ciecamloc_02float' argument 27 names different: declaration 'comtsig' definition 'contsig'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:226:80: note: Function 'ciecamloc_02float' argument 27 names different: declaration 'comtsig' definition 'contsig'. rawtherapee-5.12/rtengine/iplocallab.cc:3258:118: note: Function 'ciecamloc_02float' argument 27 names different: declaration 'comtsig' definition 'contsig'. 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:3285:10: style: The scope of the variable 'z_cam' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:3286:10: style: The scope of the variable 'jabcie' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:3294:10: style: The scope of the variable 'issig' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:3315:11: style: The scope of the variable 'sumcamq01' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:3373:11: style: The scope of the variable 'th' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:3527:16: style: The scope of the variable 'kb' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:3533:16: style: The scope of the variable 'kbl' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:362:11: style: The scope of the variable 'a0' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:366:11: style: The scope of the variable 'b1' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:368:11: style: The scope of the variable 'b2' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:3801:11: style: The scope of the variable 'xw1' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:3801:22: style: The scope of the variable 'yw1' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:3801:33: style: The scope of the variable 'zw1' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:3860:12: style: The scope of the variable 'targetgraycor' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:3884:13: style: Local variable 'nc' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:3394:20: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:3884:13: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:3891:21: style: The scope of the variable 'azw' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:3891:26: style: The scope of the variable 'bzw' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:3992:16: style: The scope of the variable 'maxreal' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:4068:16: style: The scope of the variable 'base' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:4222:27: style: Variable 'mergfile' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:4249:23: style: The scope of the variable 'c_z' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:4319:32: style: Local variable 'hue' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:3733:11: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:4319:32: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:4348:29: style: Local variable 'epsil' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:3851:17: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:4348:29: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:4404:32: style: Local variable 'f' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:3394:11: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:4404:32: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:4680:15: style: The scope of the variable 'base' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:4681:15: style: The scope of the variable 'linbaseor' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:4683:15: style: The scope of the variable 'gray' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:4703:19: style: Local variable 'targetgraycor' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:3860:12: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:4703:19: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:4709:25: style: Local variable 'log2' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:3863:18: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:4709:25: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:4873:30: style: The scope of the variable 'jp' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:4882:39: style: Local variable 'f' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:3394:11: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:4882:39: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:4992:39: style: Local variable 'dred' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:4945:31: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:4992:39: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:4993:39: style: Local variable 'protect_red' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:4946:31: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:4993:39: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:5004:39: style: Local variable 'dred' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:4945:31: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:5004:39: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:5005:39: style: Local variable 'protect_red' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:4946:31: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:5005:39: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:5018:39: style: Local variable 'dred' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:4945:31: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:5018:39: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:5019:39: style: Local variable 'protect_red' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/iplocallab.cc:4946:31: note: Shadowed declaration rawtherapee-5.12/rtengine/iplocallab.cc:5019:39: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:5149:23: style:inconclusive: Technically the member function 'rtengine::ImProcFunctions::softproc' can be const. [functionConst] rawtherapee-5.12/rtengine/improcfun.h:237:10: note: Technically the member function 'rtengine::ImProcFunctions::softproc' can be const. rawtherapee-5.12/rtengine/iplocallab.cc:5149:23: note: Technically the member function 'rtengine::ImProcFunctions::softproc' can be const. 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:5249:23: style:inconclusive: Technically the member function 'rtengine::ImProcFunctions::softprocess' can be const. [functionConst] rawtherapee-5.12/rtengine/improcfun.h:236:10: note: Technically the member function 'rtengine::ImProcFunctions::softprocess' can be const. rawtherapee-5.12/rtengine/iplocallab.cc:5249:23: note: Technically the member function 'rtengine::ImProcFunctions::softprocess' can be const. 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:5306:9: style: The scope of the variable 'bw' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:5307:9: style: The scope of the variable 'bh' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:5337:19: style: The scope of the variable 'bb' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:5420:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::addGaNoise' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:442:10: note: Technically the member function 'rtengine::ImProcFunctions::addGaNoise' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iplocallab.cc:5420:23: note: Technically the member function 'rtengine::ImProcFunctions::addGaNoise' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:5429:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RAND_MAX [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:5488:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::DeNoise_Local' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:481:10: note: Technically the member function 'rtengine::ImProcFunctions::DeNoise_Local' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iplocallab.cc:5488:23: note: Technically the member function 'rtengine::ImProcFunctions::DeNoise_Local' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:5646:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::DeNoise_Local2' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:482:10: note: Technically the member function 'rtengine::ImProcFunctions::DeNoise_Local2' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iplocallab.cc:5646:23: note: Technically the member function 'rtengine::ImProcFunctions::DeNoise_Local2' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:5806:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::InverseReti_Local' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:445:10: note: Technically the member function 'rtengine::ImProcFunctions::InverseReti_Local' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iplocallab.cc:5806:23: note: Technically the member function 'rtengine::ImProcFunctions::InverseReti_Local' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:5813:11: style: The scope of the variable 'refa' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:5814:11: style: The scope of the variable 'refb' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:5822:11: style: The scope of the variable 'radius' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:5926:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::InverseBlurNoise_Local' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:444:10: note: Technically the member function 'rtengine::ImProcFunctions::InverseBlurNoise_Local' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iplocallab.cc:5926:23: note: Technically the member function 'rtengine::ImProcFunctions::InverseBlurNoise_Local' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6112:21: style: Variable 'maxm' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6222:18: style: float result is assigned to double variable. If the variable is double to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6226:18: style: float result is assigned to double variable. If the variable is double to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6230:18: style: float result is assigned to double variable. If the variable is double to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6234:18: style: float result is assigned to double variable. If the variable is double to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6245:18: style: float result is assigned to double variable. If the variable is double to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6249:18: style: float result is assigned to double variable. If the variable is double to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6253:18: style: float result is assigned to double variable. If the variable is double to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6257:18: style: float result is assigned to double variable. If the variable is double to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6267:18: style: float result is assigned to double variable. If the variable is double to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6271:18: style: float result is assigned to double variable. If the variable is double to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6275:18: style: float result is assigned to double variable. If the variable is double to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6279:18: style: float result is assigned to double variable. If the variable is double to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6283:18: style: float result is assigned to double variable. If the variable is double to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6287:18: style: float result is assigned to double variable. If the variable is double to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6370:23: style:inconclusive: Technically the member function 'rtengine::ImProcFunctions::blendstruc' can be const. [functionConst] rawtherapee-5.12/rtengine/improcfun.h:448:10: note: Technically the member function 'rtengine::ImProcFunctions::blendstruc' can be const. rawtherapee-5.12/rtengine/iplocallab.cc:6370:23: note: Technically the member function 'rtengine::ImProcFunctions::blendstruc' can be const. 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6516:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::deltaEforMask' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:315:10: note: Technically the member function 'rtengine::ImProcFunctions::deltaEforMask' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iplocallab.cc:6516:23: note: Technically the member function 'rtengine::ImProcFunctions::deltaEforMask' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6621:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::laplacian' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:318:10: note: Technically the member function 'rtengine::ImProcFunctions::laplacian' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iplocallab.cc:6621:23: note: Technically the member function 'rtengine::ImProcFunctions::laplacian' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6662:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::discrete_laplacian_threshold' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:317:10: note: Technically the member function 'rtengine::ImProcFunctions::discrete_laplacian_threshold' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iplocallab.cc:6662:23: note: Technically the member function 'rtengine::ImProcFunctions::discrete_laplacian_threshold' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6667:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6718:25: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::cos_table' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:325:12: note: Technically the member function 'rtengine::ImProcFunctions::cos_table' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iplocallab.cc:6718:25: note: Technically the member function 'rtengine::ImProcFunctions::cos_table' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6723:26: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6724:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6794:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::mean_dt' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:324:10: note: Technically the member function 'rtengine::ImProcFunctions::mean_dt' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iplocallab.cc:6794:23: note: Technically the member function 'rtengine::ImProcFunctions::mean_dt' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6830:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6870:127: style: Parameter 'dE' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6896:20: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6899:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6904:23: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6914:23: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6936:29: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:6937:29: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:7262:17: style: The scope of the variable 'levred' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:7802:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::InverseSharp_Local' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:494:10: note: Technically the member function 'rtengine::ImProcFunctions::InverseSharp_Local' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iplocallab.cc:7802:23: note: Technically the member function 'rtengine::ImProcFunctions::InverseSharp_Local' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:7836:11: style: The scope of the variable 'radius' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:7948:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::Sharp_Local' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:492:10: note: Technically the member function 'rtengine::ImProcFunctions::Sharp_Local' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iplocallab.cc:7948:23: note: Technically the member function 'rtengine::ImProcFunctions::Sharp_Local' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:7975:11: style: The scope of the variable 'bbdark' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:8220:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::transit_shapedetect_retinex' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:476:10: note: Technically the member function 'rtengine::ImProcFunctions::transit_shapedetect_retinex' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iplocallab.cc:8220:23: note: Technically the member function 'rtengine::ImProcFunctions::transit_shapedetect_retinex' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:8688:23: style: The scope of the variable 'realstrchdE' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:9089:23: style:inconclusive: Technically the member function 'rtengine::ImProcFunctions::calc_ref' can be const. [functionConst] rawtherapee-5.12/rtengine/improcfun.h:358:10: note: Technically the member function 'rtengine::ImProcFunctions::calc_ref' can be const. rawtherapee-5.12/rtengine/iplocallab.cc:9089:23: note: Technically the member function 'rtengine::ImProcFunctions::calc_ref' can be const. 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:9089:72: style: Parameter 'transformed' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:9182:19: style: The scope of the variable 'radius' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:9437:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::BlurNoise_Local' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:446:10: note: Technically the member function 'rtengine::ImProcFunctions::BlurNoise_Local' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iplocallab.cc:9437:23: note: Technically the member function 'rtengine::ImProcFunctions::BlurNoise_Local' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/iplocallab.cc:9734:11: style: The scope of the variable 'bbdark' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipresize.cc:1132:16: style: Local variable 'resize' shadows outer function [shadowFunction] rawtherapee-5.12/rtengine/improcfun.h:245:10: note: Shadowed declaration rawtherapee-5.12/rtengine/ipresize.cc:1132:16: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/ipresize.cc:179:12: style: The scope of the variable 'imgAspectRatio' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipresize.cc:387:78: style:inconclusive: Function 'adjustResize' argument 2 names different: declaration 'newSize' definition 'bbox'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/ipresize.cc:111:73: note: Function 'adjustResize' argument 2 names different: declaration 'newSize' definition 'bbox'. rawtherapee-5.12/rtengine/ipresize.cc:387:78: note: Function 'adjustResize' argument 2 names different: declaration 'newSize' definition 'bbox'. 2.18.0 rawtherapee-5.12/rtengine/ipresize.cc:494:16: style: Variable 'border' is assigned a value that is never used. [unreadVariable] 2.18.0 rawtherapee-5.12/rtengine/ipresize.cc:540:59: style:inconclusive: Function 'resizeForFixedFrame' argument 1 names different: declaration 'resize' definition 'args'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/ipresize.cc:116:54: note: Function 'resizeForFixedFrame' argument 1 names different: declaration 'resize' definition 'args'. rawtherapee-5.12/rtengine/ipresize.cc:540:59: note: Function 'resizeForFixedFrame' argument 1 names different: declaration 'resize' definition 'args'. 2.18.0 rawtherapee-5.12/rtengine/ipresize.cc:565:53: style:inconclusive: Function 'resizeForBBox' argument 1 names different: declaration 'resize' definition 'args'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/ipresize.cc:117:48: note: Function 'resizeForBBox' argument 1 names different: declaration 'resize' definition 'args'. rawtherapee-5.12/rtengine/ipresize.cc:565:53: note: Function 'resizeForBBox' argument 1 names different: declaration 'resize' definition 'args'. 2.18.0 rawtherapee-5.12/rtengine/ipresize.cc:771:19: style: Consider using std::fill algorithm instead of a raw loop. [useStlAlgorithm] 2.18.0 rawtherapee-5.12/rtengine/ipresize.cc:814:25: style: Variable 'wh' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/ipresize.cc:968:25: style: Variable 'wh' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/ipretinex.cc:1121:15: style: The scope of the variable 'radius' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipretinex.cc:1268:14: style: Local variable 'scale' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improcfun.h:143:12: note: Shadowed declaration rawtherapee-5.12/rtengine/ipretinex.cc:1268:14: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/ipretinex.cc:189:22: performance:inconclusive: Technically the member function 'rtengine::RawImageSource::MSR' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/rawimagesource.h:199:10: note: Technically the member function 'rtengine::RawImageSource::MSR' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/ipretinex.cc:189:22: note: Technically the member function 'rtengine::RawImageSource::MSR' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/ipretinex.cc:939:11: style: The scope of the variable 'radiusb' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipshadowshighlights.cc:53:16: style: Local variable 'rgb2lab' shadows outer function [shadowFunction] rawtherapee-5.12/rtengine/improcfun.h:147:17: note: Shadowed declaration rawtherapee-5.12/rtengine/ipshadowshighlights.cc:53:16: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/ipshadowshighlights.cc:61:16: style: Local variable 'lab2rgb' shadows outer function [shadowFunction] rawtherapee-5.12/rtengine/improcfun.h:583:17: note: Shadowed declaration rawtherapee-5.12/rtengine/ipshadowshighlights.cc:61:16: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/ipsharpen.cc:164:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::deconvsharpening' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:269:10: note: Technically the member function 'rtengine::ImProcFunctions::deconvsharpening' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/ipsharpen.cc:164:23: note: Technically the member function 'rtengine::ImProcFunctions::deconvsharpening' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/ipsharpen.cc:164:68: style:inconclusive: Function 'deconvsharpening' argument 2 names different: declaration 'buffer' definition 'tmp'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:269:54: note: Function 'deconvsharpening' argument 2 names different: declaration 'buffer' definition 'tmp'. rawtherapee-5.12/rtengine/ipsharpen.cc:164:68: note: Function 'deconvsharpening' argument 2 names different: declaration 'buffer' definition 'tmp'. 2.18.0 rawtherapee-5.12/rtengine/ipsharpen.cc:185:29: style: The scope of the variable 'blur' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipsharpen.cc:233:33: style: Variable 'blur' can be declared as reference to const [constVariableReference] 2.18.0 rawtherapee-5.12/rtengine/ipsharpen.cc:247:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::deconvsharpeningloc' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:270:10: note: Technically the member function 'rtengine::ImProcFunctions::deconvsharpeningloc' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/ipsharpen.cc:247:23: note: Technically the member function 'rtengine::ImProcFunctions::deconvsharpeningloc' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/ipsharpen.cc:247:71: style:inconclusive: Function 'deconvsharpeningloc' argument 2 names different: declaration 'buffer' definition 'tmp'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:270:57: note: Function 'deconvsharpeningloc' argument 2 names different: declaration 'buffer' definition 'tmp'. rawtherapee-5.12/rtengine/ipsharpen.cc:247:71: note: Function 'deconvsharpeningloc' argument 2 names different: declaration 'buffer' definition 'tmp'. 2.18.0 rawtherapee-5.12/rtengine/ipsharpen.cc:277:29: style: The scope of the variable 'blur' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipsharpen.cc:303:9: style: The scope of the variable 'itera' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipsharpen.cc:334:33: style: Variable 'blur' can be declared as reference to const [constVariableReference] 2.18.0 rawtherapee-5.12/rtengine/ipsharpen.cc:425:46: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ipsharpen.cc:502:23: style:inconclusive: Technically the member function 'rtengine::ImProcFunctions::MLmicrocontrast' can be const. [functionConst] rawtherapee-5.12/rtengine/improcfun.h:273:10: note: Technically the member function 'rtengine::ImProcFunctions::MLmicrocontrast' can be const. rawtherapee-5.12/rtengine/ipsharpen.cc:502:23: note: Technically the member function 'rtengine::ImProcFunctions::MLmicrocontrast' can be const. 2.18.0 rawtherapee-5.12/rtengine/ipsharpen.cc:745:62: style:inconclusive: Function 'sharpeningcam' argument 2 names different: declaration 'buffer' definition 'b2'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:240:48: note: Function 'sharpeningcam' argument 2 names different: declaration 'buffer' definition 'b2'. rawtherapee-5.12/rtengine/ipsharpen.cc:745:62: note: Function 'sharpeningcam' argument 2 names different: declaration 'buffer' definition 'b2'. 2.18.0 rawtherapee-5.12/rtengine/ipsharpen.cc:795:50: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/ipsharpenedges.cc:66:23: style:inconclusive: Technically the member function 'rtengine::ImProcFunctions::MLsharpen' can be const. [functionConst] rawtherapee-5.12/rtengine/improcfun.h:272:10: note: Technically the member function 'rtengine::ImProcFunctions::MLsharpen' can be const. rawtherapee-5.12/rtengine/ipsharpenedges.cc:66:23: note: Technically the member function 'rtengine::ImProcFunctions::MLsharpen' can be const. 2.18.0 rawtherapee-5.12/rtengine/ipsoftlight.cc:38:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MAXVALF [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iptoneequalizer.cc:188:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TYPE_RGB_FLT [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/iptoneequalizer.cc:348:23: style:inconclusive: Technically the member function 'rtengine::ImProcFunctions::toneEqualizer' can be const. [functionConst] rawtherapee-5.12/rtengine/improcfun.h:579:10: note: Technically the member function 'rtengine::ImProcFunctions::toneEqualizer' can be const. rawtherapee-5.12/rtengine/iptoneequalizer.cc:348:23: note: Technically the member function 'rtengine::ImProcFunctions::toneEqualizer' can be const. 2.18.0 rawtherapee-5.12/rtengine/iptransform.cc:1397:16: style: Local variable 'scale' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improcfun.h:143:12: note: Shadowed declaration rawtherapee-5.12/rtengine/iptransform.cc:1397:16: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/iptransform.cc:1489:207: error: Using object that points to local variable 'pLCPMap' that is out of scope. [invalidLifetime] rawtherapee-5.12/rtengine/iptransform.cc:1487:30: note: Raw pointer to smart pointer created here. rawtherapee-5.12/rtengine/iptransform.cc:1486:47: note: Variable created here. rawtherapee-5.12/rtengine/iptransform.cc:1489:207: note: Using object that points to local variable 'pLCPMap' that is out of scope. 2.18.0 rawtherapee-5.12/rtengine/iptransform.cc:671:12: style: The scope of the variable 'focalLen' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iptransform.cc:672:12: style: The scope of the variable 'focalLen35mm' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iptransform.cc:673:11: style: The scope of the variable 'focusDist' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iptransform.cc:674:12: style: The scope of the variable 'fNumber' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/iptransform.cc:704:37: style: Unused variable: tmpimg [unusedVariable] 2.18.0 rawtherapee-5.12/rtengine/iptransform.cc:717:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::calcVignettingParams' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:146:10: note: Technically the member function 'rtengine::ImProcFunctions::calcVignettingParams' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iptransform.cc:717:23: note: Technically the member function 'rtengine::ImProcFunctions::calcVignettingParams' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/iptransform.cc:821:24: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::calcGradientFactor' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:199:11: note: Technically the member function 'rtengine::ImProcFunctions::calcGradientFactor' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/iptransform.cc:821:24: note: Technically the member function 'rtengine::ImProcFunctions::calcGradientFactor' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/ipvibrance.cc:39:40: style: Parameter 'diagCurve' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:1179:33: style: The scope of the variable 'edge' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:1365:56: style: Variable 'WavL42' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:1366:56: style: Variable 'WavL52' can be declared as pointer to const [constVariablePointer] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:2274:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::Aver' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:519:10: note: Technically the member function 'rtengine::ImProcFunctions::Aver' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/ipwavelet.cc:2274:23: note: Technically the member function 'rtengine::ImProcFunctions::Aver' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:2274:50: style:inconclusive: Function 'Aver' argument 1 names different: declaration 'HH_Coeffs' definition 'DataList'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:519:28: note: Function 'Aver' argument 1 names different: declaration 'HH_Coeffs' definition 'DataList'. rawtherapee-5.12/rtengine/ipwavelet.cc:2274:50: note: Function 'Aver' argument 1 names different: declaration 'HH_Coeffs' definition 'DataList'. 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:2329:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::Sigma' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:520:10: note: Technically the member function 'rtengine::ImProcFunctions::Sigma' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/ipwavelet.cc:2329:23: note: Technically the member function 'rtengine::ImProcFunctions::Sigma' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:2329:51: style:inconclusive: Function 'Sigma' argument 1 names different: declaration 'HH_Coeffs' definition 'DataList'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:520:29: note: Function 'Sigma' argument 1 names different: declaration 'HH_Coeffs' definition 'DataList'. rawtherapee-5.12/rtengine/ipwavelet.cc:2329:51: note: Function 'Sigma' argument 1 names different: declaration 'HH_Coeffs' definition 'DataList'. 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:2380:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::calceffect' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:517:10: note: Technically the member function 'rtengine::ImProcFunctions::calceffect' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/ipwavelet.cc:2380:23: note: Technically the member function 'rtengine::ImProcFunctions::calceffect' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:2380:52: style: Parameter 'mean' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:2380:65: style: Parameter 'sigma' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:2476:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::CompressDR' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:287:10: note: Technically the member function 'rtengine::ImProcFunctions::CompressDR' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/ipwavelet.cc:2476:23: note: Technically the member function 'rtengine::ImProcFunctions::CompressDR' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:2561:23: style:inconclusive: Technically the member function 'rtengine::ImProcFunctions::EPDToneMapResid' can be const. [functionConst] rawtherapee-5.12/rtengine/improcfun.h:286:10: note: Technically the member function 'rtengine::ImProcFunctions::EPDToneMapResid' can be const. rawtherapee-5.12/rtengine/ipwavelet.cc:2561:23: note: Technically the member function 'rtengine::ImProcFunctions::EPDToneMapResid' can be const. 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:2618:50: style:inconclusive: Function 'WaveletcontAllL' argument 1 names different: declaration 'lab' definition 'labco'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:500:37: note: Function 'WaveletcontAllL' argument 1 names different: declaration 'lab' definition 'labco'. rawtherapee-5.12/rtengine/ipwavelet.cc:2618:50: note: Function 'WaveletcontAllL' argument 1 names different: declaration 'lab' definition 'labco'. 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:2869:31: style: The scope of the variable 'blipinfl' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:2985:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::WaveletAandBAllAB' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:505:10: note: Technically the member function 'rtengine::ImProcFunctions::WaveletAandBAllAB' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/ipwavelet.cc:2985:23: note: Technically the member function 'rtengine::ImProcFunctions::WaveletAandBAllAB' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:2986:75: style: Parameter 'hhCurve' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:2986:75: style:inconclusive: Function 'WaveletAandBAllAB' argument 4 names different: declaration 'hhcurve' definition 'hhCurve'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:506:47: note: Function 'WaveletAandBAllAB' argument 4 names different: declaration 'hhcurve' definition 'hhCurve'. rawtherapee-5.12/rtengine/ipwavelet.cc:2986:75: note: Function 'WaveletAandBAllAB' argument 4 names different: declaration 'hhcurve' definition 'hhCurve'. 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:3051:116: style:inconclusive: Function 'WaveletcontAllAB' argument 4 names different: declaration 'WaveletCoeffs_a' definition 'WaveletCoeffs_ab'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:503:100: note: Function 'WaveletcontAllAB' argument 4 names different: declaration 'WaveletCoeffs_a' definition 'WaveletCoeffs_ab'. rawtherapee-5.12/rtengine/ipwavelet.cc:3051:116: note: Function 'WaveletcontAllAB' argument 4 names different: declaration 'WaveletCoeffs_a' definition 'WaveletCoeffs_ab'. 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:3051:51: style:inconclusive: Function 'WaveletcontAllAB' argument 1 names different: declaration 'lab' definition 'labco'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:503:38: note: Function 'WaveletcontAllAB' argument 1 names different: declaration 'lab' definition 'labco'. rawtherapee-5.12/rtengine/ipwavelet.cc:3051:51: note: Function 'WaveletcontAllAB' argument 1 names different: declaration 'lab' definition 'labco'. 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:3077:23: style: Local variable 'scale' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improcfun.h:143:12: note: Shadowed declaration rawtherapee-5.12/rtengine/ipwavelet.cc:3077:23: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:3120:27: style: The scope of the variable 'bb' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:3122:27: style: The scope of the variable 'bbb' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:3140:27: style: The scope of the variable 'bb1' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:3142:27: style: The scope of the variable 'bbb1' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:3250:23: performance:inconclusive: Technically the member function 'rtengine::ImProcFunctions::calckoe' can be static (but you may consider moving to unnamed namespace). [functionStatic] rawtherapee-5.12/rtengine/improcfun.h:521:10: note: Technically the member function 'rtengine::ImProcFunctions::calckoe' can be static (but you may consider moving to unnamed namespace). rawtherapee-5.12/rtengine/ipwavelet.cc:3250:23: note: Technically the member function 'rtengine::ImProcFunctions::calckoe' can be static (but you may consider moving to unnamed namespace). 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:3250:45: style:inconclusive: Function 'calckoe' argument 1 names different: declaration 'WavCoeffs_LL' definition 'WavCoeffs'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:521:31: note: Function 'calckoe' argument 1 names different: declaration 'WavCoeffs_LL' definition 'WavCoeffs'. rawtherapee-5.12/rtengine/ipwavelet.cc:3250:45: note: Function 'calckoe' argument 1 names different: declaration 'WavCoeffs_LL' definition 'WavCoeffs'. 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:3559:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FLT_MAX [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:3598:23: style: The scope of the variable 'bh' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:3600:23: style: The scope of the variable 'bl' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:3743:23: style:inconclusive: Technically the member function 'rtengine::ImProcFunctions::finalContAllL' can be const. [functionConst] rawtherapee-5.12/rtengine/improcfun.h:509:10: note: Technically the member function 'rtengine::ImProcFunctions::finalContAllL' can be const. rawtherapee-5.12/rtengine/ipwavelet.cc:3743:23: note: Technically the member function 'rtengine::ImProcFunctions::finalContAllL' can be const. 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:3744:62: style: Parameter 'mean' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:3744:75: style: Parameter 'sigma' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:3744:89: style: Parameter 'MaxP' can be declared as pointer to const [constParameterPointer] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:4056:15: style: The scope of the variable 'edghig' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:4057:15: style: The scope of the variable 'edglow' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:4491:23: style: The scope of the variable 'bbal' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:4493:23: style: The scope of the variable 'bbbr' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:4496:23: style: The scope of the variable 'bbalS' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:4498:23: style: The scope of the variable 'bbbrS' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:4580:17: style: The scope of the variable 'itplus' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:4581:17: style: The scope of the variable 'itmoins' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:4604:27: style: The scope of the variable 'k2' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:4621:17: style: The scope of the variable 'itplus' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:4622:17: style: The scope of the variable 'itmoins' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:4684:112: style:inconclusive: Function 'ContAllAB' argument 5 names different: declaration 'WavCoeffs_a' definition 'WavCoeffs_ab'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:511:96: note: Function 'ContAllAB' argument 5 names different: declaration 'WavCoeffs_a' definition 'WavCoeffs_ab'. rawtherapee-5.12/rtengine/ipwavelet.cc:4684:112: note: Function 'ContAllAB' argument 5 names different: declaration 'WavCoeffs_a' definition 'WavCoeffs_ab'. 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:4684:134: style:inconclusive: Function 'ContAllAB' argument 6 names different: declaration 'WavCoeffs_a0' definition 'WavCoeffs_ab0'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:511:117: note: Function 'ContAllAB' argument 6 names different: declaration 'WavCoeffs_a0' definition 'WavCoeffs_ab0'. rawtherapee-5.12/rtengine/ipwavelet.cc:4684:134: note: Function 'ContAllAB' argument 6 names different: declaration 'WavCoeffs_a0' definition 'WavCoeffs_ab0'. 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:4684:44: style:inconclusive: Function 'ContAllAB' argument 1 names different: declaration 'lab' definition 'labco'. [funcArgNamesDifferent] rawtherapee-5.12/rtengine/improcfun.h:511:31: note: Function 'ContAllAB' argument 1 names different: declaration 'lab' definition 'labco'. rawtherapee-5.12/rtengine/ipwavelet.cc:4684:44: note: Function 'ContAllAB' argument 1 names different: declaration 'lab' definition 'labco'. 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:4732:19: style: Local variable 'scale' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improcfun.h:143:12: note: Shadowed declaration rawtherapee-5.12/rtengine/ipwavelet.cc:4732:19: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:4806:19: style: Local variable 'scale' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/improcfun.h:143:12: note: Shadowed declaration rawtherapee-5.12/rtengine/ipwavelet.cc:4806:19: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:4834:25: style: Variable 'kClev' is assigned an expression that holds the same value. [redundantAssignment] rawtherapee-5.12/rtengine/ipwavelet.cc:4828:25: note: kClev is assigned 'beta' here. rawtherapee-5.12/rtengine/ipwavelet.cc:4834:25: note: Variable 'kClev' is assigned an expression that holds the same value. 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:4849:25: style: Variable 'kClev' is assigned an expression that holds the same value. [redundantAssignment] rawtherapee-5.12/rtengine/ipwavelet.cc:4828:25: note: kClev is assigned 'beta' here. rawtherapee-5.12/rtengine/ipwavelet.cc:4849:25: note: Variable 'kClev' is assigned an expression that holds the same value. 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:4863:17: style: Variable 'kClev' is assigned an expression that holds the same value. [redundantAssignment] rawtherapee-5.12/rtengine/ipwavelet.cc:4828:25: note: kClev is assigned 'beta' here. rawtherapee-5.12/rtengine/ipwavelet.cc:4863:17: note: Variable 'kClev' is assigned an expression that holds the same value. 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:4945:17: style: The scope of the variable 'jj' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:5007:17: style: The scope of the variable 'itplus' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:5008:17: style: The scope of the variable 'itmoins' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:5031:27: style: The scope of the variable 'k2' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:5048:17: style: The scope of the variable 'itplus' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/ipwavelet.cc:5049:17: style: The scope of the variable 'itmoins' can be reduced. [variableScope] head rawtherapee-5.12/rtengine/lcp.cc:242:12: warning: Class 'LCPProfile' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] head rawtherapee-5.12/rtengine/lcp.cc:242:12: warning: Class 'LCPProfile' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:1034:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:185:5: style: Class 'SonyMetadataLensCorrection' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:221:19: style: Local variable 'nc' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/lensmetadata.cc:193:9: note: Shadowed declaration rawtherapee-5.12/rtengine/lensmetadata.cc:221:19: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:285:5: style: Class 'FujiMetadataLensCorrection' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:326:23: style: Local variable 'nc' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/lensmetadata.cc:295:9: note: Shadowed declaration rawtherapee-5.12/rtengine/lensmetadata.cc:326:23: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:358:23: style: Local variable 'nc' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/lensmetadata.cc:295:9: note: Shadowed declaration rawtherapee-5.12/rtengine/lensmetadata.cc:358:23: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:489:5: style: Class 'OlympusMetadataLensCorrection' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:52:37: warning: Member variable 'CenterRadiusMetadataLensCorrection::h2' is not initialized in the constructor. [uninitMemberVar] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:52:37: warning: Member variable 'CenterRadiusMetadataLensCorrection::rf' is not initialized in the constructor. [uninitMemberVar] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:52:37: warning: Member variable 'CenterRadiusMetadataLensCorrection::w2' is not initialized in the constructor. [uninitMemberVar] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:55:5: performance: Variable 'metadata' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:629:5: style: Class 'PanasonicMetadataLensCorrection' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:629:5: warning: Member variable 'PanasonicMetadataLensCorrection::scale' is not initialized in the constructor. [uninitMemberVar] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:642:10: style: Unused private function: 'PanasonicMetadataLensCorrection::parse' [unusedPrivateFunction] rawtherapee-5.12/rtengine/lensmetadata.cc:642:10: note: Unused private function: 'PanasonicMetadataLensCorrection::parse' rawtherapee-5.12/rtengine/lensmetadata.cc:642:10: note: Unused private function: 'PanasonicMetadataLensCorrection::parse' 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:654:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable littleEndian [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:69:8: style: float result is assigned to double variable. If the variable is double to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:70:8: style: float result is assigned to double variable. If the variable is double to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:717:5: style: Class 'DNGMetadataLensCorrection' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:717:5: warning: Member variable 'DNGMetadataLensCorrection::cx_d' is not initialized in the constructor. [uninitMemberVar] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:717:5: warning: Member variable 'DNGMetadataLensCorrection::cx_v' is not initialized in the constructor. [uninitMemberVar] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:717:5: warning: Member variable 'DNGMetadataLensCorrection::cy_d' is not initialized in the constructor. [uninitMemberVar] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:717:5: warning: Member variable 'DNGMetadataLensCorrection::cy_v' is not initialized in the constructor. [uninitMemberVar] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:717:5: warning: Member variable 'DNGMetadataLensCorrection::height' is not initialized in the constructor. [uninitMemberVar] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:717:5: warning: Member variable 'DNGMetadataLensCorrection::m_d' is not initialized in the constructor. [uninitMemberVar] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:717:5: warning: Member variable 'DNGMetadataLensCorrection::m_v' is not initialized in the constructor. [uninitMemberVar] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:717:5: warning: Member variable 'DNGMetadataLensCorrection::width' is not initialized in the constructor. [uninitMemberVar] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:720:9: performance: Variable 'metadata' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:769:23: style: The scope of the variable 'processed_opcodes' can be reduced. [variableScope] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:780:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable invalidByteOrder [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:802:30: warning: %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:821:34: style: Local variable 'i' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/lensmetadata.cc:786:25: note: Shadowed declaration rawtherapee-5.12/rtengine/lensmetadata.cc:821:34: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:852:30: warning: %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] 2.18.0 rawtherapee-5.12/rtengine/lensmetadata.cc:992:10: style: Unused private function: 'DNGMetadataLensCorrection::isCACorrectionAvailable' [unusedPrivateFunction] rawtherapee-5.12/rtengine/lensmetadata.cc:992:10: note: Unused private function: 'DNGMetadataLensCorrection::isCACorrectionAvailable' rawtherapee-5.12/rtengine/lensmetadata.cc:992:10: note: Unused private function: 'DNGMetadataLensCorrection::isCACorrectionAvailable' 2.18.0 rawtherapee-5.12/rtengine/linalgebra.h:229:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable T [valueFlowBailoutIncompleteVar] 2.18.0 rawtherapee-5.12/rtengine/linalgebra.h:32:5: style: Class 'Vec3' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.18.0 rawtherapee-5.12/rtengine/lmmse_demosaic.cc:101:21: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/lmmse_demosaic.cc:108:22: style: C-style pointer casting [cstyleCast] 2.18.0 rawtherapee-5.12/rtengine/lmmse_demosaic.cc:162:24: style: Local variable 'rix' shadows outer variable [shadowVariable] rawtherapee-5.12/rtengine/lmmse_demosaic.cc:99:12: note: Shadowed declaration rawtherapee-5.12/rtengine/lmmse_demosaic.cc:162:24: note: Shadow variable 2.18.0 rawtherapee-5.12/rtengine/lmmse_demosaic.cc:188:42: error: Array 'rix[5]' accessed at index rix[*][-2], which is out of bounds. [negativeIndex] 2.18.0 rawtherapee-5.12/rtengine/lmmse_demosaic.cc:188:77: error: Array 'rix[5]' accessed at index rix[*][-1], which is out of bounds. [negativeIndex] 2.18.0 rawtherapee-5.12/rtengine/lmmse_demosaic.cc:192:54: error: Array 'rix[5]' accessed at index rix[*][-1], which is out of bounds. [negativeIndex] 2.18.0 rawtherapee-5.12/rtengine/lmmse_demosaic.cc:217:41: error: Array 'rix[5]' accessed at index rix[*][-2], which is out of bounds. [negativeIndex] 2.18.0 rawtherapee-5.12/rtengine/lmmse_demosaic.cc:217:76: error: Array 'rix[5]' accessed at index rix[*][-1], which is out of bounds. [negativeIndex] 2.18.0 rawtherapee-5.12/rtengine/lmmse_demosaic.cc:243:123: error: Array 'rix[5]' accessed at index rix[*][-3], which is out of bounds. [negativeIndex] 2.18.0 rawtherapee-5.12/rtengine/lmmse_demosaic.cc:243:157: error: Array 'rix[5]' accessed at index rix[*][-4], which is out of bounds. [negativeIndex] 2.18.0 rawtherapee-5.12/rtengine/lmmse_demosaic.cc:243:55: error: Array 'rix[5]' accessed at index rix[*][-1], which is out of bounds. [negativeIndex] 2.18.0 rawtherapee-5.12/rtengine/lmmse_demosaic.cc:243:89: error: Array 'rix[5]' accessed at index rix[*][-2], which is out of bounds. [negativeIndex] 2.18.0 rawtherapee-5.12/rtengine/lmmse_demosaic.cc:339:31: error: Array 'rix[5]' accessed at index rix[*][-4], which is out of bounds. [negativeIndex] 2.18.0 rawtherapee-5.12/rtengine/lmmse_demosaic.cc:340:31: error: Array 'rix[5]' accessed at index rix[*][-3], which is out of bounds. [negativeIndex] 2.18.0 rawtherapee-5.12/rtengine/lmmse_demosaic.cc:341:31: error: Array 'rix[5]' accessed at index rix[*][-2], which is out of bounds. [negativeIndex] 2.18.0 rawtherapee-5.12/rtengine/lmmse_demosaic.cc:342:31: error: Array 'rix[5]' accessed at index rix[*][-1], which is out of bounds. [negativeIndex] 2.18.0 rawtherapee-5.12/rtengine/lmmse_demosaic.cc:350:26: error: Array 'rix[5]' accessed at index rix[*][-4], which is out of bounds. [negativeIndex] 2.18.0 rawtherapee-5.12/rtengine/lmmse_demosaic.cc:351:26: error: Array 'rix[5]' accessed at index rix[*][-3], which is out of bounds. [negativeIndex] 2.18.0 rawtherapee-5.12/rtengine/lmmse_demosaic.cc:352:26: error: Array 'rix[5]' accessed at index rix[*][-2], which is out of bounds. [negativeIndex] 2.18.0 rawtherapee-5.12/rtengine/lmmse_demosaic.cc:353:26: error: Array 'rix[5]' accessed at index rix[*][-1], which is out of bounds. [negativeIndex] 2.18.0 rawtherapee-5.12/rtengine/lmmse_demosaic.cc:412:32: style:inconclusive: Boolean expression 'row>=0' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] 2.18.0 rawtherapee-5.12/rtengine/lmmse_demosaic.cc:412:49: style:inconclusive: Boolean expression 'col>=0' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] 2.18.0 rawtherapee-5.12/rtengine/lmmse_demosaic.cc:412:62: style:inconclusive: Boolean expression 'col