2022-06-30 13:47 ftp://ftp.de.debian.org/debian/pool/main/q/qqwing/qqwing_1.3.4.orig.tar.gz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j1 platform: Linux-5.4.0-110-generic-x86_64-with-glibc2.29 python: 3.8.10 client-version: 1.3.24 compiler: g++ (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0 cppcheck: head 2.8 head-info: 27578e9 (2022-06-30 13:50:31 +0200) count: 32 32 elapsed-time: 7.4 11.3 head-timing-info: Tokenizer::simplifyTokens1: 7.38043s (avg. 3.69022s - 2 result(s)) Tokenizer::simplifyTokens1::ValueFlow: 7.32653s (avg. 3.66326s - 2 result(s)) Tokenizer::simplifyTokens1::createSymbolDatabase: 0.028432s (avg. 0.014216s - 2 result(s)) Other::runChecks: 0.016184s (avg. 0.008092s - 2 result(s)) Tokenizer::createTokens: 0.00705s (avg. 0.003525s - 2 result(s)) Overall time: 14.7919s old-timing-info: Tokenizer::simplifyTokens1: 11.2387s (avg. 5.61936s - 2 result(s)) Tokenizer::simplifyTokens1::ValueFlow: 11.1854s (avg. 5.59272s - 2 result(s)) Tokenizer::simplifyTokens1::createSymbolDatabase: 0.02727s (avg. 0.013635s - 2 result(s)) Other::runChecks: 0.01521s (avg. 0.007605s - 2 result(s)) Tokenizer::createTokens: 0.007035s (avg. 0.0035175s - 2 result(s)) Overall time: 22.5058s head results: qqwing-1.3.4/main.cpp:492:7: warning: Storing getchar() return value in char variable and then comparing with EOF. [checkCastIntToCharAndBack] qqwing-1.3.4/qqwing.hpp:74:16: style:inconclusive: Technically the member function 'qqwing::SudokuBoard::getPuzzle' can be const. [functionConst] qqwing-1.3.4/qqwing.cpp:160:26: note: Technically the member function 'qqwing::SudokuBoard::getPuzzle' can be const. qqwing-1.3.4/qqwing.hpp:74:16: note: Technically the member function 'qqwing::SudokuBoard::getPuzzle' can be const. qqwing-1.3.4/qqwing.hpp:75:16: style:inconclusive: Technically the member function 'qqwing::SudokuBoard::getSolution' can be const. [functionConst] qqwing-1.3.4/qqwing.cpp:167:26: note: Technically the member function 'qqwing::SudokuBoard::getSolution' can be const. qqwing-1.3.4/qqwing.hpp:75:16: note: Technically the member function 'qqwing::SudokuBoard::getSolution' can be const. qqwing-1.3.4/qqwing.hpp:101:10: style:inconclusive: Technically the member function 'qqwing::SudokuBoard::isSolved' can be const. [functionConst] qqwing-1.3.4/qqwing.cpp:605:20: note: Technically the member function 'qqwing::SudokuBoard::isSolved' can be const. qqwing-1.3.4/qqwing.hpp:101:10: note: Technically the member function 'qqwing::SudokuBoard::isSolved' can be const. qqwing-1.3.4/qqwing.hpp:108:9: style:inconclusive: Technically the member function 'qqwing::SudokuBoard::getGivenCount' can be const. [functionConst] qqwing-1.3.4/qqwing.cpp:138:19: note: Technically the member function 'qqwing::SudokuBoard::getGivenCount' can be const. qqwing-1.3.4/qqwing.hpp:108:9: note: Technically the member function 'qqwing::SudokuBoard::getGivenCount' can be const. qqwing-1.3.4/qqwing.hpp:217:10: style:inconclusive: Technically the member function 'qqwing::SudokuBoard::isImpossible' can be const. [functionConst] qqwing-1.3.4/qqwing.cpp:614:20: note: Technically the member function 'qqwing::SudokuBoard::isImpossible' can be const. qqwing-1.3.4/qqwing.hpp:217:10: note: Technically the member function 'qqwing::SudokuBoard::isImpossible' can be const. qqwing-1.3.4/qqwing.hpp:227:9: style:inconclusive: Technically the member function 'qqwing::SudokuBoard::findPositionWithFewestPossibilities' can be const. [functionConst] qqwing-1.3.4/qqwing.cpp:630:19: note: Technically the member function 'qqwing::SudokuBoard::findPositionWithFewestPossibilities' can be const. qqwing-1.3.4/qqwing.hpp:227:9: note: Technically the member function 'qqwing::SudokuBoard::findPositionWithFewestPossibilities' can be const. qqwing-1.3.4/qqwing.hpp:229:9: style:inconclusive: Technically the member function 'qqwing::SudokuBoard::countPossibilities' can be const. [functionConst] qqwing-1.3.4/qqwing.cpp:869:19: note: Technically the member function 'qqwing::SudokuBoard::countPossibilities' can be const. qqwing-1.3.4/qqwing.hpp:229:9: note: Technically the member function 'qqwing::SudokuBoard::countPossibilities' can be const. qqwing-1.3.4/qqwing.hpp:230:10: style:inconclusive: Technically the member function 'qqwing::SudokuBoard::arePossibilitiesSame' can be const. [functionConst] qqwing-1.3.4/qqwing.cpp:878:20: note: Technically the member function 'qqwing::SudokuBoard::arePossibilitiesSame' can be const. qqwing-1.3.4/qqwing.hpp:230:10: note: Technically the member function 'qqwing::SudokuBoard::arePossibilitiesSame' can be const. qqwing-1.3.4/qqwing.hpp:233:10: style:inconclusive: Technically the member function 'qqwing::SudokuBoard::print' can be const. [functionConst] qqwing-1.3.4/qqwing.cpp:1346:20: note: Technically the member function 'qqwing::SudokuBoard::print' can be const. qqwing-1.3.4/qqwing.hpp:233:10: note: Technically the member function 'qqwing::SudokuBoard::print' can be const. qqwing-1.3.4/qqwing.hpp:236:10: style:inconclusive: Technically the member function 'qqwing::SudokuBoard::printHistory' can be const. [functionConst] qqwing-1.3.4/qqwing.cpp:468:20: note: Technically the member function 'qqwing::SudokuBoard::printHistory' can be const. qqwing-1.3.4/qqwing.hpp:236:10: note: Technically the member function 'qqwing::SudokuBoard::printHistory' can be const. qqwing-1.3.4/qqwing.cpp:64:8: style:inconclusive: Technically the member function 'qqwing::LogItem::getRound' can be const. [functionConst] qqwing-1.3.4/qqwing.cpp:1426:15: note: Technically the member function 'qqwing::LogItem::getRound' can be const. qqwing-1.3.4/qqwing.cpp:64:8: note: Technically the member function 'qqwing::LogItem::getRound' can be const. qqwing-1.3.4/qqwing.cpp:66:12: style:inconclusive: Technically the member function 'qqwing::LogItem::getType' can be const. [functionConst] qqwing-1.3.4/qqwing.cpp:1433:28: note: Technically the member function 'qqwing::LogItem::getType' can be const. qqwing-1.3.4/qqwing.cpp:66:12: note: Technically the member function 'qqwing::LogItem::getType' can be const. qqwing-1.3.4/qqwing.cpp:112:3: warning: Class 'SudokuBoard' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] qqwing-1.3.4/qqwing.cpp:112:3: warning: Class 'SudokuBoard' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] qqwing-1.3.4/qqwing.cpp:1503:9: style: Condition 'printed' is always false [knownConditionTrueFalse] qqwing-1.3.4/qqwing.cpp:1501:19: note: Assignment 'printed=false', assigned value is 0 qqwing-1.3.4/qqwing.cpp:1503:9: note: Condition 'printed' is always false qqwing-1.3.4/qqwing.cpp:631:7: style: The scope of the variable 'minPossibilities' can be reduced. [variableScope] qqwing-1.3.4/qqwing.cpp:651:7: style: The scope of the variable 'localGuessCount' can be reduced. [variableScope] qqwing-1.3.4/qqwing.cpp:1408:23: style:inconclusive: Function 'LogItem' argument 1 names different: declaration 'round' definition 'r'. [funcArgNamesDifferent] qqwing-1.3.4/qqwing.cpp:62:16: note: Function 'LogItem' argument 1 names different: declaration 'round' definition 'r'. qqwing-1.3.4/qqwing.cpp:1408:23: note: Function 'LogItem' argument 1 names different: declaration 'round' definition 'r'. qqwing-1.3.4/qqwing.cpp:1408:34: style:inconclusive: Function 'LogItem' argument 2 names different: declaration 'type' definition 't'. [funcArgNamesDifferent] qqwing-1.3.4/qqwing.cpp:62:31: note: Function 'LogItem' argument 2 names different: declaration 'type' definition 't'. qqwing-1.3.4/qqwing.cpp:1408:34: note: Function 'LogItem' argument 2 names different: declaration 'type' definition 't'. qqwing-1.3.4/qqwing.cpp:1412:23: style:inconclusive: Function 'LogItem' argument 1 names different: declaration 'round' definition 'r'. [funcArgNamesDifferent] qqwing-1.3.4/qqwing.cpp:63:16: note: Function 'LogItem' argument 1 names different: declaration 'round' definition 'r'. qqwing-1.3.4/qqwing.cpp:1412:23: note: Function 'LogItem' argument 1 names different: declaration 'round' definition 'r'. qqwing-1.3.4/qqwing.cpp:1412:34: style:inconclusive: Function 'LogItem' argument 2 names different: declaration 'type' definition 't'. [funcArgNamesDifferent] qqwing-1.3.4/qqwing.cpp:63:31: note: Function 'LogItem' argument 2 names different: declaration 'type' definition 't'. qqwing-1.3.4/qqwing.cpp:1412:34: note: Function 'LogItem' argument 2 names different: declaration 'type' definition 't'. qqwing-1.3.4/qqwing.cpp:1412:41: style:inconclusive: Function 'LogItem' argument 3 names different: declaration 'value' definition 'v'. [funcArgNamesDifferent] qqwing-1.3.4/qqwing.cpp:63:41: note: Function 'LogItem' argument 3 names different: declaration 'value' definition 'v'. qqwing-1.3.4/qqwing.cpp:1412:41: note: Function 'LogItem' argument 3 names different: declaration 'value' definition 'v'. qqwing-1.3.4/qqwing.cpp:1412:48: style:inconclusive: Function 'LogItem' argument 4 names different: declaration 'position' definition 'p'. [funcArgNamesDifferent] qqwing-1.3.4/qqwing.cpp:63:52: note: Function 'LogItem' argument 4 names different: declaration 'position' definition 'p'. qqwing-1.3.4/qqwing.cpp:1412:48: note: Function 'LogItem' argument 4 names different: declaration 'position' definition 'p'. qqwing-1.3.4/qqwing.cpp:1416:25: style:inconclusive: Function 'init' argument 1 names different: declaration 'round' definition 'r'. [funcArgNamesDifferent] qqwing-1.3.4/qqwing.cpp:69:18: note: Function 'init' argument 1 names different: declaration 'round' definition 'r'. qqwing-1.3.4/qqwing.cpp:1416:25: note: Function 'init' argument 1 names different: declaration 'round' definition 'r'. qqwing-1.3.4/qqwing.cpp:1416:36: style:inconclusive: Function 'init' argument 2 names different: declaration 'type' definition 't'. [funcArgNamesDifferent] qqwing-1.3.4/qqwing.cpp:69:33: note: Function 'init' argument 2 names different: declaration 'type' definition 't'. qqwing-1.3.4/qqwing.cpp:1416:36: note: Function 'init' argument 2 names different: declaration 'type' definition 't'. qqwing-1.3.4/qqwing.cpp:1416:43: style:inconclusive: Function 'init' argument 3 names different: declaration 'value' definition 'v'. [funcArgNamesDifferent] qqwing-1.3.4/qqwing.cpp:69:43: note: Function 'init' argument 3 names different: declaration 'value' definition 'v'. qqwing-1.3.4/qqwing.cpp:1416:43: note: Function 'init' argument 3 names different: declaration 'value' definition 'v'. qqwing-1.3.4/qqwing.cpp:1416:50: style:inconclusive: Function 'init' argument 4 names different: declaration 'position' definition 'p'. [funcArgNamesDifferent] qqwing-1.3.4/qqwing.cpp:69:54: note: Function 'init' argument 4 names different: declaration 'position' definition 'p'. qqwing-1.3.4/qqwing.cpp:1416:50: note: Function 'init' argument 4 names different: declaration 'position' definition 'p'. qqwing-1.3.4/qqwing.cpp:1099:8: style: Local variable 'possibilities' shadows outer variable [shadowVariable] qqwing-1.3.4/qqwing.hpp:156:10: note: Shadowed declaration qqwing-1.3.4/qqwing.cpp:1099:8: note: Shadow variable qqwing-1.3.4/qqwing.cpp:1333:13: style: Local variable 'valIndex' shadows outer variable [shadowVariable] qqwing-1.3.4/qqwing.cpp:1290:7: note: Shadowed declaration qqwing-1.3.4/qqwing.cpp:1333:13: note: Shadow variable qqwing-1.3.4/qqwing.cpp:1346:31: style: Parameter 'sudoku' can be declared as pointer to const [constParameter] qqwing-1.3.4/qqwing.cpp:1510:13: style: Variable 'printed' is assigned a value that is never used. [unreadVariable] diff: head qqwing-1.3.4/qqwing.cpp:1346:31: style: Parameter 'sudoku' can be declared as pointer to const [constParameter] 2.8 qqwing-1.3.4/qqwing.cpp:1346:31: style: Parameter 'sudoku' can be declared with const [constParameter] DONE