2021-09-20 17:12 ftp://ftp.de.debian.org/debian/pool/main/q/qbittorrent/qbittorrent_4.2.5.orig.tar.xz cppcheck-options: --library=posix --library=gnu --library=boost --library=openssl --library=qt --library=zlib -j2 --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -rp=temp -D__GNUC__ --platform=unix64 temp platform: Linux-5.4.0-84-generic-x86_64-with-glibc2.29 python: 3.8.10 client-version: 1.3.12 compiler: g++ (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0 cppcheck: head 2.5 head-info: e388bdc4d (2021-09-20 11:54:16 +0200) count: 122 97 elapsed-time: 8.3 14.0 head-timing-info: Overall time: 0s old-timing-info: Overall time: 0s head results: qbittorrent-4.2.5/src/app/qtlocalpeer/qtlockedfile.h:91:9: style: Class 'QtLockedFile' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] qbittorrent-4.2.5/src/app/cmdoptions.cpp:62:28: style: Class 'Option' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] qbittorrent-4.2.5/src/app/cmdoptions.cpp:109:28: style: Class 'BoolOption' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] qbittorrent-4.2.5/src/app/cmdoptions.cpp:146:28: style: Struct 'StringOption' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] qbittorrent-4.2.5/src/app/cmdoptions.cpp:193:28: style: Class 'IntOption' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] qbittorrent-4.2.5/src/app/main.cpp:148:40: performance:inconclusive: Use const reference for 'params' to avoid unnecessary data copying. [redundantCopyLocalConst] qbittorrent-4.2.5/src/base/bittorrent/infohash.h:43:9: style: Class 'InfoHash' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] qbittorrent-4.2.5/src/base/bittorrent/infohash.h:44:9: style: Class 'InfoHash' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] qbittorrent-4.2.5/src/base/bittorrent/trackerentry.h:52:9: style: Class 'TrackerEntry' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] qbittorrent-4.2.5/src/base/bittorrent/trackerentry.h:53:9: style: Class 'TrackerEntry' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] qbittorrent-4.2.5/src/base/bittorrent/private/filterparserthread.cpp:197:28: style: The if condition is the same as the previous if condition [duplicateCondition] qbittorrent-4.2.5/src/base/bittorrent/private/filterparserthread.cpp:193:28: note: First condition qbittorrent-4.2.5/src/base/bittorrent/private/filterparserthread.cpp:197:28: note: Second condition qbittorrent-4.2.5/src/base/bittorrent/private/filterparserthread.cpp:133:12: style: The scope of the variable 'bytesRead' can be reduced. [variableScope] qbittorrent-4.2.5/src/base/bittorrent/private/filterparserthread.cpp:280:12: style: The scope of the variable 'bytesRead' can be reduced. [variableScope] qbittorrent-4.2.5/src/base/bittorrent/torrentcreatorthread.cpp:71:23: warning: Member variable 'TorrentCreatorThread::m_params' is not initialized in the constructor. [uninitMemberVar] qbittorrent-4.2.5/src/base/tristatebool.h:41:24: style: Class 'TriStateBool' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] qbittorrent-4.2.5/src/base/tristatebool.h:59:24: style: Class 'TriStateBool' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] qbittorrent-4.2.5/src/base/bittorrent/session.cpp:1000:28: style: The statement 'if (m_isTrackerEnabled!=enabled) m_isTrackerEnabled=enabled' is logically equivalent to 'm_isTrackerEnabled=enabled'. [duplicateConditionalAssign] qbittorrent-4.2.5/src/base/bittorrent/session.cpp:1001:28: note: Assignment 'm_isTrackerEnabled=enabled' qbittorrent-4.2.5/src/base/bittorrent/session.cpp:1000:28: note: Condition 'm_isTrackerEnabled!=enabled' is redundant qbittorrent-4.2.5/src/base/bittorrent/session.cpp:2977:50: style:inconclusive: Function 'setNetworkInterface' argument 1 names different: declaration 'interface' definition 'iface'. [funcArgNamesDifferent] qbittorrent-4.2.5/src/base/bittorrent/session.h:305:49: note: Function 'setNetworkInterface' argument 1 names different: declaration 'interface' definition 'iface'. qbittorrent-4.2.5/src/base/bittorrent/session.cpp:2977:50: note: Function 'setNetworkInterface' argument 1 names different: declaration 'interface' definition 'iface'. qbittorrent-4.2.5/src/base/bittorrent/session.cpp:1537:27: style: Local variable 'ip' shadows outer variable [shadowVariable] qbittorrent-4.2.5/src/base/bittorrent/session.cpp:1534:25: note: Shadowed declaration qbittorrent-4.2.5/src/base/bittorrent/session.cpp:1537:27: note: Shadow variable qbittorrent-4.2.5/src/base/bittorrent/session.cpp:2131:27: style: Local variable 'savePath' shadows outer variable [shadowVariable] qbittorrent-4.2.5/src/base/bittorrent/session.cpp:2080:13: note: Shadowed declaration qbittorrent-4.2.5/src/base/bittorrent/session.cpp:2131:27: note: Shadow variable qbittorrent-4.2.5/src/base/bittorrent/session.cpp:2191:21: style: Local variable 'savePath' shadows outer variable [shadowVariable] qbittorrent-4.2.5/src/base/bittorrent/session.cpp:2080:13: note: Shadowed declaration qbittorrent-4.2.5/src/base/bittorrent/session.cpp:2191:21: note: Shadow variable qbittorrent-4.2.5/src/base/bittorrent/session.cpp:2599:14: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] qbittorrent-4.2.5/src/base/bittorrent/torrenthandleimpl.h:220:14: style: Virtual function 'setSequentialDownload' is called from constructor 'TorrentHandleImpl(Session*session,const lt::torrent_handle&nativeHandle,const CreateTorrentParams¶ms)' at line 195. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/base/bittorrent/torrenthandleimpl.cpp:195:9: note: Calling setSequentialDownload qbittorrent-4.2.5/src/base/bittorrent/torrenthandleimpl.h:220:14: note: setSequentialDownload is a virtual function qbittorrent-4.2.5/src/base/bittorrent/torrenthandleimpl.h:221:14: style: Virtual function 'setFirstLastPiecePriority' is called from constructor 'TorrentHandleImpl(Session*session,const lt::torrent_handle&nativeHandle,const CreateTorrentParams¶ms)' at line 197. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/base/bittorrent/torrenthandleimpl.cpp:197:9: note: Calling setFirstLastPiecePriority qbittorrent-4.2.5/src/base/bittorrent/torrenthandleimpl.h:221:14: note: setFirstLastPiecePriority is a virtual function qbittorrent-4.2.5/src/base/bittorrent/torrenthandleimpl.cpp:123:23: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] qbittorrent-4.2.5/src/base/bittorrent/torrentinfo.h:104:14: style:inconclusive: Technically the member function 'BitTorrent::TorrentInfo::renameFile' can be const. [functionConst] qbittorrent-4.2.5/src/base/bittorrent/torrentinfo.cpp:413:19: note: Technically the member function 'BitTorrent::TorrentInfo::renameFile' can be const. qbittorrent-4.2.5/src/base/bittorrent/torrentinfo.h:104:14: note: Technically the member function 'BitTorrent::TorrentInfo::renameFile' can be const. qbittorrent-4.2.5/src/base/http/server.cpp:137:22: style: Condition 'certs.isEmpty()' is always false [knownConditionTrueFalse] qbittorrent-4.2.5/src/base/net/downloadmanager.h:67:9: style: Class 'DownloadRequest' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] qbittorrent-4.2.5/src/base/net/downloadmanager.cpp:283:19: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] qbittorrent-4.2.5/src/base/net/private/geoipdatabase.cpp:173:26: warning: The address of local variable 'id' might be accessed at non-zero index. [objectIndex] qbittorrent-4.2.5/src/base/net/private/geoipdatabase.cpp:172:53: note: Address of variable taken here. qbittorrent-4.2.5/src/base/net/private/geoipdatabase.cpp:173:26: note: The address of local variable 'id' might be accessed at non-zero index. qbittorrent-4.2.5/src/base/net/private/geoipdatabase.h:66:10: performance:inconclusive: Technically the member function 'GeoIPDatabase::fromBigEndian' can be static (but you may consider moving to unnamed namespace). [functionStatic] qbittorrent-4.2.5/src/base/net/private/geoipdatabase.cpp:439:21: note: Technically the member function 'GeoIPDatabase::fromBigEndian' can be static (but you may consider moving to unnamed namespace). qbittorrent-4.2.5/src/base/net/private/geoipdatabase.h:66:10: note: Technically the member function 'GeoIPDatabase::fromBigEndian' can be static (but you may consider moving to unnamed namespace). qbittorrent-4.2.5/src/base/net/private/geoipdatabase.cpp:83:7: warning: Class 'GeoIPDatabase' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] qbittorrent-4.2.5/src/base/net/private/geoipdatabase.cpp:83:7: warning: Class 'GeoIPDatabase' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] qbittorrent-4.2.5/src/base/net/private/geoipdatabase.h:79:26: portability:inconclusive: Casting from double * to unsigned char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] qbittorrent-4.2.5/src/base/net/private/geoipdatabase.h:81:27: portability:inconclusive: Casting from double * to unsigned char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] qbittorrent-4.2.5/src/base/net/private/geoipdatabase.h:79:26: portability:inconclusive: Casting from float * to unsigned char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] qbittorrent-4.2.5/src/base/net/private/geoipdatabase.h:81:27: portability:inconclusive: Casting from float * to unsigned char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] qbittorrent-4.2.5/src/base/rss/private/rss_parser.cpp:435:13: style: The scope of the variable 'dayOfWeek' can be reduced. [variableScope] qbittorrent-4.2.5/src/base/rss/private/rss_parser.cpp:454:14: style: The scope of the variable 'negOffset' can be reduced. [variableScope] qbittorrent-4.2.5/src/base/rss/private/rss_parser.cpp:490:34: style: Local variable 'i' shadows outer variable [shadowVariable] qbittorrent-4.2.5/src/base/rss/private/rss_parser.cpp:446:19: note: Shadowed declaration qbittorrent-4.2.5/src/base/rss/private/rss_parser.cpp:490:34: note: Shadow variable qbittorrent-4.2.5/src/base/rss/private/rss_parser.cpp:527:30: performance: Function parameter 'lastBuildDate' should be passed by const reference. [passedByValue] qbittorrent-4.2.5/src/base/rss/private/rss_parser.cpp:362:20: debug: Wrong data detected by condition !tok->next()->astOperand2() [DacaWrongData] qbittorrent-4.2.5/src/base/rss/private/rss_parser.cpp:367:20: debug: Wrong data detected by condition !tok->next()->astOperand2() [DacaWrongData] qbittorrent-4.2.5/src/base/rss/private/rss_parser.cpp:372:20: debug: Wrong data detected by condition !tok->next()->astOperand2() [DacaWrongData] qbittorrent-4.2.5/src/base/rss/private/rss_parser.cpp:454:24: style: Variable 'negOffset' is assigned a value that is never used. [unreadVariable] qbittorrent-4.2.5/src/base/rss/private/rss_parser.cpp:473:31: style: Variable 'negOffset' is assigned a value that is never used. [unreadVariable] qbittorrent-4.2.5/src/base/rss/private/rss_parser.cpp:495:35: style: Variable 'negOffset' is assigned a value that is never used. [unreadVariable] qbittorrent-4.2.5/src/base/rss/rss_autodownloadrule.cpp:295:37: style: Local variable 'matcher' shadows outer variable [shadowVariable] qbittorrent-4.2.5/src/base/rss/rss_autodownloadrule.cpp:274:35: note: Shadowed declaration qbittorrent-4.2.5/src/base/rss/rss_autodownloadrule.cpp:295:37: note: Shadow variable qbittorrent-4.2.5/src/base/settingsstorage.cpp:189:9: warning: Identical condition '!m_dirty', second condition is always false [identicalConditionAfterEarlyExit] qbittorrent-4.2.5/src/base/settingsstorage.cpp:187:9: note: If condition '!m_dirty' is true, the function will return/exit qbittorrent-4.2.5/src/base/settingsstorage.cpp:189:9: note: Testing identical condition '!m_dirty' qbittorrent-4.2.5/src/base/torrentfilter.h:81:5: style: Class 'TorrentFilter' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] qbittorrent-4.2.5/src/base/torrentfilter.h:82:5: style: Class 'TorrentFilter' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] qbittorrent-4.2.5/src/base/torrentfilter.cpp:65:120: style:inconclusive: Function 'TorrentFilter' argument 4 names different: declaration 'tags' definition 'tag'. [funcArgNamesDifferent] qbittorrent-4.2.5/src/base/torrentfilter.h:82:133: note: Function 'TorrentFilter' argument 4 names different: declaration 'tags' definition 'tag'. qbittorrent-4.2.5/src/base/torrentfilter.cpp:65:120: note: Function 'TorrentFilter' argument 4 names different: declaration 'tags' definition 'tag'. qbittorrent-4.2.5/src/gui/advancedsettings.h:43:5: style: Class 'AdvancedSettings' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] qbittorrent-4.2.5/src/gui/banlistoptionsdialog.h:58:23: style: Class 'BanListOptionsDialog' is unsafe, 'BanListOptionsDialog::m_model' can leak by wrong usage. [unsafeClassCanLeak] qbittorrent-4.2.5/src/gui/banlistoptionsdialog.h:59:28: style: Class 'BanListOptionsDialog' is unsafe, 'BanListOptionsDialog::m_sortFilter' can leak by wrong usage. [unsafeClassCanLeak] qbittorrent-4.2.5/src/gui/categoryfiltermodel.cpp:317:9: debug: Wrong data detected by condition !tok->next()->astOperand1() [DacaWrongData] qbittorrent-4.2.5/src/gui/categoryfiltermodel.cpp:414:25: debug: Wrong data detected by condition !tok->next()->astOperand1() [DacaWrongData] qbittorrent-4.2.5/src/gui/categoryfiltermodel.cpp:423:17: debug: Wrong data detected by condition !tok->next()->astOperand1() [DacaWrongData] qbittorrent-4.2.5/src/gui/categoryfiltermodel.h:57:17: style: Virtual function 'index' is called from constructor 'CategoryFilterModel(QObject*parent=nullptr)' at line 181. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/gui/categoryfiltermodel.cpp:181:75: note: Calling categoryAdded qbittorrent-4.2.5/src/gui/categoryfiltermodel.cpp:316:21: note: Calling index qbittorrent-4.2.5/src/gui/categoryfiltermodel.cpp:302:12: note: Calling index qbittorrent-4.2.5/src/gui/categoryfiltermodel.h:57:17: note: index is a virtual function qbittorrent-4.2.5/src/gui/categoryfiltermodel.h:57:17: style: Virtual function 'index' is called from constructor 'CategoryFilterModel(QObject*parent=nullptr)' at line 183. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/gui/categoryfiltermodel.cpp:183:84: note: Calling torrentCategoryChanged qbittorrent-4.2.5/src/gui/categoryfiltermodel.cpp:359:9: note: Calling index qbittorrent-4.2.5/src/gui/categoryfiltermodel.cpp:302:12: note: Calling index qbittorrent-4.2.5/src/gui/categoryfiltermodel.h:57:17: note: index is a virtual function qbittorrent-4.2.5/src/gui/categoryfiltermodel.cpp:48:58: performance: Function parameter 'categoryName' should be passed by const reference. [passedByValue] qbittorrent-4.2.5/src/gui/fspathedit.cpp:69:5: performance:inconclusive: Technically the member function 'FileSystemPathEditPrivate::d_func' can be static (but you may consider moving to unnamed namespace). [functionStatic] qbittorrent-4.2.5/src/gui/fspathedit.cpp:75:10: style:inconclusive: Technically the member function 'FileSystemPathEditPrivate::browseActionTriggered' can be const. [functionConst] qbittorrent-4.2.5/src/gui/fspathedit.cpp:110:53: note: Technically the member function 'FileSystemPathEditPrivate::browseActionTriggered' can be const. qbittorrent-4.2.5/src/gui/fspathedit.cpp:75:10: note: Technically the member function 'FileSystemPathEditPrivate::browseActionTriggered' can be const. qbittorrent-4.2.5/src/gui/fspathedit.h:55:6: style: Virtual function 'FileSystemPathEdit' is called from constructor 'FileSystemPathEdit(Private::FileEditorWithCompletion*editor,QWidget*parent)' at line 186. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/gui/fspathedit.cpp:186:9: note: Calling FileSystemPathEdit qbittorrent-4.2.5/src/gui/fspathedit.h:55:6: note: FileSystemPathEdit is a virtual function qbittorrent-4.2.5/src/gui/fspathedit.cpp:276:59: style:inconclusive: Function 'setMode' argument 1 names different: declaration 'mode' definition 'theMode'. [funcArgNamesDifferent] qbittorrent-4.2.5/src/gui/fspathedit.h:66:23: note: Function 'setMode' argument 1 names different: declaration 'mode' definition 'theMode'. qbittorrent-4.2.5/src/gui/fspathedit.cpp:276:59: note: Function 'setMode' argument 1 names different: declaration 'mode' definition 'theMode'. qbittorrent-4.2.5/src/gui/ipsubnetwhitelistoptionsdialog.h:59:23: style: Class 'IPSubnetWhitelistOptionsDialog' is unsafe, 'IPSubnetWhitelistOptionsDialog::m_model' can leak by wrong usage. [unsafeClassCanLeak] qbittorrent-4.2.5/src/gui/ipsubnetwhitelistoptionsdialog.h:60:28: style: Class 'IPSubnetWhitelistOptionsDialog' is unsafe, 'IPSubnetWhitelistOptionsDialog::m_sortFilter' can leak by wrong usage. [unsafeClassCanLeak] qbittorrent-4.2.5/src/gui/lineedit.h:22:5: style: Class 'LineEdit' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] qbittorrent-4.2.5/src/gui/rss/rsswidget.h:52:5: style: Class 'RSSWidget' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] qbittorrent-4.2.5/src/gui/mainwindow.cpp:1222:44: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] qbittorrent-4.2.5/src/gui/private/fspathedit_p.cpp:249:54: style:inconclusive: Function 'keyPressEvent' argument 1 names different: declaration 'event' definition 'e'. [funcArgNamesDifferent] qbittorrent-4.2.5/src/gui/private/fspathedit_p.h:130:39: note: Function 'keyPressEvent' argument 1 names different: declaration 'event' definition 'e'. qbittorrent-4.2.5/src/gui/private/fspathedit_p.cpp:249:54: note: Function 'keyPressEvent' argument 1 names different: declaration 'event' definition 'e'. qbittorrent-4.2.5/src/gui/properties/downloadedpiecesbar.h:46:5: style: Class 'DownloadedPiecesBar' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] qbittorrent-4.2.5/src/gui/properties/peersadditiondialog.h:47:5: style: Class 'PeersAdditionDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] qbittorrent-4.2.5/src/gui/properties/pieceavailabilitybar.h:41:5: style: Class 'PieceAvailabilityBar' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] qbittorrent-4.2.5/src/gui/properties/piecesbar.cpp:267:31: style: Condition 'files.count()>1' is always false [knownConditionTrueFalse] qbittorrent-4.2.5/src/gui/properties/piecesbar.cpp:312:29: style: Condition 'fileIndices.count()==1' is always true [knownConditionTrueFalse] qbittorrent-4.2.5/src/gui/properties/propertieswidget.cpp:512:13: debug: Wrong data detected by condition !tok->next()->astOperand1() [DacaWrongData] qbittorrent-4.2.5/src/gui/properties/speedplotview.cpp:336:14: style: Local variable 'i' shadows outer variable [shadowVariable] qbittorrent-4.2.5/src/gui/properties/speedplotview.cpp:313:9: note: Shadowed declaration qbittorrent-4.2.5/src/gui/properties/speedplotview.cpp:336:14: note: Shadow variable qbittorrent-4.2.5/src/gui/properties/speedplotview.cpp:357:18: style: Local variable 'i' shadows outer variable [shadowVariable] qbittorrent-4.2.5/src/gui/properties/speedplotview.cpp:313:9: note: Shadowed declaration qbittorrent-4.2.5/src/gui/properties/speedplotview.cpp:357:18: note: Shadow variable qbittorrent-4.2.5/src/gui/properties/speedplotview.cpp:102:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] qbittorrent-4.2.5/src/gui/properties/trackerlistwidget.cpp:465:30: style: Consider using std::copy_if algorithm instead of a raw loop. [useStlAlgorithm] qbittorrent-4.2.5/src/gui/search/searchwidget.cpp:246:9: debug: Wrong data detected by condition !tok->next()->astOperand1() [DacaWrongData] qbittorrent-4.2.5/src/gui/speedlimitdialog.cpp:74:50: style:inconclusive: Function 'updateSpinValue' argument 1 names different: declaration 'val' definition 'value'. [funcArgNamesDifferent] qbittorrent-4.2.5/src/gui/speedlimitdialog.h:49:30: note: Function 'updateSpinValue' argument 1 names different: declaration 'val' definition 'value'. qbittorrent-4.2.5/src/gui/speedlimitdialog.cpp:74:50: note: Function 'updateSpinValue' argument 1 names different: declaration 'val' definition 'value'. qbittorrent-4.2.5/src/gui/speedlimitdialog.cpp:79:52: style:inconclusive: Function 'updateSliderValue' argument 1 names different: declaration 'val' definition 'value'. [funcArgNamesDifferent] qbittorrent-4.2.5/src/gui/speedlimitdialog.h:50:32: note: Function 'updateSliderValue' argument 1 names different: declaration 'val' definition 'value'. qbittorrent-4.2.5/src/gui/speedlimitdialog.cpp:79:52: note: Function 'updateSliderValue' argument 1 names different: declaration 'val' definition 'value'. qbittorrent-4.2.5/src/gui/tagfiltermodel.h:58:17: style: Virtual function 'index' is called from constructor 'TagFilterModel(QObject*parent=nullptr)' at line 98. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/gui/tagfiltermodel.cpp:98:67: note: Calling tagRemoved qbittorrent-4.2.5/src/gui/tagfiltermodel.cpp:197:21: note: Calling index qbittorrent-4.2.5/src/gui/tagfiltermodel.cpp:175:12: note: Calling index qbittorrent-4.2.5/src/gui/tagfiltermodel.h:58:17: note: index is a virtual function qbittorrent-4.2.5/src/gui/tagfiltermodel.h:58:17: style: Virtual function 'index' is called from constructor 'TagFilterModel(QObject*parent=nullptr)' at line 99. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/gui/tagfiltermodel.cpp:99:72: note: Calling torrentTagAdded qbittorrent-4.2.5/src/gui/tagfiltermodel.cpp:213:27: note: Calling index qbittorrent-4.2.5/src/gui/tagfiltermodel.h:58:17: note: index is a virtual function qbittorrent-4.2.5/src/gui/tagfiltermodel.h:58:17: style: Virtual function 'index' is called from constructor 'TagFilterModel(QObject*parent=nullptr)' at line 100. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/gui/tagfiltermodel.cpp:100:74: note: Calling torrentTagRemoved qbittorrent-4.2.5/src/gui/tagfiltermodel.cpp:228:27: note: Calling index qbittorrent-4.2.5/src/gui/tagfiltermodel.h:58:17: note: index is a virtual function qbittorrent-4.2.5/src/gui/tagfiltermodel.cpp:59:5: style: Class 'TagModelItem' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] qbittorrent-4.2.5/src/gui/torrentcontentfiltermodel.cpp:108:17: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled] qbittorrent-4.2.5/src/gui/torrentcontentfiltermodel.cpp:110:22: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled] qbittorrent-4.2.5/src/gui/torrentcontentfiltermodel.cpp:116:17: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled] qbittorrent-4.2.5/src/gui/torrentcontentfiltermodel.cpp:118:22: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled] qbittorrent-4.2.5/src/gui/torrentcontentfiltermodel.cpp:110:28: error: Null pointer dereference [nullPointer] qbittorrent-4.2.5/src/gui/torrentcontentfiltermodel.cpp:118:28: error: Null pointer dereference [nullPointer] qbittorrent-4.2.5/src/gui/torrentcontentmodel.cpp:248:14: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] qbittorrent-4.2.5/src/gui/torrentcontentmodelitem.h:79:9: performance:inconclusive: Technically the member function 'TorrentContentModelItem::columnCount' can be static (but you may consider moving to unnamed namespace). [functionStatic] qbittorrent-4.2.5/src/gui/torrentcontentmodelitem.cpp:97:30: note: Technically the member function 'TorrentContentModelItem::columnCount' can be static (but you may consider moving to unnamed namespace). qbittorrent-4.2.5/src/gui/torrentcontentmodelitem.h:79:9: note: Technically the member function 'TorrentContentModelItem::columnCount' can be static (but you may consider moving to unnamed namespace). qbittorrent-4.2.5/src/gui/torrentcontentmodelfolder.cpp:92:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] qbittorrent-4.2.5/src/gui/torrentcontenttreeview.cpp:109:16: warning: Identical condition '!modelIndex.isValid()', second condition is always false [identicalConditionAfterEarlyExit] qbittorrent-4.2.5/src/gui/torrentcontenttreeview.cpp:98:9: note: If condition '!modelIndex.isValid()' is true, the function will return/exit qbittorrent-4.2.5/src/gui/torrentcontenttreeview.cpp:109:16: note: Testing identical condition '!modelIndex.isValid()' qbittorrent-4.2.5/src/gui/torrentcontenttreeview.cpp:228:16: warning: Identical condition '!modelIndex.isValid()', second condition is always false [identicalConditionAfterEarlyExit] qbittorrent-4.2.5/src/gui/torrentcontenttreeview.cpp:217:9: note: If condition '!modelIndex.isValid()' is true, the function will return/exit qbittorrent-4.2.5/src/gui/torrentcontenttreeview.cpp:228:16: note: Testing identical condition '!modelIndex.isValid()' qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:562:22: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled] qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:574:30: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled] qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:579:26: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled] qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:597:26: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled] qbittorrent-4.2.5/src/gui/transferlistmodel.h:96:9: style: Virtual function 'columnCount' is called from constructor 'TransferListModel(QObject*parent=nullptr)' at line 119. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:119:87: note: Calling handleTorrentsUpdated qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:567:26: note: Calling columnCount qbittorrent-4.2.5/src/gui/transferlistmodel.h:96:9: note: columnCount is a virtual function qbittorrent-4.2.5/src/gui/transferlistmodel.h:96:9: style: Virtual function 'columnCount' is called from constructor 'TransferListModel(QObject*parent=nullptr)' at line 121. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:121:87: note: Calling handleTorrentStatusUpdated qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:562:48: note: Calling columnCount qbittorrent-4.2.5/src/gui/transferlistmodel.h:96:9: note: columnCount is a virtual function qbittorrent-4.2.5/src/gui/transferlistmodel.h:96:9: style: Virtual function 'columnCount' is called from constructor 'TransferListModel(QObject*parent=nullptr)' at line 122. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:122:93: note: Calling handleTorrentStatusUpdated qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:562:48: note: Calling columnCount qbittorrent-4.2.5/src/gui/transferlistmodel.h:96:9: note: columnCount is a virtual function qbittorrent-4.2.5/src/gui/transferlistmodel.h:96:9: style: Virtual function 'columnCount' is called from constructor 'TransferListModel(QObject*parent=nullptr)' at line 123. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:123:86: note: Calling handleTorrentStatusUpdated qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:562:48: note: Calling columnCount qbittorrent-4.2.5/src/gui/transferlistmodel.h:96:9: note: columnCount is a virtual function qbittorrent-4.2.5/src/gui/transferlistmodel.h:96:9: style: Virtual function 'columnCount' is called from constructor 'TransferListModel(QObject*parent=nullptr)' at line 124. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:124:85: note: Calling handleTorrentStatusUpdated qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:562:48: note: Calling columnCount qbittorrent-4.2.5/src/gui/transferlistmodel.h:96:9: note: columnCount is a virtual function qbittorrent-4.2.5/src/gui/transferlistmodel.h:96:9: style: Virtual function 'columnCount' is called from constructor 'TransferListModel(QObject*parent=nullptr)' at line 125. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:125:95: note: Calling handleTorrentStatusUpdated qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:562:48: note: Calling columnCount qbittorrent-4.2.5/src/gui/transferlistmodel.h:96:9: note: columnCount is a virtual function qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:579:32: error: Null pointer dereference [nullPointer] qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:597:32: error: Null pointer dereference [nullPointer] qbittorrent-4.2.5/src/gui/transferlistfilterswidget.h:69:18: warning: Call of pure virtual function 'showMenu' in constructor. [pureVirtualCall] qbittorrent-4.2.5/src/gui/transferlistfilterswidget.cpp:120:91: note: Calling showMenu qbittorrent-4.2.5/src/gui/transferlistfilterswidget.h:69:18: note: showMenu is a pure virtual function without body qbittorrent-4.2.5/src/gui/transferlistfilterswidget.h:70:18: warning: Call of pure virtual function 'applyFilter' in constructor. [pureVirtualCall] qbittorrent-4.2.5/src/gui/transferlistfilterswidget.cpp:121:82: note: Calling applyFilter qbittorrent-4.2.5/src/gui/transferlistfilterswidget.h:70:18: note: applyFilter is a pure virtual function without body qbittorrent-4.2.5/src/gui/transferlistfilterswidget.h:71:18: warning: Call of pure virtual function 'handleNewTorrent' in constructor. [pureVirtualCall] qbittorrent-4.2.5/src/gui/transferlistfilterswidget.cpp:124:40: note: Calling handleNewTorrent qbittorrent-4.2.5/src/gui/transferlistfilterswidget.h:71:18: note: handleNewTorrent is a pure virtual function without body qbittorrent-4.2.5/src/gui/transferlistfilterswidget.h:72:18: warning: Call of pure virtual function 'torrentAboutToBeDeleted' in constructor. [pureVirtualCall] qbittorrent-4.2.5/src/gui/transferlistfilterswidget.cpp:126:40: note: Calling torrentAboutToBeDeleted qbittorrent-4.2.5/src/gui/transferlistfilterswidget.h:72:18: note: torrentAboutToBeDeleted is a pure virtual function without body qbittorrent-4.2.5/src/gui/updownratiodialog.cpp:38:61: style:inconclusive: Function 'UpDownRatioDialog' argument 2 names different: declaration 'initialValue' definition 'initialRatioValue'. [funcArgNamesDifferent] qbittorrent-4.2.5/src/gui/updownratiodialog.h:44:46: note: Function 'UpDownRatioDialog' argument 2 names different: declaration 'initialValue' definition 'initialRatioValue'. qbittorrent-4.2.5/src/gui/updownratiodialog.cpp:38:61: note: Function 'UpDownRatioDialog' argument 2 names different: declaration 'initialValue' definition 'initialRatioValue'. qbittorrent-4.2.5/src/gui/updownratiodialog.cpp:39:38: style:inconclusive: Function 'UpDownRatioDialog' argument 3 names different: declaration 'maxValue' definition 'maxRatioValue'. [funcArgNamesDifferent] qbittorrent-4.2.5/src/gui/updownratiodialog.h:44:66: note: Function 'UpDownRatioDialog' argument 3 names different: declaration 'maxValue' definition 'maxRatioValue'. qbittorrent-4.2.5/src/gui/updownratiodialog.cpp:39:38: note: Function 'UpDownRatioDialog' argument 3 names different: declaration 'maxValue' definition 'maxRatioValue'. qbittorrent-4.2.5/src/gui/transferlistwidget.cpp:738:51: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] qbittorrent-4.2.5/src/gui/transferlistwidget.cpp:763:49: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] qbittorrent-4.2.5/src/webui/api/torrentscontroller.cpp:1123:21: style: Condition 'tags.isEmpty()' is always false [knownConditionTrueFalse] qbittorrent-4.2.5/src/webui/api/torrentscontroller.cpp:503:28: style: Local variable 'hash' shadows outer variable [shadowVariable] qbittorrent-4.2.5/src/webui/api/torrentscontroller.cpp:496:19: note: Shadowed declaration qbittorrent-4.2.5/src/webui/api/torrentscontroller.cpp:503:28: note: Shadow variable qbittorrent-4.2.5/src/webui/api/torrentscontroller.cpp:683:30: style: Consider using std::copy_if algorithm instead of a raw loop. [useStlAlgorithm] diff: head qbittorrent-4.2.5/src/app/cmdoptions.cpp:109:28: style: Class 'BoolOption' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head qbittorrent-4.2.5/src/app/cmdoptions.cpp:146:28: style: Struct 'StringOption' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head qbittorrent-4.2.5/src/app/cmdoptions.cpp:193:28: style: Class 'IntOption' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head qbittorrent-4.2.5/src/app/cmdoptions.cpp:62:28: style: Class 'Option' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head qbittorrent-4.2.5/src/base/bittorrent/torrenthandleimpl.h:220:14: style: Virtual function 'setSequentialDownload' is called from constructor 'TorrentHandleImpl(Session*session,const lt::torrent_handle&nativeHandle,const CreateTorrentParams¶ms)' at line 195. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/base/bittorrent/torrenthandleimpl.cpp:195:9: note: Calling setSequentialDownload qbittorrent-4.2.5/src/base/bittorrent/torrenthandleimpl.h:220:14: note: setSequentialDownload is a virtual function head qbittorrent-4.2.5/src/base/bittorrent/torrenthandleimpl.h:221:14: style: Virtual function 'setFirstLastPiecePriority' is called from constructor 'TorrentHandleImpl(Session*session,const lt::torrent_handle&nativeHandle,const CreateTorrentParams¶ms)' at line 197. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/base/bittorrent/torrenthandleimpl.cpp:197:9: note: Calling setFirstLastPiecePriority qbittorrent-4.2.5/src/base/bittorrent/torrenthandleimpl.h:221:14: note: setFirstLastPiecePriority is a virtual function head qbittorrent-4.2.5/src/base/tristatebool.h:41:24: style: Class 'TriStateBool' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head qbittorrent-4.2.5/src/base/tristatebool.h:59:24: style: Class 'TriStateBool' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head qbittorrent-4.2.5/src/gui/categoryfiltermodel.h:57:17: style: Virtual function 'index' is called from constructor 'CategoryFilterModel(QObject*parent=nullptr)' at line 181. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/gui/categoryfiltermodel.cpp:181:75: note: Calling categoryAdded qbittorrent-4.2.5/src/gui/categoryfiltermodel.cpp:316:21: note: Calling index qbittorrent-4.2.5/src/gui/categoryfiltermodel.cpp:302:12: note: Calling index qbittorrent-4.2.5/src/gui/categoryfiltermodel.h:57:17: note: index is a virtual function head qbittorrent-4.2.5/src/gui/categoryfiltermodel.h:57:17: style: Virtual function 'index' is called from constructor 'CategoryFilterModel(QObject*parent=nullptr)' at line 183. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/gui/categoryfiltermodel.cpp:183:84: note: Calling torrentCategoryChanged qbittorrent-4.2.5/src/gui/categoryfiltermodel.cpp:359:9: note: Calling index qbittorrent-4.2.5/src/gui/categoryfiltermodel.cpp:302:12: note: Calling index qbittorrent-4.2.5/src/gui/categoryfiltermodel.h:57:17: note: index is a virtual function head qbittorrent-4.2.5/src/gui/fspathedit.h:55:6: style: Virtual function 'FileSystemPathEdit' is called from constructor 'FileSystemPathEdit(Private::FileEditorWithCompletion*editor,QWidget*parent)' at line 186. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/gui/fspathedit.cpp:186:9: note: Calling FileSystemPathEdit qbittorrent-4.2.5/src/gui/fspathedit.h:55:6: note: FileSystemPathEdit is a virtual function head qbittorrent-4.2.5/src/gui/mainwindow.cpp:1222:44: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] head qbittorrent-4.2.5/src/gui/tagfiltermodel.h:58:17: style: Virtual function 'index' is called from constructor 'TagFilterModel(QObject*parent=nullptr)' at line 100. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/gui/tagfiltermodel.cpp:100:74: note: Calling torrentTagRemoved qbittorrent-4.2.5/src/gui/tagfiltermodel.cpp:228:27: note: Calling index qbittorrent-4.2.5/src/gui/tagfiltermodel.h:58:17: note: index is a virtual function head qbittorrent-4.2.5/src/gui/tagfiltermodel.h:58:17: style: Virtual function 'index' is called from constructor 'TagFilterModel(QObject*parent=nullptr)' at line 98. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/gui/tagfiltermodel.cpp:98:67: note: Calling tagRemoved qbittorrent-4.2.5/src/gui/tagfiltermodel.cpp:197:21: note: Calling index qbittorrent-4.2.5/src/gui/tagfiltermodel.cpp:175:12: note: Calling index qbittorrent-4.2.5/src/gui/tagfiltermodel.h:58:17: note: index is a virtual function head qbittorrent-4.2.5/src/gui/tagfiltermodel.h:58:17: style: Virtual function 'index' is called from constructor 'TagFilterModel(QObject*parent=nullptr)' at line 99. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/gui/tagfiltermodel.cpp:99:72: note: Calling torrentTagAdded qbittorrent-4.2.5/src/gui/tagfiltermodel.cpp:213:27: note: Calling index qbittorrent-4.2.5/src/gui/tagfiltermodel.h:58:17: note: index is a virtual function head qbittorrent-4.2.5/src/gui/transferlistfilterswidget.h:69:18: warning: Call of pure virtual function 'showMenu' in constructor. [pureVirtualCall] qbittorrent-4.2.5/src/gui/transferlistfilterswidget.cpp:120:91: note: Calling showMenu qbittorrent-4.2.5/src/gui/transferlistfilterswidget.h:69:18: note: showMenu is a pure virtual function without body head qbittorrent-4.2.5/src/gui/transferlistfilterswidget.h:70:18: warning: Call of pure virtual function 'applyFilter' in constructor. [pureVirtualCall] qbittorrent-4.2.5/src/gui/transferlistfilterswidget.cpp:121:82: note: Calling applyFilter qbittorrent-4.2.5/src/gui/transferlistfilterswidget.h:70:18: note: applyFilter is a pure virtual function without body head qbittorrent-4.2.5/src/gui/transferlistfilterswidget.h:71:18: warning: Call of pure virtual function 'handleNewTorrent' in constructor. [pureVirtualCall] qbittorrent-4.2.5/src/gui/transferlistfilterswidget.cpp:124:40: note: Calling handleNewTorrent qbittorrent-4.2.5/src/gui/transferlistfilterswidget.h:71:18: note: handleNewTorrent is a pure virtual function without body head qbittorrent-4.2.5/src/gui/transferlistfilterswidget.h:72:18: warning: Call of pure virtual function 'torrentAboutToBeDeleted' in constructor. [pureVirtualCall] qbittorrent-4.2.5/src/gui/transferlistfilterswidget.cpp:126:40: note: Calling torrentAboutToBeDeleted qbittorrent-4.2.5/src/gui/transferlistfilterswidget.h:72:18: note: torrentAboutToBeDeleted is a pure virtual function without body head qbittorrent-4.2.5/src/gui/transferlistmodel.h:96:9: style: Virtual function 'columnCount' is called from constructor 'TransferListModel(QObject*parent=nullptr)' at line 119. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:119:87: note: Calling handleTorrentsUpdated qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:567:26: note: Calling columnCount qbittorrent-4.2.5/src/gui/transferlistmodel.h:96:9: note: columnCount is a virtual function head qbittorrent-4.2.5/src/gui/transferlistmodel.h:96:9: style: Virtual function 'columnCount' is called from constructor 'TransferListModel(QObject*parent=nullptr)' at line 121. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:121:87: note: Calling handleTorrentStatusUpdated qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:562:48: note: Calling columnCount qbittorrent-4.2.5/src/gui/transferlistmodel.h:96:9: note: columnCount is a virtual function head qbittorrent-4.2.5/src/gui/transferlistmodel.h:96:9: style: Virtual function 'columnCount' is called from constructor 'TransferListModel(QObject*parent=nullptr)' at line 122. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:122:93: note: Calling handleTorrentStatusUpdated qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:562:48: note: Calling columnCount qbittorrent-4.2.5/src/gui/transferlistmodel.h:96:9: note: columnCount is a virtual function head qbittorrent-4.2.5/src/gui/transferlistmodel.h:96:9: style: Virtual function 'columnCount' is called from constructor 'TransferListModel(QObject*parent=nullptr)' at line 123. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:123:86: note: Calling handleTorrentStatusUpdated qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:562:48: note: Calling columnCount qbittorrent-4.2.5/src/gui/transferlistmodel.h:96:9: note: columnCount is a virtual function head qbittorrent-4.2.5/src/gui/transferlistmodel.h:96:9: style: Virtual function 'columnCount' is called from constructor 'TransferListModel(QObject*parent=nullptr)' at line 124. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:124:85: note: Calling handleTorrentStatusUpdated qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:562:48: note: Calling columnCount qbittorrent-4.2.5/src/gui/transferlistmodel.h:96:9: note: columnCount is a virtual function head qbittorrent-4.2.5/src/gui/transferlistmodel.h:96:9: style: Virtual function 'columnCount' is called from constructor 'TransferListModel(QObject*parent=nullptr)' at line 125. Dynamic binding is not used. [virtualCallInConstructor] qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:125:95: note: Calling handleTorrentStatusUpdated qbittorrent-4.2.5/src/gui/transferlistmodel.cpp:562:48: note: Calling columnCount qbittorrent-4.2.5/src/gui/transferlistmodel.h:96:9: note: columnCount is a virtual function DONE