2024-04-21 09:58 ftp://ftp.de.debian.org/debian/pool/main/p/python-fisx/python-fisx_1.3.1.orig.tar.gz cppcheck-options: --library=posix --library=gnu --library=openmp --library=python --showtime=top5 --check-library --inconclusive --enable=style,information --inline-suppr --disable=missingInclude --suppress=unmatchedSuppression --template=daca2 --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning -D__GNUC__ --platform=unix64 -j1 platform: Linux-6.6.15-amd64-x86_64-with-glibc2.37 python: 3.11.8 client-version: 1.3.49 compiler: g++ (Debian 13.2.0-13) 13.2.0 cppcheck: head 2.14.0 head-info: 4f922b0 (2024-04-21 11:41:48 +0200) count: 362 362 elapsed-time: 7.6 7.4 head-timing-info: Tokenizer::simplifyTokens1::ValueFlow: 6.02442s (avg. 0.376526s - 16 result(s)) valueFlowLifetime(tokenlist, errorLogger, settings): 1.16435s (avg. 0.0187799s - 62 result(s)) valueFlowAfterAssign(tokenlist, symboldatabase, errorLogger, settings, skippedFunctions): 1.1388s (avg. 0.0247565s - 46 result(s)) valueFlowCondition(SimpleConditionHandler{}, tokenlist, symboldatabase, errorLogger, settings, skippedFunctions): 0.847541s (avg. 0.0184248s - 46 result(s)) valueFlowCondition(SymbolicConditionHandler{}, tokenlist, symboldatabase, errorLogger, settings, skippedFunctions): 0.671165s (avg. 0.0145905s - 46 result(s)) Overall time: 6.95297s old-timing-info: Tokenizer::simplifyTokens1::ValueFlow: 6.005s (avg. 0.375313s - 16 result(s)) valueFlowLifetime(tokenlist, errorLogger, settings): 1.1535s (avg. 0.0186048s - 62 result(s)) valueFlowAfterAssign(tokenlist, symboldatabase, errorLogger, settings, skippedFunctions): 1.13013s (avg. 0.024568s - 46 result(s)) valueFlowCondition(SimpleConditionHandler{}, tokenlist, symboldatabase, errorLogger, settings, skippedFunctions): 0.857582s (avg. 0.0186431s - 46 result(s)) valueFlowCondition(SymbolicConditionHandler{}, tokenlist, symboldatabase, errorLogger, settings, skippedFunctions): 0.668568s (avg. 0.0145341s - 46 result(s)) Overall time: 6.92503s head results: fisx-1.3.1/python/cython/default/_fisx.cpp:8:0: error: #error Python headers needed to compile C extensions, please install development version of Python. [preprocessorErrorDirective] fisx-1.3.1/src/fisx_beam.cpp:258:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable endl [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_beam.h:99:30: style:inconclusive: Technically the member function 'fisx::Beam::getBeam' can be const. [functionConst] fisx-1.3.1/src/fisx_beam.cpp:245:32: note: Technically the member function 'fisx::Beam::getBeam' can be const. fisx-1.3.1/src/fisx_beam.h:99:30: note: Technically the member function 'fisx::Beam::getBeam' can be const. fisx-1.3.1/src/fisx_beam.cpp:218:16: style: The scope of the variable 'ray' can be reduced. [variableScope] fisx-1.3.1/src/fisx_material.h:83:12: style:inconclusive: Technically the member function 'fisx::Material::getDefaultDensity' can be const. [functionConst] fisx-1.3.1/src/fisx_material.h:84:12: style:inconclusive: Technically the member function 'fisx::Material::getDefaultThickness' can be const. [functionConst] fisx-1.3.1/src/fisx_elements.h:617:14: style:inconclusive: Technically the member function 'fisx::Elements::sortVectorOfExcited::operator()' can be const. [functionConst] fisx-1.3.1/src/fisx_detector.cpp:47:16: warning: The class 'Detector' defines member function with name 'setMaterial' also defined in its parent class 'Layer'. [duplInheritedMember] fisx-1.3.1/src/fisx_layer.h:53:10: note: Parent function 'Layer::setMaterial' fisx-1.3.1/src/fisx_detector.cpp:47:16: note: Derived function 'Detector::setMaterial' fisx-1.3.1/src/fisx_detector.cpp:53:16: warning: The class 'Detector' defines member function with name 'setMaterial' also defined in its parent class 'Layer'. [duplInheritedMember] fisx-1.3.1/src/fisx_layer.h:55:10: note: Parent function 'Layer::setMaterial' fisx-1.3.1/src/fisx_detector.cpp:53:16: note: Derived function 'Detector::setMaterial' fisx-1.3.1/src/fisx_simplespecfile.h:59:5: style: Class 'SimpleSpecfile' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] fisx-1.3.1/src/fisx_shell.h:47:5: style: Class 'Shell' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] fisx-1.3.1/src/fisx_epdl97.h:42:5: style: Class 'EPDL97' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] fisx-1.3.1/src/fisx_material.h:56:5: style: Class 'Material' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] fisx-1.3.1/src/fisx_elements.h:73:5: style: Class 'Elements' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] fisx-1.3.1/src/fisx_layer.h:47:5: style: Class 'Layer' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] fisx-1.3.1/src/fisx_detector.h:48:5: style: Class 'Detector' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] fisx-1.3.1/src/fisx_element.cpp:264:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_element.cpp:455:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_element.cpp:573:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable first [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_element.cpp:642:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_element.cpp:873:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_element.cpp:1143:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_element.cpp:1185:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_element.cpp:1332:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_element.cpp:1456:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_element.cpp:1744:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_element.cpp:38:10: warning: Member variable 'Element::atomicMass' is not initialized in the constructor. [uninitMemberVar] fisx-1.3.1/src/fisx_element.cpp:66:10: warning: Member variable 'Element::atomicMass' is not initialized in the constructor. [uninitMemberVar] fisx-1.3.1/src/fisx_element.h:183:10: performance:inconclusive: Technically the member function 'fisx::Element::setTotalMassAttenuationCoefficient' can be static (but you may consider moving to unnamed namespace). [functionStatic] fisx-1.3.1/src/fisx_element.cpp:307:15: note: Technically the member function 'fisx::Element::setTotalMassAttenuationCoefficient' can be static (but you may consider moving to unnamed namespace). fisx-1.3.1/src/fisx_element.h:183:10: note: Technically the member function 'fisx::Element::setTotalMassAttenuationCoefficient' can be static (but you may consider moving to unnamed namespace). fisx-1.3.1/src/fisx_element.h:327:43: style:inconclusive: Technically the member function 'fisx::Element::getAugerRatios' can be const. [functionConst] fisx-1.3.1/src/fisx_element.cpp:1088:48: note: Technically the member function 'fisx::Element::getAugerRatios' can be const. fisx-1.3.1/src/fisx_element.h:327:43: note: Technically the member function 'fisx::Element::getAugerRatios' can be const. fisx-1.3.1/src/fisx_element.h:328:67: style:inconclusive: Technically the member function 'fisx::Element::getCosterKronigRatios' can be const. [functionConst] fisx-1.3.1/src/fisx_element.cpp:1095:72: note: Technically the member function 'fisx::Element::getCosterKronigRatios' can be const. fisx-1.3.1/src/fisx_element.h:328:67: note: Technically the member function 'fisx::Element::getCosterKronigRatios' can be const. fisx-1.3.1/src/fisx_element.h:333:27: performance:inconclusive: Technically the member function 'fisx::Element::getInterpolationIndices' can be static (but you may consider moving to unnamed namespace). [functionStatic] fisx-1.3.1/src/fisx_element.cpp:1565:32: note: Technically the member function 'fisx::Element::getInterpolationIndices' can be static (but you may consider moving to unnamed namespace). fisx-1.3.1/src/fisx_element.h:333:27: note: Technically the member function 'fisx::Element::getInterpolationIndices' can be static (but you may consider moving to unnamed namespace). fisx-1.3.1/src/fisx_element.cpp:855:25: style: Variable 'x0w' is reassigned a value before the old one has been used. [redundantAssignment] fisx-1.3.1/src/fisx_element.cpp:850:29: note: x0w is assigned fisx-1.3.1/src/fisx_element.cpp:855:25: note: x0w is overwritten fisx-1.3.1/src/fisx_element.cpp:856:25: style: Variable 'x1w' is reassigned a value before the old one has been used. [redundantAssignment] fisx-1.3.1/src/fisx_element.cpp:851:29: note: x1w is assigned fisx-1.3.1/src/fisx_element.cpp:856:25: note: x1w is overwritten fisx-1.3.1/src/fisx_element.cpp:148:17: style: The scope of the variable 'tmpString' can be reduced. [variableScope] fisx-1.3.1/src/fisx_element.cpp:331:12: style: The scope of the variable 'A' can be reduced. [variableScope] fisx-1.3.1/src/fisx_element.cpp:331:15: style: The scope of the variable 'B' can be reduced. [variableScope] fisx-1.3.1/src/fisx_element.cpp:331:26: style: The scope of the variable 'y0' can be reduced. [variableScope] fisx-1.3.1/src/fisx_element.cpp:331:30: style: The scope of the variable 'y1' can be reduced. [variableScope] fisx-1.3.1/src/fisx_element.cpp:520:17: style: The scope of the variable 'key' can be reduced. [variableScope] fisx-1.3.1/src/fisx_element.cpp:525:12: style: The scope of the variable 'shellIndex' can be reduced. [variableScope] fisx-1.3.1/src/fisx_element.cpp:621:17: style: The scope of the variable 'msg' can be reduced. [variableScope] fisx-1.3.1/src/fisx_element.cpp:686:17: style: The scope of the variable 'shell' can be reduced. [variableScope] fisx-1.3.1/src/fisx_element.cpp:914:17: style: The scope of the variable 'shell' can be reduced. [variableScope] fisx-1.3.1/src/fisx_element.cpp:945:17: style: The scope of the variable 'shell' can be reduced. [variableScope] fisx-1.3.1/src/fisx_element.cpp:946:12: style: The scope of the variable 'total' can be reduced. [variableScope] fisx-1.3.1/src/fisx_element.cpp:1056:17: style: The scope of the variable 'msg' can be reduced. [variableScope] fisx-1.3.1/src/fisx_element.cpp:1071:17: style: The scope of the variable 'msg' can be reduced. [variableScope] fisx-1.3.1/src/fisx_element.cpp:1617:10: style: The scope of the variable 'oldFlag' can be reduced. [variableScope] fisx-1.3.1/src/fisx_element.cpp:102:47: style:inconclusive: Function 'setLongName' argument 1 names different: declaration 'name' definition 'longName'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_element.h:105:42: note: Function 'setLongName' argument 1 names different: declaration 'name' definition 'longName'. fisx-1.3.1/src/fisx_element.cpp:102:47: note: Function 'setLongName' argument 1 names different: declaration 'name' definition 'longName'. fisx-1.3.1/src/fisx_element.cpp:179:87: style:inconclusive: Function 'setBindingEnergies' argument 2 names different: declaration 'energies' definition 'bindingEnergies'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_element.h:143:82: note: Function 'setBindingEnergies' argument 2 names different: declaration 'energies' definition 'bindingEnergies'. fisx-1.3.1/src/fisx_element.cpp:179:87: note: Function 'setBindingEnergies' argument 2 names different: declaration 'energies' definition 'bindingEnergies'. fisx-1.3.1/src/fisx_element.cpp:206:316: style:inconclusive: Function 'setMassAttenuationCoefficients' argument 4 names different: declaration 'incoherent' definition 'compton'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_element.h:172:311: note: Function 'setMassAttenuationCoefficients' argument 4 names different: declaration 'incoherent' definition 'compton'. fisx-1.3.1/src/fisx_element.cpp:206:316: note: Function 'setMassAttenuationCoefficients' argument 4 names different: declaration 'incoherent' definition 'compton'. fisx-1.3.1/src/fisx_element.cpp:215:316: style:inconclusive: Function 'setMassAttenuationCoefficients' argument 4 names different: declaration 'incoherent' definition 'compton'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_element.h:162:311: note: Function 'setMassAttenuationCoefficients' argument 4 names different: declaration 'incoherent' definition 'compton'. fisx-1.3.1/src/fisx_element.cpp:215:316: note: Function 'setMassAttenuationCoefficients' argument 4 names different: declaration 'incoherent' definition 'compton'. fisx-1.3.1/src/fisx_element.cpp:504:145: style:inconclusive: Function 'extractEdgeEnergiesFromMassAttenuationCoefficients' argument 1 names different: declaration 'energies' definition 'muEnergy'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_element.h:204:192: note: Function 'extractEdgeEnergiesFromMassAttenuationCoefficients' argument 1 names different: declaration 'energies' definition 'muEnergy'. fisx-1.3.1/src/fisx_element.cpp:504:145: note: Function 'extractEdgeEnergiesFromMassAttenuationCoefficients' argument 1 names different: declaration 'energies' definition 'muEnergy'. fisx-1.3.1/src/fisx_element.cpp:1463:44: style:inconclusive: Function 'setAtomicMass' argument 1 names different: declaration 'mass' definition 'A'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_element.h:82:39: note: Function 'setAtomicMass' argument 1 names different: declaration 'mass' definition 'A'. fisx-1.3.1/src/fisx_element.cpp:1463:44: note: Function 'setAtomicMass' argument 1 names different: declaration 'mass' definition 'A'. fisx-1.3.1/src/fisx_element.cpp:1321:64: style: Local variable 'c_it' shadows outer variable [shadowVariable] fisx-1.3.1/src/fisx_element.cpp:1299:51: note: Shadowed declaration fisx-1.3.1/src/fisx_element.cpp:1321:64: note: Shadow variable fisx-1.3.1/src/fisx_element.cpp:66:30: performance: Function parameter 'name' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_element.cpp:179:59: performance: Function parameter 'labels' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_element.cpp:179:87: performance: Function parameter 'bindingEnergies' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_element.cpp:967:125: performance: Function parameter 'labels' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_element.cpp:967:153: performance: Function parameter 'values' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_element.cpp:988:91: performance: Function parameter 'values' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_element.cpp:1017:89: performance: Function parameter 'labels' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_element.cpp:1017:117: performance: Function parameter 'values' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_element.cpp:1035:94: performance: Function parameter 'values' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_element.cpp:1069:85: performance: Function parameter 'constants' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_element.cpp:1088:75: performance: Function parameter 'subshell' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_element.cpp:1095:106: performance: Function parameter 'subshell' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_element.cpp:518:17: style: Variable 'shellList' can be declared as const array [constVariable] fisx-1.3.1/src/fisx_element.cpp:603:17: style: Variable 'photoShells' can be declared as const array [constVariable] fisx-1.3.1/src/fisx_element.cpp:685:17: style: Variable 'shellList' can be declared as const array [constVariable] fisx-1.3.1/src/fisx_element.cpp:916:17: style: Variable 'shellList' can be declared as const array [constVariable] fisx-1.3.1/src/fisx_element.cpp:947:17: style: Variable 'shellList' can be declared as const array [constVariable] fisx-1.3.1/src/fisx_element.cpp:170:55: performance: Searching before insertion is not necessary. Instead of 'this->shellInstance[it->first]=Shell(it->first)' consider using 'this->shellInstance.try_emplace(it->first, Shell(it->first));'. [stlFindInsert] fisx-1.3.1/src/fisx_element.cpp:1727:84: performance: Searching before insertion is not necessary. Instead of 'this->muCache[energy[i]]=this->getMassAttenuationCoefficients(energy[i])' consider using 'this->muCache.try_emplace(energy[i], this->getMassAttenuationCoefficients(energy[i]));'. [stlFindInsert] fisx-1.3.1/src/fisx_element.cpp:1731:102: performance: Searching before insertion is not necessary. Instead of 'this->excitationFactorsCache[energy[i]]=this->getPhotoelectricExcitationFactors(energy[i],1.0)' consider using 'this->excitationFactorsCache.try_emplace(energy[i], this->getPhotoelectricExcitationFactors(energy[i],1.0));'. [stlFindInsert] fisx-1.3.1/src/fisx_element.cpp:359:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] fisx-1.3.1/src/fisx_element.cpp:1285:26: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] fisx-1.3.1/src/fisx_element.cpp:222:41: style: Unused variable: c_it [unusedVariable] fisx-1.3.1/src/fisx_element.cpp:516:62: style: Unused variable: result_it [unusedVariable] fisx-1.3.1/src/fisx_element.cpp:891:17: style: Unused variable: shell [unusedVariable] fisx-1.3.1/src/fisx_element.cpp:1167:50: style: Unused variable: shell_it [unusedVariable] fisx-1.3.1/src/fisx_element.cpp:1247:17: style: Unused variable: tmpString [unusedVariable] fisx-1.3.1/src/fisx_element.cpp:1250:35: style: Unused variable: fluorescenceRatios [unusedVariable] fisx-1.3.1/src/fisx_element.cpp:1251:58: style: Unused variable: result [unusedVariable] fisx-1.3.1/src/fisx_element.cpp:1253:51: style: Unused variable: bind_it [unusedVariable] fisx-1.3.1/src/fisx_element.cpp:1306:35: style: Unused variable: transferRatios [unusedVariable] fisx-1.3.1/src/fisx_element.cpp:1504:69: style: Unused variable: it [unusedVariable] fisx-1.3.1/src/fisx_element.cpp:1152:83: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] fisx-1.3.1/src/fisx_element.cpp:1383:83: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] fisx-1.3.1/src/fisx_elements.cpp:649:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_elements.cpp:797:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable second [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_elements.cpp:1112:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_elements.cpp:1504:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_elements.cpp:2320:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_elements.cpp:2091:68: style: Expression 'log(1 + x)' can be replaced by 'log1p(x)' to avoid loss of precision. [unpreciseMathCall] fisx-1.3.1/src/fisx_elements.cpp:70:11: warning: Member variable 'Elements::detectorEnergyThresholdUsedInCache' is not initialized in the constructor. [uninitMemberVar] fisx-1.3.1/src/fisx_elements.cpp:70:11: warning: Member variable 'Elements::detectorIntensityThresholdUsedInCache' is not initialized in the constructor. [uninitMemberVar] fisx-1.3.1/src/fisx_elements.cpp:70:11: warning: Member variable 'Elements::detectorNThresholdUsedInCache' is not initialized in the constructor. [uninitMemberVar] fisx-1.3.1/src/fisx_elements.cpp:70:11: warning: Member variable 'Elements::detectorAlphaInUsedInCache' is not initialized in the constructor. [uninitMemberVar] fisx-1.3.1/src/fisx_elements.cpp:70:11: warning: Member variable 'Elements::detectorThicknessUsedInCache' is not initialized in the constructor. [uninitMemberVar] fisx-1.3.1/src/fisx_elements.cpp:70:11: warning: Member variable 'Elements::escapeCacheEnabled' is not initialized in the constructor. [uninitMemberVar] fisx-1.3.1/src/fisx_elements.h:306:14: style:inconclusive: Technically the member function 'fisx::Elements::createMaterial' can be const. [functionConst] fisx-1.3.1/src/fisx_elements.cpp:1169:20: note: Technically the member function 'fisx::Elements::createMaterial' can be const. fisx-1.3.1/src/fisx_elements.h:306:14: note: Technically the member function 'fisx::Elements::createMaterial' can be const. fisx-1.3.1/src/fisx_elements.h:331:22: style:inconclusive: Technically the member function 'fisx::Elements::getMaterial' can be const. [functionConst] fisx-1.3.1/src/fisx_elements.cpp:1247:28: note: Technically the member function 'fisx::Elements::getMaterial' can be const. fisx-1.3.1/src/fisx_elements.h:331:22: note: Technically the member function 'fisx::Elements::getMaterial' can be const. fisx-1.3.1/src/fisx_elements.h:341:14: style:inconclusive: Technically the member function 'fisx::Elements::getMaterialCopy' can be const. [functionConst] fisx-1.3.1/src/fisx_elements.cpp:1275:20: note: Technically the member function 'fisx::Elements::getMaterialCopy' can be const. fisx-1.3.1/src/fisx_elements.h:341:14: note: Technically the member function 'fisx::Elements::getMaterialCopy' can be const. fisx-1.3.1/src/fisx_elements.h:400:35: performance:inconclusive: Technically the member function 'fisx::Elements::parseFormula' can be static (but you may consider moving to unnamed namespace). [functionStatic] fisx-1.3.1/src/fisx_elements.cpp:1612:41: note: Technically the member function 'fisx::Elements::parseFormula' can be static (but you may consider moving to unnamed namespace). fisx-1.3.1/src/fisx_elements.h:400:35: note: Technically the member function 'fisx::Elements::parseFormula' can be static (but you may consider moving to unnamed namespace). fisx-1.3.1/src/fisx_elements.cpp:85:17: style: The scope of the variable 'BINDING_ENERGIES' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:151:17: style: The scope of the variable 'symbol' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:152:12: style: The scope of the variable 'atomicNumber' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:154:49: style: The scope of the variable 'massAttenuationCoefficients' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:282:9: style: The scope of the variable 'i' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:620:30: style: The scope of the variable 'labels' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:984:17: style: The scope of the variable 'msg' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:1000:17: style: The scope of the variable 'msg' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:1001:35: style: The scope of the variable 'composition' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:1026:17: style: The scope of the variable 'msg' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:1027:35: style: The scope of the variable 'composition' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:1077:26: style: The scope of the variable 'msg' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:1077:31: style: The scope of the variable 'name' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:1189:17: style: The scope of the variable 'msg' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:1220:17: style: The scope of the variable 'msg' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:1235:17: style: The scope of the variable 'msg' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:1249:17: style: The scope of the variable 'msg' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:1277:17: style: The scope of the variable 'msg' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:1292:17: style: The scope of the variable 'msg' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:1330:17: style: The scope of the variable 'msg' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:1516:17: style: The scope of the variable 'name' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:1622:17: style: The scope of the variable 'newFormula' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:1875:30: style: The scope of the variable 'shells' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:1947:17: style: The scope of the variable 'msg' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:2023:12: style: The scope of the variable 'massFraction' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:2078:16: style: The scope of the variable 'rate' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:2079:16: style: The scope of the variable 'fluorescentEnergy' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:2127:17: style: The scope of the variable 'msg' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:2141:9: style: The scope of the variable 'i' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:2154:9: style: The scope of the variable 'i' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:2167:9: style: The scope of the variable 'i' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:2180:9: style: The scope of the variable 'i' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:2194:9: style: The scope of the variable 'i' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:2208:9: style: The scope of the variable 'i' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:2223:9: style: The scope of the variable 'i' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:2237:9: style: The scope of the variable 'i' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:2316:12: style: The scope of the variable 'energy' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:2352:9: style: The scope of the variable 'i' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:2366:9: style: The scope of the variable 'i' can be reduced. [variableScope] fisx-1.3.1/src/fisx_elements.cpp:57:32: style:inconclusive: Function 'Elements' argument 1 names different: declaration 'dataDirectory' definition 'epdl97Directory'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:93:26: note: Function 'Elements' argument 1 names different: declaration 'dataDirectory' definition 'epdl97Directory'. fisx-1.3.1/src/fisx_elements.cpp:57:32: note: Function 'Elements' argument 1 names different: declaration 'dataDirectory' definition 'epdl97Directory'. fisx-1.3.1/src/fisx_elements.cpp:57:61: style:inconclusive: Function 'Elements' argument 2 names different: declaration 'bindingEnergiesFile' definition 'bindingEnergiesFileName'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:93:53: note: Function 'Elements' argument 2 names different: declaration 'bindingEnergiesFile' definition 'bindingEnergiesFileName'. fisx-1.3.1/src/fisx_elements.cpp:57:61: note: Function 'Elements' argument 2 names different: declaration 'bindingEnergiesFile' definition 'bindingEnergiesFileName'. fisx-1.3.1/src/fisx_elements.cpp:70:32: style:inconclusive: Function 'Elements' argument 1 names different: declaration 'dataDirectory' definition 'epdl97Directory'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:73:26: note: Function 'Elements' argument 1 names different: declaration 'dataDirectory' definition 'epdl97Directory'. fisx-1.3.1/src/fisx_elements.cpp:70:32: note: Function 'Elements' argument 1 names different: declaration 'dataDirectory' definition 'epdl97Directory'. fisx-1.3.1/src/fisx_elements.cpp:83:32: style:inconclusive: Function 'Elements' argument 1 names different: declaration 'dataDirectory' definition 'directoryName'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:82:26: note: Function 'Elements' argument 1 names different: declaration 'dataDirectory' definition 'directoryName'. fisx-1.3.1/src/fisx_elements.cpp:83:32: note: Function 'Elements' argument 1 names different: declaration 'dataDirectory' definition 'directoryName'. fisx-1.3.1/src/fisx_elements.cpp:301:43: style:inconclusive: Function 'addElement' argument 1 names different: declaration 'elementInstance' definition 'element'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:115:37: note: Function 'addElement' argument 1 names different: declaration 'elementInstance' definition 'element'. fisx-1.3.1/src/fisx_elements.cpp:301:43: note: Function 'addElement' argument 1 names different: declaration 'elementInstance' definition 'element'. fisx-1.3.1/src/fisx_elements.cpp:716:67: style:inconclusive: Function 'setMassAttenuationCoefficients' argument 1 names different: declaration 'elementName' definition 'name'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:250:61: note: Function 'setMassAttenuationCoefficients' argument 1 names different: declaration 'elementName' definition 'name'. fisx-1.3.1/src/fisx_elements.cpp:716:67: note: Function 'setMassAttenuationCoefficients' argument 1 names different: declaration 'elementName' definition 'name'. fisx-1.3.1/src/fisx_elements.cpp:981:172: style:inconclusive: Function 'getMassAttenuationCoefficients' argument 1 names different: declaration 'elementName' definition 'name'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:260:158: note: Function 'getMassAttenuationCoefficients' argument 1 names different: declaration 'elementName' definition 'name'. fisx-1.3.1/src/fisx_elements.cpp:981:172: note: Function 'getMassAttenuationCoefficients' argument 1 names different: declaration 'elementName' definition 'name'. fisx-1.3.1/src/fisx_elements.cpp:998:84: style:inconclusive: Function 'getMassAttenuationCoefficients' argument 1 names different: declaration 'formula' definition 'name'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:289:78: note: Function 'getMassAttenuationCoefficients' argument 1 names different: declaration 'formula' definition 'name'. fisx-1.3.1/src/fisx_elements.cpp:998:84: note: Function 'getMassAttenuationCoefficients' argument 1 names different: declaration 'formula' definition 'name'. fisx-1.3.1/src/fisx_elements.cpp:1022:164: style:inconclusive: Function 'getMassAttenuationCoefficients' argument 1 names different: declaration 'formula' definition 'name'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:268:154: note: Function 'getMassAttenuationCoefficients' argument 1 names different: declaration 'formula' definition 'name'. fisx-1.3.1/src/fisx_elements.cpp:1022:164: note: Function 'getMassAttenuationCoefficients' argument 1 names different: declaration 'formula' definition 'name'. fisx-1.3.1/src/fisx_elements.cpp:1022:255: style:inconclusive: Function 'getMassAttenuationCoefficients' argument 2 names different: declaration 'energies' definition 'energy'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:270:81: note: Function 'getMassAttenuationCoefficients' argument 2 names different: declaration 'energies' definition 'energy'. fisx-1.3.1/src/fisx_elements.cpp:1022:255: note: Function 'getMassAttenuationCoefficients' argument 2 names different: declaration 'energies' definition 'energy'. fisx-1.3.1/src/fisx_elements.cpp:1049:159: style:inconclusive: Function 'getMassAttenuationCoefficients' argument 1 names different: declaration 'elementMassFractions' definition 'inputFormulaDict'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:296:153: note: Function 'getMassAttenuationCoefficients' argument 1 names different: declaration 'elementMassFractions' definition 'inputFormulaDict'. fisx-1.3.1/src/fisx_elements.cpp:1049:159: note: Function 'getMassAttenuationCoefficients' argument 1 names different: declaration 'elementMassFractions' definition 'inputFormulaDict'. fisx-1.3.1/src/fisx_elements.cpp:1049:240: style:inconclusive: Function 'getMassAttenuationCoefficients' argument 2 names different: declaration 'energies' definition 'inputEnergy'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:296:238: note: Function 'getMassAttenuationCoefficients' argument 2 names different: declaration 'energies' definition 'inputEnergy'. fisx-1.3.1/src/fisx_elements.cpp:1049:240: note: Function 'getMassAttenuationCoefficients' argument 2 names different: declaration 'energies' definition 'inputEnergy'. fisx-1.3.1/src/fisx_elements.cpp:1072:173: style:inconclusive: Function 'getMassAttenuationCoefficients' argument 1 names different: declaration 'elementMassFractions' definition 'inputFormulaDict'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:277:167: note: Function 'getMassAttenuationCoefficients' argument 1 names different: declaration 'elementMassFractions' definition 'inputFormulaDict'. fisx-1.3.1/src/fisx_elements.cpp:1072:173: note: Function 'getMassAttenuationCoefficients' argument 1 names different: declaration 'elementMassFractions' definition 'inputFormulaDict'. fisx-1.3.1/src/fisx_elements.cpp:1072:267: style:inconclusive: Function 'getMassAttenuationCoefficients' argument 2 names different: declaration 'energies' definition 'energy'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:277:265: note: Function 'getMassAttenuationCoefficients' argument 2 names different: declaration 'energies' definition 'energy'. fisx-1.3.1/src/fisx_elements.cpp:1072:267: note: Function 'getMassAttenuationCoefficients' argument 2 names different: declaration 'energies' definition 'energy'. fisx-1.3.1/src/fisx_elements.cpp:1290:45: style:inconclusive: Function 'addMaterial' argument 1 names different: declaration 'materialInstance' definition 'material'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:346:39: note: Function 'addMaterial' argument 1 names different: declaration 'materialInstance' definition 'material'. fisx-1.3.1/src/fisx_elements.cpp:1290:45: note: Function 'addMaterial' argument 1 names different: declaration 'materialInstance' definition 'material'. fisx-1.3.1/src/fisx_elements.cpp:1394:94: style:inconclusive: Function 'getComposition' argument 1 names different: declaration 'composition' definition 'inputComposition'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:393:88: note: Function 'getComposition' argument 1 names different: declaration 'composition' definition 'inputComposition'. fisx-1.3.1/src/fisx_elements.cpp:1394:94: note: Function 'getComposition' argument 1 names different: declaration 'composition' definition 'inputComposition'. fisx-1.3.1/src/fisx_elements.cpp:1394:198: style:inconclusive: Function 'getComposition' argument 2 names different: declaration 'materials' definition 'additionalMaterials'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:393:181: note: Function 'getComposition' argument 2 names different: declaration 'materials' definition 'additionalMaterials'. fisx-1.3.1/src/fisx_elements.cpp:1394:198: note: Function 'getComposition' argument 2 names different: declaration 'materials' definition 'additionalMaterials'. fisx-1.3.1/src/fisx_elements.cpp:1432:162: style:inconclusive: Function 'getComposition' argument 2 names different: declaration 'materials' definition 'additionalMaterials'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:384:156: note: Function 'getComposition' argument 2 names different: declaration 'materials' definition 'additionalMaterials'. fisx-1.3.1/src/fisx_elements.cpp:1432:162: note: Function 'getComposition' argument 2 names different: declaration 'materials' definition 'additionalMaterials'. fisx-1.3.1/src/fisx_elements.cpp:1552:57: style:inconclusive: Function 'getExcitationFactors' argument 2 names different: declaration 'energy' definition 'energies'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:409:57: note: Function 'getExcitationFactors' argument 2 names different: declaration 'energy' definition 'energies'. fisx-1.3.1/src/fisx_elements.cpp:1552:57: note: Function 'getExcitationFactors' argument 2 names different: declaration 'energy' definition 'energies'. fisx-1.3.1/src/fisx_elements.cpp:1565:44: style:inconclusive: Function 'getExcitationFactors' argument 3 names different: declaration 'weights' definition 'weight'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:419:96: note: Function 'getExcitationFactors' argument 3 names different: declaration 'weights' definition 'weight'. fisx-1.3.1/src/fisx_elements.cpp:1565:44: note: Function 'getExcitationFactors' argument 3 names different: declaration 'weights' definition 'weight'. fisx-1.3.1/src/fisx_elements.cpp:1906:60: style:inconclusive: Function 'getAtomicMass' argument 1 names different: declaration 'name' definition 'element'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:441:54: note: Function 'getAtomicMass' argument 1 names different: declaration 'name' definition 'element'. fisx-1.3.1/src/fisx_elements.cpp:1906:60: note: Function 'getAtomicMass' argument 1 names different: declaration 'name' definition 'element'. fisx-1.3.1/src/fisx_elements.cpp:1911:59: style:inconclusive: Function 'getAtomicNumber' argument 1 names different: declaration 'name' definition 'element'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:446:53: note: Function 'getAtomicNumber' argument 1 names different: declaration 'name' definition 'element'. fisx-1.3.1/src/fisx_elements.cpp:1911:59: note: Function 'getAtomicNumber' argument 1 names different: declaration 'name' definition 'element'. fisx-1.3.1/src/fisx_elements.cpp:1916:88: style:inconclusive: Function 'getBindingEnergies' argument 1 names different: declaration 'name' definition 'element'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:452:82: note: Function 'getBindingEnergies' argument 1 names different: declaration 'name' definition 'element'. fisx-1.3.1/src/fisx_elements.cpp:1916:88: note: Function 'getBindingEnergies' argument 1 names different: declaration 'name' definition 'element'. fisx-1.3.1/src/fisx_elements.cpp:1921:49: style:inconclusive: Function 'getDensity' argument 1 names different: declaration 'name' definition 'element'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:457:43: note: Function 'getDensity' argument 1 names different: declaration 'name' definition 'element'. fisx-1.3.1/src/fisx_elements.cpp:1921:49: note: Function 'getDensity' argument 1 names different: declaration 'name' definition 'element'. fisx-1.3.1/src/fisx_elements.cpp:1926:55: style:inconclusive: Function 'getLongName' argument 1 names different: declaration 'name' definition 'element'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:462:49: note: Function 'getLongName' argument 1 names different: declaration 'name' definition 'element'. fisx-1.3.1/src/fisx_elements.cpp:1926:55: note: Function 'getLongName' argument 1 names different: declaration 'name' definition 'element'. fisx-1.3.1/src/fisx_elements.cpp:1931:42: style:inconclusive: Function 'getRow' argument 1 names different: declaration 'name' definition 'element'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:472:36: note: Function 'getRow' argument 1 names different: declaration 'name' definition 'element'. fisx-1.3.1/src/fisx_elements.cpp:1931:42: note: Function 'getRow' argument 1 names different: declaration 'name' definition 'element'. fisx-1.3.1/src/fisx_elements.cpp:1936:45: style:inconclusive: Function 'getColumn' argument 1 names different: declaration 'name' definition 'element'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:467:39: note: Function 'getColumn' argument 1 names different: declaration 'name' definition 'element'. fisx-1.3.1/src/fisx_elements.cpp:1936:45: note: Function 'getColumn' argument 1 names different: declaration 'name' definition 'element'. fisx-1.3.1/src/fisx_elements.cpp:2308:69: style:inconclusive: Function 'updateEscapeCache' argument 2 names different: declaration 'energy' definition 'energyList'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_elements.h:507:148: note: Function 'updateEscapeCache' argument 2 names different: declaration 'energy' definition 'energyList'. fisx-1.3.1/src/fisx_elements.cpp:2308:69: note: Function 'updateEscapeCache' argument 2 names different: declaration 'energy' definition 'energyList'. fisx-1.3.1/src/fisx_elements.cpp:57:32: performance: Function parameter 'epdl97Directory' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_elements.cpp:57:61: performance: Function parameter 'bindingEnergiesFileName' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_elements.cpp:57:98: performance: Function parameter 'crossSectionsFile' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_elements.cpp:70:32: performance: Function parameter 'epdl97Directory' should be passed by const reference. However it seems that 'Elements' is a callback function. [passedByValueCallback] fisx-1.3.1/src/fisx_elements.h:60:7: note: Function pointer used here. fisx-1.3.1/src/fisx_elements.cpp:70:32: note: Function parameter 'epdl97Directory' should be passed by const reference. However it seems that 'Elements' is a callback function. fisx-1.3.1/src/fisx_elements.cpp:83:32: performance: Function parameter 'directoryName' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_elements.cpp:136:39: performance: Function parameter 'epdl97Directory' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_elements.cpp:136:68: performance: Function parameter 'bindingEnergiesFile' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_elements.cpp:150:17: style: Variable 'shellList' can be declared as const array [constVariable] fisx-1.3.1/src/fisx_elements.cpp:727:17: style: Variable 'shellList' can be declared as const array [constVariable] fisx-1.3.1/src/fisx_elements.cpp:1120:48: performance: Searching before insertion is not necessary. Instead of 'elementsDict[it->first]=0.0' consider using 'elementsDict.try_emplace(it->first, 0.0);'. [stlFindInsert] fisx-1.3.1/src/fisx_elements.cpp:1386:41: performance: Searching before insertion is not necessary. Instead of 'result[c_it2->first]=0.0' consider using 'result.try_emplace(c_it2->first, 0.0);'. [stlFindInsert] fisx-1.3.1/src/fisx_elements.cpp:1413:41: performance: Searching before insertion is not necessary. Instead of 'result[c_it2->first]=0.0' consider using 'result.try_emplace(c_it2->first, 0.0);'. [stlFindInsert] fisx-1.3.1/src/fisx_elements.cpp:1493:41: performance: Searching before insertion is not necessary. Instead of 'result[c_it2->first]=0.0' consider using 'result.try_emplace(c_it2->first, 0.0);'. [stlFindInsert] fisx-1.3.1/src/fisx_elements.cpp:2335:64: performance: Searching before insertion is not necessary. Instead of 'this->detectorEscapeCache[energy]=this->getEscape(composition,energy,energyThreshold,intensityThreshold,nThreshold,alphaIn,thickness)' consider using 'this->detectorEscapeCache.try_emplace(energy, this->getEscape(composition,energy,energyThreshold,intensityThreshold,nThreshold,alphaIn,thickness));'. [stlFindInsert] fisx-1.3.1/src/fisx_elements.cpp:1367:15: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] fisx-1.3.1/src/fisx_elements.cpp:1423:15: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] fisx-1.3.1/src/fisx_elements.cpp:1502:15: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] fisx-1.3.1/src/fisx_elements.cpp:131:25: style: Variable 'bindingEnergies' is assigned a value that is never used. [unreadVariable] fisx-1.3.1/src/fisx_elements.cpp:87:17: style: Unused variable: crossSections [unusedVariable] fisx-1.3.1/src/fisx_elements.cpp:153:25: style: Unused variable: energyGrid [unusedVariable] fisx-1.3.1/src/fisx_elements.cpp:435:17: style: Unused variable: subshell [unusedVariable] fisx-1.3.1/src/fisx_elements.cpp:531:17: style: Unused variable: subshell [unusedVariable] fisx-1.3.1/src/fisx_elements.cpp:1172:17: style: Unused variable: msg [unusedVariable] fisx-1.3.1/src/fisx_elements.cpp:1335:49: style: Unused variable: matIterator [unusedVariable] fisx-1.3.1/src/fisx_elements.cpp:1516:23: style: Unused variable: msg [unusedVariable] fisx-1.3.1/src/fisx_elements.cpp:1556:59: style: Unused variable: result [unusedVariable] fisx-1.3.1/src/fisx_elements.cpp:1618:33: style: Unused variable: c_it [unusedVariable] fisx-1.3.1/src/fisx_elements.cpp:2067:65: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] fisx-1.3.1/src/fisx_epdl97.cpp:139:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_epdl97.cpp:203:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_epdl97.cpp:449:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_epdl97.h:48:43: style:inconclusive: Technically the member function 'fisx::EPDL97::getBindingEnergies' can be const. [functionConst] fisx-1.3.1/src/fisx_epdl97.cpp:347:47: note: Technically the member function 'fisx::EPDL97::getBindingEnergies' can be const. fisx-1.3.1/src/fisx_epdl97.h:48:43: note: Technically the member function 'fisx::EPDL97::getBindingEnergies' can be const. fisx-1.3.1/src/fisx_epdl97.h:58:35: style:inconclusive: Technically the member function 'fisx::EPDL97::getPhotoelectricWeights' can be const. [functionConst] fisx-1.3.1/src/fisx_epdl97.cpp:693:39: note: Technically the member function 'fisx::EPDL97::getPhotoelectricWeights' can be const. fisx-1.3.1/src/fisx_epdl97.h:58:35: note: Technically the member function 'fisx::EPDL97::getPhotoelectricWeights' can be const. fisx-1.3.1/src/fisx_epdl97.h:65:17: performance:inconclusive: Technically the member function 'fisx::EPDL97::toUpperCaseString' can be static (but you may consider moving to unnamed namespace). [functionStatic] fisx-1.3.1/src/fisx_epdl97.cpp:769:21: note: Technically the member function 'fisx::EPDL97::toUpperCaseString' can be static (but you may consider moving to unnamed namespace). fisx-1.3.1/src/fisx_epdl97.h:65:17: note: Technically the member function 'fisx::EPDL97::toUpperCaseString' can be static (but you may consider moving to unnamed namespace). fisx-1.3.1/src/fisx_epdl97.h:66:27: performance:inconclusive: Technically the member function 'fisx::EPDL97::getInterpolationIndices' can be static (but you may consider moving to unnamed namespace). [functionStatic] fisx-1.3.1/src/fisx_epdl97.cpp:778:31: note: Technically the member function 'fisx::EPDL97::getInterpolationIndices' can be static (but you may consider moving to unnamed namespace). fisx-1.3.1/src/fisx_epdl97.h:66:27: note: Technically the member function 'fisx::EPDL97::getInterpolationIndices' can be static (but you may consider moving to unnamed namespace). fisx-1.3.1/src/fisx_epdl97.cpp:123:17: style: The scope of the variable 'msg' can be reduced. [variableScope] fisx-1.3.1/src/fisx_epdl97.cpp:189:12: style: The scope of the variable 'n' can be reduced. [variableScope] fisx-1.3.1/src/fisx_epdl97.cpp:190:30: style: The scope of the variable 'tmpLabels' can be reduced. [variableScope] fisx-1.3.1/src/fisx_epdl97.cpp:194:28: style: The scope of the variable 'key' can be reduced. [variableScope] fisx-1.3.1/src/fisx_epdl97.cpp:369:34: style: The scope of the variable 'Aw' can be reduced. [variableScope] fisx-1.3.1/src/fisx_epdl97.cpp:369:38: style: The scope of the variable 'Bw' can be reduced. [variableScope] fisx-1.3.1/src/fisx_epdl97.cpp:620:17: style: The scope of the variable 'key' can be reduced. [variableScope] fisx-1.3.1/src/fisx_epdl97.cpp:50:28: performance: Function parameter 'directoryName' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_epdl97.cpp:61:43: performance: Function parameter 'directoryName' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_epdl97.cpp:74:35: performance: Function parameter 'directoryName' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_epdl97.cpp:112:46: performance: Function parameter 'fileName' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_epdl97.cpp:185:44: performance: Function parameter 'fileName' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_epdl97.cpp:195:17: style: Variable 'interestingLabels' can be declared as const array [constVariable] fisx-1.3.1/src/fisx_epdl97.cpp:702:17: style: Variable 'shellList' can be declared as const array [constVariable] fisx-1.3.1/src/fisx_epdl97.cpp:193:32: style: Unused variable: labelMap [unusedVariable] fisx-1.3.1/src/fisx_epdl97.cpp:335:45: style: Unused variable: it [unusedVariable] fisx-1.3.1/src/fisx_epdl97.cpp:336:17: style: Unused variable: tmpString [unusedVariable] fisx-1.3.1/src/fisx_layer.cpp:47:39: style:inconclusive: Function 'setDensity' argument 1 names different: declaration 'density' definition 'value'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_layer.h:123:36: note: Function 'setDensity' argument 1 names different: declaration 'density' definition 'value'. fisx-1.3.1/src/fisx_layer.cpp:47:39: note: Function 'setDensity' argument 1 names different: declaration 'density' definition 'value'. fisx-1.3.1/src/fisx_layer.cpp:56:41: style:inconclusive: Function 'setThickness' argument 1 names different: declaration 'thickness' definition 'value'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_layer.h:124:38: note: Function 'setThickness' argument 1 names different: declaration 'thickness' definition 'value'. fisx-1.3.1/src/fisx_layer.cpp:56:41: note: Function 'setThickness' argument 1 names different: declaration 'thickness' definition 'value'. fisx-1.3.1/src/fisx_layer.cpp:108:164: style:inconclusive: Function 'getMassAttenuationCoefficients' argument 1 names different: declaration 'energies' definition 'energy'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_layer.h:93:174: note: Function 'getMassAttenuationCoefficients' argument 1 names different: declaration 'energies' definition 'energy'. fisx-1.3.1/src/fisx_layer.cpp:108:164: note: Function 'getMassAttenuationCoefficients' argument 1 names different: declaration 'energies' definition 'energy'. fisx-1.3.1/src/fisx_material.cpp:119:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_material.cpp:53:17: style: The scope of the variable 'msg' can be reduced. [variableScope] fisx-1.3.1/src/fisx_material.cpp:66:17: style: Unused variable: msg [unusedVariable] fisx-1.3.1/src/fisx_math.cpp:184:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_math.cpp:215:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_math.cpp:328:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_math.cpp:406:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_math.cpp:501:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DBL_MAX [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_math.cpp:518:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_math.cpp:180:25: style: Expression 'log(1 + x)' can be replaced by 'log1p(x)' to avoid loss of precision. [unpreciseMathCall] fisx-1.3.1/src/fisx_math.cpp:181:19: style: Expression 'log(1 + x)' can be replaced by 'log1p(x)' to avoid loss of precision. [unpreciseMathCall] fisx-1.3.1/src/fisx_math.cpp:241:38: style: Expression 'log(1 + x)' can be replaced by 'log1p(x)' to avoid loss of precision. [unpreciseMathCall] fisx-1.3.1/src/fisx_math.cpp:282:23: style: Expression 'log(1 + x)' can be replaced by 'log1p(x)' to avoid loss of precision. [unpreciseMathCall] fisx-1.3.1/src/fisx_math.cpp:329:60: style: Expression 'log(1 + x)' can be replaced by 'log1p(x)' to avoid loss of precision. [unpreciseMathCall] fisx-1.3.1/src/fisx_math.cpp:553:20: style: Expression 'log(1 + x)' can be replaced by 'log1p(x)' to avoid loss of precision. [unpreciseMathCall] fisx-1.3.1/src/fisx_math.cpp:554:14: style: Expression 'log(1 + x)' can be replaced by 'log1p(x)' to avoid loss of precision. [unpreciseMathCall] fisx-1.3.1/src/fisx_math.cpp:514:12: style: The scope of the variable 'a' can be reduced. [variableScope] fisx-1.3.1/src/fisx_math.cpp:514:18: style: The scope of the variable 'delta' can be reduced. [variableScope] fisx-1.3.1/src/fisx_math.cpp:315:133: style:inconclusive: Function 'deBoerX' argument 5 names different: declaration 'mu_1_j' definition 'mu1j'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_math.h:105:182: note: Function 'deBoerX' argument 5 names different: declaration 'mu_1_j' definition 'mu1j'. fisx-1.3.1/src/fisx_math.cpp:315:133: note: Function 'deBoerX' argument 5 names different: declaration 'mu_1_j' definition 'mu1j'. fisx-1.3.1/src/fisx_math.cpp:315:154: style:inconclusive: Function 'deBoerX' argument 6 names different: declaration 'mu_2_j' definition 'mu2j'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_math.h:105:205: note: Function 'deBoerX' argument 6 names different: declaration 'mu_2_j' definition 'mu2j'. fisx-1.3.1/src/fisx_math.cpp:315:154: note: Function 'deBoerX' argument 6 names different: declaration 'mu_2_j' definition 'mu2j'. fisx-1.3.1/src/fisx_math.cpp:315:175: style:inconclusive: Function 'deBoerX' argument 7 names different: declaration 'mu_b_j_d_t' definition 'mubj_dt'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_math.h:105:259: note: Function 'deBoerX' argument 7 names different: declaration 'mu_b_j_d_t' definition 'mubj_dt'. fisx-1.3.1/src/fisx_math.cpp:315:175: note: Function 'deBoerX' argument 7 names different: declaration 'mu_b_j_d_t' definition 'mubj_dt'. fisx-1.3.1/src/fisx_math.cpp:384:133: style:inconclusive: Function 'deBoerV' argument 5 names different: declaration 'mu_1_j' definition 'mu1j'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_math.h:110:182: note: Function 'deBoerV' argument 5 names different: declaration 'mu_1_j' definition 'mu1j'. fisx-1.3.1/src/fisx_math.cpp:384:133: note: Function 'deBoerV' argument 5 names different: declaration 'mu_1_j' definition 'mu1j'. fisx-1.3.1/src/fisx_math.cpp:384:154: style:inconclusive: Function 'deBoerV' argument 6 names different: declaration 'mu_2_j' definition 'mu2j'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_math.h:110:205: note: Function 'deBoerV' argument 6 names different: declaration 'mu_2_j' definition 'mu2j'. fisx-1.3.1/src/fisx_math.cpp:384:154: note: Function 'deBoerV' argument 6 names different: declaration 'mu_2_j' definition 'mu2j'. fisx-1.3.1/src/fisx_math.cpp:384:175: style:inconclusive: Function 'deBoerV' argument 7 names different: declaration 'mu_b_j_d_t' definition 'mubjdt'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_math.h:110:259: note: Function 'deBoerV' argument 7 names different: declaration 'mu_b_j_d_t' definition 'mubjdt'. fisx-1.3.1/src/fisx_math.cpp:384:175: note: Function 'deBoerV' argument 7 names different: declaration 'mu_b_j_d_t' definition 'mubjdt'. fisx-1.3.1/src/fisx_math.cpp:59:16: style: Variable 'factorial' can be declared as const array [constVariable] fisx-1.3.1/src/fisx_math.cpp:119:12: style: Variable 'a' can be declared as const array [constVariable] fisx-1.3.1/src/fisx_math.cpp:140:12: style: Variable 'a' can be declared as const array [constVariable] fisx-1.3.1/src/fisx_math.cpp:141:12: style: Variable 'b' can be declared as const array [constVariable] fisx-1.3.1/src/fisx_multilayer.cpp:250:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_detector.h:52:10: warning: The class 'Detector' defines member function with name 'setMaterial' also defined in its parent class 'Layer'. [duplInheritedMember] fisx-1.3.1/src/fisx_layer.h:53:10: note: Parent function 'Layer::setMaterial' fisx-1.3.1/src/fisx_detector.h:52:10: note: Derived function 'Detector::setMaterial' fisx-1.3.1/src/fisx_detector.h:54:10: warning: The class 'Detector' defines member function with name 'setMaterial' also defined in its parent class 'Layer'. [duplInheritedMember] fisx-1.3.1/src/fisx_layer.h:55:10: note: Parent function 'Layer::setMaterial' fisx-1.3.1/src/fisx_detector.h:54:10: note: Derived function 'Detector::setMaterial' fisx-1.3.1/src/fisx_transmissiontable.h:59:5: style: Class 'TransmissionTable' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] fisx-1.3.1/src/fisx_xrf.h:54:5: style: Class 'XRF' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] fisx-1.3.1/src/fisx_multilayer.cpp:239:29: style: The scope of the variable 'family' can be reduced. [variableScope] fisx-1.3.1/src/fisx_multilayer.cpp:242:47: style: Local variable 'sampleLayerComposition' shadows outer variable [shadowVariable] fisx-1.3.1/src/fisx_multilayer.cpp:139:35: note: Shadowed declaration fisx-1.3.1/src/fisx_multilayer.cpp:242:47: note: Shadow variable fisx-1.3.1/src/fisx_multilayer.cpp:476:51: style: Local variable 'sampleLayerComposition' shadows outer variable [shadowVariable] fisx-1.3.1/src/fisx_multilayer.cpp:139:35: note: Shadowed declaration fisx-1.3.1/src/fisx_multilayer.cpp:476:51: note: Shadow variable fisx-1.3.1/src/fisx_multilayer.cpp:730:121: performance: Searching before insertion is not necessary. Instead of 'actualResult[elementName+" "+lineFamily][iLayer][c_it->first][tmpString]=0.0' consider using 'actualResult[elementName+" "+lineFamily][iLayer][c_it->first].try_emplace(tmpString, 0.0);'. [stlFindInsert] fisx-1.3.1/src/fisx_multilayer.cpp:886:125: performance: Searching before insertion is not necessary. Instead of 'actualResult[elementName+" "+lineFamily][iLayer][c_it->first][tmpString]=0.0' consider using 'actualResult[elementName+" "+lineFamily][iLayer][c_it->first].try_emplace(tmpString, 0.0);'. [stlFindInsert] fisx-1.3.1/src/fisx_multilayer.cpp:1024:125: performance: Searching before insertion is not necessary. Instead of 'actualResult[elementName+" "+lineFamily][iLayer][c_it->first][tmpString]=0.0' consider using 'actualResult[elementName+" "+lineFamily][iLayer][c_it->first].try_emplace(tmpString, 0.0);'. [stlFindInsert] fisx-1.3.1/src/fisx_multilayer.cpp:67:17: style: Unused variable: msg [unusedVariable] fisx-1.3.1/src/fisx_multilayer.cpp:139:35: style: Unused variable: sampleLayerComposition [unusedVariable] fisx-1.3.1/src/fisx_multilayer.cpp:243:63: style: Unused variable: mapIt [unusedVariable] fisx-1.3.1/src/fisx_multilayer.cpp:414:39: style: Unused variable: muTotalFluo [unusedVariable] fisx-1.3.1/src/fisx_multilayer.cpp:1103:73: style: Unused variable: c_it [unusedVariable] fisx-1.3.1/src/fisx_multilayer.cpp:1105:73: style: Unused variable: it2 [unusedVariable] fisx-1.3.1/src/fisx_shell.cpp:101:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_shell.cpp:233:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_shell.cpp:610:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_shell.cpp:39:8: warning: Member variable 'Shell::shellMainIndex' is not initialized in the constructor. [uninitMemberVar] fisx-1.3.1/src/fisx_shell.cpp:39:8: warning: Member variable 'Shell::subshellIndex' is not initialized in the constructor. [uninitMemberVar] fisx-1.3.1/src/fisx_shell.h:114:10: performance:inconclusive: Technically the member function 'fisx::Shell::StringToInteger' can be static (but you may consider moving to unnamed namespace). [functionStatic] fisx-1.3.1/src/fisx_shell.cpp:665:13: note: Technically the member function 'fisx::Shell::StringToInteger' can be static (but you may consider moving to unnamed namespace). fisx-1.3.1/src/fisx_shell.h:114:10: note: Technically the member function 'fisx::Shell::StringToInteger' can be static (but you may consider moving to unnamed namespace). fisx-1.3.1/src/fisx_shell.h:124:17: performance:inconclusive: Technically the member function 'fisx::Shell::toUpperCaseString' can be static (but you may consider moving to unnamed namespace). [functionStatic] fisx-1.3.1/src/fisx_shell.cpp:134:20: note: Technically the member function 'fisx::Shell::toUpperCaseString' can be static (but you may consider moving to unnamed namespace). fisx-1.3.1/src/fisx_shell.h:124:17: note: Technically the member function 'fisx::Shell::toUpperCaseString' can be static (but you may consider moving to unnamed namespace). fisx-1.3.1/src/fisx_shell.cpp:478:16: style: Variable 'totalAuger' is reassigned a value before the old one has been used. [redundantAssignment] fisx-1.3.1/src/fisx_shell.cpp:422:20: note: totalAuger is assigned fisx-1.3.1/src/fisx_shell.cpp:478:16: note: totalAuger is overwritten fisx-1.3.1/src/fisx_shell.cpp:47:9: style: The scope of the variable 'i' can be reduced. [variableScope] fisx-1.3.1/src/fisx_shell.cpp:47:12: style: The scope of the variable 'maxShellSubindex' can be reduced. [variableScope] fisx-1.3.1/src/fisx_shell.cpp:49:17: style: The scope of the variable 'msg' can be reduced. [variableScope] fisx-1.3.1/src/fisx_shell.cpp:50:17: style: The scope of the variable 'fij' can be reduced. [variableScope] fisx-1.3.1/src/fisx_shell.cpp:51:17: style: The scope of the variable 'digit' can be reduced. [variableScope] fisx-1.3.1/src/fisx_shell.cpp:195:17: style: The scope of the variable 'tmpString' can be reduced. [variableScope] fisx-1.3.1/src/fisx_shell.cpp:374:12: style: The scope of the variable 'tmpTotal' can be reduced. [variableScope] fisx-1.3.1/src/fisx_shell.cpp:380:17: style: The scope of the variable 'testString' can be reduced. [variableScope] fisx-1.3.1/src/fisx_shell.cpp:160:70: style:inconclusive: Function 'setNonradiativeTransitions' argument 1 names different: declaration 'values' definition 'inputMap'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_shell.h:76:67: note: Function 'setNonradiativeTransitions' argument 1 names different: declaration 'values' definition 'inputMap'. fisx-1.3.1/src/fisx_shell.cpp:160:70: note: Function 'setNonradiativeTransitions' argument 1 names different: declaration 'values' definition 'inputMap'. fisx-1.3.1/src/fisx_shell.cpp:183:52: style:inconclusive: Function 'setNonradiativeTransitions' argument 1 names different: declaration 'strings' definition 'c_strings'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_shell.h:77:49: note: Function 'setNonradiativeTransitions' argument 1 names different: declaration 'strings' definition 'c_strings'. fisx-1.3.1/src/fisx_shell.cpp:183:52: note: Function 'setNonradiativeTransitions' argument 1 names different: declaration 'strings' definition 'c_strings'. fisx-1.3.1/src/fisx_shell.cpp:284:49: style:inconclusive: Function 'setRadiativeTransitions' argument 1 names different: declaration 'strings' definition 'c_strings'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_shell.h:66:46: note: Function 'setRadiativeTransitions' argument 1 names different: declaration 'strings' definition 'c_strings'. fisx-1.3.1/src/fisx_shell.cpp:284:49: note: Function 'setRadiativeTransitions' argument 1 names different: declaration 'strings' definition 'c_strings'. fisx-1.3.1/src/fisx_shell.cpp:48:9: style: Local variable 'shellMainIndex' shadows outer variable [shadowVariable] fisx-1.3.1/src/fisx_shell.h:120:9: note: Shadowed declaration fisx-1.3.1/src/fisx_shell.cpp:48:9: note: Shadow variable fisx-1.3.1/src/fisx_shell.cpp:44:26: performance: Function parameter 'name' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_shell.cpp:144:65: performance: Function parameter 'labels' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_shell.cpp:144:93: performance: Function parameter 'values' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_shell.cpp:160:70: performance: Function parameter 'inputMap' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_shell.cpp:193:62: performance: Function parameter 'labels' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_shell.cpp:193:90: performance: Function parameter 'values' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_shell.cpp:261:67: performance: Function parameter 'inputMap' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_shell.cpp:51:17: style: Variable 'digit' can be declared as const array [constVariable] fisx-1.3.1/src/fisx_shell.cpp:411:53: performance: Searching before insertion is not necessary. Instead of 'this->nonradiativeTransitions[totalLabel]=total' consider using 'this->nonradiativeTransitions.try_emplace(totalLabel, total);'. [stlFindInsert] fisx-1.3.1/src/fisx_shell.cpp:345:19: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] fisx-1.3.1/src/fisx_shell.cpp:400:19: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] fisx-1.3.1/src/fisx_shell.cpp:604:19: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] fisx-1.3.1/src/fisx_simpleini.cpp:66:60: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable in [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_simpleini.h:48:39: style:inconclusive: Technically the member function 'fisx::SimpleIni::getSections' can be const. [functionConst] fisx-1.3.1/src/fisx_simpleini.cpp:233:45: note: Technically the member function 'fisx::SimpleIni::getSections' can be const. fisx-1.3.1/src/fisx_simpleini.h:48:39: note: Technically the member function 'fisx::SimpleIni::getSections' can be const. fisx-1.3.1/src/fisx_simpleini.h:43:5: style: Class 'SimpleIni' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] fisx-1.3.1/src/fisx_simpleini.cpp:201:28: style: Condition 'length<1' is always false [knownConditionTrueFalse] fisx-1.3.1/src/fisx_simpleini.cpp:198:22: note: Assignment 'p0=0', assigned value is 0 fisx-1.3.1/src/fisx_simpleini.cpp:200:24: note: length is assigned 'p1-p0' here. fisx-1.3.1/src/fisx_simpleini.cpp:201:28: note: Condition 'length<1' is always false fisx-1.3.1/src/fisx_simpleini.cpp:132:25: style: Variable 'mainKey' is reassigned a value before the old one has been used. [redundantAssignment] fisx-1.3.1/src/fisx_simpleini.cpp:106:25: note: mainKey is assigned fisx-1.3.1/src/fisx_simpleini.cpp:132:25: note: mainKey is overwritten fisx-1.3.1/src/fisx_simpleini.cpp:206:21: style: Variable 'key' is reassigned a value before the old one has been used. [redundantAssignment] fisx-1.3.1/src/fisx_simpleini.cpp:197:21: note: key is assigned fisx-1.3.1/src/fisx_simpleini.cpp:206:21: note: key is overwritten fisx-1.3.1/src/fisx_simpleini.cpp:243:17: style: The scope of the variable 'instanceString' can be reduced. [variableScope] fisx-1.3.1/src/fisx_simpleini.cpp:293:17: style: The scope of the variable 'inputKey' can be reduced. [variableScope] fisx-1.3.1/src/fisx_simpleini.cpp:294:17: style: The scope of the variable 'tmpKey' can be reduced. [variableScope] fisx-1.3.1/src/fisx_simpleini.cpp:290:88: style:inconclusive: Function 'readSection' argument 1 names different: declaration 'section' definition 'key'. [funcArgNamesDifferent] fisx-1.3.1/src/fisx_simpleini.h:63:80: note: Function 'readSection' argument 1 names different: declaration 'section' definition 'key'. fisx-1.3.1/src/fisx_simpleini.cpp:290:88: note: Function 'readSection' argument 1 names different: declaration 'section' definition 'key'. fisx-1.3.1/src/fisx_simpleini.cpp:44:34: performance: Function parameter 'fileName' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_simpleini.cpp:50:42: performance: Function parameter 'fileName' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_simplespecfile.cpp:58:60: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable in [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_simplespecfile.cpp:114:67: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable in [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_simplespecfile.cpp:211:67: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable in [valueFlowBailoutIncompleteVar] fisx-1.3.1/src/fisx_simplespecfile.h:61:9: style:inconclusive: Technically the member function 'fisx::SimpleSpecfile::getNumberOfScans' can be const. [functionConst] fisx-1.3.1/src/fisx_simplespecfile.cpp:106:21: note: Technically the member function 'fisx::SimpleSpecfile::getNumberOfScans' can be const. fisx-1.3.1/src/fisx_simplespecfile.h:61:9: note: Technically the member function 'fisx::SimpleSpecfile::getNumberOfScans' can be const. fisx-1.3.1/src/fisx_simplespecfile.cpp:46:44: performance: Function parameter 'fileName' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_simplespecfile.cpp:52:46: performance: Function parameter 'fileName' should be passed by const reference. [passedByValue] fisx-1.3.1/src/fisx_simplespecfile.cpp:272:25: warning: Either the condition 'iString