2022-06-24 15:04 ftp://ftp.de.debian.org/debian/pool/main/p/pynifti/pynifti_0.20100607.1.orig.tar.gz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j1 platform: Linux-4.19.0-18-amd64-x86_64-with-debian-10.12 python: 3.7.3 client-version: 1.3.24 compiler: g++ (Debian 8.3.0-6) 8.3.0 cppcheck: head 2.8 head-info: 11860cc (2022-06-24 13:55:04 +0200) count: 31 31 elapsed-time: 32.5 40.8 head-timing-info: Tokenizer::simplifyTokens1: 32.0259s (avg. 16.013s - 2 result(s)) Tokenizer::simplifyTokens1::ValueFlow: 31.4464s (avg. 15.7232s - 2 result(s)) Tokenizer::simplifyTokens1::createSymbolDatabase: 0.303942s (avg. 0.151971s - 2 result(s)) Tokenizer::simplifyTokens1::setValueType: 0.068876s (avg. 0.034438s - 2 result(s)) Tokenizer::createTokens: 0.062878s (avg. 0.031439s - 2 result(s)) Overall time: 64.2519s old-timing-info: Tokenizer::simplifyTokens1: 40.3584s (avg. 20.1792s - 2 result(s)) Tokenizer::simplifyTokens1::ValueFlow: 39.7633s (avg. 19.8817s - 2 result(s)) Tokenizer::simplifyTokens1::createSymbolDatabase: 0.310205s (avg. 0.155103s - 2 result(s)) Tokenizer::simplifyTokens1::setValueType: 0.070015s (avg. 0.0350075s - 2 result(s)) Other::runChecks: 0.062921s (avg. 0.0314605s - 2 result(s)) Overall time: 80.9099s head results: pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:6294:28: style: Expression is always true because 'else if' condition is opposite to previous condition at line 6292. [multiCondition] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:6292:23: note: first condition pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:6294:28: note: else if condition is opposite to first condition pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:608:23: style: Redundant condition: nim->dim[0]>=2. 'nim->dim[0]<2 || (nim->dim[0]>=2 && nim->dim[2]<1)' is equivalent to 'nim->dim[0]<2 || nim->dim[2]<1' [redundantCondition] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:615:23: style: Redundant condition: nim->dim[0]>=3. 'nim->dim[0]<3 || (nim->dim[0]>=3 && nim->dim[3]<1)' is equivalent to 'nim->dim[0]<3 || nim->dim[3]<1' [redundantCondition] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:621:23: style: Redundant condition: nim->dim[0]>=4. 'nim->dim[0]<4 || (nim->dim[0]>=4 && nim->dim[4]<1)' is equivalent to 'nim->dim[0]<4 || nim->dim[4]<1' [redundantCondition] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:627:23: style: Redundant condition: nim->dim[0]>=5. 'nim->dim[0]<5 || (nim->dim[0]>=5 && nim->dim[5]<1)' is equivalent to 'nim->dim[0]<5 || nim->dim[5]<1' [redundantCondition] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:633:23: style: Redundant condition: nim->dim[0]>=6. 'nim->dim[0]<6 || (nim->dim[0]>=6 && nim->dim[6]<1)' is equivalent to 'nim->dim[0]<6 || nim->dim[6]<1' [redundantCondition] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:639:23: style: Redundant condition: nim->dim[0]>=7. 'nim->dim[0]<7 || (nim->dim[0]>=7 && nim->dim[7]<1)' is equivalent to 'nim->dim[0]<7 || nim->dim[7]<1' [redundantCondition] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:2410:9: style: Condition 'ext' is always true [knownConditionTrueFalse] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:3890:24: style: Condition 'g_opts.debug>2' is always true [knownConditionTrueFalse] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:3888:21: note: Assuming that condition 'g_opts.debug>3' is not redundant pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:3890:24: note: Condition 'g_opts.debug>2' is always true pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:6266:23: style: Condition 'nim->dim[0]>=1' is always true [knownConditionTrueFalse] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:6251:20: note: Assuming that condition 'nim->dim[0]<=0' is not redundant pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:6266:23: note: Condition 'nim->dim[0]>=1' is always true pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:4163:7: portability: %d in format string (no. 2) requires 'int' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:5961:4: error: Common realloc mistake: 'buf' nulled but not freed upon failure [memleakOnRealloc] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:6921:10: error: Common realloc mistake: 'subv' nulled but not freed upon failure [memleakOnRealloc] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:6992:10: error: Common realloc mistake: 'subv' nulled but not freed upon failure [memleakOnRealloc] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:3571:46: style: Checking if unsigned expression '(*nim)->nvox' is less than zero. [unsignedLessThanZero] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:4447:38: style: Checking if unsigned expression 'nim->nvox' is less than zero. [unsignedLessThanZero] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:4485:13: style: Checking if unsigned expression 'ii' is less than zero. [unsignedLessThanZero] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:4808:60: style: Checking if unsigned expression 'NBL->bsize' is less than zero. [unsignedLessThanZero] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:4588:44: style:inconclusive: Function 'nifti_read_buffer' argument 2 names different: declaration 'datatptr' definition 'dataptr'. [funcArgNamesDifferent] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.h:342:45: note: Function 'nifti_read_buffer' argument 2 names different: declaration 'datatptr' definition 'dataptr'. pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:4588:44: note: Function 'nifti_read_buffer' argument 2 names different: declaration 'datatptr' definition 'dataptr'. pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:765:61: style: Parameter 'slist' can be declared as pointer to const [constParameter] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:765:74: style: Parameter 'sindex' can be declared as pointer to const [constParameter] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:6501:38: style: Parameter 'start_index' can be declared as pointer to const [constParameter] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:6502:38: style: Parameter 'region_size' can be declared as pointer to const [constParameter] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:6755:44: style: Parameter 'prods' can be declared as const array [constParameter] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:1560:43: style: Variable 'a' is assigned a value that is never used. [unreadVariable] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:2955:14: style: Variable 'errs' is assigned a value that is never used. [unreadVariable] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:2971:14: style: Variable 'errs' is assigned a value that is never used. [unreadVariable] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:4839:35: style: Variable 'ok' is assigned a value that is never used. [unreadVariable] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:6024:20: style: Variable 'slen' is assigned a value that is never used. [unreadVariable] pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:6252:11: style: Variable 'errs' is assigned a value that is never used. [unreadVariable] pynifti-0.20100607.1/3rd/nifticlibs/znzlib.c:248:9: style: Unused variable: tmpstr [unusedVariable] diff: head pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:6501:38: style: Parameter 'start_index' can be declared as pointer to const [constParameter] 2.8 pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:6501:38: style: Parameter 'start_index' can be declared with const [constParameter] head pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:6502:38: style: Parameter 'region_size' can be declared as pointer to const [constParameter] 2.8 pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:6502:38: style: Parameter 'region_size' can be declared with const [constParameter] head pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:6755:44: style: Parameter 'prods' can be declared as const array [constParameter] 2.8 pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:6755:44: style: Parameter 'prods' can be declared with const [constParameter] head pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:765:61: style: Parameter 'slist' can be declared as pointer to const [constParameter] 2.8 pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:765:61: style: Parameter 'slist' can be declared with const [constParameter] head pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:765:74: style: Parameter 'sindex' can be declared as pointer to const [constParameter] 2.8 pynifti-0.20100607.1/3rd/nifticlibs/nifti1_io.c:765:74: style: Parameter 'sindex' can be declared with const [constParameter] DONE