2021-09-20 13:35 ftp://ftp.de.debian.org/debian/pool/main/p/phalanx/phalanx_22+d051004.orig.tar.gz cppcheck-options: --library=posix --library=gnu -j2 --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -rp=temp -D__GNUC__ --platform=unix64 temp platform: Linux-5.4.0-84-generic-x86_64-with-Ubuntu-18.04-bionic python: 3.6.9 client-version: 1.3.12 compiler: g++ (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0 cppcheck: head 2.5 head-info: e388bdc4d (2021-09-20 11:54:16 +0200) count: 76 64 elapsed-time: 4.8 20.6 head-timing-info: Overall time: 0s old-timing-info: Overall time: 0s head results: Phalanx-XXII/bcreate.c:153:10: style: Condition '!found' is always true [knownConditionTrueFalse] Phalanx-XXII/bcreate.c:150:22: note: Assignment 'found=0', assigned value is 0 Phalanx-XXII/bcreate.c:153:10: note: Condition '!found' is always true Phalanx-XXII/bcreate.c:389:13: style: Local variable 'i' shadows outer variable [shadowVariable] Phalanx-XXII/bcreate.c:364:6: note: Shadowed declaration Phalanx-XXII/bcreate.c:389:13: note: Shadow variable Phalanx-XXII/bcreate.c:186:8: style: Variable 'p' is assigned a value that is never used. [unreadVariable] Phalanx-XXII/bcreate.c:187:44: style: Variable 'p' is assigned a value that is never used. [unreadVariable] Phalanx-XXII/bcreate.c:189:6: style: Variable 'p' is assigned a value that is never used. [unreadVariable] Phalanx-XXII/book.c:473:7: style: Obsolescent function 'index' called. It is recommended to use 'strchr' instead. [prohibitedindexCalled] Phalanx-XXII/book.c:474:7: style: Obsolescent function 'rindex' called. It is recommended to use 'strrchr' instead. [prohibitedrindexCalled] Phalanx-XXII/book.c:43:13: style: Local variable 'P' shadows outer variable [shadowVariable] Phalanx-XXII/phalanx.h:431:23: note: Shadowed declaration Phalanx-XXII/book.c:43:13: note: Shadow variable Phalanx-XXII/book.c:418:11: style: Local variable 'm' shadows outer argument [shadowArgument] Phalanx-XXII/book.c:391:17: note: Shadowed declaration Phalanx-XXII/book.c:418:11: note: Shadow variable Phalanx-XXII/book.c:419:31: style: Local variable 'n' shadows outer argument [shadowArgument] Phalanx-XXII/book.c:391:24: note: Shadowed declaration Phalanx-XXII/book.c:419:31: note: Shadow variable Phalanx-XXII/data.c:43:25: portability: Undefined behaviour, pointer arithmetic 'Th_-20' is out of bounds. [pointerOutOfBounds] Phalanx-XXII/data.c:55:25: portability: Undefined behaviour, pointer arithmetic 'Tv_-20' is out of bounds. [pointerOutOfBounds] Phalanx-XXII/data.c:78:16: portability: Undefined behaviour, pointer arithmetic 'HS_-20' is out of bounds. [pointerOutOfBounds] Phalanx-XXII/endgame.c:116:32: portability: Undefined behaviour, pointer arithmetic 'kbonus_-20' is out of bounds. [pointerOutOfBounds] Phalanx-XXII/endgame.c:299:18: portability: Undefined behaviour, pointer arithmetic 'nb_-20' is out of bounds. [pointerOutOfBounds] Phalanx-XXII/endgame.c:106:12: style: Variable 'kbonus_' can be declared with const [constVariable] Phalanx-XXII/endgame.c:359:30: style: Variable 'wk' is assigned a value that is never used. [unreadVariable] Phalanx-XXII/evaluate.c:310:43: style: Condition 'G[Counter].mtrl<400' is always true [knownConditionTrueFalse] Phalanx-XXII/evaluate.c:310:20: note: Assuming that condition 'G[Counter].mtrl<400' is not redundant Phalanx-XXII/evaluate.c:310:43: note: Condition 'G[Counter].mtrl<400' is always true Phalanx-XXII/evaluate.c:310:25: style: Same expression on both sides of '&&'. [duplicateExpression] Phalanx-XXII/evaluate.c:250:6: style: Local variable 't' shadows outer variable [shadowVariable] Phalanx-XXII/evaluate.c:236:13: note: Shadowed declaration Phalanx-XXII/evaluate.c:250:6: note: Shadow variable Phalanx-XXII/evaluate.c:438:9: style: Local variable 'm' shadows outer variable [shadowVariable] Phalanx-XXII/evaluate.c:235:7: note: Shadowed declaration Phalanx-XXII/evaluate.c:438:9: note: Shadow variable Phalanx-XXII/evaluate.c:438:21: style: Local variable 'n' shadows outer variable [shadowVariable] Phalanx-XXII/evaluate.c:235:19: note: Shadowed declaration Phalanx-XXII/evaluate.c:438:21: note: Shadow variable Phalanx-XXII/evaluate.c:739:10: style: Local variable 't' shadows outer variable [shadowVariable] Phalanx-XXII/evaluate.c:236:13: note: Shadowed declaration Phalanx-XXII/evaluate.c:739:10: note: Shadow variable Phalanx-XXII/genmoves.c:544:8: style: Array index 'destination' is used before limits check. [arrayIndexThenCheck] Phalanx-XXII/genmoves.c:639:8: style: Array index 'destination' is used before limits check. [arrayIndexThenCheck] Phalanx-XXII/genmoves.c:163:8: style: Local variable 'square' shadows outer variable [shadowVariable] Phalanx-XXII/genmoves.c:267:5: note: Shadowed declaration Phalanx-XXII/genmoves.c:163:8: note: Shadow variable Phalanx-XXII/genmoves.c:176:6: style: Local variable 'destination' shadows outer variable [shadowVariable] Phalanx-XXII/genmoves.c:267:13: note: Shadowed declaration Phalanx-XXII/genmoves.c:176:6: note: Shadow variable Phalanx-XXII/genmoves.c:227:7: style: Local variable 'square' shadows outer variable [shadowVariable] Phalanx-XXII/genmoves.c:267:5: note: Shadowed declaration Phalanx-XXII/genmoves.c:227:7: note: Shadow variable Phalanx-XXII/genmoves.c:237:6: style: Local variable 'destination' shadows outer variable [shadowVariable] Phalanx-XXII/genmoves.c:267:13: note: Shadowed declaration Phalanx-XXII/genmoves.c:237:6: note: Shadow variable Phalanx-XXII/io.c:1080:15: debug: Wrong data detected by condition !tok->next()->astOperand1() [DacaWrongData] Phalanx-XXII/io.c:1484:23: warning: Logical disjunction always evaluates to true: Abort != 0 || Abort != 4. [incorrectLogicOperator] Phalanx-XXII/io.c:881:2: warning: %i in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] Phalanx-XXII/io.c:917:2: warning: %i in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] Phalanx-XXII/io.c:565:8: style: Local variable 't' shadows outer variable [shadowVariable] Phalanx-XXII/io.c:520:6: note: Shadowed declaration Phalanx-XXII/io.c:565:8: note: Shadow variable Phalanx-XXII/io.c:316:15: style: Variable 'ok' can be declared with const [constVariable] Phalanx-XXII/io.c:317:15: style: Variable 'up' can be declared with const [constVariable] Phalanx-XXII/learn.c:39:25: style: Variable 'bdepth' is assigned a value that is never used. [unreadVariable] Phalanx-XXII/moving.c:102:36: portability: Undefined behaviour, pointer arithmetic 'cb_-20' is out of bounds. [pointerOutOfBounds] Phalanx-XXII/moving.c:92:23: style: Variable 'cb_' can be declared with const [constVariable] Phalanx-XXII/moving.c:102:28: style: Variable 'cb' can be declared with const [constVariable] Phalanx-XXII/phalanx.c:272:15: debug: Wrong data detected by condition !tok->next()->astOperand1() [DacaWrongData] Phalanx-XXII/phalanx.c:275:15: debug: Wrong data detected by condition !tok->next()->astOperand1() [DacaWrongData] Phalanx-XXII/phalanx.c:148:7: warning: %i in format string (no. 1) requires 'int *' but the argument type is 'unsigned int *'. [invalidScanfArgType_int] Phalanx-XXII/phalanx.c:151:7: warning: %i in format string (no. 1) requires 'int *' but the argument type is 'unsigned int *'. [invalidScanfArgType_int] Phalanx-XXII/phalanx.c:423:1: warning: %i in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] Phalanx-XXII/phalanx.c:160:14: style: Local variable 't' shadows outer variable [shadowVariable] Phalanx-XXII/phalanx.c:48:9: note: Shadowed declaration Phalanx-XXII/phalanx.c:160:14: note: Shadow variable Phalanx-XXII/static.c:43:36: portability: Undefined behaviour, pointer arithmetic 'sqcolor_-20' is out of bounds. [pointerOutOfBounds] Phalanx-XXII/static.c:56:28: portability: Undefined behaviour, pointer arithmetic 'pmpb_-20' is out of bounds. [pointerOutOfBounds] Phalanx-XXII/static.c:69:42: portability: Undefined behaviour, pointer arithmetic 'qstormtable_-20' is out of bounds. [pointerOutOfBounds] Phalanx-XXII/static.c:82:42: portability: Undefined behaviour, pointer arithmetic 'kstormtable_-20' is out of bounds. [pointerOutOfBounds] Phalanx-XXII/static.c:95:28: portability: Undefined behaviour, pointer arithmetic 'nmpb_-20' is out of bounds. [pointerOutOfBounds] Phalanx-XXII/static.c:108:28: portability: Undefined behaviour, pointer arithmetic 'bmpb_-20' is out of bounds. [pointerOutOfBounds] Phalanx-XXII/static.c:121:28: portability: Undefined behaviour, pointer arithmetic 'bepb_-20' is out of bounds. [pointerOutOfBounds] Phalanx-XXII/static.c:134:28: portability: Undefined behaviour, pointer arithmetic 'rmpb_-20' is out of bounds. [pointerOutOfBounds] Phalanx-XXII/static.c:147:28: portability: Undefined behaviour, pointer arithmetic 'qmpb_-20' is out of bounds. [pointerOutOfBounds] Phalanx-XXII/static.c:160:28: portability: Undefined behaviour, pointer arithmetic 'kmpb_-20' is out of bounds. [pointerOutOfBounds] Phalanx-XXII/static.c:173:28: portability: Undefined behaviour, pointer arithmetic 'kepb_-20' is out of bounds. [pointerOutOfBounds] Phalanx-XXII/static.c:186:27: portability: Undefined behaviour, pointer arithmetic 'c_bonus_-20' is out of bounds. [pointerOutOfBounds] Phalanx-XXII/static.c:198:33: portability: Undefined behaviour, pointer arithmetic 'outpost_-20' is out of bounds. [pointerOutOfBounds] Phalanx-XXII/static.c:412:24: style: Array index 'd' is used before limits check. [arrayIndexThenCheck] Phalanx-XXII/static.c:494:24: style: Array index 'd' is used before limits check. [arrayIndexThenCheck] Phalanx-XXII/static.c:650:13: style: Condition 'defs==0' is always false [knownConditionTrueFalse] Phalanx-XXII/static.c:646:6: note: Assuming that condition 'ataks' is not redundant Phalanx-XXII/static.c:645:13: note: ataks is assigned '(P[d]>>5)&0x7' here. Phalanx-XXII/static.c:648:25: note: Assignment 'defs=(P[d]>>5)&0x7', assigned value is symbolic=ataks Phalanx-XXII/static.c:650:13: note: Condition 'defs==0' is always false Phalanx-XXII/static.c:653:14: style: Condition 'ataks>1' is always false [knownConditionTrueFalse] Phalanx-XXII/static.c:650:13: note: Assuming that condition 'defs==0' is not redundant Phalanx-XXII/static.c:648:13: note: defs is assigned '(P[d]>>5)&0x7' here. Phalanx-XXII/static.c:645:13: note: ataks is assigned '(P[d]>>5)&0x7' here. Phalanx-XXII/static.c:653:14: note: Condition 'ataks>1' is always false Phalanx-XXII/static.c:313:8: style: Local variable 'i' shadows outer variable [shadowVariable] Phalanx-XXII/static.c:214:5: note: Shadowed declaration Phalanx-XXII/static.c:313:8: note: Shadow variable Phalanx-XXII/static.c:887:9: style: Local variable 'j' shadows outer variable [shadowVariable] Phalanx-XXII/static.c:728:6: note: Shadowed declaration Phalanx-XXII/static.c:887:9: note: Shadow variable Phalanx-XXII/static.c:1003:9: style: Local variable 'j' shadows outer variable [shadowVariable] Phalanx-XXII/static.c:728:6: note: Shadowed declaration Phalanx-XXII/static.c:1003:9: note: Shadow variable Phalanx-XXII/static.c:1206:7: style: Local variable 'j' shadows outer variable [shadowVariable] Phalanx-XXII/static.c:728:6: note: Shadowed declaration Phalanx-XXII/static.c:1206:7: note: Shadow variable Phalanx-XXII/static.c:1239:8: style: Local variable 'b' shadows outer variable [shadowVariable] Phalanx-XXII/static.c:269:10: note: Shadowed declaration Phalanx-XXII/static.c:1239:8: note: Shadow variable Phalanx-XXII/static.c:1271:8: style: Local variable 'j' shadows outer variable [shadowVariable] Phalanx-XXII/static.c:728:6: note: Shadowed declaration Phalanx-XXII/static.c:1271:8: note: Shadow variable Phalanx-XXII/static.c:1327:8: style: Local variable 'j' shadows outer variable [shadowVariable] Phalanx-XXII/static.c:728:6: note: Shadowed declaration Phalanx-XXII/static.c:1327:8: note: Shadow variable Phalanx-XXII/static.c:548:18: style: Variable 'm' can be declared with const [constVariable] Phalanx-XXII/static.c:1209:14: style: Variable 'frb' can be declared with const [constVariable] Phalanx-XXII/static.c:1237:15: style: Variable 'bon' can be declared with const [constVariable] Phalanx-XXII/static.c:1312:15: style: Variable 'bon' can be declared with const [constVariable] Phalanx-XXII/static.c:1390:15: style: Variable 'bon' can be declared with const [constVariable] Phalanx-XXII/static.c:1422:15: style: Variable 'bon' can be declared with const [constVariable] diff: head Phalanx-XXII/endgame.c:106:12: style: Variable 'kbonus_' can be declared with const [constVariable] head Phalanx-XXII/evaluate.c:310:43: style: Condition 'G[Counter].mtrl<400' is always true [knownConditionTrueFalse] Phalanx-XXII/evaluate.c:310:20: note: Assuming that condition 'G[Counter].mtrl<400' is not redundant Phalanx-XXII/evaluate.c:310:43: note: Condition 'G[Counter].mtrl<400' is always true 2.5 Phalanx-XXII/evaluate.c:781:7: style: Condition '!target' is always true [knownConditionTrueFalse] Phalanx-XXII/evaluate.c:771:14: note: Assignment 'target=0', assigned value is 0 Phalanx-XXII/evaluate.c:774:34: note: Assuming condition is false Phalanx-XXII/evaluate.c:781:7: note: Condition '!target' is always true head Phalanx-XXII/io.c:316:15: style: Variable 'ok' can be declared with const [constVariable] head Phalanx-XXII/io.c:317:15: style: Variable 'up' can be declared with const [constVariable] head Phalanx-XXII/moving.c:102:28: style: Variable 'cb' can be declared with const [constVariable] head Phalanx-XXII/moving.c:92:23: style: Variable 'cb_' can be declared with const [constVariable] 2.5 Phalanx-XXII/static.c:1032:10: style: Condition 'b[sq+10]' is always true [knownConditionTrueFalse] Phalanx-XXII/static.c:1026:21: note: Assuming condition 'b[sq+10]!=0' is true Phalanx-XXII/static.c:1032:10: note: Condition 'b[sq+10]' is always true head Phalanx-XXII/static.c:1209:14: style: Variable 'frb' can be declared with const [constVariable] head Phalanx-XXII/static.c:1237:15: style: Variable 'bon' can be declared with const [constVariable] head Phalanx-XXII/static.c:1312:15: style: Variable 'bon' can be declared with const [constVariable] head Phalanx-XXII/static.c:1390:15: style: Variable 'bon' can be declared with const [constVariable] head Phalanx-XXII/static.c:1422:15: style: Variable 'bon' can be declared with const [constVariable] head Phalanx-XXII/static.c:548:18: style: Variable 'm' can be declared with const [constVariable] head Phalanx-XXII/static.c:650:13: style: Condition 'defs==0' is always false [knownConditionTrueFalse] Phalanx-XXII/static.c:646:6: note: Assuming that condition 'ataks' is not redundant Phalanx-XXII/static.c:645:13: note: ataks is assigned '(P[d]>>5)&0x7' here. Phalanx-XXII/static.c:648:25: note: Assignment 'defs=(P[d]>>5)&0x7', assigned value is symbolic=ataks Phalanx-XXII/static.c:650:13: note: Condition 'defs==0' is always false head Phalanx-XXII/static.c:653:14: style: Condition 'ataks>1' is always false [knownConditionTrueFalse] Phalanx-XXII/static.c:650:13: note: Assuming that condition 'defs==0' is not redundant Phalanx-XXII/static.c:648:13: note: defs is assigned '(P[d]>>5)&0x7' here. Phalanx-XXII/static.c:645:13: note: ataks is assigned '(P[d]>>5)&0x7' here. Phalanx-XXII/static.c:653:14: note: Condition 'ataks>1' is always false DONE