2021-10-18 08:31 ftp://ftp.de.debian.org/debian/pool/main/p/pcb/pcb_20140316.orig.tar.gz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp platform: Linux-5.10.0-9-amd64-x86_64-with-glibc2.31 python: 3.9.2 client-version: 1.3.15 compiler: g++ (Debian 10.2.1-6) 10.2.1 20210110 cppcheck: head 2.6 head-info: c49d24630 (2021-10-18 07:25:31 +0200) count: 879 879 elapsed-time: 45.2 44.1 head-timing-info: Overall time: 0s old-timing-info: Overall time: 0s head results: pcb-20140316/gts/bbtree.c:895:13: style: Local variable 'min' shadows outer variable [shadowVariable] pcb-20140316/gts/bbtree.c:883:11: note: Shadowed declaration pcb-20140316/gts/bbtree.c:895:13: note: Shadow variable pcb-20140316/gts/cdt.c:1048:57: style: Parameter 'data' can be declared with const [constParameter] pcb-20140316/gts/curvature.c:408:15: style: Local variable 'e' shadows outer variable [shadowVariable] pcb-20140316/gts/curvature.c:351:7: note: Shadowed declaration pcb-20140316/gts/curvature.c:408:15: note: Shadow variable pcb-20140316/gts/curvature.c:336:49: style: Parameter 'Kh' can be declared with const [constParameter] pcb-20140316/gts/edge.c:412:18: style: Parameter 'e1' can be declared with const [constParameter] pcb-20140316/gts/boolean.c:888:5: style: Redundant initialization for 'i'. The initialized value is overwritten before it is read. [redundantInitialization] pcb-20140316/gts/boolean.c:885:14: note: i is initialized pcb-20140316/gts/boolean.c:888:5: note: i is overwritten pcb-20140316/gts/boolean.c:1804:14: style: Local variable 'data' shadows outer variable [shadowVariable] pcb-20140316/gts/boolean.c:1786:12: note: Shadowed declaration pcb-20140316/gts/boolean.c:1804:14: note: Shadow variable pcb-20140316/gts/boolean.c:1671:57: style: Parameter 'data' can be declared with const [constParameter] pcb-20140316/gts/boolean.c:1734:52: style: Parameter 'data' can be declared with const [constParameter] pcb-20140316/gts/boolean.c:1945:22: style: Parameter 'd' can be declared with const [constParameter] pcb-20140316/gts/boolean.c:306:11: style: Variable 'ev2' is assigned a value that is never used. [unreadVariable] pcb-20140316/gts/boolean.c:1711:19: style: Variable 'o2' is assigned a value that is never used. [unreadVariable] pcb-20140316/gts/face.c:111:65: style: Parameter 's' can be declared with const [constParameter] pcb-20140316/gts/hsurface.c:363:19: style: Local variable 'hs' shadows outer variable [shadowVariable] pcb-20140316/gts/hsurface.c:348:15: note: Shadowed declaration pcb-20140316/gts/hsurface.c:363:19: note: Shadow variable pcb-20140316/gts/hsurface.c:372:19: style: Local variable 'hs' shadows outer variable [shadowVariable] pcb-20140316/gts/hsurface.c:348:15: note: Shadowed declaration pcb-20140316/gts/hsurface.c:372:19: note: Shadow variable pcb-20140316/gts/graph.c:495:11: style: Condition 'n2' is always true [knownConditionTrueFalse] pcb-20140316/gts/graph.c:498:11: style: Condition 'n1' is always true [knownConditionTrueFalse] pcb-20140316/gts/graph.c:670:19: style:inconclusive: Function 'gts_pgedge_new' argument 2 names different: declaration 'n1' definition 'g1'. [funcArgNamesDifferent] pcb-20140316/gts/gts.h:2302:20: note: Function 'gts_pgedge_new' argument 2 names different: declaration 'n1' definition 'g1'. pcb-20140316/gts/graph.c:670:19: note: Function 'gts_pgedge_new' argument 2 names different: declaration 'n1' definition 'g1'. pcb-20140316/gts/graph.c:671:19: style:inconclusive: Function 'gts_pgedge_new' argument 3 names different: declaration 'n2' definition 'g2'. [funcArgNamesDifferent] pcb-20140316/gts/gts.h:2303:20: note: Function 'gts_pgedge_new' argument 3 names different: declaration 'n2' definition 'g2'. pcb-20140316/gts/graph.c:671:19: note: Function 'gts_pgedge_new' argument 3 names different: declaration 'n2' definition 'g2'. pcb-20140316/gts/graph.c:735:19: style:inconclusive: Function 'gts_wgedge_new' argument 2 names different: declaration 'n1' definition 'g1'. [funcArgNamesDifferent] pcb-20140316/gts/gts.h:2332:20: note: Function 'gts_wgedge_new' argument 2 names different: declaration 'n1' definition 'g1'. pcb-20140316/gts/graph.c:735:19: note: Function 'gts_wgedge_new' argument 2 names different: declaration 'n1' definition 'g1'. pcb-20140316/gts/graph.c:736:19: style:inconclusive: Function 'gts_wgedge_new' argument 3 names different: declaration 'n2' definition 'g2'. [funcArgNamesDifferent] pcb-20140316/gts/gts.h:2333:20: note: Function 'gts_wgedge_new' argument 3 names different: declaration 'n2' definition 'g2'. pcb-20140316/gts/graph.c:736:19: note: Function 'gts_wgedge_new' argument 3 names different: declaration 'n2' definition 'g2'. pcb-20140316/gts/graph.c:486:70: style: Parameter 'c' can be declared with const [constParameter] pcb-20140316/gts/graph.c:507:70: style: Parameter 'c' can be declared with const [constParameter] pcb-20140316/gts/graph.c:862:54: style: Parameter 'data' can be declared with const [constParameter] pcb-20140316/gts/graph.c:946:53: style: Parameter 'data' can be declared with const [constParameter] pcb-20140316/gts/graph.c:1143:54: style: Parameter 'data' can be declared with const [constParameter] pcb-20140316/gts/graph.c:1178:60: style: Parameter 'data' can be declared with const [constParameter] pcb-20140316/gts/graph.c:1298:54: style: Parameter 'data' can be declared with const [constParameter] pcb-20140316/gts/graph.c:1499:57: style: Parameter 'data' can be declared with const [constParameter] pcb-20140316/gts/gts.h:270:20: style: Local variable 'c' shadows outer variable [shadowVariable] pcb-20140316/gts/iso.c:35:14: note: Shadowed declaration pcb-20140316/gts/gts.h:270:20: note: Shadow variable pcb-20140316/gts/gts.h:294:20: style: Local variable 'c' shadows outer variable [shadowVariable] pcb-20140316/gts/iso.c:35:14: note: Shadowed declaration pcb-20140316/gts/gts.h:294:20: note: Shadow variable pcb-20140316/gts/kdtree.c:111:36: style:inconclusive: Function 'gts_kdtree_range' argument 1 names different: declaration 'tree' definition 'tree_3d'. [funcArgNamesDifferent] pcb-20140316/gts/gts.h:842:63: note: Function 'gts_kdtree_range' argument 1 names different: declaration 'tree' definition 'tree_3d'. pcb-20140316/gts/kdtree.c:111:36: note: Function 'gts_kdtree_range' argument 1 names different: declaration 'tree' definition 'tree_3d'. pcb-20140316/gts/matrix.c:502:17: style: Parameter 'c' can be declared with const [constParameter] pcb-20140316/gts/oocs.c:270:18: style: Parameter 'n' can be declared with const [constParameter] pcb-20140316/gts/pgraph.c:111:52: style: Parameter 'data' can be declared with const [constParameter] pcb-20140316/gts/pgraph.c:195:52: style: Parameter 'data' can be declared with const [constParameter] pcb-20140316/gts/pgraph.c:323:54: style: Parameter 'data' can be declared with const [constParameter] pcb-20140316/gts/partition.c:555:11: style: The if condition is the same as the previous if condition [duplicateCondition] pcb-20140316/gts/partition.c:553:11: note: First condition pcb-20140316/gts/partition.c:555:11: note: Second condition pcb-20140316/gts/partition.c:653:11: style: The if condition is the same as the previous if condition [duplicateCondition] pcb-20140316/gts/partition.c:651:11: note: First condition pcb-20140316/gts/partition.c:653:11: note: Second condition pcb-20140316/gts/partition.c:318:18: style: Local variable 'g1' shadows outer variable [shadowVariable] pcb-20140316/gts/partition.c:279:14: note: Shadowed declaration pcb-20140316/gts/partition.c:318:18: note: Shadow variable pcb-20140316/gts/partition.c:319:18: style: Local variable 'seed' shadows outer variable [shadowVariable] pcb-20140316/gts/partition.c:276:14: note: Shadowed declaration pcb-20140316/gts/partition.c:319:18: note: Shadow variable pcb-20140316/gts/partition.c:331:13: style: Local variable 'g1' shadows outer variable [shadowVariable] pcb-20140316/gts/partition.c:279:14: note: Shadowed declaration pcb-20140316/gts/partition.c:331:13: note: Shadow variable pcb-20140316/gts/partition.c:332:13: style: Local variable 'seed' shadows outer variable [shadowVariable] pcb-20140316/gts/partition.c:276:14: note: Shadowed declaration pcb-20140316/gts/partition.c:332:13: note: Shadow variable pcb-20140316/gts/partition.c:760:16: style: Local variable 'i' shadows outer variable [shadowVariable] pcb-20140316/gts/partition.c:725:17: note: Shadowed declaration pcb-20140316/gts/partition.c:760:16: note: Shadow variable pcb-20140316/gts/partition.c:806:16: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-20140316/gts/partition.c:724:14: note: Shadowed declaration pcb-20140316/gts/partition.c:806:16: note: Shadow variable pcb-20140316/gts/partition.c:977:16: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-20140316/gts/partition.c:889:14: note: Shadowed declaration pcb-20140316/gts/partition.c:977:16: note: Shadow variable pcb-20140316/gts/partition.c:161:60: style: Parameter 'data' can be declared with const [constParameter] pcb-20140316/gts/partition.c:224:51: style: Parameter 'data' can be declared with const [constParameter] pcb-20140316/gts/partition.c:351:52: style: Parameter 'data' can be declared with const [constParameter] pcb-20140316/gts/partition.c:431:48: style: Parameter 'data' can be declared with const [constParameter] pcb-20140316/gts/stripe.c:682:35: warning: Either the condition 'v1' is redundant or there is possible null pointer dereference: v1. [nullPointerRedundantCheck] pcb-20140316/gts/stripe.c:690:13: note: Assuming that condition 'v1' is not redundant pcb-20140316/gts/stripe.c:682:35: note: Null pointer dereference pcb-20140316/gts/stripe.c:682:40: warning: Either the condition 'v2' is redundant or there is possible null pointer dereference: v2. [nullPointerRedundantCheck] pcb-20140316/gts/stripe.c:690:19: note: Assuming that condition 'v2' is not redundant pcb-20140316/gts/stripe.c:682:40: note: Null pointer dereference pcb-20140316/gts/stripe.c:682:45: warning: Either the condition 'v3' is redundant or there is possible null pointer dereference: v3. [nullPointerRedundantCheck] pcb-20140316/gts/stripe.c:690:25: note: Assuming that condition 'v3' is not redundant pcb-20140316/gts/stripe.c:682:45: note: Null pointer dereference pcb-20140316/gts/stripe.c:683:35: warning: Either the condition 'v4' is redundant or there is possible null pointer dereference: v4. [nullPointerRedundantCheck] pcb-20140316/gts/stripe.c:691:13: note: Assuming that condition 'v4' is not redundant pcb-20140316/gts/stripe.c:683:35: note: Null pointer dereference pcb-20140316/gts/stripe.c:683:40: warning: Either the condition 'v5' is redundant or there is possible null pointer dereference: v5. [nullPointerRedundantCheck] pcb-20140316/gts/stripe.c:691:19: note: Assuming that condition 'v5' is not redundant pcb-20140316/gts/stripe.c:683:40: note: Null pointer dereference pcb-20140316/gts/stripe.c:683:45: warning: Either the condition 'v6' is redundant or there is possible null pointer dereference: v6. [nullPointerRedundantCheck] pcb-20140316/gts/stripe.c:691:25: note: Assuming that condition 'v6' is not redundant pcb-20140316/gts/stripe.c:683:45: note: Null pointer dereference pcb-20140316/gts/stripe.c:684:35: warning: Either the condition 'v1' is redundant or there is possible null pointer dereference: v1. [nullPointerRedundantCheck] pcb-20140316/gts/stripe.c:690:13: note: Assuming that condition 'v1' is not redundant pcb-20140316/gts/stripe.c:684:35: note: Null pointer dereference pcb-20140316/gts/stripe.c:684:40: warning: Either the condition 'v2' is redundant or there is possible null pointer dereference: v2. [nullPointerRedundantCheck] pcb-20140316/gts/stripe.c:690:19: note: Assuming that condition 'v2' is not redundant pcb-20140316/gts/stripe.c:684:40: note: Null pointer dereference pcb-20140316/gts/stripe.c:684:45: warning: Either the condition 'v3' is redundant or there is possible null pointer dereference: v3. [nullPointerRedundantCheck] pcb-20140316/gts/stripe.c:690:25: note: Assuming that condition 'v3' is not redundant pcb-20140316/gts/stripe.c:684:45: note: Null pointer dereference pcb-20140316/gts/stripe.c:684:50: warning: Either the condition 'v4' is redundant or there is possible null pointer dereference: v4. [nullPointerRedundantCheck] pcb-20140316/gts/stripe.c:691:13: note: Assuming that condition 'v4' is not redundant pcb-20140316/gts/stripe.c:684:50: note: Null pointer dereference pcb-20140316/gts/stripe.c:684:55: warning: Either the condition 'v5' is redundant or there is possible null pointer dereference: v5. [nullPointerRedundantCheck] pcb-20140316/gts/stripe.c:691:19: note: Assuming that condition 'v5' is not redundant pcb-20140316/gts/stripe.c:684:55: note: Null pointer dereference pcb-20140316/gts/stripe.c:684:60: warning: Either the condition 'v6' is redundant or there is possible null pointer dereference: v6. [nullPointerRedundantCheck] pcb-20140316/gts/stripe.c:691:25: note: Assuming that condition 'v6' is not redundant pcb-20140316/gts/stripe.c:684:60: note: Null pointer dereference pcb-20140316/gts/stripe.c:686:28: warning: Either the condition 'v1' is redundant or there is possible null pointer dereference: v1. [nullPointerRedundantCheck] pcb-20140316/gts/stripe.c:690:13: note: Assuming that condition 'v1' is not redundant pcb-20140316/gts/stripe.c:686:28: note: Null pointer dereference pcb-20140316/gts/stripe.c:686:33: warning: Either the condition 'v2' is redundant or there is possible null pointer dereference: v2. [nullPointerRedundantCheck] pcb-20140316/gts/stripe.c:690:19: note: Assuming that condition 'v2' is not redundant pcb-20140316/gts/stripe.c:686:33: note: Null pointer dereference pcb-20140316/gts/stripe.c:686:38: warning: Either the condition 'v3' is redundant or there is possible null pointer dereference: v3. [nullPointerRedundantCheck] pcb-20140316/gts/stripe.c:690:25: note: Assuming that condition 'v3' is not redundant pcb-20140316/gts/stripe.c:686:38: note: Null pointer dereference pcb-20140316/gts/stripe.c:686:43: warning: Either the condition 'v4' is redundant or there is possible null pointer dereference: v4. [nullPointerRedundantCheck] pcb-20140316/gts/stripe.c:691:13: note: Assuming that condition 'v4' is not redundant pcb-20140316/gts/stripe.c:686:43: note: Null pointer dereference pcb-20140316/gts/stripe.c:686:48: warning: Either the condition 'v5' is redundant or there is possible null pointer dereference: v5. [nullPointerRedundantCheck] pcb-20140316/gts/stripe.c:691:19: note: Assuming that condition 'v5' is not redundant pcb-20140316/gts/stripe.c:686:48: note: Null pointer dereference pcb-20140316/gts/stripe.c:686:53: warning: Either the condition 'v6' is redundant or there is possible null pointer dereference: v6. [nullPointerRedundantCheck] pcb-20140316/gts/stripe.c:691:25: note: Assuming that condition 'v6' is not redundant pcb-20140316/gts/stripe.c:686:53: note: Null pointer dereference pcb-20140316/gts/stripe.c:688:18: warning: Either the condition 'v3' is redundant or there is possible null pointer dereference: v3. [nullPointerRedundantCheck] pcb-20140316/gts/stripe.c:690:25: note: Assuming that condition 'v3' is not redundant pcb-20140316/gts/stripe.c:688:18: note: Null pointer dereference pcb-20140316/gts/stripe.c:60:50: style: Parameter 'v1' can be declared with const [constParameter] pcb-20140316/gts/stripe.c:61:22: style: Parameter 'v2' can be declared with const [constParameter] pcb-20140316/gts/stripe.c:62:22: style: Parameter 'v3' can be declared with const [constParameter] pcb-20140316/gts/stripe.c:68:47: style: Parameter 'v' can be declared with const [constParameter] pcb-20140316/gts/stripe.c:69:19: style: Parameter 'v1' can be declared with const [constParameter] pcb-20140316/gts/stripe.c:70:19: style: Parameter 'v2' can be declared with const [constParameter] pcb-20140316/gts/stripe.c:71:19: style: Parameter 'v3' can be declared with const [constParameter] pcb-20140316/gts/stripe.c:100:45: style: Parameter 'v1' can be declared with const [constParameter] pcb-20140316/gts/stripe.c:101:17: style: Parameter 'v2' can be declared with const [constParameter] pcb-20140316/gts/stripe.c:102:17: style: Parameter 'v3' can be declared with const [constParameter] pcb-20140316/gts/stripe.c:384:10: style: struct member 'min_key_t::min_key' is never used. [unusedStructMember] pcb-20140316/gts/split.c:1403:17: warning: Opposite inner 'if' condition leads to a dead code block. [oppositeInnerCondition] pcb-20140316/gts/split.c:1402:15: note: outer condition: f->type==GTS_STRING pcb-20140316/gts/split.c:1403:17: note: opposite inner condition: f->type!=GTS_STRING pcb-20140316/gts/split.c:832:14: style: Local variable 'j' shadows outer variable [shadowVariable] pcb-20140316/gts/split.c:800:9: note: Shadowed declaration pcb-20140316/gts/split.c:832:14: note: Shadow variable pcb-20140316/gts/split.c:194:16: style: Parameter 'e' can be declared with const [constParameter] pcb-20140316/gts/split.c:195:18: style: Parameter 'v1' can be declared with const [constParameter] pcb-20140316/gts/split.c:196:18: style: Parameter 'v2' can be declared with const [constParameter] pcb-20140316/gts/split.c:295:35: style: Parameter 'vs' can be declared with const [constParameter] pcb-20140316/gts/split.c:326:44: style: Parameter 'e' can be declared with const [constParameter] pcb-20140316/gts/triangle.c:551:7: warning: Possible null pointer dereference: (struct _GtsSegment*)(ee1) [nullPointer] pcb-20140316/gts/triangle.c:549:0: note: Assignment 'ee1=NULL', assigned value is 0 pcb-20140316/gts/triangle.c:551:7: note: Null pointer dereference pcb-20140316/gts/triangle.c:551:32: warning: Possible null pointer dereference: (struct _GtsSegment*)(ee2) [nullPointer] pcb-20140316/gts/triangle.c:549:17: note: Assignment 'ee2=NULL', assigned value is 0 pcb-20140316/gts/triangle.c:551:32: note: Null pointer dereference pcb-20140316/gts/triangle.c:197:68: style: Parameter 'v' can be declared with const [constParameter] pcb-20140316/gts/triangle.c:261:22: style: Parameter 'e' can be declared with const [constParameter] pcb-20140316/gts/triangle.c:746:21: style: Parameter 'e2' can be declared with const [constParameter] pcb-20140316/gts/triangle.c:747:21: style: Parameter 'e3' can be declared with const [constParameter] pcb-20140316/gts/triangle.c:915:20: style: Parameter 'A' can be declared with const [constParameter] pcb-20140316/gts/triangle.c:916:20: style: Parameter 'B' can be declared with const [constParameter] pcb-20140316/gts/surface.c:247:17: warning: Opposite inner 'if' condition leads to a dead code block. [oppositeInnerCondition] pcb-20140316/gts/surface.c:246:15: note: outer condition: f->type==GTS_STRING pcb-20140316/gts/surface.c:247:17: note: opposite inner condition: f->type!=GTS_STRING pcb-20140316/gts/surface.c:1331:16: style: Local variable 't' shadows outer variable [shadowVariable] pcb-20140316/gts/surface.c:1307:19: note: Shadowed declaration pcb-20140316/gts/surface.c:1331:16: note: Shadow variable pcb-20140316/gts/surface.c:1387:18: style: Local variable 's' shadows outer variable [shadowVariable] pcb-20140316/gts/surface.c:1372:16: note: Shadowed declaration pcb-20140316/gts/surface.c:1387:18: note: Shadow variable pcb-20140316/gts/surface.c:1401:18: style: Local variable 's' shadows outer variable [shadowVariable] pcb-20140316/gts/surface.c:1372:16: note: Shadowed declaration pcb-20140316/gts/surface.c:1401:18: note: Shadow variable pcb-20140316/gts/surface.c:1460:12: style: Local variable 'e1' shadows outer variable [shadowVariable] pcb-20140316/gts/surface.c:1454:15: note: Shadowed declaration pcb-20140316/gts/surface.c:1460:12: note: Shadow variable pcb-20140316/gts/surface.c:2672:14: style: Local variable 'data' shadows outer argument [shadowArgument] pcb-20140316/gts/surface.c:2659:56: note: Shadowed declaration pcb-20140316/gts/surface.c:2672:14: note: Shadow variable pcb-20140316/gts/surface.c:2701:14: style: Local variable 'data' shadows outer argument [shadowArgument] pcb-20140316/gts/surface.c:2689:57: note: Shadowed declaration pcb-20140316/gts/surface.c:2701:14: note: Shadow variable pcb-20140316/gts/surface.c:1710:15: style: Parameter 'min_number' can be declared with const [constParameter] pcb-20140316/gts/surface.c:1733:15: style: Parameter 'max_cost' can be declared with const [constParameter] pcb-20140316/gts/surface.c:1301:57: style: Parameter 'e' can be declared with const [constParameter] pcb-20140316/gts/surface.c:1344:53: style: Parameter 'v1' can be declared with const [constParameter] pcb-20140316/gts/surface.c:2178:62: style: Parameter 'data' can be declared with const [constParameter] pcb-20140316/gts/surface.c:2257:18: style: Parameter 'data' can be declared with const [constParameter] pcb-20140316/gts/surface.c:2325:18: style: Parameter 'data' can be declared with const [constParameter] pcb-20140316/gts/surface.c:2642:57: style: Parameter 'data' can be declared with const [constParameter] pcb-20140316/gts/surface.c:2659:56: style: Parameter 'data' can be declared with const [constParameter] pcb-20140316/gts/surface.c:2689:57: style: Parameter 'data' can be declared with const [constParameter] pcb-20140316/gts/tribox3.c:45:28: style: Parameter 'normal' can be declared with const [constParameter] pcb-20140316/gts/tribox3.c:45:46: style: Parameter 'vert' can be declared with const [constParameter] pcb-20140316/gts/tribox3.c:45:62: style: Parameter 'maxbox' can be declared with const [constParameter] pcb-20140316/gts/tribox3.c:116:26: style: Parameter 'boxcenter' can be declared with const [constParameter] pcb-20140316/intl/bindtextdom.c:252:12: style: Local variable 'len' shadows outer variable [shadowVariable] pcb-20140316/intl/bindtextdom.c:224:14: note: Shadowed declaration pcb-20140316/intl/bindtextdom.c:252:12: note: Shadow variable pcb-20140316/intl/bindtextdom.c:283:15: style: Local variable 'len' shadows outer variable [shadowVariable] pcb-20140316/intl/bindtextdom.c:224:14: note: Shadowed declaration pcb-20140316/intl/bindtextdom.c:283:15: note: Shadow variable pcb-20140316/gts/vertex.c:165:70: style: Parameter 'v2' can be declared with const [constParameter] pcb-20140316/gts/vertex.c:442:21: style: Parameter 'f' can be declared with const [constParameter] pcb-20140316/gts/vertex.c:567:16: style: Parameter 'e1' can be declared with const [constParameter] pcb-20140316/gts/vopt.c:357:11: style: Local variable 'i' shadows outer variable [shadowVariable] pcb-20140316/gts/vopt.c:240:25: note: Shadowed declaration pcb-20140316/gts/vopt.c:357:11: note: Shadow variable pcb-20140316/gts/vopt.c:384:22: style: Local variable 'i' shadows outer variable [shadowVariable] pcb-20140316/gts/vopt.c:240:25: note: Shadowed declaration pcb-20140316/gts/vopt.c:384:22: note: Shadow variable pcb-20140316/intl/dcigettext.c:544:10: style: Obsolescent function 'getwd' called. It is recommended to use 'getcwd' instead. [prohibitedgetwdCalled] pcb-20140316/intl/dcigettext.c:583:39: style: Redundant condition: If 'EXPR == ':'', the comparison 'EXPR != '\0'' is always true. [redundantCondition] pcb-20140316/intl/dcigettext.c:427:25: style:inconclusive: Function 'libintl_dcigettext' argument 1 names different: declaration '__domainname' definition 'domainname'. [funcArgNamesDifferent] pcb-20140316/intl/gettextP.h:207:46: note: Function 'libintl_dcigettext' argument 1 names different: declaration '__domainname' definition 'domainname'. pcb-20140316/intl/dcigettext.c:427:25: note: Function 'libintl_dcigettext' argument 1 names different: declaration '__domainname' definition 'domainname'. pcb-20140316/intl/dcigettext.c:427:49: style:inconclusive: Function 'libintl_dcigettext' argument 2 names different: declaration '__msgid1' definition 'msgid1'. [funcArgNamesDifferent] pcb-20140316/intl/gettextP.h:208:18: note: Function 'libintl_dcigettext' argument 2 names different: declaration '__msgid1' definition 'msgid1'. pcb-20140316/intl/dcigettext.c:427:49: note: Function 'libintl_dcigettext' argument 2 names different: declaration '__msgid1' definition 'msgid1'. pcb-20140316/intl/dcigettext.c:427:69: style:inconclusive: Function 'libintl_dcigettext' argument 3 names different: declaration '__msgid2' definition 'msgid2'. [funcArgNamesDifferent] pcb-20140316/intl/gettextP.h:208:40: note: Function 'libintl_dcigettext' argument 3 names different: declaration '__msgid2' definition 'msgid2'. pcb-20140316/intl/dcigettext.c:427:69: note: Function 'libintl_dcigettext' argument 3 names different: declaration '__msgid2' definition 'msgid2'. pcb-20140316/intl/dcigettext.c:428:10: style:inconclusive: Function 'libintl_dcigettext' argument 4 names different: declaration '__plural' definition 'plural'. [funcArgNamesDifferent] pcb-20140316/intl/gettextP.h:209:10: note: Function 'libintl_dcigettext' argument 4 names different: declaration '__plural' definition 'plural'. pcb-20140316/intl/dcigettext.c:428:10: note: Function 'libintl_dcigettext' argument 4 names different: declaration '__plural' definition 'plural'. pcb-20140316/intl/dcigettext.c:428:36: style:inconclusive: Function 'libintl_dcigettext' argument 5 names different: declaration '__n' definition 'n'. [funcArgNamesDifferent] pcb-20140316/intl/gettextP.h:209:38: note: Function 'libintl_dcigettext' argument 5 names different: declaration '__n' definition 'n'. pcb-20140316/intl/dcigettext.c:428:36: note: Function 'libintl_dcigettext' argument 5 names different: declaration '__n' definition 'n'. pcb-20140316/intl/dcigettext.c:428:43: style:inconclusive: Function 'libintl_dcigettext' argument 6 names different: declaration '__category' definition 'category'. [funcArgNamesDifferent] pcb-20140316/intl/gettextP.h:210:10: note: Function 'libintl_dcigettext' argument 6 names different: declaration '__category' definition 'category'. pcb-20140316/intl/dcigettext.c:428:43: note: Function 'libintl_dcigettext' argument 6 names different: declaration '__category' definition 'category'. pcb-20140316/intl/dcigettext.c:227:7: style: struct member 'known_translation_t::category' is never used. [unusedStructMember] pcb-20140316/intl/dcigettext.c:230:7: style: struct member 'known_translation_t::counter' is never used. [unusedStructMember] pcb-20140316/intl/dcigettext.c:233:27: style: struct member 'known_translation_t::domain' is never used. [unusedStructMember] pcb-20140316/intl/dcigettext.c:236:15: style: struct member 'known_translation_t::translation' is never used. [unusedStructMember] pcb-20140316/intl/dcigettext.c:237:10: style: struct member 'known_translation_t::translation_length' is never used. [unusedStructMember] pcb-20140316/intl/dcigettext.c:240:8: style: struct member 'known_translation_t::msgid' is never used. [unusedStructMember] pcb-20140316/intl/finddomain.c:102:38: warning: Either the condition 'cnt>=0' is redundant or the array 'retval->successor[1]' is accessed at index -1, which is out of bounds. [negativeIndex] pcb-20140316/intl/finddomain.c:110:18: note: Assuming that condition 'cnt>=0' is not redundant pcb-20140316/intl/finddomain.c:102:38: note: Negative array index pcb-20140316/intl/finddomain.c:50:30: style:inconclusive: Function '_nl_find_domain' argument 1 names different: declaration '__dirname' definition 'dirname'. [funcArgNamesDifferent] pcb-20140316/intl/gettextP.h:157:54: note: Function '_nl_find_domain' argument 1 names different: declaration '__dirname' definition 'dirname'. pcb-20140316/intl/finddomain.c:50:30: note: Function '_nl_find_domain' argument 1 names different: declaration '__dirname' definition 'dirname'. pcb-20140316/intl/finddomain.c:50:45: style:inconclusive: Function '_nl_find_domain' argument 2 names different: declaration '__locale' definition 'locale'. [funcArgNamesDifferent] pcb-20140316/intl/gettextP.h:157:71: note: Function '_nl_find_domain' argument 2 names different: declaration '__locale' definition 'locale'. pcb-20140316/intl/finddomain.c:50:45: note: Function '_nl_find_domain' argument 2 names different: declaration '__locale' definition 'locale'. pcb-20140316/intl/finddomain.c:51:16: style:inconclusive: Function '_nl_find_domain' argument 3 names different: declaration '__domainname' definition 'domainname'. [funcArgNamesDifferent] pcb-20140316/intl/gettextP.h:158:19: note: Function '_nl_find_domain' argument 3 names different: declaration '__domainname' definition 'domainname'. pcb-20140316/intl/finddomain.c:51:16: note: Function '_nl_find_domain' argument 3 names different: declaration '__domainname' definition 'domainname'. pcb-20140316/intl/finddomain.c:51:44: style:inconclusive: Function '_nl_find_domain' argument 4 names different: declaration '__domainbinding' definition 'domainbinding'. [funcArgNamesDifferent] pcb-20140316/intl/gettextP.h:159:23: note: Function '_nl_find_domain' argument 4 names different: declaration '__domainbinding' definition 'domainbinding'. pcb-20140316/intl/finddomain.c:51:44: note: Function '_nl_find_domain' argument 4 names different: declaration '__domainbinding' definition 'domainbinding'. pcb-20140316/intl/localcharset.c:295:14: style: Condition 'locale==NULL' is always true [knownConditionTrueFalse] pcb-20140316/intl/localcharset.c:286:24: note: Assignment 'locale=NULL', assigned value is 0 pcb-20140316/intl/localcharset.c:295:14: note: Condition 'locale==NULL' is always true pcb-20140316/intl/localcharset.c:181:5: error: Common realloc mistake: 'res_ptr' nulled but not freed upon failure [memleakOnRealloc] plural.c:1201:5: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] plural.y:152:21: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:154:52: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:163:96: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:172:71: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:181:72: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:190:89: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:199:89: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:208:89: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:217:89: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:226:48: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:245:42: style: Same expression on both sides of '-'. [duplicateExpression] pcb-20140316/src/autoplace.c:127:12: style: struct member 'ElementPtrListType::elementN' is never used. [unusedStructMember] pcb-20140316/src/action.c:7396:21: style: Obsolescent function 'tmpnam' called. It is recommended to use 'tmpfile', 'mkstemp' or 'mkdtemp' instead. [prohibitedtmpnamCalled] pcb-20140316/src/action.c:6336:12: style: Condition 'function' is always true [knownConditionTrueFalse] pcb-20140316/src/action.c:7123:12: style: Condition 'e' is always true [knownConditionTrueFalse] pcb-20140316/src/action.c:1890:3: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] pcb-20140316/src/action.c:1891:3: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] pcb-20140316/src/action.c:1895:7: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] pcb-20140316/src/action.c:1896:7: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] pcb-20140316/src/action.c:3474:8: warning: %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] pcb-20140316/src/action.c:7828:6: error: Memory leak: sources [memleak] pcb-20140316/src/action.c:3302:21: warning: Either the condition 'name' is redundant or there is possible null pointer dereference: name. [nullPointerRedundantCheck] pcb-20140316/src/action.c:3297:7: note: Assuming that condition 'name' is not redundant pcb-20140316/src/action.c:3302:21: note: Null pointer dereference pcb-20140316/src/action.c:6108:26: warning: Either the condition 'name' is redundant or there is possible null pointer dereference: name. [nullPointerRedundantCheck] pcb-20140316/src/action.c:6095:13: note: Assuming that condition 'name' is not redundant pcb-20140316/src/action.c:6108:26: note: Null pointer dereference pcb-20140316/src/action.c:4002:18: style: Variable 'Marked.status' is reassigned a value before the old one has been used. [redundantAssignment] pcb-20140316/src/action.c:4001:18: note: Marked.status is assigned pcb-20140316/src/action.c:4002:18: note: Marked.status is overwritten pcb-20140316/src/action.c:1149:37: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-20140316/src/action.c:1164:37: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-20140316/src/action.c:7847:45: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-20140316/src/action.c:7849:39: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-20140316/src/action.c:657:15: style: Local variable 'box' shadows outer variable [shadowVariable] pcb-20140316/src/action.c:653:11: note: Shadowed declaration pcb-20140316/src/action.c:657:15: note: Shadow variable pcb-20140316/src/action.c:1544:10: style: Local variable 'type' shadows outer variable [shadowVariable] pcb-20140316/src/action.c:970:7: note: Shadowed declaration pcb-20140316/src/action.c:1544:10: note: Shadow variable pcb-20140316/src/action.c:1566:10: style: Local variable 'type' shadows outer variable [shadowVariable] pcb-20140316/src/action.c:970:7: note: Shadowed declaration pcb-20140316/src/action.c:1566:10: note: Shadow variable pcb-20140316/src/action.c:3044:10: style: Local variable 'saved_mode' shadows outer variable [shadowVariable] pcb-20140316/src/action.c:324:13: note: Shadowed declaration pcb-20140316/src/action.c:3044:10: note: Shadow variable pcb-20140316/src/action.c:5466:12: style: Local variable 'x' shadows outer argument [shadowArgument] pcb-20140316/src/action.c:5349:44: note: Shadowed declaration pcb-20140316/src/action.c:5466:12: note: Shadow variable pcb-20140316/src/action.c:5466:15: style: Local variable 'y' shadows outer argument [shadowArgument] pcb-20140316/src/action.c:5349:53: note: Shadowed declaration pcb-20140316/src/action.c:5466:15: note: Shadow variable pcb-20140316/src/action.c:6126:12: style: Local variable 'x' shadows outer argument [shadowArgument] pcb-20140316/src/action.c:6029:49: note: Shadowed declaration pcb-20140316/src/action.c:6126:12: note: Shadow variable pcb-20140316/src/action.c:6126:15: style: Local variable 'y' shadows outer argument [shadowArgument] pcb-20140316/src/action.c:6029:58: note: Shadowed declaration pcb-20140316/src/action.c:6126:15: note: Shadow variable pcb-20140316/src/action.c:7643:13: style: Local variable 'x' shadows outer argument [shadowArgument] pcb-20140316/src/action.c:7604:44: note: Shadowed declaration pcb-20140316/src/action.c:7643:13: note: Shadow variable pcb-20140316/src/action.c:7643:16: style: Local variable 'y' shadows outer argument [shadowArgument] pcb-20140316/src/action.c:7604:53: note: Shadowed declaration pcb-20140316/src/action.c:7643:16: note: Shadow variable pcb-20140316/src/action.c:3250:34: style: Parameter 'argv' can be declared with const [constParameter] pcb-20140316/src/action.c:4474:39: style: Parameter 'argv' can be declared with const [constParameter] pcb-20140316/src/action.c:5698:32: style: Parameter 'argv' can be declared with const [constParameter] pcb-20140316/src/action.c:5848:34: style: Parameter 'argv' can be declared with const [constParameter] pcb-20140316/src/action.c:6853:37: style: Parameter 'argv' can be declared with const [constParameter] pcb-20140316/src/action.c:7334:27: style: Parameter 'name' can be declared with const [constParameter] pcb-20140316/src/action.c:6757:7: warning: Conversion of string literal "square" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/action.c:6762:12: warning: Conversion of string literal "octagon" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/action.c:6767:12: warning: Conversion of string literal "join" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/action.c:4676:16: style: Variable 'type' is assigned a value that is never used. [unreadVariable] pcb-20140316/src/action.c:5228:16: style: Variable 'type' is assigned a value that is never used. [unreadVariable] pcb-20140316/src/action.c:5277:16: style: Variable 'type' is assigned a value that is never used. [unreadVariable] pcb-20140316/src/action.c:6299:10: style: Variable 'ptr2' is assigned a value that is never used. [unreadVariable] pcb-20140316/src/autoroute.c:4851:13: warning: Assert statement calls a function which may have desired side effects: 'no_expansion_boxes'. [assertWithSideEffect] pcb-20140316/src/autoroute.c:4939:16: style: Condition 'smoothes' is always true [knownConditionTrueFalse] pcb-20140316/src/autoroute.c:4941:53: style: Condition 'ipasses' is not redundant pcb-20140316/src/autoroute.c:4941:53: note: Condition 'iX' to itself. [selfAssignment] pcb-20140316/src/buffer.c:1426:12: warning: Redundant assignment of 'via->X' to itself. [selfAssignment] pcb-20140316/src/buffer.c:1432:20: warning: Redundant assignment of 'line->Point1.X' to itself. [selfAssignment] pcb-20140316/src/buffer.c:1434:20: warning: Redundant assignment of 'line->Point2.X' to itself. [selfAssignment] pcb-20140316/src/buffer.c:1440:12: warning: Redundant assignment of 'arc->X' to itself. [selfAssignment] pcb-20140316/src/buffer.c:1451:16: warning: Redundant assignment of 'point->X' to itself. [selfAssignment] pcb-20140316/src/buffer.c:1480:13: warning: Redundant assignment of 'Buffer->X' to itself. [selfAssignment] pcb-20140316/src/buffer.c:1485:12: warning: Redundant assignment of 'via->X' to itself. [selfAssignment] pcb-20140316/src/buffer.c:1494:20: warning: Redundant assignment of 'line->Point1.X' to itself. [selfAssignment] pcb-20140316/src/buffer.c:1496:20: warning: Redundant assignment of 'line->Point2.X' to itself. [selfAssignment] pcb-20140316/src/buffer.c:1505:12: warning: Redundant assignment of 'arc->X' to itself. [selfAssignment] pcb-20140316/src/buffer.c:1518:16: warning: Redundant assignment of 'point->X' to itself. [selfAssignment] pcb-20140316/src/buffer.c:1530:13: warning: Redundant assignment of 'text->X' to itself. [selfAssignment] pcb-20140316/src/buffer.c:710:41: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-20140316/src/buffer.c:736:63: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-20140316/src/buffer.c:1569:11: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/buffer.c:1570:11: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/buffer.c:1577:11: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/buffer.c:1578:11: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/buffer.c:1365:41: style: Parameter 'argv' can be declared with const [constParameter] pcb-20140316/intl/loadmsgcat.c:982:2: error: Resource leak: fd [resourceLeak] pcb-20140316/intl/loadmsgcat.c:1018:7: error: Resource leak: fd [resourceLeak] pcb-20140316/intl/loadmsgcat.c:1023:5: error: Resource leak: fd [resourceLeak] pcb-20140316/intl/loadmsgcat.c:975:12: style: The comparison 'data == (struct mo_file_header*)-1' is always true because 'data' and '(struct mo_file_header*)-1' represent the same value. [knownConditionTrueFalse] pcb-20140316/intl/loadmsgcat.c:919:33: note: 'data' is assigned value '(struct mo_file_header*)-1' here. pcb-20140316/intl/loadmsgcat.c:975:12: note: The comparison 'data == (struct mo_file_header*)-1' is always true because 'data' and '(struct mo_file_header*)-1' represent the same value. pcb-20140316/intl/loadmsgcat.c:771:47: style:inconclusive: Function '_nl_init_domain_conv' argument 1 names different: declaration '__domain_file' definition 'domain_file'. [funcArgNamesDifferent] pcb-20140316/intl/gettextP.h:166:59: note: Function '_nl_init_domain_conv' argument 1 names different: declaration '__domain_file' definition 'domain_file'. pcb-20140316/intl/loadmsgcat.c:771:47: note: Function '_nl_init_domain_conv' argument 1 names different: declaration '__domain_file' definition 'domain_file'. pcb-20140316/intl/loadmsgcat.c:772:31: style:inconclusive: Function '_nl_init_domain_conv' argument 2 names different: declaration '__domain' definition 'domain'. [funcArgNamesDifferent] pcb-20140316/intl/gettextP.h:167:29: note: Function '_nl_init_domain_conv' argument 2 names different: declaration '__domain' definition 'domain'. pcb-20140316/intl/loadmsgcat.c:772:31: note: Function '_nl_init_domain_conv' argument 2 names different: declaration '__domain' definition 'domain'. pcb-20140316/intl/loadmsgcat.c:773:25: style:inconclusive: Function '_nl_init_domain_conv' argument 3 names different: declaration '__domainbinding' definition 'domainbinding'. [funcArgNamesDifferent] pcb-20140316/intl/gettextP.h:168:23: note: Function '_nl_init_domain_conv' argument 3 names different: declaration '__domainbinding' definition 'domainbinding'. pcb-20140316/intl/loadmsgcat.c:773:25: note: Function '_nl_init_domain_conv' argument 3 names different: declaration '__domainbinding' definition 'domainbinding'. pcb-20140316/intl/loadmsgcat.c:889:45: style:inconclusive: Function '_nl_free_domain_conv' argument 1 names different: declaration '__domain' definition 'domain'. [funcArgNamesDifferent] pcb-20140316/intl/gettextP.h:170:50: note: Function '_nl_free_domain_conv' argument 1 names different: declaration '__domain' definition 'domain'. pcb-20140316/intl/loadmsgcat.c:889:45: note: Function '_nl_free_domain_conv' argument 1 names different: declaration '__domain' definition 'domain'. pcb-20140316/intl/loadmsgcat.c:909:42: style:inconclusive: Function '_nl_load_domain' argument 1 names different: declaration '__domain' definition 'domain_file'. [funcArgNamesDifferent] pcb-20140316/intl/gettextP.h:161:47: note: Function '_nl_load_domain' argument 1 names different: declaration '__domain' definition 'domain_file'. pcb-20140316/intl/loadmsgcat.c:909:42: note: Function '_nl_load_domain' argument 1 names different: declaration '__domain' definition 'domain_file'. pcb-20140316/intl/loadmsgcat.c:910:20: style:inconclusive: Function '_nl_load_domain' argument 2 names different: declaration '__domainbinding' definition 'domainbinding'. [funcArgNamesDifferent] pcb-20140316/intl/gettextP.h:162:25: note: Function '_nl_load_domain' argument 2 names different: declaration '__domainbinding' definition 'domainbinding'. pcb-20140316/intl/loadmsgcat.c:910:20: note: Function '_nl_load_domain' argument 2 names different: declaration '__domainbinding' definition 'domainbinding'. pcb-20140316/src/command.c:123:37: style: Parameter 'argv' can be declared with const [constParameter] pcb-20140316/src/command.c:161:46: style: Parameter 'argv' can be declared with const [constParameter] pcb-20140316/src/command.c:197:45: style: Parameter 'argv' can be declared with const [constParameter] pcb-20140316/src/command.c:281:38: style: Parameter 'argv' can be declared with const [constParameter] pcb-20140316/src/create.c:659:38: style:inconclusive: Function 'CreateNewHoleInPolygon' argument 1 names different: declaration 'polygon' definition 'Polygon'. [funcArgNamesDifferent] pcb-20140316/src/create.h:55:52: note: Function 'CreateNewHoleInPolygon' argument 1 names different: declaration 'polygon' definition 'Polygon'. pcb-20140316/src/create.c:659:38: note: Function 'CreateNewHoleInPolygon' argument 1 names different: declaration 'polygon' definition 'Polygon'. pcb-20140316/src/create.c:976:24: warning: Conversion of string literal "(unknown)" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/dbus.c:118:10: warning: Either the condition 'argv' is redundant or there is possible null pointer dereference: argv. [nullPointerRedundantCheck] pcb-20140316/src/dbus.c:142:11: note: Assuming that condition 'argv' is not redundant pcb-20140316/src/dbus.c:118:10: note: Null pointer dereference pcb-20140316/src/crosshair.c:1104:41: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-20140316/src/crosshair.c:72:29: style: Parameter 'pv' can be declared with const [constParameter] pcb-20140316/src/draw.c:1042:3: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] pcb-20140316/src/draw.c:1047:3: note: Found duplicate branches for 'if' and 'else'. pcb-20140316/src/draw.c:1042:3: note: Found duplicate branches for 'if' and 'else'. pcb-20140316/src/drill.c:252:15: warning: Size of pointer 'Drill' used instead of size of its data. [pointerSize] pcb-20140316/src/draw.c:878:36: style:inconclusive: Function 'DrawMask' argument 2 names different: declaration 'drawn_area' definition 'screen'. [funcArgNamesDifferent] pcb-20140316/src/draw.h:73:41: note: Function 'DrawMask' argument 2 names different: declaration 'drawn_area' definition 'screen'. pcb-20140316/src/draw.c:878:36: note: Function 'DrawMask' argument 2 names different: declaration 'drawn_area' definition 'screen'. pcb-20140316/src/draw.c:1000:21: style:inconclusive: Function 'DrawLayerGroup' argument 1 names different: declaration 'side' definition 'group'. [funcArgNamesDifferent] pcb-20140316/src/draw.h:70:26: note: Function 'DrawLayerGroup' argument 1 names different: declaration 'side' definition 'group'. pcb-20140316/src/draw.c:1000:21: note: Function 'DrawLayerGroup' argument 1 names different: declaration 'side' definition 'group'. pcb-20140316/src/draw.c:1541:28: style:inconclusive: Function 'hid_expose_callback' argument 1 names different: declaration 'hid_' definition 'hid'. [funcArgNamesDifferent] pcb-20140316/src/hid.h:558:35: note: Function 'hid_expose_callback' argument 1 names different: declaration 'hid_' definition 'hid'. pcb-20140316/src/draw.c:1541:28: note: Function 'hid_expose_callback' argument 1 names different: declaration 'hid_' definition 'hid'. pcb-20140316/src/draw.c:1541:43: style:inconclusive: Function 'hid_expose_callback' argument 2 names different: declaration 'region_' definition 'region'. [funcArgNamesDifferent] pcb-20140316/src/hid.h:558:57: note: Function 'hid_expose_callback' argument 2 names different: declaration 'region_' definition 'region'. pcb-20140316/src/draw.c:1541:43: note: Function 'hid_expose_callback' argument 2 names different: declaration 'region_' definition 'region'. pcb-20140316/src/draw.c:1541:57: style:inconclusive: Function 'hid_expose_callback' argument 3 names different: declaration 'item_' definition 'item'. [funcArgNamesDifferent] pcb-20140316/src/hid.h:558:72: note: Function 'hid_expose_callback' argument 3 names different: declaration 'item_' definition 'item'. pcb-20140316/src/draw.c:1541:57: note: Function 'hid_expose_callback' argument 3 names different: declaration 'item_' definition 'item'. edif.c:3932:5: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] edif.y:520:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:551:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:575:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:666:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:676:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:691:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:714:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:774:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:866:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:873:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:974:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:987:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1034:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1041:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1130:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1137:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1153:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1160:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1167:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1200:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1207:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1215:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1222:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1228:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1235:28: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1242:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1247:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1262:33: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1326:18: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1352:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1359:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1366:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1373:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1406:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1413:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1423:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1451:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1458:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1469:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1524:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1536:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1552:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1559:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1591:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1598:33: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1612:28: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1619:44: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1626:44: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1633:29: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1640:28: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1647:28: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1661:29: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1675:29: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1689:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1696:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1703:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1868:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1934:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1969:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1975:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:1991:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:2010:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:2021:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:2027:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:2034:28: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:2066:29: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:2073:44: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:2087:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:2094:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:2143:28: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:2150:28: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:2157:28: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:2171:32: style: Same expression on both sides of '-'. [duplicateExpression] pcb-20140316/src/file.c:1228:25: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled] edif.y:2178:23: style: Same expression on both sides of '-'. [duplicateExpression] pcb-20140316/src/file.c:1320:12: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] edif.y:2206:23: style: Same expression on both sides of '-'. [duplicateExpression] pcb-20140316/src/file.c:1370:26: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled] edif.y:2213:23: style: Same expression on both sides of '-'. [duplicateExpression] pcb-20140316/src/file.c:1483:31: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] edif.y:2220:32: style: Same expression on both sides of '-'. [duplicateExpression] pcb-20140316/src/file.c:1485:25: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] edif.y:2250:32: style: Same expression on both sides of '-'. [duplicateExpression] pcb-20140316/src/file.c:1486:25: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] edif.y:2266:23: style: Same expression on both sides of '-'. [duplicateExpression] pcb-20140316/src/file.c:1487:28: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] edif.y:2271:23: style: Same expression on both sides of '-'. [duplicateExpression] pcb-20140316/src/file.c:319:7: style: Condition 'fname' is always true [knownConditionTrueFalse] edif.y:2316:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:2461:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:2468:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:2475:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:2482:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:2489:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:2496:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:2512:32: style: Same expression on both sides of '-'. [duplicateExpression] pcb-20140316/src/file.c:1005:3: error: Returning/dereferencing 'fp' after it is deallocated / released [deallocret] pcb-20140316/src/file.c:1004:13: note: Returning/dereferencing 'fp' after it is deallocated / released pcb-20140316/src/file.c:1005:3: note: Returning/dereferencing 'fp' after it is deallocated / released edif.y:2519:23: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:2556:32: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:2563:33: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:2585:28: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:2592:28: style: Same expression on both sides of '-'. [duplicateExpression] edif.y:2599:28: style: Same expression on both sides of '-'. [duplicateExpression] pcb-20140316/src/file.c:1476:26: error: Null pointer dereference: (char*)NULL [nullPointer] edif.y:2606:28: style: Same expression on both sides of '-'. [duplicateExpression] pcb-20140316/src/file.c:458:44: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-20140316/src/file.c:1168:35: style:inconclusive: Function 'LoadNewlibFootprintsFromDir' argument 1 names different: declaration 'path' definition 'libpath'. [funcArgNamesDifferent] pcb-20140316/src/file.c:124:46: note: Function 'LoadNewlibFootprintsFromDir' argument 1 names different: declaration 'path' definition 'libpath'. pcb-20140316/src/file.c:1168:35: note: Function 'LoadNewlibFootprintsFromDir' argument 1 names different: declaration 'path' definition 'libpath'. pcb-20140316/src/file.c:1242:10: warning: Conversion of string literal "CVS" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/file.c:1243:10: warning: Conversion of string literal "Makefile" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/file.c:1244:10: warning: Conversion of string literal "Makefile.am" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/file.c:1245:10: warning: Conversion of string literal "Makefile.in" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/file.c:1246:20: warning: Conversion of string literal ".png" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/file.c:1247:20: warning: Conversion of string literal ".html" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/file.c:1248:20: warning: Conversion of string literal ".pcb" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/file.c:1381:11: warning: Conversion of string literal "CVS" to bool always evaluates to true. [incorrectStringBooleanError] edif.y:4039:3: error: Memory is allocated but not initialized: cp [uninitdata] pcb-20140316/src/flags.c:110:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/djopt.c:1300:4: error: Common realloc mistake: 'cs' nulled but not freed upon failure [memleakOnRealloc] pcb-20140316/src/djopt.c:1334:4: error: Common realloc mistake: 'ls' nulled but not freed upon failure [memleakOnRealloc] pcb-20140316/src/djopt.c:2018:11: warning: Possible null pointer dereference: c2 [nullPointer] pcb-20140316/src/djopt.c:2002:12: note: Assignment 'c2=0', assigned value is 0 pcb-20140316/src/djopt.c:2003:21: note: Assuming condition is false pcb-20140316/src/djopt.c:2018:11: note: Null pointer dereference pcb-20140316/src/free_atexit.c:51:3: error: Common realloc mistake: 'free_list' nulled but not freed upon failure [memleakOnRealloc] pcb-20140316/src/free_atexit.c:56:21: portability: 'new_memory' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer] pcb-20140316/src/free_atexit.c:76:14: portability: 'old_memory' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer] pcb-20140316/src/free_atexit.c:83:21: portability: 'new_memory' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer] pcb-20140316/src/free_atexit.c:39:15: style: union member 'leaky_admin_t::idx' is never used. [unusedStructMember] pcb-20140316/src/free_atexit.c:40:9: style: union member 'leaky_admin_t::ptr' is never used. [unusedStructMember] pcb-20140316/src/djopt.c:1531:8: style: Local variable 'len' shadows outer variable [shadowVariable] pcb-20140316/src/djopt.c:1256:12: note: Shadowed declaration pcb-20140316/src/djopt.c:1531:8: note: Shadow variable pcb-20140316/src/djopt.c:1571:14: style: Local variable 'l' shadows outer variable [shadowVariable] pcb-20140316/src/djopt.c:1252:11: note: Shadowed declaration pcb-20140316/src/djopt.c:1571:14: note: Shadow variable pcb-20140316/src/djopt.c:2225:17: style: Local variable 'dist' shadows outer function [shadowFunction] pcb-20140316/src/djopt.c:327:1: note: Shadowed declaration pcb-20140316/src/djopt.c:2225:17: note: Shadow variable pcb-20140316/src/djopt.c:2680:15: style: Local variable 'l' shadows outer variable [shadowVariable] pcb-20140316/src/djopt.c:2550:7: note: Shadowed declaration pcb-20140316/src/djopt.c:2680:15: note: Shadow variable pcb-20140316/src/djopt.c:411:37: style: Parameter 'c' can be declared with const [constParameter] pcb-20140316/src/djopt.c:458:38: style: Parameter 'c' can be declared with const [constParameter] pcb-20140316/src/djopt.c:626:36: style: Parameter 'l' can be declared with const [constParameter] pcb-20140316/src/djopt.c:2967:7: warning: Conversion of string literal "splitlines" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/djopt.c:3018:7: warning: Conversion of string literal "debumpify" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/djopt.c:3020:12: warning: Conversion of string literal "unjaggy" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/djopt.c:3022:12: warning: Conversion of string literal "simple" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/djopt.c:3024:12: warning: Conversion of string literal "vianudge" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/djopt.c:3026:12: warning: Conversion of string literal "viatrim" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/djopt.c:3028:12: warning: Conversion of string literal "orthopull" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/djopt.c:3030:12: warning: Conversion of string literal "auto" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/djopt.c:3032:12: warning: Conversion of string literal "miter" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/djopt.c:906:7: style: Variable 'i' is assigned a value that is never used. [unreadVariable] pcb-20140316/src/hid/batch/batch.c:34:7: style: struct member 'hid_gc_struct::nothing_interesting_here' is never used. [unusedStructMember] pcb-20140316/src/hid/common/actions.c:41:3: error: Common realloc mistake: 'all_actions' nulled but not freed upon failure [memleakOnRealloc] pcb-20140316/src/hid/common/actions.c:352:3: error: Common realloc mistake: 'list' nulled but not freed upon failure [memleakOnRealloc] pcb-20140316/src/hid/common/actions.c:222:11: style: Local variable 'i' shadows outer variable [shadowVariable] pcb-20140316/src/hid/common/actions.c:213:7: note: Shadowed declaration pcb-20140316/src/hid/common/actions.c:222:11: note: Shadow variable pcb-20140316/src/hid/bom/bom.c:367:47: portability: Non reentrant function 'gmtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'gmtime_r'. [prohibitedgmtimeCalled] pcb-20140316/src/hid/bom/bom.c:455:17: style: Condition 'pin_cnt>0' is always true [knownConditionTrueFalse] pcb-20140316/src/hid/bom/bom.c:389:15: note: Assignment 'pin_cnt=0', assigned value is 0 pcb-20140316/src/hid/bom/bom.c:413:7: note: pin_cnt is incremented', new value is 1 pcb-20140316/src/hid/bom/bom.c:432:7: note: pin_cnt is incremented', new value is 2 pcb-20140316/src/hid/bom/bom.c:455:17: note: Condition 'pin_cnt>0' is always true pcb-20140316/src/hid/bom/bom.c:337:16: style: Variable 'theta' is assigned a value that is never used. [unreadVariable] pcb-20140316/src/hid/bom/bom.c:476:39: style: Variable 'found_any_not_at_centroid' is assigned a value that is never used. [unreadVariable] pcb-20140316/src/hid/bom/bom.c:477:23: style: Variable 'found_any' is assigned a value that is never used. [unreadVariable] pcb-20140316/src/hid/common/extents.c:136:64: style: Parameter 'y' can be declared with const [constParameter] pcb-20140316/src/hid/common/extents.c:136:54: style: Parameter 'x' can be declared with const [constParameter] pcb-20140316/src/hid/common/draw_helpers.c:260:53: style:inconclusive: Function 'common_gui_draw_pcb_polygon' argument 2 names different: declaration 'poly' definition 'polygon'. [funcArgNamesDifferent] pcb-20140316/src/hid/common/draw_helpers.h:1:58: note: Function 'common_gui_draw_pcb_polygon' argument 2 names different: declaration 'poly' definition 'polygon'. pcb-20140316/src/hid/common/draw_helpers.c:260:53: note: Function 'common_gui_draw_pcb_polygon' argument 2 names different: declaration 'poly' definition 'polygon'. pcb-20140316/src/hid/common/draw_helpers.c:521:11: style: Local variable 'i' shadows outer variable [shadowVariable] pcb-20140316/src/hid/common/draw_helpers.c:501:7: note: Shadowed declaration pcb-20140316/src/hid/common/draw_helpers.c:521:11: note: Shadow variable pcb-20140316/src/hid/common/draw_helpers.c:558:13: style: Local variable 'r' shadows outer variable [shadowVariable] pcb-20140316/src/hid/common/draw_helpers.c:538:9: note: Shadowed declaration pcb-20140316/src/hid/common/draw_helpers.c:558:13: note: Shadow variable pcb-20140316/src/hid/common/draw_helpers.c:597:13: style: Local variable 'r' shadows outer variable [shadowVariable] pcb-20140316/src/hid/common/draw_helpers.c:577:9: note: Shadowed declaration pcb-20140316/src/hid/common/draw_helpers.c:597:13: note: Shadow variable pcb-20140316/src/hid/common/flags.c:109:4: error: Common realloc mistake: 'buf' nulled but not freed upon failure [memleakOnRealloc] pcb-20140316/src/hid/common/flags.c:140:29: style: Parameter 'save_array' can be declared with const [constParameter] pcb-20140316/src/hid/common/hidgl.c:443:9: portability: %lu in format string (no. 1) requires 'unsigned long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_uint] pcb-20140316/src/hid/common/hidgl.c:149:7: error: Common realloc mistake: 'points' nulled but not freed upon failure [memleakOnRealloc] pcb-20140316/src/hid/common/hidgl.c:282:36: style:inconclusive: Function 'hidgl_draw_arc' argument 2 names different: declaration 'vx' definition 'x'. [funcArgNamesDifferent] pcb-20140316/src/hid/common/hidgl.h:71:41: note: Function 'hidgl_draw_arc' argument 2 names different: declaration 'vx' definition 'x'. pcb-20140316/src/hid/common/hidgl.c:282:36: note: Function 'hidgl_draw_arc' argument 2 names different: declaration 'vx' definition 'x'. pcb-20140316/src/hid/common/hidgl.c:282:45: style:inconclusive: Function 'hidgl_draw_arc' argument 3 names different: declaration 'vy' definition 'y'. [funcArgNamesDifferent] pcb-20140316/src/hid/common/hidgl.h:71:51: note: Function 'hidgl_draw_arc' argument 3 names different: declaration 'vy' definition 'y'. pcb-20140316/src/hid/common/hidgl.c:282:45: note: Function 'hidgl_draw_arc' argument 3 names different: declaration 'vy' definition 'y'. pcb-20140316/src/hid/common/hidgl.c:282:54: style:inconclusive: Function 'hidgl_draw_arc' argument 4 names different: declaration 'vrx' definition 'rx'. [funcArgNamesDifferent] pcb-20140316/src/hid/common/hidgl.h:71:61: note: Function 'hidgl_draw_arc' argument 4 names different: declaration 'vrx' definition 'rx'. pcb-20140316/src/hid/common/hidgl.c:282:54: note: Function 'hidgl_draw_arc' argument 4 names different: declaration 'vrx' definition 'rx'. pcb-20140316/src/hid/common/hidgl.c:282:64: style:inconclusive: Function 'hidgl_draw_arc' argument 5 names different: declaration 'vry' definition 'ry'. [funcArgNamesDifferent] pcb-20140316/src/hid/common/hidgl.h:71:72: note: Function 'hidgl_draw_arc' argument 5 names different: declaration 'vry' definition 'ry'. pcb-20140316/src/hid/common/hidgl.c:282:64: note: Function 'hidgl_draw_arc' argument 5 names different: declaration 'vry' definition 'ry'. pcb-20140316/src/hid/common/hidgl.c:524:42: style: Parameter 'x' can be declared with const [constParameter] pcb-20140316/src/hid/common/hidgl.c:524:52: style: Parameter 'y' can be declared with const [constParameter] pcb-20140316/src/hid/common/hidgl.c:423:22: style: Parameter 'coords' can be declared with const [constParameter] pcb-20140316/src/hid/common/hidnogui.c:230:3: style: Statements following return, break, continue, goto or throw will never be executed. [unreachableCode] pcb-20140316/src/hid/common/hidnogui.c:246:3: style: Statements following return, break, continue, goto or throw will never be executed. [unreachableCode] pcb-20140316/src/hid/common/hidnogui.c:261:3: style: Statements following return, break, continue, goto or throw will never be executed. [unreachableCode] pcb-20140316/src/hid/common/hidnogui.c:358:54: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-20140316/src/hid/common/hidnogui.c:27:7: style: struct member 'hid_gc_struct::nothing_interesting_here' is never used. [unusedStructMember] pcb-20140316/src/hid/common/trackball.c:302:38: style: Parameter 'q' can be declared with const [constParameter] pcb-20140316/src/hid/common/hidinit.c:63:16: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled] pcb-20140316/src/hid/common/hidinit.c:169:5: error: Common realloc mistake: 'hid_list' nulled but not freed upon failure [memleakOnRealloc] pcb-20140316/src/hid/common/hidinit.c:711:24: style: Variable 'hash' is reassigned a value before the old one has been used. [redundantAssignment] pcb-20140316/src/hid/common/hidinit.c:710:8: note: hash is assigned pcb-20140316/src/hid/common/hidinit.c:711:24: note: hash is overwritten pcb-20140316/src/hid/common/hidinit.c:381:5: style: Statements following return, break, continue, goto or throw will never be executed. [unreachableCode] pcb-20140316/src/hid/common/hidinit.c:686:66: style:inconclusive: Function 'hid_cache_color' argument 4 names different: declaration 'cache' definition 'vcache'. [funcArgNamesDifferent] pcb-20140316/src/hid/hidint.h:25:70: note: Function 'hid_cache_color' argument 4 names different: declaration 'cache' definition 'vcache'. pcb-20140316/src/hid/common/hidinit.c:686:66: note: Function 'hid_cache_color' argument 4 names different: declaration 'cache' definition 'vcache'. pcb-20140316/src/hid/gcode/gcode.c:1468:7: error: Common realloc mistake: 'drills' nulled but not freed upon failure [memleakOnRealloc] pcb-20140316/src/hid/gcode/gcode.c:1543:52: style: Parameter 'x' can be declared with const [constParameter] pcb-20140316/src/hid/gcode/gcode.c:1543:62: style: Parameter 'y' can be declared with const [constParameter] pcb-20140316/src/hid/gerber/gerber.c:843:42: portability: Non reentrant function 'gmtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'gmtime_r'. [prohibitedgmtimeCalled] pcb-20140316/src/hid/gerber/gerber.c:282:7: error: Common realloc mistake: 'layer_aptr_list' nulled but not freed upon failure [memleakOnRealloc] pcb-20140316/src/hid/gerber/gerber.c:643:3: error: Common realloc mistake: 'filename' nulled but not freed upon failure [memleakOnRealloc] pcb-20140316/src/hid/gerber/gerber.c:1216:4: error: Common realloc mistake: 'pending_drills' nulled but not freed upon failure [memleakOnRealloc] pcb-20140316/src/hid/gerber/gerber.c:246:31: style: Same expression in both branches of ternary operator. [duplicateExpressionTernary] pcb-20140316/src/hid/gerber/gerber.c:997:36: style:inconclusive: Function 'gerber_set_draw_xor' argument 2 names different: declaration '_xor' definition 'xor_'. [funcArgNamesDifferent] pcb-20140316/src/hid/gerber/gerber.c:56:48: note: Function 'gerber_set_draw_xor' argument 2 names different: declaration '_xor' definition 'xor_'. pcb-20140316/src/hid/gerber/gerber.c:997:36: note: Function 'gerber_set_draw_xor' argument 2 names different: declaration '_xor' definition 'xor_'. pcb-20140316/src/hid/gerber/gerber.c:1242:53: style: Parameter 'x' can be declared with const [constParameter] pcb-20140316/src/hid/gerber/gerber.c:1242:63: style: Parameter 'y' can be declared with const [constParameter] pcb-20140316/src/find.c:3083:35: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-20140316/src/find.c:602:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:617:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:632:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:646:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:663:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:664:41: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:889:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:961:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:981:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:1001:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:1022:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:1023:36: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:1062:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:1658:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:1674:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:1688:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:1744:20: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:1768:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:1784:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:1798:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:1822:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:1891:24: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:1925:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:1941:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:1957:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:2028:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:2044:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:2059:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:2075:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:2105:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:2194:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:2210:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:2224:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:2240:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:2303:20: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:2674:14: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:2717:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:2805:9: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:2829:9: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:3159:9: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:3174:11: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:3187:11: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:3215:9: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:3228:9: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:3241:9: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:3254:9: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/find.c:366:25: style: Parameter 'box_in' can be declared with const [constParameter] pcb-20140316/src/hid/gcode/trace.c:1418:6: style: Redundant initialization for 'po'. The initialized value is overwritten before it is read. [redundantInitialization] pcb-20140316/src/hid/gcode/trace.c:1410:11: note: po is initialized pcb-20140316/src/hid/gcode/trace.c:1418:6: note: po is overwritten pcb-20140316/src/hid/gcode/trace.c:1419:6: style: Redundant initialization for 'pt'. The initialized value is overwritten before it is read. [redundantInitialization] pcb-20140316/src/hid/gcode/trace.c:1411:15: note: pt is initialized pcb-20140316/src/hid/gcode/trace.c:1419:6: note: pt is overwritten pcb-20140316/src/hid/gcode/trace.c:1064:34: style: Parameter 'convc' can be declared with const [constParameter] pcb-20140316/src/hid/gcode/trace.c:1064:49: style: Parameter 'areac' can be declared with const [constParameter] pcb-20140316/src/hid/gtk/ghid-route-style-selector.c:551:57: style: Parameter 'rst' can be declared with const [constParameter] pcb-20140316/src/hid/gtk/gtkhid-main.c:2075:1: error: There is an unknown macro here somewhere. Configuration is required. If REGISTER_FLAGS is a macro then please configure it. [unknownMacro] pcb-20140316/src/hid/gtk/gtkhid-gdk.c:199:7: error: Common realloc mistake: 'points' nulled but not freed upon failure [memleakOnRealloc] pcb-20140316/src/hid/gtk/gtkhid-gdk.c:650:7: error: Common realloc mistake: 'points' nulled but not freed upon failure [memleakOnRealloc] pcb-20140316/src/hid/gtk/gtkhid-gdk.c:471:34: style:inconclusive: Function 'ghid_set_draw_xor' argument 2 names different: declaration '_xor' definition 'xor_mask'. [funcArgNamesDifferent] pcb-20140316/src/hid/gtk/gui.h:480:39: note: Function 'ghid_set_draw_xor' argument 2 names different: declaration '_xor' definition 'xor_mask'. pcb-20140316/src/hid/gtk/gtkhid-gdk.c:471:34: note: Function 'ghid_set_draw_xor' argument 2 names different: declaration '_xor' definition 'xor_mask'. pcb-20140316/src/hid/gtk/gtkhid-gdk.c:702:30: style: Parameter 'rect' can be declared with const [constParameter] pcb-20140316/src/hid/gtk/gtkhid-gl.c:490:34: style:inconclusive: Function 'ghid_set_draw_xor' argument 2 names different: declaration '_xor' definition 'xor'. [funcArgNamesDifferent] pcb-20140316/src/hid/gtk/gui.h:480:39: note: Function 'ghid_set_draw_xor' argument 2 names different: declaration '_xor' definition 'xor'. pcb-20140316/src/hid/gtk/gtkhid-gl.c:490:34: note: Function 'ghid_set_draw_xor' argument 2 names different: declaration '_xor' definition 'xor'. pcb-20140316/src/hid/gtk/gui-dialog.c:674:44: warning: Either the condition 'k<8' is redundant or the array 'recent_dirs[history_pool].history[8]' is accessed at index 8, which is out of bounds. [arrayIndexOutOfBoundsCond] pcb-20140316/src/hid/gtk/gui-dialog.c:668:14: note: Assuming that condition 'k<8' is not redundant pcb-20140316/src/hid/gtk/gui-dialog.c:674:44: note: Array index out of bounds pcb-20140316/src/hid/gtk/gui-dialog.c:345:24: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] pcb-20140316/src/hid/gtk/gui-dialog.c:428:24: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] pcb-20140316/src/hid/gtk/gui-dialog.c:498:24: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] pcb-20140316/src/hid/gtk/gui-dialog.c:110:34: style:inconclusive: Function 'ghid_dialog_confirm_all' argument 1 names different: declaration 'message' definition 'all_message'. [funcArgNamesDifferent] pcb-20140316/src/hid/gtk/gui.h:321:39: note: Function 'ghid_dialog_confirm_all' argument 1 names different: declaration 'message' definition 'all_message'. pcb-20140316/src/hid/gtk/gui-dialog.c:110:34: note: Function 'ghid_dialog_confirm_all' argument 1 names different: declaration 'message' definition 'all_message'. pcb-20140316/src/hid/gtk/gui-misc.c:147:23: style:inconclusive: Function 'ghid_mode_cursor' argument 1 names different: declaration 'mode' definition 'Mode'. [funcArgNamesDifferent] pcb-20140316/src/hid/gtk/gui.h:265:29: note: Function 'ghid_mode_cursor' argument 1 names different: declaration 'mode' definition 'Mode'. pcb-20140316/src/hid/gtk/gui-misc.c:147:23: note: Function 'ghid_mode_cursor' argument 1 names different: declaration 'mode' definition 'Mode'. pcb-20140316/src/hid/gtk/gui-output-events.c:200:16: debug: Wrong data detected by condition !tok->next()->astOperand1() [DacaWrongData] pcb-20140316/src/hid/gtk/gui-top-window.c:1708:1: error: There is an unknown macro here somewhere. Configuration is required. If REGISTER_ATTRIBUTES is a macro then please configure it. [unknownMacro] pcb-20140316/src/hid/gtk/gui-library-window.c:227:22: style: Local variable 'library_window' shadows outer variable [shadowVariable] pcb-20140316/src/hid/gtk/gui-library-window.c:70:19: note: Shadowed declaration pcb-20140316/src/hid/gtk/gui-library-window.c:227:22: note: Shadow variable pcb-20140316/src/hid/gtk/gui-library-window.c:368:22: style: Local variable 'library_window' shadows outer variable [shadowVariable] pcb-20140316/src/hid/gtk/gui-library-window.c:70:19: note: Shadowed declaration pcb-20140316/src/hid/gtk/gui-library-window.c:368:22: note: Shadow variable pcb-20140316/src/hid/gtk/gui-library-window.c:431:22: style: Local variable 'library_window' shadows outer variable [shadowVariable] pcb-20140316/src/hid/gtk/gui-library-window.c:70:19: note: Shadowed declaration pcb-20140316/src/hid/gtk/gui-library-window.c:431:22: note: Shadow variable pcb-20140316/src/hid/gtk/gui-library-window.c:472:22: style: Local variable 'library_window' shadows outer variable [shadowVariable] pcb-20140316/src/hid/gtk/gui-library-window.c:70:19: note: Shadowed declaration pcb-20140316/src/hid/gtk/gui-library-window.c:472:22: note: Shadow variable pcb-20140316/src/hid/gtk/gui-library-window.c:511:22: style: Local variable 'library_window' shadows outer variable [shadowVariable] pcb-20140316/src/hid/gtk/gui-library-window.c:70:19: note: Shadowed declaration pcb-20140316/src/hid/gtk/gui-library-window.c:511:22: note: Shadow variable pcb-20140316/src/hid/gtk/gui-library-window.c:789:22: style: Local variable 'library_window' shadows outer variable [shadowVariable] pcb-20140316/src/hid/gtk/gui-library-window.c:70:19: note: Shadowed declaration pcb-20140316/src/hid/gtk/gui-library-window.c:789:22: note: Shadow variable pcb-20140316/src/hid/gtk/gui-library-window.c:875:22: style: Local variable 'library_window' shadows outer variable [shadowVariable] pcb-20140316/src/hid/gtk/gui-library-window.c:70:19: note: Shadowed declaration pcb-20140316/src/hid/gtk/gui-library-window.c:875:22: note: Shadow variable pcb-20140316/src/hid/gtk/gui-output-events.c:454:43: style: Condition 'netname!=NULL' is always false [knownConditionTrueFalse] pcb-20140316/src/hid/gtk/gui-output-events.c:444:17: note: Assuming that condition 'netname!=NULL' is not redundant pcb-20140316/src/hid/gtk/gui-output-events.c:454:43: note: Condition 'netname!=NULL' is always false pcb-20140316/src/hid/gtk/gui-pinout-window.c:58:56: style:inconclusive: Function 'ghid_pinout_window_show' argument 2 names different: declaration 'Element' definition 'element'. [funcArgNamesDifferent] pcb-20140316/src/hid/gtk/gui.h:470:59: note: Function 'ghid_pinout_window_show' argument 2 names different: declaration 'Element' definition 'element'. pcb-20140316/src/hid/gtk/gui-pinout-window.c:58:56: note: Function 'ghid_pinout_window_show' argument 2 names different: declaration 'Element' definition 'element'. pcb-20140316/src/hid/lesstif/library.c:68:9: style: Local variable 'args' shadows outer variable [shadowVariable] pcb-20140316/src/hid/lesstif/library.c:27:12: note: Shadowed declaration pcb-20140316/src/hid/lesstif/library.c:68:9: note: Shadow variable pcb-20140316/src/hid/gtk/gui-config.c:546:12: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] pcb-20140316/src/hid/gtk/gui-config.c:644:5: style: Statements following return, break, continue, goto or throw will never be executed. [unreachableCode] pcb-20140316/src/hid/gtk/gui-netlist-window.c:887:38: style:inconclusive: Function 'ghid_get_net_from_node_name' argument 1 names different: declaration 'name' definition 'node_name'. [funcArgNamesDifferent] pcb-20140316/src/hid/gtk/gui.h:445:55: note: Function 'ghid_get_net_from_node_name' argument 1 names different: declaration 'name' definition 'node_name'. pcb-20140316/src/hid/gtk/gui-netlist-window.c:887:38: note: Function 'ghid_get_net_from_node_name' argument 1 names different: declaration 'name' definition 'node_name'. pcb-20140316/src/hid/gtk/gui-netlist-window.c:935:38: style:inconclusive: Function 'ghid_netlist_highlight_node' argument 1 names different: declaration 'name' definition 'node_name'. [funcArgNamesDifferent] pcb-20140316/src/hid/gtk/gui.h:446:43: note: Function 'ghid_netlist_highlight_node' argument 1 names different: declaration 'name' definition 'node_name'. pcb-20140316/src/hid/gtk/gui-netlist-window.c:935:38: note: Function 'ghid_netlist_highlight_node' argument 1 names different: declaration 'name' definition 'node_name'. pcb-20140316/src/hid/lesstif/menu.c:721:1: error: There is an unknown macro here somewhere. Configuration is required. If REGISTER_ACTIONS is a macro then please configure it. [unknownMacro] pcb-20140316/src/hid/gtk/gui-utils.c:151:35: style:inconclusive: Function 'ghid_draw_area_update' argument 1 names different: declaration 'out' definition 'port'. [funcArgNamesDifferent] pcb-20140316/src/hid/gtk/gui.h:361:40: note: Function 'ghid_draw_area_update' argument 1 names different: declaration 'out' definition 'port'. pcb-20140316/src/hid/gtk/gui-utils.c:151:35: note: Function 'ghid_draw_area_update' argument 1 names different: declaration 'out' definition 'port'. pcb-20140316/src/hid/gtk/gui-utils.c:401:37: style:inconclusive: Function 'ghid_table_spin_button' argument 1 names different: declaration 'box' definition 'table'. [funcArgNamesDifferent] pcb-20140316/src/hid/gtk/gui.h:388:42: note: Function 'ghid_table_spin_button' argument 1 names different: declaration 'box' definition 'table'. pcb-20140316/src/hid/gtk/gui-utils.c:401:37: note: Function 'ghid_table_spin_button' argument 1 names different: declaration 'box' definition 'table'. pcb-20140316/src/hid/gtk/gui-utils.c:83:45: style: Parameter 'state' can be declared with const [constParameter] pcb-20140316/src/hid/gtk/gui-utils.c:121:38: style: Parameter 'state' can be declared with const [constParameter] pcb-20140316/src/hid/gtk/gui-utils.c:768:59: style: Parameter 'string' can be declared with const [constParameter] pcb-20140316/src/hid/lesstif/netlist.c:321:13: style: Variable 'b_rat_off' is assigned a value that is never used. [unreadVariable] pcb-20140316/src/hid/lesstif/netlist.c:342:11: style: Variable 'b_ripup' is assigned a value that is never used. [unreadVariable] pcb-20140316/src/hid/lesstif/styles.c:447:3: error: Common realloc mistake: 'style_button_list' nulled but not freed upon failure [memleakOnRealloc] pcb-20140316/src/hid/lesstif/styles.c:136:10: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-20140316/src/hid/lesstif/styles.c:47:12: note: Shadowed declaration pcb-20140316/src/hid/lesstif/styles.c:136:10: note: Shadow variable pcb-20140316/src/hid/lesstif/styles.c:159:9: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-20140316/src/hid/lesstif/styles.c:47:12: note: Shadowed declaration pcb-20140316/src/hid/lesstif/styles.c:159:9: note: Shadow variable pcb-20140316/src/hid/lesstif/styles.c:262:10: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-20140316/src/hid/lesstif/styles.c:47:12: note: Shadowed declaration pcb-20140316/src/hid/lesstif/styles.c:262:10: note: Shadow variable pcb-20140316/src/hid/lesstif/main.c:2021:10: warning: Either the condition '(nbytes=read(*fid,buf,BUFSIZ))==-1' is redundant or the array 'buf[0]' is accessed at index -1, which is out of bounds. [negativeIndex] pcb-20140316/src/hid/lesstif/main.c:2016:43: note: Assuming that condition '(nbytes=read(*fid,buf,BUFSIZ))==-1' is not redundant pcb-20140316/src/hid/lesstif/main.c:2021:10: note: Negative array index pcb-20140316/src/hid/lesstif/dialogs.c:1760:2: error: Common realloc mistake: 'attr_row' nulled but not freed upon failure [memleakOnRealloc] pcb-20140316/src/hid/lesstif/dialogs.c:480:53: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-20140316/src/hid/lesstif/dialogs.c:764:22: style: Local variable 'empty' shadows outer variable [shadowVariable] pcb-20140316/src/hid/lesstif/dialogs.c:642:19: note: Shadowed declaration pcb-20140316/src/hid/lesstif/dialogs.c:764:22: note: Shadow variable pcb-20140316/src/hid/lesstif/dialogs.c:946:16: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-20140316/src/hid/lesstif/dialogs.c:30:12: note: Shadowed declaration pcb-20140316/src/hid/lesstif/dialogs.c:946:16: note: Shadow variable pcb-20140316/src/hid/lesstif/dialogs.c:979:7: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-20140316/src/hid/lesstif/dialogs.c:30:12: note: Shadowed declaration pcb-20140316/src/hid/lesstif/dialogs.c:979:7: note: Shadow variable pcb-20140316/src/hid/lesstif/dialogs.c:1057:7: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-20140316/src/hid/lesstif/dialogs.c:30:12: note: Shadowed declaration pcb-20140316/src/hid/lesstif/dialogs.c:1057:7: note: Shadow variable pcb-20140316/src/hid/lesstif/dialogs.c:1454:13: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-20140316/src/hid/lesstif/dialogs.c:30:12: note: Shadowed declaration pcb-20140316/src/hid/lesstif/dialogs.c:1454:13: note: Shadow variable pcb-20140316/src/hid/lesstif/dialogs.c:1840:10: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-20140316/src/hid/lesstif/dialogs.c:30:12: note: Shadowed declaration pcb-20140316/src/hid/lesstif/dialogs.c:1840:10: note: Shadow variable pcb-20140316/src/hid/ps/eps.c:523:33: style:inconclusive: Function 'eps_set_draw_xor' argument 2 names different: declaration '_xor' definition 'xor_'. [funcArgNamesDifferent] pcb-20140316/src/hid/ps/eps.c:43:45: note: Function 'eps_set_draw_xor' argument 2 names different: declaration '_xor' definition 'xor_'. pcb-20140316/src/hid/ps/eps.c:523:33: note: Function 'eps_set_draw_xor' argument 2 names different: declaration '_xor' definition 'xor_'. pcb-20140316/src/hid/ps/ps_lists.h:2:1: debug: Wrong data detected by condition !tok->next()->astOperand1() [DacaWrongData] pcb-20140316/src/hid/ps/ps.c:462:39: style: Obsolete function 'asctime' called. It is recommended to use 'strftime' instead. [prohibitedasctimeCalled] pcb-20140316/src/hid/ps/ps.c:462:48: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] pcb-20140316/src/hid/ps/ps.c:832:59: style: Obsolete function 'asctime' called. It is recommended to use 'strftime' instead. [prohibitedasctimeCalled] pcb-20140316/src/hid/ps/ps.c:832:68: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] pcb-20140316/src/hid/ps/ps.c:1049:7: warning: %x in format string (no. 1) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int] pcb-20140316/src/hid/ps/ps.c:1049:7: warning: %x in format string (no. 2) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int] pcb-20140316/src/hid/ps/ps.c:1049:7: warning: %x in format string (no. 3) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int] pcb-20140316/src/hid/lesstif/main.c:3072:7: style: Condition '!use_xrender' is always true [knownConditionTrueFalse] pcb-20140316/src/hid/png/png.c:1290:5: warning: Either the condition 'photo_im==NULL' is redundant or there is possible null pointer dereference: photo_im. [nullPointerRedundantCheck] pcb-20140316/src/hid/png/png.c:1291:24: note: Assuming that condition 'photo_im==NULL' is not redundant pcb-20140316/src/hid/png/png.c:1290:5: note: Null pointer dereference pcb-20140316/src/intersect.c:303:17: style:inconclusive: Function 'nextpwrof2' argument 1 names different: declaration 'i' definition 'n'. [funcArgNamesDifferent] pcb-20140316/src/intersect.c:57:28: note: Function 'nextpwrof2' argument 1 names different: declaration 'i' definition 'n'. pcb-20140316/src/intersect.c:303:17: note: Function 'nextpwrof2' argument 1 names different: declaration 'i' definition 'n'. pcb-20140316/src/hid/png/png.c:1179:8: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] pcb-20140316/src/hid/png/png.c:1185:3: note: Found duplicate branches for 'if' and 'else'. pcb-20140316/src/hid/png/png.c:1179:8: note: Found duplicate branches for 'if' and 'else'. pcb-20140316/src/hid/png/png.c:682:3: style: Checking if unsigned expression 'dest->r' is less than zero. [unsignedLessThanZero] pcb-20140316/src/hid/png/png.c:683:3: style: Checking if unsigned expression 'dest->g' is less than zero. [unsignedLessThanZero] pcb-20140316/src/hid/png/png.c:684:3: style: Checking if unsigned expression 'dest->b' is less than zero. [unsignedLessThanZero] pcb-20140316/src/hid/png/png.c:611:8: style: Local variable 'i' shadows outer variable [shadowVariable] pcb-20140316/src/hid/png/png.c:557:7: note: Shadowed declaration pcb-20140316/src/hid/png/png.c:611:8: note: Shadow variable pcb-20140316/src/hid/png/png.c:658:11: style: Local variable 'i' shadows outer variable [shadowVariable] pcb-20140316/src/hid/png/png.c:557:7: note: Shadowed declaration pcb-20140316/src/hid/png/png.c:658:11: note: Shadow variable pcb-20140316/src/hid/png/png.c:1002:20: style: Local variable 'white' shadows outer variable [shadowVariable] pcb-20140316/src/hid/png/png.c:108:37: note: Shadowed declaration pcb-20140316/src/hid/png/png.c:1002:20: note: Shadow variable pcb-20140316/src/hid/png/png.c:1002:27: style: Local variable 'black' shadows outer variable [shadowVariable] pcb-20140316/src/hid/png/png.c:108:22: note: Shadowed declaration pcb-20140316/src/hid/png/png.c:1002:27: note: Shadow variable pcb-20140316/src/hid/png/png.c:1015:6: style: Local variable 'black' shadows outer variable [shadowVariable] pcb-20140316/src/hid/png/png.c:1002:27: note: Shadowed declaration pcb-20140316/src/hid/png/png.c:1015:6: note: Shadow variable pcb-20140316/src/hid/png/png.c:1289:25: style: Local variable 'black' shadows outer variable [shadowVariable] pcb-20140316/src/hid/png/png.c:108:22: note: Shadowed declaration pcb-20140316/src/hid/png/png.c:1289:25: note: Shadow variable pcb-20140316/src/hid/png/png.c:1289:40: style: Local variable 'white' shadows outer variable [shadowVariable] pcb-20140316/src/hid/png/png.c:108:37: note: Shadowed declaration pcb-20140316/src/hid/png/png.c:1289:40: note: Shadow variable pcb-20140316/src/hid/png/png.c:1785:50: style: Parameter 'x' can be declared with const [constParameter] pcb-20140316/src/hid/lesstif/main.c:2343:7: error: Common realloc mistake: 'points' nulled but not freed upon failure [memleakOnRealloc] pcb-20140316/src/hid/lesstif/main.c:3433:2: error: Common realloc mistake: 'p' nulled but not freed upon failure [memleakOnRealloc] pcb-20140316/src/hid/lesstif/main.c:2413:18: style: Redundant initialization for 'this_state'. The initialized value is overwritten before it is read. [redundantInitialization] pcb-20140316/src/hid/lesstif/main.c:2402:18: note: this_state is initialized pcb-20140316/src/hid/lesstif/main.c:2413:18: note: this_state is overwritten pcb-20140316/src/hid/lesstif/main.c:1218:17: style:inconclusive: Function 'zoom_to' argument 1 names different: declaration 'factor' definition 'new_zoom'. [funcArgNamesDifferent] pcb-20140316/src/hid/lesstif/main.c:238:29: note: Function 'zoom_to' argument 1 names different: declaration 'factor' definition 'new_zoom'. pcb-20140316/src/hid/lesstif/main.c:1218:17: note: Function 'zoom_to' argument 1 names different: declaration 'factor' definition 'new_zoom'. pcb-20140316/src/hid/lesstif/main.c:2290:7: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-20140316/src/hid/lesstif/main.c:184:12: note: Shadowed declaration pcb-20140316/src/hid/lesstif/main.c:2290:7: note: Shadow variable pcb-20140316/src/hid/lesstif/main.c:2829:14: style: Local variable 'bg' shadows outer variable [shadowVariable] pcb-20140316/src/hid/lesstif/main.c:967:16: note: Shadowed declaration pcb-20140316/src/hid/lesstif/main.c:2829:14: note: Shadow variable pcb-20140316/src/hid/lesstif/main.c:3003:11: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-20140316/src/hid/lesstif/main.c:184:12: note: Shadowed declaration pcb-20140316/src/hid/lesstif/main.c:3003:11: note: Shadow variable pcb-20140316/src/hid/lesstif/main.c:2037:7: style: Unused variable: render_event [unusedVariable] pcb-20140316/src/hid/lesstif/main.c:2037:21: style: Unused variable: render_error [unusedVariable] pcb-20140316/src/main.c:1237:0: error: failed to expand 'SSET', it is invalid to use a preprocessor directive as macro parameter [preprocessorErrorDirective] pcb-20140316/src/misc.c:2268:0: error: #error "Don't know how to create a directory on this system." [preprocessorErrorDirective] pcb-20140316/src/mirror.c:66:20: warning: Redundant assignment of 'line->Point1.X' to itself. [selfAssignment] pcb-20140316/src/mirror.c:68:20: warning: Redundant assignment of 'line->Point2.X' to itself. [selfAssignment] pcb-20140316/src/mirror.c:75:12: warning: Redundant assignment of 'pin->X' to itself. [selfAssignment] pcb-20140316/src/mirror.c:82:19: warning: Redundant assignment of 'pad->Point1.X' to itself. [selfAssignment] pcb-20140316/src/mirror.c:84:19: warning: Redundant assignment of 'pad->Point2.X' to itself. [selfAssignment] pcb-20140316/src/mirror.c:91:12: warning: Redundant assignment of 'arc->X' to itself. [selfAssignment] pcb-20140316/src/mirror.c:99:13: warning: Redundant assignment of 'text->X' to itself. [selfAssignment] pcb-20140316/src/mirror.c:104:18: warning: Redundant assignment of 'Element->MarkX' to itself. [selfAssignment] pcb-20140316/src/mtspace.c:534:19: style: Local variable 'temporary' shadows outer variable [shadowVariable] pcb-20140316/src/mtspace.c:488:22: note: Shadowed declaration pcb-20140316/src/mtspace.c:534:19: note: Shadow variable pcb-20140316/src/mtspace.c:433:57: style: Parameter 'desired' can be declared with const [constParameter] pcb-20140316/src/move.c:584:3: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] pcb-20140316/src/netlist.c:274:11: style: Variable 'pin' is assigned a value that is never used. [unreadVariable] pcb-20140316/src/move.c:716:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/mymem.c:79:7: error: Common realloc mistake: 'ptr' nulled but not freed upon failure [memleakOnRealloc] parse_l.l:350:11: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] parse_l.l:351:7: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] pcb-20140316/src/pcb-printf.c:142:42: style:inconclusive: Function 'get_unit_struct' argument 1 names different: declaration 'suffix' definition 'const_suffix'. [funcArgNamesDifferent] pcb-20140316/src/pcb-printf.h:157:42: note: Function 'get_unit_struct' argument 1 names different: declaration 'suffix' definition 'const_suffix'. pcb-20140316/src/pcb-printf.c:142:42: note: Function 'get_unit_struct' argument 1 names different: declaration 'suffix' definition 'const_suffix'. parse_l.l:292:2: error: Returning/dereferencing 'yyin' after it is deallocated / released [deallocret] parse_l.l:291:11: note: Returning/dereferencing 'yyin' after it is deallocated / released parse_l.l:292:2: note: Returning/dereferencing 'yyin' after it is deallocated / released pcb-20140316/src/pcb-printf.c:641:23: style:inconclusive: Function 'pcb_fprintf' argument 1 names different: declaration 'f' definition 'fh'. [funcArgNamesDifferent] pcb-20140316/src/pcb-printf.h:165:23: note: Function 'pcb_fprintf' argument 1 names different: declaration 'f' definition 'fh'. pcb-20140316/src/pcb-printf.c:641:23: note: Function 'pcb_fprintf' argument 1 names different: declaration 'f' definition 'fh'. parse_l.c:1458:27: warning: Possible null pointer dereference: b [nullPointer] parse_l.c:1455:24: note: Assignment 'b=(yy_buffer_stack)?(yy_buffer_stack)[yy_buffer_stack_top]:NULL', assigned value is 0 parse_l.c:1458:27: note: Null pointer dereference pcb-20140316/src/pcb-printf.c:283:36: style: Parameter 'coord' can be declared with const [constParameter] parse_l.c:1460:9: warning: Possible null pointer dereference: b [nullPointer] parse_l.c:1455:24: note: Assignment 'b=(yy_buffer_stack)?(yy_buffer_stack)[yy_buffer_stack_top]:NULL', assigned value is 0 parse_l.c:1460:9: note: Null pointer dereference parse_l.c:1836:2: warning: Possible null pointer dereference: b [nullPointer] parse_l.c:1725:17: note: Calling function 'yy_init_buffer', 1st argument '(yy_buffer_stack)?(yy_buffer_stack)[yy_buffer_stack_top]:NULL' value is 0 parse_l.c:1836:2: note: Null pointer dereference parse_l.c:1837:2: warning: Possible null pointer dereference: b [nullPointer] parse_l.c:1725:17: note: Calling function 'yy_init_buffer', 1st argument '(yy_buffer_stack)?(yy_buffer_stack)[yy_buffer_stack_top]:NULL' value is 0 parse_l.c:1837:2: note: Null pointer dereference parse_l.c:1492:3: style: Redundant initialization for 'c'. The initialized value is overwritten before it is read. [redundantInitialization] parse_l.c:1492:3: note: c is initialized parse_l.c:1492:3: note: c is overwritten parse_l.c:1568:59: style:inconclusive: Function 'yy_try_NUL_trans' argument 1 names different: declaration 'current_state' definition 'yy_current_state'. [funcArgNamesDifferent] parse_l.c:361:54: note: Function 'yy_try_NUL_trans' argument 1 names different: declaration 'current_state' definition 'yy_current_state'. parse_l.c:1568:59: note: Function 'yy_try_NUL_trans' argument 1 names different: declaration 'current_state' definition 'yy_current_state'. parse_l.c:1591:49: style:inconclusive: Function 'yyunput' argument 2 names different: declaration 'buf_ptr' definition 'yy_bp'. [funcArgNamesDifferent] parse_l.c:740:38: note: Function 'yyunput' argument 2 names different: declaration 'buf_ptr' definition 'yy_bp'. parse_l.c:1591:49: note: Function 'yyunput' argument 2 names different: declaration 'buf_ptr' definition 'yy_bp'. parse_l.c:2021:48: style:inconclusive: Function 'yy_scan_string' argument 1 names different: declaration 'yy_str' definition 'yystr'. [funcArgNamesDifferent] parse_l.c:314:47: note: Function 'yy_scan_string' argument 1 names different: declaration 'yy_str' definition 'yystr'. parse_l.c:2021:48: note: Function 'yy_scan_string' argument 1 names different: declaration 'yy_str' definition 'yystr'. parse_l.c:2034:48: style:inconclusive: Function 'yy_scan_bytes' argument 1 names different: declaration 'bytes' definition 'yybytes'. [funcArgNamesDifferent] parse_l.c:315:46: note: Function 'yy_scan_bytes' argument 1 names different: declaration 'bytes' definition 'yybytes'. parse_l.c:2034:48: note: Function 'yy_scan_bytes' argument 1 names different: declaration 'bytes' definition 'yybytes'. parse_l.c:2034:62: style:inconclusive: Function 'yy_scan_bytes' argument 2 names different: declaration 'len' definition '_yybytes_len'. [funcArgNamesDifferent] parse_l.c:315:56: note: Function 'yy_scan_bytes' argument 2 names different: declaration 'len' definition '_yybytes_len'. parse_l.c:2034:62: note: Function 'yy_scan_bytes' argument 2 names different: declaration 'len' definition '_yybytes_len'. parse_l.c:2166:24: style:inconclusive: Function 'yyset_debug' argument 1 names different: declaration 'debug_flag' definition 'bdebug'. [funcArgNamesDifferent] parse_l.c:706:23: note: Function 'yyset_debug' argument 1 names different: declaration 'debug_flag' definition 'bdebug'. parse_l.c:2166:24: note: Function 'yyset_debug' argument 1 names different: declaration 'debug_flag' definition 'bdebug'. parse_l.c:2034:48: style: Parameter 'yybytes' can be declared with const [constParameter] pcb-20140316/src/polygon.c:497:12: style: Condition 'thick>0' is always true [knownConditionTrueFalse] pcb-20140316/src/polygon.c:484:13: note: Assuming condition 'thick<=0' is false pcb-20140316/src/polygon.c:497:12: note: Condition 'thick>0' is always true pcb-20140316/src/polygon.c:1888:3: warning: %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] pcb-20140316/src/polygon.c:1893:7: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] pcb-20140316/src/polygon.c:1895:9: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] pcb-20140316/src/polygon.c:1895:9: warning: %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] pcb-20140316/src/polygon.c:547:20: style:inconclusive: Function 'ArcPoly' argument 1 names different: declaration 'l' definition 'a'. [funcArgNamesDifferent] pcb-20140316/src/polygon.h:75:29: note: Function 'ArcPoly' argument 1 names different: declaration 'l' definition 'a'. pcb-20140316/src/polygon.c:547:20: note: Function 'ArcPoly' argument 1 names different: declaration 'l' definition 'a'. pcb-20140316/src/polygon.c:577:22: style:inconclusive: Function 'LinePoly' argument 1 names different: declaration 'l' definition 'L'. [funcArgNamesDifferent] pcb-20140316/src/polygon.h:74:31: note: Function 'LinePoly' argument 1 names different: declaration 'l' definition 'L'. pcb-20140316/src/polygon.c:577:22: note: Function 'LinePoly' argument 1 names different: declaration 'l' definition 'L'. pcb-20140316/src/polygon.c:757:20: style:inconclusive: Function 'PinPoly' argument 1 names different: declaration 'l' definition 'pin'. [funcArgNamesDifferent] pcb-20140316/src/polygon.h:76:29: note: Function 'PinPoly' argument 1 names different: declaration 'l' definition 'pin'. pcb-20140316/src/polygon.c:757:20: note: Function 'PinPoly' argument 1 names different: declaration 'l' definition 'pin'. pcb-20140316/src/polygon.c:779:37: style:inconclusive: Function 'BoxPolyBloated' argument 2 names different: declaration 'radius' definition 'bloat'. [funcArgNamesDifferent] pcb-20140316/src/polygon.h:77:48: note: Function 'BoxPolyBloated' argument 2 names different: declaration 'radius' definition 'bloat'. pcb-20140316/src/polygon.c:779:37: note: Function 'BoxPolyBloated' argument 2 names different: declaration 'radius' definition 'bloat'. pcb-20140316/src/polygon.c:1212:21: style:inconclusive: Function 'InitClip' argument 1 names different: declaration 'd' definition 'Data'. [funcArgNamesDifferent] pcb-20140316/src/polygon.h:79:24: note: Function 'InitClip' argument 1 names different: declaration 'd' definition 'Data'. pcb-20140316/src/polygon.c:1212:21: note: Function 'InitClip' argument 1 names different: declaration 'd' definition 'Data'. pcb-20140316/src/polygon.c:1212:38: style:inconclusive: Function 'InitClip' argument 2 names different: declaration 'l' definition 'layer'. [funcArgNamesDifferent] pcb-20140316/src/polygon.h:79:38: note: Function 'InitClip' argument 2 names different: declaration 'l' definition 'layer'. pcb-20140316/src/polygon.c:1212:38: note: Function 'InitClip' argument 2 names different: declaration 'l' definition 'layer'. pcb-20140316/src/polygon.c:1429:28: style:inconclusive: Function 'PolygonHoles' argument 1 names different: declaration 'ptr' definition 'polygon'. [funcArgNamesDifferent] pcb-20140316/src/polygon.h:62:32: note: Function 'PolygonHoles' argument 1 names different: declaration 'ptr' definition 'polygon'. pcb-20140316/src/polygon.c:1429:28: note: Function 'PolygonHoles' argument 1 names different: declaration 'ptr' definition 'polygon'. pcb-20140316/src/polygon.c:795:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/polygon.c:910:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/polygon.c:577:22: style: Parameter 'L' can be declared with const [constParameter] parse_y.c:1392:47: warning: Either the condition 'yytype<52' is redundant or the array 'yytname[159]' is accessed at index 159, which is out of bounds. [arrayIndexOutOfBoundsCond] parse_y.c:1389:14: note: Assuming that condition 'yytype<52' is not redundant parse_y.c:1392:47: note: Array index out of bounds pcb-20140316/src/polygon1.c:399:11: warning: Either the condition 'l' is redundant or there is possible null pointer dereference: l. [nullPointerRedundantCheck] pcb-20140316/src/polygon1.c:403:11: note: Assuming that condition 'l' is not redundant pcb-20140316/src/polygon1.c:399:11: note: Null pointer dereference pcb-20140316/src/polygon1.c:401:11: warning: Either the condition 'l' is redundant or there is possible null pointer dereference: l. [nullPointerRedundantCheck] pcb-20140316/src/polygon1.c:403:11: note: Assuming that condition 'l' is not redundant pcb-20140316/src/polygon1.c:401:11: note: Null pointer dereference pcb-20140316/src/polygon1.c:1134:13: style: Redundant initialization for 'curc'. The initialized value is overwritten before it is read. [redundantInitialization] pcb-20140316/src/polygon1.c:1132:15: note: curc is initialized pcb-20140316/src/polygon1.c:1134:13: note: curc is overwritten pcb-20140316/src/polygon1.c:2258:22: style:inconclusive: Function 'Touching' argument 1 names different: declaration 'p1' definition 'a'. [funcArgNamesDifferent] pcb-20140316/src/polyarea.h:150:26: note: Function 'Touching' argument 1 names different: declaration 'p1' definition 'a'. pcb-20140316/src/polygon1.c:2258:22: note: Function 'Touching' argument 1 names different: declaration 'p1' definition 'a'. pcb-20140316/src/polygon1.c:2258:36: style:inconclusive: Function 'Touching' argument 2 names different: declaration 'p2' definition 'b'. [funcArgNamesDifferent] pcb-20140316/src/polyarea.h:150:40: note: Function 'Touching' argument 2 names different: declaration 'p2' definition 'b'. pcb-20140316/src/polygon1.c:2258:36: note: Function 'Touching' argument 2 names different: declaration 'p2' definition 'b'. pcb-20140316/src/polygon1.c:2285:32: style:inconclusive: Function 'poly_Boolean' argument 1 names different: declaration 'a' definition 'a_org'. [funcArgNamesDifferent] pcb-20140316/src/polyarea.h:182:35: note: Function 'poly_Boolean' argument 1 names different: declaration 'a' definition 'a_org'. pcb-20140316/src/polygon1.c:2285:32: note: Function 'poly_Boolean' argument 1 names different: declaration 'a' definition 'a_org'. pcb-20140316/src/polygon1.c:2285:56: style:inconclusive: Function 'poly_Boolean' argument 2 names different: declaration 'b' definition 'b_org'. [funcArgNamesDifferent] pcb-20140316/src/polyarea.h:182:55: note: Function 'poly_Boolean' argument 2 names different: declaration 'b' definition 'b_org'. pcb-20140316/src/polygon1.c:2285:56: note: Function 'poly_Boolean' argument 2 names different: declaration 'b' definition 'b_org'. pcb-20140316/src/polygon1.c:2298:31: style:inconclusive: Function 'poly_Boolean_free' argument 1 names different: declaration 'a' definition 'ai'. [funcArgNamesDifferent] pcb-20140316/src/polyarea.h:183:34: note: Function 'poly_Boolean_free' argument 1 names different: declaration 'a' definition 'ai'. pcb-20140316/src/polygon1.c:2298:31: note: Function 'poly_Boolean_free' argument 1 names different: declaration 'a' definition 'ai'. pcb-20140316/src/polygon1.c:2298:46: style:inconclusive: Function 'poly_Boolean_free' argument 2 names different: declaration 'b' definition 'bi'. [funcArgNamesDifferent] pcb-20140316/src/polyarea.h:183:48: note: Function 'poly_Boolean_free' argument 2 names different: declaration 'b' definition 'bi'. pcb-20140316/src/polygon1.c:2298:46: note: Function 'poly_Boolean_free' argument 2 names different: declaration 'b' definition 'bi'. pcb-20140316/src/polygon1.c:2413:35: style:inconclusive: Function 'poly_AndSubtract_free' argument 1 names different: declaration 'a' definition 'ai'. [funcArgNamesDifferent] pcb-20140316/src/polyarea.h:184:38: note: Function 'poly_AndSubtract_free' argument 1 names different: declaration 'a' definition 'ai'. pcb-20140316/src/polygon1.c:2413:35: note: Function 'poly_AndSubtract_free' argument 1 names different: declaration 'a' definition 'ai'. pcb-20140316/src/polygon1.c:2413:50: style:inconclusive: Function 'poly_AndSubtract_free' argument 2 names different: declaration 'b' definition 'bi'. [funcArgNamesDifferent] pcb-20140316/src/polyarea.h:184:52: note: Function 'poly_AndSubtract_free' argument 2 names different: declaration 'b' definition 'bi'. pcb-20140316/src/polygon1.c:2413:50: note: Function 'poly_AndSubtract_free' argument 2 names different: declaration 'b' definition 'bi'. pcb-20140316/src/polygon1.c:2587:26: style:inconclusive: Function 'poly_PreContour' argument 1 names different: declaration 'c' definition 'C'. [funcArgNamesDifferent] pcb-20140316/src/polyarea.h:119:30: note: Function 'poly_PreContour' argument 1 names different: declaration 'c' definition 'C'. pcb-20140316/src/polygon1.c:2587:26: note: Function 'poly_PreContour' argument 1 names different: declaration 'c' definition 'C'. pcb-20140316/src/polygon1.c:2892:39: style:inconclusive: Function 'poly_InsideContour' argument 2 names different: declaration 'v' definition 'p'. [funcArgNamesDifferent] pcb-20140316/src/polyarea.h:159:41: note: Function 'poly_InsideContour' argument 2 names different: declaration 'v' definition 'p'. pcb-20140316/src/polygon1.c:2892:39: note: Function 'poly_InsideContour' argument 2 names different: declaration 'v' definition 'p'. pcb-20140316/src/polygon1.c:2910:30: style:inconclusive: Function 'poly_CheckInside' argument 1 names different: declaration 'c' definition 'p'. [funcArgNamesDifferent] pcb-20140316/src/polyarea.h:149:35: note: Function 'poly_CheckInside' argument 1 names different: declaration 'c' definition 'p'. pcb-20140316/src/polygon1.c:2910:30: note: Function 'poly_CheckInside' argument 1 names different: declaration 'c' definition 'p'. pcb-20140316/src/polygon1.c:3118:29: style:inconclusive: Function 'poly_FreeContours' argument 1 names different: declaration 'pl' definition 'pline'. [funcArgNamesDifferent] pcb-20140316/src/polyarea.h:165:32: note: Function 'poly_FreeContours' argument 1 names different: declaration 'pl' definition 'pline'. pcb-20140316/src/polygon1.c:3118:29: note: Function 'poly_FreeContours' argument 1 names different: declaration 'pl' definition 'pline'. pcb-20140316/src/polygon1.c:3328:18: warning: Function 'vect_sub' argument order different: declaration 'res, v2, v3' definition 'res, v1, v2' [funcArgOrderDifferent] pcb-20140316/src/polygon1.c:65:23: note: Function 'vect_sub' argument order different: declaration 'res, v2, v3' definition 'res, v1, v2' pcb-20140316/src/polygon1.c:3328:18: note: Function 'vect_sub' argument order different: declaration 'res, v2, v3' definition 'res, v1, v2' pcb-20140316/src/polygon1.c:3333:18: style:inconclusive: Function 'vect_min' argument 1 names different: declaration 'res' definition 'v1'. [funcArgNamesDifferent] pcb-20140316/src/polygon1.c:67:23: note: Function 'vect_min' argument 1 names different: declaration 'res' definition 'v1'. pcb-20140316/src/polygon1.c:3333:18: note: Function 'vect_min' argument 1 names different: declaration 'res' definition 'v1'. pcb-20140316/src/polygon1.c:3340:18: style:inconclusive: Function 'vect_max' argument 1 names different: declaration 'res' definition 'v1'. [funcArgNamesDifferent] pcb-20140316/src/polygon1.c:68:23: note: Function 'vect_max' argument 1 names different: declaration 'res' definition 'v1'. pcb-20140316/src/polygon1.c:3340:18: note: Function 'vect_max' argument 1 names different: declaration 'res' definition 'v1'. pcb-20140316/src/polygon1.c:3347:19: style:inconclusive: Function 'vect_len2' argument 1 names different: declaration 'v1' definition 'v'. [funcArgNamesDifferent] pcb-20140316/src/polyarea.h:177:26: note: Function 'vect_len2' argument 1 names different: declaration 'v1' definition 'v'. pcb-20140316/src/polygon1.c:3347:19: note: Function 'vect_len2' argument 1 names different: declaration 'v1' definition 'v'. pcb-20140316/src/polygon1.c:3391:22: style:inconclusive: Function 'vect_inters2' argument 1 names different: declaration 'A' definition 'p1'. [funcArgNamesDifferent] pcb-20140316/src/polyarea.h:179:26: note: Function 'vect_inters2' argument 1 names different: declaration 'A' definition 'p1'. pcb-20140316/src/polygon1.c:3391:22: note: Function 'vect_inters2' argument 1 names different: declaration 'A' definition 'p1'. pcb-20140316/src/polygon1.c:3391:33: style:inconclusive: Function 'vect_inters2' argument 2 names different: declaration 'B' definition 'p2'. [funcArgNamesDifferent] pcb-20140316/src/polyarea.h:179:36: note: Function 'vect_inters2' argument 2 names different: declaration 'B' definition 'p2'. pcb-20140316/src/polygon1.c:3391:33: note: Function 'vect_inters2' argument 2 names different: declaration 'B' definition 'p2'. pcb-20140316/src/polygon1.c:3391:44: style:inconclusive: Function 'vect_inters2' argument 3 names different: declaration 'C' definition 'q1'. [funcArgNamesDifferent] pcb-20140316/src/polyarea.h:179:46: note: Function 'vect_inters2' argument 3 names different: declaration 'C' definition 'q1'. pcb-20140316/src/polygon1.c:3391:44: note: Function 'vect_inters2' argument 3 names different: declaration 'C' definition 'q1'. pcb-20140316/src/polygon1.c:3391:55: style:inconclusive: Function 'vect_inters2' argument 4 names different: declaration 'D' definition 'q2'. [funcArgNamesDifferent] pcb-20140316/src/polyarea.h:179:56: note: Function 'vect_inters2' argument 4 names different: declaration 'D' definition 'q2'. pcb-20140316/src/polygon1.c:3391:55: note: Function 'vect_inters2' argument 4 names different: declaration 'D' definition 'q2'. pcb-20140316/src/polygon1.c:2068:15: style: Local variable 'prev' shadows outer variable [shadowVariable] pcb-20140316/src/polygon1.c:1981:24: note: Shadowed declaration pcb-20140316/src/polygon1.c:2068:15: note: Shadow variable pcb-20140316/src/polygon1.c:3353:20: style: Parameter 'v1' can be declared with const [constParameter] pcb-20140316/src/polygon1.c:3353:31: style: Parameter 'v2' can be declared with const [constParameter] pcb-20140316/src/polygon1.c:3321:20: style: Parameter 'v1' can be declared with const [constParameter] pcb-20140316/src/print.c:299:45: portability: Non reentrant function 'gmtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'gmtime_r'. [prohibitedgmtimeCalled] pcb-20140316/src/polygon1.c:3321:31: style: Parameter 'v2' can be declared with const [constParameter] pcb-20140316/src/polygon1.c:3328:30: style: Parameter 'v1' can be declared with const [constParameter] pcb-20140316/src/polygon1.c:3328:41: style: Parameter 'v2' can be declared with const [constParameter] pcb-20140316/src/polygon1.c:1498:45: style: Parameter 'cdir' can be declared with const [constParameter] pcb-20140316/src/polygon1.c:1505:45: style: Parameter 'cdir' can be declared with const [constParameter] pcb-20140316/src/polygon1.c:1832:41: style: Parameter 'cur' can be declared with const [constParameter] pcb-20140316/src/polygon1.c:2476:36: style: Parameter 'p' can be declared with const [constParameter] pcb-20140316/src/polygon1.c:2953:27: style: Parameter 'A' can be declared with const [constParameter] pcb-20140316/src/polygon1.c:2953:37: style: Parameter 'B' can be declared with const [constParameter] pcb-20140316/src/polygon1.c:2953:47: style: Parameter 'C' can be declared with const [constParameter] pcb-20140316/src/polygon1.c:2953:57: style: Parameter 'P' can be declared with const [constParameter] pcb-20140316/src/polygon1.c:2987:37: style: Parameter 'A' can be declared with const [constParameter] pcb-20140316/src/polygon1.c:2987:47: style: Parameter 'B' can be declared with const [constParameter] pcb-20140316/src/polygon1.c:2987:57: style: Parameter 'C' can be declared with const [constParameter] pcb-20140316/src/polygon1.c:2987:67: style: Parameter 'D' can be declared with const [constParameter] pcb-20140316/src/polygon1.c:3369:21: style: Parameter 'v1' can be declared with const [constParameter] pcb-20140316/src/polygon1.c:3369:32: style: Parameter 'v2' can be declared with const [constParameter] pcb-20140316/src/polygon1.c:1420:29: error: Uninitialized struct member: info.result [uninitStructMember] pcb-20140316/src/polygon1.c:2093:29: error: Uninitialized struct member: info.result [uninitStructMember] parse_y.y:273:5: style: Obsolescent function 'bzero' called. It is recommended to use 'memset' instead. [prohibitedbzeroCalled] parse_y.y:1695:46: style: Same expression on both sides of '-'. [duplicateExpression] parse_y.y:1702:54: style: Same expression on both sides of '-'. [duplicateExpression] parse_y.y:1922:35: style: Same expression on both sides of '-'. [duplicateExpression] parse_y.y:1936:35: style: Same expression on both sides of '-'. [duplicateExpression] parse_y.y:1943:35: style: Same expression on both sides of '-'. [duplicateExpression] parse_y.y:1950:47: style: Same expression on both sides of '-'. [duplicateExpression] parse_y.c:1605:47: style: Parameter 'yymsg' can be declared with const [constParameter] parse_y.c:1606:31: style: Parameter 'yyssp' can be declared with const [constParameter] parse_y.c:1411:19: style: Parameter 'yytop' can be declared with const [constParameter] pcb-20140316/src/remove.c:486:28: style: Condition 'contour==0' is always false [knownConditionTrueFalse] pcb-20140316/src/remove.c:473:15: note: Assuming condition 'contour==0' is false pcb-20140316/src/remove.c:486:28: note: Condition 'contour==0' is always false pcb-20140316/src/report.c:919:11: style: Condition 'net_found' is always true [knownConditionTrueFalse] pcb-20140316/src/report.c:93:3: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] pcb-20140316/src/report.c:728:40: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-20140316/src/report.c:753:40: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-20140316/src/report.c:570:9: style: Local variable 'l' shadows outer variable [shadowVariable] pcb-20140316/src/report.c:566:3: note: Shadowed declaration pcb-20140316/src/report.c:570:9: note: Shadow variable pcb-20140316/src/report.c:585:9: style: Local variable 'l' shadows outer variable [shadowVariable] pcb-20140316/src/report.c:581:3: note: Shadowed declaration pcb-20140316/src/report.c:585:9: note: Shadow variable pcb-20140316/src/report.c:724:10: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-20140316/src/report.c:717:5: note: Shadowed declaration pcb-20140316/src/report.c:724:10: note: Shadow variable pcb-20140316/src/report.c:749:10: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-20140316/src/report.c:742:5: note: Shadowed declaration pcb-20140316/src/report.c:749:10: note: Shadow variable pcb-20140316/src/report.c:598:39: style: Parameter 'argv' can be declared with const [constParameter] pcb-20140316/src/rats.c:89:24: style: Parameter 'InString' can be declared with const [constParameter] pcb-20140316/src/report.c:789:7: style: Unused variable: result [unusedVariable] res_lex.c:1063:27: warning: Possible null pointer dereference: b [nullPointer] res_lex.c:1060:24: note: Assignment 'b=(yy_buffer_stack)?(yy_buffer_stack)[yy_buffer_stack_top]:NULL', assigned value is 0 res_lex.c:1063:27: note: Null pointer dereference res_lex.c:1065:9: warning: Possible null pointer dereference: b [nullPointer] res_lex.c:1060:24: note: Assignment 'b=(yy_buffer_stack)?(yy_buffer_stack)[yy_buffer_stack_top]:NULL', assigned value is 0 res_lex.c:1065:9: note: Null pointer dereference res_lex.c:1441:2: warning: Possible null pointer dereference: b [nullPointer] res_lex.c:1330:18: note: Calling function 'res_init_buffer', 1st argument '(yy_buffer_stack)?(yy_buffer_stack)[yy_buffer_stack_top]:NULL' value is 0 res_lex.c:1441:2: note: Null pointer dereference res_lex.c:1442:2: warning: Possible null pointer dereference: b [nullPointer] res_lex.c:1330:18: note: Calling function 'res_init_buffer', 1st argument '(yy_buffer_stack)?(yy_buffer_stack)[yy_buffer_stack_top]:NULL' value is 0 res_lex.c:1442:2: note: Null pointer dereference res_parse.c:1096:5: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] res_lex.c:1173:59: style:inconclusive: Function 'yy_try_NUL_trans' argument 1 names different: declaration 'current_state' definition 'yy_current_state'. [funcArgNamesDifferent] res_lex.c:384:54: note: Function 'yy_try_NUL_trans' argument 1 names different: declaration 'current_state' definition 'yy_current_state'. res_lex.c:1173:59: note: Function 'yy_try_NUL_trans' argument 1 names different: declaration 'current_state' definition 'yy_current_state'. res_lex.c:1196:49: style:inconclusive: Function 'yyunput' argument 2 names different: declaration 'buf_ptr' definition 'yy_bp'. [funcArgNamesDifferent] res_lex.c:597:38: note: Function 'yyunput' argument 2 names different: declaration 'buf_ptr' definition 'yy_bp'. res_lex.c:1196:49: note: Function 'yyunput' argument 2 names different: declaration 'buf_ptr' definition 'yy_bp'. res_lex.c:1626:49: style:inconclusive: Function 'res_scan_string' argument 1 names different: declaration 'yy_str' definition 'yystr'. [funcArgNamesDifferent] res_lex.c:334:48: note: Function 'res_scan_string' argument 1 names different: declaration 'yy_str' definition 'yystr'. res_lex.c:1626:49: note: Function 'res_scan_string' argument 1 names different: declaration 'yy_str' definition 'yystr'. res_lex.c:1639:49: style:inconclusive: Function 'res_scan_bytes' argument 1 names different: declaration 'bytes' definition 'yybytes'. [funcArgNamesDifferent] res_lex.c:335:47: note: Function 'res_scan_bytes' argument 1 names different: declaration 'bytes' definition 'yybytes'. res_lex.c:1639:49: note: Function 'res_scan_bytes' argument 1 names different: declaration 'bytes' definition 'yybytes'. res_parse.y:71:51: style: Same expression on both sides of '-'. [duplicateExpression] res_lex.c:1639:63: style:inconclusive: Function 'res_scan_bytes' argument 2 names different: declaration 'len' definition '_yybytes_len'. [funcArgNamesDifferent] res_lex.c:335:57: note: Function 'res_scan_bytes' argument 2 names different: declaration 'len' definition '_yybytes_len'. res_lex.c:1639:63: note: Function 'res_scan_bytes' argument 2 names different: declaration 'len' definition '_yybytes_len'. res_parse.y:78:73: style: Same expression on both sides of '-'. [duplicateExpression] res_lex.c:1771:25: style:inconclusive: Function 'resset_debug' argument 1 names different: declaration 'debug_flag' definition 'bdebug'. [funcArgNamesDifferent] res_lex.c:563:24: note: Function 'resset_debug' argument 1 names different: declaration 'debug_flag' definition 'bdebug'. res_lex.c:1771:25: note: Function 'resset_debug' argument 1 names different: declaration 'debug_flag' definition 'bdebug'. res_parse.y:85:51: style: Same expression on both sides of '-'. [duplicateExpression] res_lex.c:1639:49: style: Parameter 'yybytes' can be declared with const [constParameter] res_parse.y:92:54: style: Same expression on both sides of '-'. [duplicateExpression] res_parse.y:99:76: style: Same expression on both sides of '-'. [duplicateExpression] res_parse.c:948:47: style: Parameter 'yymsg' can be declared with const [constParameter] res_parse.c:949:31: style: Parameter 'yyssp' can be declared with const [constParameter] pcb-20140316/src/puller.c:502:15: style: Variable 'arc_angle' is reassigned a value before the old one has been used. [redundantAssignment] pcb-20140316/src/puller.c:483:15: note: arc_angle is assigned pcb-20140316/src/puller.c:502:15: note: arc_angle is overwritten pcb-20140316/src/puller.c:502:15: style: Variable 'arc_angle' is reassigned a value before the old one has been used. [redundantAssignment] pcb-20140316/src/puller.c:485:15: note: arc_angle is assigned pcb-20140316/src/puller.c:502:15: note: arc_angle is overwritten pcb-20140316/src/puller.c:228:10: style: Local variable 'x' shadows outer variable [shadowVariable] pcb-20140316/src/puller.c:94:12: note: Shadowed declaration pcb-20140316/src/puller.c:228:10: note: Shadow variable pcb-20140316/src/puller.c:228:13: style: Local variable 'y' shadows outer variable [shadowVariable] pcb-20140316/src/puller.c:94:15: note: Shadowed declaration pcb-20140316/src/puller.c:228:13: note: Shadow variable pcb-20140316/src/puller.c:248:10: style: Local variable 'x' shadows outer variable [shadowVariable] pcb-20140316/src/puller.c:94:12: note: Shadowed declaration pcb-20140316/src/puller.c:248:10: note: Shadow variable pcb-20140316/src/puller.c:248:13: style: Local variable 'y' shadows outer variable [shadowVariable] pcb-20140316/src/puller.c:94:15: note: Shadowed declaration pcb-20140316/src/puller.c:248:13: note: Shadow variable pcb-20140316/src/puller.c:1329:7: style: Local variable 'x' shadows outer variable [shadowVariable] pcb-20140316/src/puller.c:94:12: note: Shadowed declaration pcb-20140316/src/puller.c:1329:7: note: Shadow variable pcb-20140316/src/puller.c:1329:10: style: Local variable 'y' shadows outer variable [shadowVariable] pcb-20140316/src/puller.c:94:15: note: Shadowed declaration pcb-20140316/src/puller.c:1329:10: note: Shadow variable pcb-20140316/src/puller.c:2000:7: style: Local variable 'ex' shadows outer variable [shadowVariable] pcb-20140316/src/puller.c:96:12: note: Shadowed declaration pcb-20140316/src/puller.c:2000:7: note: Shadow variable pcb-20140316/src/puller.c:2000:11: style: Local variable 'ey' shadows outer variable [shadowVariable] pcb-20140316/src/puller.c:96:16: note: Shadowed declaration pcb-20140316/src/puller.c:2000:11: note: Shadow variable pcb-20140316/src/puller.c:647:20: style: Parameter 'x' can be declared with const [constParameter] pcb-20140316/src/puller.c:872:8: style: Variable 'hits' is assigned a value that is never used. [unreadVariable] pcb-20140316/src/puller.c:873:8: style: Variable 'hits' is assigned a value that is never used. [unreadVariable] pcb-20140316/src/puller.c:1022:8: style: Variable 'hits' is assigned a value that is never used. [unreadVariable] pcb-20140316/src/puller.c:1023:8: style: Variable 'hits' is assigned a value that is never used. [unreadVariable] pcb-20140316/src/rtree.c:117:31: style: Condition 'node->u.rects[i].bptr' is always true [knownConditionTrueFalse] pcb-20140316/src/rtree.c:111:15: note: Assuming condition '!node->u.rects[i].bptr' is false pcb-20140316/src/rtree.c:117:31: note: Condition 'node->u.rects[i].bptr' is always true pcb-20140316/src/rtree.c:156:27: style: Condition 'node->u.kids[i]' is always true [knownConditionTrueFalse] pcb-20140316/src/rtree.c:145:15: note: Assuming condition '!node->u.kids[i]' is false pcb-20140316/src/rtree.c:156:27: note: Condition 'node->u.kids[i]' is always true pcb-20140316/src/rtree.c:544:44: style:inconclusive: Function 'r_search' argument 2 names different: declaration 'starting_region' definition 'query'. [funcArgNamesDifferent] pcb-20140316/src/rtree.h:65:48: note: Function 'r_search' argument 2 names different: declaration 'starting_region' definition 'query'. pcb-20140316/src/rtree.c:544:44: note: Function 'r_search' argument 2 names different: declaration 'starting_region' definition 'query'. pcb-20140316/src/rtree.c:546:73: style:inconclusive: Function 'r_search' argument 5 names different: declaration 'closure' definition 'cl'. [funcArgNamesDifferent] pcb-20140316/src/rtree.h:68:14: note: Function 'r_search' argument 5 names different: declaration 'closure' definition 'cl'. pcb-20140316/src/rtree.c:546:73: note: Function 'r_search' argument 5 names different: declaration 'closure' definition 'cl'. pcb-20140316/src/rtree.c:974:61: style:inconclusive: Function 'r_insert_entry' argument 3 names different: declaration 'manage' definition 'man'. [funcArgNamesDifferent] pcb-20140316/src/rtree.h:49:66: note: Function 'r_insert_entry' argument 3 names different: declaration 'manage' definition 'man'. pcb-20140316/src/rtree.c:974:61: note: Function 'r_insert_entry' argument 3 names different: declaration 'manage' definition 'man'. pcb-20140316/src/rtree.c:1097:50: style:inconclusive: Function 'r_delete_entry' argument 2 names different: declaration 'which' definition 'box'. [funcArgNamesDifferent] pcb-20140316/src/rtree.h:48:55: note: Function 'r_delete_entry' argument 2 names different: declaration 'which' definition 'box'. pcb-20140316/src/rtree.c:1097:50: note: Function 'r_delete_entry' argument 2 names different: declaration 'which' definition 'box'. pcb-20140316/src/set.c:171:20: style: The statement 'if (PCB->Changed!=New) PCB->Changed=New' is logically equivalent to 'PCB->Changed=New'. [duplicateConditionalAssign] pcb-20140316/src/set.c:173:20: note: Assignment 'PCB->Changed=New' pcb-20140316/src/set.c:171:20: note: Condition 'PCB->Changed!=New' is redundant pcb-20140316/src/set.c:337:2: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] pcb-20140316/src/set.c:338:32: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-20140316/src/strflags.c:194:7: error: Common realloc mistake: 'layers' nulled but not freed upon failure [memleakOnRealloc] pcb-20140316/src/strflags.c:312:2: error: Common realloc mistake: 'buf' nulled but not freed upon failure [memleakOnRealloc] pcb-20140316/src/strflags.c:504:6: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/strflags.c:514:6: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/strflags.c:525:6: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/strflags.c:542:6: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/thermal.c:387:15: style: Local variable 't' shadows outer variable [shadowVariable] pcb-20140316/src/thermal.c:362:9: note: Shadowed declaration pcb-20140316/src/thermal.c:387:15: note: Shadow variable pcb-20140316/src/thermal.c:82:8: style: struct member 'cent::style' is never used. [unusedStructMember] pcb-20140316/src/thermal.c:83:13: style: struct member 'cent::p' is never used. [unusedStructMember] pcb-20140316/src/search.c:115:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/search.c:185:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/search.c:249:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/search.c:287:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/search.c:341:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/search.c:378:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/search.c:418:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/search.c:461:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/search.c:513:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/search.c:597:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/search.c:651:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/select.c:195:11: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] pcb-20140316/src/select.c:192:9: note: outer condition: PCB->ElementOn pcb-20140316/src/select.c:195:11: note: identical inner condition: PCB->ElementOn pcb-20140316/src/select.c:374:11: style: Variable 'changed' is reassigned a value before the old one has been used. [redundantAssignment] pcb-20140316/src/select.c:356:17: note: changed is assigned pcb-20140316/src/select.c:374:11: note: changed is overwritten pcb-20140316/src/select.c:374:11: style: Variable 'changed' is reassigned a value before the old one has been used. [redundantAssignment] pcb-20140316/src/select.c:368:17: note: changed is assigned pcb-20140316/src/select.c:374:11: note: changed is overwritten pcb-20140316/src/select.c:719:9: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/select.c:731:9: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/select.c:742:9: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/select.c:753:9: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/select.c:767:40: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/select.c:778:40: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/select.c:792:9: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-20140316/src/undo.c:214:7: error: Common realloc mistake: 'UndoList' nulled but not freed upon failure [memleakOnRealloc] pcb-20140316/src/vector.c:199:30: style:inconclusive: Function 'vector_duplicate' argument 1 names different: declaration 'vector' definition 'orig'. [funcArgNamesDifferent] pcb-20140316/src/vector.h:48:40: note: Function 'vector_duplicate' argument 1 names different: declaration 'vector' definition 'orig'. pcb-20140316/src/vector.c:199:30: note: Function 'vector_duplicate' argument 1 names different: declaration 'vector' definition 'orig'. pcb-20140316/tools/gerbertotk.c:71:4: error: Found a exit path from function with non-void return type that has missing return statement [missingReturn] pcb-20140316/src/vendor.c:296:11: style: Condition 'fname' is always true [knownConditionTrueFalse] pcb-20140316/src/vendor.c:698:7: portability: %ld in format string (no. 1) requires 'long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] pcb-20140316/src/vendor.c:695:8: error: Common realloc mistake: 'vendor_drills' nulled but not freed upon failure [memleakOnRealloc] pcb-20140316/src/vendor.c:791:15: error: Common realloc mistake: 'lst' nulled but not freed upon failure [memleakOnRealloc] pcb-20140316/src/vendor.c:328:13: warning: Conversion of string literal "mil" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/vendor.c:328:45: warning: Conversion of string literal "mils" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/vendor.c:332:13: warning: Conversion of string literal "inch" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/vendor.c:332:46: warning: Conversion of string literal "inches" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/vendor.c:336:12: warning: Conversion of string literal "mm" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/vendor.c:362:8: warning: Conversion of string literal "up" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/vendor.c:366:13: warning: Conversion of string literal "nearest" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/vendor.c:764:12: warning: Conversion of string literal "refdes" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/vendor.c:769:17: warning: Conversion of string literal "value" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/vendor.c:774:17: warning: Conversion of string literal "descr" to bool always evaluates to true. [incorrectStringBooleanError] pcb-20140316/src/toporouter.c:7574:27: style: Obsolete function 'asctime' called. It is recommended to use 'strftime' instead. [prohibitedasctimeCalled] pcb-20140316/src/toporouter.c:7574:35: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] pcb-20140316/src/toporouter.c:2854:32: style: Condition 'waiting' is always true [knownConditionTrueFalse] pcb-20140316/src/toporouter.c:2852:19: note: Assignment 'waiting=1', assigned value is 1 pcb-20140316/src/toporouter.c:2854:32: note: Condition 'waiting' is always true pcb-20140316/src/toporouter.c:6749:5: error: Memory leak: netscore [memleak] pcb-20140316/src/toporouter.c:4518:8: warning:inconclusive: Either the condition 'pv' is redundant or there is possible null pointer dereference: pv. [nullPointerRedundantCheck] pcb-20140316/src/toporouter.c:4541:8: note: Assuming that condition 'pv' is not redundant pcb-20140316/src/toporouter.c:4518:8: note: Null pointer dereference pcb-20140316/src/toporouter.c:4536:10: warning: Either the condition 'pv' is redundant or there is possible null pointer dereference: pv. [nullPointerRedundantCheck] pcb-20140316/src/toporouter.c:4541:8: note: Assuming that condition 'pv' is not redundant pcb-20140316/src/toporouter.c:4536:10: note: Null pointer dereference pcb-20140316/src/toporouter.c:4660:10: warning: Possible null pointer dereference: srcv [nullPointer] pcb-20140316/src/toporouter.c:4641:14: note: Assignment 'srcv=NULL', assigned value is 0 pcb-20140316/src/toporouter.c:4646:13: note: Assuming condition is false pcb-20140316/src/toporouter.c:4660:10: note: Null pointer dereference pcb-20140316/src/toporouter.c:5187:8: warning: Either the condition 'arc' is redundant or there is possible null pointer dereference: arc. [nullPointerRedundantCheck] pcb-20140316/src/toporouter.c:5545:16: note: Assuming that condition 'arc' is not redundant pcb-20140316/src/toporouter.c:5555:49: note: Calling function 'export_pcb_drawarc', 2nd argument 'arc' value is 0 pcb-20140316/src/toporouter.c:5211:21: note: Calling function 'arc_angle', 1st argument 'a' value is 0 pcb-20140316/src/toporouter.c:5187:8: note: Null pointer dereference pcb-20140316/src/toporouter.c:5188:8: warning: Either the condition 'arc' is redundant or there is possible null pointer dereference: arc. [nullPointerRedundantCheck] pcb-20140316/src/toporouter.c:5545:16: note: Assuming that condition 'arc' is not redundant pcb-20140316/src/toporouter.c:5555:49: note: Calling function 'export_pcb_drawarc', 2nd argument 'arc' value is 0 pcb-20140316/src/toporouter.c:5211:21: note: Calling function 'arc_angle', 1st argument 'a' value is 0 pcb-20140316/src/toporouter.c:5188:8: note: Null pointer dereference pcb-20140316/src/toporouter.c:5189:8: warning: Either the condition 'arc' is redundant or there is possible null pointer dereference: arc. [nullPointerRedundantCheck] pcb-20140316/src/toporouter.c:5545:16: note: Assuming that condition 'arc' is not redundant pcb-20140316/src/toporouter.c:5555:49: note: Calling function 'export_pcb_drawarc', 2nd argument 'arc' value is 0 pcb-20140316/src/toporouter.c:5211:21: note: Calling function 'arc_angle', 1st argument 'a' value is 0 pcb-20140316/src/toporouter.c:5189:8: note: Null pointer dereference pcb-20140316/src/toporouter.c:5190:8: warning: Either the condition 'arc' is redundant or there is possible null pointer dereference: arc. [nullPointerRedundantCheck] pcb-20140316/src/toporouter.c:5545:16: note: Assuming that condition 'arc' is not redundant pcb-20140316/src/toporouter.c:5555:49: note: Calling function 'export_pcb_drawarc', 2nd argument 'arc' value is 0 pcb-20140316/src/toporouter.c:5211:21: note: Calling function 'arc_angle', 1st argument 'a' value is 0 pcb-20140316/src/toporouter.c:5190:8: note: Null pointer dereference pcb-20140316/src/toporouter.c:5203:21: warning: Either the condition 'arc' is redundant or there is possible null pointer dereference: a. [nullPointerRedundantCheck] pcb-20140316/src/toporouter.c:5545:16: note: Assuming that condition 'arc' is not redundant pcb-20140316/src/toporouter.c:5555:49: note: Calling function 'export_pcb_drawarc', 2nd argument 'arc' value is 0 pcb-20140316/src/toporouter.c:5203:21: note: Null pointer dereference pcb-20140316/src/toporouter.c:5209:29: warning: Either the condition 'arc' is redundant or there is possible null pointer dereference: a. [nullPointerRedundantCheck] pcb-20140316/src/toporouter.c:5545:16: note: Assuming that condition 'arc' is not redundant pcb-20140316/src/toporouter.c:5555:49: note: Calling function 'export_pcb_drawarc', 2nd argument 'arc' value is 0 pcb-20140316/src/toporouter.c:5209:29: note: Null pointer dereference pcb-20140316/src/toporouter.c:5213:7: warning: Either the condition 'arc' is redundant or there is possible null pointer dereference: a. [nullPointerRedundantCheck] pcb-20140316/src/toporouter.c:5545:16: note: Assuming that condition 'arc' is not redundant pcb-20140316/src/toporouter.c:5555:49: note: Calling function 'export_pcb_drawarc', 2nd argument 'arc' value is 0 pcb-20140316/src/toporouter.c:5213:7: note: Null pointer dereference pcb-20140316/src/toporouter.c:5556:50: warning: Either the condition 'arc' is redundant or there is possible null pointer dereference: arc. [nullPointerRedundantCheck] pcb-20140316/src/toporouter.c:5545:16: note: Assuming that condition 'arc' is not redundant pcb-20140316/src/toporouter.c:5556:50: note: Null pointer dereference pcb-20140316/src/toporouter.c:5605:37: warning: Either the condition 'arc' is redundant or there is possible null pointer dereference: parc. [nullPointerRedundantCheck] pcb-20140316/src/toporouter.c:5594:16: note: Assuming that condition 'arc' is not redundant pcb-20140316/src/toporouter.c:5601:12: note: Assignment 'parc=arc', assigned value is 0 pcb-20140316/src/toporouter.c:5605:37: note: Null pointer dereference pcb-20140316/src/toporouter.c:5606:28: warning: Either the condition 'arc' is redundant or there is possible null pointer dereference: arc. [nullPointerRedundantCheck] pcb-20140316/src/toporouter.c:5594:16: note: Assuming that condition 'arc' is not redundant pcb-20140316/src/toporouter.c:5606:28: note: Null pointer dereference pcb-20140316/src/toporouter.c:3058:5: style: Redundant initialization for 'i'. The initialized value is overwritten before it is read. [redundantInitialization] pcb-20140316/src/toporouter.c:3053:12: note: i is initialized pcb-20140316/src/toporouter.c:3058:5: note: i is overwritten pcb-20140316/src/toporouter.c:4992:5: style: Redundant initialization for 'i'. The initialized value is overwritten before it is read. [redundantInitialization] pcb-20140316/src/toporouter.c:4978:12: note: i is initialized pcb-20140316/src/toporouter.c:4992:5: note: i is overwritten pcb-20140316/src/toporouter.c:5157:5: style: Redundant initialization for 'i'. The initialized value is overwritten before it is read. [redundantInitialization] pcb-20140316/src/toporouter.c:5143:12: note: i is initialized pcb-20140316/src/toporouter.c:5157:5: note: i is overwritten pcb-20140316/src/toporouter.c:7300:7: style: Redundant initialization for 'k'. The initialized value is overwritten before it is read. [redundantInitialization] pcb-20140316/src/toporouter.c:7298:52: note: k is initialized pcb-20140316/src/toporouter.c:7300:7: note: k is overwritten pcb-20140316/src/toporouter.c:4526:26: style: Local variable 'pv' shadows outer argument [shadowArgument] pcb-20140316/src/toporouter.c:4513:122: note: Shadowed declaration pcb-20140316/src/toporouter.c:4526:26: note: Shadow variable pcb-20140316/src/toporouter.c:4604:12: style: Local variable 'i' shadows outer variable [shadowVariable] pcb-20140316/src/toporouter.c:4570:10: note: Shadowed declaration pcb-20140316/src/toporouter.c:4604:12: note: Shadow variable pcb-20140316/src/toporouter.c:4848:12: style: Local variable 'i' shadows outer variable [shadowVariable] pcb-20140316/src/toporouter.c:4570:10: note: Shadowed declaration pcb-20140316/src/toporouter.c:4848:12: note: Shadow variable pcb-20140316/src/toporouter.c:4865:12: style: Local variable 'i' shadows outer variable [shadowVariable] pcb-20140316/src/toporouter.c:4570:10: note: Shadowed declaration pcb-20140316/src/toporouter.c:4865:12: note: Shadow variable pcb-20140316/src/toporouter.c:4886:12: style: Local variable 'i' shadows outer variable [shadowVariable] pcb-20140316/src/toporouter.c:4570:10: note: Shadowed declaration pcb-20140316/src/toporouter.c:4886:12: note: Shadow variable pcb-20140316/src/toporouter.c:4907:12: style: Local variable 'i' shadows outer variable [shadowVariable] pcb-20140316/src/toporouter.c:4570:10: note: Shadowed declaration pcb-20140316/src/toporouter.c:4907:12: note: Shadow variable pcb-20140316/src/toporouter.c:5201:8: style: Local variable 'wind' shadows outer function [shadowFunction] pcb-20140316/src/toporouter.c:1131:1: note: Shadowed declaration pcb-20140316/src/toporouter.c:5201:8: note: Shadow variable pcb-20140316/src/toporouter.c:5693:13: style: Local variable 'd' shadows outer variable [shadowVariable] pcb-20140316/src/toporouter.c:5686:45: note: Shadowed declaration pcb-20140316/src/toporouter.c:5693:13: note: Shadow variable pcb-20140316/src/toporouter.c:5761:13: style: Local variable 'd' shadows outer variable [shadowVariable] pcb-20140316/src/toporouter.c:5758:45: note: Shadowed declaration pcb-20140316/src/toporouter.c:5761:13: note: Shadow variable pcb-20140316/src/toporouter.c:7435:28: style: Local variable 'i' shadows outer variable [shadowVariable] pcb-20140316/src/toporouter.c:7420:10: note: Shadowed declaration pcb-20140316/src/toporouter.c:7435:28: note: Shadow variable pcb-20140316/src/toporouter.c:2497:71: style: Parameter 'data' can be declared with const [constParameter] pcb-20140316/src/toporouter.c:2847:54: style: Parameter 'v1' can be declared with const [constParameter] pcb-20140316/src/toporouter.c:2847:79: style: Parameter 'v2' can be declared with const [constParameter] pcb-20140316/src/toporouter.c:3226:57: style: Parameter 'curpoint' can be declared with const [constParameter] pcb-20140316/src/toporouter.c:4514:27: style: Parameter 'pair' can be declared with const [constParameter] pcb-20140316/src/toporouter.c:4554:70: style: Parameter 'v' can be declared with const [constParameter] pcb-20140316/src/toporouter.c:4946:87: style: Parameter 'arcv' can be declared with const [constParameter] pcb-20140316/src/toporouter.c:6179:32: style: Parameter 't' can be declared with const [constParameter] pcb-20140316/src/toporouter.c:6655:46: style: Parameter 'routedata' can be declared with const [constParameter] pcb-20140316/src/toporouter.c:7029:65: style: Parameter 'temproute' can be declared with const [constParameter] pcb-20140316/src/toporouter.c:5721:9: style: Variable 'x' is assigned a value that is never used. [unreadVariable] pcb-20140316/src/toporouter.c:5721:18: style: Variable 'y' is assigned a value that is never used. [unreadVariable] pcb-20140316/src/toporouter.c:7329:40: style: Variable 'nscore' is assigned a value that is never used. [unreadVariable] pcb-20140316/gts/predicates.c:709:56: style: Parameter 'e' can be declared with const [constParameter] pcb-20140316/gts/predicates.c:710:28: style: Parameter 'f' can be declared with const [constParameter] pcb-20140316/gts/predicates.c:795:53: style: Parameter 'e' can be declared with const [constParameter] pcb-20140316/gts/predicates.c:843:38: style: Parameter 'e' can be declared with const [constParameter] pcb-20140316/gts/predicates.c:881:33: style: Parameter 'pa' can be declared with const [constParameter] pcb-20140316/gts/predicates.c:881:43: style: Parameter 'pb' can be declared with const [constParameter] pcb-20140316/gts/predicates.c:881:53: style: Parameter 'pc' can be declared with const [constParameter] pcb-20140316/gts/predicates.c:1035:33: style: Parameter 'pa' can be declared with const [constParameter] pcb-20140316/gts/predicates.c:1035:43: style: Parameter 'pb' can be declared with const [constParameter] pcb-20140316/gts/predicates.c:1035:53: style: Parameter 'pc' can be declared with const [constParameter] pcb-20140316/gts/predicates.c:1035:63: style: Parameter 'pd' can be declared with const [constParameter] pcb-20140316/gts/predicates.c:1513:33: style: Parameter 'pa' can be declared with const [constParameter] pcb-20140316/gts/predicates.c:1513:43: style: Parameter 'pb' can be declared with const [constParameter] pcb-20140316/gts/predicates.c:1513:53: style: Parameter 'pc' can be declared with const [constParameter] pcb-20140316/gts/predicates.c:1513:63: style: Parameter 'pd' can be declared with const [constParameter] pcb-20140316/gts/predicates.c:1430:51: style: Variable 'finother' is assigned a value that is never used. [unreadVariable] pcb-20140316/gts/predicates.c:2078:53: style: Variable 'finother' is assigned a value that is never used. [unreadVariable] diff: head pcb-20140316/gts/graph.c:495:11: style: Condition 'n2' is always true [knownConditionTrueFalse] 2.6 pcb-20140316/gts/graph.c:495:11: style: Condition 'n2' is always true [knownConditionTrueFalse] pcb-20140316/gts/graph.c:493:24: note: Assuming that condition 'n2!=NULL' is not redundant pcb-20140316/gts/graph.c:495:11: note: Condition 'n2' is always true head pcb-20140316/gts/graph.c:498:11: style: Condition 'n1' is always true [knownConditionTrueFalse] 2.6 pcb-20140316/gts/graph.c:498:11: style: Condition 'n1' is always true [knownConditionTrueFalse] pcb-20140316/gts/graph.c:493:10: note: Assuming that condition 'n1!=NULL' is not redundant pcb-20140316/gts/graph.c:498:11: note: Condition 'n1' is always true head pcb-20140316/src/action.c:6336:12: style: Condition 'function' is always true [knownConditionTrueFalse] 2.6 pcb-20140316/src/action.c:6336:12: style: Condition 'function' is always true [knownConditionTrueFalse] pcb-20140316/src/action.c:6197:7: note: Assuming that condition '!function' is not redundant pcb-20140316/src/action.c:6336:12: note: Condition 'function' is always true head pcb-20140316/src/action.c:7123:12: style: Condition 'e' is always true [knownConditionTrueFalse] 2.6 pcb-20140316/src/action.c:7123:12: style: Condition 'e' is always true [knownConditionTrueFalse] pcb-20140316/src/action.c:7081:7: note: Assuming that condition '!e' is not redundant pcb-20140316/src/action.c:7123:12: note: Condition 'e' is always true head pcb-20140316/src/file.c:319:7: style: Condition 'fname' is always true [knownConditionTrueFalse] 2.6 pcb-20140316/src/file.c:319:7: style: Condition 'fname' is always true [knownConditionTrueFalse] pcb-20140316/src/file.c:310:13: note: Assuming that condition 'fname==NULL' is not redundant pcb-20140316/src/file.c:319:7: note: Condition 'fname' is always true head pcb-20140316/src/report.c:919:11: style: Condition 'net_found' is always true [knownConditionTrueFalse] 2.6 pcb-20140316/src/report.c:919:11: style: Condition 'net_found' is always true [knownConditionTrueFalse] pcb-20140316/src/report.c:889:7: note: Assuming that condition '!net_found' is not redundant pcb-20140316/src/report.c:919:11: note: Condition 'net_found' is always true head pcb-20140316/src/vendor.c:296:11: style: Condition 'fname' is always true [knownConditionTrueFalse] 2.6 pcb-20140316/src/vendor.c:296:11: style: Condition 'fname' is always true [knownConditionTrueFalse] pcb-20140316/src/vendor.c:288:17: note: Assuming that condition 'fname==NULL' is not redundant pcb-20140316/src/vendor.c:296:11: note: Condition 'fname' is always true DONE