2024-03-25 03:00 ftp://ftp.de.debian.org/debian/pool/main/p/pcb/pcb_4.3.0.orig.tar.gz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --inline-suppr --disable=missingInclude --suppress=unmatchedSuppression --template=daca2 --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=valueFlowBailoutIncompleteVar -D__GNUC__ --platform=unix64 -j4 platform: Linux-6.1.0-0.deb11.6-amd64-x86_64-with-glibc2.31 python: 3.9.2 client-version: 1.3.45 compiler: g++ (Debian 10.2.1-6) 10.2.1 20210110 cppcheck: head 2.13.0 head-info: 51f8b53 (2024-03-24 16:07:43 +0100) count: 1240 1196 elapsed-time: 14.9 37.6 head-timing-info: Tokenizer::simplifyTokens1::ValueFlow: 13.8921s (avg. 13.8921s - 1 result(s)) valueFlowSymbolic(tokenlist, symboldatabase, errorLogger, settings): 8.5304s (avg. 8.5304s - 1 result(s)) valueFlowAfterAssign(tokenlist, symboldatabase, errorLogger, settings, skippedFunctions): 2.80511s (avg. 0.935036s - 3 result(s)) valueFlowSubFunction(tokenlist, symboldatabase, errorLogger, settings): 1.044s (avg. 0.348s - 3 result(s)) valueFlowUninit(tokenlist, errorLogger, settings): 0.750928s (avg. 0.250309s - 3 result(s)) Overall time: 14.1235s old-timing-info: Tokenizer::simplifyTokens1::ValueFlow: 36.5444s (avg. 36.5444s - 1 result(s)) valueFlowSymbolic(tokenlist, symboldatabase, settings): 24.0588s (avg. 24.0588s - 1 result(s)) valueFlowAfterAssign(tokenlist, symboldatabase, errorLogger, settings, skippedFunctions): 6.12556s (avg. 2.04185s - 3 result(s)) valueFlowSubFunction(tokenlist, symboldatabase, errorLogger, *settings): 3.82737s (avg. 1.27579s - 3 result(s)) valueFlowConditionExpressions(tokenlist, symboldatabase, errorLogger, *settings): 1.56743s (avg. 1.56743s - 1 result(s)) Overall time: 36.957s head results: pcb-4.3.0/gts/curvature.c:408:15: style: Local variable 'e' shadows outer variable [shadowVariable] pcb-4.3.0/gts/curvature.c:351:7: note: Shadowed declaration pcb-4.3.0/gts/curvature.c:408:15: note: Shadow variable pcb-4.3.0/gts/bbtree.c:895:13: style: Local variable 'min' shadows outer variable [shadowVariable] pcb-4.3.0/gts/bbtree.c:883:11: note: Shadowed declaration pcb-4.3.0/gts/bbtree.c:895:13: note: Shadow variable pcb-4.3.0/gts/bbtree.c:153:14: style: Variable 'p1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/bbtree.c:153:20: style: Variable 'p2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/bbtree.c:184:45: style: Parameter 'p' can be declared as pointer to const. However it seems that 'bbox_foreach_vertex' is a callback function, if 'p' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/bbtree.c:212:50: note: You might need to cast the function pointer here pcb-4.3.0/gts/bbtree.c:184:45: note: Parameter 'p' can be declared as pointer to const pcb-4.3.0/gts/bbtree.c:262:12: style: Variable 'i' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/bbtree.c:299:48: style: Parameter 'bb1' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/bbtree.c:299:63: style: Parameter 'bb2' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/bbtree.c:331:39: style: Parameter 'bb' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/bbtree.c:351:31: style: Parameter 'bb' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/bbtree.c:397:42: style: Parameter 'bb' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/bbtree.c:397:57: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/bbtree.c:444:41: style: Parameter 'bb' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/bbtree.c:444:56: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/bbtree.c:470:48: style: Parameter 'bb' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/bbtree.c:473:14: style: Variable 'p1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/bbtree.c:473:20: style: Variable 'p2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/bbtree.c:473:26: style: Variable 'p3' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/bbtree.c:504:47: style: Parameter 'bb' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/bbtree.c:507:20: style: Variable 'p2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/bbtree.c:507:26: style: Variable 'p3' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/bbtree.c:549:13: style: Variable 'p1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/bbtree.c:549:19: style: Variable 'p2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/bbtree.c:1096:14: style: Variable 'p1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/bbtree.c:1096:20: style: Variable 'p2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/eheap.c:230:18: style: Variable 'pair' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/cdt.c:136:16: style: Variable 'p1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/cdt.c:173:17: style: Variable 't' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/cdt.c:248:14: style: Variable 'p' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/cdt.c:656:45: style: Parameter 'poly' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/cdt.c:661:15: style: Variable 'v1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/cdt.c:661:28: style: Variable 'v2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/cdt.c:1048:57: style: Parameter 'data' can be declared as pointer to const. However it seems that 'delaunay_check' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/cdt.c:1093:48: note: You might need to cast the function pointer here pcb-4.3.0/gts/cdt.c:1048:57: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/gts/cdt.c:926:15: style: Variable 'o1' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/gts/cdt.c:928:8: style: Variable 'o2' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/gts/boolean.c:838:5: style: Redundant initialization for 'i'. The initialized value is overwritten before it is read. [redundantInitialization] pcb-4.3.0/gts/boolean.c:835:14: note: i is initialized pcb-4.3.0/gts/boolean.c:838:5: note: i is overwritten pcb-4.3.0/gts/boolean.c:1754:14: style: Local variable 'data' shadows outer variable [shadowVariable] pcb-4.3.0/gts/boolean.c:1736:12: note: Shadowed declaration pcb-4.3.0/gts/boolean.c:1754:14: note: Shadow variable pcb-4.3.0/gts/boolean.c:770:12: style: Variable 'i' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/boolean.c:784:12: style: Variable 'i' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/boolean.c:856:15: style: Variable 'next' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/boolean.c:856:23: style: Variable 'prev' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/boolean.c:925:15: style: Parameter 'i' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/boolean.c:1476:56: style: Parameter 'next' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/boolean.c:1510:14: style: Variable 'p' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/boolean.c:1621:57: style: Parameter 'data' can be declared as pointer to const. However it seems that 'check_surface_edge' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/boolean.c:1760:49: note: You might need to cast the function pointer here pcb-4.3.0/gts/boolean.c:1621:57: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/gts/boolean.c:1645:16: style: Variable 's' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/boolean.c:1650:15: style: Variable 'v2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/boolean.c:1684:52: style: Parameter 'data' can be declared as pointer to const. However it seems that 'check_edge' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/boolean.c:1749:39: note: You might need to cast the function pointer here pcb-4.3.0/gts/boolean.c:1684:52: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/gts/boolean.c:1689:12: style: Variable 'j' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/boolean.c:1895:22: style: Parameter 'd' can be declared as pointer to const. However it seems that 'self_intersecting' is a callback function, if 'd' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/boolean.c:1961:33: note: You might need to cast the function pointer here pcb-4.3.0/gts/boolean.c:1895:22: note: Parameter 'd' can be declared as pointer to const pcb-4.3.0/gts/boolean.c:1901:18: style: Variable 's1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/boolean.c:1902:18: style: Variable 's2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/boolean.c:1903:18: style: Variable 's3' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/boolean.c:293:11: style: Variable 'ev2' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/gts/boolean.c:1661:19: style: Variable 'o2' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/gts/fifo.c:49:11: style: Variable 'i' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/fifo.c:151:39: style: Parameter 'fifo' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/face.c:111:65: style: Parameter 's' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/face.c:113:12: style: Variable 'i' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/edge.c:284:15: style: Variable 'v2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/edge.c:353:15: style: Variable 'v1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/edge.c:412:18: style: Parameter 'e1' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/edge.c:415:15: style: Variable 'v1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/edge.c:416:15: style: Variable 'v2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/hsurface.c:363:19: style: Local variable 'hs' shadows outer variable [shadowVariable] pcb-4.3.0/gts/hsurface.c:348:15: note: Shadowed declaration pcb-4.3.0/gts/hsurface.c:363:19: note: Shadow variable pcb-4.3.0/gts/hsurface.c:372:19: style: Local variable 'hs' shadows outer variable [shadowVariable] pcb-4.3.0/gts/hsurface.c:348:15: note: Shadowed declaration pcb-4.3.0/gts/hsurface.c:372:19: note: Shadow variable pcb-4.3.0/gts/hsurface.c:68:64: style: Parameter 'vs' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/kdtree.c:111:36: style:inconclusive: Function 'gts_kdtree_range' argument 1 names different: declaration 'tree' definition 'tree_3d'. [funcArgNamesDifferent] pcb-4.3.0/gts/gts.h:842:63: note: Function 'gts_kdtree_range' argument 1 names different: declaration 'tree' definition 'tree_3d'. pcb-4.3.0/gts/kdtree.c:111:36: note: Function 'gts_kdtree_range' argument 1 names different: declaration 'tree' definition 'tree_3d'. pcb-4.3.0/gts/kdtree.c:26:7: style: Variable 'pp1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/kdtree.c:27:7: style: Variable 'pp2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/kdtree.c:35:7: style: Variable 'pp1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/kdtree.c:36:7: style: Variable 'pp2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/kdtree.c:44:7: style: Variable 'pp1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/kdtree.c:45:7: style: Variable 'pp2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/graph.c:495:11: style: Condition 'n2' is always true [knownConditionTrueFalse] pcb-4.3.0/gts/graph.c:498:11: style: Condition 'n1' is always true [knownConditionTrueFalse] pcb-4.3.0/gts/isotetra.c:114:30: style: Parameter 'g' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/isotetra.c:176:27: style: Parameter 'g' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/graph.c:670:19: style:inconclusive: Function 'gts_pgedge_new' argument 2 names different: declaration 'n1' definition 'g1'. [funcArgNamesDifferent] pcb-4.3.0/gts/gts.h:2302:20: note: Function 'gts_pgedge_new' argument 2 names different: declaration 'n1' definition 'g1'. pcb-4.3.0/gts/graph.c:670:19: note: Function 'gts_pgedge_new' argument 2 names different: declaration 'n1' definition 'g1'. pcb-4.3.0/gts/graph.c:671:19: style:inconclusive: Function 'gts_pgedge_new' argument 3 names different: declaration 'n2' definition 'g2'. [funcArgNamesDifferent] pcb-4.3.0/gts/gts.h:2303:20: note: Function 'gts_pgedge_new' argument 3 names different: declaration 'n2' definition 'g2'. pcb-4.3.0/gts/graph.c:671:19: note: Function 'gts_pgedge_new' argument 3 names different: declaration 'n2' definition 'g2'. pcb-4.3.0/gts/graph.c:735:19: style:inconclusive: Function 'gts_wgedge_new' argument 2 names different: declaration 'n1' definition 'g1'. [funcArgNamesDifferent] pcb-4.3.0/gts/gts.h:2332:20: note: Function 'gts_wgedge_new' argument 2 names different: declaration 'n1' definition 'g1'. pcb-4.3.0/gts/graph.c:735:19: note: Function 'gts_wgedge_new' argument 2 names different: declaration 'n1' definition 'g1'. pcb-4.3.0/gts/graph.c:736:19: style:inconclusive: Function 'gts_wgedge_new' argument 3 names different: declaration 'n2' definition 'g2'. [funcArgNamesDifferent] pcb-4.3.0/gts/gts.h:2333:20: note: Function 'gts_wgedge_new' argument 3 names different: declaration 'n2' definition 'g2'. pcb-4.3.0/gts/graph.c:736:19: note: Function 'gts_wgedge_new' argument 3 names different: declaration 'n2' definition 'g2'. pcb-4.3.0/gts/graph.c:412:37: style: Parameter 'n' can be declared as pointer to const. However it seems that 'fnode_write' is a callback function, if 'n' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/graph.c:419:18: note: You might need to cast the function pointer here pcb-4.3.0/gts/graph.c:412:37: note: Parameter 'n' can be declared as pointer to const pcb-4.3.0/gts/graph.c:486:70: style: Parameter 'c' can be declared as pointer to const. However it seems that 'gedge_remove_container' is a callback function, if 'c' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/graph.c:521:51: note: You might need to cast the function pointer here pcb-4.3.0/gts/graph.c:486:70: note: Parameter 'c' can be declared as pointer to const pcb-4.3.0/gts/graph.c:507:70: style: Parameter 'c' can be declared as pointer to const. However it seems that 'gedge_is_contained' is a callback function, if 'c' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/graph.c:522:47: note: You might need to cast the function pointer here pcb-4.3.0/gts/graph.c:507:70: note: Parameter 'c' can be declared as pointer to const pcb-4.3.0/gts/graph.c:758:14: style: Variable 'graph' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/graph.c:862:54: style: Parameter 'data' can be declared as pointer to const. However it seems that 'compute_degree' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/graph.c:892:55: note: You might need to cast the function pointer here pcb-4.3.0/gts/graph.c:862:54: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/gts/graph.c:946:53: style: Parameter 'data' can be declared as pointer to const. However it seems that 'push_neighbor' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/graph.c:976:52: note: You might need to cast the function pointer here pcb-4.3.0/gts/graph.c:946:53: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/gts/graph.c:949:14: style: Variable 'u' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/graph.c:1077:14: style: Variable 'n' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/graph.c:1143:54: style: Parameter 'data' can be declared as pointer to const. However it seems that 'neighbor_count' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/graph.c:1154:50: note: You might need to cast the function pointer here pcb-4.3.0/gts/graph.c:1143:54: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/gts/graph.c:1178:60: style: Parameter 'data' can be declared as pointer to const. However it seems that 'sum_edge_cuts_weight' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/graph.c:1208:55: note: You might need to cast the function pointer here pcb-4.3.0/gts/graph.c:1178:60: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/gts/graph.c:1298:54: style: Parameter 'data' can be declared as pointer to const. However it seems that 'write_node' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/graph.c:1359:55: note: You might need to cast the function pointer here pcb-4.3.0/gts/graph.c:1298:54: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/gts/graph.c:1499:57: style: Parameter 'data' can be declared as pointer to const. However it seems that 'write_dot_node' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/graph.c:1546:55: note: You might need to cast the function pointer here pcb-4.3.0/gts/graph.c:1499:57: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/gts/named.c:36:16: style: Variable 'nv' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/named.c:92:14: style: Variable 'ne' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/named.c:147:14: style: Variable 'nf' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/object.c:100:58: style: Parameter 'object' can be declared as pointer to const. However it seems that 'object_clone' is a callback function, if 'object' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/object.c:108:18: note: You might need to cast the function pointer here pcb-4.3.0/gts/object.c:100:58: note: Parameter 'object' can be declared as pointer to const pcb-4.3.0/gts/oocs.c:34:53: style: Parameter 'p' can be declared as pointer to const. However it seems that 'cluster_add' is a callback function, if 'p' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/oocs.c:67:16: note: You might need to cast the function pointer here pcb-4.3.0/gts/oocs.c:34:53: note: Parameter 'p' can be declared as pointer to const pcb-4.3.0/gts/oocs.c:268:47: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/oocs.c:269:18: style: Parameter 'bb' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/gts.h:270:20: style: Local variable 'c' shadows outer variable [shadowVariable] pcb-4.3.0/gts/iso.c:35:14: note: Shadowed declaration pcb-4.3.0/gts/gts.h:270:20: note: Shadow variable pcb-4.3.0/gts/gts.h:294:20: style: Local variable 'c' shadows outer variable [shadowVariable] pcb-4.3.0/gts/iso.c:35:14: note: Shadowed declaration pcb-4.3.0/gts/gts.h:294:20: note: Shadow variable pcb-4.3.0/gts/iso.c:350:19: style: Variable 'ne' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/pgraph.c:410:13: style: Condition 'matching=maximal_matching(g)' is always false [knownConditionTrueFalse] pcb-4.3.0/gts/pgraph.c:354:19: note: Assignment 'list=NULL', assigned value is 0 pcb-4.3.0/gts/pgraph.c:410:32: note: Calling function 'maximal_matching' returns 0 pcb-4.3.0/gts/pgraph.c:410:13: note: Condition 'matching=maximal_matching(g)' is always false pcb-4.3.0/gts/pgraph.c:111:52: style: Parameter 'data' can be declared as pointer to const. However it seems that 'connect_edge' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/pgraph.c:186:56: note: You might need to cast the function pointer here pcb-4.3.0/gts/pgraph.c:111:52: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/gts/pgraph.c:114:14: style: Variable 'n1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/pgraph.c:115:14: style: Variable 'n2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/pgraph.c:163:13: style: Variable 'n4' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/pgraph.c:195:52: style: Parameter 'data' can be declared as pointer to const. However it seems that 'restore_edge' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/pgraph.c:249:56: note: You might need to cast the function pointer here pcb-4.3.0/gts/pgraph.c:195:52: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/gts/pgraph.c:199:14: style: Variable 'n2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/pgraph.c:323:54: style: Parameter 'data' can be declared as pointer to const. However it seems that 'match_neighbor' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/pgraph.c:359:55: note: You might need to cast the function pointer here pcb-4.3.0/gts/pgraph.c:323:54: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/gts/pgraph.c:509:47: style: Parameter 'pg' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/psurface.c:404:53: style: Parameter 'ps' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/partition.c:555:11: style: The if condition is the same as the previous if condition [duplicateCondition] pcb-4.3.0/gts/partition.c:553:11: note: First condition pcb-4.3.0/gts/partition.c:555:11: note: Second condition pcb-4.3.0/gts/partition.c:653:11: style: The if condition is the same as the previous if condition [duplicateCondition] pcb-4.3.0/gts/partition.c:651:11: note: First condition pcb-4.3.0/gts/partition.c:653:11: note: Second condition pcb-4.3.0/gts/partition.c:291:12: style: Condition 'seed==NULL' is always true [knownConditionTrueFalse] pcb-4.3.0/gts/partition.c:276:21: note: Assignment 'seed=NULL', assigned value is 0 pcb-4.3.0/gts/partition.c:291:12: note: Condition 'seed==NULL' is always true pcb-4.3.0/gts/refine.c:33:14: style: Variable 'p' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/refine.c:33:19: style: Variable 'p1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/refine.c:33:25: style: Variable 'p2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/refine.c:194:16: style: Variable 'add_vertex_returned' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/refine.c:391:16: style: Variable 'add_vertex_returned' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/partition.c:318:18: style: Local variable 'g1' shadows outer variable [shadowVariable] pcb-4.3.0/gts/partition.c:279:14: note: Shadowed declaration pcb-4.3.0/gts/partition.c:318:18: note: Shadow variable pcb-4.3.0/gts/partition.c:319:18: style: Local variable 'seed' shadows outer variable [shadowVariable] pcb-4.3.0/gts/partition.c:276:14: note: Shadowed declaration pcb-4.3.0/gts/partition.c:319:18: note: Shadow variable pcb-4.3.0/gts/partition.c:331:13: style: Local variable 'g1' shadows outer variable [shadowVariable] pcb-4.3.0/gts/partition.c:279:14: note: Shadowed declaration pcb-4.3.0/gts/partition.c:331:13: note: Shadow variable pcb-4.3.0/gts/partition.c:332:13: style: Local variable 'seed' shadows outer variable [shadowVariable] pcb-4.3.0/gts/partition.c:276:14: note: Shadowed declaration pcb-4.3.0/gts/partition.c:332:13: note: Shadow variable pcb-4.3.0/gts/partition.c:760:16: style: Local variable 'i' shadows outer variable [shadowVariable] pcb-4.3.0/gts/partition.c:725:17: note: Shadowed declaration pcb-4.3.0/gts/partition.c:760:16: note: Shadow variable pcb-4.3.0/gts/partition.c:806:16: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-4.3.0/gts/partition.c:724:14: note: Shadowed declaration pcb-4.3.0/gts/partition.c:806:16: note: Shadow variable pcb-4.3.0/gts/partition.c:977:16: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-4.3.0/gts/partition.c:889:14: note: Shadowed declaration pcb-4.3.0/gts/partition.c:977:16: note: Shadow variable pcb-4.3.0/gts/partition.c:161:60: style: Parameter 'data' can be declared as pointer to const. However it seems that 'find_smallest_degree' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/partition.c:289:15: note: You might need to cast the function pointer here pcb-4.3.0/gts/partition.c:161:60: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/gts/partition.c:224:51: style: Parameter 'data' can be declared as pointer to const. However it seems that 'better_seed' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/partition.c:246:50: note: You might need to cast the function pointer here pcb-4.3.0/gts/partition.c:224:51: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/gts/partition.c:351:52: style: Parameter 'data' can be declared as pointer to const. However it seems that 'node_cost' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/partition.c:531:40: note: You might need to cast the function pointer here pcb-4.3.0/gts/partition.c:351:52: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/gts/partition.c:431:48: style: Parameter 'data' can be declared as pointer to const. However it seems that 'check_bg' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/partition.c:477:60: note: You might need to cast the function pointer here pcb-4.3.0/gts/partition.c:431:48: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/gts/segment.c:112:12: style: Variable 'i' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/segment.c:113:15: style: Variable 'v2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/segment.c:177:14: style: Variable 'p1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/segment.c:177:20: style: Variable 'p2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/stripe.c:682:35: warning: Either the condition 'v1' is redundant or there is possible null pointer dereference: v1. [nullPointerRedundantCheck] pcb-4.3.0/gts/stripe.c:690:13: note: Assuming that condition 'v1' is not redundant pcb-4.3.0/gts/stripe.c:682:35: note: Null pointer dereference pcb-4.3.0/gts/stripe.c:682:40: warning: Either the condition 'v2' is redundant or there is possible null pointer dereference: v2. [nullPointerRedundantCheck] pcb-4.3.0/gts/stripe.c:690:19: note: Assuming that condition 'v2' is not redundant pcb-4.3.0/gts/stripe.c:682:40: note: Null pointer dereference pcb-4.3.0/gts/stripe.c:682:45: warning: Either the condition 'v3' is redundant or there is possible null pointer dereference: v3. [nullPointerRedundantCheck] pcb-4.3.0/gts/stripe.c:690:25: note: Assuming that condition 'v3' is not redundant pcb-4.3.0/gts/stripe.c:682:45: note: Null pointer dereference pcb-4.3.0/gts/stripe.c:683:35: warning: Either the condition 'v4' is redundant or there is possible null pointer dereference: v4. [nullPointerRedundantCheck] pcb-4.3.0/gts/stripe.c:691:13: note: Assuming that condition 'v4' is not redundant pcb-4.3.0/gts/stripe.c:683:35: note: Null pointer dereference pcb-4.3.0/gts/stripe.c:683:40: warning: Either the condition 'v5' is redundant or there is possible null pointer dereference: v5. [nullPointerRedundantCheck] pcb-4.3.0/gts/stripe.c:691:19: note: Assuming that condition 'v5' is not redundant pcb-4.3.0/gts/stripe.c:683:40: note: Null pointer dereference pcb-4.3.0/gts/stripe.c:683:45: warning: Either the condition 'v6' is redundant or there is possible null pointer dereference: v6. [nullPointerRedundantCheck] pcb-4.3.0/gts/stripe.c:691:25: note: Assuming that condition 'v6' is not redundant pcb-4.3.0/gts/stripe.c:683:45: note: Null pointer dereference pcb-4.3.0/gts/stripe.c:684:35: warning: Either the condition 'v1' is redundant or there is possible null pointer dereference: v1. [nullPointerRedundantCheck] pcb-4.3.0/gts/stripe.c:690:13: note: Assuming that condition 'v1' is not redundant pcb-4.3.0/gts/stripe.c:684:35: note: Null pointer dereference pcb-4.3.0/gts/stripe.c:684:40: warning: Either the condition 'v2' is redundant or there is possible null pointer dereference: v2. [nullPointerRedundantCheck] pcb-4.3.0/gts/stripe.c:690:19: note: Assuming that condition 'v2' is not redundant pcb-4.3.0/gts/stripe.c:684:40: note: Null pointer dereference pcb-4.3.0/gts/stripe.c:684:45: warning: Either the condition 'v3' is redundant or there is possible null pointer dereference: v3. [nullPointerRedundantCheck] pcb-4.3.0/gts/stripe.c:690:25: note: Assuming that condition 'v3' is not redundant pcb-4.3.0/gts/stripe.c:684:45: note: Null pointer dereference pcb-4.3.0/gts/stripe.c:684:50: warning: Either the condition 'v4' is redundant or there is possible null pointer dereference: v4. [nullPointerRedundantCheck] pcb-4.3.0/gts/stripe.c:691:13: note: Assuming that condition 'v4' is not redundant pcb-4.3.0/gts/stripe.c:684:50: note: Null pointer dereference pcb-4.3.0/gts/stripe.c:684:55: warning: Either the condition 'v5' is redundant or there is possible null pointer dereference: v5. [nullPointerRedundantCheck] pcb-4.3.0/gts/stripe.c:691:19: note: Assuming that condition 'v5' is not redundant pcb-4.3.0/gts/stripe.c:684:55: note: Null pointer dereference pcb-4.3.0/gts/stripe.c:684:60: warning: Either the condition 'v6' is redundant or there is possible null pointer dereference: v6. [nullPointerRedundantCheck] pcb-4.3.0/gts/stripe.c:691:25: note: Assuming that condition 'v6' is not redundant pcb-4.3.0/gts/stripe.c:684:60: note: Null pointer dereference pcb-4.3.0/gts/stripe.c:686:28: warning: Either the condition 'v1' is redundant or there is possible null pointer dereference: v1. [nullPointerRedundantCheck] pcb-4.3.0/gts/stripe.c:690:13: note: Assuming that condition 'v1' is not redundant pcb-4.3.0/gts/stripe.c:686:28: note: Null pointer dereference pcb-4.3.0/gts/stripe.c:686:33: warning: Either the condition 'v2' is redundant or there is possible null pointer dereference: v2. [nullPointerRedundantCheck] pcb-4.3.0/gts/stripe.c:690:19: note: Assuming that condition 'v2' is not redundant pcb-4.3.0/gts/stripe.c:686:33: note: Null pointer dereference pcb-4.3.0/gts/stripe.c:686:38: warning: Either the condition 'v3' is redundant or there is possible null pointer dereference: v3. [nullPointerRedundantCheck] pcb-4.3.0/gts/stripe.c:690:25: note: Assuming that condition 'v3' is not redundant pcb-4.3.0/gts/stripe.c:686:38: note: Null pointer dereference pcb-4.3.0/gts/stripe.c:686:43: warning: Either the condition 'v4' is redundant or there is possible null pointer dereference: v4. [nullPointerRedundantCheck] pcb-4.3.0/gts/stripe.c:691:13: note: Assuming that condition 'v4' is not redundant pcb-4.3.0/gts/stripe.c:686:43: note: Null pointer dereference pcb-4.3.0/gts/stripe.c:686:48: warning: Either the condition 'v5' is redundant or there is possible null pointer dereference: v5. [nullPointerRedundantCheck] pcb-4.3.0/gts/stripe.c:691:19: note: Assuming that condition 'v5' is not redundant pcb-4.3.0/gts/stripe.c:686:48: note: Null pointer dereference pcb-4.3.0/gts/stripe.c:686:53: warning: Either the condition 'v6' is redundant or there is possible null pointer dereference: v6. [nullPointerRedundantCheck] pcb-4.3.0/gts/stripe.c:691:25: note: Assuming that condition 'v6' is not redundant pcb-4.3.0/gts/stripe.c:686:53: note: Null pointer dereference pcb-4.3.0/gts/stripe.c:688:18: warning: Either the condition 'v3' is redundant or there is possible null pointer dereference: v3. [nullPointerRedundantCheck] pcb-4.3.0/gts/stripe.c:690:25: note: Assuming that condition 'v3' is not redundant pcb-4.3.0/gts/stripe.c:688:18: note: Null pointer dereference pcb-4.3.0/gts/stripe.c:100:45: style: Parameter 'v1' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/stripe.c:101:17: style: Parameter 'v2' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/stripe.c:102:17: style: Parameter 'v3' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/stripe.c:383:18: style: struct member 'min_key_t::heap' is never used. [unusedStructMember] pcb-4.3.0/gts/stripe.c:384:10: style: struct member 'min_key_t::min_key' is never used. [unusedStructMember] pcb-4.3.0/gts/point.c:71:14: style: Variable 'p' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/point.c:161:40: style: Parameter 'p1' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/point.c:161:55: style: Parameter 'p2' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/point.c:177:41: style: Parameter 'p1' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/point.c:177:56: style: Parameter 'p2' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/point.c:394:44: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/point.c:756:13: style: Variable 'bb' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/split.c:1388:17: warning: Opposite inner 'if' condition leads to a dead code block. [oppositeInnerCondition] pcb-4.3.0/gts/split.c:1387:15: note: outer condition: f->type==GTS_STRING pcb-4.3.0/gts/split.c:1388:17: note: opposite inner condition: f->type!=GTS_STRING pcb-4.3.0/gts/split.c:817:14: style: Local variable 'j' shadows outer variable [shadowVariable] pcb-4.3.0/gts/split.c:785:9: note: Shadowed declaration pcb-4.3.0/gts/split.c:817:14: note: Shadow variable pcb-4.3.0/gts/split.c:203:16: style: Parameter 'e' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/split.c:204:18: style: Parameter 'v1' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/split.c:205:18: style: Parameter 'v2' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/split.c:304:35: style: Parameter 'vs' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/split.c:335:44: style: Parameter 'e' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/triangle.c:551:7: warning: Possible null pointer dereference: (struct GtsSegment*)(ee1) [nullPointer] pcb-4.3.0/gts/triangle.c:549:0: note: Assignment 'ee1=NULL', assigned value is 0 pcb-4.3.0/gts/triangle.c:551:7: note: Null pointer dereference pcb-4.3.0/gts/triangle.c:551:32: warning: Possible null pointer dereference: (struct GtsSegment*)(ee2) [nullPointer] pcb-4.3.0/gts/triangle.c:549:17: note: Assignment 'ee2=NULL', assigned value is 0 pcb-4.3.0/gts/triangle.c:551:32: note: Null pointer dereference pcb-4.3.0/gts/triangle.c:197:68: style: Parameter 'v' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/triangle.c:199:16: style: Variable 's1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/triangle.c:199:22: style: Variable 's2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/triangle.c:199:28: style: Variable 's3' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/triangle.c:261:22: style: Parameter 'e' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/triangle.c:371:14: style: Variable 'p1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/triangle.c:371:20: style: Variable 'p2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/triangle.c:371:26: style: Variable 'p3' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/triangle.c:608:16: style: Variable 'p' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/triangle.c:639:12: style: Variable 'i' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/triangle.c:649:21: style: Variable 't1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/triangle.c:693:24: style: Parameter 't2' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/triangle.c:716:12: style: Variable 'i' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/triangle.c:717:13: style: Variable 'e2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/triangle.c:717:19: style: Variable 'e3' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/triangle.c:746:21: style: Parameter 'e2' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/triangle.c:747:21: style: Parameter 'e3' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/triangle.c:749:12: style: Variable 'i' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/triangle.c:886:47: style: Parameter 'A' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/triangle.c:887:19: style: Parameter 'B' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/triangle.c:888:19: style: Parameter 'C' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/triangle.c:889:19: style: Parameter 'D' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/triangle.c:915:20: style: Parameter 'A' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/triangle.c:916:20: style: Parameter 'B' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/triangle.c:1069:14: style: Variable 'p1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/triangle.c:1069:20: style: Variable 'p2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/triangle.c:1069:26: style: Variable 'p3' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/tribox3.c:45:28: style: Parameter 'normal' can be declared as const array [constParameter] pcb-4.3.0/gts/tribox3.c:45:46: style: Parameter 'vert' can be declared as const array [constParameter] pcb-4.3.0/gts/tribox3.c:45:62: style: Parameter 'maxbox' can be declared as const array [constParameter] pcb-4.3.0/gts/tribox3.c:116:26: style: Parameter 'boxcenter' can be declared as const array [constParameter] pcb-4.3.0/gts/vertex.c:149:48: style: Parameter 'v' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/vertex.c:165:70: style: Parameter 'v2' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/vertex.c:167:12: style: Variable 'i' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/vertex.c:442:21: style: Parameter 'f' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/vertex.c:567:16: style: Parameter 'e1' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/vertex.c:667:16: style: Variable 'p1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/vertex.c:668:16: style: Variable 'p2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/vertex.c:669:16: style: Variable 'p' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/vopt.c:357:11: style: Local variable 'i' shadows outer variable [shadowVariable] pcb-4.3.0/gts/vopt.c:240:25: note: Shadowed declaration pcb-4.3.0/gts/vopt.c:357:11: note: Shadow variable pcb-4.3.0/gts/vopt.c:384:22: style: Local variable 'i' shadows outer variable [shadowVariable] pcb-4.3.0/gts/vopt.c:240:25: note: Shadowed declaration pcb-4.3.0/gts/vopt.c:384:22: note: Shadow variable pcb-4.3.0/gts/vopt.c:32:14: style: Variable 'p1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/vopt.c:32:20: style: Variable 'p2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/vopt.c:32:33: style: Variable 'p3' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/vopt.c:81:14: style: Variable 'p1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/vopt.c:81:20: style: Variable 'p2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/vopt.c:130:14: style: Variable 'p1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/vopt.c:130:20: style: Variable 'p2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/vopt.c:132:14: style: Variable 'p' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/vopt.c:238:34: style: Parameter 'params' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/vopt.c:391:18: style: Variable 'p1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/surface.c:247:17: warning: Opposite inner 'if' condition leads to a dead code block. [oppositeInnerCondition] pcb-4.3.0/gts/surface.c:246:15: note: outer condition: f->type==GTS_STRING pcb-4.3.0/gts/surface.c:247:17: note: opposite inner condition: f->type!=GTS_STRING pcb-4.3.0/gts/surface.c:1331:16: style: Local variable 't' shadows outer variable [shadowVariable] pcb-4.3.0/gts/surface.c:1307:19: note: Shadowed declaration pcb-4.3.0/gts/surface.c:1331:16: note: Shadow variable pcb-4.3.0/gts/surface.c:1387:18: style: Local variable 's' shadows outer variable [shadowVariable] pcb-4.3.0/gts/surface.c:1372:16: note: Shadowed declaration pcb-4.3.0/gts/surface.c:1387:18: note: Shadow variable pcb-4.3.0/gts/surface.c:1401:18: style: Local variable 's' shadows outer variable [shadowVariable] pcb-4.3.0/gts/surface.c:1372:16: note: Shadowed declaration pcb-4.3.0/gts/surface.c:1401:18: note: Shadow variable pcb-4.3.0/gts/surface.c:1460:12: style: Local variable 'e1' shadows outer variable [shadowVariable] pcb-4.3.0/gts/surface.c:1454:15: note: Shadowed declaration pcb-4.3.0/gts/surface.c:1460:12: note: Shadow variable pcb-4.3.0/gts/surface.c:2672:14: style: Local variable 'data' shadows outer argument [shadowArgument] pcb-4.3.0/gts/surface.c:2659:56: note: Shadowed declaration pcb-4.3.0/gts/surface.c:2672:14: note: Shadow variable pcb-4.3.0/gts/surface.c:2701:14: style: Local variable 'data' shadows outer argument [shadowArgument] pcb-4.3.0/gts/surface.c:2689:57: note: Shadowed declaration pcb-4.3.0/gts/surface.c:2701:14: note: Shadow variable pcb-4.3.0/gts/surface.c:49:40: style: Parameter 'object' can be declared as pointer to const. However it seems that 'surface_write' is a callback function, if 'object' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/surface.c:63:37: note: You might need to cast the function pointer here pcb-4.3.0/gts/surface.c:49:40: note: Parameter 'object' can be declared as pointer to const pcb-4.3.0/gts/surface.c:505:34: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/surface.c:1301:57: style: Parameter 'e' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/surface.c:1344:53: style: Parameter 'v1' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/surface.c:1710:15: style: Parameter 'min_number' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/surface.c:1733:15: style: Parameter 'max_cost' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/surface.c:1833:14: style: Variable 'p1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/surface.c:1833:20: style: Variable 'p2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/surface.c:2178:62: style: Parameter 'data' can be declared as pointer to const. However it seems that 'orientable_foreach_edge' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/surface.c:2218:42: note: You might need to cast the function pointer here pcb-4.3.0/gts/surface.c:2178:62: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/gts/surface.c:2226:14: style: Variable 'pa' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/surface.c:2226:20: style: Variable 'pb' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/surface.c:2226:26: style: Variable 'pc' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/surface.c:2257:18: style: Parameter 'data' can be declared as pointer to const. However it seems that 'center_of_mass_foreach_face' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/surface.c:2313:42: note: You might need to cast the function pointer here pcb-4.3.0/gts/surface.c:2257:18: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/gts/surface.c:2260:14: style: Variable 'p1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/surface.c:2260:20: style: Variable 'p2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/surface.c:2260:26: style: Variable 'p3' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/surface.c:2325:18: style: Parameter 'data' can be declared as pointer to const. However it seems that 'center_of_area_foreach_face' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/surface.c:2366:42: note: You might need to cast the function pointer here pcb-4.3.0/gts/surface.c:2325:18: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/gts/surface.c:2328:14: style: Variable 'p1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/surface.c:2328:20: style: Variable 'p2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/surface.c:2328:26: style: Variable 'p3' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/gts/surface.c:2642:57: style: Parameter 'data' can be declared as pointer to const. However it seems that 'non_manifold_edges' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/surface.c:2708:44: note: You might need to cast the function pointer here pcb-4.3.0/gts/surface.c:2642:57: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/gts/surface.c:2659:56: style: Parameter 'data' can be declared as pointer to const. However it seems that 'traverse_boundary' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/surface.c:2737:42: note: You might need to cast the function pointer here pcb-4.3.0/gts/surface.c:2659:56: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/gts/surface.c:2689:57: style: Parameter 'data' can be declared as pointer to const. However it seems that 'traverse_remaining' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/gts/surface.c:2740:42: note: You might need to cast the function pointer here pcb-4.3.0/gts/surface.c:2689:57: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/intl/bindtextdom.c:230:12: style: Local variable 'len' shadows outer variable [shadowVariable] pcb-4.3.0/intl/bindtextdom.c:202:14: note: Shadowed declaration pcb-4.3.0/intl/bindtextdom.c:230:12: note: Shadow variable pcb-4.3.0/intl/bindtextdom.c:259:15: style: Local variable 'len' shadows outer variable [shadowVariable] pcb-4.3.0/intl/bindtextdom.c:202:14: note: Shadowed declaration pcb-4.3.0/intl/bindtextdom.c:259:15: note: Shadow variable pcb-4.3.0/intl/finddomain.c:59:30: style:inconclusive: Function '_nl_find_domain' argument 1 names different: declaration '__dirname' definition 'dirname'. [funcArgNamesDifferent] pcb-4.3.0/intl/gettextP.h:255:54: note: Function '_nl_find_domain' argument 1 names different: declaration '__dirname' definition 'dirname'. pcb-4.3.0/intl/finddomain.c:59:30: note: Function '_nl_find_domain' argument 1 names different: declaration '__dirname' definition 'dirname'. pcb-4.3.0/intl/finddomain.c:59:45: style:inconclusive: Function '_nl_find_domain' argument 2 names different: declaration '__locale' definition 'locale'. [funcArgNamesDifferent] pcb-4.3.0/intl/gettextP.h:255:71: note: Function '_nl_find_domain' argument 2 names different: declaration '__locale' definition 'locale'. pcb-4.3.0/intl/finddomain.c:59:45: note: Function '_nl_find_domain' argument 2 names different: declaration '__locale' definition 'locale'. pcb-4.3.0/intl/finddomain.c:60:16: style:inconclusive: Function '_nl_find_domain' argument 3 names different: declaration '__domainname' definition 'domainname'. [funcArgNamesDifferent] pcb-4.3.0/intl/gettextP.h:256:19: note: Function '_nl_find_domain' argument 3 names different: declaration '__domainname' definition 'domainname'. pcb-4.3.0/intl/finddomain.c:60:16: note: Function '_nl_find_domain' argument 3 names different: declaration '__domainname' definition 'domainname'. pcb-4.3.0/intl/finddomain.c:60:44: style:inconclusive: Function '_nl_find_domain' argument 4 names different: declaration '__domainbinding' definition 'domainbinding'. [funcArgNamesDifferent] pcb-4.3.0/intl/gettextP.h:257:23: note: Function '_nl_find_domain' argument 4 names different: declaration '__domainbinding' definition 'domainbinding'. pcb-4.3.0/intl/finddomain.c:60:44: note: Function '_nl_find_domain' argument 4 names different: declaration '__domainbinding' definition 'domainbinding'. pcb-4.3.0/intl/l10nflist.c:319:12: style: Variable 'dir' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/intl/localcharset.c:443:14: style: Condition 'locale==NULL' is always true [knownConditionTrueFalse] pcb-4.3.0/intl/localcharset.c:434:24: note: Assignment 'locale=NULL', assigned value is 0 pcb-4.3.0/intl/localcharset.c:443:14: note: Condition 'locale==NULL' is always true pcb-4.3.0/intl/localcharset.c:184:19: error: Resource handle 'fd' freed twice. [doubleFree] pcb-4.3.0/intl/localcharset.c:180:20: note: Resource handle 'fd' freed twice. pcb-4.3.0/intl/localcharset.c:184:19: note: Resource handle 'fd' freed twice. pcb-4.3.0/intl/localealias.c:157:21: style: Variable 'retval' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/intl/localealias.c:259:13: style: Variable 'alias' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/intl/localealias.c:260:13: style: Variable 'value' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/intl/localealias.c:173:41: error: Uninitialized variable: &item.value [uninitvar] pcb-4.3.0/intl/loadmsgcat.c:868:12: style: The comparison 'data == (struct mo_file_header*)-1' is always true because 'data' and '(struct mo_file_header*)-1' represent the same value. [knownConditionTrueFalse] pcb-4.3.0/intl/loadmsgcat.c:796:33: note: 'data' is assigned value '(struct mo_file_header*)-1' here. pcb-4.3.0/intl/loadmsgcat.c:868:12: note: The comparison 'data == (struct mo_file_header*)-1' is always true because 'data' and '(struct mo_file_header*)-1' represent the same value. pcb-4.3.0/intl/loadmsgcat.c:785:42: style:inconclusive: Function '_nl_load_domain' argument 1 names different: declaration '__domain' definition 'domain_file'. [funcArgNamesDifferent] pcb-4.3.0/intl/gettextP.h:259:47: note: Function '_nl_load_domain' argument 1 names different: declaration '__domain' definition 'domain_file'. pcb-4.3.0/intl/loadmsgcat.c:785:42: note: Function '_nl_load_domain' argument 1 names different: declaration '__domain' definition 'domain_file'. pcb-4.3.0/intl/loadmsgcat.c:786:20: style:inconclusive: Function '_nl_load_domain' argument 2 names different: declaration '__domainbinding' definition 'domainbinding'. [funcArgNamesDifferent] pcb-4.3.0/intl/gettextP.h:260:25: note: Function '_nl_load_domain' argument 2 names different: declaration '__domainbinding' definition 'domainbinding'. pcb-4.3.0/intl/loadmsgcat.c:786:20: note: Function '_nl_load_domain' argument 2 names different: declaration '__domainbinding' definition 'domainbinding'. pcb-4.3.0/intl/localename.c:2950:14: style: Condition 'retval!=NULL' is always false [knownConditionTrueFalse] pcb-4.3.0/intl/localename.c:2949:34: note: Calling function 'gl_locale_name_thread' returns 0 pcb-4.3.0/intl/localename.c:2949:34: note: Assignment 'retval=gl_locale_name_thread(category,categoryname)', assigned value is 0 pcb-4.3.0/intl/localename.c:2950:14: note: Condition 'retval!=NULL' is always false pcb-4.3.0/intl/dcigettext.c:640:14: style: Obsolescent function 'getwd' called. It is recommended to use 'getcwd' instead. [prohibitedgetwdCalled] pcb-4.3.0/intl/dcigettext.c:689:39: style: Redundant condition: The condition 'categoryvalue[0] != '\0'' is redundant since 'categoryvalue[0] == ':'' is sufficient. [redundantCondition] pcb-4.3.0/intl/dcigettext.c:485:25: style:inconclusive: Function 'libintl_dcigettext' argument 1 names different: declaration '__domainname' definition 'domainname'. [funcArgNamesDifferent] pcb-4.3.0/intl/gettextP.h:78:46: note: Function 'libintl_dcigettext' argument 1 names different: declaration '__domainname' definition 'domainname'. pcb-4.3.0/intl/dcigettext.c:485:25: note: Function 'libintl_dcigettext' argument 1 names different: declaration '__domainname' definition 'domainname'. pcb-4.3.0/intl/dcigettext.c:485:49: style:inconclusive: Function 'libintl_dcigettext' argument 2 names different: declaration '__msgid1' definition 'msgid1'. [funcArgNamesDifferent] pcb-4.3.0/intl/gettextP.h:79:18: note: Function 'libintl_dcigettext' argument 2 names different: declaration '__msgid1' definition 'msgid1'. pcb-4.3.0/intl/dcigettext.c:485:49: note: Function 'libintl_dcigettext' argument 2 names different: declaration '__msgid1' definition 'msgid1'. pcb-4.3.0/intl/dcigettext.c:485:69: style:inconclusive: Function 'libintl_dcigettext' argument 3 names different: declaration '__msgid2' definition 'msgid2'. [funcArgNamesDifferent] pcb-4.3.0/intl/gettextP.h:79:40: note: Function 'libintl_dcigettext' argument 3 names different: declaration '__msgid2' definition 'msgid2'. pcb-4.3.0/intl/dcigettext.c:485:69: note: Function 'libintl_dcigettext' argument 3 names different: declaration '__msgid2' definition 'msgid2'. pcb-4.3.0/intl/dcigettext.c:486:10: style:inconclusive: Function 'libintl_dcigettext' argument 4 names different: declaration '__plural' definition 'plural'. [funcArgNamesDifferent] pcb-4.3.0/intl/gettextP.h:80:10: note: Function 'libintl_dcigettext' argument 4 names different: declaration '__plural' definition 'plural'. pcb-4.3.0/intl/dcigettext.c:486:10: note: Function 'libintl_dcigettext' argument 4 names different: declaration '__plural' definition 'plural'. pcb-4.3.0/intl/dcigettext.c:486:36: style:inconclusive: Function 'libintl_dcigettext' argument 5 names different: declaration '__n' definition 'n'. [funcArgNamesDifferent] pcb-4.3.0/intl/gettextP.h:80:38: note: Function 'libintl_dcigettext' argument 5 names different: declaration '__n' definition 'n'. pcb-4.3.0/intl/dcigettext.c:486:36: note: Function 'libintl_dcigettext' argument 5 names different: declaration '__n' definition 'n'. pcb-4.3.0/intl/dcigettext.c:486:43: style:inconclusive: Function 'libintl_dcigettext' argument 6 names different: declaration '__category' definition 'category'. [funcArgNamesDifferent] pcb-4.3.0/intl/gettextP.h:81:10: note: Function 'libintl_dcigettext' argument 6 names different: declaration '__category' definition 'category'. pcb-4.3.0/intl/dcigettext.c:486:43: note: Function 'libintl_dcigettext' argument 6 names different: declaration '__category' definition 'category'. pcb-4.3.0/intl/tsearch.c:182:8: style: Local variable 'root' shadows outer variable [shadowVariable] pcb-4.3.0/intl/dcigettext.c:275:14: note: Shadowed declaration pcb-4.3.0/intl/tsearch.c:182:8: note: Shadow variable pcb-4.3.0/intl/tsearch.c:282:12: style: Local variable 'root' shadows outer variable [shadowVariable] pcb-4.3.0/intl/dcigettext.c:275:14: note: Shadowed declaration pcb-4.3.0/intl/tsearch.c:282:12: note: Shadow variable pcb-4.3.0/intl/tsearch.c:343:12: style: Local variable 'root' shadows outer variable [shadowVariable] pcb-4.3.0/intl/dcigettext.c:275:14: note: Shadowed declaration pcb-4.3.0/intl/tsearch.c:343:12: note: Shadow variable pcb-4.3.0/intl/tsearch.c:368:8: style: Local variable 'root' shadows outer variable [shadowVariable] pcb-4.3.0/intl/dcigettext.c:275:14: note: Shadowed declaration pcb-4.3.0/intl/tsearch.c:368:8: note: Shadow variable pcb-4.3.0/intl/tsearch.c:618:14: style: Local variable 'root' shadows outer variable [shadowVariable] pcb-4.3.0/intl/dcigettext.c:275:14: note: Shadowed declaration pcb-4.3.0/intl/tsearch.c:618:14: note: Shadow variable pcb-4.3.0/intl/tsearch.c:641:14: style: Local variable 'root' shadows outer variable [shadowVariable] pcb-4.3.0/intl/dcigettext.c:275:14: note: Shadowed declaration pcb-4.3.0/intl/tsearch.c:641:14: note: Shadow variable pcb-4.3.0/intl/dcigettext.c:629:10: style: Variable 'ret' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/intl/dcigettext.c:1421:25: style: Variable 'domaindata' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/intl/os2compat.c:49:9: style: Variable 'root' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/intl/xsize.h:31:0: error: #error "Please include config.h first." [preprocessorErrorDirective] plural.c:1201:5: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] plural.y:154:21: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:156:28: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:162:96: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:170:71: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:178:72: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:186:89: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:194:89: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:202:89: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:210:89: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:218:48: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:235:42: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:380:29: style: Parameter 'arg' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/autoplace.c:387:20: style: Variable 'c' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/autoplace.c:131:17: style: struct member 'ElementPtrListType::element' is never used. [unusedStructMember] pcb-4.3.0/src/autoplace.c:132:12: style: struct member 'ElementPtrListType::elementN' is never used. [unusedStructMember] pcb-4.3.0/src/buffer.c:1004:2: portability: %d in format string (no. 1) requires 'int' but the argument type is 'Cardinal {aka unsigned int}'. [invalidPrintfArgType_sint] pcb-4.3.0/src/buffer.c:1048:4: portability: %d in format string (no. 1) requires 'int' but the argument type is 'Cardinal {aka unsigned int}'. [invalidPrintfArgType_sint] pcb-4.3.0/src/buffer.c:1078:4: portability: %d in format string (no. 1) requires 'int' but the argument type is 'Cardinal {aka unsigned int}'. [invalidPrintfArgType_sint] pcb-4.3.0/src/buffer.c:884:6: warning: Either the condition 'line' is redundant or there is possible null pointer dereference: line. [nullPointerRedundantCheck] pcb-4.3.0/src/buffer.c:887:9: note: Assuming that condition 'line' is not redundant pcb-4.3.0/src/buffer.c:884:6: note: Null pointer dereference pcb-4.3.0/src/buffer.c:885:6: warning: Either the condition 'line' is redundant or there is possible null pointer dereference: line. [nullPointerRedundantCheck] pcb-4.3.0/src/buffer.c:887:9: note: Assuming that condition 'line' is not redundant pcb-4.3.0/src/buffer.c:885:6: note: Null pointer dereference pcb-4.3.0/src/buffer.c:886:6: warning: Either the condition 'line' is redundant or there is possible null pointer dereference: line. [nullPointerRedundantCheck] pcb-4.3.0/src/buffer.c:887:9: note: Assuming that condition 'line' is not redundant pcb-4.3.0/src/buffer.c:886:6: note: Null pointer dereference pcb-4.3.0/src/buffer.c:1449:13: style: Redundant assignment of 'Buffer->X' to itself. [selfAssignment] pcb-4.3.0/src/buffer.c:1453:12: style: Redundant assignment of 'via->X' to itself. [selfAssignment] pcb-4.3.0/src/buffer.c:1459:20: style: Redundant assignment of 'line->Point1.X' to itself. [selfAssignment] pcb-4.3.0/src/buffer.c:1461:20: style: Redundant assignment of 'line->Point2.X' to itself. [selfAssignment] pcb-4.3.0/src/buffer.c:1468:12: style: Redundant assignment of 'arc->X' to itself. [selfAssignment] pcb-4.3.0/src/buffer.c:1481:16: style: Redundant assignment of 'point->X' to itself. [selfAssignment] pcb-4.3.0/src/buffer.c:1511:13: style: Redundant assignment of 'Buffer->X' to itself. [selfAssignment] pcb-4.3.0/src/buffer.c:1516:12: style: Redundant assignment of 'via->X' to itself. [selfAssignment] pcb-4.3.0/src/buffer.c:1525:20: style: Redundant assignment of 'line->Point1.X' to itself. [selfAssignment] pcb-4.3.0/src/buffer.c:1527:20: style: Redundant assignment of 'line->Point2.X' to itself. [selfAssignment] pcb-4.3.0/src/buffer.c:1536:12: style: Redundant assignment of 'arc->X' to itself. [selfAssignment] pcb-4.3.0/src/buffer.c:1549:16: style: Redundant assignment of 'point->X' to itself. [selfAssignment] pcb-4.3.0/src/buffer.c:1561:13: style: Redundant assignment of 'text->X' to itself. [selfAssignment] pcb-4.3.0/src/buffer.c:726:41: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-4.3.0/src/buffer.c:752:63: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-4.3.0/src/buffer.c:1600:11: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/buffer.c:1601:11: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/buffer.c:1608:11: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/buffer.c:1609:11: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/buffer.c:417:12: style: Variable 'box' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/buffer.c:563:23: style: Variable 'a' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/buffer.c:564:23: style: Variable 'b' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/buffer.c:815:9: style: Variable 'refdes' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/buffer.c:816:9: style: Variable 'value' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/buffer.c:1382:9: style: Variable 'angle_s' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/buffer.c:1441:18: style: Variable 'layer' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/change.c:853:46: style: Same expression in both branches of ternary operator. [duplicateExpressionTernary] pcb-4.3.0/src/change.c:932:46: style: Same expression in both branches of ternary operator. [duplicateExpressionTernary] pcb-4.3.0/src/change.c:1037:29: style: Parameter 'pcb' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/create.c:717:38: style:inconclusive: Function 'CreateNewHoleInPolygon' argument 1 names different: declaration 'polygon' definition 'Polygon'. [funcArgNamesDifferent] pcb-4.3.0/src/create.h:54:52: note: Function 'CreateNewHoleInPolygon' argument 1 names different: declaration 'polygon' definition 'Polygon'. pcb-4.3.0/src/create.c:717:38: note: Function 'CreateNewHoleInPolygon' argument 1 names different: declaration 'polygon' definition 'Polygon'. pcb-4.3.0/src/create.c:258:34: style: Parameter 'Name' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/create.c:651:46: style: Parameter 'TextString' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/create.c:909:26: style: Parameter 'Name' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/create.c:909:38: style: Parameter 'Number' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/create.c:948:31: style: Parameter 'TextString' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/create.c:1031:39: style: Parameter 'name' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/create.c:1031:51: style: Parameter 'style' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/create.c:1051:50: style: Parameter 'conn' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/create.c:1063:52: style: Parameter 'name' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/create.c:1063:64: style: Parameter 'value' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/create.c:1089:9: style: Variable 'x_str' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/create.c:1090:9: style: Variable 'y_str' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/create.c:1091:9: style: Variable 'units' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/create.c:1094:12: style: Variable 'via' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:7461:21: style: Obsolescent function 'tmpnam' called. It is recommended to use 'tmpfile', 'mkstemp' or 'mkdtemp' instead. [prohibitedtmpnamCalled] pcb-4.3.0/src/action.c:7611:32: warning: Obsolete function 'alloca' called. In C99 and later it is recommended to use a variable length array instead. [allocaCalled] pcb-4.3.0/src/action.c:7649:10: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] pcb-4.3.0/src/action.c:7661:15: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] pcb-4.3.0/src/action.c:7743:18: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] pcb-4.3.0/src/action.c:7755:23: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] pcb-4.3.0/src/action.c:6392:12: style: Condition 'function' is always true [knownConditionTrueFalse] pcb-4.3.0/src/action.c:7185:12: style: Condition 'e' is always true [knownConditionTrueFalse] pcb-4.3.0/src/action.c:3331:21: warning: Either the condition 'name' is redundant or there is possible null pointer dereference: name. [nullPointerRedundantCheck] pcb-4.3.0/src/action.c:3336:21: note: Assuming that condition 'name' is not redundant pcb-4.3.0/src/action.c:3331:21: note: Null pointer dereference pcb-4.3.0/src/action.c:3342:21: warning: Either the condition 'name' is redundant or there is possible null pointer dereference: name. [nullPointerRedundantCheck] pcb-4.3.0/src/action.c:3345:24: note: Assuming that condition 'name' is not redundant pcb-4.3.0/src/action.c:3342:21: note: Null pointer dereference pcb-4.3.0/src/action.c:6164:26: warning: Either the condition 'name' is redundant or there is possible null pointer dereference: name. [nullPointerRedundantCheck] pcb-4.3.0/src/action.c:6151:13: note: Assuming that condition 'name' is not redundant pcb-4.3.0/src/action.c:6164:26: note: Null pointer dereference pcb-4.3.0/src/action.c:4034:18: style: Variable 'Marked.status' is reassigned a value before the old one has been used. [redundantAssignment] pcb-4.3.0/src/action.c:4033:18: note: Marked.status is assigned pcb-4.3.0/src/action.c:4034:18: note: Marked.status is overwritten pcb-4.3.0/src/action.c:1169:37: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-4.3.0/src/action.c:1184:37: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-4.3.0/src/action.c:7601:37: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-4.3.0/src/action.c:7605:50: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-4.3.0/src/action.c:7751:41: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-4.3.0/src/action.c:7754:48: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-4.3.0/src/action.c:7769:43: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-4.3.0/src/action.c:8139:45: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-4.3.0/src/action.c:8141:39: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-4.3.0/src/action.c:668:15: style: Local variable 'box' shadows outer variable [shadowVariable] pcb-4.3.0/src/action.c:664:11: note: Shadowed declaration pcb-4.3.0/src/action.c:668:15: note: Shadow variable pcb-4.3.0/src/action.c:1583:10: style: Local variable 'type' shadows outer variable [shadowVariable] pcb-4.3.0/src/action.c:990:7: note: Shadowed declaration pcb-4.3.0/src/action.c:1583:10: note: Shadow variable pcb-4.3.0/src/action.c:1605:10: style: Local variable 'type' shadows outer variable [shadowVariable] pcb-4.3.0/src/action.c:990:7: note: Shadowed declaration pcb-4.3.0/src/action.c:1605:10: note: Shadow variable pcb-4.3.0/src/action.c:3073:10: style: Local variable 'saved_mode' shadows outer variable [shadowVariable] pcb-4.3.0/src/action.c:333:13: note: Shadowed declaration pcb-4.3.0/src/action.c:3073:10: note: Shadow variable pcb-4.3.0/src/action.c:5522:12: style: Local variable 'x' shadows outer argument [shadowArgument] pcb-4.3.0/src/action.c:5396:44: note: Shadowed declaration pcb-4.3.0/src/action.c:5522:12: note: Shadow variable pcb-4.3.0/src/action.c:5522:15: style: Local variable 'y' shadows outer argument [shadowArgument] pcb-4.3.0/src/action.c:5396:53: note: Shadowed declaration pcb-4.3.0/src/action.c:5522:15: note: Shadow variable pcb-4.3.0/src/action.c:6182:12: style: Local variable 'x' shadows outer argument [shadowArgument] pcb-4.3.0/src/action.c:6085:49: note: Shadowed declaration pcb-4.3.0/src/action.c:6182:12: note: Shadow variable pcb-4.3.0/src/action.c:6182:15: style: Local variable 'y' shadows outer argument [shadowArgument] pcb-4.3.0/src/action.c:6085:58: note: Shadowed declaration pcb-4.3.0/src/action.c:6182:15: note: Shadow variable pcb-4.3.0/src/action.c:7934:13: style: Local variable 'x' shadows outer argument [shadowArgument] pcb-4.3.0/src/action.c:7895:44: note: Shadowed declaration pcb-4.3.0/src/action.c:7934:13: note: Shadow variable pcb-4.3.0/src/action.c:7934:16: style: Local variable 'y' shadows outer argument [shadowArgument] pcb-4.3.0/src/action.c:7895:53: note: Shadowed declaration pcb-4.3.0/src/action.c:7934:16: note: Shadow variable pcb-4.3.0/src/action.c:838:14: style: Variable 'pnt' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:918:13: style: Variable 'pad' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:1444:13: style: Variable 'points' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:1510:19: style: Variable 'points' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:2048:9: style: Variable 'style' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:2263:9: style: Variable 'force' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:2640:20: style: Variable 'str_dir' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:4076:9: style: Variable 'delta' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:4077:9: style: Variable 'units' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:4171:9: style: Variable 'delta' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:4172:9: style: Variable 'units' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:4238:9: style: Variable 'delta' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:4239:9: style: Variable 'units' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:4317:9: style: Variable 'units' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:4413:9: style: Variable 'units' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:4521:9: style: Variable 'refdes' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:4521:18: style: Variable 'pinnum' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:4521:27: style: Variable 'pinname' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:5756:9: style: Variable 'function' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:5907:9: style: Variable 'function' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:6088:9: style: Variable 'sbufnum' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:6373:17: style: Variable 'bx' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:6516:9: style: Variable 'str' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:6558:9: style: Variable 'x_str' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:6559:9: style: Variable 'y_str' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:6560:9: style: Variable 'units' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:6913:9: style: Variable 'fname' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:6983:31: style: Parameter 'refdes' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/action.c:7073:9: style: Variable 'function' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:7327:9: style: Variable 'command' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:7399:27: style: Parameter 'name' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/action.c:7909:18: style: Variable 'units' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:8016:13: style: Variable 'pcbname' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:8018:19: style: Variable 'slash' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:8018:27: style: Variable 'bslash' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/action.c:4720:16: style: Variable 'type' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/action.c:5272:16: style: Variable 'type' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/action.c:5321:16: style: Variable 'type' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/action.c:6355:10: style: Variable 'ptr2' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/action.c:8432:12: style: Variable 'type' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/crosshair.c:1225:41: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-4.3.0/src/crosshair.c:70:39: style: Parameter 'pv' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/crosshair.c:379:13: style: Variable 'box' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/crosshair.c:484:13: style: Variable 'point' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/crosshair.c:500:13: style: Variable 'point' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/crosshair.c:535:11: style: Variable 'box' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/crosshair.c:555:27: style: Variable 'point2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/crosshair.c:862:35: style: Parameter 'crosshair' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/crosshair.c:1090:18: style: Variable 'desired_layer' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/crosshair.c:1110:7: style: Variable 'layer' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/crosshair.c:1276:12: style: Variable 'box' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/crosshair.c:61:7: style: struct member 'point::x' is never used. [unusedStructMember] pcb-4.3.0/src/crosshair.c:61:10: style: struct member 'point::y' is never used. [unusedStructMember] pcb-4.3.0/src/dbus-pcbmain.c:251:43: style: Parameter 'conn' can be declared as pointer to const. However it seems that 'dispatch_status_changed' is a callback function, if 'conn' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/dbus-pcbmain.c:306:7: note: You might need to cast the function pointer here pcb-4.3.0/src/dbus-pcbmain.c:251:43: note: Parameter 'conn' can be declared as pointer to const pcb-4.3.0/src/dbus-pcbmain.c:252:11: style: Parameter 'data' can be declared as pointer to const. However it seems that 'dispatch_status_changed' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/dbus-pcbmain.c:306:7: note: You might need to cast the function pointer here pcb-4.3.0/src/dbus-pcbmain.c:252:11: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/src/dbus.c:227:43: style: Parameter 'connection' can be declared as pointer to const. However it seems that 'unregister_dbus_handler' is a callback function, if 'connection' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/dbus.c:334:5: note: You might need to cast the function pointer here pcb-4.3.0/src/dbus.c:227:43: note: Parameter 'connection' can be declared as pointer to const pcb-4.3.0/src/dbus.c:227:61: style: Parameter 'data' can be declared as pointer to const. However it seems that 'unregister_dbus_handler' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/dbus.c:334:5: note: You might need to cast the function pointer here pcb-4.3.0/src/dbus.c:227:61: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/src/draw.c:1190:3: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] pcb-4.3.0/src/draw.c:1195:3: note: Found duplicate branches for 'if' and 'else'. pcb-4.3.0/src/draw.c:1190:3: note: Found duplicate branches for 'if' and 'else'. pcb-4.3.0/src/draw.c:1001:36: style:inconclusive: Function 'DrawMask' argument 2 names different: declaration 'drawn_area' definition 'screen'. [funcArgNamesDifferent] pcb-4.3.0/src/draw.h:76:41: note: Function 'DrawMask' argument 2 names different: declaration 'drawn_area' definition 'screen'. pcb-4.3.0/src/draw.c:1001:36: note: Function 'DrawMask' argument 2 names different: declaration 'drawn_area' definition 'screen'. pcb-4.3.0/src/draw.c:1148:21: style:inconclusive: Function 'DrawLayerGroup' argument 1 names different: declaration 'side' definition 'group'. [funcArgNamesDifferent] pcb-4.3.0/src/draw.h:73:26: note: Function 'DrawLayerGroup' argument 1 names different: declaration 'side' definition 'group'. pcb-4.3.0/src/draw.c:1148:21: note: Function 'DrawLayerGroup' argument 1 names different: declaration 'side' definition 'group'. pcb-4.3.0/src/draw.c:1690:28: style:inconclusive: Function 'hid_expose_callback' argument 1 names different: declaration 'hid_' definition 'hid'. [funcArgNamesDifferent] pcb-4.3.0/src/hid.h:825:35: note: Function 'hid_expose_callback' argument 1 names different: declaration 'hid_' definition 'hid'. pcb-4.3.0/src/draw.c:1690:28: note: Function 'hid_expose_callback' argument 1 names different: declaration 'hid_' definition 'hid'. pcb-4.3.0/src/draw.c:1690:43: style:inconclusive: Function 'hid_expose_callback' argument 2 names different: declaration 'region_' definition 'region'. [funcArgNamesDifferent] pcb-4.3.0/src/hid.h:825:57: note: Function 'hid_expose_callback' argument 2 names different: declaration 'region_' definition 'region'. pcb-4.3.0/src/draw.c:1690:43: note: Function 'hid_expose_callback' argument 2 names different: declaration 'region_' definition 'region'. pcb-4.3.0/src/draw.c:1690:57: style:inconclusive: Function 'hid_expose_callback' argument 3 names different: declaration 'item_' definition 'item'. [funcArgNamesDifferent] pcb-4.3.0/src/hid.h:825:72: note: Function 'hid_expose_callback' argument 3 names different: declaration 'item_' definition 'item'. pcb-4.3.0/src/draw.c:1690:57: note: Function 'hid_expose_callback' argument 3 names different: declaration 'item_' definition 'item'. pcb-4.3.0/src/draw.c:92:34: style: Parameter 'obj' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/draw.c:350:8: style: Variable 'side' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/draw.c:379:8: style: Variable 'side' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/draw.c:426:14: style: Variable 'hi' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/draw.c:592:8: style: Variable 'side' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/draw.c:641:18: style: Variable 'l' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/draw.c:807:16: style: Variable 'pin0' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/draw.c:816:16: style: Variable 'pad0' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/draw.c:932:8: style: Variable 'side' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/draw.c:1154:13: style: Variable 'layers' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/draw.c:1690:43: style: Parameter 'region' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/drc/drc.c:59:34: style:inconclusive: Function 'SetThing' argument 3 names different: declaration 'p1' definition 'ptr1'. [funcArgNamesDifferent] pcb-4.3.0/src/drc/drc.h:43:38: note: Function 'SetThing' argument 3 names different: declaration 'p1' definition 'ptr1'. pcb-4.3.0/src/drc/drc.c:59:34: note: Function 'SetThing' argument 3 names different: declaration 'p1' definition 'ptr1'. pcb-4.3.0/src/drc/drc.c:59:46: style:inconclusive: Function 'SetThing' argument 4 names different: declaration 'p2' definition 'ptr2'. [funcArgNamesDifferent] pcb-4.3.0/src/drc/drc.h:43:48: note: Function 'SetThing' argument 4 names different: declaration 'p2' definition 'ptr2'. pcb-4.3.0/src/drc/drc.c:59:46: note: Function 'SetThing' argument 4 names different: declaration 'p2' definition 'ptr2'. pcb-4.3.0/src/drc/drc.c:59:58: style:inconclusive: Function 'SetThing' argument 5 names different: declaration 'p3' definition 'ptr3'. [funcArgNamesDifferent] pcb-4.3.0/src/drc/drc.h:43:58: note: Function 'SetThing' argument 5 names different: declaration 'p3' definition 'ptr3'. pcb-4.3.0/src/drc/drc.c:59:58: note: Function 'SetThing' argument 5 names different: declaration 'p3' definition 'ptr3'. pcb-4.3.0/src/drc/drc.c:89:10: style: Variable 'v' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/drc/drc.c:1023:13: style: Variable 'title' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/drc/drc.c:1024:13: style: Variable 'name' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/drc/drc.c:1146:15: style: Variable 'len' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/drc/drc.c:1180:16: style: Variable 'cont' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/drc/drc_violation.c:188:46: warning: Either the condition 'violation->objects' is redundant or there is possible null pointer dereference: violation->objects. [nullPointerRedundantCheck] pcb-4.3.0/src/drc/drc_violation.c:190:16: note: Assuming that condition 'violation->objects' is not redundant pcb-4.3.0/src/drc/drc_violation.c:188:46: note: Null pointer dereference pcb-4.3.0/src/drc/drc_violation.c:272:5: style: Variable 'r' is reassigned a value before the old one has been used. [redundantAssignment] pcb-4.3.0/src/drc/drc_violation.c:262:5: note: r is assigned pcb-4.3.0/src/drc/drc_violation.c:272:5: note: r is overwritten pcb-4.3.0/src/drc/drc_violation.c:124:14: style: Variable 'oa' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/drc/drc_violation.c:124:19: style: Variable 'ob' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/drc/drc_violation.c:179:15: style: Variable 'obj' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/drc/drc_violation.c:284:18: style: Variable 't1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/drc/drc_violation.c:126:16: style: Variable 'j' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/drc/drc_violation.c:127:13: style: Variable 'found' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/drc/drc_violation.c:178:9: style: Variable 'i' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/drc/drc_violation.c:283:21: style: Variable 'b' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/drill.c:113:14: style: Variable 'a' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/drill.c:114:14: style: Variable 'b' can be declared as pointer to const [constVariablePointer] edif.c:3488:5: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] edif.y:4012:30: error: Uninitialized variables: (bck=CurrentBucket)->Index.Next, (bck=CurrentBucket)->Index.Index [uninitvar] edif.y:4041:3: error: Memory is allocated but not initialized: cp [uninitdata] edif.c:3488:11: style: Variable 'yymsg' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/autoroute.c:4924:13: warning: Assert statement calls a function which may have desired side effects: 'no_expansion_boxes'. [assertWithSideEffect] pcb-4.3.0/src/autoroute.c:3480:9: style: Condition '1||!AutoRouteParameters.is_smoothing' is always true [knownConditionTrueFalse] pcb-4.3.0/src/autoroute.c:5012:16: style: Condition 'smoothes' is always true [knownConditionTrueFalse] pcb-4.3.0/src/autoroute.c:5014:53: style: Condition 'ipasses' is not redundant pcb-4.3.0/src/autoroute.c:5014:53: note: Condition 'is' is redundant or there is possible null pointer dereference: l->s. [nullPointerRedundantCheck] pcb-4.3.0/src/djopt.c:2820:11: note: Calling function 'line_orient', 2nd argument '0' value is 0 pcb-4.3.0/src/djopt.c:414:9: note: Assuming that condition 'c==l->s' is not redundant pcb-4.3.0/src/djopt.c:416:13: note: Null pointer dereference pcb-4.3.0/src/djopt.c:417:13: warning: Either the condition 'c==l->s' is redundant or there is possible null pointer dereference: l->s. [nullPointerRedundantCheck] pcb-4.3.0/src/djopt.c:2820:11: note: Calling function 'line_orient', 2nd argument '0' value is 0 pcb-4.3.0/src/djopt.c:414:9: note: Assuming that condition 'c==l->s' is not redundant pcb-4.3.0/src/djopt.c:417:13: note: Null pointer dereference pcb-4.3.0/src/djopt.c:2028:11: warning: Possible null pointer dereference: c2 [nullPointer] pcb-4.3.0/src/djopt.c:2012:12: note: Assignment 'c2=0', assigned value is 0 pcb-4.3.0/src/djopt.c:2013:21: note: Assuming condition is false pcb-4.3.0/src/djopt.c:2028:11: note: Null pointer dereference pcb-4.3.0/src/djopt.c:2212:49: style: Same expression '!c->via' found multiple times in chain of '&&' operators. [duplicateExpression] pcb-4.3.0/src/djopt.c:2066:7: style: 'continue' is redundant since it is the last statement in a loop. [redundantContinue] pcb-4.3.0/src/djopt.c:2174:7: style: 'continue' is redundant since it is the last statement in a loop. [redundantContinue] pcb-4.3.0/src/djopt.c:1533:8: style: Local variable 'len' shadows outer variable [shadowVariable] pcb-4.3.0/src/djopt.c:1258:12: note: Shadowed declaration pcb-4.3.0/src/djopt.c:1533:8: note: Shadow variable pcb-4.3.0/src/djopt.c:1573:14: style: Local variable 'l' shadows outer variable [shadowVariable] pcb-4.3.0/src/djopt.c:1254:11: note: Shadowed declaration pcb-4.3.0/src/djopt.c:1573:14: note: Shadow variable pcb-4.3.0/src/djopt.c:2238:17: style: Local variable 'dist' shadows outer function [shadowFunction] pcb-4.3.0/src/djopt.c:338:1: note: Shadowed declaration pcb-4.3.0/src/djopt.c:2238:17: note: Shadow variable pcb-4.3.0/src/djopt.c:2697:15: style: Local variable 'l' shadows outer variable [shadowVariable] pcb-4.3.0/src/djopt.c:2570:7: note: Shadowed declaration pcb-4.3.0/src/djopt.c:2697:15: note: Shadow variable pcb-4.3.0/src/djopt.c:152:28: style: Parameter 'data' can be declared as pointer to const. However it seems that 'djopt_get_auto_only' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/djopt.c:158:19: note: You might need to cast the function pointer here pcb-4.3.0/src/djopt.c:152:28: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/src/djopt.c:164:30: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/djopt.c:349:23: style: Parameter 'l' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/djopt.c:383:44: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/djopt.c:411:37: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/djopt.c:458:38: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/djopt.c:529:16: style: Variable 'to' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/djopt.c:626:36: style: Parameter 'l' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/djopt.c:664:43: style: Parameter 'l' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/djopt.c:671:23: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/djopt.c:685:36: style: Parameter 'l' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/djopt.c:708:27: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/djopt.c:1241:21: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/djopt.c:1574:16: style: Variable 'oc' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/djopt.c:1686:17: style: Variable 'c1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/djopt.c:1686:22: style: Variable 'c2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/djopt.c:2239:18: style: Variable 'closest_corner' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/djopt.c:2239:44: style: Variable 'oc1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/djopt.c:2239:50: style: Variable 'oc2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/djopt.c:2572:12: style: Variable 'pin' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/djopt.c:2773:23: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/djopt.c:3000:9: style: Variable 'arg' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/djopt.c:906:7: style: Variable 'i' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/flags.c:421:138: warning: Result of operator '|' is always true if one operand is non-zero. Did you intend to use '&'? [badBitmaskCheck] pcb-4.3.0/src/flags.c:421:14: style: Condition 'type' is always true [knownConditionTrueFalse] pcb-4.3.0/src/flags.c:138:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/flags.c:284:9: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/flags.c:297:11: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/flags.c:308:11: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/flags.c:334:9: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/flags.c:345:9: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/flags.c:356:9: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/flags.c:367:9: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/flags.c:65:24: style: Parameter 'f1' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/flags.c:65:38: style: Parameter 'f2' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/flags.c:74:25: style: Parameter 'data' can be declared as pointer to const. However it seems that 'FlagCurrentStyle' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/flags.c:442:28: note: You might need to cast the function pointer here pcb-4.3.0/src/flags.c:74:25: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/src/flags.c:76:3: style: Variable 'style' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/flags.c:89:17: style: Parameter 'data' can be declared as pointer to const. However it seems that 'FlagGrid' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/flags.c:443:28: note: You might need to cast the function pointer here pcb-4.3.0/src/flags.c:89:17: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/src/flags.c:95:21: style: Parameter 'data' can be declared as pointer to const. However it seems that 'FlagGridSize' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/flags.c:444:28: note: You might need to cast the function pointer here pcb-4.3.0/src/flags.c:95:21: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/src/flags.c:101:20: style: Parameter 'data' can be declared as pointer to const. However it seems that 'FlagUnitsMm' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/flags.c:502:28: note: You might need to cast the function pointer here pcb-4.3.0/src/flags.c:101:20: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/src/flags.c:110:21: style: Parameter 'data' can be declared as pointer to const. However it seems that 'FlagUnitsMil' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/flags.c:503:28: note: You might need to cast the function pointer here pcb-4.3.0/src/flags.c:110:21: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/src/flags.c:119:19: style: Parameter 'data' can be declared as pointer to const. However it seems that 'FlagBuffer' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/flags.c:521:28: note: You might need to cast the function pointer here pcb-4.3.0/src/flags.c:119:19: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/src/flags.c:125:25: style: Parameter 'data' can be declared as pointer to const. However it seems that 'FlagElementName' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/flags.c:445:28: note: You might need to cast the function pointer here pcb-4.3.0/src/flags.c:125:25: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/src/flags.c:158:22: style: Parameter 'data' can be declared as pointer to const. However it seems that 'FlagHaveRegex' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/flags.c:446:28: note: You might need to cast the function pointer here pcb-4.3.0/src/flags.c:158:22: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/src/flags.c:217:29: style: Parameter 'ptr' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/flags.c:403:12: style: Variable 'type' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/free_atexit.c:70:3: error: Common realloc mistake: 'free_list' nulled but not freed upon failure [memleakOnRealloc] pcb-4.3.0/src/free_atexit.c:75:21: portability: 'new_memory' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer] pcb-4.3.0/src/free_atexit.c:102:14: portability: 'old_memory' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer] pcb-4.3.0/src/free_atexit.c:109:21: portability: 'new_memory' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer] pcb-4.3.0/src/free_atexit.c:54:15: style: union member 'leaky_admin_t::idx' is never used. [unusedStructMember] pcb-4.3.0/src/free_atexit.c:55:9: style: union member 'leaky_admin_t::ptr' is never used. [unusedStructMember] pcb-4.3.0/src/heap.c:100:26: style: Parameter 'heap' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/batch/batch.c:150:1: error: There is an unknown macro here somewhere. Configuration is required. If REGISTER_ACTIONS is a macro then please configure it. [unknownMacro] pcb-4.3.0/src/hid/bom/bom.c:510:47: portability: Non reentrant function 'gmtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'gmtime_r'. [prohibitedgmtimeCalled] pcb-4.3.0/src/hid/bom/bom.c:447:8: error: Common realloc mistake: 'attr_list' nulled but not freed upon failure [memleakOnRealloc] pcb-4.3.0/src/hid/bom/bom.c:509:17: style: Local variable 'fmt' shadows outer variable [shadowVariable] pcb-4.3.0/src/hid/bom/bom.c:491:8: note: Shadowed declaration pcb-4.3.0/src/hid/bom/bom.c:509:17: note: Shadow variable pcb-4.3.0/src/hid/bom/bom.c:188:23: style: Parameter 'in' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/bom/bom.c:264:22: style: Parameter 'str' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/bom/bom.c:415:9: style: Variable 'fname' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/hid/bom/bom.c:488:31: style: Variable 'fixed_rotation' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/hid/bom/bom.c:473:16: style: Variable 'theta' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/hid/bom/bom.c:621:39: style: Variable 'found_any_not_at_centroid' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/hid/bom/bom.c:622:23: style: Variable 'found_any' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/hid/bom_md/bom_md.c:413:47: portability: Non reentrant function 'gmtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'gmtime_r'. [prohibitedgmtimeCalled] pcb-4.3.0/src/hid/bom_md/bom_md.c:381:13: error: Common realloc mistake: 'attr_list' nulled but not freed upon failure [memleakOnRealloc] pcb-4.3.0/src/hid/bom_md/bom_md.c:315:14: warning: Either the condition 'fp' is redundant or there is possible null pointer dereference: fp. [nullPointerRedundantCheck] pcb-4.3.0/src/hid/bom_md/bom_md.c:317:9: note: Assuming that condition 'fp' is not redundant pcb-4.3.0/src/hid/bom_md/bom_md.c:315:14: note: Null pointer dereference pcb-4.3.0/src/hid/bom_md/bom_md.c:147:28: style: Parameter 'in' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/bom_md/bom_md.c:178:29: style: Parameter 'str' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/bom_md/bom_md.c:342:9: style: Variable 'fname' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/hid/bom_md/bom_md.c:401:9: style: Variable 'name' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/hid/bom_md/bom_md.c:401:16: style: Variable 'descr' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/hid/bom_md/bom_md.c:401:24: style: Variable 'value' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/hid/bom_md/bom_md.c:451:10: style: Variable 'name' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/hid/bom_md/bom_md.c:452:11: style: Variable 'descr' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/hid/bom_md/bom_md.c:453:11: style: Variable 'value' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/hid/common/draw_helpers.c:260:53: style:inconclusive: Function 'common_gui_draw_pcb_polygon' argument 2 names different: declaration 'poly' definition 'polygon'. [funcArgNamesDifferent] pcb-4.3.0/src/hid/common/draw_helpers.h:3:58: note: Function 'common_gui_draw_pcb_polygon' argument 2 names different: declaration 'poly' definition 'polygon'. pcb-4.3.0/src/hid/common/draw_helpers.c:260:53: note: Function 'common_gui_draw_pcb_polygon' argument 2 names different: declaration 'poly' definition 'polygon'. pcb-4.3.0/src/hid/common/draw_helpers.c:582:11: style: Local variable 'i' shadows outer variable [shadowVariable] pcb-4.3.0/src/hid/common/draw_helpers.c:562:7: note: Shadowed declaration pcb-4.3.0/src/hid/common/draw_helpers.c:582:11: note: Shadow variable pcb-4.3.0/src/hid/common/draw_helpers.c:619:13: style: Local variable 'r' shadows outer variable [shadowVariable] pcb-4.3.0/src/hid/common/draw_helpers.c:599:9: note: Shadowed declaration pcb-4.3.0/src/hid/common/draw_helpers.c:619:13: note: Shadow variable pcb-4.3.0/src/hid/common/draw_helpers.c:658:13: style: Local variable 'r' shadows outer variable [shadowVariable] pcb-4.3.0/src/hid/common/draw_helpers.c:638:9: note: Shadowed declaration pcb-4.3.0/src/hid/common/draw_helpers.c:658:13: note: Shadow variable pcb-4.3.0/src/hid/common/actions.c:41:3: error: Common realloc mistake: 'all_actions' nulled but not freed upon failure [memleakOnRealloc] pcb-4.3.0/src/hid/common/actions.c:352:3: error: Common realloc mistake: 'list' nulled but not freed upon failure [memleakOnRealloc] pcb-4.3.0/src/hid/common/actions.c:222:11: style: Local variable 'i' shadows outer variable [shadowVariable] pcb-4.3.0/src/hid/common/actions.c:213:7: note: Shadowed declaration pcb-4.3.0/src/hid/common/actions.c:222:11: note: Shadow variable pcb-4.3.0/src/hid/common/actions.c:66:15: style: Variable 'a' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/hid/common/actions.c:67:15: style: Variable 'b' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/hid/common/actions.c:81:9: style: Variable 'name' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/hid/common/actions.c:82:15: style: Variable 'action' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/hid/common/actions.c:257:14: style: Variable 'aname' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/hid/common/actions.c:130:12: style: Variable 'eb' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/hid/common/extents.c:136:54: style: Parameter 'x' can be declared as pointer to const. However it seems that 'extents_fill_polygon' is a callback function, if 'x' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/common/extents.c:191:37: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/common/extents.c:136:54: note: Parameter 'x' can be declared as pointer to const pcb-4.3.0/src/hid/common/extents.c:136:64: style: Parameter 'y' can be declared as pointer to const. However it seems that 'extents_fill_polygon' is a callback function, if 'y' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/common/extents.c:191:37: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/common/extents.c:136:64: note: Parameter 'y' can be declared as pointer to const pcb-4.3.0/src/hid/common/flags.c:109:4: error: Common realloc mistake: 'buf' nulled but not freed upon failure [memleakOnRealloc] pcb-4.3.0/src/hid/common/flags.c:111:15: warning: Possible null pointer dereference: buf [nullPointer] pcb-4.3.0/src/hid/common/flags.c:96:22: note: Assignment 'buf=0', assigned value is 0 pcb-4.3.0/src/hid/common/flags.c:106:16: note: Assuming condition is false pcb-4.3.0/src/hid/common/flags.c:111:15: note: Null pointer dereference pcb-4.3.0/src/hid/common/flags.c:112:7: warning: Possible null pointer dereference: buf [nullPointer] pcb-4.3.0/src/hid/common/flags.c:96:22: note: Assignment 'buf=0', assigned value is 0 pcb-4.3.0/src/hid/common/flags.c:106:16: note: Assuming condition is false pcb-4.3.0/src/hid/common/flags.c:112:7: note: Null pointer dereference pcb-4.3.0/src/hid/common/flags.c:53:13: style: Variable 'a' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/hid/common/flags.c:54:13: style: Variable 'b' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/hid/common/flags.c:140:29: style: Parameter 'save_array' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/common/hidgl.c:52:0: error: #error autoconf couldnt find gl.h [preprocessorErrorDirective] pcb-4.3.0/src/hid/common/hidnogui.c:231:3: style: Statements following noreturn function 'abort()' will never be executed. [unreachableCode] pcb-4.3.0/src/hid/common/hidnogui.c:247:3: style: Statements following noreturn function 'abort()' will never be executed. [unreachableCode] pcb-4.3.0/src/hid/common/hidnogui.c:262:3: style: Statements following noreturn function 'abort()' will never be executed. [unreachableCode] pcb-4.3.0/src/hid/common/hidnogui.c:359:54: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-4.3.0/src/hid/common/hidnogui.c:363:28: style: Parameter 'title' can be declared as pointer to const. However it seems that 'nogui_report_dialog' is a callback function, if 'title' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/common/hidnogui.c:475:31: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/common/hidnogui.c:363:28: note: Parameter 'title' can be declared as pointer to const pcb-4.3.0/src/hid/common/hidnogui.c:363:41: style: Parameter 'msg' can be declared as pointer to const. However it seems that 'nogui_report_dialog' is a callback function, if 'msg' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/common/hidnogui.c:475:31: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/common/hidnogui.c:363:41: note: Parameter 'msg' can be declared as pointer to const pcb-4.3.0/src/hid/common/hidnogui.c:389:11: style: Parameter 'default_file' can be declared as pointer to const. However it seems that 'nogui_fileselect' is a callback function, if 'default_file' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/common/hidnogui.c:477:31: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/common/hidnogui.c:389:11: note: Parameter 'default_file' can be declared as pointer to const pcb-4.3.0/src/hid/common/hidnogui.c:389:31: style: Parameter 'default_ext' can be declared as pointer to const. However it seems that 'nogui_fileselect' is a callback function, if 'default_ext' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/common/hidnogui.c:477:31: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/common/hidnogui.c:389:31: note: Parameter 'default_ext' can be declared as pointer to const pcb-4.3.0/src/hid/common/hidnogui.c:27:7: style: struct member 'hid_gc_struct::nothing_interesting_here' is never used. [unusedStructMember] pcb-4.3.0/src/hid/common/trackball.c:247:17: style: Parameter 'q1' can be declared as const array [constParameter] pcb-4.3.0/src/hid/common/trackball.c:247:30: style: Parameter 'q2' can be declared as const array [constParameter] pcb-4.3.0/src/hid/common/trackball.c:302:38: style: Parameter 'q' can be declared as const array [constParameter] pcb-4.3.0/src/hid/common/hidinit.c:109:16: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled] pcb-4.3.0/src/hid/common/hidinit.c:234:5: error: Common realloc mistake: 'hid_list' nulled but not freed upon failure [memleakOnRealloc] pcb-4.3.0/src/hid/common/hidinit.c:776:24: style: Variable 'hash' is reassigned a value before the old one has been used. [redundantAssignment] pcb-4.3.0/src/hid/common/hidinit.c:775:8: note: hash is assigned pcb-4.3.0/src/hid/common/hidinit.c:776:24: note: hash is overwritten pcb-4.3.0/src/hid/common/hidinit.c:446:5: style: Statements following noreturn function 'abort()' will never be executed. [unreachableCode] pcb-4.3.0/src/hid/common/hidinit.c:751:66: style:inconclusive: Function 'hid_cache_color' argument 4 names different: declaration 'cache' definition 'vcache'. [funcArgNamesDifferent] pcb-4.3.0/src/hid/hidint.h:67:70: note: Function 'hid_cache_color' argument 4 names different: declaration 'cache' definition 'vcache'. pcb-4.3.0/src/hid/common/hidinit.c:751:66: note: Function 'hid_cache_color' argument 4 names different: declaration 'cache' definition 'vcache'. pcb-4.3.0/src/hid/common/hidinit.c:488:18: style: Variable 'cp' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/hid/common/hidinit.c:579:30: style: Variable 'value' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/hid/common/hidinit.c:601:26: style: Parameter 'name' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gcode/gcode.c:392:1: error: There is an unknown macro here somewhere. Configuration is required. If REGISTER_ATTRIBUTES is a macro then please configure it. [unknownMacro] pcb-4.3.0/src/find.c:3170:35: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-4.3.0/src/find.c:1369:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:1387:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:1405:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:1419:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:1440:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:1441:12: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:1697:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:1781:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:1804:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:1827:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:1851:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:1852:36: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:1891:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:2074:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:2090:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:2104:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:2164:20: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:2188:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:2204:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:2218:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:2242:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:2317:24: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:2351:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:2367:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:2383:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:2456:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:2472:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:2487:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:2503:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:2533:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:2626:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:2642:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:2656:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:2672:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:2737:20: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:2994:9: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:3018:9: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:3236:14: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:3279:10: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/find.c:430:18: style: Variable 'layer' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/find.c:576:25: style: Parameter 'box_in' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/find.c:611:30: style: Parameter 'b1' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/find.c:611:43: style: Parameter 'b2' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/find.c:669:50: style: Parameter 'arc' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/find.c:683:36: style: Parameter 'arc' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/find.c:836:33: style: Parameter 'Point' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/find.c:836:50: style: Parameter 'Line' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/find.c:1166:12: style: Variable 'Box' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/find.c:1198:12: style: Variable 'Box' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/find.c:1912:18: style: Variable 'layer' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/hid/gcode/decompose.c:37:36: style: Parameter 'bm' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gcode/decompose.c:64:40: style: Parameter 'bm' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gcode/decompose.c:64:53: style: Parameter 'bbox' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gcode/decompose.c:122:30: style: Parameter 'bm' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gcode/decompose.c:157:32: style: Parameter 'bm' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gcode/decompose.c:543:30: style: Parameter 'bm' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gerber/gerber.c:930:38: error: There is an unknown macro here somewhere. Configuration is required. If VERSION is a macro then please configure it. [unknownMacro] pcb-4.3.0/src/hid/gsvit/gsvit.c:254:1: error: There is an unknown macro here somewhere. Configuration is required. If REGISTER_ATTRIBUTES is a macro then please configure it. [unknownMacro] pcb-4.3.0/src/hid/gtk/ghid-cell-renderer-visibility.c:80:58: style: Parameter 'cell_area' can be declared as pointer to const. However it seems that 'ghid_cell_renderer_visibility_get_size' is a callback function, if 'cell_area' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/ghid-cell-renderer-visibility.c:285:26: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/ghid-cell-renderer-visibility.c:80:58: note: Parameter 'cell_area' can be declared as pointer to const pcb-4.3.0/src/hid/gtk/ghid-cell-renderer-visibility.c:86:13: style: Variable 'style' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/hid/gtk/ghid-coord-entry.c:342:45: style: Parameter 'ce' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gtk/ghid-layer-selector.c:848:57: style: Parameter 'ls' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gtk/ghid-main-menu.c:434:36: style: Parameter 'mm' can be declared as pointer to const. However it seems that 'ghid_main_menu_init' is a callback function, if 'mm' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/ghid-main-menu.c:462:31: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/ghid-main-menu.c:434:36: note: Parameter 'mm' can be declared as pointer to const pcb-4.3.0/src/hid/gtk/ghid-main-menu.c:440:47: style: Parameter 'klass' can be declared as pointer to const. However it seems that 'ghid_main_menu_class_init' is a callback function, if 'klass' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/ghid-main-menu.c:457:28: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/ghid-main-menu.c:440:47: note: Parameter 'klass' can be declared as pointer to const pcb-4.3.0/src/hid/gtk/ghid-main-menu.c:649:47: style: Parameter 'menu' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gtk/ghid-route-style-selector.c:349:57: style: Parameter 'rss' can be declared as pointer to const. However it seems that 'ghid_route_style_selector_init' is a callback function, if 'rss' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/ghid-route-style-selector.c:413:22: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/ghid-route-style-selector.c:349:57: note: Parameter 'rss' can be declared as pointer to const pcb-4.3.0/src/hid/gtk/ghid-route-style-selector.c:585:57: style: Parameter 'rst' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gtk/ghid-route-style-selector.c:620:68: style: Parameter 'rss' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gtk/gtkhid-gl.c:30:0: error: #error autoconf couldnt find gl.h [preprocessorErrorDirective] pcb-4.3.0/src/hid/gtk/gtkhid-main.c:2244:1: error: There is an unknown macro here somewhere. Configuration is required. If REGISTER_ACTIONS is a macro then please configure it. [unknownMacro] pcb-4.3.0/src/hid/gtk/gui-command-window.c:290:45: style: Parameter 'widget' can be declared as pointer to const. However it seems that 'command_window_delete_event_cb' is a callback function, if 'widget' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/gui-command-window.c:377:33: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/gui-command-window.c:290:45: note: Parameter 'widget' can be declared as pointer to const pcb-4.3.0/src/hid/gtk/gui-command-window.c:290:64: style: Parameter 'event' can be declared as pointer to const. However it seems that 'command_window_delete_event_cb' is a callback function, if 'event' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/gui-command-window.c:377:33: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/gui-command-window.c:290:64: note: Parameter 'event' can be declared as pointer to const pcb-4.3.0/src/hid/gtk/gui-command-window.c:299:33: style: Parameter 'widget' can be declared as pointer to const. However it seems that 'command_destroy_cb' is a callback function, if 'widget' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/gui-command-window.c:375:33: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/gui-command-window.c:299:33: note: Parameter 'widget' can be declared as pointer to const pcb-4.3.0/src/hid/gtk/gui-command-window.c:306:54: style: Parameter 'kev' can be declared as pointer to const. However it seems that 'command_escape_cb' is a callback function, if 'kev' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/gui-command-window.c:474:21: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/gui-command-window.c:306:54: note: Parameter 'kev' can be declared as pointer to const pcb-4.3.0/src/hid/gtk/gtkhid-gdk.c:242:7: error: Common realloc mistake: 'points' nulled but not freed upon failure [memleakOnRealloc] pcb-4.3.0/src/hid/gtk/gtkhid-gdk.c:693:7: error: Common realloc mistake: 'points' nulled but not freed upon failure [memleakOnRealloc] pcb-4.3.0/src/hid/gtk/gtkhid-gdk.c:514:34: style:inconclusive: Function 'ghid_set_draw_xor' argument 2 names different: declaration '_xor' definition 'xor_mask'. [funcArgNamesDifferent] pcb-4.3.0/src/hid/gtk/gui.h:488:39: note: Function 'ghid_set_draw_xor' argument 2 names different: declaration '_xor' definition 'xor_mask'. pcb-4.3.0/src/hid/gtk/gtkhid-gdk.c:514:34: note: Function 'ghid_set_draw_xor' argument 2 names different: declaration '_xor' definition 'xor_mask'. pcb-4.3.0/src/hid/gtk/gui-config.c:1283:31: error: There is an unknown macro here somewhere. Configuration is required. If PCB_PATH_DELIMETER is a macro then please configure it. [unknownMacro] pcb-4.3.0/src/hid/gtk/gtkhid-gdk.c:748:30: style: Parameter 'rect' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gtk/gtkhid-gdk.c:1112:38: style: Parameter 'widget' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gtk/gtkhid-gdk.c:1112:56: style: Parameter 'port' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gtk/gtkhid-gdk.c:1171:42: style: Parameter 'widget' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gtk/gui-dialog.c:674:44: warning: Either the condition 'k<8' is redundant or the array 'recent_dirs[history_pool].history[8]' is accessed at index 8, which is out of bounds. [arrayIndexOutOfBoundsCond] pcb-4.3.0/src/hid/gtk/gui-dialog.c:668:14: note: Assuming that condition 'k<8' is not redundant pcb-4.3.0/src/hid/gtk/gui-dialog.c:674:44: note: Array index out of bounds pcb-4.3.0/src/hid/gtk/gui-dialog.c:345:24: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] pcb-4.3.0/src/hid/gtk/gui-dialog.c:428:24: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] pcb-4.3.0/src/hid/gtk/gui-dialog.c:498:24: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] pcb-4.3.0/src/hid/gtk/gui-dialog.c:109:34: style:inconclusive: Function 'ghid_dialog_confirm_all' argument 1 names different: declaration 'message' definition 'all_message'. [funcArgNamesDifferent] pcb-4.3.0/src/hid/gtk/gui.h:328:39: note: Function 'ghid_dialog_confirm_all' argument 1 names different: declaration 'message' definition 'all_message'. pcb-4.3.0/src/hid/gtk/gui-dialog.c:109:34: note: Function 'ghid_dialog_confirm_all' argument 1 names different: declaration 'message' definition 'all_message'. pcb-4.3.0/src/hid/gtk/gui-keyref-window.c:331:32: style: Parameter 'widget' can be declared as pointer to const. However it seems that 'keyref_destroy_cb' is a callback function, if 'widget' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/gui-keyref-window.c:350:19: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/gui-keyref-window.c:331:32: note: Parameter 'widget' can be declared as pointer to const pcb-4.3.0/src/hid/gtk/gui-drc-window.c:86:29: style: Parameter 'widget' can be declared as pointer to const. However it seems that 'drc_destroy_cb' is a callback function, if 'widget' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/gui-drc-window.c:746:19: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/gui-drc-window.c:86:29: note: Parameter 'widget' can be declared as pointer to const pcb-4.3.0/src/hid/gtk/gui-drc-window.c:193:7: style: struct member 'ghid_drc_object_list::count' is never used. [unusedStructMember] pcb-4.3.0/src/hid/gtk/gui-drc-window.c:194:13: style: struct member 'ghid_drc_object_list::id_list' is never used. [unusedStructMember] pcb-4.3.0/src/hid/gtk/gui-drc-window.c:195:8: style: struct member 'ghid_drc_object_list::type_list' is never used. [unusedStructMember] pcb-4.3.0/src/hid/gtk/gui-log-window.c:67:29: style: Parameter 'widget' can be declared as pointer to const. However it seems that 'log_destroy_cb' is a callback function, if 'widget' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/gui-log-window.c:82:19: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/gui-log-window.c:67:29: note: Parameter 'widget' can be declared as pointer to const pcb-4.3.0/src/hid/gtk/gui-log-window.c:159:9: style: Variable 'a' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/hid/gtk/gui-library-window.c:230:22: style: Local variable 'library_window' shadows outer variable [shadowVariable] pcb-4.3.0/src/hid/gtk/gui-library-window.c:71:19: note: Shadowed declaration pcb-4.3.0/src/hid/gtk/gui-library-window.c:230:22: note: Shadow variable pcb-4.3.0/src/hid/gtk/gui-library-window.c:371:22: style: Local variable 'library_window' shadows outer variable [shadowVariable] pcb-4.3.0/src/hid/gtk/gui-library-window.c:71:19: note: Shadowed declaration pcb-4.3.0/src/hid/gtk/gui-library-window.c:371:22: note: Shadow variable pcb-4.3.0/src/hid/gtk/gui-library-window.c:451:22: style: Local variable 'library_window' shadows outer variable [shadowVariable] pcb-4.3.0/src/hid/gtk/gui-library-window.c:71:19: note: Shadowed declaration pcb-4.3.0/src/hid/gtk/gui-library-window.c:451:22: note: Shadow variable pcb-4.3.0/src/hid/gtk/gui-library-window.c:493:22: style: Local variable 'library_window' shadows outer variable [shadowVariable] pcb-4.3.0/src/hid/gtk/gui-library-window.c:71:19: note: Shadowed declaration pcb-4.3.0/src/hid/gtk/gui-library-window.c:493:22: note: Shadow variable pcb-4.3.0/src/hid/gtk/gui-library-window.c:532:22: style: Local variable 'library_window' shadows outer variable [shadowVariable] pcb-4.3.0/src/hid/gtk/gui-library-window.c:71:19: note: Shadowed declaration pcb-4.3.0/src/hid/gtk/gui-library-window.c:532:22: note: Shadow variable pcb-4.3.0/src/hid/gtk/gui-library-window.c:852:22: style: Local variable 'library_window' shadows outer variable [shadowVariable] pcb-4.3.0/src/hid/gtk/gui-library-window.c:71:19: note: Shadowed declaration pcb-4.3.0/src/hid/gtk/gui-library-window.c:852:22: note: Shadow variable pcb-4.3.0/src/hid/gtk/gui-library-window.c:938:22: style: Local variable 'library_window' shadows outer variable [shadowVariable] pcb-4.3.0/src/hid/gtk/gui-library-window.c:71:19: note: Shadowed declaration pcb-4.3.0/src/hid/gtk/gui-library-window.c:938:22: note: Shadow variable pcb-4.3.0/src/hid/gtk/gui-library-window.c:323:36: style: Parameter 'event' can be declared as pointer to const. However it seems that 'tree_row_key_pressed' is a callback function, if 'event' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/gui-library-window.c:729:33: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/gui-library-window.c:323:36: note: Parameter 'event' can be declared as pointer to const pcb-4.3.0/src/hid/gtk/gui-misc.c:147:23: style:inconclusive: Function 'ghid_mode_cursor' argument 1 names different: declaration 'mode' definition 'Mode'. [funcArgNamesDifferent] pcb-4.3.0/src/hid/gtk/gui.h:272:29: note: Function 'ghid_mode_cursor' argument 1 names different: declaration 'mode' definition 'Mode'. pcb-4.3.0/src/hid/gtk/gui-misc.c:147:23: note: Function 'ghid_mode_cursor' argument 1 names different: declaration 'mode' definition 'Mode'. pcb-4.3.0/src/hid/gtk/gui-misc.c:68:46: style: Parameter 'text' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gtk/gui-misc.c:74:55: style: Parameter 'text' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gtk/gui-misc.c:247:60: style: Parameter 'kev' can be declared as pointer to const. However it seems that 'loop_key_press_cb' is a callback function, if 'kev' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/gui-misc.c:331:21: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/gui-misc.c:247:60: note: Parameter 'kev' can be declared as pointer to const pcb-4.3.0/src/hid/gtk/gui-misc.c:371:33: style: Parameter 'msg' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gtk/gui-netlist-window.c:890:38: style:inconclusive: Function 'ghid_get_net_from_node_name' argument 1 names different: declaration 'name' definition 'node_name'. [funcArgNamesDifferent] pcb-4.3.0/src/hid/gtk/gui.h:453:55: note: Function 'ghid_get_net_from_node_name' argument 1 names different: declaration 'name' definition 'node_name'. pcb-4.3.0/src/hid/gtk/gui-netlist-window.c:890:38: note: Function 'ghid_get_net_from_node_name' argument 1 names different: declaration 'name' definition 'node_name'. pcb-4.3.0/src/hid/gtk/gui-netlist-window.c:938:38: style:inconclusive: Function 'ghid_netlist_highlight_node' argument 1 names different: declaration 'name' definition 'node_name'. [funcArgNamesDifferent] pcb-4.3.0/src/hid/gtk/gui.h:454:43: note: Function 'ghid_netlist_highlight_node' argument 1 names different: declaration 'name' definition 'node_name'. pcb-4.3.0/src/hid/gtk/gui-netlist-window.c:938:38: note: Function 'ghid_netlist_highlight_node' argument 1 names different: declaration 'name' definition 'node_name'. pcb-4.3.0/src/hid/gtk/gui-netlist-window.c:283:20: style: Variable 'pin' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/hid/gtk/gui-netlist-window.c:689:33: style: Parameter 'widget' can be declared as pointer to const. However it seems that 'netlist_destroy_cb' is a callback function, if 'widget' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/gui-netlist-window.c:709:19: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/gui-netlist-window.c:689:33: note: Parameter 'widget' can be declared as pointer to const pcb-4.3.0/src/hid/gtk/gui-netlist-window.c:689:52: style: Parameter 'out' can be declared as pointer to const. However it seems that 'netlist_destroy_cb' is a callback function, if 'out' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/gui-netlist-window.c:709:19: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/gui-netlist-window.c:689:52: note: Parameter 'out' can be declared as pointer to const pcb-4.3.0/src/hid/gtk/gui-output-events.c:454:43: style: Condition 'netname!=NULL' is always false [knownConditionTrueFalse] pcb-4.3.0/src/hid/gtk/gui-output-events.c:444:17: note: Assuming that condition 'netname!=NULL' is not redundant pcb-4.3.0/src/hid/gtk/gui-output-events.c:454:43: note: Condition 'netname!=NULL' is always false pcb-4.3.0/src/hid/gtk/gui-output-events.c:123:44: style: Parameter 'ev' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gtk/gui-output-events.c:168:67: style: Parameter 'kev' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gtk/gui-output-events.c:350:29: style: Parameter 'ev' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gtk/gui-output-events.c:538:26: style: Parameter 'ev' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gtk/gui-output-events.c:571:47: style: Parameter 'ev' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gtk/gui-pinout-preview.c:330:59: style: Parameter 'pinout' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gtk/gui-pinout-window.c:58:56: style:inconclusive: Function 'ghid_pinout_window_show' argument 2 names different: declaration 'Element' definition 'element'. [funcArgNamesDifferent] pcb-4.3.0/src/hid/gtk/gui.h:478:59: note: Function 'ghid_pinout_window_show' argument 2 names different: declaration 'Element' definition 'element'. pcb-4.3.0/src/hid/gtk/gui-pinout-window.c:58:56: note: Function 'ghid_pinout_window_show' argument 2 names different: declaration 'Element' definition 'element'. pcb-4.3.0/src/hid/gtk/gui-top-window.c:1784:1: error: There is an unknown macro here somewhere. Configuration is required. If REGISTER_ATTRIBUTES is a macro then please configure it. [unknownMacro] pcb-4.3.0/src/hid/gtk/gui-trackball.c:60:53: style: Parameter 'ev' can be declared as pointer to const. However it seems that 'button_press_cb' is a callback function, if 'ev' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/gui-trackball.c:279:33: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/gui-trackball.c:60:53: note: Parameter 'ev' can be declared as pointer to const pcb-4.3.0/src/hid/gtk/gui-trackball.c:96:55: style: Parameter 'ev' can be declared as pointer to const. However it seems that 'button_release_cb' is a callback function, if 'ev' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/gui-trackball.c:281:33: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/gui-trackball.c:96:55: note: Parameter 'ev' can be declared as pointer to const pcb-4.3.0/src/hid/ipcd356/ipcd356.c:146:51: error: There is an unknown macro here somewhere. Configuration is required. If VERSION is a macro then please configure it. [unknownMacro] pcb-4.3.0/src/hid/gcode/trace.c:1495:6: style: Redundant initialization for 'po'. The initialized value is overwritten before it is read. [redundantInitialization] pcb-4.3.0/src/hid/gcode/trace.c:1487:11: note: po is initialized pcb-4.3.0/src/hid/gcode/trace.c:1495:6: note: po is overwritten pcb-4.3.0/src/hid/gcode/trace.c:1496:6: style: Redundant initialization for 'pt'. The initialized value is overwritten before it is read. [redundantInitialization] pcb-4.3.0/src/hid/gcode/trace.c:1488:15: note: pt is initialized pcb-4.3.0/src/hid/gcode/trace.c:1496:6: note: pt is overwritten pcb-4.3.0/src/hid/gcode/trace.c:1017:7: style: 'continue' is redundant since it is the last statement in a loop. [redundantContinue] pcb-4.3.0/src/hid/gcode/trace.c:806:8: style: Variable 'po' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/hid/gcode/trace.c:1138:34: style: Parameter 'convc' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gcode/trace.c:1138:49: style: Parameter 'areac' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gtk/gui-utils.c:157:35: style:inconclusive: Function 'ghid_draw_area_update' argument 1 names different: declaration 'out' definition 'port'. [funcArgNamesDifferent] pcb-4.3.0/src/hid/gtk/gui.h:369:40: note: Function 'ghid_draw_area_update' argument 1 names different: declaration 'out' definition 'port'. pcb-4.3.0/src/hid/gtk/gui-utils.c:157:35: note: Function 'ghid_draw_area_update' argument 1 names different: declaration 'out' definition 'port'. pcb-4.3.0/src/hid/gtk/gui-utils.c:407:37: style:inconclusive: Function 'ghid_table_spin_button' argument 1 names different: declaration 'box' definition 'table'. [funcArgNamesDifferent] pcb-4.3.0/src/hid/gtk/gui.h:396:42: note: Function 'ghid_table_spin_button' argument 1 names different: declaration 'box' definition 'table'. pcb-4.3.0/src/hid/gtk/gui-utils.c:407:37: note: Function 'ghid_table_spin_button' argument 1 names different: declaration 'box' definition 'table'. pcb-4.3.0/src/hid/gtk/gui-utils.c:89:45: style: Parameter 'state' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gtk/gui-utils.c:127:38: style: Parameter 'state' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gtk/gui-utils.c:165:33: style: Parameter 'color' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/gtk/gui-utils.c:651:52: style: Parameter 'name' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/lesstif/library.c:68:9: style: Local variable 'args' shadows outer variable [shadowVariable] pcb-4.3.0/src/hid/lesstif/library.c:27:12: note: Shadowed declaration pcb-4.3.0/src/hid/lesstif/library.c:68:9: note: Shadow variable pcb-4.3.0/src/hid/lesstif/library.c:60:33: style: Parameter 'v' can be declared as pointer to const. However it seems that 'library_browse' is a callback function, if 'v' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/lesstif/library.c:105:21: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/lesstif/library.c:60:33: note: Parameter 'v' can be declared as pointer to const pcb-4.3.0/src/hid/lesstif/library.c:60:59: style: Parameter 'cbs' can be declared as pointer to const. However it seems that 'library_browse' is a callback function, if 'cbs' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/lesstif/library.c:105:21: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/lesstif/library.c:60:59: note: Parameter 'cbs' can be declared as pointer to const pcb-4.3.0/src/hid/lesstif/library.c:66:59: style: Parameter 'cbs' can be declared as pointer to const. However it seems that 'libnode_select' is a callback function, if 'cbs' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/lesstif/library.c:116:21: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/lesstif/library.c:66:59: note: Parameter 'cbs' can be declared as pointer to const pcb-4.3.0/src/hid/lesstif/menu.c:757:1: error: There is an unknown macro here somewhere. Configuration is required. If REGISTER_ACTIONS is a macro then please configure it. [unknownMacro] pcb-4.3.0/src/hid/lesstif/main.c:217:1: error: There is an unknown macro here somewhere. Configuration is required. If REGISTER_FLAGS is a macro then please configure it. [unknownMacro] pcb-4.3.0/src/hid/lesstif/dialogs.c:1793:2: error: Common realloc mistake: 'attr_row' nulled but not freed upon failure [memleakOnRealloc] pcb-4.3.0/src/hid/lesstif/dialogs.c:512:53: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-4.3.0/src/hid/lesstif/dialogs.c:796:22: style: Local variable 'empty' shadows outer variable [shadowVariable] pcb-4.3.0/src/hid/lesstif/dialogs.c:674:19: note: Shadowed declaration pcb-4.3.0/src/hid/lesstif/dialogs.c:796:22: note: Shadow variable pcb-4.3.0/src/hid/lesstif/dialogs.c:978:16: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-4.3.0/src/hid/lesstif/dialogs.c:30:12: note: Shadowed declaration pcb-4.3.0/src/hid/lesstif/dialogs.c:978:16: note: Shadow variable pcb-4.3.0/src/hid/lesstif/dialogs.c:1011:7: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-4.3.0/src/hid/lesstif/dialogs.c:30:12: note: Shadowed declaration pcb-4.3.0/src/hid/lesstif/dialogs.c:1011:7: note: Shadow variable pcb-4.3.0/src/hid/lesstif/dialogs.c:1089:7: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-4.3.0/src/hid/lesstif/dialogs.c:30:12: note: Shadowed declaration pcb-4.3.0/src/hid/lesstif/dialogs.c:1089:7: note: Shadow variable pcb-4.3.0/src/hid/lesstif/dialogs.c:1487:13: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-4.3.0/src/hid/lesstif/dialogs.c:30:12: note: Shadowed declaration pcb-4.3.0/src/hid/lesstif/dialogs.c:1487:13: note: Shadow variable pcb-4.3.0/src/hid/lesstif/dialogs.c:1873:10: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-4.3.0/src/hid/lesstif/dialogs.c:30:12: note: Shadowed declaration pcb-4.3.0/src/hid/lesstif/dialogs.c:1873:10: note: Shadow variable pcb-4.3.0/src/hid/lesstif/dialogs.c:41:43: style: Parameter 'cbs' can be declared as pointer to const. However it seems that 'dialog_callback' is a callback function, if 'cbs' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/lesstif/dialogs.c:1951:25: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/lesstif/dialogs.c:41:43: note: Parameter 'cbs' can be declared as pointer to const pcb-4.3.0/src/hid/lesstif/dialogs.c:557:13: style: Parameter 'default_file' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/lesstif/dialogs.c:634:9: style: Variable 'rv' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/hid/lesstif/dialogs.c:1395:70: style: Parameter 'cbs' can be declared as pointer to const. However it seems that 'lgbutton_expose' is a callback function, if 'cbs' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/lesstif/dialogs.c:1615:25: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/lesstif/dialogs.c:1395:70: note: Parameter 'cbs' can be declared as pointer to const pcb-4.3.0/src/hid/lesstif/dialogs.c:1897:45: style: Parameter 'v' can be declared as pointer to const. However it seems that 'attributes_revert_callback' is a callback function, if 'v' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/lesstif/dialogs.c:1944:25: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/lesstif/dialogs.c:1897:45: note: Parameter 'v' can be declared as pointer to const pcb-4.3.0/src/hid/lesstif/dialogs.c:1897:54: style: Parameter 'cbs' can be declared as pointer to const. However it seems that 'attributes_revert_callback' is a callback function, if 'cbs' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/lesstif/dialogs.c:1944:25: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/lesstif/dialogs.c:1897:54: note: Parameter 'cbs' can be declared as pointer to const pcb-4.3.0/src/hid/lesstif/dialogs.c:1498:28: style: Variable 'sets[l->Entries[i][j]][i]' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/hid/lesstif/netlist.c:70:59: style: Parameter 'cbs' can be declared as pointer to const. However it seems that 'netlist_select' is a callback function, if 'cbs' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/lesstif/netlist.c:367:74: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/lesstif/netlist.c:70:59: note: Parameter 'cbs' can be declared as pointer to const pcb-4.3.0/src/hid/lesstif/netlist.c:94:33: style: Parameter 'v' can be declared as pointer to const. However it seems that 'netlist_extend' is a callback function, if 'v' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/lesstif/netlist.c:368:78: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/lesstif/netlist.c:94:33: note: Parameter 'v' can be declared as pointer to const pcb-4.3.0/src/hid/lesstif/netlist.c:94:59: style: Parameter 'cbs' can be declared as pointer to const. However it seems that 'netlist_extend' is a callback function, if 'cbs' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/lesstif/netlist.c:368:78: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/lesstif/netlist.c:94:59: note: Parameter 'cbs' can be declared as pointer to const pcb-4.3.0/src/hid/lesstif/netlist.c:130:38: style: Parameter 'net' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/hid/lesstif/netlist.c:163:29: style: Parameter 'net' can be declared as pointer to const. However it seems that 'nbcb_find' is a callback function, if 'net' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/lesstif/netlist.c:339:50: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/lesstif/netlist.c:163:29: note: Parameter 'net' can be declared as pointer to const pcb-4.3.0/src/hid/lesstif/netlist.c:224:63: style: Parameter 'cbs' can be declared as pointer to const. However it seems that 'netnode_browse' is a callback function, if 'cbs' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/lesstif/netlist.c:379:76: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/lesstif/netlist.c:224:63: note: Parameter 'cbs' can be declared as pointer to const pcb-4.3.0/src/hid/lesstif/netlist.c:227:9: style: Variable 'name' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/hid/lesstif/netlist.c:241:11: style: Variable 'es' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/hid/lesstif/styles.c:456:3: error: Common realloc mistake: 'style_button_list' nulled but not freed upon failure [memleakOnRealloc] pcb-4.3.0/src/hid/lesstif/styles.c:137:10: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-4.3.0/src/hid/lesstif/styles.c:47:12: note: Shadowed declaration pcb-4.3.0/src/hid/lesstif/styles.c:137:10: note: Shadow variable pcb-4.3.0/src/hid/lesstif/styles.c:160:9: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-4.3.0/src/hid/lesstif/styles.c:47:12: note: Shadowed declaration pcb-4.3.0/src/hid/lesstif/styles.c:160:9: note: Shadow variable pcb-4.3.0/src/hid/lesstif/styles.c:267:10: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-4.3.0/src/hid/lesstif/styles.c:47:12: note: Shadowed declaration pcb-4.3.0/src/hid/lesstif/styles.c:267:10: note: Shadow variable pcb-4.3.0/src/hid/lesstif/styles.c:264:65: style: Parameter 'cbs' can be declared as pointer to const. However it seems that 'style_selected' is a callback function, if 'cbs' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/lesstif/styles.c:469:25: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/lesstif/styles.c:264:65: note: Parameter 'cbs' can be declared as pointer to const pcb-4.3.0/src/hid/lpr/lpr.c:67:22: style: Variable 'ps_opts' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/hid/nelma/nelma.c:213:1: error: There is an unknown macro here somewhere. Configuration is required. If REGISTER_ATTRIBUTES is a macro then please configure it. [unknownMacro] pcb-4.3.0/src/hid/ps/eps.c:136:1: error: There is an unknown macro here somewhere. Configuration is required. If REGISTER_ATTRIBUTES is a macro then please configure it. [unknownMacro] pcb-4.3.0/src/hid/png/png.c:465:1: error: There is an unknown macro here somewhere. Configuration is required. If REGISTER_ATTRIBUTES is a macro then please configure it. [unknownMacro] pcb-4.3.0/src/hid/ps/ps.c:462:47: error: There is an unknown macro here somewhere. Configuration is required. If VERSION is a macro then please configure it. [unknownMacro] pcb-4.3.0/src/layerflags.c:76:34: style:inconclusive: Function 'string_to_layertype' argument 1 names different: declaration 'typestring' definition 'flagstring'. [funcArgNamesDifferent] pcb-4.3.0/src/layerflags.h:34:47: note: Function 'string_to_layertype' argument 1 names different: declaration 'typestring' definition 'flagstring'. pcb-4.3.0/src/layerflags.c:76:34: note: Function 'string_to_layertype' argument 1 names different: declaration 'typestring' definition 'flagstring'. pcb-4.3.0/src/layerflags.c:77:28: style: Parameter 'error' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/layerflags.c:120:64: style: Parameter 'data' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/intersect.c:313:17: style:inconclusive: Function 'nextpwrof2' argument 1 names different: declaration 'i' definition 'n'. [funcArgNamesDifferent] pcb-4.3.0/src/intersect.c:59:28: note: Function 'nextpwrof2' argument 1 names different: declaration 'i' definition 'n'. pcb-4.3.0/src/intersect.c:313:17: note: Function 'nextpwrof2' argument 1 names different: declaration 'i' definition 'n'. pcb-4.3.0/src/main.c:1270:0: error: failed to expand 'SSET', it is invalid to use a preprocessor directive as macro parameter [preprocessorErrorDirective] pcb-4.3.0/src/misc.c:2712:0: error: #error "Don't know how to create a directory on this system." [preprocessorErrorDirective] pcb-4.3.0/src/mirror.c:71:20: style: Redundant assignment of 'line->Point1.X' to itself. [selfAssignment] pcb-4.3.0/src/mirror.c:73:20: style: Redundant assignment of 'line->Point2.X' to itself. [selfAssignment] pcb-4.3.0/src/mirror.c:80:12: style: Redundant assignment of 'pin->X' to itself. [selfAssignment] pcb-4.3.0/src/mirror.c:112:12: style: Redundant assignment of 'arc->X' to itself. [selfAssignment] pcb-4.3.0/src/mirror.c:120:13: style: Redundant assignment of 'text->X' to itself. [selfAssignment] pcb-4.3.0/src/mirror.c:125:18: style: Redundant assignment of 'Element->MarkX' to itself. [selfAssignment] pcb-4.3.0/src/mtspace.c:576:19: style: Local variable 'temporary' shadows outer variable [shadowVariable] pcb-4.3.0/src/mtspace.c:530:22: note: Shadowed declaration pcb-4.3.0/src/mtspace.c:576:19: note: Shadow variable pcb-4.3.0/src/mtspace.c:167:17: style: Variable 'box' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/mtspace.c:610:26: style: Parameter 'w' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/move.c:589:3: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] pcb-4.3.0/src/move.c:732:8: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/object_list.c:167:16: style: Condition 'result<0' is always false [knownConditionTrueFalse] pcb-4.3.0/src/object_list.c:166:32: note: Calling function 'object_list_expand' returns 0 pcb-4.3.0/src/object_list.c:166:32: note: Assignment 'result=object_list_expand(list,1)', assigned value is 0 pcb-4.3.0/src/object_list.c:167:16: note: Condition 'result<0' is always false pcb-4.3.0/src/object_list.c:147:37: style: Parameter 'list' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/object_list.c:265:45: style: Parameter 'list' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/object_list.c:183:16: portability: 'nptr' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer] pcb-4.3.0/src/object_list.c:231:20: portability: 'nptr' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer] pcb-4.3.0/src/object_list.c:268:21: portability: 'list->data' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [arithOperationsOnVoidPointer] pcb-4.3.0/src/object_list.c:102:8: style: Variable 'i' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/mymem.c:85:7: error: Common realloc mistake: 'ptr' nulled but not freed upon failure [memleakOnRealloc] pcb-4.3.0/src/netlist.c:107:27: style: Parameter 'nodename' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/netlist.c:261:21: style: Variable 'pin' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/netlist.c:282:11: style: Variable 'pin' is assigned a value that is never used. [unreadVariable] parse_l.l:349:11: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] parse_l.l:350:7: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] parse_l.c:1849:2: warning: Possible null pointer dereference: b [nullPointer] parse_l.c:1742:18: note: Calling function 'yy_init_buffer', 1st argument '(yy_buffer_stack)?(yy_buffer_stack)[yy_buffer_stack_top]:NULL' value is 0 parse_l.c:1849:2: note: Null pointer dereference parse_l.c:1850:2: warning: Possible null pointer dereference: b [nullPointer] parse_l.c:1742:18: note: Calling function 'yy_init_buffer', 1st argument '(yy_buffer_stack)?(yy_buffer_stack)[yy_buffer_stack_top]:NULL' value is 0 parse_l.c:1850:2: note: Null pointer dereference parse_l.c:1502:3: style: Redundant initialization for 'c'. The initialized value is overwritten before it is read. [redundantInitialization] parse_l.c:1502:3: note: c is initialized parse_l.c:1502:3: note: c is overwritten parse_l.c:1581:59: style:inconclusive: Function 'yy_try_NUL_trans' argument 1 names different: declaration 'current_state' definition 'yy_current_state'. [funcArgNamesDifferent] parse_l.c:360:55: note: Function 'yy_try_NUL_trans' argument 1 names different: declaration 'current_state' definition 'yy_current_state'. parse_l.c:1581:59: note: Function 'yy_try_NUL_trans' argument 1 names different: declaration 'current_state' definition 'yy_current_state'. parse_l.c:1606:40: style:inconclusive: Function 'yyunput' argument 2 names different: declaration 'buf_ptr' definition 'yy_bp'. [funcArgNamesDifferent] parse_l.c:741:40: note: Function 'yyunput' argument 2 names different: declaration 'buf_ptr' definition 'yy_bp'. parse_l.c:1606:40: note: Function 'yyunput' argument 2 names different: declaration 'buf_ptr' definition 'yy_bp'. parse_l.c:2034:46: style:inconclusive: Function 'yy_scan_string' argument 1 names different: declaration 'yy_str' definition 'yystr'. [funcArgNamesDifferent] parse_l.c:315:46: note: Function 'yy_scan_string' argument 1 names different: declaration 'yy_str' definition 'yystr'. parse_l.c:2034:46: note: Function 'yy_scan_string' argument 1 names different: declaration 'yy_str' definition 'yystr'. parse_l.c:2047:46: style:inconclusive: Function 'yy_scan_bytes' argument 1 names different: declaration 'bytes' definition 'yybytes'. [funcArgNamesDifferent] parse_l.c:316:45: note: Function 'yy_scan_bytes' argument 1 names different: declaration 'bytes' definition 'yybytes'. parse_l.c:2047:46: note: Function 'yy_scan_bytes' argument 1 names different: declaration 'bytes' definition 'yybytes'. parse_l.c:2047:60: style:inconclusive: Function 'yy_scan_bytes' argument 2 names different: declaration 'len' definition '_yybytes_len'. [funcArgNamesDifferent] parse_l.c:316:56: note: Function 'yy_scan_bytes' argument 2 names different: declaration 'len' definition '_yybytes_len'. parse_l.c:2047:60: note: Function 'yy_scan_bytes' argument 2 names different: declaration 'len' definition '_yybytes_len'. parse_l.c:2179:24: style:inconclusive: Function 'yyset_debug' argument 1 names different: declaration 'debug_flag' definition '_bdebug'. [funcArgNamesDifferent] parse_l.c:705:24: note: Function 'yyset_debug' argument 1 names different: declaration 'debug_flag' definition '_bdebug'. parse_l.c:2179:24: note: Function 'yyset_debug' argument 1 names different: declaration 'debug_flag' definition '_bdebug'. parse_l.c:1414:8: style: Variable 'source' can be declared as pointer to const [constVariablePointer] parse_l.c:1621:9: style: Variable 'source' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/pcb-printf.c:175:42: style:inconclusive: Function 'get_unit_struct' argument 1 names different: declaration 'suffix' definition 'const_suffix'. [funcArgNamesDifferent] pcb-4.3.0/src/pcb-printf.h:162:42: note: Function 'get_unit_struct' argument 1 names different: declaration 'suffix' definition 'const_suffix'. pcb-4.3.0/src/pcb-printf.c:175:42: note: Function 'get_unit_struct' argument 1 names different: declaration 'suffix' definition 'const_suffix'. pcb-4.3.0/src/pcb-printf.c:723:23: style:inconclusive: Function 'pcb_fprintf' argument 1 names different: declaration 'f' definition 'fh'. [funcArgNamesDifferent] pcb-4.3.0/src/pcb-printf.h:171:23: note: Function 'pcb_fprintf' argument 1 names different: declaration 'f' definition 'fh'. pcb-4.3.0/src/pcb-printf.c:723:23: note: Function 'pcb_fprintf' argument 1 names different: declaration 'f' definition 'fh'. parse_y.c:1679:5: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] parse_y.y:282:5: style: Obsolescent function 'bzero' called. It is recommended to use 'memset' instead. [prohibitedbzeroCalled] parse_y.c:1679:11: style: Variable 'yymsg' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/polygon.c:2001:3: portability: %d in format string (no. 2) requires 'int' but the argument type is 'Cardinal {aka unsigned int}'. [invalidPrintfArgType_sint] pcb-4.3.0/src/polygon.c:2006:7: portability: %d in format string (no. 1) requires 'int' but the argument type is 'Cardinal {aka unsigned int}'. [invalidPrintfArgType_sint] pcb-4.3.0/src/polygon.c:2008:9: portability: %d in format string (no. 1) requires 'int' but the argument type is 'Cardinal {aka unsigned int}'. [invalidPrintfArgType_sint] pcb-4.3.0/src/polygon.c:2008:9: portability: %d in format string (no. 2) requires 'int' but the argument type is 'Cardinal {aka unsigned int}'. [invalidPrintfArgType_sint] pcb-4.3.0/src/polygon.c:585:20: style:inconclusive: Function 'ArcPoly' argument 1 names different: declaration 'l' definition 'a'. [funcArgNamesDifferent] pcb-4.3.0/src/polygon.h:86:29: note: Function 'ArcPoly' argument 1 names different: declaration 'l' definition 'a'. pcb-4.3.0/src/polygon.c:585:20: note: Function 'ArcPoly' argument 1 names different: declaration 'l' definition 'a'. pcb-4.3.0/src/polygon.c:615:22: style:inconclusive: Function 'LinePoly' argument 1 names different: declaration 'l' definition 'L'. [funcArgNamesDifferent] pcb-4.3.0/src/polygon.h:85:31: note: Function 'LinePoly' argument 1 names different: declaration 'l' definition 'L'. pcb-4.3.0/src/polygon.c:615:22: note: Function 'LinePoly' argument 1 names different: declaration 'l' definition 'L'. pcb-4.3.0/src/polygon.c:803:20: style:inconclusive: Function 'PinPoly' argument 1 names different: declaration 'l' definition 'pin'. [funcArgNamesDifferent] pcb-4.3.0/src/polygon.h:87:29: note: Function 'PinPoly' argument 1 names different: declaration 'l' definition 'pin'. pcb-4.3.0/src/polygon.c:803:20: note: Function 'PinPoly' argument 1 names different: declaration 'l' definition 'pin'. pcb-4.3.0/src/polygon.c:825:37: style:inconclusive: Function 'BoxPolyBloated' argument 2 names different: declaration 'radius' definition 'bloat'. [funcArgNamesDifferent] pcb-4.3.0/src/polygon.h:88:48: note: Function 'BoxPolyBloated' argument 2 names different: declaration 'radius' definition 'bloat'. pcb-4.3.0/src/polygon.c:825:37: note: Function 'BoxPolyBloated' argument 2 names different: declaration 'radius' definition 'bloat'. pcb-4.3.0/src/polygon.c:1267:21: style:inconclusive: Function 'InitClip' argument 1 names different: declaration 'd' definition 'Data'. [funcArgNamesDifferent] pcb-4.3.0/src/polygon.h:90:24: note: Function 'InitClip' argument 1 names different: declaration 'd' definition 'Data'. pcb-4.3.0/src/polygon.c:1267:21: note: Function 'InitClip' argument 1 names different: declaration 'd' definition 'Data'. pcb-4.3.0/src/polygon.c:1267:38: style:inconclusive: Function 'InitClip' argument 2 names different: declaration 'l' definition 'layer'. [funcArgNamesDifferent] pcb-4.3.0/src/polygon.h:90:38: note: Function 'InitClip' argument 2 names different: declaration 'l' definition 'layer'. pcb-4.3.0/src/polygon.c:1267:38: note: Function 'InitClip' argument 2 names different: declaration 'l' definition 'layer'. pcb-4.3.0/src/polygon.c:1500:28: style:inconclusive: Function 'PolygonHoles' argument 1 names different: declaration 'ptr' definition 'polygon'. [funcArgNamesDifferent] pcb-4.3.0/src/polygon.h:72:32: note: Function 'PolygonHoles' argument 1 names different: declaration 'ptr' definition 'polygon'. pcb-4.3.0/src/polygon.c:1500:28: note: Function 'PolygonHoles' argument 1 names different: declaration 'ptr' definition 'polygon'. pcb-4.3.0/src/polygon.c:843:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/polygon.c:962:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/polygon.c:145:37: style: Parameter 'polygon' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/polygon.c:615:22: style: Parameter 'L' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/polygon.c:677:26: style: Parameter 'pad' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/polygon.c:825:26: style: Parameter 'box' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/polygon.c:1074:18: style: Parameter 'Data' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/polygon.c:1341:14: style: Variable 'ptr1' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/polygon.c:1341:21: style: Variable 'ptr2' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/polygon.c:1504:13: style: Variable 'pa' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/polygon.c:1584:12: style: Variable 'via' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/polygon.c:1869:35: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/polygon.c:1906:17: style: Variable 'start' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/print.c:317:46: portability: Non reentrant function 'gmtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'gmtime_r'. [prohibitedgmtimeCalled] pcb-4.3.0/src/print.c:214:18: style: Variable 'drill' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/print.c:325:18: style: Variable 'l' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/puller.c:526:15: style: Variable 'arc_angle' is reassigned a value before the old one has been used. [redundantAssignment] pcb-4.3.0/src/puller.c:507:15: note: arc_angle is assigned pcb-4.3.0/src/puller.c:526:15: note: arc_angle is overwritten pcb-4.3.0/src/puller.c:526:15: style: Variable 'arc_angle' is reassigned a value before the old one has been used. [redundantAssignment] pcb-4.3.0/src/puller.c:509:15: note: arc_angle is assigned pcb-4.3.0/src/puller.c:526:15: note: arc_angle is overwritten pcb-4.3.0/src/puller.c:246:10: style: Local variable 'x' shadows outer variable [shadowVariable] pcb-4.3.0/src/puller.c:93:14: note: Shadowed declaration pcb-4.3.0/src/puller.c:246:10: note: Shadow variable pcb-4.3.0/src/puller.c:246:13: style: Local variable 'y' shadows outer variable [shadowVariable] pcb-4.3.0/src/puller.c:93:17: note: Shadowed declaration pcb-4.3.0/src/puller.c:246:13: note: Shadow variable pcb-4.3.0/src/puller.c:272:10: style: Local variable 'x' shadows outer variable [shadowVariable] pcb-4.3.0/src/puller.c:93:14: note: Shadowed declaration pcb-4.3.0/src/puller.c:272:10: note: Shadow variable pcb-4.3.0/src/puller.c:272:13: style: Local variable 'y' shadows outer variable [shadowVariable] pcb-4.3.0/src/puller.c:93:17: note: Shadowed declaration pcb-4.3.0/src/puller.c:272:13: note: Shadow variable pcb-4.3.0/src/puller.c:1352:9: style: Local variable 'x' shadows outer variable [shadowVariable] pcb-4.3.0/src/puller.c:93:14: note: Shadowed declaration pcb-4.3.0/src/puller.c:1352:9: note: Shadow variable pcb-4.3.0/src/puller.c:1352:12: style: Local variable 'y' shadows outer variable [shadowVariable] pcb-4.3.0/src/puller.c:93:17: note: Shadowed declaration pcb-4.3.0/src/puller.c:1352:12: note: Shadow variable pcb-4.3.0/src/puller.c:2029:9: style: Local variable 'ex' shadows outer variable [shadowVariable] pcb-4.3.0/src/puller.c:95:14: note: Shadowed declaration pcb-4.3.0/src/puller.c:2029:9: note: Shadow variable pcb-4.3.0/src/puller.c:2029:13: style: Local variable 'ey' shadows outer variable [shadowVariable] pcb-4.3.0/src/puller.c:95:18: note: Shadowed declaration pcb-4.3.0/src/puller.c:2029:13: note: Shadow variable pcb-4.3.0/src/puller.c:106:27: style: Parameter 'a' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/puller.c:330:41: style: Parameter 'cl' can be declared as pointer to const. However it seems that 'line_callback' is a callback function, if 'cl' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/puller.c:417:46: note: You might need to cast the function pointer here pcb-4.3.0/src/puller.c:330:41: note: Parameter 'cl' can be declared as pointer to const pcb-4.3.0/src/puller.c:670:20: style: Parameter 'x' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/puller.c:712:25: style: Parameter 'a' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/puller.c:2559:30: style: Parameter 'line' can be declared as pointer to const. However it seems that 'mark_ends_pending' is a callback function, if 'line' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/puller.c:2621:40: note: You might need to cast the function pointer here pcb-4.3.0/src/puller.c:2559:30: note: Parameter 'line' can be declared as pointer to const pcb-4.3.0/src/puller.c:2561:8: style: Variable 'select_flags' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/puller.c:895:8: style: Variable 'hits' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/puller.c:896:8: style: Variable 'hits' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/puller.c:1045:8: style: Variable 'hits' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/puller.c:1046:8: style: Variable 'hits' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/polygon1.c:1048:13: style: Condition 'intersect(e,a,b,add)' is always false [knownConditionTrueFalse] pcb-4.3.0/src/polygon1.c:1048:13: note: Calling function 'intersect' returns 0 pcb-4.3.0/src/polygon1.c:1048:13: note: Condition 'intersect(e,a,b,add)' is always false pcb-4.3.0/src/polygon1.c:444:11: warning: Either the condition 'l' is redundant or there is possible null pointer dereference: l. [nullPointerRedundantCheck] pcb-4.3.0/src/polygon1.c:448:11: note: Assuming that condition 'l' is not redundant pcb-4.3.0/src/polygon1.c:444:11: note: Null pointer dereference pcb-4.3.0/src/polygon1.c:446:11: warning: Either the condition 'l' is redundant or there is possible null pointer dereference: l. [nullPointerRedundantCheck] pcb-4.3.0/src/polygon1.c:448:11: note: Assuming that condition 'l' is not redundant pcb-4.3.0/src/polygon1.c:446:11: note: Null pointer dereference pcb-4.3.0/src/polygon1.c:1257:13: style: Redundant initialization for 'curc'. The initialized value is overwritten before it is read. [redundantInitialization] pcb-4.3.0/src/polygon1.c:1255:15: note: curc is initialized pcb-4.3.0/src/polygon1.c:1257:13: note: curc is overwritten pcb-4.3.0/src/polygon1.c:2391:22: style:inconclusive: Function 'Touching' argument 1 names different: declaration 'p1' definition 'a'. [funcArgNamesDifferent] pcb-4.3.0/src/polyarea.h:172:26: note: Function 'Touching' argument 1 names different: declaration 'p1' definition 'a'. pcb-4.3.0/src/polygon1.c:2391:22: note: Function 'Touching' argument 1 names different: declaration 'p1' definition 'a'. pcb-4.3.0/src/polygon1.c:2391:36: style:inconclusive: Function 'Touching' argument 2 names different: declaration 'p2' definition 'b'. [funcArgNamesDifferent] pcb-4.3.0/src/polyarea.h:172:40: note: Function 'Touching' argument 2 names different: declaration 'p2' definition 'b'. pcb-4.3.0/src/polygon1.c:2391:36: note: Function 'Touching' argument 2 names different: declaration 'p2' definition 'b'. pcb-4.3.0/src/polygon1.c:2420:32: style:inconclusive: Function 'poly_Boolean' argument 1 names different: declaration 'a' definition 'a_org'. [funcArgNamesDifferent] pcb-4.3.0/src/polyarea.h:203:35: note: Function 'poly_Boolean' argument 1 names different: declaration 'a' definition 'a_org'. pcb-4.3.0/src/polygon1.c:2420:32: note: Function 'poly_Boolean' argument 1 names different: declaration 'a' definition 'a_org'. pcb-4.3.0/src/polygon1.c:2420:56: style:inconclusive: Function 'poly_Boolean' argument 2 names different: declaration 'b' definition 'b_org'. [funcArgNamesDifferent] pcb-4.3.0/src/polyarea.h:203:55: note: Function 'poly_Boolean' argument 2 names different: declaration 'b' definition 'b_org'. pcb-4.3.0/src/polygon1.c:2420:56: note: Function 'poly_Boolean' argument 2 names different: declaration 'b' definition 'b_org'. pcb-4.3.0/src/polygon1.c:2435:31: style:inconclusive: Function 'poly_Boolean_free' argument 1 names different: declaration 'a' definition 'ai'. [funcArgNamesDifferent] pcb-4.3.0/src/polyarea.h:204:34: note: Function 'poly_Boolean_free' argument 1 names different: declaration 'a' definition 'ai'. pcb-4.3.0/src/polygon1.c:2435:31: note: Function 'poly_Boolean_free' argument 1 names different: declaration 'a' definition 'ai'. pcb-4.3.0/src/polygon1.c:2435:46: style:inconclusive: Function 'poly_Boolean_free' argument 2 names different: declaration 'b' definition 'bi'. [funcArgNamesDifferent] pcb-4.3.0/src/polyarea.h:204:48: note: Function 'poly_Boolean_free' argument 2 names different: declaration 'b' definition 'bi'. pcb-4.3.0/src/polygon1.c:2435:46: note: Function 'poly_Boolean_free' argument 2 names different: declaration 'b' definition 'bi'. pcb-4.3.0/src/polygon1.c:2557:35: style:inconclusive: Function 'poly_AndSubtract_free' argument 1 names different: declaration 'a' definition 'ai'. [funcArgNamesDifferent] pcb-4.3.0/src/polyarea.h:205:38: note: Function 'poly_AndSubtract_free' argument 1 names different: declaration 'a' definition 'ai'. pcb-4.3.0/src/polygon1.c:2557:35: note: Function 'poly_AndSubtract_free' argument 1 names different: declaration 'a' definition 'ai'. pcb-4.3.0/src/polygon1.c:2557:50: style:inconclusive: Function 'poly_AndSubtract_free' argument 2 names different: declaration 'b' definition 'bi'. [funcArgNamesDifferent] pcb-4.3.0/src/polyarea.h:205:52: note: Function 'poly_AndSubtract_free' argument 2 names different: declaration 'b' definition 'bi'. pcb-4.3.0/src/polygon1.c:2557:50: note: Function 'poly_AndSubtract_free' argument 2 names different: declaration 'b' definition 'bi'. pcb-4.3.0/src/polygon1.c:2761:26: style:inconclusive: Function 'poly_PreContour' argument 1 names different: declaration 'c' definition 'C'. [funcArgNamesDifferent] pcb-4.3.0/src/polyarea.h:139:30: note: Function 'poly_PreContour' argument 1 names different: declaration 'c' definition 'C'. pcb-4.3.0/src/polygon1.c:2761:26: note: Function 'poly_PreContour' argument 1 names different: declaration 'c' definition 'C'. pcb-4.3.0/src/polygon1.c:3157:39: style:inconclusive: Function 'poly_InsideContour' argument 2 names different: declaration 'v' definition 'p'. [funcArgNamesDifferent] pcb-4.3.0/src/polyarea.h:180:41: note: Function 'poly_InsideContour' argument 2 names different: declaration 'v' definition 'p'. pcb-4.3.0/src/polygon1.c:3157:39: note: Function 'poly_InsideContour' argument 2 names different: declaration 'v' definition 'p'. pcb-4.3.0/src/polygon1.c:3189:30: style:inconclusive: Function 'poly_CheckInside' argument 1 names different: declaration 'c' definition 'p'. [funcArgNamesDifferent] pcb-4.3.0/src/polyarea.h:171:35: note: Function 'poly_CheckInside' argument 1 names different: declaration 'c' definition 'p'. pcb-4.3.0/src/polygon1.c:3189:30: note: Function 'poly_CheckInside' argument 1 names different: declaration 'c' definition 'p'. pcb-4.3.0/src/polygon1.c:3430:29: style:inconclusive: Function 'poly_FreeContours' argument 1 names different: declaration 'pl' definition 'pline'. [funcArgNamesDifferent] pcb-4.3.0/src/polyarea.h:186:32: note: Function 'poly_FreeContours' argument 1 names different: declaration 'pl' definition 'pline'. pcb-4.3.0/src/polygon1.c:3430:29: note: Function 'poly_FreeContours' argument 1 names different: declaration 'pl' definition 'pline'. pcb-4.3.0/src/polygon1.c:3642:18: warning: Function 'vect_sub' argument order different: declaration 'res, v2, v3' definition 'res, v1, v2' [funcArgOrderDifferent] pcb-4.3.0/src/polygon1.c:97:23: note: Function 'vect_sub' argument order different: declaration 'res, v2, v3' definition 'res, v1, v2' pcb-4.3.0/src/polygon1.c:3642:18: note: Function 'vect_sub' argument order different: declaration 'res, v2, v3' definition 'res, v1, v2' pcb-4.3.0/src/polygon1.c:3647:18: style:inconclusive: Function 'vect_min' argument 1 names different: declaration 'res' definition 'v1'. [funcArgNamesDifferent] pcb-4.3.0/src/polygon1.c:99:23: note: Function 'vect_min' argument 1 names different: declaration 'res' definition 'v1'. pcb-4.3.0/src/polygon1.c:3647:18: note: Function 'vect_min' argument 1 names different: declaration 'res' definition 'v1'. pcb-4.3.0/src/polygon1.c:3654:18: style:inconclusive: Function 'vect_max' argument 1 names different: declaration 'res' definition 'v1'. [funcArgNamesDifferent] pcb-4.3.0/src/polygon1.c:100:23: note: Function 'vect_max' argument 1 names different: declaration 'res' definition 'v1'. pcb-4.3.0/src/polygon1.c:3654:18: note: Function 'vect_max' argument 1 names different: declaration 'res' definition 'v1'. pcb-4.3.0/src/polygon1.c:3661:19: style:inconclusive: Function 'vect_len2' argument 1 names different: declaration 'v1' definition 'v'. [funcArgNamesDifferent] pcb-4.3.0/src/polyarea.h:198:26: note: Function 'vect_len2' argument 1 names different: declaration 'v1' definition 'v'. pcb-4.3.0/src/polygon1.c:3661:19: note: Function 'vect_len2' argument 1 names different: declaration 'v1' definition 'v'. pcb-4.3.0/src/polygon1.c:3713:22: style:inconclusive: Function 'vect_inters2' argument 1 names different: declaration 'A' definition 'p1'. [funcArgNamesDifferent] pcb-4.3.0/src/polyarea.h:200:26: note: Function 'vect_inters2' argument 1 names different: declaration 'A' definition 'p1'. pcb-4.3.0/src/polygon1.c:3713:22: note: Function 'vect_inters2' argument 1 names different: declaration 'A' definition 'p1'. pcb-4.3.0/src/polygon1.c:3713:33: style:inconclusive: Function 'vect_inters2' argument 2 names different: declaration 'B' definition 'p2'. [funcArgNamesDifferent] pcb-4.3.0/src/polyarea.h:200:36: note: Function 'vect_inters2' argument 2 names different: declaration 'B' definition 'p2'. pcb-4.3.0/src/polygon1.c:3713:33: note: Function 'vect_inters2' argument 2 names different: declaration 'B' definition 'p2'. pcb-4.3.0/src/polygon1.c:3713:44: style:inconclusive: Function 'vect_inters2' argument 3 names different: declaration 'C' definition 'q1'. [funcArgNamesDifferent] pcb-4.3.0/src/polyarea.h:200:46: note: Function 'vect_inters2' argument 3 names different: declaration 'C' definition 'q1'. pcb-4.3.0/src/polygon1.c:3713:44: note: Function 'vect_inters2' argument 3 names different: declaration 'C' definition 'q1'. pcb-4.3.0/src/polygon1.c:3713:55: style:inconclusive: Function 'vect_inters2' argument 4 names different: declaration 'D' definition 'q2'. [funcArgNamesDifferent] pcb-4.3.0/src/polyarea.h:200:56: note: Function 'vect_inters2' argument 4 names different: declaration 'D' definition 'q2'. pcb-4.3.0/src/polygon1.c:3713:55: note: Function 'vect_inters2' argument 4 names different: declaration 'D' definition 'q2'. pcb-4.3.0/src/polygon1.c:2199:15: style: Local variable 'prev' shadows outer variable [shadowVariable] pcb-4.3.0/src/polygon1.c:2112:24: note: Shadowed declaration pcb-4.3.0/src/polygon1.c:2199:15: note: Shadow variable pcb-4.3.0/src/polygon1.c:623:16: style: Variable 'i' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/polygon1.c:1071:25: style: Parameter 'c1' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/polygon1.c:1071:37: style: Parameter 'c2' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/polygon1.c:1201:10: style: Variable 'first_labelled' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/polygon1.c:1383:10: style: Variable 'p' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/polygon1.c:1609:20: style: Parameter 'cur' can be declared as pointer to const. However it seems that 'XorS_Rule' is a callback function, if 'cur' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/polygon1.c:1854:37: note: You might need to cast the function pointer here pcb-4.3.0/src/polygon1.c:1609:20: note: Parameter 'cur' can be declared as pointer to const pcb-4.3.0/src/polygon1.c:1625:45: style: Parameter 'cdir' can be declared as pointer to const. However it seems that 'IsectJ_Rule' is a callback function, if 'cdir' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/polygon1.c:1851:50: note: You might need to cast the function pointer here pcb-4.3.0/src/polygon1.c:1625:45: note: Parameter 'cdir' can be declared as pointer to const pcb-4.3.0/src/polygon1.c:1632:45: style: Parameter 'cdir' can be declared as pointer to const. However it seems that 'UniteJ_Rule' is a callback function, if 'cdir' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/polygon1.c:1848:50: note: You might need to cast the function pointer here pcb-4.3.0/src/polygon1.c:1632:45: note: Parameter 'cdir' can be declared as pointer to const pcb-4.3.0/src/polygon1.c:1639:28: style: Parameter 'v' can be declared as pointer to const. However it seems that 'XorJ_Rule' is a callback function, if 'v' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/polygon1.c:1854:48: note: You might need to cast the function pointer here pcb-4.3.0/src/polygon1.c:1639:28: note: Parameter 'v' can be declared as pointer to const pcb-4.3.0/src/polygon1.c:1655:28: style: Parameter 'v' can be declared as pointer to const. However it seems that 'SubJ_Rule' is a callback function, if 'v' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/polygon1.c:1857:48: note: You might need to cast the function pointer here pcb-4.3.0/src/polygon1.c:1655:28: note: Parameter 'v' can be declared as pointer to const pcb-4.3.0/src/polygon1.c:1689:16: style: Variable 'start' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/polygon1.c:1963:30: style: Parameter 'a' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/polygon1.c:1963:41: style: Parameter 'cur' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/polygon1.c:1970:26: style: Parameter 'cur' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/polygon1.c:2141:16: style: Variable 'b_box' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/polygon1.c:2620:26: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/polygon1.c:2628:26: style: Parameter 'a' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/polygon1.c:2628:37: style: Parameter 'b' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/polygon1.c:1544:29: error: Uninitialized struct member: info.result [uninitStructMember] pcb-4.3.0/src/polygon1.c:2224:29: error: Uninitialized struct member: info.result [uninitStructMember] pcb-4.3.0/src/remove.c:494:28: style: Condition 'contour==0' is always false [knownConditionTrueFalse] pcb-4.3.0/src/remove.c:481:15: note: Assuming that condition 'contour==0' is not redundant pcb-4.3.0/src/remove.c:494:28: note: Condition 'contour==0' is always false pcb-4.3.0/src/renumber.c:81:11: style: Variable 'refdes_split' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/renumber.c:152:11: style: Variable 'refdes_split' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/rats.c:100:24: style: Parameter 'InString' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/rats.c:129:35: style: Parameter 'PinNum' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/rats.c:351:3: style: Variable 'connection' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/rats.c:778:5: style: Variable 'connection' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/rats.c:871:5: style: Variable 'connection' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/rats.c:896:17: style: Parameter 'name' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/rats.c:901:3: style: Variable 'menu' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/rats.c:1026:33: style: Parameter 'ptr1' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/rats.c:1029:9: style: Variable 'num' can be declared as pointer to const [constVariablePointer] res_lex.c:1695:2: warning: Possible null pointer dereference: b [nullPointer] res_lex.c:1588:18: note: Calling function 'res_init_buffer', 1st argument '(yy_buffer_stack)?(yy_buffer_stack)[yy_buffer_stack_top]:NULL' value is 0 res_lex.c:1695:2: note: Null pointer dereference res_lex.c:1696:2: warning: Possible null pointer dereference: b [nullPointer] res_lex.c:1588:18: note: Calling function 'res_init_buffer', 1st argument '(yy_buffer_stack)?(yy_buffer_stack)[yy_buffer_stack_top]:NULL' value is 0 res_lex.c:1696:2: note: Null pointer dereference res_lex.c:1427:59: style:inconclusive: Function 'yy_try_NUL_trans' argument 1 names different: declaration 'current_state' definition 'yy_current_state'. [funcArgNamesDifferent] res_lex.c:623:55: note: Function 'yy_try_NUL_trans' argument 1 names different: declaration 'current_state' definition 'yy_current_state'. res_lex.c:1427:59: note: Function 'yy_try_NUL_trans' argument 1 names different: declaration 'current_state' definition 'yy_current_state'. res_lex.c:1452:40: style:inconclusive: Function 'yyunput' argument 2 names different: declaration 'buf_ptr' definition 'yy_bp'. [funcArgNamesDifferent] res_lex.c:839:40: note: Function 'yyunput' argument 2 names different: declaration 'buf_ptr' definition 'yy_bp'. res_lex.c:1452:40: note: Function 'yyunput' argument 2 names different: declaration 'buf_ptr' definition 'yy_bp'. res_lex.c:1880:46: style:inconclusive: Function 'res_scan_string' argument 1 names different: declaration 'yy_str' definition 'yystr'. [funcArgNamesDifferent] res_lex.c:575:46: note: Function 'res_scan_string' argument 1 names different: declaration 'yy_str' definition 'yystr'. res_lex.c:1880:46: note: Function 'res_scan_string' argument 1 names different: declaration 'yy_str' definition 'yystr'. res_lex.c:1893:46: style:inconclusive: Function 'res_scan_bytes' argument 1 names different: declaration 'bytes' definition 'yybytes'. [funcArgNamesDifferent] res_lex.c:576:45: note: Function 'res_scan_bytes' argument 1 names different: declaration 'bytes' definition 'yybytes'. res_lex.c:1893:46: note: Function 'res_scan_bytes' argument 1 names different: declaration 'bytes' definition 'yybytes'. res_lex.c:1893:60: style:inconclusive: Function 'res_scan_bytes' argument 2 names different: declaration 'len' definition '_yybytes_len'. [funcArgNamesDifferent] res_lex.c:576:56: note: Function 'res_scan_bytes' argument 2 names different: declaration 'len' definition '_yybytes_len'. res_lex.c:1893:60: note: Function 'res_scan_bytes' argument 2 names different: declaration 'len' definition '_yybytes_len'. res_lex.c:2025:24: style:inconclusive: Function 'resset_debug' argument 1 names different: declaration 'debug_flag' definition '_bdebug'. [funcArgNamesDifferent] res_lex.c:803:24: note: Function 'resset_debug' argument 1 names different: declaration 'debug_flag' definition '_bdebug'. res_lex.c:2025:24: note: Function 'resset_debug' argument 1 names different: declaration 'debug_flag' definition '_bdebug'. res_lex.c:1260:8: style: Variable 'source' can be declared as pointer to const [constVariablePointer] res_lex.c:1467:9: style: Variable 'source' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/report.c:952:11: style: Condition 'net_found' is always true [knownConditionTrueFalse] pcb-4.3.0/src/report.c:102:3: portability: %d in format string (no. 1) requires 'int' but the argument type is 'Cardinal {aka unsigned int}'. [invalidPrintfArgType_sint] pcb-4.3.0/src/report.c:761:40: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-4.3.0/src/report.c:786:40: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-4.3.0/src/report.c:618:9: style: Local variable 'l' shadows outer variable [shadowVariable] pcb-4.3.0/src/report.c:614:3: note: Shadowed declaration pcb-4.3.0/src/report.c:618:9: note: Shadow variable pcb-4.3.0/src/report.c:757:10: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-4.3.0/src/report.c:750:5: note: Shadowed declaration pcb-4.3.0/src/report.c:757:10: note: Shadow variable pcb-4.3.0/src/report.c:782:10: style: Local variable 'n' shadows outer variable [shadowVariable] pcb-4.3.0/src/report.c:775:5: note: Shadowed declaration pcb-4.3.0/src/report.c:782:10: note: Shadow variable pcb-4.3.0/src/report.c:665:8: style: Variable 'es' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/report.c:755:10: style: Variable 'ename' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/report.c:757:10: style: Variable 'n' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/report.c:780:10: style: Variable 'ename' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/report.c:782:10: style: Variable 'n' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/report.c:822:7: style: Unused variable: result [unusedVariable] res_parse.c:1081:5: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] res_parse.c:852:5: style: 'continue' is redundant since it is the last statement in a loop. [redundantContinue] res_parse.c:871:5: style: 'continue' is redundant since it is the last statement in a loop. [redundantContinue] res_parse.c:939:29: style: Parameter 'yyssp' can be declared as pointer to const [constParameterPointer] res_parse.c:1081:11: style: Variable 'yymsg' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/rubberband.c:280:17: style: Variable 'i' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/rubberband.c:381:43: style: Parameter 'Pin' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/rubberband.c:419:23: style: Parameter 'LinePoint' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/rubberband.c:457:20: style: Parameter 'Arc' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/rubberband.c:458:22: style: Parameter 'ArcPoint' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/rubberband.c:199:9: style: float result is assigned to double variable. If the variable is double to avoid loss of information, then you have loss of information. [truncLongCastAssignment] pcb-4.3.0/src/rtree.c:125:31: style: Condition 'node->u.rects[i].bptr' is always true [knownConditionTrueFalse] pcb-4.3.0/src/rtree.c:164:27: style: Condition 'node->u.kids[i]' is always true [knownConditionTrueFalse] pcb-4.3.0/src/rtree.c:208:7: style: Condition '!__r_node_is_good(node)' is always false [knownConditionTrueFalse] pcb-4.3.0/src/rtree.c:208:25: note: Calling function '__r_node_is_good' returns 1 pcb-4.3.0/src/rtree.c:208:7: note: Condition '!__r_node_is_good(node)' is always false pcb-4.3.0/src/rtree.c:612:44: style:inconclusive: Function 'r_search' argument 2 names different: declaration 'starting_region' definition 'query'. [funcArgNamesDifferent] pcb-4.3.0/src/rtree.h:52:48: note: Function 'r_search' argument 2 names different: declaration 'starting_region' definition 'query'. pcb-4.3.0/src/rtree.c:612:44: note: Function 'r_search' argument 2 names different: declaration 'starting_region' definition 'query'. pcb-4.3.0/src/rtree.c:614:73: style:inconclusive: Function 'r_search' argument 5 names different: declaration 'closure' definition 'cl'. [funcArgNamesDifferent] pcb-4.3.0/src/rtree.h:55:14: note: Function 'r_search' argument 5 names different: declaration 'closure' definition 'cl'. pcb-4.3.0/src/rtree.c:614:73: note: Function 'r_search' argument 5 names different: declaration 'closure' definition 'cl'. pcb-4.3.0/src/rtree.c:1051:61: style:inconclusive: Function 'r_insert_entry' argument 3 names different: declaration 'manage' definition 'man'. [funcArgNamesDifferent] pcb-4.3.0/src/rtree.h:51:66: note: Function 'r_insert_entry' argument 3 names different: declaration 'manage' definition 'man'. pcb-4.3.0/src/rtree.c:1051:61: note: Function 'r_insert_entry' argument 3 names different: declaration 'manage' definition 'man'. pcb-4.3.0/src/rtree.c:1174:50: style:inconclusive: Function 'r_delete_entry' argument 2 names different: declaration 'which' definition 'box'. [funcArgNamesDifferent] pcb-4.3.0/src/rtree.h:50:55: note: Function 'r_delete_entry' argument 2 names different: declaration 'which' definition 'box'. pcb-4.3.0/src/rtree.c:1174:50: note: Function 'r_delete_entry' argument 2 names different: declaration 'which' definition 'box'. pcb-4.3.0/src/rtree.c:704:12: style: Variable 'b' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/rtree.c:899:31: style: Parameter 'node' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/search.c:118:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/search.c:192:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/search.c:253:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/search.c:294:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/search.c:345:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/search.c:385:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/search.c:425:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/search.c:468:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/search.c:520:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/search.c:604:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/search.c:660:7: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/search.c:739:46: style: Parameter 'Line' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/search.c:874:48: style: Parameter 'l' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/search.c:995:56: style: Parameter 'Pad' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/search.c:1075:42: style: Parameter 'box' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/search.c:1124:56: style: Parameter 'Arc' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/search.c:1234:20: style: Variable 'box' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/search.c:1348:16: style: Variable 'box' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/search.c:1359:16: style: Variable 'box' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/search.c:1673:44: style: Parameter 'Name' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/search.c:1697:42: style: Parameter 'Name' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/search.c:643:17: style: float result is assigned to double variable. If the variable is double to avoid loss of information, then you have loss of information. [truncLongCastAssignment] pcb-4.3.0/src/search.c:701:17: style: float result is assigned to double variable. If the variable is double to avoid loss of information, then you have loss of information. [truncLongCastAssignment] pcb-4.3.0/src/set.c:184:20: style: The statement 'if (PCB->Changed!=New) PCB->Changed=New' is logically equivalent to 'PCB->Changed=New'. [duplicateConditionalAssign] pcb-4.3.0/src/set.c:186:20: note: Assignment 'PCB->Changed=New' pcb-4.3.0/src/set.c:184:20: note: Condition 'PCB->Changed!=New' is redundant pcb-4.3.0/src/set.c:331:2: portability: %d in format string (no. 1) requires 'int' but the argument type is 'Cardinal {aka unsigned int}'. [invalidPrintfArgType_sint] pcb-4.3.0/src/set.c:332:32: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] pcb-4.3.0/src/set.c:145:39: style: Parameter 'rst' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/set.c:323:22: style: Parameter 'name' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/set.c:388:9: style: Variable 'nstyle' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/set.c:390:9: style: Variable 'thickness' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/set.c:391:9: style: Variable 'diameter' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/set.c:392:9: style: Variable 'drill' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/set.c:393:9: style: Variable 'keepaway' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/set.c:394:9: style: Variable 'mask_aperture' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/set.c:395:9: style: Variable 'units' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/smartdisperse.c:167:9: style: Variable 'function' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/strflags.c:213:7: error: Common realloc mistake: 'layers' nulled but not freed upon failure [memleakOnRealloc] pcb-4.3.0/src/strflags.c:369:2: error: Common realloc mistake: 'buf' nulled but not freed upon failure [memleakOnRealloc] pcb-4.3.0/src/strflags.c:571:6: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/strflags.c:581:6: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/strflags.c:592:6: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/strflags.c:609:6: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/strflags.c:306:10: style: Variable 'fmt' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/thermal.c:438:15: style: Local variable 't' shadows outer variable [shadowVariable] pcb-4.3.0/src/thermal.c:413:9: note: Shadowed declaration pcb-4.3.0/src/thermal.c:438:15: note: Shadow variable pcb-4.3.0/src/thermal.c:137:24: style: Parameter 'pin' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/thermal.c:94:8: style: struct member 'cent::style' is never used. [unusedStructMember] pcb-4.3.0/src/thermal.c:95:13: style: struct member 'cent::p' is never used. [unusedStructMember] pcb-4.3.0/src/undo.c:270:7: error: Common realloc mistake: 'UndoList' nulled but not freed upon failure [memleakOnRealloc] pcb-4.3.0/src/undo.c:892:37: style: Parameter 'Entry' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/undo.c:986:22: style: Variable 'saved' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/undo.c:1561:49: style: Parameter 'Ptr1' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/undo.c:1561:61: style: Parameter 'Ptr2' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/undo.c:1571:18: style: Variable 'copy' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/undo.c:1799:12: style: Variable 'a' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/vector.c:230:30: style:inconclusive: Function 'vector_duplicate' argument 1 names different: declaration 'vector' definition 'orig'. [funcArgNamesDifferent] pcb-4.3.0/src/vector.h:55:40: note: Function 'vector_duplicate' argument 1 names different: declaration 'vector' definition 'orig'. pcb-4.3.0/src/vector.c:230:30: note: Function 'vector_duplicate' argument 1 names different: declaration 'vector' definition 'orig'. pcb-4.3.0/src/vector.c:83:30: style: Parameter 'vector' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/vector.c:230:30: style: Parameter 'orig' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/select.c:202:11: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] pcb-4.3.0/src/select.c:199:9: note: outer condition: PCB->ElementOn pcb-4.3.0/src/select.c:202:11: note: identical inner condition: PCB->ElementOn pcb-4.3.0/src/select.c:383:11: style: Variable 'changed' is reassigned a value before the old one has been used. [redundantAssignment] pcb-4.3.0/src/select.c:365:17: note: changed is assigned pcb-4.3.0/src/select.c:383:11: note: changed is overwritten pcb-4.3.0/src/select.c:383:11: style: Variable 'changed' is reassigned a value before the old one has been used. [redundantAssignment] pcb-4.3.0/src/select.c:377:17: note: changed is assigned pcb-4.3.0/src/select.c:383:11: note: changed is overwritten pcb-4.3.0/src/select.c:736:9: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/select.c:748:9: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/select.c:759:9: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/select.c:770:9: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/select.c:784:40: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/select.c:795:40: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/select.c:809:9: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] pcb-4.3.0/src/select.c:225:23: style: Parameter 'Box' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/tools/gerbertotk.c:62:1: portability: Omitted return type of function 'do_cmd' defaults to int, this is not supported by ISO C99 and later standards. [returnImplicitInt] pcb-4.3.0/tools/gerbertotk.c:132:1: portability: Omitted return type of function 'main' defaults to int, this is not supported by ISO C99 and later standards. [returnImplicitInt] pcb-4.3.0/tools/gerbertotk.c:62:42: style: Parameter 'buffer' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/tools/gerbertotk.c:132:22: style: Parameter 'argv' can be declared as const array [constParameter] pcb-4.3.0/src/vendor.c:308:11: style: Condition 'fname' is always true [knownConditionTrueFalse] pcb-4.3.0/src/vendor.c:712:7: portability: %ld in format string (no. 1) requires 'long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] pcb-4.3.0/src/vendor.c:709:8: error: Common realloc mistake: 'vendor_drills' nulled but not freed upon failure [memleakOnRealloc] pcb-4.3.0/src/vendor.c:807:15: error: Common realloc mistake: 'lst' nulled but not freed upon failure [memleakOnRealloc] pcb-4.3.0/src/vendor.c:283:13: style: Variable 'res' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/vendor.c:283:19: style: Variable 'drcres' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/vendor.c:701:22: style: Parameter 'sval' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/vendor.c:756:9: style: Variable 'sval' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/vendor.c:981:38: style: Parameter 'data' can be declared as pointer to const. However it seems that 'vendor_get_enabled' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/vendor.c:987:19: note: You might need to cast the function pointer here pcb-4.3.0/src/vendor.c:981:38: note: Parameter 'data' can be declared as pointer to const pcb-4.3.0/src/toporouter.c:7693:27: style: Obsolete function 'asctime' called. It is recommended to use 'strftime' instead. [prohibitedasctimeCalled] pcb-4.3.0/src/toporouter.c:7693:35: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] pcb-4.3.0/src/toporouter.c:2952:32: style: Condition 'waiting' is always true [knownConditionTrueFalse] pcb-4.3.0/src/toporouter.c:2950:19: note: Assignment 'waiting=1', assigned value is 1 pcb-4.3.0/src/toporouter.c:2952:32: note: Condition 'waiting' is always true pcb-4.3.0/src/toporouter.c:7318:32: style: Condition 'routedata->src->c!=routedata->dest->c' is always false [knownConditionTrueFalse] pcb-4.3.0/src/toporouter.c:7316:24: note: Assuming that condition 'routedata->src->c==routedata->dest->c' is not redundant pcb-4.3.0/src/toporouter.c:7318:32: note: Condition 'routedata->src->c!=routedata->dest->c' is always false pcb-4.3.0/src/toporouter.c:6868:5: error: Memory leak: netscore [memleak] pcb-4.3.0/src/toporouter.c:4624:8: warning:inconclusive: Either the condition 'pv' is redundant or there is possible null pointer dereference: pv. [nullPointerRedundantCheck] pcb-4.3.0/src/toporouter.c:4647:8: note: Assuming that condition 'pv' is not redundant pcb-4.3.0/src/toporouter.c:4624:8: note: Null pointer dereference pcb-4.3.0/src/toporouter.c:4642:10: warning: Either the condition 'pv' is redundant or there is possible null pointer dereference: pv. [nullPointerRedundantCheck] pcb-4.3.0/src/toporouter.c:4647:8: note: Assuming that condition 'pv' is not redundant pcb-4.3.0/src/toporouter.c:4642:10: note: Null pointer dereference pcb-4.3.0/src/toporouter.c:4766:10: warning: Possible null pointer dereference: srcv [nullPointer] pcb-4.3.0/src/toporouter.c:4747:14: note: Assignment 'srcv=NULL', assigned value is 0 pcb-4.3.0/src/toporouter.c:4752:13: note: Assuming condition is false pcb-4.3.0/src/toporouter.c:4766:10: note: Null pointer dereference pcb-4.3.0/src/toporouter.c:3160:5: style: Redundant initialization for 'i'. The initialized value is overwritten before it is read. [redundantInitialization] pcb-4.3.0/src/toporouter.c:3155:12: note: i is initialized pcb-4.3.0/src/toporouter.c:3160:5: note: i is overwritten pcb-4.3.0/src/toporouter.c:5098:5: style: Redundant initialization for 'i'. The initialized value is overwritten before it is read. [redundantInitialization] pcb-4.3.0/src/toporouter.c:5084:12: note: i is initialized pcb-4.3.0/src/toporouter.c:5098:5: note: i is overwritten pcb-4.3.0/src/toporouter.c:5263:5: style: Redundant initialization for 'i'. The initialized value is overwritten before it is read. [redundantInitialization] pcb-4.3.0/src/toporouter.c:5249:12: note: i is initialized pcb-4.3.0/src/toporouter.c:5263:5: note: i is overwritten pcb-4.3.0/src/toporouter.c:7419:7: style: Redundant initialization for 'k'. The initialized value is overwritten before it is read. [redundantInitialization] pcb-4.3.0/src/toporouter.c:7417:52: note: k is initialized pcb-4.3.0/src/toporouter.c:7419:7: note: k is overwritten pcb-4.3.0/src/toporouter.c:4632:26: style: Local variable 'pv' shadows outer argument [shadowArgument] pcb-4.3.0/src/toporouter.c:4619:122: note: Shadowed declaration pcb-4.3.0/src/toporouter.c:4632:26: note: Shadow variable pcb-4.3.0/src/toporouter.c:4710:12: style: Local variable 'i' shadows outer variable [shadowVariable] pcb-4.3.0/src/toporouter.c:4676:10: note: Shadowed declaration pcb-4.3.0/src/toporouter.c:4710:12: note: Shadow variable pcb-4.3.0/src/toporouter.c:4954:12: style: Local variable 'i' shadows outer variable [shadowVariable] pcb-4.3.0/src/toporouter.c:4676:10: note: Shadowed declaration pcb-4.3.0/src/toporouter.c:4954:12: note: Shadow variable pcb-4.3.0/src/toporouter.c:4971:12: style: Local variable 'i' shadows outer variable [shadowVariable] pcb-4.3.0/src/toporouter.c:4676:10: note: Shadowed declaration pcb-4.3.0/src/toporouter.c:4971:12: note: Shadow variable pcb-4.3.0/src/toporouter.c:4992:12: style: Local variable 'i' shadows outer variable [shadowVariable] pcb-4.3.0/src/toporouter.c:4676:10: note: Shadowed declaration pcb-4.3.0/src/toporouter.c:4992:12: note: Shadow variable pcb-4.3.0/src/toporouter.c:5013:12: style: Local variable 'i' shadows outer variable [shadowVariable] pcb-4.3.0/src/toporouter.c:4676:10: note: Shadowed declaration pcb-4.3.0/src/toporouter.c:5013:12: note: Shadow variable pcb-4.3.0/src/toporouter.c:5307:8: style: Local variable 'wind' shadows outer function [shadowFunction] pcb-4.3.0/src/toporouter.c:1203:1: note: Shadowed declaration pcb-4.3.0/src/toporouter.c:5307:8: note: Shadow variable pcb-4.3.0/src/toporouter.c:5804:13: style: Local variable 'd' shadows outer variable [shadowVariable] pcb-4.3.0/src/toporouter.c:5797:45: note: Shadowed declaration pcb-4.3.0/src/toporouter.c:5804:13: note: Shadow variable pcb-4.3.0/src/toporouter.c:5872:13: style: Local variable 'd' shadows outer variable [shadowVariable] pcb-4.3.0/src/toporouter.c:5869:45: note: Shadowed declaration pcb-4.3.0/src/toporouter.c:5872:13: note: Shadow variable pcb-4.3.0/src/toporouter.c:7554:28: style: Local variable 'i' shadows outer variable [shadowVariable] pcb-4.3.0/src/toporouter.c:7539:10: note: Shadowed declaration pcb-4.3.0/src/toporouter.c:7554:28: note: Shadow variable pcb-4.3.0/src/toporouter.c:141:58: style: Parameter 'klass' can be declared as pointer to const. However it seems that 'toporouter_vertex_class_init' is a callback function, if 'klass' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/toporouter.c:176:32: note: You might need to cast the function pointer here pcb-4.3.0/src/toporouter.c:141:58: note: Parameter 'klass' can be declared as pointer to const pcb-4.3.0/src/toporouter.c:191:66: style: Parameter 'klass' can be declared as pointer to const. However it seems that 'toporouter_constraint_class_init' is a callback function, if 'klass' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/toporouter.c:216:32: note: You might need to cast the function pointer here pcb-4.3.0/src/toporouter.c:191:66: note: Parameter 'klass' can be declared as pointer to const pcb-4.3.0/src/toporouter.c:312:44: style: Parameter 'dc' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:325:23: style: Parameter 'name' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:342:24: style: Parameter 'name' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:705:16: style: Variable 'pin' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/toporouter.c:794:22: style: Parameter 'a' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:794:35: style: Parameter 'b' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:794:48: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:941:39: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:941:61: style: Parameter 'dc' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:941:87: style: Parameter 'cluster' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:961:39: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:961:54: style: Parameter 's' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:961:63: style: Parameter 'filename' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:961:104: style: Parameter 'datas' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:961:129: style: Parameter 'candidatepoints' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:1203:27: style: Parameter 'p1' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:1203:52: style: Parameter 'p2' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:1203:77: style: Parameter 'p3' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:1213:54: style: Parameter 'tc' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:1223:46: style: Parameter 'tv' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:1238:40: style: Parameter 'a' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:1310:38: style: Parameter 'a' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:1310:62: style: Parameter 'b' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:1362:46: style: Parameter 'a' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:1362:70: style: Parameter 'b' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:1624:29: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:1648:38: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:1726:15: style: Variable 'p' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/toporouter.c:1736:20: style: Parameter 'a' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:1736:33: style: Parameter 'b' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:2146:12: style: Variable 'min_quality' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/toporouter.c:2147:12: style: Variable 'max_area' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/toporouter.c:2534:32: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:2534:57: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:2540:3: style: Variable 'cluster' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/toporouter.c:2565:37: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:2595:71: style: Parameter 'data' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:2810:13: style: Variable 'i' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/toporouter.c:2811:13: style: Variable 'j' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/toporouter.c:2945:54: style: Parameter 'v1' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:2945:79: style: Parameter 'v2' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:3282:51: style: Parameter 's2' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:3332:57: style: Parameter 'curpoint' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:3553:24: style: Variable 'v' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/toporouter.c:3569:24: style: Variable 'v' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/toporouter.c:3815:48: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:3815:71: style: Parameter 'routedata' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:3951:28: style: Variable 'temp' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/toporouter.c:4091:28: style: Variable 'temp' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/toporouter.c:4293:32: style: Variable 'tempj' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/toporouter.c:4344:26: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:4620:27: style: Parameter 'pair' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:4632:26: style: Variable 'pv' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/toporouter.c:4633:26: style: Variable 'nv' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/toporouter.c:4660:70: style: Parameter 'v' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:4712:27: style: Variable 'curroute' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/toporouter.c:4953:26: style: Variable 'pv' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/toporouter.c:5052:87: style: Parameter 'arcv' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:5906:52: style: Parameter 'arc' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:5943:54: style: Parameter 'a' can be declared as pointer to const. However it seems that 'compare_rubberband_arcs' is a callback function, if 'a' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/toporouter.c:6156:43: note: You might need to cast the function pointer here pcb-4.3.0/src/toporouter.c:5943:54: note: Parameter 'a' can be declared as pointer to const pcb-4.3.0/src/toporouter.c:5943:86: style: Parameter 'b' can be declared as pointer to const. However it seems that 'compare_rubberband_arcs' is a callback function, if 'b' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/toporouter.c:6156:43: note: You might need to cast the function pointer here pcb-4.3.0/src/toporouter.c:5943:86: note: Parameter 'b' can be declared as pointer to const pcb-4.3.0/src/toporouter.c:6774:46: style: Parameter 'routedata' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:6824:23: style: Variable 'ra' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/toporouter.c:6825:23: style: Variable 'rb' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/toporouter.c:6830:27: style: Parameter 'm' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:6857:10: style: Variable 'path' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/toporouter.c:7051:33: style: Parameter 'name' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:7277:27: style: Variable 'netlist' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/toporouter.c:7288:37: style: Parameter 'netlist' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:7293:3: style: Variable 'cluster' can be declared as pointer to const [constVariablePointer] pcb-4.3.0/src/toporouter.c:7715:36: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:7715:45: style: Parameter 'name' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/src/toporouter.c:5666:49: warning: Uninitialized variables: arc.object, arc.x0, arc.y0, arc.x1, arc.y1, arc.centre, arc.v, arc.r, arc.dir, arc.clearance, arc.oproute, arc.v1, arc.v2 [uninitvar] pcb-4.3.0/src/toporouter.c:5653:9: note: Assuming condition is false pcb-4.3.0/src/toporouter.c:5666:49: note: Uninitialized variables: arc.object, arc.x0, arc.y0, arc.x1, arc.y1, arc.centre, arc.v, arc.r, arc.dir, arc.clearance, arc.oproute, arc.v1, arc.v2 pcb-4.3.0/src/toporouter.c:5717:25: warning: Uninitialized variable: arc [uninitvar] pcb-4.3.0/src/toporouter.c:5702:9: note: Assuming condition is false pcb-4.3.0/src/toporouter.c:5717:25: note: Uninitialized variable: arc pcb-4.3.0/src/toporouter.c:5832:9: style: Variable 'x' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/toporouter.c:5832:18: style: Variable 'y' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/src/toporouter.c:7448:40: style: Variable 'nscore' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/gts/predicates.c:709:56: style: Parameter 'e' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/predicates.c:710:28: style: Parameter 'f' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/predicates.c:795:53: style: Parameter 'e' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/predicates.c:843:38: style: Parameter 'e' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/predicates.c:881:33: style: Parameter 'pa' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/predicates.c:881:43: style: Parameter 'pb' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/predicates.c:881:53: style: Parameter 'pc' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/predicates.c:1035:33: style: Parameter 'pa' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/predicates.c:1035:43: style: Parameter 'pb' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/predicates.c:1035:53: style: Parameter 'pc' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/predicates.c:1035:63: style: Parameter 'pd' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/predicates.c:1513:33: style: Parameter 'pa' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/predicates.c:1513:43: style: Parameter 'pb' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/predicates.c:1513:53: style: Parameter 'pc' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/predicates.c:1513:63: style: Parameter 'pd' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/predicates.c:2164:33: style: Parameter 'pa' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/predicates.c:2164:43: style: Parameter 'pb' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/predicates.c:2164:53: style: Parameter 'pc' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/predicates.c:2164:63: style: Parameter 'pd' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/predicates.c:2164:73: style: Parameter 'pe' can be declared as pointer to const [constParameterPointer] pcb-4.3.0/gts/predicates.c:1430:51: style: Variable 'finother' is assigned a value that is never used. [unreadVariable] pcb-4.3.0/gts/predicates.c:2078:53: style: Variable 'finother' is assigned a value that is never used. [unreadVariable] diff: head pcb-4.3.0/gts/triangle.c:551:32: warning: Possible null pointer dereference: (struct GtsSegment*)(ee2) [nullPointer] pcb-4.3.0/gts/triangle.c:549:17: note: Assignment 'ee2=NULL', assigned value is 0 pcb-4.3.0/gts/triangle.c:551:32: note: Null pointer dereference 2.13.0 pcb-4.3.0/gts/triangle.c:551:32: warning: Possible null pointer dereference: (struct _GtsSegment*)(ee2) [nullPointer] pcb-4.3.0/gts/triangle.c:549:17: note: Assignment 'ee2=NULL', assigned value is 0 pcb-4.3.0/gts/triangle.c:551:32: note: Null pointer dereference head pcb-4.3.0/gts/triangle.c:551:7: warning: Possible null pointer dereference: (struct GtsSegment*)(ee1) [nullPointer] pcb-4.3.0/gts/triangle.c:549:0: note: Assignment 'ee1=NULL', assigned value is 0 pcb-4.3.0/gts/triangle.c:551:7: note: Null pointer dereference 2.13.0 pcb-4.3.0/gts/triangle.c:551:7: warning: Possible null pointer dereference: (struct _GtsSegment*)(ee1) [nullPointer] pcb-4.3.0/gts/triangle.c:549:0: note: Assignment 'ee1=NULL', assigned value is 0 pcb-4.3.0/gts/triangle.c:551:7: note: Null pointer dereference head pcb-4.3.0/gts/vertex.c:442:21: style: Parameter 'f' can be declared as pointer to const [constParameterPointer] 2.13.0 pcb-4.3.0/src/action.c:7720:27: error: Uninitialized variable: maxhdr [uninitvar] 2.13.0 pcb-4.3.0/src/autoplace.c:450:5: style: Variable 'pin' can be declared as pointer to const [constVariablePointer] 2.13.0 pcb-4.3.0/src/autoplace.c:480:7: style: Variable 'pin' can be declared as pointer to const [constVariablePointer] head pcb-4.3.0/src/autoroute.c:3480:9: style: Condition '1||!AutoRouteParameters.is_smoothing' is always true [knownConditionTrueFalse] head pcb-4.3.0/src/autoroute.c:4653:35: style: Parameter 'cl' can be declared as pointer to const. However it seems that 'bad_boy' is a callback function, if 'cl' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/autoroute.c:4672:56: note: You might need to cast the function pointer here pcb-4.3.0/src/autoroute.c:4653:35: note: Parameter 'cl' can be declared as pointer to const head pcb-4.3.0/src/autoroute.c:4722:45: style: Parameter 'ras' can be declared as pointer to const [constParameterPointer] head pcb-4.3.0/src/autoroute.c:509:37: style: Parameter 'cl' can be declared as pointer to const [constParameterPointer] 2.13.0 pcb-4.3.0/src/autoroute.c:5267:7: style: Variable 'line' can be declared as pointer to const [constVariablePointer] head pcb-4.3.0/src/buffer.c:1004:2: portability: %d in format string (no. 1) requires 'int' but the argument type is 'Cardinal {aka unsigned int}'. [invalidPrintfArgType_sint] 2.13.0 pcb-4.3.0/src/buffer.c:1004:2: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] head pcb-4.3.0/src/buffer.c:1048:4: portability: %d in format string (no. 1) requires 'int' but the argument type is 'Cardinal {aka unsigned int}'. [invalidPrintfArgType_sint] 2.13.0 pcb-4.3.0/src/buffer.c:1048:4: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] head pcb-4.3.0/src/buffer.c:1078:4: portability: %d in format string (no. 1) requires 'int' but the argument type is 'Cardinal {aka unsigned int}'. [invalidPrintfArgType_sint] 2.13.0 pcb-4.3.0/src/buffer.c:1078:4: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] head pcb-4.3.0/src/buffer.c:1449:13: style: Redundant assignment of 'Buffer->X' to itself. [selfAssignment] 2.13.0 pcb-4.3.0/src/buffer.c:1449:13: warning: Redundant assignment of 'Buffer->X' to itself. [selfAssignment] head pcb-4.3.0/src/buffer.c:1453:12: style: Redundant assignment of 'via->X' to itself. [selfAssignment] 2.13.0 pcb-4.3.0/src/buffer.c:1453:12: warning: Redundant assignment of 'via->X' to itself. [selfAssignment] head pcb-4.3.0/src/buffer.c:1459:20: style: Redundant assignment of 'line->Point1.X' to itself. [selfAssignment] 2.13.0 pcb-4.3.0/src/buffer.c:1459:20: warning: Redundant assignment of 'line->Point1.X' to itself. [selfAssignment] head pcb-4.3.0/src/buffer.c:1461:20: style: Redundant assignment of 'line->Point2.X' to itself. [selfAssignment] 2.13.0 pcb-4.3.0/src/buffer.c:1461:20: warning: Redundant assignment of 'line->Point2.X' to itself. [selfAssignment] head pcb-4.3.0/src/buffer.c:1468:12: style: Redundant assignment of 'arc->X' to itself. [selfAssignment] 2.13.0 pcb-4.3.0/src/buffer.c:1468:12: warning: Redundant assignment of 'arc->X' to itself. [selfAssignment] head pcb-4.3.0/src/buffer.c:1481:16: style: Redundant assignment of 'point->X' to itself. [selfAssignment] 2.13.0 pcb-4.3.0/src/buffer.c:1481:16: warning: Redundant assignment of 'point->X' to itself. [selfAssignment] head pcb-4.3.0/src/buffer.c:1511:13: style: Redundant assignment of 'Buffer->X' to itself. [selfAssignment] 2.13.0 pcb-4.3.0/src/buffer.c:1511:13: warning: Redundant assignment of 'Buffer->X' to itself. [selfAssignment] head pcb-4.3.0/src/buffer.c:1516:12: style: Redundant assignment of 'via->X' to itself. [selfAssignment] 2.13.0 pcb-4.3.0/src/buffer.c:1516:12: warning: Redundant assignment of 'via->X' to itself. [selfAssignment] head pcb-4.3.0/src/buffer.c:1525:20: style: Redundant assignment of 'line->Point1.X' to itself. [selfAssignment] 2.13.0 pcb-4.3.0/src/buffer.c:1525:20: warning: Redundant assignment of 'line->Point1.X' to itself. [selfAssignment] head pcb-4.3.0/src/buffer.c:1527:20: style: Redundant assignment of 'line->Point2.X' to itself. [selfAssignment] 2.13.0 pcb-4.3.0/src/buffer.c:1527:20: warning: Redundant assignment of 'line->Point2.X' to itself. [selfAssignment] head pcb-4.3.0/src/buffer.c:1536:12: style: Redundant assignment of 'arc->X' to itself. [selfAssignment] 2.13.0 pcb-4.3.0/src/buffer.c:1536:12: warning: Redundant assignment of 'arc->X' to itself. [selfAssignment] head pcb-4.3.0/src/buffer.c:1549:16: style: Redundant assignment of 'point->X' to itself. [selfAssignment] 2.13.0 pcb-4.3.0/src/buffer.c:1549:16: warning: Redundant assignment of 'point->X' to itself. [selfAssignment] head pcb-4.3.0/src/buffer.c:1561:13: style: Redundant assignment of 'text->X' to itself. [selfAssignment] 2.13.0 pcb-4.3.0/src/buffer.c:1561:13: warning: Redundant assignment of 'text->X' to itself. [selfAssignment] 2.13.0 pcb-4.3.0/src/create.c:591:3: style: Variable 'arc' can be declared as pointer to const [constVariablePointer] 2.13.0 pcb-4.3.0/src/crosshair.c:300:3: style: Variable 'pad' can be declared as pointer to const [constVariablePointer] head pcb-4.3.0/src/dbus-pcbmain.c:251:43: style: Parameter 'conn' can be declared as pointer to const. However it seems that 'dispatch_status_changed' is a callback function, if 'conn' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/dbus-pcbmain.c:306:7: note: You might need to cast the function pointer here pcb-4.3.0/src/dbus-pcbmain.c:251:43: note: Parameter 'conn' can be declared as pointer to const head pcb-4.3.0/src/dbus-pcbmain.c:252:11: style: Parameter 'data' can be declared as pointer to const. However it seems that 'dispatch_status_changed' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/dbus-pcbmain.c:306:7: note: You might need to cast the function pointer here pcb-4.3.0/src/dbus-pcbmain.c:252:11: note: Parameter 'data' can be declared as pointer to const head pcb-4.3.0/src/dbus.c:227:43: style: Parameter 'connection' can be declared as pointer to const. However it seems that 'unregister_dbus_handler' is a callback function, if 'connection' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/dbus.c:334:5: note: You might need to cast the function pointer here pcb-4.3.0/src/dbus.c:227:43: note: Parameter 'connection' can be declared as pointer to const head pcb-4.3.0/src/dbus.c:227:61: style: Parameter 'data' can be declared as pointer to const. However it seems that 'unregister_dbus_handler' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/dbus.c:334:5: note: You might need to cast the function pointer here pcb-4.3.0/src/dbus.c:227:61: note: Parameter 'data' can be declared as pointer to const head pcb-4.3.0/src/djopt.c:152:28: style: Parameter 'data' can be declared as pointer to const. However it seems that 'djopt_get_auto_only' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/djopt.c:158:19: note: You might need to cast the function pointer here pcb-4.3.0/src/djopt.c:152:28: note: Parameter 'data' can be declared as pointer to const 2.13.0 pcb-4.3.0/src/djopt.c:168:5: style: Variable 'pin' can be declared as pointer to const [constVariablePointer] 2.13.0 pcb-4.3.0/src/djopt.c:174:5: style: Variable 'pad' can be declared as pointer to const [constVariablePointer] 2.13.0 pcb-4.3.0/src/find.c:396:3: style: Variable 'pad' can be declared as pointer to const [constVariablePointer] head pcb-4.3.0/src/flags.c:101:20: style: Parameter 'data' can be declared as pointer to const. However it seems that 'FlagUnitsMm' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/flags.c:502:28: note: You might need to cast the function pointer here pcb-4.3.0/src/flags.c:101:20: note: Parameter 'data' can be declared as pointer to const head pcb-4.3.0/src/flags.c:110:21: style: Parameter 'data' can be declared as pointer to const. However it seems that 'FlagUnitsMil' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/flags.c:503:28: note: You might need to cast the function pointer here pcb-4.3.0/src/flags.c:110:21: note: Parameter 'data' can be declared as pointer to const head pcb-4.3.0/src/flags.c:119:19: style: Parameter 'data' can be declared as pointer to const. However it seems that 'FlagBuffer' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/flags.c:521:28: note: You might need to cast the function pointer here pcb-4.3.0/src/flags.c:119:19: note: Parameter 'data' can be declared as pointer to const head pcb-4.3.0/src/flags.c:125:25: style: Parameter 'data' can be declared as pointer to const. However it seems that 'FlagElementName' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/flags.c:445:28: note: You might need to cast the function pointer here pcb-4.3.0/src/flags.c:125:25: note: Parameter 'data' can be declared as pointer to const head pcb-4.3.0/src/flags.c:158:22: style: Parameter 'data' can be declared as pointer to const. However it seems that 'FlagHaveRegex' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/flags.c:446:28: note: You might need to cast the function pointer here pcb-4.3.0/src/flags.c:158:22: note: Parameter 'data' can be declared as pointer to const head pcb-4.3.0/src/flags.c:74:25: style: Parameter 'data' can be declared as pointer to const. However it seems that 'FlagCurrentStyle' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/flags.c:442:28: note: You might need to cast the function pointer here pcb-4.3.0/src/flags.c:74:25: note: Parameter 'data' can be declared as pointer to const head pcb-4.3.0/src/flags.c:89:17: style: Parameter 'data' can be declared as pointer to const. However it seems that 'FlagGrid' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/flags.c:443:28: note: You might need to cast the function pointer here pcb-4.3.0/src/flags.c:89:17: note: Parameter 'data' can be declared as pointer to const head pcb-4.3.0/src/flags.c:95:21: style: Parameter 'data' can be declared as pointer to const. However it seems that 'FlagGridSize' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/flags.c:444:28: note: You might need to cast the function pointer here pcb-4.3.0/src/flags.c:95:21: note: Parameter 'data' can be declared as pointer to const 2.13.0 pcb-4.3.0/src/hid/bom/bom.c:600:17: style: Condition 'pin_cnt>0' is always true [knownConditionTrueFalse] pcb-4.3.0/src/hid/bom/bom.c:532:15: note: Assignment 'pin_cnt=0', assigned value is 0 pcb-4.3.0/src/hid/bom/bom.c:558:7: note: pin_cnt is incremented', new value is 1 pcb-4.3.0/src/hid/bom/bom.c:577:7: note: pin_cnt is incremented', new value is 2 pcb-4.3.0/src/hid/bom/bom.c:600:17: note: Condition 'pin_cnt>0' is always true head pcb-4.3.0/src/hid/common/hidnogui.c:389:31: style: Parameter 'default_ext' can be declared as pointer to const. However it seems that 'nogui_fileselect' is a callback function, if 'default_ext' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/common/hidnogui.c:477:31: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/common/hidnogui.c:389:31: note: Parameter 'default_ext' can be declared as pointer to const head pcb-4.3.0/src/hid/gcode/decompose.c:157:32: style: Parameter 'bm' can be declared as pointer to const [constParameterPointer] head pcb-4.3.0/src/hid/gcode/decompose.c:37:36: style: Parameter 'bm' can be declared as pointer to const [constParameterPointer] head pcb-4.3.0/src/hid/gtk/ghid-main-menu.c:434:36: style: Parameter 'mm' can be declared as pointer to const. However it seems that 'ghid_main_menu_init' is a callback function, if 'mm' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/ghid-main-menu.c:462:31: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/ghid-main-menu.c:434:36: note: Parameter 'mm' can be declared as pointer to const head pcb-4.3.0/src/hid/gtk/ghid-main-menu.c:440:47: style: Parameter 'klass' can be declared as pointer to const. However it seems that 'ghid_main_menu_class_init' is a callback function, if 'klass' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/ghid-main-menu.c:457:28: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/ghid-main-menu.c:440:47: note: Parameter 'klass' can be declared as pointer to const head pcb-4.3.0/src/hid/gtk/ghid-route-style-selector.c:349:57: style: Parameter 'rss' can be declared as pointer to const. However it seems that 'ghid_route_style_selector_init' is a callback function, if 'rss' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/ghid-route-style-selector.c:413:22: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/ghid-route-style-selector.c:349:57: note: Parameter 'rss' can be declared as pointer to const head pcb-4.3.0/src/hid/gtk/gtkhid-gdk.c:1112:38: style: Parameter 'widget' can be declared as pointer to const [constParameterPointer] head pcb-4.3.0/src/hid/gtk/gtkhid-gdk.c:1112:56: style: Parameter 'port' can be declared as pointer to const [constParameterPointer] head pcb-4.3.0/src/hid/gtk/gtkhid-gdk.c:1171:42: style: Parameter 'widget' can be declared as pointer to const [constParameterPointer] head pcb-4.3.0/src/hid/gtk/gui-command-window.c:290:45: style: Parameter 'widget' can be declared as pointer to const. However it seems that 'command_window_delete_event_cb' is a callback function, if 'widget' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/gui-command-window.c:377:33: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/gui-command-window.c:290:45: note: Parameter 'widget' can be declared as pointer to const head pcb-4.3.0/src/hid/gtk/gui-command-window.c:290:64: style: Parameter 'event' can be declared as pointer to const. However it seems that 'command_window_delete_event_cb' is a callback function, if 'event' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/gui-command-window.c:377:33: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/gui-command-window.c:290:64: note: Parameter 'event' can be declared as pointer to const head pcb-4.3.0/src/hid/gtk/gui-command-window.c:299:33: style: Parameter 'widget' can be declared as pointer to const. However it seems that 'command_destroy_cb' is a callback function, if 'widget' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/gui-command-window.c:375:33: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/gui-command-window.c:299:33: note: Parameter 'widget' can be declared as pointer to const head pcb-4.3.0/src/hid/gtk/gui-drc-window.c:86:29: style: Parameter 'widget' can be declared as pointer to const. However it seems that 'drc_destroy_cb' is a callback function, if 'widget' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/gui-drc-window.c:746:19: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/gui-drc-window.c:86:29: note: Parameter 'widget' can be declared as pointer to const head pcb-4.3.0/src/hid/gtk/gui-keyref-window.c:331:32: style: Parameter 'widget' can be declared as pointer to const. However it seems that 'keyref_destroy_cb' is a callback function, if 'widget' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/gui-keyref-window.c:350:19: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/gui-keyref-window.c:331:32: note: Parameter 'widget' can be declared as pointer to const head pcb-4.3.0/src/hid/gtk/gui-log-window.c:67:29: style: Parameter 'widget' can be declared as pointer to const. However it seems that 'log_destroy_cb' is a callback function, if 'widget' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/gui-log-window.c:82:19: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/gui-log-window.c:67:29: note: Parameter 'widget' can be declared as pointer to const head pcb-4.3.0/src/hid/gtk/gui-misc.c:371:33: style: Parameter 'msg' can be declared as pointer to const [constParameterPointer] head pcb-4.3.0/src/hid/gtk/gui-netlist-window.c:689:33: style: Parameter 'widget' can be declared as pointer to const. However it seems that 'netlist_destroy_cb' is a callback function, if 'widget' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/gui-netlist-window.c:709:19: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/gui-netlist-window.c:689:33: note: Parameter 'widget' can be declared as pointer to const head pcb-4.3.0/src/hid/gtk/gui-netlist-window.c:689:52: style: Parameter 'out' can be declared as pointer to const. However it seems that 'netlist_destroy_cb' is a callback function, if 'out' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/gtk/gui-netlist-window.c:709:19: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/gtk/gui-netlist-window.c:689:52: note: Parameter 'out' can be declared as pointer to const head pcb-4.3.0/src/hid/lesstif/dialogs.c:1897:45: style: Parameter 'v' can be declared as pointer to const. However it seems that 'attributes_revert_callback' is a callback function, if 'v' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/lesstif/dialogs.c:1944:25: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/lesstif/dialogs.c:1897:45: note: Parameter 'v' can be declared as pointer to const head pcb-4.3.0/src/hid/lesstif/dialogs.c:1897:54: style: Parameter 'cbs' can be declared as pointer to const. However it seems that 'attributes_revert_callback' is a callback function, if 'cbs' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/lesstif/dialogs.c:1944:25: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/lesstif/dialogs.c:1897:54: note: Parameter 'cbs' can be declared as pointer to const head pcb-4.3.0/src/hid/lesstif/dialogs.c:41:43: style: Parameter 'cbs' can be declared as pointer to const. However it seems that 'dialog_callback' is a callback function, if 'cbs' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/lesstif/dialogs.c:1951:25: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/lesstif/dialogs.c:41:43: note: Parameter 'cbs' can be declared as pointer to const head pcb-4.3.0/src/hid/lesstif/library.c:60:33: style: Parameter 'v' can be declared as pointer to const. However it seems that 'library_browse' is a callback function, if 'v' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/lesstif/library.c:105:21: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/lesstif/library.c:60:33: note: Parameter 'v' can be declared as pointer to const head pcb-4.3.0/src/hid/lesstif/netlist.c:163:29: style: Parameter 'net' can be declared as pointer to const. However it seems that 'nbcb_find' is a callback function, if 'net' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/lesstif/netlist.c:339:50: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/lesstif/netlist.c:163:29: note: Parameter 'net' can be declared as pointer to const head pcb-4.3.0/src/hid/lesstif/netlist.c:94:33: style: Parameter 'v' can be declared as pointer to const. However it seems that 'netlist_extend' is a callback function, if 'v' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/hid/lesstif/netlist.c:368:78: note: You might need to cast the function pointer here pcb-4.3.0/src/hid/lesstif/netlist.c:94:33: note: Parameter 'v' can be declared as pointer to const head pcb-4.3.0/src/layerflags.c:120:64: style: Parameter 'data' can be declared as pointer to const [constParameterPointer] head pcb-4.3.0/src/layerflags.c:77:28: style: Parameter 'error' can be declared as pointer to const [constParameterPointer] head pcb-4.3.0/src/mirror.c:112:12: style: Redundant assignment of 'arc->X' to itself. [selfAssignment] 2.13.0 pcb-4.3.0/src/mirror.c:112:12: warning: Redundant assignment of 'arc->X' to itself. [selfAssignment] head pcb-4.3.0/src/mirror.c:120:13: style: Redundant assignment of 'text->X' to itself. [selfAssignment] 2.13.0 pcb-4.3.0/src/mirror.c:120:13: warning: Redundant assignment of 'text->X' to itself. [selfAssignment] head pcb-4.3.0/src/mirror.c:125:18: style: Redundant assignment of 'Element->MarkX' to itself. [selfAssignment] 2.13.0 pcb-4.3.0/src/mirror.c:125:18: warning: Redundant assignment of 'Element->MarkX' to itself. [selfAssignment] head pcb-4.3.0/src/mirror.c:71:20: style: Redundant assignment of 'line->Point1.X' to itself. [selfAssignment] 2.13.0 pcb-4.3.0/src/mirror.c:71:20: warning: Redundant assignment of 'line->Point1.X' to itself. [selfAssignment] head pcb-4.3.0/src/mirror.c:73:20: style: Redundant assignment of 'line->Point2.X' to itself. [selfAssignment] 2.13.0 pcb-4.3.0/src/mirror.c:73:20: warning: Redundant assignment of 'line->Point2.X' to itself. [selfAssignment] head pcb-4.3.0/src/mirror.c:80:12: style: Redundant assignment of 'pin->X' to itself. [selfAssignment] 2.13.0 pcb-4.3.0/src/mirror.c:80:12: warning: Redundant assignment of 'pin->X' to itself. [selfAssignment] head pcb-4.3.0/src/mtspace.c:610:26: style: Parameter 'w' can be declared as pointer to const [constParameterPointer] head pcb-4.3.0/src/polygon.c:2001:3: portability: %d in format string (no. 2) requires 'int' but the argument type is 'Cardinal {aka unsigned int}'. [invalidPrintfArgType_sint] 2.13.0 pcb-4.3.0/src/polygon.c:2001:3: warning: %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] head pcb-4.3.0/src/polygon.c:2006:7: portability: %d in format string (no. 1) requires 'int' but the argument type is 'Cardinal {aka unsigned int}'. [invalidPrintfArgType_sint] 2.13.0 pcb-4.3.0/src/polygon.c:2006:7: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] head pcb-4.3.0/src/polygon.c:2008:9: portability: %d in format string (no. 1) requires 'int' but the argument type is 'Cardinal {aka unsigned int}'. [invalidPrintfArgType_sint] head pcb-4.3.0/src/polygon.c:2008:9: portability: %d in format string (no. 2) requires 'int' but the argument type is 'Cardinal {aka unsigned int}'. [invalidPrintfArgType_sint] 2.13.0 pcb-4.3.0/src/polygon.c:2008:9: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] 2.13.0 pcb-4.3.0/src/polygon.c:2008:9: warning: %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] 2.13.0 pcb-4.3.0/src/polygon.c:535:12: style: Condition 'thick>0' is always true [knownConditionTrueFalse] pcb-4.3.0/src/polygon.c:522:13: note: Assuming condition 'thick<=0' is false pcb-4.3.0/src/polygon.c:535:12: note: Condition 'thick>0' is always true head pcb-4.3.0/src/puller.c:330:41: style: Parameter 'cl' can be declared as pointer to const. However it seems that 'line_callback' is a callback function, if 'cl' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/puller.c:417:46: note: You might need to cast the function pointer here pcb-4.3.0/src/puller.c:330:41: note: Parameter 'cl' can be declared as pointer to const head pcb-4.3.0/src/report.c:102:3: portability: %d in format string (no. 1) requires 'int' but the argument type is 'Cardinal {aka unsigned int}'. [invalidPrintfArgType_sint] 2.13.0 pcb-4.3.0/src/report.c:102:3: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] 2.13.0 pcb-4.3.0/src/report.c:232:2: style: Variable 'pin' can be declared as pointer to const [constVariablePointer] 2.13.0 pcb-4.3.0/src/report.c:398:2: style: Variable 'pad' can be declared as pointer to const [constVariablePointer] 2.13.0 pcb-4.3.0/src/report.c:552:5: style: Variable 'pin' can be declared as pointer to const [constVariablePointer] 2.13.0 pcb-4.3.0/src/report.c:564:5: style: Variable 'pad' can be declared as pointer to const [constVariablePointer] 2.13.0 pcb-4.3.0/src/report.c:614:3: style: Variable 'arc' can be declared as pointer to const [constVariablePointer] 2.13.0 pcb-4.3.0/src/report.c:668:6: style: Variable 'pin' can be declared as pointer to const [constVariablePointer] head pcb-4.3.0/src/rtree.c:125:31: style: Condition 'node->u.rects[i].bptr' is always true [knownConditionTrueFalse] 2.13.0 pcb-4.3.0/src/rtree.c:125:31: style: Condition 'node->u.rects[i].bptr' is always true [knownConditionTrueFalse] pcb-4.3.0/src/rtree.c:119:15: note: Assuming condition '!node->u.rects[i].bptr' is false pcb-4.3.0/src/rtree.c:125:31: note: Condition 'node->u.rects[i].bptr' is always true head pcb-4.3.0/src/rtree.c:164:27: style: Condition 'node->u.kids[i]' is always true [knownConditionTrueFalse] 2.13.0 pcb-4.3.0/src/rtree.c:164:27: style: Condition 'node->u.kids[i]' is always true [knownConditionTrueFalse] pcb-4.3.0/src/rtree.c:153:15: note: Assuming condition '!node->u.kids[i]' is false pcb-4.3.0/src/rtree.c:164:27: note: Condition 'node->u.kids[i]' is always true head pcb-4.3.0/src/set.c:331:2: portability: %d in format string (no. 1) requires 'int' but the argument type is 'Cardinal {aka unsigned int}'. [invalidPrintfArgType_sint] 2.13.0 pcb-4.3.0/src/set.c:331:2: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] 2.13.0 pcb-4.3.0/src/smartdisperse.c:203:3: style: Variable 'element' can be declared as pointer to const [constVariablePointer] head pcb-4.3.0/src/toporouter.c:141:58: style: Parameter 'klass' can be declared as pointer to const. However it seems that 'toporouter_vertex_class_init' is a callback function, if 'klass' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/toporouter.c:176:32: note: You might need to cast the function pointer here pcb-4.3.0/src/toporouter.c:141:58: note: Parameter 'klass' can be declared as pointer to const head pcb-4.3.0/src/toporouter.c:191:66: style: Parameter 'klass' can be declared as pointer to const. However it seems that 'toporouter_constraint_class_init' is a callback function, if 'klass' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/toporouter.c:216:32: note: You might need to cast the function pointer here pcb-4.3.0/src/toporouter.c:191:66: note: Parameter 'klass' can be declared as pointer to const head pcb-4.3.0/src/toporouter.c:312:44: style: Parameter 'dc' can be declared as pointer to const [constParameterPointer] head pcb-4.3.0/src/toporouter.c:3332:57: style: Parameter 'curpoint' can be declared as pointer to const [constParameterPointer] head pcb-4.3.0/src/toporouter.c:941:39: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] head pcb-4.3.0/src/toporouter.c:941:61: style: Parameter 'dc' can be declared as pointer to const [constParameterPointer] head pcb-4.3.0/src/toporouter.c:941:87: style: Parameter 'cluster' can be declared as pointer to const [constParameterPointer] head pcb-4.3.0/src/toporouter.c:961:104: style: Parameter 'datas' can be declared as pointer to const [constParameterPointer] head pcb-4.3.0/src/toporouter.c:961:129: style: Parameter 'candidatepoints' can be declared as pointer to const [constParameterPointer] head pcb-4.3.0/src/toporouter.c:961:39: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] head pcb-4.3.0/src/toporouter.c:961:54: style: Parameter 's' can be declared as pointer to const [constParameterPointer] head pcb-4.3.0/src/toporouter.c:961:63: style: Parameter 'filename' can be declared as pointer to const [constParameterPointer] head pcb-4.3.0/src/undo.c:1561:49: style: Parameter 'Ptr1' can be declared as pointer to const [constParameterPointer] head pcb-4.3.0/src/undo.c:1561:61: style: Parameter 'Ptr2' can be declared as pointer to const [constParameterPointer] head pcb-4.3.0/src/vendor.c:981:38: style: Parameter 'data' can be declared as pointer to const. However it seems that 'vendor_get_enabled' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] pcb-4.3.0/src/vendor.c:987:19: note: You might need to cast the function pointer here pcb-4.3.0/src/vendor.c:981:38: note: Parameter 'data' can be declared as pointer to const head plural.y:380:29: style: Parameter 'arg' can be declared as pointer to const [constParameterPointer] DONE