2022-06-24 07:44 ftp://ftp.de.debian.org/debian/pool/main/o/osmo-hlr/osmo-hlr_1.4.0+dfsg1.orig.tar.xz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j1 platform: Linux-4.19.0-18-amd64-x86_64-with-debian-10.12 python: 3.7.3 client-version: 1.3.24 compiler: g++ (Debian 8.3.0-6) 8.3.0 cppcheck: head 2.8 head-info: 60c1eef (2022-06-23 20:26:47 +0200) count: 41 39 elapsed-time: 109.6 151.2 head-timing-info: Tokenizer::simplifyTokens1: 108.467s (avg. 2.21362s - 49 result(s)) Tokenizer::simplifyTokens1::ValueFlow: 106.675s (avg. 2.37055s - 45 result(s)) Tokenizer::simplifyTokens1::createSymbolDatabase: 1.14965s (avg. 0.0255477s - 45 result(s)) Tokenizer::createTokens: 0.219727s (avg. 0.00448422s - 49 result(s)) Tokenizer::simplifyTokens1::setValueType: 0.189699s (avg. 0.00421553s - 45 result(s)) Overall time: 217.564s old-timing-info: Tokenizer::simplifyTokens1: 150.041s (avg. 3.06205s - 49 result(s)) Tokenizer::simplifyTokens1::ValueFlow: 147.906s (avg. 3.28679s - 45 result(s)) Tokenizer::simplifyTokens1::createSymbolDatabase: 1.44181s (avg. 0.0320402s - 45 result(s)) Tokenizer::createTokens: 0.214403s (avg. 0.00437557s - 49 result(s)) Tokenizer::simplifyTokens1::setValueType: 0.183371s (avg. 0.00407491s - 45 result(s)) Overall time: 300.705s head results: osmo-hlr-1.4.0/src/db_auc.c:240:4: style: Assignment of function parameter has no effect outside the function. [uselessAssignmentArg] osmo-hlr-1.4.0/src/db_auc.c:240:12: style: Variable 'num_vec' is assigned a value that is never used. [unreadVariable] osmo-hlr-1.4.0/src/dgsm_vty.c:487:78: error: There is an unknown macro here somewhere. Configuration is required. If OSMO_STRINGIFY_VAL is a macro then please configure it. [unknownMacro] osmo-hlr-1.4.0/src/gsup_server.c:497:62: style: Parameter 'modified_gsup' can be declared as pointer to const [constParameter] osmo-hlr-1.4.0/src/gsupclient/gsup_test_client.c:61:38: error: Uninitialized variable: io->type [uninitvar] osmo-hlr-1.4.0/src/hlr_db_tool.c:493:7: style: Condition 'main_action' is always false [knownConditionTrueFalse] osmo-hlr-1.4.0/src/hlr_db_tool.c:478:16: note: Assignment 'main_action=NULL', assigned value is 0 osmo-hlr-1.4.0/src/hlr_db_tool.c:485:9: note: Assuming condition is false osmo-hlr-1.4.0/src/hlr_db_tool.c:493:7: note: Condition 'main_action' is always false osmo-hlr-1.4.0/src/hlr_db_tool.c:46:7: style: struct member 'Anonymous0::bootstrap' is never used. [unusedStructMember] osmo-hlr-1.4.0/src/hlr_ussd.c:611:17: style: Condition 'rt' is always true [knownConditionTrueFalse] osmo-hlr-1.4.0/src/hlr_vty.c:131:2: error: There is an unknown macro here somewhere. Configuration is required. If llist_for_each_entry is a macro then please configure it. [unknownMacro] osmo-hlr-1.4.0/src/hlr_vty_subscr.c:67:3: style: Modulo of one is always equal to zero [moduloofone] osmo-hlr-1.4.0/src/lu_fsm.c:294:4: warning: Operator '|' with one operand equal to zero is redundant. [badBitmaskCheck] osmo-hlr-1.4.0/src/lu_fsm.c:300:4: warning: Operator '|' with one operand equal to zero is redundant. [badBitmaskCheck] osmo-hlr-1.4.0/src/lu_fsm.c:210:18: error: Uninitialized variable: lu->subscr [uninitvar] osmo-hlr-1.4.0/src/lu_fsm.c:206:29: note: Assuming condition is false osmo-hlr-1.4.0/src/lu_fsm.c:210:18: note: Uninitialized variable: lu->subscr osmo-hlr-1.4.0/src/mslookup/mslookup_client.c:50:10: error: Uninitialized variable: r->request_handle [uninitvar] osmo-hlr-1.4.0/src/mslookup/mslookup_client.c:47:6: note: Assuming condition is false osmo-hlr-1.4.0/src/mslookup/mslookup_client.c:50:10: note: Uninitialized variable: r->request_handle osmo-hlr-1.4.0/src/mslookup/mslookup_client_fake.c:85:46: style:inconclusive: Function 'fake_lookup_async_response' argument 1 names different: declaration 'state' definition 'data'. [funcArgNamesDifferent] osmo-hlr-1.4.0/src/mslookup/mslookup_client_fake.c:44:46: note: Function 'fake_lookup_async_response' argument 1 names different: declaration 'state' definition 'data'. osmo-hlr-1.4.0/src/mslookup/mslookup_client_fake.c:85:46: note: Function 'fake_lookup_async_response' argument 1 names different: declaration 'state' definition 'data'. osmo-hlr-1.4.0/src/mslookup/mslookup_client_fake.c:75:10: error: Uninitialized variable: r->request_handle [uninitvar] osmo-hlr-1.4.0/src/mslookup/mslookup_client_mdns.c:58:23: error: Uninitialized variable: request->query [uninitvar] osmo-hlr-1.4.0/src/mslookup/mslookup_client_mdns.c:134:10: error: Uninitialized variable: r->request_handle [uninitvar] osmo-hlr-1.4.0/src/mslookup/osmo-mslookup-client.c:151:19: error: There is an unknown macro here somewhere. Configuration is required. If OSMO_STRINGIFY_VAL is a macro then please configure it. [unknownMacro] osmo-hlr-1.4.0/src/mslookup_server.c:235:33: style: Parameter 'ret_subscr' can be declared as pointer to const [constParameter] osmo-hlr-1.4.0/src/mslookup_server.c:241:49: error: Uninitialized variable: &_subscr [uninitvar] osmo-hlr-1.4.0/src/proxy.c:179:63: warning: Either the condition 'proxy_subscr' is redundant or there is possible null pointer dereference: proxy_subscr. [nullPointerRedundantCheck] osmo-hlr-1.4.0/src/proxy.c:453:3: note: Assuming that condition 'proxy_subscr' is not redundant osmo-hlr-1.4.0/src/proxy.c:452:43: note: Calling function 'proxy_subscr_create_or_update', 2nd argument 'proxy_subscr' value is 0 osmo-hlr-1.4.0/src/proxy.c:179:63: note: Null pointer dereference osmo-hlr-1.4.0/src/proxy.c:261:42: warning: Either the condition 'proxy_subscr' is redundant or there is possible null pointer dereference: proxy_subscr. [nullPointerRedundantCheck] osmo-hlr-1.4.0/src/proxy.c:267:3: note: Assuming that condition 'proxy_subscr' is not redundant osmo-hlr-1.4.0/src/proxy.c:261:42: note: Null pointer dereference osmo-hlr-1.4.0/src/proxy.c:324:42: warning: Either the condition 'proxy_subscr' is redundant or there is possible null pointer dereference: proxy_subscr. [nullPointerRedundantCheck] osmo-hlr-1.4.0/src/proxy.c:536:3: note: Assuming that condition 'proxy_subscr' is not redundant osmo-hlr-1.4.0/src/proxy.c:534:52: note: Calling function 'proxy_acknowledge_gsup_from_remote_hlr', 2nd argument 'proxy_subscr' value is 0 osmo-hlr-1.4.0/src/proxy.c:324:42: note: Null pointer dereference osmo-hlr-1.4.0/src/proxy.c:347:20: warning: Either the condition 'proxy_subscr' is redundant or there is possible null pointer dereference: proxy_subscr. [nullPointerRedundantCheck] osmo-hlr-1.4.0/src/proxy.c:348:4: note: Assuming that condition 'proxy_subscr' is not redundant osmo-hlr-1.4.0/src/proxy.c:347:20: note: Null pointer dereference osmo-hlr-1.4.0/src/proxy.c:96:17: error: Uninitialized variable: p->req [uninitvar] osmo-hlr-1.4.0/src/proxy.c:111:17: error: Uninitialized variable: p->req [uninitvar] osmo-hlr-1.4.0/src/proxy.c:142:11: error: Uninitialized variables: e.entry, e.last_update [uninitvar] osmo-hlr-1.4.0/src/proxy.c:138:6: note: Assuming condition is false osmo-hlr-1.4.0/src/proxy.c:142:11: note: Uninitialized variables: e.entry, e.last_update osmo-hlr-1.4.0/src/proxy.c:154:11: error: Uninitialized variables: e.entry, e.last_update [uninitvar] osmo-hlr-1.4.0/src/proxy.c:150:6: note: Assuming condition is false osmo-hlr-1.4.0/src/proxy.c:154:11: note: Uninitialized variables: e.entry, e.last_update osmo-hlr-1.4.0/src/proxy.c:217:3: error: Uninitialized variable: &e->data [uninitvar] osmo-hlr-1.4.0/src/remote_hlr.c:223:35: style: Parameter 'modified_gsup' can be declared as pointer to const [constParameter] osmo-hlr-1.4.0/src/remote_hlr.c:121:10: error: Uninitialized variable: p->connect_result_cb [uninitvar] osmo-hlr-1.4.0/src/remote_hlr.c:113:6: note: Assuming condition is false osmo-hlr-1.4.0/src/remote_hlr.c:121:10: note: Uninitialized variable: p->connect_result_cb osmo-hlr-1.4.0/tests/auc/gen_ts_55_205_test_sets/func_template.c:51:33: error: syntax error [syntaxError] osmo-hlr-1.4.0/tests/auc/gen_ts_55_205_test_sets/main_template.c:118:8: style: Variable 'printf' is assigned a value that is never used. [unreadVariable] osmo-hlr-1.4.0/tests/mslookup/mdns_test.c:158:5: portability: %lu in format string (no. 1) requires 'unsigned long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_uint] osmo-hlr-1.4.0/tests/mslookup/mdns_test.c:359:3: portability: %lu in format string (no. 1) requires 'unsigned long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_uint] osmo-hlr-1.4.0/tests/mslookup/mdns_test.c:492:8: style: Variable 'j' is assigned a value that is never used. [unreadVariable] osmo-hlr-1.4.0/tests/mslookup/mslookup_client_mdns_test.c:219:2: error: Resource leak: sock [resourceLeak] osmo-hlr-1.4.0/src/proxy.c:179:63: warning: Null pointer dereference: proxy_subscr [ctunullpointer] osmo-hlr-1.4.0/src/proxy.c:453:3: note: Assuming that condition 'proxy_subscr' is not redundant osmo-hlr-1.4.0/src/proxy.c:452:35: note: Calling function proxy_subscr_create_or_update, 2nd argument is null osmo-hlr-1.4.0/src/proxy.c:179:63: note: Dereferencing argument proxy_subscr that is null osmo-hlr-1.4.0/src/proxy.c:261:42: warning: Null pointer dereference: proxy_subscr [ctunullpointer] osmo-hlr-1.4.0/src/proxy.c:481:3: note: Assuming that condition 'proxy_subscr' is not redundant osmo-hlr-1.4.0/src/proxy.c:472:43: note: Calling function proxy_acknowledge_gsup_to_remote_hlr, 2nd argument is null osmo-hlr-1.4.0/src/proxy.c:261:42: note: Dereferencing argument proxy_subscr that is null osmo-hlr-1.4.0/src/proxy.c:324:42: warning: Null pointer dereference: proxy_subscr [ctunullpointer] osmo-hlr-1.4.0/src/proxy.c:536:3: note: Assuming that condition 'proxy_subscr' is not redundant osmo-hlr-1.4.0/src/proxy.c:534:44: note: Calling function proxy_acknowledge_gsup_from_remote_hlr, 2nd argument is null osmo-hlr-1.4.0/src/proxy.c:324:42: note: Dereferencing argument proxy_subscr that is null diff: head osmo-hlr-1.4.0/src/gsup_server.c:497:62: style: Parameter 'modified_gsup' can be declared as pointer to const [constParameter] 2.8 osmo-hlr-1.4.0/src/gsup_server.c:497:62: style: Parameter 'modified_gsup' can be declared with const [constParameter] head osmo-hlr-1.4.0/src/lu_fsm.c:294:4: warning: Operator '|' with one operand equal to zero is redundant. [badBitmaskCheck] head osmo-hlr-1.4.0/src/lu_fsm.c:300:4: warning: Operator '|' with one operand equal to zero is redundant. [badBitmaskCheck] head osmo-hlr-1.4.0/src/mslookup_server.c:235:33: style: Parameter 'ret_subscr' can be declared as pointer to const [constParameter] 2.8 osmo-hlr-1.4.0/src/mslookup_server.c:235:33: style: Parameter 'ret_subscr' can be declared with const [constParameter] head osmo-hlr-1.4.0/src/remote_hlr.c:223:35: style: Parameter 'modified_gsup' can be declared as pointer to const [constParameter] 2.8 osmo-hlr-1.4.0/src/remote_hlr.c:223:35: style: Parameter 'modified_gsup' can be declared with const [constParameter] DONE