2025-05-06 22:06 ftp://ftp.de.debian.org/debian/pool/main/o/openssn/openssn_1.4.orig.tar.gz cppcheck-options: --library=posix --library=gnu --library=bsd --library=sdl --inconclusive --enable=style,information --inline-suppr --template=daca2 --disable=missingInclude --suppress=unmatchedSuppression --check-library --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=normalCheckLevelConditionExpressions -D__GNUC__ --platform=unix64 -j3 platform: Linux-6.8.0-1022-oracle-aarch64-with-glibc2.39 python: 3.12.3 client-version: 1.3.67 compiler: g++ (Ubuntu 13.3.0-6ubuntu2~24.04) 13.3.0 cppcheck: head 2.17.0 head-info: 8e656e5 (2025-05-06 23:42:00 +0200) count: 592 592 elapsed-time: 1.7 1.7 head-timing-info: old-timing-info: head results: openssn/src/adcap.cpp:21:8: warning: Member variable 'AdCap::ActiveSearch' is not initialized in the constructor. [uninitMemberVar] openssn/src/adcap.cpp:21:8: warning: Member variable 'AdCap::WireGuided' is not initialized in the constructor. [uninitMemberVar] openssn/src/adcap.cpp:21:8: warning: Member variable 'AdCap::DesiredHeading' is not initialized in the constructor. [uninitMemberVar] openssn/src/adcap.cpp:21:8: warning: Member variable 'AdCap::CurrentHeading' is not initialized in the constructor. [uninitMemberVar] openssn/src/adcap.cpp:21:8: warning: Member variable 'AdCap::SwimoutSpeed' is not initialized in the constructor. [uninitMemberVar] openssn/src/adcap.cpp:21:8: warning: Member variable 'AdCap::AttackSpeed' is not initialized in the constructor. [uninitMemberVar] openssn/src/adcap.cpp:21:8: warning: Member variable 'AdCap::Aquired' is not initialized in the constructor. [uninitMemberVar] openssn/src/adcap.cpp:21:8: warning: Member variable 'AdCap::RunningTime' is not initialized in the constructor. [uninitMemberVar] openssn/src/adcap.cpp:21:8: warning: Member variable 'AdCap::RunToEnable' is not initialized in the constructor. [uninitMemberVar] openssn/src/boatpositionlog.cpp:57:23: style:inconclusive: Technically the member function 'BoatPositionLog::GetLogItem' can be const. [functionConst] openssn/src/boatpositionlog.h:41:8: note: Technically the member function 'BoatPositionLog::GetLogItem' can be const. openssn/src/boatpositionlog.cpp:57:23: note: Technically the member function 'BoatPositionLog::GetLogItem' can be const. openssn/src/boatpositionlog.cpp:42:43: performance: Function parameter 'temp' should be passed by const reference. [passedByValue] openssn/src/coord.cpp:21:8: warning: Member variable 'Coord::Heading' is not initialized in the constructor. [uninitMemberVar] openssn/src/coord.cpp:21:8: warning: Member variable 'Coord::Speed' is not initialized in the constructor. [uninitMemberVar] openssn/src/coord.cpp:21:8: warning: Member variable 'Coord::Lat_Degrees' is not initialized in the constructor. [uninitMemberVar] openssn/src/coord.cpp:21:8: warning: Member variable 'Coord::Lat_Minutes' is not initialized in the constructor. [uninitMemberVar] openssn/src/coord.cpp:21:8: warning: Member variable 'Coord::Lat_Seconds' is not initialized in the constructor. [uninitMemberVar] openssn/src/coord.cpp:21:8: warning: Member variable 'Coord::Lat_SubSeconds' is not initialized in the constructor. [uninitMemberVar] openssn/src/coord.cpp:21:8: warning: Member variable 'Coord::Lat_TotalYards' is not initialized in the constructor. [uninitMemberVar] openssn/src/coord.cpp:21:8: warning: Member variable 'Coord::Lon_Degrees' is not initialized in the constructor. [uninitMemberVar] openssn/src/coord.cpp:21:8: warning: Member variable 'Coord::Lon_Minutes' is not initialized in the constructor. [uninitMemberVar] openssn/src/coord.cpp:21:8: warning: Member variable 'Coord::Lon_Seconds' is not initialized in the constructor. [uninitMemberVar] openssn/src/coord.cpp:21:8: warning: Member variable 'Coord::Lon_SubSeconds' is not initialized in the constructor. [uninitMemberVar] openssn/src/coord.cpp:21:8: warning: Member variable 'Coord::Lon_TotalYards' is not initialized in the constructor. [uninitMemberVar] openssn/src/coord.cpp:95:13: performance:inconclusive: Technically the member function 'Coord::LatLonPercent' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/coord.h:53:7: note: Technically the member function 'Coord::LatLonPercent' can be static (but you may consider moving to unnamed namespace). openssn/src/coord.cpp:95:13: note: Technically the member function 'Coord::LatLonPercent' can be static (but you may consider moving to unnamed namespace). openssn/src/coord.cpp:95:49: style:inconclusive: Function 'LatLonPercent' argument 2 names different: declaration 'lop' definition 'lonpercent'. [funcArgNamesDifferent] openssn/src/coord.h:53:43: note: Function 'LatLonPercent' argument 2 names different: declaration 'lop' definition 'lonpercent'. openssn/src/coord.cpp:95:49: note: Function 'LatLonPercent' argument 2 names different: declaration 'lop' definition 'lonpercent'. openssn/src/coord.cpp:95:68: style:inconclusive: Function 'LatLonPercent' argument 3 names different: declaration 'lap' definition 'latpercent'. [funcArgNamesDifferent] openssn/src/coord.h:53:55: note: Function 'LatLonPercent' argument 3 names different: declaration 'lap' definition 'latpercent'. openssn/src/coord.cpp:95:68: note: Function 'LatLonPercent' argument 3 names different: declaration 'lap' definition 'latpercent'. openssn/src/coord.cpp:98:11: style: Variable 'llb' is assigned a value that is never used. [unreadVariable] openssn/src/dfont.cpp:9:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable in [valueFlowBailoutIncompleteVar] openssn/src/dfont.cpp:32:5: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] openssn/src/dfont.cpp:85:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable w [valueFlowBailoutIncompleteVar] openssn/src/dfont.cpp:99:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable w [valueFlowBailoutIncompleteVar] openssn/src/dfont.cpp:129:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable x [valueFlowBailoutIncompleteVar] openssn/src/dfont.cpp:40:15: performance:inconclusive: Technically the member function 'DFont::GetPixel' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/dfont.h:35:10: note: Technically the member function 'DFont::GetPixel' can be static (but you may consider moving to unnamed namespace). openssn/src/dfont.cpp:40:15: note: Technically the member function 'DFont::GetPixel' can be static (but you may consider moving to unnamed namespace). openssn/src/dfont.cpp:44:14: style: C-style pointer casting [cstyleCast] openssn/src/dfont.cpp:49:14: style: C-style pointer casting [cstyleCast] openssn/src/dfont.cpp:60:14: style: C-style pointer casting [cstyleCast] openssn/src/dfont.cpp:46:3: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/dfont.cpp:51:3: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/dfont.cpp:57:3: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/dfont.cpp:62:3: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/dstack.cpp:38:13: style:inconclusive: Technically the member function 'DStack::num_items' can be const. [functionConst] openssn/src/dstack.h:30:9: note: Technically the member function 'DStack::num_items' can be const. openssn/src/dstack.cpp:38:13: note: Technically the member function 'DStack::num_items' can be const. openssn/src/dstack.cpp:85:13: style:inconclusive: Technically the member function 'DStack::empty' can be const. [functionConst] openssn/src/dstack.h:32:9: note: Technically the member function 'DStack::empty' can be const. openssn/src/dstack.cpp:85:13: note: Technically the member function 'DStack::empty' can be const. openssn/src/dstack.cpp:28:22: style: C-style pointer casting [cstyleCast] openssn/src/dstack.cpp:47:18: style: C-style pointer casting [cstyleCast] openssn/src/dstack.cpp:73:18: style: C-style pointer casting [cstyleCast] openssn/src/dstack.cpp:103:19: style: C-style pointer casting [cstyleCast] openssn/src/draw.cpp:21:26: style: C-style pointer casting [cstyleCast] openssn/src/control.cpp:67:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_SWSURFACE [valueFlowBailoutIncompleteVar] openssn/src/control.cpp:90:5: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] openssn/src/control.cpp:483:5: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] openssn/src/control.cpp:527:5: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] openssn/src/control.cpp:559:5: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] openssn/src/control.cpp:589:5: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] openssn/src/control.cpp:631:5: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] openssn/src/control.cpp:662:5: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] openssn/src/draw.cpp:70:13: style: The scope of the variable 'x' can be reduced. [variableScope] openssn/src/draw.cpp:70:16: style: The scope of the variable 'y' can be reduced. [variableScope] openssn/src/draw.cpp:44:26: style: Local variable 'x' shadows outer variable [shadowVariable] openssn/src/draw.cpp:30:33: note: Shadowed declaration openssn/src/draw.cpp:44:26: note: Shadow variable openssn/src/draw.cpp:54:26: style: Local variable 'y' shadows outer variable [shadowVariable] openssn/src/draw.cpp:30:35: note: Shadowed declaration openssn/src/draw.cpp:54:26: note: Shadow variable openssn/src/esm.cpp:52:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_SWSURFACE [valueFlowBailoutIncompleteVar] openssn/src/esm.cpp:73:3: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] openssn/src/esm.cpp:178:3: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] openssn/src/files.cpp:69:4: error: Memory leak: location [memleak] openssn/src/files.cpp:15:15: style: C-style pointer casting [cstyleCast] openssn/src/gameclock.cpp:60:17: style:inconclusive: Technically the member function 'GameClock::GetTime' can be const. [functionConst] openssn/src/gameclock.h:30:8: note: Technically the member function 'GameClock::GetTime' can be const. openssn/src/gameclock.cpp:60:17: note: Technically the member function 'GameClock::GetTime' can be const. openssn/src/gameclock.cpp:67:16: style:inconclusive: Technically the member function 'GameClock::GetTick' can be const. [functionConst] openssn/src/gameclock.h:31:7: note: Technically the member function 'GameClock::GetTick' can be const. openssn/src/gameclock.cpp:67:16: note: Technically the member function 'GameClock::GetTick' can be const. openssn/src/gameclock.cpp:36:30: style:inconclusive: Function 'InitTime' argument 1 names different: declaration 'hours' definition 'hrs'. [funcArgNamesDifferent] openssn/src/gameclock.h:28:21: note: Function 'InitTime' argument 1 names different: declaration 'hours' definition 'hrs'. openssn/src/gameclock.cpp:36:30: note: Function 'InitTime' argument 1 names different: declaration 'hours' definition 'hrs'. openssn/src/gameclock.cpp:36:39: style:inconclusive: Function 'InitTime' argument 2 names different: declaration 'minutes' definition 'min'. [funcArgNamesDifferent] openssn/src/gameclock.h:28:32: note: Function 'InitTime' argument 2 names different: declaration 'minutes' definition 'min'. openssn/src/gameclock.cpp:36:39: note: Function 'InitTime' argument 2 names different: declaration 'minutes' definition 'min'. openssn/src/gameclock.cpp:36:48: style:inconclusive: Function 'InitTime' argument 3 names different: declaration 'seconds' definition 'sec'. [funcArgNamesDifferent] openssn/src/gameclock.h:28:45: note: Function 'InitTime' argument 3 names different: declaration 'seconds' definition 'sec'. openssn/src/gameclock.cpp:36:48: note: Function 'InitTime' argument 3 names different: declaration 'seconds' definition 'sec'. openssn/src/gameclock.cpp:60:30: style:inconclusive: Function 'GetTime' argument 1 names different: declaration 'hours' definition 'hrs'. [funcArgNamesDifferent] openssn/src/gameclock.h:30:21: note: Function 'GetTime' argument 1 names different: declaration 'hours' definition 'hrs'. openssn/src/gameclock.cpp:60:30: note: Function 'GetTime' argument 1 names different: declaration 'hours' definition 'hrs'. openssn/src/gameclock.cpp:60:40: style:inconclusive: Function 'GetTime' argument 2 names different: declaration 'minutes' definition 'min'. [funcArgNamesDifferent] openssn/src/gameclock.h:30:33: note: Function 'GetTime' argument 2 names different: declaration 'minutes' definition 'min'. openssn/src/gameclock.cpp:60:40: note: Function 'GetTime' argument 2 names different: declaration 'minutes' definition 'min'. openssn/src/gameclock.cpp:60:50: style:inconclusive: Function 'GetTime' argument 3 names different: declaration 'seconds' definition 'sec'. [funcArgNamesDifferent] openssn/src/gameclock.h:30:47: note: Function 'GetTime' argument 3 names different: declaration 'seconds' definition 'sec'. openssn/src/gameclock.cpp:60:50: note: Function 'GetTime' argument 3 names different: declaration 'seconds' definition 'sec'. openssn/src/control.cpp:42:10: warning: Member variable 'Control::controlscreen' is not initialized in the constructor. [uninitMemberVar] openssn/src/control.cpp:42:10: warning: Member variable 'Control::tempscreen' is not initialized in the constructor. [uninitMemberVar] openssn/src/control.cpp:42:10: warning: Member variable 'Control::ClearControl' is not initialized in the constructor. [uninitMemberVar] openssn/src/control.cpp:42:10: warning: Member variable 'Control::screen' is not initialized in the constructor. [uninitMemberVar] openssn/src/control.cpp:42:10: warning: Member variable 'Control::STOPoff' is not initialized in the constructor. [uninitMemberVar] openssn/src/control.cpp:42:10: warning: Member variable 'Control::STOPon' is not initialized in the constructor. [uninitMemberVar] openssn/src/control.cpp:42:10: warning: Member variable 'Control::A13off' is not initialized in the constructor. [uninitMemberVar] openssn/src/control.cpp:42:10: warning: Member variable 'Control::A13on' is not initialized in the constructor. [uninitMemberVar] openssn/src/control.cpp:42:10: warning: Member variable 'Control::A23off' is not initialized in the constructor. [uninitMemberVar] openssn/src/control.cpp:42:10: warning: Member variable 'Control::A23on' is not initialized in the constructor. [uninitMemberVar] openssn/src/control.cpp:42:10: warning: Member variable 'Control::ASTDoff' is not initialized in the constructor. [uninitMemberVar] openssn/src/control.cpp:42:10: warning: Member variable 'Control::ASTDon' is not initialized in the constructor. [uninitMemberVar] openssn/src/control.cpp:42:10: warning: Member variable 'Control::AFULLoff' is not initialized in the constructor. [uninitMemberVar] openssn/src/control.cpp:42:10: warning: Member variable 'Control::AFULLon' is not initialized in the constructor. [uninitMemberVar] openssn/src/control.cpp:42:10: warning: Member variable 'Control::AFLKoff' is not initialized in the constructor. [uninitMemberVar] openssn/src/control.cpp:42:10: warning: Member variable 'Control::AFLKon' is not initialized in the constructor. [uninitMemberVar] openssn/src/control.cpp:42:10: warning: Member variable 'Control::depthupoff' is not initialized in the constructor. [uninitMemberVar] openssn/src/control.cpp:42:10: warning: Member variable 'Control::depthupon' is not initialized in the constructor. [uninitMemberVar] openssn/src/control.cpp:42:10: warning: Member variable 'Control::depthdownoff' is not initialized in the constructor. [uninitMemberVar] openssn/src/control.cpp:42:10: warning: Member variable 'Control::depthdownon' is not initialized in the constructor. [uninitMemberVar] openssn/src/control.cpp:42:10: warning: Member variable 'Control::x' is not initialized in the constructor. [uninitMemberVar] openssn/src/control.cpp:42:10: warning: Member variable 'Control::y' is not initialized in the constructor. [uninitMemberVar] openssn/src/control.h:38:3: style: Class 'Control' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] openssn/src/control.cpp:741:18: style: The scope of the variable 'previous_radians' can be reduced. [variableScope] openssn/src/control.cpp:742:9: style: The scope of the variable 'previous_speed' can be reduced. [variableScope] openssn/src/control.cpp:742:25: style: The scope of the variable 'previous_depth' can be reduced. [variableScope] openssn/src/control.cpp:507:6: style: Local variable 'x' shadows outer variable [shadowVariable] openssn/src/control.h:104:7: note: Shadowed declaration openssn/src/control.cpp:507:6: note: Shadow variable openssn/src/control.cpp:507:9: style: Local variable 'y' shadows outer variable [shadowVariable] openssn/src/control.h:105:7: note: Shadowed declaration openssn/src/control.cpp:507:9: note: Shadow variable openssn/src/control.cpp:737:15: style: Local variable 'text' shadows outer variable [shadowVariable] openssn/src/control.h:108:15: note: Shadowed declaration openssn/src/control.cpp:737:15: note: Shadow variable openssn/src/control.cpp:740:9: style: Local variable 'fnt' shadows outer function [shadowFunction] openssn/src/control.h:110:9: note: Shadowed declaration openssn/src/control.cpp:740:9: note: Shadow variable openssn/src/esm.cpp:38:6: warning: Member variable 'Esm::esmscreen' is not initialized in the constructor. [uninitMemberVar] openssn/src/esm.cpp:38:6: warning: Member variable 'Esm::tempscreen' is not initialized in the constructor. [uninitMemberVar] openssn/src/esm.cpp:38:6: warning: Member variable 'Esm::blip' is not initialized in the constructor. [uninitMemberVar] openssn/src/esm.cpp:38:6: warning: Member variable 'Esm::sweep1' is not initialized in the constructor. [uninitMemberVar] openssn/src/esm.cpp:38:6: warning: Member variable 'Esm::ClearEsm' is not initialized in the constructor. [uninitMemberVar] openssn/src/esm.cpp:38:6: warning: Member variable 'Esm::ClearEsm2' is not initialized in the constructor. [uninitMemberVar] openssn/src/esm.cpp:38:6: warning: Member variable 'Esm::screen' is not initialized in the constructor. [uninitMemberVar] openssn/src/esm.cpp:38:6: warning: Member variable 'Esm::mastdownoff' is not initialized in the constructor. [uninitMemberVar] openssn/src/esm.cpp:38:6: warning: Member variable 'Esm::mastdownon' is not initialized in the constructor. [uninitMemberVar] openssn/src/esm.cpp:38:6: warning: Member variable 'Esm::mastupoff' is not initialized in the constructor. [uninitMemberVar] openssn/src/esm.cpp:38:6: warning: Member variable 'Esm::mastupon' is not initialized in the constructor. [uninitMemberVar] openssn/src/esm.cpp:38:6: warning: Member variable 'Esm::styllus' is not initialized in the constructor. [uninitMemberVar] openssn/src/esm.cpp:38:6: warning: Member variable 'Esm::CurrentAntennaHeight' is not initialized in the constructor. [uninitMemberVar] openssn/src/esm.cpp:38:6: warning: Member variable 'Esm::EsmHorizon' is not initialized in the constructor. [uninitMemberVar] openssn/src/esm.cpp:38:6: warning: Member variable 'Esm::bearing' is not initialized in the constructor. [uninitMemberVar] openssn/src/esm.cpp:38:6: warning: Member variable 'Esm::SignalStrength' is not initialized in the constructor. [uninitMemberVar] openssn/src/esm.cpp:38:6: warning: Member variable 'Esm::DetectProb' is not initialized in the constructor. [uninitMemberVar] openssn/src/esm.cpp:38:6: warning: Member variable 'Esm::x' is not initialized in the constructor. [uninitMemberVar] openssn/src/esm.cpp:38:6: warning: Member variable 'Esm::y' is not initialized in the constructor. [uninitMemberVar] openssn/src/esm.cpp:38:6: warning: Member variable 'Esm::orange' is not initialized in the constructor. [uninitMemberVar] openssn/src/esm.cpp:38:6: warning: Member variable 'Esm::black' is not initialized in the constructor. [uninitMemberVar] openssn/src/esm.cpp:475:11: style:inconclusive: Technically the member function 'Esm::DPixel' can be const. [functionConst] openssn/src/esm.h:71:7: note: Technically the member function 'Esm::DPixel' can be const. openssn/src/esm.cpp:475:11: note: Technically the member function 'Esm::DPixel' can be const. openssn/src/esm.h:40:2: style: Class 'Esm' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] openssn/src/esm.cpp:488:19: style: C-style pointer casting [cstyleCast] openssn/src/esm.cpp:366:8: style: The scope of the variable 'radians' can be reduced. [variableScope] openssn/src/esm.cpp:367:8: style: The scope of the variable 'radians_old' can be reduced. [variableScope] openssn/src/esm.cpp:368:6: style: The scope of the variable 'bearing' can be reduced. [variableScope] openssn/src/esm.cpp:368:15: style: The scope of the variable 'range' can be reduced. [variableScope] openssn/src/esm.cpp:368:22: style: The scope of the variable 'depth' can be reduced. [variableScope] openssn/src/esm.cpp:47:56: style:inconclusive: Function 'InitGraphics' argument 2 names different: declaration 'tempradarscreen' definition 'tempesmscreen'. [funcArgNamesDifferent] openssn/src/esm.h:69:52: note: Function 'InitGraphics' argument 2 names different: declaration 'tempradarscreen' definition 'tempesmscreen'. openssn/src/esm.cpp:47:56: note: Function 'InitGraphics' argument 2 names different: declaration 'tempradarscreen' definition 'tempesmscreen'. openssn/src/esm.cpp:361:14: style: Local variable 'text' shadows outer variable [shadowVariable] openssn/src/esm.h:99:14: note: Shadowed declaration openssn/src/esm.cpp:361:14: note: Shadow variable openssn/src/esm.cpp:364:8: style: Local variable 'fnt' shadows outer function [shadowFunction] openssn/src/esm.h:101:8: note: Shadowed declaration openssn/src/esm.cpp:364:8: note: Shadow variable openssn/src/esm.cpp:368:6: style: Local variable 'bearing' shadows outer variable [shadowVariable] openssn/src/esm.h:92:6: note: Shadowed declaration openssn/src/esm.cpp:368:6: note: Shadow variable openssn/src/esm.cpp:439:26: style: Local variable 'x' shadows outer variable [shadowVariable] openssn/src/esm.h:95:6: note: Shadowed declaration openssn/src/esm.cpp:439:26: note: Shadow variable openssn/src/esm.cpp:439:28: style: Local variable 'y' shadows outer variable [shadowVariable] openssn/src/esm.h:96:6: note: Shadowed declaration openssn/src/esm.cpp:439:28: note: Shadow variable openssn/src/esm.cpp:453:12: style: Local variable 'x' shadows outer variable [shadowVariable] openssn/src/esm.cpp:439:26: note: Shadowed declaration openssn/src/esm.cpp:453:12: note: Shadow variable openssn/src/esm.cpp:463:12: style: Local variable 'y' shadows outer variable [shadowVariable] openssn/src/esm.cpp:439:28: note: Shadowed declaration openssn/src/esm.cpp:463:12: note: Shadow variable openssn/src/esm.cpp:259:38: style: Parameter 'target' can be declared as pointer to const [constParameterPointer] openssn/src/helicopter.cpp:8:13: warning: Member variable 'Helicopter::DesiredSpeed' is not initialized in the constructor. [uninitMemberVar] openssn/src/helicopter.cpp:8:13: warning: Member variable 'Helicopter::Depth' is not initialized in the constructor. [uninitMemberVar] openssn/src/helicopter.cpp:8:13: warning: Member variable 'Helicopter::DesiredDepth' is not initialized in the constructor. [uninitMemberVar] openssn/src/helicopter.cpp:8:13: warning: Member variable 'Helicopter::TorpedoesOnBoard' is not initialized in the constructor. [uninitMemberVar] openssn/src/helicopter.cpp:8:13: warning: Member variable 'Helicopter::ClassName' is not initialized in the constructor. [uninitMemberVar] openssn/src/helicopter.cpp:8:13: warning: Member variable 'Helicopter::ClassType' is not initialized in the constructor. [uninitMemberVar] openssn/src/helicopter.cpp:8:13: warning: Member variable 'Helicopter::map' is not initialized in the constructor. [uninitMemberVar] openssn/src/helicopter.cpp:45:18: performance:inconclusive: Technically the member function 'Helicopter::Cleanup' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/helicopter.h:57:9: note: Technically the member function 'Helicopter::Cleanup' can be static (but you may consider moving to unnamed namespace). openssn/src/helicopter.cpp:45:18: note: Technically the member function 'Helicopter::Cleanup' can be static (but you may consider moving to unnamed namespace). openssn/src/helicopter.cpp:86:17: performance:inconclusive: Technically the member function 'Helicopter::Load_Mission' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/helicopter.h:62:8: note: Technically the member function 'Helicopter::Load_Mission' can be static (but you may consider moving to unnamed namespace). openssn/src/helicopter.cpp:86:17: note: Technically the member function 'Helicopter::Load_Mission' can be static (but you may consider moving to unnamed namespace). openssn/src/helicopter.cpp:106:17: style:inconclusive: Technically the member function 'Helicopter::Check_Status' can be const. [functionConst] openssn/src/helicopter.h:63:8: note: Technically the member function 'Helicopter::Check_Status' can be const. openssn/src/helicopter.cpp:106:17: note: Technically the member function 'Helicopter::Check_Status' can be const. openssn/src/helicopter.cpp:484:20: style:inconclusive: Technically the member function 'Helicopter::Distance_To_Destination' can be const. [functionConst] openssn/src/helicopter.h:65:11: note: Technically the member function 'Helicopter::Distance_To_Destination' can be const. openssn/src/helicopter.cpp:484:20: note: Technically the member function 'Helicopter::Distance_To_Destination' can be const. openssn/src/helicopter.cpp:504:20: style:inconclusive: Technically the member function 'Helicopter::Distance_To_Target' can be const. [functionConst] openssn/src/helicopter.h:66:11: note: Technically the member function 'Helicopter::Distance_To_Target' can be const. openssn/src/helicopter.cpp:504:20: note: Technically the member function 'Helicopter::Distance_To_Target' can be const. openssn/src/helicopter.cpp:72:8: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] openssn/src/helicopter.cpp:582:45: warning: Either the condition '!target' is redundant or there is possible null pointer dereference: target. [nullPointerRedundantCheck] openssn/src/helicopter.cpp:598:13: note: Assuming that condition '!target' is not redundant openssn/src/helicopter.cpp:582:45: note: Null pointer dereference openssn/src/helicopter.cpp:126:14: style: The scope of the variable 'new_direction' can be reduced. [variableScope] openssn/src/helicopter.cpp:128:7: style: The scope of the variable 'do_what' can be reduced. [variableScope] openssn/src/helicopter.cpp:131:7: style: The scope of the variable 'found' can be reduced. [variableScope] openssn/src/helicopter.cpp:504:50: style:inconclusive: Function 'Distance_To_Target' argument 1 names different: declaration 'target' definition 'Target'. [funcArgNamesDifferent] openssn/src/helicopter.h:66:41: note: Function 'Distance_To_Target' argument 1 names different: declaration 'target' definition 'Target'. openssn/src/helicopter.cpp:504:50: note: Function 'Distance_To_Target' argument 1 names different: declaration 'target' definition 'Target'. openssn/src/helicopter.cpp:57:34: style: Parameter 'from_file' can be declared as pointer to const [constParameterPointer] openssn/src/helicopter.cpp:61:10: style: Variable 'status' can be declared as pointer to const [constVariablePointer] openssn/src/helicopter.cpp:89:10: style: Variable 'status' can be declared as pointer to const [constVariablePointer] openssn/src/helicopter.cpp:127:14: style: Variable 'ship' can be declared as pointer to const [constVariablePointer] openssn/src/helicopter.cpp:504:50: style: Parameter 'Target' can be declared as pointer to const [constParameterPointer] openssn/src/helicopter.cpp:241:31: style: Variable 'do_what' is assigned a value that is never used. [unreadVariable] openssn/src/helicopter.cpp:289:32: style: Variable 'do_what' is assigned a value that is never used. [unreadVariable] openssn/src/map.cpp:59:10: performance:inconclusive: Technically the member function 'MAP::Get_Ocean_Depth' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/map.h:40:7: note: Technically the member function 'MAP::Get_Ocean_Depth' can be static (but you may consider moving to unnamed namespace). openssn/src/map.cpp:59:10: note: Technically the member function 'MAP::Get_Ocean_Depth' can be static (but you may consider moving to unnamed namespace). openssn/src/map.cpp:69:10: style:inconclusive: Technically the member function 'MAP::Thermals_Between' can be const. [functionConst] openssn/src/map.h:41:7: note: Technically the member function 'MAP::Thermals_Between' can be const. openssn/src/map.cpp:69:10: note: Technically the member function 'MAP::Thermals_Between' can be const. openssn/src/map.cpp:108:10: style:inconclusive: Technically the member function 'MAP::Next_Up' can be const. [functionConst] openssn/src/map.h:42:7: note: Technically the member function 'MAP::Next_Up' can be const. openssn/src/map.cpp:108:10: note: Technically the member function 'MAP::Next_Up' can be const. openssn/src/map.cpp:131:10: style:inconclusive: Technically the member function 'MAP::Next_Down' can be const. [functionConst] openssn/src/map.h:43:7: note: Technically the member function 'MAP::Next_Down' can be const. openssn/src/map.cpp:131:10: note: Technically the member function 'MAP::Next_Down' can be const. openssn/src/map.cpp:108:22: style:inconclusive: Function 'Next_Up' argument 1 names different: declaration 'current_depth' definition 'from_depth'. [funcArgNamesDifferent] openssn/src/map.h:42:19: note: Function 'Next_Up' argument 1 names different: declaration 'current_depth' definition 'from_depth'. openssn/src/map.cpp:108:22: note: Function 'Next_Up' argument 1 names different: declaration 'current_depth' definition 'from_depth'. openssn/src/map.cpp:131:24: style:inconclusive: Function 'Next_Down' argument 1 names different: declaration 'current_depth' definition 'from_depth'. [funcArgNamesDifferent] openssn/src/map.h:43:21: note: Function 'Next_Down' argument 1 names different: declaration 'current_depth' definition 'from_depth'. openssn/src/map.cpp:131:24: note: Function 'Next_Down' argument 1 names different: declaration 'current_depth' definition 'from_depth'. openssn/src/message.cpp:42:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_SWSURFACE [valueFlowBailoutIncompleteVar] openssn/src/menu.cpp:205:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_UP [valueFlowBailoutIncompleteVar] openssn/src/message.cpp:28:6: warning: Member variable 'msg::screen' is not initialized in the constructor. [uninitMemberVar] openssn/src/message.cpp:28:6: warning: Member variable 'msg::messagewindow' is not initialized in the constructor. [uninitMemberVar] openssn/src/message.cpp:28:6: warning: Member variable 'msg::textcolor' is not initialized in the constructor. [uninitMemberVar] openssn/src/message.cpp:28:6: warning: Member variable 'msg::black' is not initialized in the constructor. [uninitMemberVar] openssn/src/message.cpp:28:6: warning: Member variable 'msg::white' is not initialized in the constructor. [uninitMemberVar] openssn/src/message.cpp:28:6: warning: Member variable 'msg::red' is not initialized in the constructor. [uninitMemberVar] openssn/src/message.cpp:28:6: warning: Member variable 'msg::green' is not initialized in the constructor. [uninitMemberVar] openssn/src/message.cpp:28:6: warning: Member variable 'msg::yellow' is not initialized in the constructor. [uninitMemberVar] openssn/src/message.cpp:58:30: style: Parameter 'temp_string' can be declared as pointer to const [constParameterPointer] openssn/src/menu.cpp:89:25: warning: Either the condition 'mission_path' is redundant or there is possible null pointer dereference: mission_path. [nullPointerRedundantCheck] openssn/src/menu.cpp:90:10: note: Assuming that condition 'mission_path' is not redundant openssn/src/menu.cpp:89:25: note: Null pointer dereference openssn/src/menu.cpp:121:25: warning: Either the condition 'full_path' is redundant or there is possible null pointer dereference: full_path. [nullPointerRedundantCheck] openssn/src/menu.cpp:122:10: note: Assuming that condition 'full_path' is not redundant openssn/src/menu.cpp:121:25: note: Null pointer dereference openssn/src/menu.cpp:15:8: style: The scope of the variable 'action' can be reduced. [variableScope] openssn/src/menu.cpp:111:8: style: The scope of the variable 'y' can be reduced. [variableScope] openssn/src/main.cpp:66:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_INIT_VIDEO [valueFlowBailoutIncompleteVar] openssn/src/main.cpp:242:3: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] openssn/src/main.cpp:269:3: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] openssn/src/main.cpp:2909:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] openssn/src/radar.cpp:77:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_SWSURFACE [valueFlowBailoutIncompleteVar] openssn/src/radar.cpp:113:3: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] openssn/src/radar.cpp:679:5: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] openssn/src/radar.cpp:710:5: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] openssn/src/radar.cpp:761:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_SRCALPHA [valueFlowBailoutIncompleteVar] openssn/src/radar.cpp:871:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_SRCALPHA [valueFlowBailoutIncompleteVar] openssn/src/sonar.cpp:51:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_SWSURFACE [valueFlowBailoutIncompleteVar] openssn/src/sonar.cpp:684:3: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cerr [valueFlowBailoutIncompleteVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::radarscreen' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::tempscreen' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::blip' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::sweep' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::ClearRadar' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::rangering5' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::screen' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::range10off' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::range10on' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::range20off' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::range20on' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::range30off' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::range30on' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::range40off' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::range40on' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::range50off' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::range50on' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::range60off' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::range60on' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::ring0off' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::ring0on' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::ring5off' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::ring5on' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::ring10off' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::ring10on' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::ring15off' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::ring15on' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::ring20off' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::ring20on' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::ring25off' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::ring25on' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::mastdownoff' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::mastdownon' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::mastupoff' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::mastupon' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::CurrentAntennaHeight' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::RadarHorizon' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::bearing' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::range' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::x' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::y' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::tempint' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::tempval' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::orange' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:39:8: warning: Member variable 'Radar::black' is not initialized in the constructor. [uninitMemberVar] openssn/src/radar.cpp:1158:12: performance:inconclusive: Technically the member function 'Radar::DeltaBearing' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/radar.h:83:6: note: Technically the member function 'Radar::DeltaBearing' can be static (but you may consider moving to unnamed namespace). openssn/src/radar.cpp:1158:12: note: Technically the member function 'Radar::DeltaBearing' can be static (but you may consider moving to unnamed namespace). openssn/src/radar.cpp:1180:13: style:inconclusive: Technically the member function 'Radar::ReciprocalBearing' can be const. [functionConst] openssn/src/radar.h:84:6: note: Technically the member function 'Radar::ReciprocalBearing' can be const. openssn/src/radar.cpp:1180:13: note: Technically the member function 'Radar::ReciprocalBearing' can be const. openssn/src/radar.cpp:1192:13: style:inconclusive: Technically the member function 'Radar::DrawPixel' can be const. [functionConst] openssn/src/radar.h:86:7: note: Technically the member function 'Radar::DrawPixel' can be const. openssn/src/radar.cpp:1192:13: note: Technically the member function 'Radar::DrawPixel' can be const. openssn/src/radar.h:53:2: style: Class 'Radar' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] openssn/src/radar.cpp:1204:19: style: C-style pointer casting [cstyleCast] openssn/src/radar.cpp:807:9: style: The scope of the variable 'radians' can be reduced. [variableScope] openssn/src/radar.cpp:808:7: style: The scope of the variable 'bearing' can be reduced. [variableScope] openssn/src/radar.cpp:808:16: style: The scope of the variable 'range' can be reduced. [variableScope] openssn/src/radar.cpp:808:23: style: The scope of the variable 'depth' can be reduced. [variableScope] openssn/src/radar.cpp:1212:6: style: The scope of the variable 'x' can be reduced. [variableScope] openssn/src/radar.cpp:1212:9: style: The scope of the variable 'y' can be reduced. [variableScope] openssn/src/radar.cpp:72:39: style:inconclusive: Function 'InitGraphics' argument 1 names different: declaration 'screen' definition 'temp'. [funcArgNamesDifferent] openssn/src/radar.h:59:33: note: Function 'InitGraphics' argument 1 names different: declaration 'screen' definition 'temp'. openssn/src/radar.cpp:72:39: note: Function 'InitGraphics' argument 1 names different: declaration 'screen' definition 'temp'. openssn/src/radar.cpp:72:58: style:inconclusive: Function 'InitGraphics' argument 2 names different: declaration 'radarscreen' definition 'tempradarscreen'. [funcArgNamesDifferent] openssn/src/radar.h:59:54: note: Function 'InitGraphics' argument 2 names different: declaration 'radarscreen' definition 'tempradarscreen'. openssn/src/radar.cpp:72:58: note: Function 'InitGraphics' argument 2 names different: declaration 'radarscreen' definition 'tempradarscreen'. openssn/src/radar.cpp:1180:35: style:inconclusive: Function 'ReciprocalBearing' argument 1 names different: declaration 'bearing1' definition 'bearing'. [funcArgNamesDifferent] openssn/src/radar.h:84:28: note: Function 'ReciprocalBearing' argument 1 names different: declaration 'bearing1' definition 'bearing'. openssn/src/radar.cpp:1180:35: note: Function 'ReciprocalBearing' argument 1 names different: declaration 'bearing1' definition 'bearing'. openssn/src/radar.cpp:808:7: style: Local variable 'bearing' shadows outer variable [shadowVariable] openssn/src/radar.h:168:6: note: Shadowed declaration openssn/src/radar.cpp:808:7: note: Shadow variable openssn/src/radar.cpp:808:16: style: Local variable 'range' shadows outer variable [shadowVariable] openssn/src/radar.h:169:6: note: Shadowed declaration openssn/src/radar.cpp:808:16: note: Shadow variable openssn/src/radar.cpp:1104:15: style: Local variable 'text' shadows outer variable [shadowVariable] openssn/src/radar.h:175:14: note: Shadowed declaration openssn/src/radar.cpp:1104:15: note: Shadow variable openssn/src/radar.cpp:1109:16: style: Local variable 'largeFont' shadows outer function [shadowFunction] openssn/src/radar.h:177:8: note: Shadowed declaration openssn/src/radar.cpp:1109:16: note: Shadow variable openssn/src/radar.cpp:1112:7: style: Local variable 'bearing' shadows outer variable [shadowVariable] openssn/src/radar.h:168:6: note: Shadowed declaration openssn/src/radar.cpp:1112:7: note: Shadow variable openssn/src/radar.cpp:1113:7: style: Local variable 'range' shadows outer variable [shadowVariable] openssn/src/radar.h:169:6: note: Shadowed declaration openssn/src/radar.cpp:1113:7: note: Shadow variable openssn/src/radar.cpp:1212:6: style: Local variable 'x' shadows outer variable [shadowVariable] openssn/src/radar.h:170:6: note: Shadowed declaration openssn/src/radar.cpp:1212:6: note: Shadow variable openssn/src/radar.cpp:1212:9: style: Local variable 'y' shadows outer variable [shadowVariable] openssn/src/radar.h:171:6: note: Shadowed declaration openssn/src/radar.cpp:1212:9: note: Shadow variable openssn/src/radar.cpp:1030:40: style: Parameter 'target' can be declared as pointer to const [constParameterPointer] openssn/src/sound.cpp:13:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AUDIO_S16 [valueFlowBailoutIncompleteVar] openssn/src/sound.cpp:12:8: style: The scope of the variable 'audio_rate' can be reduced. [variableScope] openssn/src/sound.cpp:14:8: style: The scope of the variable 'audio_channels' can be reduced. [variableScope] openssn/src/sound.cpp:15:8: style: The scope of the variable 'audio_buffers' can be reduced. [variableScope] openssn/src/sound.cpp:9:20: style:inconclusive: Function 'Init_Audio' argument 1 names different: declaration 'enable_sound' definition 'allow_sounds'. [funcArgNamesDifferent] openssn/src/sound.h:11:20: note: Function 'Init_Audio' argument 1 names different: declaration 'enable_sound' definition 'allow_sounds'. openssn/src/sound.cpp:9:20: note: Function 'Init_Audio' argument 1 names different: declaration 'enable_sound' definition 'allow_sounds'. openssn/src/stack.cpp:90:12: style:inconclusive: Technically the member function 'Stack::GetCount' can be const. [functionConst] openssn/src/stack.h:54:7: note: Technically the member function 'Stack::GetCount' can be const. openssn/src/stack.cpp:90:12: note: Technically the member function 'Stack::GetCount' can be const. openssn/src/stack.cpp:67:12: style:inconclusive: Technically the member function 'Stack::GetEvent' can be const. [functionConst] openssn/src/stack.h:56:6: note: Technically the member function 'Stack::GetEvent' can be const. openssn/src/stack.cpp:67:12: note: Technically the member function 'Stack::GetEvent' can be const. openssn/src/stack.cpp:38:18: style: C-style pointer casting [cstyleCast] openssn/src/stack.cpp:47:16: style: C-style pointer casting [cstyleCast] openssn/src/stack.cpp:75:20: style: C-style pointer casting [cstyleCast] openssn/src/stack.cpp:102:18: style: C-style pointer casting [cstyleCast] openssn/src/stack.cpp:32:26: style: The scope of the variable 'previous' can be reduced. [variableScope] openssn/src/stack.cpp:97:26: style: The scope of the variable 'previous' can be reduced. [variableScope] openssn/src/stack.cpp:43:47: style:inconclusive: Function 'RegisterEvent' argument 2 names different: declaration 'signalstrength' definition 'signal'. [funcArgNamesDifferent] openssn/src/stack.h:52:41: note: Function 'RegisterEvent' argument 2 names different: declaration 'signalstrength' definition 'signal'. openssn/src/stack.cpp:43:47: note: Function 'RegisterEvent' argument 2 names different: declaration 'signalstrength' definition 'signal'. openssn/src/stack.cpp:67:37: style:inconclusive: Function 'GetEvent' argument 2 names different: declaration 'Direction' definition 'rdirection'. [funcArgNamesDifferent] openssn/src/stack.h:56:31: note: Function 'GetEvent' argument 2 names different: declaration 'Direction' definition 'rdirection'. openssn/src/stack.cpp:67:37: note: Function 'GetEvent' argument 2 names different: declaration 'Direction' definition 'rdirection'. openssn/src/stack.cpp:67:56: style:inconclusive: Function 'GetEvent' argument 3 names different: declaration 'SignalStrength' definition 'rsignal'. [funcArgNamesDifferent] openssn/src/stack.h:56:49: note: Function 'GetEvent' argument 3 names different: declaration 'SignalStrength' definition 'rsignal'. openssn/src/stack.cpp:67:56: note: Function 'GetEvent' argument 3 names different: declaration 'SignalStrength' definition 'rsignal'. openssn/src/submarine.cpp:690:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable in [valueFlowBailoutIncompleteVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::assigntracker' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::flowandambientnoise' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::screen' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::sonarscreen' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::towedarrayscreen' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::uppersonarcrt' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::lowersonarcrt' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::ncscale' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::scscale' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::sonarbuttondown' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::sonarbuttonup' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::truerel' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::sphertowed' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::uppercrtoff' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::uppercrton' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::lowercrtoff' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::lowercrton' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::tb16winchoff' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::tb16winchon' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::extendtb16' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::retracttb16' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::cutarray' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::sendping' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::assigntrackerwidget' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::tracker1' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::tracker2' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::tracker3' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::tracker4' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::tempint' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::tempval' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::deAngle' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::black' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::white' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:36:9: warning: Member variable 'AnBqq5::green' is not initialized in the constructor. [uninitMemberVar] openssn/src/sonar.cpp:85:21: style:inconclusive: Technically the member function 'AnBqq5::DPixel' can be const. [functionConst] openssn/src/sonar.h:42:14: note: Technically the member function 'AnBqq5::DPixel' can be const. openssn/src/sonar.cpp:85:21: note: Technically the member function 'AnBqq5::DPixel' can be const. openssn/src/sonar.cpp:1113:14: style:inconclusive: Technically the member function 'AnBqq5::GetNorthCenterState' can be const. [functionConst] openssn/src/sonar.h:129:7: note: Technically the member function 'AnBqq5::GetNorthCenterState' can be const. openssn/src/sonar.cpp:1113:14: note: Technically the member function 'AnBqq5::GetNorthCenterState' can be const. openssn/src/sonar.cpp:1168:13: performance:inconclusive: Technically the member function 'AnBqq5::RandInt' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/sonar.h:140:6: note: Technically the member function 'AnBqq5::RandInt' can be static (but you may consider moving to unnamed namespace). openssn/src/sonar.cpp:1168:13: note: Technically the member function 'AnBqq5::RandInt' can be static (but you may consider moving to unnamed namespace). openssn/src/sonar.cpp:1173:13: performance:inconclusive: Technically the member function 'AnBqq5::ReciprocalBearing' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/sonar.h:142:6: note: Technically the member function 'AnBqq5::ReciprocalBearing' can be static (but you may consider moving to unnamed namespace). openssn/src/sonar.cpp:1173:13: note: Technically the member function 'AnBqq5::ReciprocalBearing' can be static (but you may consider moving to unnamed namespace). openssn/src/sonar.cpp:52:6: warning: Either the condition 'screen==NULL' is redundant or there is possible null pointer dereference: screen. [nullPointerRedundantCheck] openssn/src/sonar.cpp:61:14: note: Assuming that condition 'screen==NULL' is not redundant openssn/src/sonar.cpp:52:6: note: Null pointer dereference openssn/src/sonar.cpp:53:6: warning: Either the condition 'screen==NULL' is redundant or there is possible null pointer dereference: screen. [nullPointerRedundantCheck] openssn/src/sonar.cpp:61:14: note: Assuming that condition 'screen==NULL' is not redundant openssn/src/sonar.cpp:53:6: note: Null pointer dereference openssn/src/sonar.cpp:54:6: warning: Either the condition 'screen==NULL' is redundant or there is possible null pointer dereference: screen. [nullPointerRedundantCheck] openssn/src/sonar.cpp:61:14: note: Assuming that condition 'screen==NULL' is not redundant openssn/src/sonar.cpp:54:6: note: Null pointer dereference openssn/src/sonar.cpp:55:6: warning: Either the condition 'screen==NULL' is redundant or there is possible null pointer dereference: screen. [nullPointerRedundantCheck] openssn/src/sonar.cpp:61:14: note: Assuming that condition 'screen==NULL' is not redundant openssn/src/sonar.cpp:55:6: note: Null pointer dereference openssn/src/sonar.cpp:90:19: style: C-style pointer casting [cstyleCast] openssn/src/sonar.cpp:148:9: style: The scope of the variable 'tracecolor' can be reduced. [variableScope] openssn/src/sonar.cpp:152:16: style: The scope of the variable 'combined_sound' can be reduced. [variableScope] openssn/src/sonar.cpp:248:14: style: The scope of the variable 'text' can be reduced. [variableScope] openssn/src/sonar.cpp:288:9: style: The scope of the variable 'tracecolor' can be reduced. [variableScope] openssn/src/sonar.cpp:289:6: style: The scope of the variable 'direction' can be reduced. [variableScope] openssn/src/sonar.cpp:289:17: style: The scope of the variable 'ambiguous_direction' can be reduced. [variableScope] openssn/src/sonar.cpp:289:47: style: The scope of the variable 'ambiguous_relative_bearing' can be reduced. [variableScope] openssn/src/sonar.cpp:292:16: style: The scope of the variable 'combined_sound' can be reduced. [variableScope] openssn/src/sonar.cpp:1206:17: style: The scope of the variable 'temp' can be reduced. [variableScope] openssn/src/sonar.cpp:246:39: style:inconclusive: Function 'UpdateDisplay' argument 1 names different: declaration 'target' definition 'current_target'. [funcArgNamesDifferent] openssn/src/sonar.h:53:32: note: Function 'UpdateDisplay' argument 1 names different: declaration 'target' definition 'current_target'. openssn/src/sonar.cpp:246:39: note: Function 'UpdateDisplay' argument 1 names different: declaration 'target' definition 'current_target'. openssn/src/sonar.cpp:115:12: style: Local variable 'x' shadows outer variable [shadowVariable] openssn/src/sonar.cpp:101:26: note: Shadowed declaration openssn/src/sonar.cpp:115:12: note: Shadow variable openssn/src/sonar.cpp:125:12: style: Local variable 'y' shadows outer variable [shadowVariable] openssn/src/sonar.cpp:101:28: note: Shadowed declaration openssn/src/sonar.cpp:125:12: note: Shadow variable openssn/src/sonar.cpp:212:11: style: Local variable 'destination_rectangle' shadows outer variable [shadowVariable] openssn/src/sonar.h:148:11: note: Shadowed declaration openssn/src/sonar.cpp:212:11: note: Shadow variable openssn/src/sonar.cpp:213:11: style: Local variable 'source_rectangle' shadows outer variable [shadowVariable] openssn/src/sonar.h:149:11: note: Shadowed declaration openssn/src/sonar.cpp:213:11: note: Shadow variable openssn/src/sonar.cpp:247:11: style: Local variable 'destination_rectangle' shadows outer variable [shadowVariable] openssn/src/sonar.h:148:11: note: Shadowed declaration openssn/src/sonar.cpp:247:11: note: Shadow variable openssn/src/sonar.cpp:248:14: style: Local variable 'text' shadows outer variable [shadowVariable] openssn/src/sonar.h:183:14: note: Shadowed declaration openssn/src/sonar.cpp:248:14: note: Shadow variable openssn/src/sonar.cpp:251:15: style: Local variable 'largeFont' shadows outer function [shadowFunction] openssn/src/sonar.h:176:8: note: Shadowed declaration openssn/src/sonar.cpp:251:15: note: Shadow variable openssn/src/sonar.cpp:364:11: style: Local variable 'destination_rectangle' shadows outer variable [shadowVariable] openssn/src/sonar.h:148:11: note: Shadowed declaration openssn/src/sonar.cpp:364:11: note: Shadow variable openssn/src/sonar.cpp:365:11: style: Local variable 'source_rectangle' shadows outer variable [shadowVariable] openssn/src/sonar.h:149:11: note: Shadowed declaration openssn/src/sonar.cpp:365:11: note: Shadow variable openssn/src/sonar.cpp:651:11: style: Local variable 'destination_rectangle' shadows outer variable [shadowVariable] openssn/src/sonar.h:148:11: note: Shadowed declaration openssn/src/sonar.cpp:651:11: note: Shadow variable openssn/src/sonar.cpp:982:11: style: Local variable 'destination_rectangle' shadows outer variable [shadowVariable] openssn/src/sonar.h:148:11: note: Shadowed declaration openssn/src/sonar.cpp:982:11: note: Shadow variable openssn/src/sonar.cpp:1122:11: style: Local variable 'destination_rectangle' shadows outer variable [shadowVariable] openssn/src/sonar.h:148:11: note: Shadowed declaration openssn/src/sonar.cpp:1122:11: note: Shadow variable openssn/src/sonar.cpp:1139:11: style: Local variable 'destination_rectangle' shadows outer variable [shadowVariable] openssn/src/sonar.h:148:11: note: Shadowed declaration openssn/src/sonar.cpp:1139:11: note: Shadow variable openssn/src/sonar.cpp:1156:11: style: Local variable 'destination_rectangle' shadows outer variable [shadowVariable] openssn/src/sonar.h:148:11: note: Shadowed declaration openssn/src/sonar.cpp:1156:11: note: Shadow variable openssn/src/sonar.cpp:65:9: style: Unused variable: filename [unusedVariable] openssn/src/sonar.cpp:66:9: style: Unused variable: filename2 [unusedVariable] openssn/src/sonar.cpp:1220:34: style: Variable 'temp' is assigned a value that is never used. [unreadVariable] openssn/src/submarine.cpp:32:12: warning: Member variable 'Submarine::NauticalMiles' is not initialized in the constructor. [uninitMemberVar] openssn/src/submarine.cpp:32:12: warning: Member variable 'Submarine::HisPassiveSonarCrosssection' is not initialized in the constructor. [uninitMemberVar] openssn/src/submarine.cpp:32:12: warning: Member variable 'Submarine::EffectiveTargetSpeed' is not initialized in the constructor. [uninitMemberVar] openssn/src/submarine.cpp:32:12: warning: Member variable 'Submarine::AmbientNoise' is not initialized in the constructor. [uninitMemberVar] openssn/src/submarine.cpp:32:12: warning: Member variable 'Submarine::OwnShipNoise' is not initialized in the constructor. [uninitMemberVar] openssn/src/submarine.cpp:32:12: warning: Member variable 'Submarine::flowandambientnoise' is not initialized in the constructor. [uninitMemberVar] openssn/src/submarine.cpp:32:12: warning: Member variable 'Submarine::TotalNoise' is not initialized in the constructor. [uninitMemberVar] openssn/src/submarine.cpp:32:12: warning: Member variable 'Submarine::TargetNoise' is not initialized in the constructor. [uninitMemberVar] openssn/src/submarine.cpp:32:12: warning: Member variable 'Submarine::Gb' is not initialized in the constructor. [uninitMemberVar] openssn/src/submarine.cpp:32:12: warning: Member variable 'Submarine::Lbp' is not initialized in the constructor. [uninitMemberVar] openssn/src/submarine.cpp:32:12: warning: Member variable 'Submarine::NoiseFromSpeed' is not initialized in the constructor. [uninitMemberVar] openssn/src/submarine.cpp:32:12: warning: Member variable 'Submarine::BasisNoiseLevel' is not initialized in the constructor. [uninitMemberVar] openssn/src/submarine.cpp:32:12: warning: Member variable 'Submarine::value' is not initialized in the constructor. [uninitMemberVar] openssn/src/submarine.cpp:32:12: warning: Member variable 'Submarine::SeaState' is not initialized in the constructor. [uninitMemberVar] openssn/src/submarine.cpp:32:12: warning: Member variable 'Submarine::ShipType' is not initialized in the constructor. [uninitMemberVar] openssn/src/submarine.cpp:32:12: warning: Member variable 'Submarine::Friend' is not initialized in the constructor. [uninitMemberVar] openssn/src/submarine.cpp:32:12: warning: Member variable 'Submarine::DesiredDepth' is not initialized in the constructor. [uninitMemberVar] openssn/src/submarine.cpp:32:12: warning: Member variable 'Submarine::DesiredHeading' is not initialized in the constructor. [uninitMemberVar] openssn/src/submarine.cpp:32:12: warning: Member variable 'Submarine::BaseNoise' is not initialized in the constructor. [uninitMemberVar] openssn/src/submarine.cpp:32:12: warning: Member variable 'Submarine::origin_x' is not initialized in the constructor. [uninitMemberVar] openssn/src/submarine.cpp:32:12: warning: Member variable 'Submarine::origin_y' is not initialized in the constructor. [uninitMemberVar] openssn/src/submarine.cpp:105:18: style:inconclusive: Technically the member function 'Submarine::CheckNegSpeed' can be const. [functionConst] openssn/src/submarine.h:193:8: note: Technically the member function 'Submarine::CheckNegSpeed' can be const. openssn/src/submarine.cpp:105:18: note: Technically the member function 'Submarine::CheckNegSpeed' can be const. openssn/src/submarine.cpp:254:19: style:inconclusive: Technically the member function 'Submarine::DistanceToTarget' can be const. [functionConst] openssn/src/submarine.h:194:9: note: Technically the member function 'Submarine::DistanceToTarget' can be const. openssn/src/submarine.cpp:254:19: note: Technically the member function 'Submarine::DistanceToTarget' can be const. openssn/src/submarine.cpp:142:19: style:inconclusive: Technically the member function 'Submarine::BearingToTarget' can be const. [functionConst] openssn/src/submarine.h:195:9: note: Technically the member function 'Submarine::BearingToTarget' can be const. openssn/src/submarine.cpp:142:19: note: Technically the member function 'Submarine::BearingToTarget' can be const. openssn/src/submarine.cpp:196:19: style:inconclusive: Technically the member function 'Submarine::BearingToOrigin' can be const. [functionConst] openssn/src/submarine.h:196:16: note: Technically the member function 'Submarine::BearingToOrigin' can be const. openssn/src/submarine.cpp:196:19: note: Technically the member function 'Submarine::BearingToOrigin' can be const. openssn/src/submarine.cpp:1338:16: style:inconclusive: Technically the member function 'Submarine::Count_Torpedoes' can be const. [functionConst] openssn/src/submarine.h:247:13: note: Technically the member function 'Submarine::Count_Torpedoes' can be const. openssn/src/submarine.cpp:1338:16: note: Technically the member function 'Submarine::Count_Torpedoes' can be const. openssn/src/submarine.cpp:1357:16: style:inconclusive: Technically the member function 'Submarine::Count_Noisemakers' can be const. [functionConst] openssn/src/submarine.h:248:13: note: Technically the member function 'Submarine::Count_Noisemakers' can be const. openssn/src/submarine.cpp:1357:16: note: Technically the member function 'Submarine::Count_Noisemakers' can be const. openssn/src/submarine.cpp:1538:16: style:inconclusive: Technically the member function 'Submarine::Radio_Signal' can be const. [functionConst] openssn/src/submarine.h:252:13: note: Technically the member function 'Submarine::Radio_Signal' can be const. openssn/src/submarine.cpp:1538:16: note: Technically the member function 'Submarine::Radio_Signal' can be const. openssn/src/submarine.cpp:875:45: warning: Either the condition '!target' is redundant or there is possible null pointer dereference: target. [nullPointerRedundantCheck] openssn/src/submarine.cpp:891:13: note: Assuming that condition '!target' is not redundant openssn/src/submarine.cpp:875:45: note: Null pointer dereference openssn/src/submarine.cpp:459:24: style: C-style pointer casting [cstyleCast] openssn/src/submarine.cpp:485:21: style: C-style pointer casting [cstyleCast] openssn/src/submarine.cpp:519:24: style: C-style pointer casting [cstyleCast] openssn/src/submarine.cpp:540:23: style: C-style pointer casting [cstyleCast] openssn/src/submarine.cpp:551:24: style: C-style pointer casting [cstyleCast] openssn/src/submarine.cpp:566:18: style: C-style pointer casting [cstyleCast] openssn/src/submarine.cpp:572:24: style: C-style pointer casting [cstyleCast] openssn/src/submarine.cpp:635:21: style: C-style pointer casting [cstyleCast] openssn/src/submarine.cpp:653:26: style: C-style pointer casting [cstyleCast] openssn/src/submarine.cpp:469:38: style: Redundant assignment of 'my_target->contact_strength' to itself. [selfAssignment] openssn/src/submarine.cpp:472:38: style: Redundant assignment of 'my_target->contact_strength' to itself. [selfAssignment] openssn/src/submarine.cpp:1014:8: style: The scope of the variable 'change' can be reduced. [variableScope] openssn/src/submarine.cpp:1016:8: style: The scope of the variable 'can_hear_torpedo' can be reduced. [variableScope] openssn/src/submarine.cpp:1017:11: style: The scope of the variable 'distance' can be reduced. [variableScope] openssn/src/submarine.cpp:1018:8: style: The scope of the variable 'bearing' can be reduced. [variableScope] openssn/src/submarine.cpp:1020:8: style: The scope of the variable 'status' can be reduced. [variableScope] openssn/src/submarine.cpp:1020:16: style: The scope of the variable 'found' can be reduced. [variableScope] openssn/src/submarine.cpp:1021:8: style: The scope of the variable 'action' can be reduced. [variableScope] openssn/src/submarine.cpp:1289:11: style: The scope of the variable 'range' can be reduced. [variableScope] openssn/src/submarine.cpp:1290:11: style: The scope of the variable 'delta_depth' can be reduced. [variableScope] openssn/src/submarine.cpp:1445:17: style: The scope of the variable 'found' can be reduced. [variableScope] openssn/src/submarine.cpp:436:53: style:inconclusive: Function 'Add_Target' argument 2 names different: declaration 'contact_strength' definition 'signal_strength'. [funcArgNamesDifferent] openssn/src/submarine.h:225:50: note: Function 'Add_Target' argument 2 names different: declaration 'contact_strength' definition 'signal_strength'. openssn/src/submarine.cpp:436:53: note: Function 'Add_Target' argument 2 names different: declaration 'contact_strength' definition 'signal_strength'. openssn/src/submarine.cpp:685:33: style:inconclusive: Function 'Load_Class' argument 1 names different: declaration 'from_file' definition 'my_file'. [funcArgNamesDifferent] openssn/src/submarine.h:234:30: note: Function 'Load_Class' argument 1 names different: declaration 'from_file' definition 'my_file'. openssn/src/submarine.cpp:685:33: note: Function 'Load_Class' argument 1 names different: declaration 'from_file' definition 'my_file'. openssn/src/submarine.cpp:1338:43: style:inconclusive: Function 'Count_Torpedoes' argument 1 names different: declaration 'all_torpedoes' definition 'all_torp'. [funcArgNamesDifferent] openssn/src/submarine.h:247:40: note: Function 'Count_Torpedoes' argument 1 names different: declaration 'all_torpedoes' definition 'all_torp'. openssn/src/submarine.cpp:1338:43: note: Function 'Count_Torpedoes' argument 1 names different: declaration 'all_torpedoes' definition 'all_torp'. openssn/src/submarine.cpp:1441:52: style:inconclusive: Function 'Launch_Noisemaker' argument 1 names different: declaration 'all_torpedoes' definition 'all_noisemakers'. [funcArgNamesDifferent] openssn/src/submarine.h:250:49: note: Function 'Launch_Noisemaker' argument 1 names different: declaration 'all_torpedoes' definition 'all_noisemakers'. openssn/src/submarine.cpp:1441:52: note: Function 'Launch_Noisemaker' argument 1 names different: declaration 'all_torpedoes' definition 'all_noisemakers'. openssn/src/submarine.cpp:96:8: style: Local variable 'value' shadows outer variable [shadowVariable] openssn/src/submarine.h:168:8: note: Shadowed declaration openssn/src/submarine.cpp:96:8: note: Shadow variable openssn/src/submarine.cpp:439:37: style: Local variable 'last_target' shadows outer variable [shadowVariable] openssn/src/submarine.h:213:17: note: Shadowed declaration openssn/src/submarine.cpp:439:37: note: Shadow variable openssn/src/submarine.cpp:874:15: style: Local variable 'NauticalMiles' shadows outer variable [shadowVariable] openssn/src/submarine.h:156:8: note: Shadowed declaration openssn/src/submarine.cpp:874:15: note: Shadow variable openssn/src/submarine.cpp:875:15: style: Local variable 'HisPassiveSonarCrosssection' shadows outer variable [shadowVariable] openssn/src/submarine.h:157:8: note: Shadowed declaration openssn/src/submarine.cpp:875:15: note: Shadow variable openssn/src/submarine.cpp:876:15: style: Local variable 'EffectiveTargetSpeed' shadows outer variable [shadowVariable] openssn/src/submarine.h:158:8: note: Shadowed declaration openssn/src/submarine.cpp:876:15: note: Shadow variable openssn/src/submarine.cpp:877:15: style: Local variable 'AmbientNoise' shadows outer variable [shadowVariable] openssn/src/submarine.h:159:8: note: Shadowed declaration openssn/src/submarine.cpp:877:15: note: Shadow variable openssn/src/submarine.cpp:878:15: style: Local variable 'OwnShipNoise' shadows outer variable [shadowVariable] openssn/src/submarine.h:160:8: note: Shadowed declaration openssn/src/submarine.cpp:878:15: note: Shadow variable openssn/src/submarine.cpp:879:15: style: Local variable 'TotalNoise' shadows outer variable [shadowVariable] openssn/src/submarine.h:162:8: note: Shadowed declaration openssn/src/submarine.cpp:879:15: note: Shadow variable openssn/src/submarine.cpp:880:15: style: Local variable 'TargetNoise' shadows outer variable [shadowVariable] openssn/src/submarine.h:163:8: note: Shadowed declaration openssn/src/submarine.cpp:880:15: note: Shadow variable openssn/src/submarine.cpp:881:15: style: Local variable 'Gb' shadows outer variable [shadowVariable] openssn/src/submarine.h:164:8: note: Shadowed declaration openssn/src/submarine.cpp:881:15: note: Shadow variable openssn/src/submarine.cpp:882:15: style: Local variable 'Lbp' shadows outer variable [shadowVariable] openssn/src/submarine.h:165:8: note: Shadowed declaration openssn/src/submarine.cpp:882:15: note: Shadow variable openssn/src/submarine.cpp:883:15: style: Local variable 'NoiseFromSpeed' shadows outer variable [shadowVariable] openssn/src/submarine.h:166:8: note: Shadowed declaration openssn/src/submarine.cpp:883:15: note: Shadow variable openssn/src/submarine.cpp:884:15: style: Local variable 'BasisNoiseLevel' shadows outer variable [shadowVariable] openssn/src/submarine.h:167:8: note: Shadowed declaration openssn/src/submarine.cpp:884:15: note: Shadow variable openssn/src/submarine.cpp:885:15: style: Local variable 'value' shadows outer variable [shadowVariable] openssn/src/submarine.h:168:8: note: Shadowed declaration openssn/src/submarine.cpp:885:15: note: Shadow variable openssn/src/submarine.cpp:886:15: style: Local variable 'SeaState' shadows outer variable [shadowVariable] openssn/src/submarine.h:169:8: note: Shadowed declaration openssn/src/submarine.cpp:886:15: note: Shadow variable openssn/src/submarine.cpp:1019:15: style: Local variable 'target' shadows outer variable [shadowVariable] openssn/src/submarine.h:212:20: note: Shadowed declaration openssn/src/submarine.cpp:1019:15: note: Shadow variable openssn/src/submarine.cpp:142:46: style: Parameter 'Target' can be declared as pointer to const [constParameterPointer] openssn/src/submarine.cpp:196:46: style: Parameter 'Target' can be declared as pointer to const [constParameterPointer] openssn/src/submarine.cpp:254:47: style: Parameter 'Target' can be declared as pointer to const [constParameterPointer] openssn/src/submarine.cpp:277:37: style: Parameter 'Target' can be declared as pointer to const [constParameterPointer] openssn/src/submarine.cpp:524:42: style: Parameter 'old_sub' can be declared as pointer to const [constParameterPointer] openssn/src/submarine.cpp:561:38: style: Parameter 'a_sub' can be declared as pointer to const [constParameterPointer] openssn/src/submarine.cpp:617:13: style: Variable 'original' can be declared as pointer to const [constVariablePointer] openssn/src/submarine.cpp:710:11: style: Variable 'status' can be declared as pointer to const [constVariablePointer] openssn/src/submarine.cpp:1012:84: style: Parameter 'helicopters' can be declared as pointer to const [constParameterPointer] openssn/src/targetmotionanalysis.cpp:163:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_SWSURFACE [valueFlowBailoutIncompleteVar] openssn/src/targetmotionanalysis.cpp:0:0: debug: ValueFlow maximum iterations exceeded [valueFlowMaxIterations] openssn/src/targetmotionanalysis.cpp:25:23: warning: Member variable 'TargetMotionAnalysis::textcolor' is not initialized in the constructor. [uninitMemberVar] openssn/src/targetmotionanalysis.cpp:25:23: warning: Member variable 'TargetMotionAnalysis::black' is not initialized in the constructor. [uninitMemberVar] openssn/src/targetmotionanalysis.cpp:25:23: warning: Member variable 'TargetMotionAnalysis::white' is not initialized in the constructor. [uninitMemberVar] openssn/src/targetmotionanalysis.cpp:25:23: warning: Member variable 'TargetMotionAnalysis::red' is not initialized in the constructor. [uninitMemberVar] openssn/src/targetmotionanalysis.cpp:25:23: warning: Member variable 'TargetMotionAnalysis::green' is not initialized in the constructor. [uninitMemberVar] openssn/src/targetmotionanalysis.cpp:25:23: warning: Member variable 'TargetMotionAnalysis::yellow' is not initialized in the constructor. [uninitMemberVar] openssn/src/targetmotionanalysis.cpp:25:23: warning: Member variable 'TargetMotionAnalysis::mapcolor' is not initialized in the constructor. [uninitMemberVar] openssn/src/targetmotionanalysis.cpp:25:23: warning: Member variable 'TargetMotionAnalysis::our_heading' is not initialized in the constructor. [uninitMemberVar] openssn/src/targetmotionanalysis.cpp:25:23: warning: Member variable 'TargetMotionAnalysis::target_heading' is not initialized in the constructor. [uninitMemberVar] openssn/src/targetmotionanalysis.cpp:25:23: warning: Member variable 'TargetMotionAnalysis::our_speed' is not initialized in the constructor. [uninitMemberVar] openssn/src/targetmotionanalysis.cpp:25:23: warning: Member variable 'TargetMotionAnalysis::target_speed' is not initialized in the constructor. [uninitMemberVar] openssn/src/targetmotionanalysis.cpp:25:23: warning: Member variable 'TargetMotionAnalysis::GeoPlotScreen' is not initialized in the constructor. [uninitMemberVar] openssn/src/targetmotionanalysis.cpp:25:23: warning: Member variable 'TargetMotionAnalysis::trackerstate' is not initialized in the constructor. [uninitMemberVar] openssn/src/targetmotionanalysis.cpp:52:28: performance:inconclusive: Technically the member function 'TargetMotionAnalysis::DesignateContact' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/targetmotionanalysis.h:65:8: note: Technically the member function 'TargetMotionAnalysis::DesignateContact' can be static (but you may consider moving to unnamed namespace). openssn/src/targetmotionanalysis.cpp:52:28: note: Technically the member function 'TargetMotionAnalysis::DesignateContact' can be static (but you may consider moving to unnamed namespace). openssn/src/targetmotionanalysis.cpp:74:28: performance:inconclusive: Technically the member function 'TargetMotionAnalysis::CreateSpeedRuler' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/targetmotionanalysis.h:79:8: note: Technically the member function 'TargetMotionAnalysis::CreateSpeedRuler' can be static (but you may consider moving to unnamed namespace). openssn/src/targetmotionanalysis.cpp:74:28: note: Technically the member function 'TargetMotionAnalysis::CreateSpeedRuler' can be static (but you may consider moving to unnamed namespace). openssn/src/targetmotionanalysis.cpp:135:28: performance:inconclusive: Technically the member function 'TargetMotionAnalysis::BearingDevitaionPlot' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/targetmotionanalysis.h:84:8: note: Technically the member function 'TargetMotionAnalysis::BearingDevitaionPlot' can be static (but you may consider moving to unnamed namespace). openssn/src/targetmotionanalysis.cpp:135:28: note: Technically the member function 'TargetMotionAnalysis::BearingDevitaionPlot' can be static (but you may consider moving to unnamed namespace). openssn/src/targetmotionanalysis.cpp:180:28: style:inconclusive: Technically the member function 'TargetMotionAnalysis::PlotPixel' can be const. [functionConst] openssn/src/targetmotionanalysis.h:100:8: note: Technically the member function 'TargetMotionAnalysis::PlotPixel' can be const. openssn/src/targetmotionanalysis.cpp:180:28: note: Technically the member function 'TargetMotionAnalysis::PlotPixel' can be const. openssn/src/targetmotionanalysis.cpp:26:2: warning: Class 'TargetMotionAnalysis' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] openssn/src/targetmotionanalysis.cpp:26:2: warning: Class 'TargetMotionAnalysis' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] openssn/src/targetmotionanalysis.cpp:187:19: style: C-style pointer casting [cstyleCast] openssn/src/targetmotionanalysis.cpp:203:6: style: The scope of the variable 'x' can be reduced. [variableScope] openssn/src/targetmotionanalysis.cpp:203:9: style: The scope of the variable 'y' can be reduced. [variableScope] openssn/src/targetmotionanalysis.cpp:208:9: style: The scope of the variable 'var1' can be reduced. [variableScope] openssn/src/targetmotionanalysis.cpp:209:9: style: The scope of the variable 'destinationx' can be reduced. [variableScope] openssn/src/targetmotionanalysis.cpp:210:9: style: The scope of the variable 'destinationy' can be reduced. [variableScope] openssn/src/targetmotionanalysis.cpp:254:12: style: Local variable 'x' shadows outer variable [shadowVariable] openssn/src/targetmotionanalysis.cpp:240:26: note: Shadowed declaration openssn/src/targetmotionanalysis.cpp:254:12: note: Shadow variable openssn/src/targetmotionanalysis.cpp:264:12: style: Local variable 'y' shadows outer variable [shadowVariable] openssn/src/targetmotionanalysis.cpp:240:28: note: Shadowed declaration openssn/src/targetmotionanalysis.cpp:264:12: note: Shadow variable openssn/src/targetmotionanalysis.cpp:162:15: style: Variable 'screen' can be declared as pointer to const [constVariablePointer] openssn/src/towedarray.cpp:28:17: error: Array 'latitude_array[100]' accessed at index -9998, which is out of bounds. [negativeIndex] openssn/src/towedarray.cpp:29:18: error: Array 'longitude_array[100]' accessed at index -9998, which is out of bounds. [negativeIndex] openssn/src/towedarray.cpp:22:13: warning: Member variable 'TowedArray::latitude_array' is not initialized in the constructor. [uninitMemberVar] openssn/src/towedarray.cpp:22:13: warning: Member variable 'TowedArray::longitude_array' is not initialized in the constructor. [uninitMemberVar] openssn/src/towedarray.cpp:22:13: warning: Member variable 'TowedArray::winch' is not initialized in the constructor. [uninitMemberVar] openssn/src/towedarray.cpp:26:13: warning: Member variable 'TowedArray::winch' is not initialized in the constructor. [uninitMemberVar] openssn/src/towedarray.cpp:75:17: style:inconclusive: Technically the member function 'TowedArray::GetLength' can be const. [functionConst] openssn/src/towedarray.h:45:6: note: Technically the member function 'TowedArray::GetLength' can be const. openssn/src/towedarray.cpp:75:17: note: Technically the member function 'TowedArray::GetLength' can be const. openssn/src/towedarray.cpp:98:18: style:inconclusive: Technically the member function 'TowedArray::ReturnLatLon' can be const. [functionConst] openssn/src/towedarray.h:47:7: note: Technically the member function 'TowedArray::ReturnLatLon' can be const. openssn/src/towedarray.cpp:98:18: note: Technically the member function 'TowedArray::ReturnLatLon' can be const. openssn/src/towedarray.cpp:149:19: performance:inconclusive: Technically the member function 'TowedArray::CalcBearing' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/towedarray.h:51:8: note: Technically the member function 'TowedArray::CalcBearing' can be static (but you may consider moving to unnamed namespace). openssn/src/towedarray.cpp:149:19: note: Technically the member function 'TowedArray::CalcBearing' can be static (but you may consider moving to unnamed namespace). openssn/src/towedarray.cpp:27:29: style: Condition 'counter<100' is always true [knownConditionTrueFalse] openssn/src/towedarray.cpp:27:19: note: Assignment 'counter=0', assigned value is 0 openssn/src/towedarray.cpp:27:29: note: Condition 'counter<100' is always true openssn/src/towedarray.cpp:106:6: style: The scope of the variable 'head_index' can be reduced. [variableScope] openssn/src/towedarray.cpp:107:6: style: The scope of the variable 'tail_index' can be reduced. [variableScope] openssn/src/towedarray.cpp:134:9: style: The scope of the variable 'array_latitude' can be reduced. [variableScope] openssn/src/towedarray.cpp:134:25: style: The scope of the variable 'array_longitude' can be reduced. [variableScope] openssn/src/towedarray.cpp:134:42: style: The scope of the variable 'array_heading' can be reduced. [variableScope] openssn/src/towedarray.cpp:134:57: style: The scope of the variable 'actual_bearing' can be reduced. [variableScope] openssn/src/towedarray.cpp:36:35: style:inconclusive: Function 'RecordPos' argument 1 names different: declaration 'lat' definition 'latitude'. [funcArgNamesDifferent] openssn/src/towedarray.h:40:24: note: Function 'RecordPos' argument 1 names different: declaration 'lat' definition 'latitude'. openssn/src/towedarray.cpp:36:35: note: Function 'RecordPos' argument 1 names different: declaration 'lat' definition 'latitude'. openssn/src/towedarray.cpp:36:52: style:inconclusive: Function 'RecordPos' argument 2 names different: declaration 'lon' definition 'longitude'. [funcArgNamesDifferent] openssn/src/towedarray.h:40:36: note: Function 'RecordPos' argument 2 names different: declaration 'lon' definition 'longitude'. openssn/src/towedarray.cpp:36:52: note: Function 'RecordPos' argument 2 names different: declaration 'lon' definition 'longitude'. openssn/src/towedarray.cpp:98:39: style:inconclusive: Function 'ReturnLatLon' argument 1 names different: declaration 'latitude' definition 'rlat'. [funcArgNamesDifferent] openssn/src/towedarray.h:47:28: note: Function 'ReturnLatLon' argument 1 names different: declaration 'latitude' definition 'rlat'. openssn/src/towedarray.cpp:98:39: note: Function 'ReturnLatLon' argument 1 names different: declaration 'latitude' definition 'rlat'. openssn/src/towedarray.cpp:98:53: style:inconclusive: Function 'ReturnLatLon' argument 2 names different: declaration 'longitude' definition 'rlon'. [funcArgNamesDifferent] openssn/src/towedarray.h:47:46: note: Function 'ReturnLatLon' argument 2 names different: declaration 'longitude' definition 'rlon'. openssn/src/towedarray.cpp:98:53: note: Function 'ReturnLatLon' argument 2 names different: declaration 'longitude' definition 'rlon'. openssn/src/towedarray.cpp:132:42: style:inconclusive: Function 'BearingToTarget' argument 1 names different: declaration 'target_Latitude' definition 'target_latitude'. [funcArgNamesDifferent] openssn/src/towedarray.h:50:31: note: Function 'BearingToTarget' argument 1 names different: declaration 'target_Latitude' definition 'target_latitude'. openssn/src/towedarray.cpp:132:42: note: Function 'BearingToTarget' argument 1 names different: declaration 'target_Latitude' definition 'target_latitude'. openssn/src/main.cpp:2221:2: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] openssn/src/main.cpp:2283:21: style: The if condition is the same as the previous if condition [duplicateCondition] openssn/src/main.cpp:2277:21: note: First condition openssn/src/main.cpp:2283:21: note: Second condition openssn/src/main.cpp:2289:21: style: The if condition is the same as the previous if condition [duplicateCondition] openssn/src/main.cpp:2283:21: note: First condition openssn/src/main.cpp:2289:21: note: Second condition openssn/src/main.cpp:2590:21: style: The if condition is the same as the previous if condition [duplicateCondition] openssn/src/main.cpp:2584:21: note: First condition openssn/src/main.cpp:2590:21: note: Second condition openssn/src/main.cpp:2623:21: style: The if condition is the same as the previous if condition [duplicateCondition] openssn/src/main.cpp:2617:21: note: First condition openssn/src/main.cpp:2623:21: note: Second condition openssn/src/main.cpp:1376:7: style: Condition 'my_file' is always true [knownConditionTrueFalse] openssn/src/main.cpp:1216:19: warning: Either the condition 'ship_file' is redundant or there is possible null pointer dereference: ship_file. [nullPointerRedundantCheck] openssn/src/main.cpp:1217:9: note: Assuming that condition 'ship_file' is not redundant openssn/src/main.cpp:1216:19: note: Null pointer dereference openssn/src/main.cpp:1232:24: warning: Either the condition 'mission_name' is redundant or there is possible null pointer dereference: mission_name. [nullPointerRedundantCheck] openssn/src/main.cpp:1233:9: note: Assuming that condition 'mission_name' is not redundant openssn/src/main.cpp:1232:24: note: Null pointer dereference openssn/src/main.cpp:1826:24: warning: Either the condition '!observer' is redundant or there is possible null pointer dereference: observer. [nullPointerRedundantCheck] openssn/src/main.cpp:1841:13: note: Assuming that condition '!observer' is not redundant openssn/src/main.cpp:1826:24: note: Null pointer dereference openssn/src/main.cpp:1792:31: style: Floating-point cast causes loss of precision. [suspiciousFloatingPointCast] openssn/src/main.cpp:2981:9: style: Variable 'timer1' is reassigned a value before the old one has been used. [redundantAssignment] openssn/src/main.cpp:2950:9: note: timer1 is assigned openssn/src/main.cpp:2981:9: note: timer1 is overwritten openssn/src/main.cpp:2240:6: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2244:6: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2248:6: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2252:6: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2256:6: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2260:6: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2264:6: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2268:6: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2273:6: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2280:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2286:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2292:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2298:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2304:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2310:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2316:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2332:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2339:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2346:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2353:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2360:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2367:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2374:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2381:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2388:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2395:8: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2402:8: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2409:8: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2416:8: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2423:8: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2478:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2485:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2514:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2521:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2527:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2533:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2539:21: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2545:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2551:21: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2557:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2563:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2569:21: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2575:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2581:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2587:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2593:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2602:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2608:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2614:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2620:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2626:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2639:40: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2645:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2651:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2657:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2663:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2669:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2675:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2681:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:2687:7: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] openssn/src/main.cpp:1448:9: style: The scope of the variable 'buffer' can be reduced. [variableScope] openssn/src/main.cpp:1451:10: style: The scope of the variable 'range' can be reduced. [variableScope] openssn/src/main.cpp:1452:11: style: The scope of the variable 'bearing' can be reduced. [variableScope] openssn/src/main.cpp:1501:11: style: The scope of the variable 'index' can be reduced. [variableScope] openssn/src/main.cpp:1561:13: style: The scope of the variable 'fresh' can be reduced. [variableScope] openssn/src/main.cpp:2230:13: style: The scope of the variable 'y1' can be reduced. [variableScope] openssn/src/main.cpp:2230:17: style: The scope of the variable 'y2' can be reduced. [variableScope] openssn/src/main.cpp:2230:21: style: The scope of the variable 'x_checks_out' can be reduced. [variableScope] openssn/src/main.cpp:2231:13: style: The scope of the variable 'index' can be reduced. [variableScope] openssn/src/main.cpp:189:29: style:inconclusive: Function 'DirectionalPointer' argument 1 names different: declaration 'X' definition 'x'. [funcArgNamesDifferent] openssn/src/main.h:303:29: note: Function 'DirectionalPointer' argument 1 names different: declaration 'X' definition 'x'. openssn/src/main.cpp:189:29: note: Function 'DirectionalPointer' argument 1 names different: declaration 'X' definition 'x'. openssn/src/main.cpp:189:36: style:inconclusive: Function 'DirectionalPointer' argument 2 names different: declaration 'Y' definition 'y'. [funcArgNamesDifferent] openssn/src/main.h:303:36: note: Function 'DirectionalPointer' argument 2 names different: declaration 'Y' definition 'y'. openssn/src/main.cpp:189:36: note: Function 'DirectionalPointer' argument 2 names different: declaration 'Y' definition 'y'. openssn/src/main.cpp:189:43: style:inconclusive: Function 'DirectionalPointer' argument 3 names different: declaration 'Heading' definition 'heading'. [funcArgNamesDifferent] openssn/src/main.h:303:43: note: Function 'DirectionalPointer' argument 3 names different: declaration 'Heading' definition 'heading'. openssn/src/main.cpp:189:43: note: Function 'DirectionalPointer' argument 3 names different: declaration 'Heading' definition 'heading'. openssn/src/main.cpp:189:69: style:inconclusive: Function 'DirectionalPointer' argument 5 names different: declaration 'Color' definition 'color'. [funcArgNamesDifferent] openssn/src/main.h:303:70: note: Function 'DirectionalPointer' argument 5 names different: declaration 'Color' definition 'color'. openssn/src/main.cpp:189:69: note: Function 'DirectionalPointer' argument 5 names different: declaration 'Color' definition 'color'. openssn/src/main.cpp:204:21: style:inconclusive: Function 'LoadScreen' argument 1 names different: declaration 'screen_to_load' definition 'item'. [funcArgNamesDifferent] openssn/src/main.h:288:21: note: Function 'LoadScreen' argument 1 names different: declaration 'screen_to_load' definition 'item'. openssn/src/main.cpp:204:21: note: Function 'LoadScreen' argument 1 names different: declaration 'screen_to_load' definition 'item'. openssn/src/main.cpp:796:32: style:inconclusive: Function 'Add_Ship' argument 1 names different: declaration 'all_torpedoes' definition 'all_torp'. [funcArgNamesDifferent] openssn/src/main.h:316:32: note: Function 'Add_Ship' argument 1 names different: declaration 'all_torpedoes' definition 'all_torp'. openssn/src/main.cpp:796:32: note: Function 'Add_Ship' argument 1 names different: declaration 'all_torpedoes' definition 'all_torp'. openssn/src/main.cpp:796:53: style:inconclusive: Function 'Add_Ship' argument 2 names different: declaration 'new_torpedo' definition 'new_torp'. [funcArgNamesDifferent] openssn/src/main.h:316:58: note: Function 'Add_Ship' argument 2 names different: declaration 'new_torpedo' definition 'new_torp'. openssn/src/main.cpp:796:53: note: Function 'Add_Ship' argument 2 names different: declaration 'new_torpedo' definition 'new_torp'. openssn/src/main.cpp:1152:23: style:inconclusive: Function 'minimize360' argument 1 names different: declaration 'course' definition 'compass_bearing'. [funcArgNamesDifferent] openssn/src/main.h:267:23: note: Function 'minimize360' argument 1 names different: declaration 'course' definition 'compass_bearing'. openssn/src/main.cpp:1152:23: note: Function 'minimize360' argument 1 names different: declaration 'course' definition 'compass_bearing'. openssn/src/main.cpp:1162:23: style:inconclusive: Function 'maximize360' argument 1 names different: declaration 'course' definition 'compass_bearing'. [funcArgNamesDifferent] openssn/src/main.h:266:23: note: Function 'maximize360' argument 1 names different: declaration 'course' definition 'compass_bearing'. openssn/src/main.cpp:1162:23: note: Function 'maximize360' argument 1 names different: declaration 'course' definition 'compass_bearing'. openssn/src/main.cpp:1180:34: style:inconclusive: Function 'LatLonDifference' argument 1 names different: declaration 'observer' definition 'x'. [funcArgNamesDifferent] openssn/src/main.h:269:34: note: Function 'LatLonDifference' argument 1 names different: declaration 'observer' definition 'x'. openssn/src/main.cpp:1180:34: note: Function 'LatLonDifference' argument 1 names different: declaration 'observer' definition 'x'. openssn/src/main.cpp:1180:48: style:inconclusive: Function 'LatLonDifference' argument 2 names different: declaration 'target' definition 'y'. [funcArgNamesDifferent] openssn/src/main.h:269:55: note: Function 'LatLonDifference' argument 2 names different: declaration 'target' definition 'y'. openssn/src/main.cpp:1180:48: note: Function 'LatLonDifference' argument 2 names different: declaration 'target' definition 'y'. openssn/src/main.cpp:1498:46: style:inconclusive: Function 'Draw_Depth_Meter' argument 2 names different: declaration 'which_screen' definition 'screen_number'. [funcArgNamesDifferent] openssn/src/main.h:274:49: note: Function 'Draw_Depth_Meter' argument 2 names different: declaration 'which_screen' definition 'screen_number'. openssn/src/main.cpp:1498:46: note: Function 'Draw_Depth_Meter' argument 2 names different: declaration 'which_screen' definition 'screen_number'. openssn/src/main.cpp:2088:24: style:inconclusive: Function 'RandInt' argument 1 names different: declaration 'to' definition 'TO'. [funcArgNamesDifferent] openssn/src/main.h:301:24: note: Function 'RandInt' argument 1 names different: declaration 'to' definition 'TO'. openssn/src/main.cpp:2088:24: note: Function 'RandInt' argument 1 names different: declaration 'to' definition 'TO'. openssn/src/main.cpp:1450:10: style: Local variable 'fnt' shadows outer function [shadowFunction] openssn/src/main.h:201:7: note: Shadowed declaration openssn/src/main.cpp:1450:10: note: Shadow variable openssn/src/main.cpp:2008:11: style: Local variable 'fnt' shadows outer function [shadowFunction] openssn/src/main.h:201:7: note: Shadowed declaration openssn/src/main.cpp:2008:11: note: Shadow variable openssn/src/main.cpp:2943:8: style: Local variable 'fnt' shadows outer function [shadowFunction] openssn/src/main.h:201:7: note: Shadowed declaration openssn/src/main.cpp:2943:8: note: Shadow variable openssn/src/main.cpp:2944:15: style: Local variable 'fnt2' shadows outer function [shadowFunction] openssn/src/main.h:202:7: note: Shadowed declaration openssn/src/main.cpp:2944:15: note: Shadow variable openssn/src/main.cpp:2991:13: style: Local variable 'rectangle' shadows outer variable [shadowVariable] openssn/src/main.cpp:2961:11: note: Shadowed declaration openssn/src/main.cpp:2991:13: note: Shadow variable openssn/src/main.cpp:2228:28: style: Parameter 'event' can be declared as reference to const [constParameterReference] openssn/src/main.cpp:822:61: style: Parameter 'old_torpedo' can be declared as pointer to const [constParameterPointer] openssn/src/main.cpp:882:72: style: Parameter 'old_helicopter' can be declared as pointer to const [constParameterPointer] openssn/src/main.cpp:1180:34: style: Parameter 'x' can be declared as pointer to const [constParameterPointer] openssn/src/main.cpp:1180:48: style: Parameter 'y' can be declared as pointer to const [constParameterPointer] openssn/src/main.cpp:1202:20: style: Variable 'status' can be declared as pointer to const [constVariablePointer] openssn/src/main.cpp:1558:79: style: Parameter 'current_target' can be declared as pointer to const [constParameterPointer] openssn/src/main.cpp:1789:73: style: Parameter 'target' can be declared as pointer to const [constParameterPointer] openssn/src/main.cpp:2185:41: style: Parameter 'param' can be declared as pointer to const. However it seems that 'timerfunc' is a callback function, if 'param' is declared with const you might also need to cast function pointer(s). [constParameterCallback] openssn/src/main.cpp:3683:53: note: You might need to cast the function pointer here openssn/src/main.cpp:2185:41: note: Parameter 'param' can be declared as pointer to const openssn/src/main.cpp:2218:40: style: Parameter 'param' can be declared as pointer to const. However it seems that 'TmaTimer' is a callback function, if 'param' is declared with const you might also need to cast function pointer(s). [constParameterCallback] openssn/src/main.cpp:3684:55: note: You might need to cast the function pointer here openssn/src/main.cpp:2218:40: note: Parameter 'param' can be declared as pointer to const openssn/src/main.cpp:2229:16: style: Unused variable: textline [unusedVariable] diff: head openssn/src/boatpositionlog.cpp:57:23: style:inconclusive: Technically the member function 'BoatPositionLog::GetLogItem' can be const. [functionConst] openssn/src/boatpositionlog.h:41:8: note: Technically the member function 'BoatPositionLog::GetLogItem' can be const. openssn/src/boatpositionlog.cpp:57:23: note: Technically the member function 'BoatPositionLog::GetLogItem' can be const. 2.17.0 openssn/src/boatpositionlog.h:41:8: style:inconclusive: Technically the member function 'BoatPositionLog::GetLogItem' can be const. [functionConst] openssn/src/boatpositionlog.cpp:57:23: note: Technically the member function 'BoatPositionLog::GetLogItem' can be const. openssn/src/boatpositionlog.h:41:8: note: Technically the member function 'BoatPositionLog::GetLogItem' can be const. head openssn/src/coord.cpp:95:13: performance:inconclusive: Technically the member function 'Coord::LatLonPercent' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/coord.h:53:7: note: Technically the member function 'Coord::LatLonPercent' can be static (but you may consider moving to unnamed namespace). openssn/src/coord.cpp:95:13: note: Technically the member function 'Coord::LatLonPercent' can be static (but you may consider moving to unnamed namespace). 2.17.0 openssn/src/coord.h:53:7: performance:inconclusive: Technically the member function 'Coord::LatLonPercent' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/coord.cpp:95:13: note: Technically the member function 'Coord::LatLonPercent' can be static (but you may consider moving to unnamed namespace). openssn/src/coord.h:53:7: note: Technically the member function 'Coord::LatLonPercent' can be static (but you may consider moving to unnamed namespace). head openssn/src/dfont.cpp:40:15: performance:inconclusive: Technically the member function 'DFont::GetPixel' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/dfont.h:35:10: note: Technically the member function 'DFont::GetPixel' can be static (but you may consider moving to unnamed namespace). openssn/src/dfont.cpp:40:15: note: Technically the member function 'DFont::GetPixel' can be static (but you may consider moving to unnamed namespace). 2.17.0 openssn/src/dfont.h:35:10: performance:inconclusive: Technically the member function 'DFont::GetPixel' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/dfont.cpp:40:15: note: Technically the member function 'DFont::GetPixel' can be static (but you may consider moving to unnamed namespace). openssn/src/dfont.h:35:10: note: Technically the member function 'DFont::GetPixel' can be static (but you may consider moving to unnamed namespace). head openssn/src/dstack.cpp:38:13: style:inconclusive: Technically the member function 'DStack::num_items' can be const. [functionConst] openssn/src/dstack.h:30:9: note: Technically the member function 'DStack::num_items' can be const. openssn/src/dstack.cpp:38:13: note: Technically the member function 'DStack::num_items' can be const. head openssn/src/dstack.cpp:85:13: style:inconclusive: Technically the member function 'DStack::empty' can be const. [functionConst] openssn/src/dstack.h:32:9: note: Technically the member function 'DStack::empty' can be const. openssn/src/dstack.cpp:85:13: note: Technically the member function 'DStack::empty' can be const. 2.17.0 openssn/src/dstack.h:30:9: style:inconclusive: Technically the member function 'DStack::num_items' can be const. [functionConst] openssn/src/dstack.cpp:38:13: note: Technically the member function 'DStack::num_items' can be const. openssn/src/dstack.h:30:9: note: Technically the member function 'DStack::num_items' can be const. 2.17.0 openssn/src/dstack.h:32:9: style:inconclusive: Technically the member function 'DStack::empty' can be const. [functionConst] openssn/src/dstack.cpp:85:13: note: Technically the member function 'DStack::empty' can be const. openssn/src/dstack.h:32:9: note: Technically the member function 'DStack::empty' can be const. head openssn/src/esm.cpp:475:11: style:inconclusive: Technically the member function 'Esm::DPixel' can be const. [functionConst] openssn/src/esm.h:71:7: note: Technically the member function 'Esm::DPixel' can be const. openssn/src/esm.cpp:475:11: note: Technically the member function 'Esm::DPixel' can be const. 2.17.0 openssn/src/esm.h:71:7: style:inconclusive: Technically the member function 'Esm::DPixel' can be const. [functionConst] openssn/src/esm.cpp:475:11: note: Technically the member function 'Esm::DPixel' can be const. openssn/src/esm.h:71:7: note: Technically the member function 'Esm::DPixel' can be const. head openssn/src/gameclock.cpp:60:17: style:inconclusive: Technically the member function 'GameClock::GetTime' can be const. [functionConst] openssn/src/gameclock.h:30:8: note: Technically the member function 'GameClock::GetTime' can be const. openssn/src/gameclock.cpp:60:17: note: Technically the member function 'GameClock::GetTime' can be const. head openssn/src/gameclock.cpp:67:16: style:inconclusive: Technically the member function 'GameClock::GetTick' can be const. [functionConst] openssn/src/gameclock.h:31:7: note: Technically the member function 'GameClock::GetTick' can be const. openssn/src/gameclock.cpp:67:16: note: Technically the member function 'GameClock::GetTick' can be const. 2.17.0 openssn/src/gameclock.h:30:8: style:inconclusive: Technically the member function 'GameClock::GetTime' can be const. [functionConst] openssn/src/gameclock.cpp:60:17: note: Technically the member function 'GameClock::GetTime' can be const. openssn/src/gameclock.h:30:8: note: Technically the member function 'GameClock::GetTime' can be const. 2.17.0 openssn/src/gameclock.h:31:7: style:inconclusive: Technically the member function 'GameClock::GetTick' can be const. [functionConst] openssn/src/gameclock.cpp:67:16: note: Technically the member function 'GameClock::GetTick' can be const. openssn/src/gameclock.h:31:7: note: Technically the member function 'GameClock::GetTick' can be const. head openssn/src/helicopter.cpp:106:17: style:inconclusive: Technically the member function 'Helicopter::Check_Status' can be const. [functionConst] openssn/src/helicopter.h:63:8: note: Technically the member function 'Helicopter::Check_Status' can be const. openssn/src/helicopter.cpp:106:17: note: Technically the member function 'Helicopter::Check_Status' can be const. head openssn/src/helicopter.cpp:45:18: performance:inconclusive: Technically the member function 'Helicopter::Cleanup' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/helicopter.h:57:9: note: Technically the member function 'Helicopter::Cleanup' can be static (but you may consider moving to unnamed namespace). openssn/src/helicopter.cpp:45:18: note: Technically the member function 'Helicopter::Cleanup' can be static (but you may consider moving to unnamed namespace). head openssn/src/helicopter.cpp:484:20: style:inconclusive: Technically the member function 'Helicopter::Distance_To_Destination' can be const. [functionConst] openssn/src/helicopter.h:65:11: note: Technically the member function 'Helicopter::Distance_To_Destination' can be const. openssn/src/helicopter.cpp:484:20: note: Technically the member function 'Helicopter::Distance_To_Destination' can be const. head openssn/src/helicopter.cpp:504:20: style:inconclusive: Technically the member function 'Helicopter::Distance_To_Target' can be const. [functionConst] openssn/src/helicopter.h:66:11: note: Technically the member function 'Helicopter::Distance_To_Target' can be const. openssn/src/helicopter.cpp:504:20: note: Technically the member function 'Helicopter::Distance_To_Target' can be const. head openssn/src/helicopter.cpp:86:17: performance:inconclusive: Technically the member function 'Helicopter::Load_Mission' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/helicopter.h:62:8: note: Technically the member function 'Helicopter::Load_Mission' can be static (but you may consider moving to unnamed namespace). openssn/src/helicopter.cpp:86:17: note: Technically the member function 'Helicopter::Load_Mission' can be static (but you may consider moving to unnamed namespace). 2.17.0 openssn/src/helicopter.h:57:9: performance:inconclusive: Technically the member function 'Helicopter::Cleanup' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/helicopter.cpp:45:18: note: Technically the member function 'Helicopter::Cleanup' can be static (but you may consider moving to unnamed namespace). openssn/src/helicopter.h:57:9: note: Technically the member function 'Helicopter::Cleanup' can be static (but you may consider moving to unnamed namespace). 2.17.0 openssn/src/helicopter.h:62:8: performance:inconclusive: Technically the member function 'Helicopter::Load_Mission' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/helicopter.cpp:86:17: note: Technically the member function 'Helicopter::Load_Mission' can be static (but you may consider moving to unnamed namespace). openssn/src/helicopter.h:62:8: note: Technically the member function 'Helicopter::Load_Mission' can be static (but you may consider moving to unnamed namespace). 2.17.0 openssn/src/helicopter.h:63:8: style:inconclusive: Technically the member function 'Helicopter::Check_Status' can be const. [functionConst] openssn/src/helicopter.cpp:106:17: note: Technically the member function 'Helicopter::Check_Status' can be const. openssn/src/helicopter.h:63:8: note: Technically the member function 'Helicopter::Check_Status' can be const. 2.17.0 openssn/src/helicopter.h:65:11: style:inconclusive: Technically the member function 'Helicopter::Distance_To_Destination' can be const. [functionConst] openssn/src/helicopter.cpp:484:20: note: Technically the member function 'Helicopter::Distance_To_Destination' can be const. openssn/src/helicopter.h:65:11: note: Technically the member function 'Helicopter::Distance_To_Destination' can be const. 2.17.0 openssn/src/helicopter.h:66:11: style:inconclusive: Technically the member function 'Helicopter::Distance_To_Target' can be const. [functionConst] openssn/src/helicopter.cpp:504:20: note: Technically the member function 'Helicopter::Distance_To_Target' can be const. openssn/src/helicopter.h:66:11: note: Technically the member function 'Helicopter::Distance_To_Target' can be const. head openssn/src/map.cpp:108:10: style:inconclusive: Technically the member function 'MAP::Next_Up' can be const. [functionConst] openssn/src/map.h:42:7: note: Technically the member function 'MAP::Next_Up' can be const. openssn/src/map.cpp:108:10: note: Technically the member function 'MAP::Next_Up' can be const. head openssn/src/map.cpp:131:10: style:inconclusive: Technically the member function 'MAP::Next_Down' can be const. [functionConst] openssn/src/map.h:43:7: note: Technically the member function 'MAP::Next_Down' can be const. openssn/src/map.cpp:131:10: note: Technically the member function 'MAP::Next_Down' can be const. head openssn/src/map.cpp:59:10: performance:inconclusive: Technically the member function 'MAP::Get_Ocean_Depth' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/map.h:40:7: note: Technically the member function 'MAP::Get_Ocean_Depth' can be static (but you may consider moving to unnamed namespace). openssn/src/map.cpp:59:10: note: Technically the member function 'MAP::Get_Ocean_Depth' can be static (but you may consider moving to unnamed namespace). head openssn/src/map.cpp:69:10: style:inconclusive: Technically the member function 'MAP::Thermals_Between' can be const. [functionConst] openssn/src/map.h:41:7: note: Technically the member function 'MAP::Thermals_Between' can be const. openssn/src/map.cpp:69:10: note: Technically the member function 'MAP::Thermals_Between' can be const. 2.17.0 openssn/src/map.h:40:7: performance:inconclusive: Technically the member function 'MAP::Get_Ocean_Depth' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/map.cpp:59:10: note: Technically the member function 'MAP::Get_Ocean_Depth' can be static (but you may consider moving to unnamed namespace). openssn/src/map.h:40:7: note: Technically the member function 'MAP::Get_Ocean_Depth' can be static (but you may consider moving to unnamed namespace). 2.17.0 openssn/src/map.h:41:7: style:inconclusive: Technically the member function 'MAP::Thermals_Between' can be const. [functionConst] openssn/src/map.cpp:69:10: note: Technically the member function 'MAP::Thermals_Between' can be const. openssn/src/map.h:41:7: note: Technically the member function 'MAP::Thermals_Between' can be const. 2.17.0 openssn/src/map.h:42:7: style:inconclusive: Technically the member function 'MAP::Next_Up' can be const. [functionConst] openssn/src/map.cpp:108:10: note: Technically the member function 'MAP::Next_Up' can be const. openssn/src/map.h:42:7: note: Technically the member function 'MAP::Next_Up' can be const. 2.17.0 openssn/src/map.h:43:7: style:inconclusive: Technically the member function 'MAP::Next_Down' can be const. [functionConst] openssn/src/map.cpp:131:10: note: Technically the member function 'MAP::Next_Down' can be const. openssn/src/map.h:43:7: note: Technically the member function 'MAP::Next_Down' can be const. head openssn/src/radar.cpp:1158:12: performance:inconclusive: Technically the member function 'Radar::DeltaBearing' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/radar.h:83:6: note: Technically the member function 'Radar::DeltaBearing' can be static (but you may consider moving to unnamed namespace). openssn/src/radar.cpp:1158:12: note: Technically the member function 'Radar::DeltaBearing' can be static (but you may consider moving to unnamed namespace). head openssn/src/radar.cpp:1180:13: style:inconclusive: Technically the member function 'Radar::ReciprocalBearing' can be const. [functionConst] openssn/src/radar.h:84:6: note: Technically the member function 'Radar::ReciprocalBearing' can be const. openssn/src/radar.cpp:1180:13: note: Technically the member function 'Radar::ReciprocalBearing' can be const. head openssn/src/radar.cpp:1192:13: style:inconclusive: Technically the member function 'Radar::DrawPixel' can be const. [functionConst] openssn/src/radar.h:86:7: note: Technically the member function 'Radar::DrawPixel' can be const. openssn/src/radar.cpp:1192:13: note: Technically the member function 'Radar::DrawPixel' can be const. 2.17.0 openssn/src/radar.h:83:6: performance:inconclusive: Technically the member function 'Radar::DeltaBearing' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/radar.cpp:1158:12: note: Technically the member function 'Radar::DeltaBearing' can be static (but you may consider moving to unnamed namespace). openssn/src/radar.h:83:6: note: Technically the member function 'Radar::DeltaBearing' can be static (but you may consider moving to unnamed namespace). 2.17.0 openssn/src/radar.h:84:6: style:inconclusive: Technically the member function 'Radar::ReciprocalBearing' can be const. [functionConst] openssn/src/radar.cpp:1180:13: note: Technically the member function 'Radar::ReciprocalBearing' can be const. openssn/src/radar.h:84:6: note: Technically the member function 'Radar::ReciprocalBearing' can be const. 2.17.0 openssn/src/radar.h:86:7: style:inconclusive: Technically the member function 'Radar::DrawPixel' can be const. [functionConst] openssn/src/radar.cpp:1192:13: note: Technically the member function 'Radar::DrawPixel' can be const. openssn/src/radar.h:86:7: note: Technically the member function 'Radar::DrawPixel' can be const. head openssn/src/sonar.cpp:1113:14: style:inconclusive: Technically the member function 'AnBqq5::GetNorthCenterState' can be const. [functionConst] openssn/src/sonar.h:129:7: note: Technically the member function 'AnBqq5::GetNorthCenterState' can be const. openssn/src/sonar.cpp:1113:14: note: Technically the member function 'AnBqq5::GetNorthCenterState' can be const. head openssn/src/sonar.cpp:1168:13: performance:inconclusive: Technically the member function 'AnBqq5::RandInt' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/sonar.h:140:6: note: Technically the member function 'AnBqq5::RandInt' can be static (but you may consider moving to unnamed namespace). openssn/src/sonar.cpp:1168:13: note: Technically the member function 'AnBqq5::RandInt' can be static (but you may consider moving to unnamed namespace). head openssn/src/sonar.cpp:1173:13: performance:inconclusive: Technically the member function 'AnBqq5::ReciprocalBearing' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/sonar.h:142:6: note: Technically the member function 'AnBqq5::ReciprocalBearing' can be static (but you may consider moving to unnamed namespace). openssn/src/sonar.cpp:1173:13: note: Technically the member function 'AnBqq5::ReciprocalBearing' can be static (but you may consider moving to unnamed namespace). head openssn/src/sonar.cpp:85:21: style:inconclusive: Technically the member function 'AnBqq5::DPixel' can be const. [functionConst] openssn/src/sonar.h:42:14: note: Technically the member function 'AnBqq5::DPixel' can be const. openssn/src/sonar.cpp:85:21: note: Technically the member function 'AnBqq5::DPixel' can be const. 2.17.0 openssn/src/sonar.h:129:7: style:inconclusive: Technically the member function 'AnBqq5::GetNorthCenterState' can be const. [functionConst] openssn/src/sonar.cpp:1113:14: note: Technically the member function 'AnBqq5::GetNorthCenterState' can be const. openssn/src/sonar.h:129:7: note: Technically the member function 'AnBqq5::GetNorthCenterState' can be const. 2.17.0 openssn/src/sonar.h:140:6: performance:inconclusive: Technically the member function 'AnBqq5::RandInt' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/sonar.cpp:1168:13: note: Technically the member function 'AnBqq5::RandInt' can be static (but you may consider moving to unnamed namespace). openssn/src/sonar.h:140:6: note: Technically the member function 'AnBqq5::RandInt' can be static (but you may consider moving to unnamed namespace). 2.17.0 openssn/src/sonar.h:142:6: performance:inconclusive: Technically the member function 'AnBqq5::ReciprocalBearing' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/sonar.cpp:1173:13: note: Technically the member function 'AnBqq5::ReciprocalBearing' can be static (but you may consider moving to unnamed namespace). openssn/src/sonar.h:142:6: note: Technically the member function 'AnBqq5::ReciprocalBearing' can be static (but you may consider moving to unnamed namespace). 2.17.0 openssn/src/sonar.h:42:14: style:inconclusive: Technically the member function 'AnBqq5::DPixel' can be const. [functionConst] openssn/src/sonar.cpp:85:21: note: Technically the member function 'AnBqq5::DPixel' can be const. openssn/src/sonar.h:42:14: note: Technically the member function 'AnBqq5::DPixel' can be const. head openssn/src/stack.cpp:67:12: style:inconclusive: Technically the member function 'Stack::GetEvent' can be const. [functionConst] openssn/src/stack.h:56:6: note: Technically the member function 'Stack::GetEvent' can be const. openssn/src/stack.cpp:67:12: note: Technically the member function 'Stack::GetEvent' can be const. head openssn/src/stack.cpp:90:12: style:inconclusive: Technically the member function 'Stack::GetCount' can be const. [functionConst] openssn/src/stack.h:54:7: note: Technically the member function 'Stack::GetCount' can be const. openssn/src/stack.cpp:90:12: note: Technically the member function 'Stack::GetCount' can be const. 2.17.0 openssn/src/stack.h:54:7: style:inconclusive: Technically the member function 'Stack::GetCount' can be const. [functionConst] openssn/src/stack.cpp:90:12: note: Technically the member function 'Stack::GetCount' can be const. openssn/src/stack.h:54:7: note: Technically the member function 'Stack::GetCount' can be const. 2.17.0 openssn/src/stack.h:56:6: style:inconclusive: Technically the member function 'Stack::GetEvent' can be const. [functionConst] openssn/src/stack.cpp:67:12: note: Technically the member function 'Stack::GetEvent' can be const. openssn/src/stack.h:56:6: note: Technically the member function 'Stack::GetEvent' can be const. head openssn/src/submarine.cpp:105:18: style:inconclusive: Technically the member function 'Submarine::CheckNegSpeed' can be const. [functionConst] openssn/src/submarine.h:193:8: note: Technically the member function 'Submarine::CheckNegSpeed' can be const. openssn/src/submarine.cpp:105:18: note: Technically the member function 'Submarine::CheckNegSpeed' can be const. head openssn/src/submarine.cpp:1338:16: style:inconclusive: Technically the member function 'Submarine::Count_Torpedoes' can be const. [functionConst] openssn/src/submarine.h:247:13: note: Technically the member function 'Submarine::Count_Torpedoes' can be const. openssn/src/submarine.cpp:1338:16: note: Technically the member function 'Submarine::Count_Torpedoes' can be const. head openssn/src/submarine.cpp:1357:16: style:inconclusive: Technically the member function 'Submarine::Count_Noisemakers' can be const. [functionConst] openssn/src/submarine.h:248:13: note: Technically the member function 'Submarine::Count_Noisemakers' can be const. openssn/src/submarine.cpp:1357:16: note: Technically the member function 'Submarine::Count_Noisemakers' can be const. head openssn/src/submarine.cpp:142:19: style:inconclusive: Technically the member function 'Submarine::BearingToTarget' can be const. [functionConst] openssn/src/submarine.h:195:9: note: Technically the member function 'Submarine::BearingToTarget' can be const. openssn/src/submarine.cpp:142:19: note: Technically the member function 'Submarine::BearingToTarget' can be const. head openssn/src/submarine.cpp:1538:16: style:inconclusive: Technically the member function 'Submarine::Radio_Signal' can be const. [functionConst] openssn/src/submarine.h:252:13: note: Technically the member function 'Submarine::Radio_Signal' can be const. openssn/src/submarine.cpp:1538:16: note: Technically the member function 'Submarine::Radio_Signal' can be const. head openssn/src/submarine.cpp:196:19: style:inconclusive: Technically the member function 'Submarine::BearingToOrigin' can be const. [functionConst] openssn/src/submarine.h:196:16: note: Technically the member function 'Submarine::BearingToOrigin' can be const. openssn/src/submarine.cpp:196:19: note: Technically the member function 'Submarine::BearingToOrigin' can be const. head openssn/src/submarine.cpp:254:19: style:inconclusive: Technically the member function 'Submarine::DistanceToTarget' can be const. [functionConst] openssn/src/submarine.h:194:9: note: Technically the member function 'Submarine::DistanceToTarget' can be const. openssn/src/submarine.cpp:254:19: note: Technically the member function 'Submarine::DistanceToTarget' can be const. 2.17.0 openssn/src/submarine.h:193:8: style:inconclusive: Technically the member function 'Submarine::CheckNegSpeed' can be const. [functionConst] openssn/src/submarine.cpp:105:18: note: Technically the member function 'Submarine::CheckNegSpeed' can be const. openssn/src/submarine.h:193:8: note: Technically the member function 'Submarine::CheckNegSpeed' can be const. 2.17.0 openssn/src/submarine.h:194:9: style:inconclusive: Technically the member function 'Submarine::DistanceToTarget' can be const. [functionConst] openssn/src/submarine.cpp:254:19: note: Technically the member function 'Submarine::DistanceToTarget' can be const. openssn/src/submarine.h:194:9: note: Technically the member function 'Submarine::DistanceToTarget' can be const. 2.17.0 openssn/src/submarine.h:195:9: style:inconclusive: Technically the member function 'Submarine::BearingToTarget' can be const. [functionConst] openssn/src/submarine.cpp:142:19: note: Technically the member function 'Submarine::BearingToTarget' can be const. openssn/src/submarine.h:195:9: note: Technically the member function 'Submarine::BearingToTarget' can be const. 2.17.0 openssn/src/submarine.h:196:16: style:inconclusive: Technically the member function 'Submarine::BearingToOrigin' can be const. [functionConst] openssn/src/submarine.cpp:196:19: note: Technically the member function 'Submarine::BearingToOrigin' can be const. openssn/src/submarine.h:196:16: note: Technically the member function 'Submarine::BearingToOrigin' can be const. 2.17.0 openssn/src/submarine.h:247:13: style:inconclusive: Technically the member function 'Submarine::Count_Torpedoes' can be const. [functionConst] openssn/src/submarine.cpp:1338:16: note: Technically the member function 'Submarine::Count_Torpedoes' can be const. openssn/src/submarine.h:247:13: note: Technically the member function 'Submarine::Count_Torpedoes' can be const. 2.17.0 openssn/src/submarine.h:248:13: style:inconclusive: Technically the member function 'Submarine::Count_Noisemakers' can be const. [functionConst] openssn/src/submarine.cpp:1357:16: note: Technically the member function 'Submarine::Count_Noisemakers' can be const. openssn/src/submarine.h:248:13: note: Technically the member function 'Submarine::Count_Noisemakers' can be const. 2.17.0 openssn/src/submarine.h:252:13: style:inconclusive: Technically the member function 'Submarine::Radio_Signal' can be const. [functionConst] openssn/src/submarine.cpp:1538:16: note: Technically the member function 'Submarine::Radio_Signal' can be const. openssn/src/submarine.h:252:13: note: Technically the member function 'Submarine::Radio_Signal' can be const. head openssn/src/targetmotionanalysis.cpp:135:28: performance:inconclusive: Technically the member function 'TargetMotionAnalysis::BearingDevitaionPlot' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/targetmotionanalysis.h:84:8: note: Technically the member function 'TargetMotionAnalysis::BearingDevitaionPlot' can be static (but you may consider moving to unnamed namespace). openssn/src/targetmotionanalysis.cpp:135:28: note: Technically the member function 'TargetMotionAnalysis::BearingDevitaionPlot' can be static (but you may consider moving to unnamed namespace). head openssn/src/targetmotionanalysis.cpp:180:28: style:inconclusive: Technically the member function 'TargetMotionAnalysis::PlotPixel' can be const. [functionConst] openssn/src/targetmotionanalysis.h:100:8: note: Technically the member function 'TargetMotionAnalysis::PlotPixel' can be const. openssn/src/targetmotionanalysis.cpp:180:28: note: Technically the member function 'TargetMotionAnalysis::PlotPixel' can be const. head openssn/src/targetmotionanalysis.cpp:52:28: performance:inconclusive: Technically the member function 'TargetMotionAnalysis::DesignateContact' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/targetmotionanalysis.h:65:8: note: Technically the member function 'TargetMotionAnalysis::DesignateContact' can be static (but you may consider moving to unnamed namespace). openssn/src/targetmotionanalysis.cpp:52:28: note: Technically the member function 'TargetMotionAnalysis::DesignateContact' can be static (but you may consider moving to unnamed namespace). head openssn/src/targetmotionanalysis.cpp:74:28: performance:inconclusive: Technically the member function 'TargetMotionAnalysis::CreateSpeedRuler' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/targetmotionanalysis.h:79:8: note: Technically the member function 'TargetMotionAnalysis::CreateSpeedRuler' can be static (but you may consider moving to unnamed namespace). openssn/src/targetmotionanalysis.cpp:74:28: note: Technically the member function 'TargetMotionAnalysis::CreateSpeedRuler' can be static (but you may consider moving to unnamed namespace). 2.17.0 openssn/src/targetmotionanalysis.h:100:8: style:inconclusive: Technically the member function 'TargetMotionAnalysis::PlotPixel' can be const. [functionConst] openssn/src/targetmotionanalysis.cpp:180:28: note: Technically the member function 'TargetMotionAnalysis::PlotPixel' can be const. openssn/src/targetmotionanalysis.h:100:8: note: Technically the member function 'TargetMotionAnalysis::PlotPixel' can be const. 2.17.0 openssn/src/targetmotionanalysis.h:65:8: performance:inconclusive: Technically the member function 'TargetMotionAnalysis::DesignateContact' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/targetmotionanalysis.cpp:52:28: note: Technically the member function 'TargetMotionAnalysis::DesignateContact' can be static (but you may consider moving to unnamed namespace). openssn/src/targetmotionanalysis.h:65:8: note: Technically the member function 'TargetMotionAnalysis::DesignateContact' can be static (but you may consider moving to unnamed namespace). 2.17.0 openssn/src/targetmotionanalysis.h:79:8: performance:inconclusive: Technically the member function 'TargetMotionAnalysis::CreateSpeedRuler' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/targetmotionanalysis.cpp:74:28: note: Technically the member function 'TargetMotionAnalysis::CreateSpeedRuler' can be static (but you may consider moving to unnamed namespace). openssn/src/targetmotionanalysis.h:79:8: note: Technically the member function 'TargetMotionAnalysis::CreateSpeedRuler' can be static (but you may consider moving to unnamed namespace). 2.17.0 openssn/src/targetmotionanalysis.h:84:8: performance:inconclusive: Technically the member function 'TargetMotionAnalysis::BearingDevitaionPlot' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/targetmotionanalysis.cpp:135:28: note: Technically the member function 'TargetMotionAnalysis::BearingDevitaionPlot' can be static (but you may consider moving to unnamed namespace). openssn/src/targetmotionanalysis.h:84:8: note: Technically the member function 'TargetMotionAnalysis::BearingDevitaionPlot' can be static (but you may consider moving to unnamed namespace). head openssn/src/towedarray.cpp:149:19: performance:inconclusive: Technically the member function 'TowedArray::CalcBearing' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/towedarray.h:51:8: note: Technically the member function 'TowedArray::CalcBearing' can be static (but you may consider moving to unnamed namespace). openssn/src/towedarray.cpp:149:19: note: Technically the member function 'TowedArray::CalcBearing' can be static (but you may consider moving to unnamed namespace). head openssn/src/towedarray.cpp:75:17: style:inconclusive: Technically the member function 'TowedArray::GetLength' can be const. [functionConst] openssn/src/towedarray.h:45:6: note: Technically the member function 'TowedArray::GetLength' can be const. openssn/src/towedarray.cpp:75:17: note: Technically the member function 'TowedArray::GetLength' can be const. head openssn/src/towedarray.cpp:98:18: style:inconclusive: Technically the member function 'TowedArray::ReturnLatLon' can be const. [functionConst] openssn/src/towedarray.h:47:7: note: Technically the member function 'TowedArray::ReturnLatLon' can be const. openssn/src/towedarray.cpp:98:18: note: Technically the member function 'TowedArray::ReturnLatLon' can be const. 2.17.0 openssn/src/towedarray.h:45:6: style:inconclusive: Technically the member function 'TowedArray::GetLength' can be const. [functionConst] openssn/src/towedarray.cpp:75:17: note: Technically the member function 'TowedArray::GetLength' can be const. openssn/src/towedarray.h:45:6: note: Technically the member function 'TowedArray::GetLength' can be const. 2.17.0 openssn/src/towedarray.h:47:7: style:inconclusive: Technically the member function 'TowedArray::ReturnLatLon' can be const. [functionConst] openssn/src/towedarray.cpp:98:18: note: Technically the member function 'TowedArray::ReturnLatLon' can be const. openssn/src/towedarray.h:47:7: note: Technically the member function 'TowedArray::ReturnLatLon' can be const. 2.17.0 openssn/src/towedarray.h:51:8: performance:inconclusive: Technically the member function 'TowedArray::CalcBearing' can be static (but you may consider moving to unnamed namespace). [functionStatic] openssn/src/towedarray.cpp:149:19: note: Technically the member function 'TowedArray::CalcBearing' can be static (but you may consider moving to unnamed namespace). openssn/src/towedarray.h:51:8: note: Technically the member function 'TowedArray::CalcBearing' can be static (but you may consider moving to unnamed namespace). DONE