2025-05-06 14:16 ftp://ftp.de.debian.org/debian/pool/main/n/niceshaper/niceshaper_1.2.4.orig.tar.bz2 cppcheck-options: --library=posix --library=gnu --library=bsd --library=bsd --inconclusive --enable=style,information --inline-suppr --template=daca2 --disable=missingInclude --suppress=unmatchedSuppression --check-library --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=normalCheckLevelConditionExpressions -D__GNUC__ --platform=unix64 -j1 platform: Linux-6.8.0-59-generic-x86_64-with-glibc2.39 python: 3.12.3 client-version: 1.3.67 compiler: g++ (Ubuntu 14.2.0-4ubuntu2~24.04) 14.2.0 cppcheck: head 2.17.0 head-info: 40776f9 (2025-05-06 14:25:14 +0200) count: 518 510 elapsed-time: 67.9 65.2 head-timing-info: old-timing-info: head results: niceshaper-1.2.4/src/aux.cc:42:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/aux.cc:99:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/aux.cc:172:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable hex [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/aux.cc:236:61: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/aux.cc:253:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/aux.cc:290:55: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AF_INET [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/aux.cc:303:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/aux.cc:331:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/aux.cc:416:78: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/aux.cc:290:10: style: Obsolescent function 'gethostbyaddr' called. It is recommended to use 'getnameinfo' instead. [prohibitedgethostbyaddrCalled] niceshaper-1.2.4/src/logger.h:39:14: style:inconclusive: Technically the member function 'Logger::getErrorLogged' can be const. [functionConst] niceshaper-1.2.4/src/logger.h:44:14: style:inconclusive: Technically the member function 'Logger::getReqRecoverQos' can be const. [functionConst] niceshaper-1.2.4/src/logger.h:46:14: style:inconclusive: Technically the member function 'Logger::getReqRecoverIpt' can be const. [functionConst] niceshaper-1.2.4/src/logger.h:48:14: style:inconclusive: Technically the member function 'Logger::getReqRecoverMissU32Perf' can be const. [functionConst] niceshaper-1.2.4/src/aux.cc:290:25: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/aux.cc:160:26: style: Checking if unsigned expression 'pad-buf.size()' is less than zero. [unsignedLessThanZero] niceshaper-1.2.4/src/aux.cc:66:42: performance: Function parameter 'source' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/aux.cc:71:42: performance: Function parameter 'source' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/aux.cc:94:34: performance: Function parameter 'source' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/aux.cc:106:40: performance: Function parameter 'source' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/aux.cc:178:43: performance: Function parameter 'arg' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/aux.cc:189:33: performance: Function parameter 'arg' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/aux.cc:200:39: performance: Function parameter 'arg' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/aux.cc:211:35: performance: Function parameter 'arg' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/aux.cc:222:50: performance: Function parameter 'arg' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/aux.cc:232:32: performance: Function parameter 'arg' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/aux.cc:261:33: performance: Function parameter 'mask' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/aux.cc:296:37: performance: Function parameter 'src' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/aux.cc:324:37: performance: Function parameter 'arg' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/aux.cc:349:165: performance: Function parameter 'section' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/aux.cc:390:46: performance: Function parameter 'source' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/aux.cc:390:66: performance: Function parameter 'param' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/aux.cc:409:37: performance: Function parameter 'arg' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/aux.cc:454:44: performance: Function parameter 'arg' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/aux.cc:464:69: performance: Function parameter 'arg' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/aux.cc:349:148: style: Parameter 'fpv' can be declared as reference to const [constParameterReference] niceshaper-1.2.4/src/aux.cc:464:52: style: Parameter 'fpv' can be declared as reference to const [constParameterReference] niceshaper-1.2.4/src/aux.cc:477:53: style: Parameter 'fpv' can be declared as reference to const [constParameterReference] niceshaper-1.2.4/src/aux.cc:360:9: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] niceshaper-1.2.4/src/aux.cc:379:9: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] niceshaper-1.2.4/src/aux.cc:471:9: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] niceshaper-1.2.4/src/aux.cc:484:9: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] niceshaper-1.2.4/src/class.cc:551:13: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] niceshaper-1.2.4/src/class.cc:556:13: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] niceshaper-1.2.4/src/class.cc:28:10: warning: Member variable 'NsClass::GradeForReducing' is not initialized in the constructor. [uninitMemberVar] niceshaper-1.2.4/src/class.cc:30:5: performance: Variable 'SectionName' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/class.cc:31:5: performance: Variable 'Header' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/class.cc:32:5: performance: Variable 'Dev' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/class.cc:33:5: performance: Variable 'Name' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/class.cc:34:5: performance: Variable 'EsfqHash' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/class.cc:35:5: performance: Variable 'TcQdiscEsfqAdd' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/class.cc:54:5: performance: Variable 'RawBytesCurr' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/class.cc:55:5: performance: Variable 'RawBytesPrev' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/sys.h:67:14: style:inconclusive: Technically the member function 'Sys::getMissU32Perf' can be const. [functionConst] niceshaper-1.2.4/src/filter.h:25:15: style:inconclusive: Technically the member function 'TcFilter::tcFilterId' can be const. [functionConst] niceshaper-1.2.4/src/filter.h:26:26: style:inconclusive: Technically the member function 'TcFilter::tcFilterType' can be const. [functionConst] niceshaper-1.2.4/src/trigger.h:8:14: style:inconclusive: Technically the member function 'Trigger::isActive' can be const. [functionConst] niceshaper-1.2.4/src/trigger.h:9:14: style:inconclusive: Technically the member function 'Trigger::isUseNsLow' can be const. [functionConst] niceshaper-1.2.4/src/trigger.h:10:14: style:inconclusive: Technically the member function 'Trigger::isUseNsCeil' can be const. [functionConst] niceshaper-1.2.4/src/class.cc:432:23: style:inconclusive: Technically the member function 'NsClass::trafficPrognosed' can be const. [functionConst] niceshaper-1.2.4/src/class.h:25:22: note: Technically the member function 'NsClass::trafficPrognosed' can be const. niceshaper-1.2.4/src/class.cc:432:23: note: Technically the member function 'NsClass::trafficPrognosed' can be const. niceshaper-1.2.4/src/class.cc:583:22: style:inconclusive: Technically the member function 'NsClass::status' can be const. [functionConst] niceshaper-1.2.4/src/class.h:32:21: note: Technically the member function 'NsClass::status' can be const. niceshaper-1.2.4/src/class.cc:583:22: note: Technically the member function 'NsClass::status' can be const. niceshaper-1.2.4/src/class.h:36:22: style:inconclusive: Technically the member function 'NsClass::getHold' can be const. [functionConst] niceshaper-1.2.4/src/class.h:37:14: style:inconclusive: Technically the member function 'NsClass::getUseQosClass' can be const. [functionConst] niceshaper-1.2.4/src/class.h:38:14: style:inconclusive: Technically the member function 'NsClass::getUseQosFilter' can be const. [functionConst] niceshaper-1.2.4/src/class.h:39:14: style:inconclusive: Technically the member function 'NsClass::getActive' can be const. [functionConst] niceshaper-1.2.4/src/class.h:40:14: style:inconclusive: Technically the member function 'NsClass::getQosInitialized' can be const. [functionConst] niceshaper-1.2.4/src/class.h:41:25: style:inconclusive: Technically the member function 'NsClass::type' can be const. [functionConst] niceshaper-1.2.4/src/class.h:42:15: style:inconclusive: Technically the member function 'NsClass::qosClassId' can be const. [functionConst] niceshaper-1.2.4/src/class.h:43:22: style:inconclusive: Technically the member function 'NsClass::traffic' can be const. [functionConst] niceshaper-1.2.4/src/class.h:44:22: style:inconclusive: Technically the member function 'NsClass::htbCeil' can be const. [functionConst] niceshaper-1.2.4/src/class.h:45:22: style:inconclusive: Technically the member function 'NsClass::htbBurst' can be const. [functionConst] niceshaper-1.2.4/src/class.h:46:22: style:inconclusive: Technically the member function 'NsClass::htbCBurst' can be const. [functionConst] niceshaper-1.2.4/src/class.h:47:22: style:inconclusive: Technically the member function 'NsClass::nsLow' can be const. [functionConst] niceshaper-1.2.4/src/class.h:48:22: style:inconclusive: Technically the member function 'NsClass::nsCeil' can be const. [functionConst] niceshaper-1.2.4/src/class.h:49:16: style:inconclusive: Technically the member function 'NsClass::gradeForReducing' can be const. [functionConst] niceshaper-1.2.4/src/class.h:50:21: style:inconclusive: Technically the member function 'NsClass::name' can be const. [functionConst] niceshaper-1.2.4/src/class.cc:624:23: style:inconclusive: Technically the member function 'NsClass::getTcFiltersNum' can be const. [functionConst] niceshaper-1.2.4/src/class.h:55:22: note: Technically the member function 'NsClass::getTcFiltersNum' can be const. niceshaper-1.2.4/src/class.cc:624:23: note: Technically the member function 'NsClass::getTcFiltersNum' can be const. niceshaper-1.2.4/src/class.h:56:22: style:inconclusive: Technically the member function 'NsClass::getDnswStubBefore' can be const. [functionConst] niceshaper-1.2.4/src/class.h:57:21: style:inconclusive: Technically the member function 'NsClass::getDev' can be const. [functionConst] niceshaper-1.2.4/src/config.h:20:19: style:inconclusive: Technically the member function 'Config::getStatusUnit' can be const. [functionConst] niceshaper-1.2.4/src/config.h:21:21: style:inconclusive: Technically the member function 'Config::getListenerIp' can be const. [functionConst] niceshaper-1.2.4/src/config.h:22:13: style:inconclusive: Technically the member function 'Config::getListenerPort' can be const. [functionConst] niceshaper-1.2.4/src/config.h:23:21: style:inconclusive: Technically the member function 'Config::getListenerPassword' can be const. [functionConst] niceshaper-1.2.4/src/config.h:24:21: style:inconclusive: Technically the member function 'Config::getStatusFilePath' can be const. [functionConst] niceshaper-1.2.4/src/config.h:25:21: style:inconclusive: Technically the member function 'Config::getStatusFileOwner' can be const. [functionConst] niceshaper-1.2.4/src/config.h:26:21: style:inconclusive: Technically the member function 'Config::getStatusFileGroup' can be const. [functionConst] niceshaper-1.2.4/src/config.h:27:21: style:inconclusive: Technically the member function 'Config::getStatusFileMode' can be const. [functionConst] niceshaper-1.2.4/src/config.h:28:13: style:inconclusive: Technically the member function 'Config::getStatusFileRewrite' can be const. [functionConst] niceshaper-1.2.4/src/config.h:29:31: style:inconclusive: Technically the member function 'Config::getStatusShowClasses' can be const. [functionConst] niceshaper-1.2.4/src/config.h:30:27: style:inconclusive: Technically the member function 'Config::getStatusShowSum' can be const. [functionConst] niceshaper-1.2.4/src/config.h:31:14: style:inconclusive: Technically the member function 'Config::getStatusShowDoNotShape' can be const. [functionConst] niceshaper-1.2.4/src/config.h:32:14: style:inconclusive: Technically the member function 'Config::getImqAutoRedirect' can be const. [functionConst] niceshaper-1.2.4/src/config.h:48:22: style:inconclusive: Technically the member function 'Config::getReqRecoverWait' can be const. [functionConst] niceshaper-1.2.4/src/config.h:49:22: style:inconclusive: Technically the member function 'Config::getStartStopDots' can be const. [functionConst] niceshaper-1.2.4/src/trigger.h:28:10: style: The destructor '~TriggerAlter' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] niceshaper-1.2.4/src/trigger.h:7:18: note: Virtual destructor in base class niceshaper-1.2.4/src/trigger.h:28:10: note: Destructor in derived class niceshaper-1.2.4/src/trigger.h:39:10: style: The destructor '~TriggerQuota' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] niceshaper-1.2.4/src/trigger.h:7:18: note: Virtual destructor in base class niceshaper-1.2.4/src/trigger.h:39:10: note: Destructor in derived class niceshaper-1.2.4/src/class.h:50:21: performance: Function 'name()' should return member 'Name' by const reference. [returnByReference] niceshaper-1.2.4/src/class.h:57:21: performance: Function 'getDev()' should return member 'Dev' by const reference. [returnByReference] niceshaper-1.2.4/src/config.h:21:21: performance: Function 'getListenerIp()' should return member 'ListenerIp' by const reference. [returnByReference] niceshaper-1.2.4/src/config.h:23:21: performance: Function 'getListenerPassword()' should return member 'ListenerPassword' by const reference. [returnByReference] niceshaper-1.2.4/src/config.h:24:21: performance: Function 'getStatusFilePath()' should return member 'StatusFilePath' by const reference. [returnByReference] niceshaper-1.2.4/src/config.h:25:21: performance: Function 'getStatusFileOwner()' should return member 'StatusFileOwner' by const reference. [returnByReference] niceshaper-1.2.4/src/config.h:26:21: performance: Function 'getStatusFileGroup()' should return member 'StatusFileGroup' by const reference. [returnByReference] niceshaper-1.2.4/src/config.h:27:21: performance: Function 'getStatusFileMode()' should return member 'StatusFileMode' by const reference. [returnByReference] niceshaper-1.2.4/src/class.cc:453:10: style: The scope of the variable 'flow_to_target' can be reduced. [variableScope] niceshaper-1.2.4/src/class.cc:490:10: style: The scope of the variable 'flow_to_target' can be reduced. [variableScope] niceshaper-1.2.4/src/class.cc:370:42: style:inconclusive: Function 'proceedReceiptTraffic' argument 1 names different: declaration 'raw_bytes' definition 'raw_bytes_curr'. [funcArgNamesDifferent] niceshaper-1.2.4/src/class.h:22:41: note: Function 'proceedReceiptTraffic' argument 1 names different: declaration 'raw_bytes' definition 'raw_bytes_curr'. niceshaper-1.2.4/src/class.cc:370:42: note: Function 'proceedReceiptTraffic' argument 1 names different: declaration 'raw_bytes' definition 'raw_bytes_curr'. niceshaper-1.2.4/src/class.cc:513:40: style:inconclusive: Function 'applyChanges' argument 1 names different: declaration 'workings_count' definition 'working_classes'. [funcArgNamesDifferent] niceshaper-1.2.4/src/class.h:30:39: note: Function 'applyChanges' argument 1 names different: declaration 'workings_count' definition 'working_classes'. niceshaper-1.2.4/src/class.cc:513:40: note: Function 'applyChanges' argument 1 names different: declaration 'workings_count' definition 'working_classes'. niceshaper-1.2.4/src/config.h:33:45: performance: Function parameter 'running_section' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/config.h:36:47: performance: Function parameter 'listener_password' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/config.h:37:45: performance: Function parameter 'status_file_path' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/config.h:38:46: performance: Function parameter 'status_file_owner' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/config.h:39:46: performance: Function parameter 'status_file_group' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/config.h:40:45: performance: Function parameter 'status_file_mode' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/class.cc:28:30: performance: Function parameter 'section_name' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/class.cc:88:32: performance: Function parameter 'buf' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/class.cc:549:16: style: Variable 'ltime' can be declared as pointer to const [constVariablePointer] niceshaper-1.2.4/src/config.cc:509:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/config.cc:676:101: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/config.cc:28:5: performance: Variable 'ListenerIp' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/config.cc:30:5: performance: Variable 'ListenerPassword' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/config.cc:32:5: performance: Variable 'StatusFilePath' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/config.cc:33:5: performance: Variable 'StatusFileOwner' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/config.cc:34:5: performance: Variable 'StatusFileGroup' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/config.cc:35:5: performance: Variable 'StatusFileMode' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/config.cc:41:5: performance: Variable 'AutoHostsBasis' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/config.cc:465:13: performance:inconclusive: Technically the member function 'Config::proceedLoopMacro' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/config.h:18:13: note: Technically the member function 'Config::proceedLoopMacro' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/config.cc:465:13: note: Technically the member function 'Config::proceedLoopMacro' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/config.cc:85:21: performance:inconclusive: Technically the member function 'Config::getLine' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/config.h:57:21: note: Technically the member function 'Config::getLine' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/config.cc:85:21: note: Technically the member function 'Config::getLine' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/config.cc:110:19: style: Condition 'state_block_comment' is always true [knownConditionTrueFalse] niceshaper-1.2.4/src/config.cc:98:13: note: Assuming that condition '!state_block_comment' is not redundant niceshaper-1.2.4/src/config.cc:110:19: note: Condition 'state_block_comment' is always true niceshaper-1.2.4/src/config.cc:158:33: style: The scope of the variable 'value2' can be reduced. [variableScope] niceshaper-1.2.4/src/config.cc:318:17: style: The scope of the variable 'buf' can be reduced. [variableScope] niceshaper-1.2.4/src/config.cc:318:22: style: The scope of the variable 'option' can be reduced. [variableScope] niceshaper-1.2.4/src/config.cc:423:17: style: The scope of the variable 'buf' can be reduced. [variableScope] niceshaper-1.2.4/src/config.cc:423:22: style: The scope of the variable 'option' can be reduced. [variableScope] niceshaper-1.2.4/src/config.cc:156:39: performance: Function parameter 'confdir' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/config.cc:556:39: performance: Function parameter 'confdir' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/config.cc:556:60: performance: Function parameter 'src' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/config.cc:589:41: performance: Function parameter 'arg' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/config.cc:757:45: performance: Function parameter 'arg' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/config.cc:770:41: performance: Function parameter 'local_subnet' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/config.cc:781:44: performance: Function parameter 'section' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/config.cc:781:65: performance: Function parameter 'iface' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/config.cc:426:35: style: Variable 'desired_position' is assigned a value that is never used. [unreadVariable] niceshaper-1.2.4/src/config.cc:292:9: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] niceshaper-1.2.4/src/config.cc:303:13: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] niceshaper-1.2.4/src/filter.cc:164:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TC_U32_TERMINAL [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/filter.cc:329:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable off [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/filter.cc:408:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AF_INET [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/filter.cc:30:11: warning: Member variable 'TcFilter::ImqAutoRedirect' is not initialized in the constructor. [uninitMemberVar] niceshaper-1.2.4/src/filter.cc:32:5: performance: Variable 'SectionName' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/filter.cc:244:15: style:inconclusive: Technically the member function 'TcFilter::del' can be const. [functionConst] niceshaper-1.2.4/src/filter.h:24:13: note: Technically the member function 'TcFilter::del' can be const. niceshaper-1.2.4/src/filter.cc:244:15: note: Technically the member function 'TcFilter::del' can be const. niceshaper-1.2.4/src/filter.cc:131:16: style:inconclusive: Technically the member function 'TcFilter::getIptRequiredToOperate' can be const. [functionConst] niceshaper-1.2.4/src/filter.h:29:14: note: Technically the member function 'TcFilter::getIptRequiredToOperate' can be const. niceshaper-1.2.4/src/filter.cc:131:16: note: Technically the member function 'TcFilter::getIptRequiredToOperate' can be const. niceshaper-1.2.4/src/filter.cc:139:16: style:inconclusive: Technically the member function 'TcFilter::getIptRequiredToCheckActivity' can be const. [functionConst] niceshaper-1.2.4/src/filter.h:30:14: note: Technically the member function 'TcFilter::getIptRequiredToCheckActivity' can be const. niceshaper-1.2.4/src/filter.cc:139:16: note: Technically the member function 'TcFilter::getIptRequiredToCheckActivity' can be const. niceshaper-1.2.4/src/filter.cc:147:16: style:inconclusive: Technically the member function 'TcFilter::getIptRequiredToCheckTraffic' can be const. [functionConst] niceshaper-1.2.4/src/filter.h:31:14: note: Technically the member function 'TcFilter::getIptRequiredToCheckTraffic' can be const. niceshaper-1.2.4/src/filter.cc:147:16: note: Technically the member function 'TcFilter::getIptRequiredToCheckTraffic' can be const. niceshaper-1.2.4/src/filter.cc:390:15: performance:inconclusive: Technically the member function 'TcFilter::getU32' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/filter.h:34:13: note: Technically the member function 'TcFilter::getU32' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/filter.cc:390:15: note: Technically the member function 'TcFilter::getU32' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/filter.cc:321:15: performance:inconclusive: Technically the member function 'TcFilter::packKey' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/filter.h:37:13: note: Technically the member function 'TcFilter::packKey' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/filter.cc:321:15: note: Technically the member function 'TcFilter::packKey' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/filter.cc:421:15: performance:inconclusive: Technically the member function 'TcFilter::getAddrIpv4' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/filter.h:41:13: note: Technically the member function 'TcFilter::getAddrIpv4' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/filter.cc:421:15: note: Technically the member function 'TcFilter::getAddrIpv4' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/filter.cc:410:21: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/filter.cc:282:22: style: Variable 'addr.bitlen' is reassigned a value before the old one has been used. [redundantAssignment] niceshaper-1.2.4/src/filter.cc:279:17: note: addr.bitlen is assigned niceshaper-1.2.4/src/filter.cc:282:22: note: addr.bitlen is overwritten niceshaper-1.2.4/src/filter.cc:157:17: style: The scope of the variable 'option' can be reduced. [variableScope] niceshaper-1.2.4/src/filter.cc:30:32: performance: Function parameter 'section_name' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/filter.cc:30:58: performance: Function parameter 'class_header' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/filter.cc:30:84: performance: Function parameter 'match' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/filter.cc:71:33: performance: Function parameter 'buf' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/filter.cc:266:92: performance: Function parameter 'param2' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/filter.cc:77:12: style: Variable 'value2' is assigned a value that is never used. [unreadVariable] niceshaper-1.2.4/src/ifaces.cc:73:91: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TC_H_ROOT [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/ifaces.cc:94:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ifreq [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/ifaces.cc:288:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TC_H_ROOT [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/ifaces.cc:34:5: performance: Variable 'Name' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/ifaces.cc:261:16: style:inconclusive: Technically the member function 'IfacesMap::initHtbOnControlled' can be const. [functionConst] niceshaper-1.2.4/src/ifaces.h:55:13: note: Technically the member function 'IfacesMap::initHtbOnControlled' can be const. niceshaper-1.2.4/src/ifaces.cc:261:16: note: Technically the member function 'IfacesMap::initHtbOnControlled' can be const. niceshaper-1.2.4/src/ifaces.cc:311:16: style:inconclusive: Technically the member function 'IfacesMap::endUpHtbFallbackOnControlled' can be const. [functionConst] niceshaper-1.2.4/src/ifaces.h:56:13: note: Technically the member function 'IfacesMap::endUpHtbFallbackOnControlled' can be const. niceshaper-1.2.4/src/ifaces.cc:311:16: note: Technically the member function 'IfacesMap::endUpHtbFallbackOnControlled' can be const. niceshaper-1.2.4/src/ifaces.cc:332:25: style:inconclusive: Technically the member function 'IfacesMap::htbDNWrapperId' can be const. [functionConst] niceshaper-1.2.4/src/ifaces.h:57:22: note: Technically the member function 'IfacesMap::htbDNWrapperId' can be const. niceshaper-1.2.4/src/ifaces.cc:332:25: note: Technically the member function 'IfacesMap::htbDNWrapperId' can be const. niceshaper-1.2.4/src/ifaces.cc:66:12: style: The scope of the variable 'dev' can be reduced. [variableScope] niceshaper-1.2.4/src/ifaces.cc:313:12: style: The scope of the variable 'dev' can be reduced. [variableScope] niceshaper-1.2.4/src/ifaces.cc:31:18: style:inconclusive: Function 'Iface' argument 1 names different: declaration 'ifr_ifindex' definition 'iface_index'. [funcArgNamesDifferent] niceshaper-1.2.4/src/ifaces.h:13:19: note: Function 'Iface' argument 1 names different: declaration 'ifr_ifindex' definition 'iface_index'. niceshaper-1.2.4/src/ifaces.cc:31:18: note: Function 'Iface' argument 1 names different: declaration 'ifr_ifindex' definition 'iface_index'. niceshaper-1.2.4/src/ifaces.cc:31:43: style:inconclusive: Function 'Iface' argument 2 names different: declaration 'ifr_name' definition 'iface_name'. [funcArgNamesDifferent] niceshaper-1.2.4/src/ifaces.h:13:44: note: Function 'Iface' argument 2 names different: declaration 'ifr_name' definition 'iface_name'. niceshaper-1.2.4/src/ifaces.cc:31:43: note: Function 'Iface' argument 2 names different: declaration 'ifr_name' definition 'iface_name'. niceshaper-1.2.4/src/ifaces.cc:31:43: performance: Function parameter 'iface_name' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:135:37: performance: Function parameter 'dev' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:144:34: performance: Function parameter 'dev' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:151:43: performance: Function parameter 'dev' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:158:45: performance: Function parameter 'dev' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:165:50: performance: Function parameter 'dev' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:172:49: performance: Function parameter 'dev' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:179:50: performance: Function parameter 'dev' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:186:64: performance: Function parameter 'dev' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:194:38: performance: Function parameter 'dev' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:201:43: performance: Function parameter 'dev' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:208:45: performance: Function parameter 'dev' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:215:40: performance: Function parameter 'dev' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:215:57: performance: Function parameter 'section' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:222:42: performance: Function parameter 'dev' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:222:59: performance: Function parameter 'section' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:229:50: performance: Function parameter 'dev_name' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:247:45: performance: Function parameter 'dev' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:254:54: performance: Function parameter 'dev' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:337:45: performance: Function parameter 'dev' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:347:59: performance: Function parameter 'dev' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:354:49: performance: Function parameter 'dev' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:362:50: performance: Function parameter 'dev' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:369:50: performance: Function parameter 'dev' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:376:50: performance: Function parameter 'dev' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:383:50: performance: Function parameter 'dev' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/ifaces.cc:66:12: style: Variable 'dev' can be declared as pointer to const [constVariablePointer] niceshaper-1.2.4/src/ifaces.cc:313:12: style: Variable 'dev' can be declared as pointer to const [constVariablePointer] niceshaper-1.2.4/src/ifaces.cc:65:17: style: Unused variable: buf [unusedVariable] niceshaper-1.2.4/src/iptables.cc:210:60: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/iptables.cc:29:5: performance: Variable 'HookDwload' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/iptables.cc:30:5: performance: Variable 'HookUpload' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/iptables.cc:31:5: performance: Variable 'ChainDwload' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/iptables.cc:32:5: performance: Variable 'ChainUpload' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/iptables.cc:33:5: performance: Variable 'Target' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/niceshaper.h:25:22: style:inconclusive: Technically the member function 'NiceShaper::getReload' can be const. [functionConst] niceshaper-1.2.4/src/worker.h:26:21: style:inconclusive: Technically the member function 'Worker::getSectionName' can be const. [functionConst] niceshaper-1.2.4/src/worker.h:30:22: style:inconclusive: Technically the member function 'Worker::getReloadsCounter' can be const. [functionConst] niceshaper-1.2.4/src/iptables.cc:409:15: performance:inconclusive: Technically the member function 'Iptables::genFilterFromNSMatch' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/iptables.h:28:13: note: Technically the member function 'Iptables::genFilterFromNSMatch' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/iptables.cc:409:15: note: Technically the member function 'Iptables::genFilterFromNSMatch' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/iptables.cc:126:15: style:inconclusive: Technically the member function 'Iptables::execSysCmd' can be const. [functionConst] niceshaper-1.2.4/src/iptables.h:31:13: note: Technically the member function 'Iptables::execSysCmd' can be const. niceshaper-1.2.4/src/iptables.cc:126:15: note: Technically the member function 'Iptables::execSysCmd' can be const. niceshaper-1.2.4/src/worker.h:26:21: performance: Function 'getSectionName()' should return member 'SectionName' by const reference. [returnByReference] niceshaper-1.2.4/src/iptables.cc:631:48: warning: If resource allocation fails, then there is a possible null pointer dereference: fp [nullPointerOutOfResources] niceshaper-1.2.4/src/iptables.cc:629:19: note: Assuming allocation function fails niceshaper-1.2.4/src/iptables.cc:629:19: note: Assignment 'fp=popen(("iptables -t mangle -L "+chain+" -vnx").c_str(),"r")', assigned value is 0 niceshaper-1.2.4/src/iptables.cc:631:48: note: Null pointer dereference niceshaper-1.2.4/src/iptables.cc:176:18: style: The scope of the variable 'bsize' can be reduced. [variableScope] niceshaper-1.2.4/src/iptables.cc:271:17: style: The scope of the variable 'buf' can be reduced. [variableScope] niceshaper-1.2.4/src/iptables.cc:271:22: style: The scope of the variable 'option' can be reduced. [variableScope] niceshaper-1.2.4/src/iptables.cc:272:43: style: The scope of the variable 'class_name' can be reduced. [variableScope] niceshaper-1.2.4/src/iptables.cc:310:98: style:inconclusive: Function 'genRulesFromNSMatch' argument 3 names different: declaration 'NsClassType' definition 'class_type'. [funcArgNamesDifferent] niceshaper-1.2.4/src/iptables.h:27:81: note: Function 'genRulesFromNSMatch' argument 3 names different: declaration 'NsClassType' definition 'class_type'. niceshaper-1.2.4/src/iptables.cc:310:98: note: Function 'genRulesFromNSMatch' argument 3 names different: declaration 'NsClassType' definition 'class_type'. niceshaper-1.2.4/src/iptables.cc:75:69: performance: Function parameter 'hook' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/iptables.cc:88:70: performance: Function parameter 'chain' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/iptables.cc:96:37: performance: Function parameter 'target' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/iptables.cc:126:38: performance: Function parameter 'command' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/iptables.cc:310:47: performance: Function parameter 'src' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/iptables.cc:310:162: performance: Function parameter 'class_iface' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/iptables.cc:409:49: performance: Function parameter 'src' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/iptables.cc:409:106: performance: Function parameter 'hook_behaviour' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/iptables.cc:409:134: performance: Function parameter 'class_iface' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/iptables.cc:409:159: performance: Function parameter 'override_test_mark' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/iptables.cc:269:55: style: Parameter 'fpv_class_file' can be declared as reference to const [constParameterReference] niceshaper-1.2.4/src/iptables.cc:269:95: style: Parameter 'workers' can be declared as reference to const [constParameterReference] niceshaper-1.2.4/src/iptables.cc:284:24: style: Variable 'class_name' is assigned a value that is never used. [unreadVariable] niceshaper-1.2.4/src/iptables.cc:292:27: style: Variable 'class_section' is assigned a value that is never used. [unreadVariable] niceshaper-1.2.4/src/iptables.cc:294:24: style: Variable 'class_name' is assigned a value that is never used. [unreadVariable] niceshaper-1.2.4/src/iptables.cc:312:17: style: Unused variable: buf [unusedVariable] niceshaper-1.2.4/src/libnetlink.cc:47:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AF_NETLINK [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/libnetlink.cc:88:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AF_NETLINK [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/libnetlink.cc:106:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AF_NETLINK [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/libnetlink.cc:125:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AF_NETLINK [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/libnetlink.cc:162:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable errno [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/libnetlink.cc:247:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AF_NETLINK [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/libnetlink.cc:360:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AF_NETLINK [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/libnetlink.cc:422:56: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable iov_base [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/libnetlink.cc:473:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable errno [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/libnetlink.cc:556:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MSG_DONTWAIT [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/libnetlink.cc:50:28: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:55:35: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:97:32: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:97:62: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:108:46: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:118:17: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:153:25: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:176:22: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:195:57: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:237:30: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:240:17: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:282:27: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:307:57: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:329:48: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:353:17: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:385:27: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:404:48: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:422:31: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:425:17: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:462:46: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:464:33: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:501:22: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:521:55: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:593:30: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:667:33: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:683:33: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:699:36: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:715:36: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/libnetlink.cc:283:29: style: The scope of the variable 'err' can be reduced. [variableScope] niceshaper-1.2.4/src/libnetlink.cc:347:13: style: The scope of the variable 'status' can be reduced. [variableScope] niceshaper-1.2.4/src/libnetlink.cc:79:56: style:inconclusive: Function 'rtnl_wilddump_request' argument 2 names different: declaration 'fam' definition 'family'. [funcArgNamesDifferent] niceshaper-1.2.4/src/libnetlink.h:59:64: note: Function 'rtnl_wilddump_request' argument 2 names different: declaration 'fam' definition 'family'. niceshaper-1.2.4/src/libnetlink.cc:79:56: note: Function 'rtnl_wilddump_request' argument 2 names different: declaration 'fam' definition 'family'. niceshaper-1.2.4/src/libnetlink.cc:195:50: style: Local variable 'err' shadows outer variable [shadowVariable] niceshaper-1.2.4/src/libnetlink.cc:179:29: note: Shadowed declaration niceshaper-1.2.4/src/libnetlink.cc:195:50: note: Shadow variable niceshaper-1.2.4/src/libnetlink.cc:307:50: style: Local variable 'err' shadows outer variable [shadowVariable] niceshaper-1.2.4/src/libnetlink.cc:283:29: note: Shadowed declaration niceshaper-1.2.4/src/libnetlink.cc:307:50: note: Shadow variable niceshaper-1.2.4/src/libnetlink.cc:101:42: style: Parameter 'rth' can be declared as pointer to const [constParameterPointer] niceshaper-1.2.4/src/libnetlink.cc:101:53: style: Parameter 'buf' can be declared as pointer to const [constParameterPointer] niceshaper-1.2.4/src/libnetlink.cc:137:49: style: Parameter 'rth' can be declared as pointer to const [constParameterPointer] niceshaper-1.2.4/src/libnetlink.cc:195:50: style: Variable 'err' can be declared as pointer to const [constVariablePointer] niceshaper-1.2.4/src/libnetlink.cc:307:50: style: Variable 'err' can be declared as pointer to const [constVariablePointer] niceshaper-1.2.4/src/libnetlink.cc:343:44: style: Parameter 'rtnl' can be declared as pointer to const [constParameterPointer] niceshaper-1.2.4/src/libnetlink.cc:521:50: style: Variable 'e' can be declared as pointer to const [constVariablePointer] niceshaper-1.2.4/src/libnetlink.cc:552:36: style: Parameter 'rth' can be declared as pointer to const [constParameterPointer] niceshaper-1.2.4/src/libnetlink.cc:676:70: style: Parameter 'data' can be declared as pointer to const [constParameterPointer] niceshaper-1.2.4/src/libnetlink.cc:708:74: style: Parameter 'data' can be declared as pointer to const [constParameterPointer] niceshaper-1.2.4/src/logger.cc:497:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/logger.cc:514:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LOG_NOTICE [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/logger.cc:524:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable O_CREAT [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/logger.cc:33:5: performance: Variable 'LogFile' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/logger.cc:45:21: style:inconclusive: Technically the member function 'Logger::getErrorMessage' can be const. [functionConst] niceshaper-1.2.4/src/logger.h:14:21: note: Technically the member function 'Logger::getErrorMessage' can be const. niceshaper-1.2.4/src/logger.cc:45:21: note: Technically the member function 'Logger::getErrorMessage' can be const. niceshaper-1.2.4/src/logger.cc:320:21: style:inconclusive: Technically the member function 'Logger::getWarningMessage' can be const. [functionConst] niceshaper-1.2.4/src/logger.h:15:21: note: Technically the member function 'Logger::getWarningMessage' can be const. niceshaper-1.2.4/src/logger.cc:320:21: note: Technically the member function 'Logger::getWarningMessage' can be const. niceshaper-1.2.4/src/logger.cc:360:21: style:inconclusive: Technically the member function 'Logger::getInfoMessage' can be const. [functionConst] niceshaper-1.2.4/src/logger.h:16:21: note: Technically the member function 'Logger::getInfoMessage' can be const. niceshaper-1.2.4/src/logger.cc:360:21: note: Technically the member function 'Logger::getInfoMessage' can be const. niceshaper-1.2.4/src/logger.cc:512:14: performance:inconclusive: Technically the member function 'Logger::toSyslog' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/logger.h:31:14: note: Technically the member function 'Logger::toSyslog' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/logger.cc:512:14: note: Technically the member function 'Logger::toSyslog' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/logger.cc:408:49: performance: Function parameter 'explanation' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/logger.cc:415:33: performance: Function parameter 'section_name' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/logger.cc:415:75: performance: Function parameter 'explanation' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/logger.cc:422:33: performance: Function parameter 'section_name' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/logger.cc:434:51: performance: Function parameter 'explanation' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/logger.cc:439:35: performance: Function parameter 'section_name' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/logger.cc:439:77: performance: Function parameter 'explanation' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/logger.cc:444:35: performance: Function parameter 'section_name' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/logger.cc:454:48: performance: Function parameter 'explanation' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/logger.cc:459:32: performance: Function parameter 'section_name' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/logger.cc:459:74: performance: Function parameter 'explanation' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/logger.cc:464:32: performance: Function parameter 'section_name' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/logger.cc:469:32: performance: Function parameter 'section_name' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/logger.cc:469:58: performance: Function parameter 'message' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/logger.cc:469:79: performance: Function parameter 'explanation' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/logger.cc:484:38: performance: Function parameter 'log_file' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/logger.cc:492:38: performance: Function parameter 'message' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/logger.cc:512:36: performance: Function parameter 'message' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/logger.cc:520:37: performance: Function parameter 'message' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/logger.cc:532:25: style: Variable 'message' is assigned a value that is never used. [unreadVariable] niceshaper-1.2.4/src/logger.cc:532:17: style: Variable 'message' is assigned a value that is never used. [unreadVariable] niceshaper-1.2.4/src/main.cc:188:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stdin [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/main.cc:263:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AF_INET [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/main.cc:429:80: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/main.cc:166:9: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled] niceshaper-1.2.4/src/main.cc:260:13: style: Obsolescent function 'bzero' called. It is recommended to use 'memset' instead. [prohibitedbzeroCalled] niceshaper-1.2.4/src/main.cc:288:49: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled] niceshaper-1.2.4/src/main.cc:333:13: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled] niceshaper-1.2.4/src/main.cc:646:5: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled] niceshaper-1.2.4/src/main.cc:260:19: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/main.cc:265:45: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/main.cc:80:31: style: The scope of the variable 'fpv_classfile' can be reduced. [variableScope] niceshaper-1.2.4/src/main.cc:140:9: style: The scope of the variable 'fork_result' can be reduced. [variableScope] niceshaper-1.2.4/src/main.cc:207:31: style: The scope of the variable 'result_vector' can be reduced. [variableScope] niceshaper-1.2.4/src/main.cc:208:17: style: The scope of the variable 'request' can be reduced. [variableScope] niceshaper-1.2.4/src/main.cc:211:9: style: The scope of the variable 'dpid' can be reduced. [variableScope] niceshaper-1.2.4/src/main.cc:212:9: style: The scope of the variable 'connection_socket' can be reduced. [variableScope] niceshaper-1.2.4/src/main.cc:214:17: style: The scope of the variable 'talk' can be reduced. [variableScope] niceshaper-1.2.4/src/main.cc:215:18: style: The scope of the variable 'dots_count' can be reduced. [variableScope] niceshaper-1.2.4/src/main.cc:347:17: style: The scope of the variable 'param' can be reduced. [variableScope] niceshaper-1.2.4/src/main.cc:401:17: style: The scope of the variable 'option' can be reduced. [variableScope] niceshaper-1.2.4/src/main.cc:401:25: style: The scope of the variable 'param' can be reduced. [variableScope] niceshaper-1.2.4/src/main.cc:401:32: style: The scope of the variable 'value' can be reduced. [variableScope] niceshaper-1.2.4/src/main.cc:205:28: performance: Function parameter 'runtime_cmd' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/main.cc:205:53: performance: Function parameter 'runtime_param_remote_address' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/main.cc:205:95: performance: Function parameter 'runtime_param_remote_password' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/main.cc:205:138: performance: Function parameter 'runtime_param_status_unit' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/main.cc:205:209: performance: Function parameter 'runtime_param_show_running' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/main.cc:343:52: performance: Function parameter 'runtime_params' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/main.cc:347:23: style: Variable 'param' is assigned a value that is never used. [unreadVariable] niceshaper-1.2.4/src/main.cc:610:9: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] niceshaper-1.2.4/src/niceshaper.cc:32:5: performance: Variable 'SectionName' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/niceshaper.cc:352:31: style:inconclusive: Technically the member function 'NiceShaper::getFlowDirection' can be const. [functionConst] niceshaper-1.2.4/src/niceshaper.h:15:27: note: Technically the member function 'NiceShaper::getFlowDirection' can be const. niceshaper-1.2.4/src/niceshaper.cc:352:31: note: Technically the member function 'NiceShaper::getFlowDirection' can be const. niceshaper-1.2.4/src/niceshaper.cc:367:18: style:inconclusive: Technically the member function 'NiceShaper::getIptRequired' can be const. [functionConst] niceshaper-1.2.4/src/niceshaper.h:18:14: note: Technically the member function 'NiceShaper::getIptRequired' can be const. niceshaper-1.2.4/src/niceshaper.cc:367:18: note: Technically the member function 'NiceShaper::getIptRequired' can be const. niceshaper-1.2.4/src/niceshaper.cc:372:18: style:inconclusive: Technically the member function 'NiceShaper::getIptRequiredToCheck' can be const. [functionConst] niceshaper-1.2.4/src/niceshaper.h:19:14: note: Technically the member function 'NiceShaper::getIptRequiredToCheck' can be const. niceshaper-1.2.4/src/niceshaper.cc:372:18: note: Technically the member function 'NiceShaper::getIptRequiredToCheck' can be const. niceshaper-1.2.4/src/niceshaper.cc:777:39: style:inconclusive: Technically the member function 'NiceShaper::dumpQuotaCounters' can be const. [functionConst] niceshaper-1.2.4/src/niceshaper.h:23:35: note: Technically the member function 'NiceShaper::dumpQuotaCounters' can be const. niceshaper-1.2.4/src/niceshaper.cc:777:39: note: Technically the member function 'NiceShaper::dumpQuotaCounters' can be const. niceshaper-1.2.4/src/niceshaper.cc:565:20: style: Condition 'judgeV12()==-1' is always false [knownConditionTrueFalse] niceshaper-1.2.4/src/niceshaper.cc:565:17: note: Calling function 'judgeV12' returns 0 niceshaper-1.2.4/src/niceshaper.cc:565:20: note: Condition 'judgeV12()==-1' is always false niceshaper-1.2.4/src/niceshaper.cc:309:17: style: The scope of the variable 'iface' can be reduced. [variableScope] niceshaper-1.2.4/src/niceshaper.cc:400:17: style: The scope of the variable 'iface' can be reduced. [variableScope] niceshaper-1.2.4/src/niceshaper.cc:403:10: style: The scope of the variable 'proceeded' can be reduced. [variableScope] niceshaper-1.2.4/src/niceshaper.cc:451:18: style: The scope of the variable 'proceeded_filters_hits' can be reduced. [variableScope] niceshaper-1.2.4/src/niceshaper.cc:733:17: style: The scope of the variable 'buf' can be reduced. [variableScope] niceshaper-1.2.4/src/niceshaper.cc:780:17: style: The scope of the variable 'counters' can be reduced. [variableScope] niceshaper-1.2.4/src/niceshaper.cc:794:17: style: The scope of the variable 'class_name' can be reduced. [variableScope] niceshaper-1.2.4/src/niceshaper.cc:30:36: performance: Function parameter 'section_name' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/niceshaper.cc:379:57: style: Parameter 'ipt_ordered_counters' can be declared as reference to const [constParameterReference] niceshaper-1.2.4/src/niceshaper.cc:379:100: style: Parameter 'ipt_ordered_counters_dnsw' can be declared as reference to const [constParameterReference] niceshaper-1.2.4/src/niceshaper.cc:790:62: style: Parameter 'counters_table' can be declared as reference to const [constParameterReference] niceshaper-1.2.4/src/niceshaper.cc:61:17: style: Unused variable: buf [unusedVariable] niceshaper-1.2.4/src/niceshaper.cc:65:69: style: Unused variable: fpvi_tmp [unusedVariable] niceshaper-1.2.4/src/niceshaper.cc:794:28: style: Variable 'class_name' is assigned a value that is never used. [unreadVariable] niceshaper-1.2.4/src/niceshaper.cc:129:13: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] niceshaper-1.2.4/src/niceshaper.cc:169:13: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] niceshaper-1.2.4/src/niceshaper.cc:210:9: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] niceshaper-1.2.4/src/niceshaper.cc:247:9: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] niceshaper-1.2.4/src/niceshaper.cc:259:21: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] niceshaper-1.2.4/src/niceshaper.cc:272:13: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] niceshaper-1.2.4/src/niceshaper.cc:811:9: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] niceshaper-1.2.4/src/supervisor.cc:136:122: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable timeval [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/supervisor.cc:211:109: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable O_WRONLY [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/supervisor.cc:568:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SHUT_RDWR [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/supervisor.cc:687:56: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable O_RDWR [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/supervisor.cc:74:13: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled] niceshaper-1.2.4/src/supervisor.cc:85:13: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled] niceshaper-1.2.4/src/supervisor.cc:137:5: style: Obsolescent function 'bzero' called. It is recommended to use 'memset' instead. [prohibitedbzeroCalled] niceshaper-1.2.4/src/supervisor.cc:277:17: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled] niceshaper-1.2.4/src/supervisor.cc:551:13: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled] niceshaper-1.2.4/src/supervisor.cc:560:13: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled] niceshaper-1.2.4/src/supervisor.cc:567:13: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled] niceshaper-1.2.4/src/supervisor.cc:599:17: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled] niceshaper-1.2.4/src/supervisor.cc:672:13: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled] niceshaper-1.2.4/src/supervisor.cc:551:21: error: Invalid usleep() argument nr 1. The value is 5000000 but the valid values are '0:999999'. [invalidFunctionArg] niceshaper-1.2.4/src/supervisor.cc:560:21: error: Invalid usleep() argument nr 1. The value is 5000000 but the valid values are '0:999999'. [invalidFunctionArg] niceshaper-1.2.4/src/supervisor.cc:567:21: error: Invalid usleep() argument nr 1. The value is 5000000 but the valid values are '0:999999'. [invalidFunctionArg] niceshaper-1.2.4/src/supervisor.cc:599:25: error: Invalid usleep() argument nr 1. The value is 1000000 but the valid values are '0:999999'. [invalidFunctionArg] niceshaper-1.2.4/src/supervisor.cc:39:13: warning: Member variable 'Supervisor::ThreadsExitRequestLock' is not initialized in the constructor. [uninitMemberVar] niceshaper-1.2.4/src/supervisor.cc:39:13: warning: Member variable 'Supervisor::ControllerHandlerLock' is not initialized in the constructor. [uninitMemberVar] niceshaper-1.2.4/src/supervisor.cc:39:13: warning: Member variable 'Supervisor::StatusFileOutOfDateLock' is not initialized in the constructor. [uninitMemberVar] niceshaper-1.2.4/src/supervisor.cc:196:28: style: Redundant condition: sao_container. '!sao_container || (sao_container && SAOContainterRequired)' is equivalent to '!sao_container || SAOContainterRequired' [redundantCondition] niceshaper-1.2.4/src/supervisor.cc:293:38: style: Condition 'recoverIpt()==-1' is always false [knownConditionTrueFalse] niceshaper-1.2.4/src/supervisor.cc:293:35: note: Calling function 'recoverIpt' returns 0 niceshaper-1.2.4/src/supervisor.cc:293:38: note: Condition 'recoverIpt()==-1' is always false niceshaper-1.2.4/src/supervisor.cc:319:34: style: Condition 'recoverQos()==-1' is always false [knownConditionTrueFalse] niceshaper-1.2.4/src/supervisor.cc:319:31: note: Calling function 'recoverQos' returns 0 niceshaper-1.2.4/src/supervisor.cc:319:34: note: Condition 'recoverQos()==-1' is always false niceshaper-1.2.4/src/supervisor.cc:211:65: error: Return value of allocation function 'creat' is not stored. [leakReturnValNotUsed] niceshaper-1.2.4/src/supervisor.cc:136:68: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/supervisor.cc:137:11: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/supervisor.cc:141:41: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/supervisor.cc:230:18: style: The scope of the variable 'next_worker_vid' can be reduced. [variableScope] niceshaper-1.2.4/src/supervisor.cc:519:9: style: The scope of the variable 'select_result' can be reduced. [variableScope] niceshaper-1.2.4/src/supervisor.cc:653:9: style: The scope of the variable 'fd' can be reduced. [variableScope] niceshaper-1.2.4/src/supervisor.cc:654:10: style: The scope of the variable 'out_of_date' can be reduced. [variableScope] niceshaper-1.2.4/src/supervisor.cc:654:23: style: The scope of the variable 'out_of_time' can be reduced. [variableScope] niceshaper-1.2.4/src/supervisor.cc:718:41: style: The scope of the variable 'value3' can be reduced. [variableScope] niceshaper-1.2.4/src/supervisor.cc:714:105: style: Parameter 'fpv_classfile' can be declared as reference to const [constParameterReference] niceshaper-1.2.4/src/supervisor.cc:729:71: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] niceshaper-1.2.4/src/supervisor.cc:734:73: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] niceshaper-1.2.4/src/supervisor.cc:752:9: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] niceshaper-1.2.4/src/supervisor.cc:780:13: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] niceshaper-1.2.4/src/sys.cc:121:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable tcmsg [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/sys.cc:213:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable tcmsg [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/sys.cc:283:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable tcmsg [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/sys.cc:361:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RTM_GETTCLASS [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/sys.cc:397:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TCA_MAX [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/sys.cc:442:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TCA_MAX [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/sys.cc:539:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TC_H_ROOT [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/sys.cc:587:58: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable HZ [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/sys.cc:43:5: performance: Variable 'QosClassId' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/sys.cc:44:5: performance: Variable 'Bytes' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/sys.cc:54:5: performance: Variable 'QosFilterId' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/sys.cc:55:5: performance: Variable 'Hits' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/sys.cc:534:10: performance:inconclusive: Technically the member function 'Sys::computeQosClassId' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/sys.h:63:13: note: Technically the member function 'Sys::computeQosClassId' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/sys.cc:534:10: note: Technically the member function 'Sys::computeQosClassId' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/sys.cc:560:10: performance:inconclusive: Technically the member function 'Sys::computeQosQdiscHandle' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/sys.h:64:13: note: Technically the member function 'Sys::computeQosQdiscHandle' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/sys.cc:560:10: note: Technically the member function 'Sys::computeQosQdiscHandle' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/sys.cc:573:10: performance:inconclusive: Technically the member function 'Sys::computeQosFilterId' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/sys.h:65:13: note: Technically the member function 'Sys::computeQosFilterId' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/sys.cc:573:10: note: Technically the member function 'Sys::computeQosFilterId' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/sys.cc:580:10: performance:inconclusive: Technically the member function 'Sys::getHz' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/sys.h:71:13: note: Technically the member function 'Sys::getHz' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/sys.cc:580:10: note: Technically the member function 'Sys::getHz' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/sys.cc:642:15: style:inconclusive: Technically the member function 'Sys::qosCoreTime2tick' can be const. [functionConst] niceshaper-1.2.4/src/sys.h:75:18: note: Technically the member function 'Sys::qosCoreTime2tick' can be const. niceshaper-1.2.4/src/sys.cc:642:15: note: Technically the member function 'Sys::qosCoreTime2tick' can be const. niceshaper-1.2.4/src/sys.cc:647:15: performance:inconclusive: Technically the member function 'Sys::qosAdjustSize' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/sys.h:76:18: note: Technically the member function 'Sys::qosAdjustSize' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/sys.cc:647:15: note: Technically the member function 'Sys::qosAdjustSize' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/sys.cc:65:5: warning: Class 'Sys' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] niceshaper-1.2.4/src/sys.cc:65:5: warning: Class 'Sys' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] niceshaper-1.2.4/src/sys.cc:304:65: style: Condition 'computeQosFilterId(tc_handle_id,&req.t.tcm_handle)==-1' is always false [knownConditionTrueFalse] niceshaper-1.2.4/src/sys.cc:304:31: note: Calling function 'computeQosFilterId' returns 0 niceshaper-1.2.4/src/sys.cc:304:65: note: Condition 'computeQosFilterId(tc_handle_id,&req.t.tcm_handle)==-1' is always false niceshaper-1.2.4/src/sys.cc:180:30: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/sys.cc:185:21: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/sys.cc:185:48: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/sys.cc:185:97: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/sys.cc:252:34: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/sys.cc:256:34: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/sys.cc:259:25: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/sys.cc:259:52: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/sys.cc:259:101: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/sys.cc:318:34: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/sys.cc:334:25: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/sys.cc:334:52: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/sys.cc:334:101: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/sys.cc:396:42: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/sys.cc:427:68: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/sys.cc:440:42: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/sys.cc:470:66: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/sys.cc:485:27: style: C-style pointer casting [cstyleCast] niceshaper-1.2.4/src/sys.cc:256:14: style: Variable 'tail' is reassigned a value before the old one has been used. [redundantAssignment] niceshaper-1.2.4/src/sys.cc:252:14: note: tail is assigned niceshaper-1.2.4/src/sys.cc:256:14: note: tail is overwritten niceshaper-1.2.4/src/sys.cc:300:14: style: Variable 'protocol' is reassigned a value before the old one has been used. [redundantAssignment] niceshaper-1.2.4/src/sys.cc:287:56: note: protocol is assigned niceshaper-1.2.4/src/sys.cc:300:14: note: protocol is overwritten niceshaper-1.2.4/src/sys.cc:206:20: style: The scope of the variable 'tail' can be reduced. [variableScope] niceshaper-1.2.4/src/sys.cc:277:20: style: The scope of the variable 'tail' can be reduced. [variableScope] niceshaper-1.2.4/src/sys.cc:614:14: style: The scope of the variable 'sz' can be reduced. [variableScope] niceshaper-1.2.4/src/sys.cc:106:25: style: struct member 'Anonymous0::buf' is never used. [unusedStructMember] niceshaper-1.2.4/src/sys.cc:202:25: style: struct member 'Anonymous1::buf' is never used. [unusedStructMember] niceshaper-1.2.4/src/sys.cc:272:25: style: struct member 'Anonymous2::buf' is never used. [unusedStructMember] niceshaper-1.2.4/src/talk.cc:32:11: performance:inconclusive: Technically the member function 'Talk::sendBool' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/talk.h:15:13: note: Technically the member function 'Talk::sendBool' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/talk.cc:32:11: note: Technically the member function 'Talk::sendBool' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/talk.cc:44:11: performance:inconclusive: Technically the member function 'Talk::recvBool' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/talk.h:16:13: note: Technically the member function 'Talk::recvBool' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/talk.cc:44:11: note: Technically the member function 'Talk::recvBool' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/talk.cc:63:11: performance:inconclusive: Technically the member function 'Talk::sendText' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/talk.h:17:13: note: Technically the member function 'Talk::sendText' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/talk.cc:63:11: note: Technically the member function 'Talk::sendText' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/talk.cc:84:11: performance:inconclusive: Technically the member function 'Talk::recvText' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/talk.h:18:13: note: Technically the member function 'Talk::recvText' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/talk.cc:84:11: note: Technically the member function 'Talk::recvText' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/talk.cc:36:29: style: Redundant initialization for 'cbuf'. The initialized value is overwritten before it is read. [redundantInitialization] niceshaper-1.2.4/src/talk.cc:34:15: note: cbuf is initialized niceshaper-1.2.4/src/talk.cc:36:29: note: cbuf is overwritten niceshaper-1.2.4/src/talk.cc:89:18: style: The scope of the variable 'msg_len' can be reduced. [variableScope] niceshaper-1.2.4/src/talk.cc:90:9: style: The scope of the variable 'msg_len_got' can be reduced. [variableScope] niceshaper-1.2.4/src/talk.cc:63:42: performance: Function parameter 'msg' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/talk.cc:120:63: style: Parameter 'msgv' can be declared as reference to const [constParameterReference] niceshaper-1.2.4/src/talk.cc:122:17: style: Unused variable: buf [unusedVariable] niceshaper-1.2.4/src/tests.cc:41:13: performance:inconclusive: Technically the member function 'Tests::validIp' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/tests.h:14:14: note: Technically the member function 'Tests::validIp' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.cc:41:13: note: Technically the member function 'Tests::validIp' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.cc:49:13: performance:inconclusive: Technically the member function 'Tests::validPort' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/tests.h:15:14: note: Technically the member function 'Tests::validPort' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.cc:49:13: note: Technically the member function 'Tests::validPort' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.cc:67:13: performance:inconclusive: Technically the member function 'Tests::fileExists' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/tests.h:17:14: note: Technically the member function 'Tests::fileExists' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.cc:67:13: note: Technically the member function 'Tests::fileExists' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.cc:76:13: performance:inconclusive: Technically the member function 'Tests::fileIsReadable' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/tests.h:18:14: note: Technically the member function 'Tests::fileIsReadable' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.cc:76:13: note: Technically the member function 'Tests::fileIsReadable' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.cc:85:13: performance:inconclusive: Technically the member function 'Tests::fileIsWriteable' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/tests.h:19:14: note: Technically the member function 'Tests::fileIsWriteable' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.cc:85:13: note: Technically the member function 'Tests::fileIsWriteable' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.cc:94:13: performance:inconclusive: Technically the member function 'Tests::fileIsExecutable' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/tests.h:20:14: note: Technically the member function 'Tests::fileIsExecutable' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.cc:94:13: note: Technically the member function 'Tests::fileIsExecutable' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.cc:103:13: performance:inconclusive: Technically the member function 'Tests::ifaceIsImq' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/tests.h:21:14: note: Technically the member function 'Tests::ifaceIsImq' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.cc:103:13: note: Technically the member function 'Tests::ifaceIsImq' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.cc:131:13: style:inconclusive: Technically the member function 'Tests::timerPrint' can be const. [functionConst] niceshaper-1.2.4/src/tests.h:24:14: note: Technically the member function 'Tests::timerPrint' can be const. niceshaper-1.2.4/src/tests.cc:131:13: note: Technically the member function 'Tests::timerPrint' can be const. niceshaper-1.2.4/src/tests.cc:41:33: performance: Function parameter 'ipaddr' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/tests.cc:55:37: performance: Function parameter 'ipmask' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/tests.cc:67:37: performance: Function parameter 'path' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/tests.cc:76:41: performance: Function parameter 'path' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/tests.cc:85:42: performance: Function parameter 'path' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/tests.cc:94:43: performance: Function parameter 'path' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/tests.cc:103:36: performance: Function parameter 'iface' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/tests.cc:110:49: performance: Function parameter 'path' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/trigger.cc:102:73: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/trigger.cc:195:72: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/trigger.cc:221:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/trigger.cc:290:27: style:inconclusive: Technically the member function 'TriggerQuota::dumpCounters' can be const. [functionConst] niceshaper-1.2.4/src/trigger.h:43:21: note: Technically the member function 'TriggerQuota::dumpCounters' can be const. niceshaper-1.2.4/src/trigger.cc:290:27: note: Technically the member function 'TriggerQuota::dumpCounters' can be const. niceshaper-1.2.4/src/trigger.cc:214:19: performance:inconclusive: Technically the member function 'TriggerQuota::readQuota' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/trigger.h:46:13: note: Technically the member function 'TriggerQuota::readQuota' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/trigger.cc:214:19: note: Technically the member function 'TriggerQuota::readQuota' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/trigger.cc:41:41: performance: Function parameter 'buf' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/trigger.cc:86:38: performance: Function parameter 'buf' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/trigger.cc:159:38: performance: Function parameter 'buf' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/trigger.cc:214:42: performance: Function parameter 'arg' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/worker.cc:64:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EBUSY [valueFlowBailoutIncompleteVar] niceshaper-1.2.4/src/worker.cc:32:9: warning: Member variable 'Worker::StatusTableUnformattedLock' is not initialized in the constructor. [uninitMemberVar] niceshaper-1.2.4/src/worker.cc:32:9: warning: Member variable 'Worker::QuotaSavePrevSec' is not initialized in the constructor. [uninitMemberVar] niceshaper-1.2.4/src/worker.cc:32:9: warning: Member variable 'Worker::CycleReportPrevSec' is not initialized in the constructor. [uninitMemberVar] niceshaper-1.2.4/src/worker.cc:34:5: performance: Variable 'SectionName' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/worker.cc:38:5: performance: Variable 'QuotaFile' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/worker.cc:355:5: performance: Variable 'TVReloadDemand' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] niceshaper-1.2.4/src/worker.cc:283:21: performance:inconclusive: Technically the member function 'Worker::statusUndent' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/worker.h:35:21: note: Technically the member function 'Worker::statusUndent' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/worker.cc:283:21: note: Technically the member function 'Worker::statusUndent' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/worker.cc:295:21: performance:inconclusive: Technically the member function 'Worker::statusIndent' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/worker.h:36:21: note: Technically the member function 'Worker::statusIndent' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/worker.cc:295:21: note: Technically the member function 'Worker::statusIndent' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/worker.cc:194:17: style: The scope of the variable 'buf' can be reduced. [variableScope] niceshaper-1.2.4/src/worker.cc:229:17: style: The scope of the variable 'status_row' can be reduced. [variableScope] niceshaper-1.2.4/src/worker.cc:230:17: style: The scope of the variable 'buf' can be reduced. [variableScope] niceshaper-1.2.4/src/worker.cc:336:31: style: The scope of the variable 'quota_counters_table' can be reduced. [variableScope] niceshaper-1.2.4/src/worker.cc:338:17: style: The scope of the variable 'buf' can be reduced. [variableScope] niceshaper-1.2.4/src/worker.cc:32:28: performance: Function parameter 'section_name' should be passed by const reference. [passedByValue] niceshaper-1.2.4/src/worker.cc:160:54: style: Parameter 'tv_curr' can be declared as reference to const [constParameterReference] niceshaper-1.2.4/src/worker.cc:160:79: style: Parameter 'tv_prev' can be declared as reference to const [constParameterReference] niceshaper-1.2.4/src/worker.cc:194:21: style: Variable 'buf' is assigned a value that is never used. [unreadVariable] niceshaper-1.2.4/src/worker.cc:322:17: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] diff: head niceshaper-1.2.4/src/class.cc:432:23: style:inconclusive: Technically the member function 'NsClass::trafficPrognosed' can be const. [functionConst] niceshaper-1.2.4/src/class.h:25:22: note: Technically the member function 'NsClass::trafficPrognosed' can be const. niceshaper-1.2.4/src/class.cc:432:23: note: Technically the member function 'NsClass::trafficPrognosed' can be const. head niceshaper-1.2.4/src/class.cc:583:22: style:inconclusive: Technically the member function 'NsClass::status' can be const. [functionConst] niceshaper-1.2.4/src/class.h:32:21: note: Technically the member function 'NsClass::status' can be const. niceshaper-1.2.4/src/class.cc:583:22: note: Technically the member function 'NsClass::status' can be const. head niceshaper-1.2.4/src/class.cc:624:23: style:inconclusive: Technically the member function 'NsClass::getTcFiltersNum' can be const. [functionConst] niceshaper-1.2.4/src/class.h:55:22: note: Technically the member function 'NsClass::getTcFiltersNum' can be const. niceshaper-1.2.4/src/class.cc:624:23: note: Technically the member function 'NsClass::getTcFiltersNum' can be const. 2.17.0 niceshaper-1.2.4/src/class.h:25:22: style:inconclusive: Technically the member function 'NsClass::trafficPrognosed' can be const. [functionConst] niceshaper-1.2.4/src/class.cc:432:23: note: Technically the member function 'NsClass::trafficPrognosed' can be const. niceshaper-1.2.4/src/class.h:25:22: note: Technically the member function 'NsClass::trafficPrognosed' can be const. 2.17.0 niceshaper-1.2.4/src/class.h:32:21: style:inconclusive: Technically the member function 'NsClass::status' can be const. [functionConst] niceshaper-1.2.4/src/class.cc:583:22: note: Technically the member function 'NsClass::status' can be const. niceshaper-1.2.4/src/class.h:32:21: note: Technically the member function 'NsClass::status' can be const. 2.17.0 niceshaper-1.2.4/src/class.h:55:22: style:inconclusive: Technically the member function 'NsClass::getTcFiltersNum' can be const. [functionConst] niceshaper-1.2.4/src/class.cc:624:23: note: Technically the member function 'NsClass::getTcFiltersNum' can be const. niceshaper-1.2.4/src/class.h:55:22: note: Technically the member function 'NsClass::getTcFiltersNum' can be const. head niceshaper-1.2.4/src/config.cc:465:13: performance:inconclusive: Technically the member function 'Config::proceedLoopMacro' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/config.h:18:13: note: Technically the member function 'Config::proceedLoopMacro' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/config.cc:465:13: note: Technically the member function 'Config::proceedLoopMacro' can be static (but you may consider moving to unnamed namespace). head niceshaper-1.2.4/src/config.cc:85:21: performance:inconclusive: Technically the member function 'Config::getLine' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/config.h:57:21: note: Technically the member function 'Config::getLine' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/config.cc:85:21: note: Technically the member function 'Config::getLine' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/config.h:18:13: performance:inconclusive: Technically the member function 'Config::proceedLoopMacro' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/config.cc:465:13: note: Technically the member function 'Config::proceedLoopMacro' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/config.h:18:13: note: Technically the member function 'Config::proceedLoopMacro' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/config.h:57:21: performance:inconclusive: Technically the member function 'Config::getLine' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/config.cc:85:21: note: Technically the member function 'Config::getLine' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/config.h:57:21: note: Technically the member function 'Config::getLine' can be static (but you may consider moving to unnamed namespace). head niceshaper-1.2.4/src/filter.cc:131:16: style:inconclusive: Technically the member function 'TcFilter::getIptRequiredToOperate' can be const. [functionConst] niceshaper-1.2.4/src/filter.h:29:14: note: Technically the member function 'TcFilter::getIptRequiredToOperate' can be const. niceshaper-1.2.4/src/filter.cc:131:16: note: Technically the member function 'TcFilter::getIptRequiredToOperate' can be const. head niceshaper-1.2.4/src/filter.cc:139:16: style:inconclusive: Technically the member function 'TcFilter::getIptRequiredToCheckActivity' can be const. [functionConst] niceshaper-1.2.4/src/filter.h:30:14: note: Technically the member function 'TcFilter::getIptRequiredToCheckActivity' can be const. niceshaper-1.2.4/src/filter.cc:139:16: note: Technically the member function 'TcFilter::getIptRequiredToCheckActivity' can be const. head niceshaper-1.2.4/src/filter.cc:147:16: style:inconclusive: Technically the member function 'TcFilter::getIptRequiredToCheckTraffic' can be const. [functionConst] niceshaper-1.2.4/src/filter.h:31:14: note: Technically the member function 'TcFilter::getIptRequiredToCheckTraffic' can be const. niceshaper-1.2.4/src/filter.cc:147:16: note: Technically the member function 'TcFilter::getIptRequiredToCheckTraffic' can be const. head niceshaper-1.2.4/src/filter.cc:244:15: style:inconclusive: Technically the member function 'TcFilter::del' can be const. [functionConst] niceshaper-1.2.4/src/filter.h:24:13: note: Technically the member function 'TcFilter::del' can be const. niceshaper-1.2.4/src/filter.cc:244:15: note: Technically the member function 'TcFilter::del' can be const. head niceshaper-1.2.4/src/filter.cc:321:15: performance:inconclusive: Technically the member function 'TcFilter::packKey' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/filter.h:37:13: note: Technically the member function 'TcFilter::packKey' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/filter.cc:321:15: note: Technically the member function 'TcFilter::packKey' can be static (but you may consider moving to unnamed namespace). head niceshaper-1.2.4/src/filter.cc:390:15: performance:inconclusive: Technically the member function 'TcFilter::getU32' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/filter.h:34:13: note: Technically the member function 'TcFilter::getU32' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/filter.cc:390:15: note: Technically the member function 'TcFilter::getU32' can be static (but you may consider moving to unnamed namespace). head niceshaper-1.2.4/src/filter.cc:421:15: performance:inconclusive: Technically the member function 'TcFilter::getAddrIpv4' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/filter.h:41:13: note: Technically the member function 'TcFilter::getAddrIpv4' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/filter.cc:421:15: note: Technically the member function 'TcFilter::getAddrIpv4' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/filter.h:24:13: style:inconclusive: Technically the member function 'TcFilter::del' can be const. [functionConst] niceshaper-1.2.4/src/filter.cc:244:15: note: Technically the member function 'TcFilter::del' can be const. niceshaper-1.2.4/src/filter.h:24:13: note: Technically the member function 'TcFilter::del' can be const. 2.17.0 niceshaper-1.2.4/src/filter.h:29:14: style:inconclusive: Technically the member function 'TcFilter::getIptRequiredToOperate' can be const. [functionConst] niceshaper-1.2.4/src/filter.cc:131:16: note: Technically the member function 'TcFilter::getIptRequiredToOperate' can be const. niceshaper-1.2.4/src/filter.h:29:14: note: Technically the member function 'TcFilter::getIptRequiredToOperate' can be const. 2.17.0 niceshaper-1.2.4/src/filter.h:30:14: style:inconclusive: Technically the member function 'TcFilter::getIptRequiredToCheckActivity' can be const. [functionConst] niceshaper-1.2.4/src/filter.cc:139:16: note: Technically the member function 'TcFilter::getIptRequiredToCheckActivity' can be const. niceshaper-1.2.4/src/filter.h:30:14: note: Technically the member function 'TcFilter::getIptRequiredToCheckActivity' can be const. 2.17.0 niceshaper-1.2.4/src/filter.h:31:14: style:inconclusive: Technically the member function 'TcFilter::getIptRequiredToCheckTraffic' can be const. [functionConst] niceshaper-1.2.4/src/filter.cc:147:16: note: Technically the member function 'TcFilter::getIptRequiredToCheckTraffic' can be const. niceshaper-1.2.4/src/filter.h:31:14: note: Technically the member function 'TcFilter::getIptRequiredToCheckTraffic' can be const. 2.17.0 niceshaper-1.2.4/src/filter.h:34:13: performance:inconclusive: Technically the member function 'TcFilter::getU32' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/filter.cc:390:15: note: Technically the member function 'TcFilter::getU32' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/filter.h:34:13: note: Technically the member function 'TcFilter::getU32' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/filter.h:37:13: performance:inconclusive: Technically the member function 'TcFilter::packKey' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/filter.cc:321:15: note: Technically the member function 'TcFilter::packKey' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/filter.h:37:13: note: Technically the member function 'TcFilter::packKey' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/filter.h:41:13: performance:inconclusive: Technically the member function 'TcFilter::getAddrIpv4' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/filter.cc:421:15: note: Technically the member function 'TcFilter::getAddrIpv4' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/filter.h:41:13: note: Technically the member function 'TcFilter::getAddrIpv4' can be static (but you may consider moving to unnamed namespace). head niceshaper-1.2.4/src/ifaces.cc:261:16: style:inconclusive: Technically the member function 'IfacesMap::initHtbOnControlled' can be const. [functionConst] niceshaper-1.2.4/src/ifaces.h:55:13: note: Technically the member function 'IfacesMap::initHtbOnControlled' can be const. niceshaper-1.2.4/src/ifaces.cc:261:16: note: Technically the member function 'IfacesMap::initHtbOnControlled' can be const. head niceshaper-1.2.4/src/ifaces.cc:311:16: style:inconclusive: Technically the member function 'IfacesMap::endUpHtbFallbackOnControlled' can be const. [functionConst] niceshaper-1.2.4/src/ifaces.h:56:13: note: Technically the member function 'IfacesMap::endUpHtbFallbackOnControlled' can be const. niceshaper-1.2.4/src/ifaces.cc:311:16: note: Technically the member function 'IfacesMap::endUpHtbFallbackOnControlled' can be const. head niceshaper-1.2.4/src/ifaces.cc:332:25: style:inconclusive: Technically the member function 'IfacesMap::htbDNWrapperId' can be const. [functionConst] niceshaper-1.2.4/src/ifaces.h:57:22: note: Technically the member function 'IfacesMap::htbDNWrapperId' can be const. niceshaper-1.2.4/src/ifaces.cc:332:25: note: Technically the member function 'IfacesMap::htbDNWrapperId' can be const. 2.17.0 niceshaper-1.2.4/src/ifaces.h:55:13: style:inconclusive: Technically the member function 'IfacesMap::initHtbOnControlled' can be const. [functionConst] niceshaper-1.2.4/src/ifaces.cc:261:16: note: Technically the member function 'IfacesMap::initHtbOnControlled' can be const. niceshaper-1.2.4/src/ifaces.h:55:13: note: Technically the member function 'IfacesMap::initHtbOnControlled' can be const. 2.17.0 niceshaper-1.2.4/src/ifaces.h:56:13: style:inconclusive: Technically the member function 'IfacesMap::endUpHtbFallbackOnControlled' can be const. [functionConst] niceshaper-1.2.4/src/ifaces.cc:311:16: note: Technically the member function 'IfacesMap::endUpHtbFallbackOnControlled' can be const. niceshaper-1.2.4/src/ifaces.h:56:13: note: Technically the member function 'IfacesMap::endUpHtbFallbackOnControlled' can be const. 2.17.0 niceshaper-1.2.4/src/ifaces.h:57:22: style:inconclusive: Technically the member function 'IfacesMap::htbDNWrapperId' can be const. [functionConst] niceshaper-1.2.4/src/ifaces.cc:332:25: note: Technically the member function 'IfacesMap::htbDNWrapperId' can be const. niceshaper-1.2.4/src/ifaces.h:57:22: note: Technically the member function 'IfacesMap::htbDNWrapperId' can be const. head niceshaper-1.2.4/src/iptables.cc:126:15: style:inconclusive: Technically the member function 'Iptables::execSysCmd' can be const. [functionConst] niceshaper-1.2.4/src/iptables.h:31:13: note: Technically the member function 'Iptables::execSysCmd' can be const. niceshaper-1.2.4/src/iptables.cc:126:15: note: Technically the member function 'Iptables::execSysCmd' can be const. head niceshaper-1.2.4/src/iptables.cc:409:15: performance:inconclusive: Technically the member function 'Iptables::genFilterFromNSMatch' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/iptables.h:28:13: note: Technically the member function 'Iptables::genFilterFromNSMatch' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/iptables.cc:409:15: note: Technically the member function 'Iptables::genFilterFromNSMatch' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/iptables.h:28:13: performance:inconclusive: Technically the member function 'Iptables::genFilterFromNSMatch' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/iptables.cc:409:15: note: Technically the member function 'Iptables::genFilterFromNSMatch' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/iptables.h:28:13: note: Technically the member function 'Iptables::genFilterFromNSMatch' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/iptables.h:31:13: style:inconclusive: Technically the member function 'Iptables::execSysCmd' can be const. [functionConst] niceshaper-1.2.4/src/iptables.cc:126:15: note: Technically the member function 'Iptables::execSysCmd' can be const. niceshaper-1.2.4/src/iptables.h:31:13: note: Technically the member function 'Iptables::execSysCmd' can be const. head niceshaper-1.2.4/src/libnetlink.cc:97:62: style: C-style pointer casting [cstyleCast] head niceshaper-1.2.4/src/logger.cc:320:21: style:inconclusive: Technically the member function 'Logger::getWarningMessage' can be const. [functionConst] niceshaper-1.2.4/src/logger.h:15:21: note: Technically the member function 'Logger::getWarningMessage' can be const. niceshaper-1.2.4/src/logger.cc:320:21: note: Technically the member function 'Logger::getWarningMessage' can be const. head niceshaper-1.2.4/src/logger.cc:360:21: style:inconclusive: Technically the member function 'Logger::getInfoMessage' can be const. [functionConst] niceshaper-1.2.4/src/logger.h:16:21: note: Technically the member function 'Logger::getInfoMessage' can be const. niceshaper-1.2.4/src/logger.cc:360:21: note: Technically the member function 'Logger::getInfoMessage' can be const. head niceshaper-1.2.4/src/logger.cc:45:21: style:inconclusive: Technically the member function 'Logger::getErrorMessage' can be const. [functionConst] niceshaper-1.2.4/src/logger.h:14:21: note: Technically the member function 'Logger::getErrorMessage' can be const. niceshaper-1.2.4/src/logger.cc:45:21: note: Technically the member function 'Logger::getErrorMessage' can be const. head niceshaper-1.2.4/src/logger.cc:512:14: performance:inconclusive: Technically the member function 'Logger::toSyslog' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/logger.h:31:14: note: Technically the member function 'Logger::toSyslog' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/logger.cc:512:14: note: Technically the member function 'Logger::toSyslog' can be static (but you may consider moving to unnamed namespace). head niceshaper-1.2.4/src/logger.cc:532:17: style: Variable 'message' is assigned a value that is never used. [unreadVariable] 2.17.0 niceshaper-1.2.4/src/logger.h:14:21: style:inconclusive: Technically the member function 'Logger::getErrorMessage' can be const. [functionConst] niceshaper-1.2.4/src/logger.cc:45:21: note: Technically the member function 'Logger::getErrorMessage' can be const. niceshaper-1.2.4/src/logger.h:14:21: note: Technically the member function 'Logger::getErrorMessage' can be const. 2.17.0 niceshaper-1.2.4/src/logger.h:15:21: style:inconclusive: Technically the member function 'Logger::getWarningMessage' can be const. [functionConst] niceshaper-1.2.4/src/logger.cc:320:21: note: Technically the member function 'Logger::getWarningMessage' can be const. niceshaper-1.2.4/src/logger.h:15:21: note: Technically the member function 'Logger::getWarningMessage' can be const. 2.17.0 niceshaper-1.2.4/src/logger.h:16:21: style:inconclusive: Technically the member function 'Logger::getInfoMessage' can be const. [functionConst] niceshaper-1.2.4/src/logger.cc:360:21: note: Technically the member function 'Logger::getInfoMessage' can be const. niceshaper-1.2.4/src/logger.h:16:21: note: Technically the member function 'Logger::getInfoMessage' can be const. 2.17.0 niceshaper-1.2.4/src/logger.h:31:14: performance:inconclusive: Technically the member function 'Logger::toSyslog' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/logger.cc:512:14: note: Technically the member function 'Logger::toSyslog' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/logger.h:31:14: note: Technically the member function 'Logger::toSyslog' can be static (but you may consider moving to unnamed namespace). head niceshaper-1.2.4/src/niceshaper.cc:352:31: style:inconclusive: Technically the member function 'NiceShaper::getFlowDirection' can be const. [functionConst] niceshaper-1.2.4/src/niceshaper.h:15:27: note: Technically the member function 'NiceShaper::getFlowDirection' can be const. niceshaper-1.2.4/src/niceshaper.cc:352:31: note: Technically the member function 'NiceShaper::getFlowDirection' can be const. head niceshaper-1.2.4/src/niceshaper.cc:367:18: style:inconclusive: Technically the member function 'NiceShaper::getIptRequired' can be const. [functionConst] niceshaper-1.2.4/src/niceshaper.h:18:14: note: Technically the member function 'NiceShaper::getIptRequired' can be const. niceshaper-1.2.4/src/niceshaper.cc:367:18: note: Technically the member function 'NiceShaper::getIptRequired' can be const. head niceshaper-1.2.4/src/niceshaper.cc:372:18: style:inconclusive: Technically the member function 'NiceShaper::getIptRequiredToCheck' can be const. [functionConst] niceshaper-1.2.4/src/niceshaper.h:19:14: note: Technically the member function 'NiceShaper::getIptRequiredToCheck' can be const. niceshaper-1.2.4/src/niceshaper.cc:372:18: note: Technically the member function 'NiceShaper::getIptRequiredToCheck' can be const. head niceshaper-1.2.4/src/niceshaper.cc:777:39: style:inconclusive: Technically the member function 'NiceShaper::dumpQuotaCounters' can be const. [functionConst] niceshaper-1.2.4/src/niceshaper.h:23:35: note: Technically the member function 'NiceShaper::dumpQuotaCounters' can be const. niceshaper-1.2.4/src/niceshaper.cc:777:39: note: Technically the member function 'NiceShaper::dumpQuotaCounters' can be const. 2.17.0 niceshaper-1.2.4/src/niceshaper.h:15:27: style:inconclusive: Technically the member function 'NiceShaper::getFlowDirection' can be const. [functionConst] niceshaper-1.2.4/src/niceshaper.cc:352:31: note: Technically the member function 'NiceShaper::getFlowDirection' can be const. niceshaper-1.2.4/src/niceshaper.h:15:27: note: Technically the member function 'NiceShaper::getFlowDirection' can be const. 2.17.0 niceshaper-1.2.4/src/niceshaper.h:18:14: style:inconclusive: Technically the member function 'NiceShaper::getIptRequired' can be const. [functionConst] niceshaper-1.2.4/src/niceshaper.cc:367:18: note: Technically the member function 'NiceShaper::getIptRequired' can be const. niceshaper-1.2.4/src/niceshaper.h:18:14: note: Technically the member function 'NiceShaper::getIptRequired' can be const. 2.17.0 niceshaper-1.2.4/src/niceshaper.h:19:14: style:inconclusive: Technically the member function 'NiceShaper::getIptRequiredToCheck' can be const. [functionConst] niceshaper-1.2.4/src/niceshaper.cc:372:18: note: Technically the member function 'NiceShaper::getIptRequiredToCheck' can be const. niceshaper-1.2.4/src/niceshaper.h:19:14: note: Technically the member function 'NiceShaper::getIptRequiredToCheck' can be const. 2.17.0 niceshaper-1.2.4/src/niceshaper.h:23:35: style:inconclusive: Technically the member function 'NiceShaper::dumpQuotaCounters' can be const. [functionConst] niceshaper-1.2.4/src/niceshaper.cc:777:39: note: Technically the member function 'NiceShaper::dumpQuotaCounters' can be const. niceshaper-1.2.4/src/niceshaper.h:23:35: note: Technically the member function 'NiceShaper::dumpQuotaCounters' can be const. head niceshaper-1.2.4/src/sys.cc:185:48: style: C-style pointer casting [cstyleCast] head niceshaper-1.2.4/src/sys.cc:185:97: style: C-style pointer casting [cstyleCast] head niceshaper-1.2.4/src/sys.cc:259:101: style: C-style pointer casting [cstyleCast] head niceshaper-1.2.4/src/sys.cc:259:52: style: C-style pointer casting [cstyleCast] head niceshaper-1.2.4/src/sys.cc:334:101: style: C-style pointer casting [cstyleCast] head niceshaper-1.2.4/src/sys.cc:334:52: style: C-style pointer casting [cstyleCast] head niceshaper-1.2.4/src/sys.cc:534:10: performance:inconclusive: Technically the member function 'Sys::computeQosClassId' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/sys.h:63:13: note: Technically the member function 'Sys::computeQosClassId' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/sys.cc:534:10: note: Technically the member function 'Sys::computeQosClassId' can be static (but you may consider moving to unnamed namespace). head niceshaper-1.2.4/src/sys.cc:560:10: performance:inconclusive: Technically the member function 'Sys::computeQosQdiscHandle' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/sys.h:64:13: note: Technically the member function 'Sys::computeQosQdiscHandle' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/sys.cc:560:10: note: Technically the member function 'Sys::computeQosQdiscHandle' can be static (but you may consider moving to unnamed namespace). head niceshaper-1.2.4/src/sys.cc:573:10: performance:inconclusive: Technically the member function 'Sys::computeQosFilterId' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/sys.h:65:13: note: Technically the member function 'Sys::computeQosFilterId' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/sys.cc:573:10: note: Technically the member function 'Sys::computeQosFilterId' can be static (but you may consider moving to unnamed namespace). head niceshaper-1.2.4/src/sys.cc:580:10: performance:inconclusive: Technically the member function 'Sys::getHz' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/sys.h:71:13: note: Technically the member function 'Sys::getHz' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/sys.cc:580:10: note: Technically the member function 'Sys::getHz' can be static (but you may consider moving to unnamed namespace). head niceshaper-1.2.4/src/sys.cc:642:15: style:inconclusive: Technically the member function 'Sys::qosCoreTime2tick' can be const. [functionConst] niceshaper-1.2.4/src/sys.h:75:18: note: Technically the member function 'Sys::qosCoreTime2tick' can be const. niceshaper-1.2.4/src/sys.cc:642:15: note: Technically the member function 'Sys::qosCoreTime2tick' can be const. head niceshaper-1.2.4/src/sys.cc:647:15: performance:inconclusive: Technically the member function 'Sys::qosAdjustSize' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/sys.h:76:18: note: Technically the member function 'Sys::qosAdjustSize' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/sys.cc:647:15: note: Technically the member function 'Sys::qosAdjustSize' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/sys.h:63:13: performance:inconclusive: Technically the member function 'Sys::computeQosClassId' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/sys.cc:534:10: note: Technically the member function 'Sys::computeQosClassId' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/sys.h:63:13: note: Technically the member function 'Sys::computeQosClassId' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/sys.h:64:13: performance:inconclusive: Technically the member function 'Sys::computeQosQdiscHandle' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/sys.cc:560:10: note: Technically the member function 'Sys::computeQosQdiscHandle' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/sys.h:64:13: note: Technically the member function 'Sys::computeQosQdiscHandle' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/sys.h:65:13: performance:inconclusive: Technically the member function 'Sys::computeQosFilterId' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/sys.cc:573:10: note: Technically the member function 'Sys::computeQosFilterId' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/sys.h:65:13: note: Technically the member function 'Sys::computeQosFilterId' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/sys.h:71:13: performance:inconclusive: Technically the member function 'Sys::getHz' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/sys.cc:580:10: note: Technically the member function 'Sys::getHz' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/sys.h:71:13: note: Technically the member function 'Sys::getHz' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/sys.h:75:18: style:inconclusive: Technically the member function 'Sys::qosCoreTime2tick' can be const. [functionConst] niceshaper-1.2.4/src/sys.cc:642:15: note: Technically the member function 'Sys::qosCoreTime2tick' can be const. niceshaper-1.2.4/src/sys.h:75:18: note: Technically the member function 'Sys::qosCoreTime2tick' can be const. 2.17.0 niceshaper-1.2.4/src/sys.h:76:18: performance:inconclusive: Technically the member function 'Sys::qosAdjustSize' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/sys.cc:647:15: note: Technically the member function 'Sys::qosAdjustSize' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/sys.h:76:18: note: Technically the member function 'Sys::qosAdjustSize' can be static (but you may consider moving to unnamed namespace). head niceshaper-1.2.4/src/talk.cc:32:11: performance:inconclusive: Technically the member function 'Talk::sendBool' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/talk.h:15:13: note: Technically the member function 'Talk::sendBool' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/talk.cc:32:11: note: Technically the member function 'Talk::sendBool' can be static (but you may consider moving to unnamed namespace). head niceshaper-1.2.4/src/talk.cc:44:11: performance:inconclusive: Technically the member function 'Talk::recvBool' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/talk.h:16:13: note: Technically the member function 'Talk::recvBool' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/talk.cc:44:11: note: Technically the member function 'Talk::recvBool' can be static (but you may consider moving to unnamed namespace). head niceshaper-1.2.4/src/talk.cc:63:11: performance:inconclusive: Technically the member function 'Talk::sendText' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/talk.h:17:13: note: Technically the member function 'Talk::sendText' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/talk.cc:63:11: note: Technically the member function 'Talk::sendText' can be static (but you may consider moving to unnamed namespace). head niceshaper-1.2.4/src/talk.cc:84:11: performance:inconclusive: Technically the member function 'Talk::recvText' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/talk.h:18:13: note: Technically the member function 'Talk::recvText' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/talk.cc:84:11: note: Technically the member function 'Talk::recvText' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/talk.h:15:13: performance:inconclusive: Technically the member function 'Talk::sendBool' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/talk.cc:32:11: note: Technically the member function 'Talk::sendBool' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/talk.h:15:13: note: Technically the member function 'Talk::sendBool' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/talk.h:16:13: performance:inconclusive: Technically the member function 'Talk::recvBool' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/talk.cc:44:11: note: Technically the member function 'Talk::recvBool' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/talk.h:16:13: note: Technically the member function 'Talk::recvBool' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/talk.h:17:13: performance:inconclusive: Technically the member function 'Talk::sendText' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/talk.cc:63:11: note: Technically the member function 'Talk::sendText' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/talk.h:17:13: note: Technically the member function 'Talk::sendText' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/talk.h:18:13: performance:inconclusive: Technically the member function 'Talk::recvText' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/talk.cc:84:11: note: Technically the member function 'Talk::recvText' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/talk.h:18:13: note: Technically the member function 'Talk::recvText' can be static (but you may consider moving to unnamed namespace). head niceshaper-1.2.4/src/tests.cc:103:13: performance:inconclusive: Technically the member function 'Tests::ifaceIsImq' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/tests.h:21:14: note: Technically the member function 'Tests::ifaceIsImq' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.cc:103:13: note: Technically the member function 'Tests::ifaceIsImq' can be static (but you may consider moving to unnamed namespace). head niceshaper-1.2.4/src/tests.cc:131:13: style:inconclusive: Technically the member function 'Tests::timerPrint' can be const. [functionConst] niceshaper-1.2.4/src/tests.h:24:14: note: Technically the member function 'Tests::timerPrint' can be const. niceshaper-1.2.4/src/tests.cc:131:13: note: Technically the member function 'Tests::timerPrint' can be const. head niceshaper-1.2.4/src/tests.cc:41:13: performance:inconclusive: Technically the member function 'Tests::validIp' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/tests.h:14:14: note: Technically the member function 'Tests::validIp' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.cc:41:13: note: Technically the member function 'Tests::validIp' can be static (but you may consider moving to unnamed namespace). head niceshaper-1.2.4/src/tests.cc:49:13: performance:inconclusive: Technically the member function 'Tests::validPort' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/tests.h:15:14: note: Technically the member function 'Tests::validPort' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.cc:49:13: note: Technically the member function 'Tests::validPort' can be static (but you may consider moving to unnamed namespace). head niceshaper-1.2.4/src/tests.cc:67:13: performance:inconclusive: Technically the member function 'Tests::fileExists' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/tests.h:17:14: note: Technically the member function 'Tests::fileExists' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.cc:67:13: note: Technically the member function 'Tests::fileExists' can be static (but you may consider moving to unnamed namespace). head niceshaper-1.2.4/src/tests.cc:76:13: performance:inconclusive: Technically the member function 'Tests::fileIsReadable' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/tests.h:18:14: note: Technically the member function 'Tests::fileIsReadable' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.cc:76:13: note: Technically the member function 'Tests::fileIsReadable' can be static (but you may consider moving to unnamed namespace). head niceshaper-1.2.4/src/tests.cc:85:13: performance:inconclusive: Technically the member function 'Tests::fileIsWriteable' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/tests.h:19:14: note: Technically the member function 'Tests::fileIsWriteable' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.cc:85:13: note: Technically the member function 'Tests::fileIsWriteable' can be static (but you may consider moving to unnamed namespace). head niceshaper-1.2.4/src/tests.cc:94:13: performance:inconclusive: Technically the member function 'Tests::fileIsExecutable' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/tests.h:20:14: note: Technically the member function 'Tests::fileIsExecutable' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.cc:94:13: note: Technically the member function 'Tests::fileIsExecutable' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/tests.h:14:14: performance:inconclusive: Technically the member function 'Tests::validIp' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/tests.cc:41:13: note: Technically the member function 'Tests::validIp' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.h:14:14: note: Technically the member function 'Tests::validIp' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/tests.h:15:14: performance:inconclusive: Technically the member function 'Tests::validPort' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/tests.cc:49:13: note: Technically the member function 'Tests::validPort' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.h:15:14: note: Technically the member function 'Tests::validPort' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/tests.h:17:14: performance:inconclusive: Technically the member function 'Tests::fileExists' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/tests.cc:67:13: note: Technically the member function 'Tests::fileExists' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.h:17:14: note: Technically the member function 'Tests::fileExists' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/tests.h:18:14: performance:inconclusive: Technically the member function 'Tests::fileIsReadable' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/tests.cc:76:13: note: Technically the member function 'Tests::fileIsReadable' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.h:18:14: note: Technically the member function 'Tests::fileIsReadable' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/tests.h:19:14: performance:inconclusive: Technically the member function 'Tests::fileIsWriteable' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/tests.cc:85:13: note: Technically the member function 'Tests::fileIsWriteable' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.h:19:14: note: Technically the member function 'Tests::fileIsWriteable' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/tests.h:20:14: performance:inconclusive: Technically the member function 'Tests::fileIsExecutable' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/tests.cc:94:13: note: Technically the member function 'Tests::fileIsExecutable' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.h:20:14: note: Technically the member function 'Tests::fileIsExecutable' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/tests.h:21:14: performance:inconclusive: Technically the member function 'Tests::ifaceIsImq' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/tests.cc:103:13: note: Technically the member function 'Tests::ifaceIsImq' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/tests.h:21:14: note: Technically the member function 'Tests::ifaceIsImq' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/tests.h:24:14: style:inconclusive: Technically the member function 'Tests::timerPrint' can be const. [functionConst] niceshaper-1.2.4/src/tests.cc:131:13: note: Technically the member function 'Tests::timerPrint' can be const. niceshaper-1.2.4/src/tests.h:24:14: note: Technically the member function 'Tests::timerPrint' can be const. head niceshaper-1.2.4/src/trigger.cc:214:19: performance:inconclusive: Technically the member function 'TriggerQuota::readQuota' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/trigger.h:46:13: note: Technically the member function 'TriggerQuota::readQuota' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/trigger.cc:214:19: note: Technically the member function 'TriggerQuota::readQuota' can be static (but you may consider moving to unnamed namespace). head niceshaper-1.2.4/src/trigger.cc:290:27: style:inconclusive: Technically the member function 'TriggerQuota::dumpCounters' can be const. [functionConst] niceshaper-1.2.4/src/trigger.h:43:21: note: Technically the member function 'TriggerQuota::dumpCounters' can be const. niceshaper-1.2.4/src/trigger.cc:290:27: note: Technically the member function 'TriggerQuota::dumpCounters' can be const. 2.17.0 niceshaper-1.2.4/src/trigger.h:43:21: style:inconclusive: Technically the member function 'TriggerQuota::dumpCounters' can be const. [functionConst] niceshaper-1.2.4/src/trigger.cc:290:27: note: Technically the member function 'TriggerQuota::dumpCounters' can be const. niceshaper-1.2.4/src/trigger.h:43:21: note: Technically the member function 'TriggerQuota::dumpCounters' can be const. 2.17.0 niceshaper-1.2.4/src/trigger.h:46:13: performance:inconclusive: Technically the member function 'TriggerQuota::readQuota' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/trigger.cc:214:19: note: Technically the member function 'TriggerQuota::readQuota' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/trigger.h:46:13: note: Technically the member function 'TriggerQuota::readQuota' can be static (but you may consider moving to unnamed namespace). head niceshaper-1.2.4/src/worker.cc:283:21: performance:inconclusive: Technically the member function 'Worker::statusUndent' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/worker.h:35:21: note: Technically the member function 'Worker::statusUndent' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/worker.cc:283:21: note: Technically the member function 'Worker::statusUndent' can be static (but you may consider moving to unnamed namespace). head niceshaper-1.2.4/src/worker.cc:295:21: performance:inconclusive: Technically the member function 'Worker::statusIndent' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/worker.h:36:21: note: Technically the member function 'Worker::statusIndent' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/worker.cc:295:21: note: Technically the member function 'Worker::statusIndent' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/worker.h:35:21: performance:inconclusive: Technically the member function 'Worker::statusUndent' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/worker.cc:283:21: note: Technically the member function 'Worker::statusUndent' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/worker.h:35:21: note: Technically the member function 'Worker::statusUndent' can be static (but you may consider moving to unnamed namespace). 2.17.0 niceshaper-1.2.4/src/worker.h:36:21: performance:inconclusive: Technically the member function 'Worker::statusIndent' can be static (but you may consider moving to unnamed namespace). [functionStatic] niceshaper-1.2.4/src/worker.cc:295:21: note: Technically the member function 'Worker::statusIndent' can be static (but you may consider moving to unnamed namespace). niceshaper-1.2.4/src/worker.h:36:21: note: Technically the member function 'Worker::statusIndent' can be static (but you may consider moving to unnamed namespace). DONE