2025-05-06 14:00 ftp://ftp.de.debian.org/debian/pool/main/n/network-manager-ssh/network-manager-ssh_1.2.11.orig.tar.gz cppcheck-options: --library=posix --library=gnu --library=bsd --library=gtk --inconclusive --enable=style,information --inline-suppr --template=daca2 --disable=missingInclude --suppress=unmatchedSuppression --check-library --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=normalCheckLevelConditionExpressions -D__GNUC__ --platform=unix64 -j3 platform: Linux-6.8.0-1022-oracle-aarch64-with-glibc2.39 python: 3.12.3 client-version: 1.3.67 compiler: g++ (Ubuntu 13.3.0-6ubuntu2~24.04) 13.3.0 cppcheck: head 2.17.0 head-info: 40776f9 (2025-05-06 14:25:14 +0200) count: 37 39 elapsed-time: 0.3 0.3 head-timing-info: old-timing-info: head results: NetworkManager-ssh-1.2.11/auth-dialog/main.c:68:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_SETTING_VPN_SETTING_NAME [valueFlowBailoutIncompleteVar] NetworkManager-ssh-1.2.11/auth-dialog/main.c:115:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stdout [valueFlowBailoutIncompleteVar] NetworkManager-ssh-1.2.11/auth-dialog/main.c:140:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_SETTING_SECRET_FLAG_NOT_SAVED [valueFlowBailoutIncompleteVar] NetworkManager-ssh-1.2.11/auth-dialog/main.c:223:3: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable errno [valueFlowBailoutIncompleteVar] NetworkManager-ssh-1.2.11/auth-dialog/main.c:244:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_SETTING_SECRET_FLAG_NONE [valueFlowBailoutIncompleteVar] NetworkManager-ssh-1.2.11/properties/advanced-dialog.c:83:66: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_TYPE_SETTING_VPN [valueFlowBailoutIncompleteVar] NetworkManager-ssh-1.2.11/properties/advanced-dialog.c:130:4: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_DIALOG_MODAL [valueFlowBailoutIncompleteVar] NetworkManager-ssh-1.2.11/properties/advanced-dialog.c:156:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UIDIR [valueFlowBailoutIncompleteVar] NetworkManager-ssh-1.2.11/properties/advanced-dialog.c:300:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_SSH_KEY_TUNNEL_MTU [valueFlowBailoutIncompleteVar] NetworkManager-ssh-1.2.11/auth-dialog/main.c:284:35: warning: Either the condition 'data' is redundant or there is possible null pointer dereference: data. [nullPointerRedundantCheck] NetworkManager-ssh-1.2.11/auth-dialog/main.c:340:6: note: Assuming that condition 'data' is not redundant NetworkManager-ssh-1.2.11/auth-dialog/main.c:284:35: note: Null pointer dereference NetworkManager-ssh-1.2.11/properties/nm-ssh.c:262:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_RESPONSE_OK [valueFlowBailoutIncompleteVar] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:291:59: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable __func__ [valueFlowBailoutIncompleteVar] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:340:59: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_SSH_AUTH_TYPE_PASSWORD [valueFlowBailoutIncompleteVar] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:425:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_SETTING_SECRET_FLAG_NONE [valueFlowBailoutIncompleteVar] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:472:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_SSH_AUTH_TYPE_SSH_AGENT [valueFlowBailoutIncompleteVar] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:696:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_SSH_KEY_AUTH_TYPE [valueFlowBailoutIncompleteVar] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:769:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_SSH_KEY_REMOTE [valueFlowBailoutIncompleteVar] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:848:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_CONNECTION_ERROR [valueFlowBailoutIncompleteVar] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:922:2: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ssh_editor_parent_class [valueFlowBailoutIncompleteVar] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1033:3: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_SSH_KEY_REMOTE [valueFlowBailoutIncompleteVar] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1094:72: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_TYPE_SETTING_CONNECTION [valueFlowBailoutIncompleteVar] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1285:72: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_TYPE_SETTING_CONNECTION [valueFlowBailoutIncompleteVar] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1297:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_VPN_EDITOR_PLUGIN_CAPABILITY_IMPORT [valueFlowBailoutIncompleteVar] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1318:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_DBUS_SERVICE_SSH [valueFlowBailoutIncompleteVar] NetworkManager-ssh-1.2.11/src/nm-ssh-service.c:1543:41: error: There is an unknown macro here somewhere. Configuration is required. If VERSION is a macro then please configure it. [unknownMacro] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:930:2: style: g_type_class_add_private has been deprecated since version 2.58 and should not be used in newly-written code. Use the G_ADD_PRIVATE() macro with the G_DEFINE_* family of macros to add instance private data to a type. [prohibitedg_type_class_add_privateCalled] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1256:2: warning: %d in format string (no. 3) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:691:10: style: Redundant initialization for 'success'. The initialized value is overwritten before it is read. [redundantInitialization] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:686:19: note: success is initialized NetworkManager-ssh-1.2.11/properties/nm-ssh.c:691:10: note: success is overwritten NetworkManager-ssh-1.2.11/properties/nm-ssh.c:820:8: style: Variable 'valid' is reassigned a value before the old one has been used. [redundantAssignment] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:814:8: note: valid is assigned NetworkManager-ssh-1.2.11/properties/nm-ssh.c:820:8: note: valid is overwritten NetworkManager-ssh-1.2.11/properties/nm-ssh.c:326:40: style: Parameter 'group' can be declared as pointer to const [constParameterPointer] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:665:44: style: Parameter 'data' can be declared as pointer to const. However it seems that 'hash_copy_advanced' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:817:41: note: You might need to cast the function pointer here NetworkManager-ssh-1.2.11/properties/nm-ssh.c:665:44: note: Parameter 'data' can be declared as pointer to const NetworkManager-ssh-1.2.11/properties/nm-ssh.c:936:29: style: Parameter 'plugin' can be declared as pointer to const [constParameterPointer] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:956:8: style: Variable 'ext' can be declared as pointer to const [constVariablePointer] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1295:38: style: Parameter 'iface' can be declared as pointer to const. However it seems that 'get_capabilities' is a callback function, if 'iface' is declared with const you might also need to cast function pointer(s). [constParameterCallback] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1356:34: note: You might need to cast the function pointer here NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1295:38: note: Parameter 'iface' can be declared as pointer to const NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1307:24: style: Parameter 'object' can be declared as pointer to const. However it seems that 'get_property' is a callback function, if 'object' is declared with const you might also need to cast function pointer(s). [constParameterCallback] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1331:31: note: You might need to cast the function pointer here NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1307:24: note: Parameter 'object' can be declared as pointer to const NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1308:33: style: Parameter 'pspec' can be declared as pointer to const. However it seems that 'get_property' is a callback function, if 'pspec' is declared with const you might also need to cast function pointer(s). [constParameterCallback] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1331:31: note: You might need to cast the function pointer here NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1308:33: note: Parameter 'pspec' can be declared as pointer to const NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1347:42: style: Parameter 'plugin' can be declared as pointer to const [constParameterPointer] diff: head NetworkManager-ssh-1.2.11/auth-dialog/main.c:284:35: warning: Either the condition 'data' is redundant or there is possible null pointer dereference: data. [nullPointerRedundantCheck] NetworkManager-ssh-1.2.11/auth-dialog/main.c:340:6: note: Assuming that condition 'data' is not redundant NetworkManager-ssh-1.2.11/auth-dialog/main.c:284:35: note: Null pointer dereference 2.17.0 NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1044:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tmp [nullPointerOutOfMemory] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1044:3: note: Assuming allocation function fails NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1044:3: note: Assignment 'tmp=g_strdup_printf("%d",NM_SSH_DEFAULT_PORT)', assigned value is 0 NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1044:3: note: Null pointer dereference 2.17.0 NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1045:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tmp [nullPointerOutOfMemory] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1045:3: note: Assuming allocation function fails NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1045:3: note: Assignment 'tmp=g_strdup_printf("%d",NM_SSH_DEFAULT_MTU)', assigned value is 0 NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1045:3: note: Null pointer dereference 2.17.0 NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1046:3: warning: If memory allocation fails, then there is a possible null pointer dereference: tmp [nullPointerOutOfMemory] NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1046:3: note: Assuming allocation function fails NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1046:3: note: Assignment 'tmp=g_strdup_printf("%d",NM_SSH_DEFAULT_REMOTE_DEV)', assigned value is 0 NetworkManager-ssh-1.2.11/properties/nm-ssh.c:1046:3: note: Null pointer dereference DONE