2026-05-03 20:01
ftp://ftp.de.debian.org/debian/pool/main/n/network-manager-pptp/network-manager-pptp_1.2.12.orig.tar.xz
cppcheck-options: --library=posix --library=gnu --library=bsd --library=gtk  --inconclusive --enable=style,information --inline-suppr --template=daca2 --disable=missingInclude --suppress=unmatchedSuppression --check-library --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=normalCheckLevelConditionExpressions -D__GNUC__ --platform=unix64 -j1
platform: Linux-6.8.0-111-generic-x86_64-with-glibc2.39
python: 3.12.3
client-version: 1.3.70
compiler: g++ (Ubuntu 14.2.0-4ubuntu2~24.04.1) 14.2.0
cppcheck: head 2.20.0
head-info: e5c4a73 (2026-05-01 11:10:43 +0200)
count: 38 38
elapsed-time: 0.5 0.4
head-timing-info:

old-timing-info:

head results:
NetworkManager-pptp-1.2.12/auth-dialog/main.c:60:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_SETTING_VPN_SETTING_NAME [valueFlowBailoutIncompleteVar]
NetworkManager-pptp-1.2.12/auth-dialog/main.c:104:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stdout [valueFlowBailoutIncompleteVar]
NetworkManager-pptp-1.2.12/auth-dialog/main.c:129:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_SETTING_SECRET_FLAG_NOT_SAVED [valueFlowBailoutIncompleteVar]
NetworkManager-pptp-1.2.12/auth-dialog/main.c:213:3: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable errno [valueFlowBailoutIncompleteVar]
NetworkManager-pptp-1.2.12/auth-dialog/main.c:233:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_SETTING_SECRET_FLAG_NONE [valueFlowBailoutIncompleteVar]
NetworkManager-pptp-1.2.12/properties/advanced-dialog.c:166:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_TYPE_STRING [valueFlowBailoutIncompleteVar]
NetworkManager-pptp-1.2.12/properties/advanced-dialog.c:266:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_PPTP_KEY_REQUIRE_MPPE [valueFlowBailoutIncompleteVar]
NetworkManager-pptp-1.2.12/properties/advanced-dialog.c:400:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GETTEXT_PACKAGE [valueFlowBailoutIncompleteVar]
NetworkManager-pptp-1.2.12/properties/advanced-dialog.c:530:41: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_PPTP_KEY_REQUIRE_MPPE_128 [valueFlowBailoutIncompleteVar]
NetworkManager-pptp-1.2.12/properties/advanced-dialog.c:309:15: style: Redundant initialization for 'mschap_state'. The initialized value is overwritten before it is read. [redundantInitialization]
NetworkManager-pptp-1.2.12/properties/advanced-dialog.c:260:24: note: mschap_state is initialized
NetworkManager-pptp-1.2.12/properties/advanced-dialog.c:309:15: note: mschap_state is overwritten
NetworkManager-pptp-1.2.12/properties/advanced-dialog.c:321:16: style: Redundant initialization for 'mschap2_state'. The initialized value is overwritten before it is read. [redundantInitialization]
NetworkManager-pptp-1.2.12/properties/advanced-dialog.c:261:25: note: mschap2_state is initialized
NetworkManager-pptp-1.2.12/properties/advanced-dialog.c:321:16: note: mschap2_state is overwritten
NetworkManager-pptp-1.2.12/properties/nm-pptp-editor-plugin.c:54:2: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable gs_free [valueFlowBailoutIncompleteVar]
NetworkManager-pptp-1.2.12/properties/nm-pptp-editor-plugin.c:127:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_VPN_EDITOR_PLUGIN_CAPABILITY_NONE [valueFlowBailoutIncompleteVar]
NetworkManager-pptp-1.2.12/properties/nm-pptp-editor-plugin.c:185:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_DBUS_SERVICE_PPTP [valueFlowBailoutIncompleteVar]
NetworkManager-pptp-1.2.12/properties/nm-pptp-editor-plugin.c:237:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GETTEXT_PACKAGE [valueFlowBailoutIncompleteVar]
NetworkManager-pptp-1.2.12/properties/nm-pptp-editor-plugin.c:56:8: style: Variable 'ext' can be declared as pointer to const [constVariablePointer]
NetworkManager-pptp-1.2.12/properties/nm-pptp-editor-plugin.c:125:38: style: Parameter 'iface' can be declared as pointer to const. However it seems that 'get_capabilities' is a callback function, if 'iface' is declared with const you might also need to cast function pointer(s). [constParameterCallback]
NetworkManager-pptp-1.2.12/properties/nm-pptp-editor-plugin.c:222:34: note: You might need to cast the function pointer here
NetworkManager-pptp-1.2.12/properties/nm-pptp-editor-plugin.c:125:38: note: Parameter 'iface' can be declared as pointer to const
NetworkManager-pptp-1.2.12/properties/nm-pptp-editor-plugin.c:174:24: style: Parameter 'object' can be declared as pointer to const. However it seems that 'get_property' is a callback function, if 'object' is declared with const you might also need to cast function pointer(s). [constParameterCallback]
NetworkManager-pptp-1.2.12/properties/nm-pptp-editor-plugin.c:198:31: note: You might need to cast the function pointer here
NetworkManager-pptp-1.2.12/properties/nm-pptp-editor-plugin.c:174:24: note: Parameter 'object' can be declared as pointer to const
NetworkManager-pptp-1.2.12/properties/nm-pptp-editor-plugin.c:175:42: style: Parameter 'pspec' can be declared as pointer to const. However it seems that 'get_property' is a callback function, if 'pspec' is declared with const you might also need to cast function pointer(s). [constParameterCallback]
NetworkManager-pptp-1.2.12/properties/nm-pptp-editor-plugin.c:198:31: note: You might need to cast the function pointer here
NetworkManager-pptp-1.2.12/properties/nm-pptp-editor-plugin.c:175:42: note: Parameter 'pspec' can be declared as pointer to const
NetworkManager-pptp-1.2.12/properties/nm-pptp-editor-plugin.c:214:36: style: Parameter 'plugin' can be declared as pointer to const [constParameterPointer]
NetworkManager-pptp-1.2.12/properties/nm-pptp-editor.c:94:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_RESPONSE_OK [valueFlowBailoutIncompleteVar]
NetworkManager-pptp-1.2.12/properties/nm-pptp-editor.c:124:59: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable __func__ [valueFlowBailoutIncompleteVar]
NetworkManager-pptp-1.2.12/properties/nm-pptp-editor.c:197:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_SETTING_SECRET_FLAG_NONE [valueFlowBailoutIncompleteVar]
NetworkManager-pptp-1.2.12/properties/nm-pptp-editor.c:239:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_PPTP_KEY_GATEWAY [valueFlowBailoutIncompleteVar]
NetworkManager-pptp-1.2.12/properties/nm-pptp-editor.c:362:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NM_PPTP_KEY_GATEWAY [valueFlowBailoutIncompleteVar]
NetworkManager-pptp-1.2.12/properties/nm-pptp-editor.c:420:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NMV_EDITOR_PLUGIN_ERROR [valueFlowBailoutIncompleteVar]
NetworkManager-pptp-1.2.12/properties/nm-pptp-editor.c:489:2: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable pptp_plugin_ui_widget_parent_class [valueFlowBailoutIncompleteVar]
NetworkManager-pptp-1.2.12/properties/nm-pptp-editor.c:497:2: style: g_type_class_add_private has been deprecated since version 2.58 and should not be used in newly-written code. Use the G_ADD_PRIVATE() macro with the G_DEFINE_* family of macros to add instance private data to a type. [prohibitedg_type_class_add_privateCalled]
NetworkManager-pptp-1.2.12/properties/nm-pptp-editor.c:403:49: style: Parameter 'plugin' can be declared as pointer to const [constParameterPointer]
NetworkManager-pptp-1.2.12/shared/nm-utils/nm-shared-utils.c:134:3: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable errno [valueFlowBailoutIncompleteVar]
NetworkManager-pptp-1.2.12/shared/nm-utils/nm-shared-utils.c:250:2: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable nm_auto_unset_gvalue [valueFlowBailoutIncompleteVar]
NetworkManager-pptp-1.2.12/shared/nm-utils/nm-shared-utils.c:213:38: style: Parameter 'error' can be declared as pointer to const [constParameterPointer]
NetworkManager-pptp-1.2.12/shared/nm-utils/nm-shared-utils.c:251:16: style: Variable 'klass' can be declared as pointer to const [constVariablePointer]
NetworkManager-pptp-1.2.12/shared/nm-utils/nm-vpn-plugin-utils.c:33:64: debug: Function::addArguments found argument 'editor_factory' with varid 0. [varid0]
NetworkManager-pptp-1.2.12/shared/nm-utils/nm-vpn-plugin-utils.c:47:2: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable gs_free [valueFlowBailoutIncompleteVar]
NetworkManager-pptp-1.2.12/shared/nm-utils/nm-vpn-plugin-utils.c:33:64: style:inconclusive: Function 'nm_vpn_plugin_utils_load_editor' argument 3 names different: declaration '<unnamed>' definition 'editor_factory'. [funcArgNamesDifferentUnnamed]
NetworkManager-pptp-1.2.12/src/nm-pptp-pppd-compat.h:49:2: error: failed to evaluate #if condition, undefined function-like macro invocation: PPP_VERSION( ... ) [syntaxError]
NetworkManager-pptp-1.2.12/src/nm-pptp-service.c:310:4: error: There is an unknown macro here somewhere. Configuration is required. If _NM_UTILS_MACRO_FIRST is a macro then please configure it. [unknownMacro]
diff:
2.20.0 NetworkManager-pptp-1.2.12/auth-dialog/main.c:274:41: warning: Either the condition 'secrets' is redundant or there is possible null pointer dereference: secrets. [nullPointerRedundantCheck]
     NetworkManager-pptp-1.2.12/auth-dialog/main.c:296:6: note: Assuming that condition 'secrets' is not redundant
     NetworkManager-pptp-1.2.12/auth-dialog/main.c:274:41: note: Null pointer dereference
head NetworkManager-pptp-1.2.12/shared/nm-utils/nm-vpn-plugin-utils.c:33:64: style:inconclusive: Function 'nm_vpn_plugin_utils_load_editor' argument 3 names different: declaration '<unnamed>' definition 'editor_factory'. [funcArgNamesDifferentUnnamed]


DONE