2026-05-03 19:57 ftp://ftp.de.debian.org/debian/pool/main/n/netrek-client-cow/netrek-client-cow_3.3.2.orig.tar.gz cppcheck-options: --library=posix --library=gnu --library=bsd --library=motif --library=bsd --inconclusive --enable=style,information --inline-suppr --template=daca2 --disable=missingInclude --suppress=unmatchedSuppression --check-library --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=normalCheckLevelConditionExpressions -D__GNUC__ --platform=unix64 -j1 platform: Linux-6.8.0-111-generic-x86_64-with-glibc2.39 python: 3.12.3 client-version: 1.3.70 compiler: g++ (Ubuntu 14.2.0-4ubuntu2~24.04.1) 14.2.0 cppcheck: head 2.20.0 head-info: e5c4a73 (2026-05-01 11:10:43 +0200) count: 512 463 elapsed-time: 19.1 17.2 head-timing-info: old-timing-info: head results: netrek-client-cow-3.3.2/censor.c:41:29: style: Parameter 'word' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/censor.c:63:25: style: Parameter 'word' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/censor.c:63:37: style: Parameter 'text' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/censor.c:63:48: style: Parameter 'skip' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/check.c:65:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/check.c:63:17: style: Obsolescent function 'gethostbyname' called. It is recommended to use 'getaddrinfo' instead. [prohibitedgethostbynameCalled] netrek-client-cow-3.3.2/check.c:81:15: warning: Either the condition '(sock=socket(AF_INET,SOCK_STREAM,0))<0' is redundant or connect() argument nr 1 can have invalid value. The value is -1 but the valid values are '0:'. [invalidFunctionArg] netrek-client-cow-3.3.2/check.c:75:48: note: Assuming that condition '(sock=socket(AF_INET,SOCK_STREAM,0))<0' is not redundant netrek-client-cow-3.3.2/check.c:81:15: note: Invalid argument netrek-client-cow-3.3.2/check.c:58:15: style: Local variable 'sock' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/data.h:204:12: note: Shadowed declaration netrek-client-cow-3.3.2/check.c:58:15: note: Shadow variable netrek-client-cow-3.3.2/check.c:61:8: error: Uninitialized variable: addr [uninitvar] netrek-client-cow-3.3.2/cowmain.c:922:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/cowmain.c:738:18: portability: Non reentrant function 'getpwuid' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getpwuid_r'. [prohibitedgetpwuidCalled] netrek-client-cow-3.3.2/cowmain.c:1032:22: style:inconclusive: Function 'handle_exception' argument 1 names different: declaration '' definition '_dummy'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/cowmain.c:883:12: style: Local variable 'i' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/cowmain.c:567:11: note: Shadowed declaration netrek-client-cow-3.3.2/cowmain.c:883:12: note: Shadow variable netrek-client-cow-3.3.2/cowmain.c:942:10: style: Local variable 'buf' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/cowmain.c:564:11: note: Shadowed declaration netrek-client-cow-3.3.2/cowmain.c:942:10: note: Shadow variable netrek-client-cow-3.3.2/cowmain.c:882:12: style: Variable 'getteam' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/dashboard.c:83:22: style: Parameter 'lab' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/dashboard.c:143:18: style: Variable 'plr' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/defaults.c:153:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MAX_MACRO [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/defaults.c:392:4: warning: If memory allocation fails, then there is a possible null pointer dereference: new [nullPointerOutOfMemory] netrek-client-cow-3.3.2/defaults.c:390:38: note: Assuming allocation function fails netrek-client-cow-3.3.2/defaults.c:390:10: note: Assignment 'new=(struct stringlist*)malloc(sizeof(struct stringlist))', assigned value is 0 netrek-client-cow-3.3.2/defaults.c:392:4: note: Null pointer dereference netrek-client-cow-3.3.2/defaults.c:393:4: warning: If memory allocation fails, then there is a possible null pointer dereference: new [nullPointerOutOfMemory] netrek-client-cow-3.3.2/defaults.c:390:38: note: Assuming allocation function fails netrek-client-cow-3.3.2/defaults.c:390:10: note: Assignment 'new=(struct stringlist*)malloc(sizeof(struct stringlist))', assigned value is 0 netrek-client-cow-3.3.2/defaults.c:393:4: note: Null pointer dereference netrek-client-cow-3.3.2/defaults.c:394:4: warning: If memory allocation fails, then there is a possible null pointer dereference: new [nullPointerOutOfMemory] netrek-client-cow-3.3.2/defaults.c:390:38: note: Assuming allocation function fails netrek-client-cow-3.3.2/defaults.c:390:10: note: Assignment 'new=(struct stringlist*)malloc(sizeof(struct stringlist))', assigned value is 0 netrek-client-cow-3.3.2/defaults.c:394:4: note: Null pointer dereference netrek-client-cow-3.3.2/defaults.c:509:11: style: Variable 'str' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/defaults.c:846:24: style: Parameter 'fname' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/defaults.c:849:11: style: Variable 'home' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/distress.c:224:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable s [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/distress.c:948:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/distress.c:144:15: warning: Either the condition 'i<6' is redundant or the array 'dist->cclist[6]' is accessed at index 6, which is out of bounds. [arrayIndexOutOfBoundsCond] netrek-client-cow-3.3.2/distress.c:139:47: note: Assuming that condition 'i<6' is not redundant netrek-client-cow-3.3.2/distress.c:144:15: note: Array index out of bounds netrek-client-cow-3.3.2/distress.c:145:19: warning: Either the condition 'i<6' is redundant or the array 'dist->cclist[6]' is accessed at index 6, which is out of bounds. [arrayIndexOutOfBoundsCond] netrek-client-cow-3.3.2/distress.c:139:47: note: Assuming that condition 'i<6' is not redundant netrek-client-cow-3.3.2/distress.c:145:19: note: Array index out of bounds netrek-client-cow-3.3.2/distress.c:207:35: style: Parameter 'dist' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/distress.c:207:58: style: Parameter 'pm' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/distress.c:660:32: style: Parameter 'bufa' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/distress.c:933:22: style: Parameter 's' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/dmessage.c:63:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable p_no [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/dmessage.c:53:8: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] netrek-client-cow-3.3.2/dmessage.c:39:14: style: Variable 'tm' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/dmessage.c:260:39: style: Parameter 'string2' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/dmessage.c:262:11: style: Variable 's' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/docwin.c:42:8: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable docwin [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/docwin.c:190:7: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable maxdoclines [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/docwin.c:209:8: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable xtrekrcwin [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/docwin.c:344:7: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable maxxtrekrclines [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/docwin.c:144:7: error: Resource leak: fptr [resourceLeak] netrek-client-cow-3.3.2/docwin.c:310:7: error: Resource leak: fptr [resourceLeak] netrek-client-cow-3.3.2/docwin.c:126:22: style: Variable 'filename' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/enter.c:107:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BUFSIZ [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/enter.c:95:10: warning: If memory allocation fails, then there is a possible null pointer dereference: ranks [nullPointerOutOfMemory] netrek-client-cow-3.3.2/enter.c:94:17: note: Assuming allocation function fails netrek-client-cow-3.3.2/enter.c:94:17: note: Assignment 'ranks=malloc(i)', assigned value is 0 netrek-client-cow-3.3.2/enter.c:95:10: note: Null pointer dereference netrek-client-cow-3.3.2/enter.c:62:16: style: Variable 'status->time' is reassigned a value before the old one has been used. [redundantAssignment] netrek-client-cow-3.3.2/enter.c:58:16: note: status->time is assigned netrek-client-cow-3.3.2/enter.c:62:16: note: status->time is overwritten netrek-client-cow-3.3.2/findslot.c:115:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/findslot.c:100:12: style: Local variable 'w' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/data.h:320:27: note: Shadowed declaration netrek-client-cow-3.3.2/findslot.c:100:12: note: Shadow variable netrek-client-cow-3.3.2/findslot.c:43:21: style: Parameter 's' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/getname.c:335:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/getname.c:356:23: error: Array 'mystats->st_keymap[96]' accessed at index 190, which is out of bounds. [arrayIndexOutOfBounds] netrek-client-cow-3.3.2/getname.c:354:17: note: Assuming that condition 'j<95' is not redundant netrek-client-cow-3.3.2/getname.c:356:23: note: Array index out of bounds netrek-client-cow-3.3.2/getname.c:60:30: style: Parameter 'password' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/getname.c:369:35: style: Parameter 'defpasswd' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/inform.c:36:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BUFSIZ [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/inform.c:40:27: style: Variable 'k' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/inform.c:42:71: style: Variable 'target' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/input.c:587:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/input.c:860:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/input.c:977:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/input.c:1120:59: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable targtype [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/input.c:1381:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/input.c:1396:59: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable targtype [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/input.c:973:31: warning: Either the condition 'key<224' is redundant or the array 'mystats->st_keymap[96]' is accessed at index 191, which is out of bounds. [arrayIndexOutOfBoundsCond] netrek-client-cow-3.3.2/input.c:971:24: note: Assuming that condition 'key<224' is not redundant netrek-client-cow-3.3.2/input.c:973:31: note: Array index out of bounds netrek-client-cow-3.3.2/input.c:1538:3: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] netrek-client-cow-3.3.2/input.c:1396:71: style: Local variable 'target' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/input.c:73:69: note: Shadowed declaration netrek-client-cow-3.3.2/input.c:1396:71: note: Shadow variable netrek-client-cow-3.3.2/input.c:1396:71: style: Variable 'target' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/input.c:1481:22: style: Variable 'l' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/input.c:1677:29: style: Parameter 'data' can be declared as pointer to const. However it seems that 'Key41' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/input.c:170:5: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/input.c:1677:29: note: Parameter 'data' can be declared as pointer to const netrek-client-cow-3.3.2/input.c:1869:29: style: Parameter 'data' can be declared as pointer to const. However it seems that 'Key65' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/input.c:195:5: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/input.c:1869:29: note: Parameter 'data' can be declared as pointer to const netrek-client-cow-3.3.2/input.c:1912:29: style: Parameter 'data' can be declared as pointer to const. However it seems that 'Key71' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/input.c:201:5: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/input.c:1912:29: note: Parameter 'data' can be declared as pointer to const netrek-client-cow-3.3.2/input.c:1917:29: style: Parameter 'data' can be declared as pointer to const. However it seems that 'Key72' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/input.c:202:5: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/input.c:1917:29: note: Parameter 'data' can be declared as pointer to const netrek-client-cow-3.3.2/input.c:1937:29: style: Parameter 'data' can be declared as pointer to const. However it seems that 'Key74' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/input.c:204:5: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/input.c:1937:29: note: Parameter 'data' can be declared as pointer to const netrek-client-cow-3.3.2/input.c:1960:29: style: Parameter 'data' can be declared as pointer to const. However it seems that 'Key77' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/input.c:207:5: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/input.c:1960:29: note: Parameter 'data' can be declared as pointer to const netrek-client-cow-3.3.2/input.c:2061:29: style: Parameter 'data' can be declared as pointer to const. However it seems that 'Key87' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/input.c:217:5: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/input.c:2061:29: note: Parameter 'data' can be declared as pointer to const netrek-client-cow-3.3.2/input.c:2071:29: style: Parameter 'data' can be declared as pointer to const. However it seems that 'Key89' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/input.c:219:5: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/input.c:2071:29: note: Parameter 'data' can be declared as pointer to const netrek-client-cow-3.3.2/input.c:2076:29: style: Parameter 'data' can be declared as pointer to const. However it seems that 'Key90' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/input.c:220:5: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/input.c:2076:29: note: Parameter 'data' can be declared as pointer to const netrek-client-cow-3.3.2/input.c:2200:30: style: Parameter 'data' can be declared as pointer to const. However it seems that 'Key103' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/input.c:233:5: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/input.c:2200:30: note: Parameter 'data' can be declared as pointer to const netrek-client-cow-3.3.2/input.c:2235:30: style: Parameter 'data' can be declared as pointer to const. However it seems that 'Key106' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/input.c:236:5: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/input.c:2235:30: note: Parameter 'data' can be declared as pointer to const netrek-client-cow-3.3.2/input.c:2280:30: style: Parameter 'data' can be declared as pointer to const. However it seems that 'Key110' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/input.c:240:5: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/input.c:2280:30: note: Parameter 'data' can be declared as pointer to const netrek-client-cow-3.3.2/input.c:2360:30: style: Parameter 'data' can be declared as pointer to const. However it seems that 'Key118' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/input.c:248:5: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/input.c:2360:30: note: Parameter 'data' can be declared as pointer to const netrek-client-cow-3.3.2/input.c:2431:30: style: Parameter 'data' can be declared as pointer to const. However it seems that 'Key126' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/input.c:257:5: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/input.c:2431:30: note: Parameter 'data' can be declared as pointer to const netrek-client-cow-3.3.2/input.c:2443:30: style: Parameter 'data' can be declared as pointer to const. However it seems that 'Key127' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/input.c:258:5: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/input.c:2443:30: note: Parameter 'data' can be declared as pointer to const netrek-client-cow-3.3.2/input.c:1487:18: style: Variable 'targettype' is assigned a value that is never used. [unreadVariable] netrek-client-cow-3.3.2/input.c:1489:20: style: Variable 'targettype' is assigned a value that is never used. [unreadVariable] netrek-client-cow-3.3.2/input.c:1491:20: style: Variable 'targettype' is assigned a value that is never used. [unreadVariable] netrek-client-cow-3.3.2/input.c:1398:18: style: Unused variable: i [unusedVariable] netrek-client-cow-3.3.2/interface.c:189:8: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] netrek-client-cow-3.3.2/interface.c:182:14: style: Variable 'tm' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/local.c:185:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ship_bits [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/local.c:868:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable p_no [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/local.c:988:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable p_no [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/local.c:1103:7: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sy [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/local.c:702:9: style: Local variable 'lx' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/local.c:182:38: note: Shadowed declaration netrek-client-cow-3.3.2/local.c:702:9: note: Shadow variable netrek-client-cow-3.3.2/local.c:702:16: style: Local variable 'ly' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/local.c:182:42: note: Shadowed declaration netrek-client-cow-3.3.2/local.c:702:16: note: Shadow variable netrek-client-cow-3.3.2/local.c:66:46: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/local.c:1027:26: style: Variable 'j' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/local.c:1267:19: style: Variable 'l' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/macrowin.c:81:43: warning: Char literal compared with pointer 'distmacro[i].macro'. Did you intend to dereference it? [charLiteralWithCharPtrCompare] netrek-client-cow-3.3.2/main.c:76:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LC_ALL [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/main.c:473:30: style: Parameter 'prog' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/main.c:54:11: style: Variable 'inplayback' is assigned a value that is never used. [unreadVariable] netrek-client-cow-3.3.2/map.c:536:24: style: Local variable 'lastUpdate' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/data.h:218:12: note: Shadowed declaration netrek-client-cow-3.3.2/map.c:536:24: note: Shadow variable netrek-client-cow-3.3.2/map.c:734:22: style: Local variable 'l' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/map.c:530:27: note: Shadowed declaration netrek-client-cow-3.3.2/map.c:734:22: note: Shadow variable netrek-client-cow-3.3.2/map.c:227:47: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/map.c:734:22: style: Variable 'l' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/mkcflags.c:37:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/mkcflags.c:41:13: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] netrek-client-cow-3.3.2/mkcflags.c:53:3: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] netrek-client-cow-3.3.2/mkcflags.c:30:14: style: Variable 'tm_date' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/mkcflags.c:63:12: style: Parameter 'cdate' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/mkcflags.c:64:12: style: Parameter 'arch' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/mkkey.c:305:48: debug: Function::addArguments found argument 'raw_global' with varid 0. [varid0] netrek-client-cow-3.3.2/mkkey.c:325:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stdout [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/mkkey.c:486:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/mkkey.c:657:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/mkkey.c:745:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BUFSIZ [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/mkkey.c:885:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/mkkey.c:1136:38: portability: Non reentrant function 'gmtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'gmtime_r'. [prohibitedgmtimeCalled] netrek-client-cow-3.3.2/mkkey.c:1089:6: style: Condition '!kgetkeyname(buffer,key_name)' is always false [knownConditionTrueFalse] netrek-client-cow-3.3.2/mkkey.c:1089:18: note: Calling function 'kgetkeyname' returns 1 netrek-client-cow-3.3.2/mkkey.c:1089:6: note: Condition '!kgetkeyname(buffer,key_name)' is always false netrek-client-cow-3.3.2/mkkey.c:447:6: warning: %x in format string (no. 1) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int] netrek-client-cow-3.3.2/mkkey.c:1007:13: style: Local variable 'one' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/mkkey.c:799:12: note: Shadowed declaration netrek-client-cow-3.3.2/mkkey.c:1007:13: note: Shadow variable netrek-client-cow-3.3.2/mkkey.c:376:10: style: Parameter 'src' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/mkkey.c:392:16: style: Parameter 'field' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/mkkey.c:420:26: style: Variable 's' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/mkkey.c:466:12: style: Parameter 'name' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/mkkey.c:537:12: style: Parameter 'name' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/mkkey.c:538:21: style: Parameter 'key' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/mkkey.c:610:12: style: Parameter 'clients_basename' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/mkkey.c:618:11: style: Variable 'op' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/mkkey.c:811:64: style: Variable 'class' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/mkkey.c:813:11: style: Variable 'keydoth' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/mkkey.c:813:22: style: Variable 'keycap' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/name.c:6:1: portability: Omitted return type of function 'main' defaults to int, this is not supported by ISO C99 and later standards. [returnImplicitInt] netrek-client-cow-3.3.2/netstat.c:204:30: style: Parameter 's' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/netstatopt.c:29:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BUFSIZ [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/netstatopt.c:26:20: style:inconclusive: Function 'nsrefresh' argument 1 names different: declaration '' definition 'i'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/netstatopt.c:68:28: style: Parameter 'data' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/newwin.c:970:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable errno [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/newwin.c:1473:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BUFSIZ [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/newwin.c:1513:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BUFSIZ [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/newwin.c:1281:24: style:inconclusive: Function 'showMotd' argument 1 names different: declaration 'motdwin' definition 'w'. [funcArgNamesDifferent] netrek-client-cow-3.3.2/newwin.h:5:24: note: Function 'showMotd' argument 1 names different: declaration 'motdwin' definition 'w'. netrek-client-cow-3.3.2/newwin.c:1281:24: note: Function 'showMotd' argument 1 names different: declaration 'motdwin' definition 'w'. netrek-client-cow-3.3.2/newwin.c:1474:16: style: Local variable 'teams' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/data.h:64:21: note: Shadowed declaration netrek-client-cow-3.3.2/newwin.c:1474:16: note: Shadow variable netrek-client-cow-3.3.2/newwin.c:144:46: style: Parameter 'event' can be declared as pointer to const. However it seems that 'handleMessageWindowKeyDown' is a callback function, if 'event' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/newwin.c:313:40: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/newwin.c:144:46: note: Parameter 'event' can be declared as pointer to const netrek-client-cow-3.3.2/newwin.c:150:45: style: Parameter 'event' can be declared as pointer to const. However it seems that 'handleMessageWindowButton' is a callback function, if 'event' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/newwin.c:247:38: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/newwin.c:150:45: note: Parameter 'event' can be declared as pointer to const netrek-client-cow-3.3.2/newwin.c:1241:11: style: Variable 's' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/newwin.c:1241:15: style: Variable 't' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/newwin.c:1389:24: style: Parameter 'line' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/newwin.c:1460:32: style: Parameter 'prog' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/newwin.c:1319:11: style: Variable 'atline' is assigned a value that is never used. [unreadVariable] netrek-client-cow-3.3.2/option.c:388:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/option.c:481:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BUFSIZ [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/option.c:810:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable spWin [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/option.c:460:30: style: Parameter 'ip' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/option.c:526:32: style: Parameter 'data' can be declared as pointer to const. However it seems that 'optionaction' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/option.c:401:43: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/option.c:526:32: note: Parameter 'data' can be declared as pointer to const netrek-client-cow-3.3.2/option.c:919:11: style: Variable 'menuptr' is assigned a value that is never used. [unreadVariable] netrek-client-cow-3.3.2/ping.c:120:3: style: Obsolescent function 'bzero' called. It is recommended to use 'memset' instead. [prohibitedbzeroCalled] netrek-client-cow-3.3.2/ping.c:53:41: style: Parameter 'packet' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/pingstats.c:49:13: style: struct member 'record::data' is never used. [unusedStructMember] netrek-client-cow-3.3.2/pingstats.c:50:13: style: struct member 'record::last_value' is never used. [unusedStructMember] netrek-client-cow-3.3.2/planetlist.c:32:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BUFSIZ [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/playerlist.c:142:7: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/playerlist.c:266:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/playerlist.c:579:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BUFSIZ [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/playerlist.c:735:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BUFSIZ [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/playerlist.c:597:11: portability: Assigning an integer to a pointer is not portable. [AssignmentIntegerToAddress] netrek-client-cow-3.3.2/playerlist.c:311:28: portability: Undefined behaviour, pointer arithmetic 'updatePlayer-1' is out of bounds. [pointerOutOfBounds] netrek-client-cow-3.3.2/playerlist.c:537:24: portability: Undefined behaviour, pointer arithmetic 'updatePlayer-1' is out of bounds. [pointerOutOfBounds] netrek-client-cow-3.3.2/playerlist.c:597:11: style: Variable 'layout' is assigned a value that is never used. [unreadVariable] netrek-client-cow-3.3.2/random.c:253:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/random.c:337:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/random.c:201:19: style:inconclusive: Function 'srandom' argument 1 names different: declaration '' definition 'x'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/random.c:209:9: style: Variable 'j' is assigned a value that is never used. [unreadVariable] netrek-client-cow-3.3.2/randomize.c:6:1: portability: Omitted return type of function 'main' defaults to int, this is not supported by ISO C99 and later standards. [returnImplicitInt] netrek-client-cow-3.3.2/redraw.c:354:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BUFSIZ [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/redraw.c:141:24: style: Variable 'oldbuf' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/redraw.c:145:18: style: Variable 'plr' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/reserved.c:67:18: style: Variable 's' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/rint.c:29:29: portability: Casting from double * to unsigned short * is not portable due to different binary data representations on different platforms. [invalidPointerCast] netrek-client-cow-3.3.2/rint.c:30:29: portability: Casting from double * to unsigned short * is not portable due to different binary data representations on different platforms. [invalidPointerCast] netrek-client-cow-3.3.2/rint.c:30:26: style: Variable 'py' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/senddist.c:26:59: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable targtype [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/senddist.c:31:3: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:31:3: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:32:3: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:32:3: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:33:3: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:33:3: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:34:3: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:34:3: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:35:3: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:35:3: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:36:3: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:36:3: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:38:7: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:38:7: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:42:3: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:42:3: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:44:3: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:44:3: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:45:3: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:45:3: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:46:3: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:46:3: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:47:3: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:47:3: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:49:3: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:49:3: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:50:7: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:50:7: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:50:34: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:50:34: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:54:3: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:54:3: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:57:3: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:57:3: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:60:3: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:60:3: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:63:3: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:63:3: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:66:3: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:66:3: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:69:3: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:69:3: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:72:3: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:72:3: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:75:3: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:75:3: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:78:3: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:78:3: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:79:3: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:79:3: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:80:3: warning: If memory allocation fails, then there is a possible null pointer dereference: dist [nullPointerOutOfMemory] netrek-client-cow-3.3.2/senddist.c:29:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/senddist.c:29:10: note: Assignment 'dist=(struct distress*)malloc(sizeof(struct distress))', assigned value is 0 netrek-client-cow-3.3.2/senddist.c:80:3: note: Null pointer dereference netrek-client-cow-3.3.2/senddist.c:27:11: style: Variable 'target' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/setstate.c:255:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/setstate.c:329:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/setstate.c:205:15: style:inconclusive: Function 'srandom' argument 1 names different: declaration '' definition 'x'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/setstate.c:212:5: style: Variable 'j' is assigned a value that is never used. [unreadVariable] netrek-client-cow-3.3.2/smessage.c:102:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable who [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/smessage.c:104:22: style: Variable 'addr_str' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/smessage.c:104:33: style: Variable 'pm' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/smessage.c:104:33: style: Unused variable: pm [unusedVariable] netrek-client-cow-3.3.2/socket.c:496:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SP_S_8_TORP [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:718:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AF_INET [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:816:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:848:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:1011:6: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable errno [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:1115:8: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable shortversion [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:1203:8: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable errno [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:1457:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:1522:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:1552:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:1716:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:2015:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:2045:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:2191:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:2226:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:2303:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:2474:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:2570:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:2671:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:2729:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:2905:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:3006:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:3400:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:3415:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:3589:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AF_INET [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:3620:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:3716:8: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable shortversion [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/socket.c:790:12: style: Obsolescent function 'gethostbyaddr' called. It is recommended to use 'getnameinfo' instead. [prohibitedgethostbyaddrCalled] netrek-client-cow-3.3.2/socket.c:813:9: portability: Non reentrant function 'getprotobyname' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getprotobyname_r'. [prohibitedgetprotobynameCalled] netrek-client-cow-3.3.2/socket.c:861:17: style: Obsolescent function 'gethostbyname' called. It is recommended to use 'getaddrinfo' instead. [prohibitedgethostbynameCalled] netrek-client-cow-3.3.2/socket.c:1738:3: style: Obsolescent function 'bzero' called. It is recommended to use 'memset' instead. [prohibitedbzeroCalled] netrek-client-cow-3.3.2/socket.c:2063:3: style: Obsolescent function 'bzero' called. It is recommended to use 'memset' instead. [prohibitedbzeroCalled] netrek-client-cow-3.3.2/socket.c:2079:3: style: Obsolescent function 'bzero' called. It is recommended to use 'memset' instead. [prohibitedbzeroCalled] netrek-client-cow-3.3.2/socket.c:2368:3: style: Obsolescent function 'bzero' called. It is recommended to use 'memset' instead. [prohibitedbzeroCalled] netrek-client-cow-3.3.2/socket.c:2404:3: style: Obsolescent function 'bzero' called. It is recommended to use 'memset' instead. [prohibitedbzeroCalled] netrek-client-cow-3.3.2/socket.c:2434:3: style: Obsolescent function 'bzero' called. It is recommended to use 'memset' instead. [prohibitedbzeroCalled] netrek-client-cow-3.3.2/socket.c:2743:3: style: Obsolescent function 'bzero' called. It is recommended to use 'memset' instead. [prohibitedbzeroCalled] netrek-client-cow-3.3.2/socket.c:3489:14: style: Obsolescent function 'gethostbyname' called. It is recommended to use 'getaddrinfo' instead. [prohibitedgethostbynameCalled] netrek-client-cow-3.3.2/socket.c:1292:16: style: Condition 'size==0' is always false [knownConditionTrueFalse] netrek-client-cow-3.3.2/socket.c:1295:52: style: Condition 'size==0' is always false [knownConditionTrueFalse] netrek-client-cow-3.3.2/socket.c:1313:13: style: Condition 'size==0' is always false [knownConditionTrueFalse] netrek-client-cow-3.3.2/socket.c:1375:9: style: Condition 'drop_flag' is always true [knownConditionTrueFalse] netrek-client-cow-3.3.2/socket.c:1543:7: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] netrek-client-cow-3.3.2/socket.c:1544:7: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] netrek-client-cow-3.3.2/socket.c:1545:7: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] netrek-client-cow-3.3.2/socket.c:1546:7: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] netrek-client-cow-3.3.2/socket.c:1547:7: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] netrek-client-cow-3.3.2/socket.c:2890:5: error: Common realloc mistake: 'ranks' nulled but not freed upon failure [memleakOnRealloc] netrek-client-cow-3.3.2/socket.c:794:11: warning: If memory allocation fails, then there is a possible null pointer dereference: serverName [nullPointerOutOfMemory] netrek-client-cow-3.3.2/socket.c:793:32: note: Assuming allocation function fails netrek-client-cow-3.3.2/socket.c:793:17: note: Assignment 'serverName=(char*)malloc(strlen(hp->h_name)+1)', assigned value is 0 netrek-client-cow-3.3.2/socket.c:794:11: note: Null pointer dereference netrek-client-cow-3.3.2/socket.c:795:47: warning: If memory allocation fails, then there is a possible null pointer dereference: serverName [nullPointerOutOfMemory] netrek-client-cow-3.3.2/socket.c:793:32: note: Assuming allocation function fails netrek-client-cow-3.3.2/socket.c:793:17: note: Assignment 'serverName=(char*)malloc(strlen(hp->h_name)+1)', assigned value is 0 netrek-client-cow-3.3.2/socket.c:795:47: note: Null pointer dereference netrek-client-cow-3.3.2/socket.c:800:11: warning: If memory allocation fails, then there is a possible null pointer dereference: serverName [nullPointerOutOfMemory] netrek-client-cow-3.3.2/socket.c:799:32: note: Assuming allocation function fails netrek-client-cow-3.3.2/socket.c:799:17: note: Assignment 'serverName=(char*)malloc(strlen(inet_ntoa(addr.sin_addr))+1)', assigned value is 0 netrek-client-cow-3.3.2/socket.c:800:11: note: Null pointer dereference netrek-client-cow-3.3.2/socket.c:801:42: warning: If memory allocation fails, then there is a possible null pointer dereference: serverName [nullPointerOutOfMemory] netrek-client-cow-3.3.2/socket.c:799:32: note: Assuming allocation function fails netrek-client-cow-3.3.2/socket.c:799:17: note: Assignment 'serverName=(char*)malloc(strlen(inet_ntoa(addr.sin_addr))+1)', assigned value is 0 netrek-client-cow-3.3.2/socket.c:801:42: note: Null pointer dereference netrek-client-cow-3.3.2/socket.c:3006:3: style:inconclusive: Statements following 'return' will never be executed. [unreachableCode] netrek-client-cow-3.3.2/socket.c:2859:33: warning: Either the condition 'rate<0' is redundant or there is division by zero at line 2859. [zerodivcond] netrek-client-cow-3.3.2/socket.c:2855:15: note: Assuming that condition 'rate<0' is not redundant netrek-client-cow-3.3.2/socket.c:2859:33: note: Division by zero netrek-client-cow-3.3.2/socket.c:3372:6: style: Label 'send' is not used. [unusedLabel] netrek-client-cow-3.3.2/socket.c:1802:29: style:inconclusive: Function 'sendServerPacket' argument 1 names different: declaration 'packet' definition 'buffer'. [funcArgNamesDifferent] netrek-client-cow-3.3.2/socket.h:25:29: note: Function 'sendServerPacket' argument 1 names different: declaration 'packet' definition 'buffer'. netrek-client-cow-3.3.2/socket.c:1802:29: note: Function 'sendServerPacket' argument 1 names different: declaration 'packet' definition 'buffer'. netrek-client-cow-3.3.2/socket.c:489:11: style: Local variable 'status' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/data.h:56:23: note: Shadowed declaration netrek-client-cow-3.3.2/socket.c:489:11: note: Shadow variable netrek-client-cow-3.3.2/socket.c:489:19: style: Local variable 'war' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/data.h:321:9: note: Shadowed declaration netrek-client-cow-3.3.2/socket.c:489:19: note: Shadow variable netrek-client-cow-3.3.2/socket.c:1917:11: style: Local variable 'redraw' shadows outer function [shadowFunction] netrek-client-cow-3.3.2/redraw.h:1:6: note: Shadowed declaration netrek-client-cow-3.3.2/socket.c:1917:11: note: Shadow variable netrek-client-cow-3.3.2/socket.c:484:25: style: Variable 'data' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/socket.c:484:44: style: Variable 'infodata' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/socket.c:685:19: style: Variable 'hp' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/socket.c:811:20: style: Variable 'ent' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/socket.c:840:33: style: Parameter 'server' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/socket.c:1090:25: style: Parameter 'bufptr' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/socket.c:1425:41: style: Parameter 'packet' can be declared as pointer to const. However it seems that 'handleTorp' is a callback function, if 'packet' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/socket.c:232:33: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/socket.c:1425:41: note: Parameter 'packet' can be declared as pointer to const netrek-client-cow-3.3.2/socket.c:1466:50: style: Parameter 'packet' can be declared as pointer to const. However it seems that 'handleTorpInfo' is a callback function, if 'packet' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/socket.c:231:38: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/socket.c:1466:50: note: Parameter 'packet' can be declared as pointer to const netrek-client-cow-3.3.2/socket.c:1530:45: style: Parameter 'packet' can be declared as pointer to const. However it seems that 'handleStatus' is a callback function, if 'packet' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/socket.c:242:35: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/socket.c:1530:45: note: Parameter 'packet' can be declared as pointer to const netrek-client-cow-3.3.2/socket.c:1576:40: style: Parameter 'packet' can be declared as pointer to const. However it seems that 'handleSelf' is a callback function, if 'packet' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/socket.c:240:32: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/socket.c:1576:40: note: Parameter 'packet' can be declared as pointer to const netrek-client-cow-3.3.2/socket.c:1647:45: style: Parameter 'packet' can be declared as pointer to const. However it seems that 'handlePlayer' is a callback function, if 'packet' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/socket.c:230:35: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/socket.c:1647:45: note: Parameter 'packet' can be declared as pointer to const netrek-client-cow-3.3.2/socket.c:1912:45: style: Parameter 'packet' can be declared as pointer to const. However it seems that 'handlePlanet' is a callback function, if 'packet' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/socket.c:243:35: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/socket.c:1912:45: note: Parameter 'packet' can be declared as pointer to const netrek-client-cow-3.3.2/socket.c:1973:45: style: Parameter 'packet' can be declared as pointer to const. However it seems that 'handlePhaser' is a callback function, if 'packet' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/socket.c:233:35: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/socket.c:1973:45: note: Parameter 'packet' can be declared as pointer to const netrek-client-cow-3.3.2/socket.c:2054:43: style: Parameter 'packet' can be declared as pointer to const. However it seems that 'handleQueue' is a callback function, if 'packet' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/socket.c:241:34: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/socket.c:2054:43: note: Parameter 'packet' can be declared as pointer to const netrek-client-cow-3.3.2/socket.c:2070:45: style: Parameter 'packet' can be declared as pointer to const. However it seems that 'handlePickok' is a callback function, if 'packet' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/socket.c:244:35: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/socket.c:2070:45: note: Parameter 'packet' can be declared as pointer to const netrek-client-cow-3.3.2/socket.c:2075:25: style: Parameter 'name' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/socket.c:2075:37: style: Parameter 'pass' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/socket.c:2090:43: style: Parameter 'packet' can be declared as pointer to const. However it seems that 'handleLogin' is a callback function, if 'packet' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/socket.c:245:34: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/socket.c:2090:43: note: Parameter 'packet' can be declared as pointer to const netrek-client-cow-3.3.2/socket.c:2150:54: style: Parameter 'packet' can be declared as pointer to const. However it seems that 'handlePlasmaInfo' is a callback function, if 'packet' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/socket.c:234:40: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/socket.c:2150:54: note: Parameter 'packet' can be declared as pointer to const netrek-client-cow-3.3.2/socket.c:2199:45: style: Parameter 'packet' can be declared as pointer to const. However it seems that 'handlePlasma' is a callback function, if 'packet' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/socket.c:237:35: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/socket.c:2199:45: note: Parameter 'packet' can be declared as pointer to const netrek-client-cow-3.3.2/socket.c:2233:43: style: Parameter 'packet' can be declared as pointer to const. However it seems that 'handleFlags' is a callback function, if 'packet' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/socket.c:246:34: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/socket.c:2233:43: note: Parameter 'packet' can be declared as pointer to const netrek-client-cow-3.3.2/socket.c:2273:43: style: Parameter 'packet' can be declared as pointer to const. However it seems that 'handleKills' is a callback function, if 'packet' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/socket.c:229:34: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/socket.c:2273:43: note: Parameter 'packet' can be declared as pointer to const netrek-client-cow-3.3.2/socket.c:2394:41: style: Parameter 'packet' can be declared as pointer to const. However it seems that 'handleMask' is a callback function, if 'packet' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/socket.c:247:33: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/socket.c:2394:41: note: Parameter 'packet' can be declared as pointer to const netrek-client-cow-3.3.2/socket.c:2447:30: style: Parameter 'reason' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/socket.c:2452:53: style: Parameter 'packet' can be declared as pointer to const. However it seems that 'handleBadVersion' is a callback function, if 'packet' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/socket.c:249:39: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/socket.c:2452:53: note: Parameter 'packet' can be declared as pointer to const netrek-client-cow-3.3.2/socket.c:2486:47: style: Parameter 'packet' can be declared as pointer to const. However it seems that 'handleHostile' is a callback function, if 'packet' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/socket.c:252:36: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/socket.c:2486:47: note: Parameter 'packet' can be declared as pointer to const netrek-client-cow-3.3.2/socket.c:2580:43: style: Parameter 'packet' can be declared as pointer to const. However it seems that 'handleStats' is a callback function, if 'packet' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/socket.c:253:34: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/socket.c:2580:43: note: Parameter 'packet' can be declared as pointer to const netrek-client-cow-3.3.2/socket.c:2623:50: style: Parameter 'packet' can be declared as pointer to const. However it seems that 'handlePlyrInfo' is a callback function, if 'packet' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/socket.c:228:38: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/socket.c:2623:50: note: Parameter 'packet' can be declared as pointer to const netrek-client-cow-3.3.2/socket.c:2689:52: style: Parameter 'packet' can be declared as pointer to const. However it seems that 'handlePlanetLoc' is a callback function, if 'packet' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/socket.c:258:39: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/socket.c:2689:52: note: Parameter 'packet' can be declared as pointer to const netrek-client-cow-3.3.2/socket.c:2789:48: style: Parameter 'packet' can be declared as pointer to const. However it seems that 'handleShipCap' is a callback function, if 'packet' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/socket.c:287:37: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/socket.c:2789:48: note: Parameter 'packet' can be declared as pointer to const netrek-client-cow-3.3.2/socket.c:2809:49: style: Parameter 'packet' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/socket.c:2816:49: style: Parameter 'packet' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/socket.c:2917:32: style: Parameter 'packet' can be declared as pointer to const. However it seems that 'handleLtd' is a callback function, if 'packet' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/socket.c:345:32: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/socket.c:2917:32: note: Parameter 'packet' can be declared as pointer to const netrek-client-cow-3.3.2/socket.c:3291:50: style: Parameter 'packet' can be declared as pointer to const. However it seems that 'handleUdpReply' is a callback function, if 'packet' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/socket.c:268:38: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/socket.c:3291:50: note: Parameter 'packet' can be declared as pointer to const netrek-client-cow-3.3.2/socket.c:3657:49: style: Parameter 'packet' can be declared as pointer to const. However it seems that 'handleSequence' is a callback function, if 'packet' is declared with const you might also need to cast function pointer(s). [constParameterCallback] netrek-client-cow-3.3.2/socket.c:270:40: note: You might need to cast the function pointer here netrek-client-cow-3.3.2/socket.c:3657:49: note: Parameter 'packet' can be declared as pointer to const netrek-client-cow-3.3.2/socket.c:5018:58: style: Parameter 's2' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/socket.c:490:22: style: Variable 'shift' is assigned a value that is never used. [unreadVariable] netrek-client-cow-3.3.2/socket.c:1178:18: style: Variable 'timeout.tv_sec' is assigned a value that is never used. [unreadVariable] netrek-client-cow-3.3.2/socket.c:1179:19: style: Variable 'timeout.tv_usec' is assigned a value that is never used. [unreadVariable] netrek-client-cow-3.3.2/socket.c:2985:39: style: Variable 'ltd.damage_repaired' is assigned a value that is never used. [unreadVariable] netrek-client-cow-3.3.2/socket.c:2997:39: style: Variable 'ltd.weapons.plasma.fired' is assigned a value that is never used. [unreadVariable] netrek-client-cow-3.3.2/socket.c:2998:39: style: Variable 'ltd.weapons.plasma.hit' is assigned a value that is never used. [unreadVariable] netrek-client-cow-3.3.2/socket.c:2999:39: style: Variable 'ltd.weapons.plasma.phasered' is assigned a value that is never used. [unreadVariable] netrek-client-cow-3.3.2/socket.c:3000:39: style: Variable 'ltd.weapons.plasma.wall' is assigned a value that is never used. [unreadVariable] netrek-client-cow-3.3.2/socket.c:3001:39: style: Variable 'ltd.weapons.plasma.damage.inflicted' is assigned a value that is never used. [unreadVariable] netrek-client-cow-3.3.2/socket.c:3002:39: style: Variable 'ltd.weapons.plasma.damage.taken' is assigned a value that is never used. [unreadVariable] netrek-client-cow-3.3.2/stats.c:47:13: style: struct member 'record::data' is never used. [unusedStructMember] netrek-client-cow-3.3.2/stats.c:48:13: style: struct member 'record::last_value' is never used. [unusedStructMember] netrek-client-cow-3.3.2/strdup.c:5:12: style: Parameter 'strptr' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/udpopt.c:36:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BUFSIZ [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/udpopt.c:152:29: style: Parameter 'data' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/usleep.c:13:1: portability: Omitted return type of function 'usleep' defaults to int, this is not supported by ISO C99 and later standards. [returnImplicitInt] netrek-client-cow-3.3.2/usleep.c:25:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable errno [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/util.c:40:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable targtype [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/war.c:56:36: style: Parameter 'string' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/war.c:108:29: style: Parameter 'data' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/warning.c:52:12: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] netrek-client-cow-3.3.2/warning.c:20:14: style: Variable 'tm' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/wsl.c:50:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PATH_MAX [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/wsl.c:269:56: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WAVEHDR [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/wsl.c:294:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PCMWAVEFORMAT [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/wsl.c:329:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WHDR_DONE [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/wsl.c:188:11: warning: If memory allocation fails, then there is a possible null pointer dereference: newsnd [nullPointerOutOfMemory] netrek-client-cow-3.3.2/wsl.c:187:37: note: Assuming allocation function fails netrek-client-cow-3.3.2/wsl.c:187:13: note: Assignment 'newsnd=(struct sound*)malloc(sizeof(struct sound))', assigned value is 0 netrek-client-cow-3.3.2/wsl.c:188:11: note: Null pointer dereference netrek-client-cow-3.3.2/wsl.c:75:7: style: Statements following 'return' will never be executed. [unreachableCode] netrek-client-cow-3.3.2/wsl.c:245:21: style: Variable 'tmp' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/wsl.c:245:25: style: Variable 'tmp' is assigned a value that is never used. [unreadVariable] netrek-client-cow-3.3.2/x11sprite.c:128:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11sprite.c:177:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11sprite.c:223:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11sprite.c:265:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11sprite.c:784:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FTS_F [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11sprite.c:215:5: warning:inconclusive: The buffer 'pixmapDir' may not be null-terminated after the call to strncpy(). [terminateStrncpy] netrek-client-cow-3.3.2/x11sprite.c:742:21: error: Memory leak: sprite [memleak] netrek-client-cow-3.3.2/x11sprite.c:824:21: error: Memory leak: sprite [memleak] netrek-client-cow-3.3.2/x11sprite.c:790:7: error: Common realloc mistake: 'ss' nulled but not freed upon failure [memleakOnRealloc] netrek-client-cow-3.3.2/x11sprite.c:782:37: error: Null pointer dereference [nullPointer] netrek-client-cow-3.3.2/x11sprite.c:209:11: style: Variable 'pd' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/x11sprite.c:498:18: style: Variable 'this' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/x11sprite.c:530:18: style: Variable 'this' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/x11sprite.c:553:18: style: Variable 'this' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/x11sprite.c:576:18: style: Variable 'this' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/x11sprite.c:732:46: style: Parameter 'name' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/x11sprite.c:814:40: style: Parameter 'name' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/x11window.c:354:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:382:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable USPosition [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:406:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:463:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:572:64: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GCFont [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:609:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:684:7: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GXand [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:937:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KeyPressMask [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:1281:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ClientMessage [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:1718:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable x [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:1955:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ExposureMask [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:2092:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable StructureNotifyMask [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:2228:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:2382:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KeyPressMask [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:2728:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable XC_trek [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:2779:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable XC_pirate [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:2808:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable XC_left_ptr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:2866:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable XC_xterm [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:2946:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BitmapSuccess [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:2969:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable width [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:2975:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable height [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:3024:77: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable name [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:3054:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:3075:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:3119:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:3289:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable None [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:3365:1: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable handle_keydown [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:3366:1: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable handle_keydown [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:3368:1: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable handle_keyup [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:3369:1: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable handle_keyup [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:3371:1: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable handle_button [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:3372:1: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable handle_button [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:3374:1: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable handle_expose [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:3375:1: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable handle_expose [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:3391:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PMinSize [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:3449:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable QueuedAlready [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:3455:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable QueuedAfterReading [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:3636:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable W_Ind [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:3652:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] netrek-client-cow-3.3.2/x11window.c:490:13: warning: Either the condition 'fontinfo==NULL' is redundant or there is possible null pointer dereference: fontinfo. [nullPointerRedundantCheck] netrek-client-cow-3.3.2/x11window.c:484:16: note: Assuming that condition 'fontinfo==NULL' is not redundant netrek-client-cow-3.3.2/x11window.c:490:13: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:491:17: warning: Either the condition 'fontinfo==NULL' is redundant or there is possible null pointer dereference: fontinfo. [nullPointerRedundantCheck] netrek-client-cow-3.3.2/x11window.c:484:16: note: Assuming that condition 'fontinfo==NULL' is not redundant netrek-client-cow-3.3.2/x11window.c:491:17: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:492:18: warning: Either the condition 'fontinfo==NULL' is redundant or there is possible null pointer dereference: fontinfo. [nullPointerRedundantCheck] netrek-client-cow-3.3.2/x11window.c:484:16: note: Assuming that condition 'fontinfo==NULL' is not redundant netrek-client-cow-3.3.2/x11window.c:492:18: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:492:49: warning: Either the condition 'fontinfo==NULL' is redundant or there is possible null pointer dereference: fontinfo. [nullPointerRedundantCheck] netrek-client-cow-3.3.2/x11window.c:484:16: note: Assuming that condition 'fontinfo==NULL' is not redundant netrek-client-cow-3.3.2/x11window.c:492:49: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:493:23: warning: Either the condition 'fontinfo==NULL' is redundant or there is possible null pointer dereference: fontinfo. [nullPointerRedundantCheck] netrek-client-cow-3.3.2/x11window.c:484:16: note: Assuming that condition 'fontinfo==NULL' is not redundant netrek-client-cow-3.3.2/x11window.c:493:23: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:1851:3: warning: If memory allocation fails, then there is a possible null pointer dereference: newicon [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:1849:35: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:1849:13: note: Assignment 'newicon=(struct icon*)malloc(sizeof(struct icon))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:1851:3: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:1852:3: warning: If memory allocation fails, then there is a possible null pointer dereference: newicon [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:1849:35: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:1849:13: note: Assignment 'newicon=(struct icon*)malloc(sizeof(struct icon))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:1852:3: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:1853:3: warning: If memory allocation fails, then there is a possible null pointer dereference: newicon [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:1849:35: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:1849:13: note: Assignment 'newicon=(struct icon*)malloc(sizeof(struct icon))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:1853:3: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:1866:3: warning: If memory allocation fails, then there is a possible null pointer dereference: newicon [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:1849:35: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:1849:13: note: Assignment 'newicon=(struct icon*)malloc(sizeof(struct icon))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:1866:3: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:1867:3: warning: If memory allocation fails, then there is a possible null pointer dereference: newicon [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:1849:35: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:1849:13: note: Assignment 'newicon=(struct icon*)malloc(sizeof(struct icon))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:1867:3: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:2016:3: warning: If memory allocation fails, then there is a possible null pointer dereference: newwin [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:2014:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:2014:12: note: Assignment 'newwin=(struct window*)malloc(sizeof(struct window))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:2016:3: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:2017:3: warning: If memory allocation fails, then there is a possible null pointer dereference: newwin [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:2014:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:2014:12: note: Assignment 'newwin=(struct window*)malloc(sizeof(struct window))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:2017:3: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:2018:3: warning: If memory allocation fails, then there is a possible null pointer dereference: newwin [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:2014:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:2014:12: note: Assignment 'newwin=(struct window*)malloc(sizeof(struct window))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:2018:3: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:2019:3: warning: If memory allocation fails, then there is a possible null pointer dereference: newwin [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:2014:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:2014:12: note: Assignment 'newwin=(struct window*)malloc(sizeof(struct window))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:2019:3: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:2020:3: warning: If memory allocation fails, then there is a possible null pointer dereference: newwin [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:2014:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:2014:12: note: Assignment 'newwin=(struct window*)malloc(sizeof(struct window))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:2020:3: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:2021:3: warning: If memory allocation fails, then there is a possible null pointer dereference: newwin [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:2014:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:2014:12: note: Assignment 'newwin=(struct window*)malloc(sizeof(struct window))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:2021:3: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:2022:3: warning: If memory allocation fails, then there is a possible null pointer dereference: newwin [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:2014:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:2014:12: note: Assignment 'newwin=(struct window*)malloc(sizeof(struct window))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:2022:3: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:2029:3: warning: If memory allocation fails, then there is a possible null pointer dereference: newwin [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:2014:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:2014:12: note: Assignment 'newwin=(struct window*)malloc(sizeof(struct window))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:2029:3: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:2058:20: warning: If memory allocation fails, then there is a possible null pointer dereference: win [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:2014:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:2014:12: note: Assignment 'newwin=(struct window*)malloc(sizeof(struct window))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:2023:13: note: Calling function 'addToHash', 1st argument 'newwin' value is 0 netrek-client-cow-3.3.2/x11window.c:2058:20: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:2065:4: warning: If memory allocation fails, then there is a possible null pointer dereference: *new [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:2063:38: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:2063:10: note: Assignment '*new=(struct windowlist*)malloc(sizeof(struct windowlist))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:2065:4: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:2129:3: warning: If memory allocation fails, then there is a possible null pointer dereference: sw [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:2127:41: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:2127:8: note: Assignment 'sw=(struct scrollingWindow*)malloc(sizeof(struct scrollingWindow))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:2129:3: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:2130:3: warning: If memory allocation fails, then there is a possible null pointer dereference: sw [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:2127:41: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:2127:8: note: Assignment 'sw=(struct scrollingWindow*)malloc(sizeof(struct scrollingWindow))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:2130:3: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:2131:3: warning: If memory allocation fails, then there is a possible null pointer dereference: sw [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:2127:41: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:2127:8: note: Assignment 'sw=(struct scrollingWindow*)malloc(sizeof(struct scrollingWindow))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:2131:3: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:2131:14: warning: If memory allocation fails, then there is a possible null pointer dereference: sw [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:2127:41: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:2127:8: note: Assignment 'sw=(struct scrollingWindow*)malloc(sizeof(struct scrollingWindow))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:2131:14: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:2131:25: warning: If memory allocation fails, then there is a possible null pointer dereference: sw [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:2127:41: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:2127:8: note: Assignment 'sw=(struct scrollingWindow*)malloc(sizeof(struct scrollingWindow))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:2131:25: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:2132:3: warning: If memory allocation fails, then there is a possible null pointer dereference: sw [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:2127:41: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:2127:8: note: Assignment 'sw=(struct scrollingWindow*)malloc(sizeof(struct scrollingWindow))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:2132:3: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:2180:7: warning: If memory allocation fails, then there is a possible null pointer dereference: new [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:2178:41: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:2178:13: note: Assignment 'new=(struct stringList*)malloc(sizeof(struct stringList))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:2180:7: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:2181:7: warning: If memory allocation fails, then there is a possible null pointer dereference: new [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:2178:41: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:2178:13: note: Assignment 'new=(struct stringList*)malloc(sizeof(struct stringList))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:2181:7: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:2199:11: warning: If memory allocation fails, then there is a possible null pointer dereference: new [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:2178:41: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:2178:13: note: Assignment 'new=(struct stringList*)malloc(sizeof(struct stringList))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:2199:11: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:2200:3: warning: If memory allocation fails, then there is a possible null pointer dereference: new [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:2178:41: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:2178:13: note: Assignment 'new=(struct stringList*)malloc(sizeof(struct stringList))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:2200:3: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:2201:3: warning: If memory allocation fails, then there is a possible null pointer dereference: new [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:2178:41: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:2178:13: note: Assignment 'new=(struct stringList*)malloc(sizeof(struct stringList))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:2201:3: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:2409:7: warning: If memory allocation fails, then there is a possible null pointer dereference: items [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:2404:37: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:2404:11: note: Assignment 'items=(struct menuItem*)malloc(height*sizeof(struct menuItem))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:2409:7: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:2410:7: warning: If memory allocation fails, then there is a possible null pointer dereference: items [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:2404:37: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:2404:11: note: Assignment 'items=(struct menuItem*)malloc(height*sizeof(struct menuItem))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:2410:7: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:2411:7: warning: If memory allocation fails, then there is a possible null pointer dereference: items [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:2404:37: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:2404:11: note: Assignment 'items=(struct menuItem*)malloc(height*sizeof(struct menuItem))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:2411:7: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:3410:7: warning: If memory allocation fails, then there is a possible null pointer dereference: items [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:3408:38: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:3408:12: note: Assignment 'items=(struct menuItem*)malloc(newh*sizeof(struct menuItem))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:3410:7: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:3411:7: warning: If memory allocation fails, then there is a possible null pointer dereference: items [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:3408:38: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:3408:12: note: Assignment 'items=(struct menuItem*)malloc(newh*sizeof(struct menuItem))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:3411:7: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:3412:7: warning: If memory allocation fails, then there is a possible null pointer dereference: items [nullPointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:3408:38: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:3408:12: note: Assignment 'items=(struct menuItem*)malloc(newh*sizeof(struct menuItem))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:3412:7: note: Null pointer dereference netrek-client-cow-3.3.2/x11window.c:1131:35: style:inconclusive: Function 'W_CacheClearArea' argument 1 names different: declaration '' definition 'window'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1131:47: style:inconclusive: Function 'W_CacheClearArea' argument 2 names different: declaration '' definition 'x'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1131:54: style:inconclusive: Function 'W_CacheClearArea' argument 3 names different: declaration '' definition 'y'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1131:61: style:inconclusive: Function 'W_CacheClearArea' argument 4 names different: declaration '' definition 'width'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1131:72: style:inconclusive: Function 'W_CacheClearArea' argument 5 names different: declaration '' definition 'height'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1147:40: style:inconclusive: Function 'W_FlushClearAreaCache' argument 1 names different: declaration '' definition 'window'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1642:30: style:inconclusive: Function 'W_CacheLine' argument 1 names different: declaration '' definition 'window'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1642:42: style:inconclusive: Function 'W_CacheLine' argument 2 names different: declaration '' definition 'x0'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1642:50: style:inconclusive: Function 'W_CacheLine' argument 3 names different: declaration '' definition 'y0'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1642:58: style:inconclusive: Function 'W_CacheLine' argument 4 names different: declaration '' definition 'x1'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1642:66: style:inconclusive: Function 'W_CacheLine' argument 5 names different: declaration '' definition 'y1'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1642:74: style:inconclusive: Function 'W_CacheLine' argument 6 names different: declaration '' definition 'color'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1658:36: style:inconclusive: Function 'W_FlushLineCaches' argument 1 names different: declaration '' definition 'window'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1671:34: style:inconclusive: Function 'W_MakeTractLine' argument 1 names different: declaration '' definition 'window'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1671:46: style:inconclusive: Function 'W_MakeTractLine' argument 2 names different: declaration '' definition 'x0'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1671:54: style:inconclusive: Function 'W_MakeTractLine' argument 3 names different: declaration '' definition 'y0'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1671:62: style:inconclusive: Function 'W_MakeTractLine' argument 4 names different: declaration '' definition 'x1'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1671:70: style:inconclusive: Function 'W_MakeTractLine' argument 5 names different: declaration '' definition 'y1'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1671:82: style:inconclusive: Function 'W_MakeTractLine' argument 6 names different: declaration '' definition 'color'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1684:35: style:inconclusive: Function 'W_MakePhaserLine' argument 1 names different: declaration '' definition 'window'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1684:47: style:inconclusive: Function 'W_MakePhaserLine' argument 2 names different: declaration '' definition 'x0'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1684:55: style:inconclusive: Function 'W_MakePhaserLine' argument 3 names different: declaration '' definition 'y0'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1684:63: style:inconclusive: Function 'W_MakePhaserLine' argument 4 names different: declaration '' definition 'x1'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1684:71: style:inconclusive: Function 'W_MakePhaserLine' argument 5 names different: declaration '' definition 'y1'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1684:83: style:inconclusive: Function 'W_MakePhaserLine' argument 6 names different: declaration '' definition 'color'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1696:30: style:inconclusive: Function 'W_WriteCircle' argument 1 names different: declaration '' definition 'window'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1697:25: style:inconclusive: Function 'W_WriteCircle' argument 2 names different: declaration '' definition 'x'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1698:25: style:inconclusive: Function 'W_WriteCircle' argument 3 names different: declaration '' definition 'y'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1699:25: style:inconclusive: Function 'W_WriteCircle' argument 4 names different: declaration '' definition 'r'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1700:29: style:inconclusive: Function 'W_WriteCircle' argument 5 names different: declaration '' definition 'color'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1711:34: style:inconclusive: Function 'W_WriteTriangle' argument 1 names different: declaration '' definition 'window'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1711:46: style:inconclusive: Function 'W_WriteTriangle' argument 2 names different: declaration '' definition 'x'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1711:53: style:inconclusive: Function 'W_WriteTriangle' argument 3 names different: declaration '' definition 'y'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1711:60: style:inconclusive: Function 'W_WriteTriangle' argument 4 names different: declaration '' definition 's'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1711:67: style:inconclusive: Function 'W_WriteTriangle' argument 5 names different: declaration '' definition 't'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:1711:78: style:inconclusive: Function 'W_WriteTriangle' argument 6 names different: declaration '' definition 'color'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:3434:37: style:inconclusive: Function 'W_ResizeTextWindow' argument 1 names different: declaration '' definition 'window'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:3434:49: style:inconclusive: Function 'W_ResizeTextWindow' argument 2 names different: declaration '' definition 'neww'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:3434:59: style:inconclusive: Function 'W_ResizeTextWindow' argument 3 names different: declaration '' definition 'newh'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:3474:26: style:inconclusive: Function 'W_OverlayBitmap' argument 1 names different: declaration '' definition 'x'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:3474:33: style:inconclusive: Function 'W_OverlayBitmap' argument 2 names different: declaration '' definition 'y'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:3474:43: style:inconclusive: Function 'W_OverlayBitmap' argument 3 names different: declaration '' definition 'bit'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:3474:56: style:inconclusive: Function 'W_OverlayBitmap' argument 4 names different: declaration '' definition 'color'. [funcArgNamesDifferentUnnamed] netrek-client-cow-3.3.2/x11window.c:3487:34: style:inconclusive: Function 'W_SetWindowName' argument 1 names different: declaration 'window' definition 'w'. [funcArgNamesDifferent] netrek-client-cow-3.3.2/Wlib.h:84:38: note: Function 'W_SetWindowName' argument 1 names different: declaration 'window' definition 'w'. netrek-client-cow-3.3.2/x11window.c:3487:34: note: Function 'W_SetWindowName' argument 1 names different: declaration 'window' definition 'w'. netrek-client-cow-3.3.2/x11window.c:1874:16: style: Local variable 'icon' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/data.h:271:34: note: Shadowed declaration netrek-client-cow-3.3.2/x11window.c:1874:16: note: Shadow variable netrek-client-cow-3.3.2/x11window.c:1899:16: style: Local variable 'icon' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/data.h:271:34: note: Shadowed declaration netrek-client-cow-3.3.2/x11window.c:1899:16: note: Shadow variable netrek-client-cow-3.3.2/x11window.c:2487:11: style: Local variable 'w' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/data.h:320:27: note: Shadowed declaration netrek-client-cow-3.3.2/x11window.c:2487:11: note: Shadow variable netrek-client-cow-3.3.2/x11window.c:2540:11: style: Local variable 'w' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/data.h:320:27: note: Shadowed declaration netrek-client-cow-3.3.2/x11window.c:2540:11: note: Shadow variable netrek-client-cow-3.3.2/x11window.c:2712:11: style: Local variable 'w' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/data.h:320:27: note: Shadowed declaration netrek-client-cow-3.3.2/x11window.c:2712:11: note: Shadow variable netrek-client-cow-3.3.2/x11window.c:2792:11: style: Local variable 'w' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/data.h:320:27: note: Shadowed declaration netrek-client-cow-3.3.2/x11window.c:2792:11: note: Shadow variable netrek-client-cow-3.3.2/x11window.c:2850:11: style: Local variable 'w' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/data.h:320:27: note: Shadowed declaration netrek-client-cow-3.3.2/x11window.c:2850:11: note: Shadow variable netrek-client-cow-3.3.2/x11window.c:2938:11: style: Local variable 'status' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/data.h:56:23: note: Shadowed declaration netrek-client-cow-3.3.2/x11window.c:2938:11: note: Shadow variable netrek-client-cow-3.3.2/x11window.c:3304:33: style: Local variable 'status' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/data.h:56:23: note: Shadowed declaration netrek-client-cow-3.3.2/x11window.c:3304:33: note: Shadow variable netrek-client-cow-3.3.2/x11window.c:3324:33: style: Local variable 'status' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/data.h:56:23: note: Shadowed declaration netrek-client-cow-3.3.2/x11window.c:3324:33: note: Shadow variable netrek-client-cow-3.3.2/x11window.c:3383:18: style: Local variable 'w' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/data.h:320:27: note: Shadowed declaration netrek-client-cow-3.3.2/x11window.c:3383:18: note: Shadow variable netrek-client-cow-3.3.2/x11window.c:3424:19: style: Local variable 'w' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/data.h:320:27: note: Shadowed declaration netrek-client-cow-3.3.2/x11window.c:3424:19: note: Shadow variable netrek-client-cow-3.3.2/x11window.c:3476:16: style: Local variable 'icon' shadows outer variable [shadowVariable] netrek-client-cow-3.3.2/data.h:271:34: note: Shadowed declaration netrek-client-cow-3.3.2/x11window.c:3476:16: note: Shadow variable netrek-client-cow-3.3.2/x11window.c:361:11: style: Variable 'buff' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/x11window.c:376:11: style: Variable 'hm_default_string' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/x11window.c:453:30: style: Parameter 'fontinfo' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/x11window.c:453:46: style: Parameter 'fontname' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/x11window.c:604:25: style: Parameter 'oldf' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/x11window.c:1078:18: style: Variable 'win' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/x11window.c:1240:17: style: Variable 'button' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/x11window.c:1241:17: style: Variable 'expose' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/x11window.c:1242:20: style: Variable 'configure' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/x11window.c:2038:22: style: Variable 'entry' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/x11window.c:2904:16: style: Variable 'oldbits' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/x11window.c:2999:34: style: Parameter 'window' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/x11window.c:3220:29: style: Parameter 'name' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/x11window.c:3232:24: style: Parameter 'name' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/x11window.c:3264:23: style: Parameter 'name' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/x11window.c:3272:27: style: Parameter 'name' can be declared as pointer to const [constParameterPointer] netrek-client-cow-3.3.2/x11window.c:3326:18: style: Variable 'win' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/x11window.c:3799:18: style: Variable 'win' can be declared as pointer to const [constVariablePointer] netrek-client-cow-3.3.2/x11window.c:3799:22: style: Variable 'win' is assigned a value that is never used. [unreadVariable] netrek-client-cow-3.3.2/x11window.c:2058:20: warning: If memory allocation fails, then there is a possible null pointer dereference: win [ctunullpointerOutOfMemory] netrek-client-cow-3.3.2/x11window.c:2014:36: note: Assuming allocation function fails netrek-client-cow-3.3.2/x11window.c:2014:12: note: Assignment 'newwin=(struct window*)malloc(sizeof(struct window))', assigned value is 0 netrek-client-cow-3.3.2/x11window.c:2023:12: note: Calling function addToHash, 1st argument is null netrek-client-cow-3.3.2/x11window.c:2058:20: note: Dereferencing argument win that is null diff: head netrek-client-cow-3.3.2/cowmain.c:1032:22: style:inconclusive: Function 'handle_exception' argument 1 names different: declaration '' definition '_dummy'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/dmessage.c:39:14: style: Variable 'tm' can be declared as pointer to const [constVariablePointer] head netrek-client-cow-3.3.2/inform.c:40:27: style: Variable 'k' can be declared as pointer to const [constVariablePointer] head netrek-client-cow-3.3.2/inform.c:42:71: style: Variable 'target' can be declared as pointer to const [constVariablePointer] head netrek-client-cow-3.3.2/netstatopt.c:26:20: style:inconclusive: Function 'nsrefresh' argument 1 names different: declaration '' definition 'i'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/random.c:201:19: style:inconclusive: Function 'srandom' argument 1 names different: declaration '' definition 'x'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/setstate.c:205:15: style:inconclusive: Function 'srandom' argument 1 names different: declaration '' definition 'x'. [funcArgNamesDifferentUnnamed] 2.20.0 netrek-client-cow-3.3.2/socket.c:1016:41: error:inconclusive: Using pointer to local variable 'mask' that is out of scope. [invalidLifetime] netrek-client-cow-3.3.2/socket.c:997:17: note: Address of variable taken here. netrek-client-cow-3.3.2/socket.c:1005:58: note: Assuming condition is false netrek-client-cow-3.3.2/socket.c:995:15: note: Variable created here. netrek-client-cow-3.3.2/socket.c:1016:41: note: Using pointer to local variable 'mask' that is out of scope. head netrek-client-cow-3.3.2/x11window.c:1131:35: style:inconclusive: Function 'W_CacheClearArea' argument 1 names different: declaration '' definition 'window'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1131:47: style:inconclusive: Function 'W_CacheClearArea' argument 2 names different: declaration '' definition 'x'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1131:54: style:inconclusive: Function 'W_CacheClearArea' argument 3 names different: declaration '' definition 'y'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1131:61: style:inconclusive: Function 'W_CacheClearArea' argument 4 names different: declaration '' definition 'width'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1131:72: style:inconclusive: Function 'W_CacheClearArea' argument 5 names different: declaration '' definition 'height'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1147:40: style:inconclusive: Function 'W_FlushClearAreaCache' argument 1 names different: declaration '' definition 'window'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1642:30: style:inconclusive: Function 'W_CacheLine' argument 1 names different: declaration '' definition 'window'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1642:42: style:inconclusive: Function 'W_CacheLine' argument 2 names different: declaration '' definition 'x0'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1642:50: style:inconclusive: Function 'W_CacheLine' argument 3 names different: declaration '' definition 'y0'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1642:58: style:inconclusive: Function 'W_CacheLine' argument 4 names different: declaration '' definition 'x1'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1642:66: style:inconclusive: Function 'W_CacheLine' argument 5 names different: declaration '' definition 'y1'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1642:74: style:inconclusive: Function 'W_CacheLine' argument 6 names different: declaration '' definition 'color'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1658:36: style:inconclusive: Function 'W_FlushLineCaches' argument 1 names different: declaration '' definition 'window'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1671:34: style:inconclusive: Function 'W_MakeTractLine' argument 1 names different: declaration '' definition 'window'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1671:46: style:inconclusive: Function 'W_MakeTractLine' argument 2 names different: declaration '' definition 'x0'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1671:54: style:inconclusive: Function 'W_MakeTractLine' argument 3 names different: declaration '' definition 'y0'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1671:62: style:inconclusive: Function 'W_MakeTractLine' argument 4 names different: declaration '' definition 'x1'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1671:70: style:inconclusive: Function 'W_MakeTractLine' argument 5 names different: declaration '' definition 'y1'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1671:82: style:inconclusive: Function 'W_MakeTractLine' argument 6 names different: declaration '' definition 'color'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1684:35: style:inconclusive: Function 'W_MakePhaserLine' argument 1 names different: declaration '' definition 'window'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1684:47: style:inconclusive: Function 'W_MakePhaserLine' argument 2 names different: declaration '' definition 'x0'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1684:55: style:inconclusive: Function 'W_MakePhaserLine' argument 3 names different: declaration '' definition 'y0'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1684:63: style:inconclusive: Function 'W_MakePhaserLine' argument 4 names different: declaration '' definition 'x1'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1684:71: style:inconclusive: Function 'W_MakePhaserLine' argument 5 names different: declaration '' definition 'y1'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1684:83: style:inconclusive: Function 'W_MakePhaserLine' argument 6 names different: declaration '' definition 'color'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1696:30: style:inconclusive: Function 'W_WriteCircle' argument 1 names different: declaration '' definition 'window'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1697:25: style:inconclusive: Function 'W_WriteCircle' argument 2 names different: declaration '' definition 'x'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1698:25: style:inconclusive: Function 'W_WriteCircle' argument 3 names different: declaration '' definition 'y'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1699:25: style:inconclusive: Function 'W_WriteCircle' argument 4 names different: declaration '' definition 'r'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1700:29: style:inconclusive: Function 'W_WriteCircle' argument 5 names different: declaration '' definition 'color'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1711:34: style:inconclusive: Function 'W_WriteTriangle' argument 1 names different: declaration '' definition 'window'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1711:46: style:inconclusive: Function 'W_WriteTriangle' argument 2 names different: declaration '' definition 'x'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1711:53: style:inconclusive: Function 'W_WriteTriangle' argument 3 names different: declaration '' definition 'y'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1711:60: style:inconclusive: Function 'W_WriteTriangle' argument 4 names different: declaration '' definition 's'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1711:67: style:inconclusive: Function 'W_WriteTriangle' argument 5 names different: declaration '' definition 't'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:1711:78: style:inconclusive: Function 'W_WriteTriangle' argument 6 names different: declaration '' definition 'color'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:3434:37: style:inconclusive: Function 'W_ResizeTextWindow' argument 1 names different: declaration '' definition 'window'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:3434:49: style:inconclusive: Function 'W_ResizeTextWindow' argument 2 names different: declaration '' definition 'neww'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:3434:59: style:inconclusive: Function 'W_ResizeTextWindow' argument 3 names different: declaration '' definition 'newh'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:3474:26: style:inconclusive: Function 'W_OverlayBitmap' argument 1 names different: declaration '' definition 'x'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:3474:33: style:inconclusive: Function 'W_OverlayBitmap' argument 2 names different: declaration '' definition 'y'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:3474:43: style:inconclusive: Function 'W_OverlayBitmap' argument 3 names different: declaration '' definition 'bit'. [funcArgNamesDifferentUnnamed] head netrek-client-cow-3.3.2/x11window.c:3474:56: style:inconclusive: Function 'W_OverlayBitmap' argument 4 names different: declaration '' definition 'color'. [funcArgNamesDifferentUnnamed] DONE