2022-06-23 21:31
ftp://ftp.de.debian.org/debian/pool/main/n/ncmpc/ncmpc_0.46.orig.tar.xz
cppcheck-options: --library=posix --library=gnu  --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j2
platform: Linux-5.4.0-110-generic-x86_64-with-glibc2.29
python: 3.8.10
client-version: 1.3.24
compiler: g++ (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
cppcheck: head 2.8
head-info: 60c1eef (2022-06-23 20:26:47 +0200)
count: 186 186
elapsed-time: 4.3 5.7
head-timing-info:
 Overall time: 0s

old-timing-info:
 Overall time: 0s

head results:
ncmpc-0.46/src/Bindings.hxx:44:12: style: Struct 'KeyBinding' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
ncmpc-0.46/src/BasicMarquee.hxx:61:2: warning: Member variable 'BasicMarquee::max_offset' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/BasicMarquee.hxx:61:2: warning: Member variable 'BasicMarquee::offset' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/BasicMarquee.hxx:61:2: style: Class 'BasicMarquee' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
ncmpc-0.46/src/BasicMarquee.cxx:36:28: style:inconclusive: Function 'Set' argument 1 names different: declaration 'width' definition '_width'. [funcArgNamesDifferent]
ncmpc-0.46/src/BasicMarquee.hxx:74:20: note: Function 'Set' argument 1 names different: declaration 'width' definition '_width'.
ncmpc-0.46/src/BasicMarquee.cxx:36:28: note: Function 'Set' argument 1 names different: declaration 'width' definition '_width'.
ncmpc-0.46/src/BasicMarquee.cxx:36:48: style:inconclusive: Function 'Set' argument 2 names different: declaration 'text' definition '_text'. [funcArgNamesDifferent]
ncmpc-0.46/src/BasicMarquee.hxx:74:39: note: Function 'Set' argument 2 names different: declaration 'text' definition '_text'.
ncmpc-0.46/src/BasicMarquee.cxx:36:48: note: Function 'Set' argument 2 names different: declaration 'text' definition '_text'.
ncmpc-0.46/src/Bindings.cxx:66:38: style:inconclusive: Function 'Check' argument 2 names different: declaration 'size' definition 'bufsize'. [funcArgNamesDifferent]
ncmpc-0.46/src/Bindings.hxx:97:31: note: Function 'Check' argument 2 names different: declaration 'size' definition 'bufsize'.
ncmpc-0.46/src/Bindings.cxx:66:38: note: Function 'Check' argument 2 names different: declaration 'size' definition 'bufsize'.
ncmpc-0.46/src/Bindings.cxx:129:39: style:inconclusive: Function 'WriteToFile' argument 2 names different: declaration 'all' definition 'flags'. [funcArgNamesDifferent]
ncmpc-0.46/src/Bindings.hxx:102:32: note: Function 'WriteToFile' argument 2 names different: declaration 'all' definition 'flags'.
ncmpc-0.46/src/Bindings.cxx:129:39: note: Function 'WriteToFile' argument 2 names different: declaration 'all' definition 'flags'.
ncmpc-0.46/src/TextPage.hxx:70:7: style:inconclusive: Technically the member function 'TextPage::Repaint' can be const. [functionConst]
ncmpc-0.46/src/DelayedSeek.hxx:39:2: warning: Member variable 'DelayedSeek::time' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/util/RuntimeError.hxx:49:2: error: snprintf format string requires 2 parameters but only 1 is given. [wrongPrintfScanfArgNum]
ncmpc-0.46/src/util/StringStrip.hxx:49:39: style: C-style pointer casting [cstyleCast]
ncmpc-0.46/src/util/StringStrip.hxx:74:40: style: C-style pointer casting [cstyleCast]
ncmpc-0.46/src/util/StringStrip.hxx:75:12: style: C-style pointer casting [cstyleCast]
ncmpc-0.46/src/util/ScopeExit.hxx:46:31: warning:inconclusive: Access of moved variable 'src'. [accessMoved]
ncmpc-0.46/src/util/ScopeExit.hxx:46:6: note: Calling std::move(src)
ncmpc-0.46/src/util/ScopeExit.hxx:46:31: note: Access of moved variable 'src'.
ncmpc-0.46/src/util/ScopeExit.hxx:47:3: warning:inconclusive: Access of moved variable 'src'. [accessMoved]
ncmpc-0.46/src/util/ScopeExit.hxx:46:6: note: Calling std::move(src)
ncmpc-0.46/src/util/ScopeExit.hxx:47:3: note: Access of moved variable 'src'.
ncmpc-0.46/src/hscroll.hxx:58:2: warning: Member variable 'hscroll::x' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/hscroll.hxx:58:2: warning: Member variable 'hscroll::y' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/hscroll.hxx:58:2: warning: Member variable 'hscroll::style' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/EditPlaylistPage.cxx:131:34: style:inconclusive: Function 'GetTitle' argument 1 names different: declaration 's' definition 'str'. [funcArgNamesDifferent]
ncmpc-0.46/src/EditPlaylistPage.cxx:68:29: note: Function 'GetTitle' argument 1 names different: declaration 's' definition 'str'.
ncmpc-0.46/src/EditPlaylistPage.cxx:131:34: note: Function 'GetTitle' argument 1 names different: declaration 's' definition 'str'.
ncmpc-0.46/src/EditPlaylistPage.cxx:153:3: warning:inconclusive: Access of moved variable 'next_playlist_name'. [accessMoved]
ncmpc-0.46/src/EditPlaylistPage.cxx:149:11: note: Calling std::move(next_playlist_name)
ncmpc-0.46/src/EditPlaylistPage.cxx:153:3: note: Access of moved variable 'next_playlist_name'.
ncmpc-0.46/src/EditPlaylistPage.cxx:96:13: performance: Passing the result of c_str() to a function that takes std::string as argument no. 2 is slow and redundant. [stlcstrParam]
ncmpc-0.46/src/FileBrowserPage.cxx:78:7: style:inconclusive: Technically the member function 'FileBrowserPage::HandleDelete' can be const. [functionConst]
ncmpc-0.46/src/FileBrowserPage.cxx:229:18: note: Technically the member function 'FileBrowserPage::HandleDelete' can be const.
ncmpc-0.46/src/FileBrowserPage.cxx:78:7: note: Technically the member function 'FileBrowserPage::HandleDelete' can be const.
ncmpc-0.46/src/FileBrowserPage.cxx:285:33: style:inconclusive: Function 'GetTitle' argument 1 names different: declaration 's' definition 'str'. [funcArgNamesDifferent]
ncmpc-0.46/src/FileBrowserPage.cxx:84:29: note: Function 'GetTitle' argument 1 names different: declaration 's' definition 'str'.
ncmpc-0.46/src/FileBrowserPage.cxx:285:33: note: Function 'GetTitle' argument 1 names different: declaration 's' definition 'str'.
ncmpc-0.46/src/FileBrowserPage.cxx:238:9: style: Variable 'entry' can be declared as reference to const [constVariable]
ncmpc-0.46/src/HelpPage.cxx:46:12: style: Struct 'HelpRow' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
ncmpc-0.46/src/event/PollResultGeneric.hxx:41:3: warning: Member variable 'Item::events' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/event/PollResultGeneric.hxx:41:3: warning: Member variable 'Item::obj' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/event/Loop.hxx:293:7: performance:inconclusive: Technically the member function 'EventLoop::IsInside' can be static (but you may consider moving to unnamed namespace). [functionStatic]
ncmpc-0.46/src/KeyDefPage.cxx:56:2: warning: Member variable 'CommandKeysPage::bindings' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/KeyDefPage.cxx:56:2: warning: Member variable 'CommandKeysPage::binding' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/KeyDefPage.cxx:355:28: style: Unused private function: 'CommandListPage::GetLeavePosition' [unusedPrivateFunction]
ncmpc-0.46/src/KeyDefPage.cxx:350:11: performance:inconclusive: Technically the member function 'CommandListPage::command_length' can be static (but you may consider moving to unnamed namespace). [functionStatic]
ncmpc-0.46/src/KeyDefPage.cxx:362:7: style:inconclusive: Technically the member function 'CommandListPage::Apply' can be const. [functionConst]
ncmpc-0.46/src/KeyDefPage.cxx:388:18: note: Technically the member function 'CommandListPage::Apply' can be const.
ncmpc-0.46/src/KeyDefPage.cxx:362:7: note: Technically the member function 'CommandListPage::Apply' can be const.
ncmpc-0.46/src/KeyDefPage.cxx:363:7: performance:inconclusive: Technically the member function 'CommandListPage::Save' can be static (but you may consider moving to unnamed namespace). [functionStatic]
ncmpc-0.46/src/KeyDefPage.cxx:399:18: note: Technically the member function 'CommandListPage::Save' can be static (but you may consider moving to unnamed namespace).
ncmpc-0.46/src/KeyDefPage.cxx:363:7: note: Technically the member function 'CommandListPage::Save' can be static (but you may consider moving to unnamed namespace).
ncmpc-0.46/src/KeyDefPage.cxx:228:3: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
ncmpc-0.46/src/KeyDefPage.cxx:234:2: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
ncmpc-0.46/src/KeyDefPage.cxx:222:15: style:inconclusive: Function 'GetListItemText' argument 3 names different: declaration 'i' definition 'idx'. [funcArgNamesDifferent]
ncmpc-0.46/src/KeyDefPage.cxx:131:18: note: Function 'GetListItemText' argument 3 names different: declaration 'i' definition 'idx'.
ncmpc-0.46/src/KeyDefPage.cxx:222:15: note: Function 'GetListItemText' argument 3 names different: declaration 'i' definition 'idx'.
ncmpc-0.46/src/KeyDefPage.cxx:248:33: style:inconclusive: Function 'GetTitle' argument 1 names different: declaration 's' definition 'str'. [funcArgNamesDifferent]
ncmpc-0.46/src/KeyDefPage.cxx:126:29: note: Function 'GetTitle' argument 1 names different: declaration 's' definition 'str'.
ncmpc-0.46/src/KeyDefPage.cxx:248:33: note: Function 'GetTitle' argument 1 names different: declaration 's' definition 'str'.
ncmpc-0.46/src/KeyDefPage.cxx:431:15: style:inconclusive: Function 'GetListItemText' argument 3 names different: declaration 'i' definition 'idx'. [funcArgNamesDifferent]
ncmpc-0.46/src/KeyDefPage.cxx:375:18: note: Function 'GetListItemText' argument 3 names different: declaration 'i' definition 'idx'.
ncmpc-0.46/src/KeyDefPage.cxx:431:15: note: Function 'GetListItemText' argument 3 names different: declaration 'i' definition 'idx'.
ncmpc-0.46/src/util/ConstBuffer.hxx:239:10: error: Reference to local variable returned. [returnReference]
ncmpc-0.46/src/util/StringAPI.hxx:126:9: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled]
ncmpc-0.46/src/util/ConstBuffer.hxx:51:2: warning: Member variable 'ConstBuffer < void >::data' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/util/ConstBuffer.hxx:51:2: warning: Member variable 'ConstBuffer < void >::size' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/util/ConstBuffer.hxx:101:2: warning: Member variable 'ConstBuffer < char >::data' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/util/ConstBuffer.hxx:101:2: warning: Member variable 'ConstBuffer < char >::size' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/util/ConstBuffer.hxx:101:2: warning: Member variable 'ConstBuffer < value_type >::data' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/util/ConstBuffer.hxx:101:2: warning: Member variable 'ConstBuffer < value_type >::size' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/util/ConstBuffer.hxx:53:12: style: Struct 'ConstBuffer < void >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
ncmpc-0.46/src/util/StringView.hxx:237:12: style: Struct 'StringView' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
ncmpc-0.46/src/util/StringView.hxx:64:2: style: Struct 'BasicStringView < char >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
ncmpc-0.46/src/util/StringView.hxx:68:12: style: Struct 'BasicStringView < char >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
ncmpc-0.46/src/util/StringView.hxx:71:12: style: Struct 'BasicStringView < char >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
ncmpc-0.46/src/util/StringView.hxx:64:2: style: Struct 'BasicStringView < value_type >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
ncmpc-0.46/src/util/StringView.hxx:68:12: style: Struct 'BasicStringView < value_type >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
ncmpc-0.46/src/util/StringView.hxx:71:12: style: Struct 'BasicStringView < value_type >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
ncmpc-0.46/src/util/ConstBuffer.hxx:103:12: style: Struct 'ConstBuffer < char >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
ncmpc-0.46/src/util/ConstBuffer.hxx:116:12: style: Struct 'ConstBuffer < char >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
ncmpc-0.46/src/util/ConstBuffer.hxx:103:12: style: Struct 'ConstBuffer < value_type >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
ncmpc-0.46/src/util/ConstBuffer.hxx:116:12: style: Struct 'ConstBuffer < value_type >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
ncmpc-0.46/src/KeyName.cxx:81:4: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint]
ncmpc-0.46/src/util/ConstBuffer.hxx:137:21: style: Modulo of one is always equal to zero [moduloofone]
ncmpc-0.46/src/util/ConstBuffer.hxx:165:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm]
ncmpc-0.46/src/ListCursor.cxx:68:32: style:inconclusive: Function 'SetLength' argument 1 names different: declaration 'length' definition '_length'. [funcArgNamesDifferent]
ncmpc-0.46/src/ListCursor.hxx:194:26: note: Function 'SetLength' argument 1 names different: declaration 'length' definition '_length'.
ncmpc-0.46/src/ListCursor.cxx:68:32: note: Function 'SetLength' argument 1 names different: declaration 'length' definition '_length'.
ncmpc-0.46/src/LibraryPage.cxx:220:30: style:inconclusive: Function 'GetTitle' argument 1 names different: declaration 's' definition 'str'. [funcArgNamesDifferent]
ncmpc-0.46/src/LibraryPage.cxx:98:29: note: Function 'GetTitle' argument 1 names different: declaration 's' definition 'str'.
ncmpc-0.46/src/LibraryPage.cxx:220:30: note: Function 'GetTitle' argument 1 names different: declaration 's' definition 'str'.
ncmpc-0.46/src/Match.hxx:40:2: warning: Member variable 'MatchExpression::expression' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/Match.hxx:40:2: warning: Member variable 'MatchExpression::length' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/Match.hxx:40:2: warning: Member variable 'MatchExpression::anchored' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/LyricsCache.cxx:134:14: style: Checking if unsigned expression 'nbytes' is less than zero. [unsignedLessThanZero]
ncmpc-0.46/src/LyricsPage.cxx:194:41: style:inconclusive: Function 'OnPluginSuccess' argument 1 names different: declaration 'plugin_name' definition '_plugin_name'. [funcArgNamesDifferent]
ncmpc-0.46/src/LyricsPage.cxx:134:35: note: Function 'OnPluginSuccess' argument 1 names different: declaration 'plugin_name' definition '_plugin_name'.
ncmpc-0.46/src/LyricsPage.cxx:194:41: note: Function 'OnPluginSuccess' argument 1 names different: declaration 'plugin_name' definition '_plugin_name'.
ncmpc-0.46/src/LyricsPage.cxx:256:41: style:inconclusive: Function 'Load' argument 1 names different: declaration 'song' definition '_song'. [funcArgNamesDifferent]
ncmpc-0.46/src/LyricsPage.cxx:108:35: note: Function 'Load' argument 1 names different: declaration 'song' definition '_song'.
ncmpc-0.46/src/LyricsPage.cxx:256:41: note: Function 'Load' argument 1 names different: declaration 'song' definition '_song'.
ncmpc-0.46/src/LyricsPage.cxx:195:20: performance: Function parameter 'result' should be passed by const reference. [passedByValue]
ncmpc-0.46/src/LyricsPage.cxx:214:39: performance: Function parameter 'error' should be passed by const reference. [passedByValue]
ncmpc-0.46/src/Main.cxx:69:7: style: The scope of the variable 'tmp' can be reduced. [variableScope]
ncmpc-0.46/src/Options.cxx:70:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm]
ncmpc-0.46/src/Options.cxx:215:7: warning: Unnecessary comparison of static strings. [staticStringCompare]
ncmpc-0.46/src/ProgressBar.cxx:86:27: style:inconclusive: Function 'Set' argument 1 names different: declaration 'current' definition '_current'. [funcArgNamesDifferent]
ncmpc-0.46/src/ProgressBar.hxx:36:20: note: Function 'Set' argument 1 names different: declaration 'current' definition '_current'.
ncmpc-0.46/src/ProgressBar.cxx:86:27: note: Function 'Set' argument 1 names different: declaration 'current' definition '_current'.
ncmpc-0.46/src/ProgressBar.cxx:86:46: style:inconclusive: Function 'Set' argument 2 names different: declaration 'max' definition '_max'. [funcArgNamesDifferent]
ncmpc-0.46/src/ProgressBar.hxx:36:38: note: Function 'Set' argument 2 names different: declaration 'max' definition '_max'.
ncmpc-0.46/src/ProgressBar.cxx:86:46: note: Function 'Set' argument 2 names different: declaration 'max' definition '_max'.
ncmpc-0.46/src/Queue.cxx:33:26: style:inconclusive: Function 'GetChecked' argument 1 names different: declaration 'i' definition 'idx'. [funcArgNamesDifferent]
ncmpc-0.46/src/Queue.hxx:65:40: note: Function 'GetChecked' argument 1 names different: declaration 'i' definition 'idx'.
ncmpc-0.46/src/Queue.cxx:33:26: note: Function 'GetChecked' argument 1 names different: declaration 'i' definition 'idx'.
ncmpc-0.46/src/Queue.cxx:88:33: style:inconclusive: Function 'FindByUri' argument 1 names different: declaration 'uri' definition 'filename'. [funcArgNamesDifferent]
ncmpc-0.46/src/Queue.hxx:105:28: note: Function 'FindByUri' argument 1 names different: declaration 'uri' definition 'filename'.
ncmpc-0.46/src/Queue.cxx:88:33: note: Function 'FindByUri' argument 1 names different: declaration 'uri' definition 'filename'.
ncmpc-0.46/src/SearchPage.cxx:67:34: style: Condition 'strcasecmp(name,"file")==0' is always false [knownConditionTrueFalse]
ncmpc-0.46/src/SearchPage.cxx:66:36: style: Same expression on both sides of '||'. [duplicateExpression]
ncmpc-0.46/src/SearchPage.cxx:475:28: style:inconclusive: Function 'GetTitle' argument 1 names different: declaration 's' definition 'str'. [funcArgNamesDifferent]
ncmpc-0.46/src/SearchPage.cxx:143:29: note: Function 'GetTitle' argument 1 names different: declaration 's' definition 'str'.
ncmpc-0.46/src/SearchPage.cxx:475:28: note: Function 'GetTitle' argument 1 names different: declaration 's' definition 'str'.
ncmpc-0.46/src/QueuePage.cxx:181:16: style:inconclusive: Function 'GetListItemText' argument 3 names different: declaration 'i' definition 'idx'. [funcArgNamesDifferent]
ncmpc-0.46/src/QueuePage.cxx:123:18: note: Function 'GetListItemText' argument 3 names different: declaration 'i' definition 'idx'.
ncmpc-0.46/src/QueuePage.cxx:181:16: note: Function 'GetListItemText' argument 3 names different: declaration 'i' definition 'idx'.
ncmpc-0.46/src/QueuePage.cxx:266:37: style:inconclusive: Function 'Pre' argument 1 names different: declaration 'value' definition 'line'. [funcArgNamesDifferent]
ncmpc-0.46/src/QueuePage.cxx:261:23: note: Function 'Pre' argument 1 names different: declaration 'value' definition 'line'.
ncmpc-0.46/src/QueuePage.cxx:266:37: note: Function 'Pre' argument 1 names different: declaration 'value' definition 'line'.
ncmpc-0.46/src/QueuePage.cxx:280:38: style:inconclusive: Function 'Post' argument 1 names different: declaration 'value' definition 'line'. [funcArgNamesDifferent]
ncmpc-0.46/src/QueuePage.cxx:262:24: note: Function 'Post' argument 1 names different: declaration 'value' definition 'line'.
ncmpc-0.46/src/QueuePage.cxx:280:38: note: Function 'Post' argument 1 names different: declaration 'value' definition 'line'.
ncmpc-0.46/src/QueuePage.cxx:367:27: style:inconclusive: Function 'GetTitle' argument 1 names different: declaration 's' definition 'str'. [funcArgNamesDifferent]
ncmpc-0.46/src/QueuePage.cxx:138:29: note: Function 'GetTitle' argument 1 names different: declaration 's' definition 'str'.
ncmpc-0.46/src/QueuePage.cxx:367:27: note: Function 'GetTitle' argument 1 names different: declaration 's' definition 'str'.
ncmpc-0.46/src/SearchPage.cxx:349:6: error: Uninitialized variable: matchv [uninitvar]
ncmpc-0.46/src/SearchPage.cxx:322:36: note: Assuming condition is false
ncmpc-0.46/src/SearchPage.cxx:349:6: note: Uninitialized variable: matchv
ncmpc-0.46/src/SongPage.cxx:405:35: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled]
ncmpc-0.46/src/SongPage.cxx:183:52: style:inconclusive: Function 'GetListItemText' argument 3 names different: declaration 'i' definition 'idx'. [funcArgNamesDifferent]
ncmpc-0.46/src/SongPage.cxx:164:18: note: Function 'GetListItemText' argument 3 names different: declaration 'i' definition 'idx'.
ncmpc-0.46/src/SongPage.cxx:183:52: note: Function 'GetListItemText' argument 3 names different: declaration 'i' definition 'idx'.
ncmpc-0.46/src/SongPage.cxx:210:43: style:inconclusive: Function 'GetTitle' argument 1 names different: declaration 's' definition 'str'. [funcArgNamesDifferent]
ncmpc-0.46/src/SongPage.cxx:159:29: note: Function 'GetTitle' argument 1 names different: declaration 's' definition 'str'.
ncmpc-0.46/src/SongPage.cxx:210:43: note: Function 'GetTitle' argument 1 names different: declaration 's' definition 'str'.
ncmpc-0.46/src/SongPage.cxx:223:53: style:inconclusive: Function 'AppendLine' argument 2 names different: declaration 'value' definition 'value_utf8'. [funcArgNamesDifferent]
ncmpc-0.46/src/SongPage.cxx:140:49: note: Function 'AppendLine' argument 2 names different: declaration 'value' definition 'value_utf8'.
ncmpc-0.46/src/SongPage.cxx:223:53: note: Function 'AppendLine' argument 2 names different: declaration 'value' definition 'value_utf8'.
ncmpc-0.46/src/StatusBar.cxx:32:12: warning: Member variable 'StatusBar::left_text' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/StatusBar.cxx:32:12: warning: Member variable 'StatusBar::right_text' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/StatusBar.cxx:32:12: warning: Member variable 'StatusBar::left_width' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/StatusBar.cxx:32:12: warning: Member variable 'StatusBar::right_width' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/TagFilter.cxx:27:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm]
ncmpc-0.46/src/TagListPage.cxx:60:18: style:inconclusive: Function 'GetListItemText' argument 3 names different: declaration 'i' definition 'idx'. [funcArgNamesDifferent]
ncmpc-0.46/src/TagListPage.hxx:125:18: note: Function 'GetListItemText' argument 3 names different: declaration 'i' definition 'idx'.
ncmpc-0.46/src/TagListPage.cxx:60:18: note: Function 'GetListItemText' argument 3 names different: declaration 'i' definition 'idx'.
ncmpc-0.46/src/TextPage.cxx:72:63: style:inconclusive: Function 'GetListItemText' argument 3 names different: declaration 'i' definition 'idx'. [funcArgNamesDifferent]
ncmpc-0.46/src/TextPage.hxx:83:18: note: Function 'GetListItemText' argument 3 names different: declaration 'i' definition 'idx'.
ncmpc-0.46/src/TextPage.cxx:72:63: note: Function 'GetListItemText' argument 3 names different: declaration 'i' definition 'idx'.
ncmpc-0.46/src/TitleBar.cxx:32:11: warning: Member variable 'TitleBar::volume' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/TitleBar.cxx:32:11: warning: Member variable 'TitleBar::flags' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/aconnect.cxx:67:1: error: syntax error: keyword 'try' is not allowed in global scope [syntaxError]
ncmpc-0.46/src/event/Loop.cxx:36:12: warning: Member variable 'EventLoop::again' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/event/Loop.cxx:255:25: style: C-style pointer casting [cstyleCast]
ncmpc-0.46/src/event/SocketEvent.cxx:32:36: style:inconclusive: Function 'Open' argument 1 names different: declaration 'fd' definition '_fd'. [funcArgNamesDifferent]
ncmpc-0.46/src/event/SocketEvent.hxx:110:29: note: Function 'Open' argument 1 names different: declaration 'fd' definition '_fd'.
ncmpc-0.46/src/event/SocketEvent.cxx:32:36: note: Function 'Open' argument 1 names different: declaration 'fd' definition '_fd'.
ncmpc-0.46/src/event/net/ConnectSocket.cxx:72:29: performance:inconclusive: Function parameter 'address' should be passed by const reference. [passedByValue]
ncmpc-0.46/src/event/net/ConnectSocket.cxx:88:44: performance:inconclusive: Function parameter 'address' should be passed by const reference. [passedByValue]
ncmpc-0.46/src/gidle.cxx:36:16: warning: Member variable 'MpdIdleSource::idle_events' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/filelist.cxx:130:9: style: Variable 'entry' can be declared as reference to const [constVariable]
ncmpc-0.46/src/filelist.cxx:150:9: style: Variable 'entry' can be declared as reference to const [constVariable]
ncmpc-0.46/src/filelist.cxx:93:11: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm]
ncmpc-0.46/src/hscroll.cxx:34:23: style:inconclusive: Function 'Set' argument 1 names different: declaration 'x' definition '_x'. [funcArgNamesDifferent]
ncmpc-0.46/src/hscroll.hxx:74:20: note: Function 'Set' argument 1 names different: declaration 'x' definition '_x'.
ncmpc-0.46/src/hscroll.cxx:34:23: note: Function 'Set' argument 1 names different: declaration 'x' definition '_x'.
ncmpc-0.46/src/hscroll.cxx:34:36: style:inconclusive: Function 'Set' argument 2 names different: declaration 'y' definition '_y'. [funcArgNamesDifferent]
ncmpc-0.46/src/hscroll.hxx:74:32: note: Function 'Set' argument 2 names different: declaration 'y' definition '_y'.
ncmpc-0.46/src/hscroll.cxx:34:36: note: Function 'Set' argument 2 names different: declaration 'y' definition '_y'.
ncmpc-0.46/src/hscroll.cxx:34:49: style:inconclusive: Function 'Set' argument 3 names different: declaration 'width' definition '_width'. [funcArgNamesDifferent]
ncmpc-0.46/src/hscroll.hxx:74:44: note: Function 'Set' argument 3 names different: declaration 'width' definition '_width'.
ncmpc-0.46/src/hscroll.cxx:34:49: note: Function 'Set' argument 3 names different: declaration 'width' definition '_width'.
ncmpc-0.46/src/hscroll.cxx:34:69: style:inconclusive: Function 'Set' argument 4 names different: declaration 'text' definition '_text'. [funcArgNamesDifferent]
ncmpc-0.46/src/hscroll.hxx:74:63: note: Function 'Set' argument 4 names different: declaration 'text' definition '_text'.
ncmpc-0.46/src/hscroll.cxx:34:69: note: Function 'Set' argument 4 names different: declaration 'text' definition '_text'.
ncmpc-0.46/src/hscroll.cxx:35:13: style:inconclusive: Function 'Set' argument 5 names different: declaration 'style' definition '_style'. [funcArgNamesDifferent]
ncmpc-0.46/src/hscroll.hxx:75:10: note: Function 'Set' argument 5 names different: declaration 'style' definition '_style'.
ncmpc-0.46/src/hscroll.cxx:35:13: note: Function 'Set' argument 5 names different: declaration 'style' definition '_style'.
ncmpc-0.46/src/hscroll.cxx:35:28: style:inconclusive: Function 'Set' argument 6 names different: declaration 'attr' definition '_attr'. [funcArgNamesDifferent]
ncmpc-0.46/src/hscroll.hxx:75:24: note: Function 'Set' argument 6 names different: declaration 'attr' definition '_attr'.
ncmpc-0.46/src/hscroll.cxx:35:28: note: Function 'Set' argument 6 names different: declaration 'attr' definition '_attr'.
ncmpc-0.46/src/io/FileDescriptor.hxx:58:2: warning: Member variable 'FileDescriptor::fd' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/io/FileDescriptor.hxx:155:7: performance:inconclusive: Technically the member function 'FileDescriptor::SetBinaryMode' can be static (but you may consider moving to unnamed namespace). [functionStatic]
ncmpc-0.46/src/io/FileDescriptor.hxx:215:8: style:inconclusive: Technically the member function 'FileDescriptor::Seek' can be const. [functionConst]
ncmpc-0.46/src/io/FileDescriptor.hxx:219:8: style:inconclusive: Technically the member function 'FileDescriptor::Skip' can be const. [functionConst]
ncmpc-0.46/src/io/FileDescriptor.cxx:300:32: style:inconclusive: Function 'FullRead' argument 1 names different: declaration 'buffer' definition '_buffer'. [funcArgNamesDifferent]
ncmpc-0.46/src/io/FileDescriptor.hxx:242:22: note: Function 'FullRead' argument 1 names different: declaration 'buffer' definition '_buffer'.
ncmpc-0.46/src/io/FileDescriptor.cxx:300:32: note: Function 'FullRead' argument 1 names different: declaration 'buffer' definition '_buffer'.
ncmpc-0.46/src/io/FileDescriptor.cxx:318:39: style:inconclusive: Function 'FullWrite' argument 1 names different: declaration 'buffer' definition '_buffer'. [funcArgNamesDifferent]
ncmpc-0.46/src/io/FileDescriptor.hxx:252:29: note: Function 'FullWrite' argument 1 names different: declaration 'buffer' definition '_buffer'.
ncmpc-0.46/src/io/FileDescriptor.cxx:318:39: note: Function 'FullWrite' argument 1 names different: declaration 'buffer' definition '_buffer'.
ncmpc-0.46/src/lirc.cxx:44:33: style:inconclusive: Function 'LircInput' argument 1 names different: declaration 'event_loop' definition '_event_loop'. [funcArgNamesDifferent]
ncmpc-0.46/src/lirc.hxx:30:32: note: Function 'LircInput' argument 1 names different: declaration 'event_loop' definition '_event_loop'.
ncmpc-0.46/src/lirc.cxx:44:33: note: Function 'LircInput' argument 1 names different: declaration 'event_loop' definition '_event_loop'.
ncmpc-0.46/src/mpdclient.cxx:527:14: style: Condition 'source!=nullptr' is always true [knownConditionTrueFalse]
ncmpc-0.46/src/mpdclient.cxx:62:28: style:inconclusive: Function 'OnIdle' argument 1 names different: declaration 'events' definition '_events'. [funcArgNamesDifferent]
ncmpc-0.46/src/mpdclient.hxx:334:23: note: Function 'OnIdle' argument 1 names different: declaration 'events' definition '_events'.
ncmpc-0.46/src/mpdclient.cxx:62:28: note: Function 'OnIdle' argument 1 names different: declaration 'events' definition '_events'.
ncmpc-0.46/src/mpdclient.cxx:152:20: style:inconclusive: Function 'mpdclient' argument 2 names different: declaration 'host' definition '_host'. [funcArgNamesDifferent]
ncmpc-0.46/src/mpdclient.hxx:140:17: note: Function 'mpdclient' argument 2 names different: declaration 'host' definition '_host'.
ncmpc-0.46/src/mpdclient.cxx:152:20: note: Function 'mpdclient' argument 2 names different: declaration 'host' definition '_host'.
ncmpc-0.46/src/mpdclient.cxx:152:36: style:inconclusive: Function 'mpdclient' argument 3 names different: declaration 'port' definition '_port'. [funcArgNamesDifferent]
ncmpc-0.46/src/mpdclient.hxx:140:32: note: Function 'mpdclient' argument 3 names different: declaration 'port' definition '_port'.
ncmpc-0.46/src/mpdclient.cxx:152:36: note: Function 'mpdclient' argument 3 names different: declaration 'port' definition '_port'.
ncmpc-0.46/src/mpdclient.cxx:620:31: style:inconclusive: Function 'RunVolume' argument 1 names different: declaration 'new_volume' definition 'value'. [funcArgNamesDifferent]
ncmpc-0.46/src/mpdclient.hxx:295:26: note: Function 'RunVolume' argument 1 names different: declaration 'new_volume' definition 'value'.
ncmpc-0.46/src/mpdclient.cxx:620:31: note: Function 'RunVolume' argument 1 names different: declaration 'new_volume' definition 'value'.
ncmpc-0.46/src/mpdclient.cxx:646:57: style:inconclusive: Function 'mpdclient_cmd_add_path' argument 2 names different: declaration 'path' definition 'path_utf8'. [funcArgNamesDifferent]
ncmpc-0.46/src/mpdclient.hxx:365:57: note: Function 'mpdclient_cmd_add_path' argument 2 names different: declaration 'path' definition 'path_utf8'.
ncmpc-0.46/src/mpdclient.cxx:646:57: note: Function 'mpdclient_cmd_add_path' argument 2 names different: declaration 'path' definition 'path_utf8'.
ncmpc-0.46/src/mpdclient.cxx:808:29: style:inconclusive: Function 'RunMove' argument 1 names different: declaration 'dest' definition 'dest_pos'. [funcArgNamesDifferent]
ncmpc-0.46/src/mpdclient.hxx:303:24: note: Function 'RunMove' argument 1 names different: declaration 'dest' definition 'dest_pos'.
ncmpc-0.46/src/mpdclient.cxx:808:29: note: Function 'RunMove' argument 1 names different: declaration 'dest' definition 'dest_pos'.
ncmpc-0.46/src/mpdclient.cxx:808:48: style:inconclusive: Function 'RunMove' argument 2 names different: declaration 'src' definition 'src_pos'. [funcArgNamesDifferent]
ncmpc-0.46/src/mpdclient.hxx:303:39: note: Function 'RunMove' argument 2 names different: declaration 'src' definition 'src_pos'.
ncmpc-0.46/src/mpdclient.cxx:808:48: note: Function 'RunMove' argument 2 names different: declaration 'src' definition 'src_pos'.
ncmpc-0.46/src/net/SocketAddress.hxx:63:2: warning: Member variable 'SocketAddress::address' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/net/SocketAddress.hxx:63:2: warning: Member variable 'SocketAddress::size' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/net/AddressInfo.hxx:147:17: performance:inconclusive: Technically the member function 'AddressInfoList::end' can be static (but you may consider moving to unnamed namespace). [functionStatic]
ncmpc-0.46/src/net/SocketAddress.hxx:65:12: style: Class 'SocketAddress' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
ncmpc-0.46/src/net/AddressInfo.hxx:102:12: style: C-style pointer casting [cstyleCast]
ncmpc-0.46/src/net/AddressInfo.hxx:135:13: style: C-style pointer casting [cstyleCast]
ncmpc-0.46/src/net/IPv4Address.hxx:118:12: style: Class 'IPv4Address' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
ncmpc-0.46/src/net/IPv4Address.hxx:166:12: style: C-style pointer casting [cstyleCast]
ncmpc-0.46/src/net/IPv4Address.hxx:178:31: style: C-style pointer casting [cstyleCast]
ncmpc-0.46/src/net/IPv6Address.hxx:134:12: style: C-style pointer casting [cstyleCast]
ncmpc-0.46/src/net/IPv6Address.hxx:146:31: style: C-style pointer casting [cstyleCast]
ncmpc-0.46/src/net/AllocatedSocketAddress.cxx:62:13: style: C-style pointer casting [cstyleCast]
ncmpc-0.46/src/net/AllocatedSocketAddress.cxx:84:9: style: C-style pointer casting [cstyleCast]
ncmpc-0.46/src/net/AllocatedSocketAddress.cxx:105:15: style: C-style pointer casting [cstyleCast]
ncmpc-0.46/src/net/AllocatedSocketAddress.cxx:112:15: style: C-style pointer casting [cstyleCast]
ncmpc-0.46/src/net/SocketAddress.cxx:67:22: style: C-style pointer casting [cstyleCast]
ncmpc-0.46/src/net/StaticSocketAddress.hxx:54:2: warning: Member variable 'StaticSocketAddress::size' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/net/SocketDescriptor.cxx:235:37: style: C-style pointer casting [cstyleCast]
ncmpc-0.46/src/net/SocketDescriptor.cxx:272:38: style: C-style pointer casting [cstyleCast]
ncmpc-0.46/src/net/SocketDescriptor.cxx:441:23: style: C-style pointer casting [cstyleCast]
ncmpc-0.46/src/net/SocketDescriptor.cxx:452:24: style: C-style pointer casting [cstyleCast]
ncmpc-0.46/src/net/SocketDescriptor.cxx:507:37: style: C-style pointer casting [cstyleCast]
ncmpc-0.46/src/net/SocketDescriptor.cxx:527:26: style: C-style pointer casting [cstyleCast]
ncmpc-0.46/src/net/StaticSocketAddress.hxx:139:7: style:inconclusive: Technically the member function 'StaticSocketAddress::SetPort' can be const. [functionConst]
ncmpc-0.46/src/net/StaticSocketAddress.cxx:60:22: note: Technically the member function 'StaticSocketAddress::SetPort' can be const.
ncmpc-0.46/src/net/StaticSocketAddress.hxx:139:7: note: Technically the member function 'StaticSocketAddress::SetPort' can be const.
ncmpc-0.46/src/net/StaticSocketAddress.cxx:65:15: style: C-style pointer casting [cstyleCast]
ncmpc-0.46/src/net/StaticSocketAddress.cxx:72:15: style: C-style pointer casting [cstyleCast]
ncmpc-0.46/src/plugin.cxx:169:25: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled]
ncmpc-0.46/src/io/UniqueFileDescriptor.hxx:72:25: style: C-style pointer casting [cstyleCast]
ncmpc-0.46/src/plugin.cxx:309:29: style: C-style pointer casting [cstyleCast]
ncmpc-0.46/src/plugin.cxx:375:26: style:inconclusive: Function 'plugin_stop' argument 1 names different: declaration 'invocation' definition 'cycle'. [funcArgNamesDifferent]
ncmpc-0.46/src/plugin.hxx:83:26: note: Function 'plugin_stop' argument 1 names different: declaration 'invocation' definition 'cycle'.
ncmpc-0.46/src/plugin.cxx:375:26: note: Function 'plugin_stop' argument 1 names different: declaration 'invocation' definition 'cycle'.
ncmpc-0.46/src/screen.cxx:137:14: style: The scope of the variable 'initialized' can be reduced. [variableScope]
ncmpc-0.46/src/screen.cxx:138:14: style: The scope of the variable 'repeat' can be reduced. [variableScope]
ncmpc-0.46/src/screen.cxx:139:14: style: The scope of the variable 'random_enabled' can be reduced. [variableScope]
ncmpc-0.46/src/screen.cxx:140:14: style: The scope of the variable 'single' can be reduced. [variableScope]
ncmpc-0.46/src/screen.cxx:141:14: style: The scope of the variable 'consume' can be reduced. [variableScope]
ncmpc-0.46/src/screen.cxx:142:18: style: The scope of the variable 'crossfade' can be reduced. [variableScope]
ncmpc-0.46/src/screen_init.cxx:42:2: warning: Class 'ScreenManager' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor]
ncmpc-0.46/src/screen_init.cxx:42:2: warning: Class 'ScreenManager' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq]
ncmpc-0.46/src/screen_init.cxx:30:41: style:inconclusive: Function 'ScreenManager' argument 1 names different: declaration '_event_loop' definition 'event_loop'. [funcArgNamesDifferent]
ncmpc-0.46/src/screen.hxx:108:36: note: Function 'ScreenManager' argument 1 names different: declaration '_event_loop' definition 'event_loop'.
ncmpc-0.46/src/screen_init.cxx:30:41: note: Function 'ScreenManager' argument 1 names different: declaration '_event_loop' definition 'event_loop'.
ncmpc-0.46/src/screen_list.cxx:98:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm]
ncmpc-0.46/src/screen_utils.cxx:94:30: style:inconclusive: Function 'screen_get_yesno' argument 1 names different: declaration 'prompt' definition '_prompt'. [funcArgNamesDifferent]
ncmpc-0.46/src/screen_utils.hxx:41:30: note: Function 'screen_get_yesno' argument 1 names different: declaration 'prompt' definition '_prompt'.
ncmpc-0.46/src/screen_utils.cxx:94:30: note: Function 'screen_get_yesno' argument 1 names different: declaration 'prompt' definition '_prompt'.
ncmpc-0.46/src/TagMask.hxx:36:2: warning: Member variable 'TagMask::value' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/TagMask.hxx:38:12: style: Class 'TagMask' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
ncmpc-0.46/src/time_format.cxx:28:3: warning: %i in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
ncmpc-0.46/src/time_format.cxx:28:3: warning: %i in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
ncmpc-0.46/src/time_format.cxx:31:3: warning: %i in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
ncmpc-0.46/src/time_format.cxx:31:3: warning: %i in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
ncmpc-0.46/src/time_format.cxx:31:3: warning: %i in format string (no. 3) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
ncmpc-0.46/src/time_format.cxx:37:28: style:inconclusive: Function 'format_duration_long' argument 1 names different: declaration 'buffer' definition 'p'. [funcArgNamesDifferent]
ncmpc-0.46/src/time_format.hxx:28:28: note: Function 'format_duration_long' argument 1 names different: declaration 'buffer' definition 'p'.
ncmpc-0.46/src/time_format.cxx:37:28: note: Function 'format_duration_long' argument 1 names different: declaration 'buffer' definition 'p'.
ncmpc-0.46/src/time_format.cxx:39:25: style: Variable 'bytes_written' is assigned a value that is never used. [unreadVariable]
ncmpc-0.46/src/util/LocaleString.cxx:45:38: style:inconclusive: Function 'StringLengthMB' argument 2 names different: declaration 'n' definition 'byte_length'. [funcArgNamesDifferent]
ncmpc-0.46/src/util/LocaleString.hxx:48:38: note: Function 'StringLengthMB' argument 2 names different: declaration 'n' definition 'byte_length'.
ncmpc-0.46/src/util/LocaleString.cxx:45:38: note: Function 'StringLengthMB' argument 2 names different: declaration 'n' definition 'byte_length'.
ncmpc-0.46/src/wreadln.cxx:76:2: warning: Member variable 'wreadln::point' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/wreadln.cxx:76:2: warning: Member variable 'wreadln::width' is not initialized in the constructor. [uninitMemberVar]
ncmpc-0.46/src/wreadln.cxx:355:26: performance: Passing the result of c_str() to a function that takes std::string as argument no. 1 is slow and redundant. [stlcstrParam]
diff:
head ncmpc-0.46/src/FileBrowserPage.cxx:238:9: style: Variable 'entry' can be declared as reference to const [constVariable]
2.8 ncmpc-0.46/src/TagMask.hxx:41:12: style: Class 'TagMask' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
head ncmpc-0.46/src/filelist.cxx:130:9: style: Variable 'entry' can be declared as reference to const [constVariable]
head ncmpc-0.46/src/filelist.cxx:150:9: style: Variable 'entry' can be declared as reference to const [constVariable]
2.8 ncmpc-0.46/src/strfsong.cxx:57:36: style: Parameter 'dest_end' can be declared with const [constParameter]
2.8 ncmpc-0.46/src/strfsong.cxx:67:44: style: Parameter 'dest_end' can be declared with const [constParameter]


DONE