2025-11-22 17:47 ftp://ftp.de.debian.org/debian/pool/main/m/morris/morris_0.3.orig.tar.gz cppcheck-options: --library=posix --library=gnu --library=bsd --library=boost --library=gtk --inconclusive --enable=style,information --inline-suppr --template=daca2 --disable=missingInclude --suppress=unmatchedSuppression --check-library --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=normalCheckLevelConditionExpressions -D__GNUC__ --platform=unix64 -j4 platform: Linux-6.12.57+deb13-amd64-x86_64-with-glibc2.41 python: 3.13.5 client-version: 1.3.67 compiler: g++ (Debian 14.2.0-19) 14.2.0 cppcheck: head 2.18.0 head-info: cb76e52 (2025-11-22 14:47:37 +0100) count: 498 494 elapsed-time: 1.2 1.1 head-timing-info: old-timing-info: head results: morris-0.3/src/ttable.hh:95:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable hex [valueFlowBailoutIncompleteVar] morris-0.3/src/algo_alphabeta.cc:146:7: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] morris-0.3/src/algo_alphabeta.cc:237:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] morris-0.3/src/util.hh:64:3: warning:inconclusive: Member variable 'Point2D::x' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/util.hh:64:3: warning:inconclusive: Member variable 'Point2D::y' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/board.hh:75:1: style: The class 'Board' does not declare a constructor although it has private member variables which likely require initialization. [noConstructor] morris-0.3/src/algo_random.hh:33:3: warning: Member variable 'PlayerIF_AlgoRandom::m_tunnel' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/learn.hh:26:1: style: The class 'Experience' does not declare a constructor although it has private member variables which likely require initialization. [noConstructor] morris-0.3/src/util.hh:36:3: warning: Member variable 'SmallVec < short , MAXTAKES >::elem' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/util.hh:36:3: warning: Member variable 'SmallVec < short , MAXNEIGHBORS >::elem' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/util.hh:36:3: warning: Member variable 'SmallVec < short , MAXMILLSIZE >::elem' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/util.hh:36:3: warning: Member variable 'SmallVec < short , MAXPOSITIONS >::elem' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/ttable.hh:61:8: style:inconclusive: Technically the member function 'TranspositionTable::resetStats' can be const. [functionConst] morris-0.3/src/mainapp.hh:105:15: style:inconclusive: Technically the member function 'MainApp::getShareTTables' can be const. [functionConst] morris-0.3/src/boardspec.hh:128:3: style: Class 'BoardSpec_Polygon' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] morris-0.3/src/boardspec.hh:167:3: style: Class 'BoardSpec_Grid' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] morris-0.3/src/ttable.hh:29:3: style: Class 'TranspositionTable' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] morris-0.3/src/boardspec.hh:126:12: style: The destructor '~BoardSpec_Polygon' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardspec.hh:44:12: note: Virtual destructor in base class morris-0.3/src/boardspec.hh:126:12: note: Destructor in derived class morris-0.3/src/boardspec.hh:132:33: style: The function 'nPositions' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardspec.hh:47:33: note: Virtual function in base class morris-0.3/src/boardspec.hh:132:33: note: Function in derived class morris-0.3/src/boardspec.hh:133:33: style: The function 'getNeighbors' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardspec.hh:50:33: note: Virtual function in base class morris-0.3/src/boardspec.hh:133:33: note: Function in derived class morris-0.3/src/boardspec.hh:134:33: style: The function 'getPositionName' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardspec.hh:53:33: note: Virtual function in base class morris-0.3/src/boardspec.hh:134:33: note: Function in derived class morris-0.3/src/boardspec.hh:135:33: style: The function 'getPositionLocation' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardspec.hh:57:33: note: Virtual function in base class morris-0.3/src/boardspec.hh:135:33: note: Function in derived class morris-0.3/src/boardspec.hh:136:33: style: The function 'getPieceRadius' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardspec.hh:60:33: note: Virtual function in base class morris-0.3/src/boardspec.hh:136:33: note: Function in derived class morris-0.3/src/boardspec.hh:138:33: style: The function 'nMills' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardspec.hh:63:33: note: Virtual function in base class morris-0.3/src/boardspec.hh:138:33: note: Function in derived class morris-0.3/src/boardspec.hh:139:33: style: The function 'getMill' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardspec.hh:66:33: note: Virtual function in base class morris-0.3/src/boardspec.hh:139:33: note: Function in derived class morris-0.3/src/boardspec.hh:140:45: style: The function 'getMillsThroughPos' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardspec.hh:69:45: note: Virtual function in base class morris-0.3/src/boardspec.hh:140:45: note: Function in derived class morris-0.3/src/boardspec.hh:142:23: style: The function 'getBoardPresetID' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardspec.hh:98:23: note: Virtual function in base class morris-0.3/src/boardspec.hh:142:23: note: Function in derived class morris-0.3/src/boardspec.hh:165:12: style: The destructor '~BoardSpec_Grid' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardspec.hh:44:12: note: Virtual destructor in base class morris-0.3/src/boardspec.hh:165:12: note: Destructor in derived class morris-0.3/src/boardspec.hh:171:33: style: The function 'nPositions' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardspec.hh:47:33: note: Virtual function in base class morris-0.3/src/boardspec.hh:171:33: note: Function in derived class morris-0.3/src/boardspec.hh:172:33: style: The function 'getNeighbors' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardspec.hh:50:33: note: Virtual function in base class morris-0.3/src/boardspec.hh:172:33: note: Function in derived class morris-0.3/src/boardspec.hh:173:33: style: The function 'getPositionName' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardspec.hh:53:33: note: Virtual function in base class morris-0.3/src/boardspec.hh:173:33: note: Function in derived class morris-0.3/src/boardspec.hh:174:33: style: The function 'getPositionLocation' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardspec.hh:57:33: note: Virtual function in base class morris-0.3/src/boardspec.hh:174:33: note: Function in derived class morris-0.3/src/boardspec.hh:175:33: style: The function 'getPieceRadius' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardspec.hh:60:33: note: Virtual function in base class morris-0.3/src/boardspec.hh:175:33: note: Function in derived class morris-0.3/src/boardspec.hh:177:33: style: The function 'nMills' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardspec.hh:63:33: note: Virtual function in base class morris-0.3/src/boardspec.hh:177:33: note: Function in derived class morris-0.3/src/boardspec.hh:178:33: style: The function 'getMill' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardspec.hh:66:33: note: Virtual function in base class morris-0.3/src/boardspec.hh:178:33: note: Function in derived class morris-0.3/src/boardspec.hh:179:45: style: The function 'getMillsThroughPos' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardspec.hh:69:45: note: Virtual function in base class morris-0.3/src/boardspec.hh:179:45: note: Function in derived class morris-0.3/src/boardspec.hh:181:23: style: The function 'getBoardPresetID' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardspec.hh:98:23: note: Virtual function in base class morris-0.3/src/boardspec.hh:181:23: note: Function in derived class morris-0.3/src/algo_random.hh:35:8: style: The function 'registerThreadTunnel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/player.hh:53:16: note: Virtual function in base class morris-0.3/src/algo_random.hh:35:8: note: Function in derived class morris-0.3/src/algo_random.hh:37:8: style: The function 'isInteractivePlayer' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/player.hh:54:16: note: Virtual function in base class morris-0.3/src/algo_random.hh:37:8: note: Function in derived class morris-0.3/src/algo_random.hh:39:8: style: The function 'startMove' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/player.hh:57:16: note: Virtual function in base class morris-0.3/src/algo_random.hh:39:8: note: Function in derived class morris-0.3/src/algo_random.hh:41:8: style: The function 'forceMove' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/player.hh:58:16: note: Virtual function in base class morris-0.3/src/algo_random.hh:41:8: note: Function in derived class morris-0.3/src/algo_random.hh:42:8: style: The function 'cancelMove' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/player.hh:59:16: note: Virtual function in base class morris-0.3/src/algo_random.hh:42:8: note: Function in derived class morris-0.3/src/boardgui.hh:141:8: style: The function 'isInteractivePlayer' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/player.hh:54:16: note: Virtual function in base class morris-0.3/src/boardgui.hh:141:8: note: Function in derived class morris-0.3/src/boardgui.hh:143:8: style: The function 'startMove' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/player.hh:57:16: note: Virtual function in base class morris-0.3/src/boardgui.hh:143:8: note: Function in derived class morris-0.3/src/boardgui.hh:144:8: style: The function 'forceMove' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/player.hh:58:16: note: Virtual function in base class morris-0.3/src/boardgui.hh:144:8: note: Function in derived class morris-0.3/src/boardgui.hh:145:8: style: The function 'cancelMove' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/player.hh:59:16: note: Virtual function in base class morris-0.3/src/boardgui.hh:145:8: note: Function in derived class morris-0.3/src/algo_random.hh:37:8: style: The function 'isInteractivePlayer' overrides a function in a base class but is identical to the overridden function [uselessOverride] morris-0.3/src/player.hh:54:16: note: Virtual function in base class morris-0.3/src/algo_random.hh:37:8: note: Function in derived class morris-0.3/src/algo_random.hh:41:8: style: The function 'forceMove' overrides a function in a base class but is identical to the overridden function [uselessOverride] morris-0.3/src/player.hh:58:16: note: Virtual function in base class morris-0.3/src/algo_random.hh:41:8: note: Function in derived class morris-0.3/src/algo_random.hh:42:8: style: The function 'cancelMove' overrides a function in a base class but is identical to the overridden function [uselessOverride] morris-0.3/src/player.hh:59:16: note: Virtual function in base class morris-0.3/src/algo_random.hh:42:8: note: Function in derived class morris-0.3/src/boardgui.hh:144:8: style: The function 'forceMove' overrides a function in a base class but is identical to the overridden function [uselessOverride] morris-0.3/src/player.hh:58:16: note: Virtual function in base class morris-0.3/src/boardgui.hh:144:8: note: Function in derived class morris-0.3/src/gettext.h:138:29: style: C-style pointer casting [cstyleCast] morris-0.3/src/gettext.h:159:5: style: C-style pointer casting [cstyleCast] morris-0.3/src/gettext.h:207:8: style: C-style pointer casting [cstyleCast] morris-0.3/src/gettext.h:214:21: style: C-style pointer casting [cstyleCast] morris-0.3/src/gettext.h:253:8: style: C-style pointer casting [cstyleCast] morris-0.3/src/gettext.h:260:21: style: C-style pointer casting [cstyleCast] morris-0.3/src/learn.hh:99:5: style:inconclusive: Statements following 'return' will never be executed. [unreachableCode] morris-0.3/src/learn.hh:121:5: style:inconclusive: Statements following 'return' will never be executed. [unreachableCode] morris-0.3/src/gettext.h:199:15: style: The scope of the variable 'translation' can be reduced. [variableScope] morris-0.3/src/gettext.h:245:15: style: The scope of the variable 'translation' can be reduced. [variableScope] morris-0.3/src/learn.hh:121:19: style: Variable 'hash' is assigned a value that is never used. [unreadVariable] morris-0.3/src/learn.hh:121:15: style: Variable 'hash' is assigned a value that is never used. [unreadVariable] morris-0.3/src/appgtk_configmgr.cc:101:5: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] morris-0.3/src/appgtk_configmgr.cc:139:5: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] morris-0.3/src/appgtk_configmgr.cc:156:5: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn] morris-0.3/src/gtkcairo_boardgui.hh:55:3: warning: Member variable 'Animation_MoveOverlay::player' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/gtkcairo_boardgui.hh:55:3: warning: Member variable 'Animation::durationMS' is not initialized in the constructor. Maybe it should be initialized directly in the class Animation? [uninitDerivedMemberVar] morris-0.3/src/util.hh:36:3: warning: Member variable 'SmallVec < short , Move :: MAXTAKES + 1 >::elem' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/app_configmgr.hh:41:4: style: The destructor '~ConfigManager_Application' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/configmgr.hh:50:12: note: Virtual destructor in base class morris-0.3/src/app_configmgr.hh:41:4: note: Destructor in derived class morris-0.3/src/app_configmgr.hh:43:16: style: The function 'readInitialValues' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/configmgr.hh:52:16: note: Virtual function in base class morris-0.3/src/app_configmgr.hh:43:16: note: Function in derived class morris-0.3/src/app_configmgr.hh:45:16: style: The function 'store' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/configmgr.hh:54:16: note: Virtual function in base class morris-0.3/src/app_configmgr.hh:45:16: note: Function in derived class morris-0.3/src/app_configmgr.hh:46:16: style: The function 'store' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/configmgr.hh:55:16: note: Virtual function in base class morris-0.3/src/app_configmgr.hh:46:16: note: Function in derived class morris-0.3/src/app_configmgr.hh:47:16: style: The function 'store' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/configmgr.hh:56:16: note: Virtual function in base class morris-0.3/src/app_configmgr.hh:47:16: note: Function in derived class morris-0.3/src/app_configmgr.hh:48:16: style: The function 'store' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/configmgr.hh:57:16: note: Virtual function in base class morris-0.3/src/app_configmgr.hh:48:16: note: Function in derived class morris-0.3/src/app_configmgr.hh:50:17: style: The function 'read_int' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/configmgr.hh:59:17: note: Virtual function in base class morris-0.3/src/app_configmgr.hh:50:17: note: Function in derived class morris-0.3/src/app_configmgr.hh:51:17: style: The function 'read_bool' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/configmgr.hh:60:17: note: Virtual function in base class morris-0.3/src/app_configmgr.hh:51:17: note: Function in derived class morris-0.3/src/app_configmgr.hh:52:17: style: The function 'read_float' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/configmgr.hh:61:17: note: Virtual function in base class morris-0.3/src/app_configmgr.hh:52:17: note: Function in derived class morris-0.3/src/app_configmgr.hh:53:23: style: The function 'read_string' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/configmgr.hh:62:23: note: Virtual function in base class morris-0.3/src/app_configmgr.hh:53:23: note: Function in derived class morris-0.3/src/appgtk_configmgr.hh:28:16: style: The function 'store' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/configmgr.hh:54:16: note: Virtual function in base class morris-0.3/src/appgtk_configmgr.hh:28:16: note: Function in derived class morris-0.3/src/appgtk_configmgr.hh:29:16: style: The function 'store' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/configmgr.hh:55:16: note: Virtual function in base class morris-0.3/src/appgtk_configmgr.hh:29:16: note: Function in derived class morris-0.3/src/appgtk_configmgr.hh:30:16: style: The function 'store' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/configmgr.hh:56:16: note: Virtual function in base class morris-0.3/src/appgtk_configmgr.hh:30:16: note: Function in derived class morris-0.3/src/appgtk_configmgr.hh:31:16: style: The function 'store' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/configmgr.hh:57:16: note: Virtual function in base class morris-0.3/src/appgtk_configmgr.hh:31:16: note: Function in derived class morris-0.3/src/appgtk_configmgr.hh:33:17: style: The function 'read_int' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/configmgr.hh:59:17: note: Virtual function in base class morris-0.3/src/appgtk_configmgr.hh:33:17: note: Function in derived class morris-0.3/src/appgtk_configmgr.hh:34:17: style: The function 'read_bool' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/configmgr.hh:60:17: note: Virtual function in base class morris-0.3/src/appgtk_configmgr.hh:34:17: note: Function in derived class morris-0.3/src/appgtk_configmgr.hh:35:17: style: The function 'read_float' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/configmgr.hh:61:17: note: Virtual function in base class morris-0.3/src/appgtk_configmgr.hh:35:17: note: Function in derived class morris-0.3/src/appgtk_configmgr.hh:36:23: style: The function 'read_string' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/configmgr.hh:62:23: note: Virtual function in base class morris-0.3/src/appgtk_configmgr.hh:36:23: note: Function in derived class morris-0.3/src/gtk_movelog.hh:30:4: style: The destructor '~MoveLog_Gtk' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/movelog.hh:30:12: note: Virtual destructor in base class morris-0.3/src/gtk_movelog.hh:30:4: note: Destructor in derived class morris-0.3/src/gtk_movelog.hh:32:8: style: The function 'refresh' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/movelog.hh:32:16: note: Virtual function in base class morris-0.3/src/gtk_movelog.hh:32:8: note: Function in derived class morris-0.3/src/gtk_appgui.hh:32:4: style: The destructor '~ApplicationGUI_Gtk' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/appgui.hh:30:12: note: Virtual destructor in base class morris-0.3/src/gtk_appgui.hh:32:4: note: Destructor in derived class morris-0.3/src/gtk_appgui.hh:36:16: style: The function 'startApplication' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/appgui.hh:44:16: note: Virtual function in base class morris-0.3/src/gtk_appgui.hh:36:16: note: Function in derived class morris-0.3/src/gtk_appgui.hh:37:16: style: The function 'quitApplication' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/appgui.hh:45:16: note: Virtual function in base class morris-0.3/src/gtk_appgui.hh:37:16: note: Function in derived class morris-0.3/src/gtk_appgui.hh:39:16: style: The function 'setProgress' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/appgui.hh:32:16: note: Virtual function in base class morris-0.3/src/gtk_appgui.hh:39:16: note: Function in derived class morris-0.3/src/gtk_appgui.hh:44:16: style: The function 'setStatusbar' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/appgui.hh:33:16: note: Virtual function in base class morris-0.3/src/gtk_appgui.hh:44:16: note: Function in derived class morris-0.3/src/gtk_appgui.hh:50:8: style: The function 'showGameOverDialog' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/appgui.hh:35:16: note: Virtual function in base class morris-0.3/src/gtk_appgui.hh:50:8: note: Function in derived class morris-0.3/src/gtk_appgui.hh:54:8: style: The function 'preferencesDialog_Display' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/appgui.hh:36:16: note: Virtual function in base class morris-0.3/src/gtk_appgui.hh:54:8: note: Function in derived class morris-0.3/src/gtk_appgui.hh:56:8: style: The function 'isMoveLogShown' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/appgui.hh:39:16: note: Virtual function in base class morris-0.3/src/gtk_appgui.hh:56:8: note: Function in derived class morris-0.3/src/gtk_appgui.hh:58:14: style: The function 'getMainWindow' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/gtk_appgui_interface.hh:30:22: note: Virtual function in base class morris-0.3/src/gtk_appgui.hh:58:14: note: Function in derived class morris-0.3/src/gtk_appgui.hh:63:16: style: The function 'getBoardGUI' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/appgui.hh:41:24: note: Virtual function in base class morris-0.3/src/gtk_appgui.hh:63:16: note: Function in derived class morris-0.3/src/gtk_appgui.hh:64:8: style: The function 'showAboutDialog' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/appgui.hh:37:16: note: Virtual function in base class morris-0.3/src/gtk_appgui.hh:64:8: note: Function in derived class morris-0.3/src/gtkcairo_boardgui.hh:41:16: style: The function 'action' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/gtkcairo_boardgui.hh:31:16: note: Virtual function in base class morris-0.3/src/gtkcairo_boardgui.hh:41:16: note: Function in derived class morris-0.3/src/gtkcairo_boardgui.hh:48:16: style: The function 'action' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/gtkcairo_boardgui.hh:31:16: note: Virtual function in base class morris-0.3/src/gtkcairo_boardgui.hh:48:16: note: Function in derived class morris-0.3/src/gtkcairo_boardgui.hh:57:16: style: The function 'action' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/gtkcairo_boardgui.hh:31:16: note: Virtual function in base class morris-0.3/src/gtkcairo_boardgui.hh:57:16: note: Function in derived class morris-0.3/src/gtkcairo_boardgui.hh:70:16: style: The function 'action' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/gtkcairo_boardgui.hh:31:16: note: Virtual function in base class morris-0.3/src/gtkcairo_boardgui.hh:70:16: note: Function in derived class morris-0.3/src/gtkcairo_boardgui.hh:83:4: style: The destructor '~BoardGUI_GtkCairo' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardgui.hh:73:12: note: Virtual destructor in base class morris-0.3/src/gtkcairo_boardgui.hh:83:4: note: Destructor in derived class morris-0.3/src/gtkcairo_boardgui.hh:85:8: style: The function 'resetDisplay' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardgui.hh:76:16: note: Virtual function in base class morris-0.3/src/gtkcairo_boardgui.hh:85:8: note: Function in derived class morris-0.3/src/gtkcairo_boardgui.hh:87:8: style: The function 'redrawBoard' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardgui.hh:79:16: note: Virtual function in base class morris-0.3/src/gtkcairo_boardgui.hh:87:8: note: Function in derived class morris-0.3/src/gtkcairo_boardgui.hh:88:8: style: The function 'visualizeMove' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardgui.hh:87:16: note: Virtual function in base class morris-0.3/src/gtkcairo_boardgui.hh:88:8: note: Function in derived class morris-0.3/src/gtkcairo_boardgui.hh:89:8: style: The function 'checkHover' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardgui.hh:88:16: note: Virtual function in base class morris-0.3/src/gtkcairo_boardgui.hh:89:8: note: Function in derived class morris-0.3/src/gtkcairo_boardgui.hh:91:8: style: The function 'showHint' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardgui.hh:92:16: note: Virtual function in base class morris-0.3/src/gtkcairo_boardgui.hh:91:8: note: Function in derived class morris-0.3/src/gtkcairo_boardgui.hh:92:8: style: The function 'removeHint' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardgui.hh:93:16: note: Virtual function in base class morris-0.3/src/gtkcairo_boardgui.hh:92:8: note: Function in derived class morris-0.3/src/gtkcairo_boardgui.hh:133:16: style: The function 'invalidateHoverAtPos' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardgui.hh:107:16: note: Virtual function in base class morris-0.3/src/gtkcairo_boardgui.hh:133:16: note: Function in derived class morris-0.3/src/gtkcairo_boardgui.hh:134:16: style: The function 'changeGfxState' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardgui.hh:108:16: note: Virtual function in base class morris-0.3/src/gtkcairo_boardgui.hh:134:16: note: Function in derived class morris-0.3/src/gtkcairo_boardgui.hh:181:16: style: The function 'startPieceDrag' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardgui.hh:103:16: note: Virtual function in base class morris-0.3/src/gtkcairo_boardgui.hh:181:16: note: Function in derived class morris-0.3/src/gtkcairo_boardgui.hh:182:16: style: The function 'stopPieceDrag' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardgui.hh:104:16: note: Virtual function in base class morris-0.3/src/gtkcairo_boardgui.hh:182:16: note: Function in derived class morris-0.3/src/gtkcairo_boardgui.hh:183:16: style: The function 'doPieceDrag' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/boardgui.hh:105:16: note: Virtual function in base class morris-0.3/src/gtkcairo_boardgui.hh:183:16: note: Function in derived class morris-0.3/src/appgtk_configmgr.cc:132:27: style: Variable 'gui' can be declared as pointer to const [constVariablePointer] morris-0.3/src/board.cc:252:8: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable cout [valueFlowBailoutIncompleteVar] morris-0.3/src/util.hh:36:3: warning: Member variable 'SmallVec < Move , MAXSEARCHDEPTH >::elem' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/algo_alphabeta.hh:50:8: style: The function 'registerThreadTunnel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/player.hh:53:16: note: Virtual function in base class morris-0.3/src/algo_alphabeta.hh:50:8: note: Function in derived class morris-0.3/src/algo_alphabeta.hh:74:8: style: The function 'isInteractivePlayer' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/player.hh:54:16: note: Virtual function in base class morris-0.3/src/algo_alphabeta.hh:74:8: note: Function in derived class morris-0.3/src/algo_alphabeta.hh:77:8: style: The function 'resetGame' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/player.hh:56:16: note: Virtual function in base class morris-0.3/src/algo_alphabeta.hh:77:8: note: Function in derived class morris-0.3/src/algo_alphabeta.hh:79:8: style: The function 'startMove' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/player.hh:57:16: note: Virtual function in base class morris-0.3/src/algo_alphabeta.hh:79:8: note: Function in derived class morris-0.3/src/algo_alphabeta.hh:82:8: style: The function 'forceMove' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/player.hh:58:16: note: Virtual function in base class morris-0.3/src/algo_alphabeta.hh:82:8: note: Function in derived class morris-0.3/src/algo_alphabeta.hh:85:8: style: The function 'cancelMove' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/player.hh:59:16: note: Virtual function in base class morris-0.3/src/algo_alphabeta.hh:85:8: note: Function in derived class morris-0.3/src/algo_alphabeta.hh:87:8: style: The function 'notifyWinner' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/player.hh:61:16: note: Virtual function in base class morris-0.3/src/algo_alphabeta.hh:87:8: note: Function in derived class morris-0.3/src/algo_alphabeta.hh:74:8: style: The function 'isInteractivePlayer' overrides a function in a base class but is identical to the overridden function [uselessOverride] morris-0.3/src/player.hh:54:16: note: Virtual function in base class morris-0.3/src/algo_alphabeta.hh:74:8: note: Function in derived class morris-0.3/src/app_configmgr.cc:106:22: style: The scope of the variable 'p' can be reduced. [variableScope] morris-0.3/src/board.cc:204:18: style: Unused private function: 'Board::hashFromScratch' [unusedPrivateFunction] morris-0.3/src/board.hh:161:13: note: Unused private function: 'Board::hashFromScratch' morris-0.3/src/board.cc:204:18: note: Unused private function: 'Board::hashFromScratch' morris-0.3/src/board.cc:93:23: style:inconclusive: Function 'reset' argument 1 names different: declaration 'nPiecesToSet' definition 'p_nPiecesToSet'. [funcArgNamesDifferent] morris-0.3/src/board.hh:78:18: note: Function 'reset' argument 1 names different: declaration 'nPiecesToSet' definition 'p_nPiecesToSet'. morris-0.3/src/board.cc:93:23: note: Function 'reset' argument 1 names different: declaration 'nPiecesToSet' definition 'p_nPiecesToSet'. morris-0.3/src/algo_alphabeta.cc:70:18: warning: Member variable 'PlayerIF_AlgoAB::m_startBoard' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/algo_alphabeta.cc:70:18: warning: Member variable 'PlayerIF_AlgoAB::m_move' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/algo_alphabeta.cc:70:18: warning: Member variable 'PlayerIF_AlgoAB::m_moveID' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/algo_alphabeta.cc:70:18: warning: Member variable 'PlayerIF_AlgoAB::m_stopThread' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/algo_alphabeta.cc:70:18: warning: Member variable 'PlayerIF_AlgoAB::m_ignoreMove' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/algo_alphabeta.cc:70:18: warning: Member variable 'PlayerIF_AlgoAB::m_computedSomeMove' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/algo_alphabeta.cc:70:18: warning: Member variable 'PlayerIF_AlgoAB::m_nodesEvaluated' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/algo_alphabeta.cc:126:23: style: Unused private function: 'PlayerIF_AlgoAB::doSearch' [unusedPrivateFunction] morris-0.3/src/algo_alphabeta.hh:90:8: note: Unused private function: 'PlayerIF_AlgoAB::doSearch' morris-0.3/src/algo_alphabeta.cc:126:23: note: Unused private function: 'PlayerIF_AlgoAB::doSearch' morris-0.3/src/algo_alphabeta.cc:172:5: style: Class 'IdleFunc_JoinAlgoThread' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] morris-0.3/src/configmgr.cc:48:3: warning: Class 'ConfigManager' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] morris-0.3/src/configmgr.cc:48:3: warning: Class 'ConfigManager' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] morris-0.3/src/algo_alphabeta.cc:590:36: style: C-style pointer casting [cstyleCast] morris-0.3/src/algo_alphabeta.cc:591:36: style: C-style pointer casting [cstyleCast] morris-0.3/src/algo_alphabeta.cc:600:38: style: C-style pointer casting [cstyleCast] morris-0.3/src/algo_alphabeta.cc:601:38: style: C-style pointer casting [cstyleCast] morris-0.3/src/algo_alphabeta.cc:133:9: style: The scope of the variable 'e' can be reduced. [variableScope] morris-0.3/src/algo_alphabeta.cc:589:13: style: Variable 'player' can be declared as pointer to const [constVariablePointer] morris-0.3/src/algo_alphabeta.cc:352:4: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] morris-0.3/src/boardgui.cc:62:16: warning: Member variable 'BoardGUI_Base::m_playermove' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/boardgui.hh:58:13: style:inconclusive: Member variable 'HoverState::hoverMode' is in the wrong place in the initializer list. [initializerList] morris-0.3/src/boardgui.cc:56:5: note: Member variable 'HoverState::hoverMode' is in the wrong place in the initializer list. morris-0.3/src/boardgui.hh:58:13: note: Member variable 'HoverState::hoverMode' is in the wrong place in the initializer list. morris-0.3/src/boardgui.cc:200:27: style: Condition 'rules.isValidMove(board,m_playermove)' is always true [knownConditionTrueFalse] morris-0.3/src/boardgui.cc:188:55: note: Assuming that condition 'rules.isValidMove(board,m_playermove)==false' is not redundant morris-0.3/src/boardgui.cc:200:27: note: Condition 'rules.isValidMove(board,m_playermove)' is always true morris-0.3/src/boardgui.cc:104:19: style: C-style pointer casting [cstyleCast] morris-0.3/src/boardspec.cc:218:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Board_Polygon3 [valueFlowBailoutIncompleteVar] morris-0.3/src/boardgui.cc:120:78: style:inconclusive: Function 'cb_buttonPress' argument 3 names different: declaration 'b' definition 'button'. [funcArgNamesDifferent] morris-0.3/src/boardgui.hh:112:67: note: Function 'cb_buttonPress' argument 3 names different: declaration 'b' definition 'button'. morris-0.3/src/boardgui.cc:120:78: note: Function 'cb_buttonPress' argument 3 names different: declaration 'b' definition 'button'. morris-0.3/src/boardgui.cc:173:62: style:inconclusive: Function 'cb_buttonRelease' argument 2 names different: declaration 'b' definition 'button'. [funcArgNamesDifferent] morris-0.3/src/boardgui.hh:113:49: note: Function 'cb_buttonRelease' argument 2 names different: declaration 'b' definition 'button'. morris-0.3/src/boardgui.cc:173:62: note: Function 'cb_buttonRelease' argument 2 names different: declaration 'b' definition 'button'. morris-0.3/src/boardgui.cc:212:45: style:inconclusive: Function 'cb_mouseMotion' argument 1 names different: declaration 'p' definition 'pos'. [funcArgNamesDifferent] morris-0.3/src/boardgui.hh:114:34: note: Function 'cb_mouseMotion' argument 1 names different: declaration 'p' definition 'pos'. morris-0.3/src/boardgui.cc:212:45: note: Function 'cb_mouseMotion' argument 1 names different: declaration 'p' definition 'pos'. morris-0.3/src/boardgui.cc:28:16: style: Variable 'control' can be declared as reference to const [constVariableReference] morris-0.3/src/boardgui.cc:122:16: style: Variable 'control' can be declared as reference to const [constVariableReference] morris-0.3/src/control.cc:25:14: warning: Member variable 'GameControl::m_partialMoveBoard' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/control.cc:25:14: warning: Member variable 'GameControl::m_winner' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/gconf_configmgr.cc:160:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GCONF_VALUE_INT [valueFlowBailoutIncompleteVar] morris-0.3/src/gconf_configmgr.cc:174:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GCONF_VALUE_BOOL [valueFlowBailoutIncompleteVar] morris-0.3/src/gconf_configmgr.cc:188:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GCONF_VALUE_FLOAT [valueFlowBailoutIncompleteVar] morris-0.3/src/gconf_configmgr.cc:90:18: warning: Class 'ConfigManager_GConf' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] morris-0.3/src/gconf_configmgr.cc:90:18: warning: Class 'ConfigManager_GConf' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] morris-0.3/src/gconf_configmgr.hh:32:4: style: The destructor '~ConfigManager_GConf' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/configmgr.hh:50:12: note: Virtual destructor in base class morris-0.3/src/gconf_configmgr.hh:32:4: note: Destructor in derived class morris-0.3/src/gconf_configmgr.hh:34:16: style: The function 'readInitialValues' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/configmgr.hh:52:16: note: Virtual function in base class morris-0.3/src/gconf_configmgr.hh:34:16: note: Function in derived class morris-0.3/src/gtk_appgui.cc:50:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_WINDOW_TOPLEVEL [valueFlowBailoutIncompleteVar] morris-0.3/src/gtk_appgui.cc:194:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_DIALOG_DESTROY_WITH_PARENT [valueFlowBailoutIncompleteVar] morris-0.3/src/gtk_appgui.cc:214:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PACKAGE_NAME [valueFlowBailoutIncompleteVar] morris-0.3/src/gconf_configmgr.cc:51:30: style: C-style pointer casting [cstyleCast] morris-0.3/src/gconf_configmgr.cc:58:48: style: C-style pointer casting [cstyleCast] morris-0.3/src/boardspec.hh:136:33: style: Virtual function 'getPieceRadius' is called from constructor 'BoardSpec_Polygon(int nCorners)' at line 62. Dynamic binding is not used. [virtualCallInConstructor] morris-0.3/src/boardspec.cc:62:23: note: Calling getPieceRadius morris-0.3/src/boardspec.hh:136:33: note: getPieceRadius is a virtual function morris-0.3/src/boardspec.hh:136:33: style: Virtual function 'getPieceRadius' is called from constructor 'BoardSpec_Polygon(int nCorners)' at line 71. Dynamic binding is not used. [virtualCallInConstructor] morris-0.3/src/boardspec.cc:71:30: note: Calling getPieceRadius morris-0.3/src/boardspec.hh:136:33: note: getPieceRadius is a virtual function morris-0.3/src/boardspec.hh:132:33: style: Virtual function 'nPositions' is called from constructor 'BoardSpec_Polygon(int nCorners)' at line 150. Dynamic binding is not used. [virtualCallInConstructor] morris-0.3/src/boardspec.cc:150:21: note: Calling nPositions morris-0.3/src/boardspec.hh:132:33: note: nPositions is a virtual function morris-0.3/src/boardspec.hh:171:33: style: Virtual function 'nPositions' is called from constructor 'BoardSpec_Grid(BoardPreset)' at line 711. Dynamic binding is not used. [virtualCallInConstructor] morris-0.3/src/boardspec.cc:711:20: note: Calling nPositions morris-0.3/src/boardspec.hh:171:33: note: nPositions is a virtual function morris-0.3/src/boardspec.hh:171:33: style: Virtual function 'nPositions' is called from constructor 'BoardSpec_Grid(BoardPreset)' at line 712. Dynamic binding is not used. [virtualCallInConstructor] morris-0.3/src/boardspec.cc:712:18: note: Calling nPositions morris-0.3/src/boardspec.hh:171:33: note: nPositions is a virtual function morris-0.3/src/boardspec.hh:171:33: style: Virtual function 'nPositions' is called from constructor 'BoardSpec_Grid(BoardPreset)' at line 734. Dynamic binding is not used. [virtualCallInConstructor] morris-0.3/src/boardspec.cc:734:21: note: Calling nPositions morris-0.3/src/boardspec.hh:171:33: note: nPositions is a virtual function morris-0.3/src/boardspec.cc:730:7: style: Local variable 'nMills' shadows outer function [shadowFunction] morris-0.3/src/boardspec.hh:177:33: note: Shadowed declaration morris-0.3/src/boardspec.cc:730:7: note: Shadow variable morris-0.3/src/gtk_menutoolbar.cc:248:56: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PACKAGE [valueFlowBailoutIncompleteVar] morris-0.3/src/gtk_appgui.cc:51:15: style: gtk_vbox_new has been deprecated since version 3.2 and should not be used in newly-written code. You can use gtk_box_new() with GTK_ORIENTATION_VERTICAL instead, which is a quick and easy change. But the recommendation is to switch to GtkGrid, since GtkBox is going to go away eventually. See Migrating from other containers to GtkGrid. [prohibitedgtk_vbox_newCalled] morris-0.3/src/gtk_appgui.cc:69:3: style: Obsolete function 'gtk_signal_connect' called. It is recommended to use 'g_signal_connect' instead. [prohibitedgtk_signal_connectCalled] morris-0.3/src/gtk_appgui.cc:70:3: style: Obsolete function 'gtk_signal_connect' called. It is recommended to use 'g_signal_connect' instead. [prohibitedgtk_signal_connectCalled] morris-0.3/src/gtk_appgui.cc:42:4: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_appgui.cc:188:25: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_appgui.cc:189:25: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_appgui.cc:190:25: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_appgui.cc:197:11: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_appgui.cc:219:17: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_appgui.cc:52:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_appgui.cc:54:25: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_appgui.cc:61:20: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_appgui.cc:64:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_appgui.cc:65:25: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_appgui.cc:69:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_appgui.cc:70:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_appgui.cc:94:20: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_appgui.cc:193:46: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_appgui.cc:200:18: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_appgui.cc:213:26: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_appgui.cc:34:44: style: Parameter 'widget' can be declared as pointer to const. However it seems that 'delete_callback' is a callback function, if 'widget' is declared with const you might also need to cast function pointer(s). [constParameterCallback] morris-0.3/src/gtk_appgui.cc:70:58: note: You might need to cast the function pointer here morris-0.3/src/gtk_appgui.cc:34:44: note: Parameter 'widget' can be declared as pointer to const morris-0.3/src/gtk_appgui.cc:34:62: style: Parameter 'event' can be declared as pointer to const. However it seems that 'delete_callback' is a callback function, if 'event' is declared with const you might also need to cast function pointer(s). [constParameterCallback] morris-0.3/src/gtk_appgui.cc:70:58: note: You might need to cast the function pointer here morris-0.3/src/gtk_appgui.cc:34:62: note: Parameter 'event' can be declared as pointer to const morris-0.3/src/gtk_appgui.cc:34:78: style: Parameter 'data' can be declared as pointer to const. However it seems that 'delete_callback' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] morris-0.3/src/gtk_appgui.cc:70:58: note: You might need to cast the function pointer here morris-0.3/src/gtk_appgui.cc:34:78: note: Parameter 'data' can be declared as pointer to const morris-0.3/src/gtk_movelog.cc:46:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_WINDOW_TOPLEVEL [valueFlowBailoutIncompleteVar] morris-0.3/src/gtk_menutoolbar.cc:269:31: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_menutoolbar.cc:274:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_menutoolbar.cc:280:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_menutoolbar.cc:245:34: style:inconclusive: Function 'gtk_initMainMenu' argument 1 names different: declaration 'appWindow' definition 'vbox'. [funcArgNamesDifferent] morris-0.3/src/gtk_menutoolbar.hh:24:34: note: Function 'gtk_initMainMenu' argument 1 names different: declaration 'appWindow' definition 'vbox'. morris-0.3/src/gtk_menutoolbar.cc:245:34: note: Function 'gtk_initMainMenu' argument 1 names different: declaration 'appWindow' definition 'vbox'. morris-0.3/src/gtk_menutoolbar.cc:96:42: style: Parameter 'w' can be declared as pointer to const [constParameterPointer] morris-0.3/src/gtk_menutoolbar.cc:96:54: style: Parameter 'spec' can be declared as pointer to const [constParameterPointer] morris-0.3/src/gtk_prefAI.cc:79:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_DIALOG_MODAL [valueFlowBailoutIncompleteVar] morris-0.3/src/gtk_movelog.cc:126:19: style: Unused private function: 'MoveLog_Gtk::cbDestroy' [unusedPrivateFunction] morris-0.3/src/gtk_movelog.hh:44:10: note: Unused private function: 'MoveLog_Gtk::cbDestroy' morris-0.3/src/gtk_movelog.cc:126:19: note: Unused private function: 'MoveLog_Gtk::cbDestroy' morris-0.3/src/gtk_movelog.cc:122:18: warning: Class 'MoveLog_Gtk' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] morris-0.3/src/gtk_movelog.cc:122:18: warning: Class 'MoveLog_Gtk' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] morris-0.3/src/gtk_movelog.cc:38:4: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_movelog.cc:47:44: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_movelog.cc:63:56: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_movelog.cc:71:56: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_movelog.cc:79:56: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_movelog.cc:154:9: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_movelog.cc:47:24: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_movelog.cc:48:34: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_movelog.cc:49:31: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_movelog.cc:52:34: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_movelog.cc:56:59: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_movelog.cc:68:33: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_movelog.cc:76:33: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_movelog.cc:84:33: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_movelog.cc:98:27: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_movelog.cc:98:52: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_movelog.cc:103:21: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_movelog.cc:104:21: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_movelog.cc:30:42: style: Parameter 'widget' can be declared as pointer to const. However it seems that 'quit_callback' is a callback function, if 'widget' is declared with const you might also need to cast function pointer(s). [constParameterCallback] morris-0.3/src/gtk_movelog.cc:107:3: note: You might need to cast the function pointer here morris-0.3/src/gtk_movelog.cc:30:42: note: Parameter 'widget' can be declared as pointer to const morris-0.3/src/gtk_movelog.cc:30:59: style: Parameter 'data' can be declared as pointer to const. However it seems that 'quit_callback' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] morris-0.3/src/gtk_movelog.cc:107:3: note: You might need to cast the function pointer here morris-0.3/src/gtk_movelog.cc:30:59: note: Parameter 'data' can be declared as pointer to const morris-0.3/src/gtk_prefDisplay.cc:38:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_DIALOG_MODAL [valueFlowBailoutIncompleteVar] morris-0.3/src/gtk_prefRules.cc:30:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_DIALOG_DESTROY_WITH_PARENT [valueFlowBailoutIncompleteVar] morris-0.3/src/gtk_prefRules.cc:82:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_DIALOG_MODAL [valueFlowBailoutIncompleteVar] morris-0.3/src/gtk_prefDisplay.cc:46:10: style: gtk_vbox_new has been deprecated since version 3.2 and should not be used in newly-written code. You can use gtk_box_new() with GTK_ORIENTATION_VERTICAL instead, which is a quick and easy change. But the recommendation is to switch to GtkGrid, since GtkBox is going to go away eventually. See Migrating from other containers to GtkGrid. [prohibitedgtk_vbox_newCalled] morris-0.3/src/gtk_prefDisplay.cc:75:22: style: gtk_hbox_new has been deprecated since version 3.2 and should not be used in newly-written code. You can use gtk_box_new() with GTK_ORIENTATION_HORIZONTAL instead, which is a quick and easy change. But the recommendation is to switch to GtkGrid, since GtkBox is going to go away eventually. See Migrating from other containers to GtkGrid. [prohibitedgtk_hbox_newCalled] morris-0.3/src/gtk_prefDisplay.cc:95:11: style: gtk_hbox_new has been deprecated since version 3.2 and should not be used in newly-written code. You can use gtk_box_new() with GTK_ORIENTATION_HORIZONTAL instead, which is a quick and easy change. But the recommendation is to switch to GtkGrid, since GtkBox is going to go away eventually. See Migrating from other containers to GtkGrid. [prohibitedgtk_hbox_newCalled] morris-0.3/src/gtk_prefDisplay.cc:36:45: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefDisplay.cc:48:63: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefDisplay.cc:49:63: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefDisplay.cc:50:63: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefDisplay.cc:51:63: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefDisplay.cc:52:66: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefDisplay.cc:53:66: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefDisplay.cc:76:36: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefDisplay.cc:96:25: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefDisplay.cc:37:10: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:42:28: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:55:32: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:57:32: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:59:32: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:61:32: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:63:32: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:65:32: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:68:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:69:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:70:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:71:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:72:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:73:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:88:48: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:90:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:91:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:92:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:107:47: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:109:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:110:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:111:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:113:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:121:32: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:129:43: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:132:43: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:135:43: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:138:43: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:141:43: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefDisplay.cc:144:43: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:92:21: style: gtk_vbox_new has been deprecated since version 3.2 and should not be used in newly-written code. You can use gtk_box_new() with GTK_ORIENTATION_VERTICAL instead, which is a quick and easy change. But the recommendation is to switch to GtkGrid, since GtkBox is going to go away eventually. See Migrating from other containers to GtkGrid. [prohibitedgtk_vbox_newCalled] morris-0.3/src/gtk_prefAI.cc:188:25: style: gtk_hbox_new has been deprecated since version 3.2 and should not be used in newly-written code. You can use gtk_box_new() with GTK_ORIENTATION_HORIZONTAL instead, which is a quick and easy change. But the recommendation is to switch to GtkGrid, since GtkBox is going to go away eventually. See Migrating from other containers to GtkGrid. [prohibitedgtk_hbox_newCalled] morris-0.3/src/gtk_prefAI.cc:201:3: style: Obsolete function 'gtk_signal_connect' called. It is recommended to use 'g_signal_connect' instead. [prohibitedgtk_signal_connectCalled] morris-0.3/src/gtk_prefAI.cc:57:29: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefAI.cc:77:45: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefAI.cc:91:36: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefAI.cc:120:46: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefAI.cc:123:57: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefAI.cc:124:57: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefAI.cc:136:46: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefAI.cc:142:57: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefAI.cc:143:57: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefAI.cc:144:57: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefAI.cc:145:57: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefAI.cc:195:61: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefAI.cc:32:25: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:33:26: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:48:28: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:49:28: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:50:28: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:51:28: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:78:10: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:83:28: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:96:34: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:117:33: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:120:28: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:121:26: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:123:24: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:124:24: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:126:33: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:127:33: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:129:34: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:131:26: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:136:28: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:137:26: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:142:24: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:143:24: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:144:24: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:145:24: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:147:33: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:148:33: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:149:33: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:150:33: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:152:34: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:154:26: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:158:25: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:159:38: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:168:33: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:170:33: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:190:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:191:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:192:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:199:32: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:200:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:201:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:207:32: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:212:40: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:226:37: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefAI.cc:228:36: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_threadtunnel.cc:73:8: performance:inconclusive: Technically the member function 'ThreadTunnel_Gtk::setStatusbar' can be static (but you may consider moving to unnamed namespace). [functionStatic] morris-0.3/src/gtk_threadtunnel.cc:100:7: style: Class 'IdleFunc_showThinking' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] morris-0.3/src/gtk_threadtunnel.cc:78:8: style: The function 'setProgress' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/threadtunnel.hh:40:16: note: Virtual function in base class morris-0.3/src/gtk_threadtunnel.cc:78:8: note: Function in derived class morris-0.3/src/gtk_threadtunnel.cc:86:8: style: The function 'doMove' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/threadtunnel.hh:46:16: note: Virtual function in base class morris-0.3/src/gtk_threadtunnel.cc:86:8: note: Function in derived class morris-0.3/src/gtk_threadtunnel.cc:95:8: style: The function 'showThinkingInfo' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] morris-0.3/src/threadtunnel.hh:43:16: note: Virtual function in base class morris-0.3/src/gtk_threadtunnel.cc:95:8: note: Function in derived class morris-0.3/src/gtk_threadtunnel.cc:84:3: error: Memory leak: p [memleak] morris-0.3/src/gtk_threadtunnel.cc:75:34: error: Allocation with new, g_idle_add doesn't release it. [leakNoVarFunctionCall] morris-0.3/src/gtk_threadtunnel.cc:30:21: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_threadtunnel.cc:40:22: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_threadtunnel.cc:56:17: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_threadtunnel.cc:125:20: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_threadtunnel.cc:133:34: style: Parameter 'func' can be declared as pointer to const [constParameterPointer] morris-0.3/src/gtk_prefAI.cc:111:18: style: Unused variable: hbox [unusedVariable] morris-0.3/src/gtk_prefRules.cc:91:14: style: gtk_vbox_new has been deprecated since version 3.2 and should not be used in newly-written code. You can use gtk_box_new() with GTK_ORIENTATION_VERTICAL instead, which is a quick and easy change. But the recommendation is to switch to GtkGrid, since GtkBox is going to go away eventually. See Migrating from other containers to GtkGrid. [prohibitedgtk_vbox_newCalled] morris-0.3/src/gtk_prefRules.cc:111:20: style: gtk_vbox_new has been deprecated since version 3.2 and should not be used in newly-written code. You can use gtk_box_new() with GTK_ORIENTATION_VERTICAL instead, which is a quick and easy change. But the recommendation is to switch to GtkGrid, since GtkBox is going to go away eventually. See Migrating from other containers to GtkGrid. [prohibitedgtk_vbox_newCalled] morris-0.3/src/gtk_prefRules.cc:124:28: style: gtk_hbox_new has been deprecated since version 3.2 and should not be used in newly-written code. You can use gtk_box_new() with GTK_ORIENTATION_HORIZONTAL instead, which is a quick and easy change. But the recommendation is to switch to GtkGrid, since GtkBox is going to go away eventually. See Migrating from other containers to GtkGrid. [prohibitedgtk_hbox_newCalled] morris-0.3/src/gtk_prefRules.cc:144:25: style: gtk_hbox_new has been deprecated since version 3.2 and should not be used in newly-written code. You can use gtk_box_new() with GTK_ORIENTATION_HORIZONTAL instead, which is a quick and easy change. But the recommendation is to switch to GtkGrid, since GtkBox is going to go away eventually. See Migrating from other containers to GtkGrid. [prohibitedgtk_hbox_newCalled] morris-0.3/src/gtk_prefRules.cc:172:21: style: gtk_hbox_new has been deprecated since version 3.2 and should not be used in newly-written code. You can use gtk_box_new() with GTK_ORIENTATION_HORIZONTAL instead, which is a quick and easy change. But the recommendation is to switch to GtkGrid, since GtkBox is going to go away eventually. See Migrating from other containers to GtkGrid. [prohibitedgtk_hbox_newCalled] morris-0.3/src/gtk_prefRules.cc:80:45: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefRules.cc:90:28: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefRules.cc:97:9: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefRules.cc:110:34: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefRules.cc:113:63: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefRules.cc:114:63: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefRules.cc:115:63: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefRules.cc:116:63: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefRules.cc:125:43: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefRules.cc:145:40: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefRules.cc:221:11: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefRules.cc:222:11: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtk_prefRules.cc:29:46: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:35:32: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:81:10: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:86:28: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:98:26: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:101:33: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:118:32: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:119:32: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:120:32: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:121:32: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:134:48: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:136:32: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:137:37: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:139:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:140:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:154:45: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:156:32: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:157:37: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:159:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:160:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:162:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:163:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:164:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:165:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:166:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:167:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:169:21: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:170:21: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:173:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:174:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:176:34: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:177:34: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:179:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:189:36: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:197:66: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:198:66: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:199:66: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:200:73: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:201:71: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:202:71: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:208:36: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:220:32: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtk_prefRules.cc:206:14: style: Local variable 'button' shadows outer variable [shadowVariable] morris-0.3/src/gtk_prefRules.cc:189:12: note: Shadowed declaration morris-0.3/src/gtk_prefRules.cc:206:14: note: Shadow variable morris-0.3/src/morris.cc:34:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LC_ALL [valueFlowBailoutIncompleteVar] morris-0.3/src/mainapp.cc:107:107: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable _1 [valueFlowBailoutIncompleteVar] morris-0.3/src/morris.cc:35:3: style: C-style pointer casting [cstyleCast] morris-0.3/src/morris.cc:36:3: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtkcairo_boardgui.cc:199:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable coordinate [valueFlowBailoutIncompleteVar] morris-0.3/src/gtkcairo_boardgui.cc:767:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable coordinate [valueFlowBailoutIncompleteVar] morris-0.3/src/gtkcairo_boardgui.cc:1158:4: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_EXPOSURE_MASK [valueFlowBailoutIncompleteVar] morris-0.3/src/gtkcairo_boardgui.cc:1191:57: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDK_WATCH [valueFlowBailoutIncompleteVar] morris-0.3/src/mainapp.cc:58:10: warning: Member variable 'MainApp::hint_gameID' is not initialized in the constructor. [uninitMemberVarPrivate] morris-0.3/src/mainapp.hh:153:14: style:inconclusive: Member variable 'MainApp::hintID' is in the wrong place in the initializer list. [initializerList] morris-0.3/src/mainapp.cc:60:5: note: Member variable 'MainApp::hintID' is in the wrong place in the initializer list. morris-0.3/src/mainapp.hh:153:14: note: Member variable 'MainApp::hintID' is in the wrong place in the initializer list. morris-0.3/src/mainapp.cc:62:3: performance: Variable 'experience' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] morris-0.3/src/mainapp.cc:204:15: style:inconclusive: Technically the member function 'MainApp::visualizeMove' can be const. [functionConst] morris-0.3/src/mainapp.hh:80:8: note: Technically the member function 'MainApp::visualizeMove' can be const. morris-0.3/src/mainapp.cc:204:15: note: Technically the member function 'MainApp::visualizeMove' can be const. morris-0.3/src/mainapp.cc:324:34: style: C-style pointer casting [cstyleCast] morris-0.3/src/mainapp.cc:328:34: style: C-style pointer casting [cstyleCast] morris-0.3/src/mainapp.cc:332:34: style: C-style pointer casting [cstyleCast] morris-0.3/src/mainapp.cc:338:37: style: C-style pointer casting [cstyleCast] morris-0.3/src/mainapp.cc:348:14: style: C-style pointer casting [cstyleCast] morris-0.3/src/mainapp.cc:350:14: style: C-style pointer casting [cstyleCast] morris-0.3/src/mainapp.cc:356:34: style: C-style pointer casting [cstyleCast] morris-0.3/src/mainapp.cc:357:34: style: C-style pointer casting [cstyleCast] morris-0.3/src/mainapp.cc:358:34: style: C-style pointer casting [cstyleCast] morris-0.3/src/mainapp.cc:362:15: style: C-style pointer casting [cstyleCast] morris-0.3/src/mainapp.cc:204:41: style:inconclusive: Function 'visualizeMove' argument 1 names different: declaration 'm' definition 'move'. [funcArgNamesDifferent] morris-0.3/src/mainapp.hh:80:34: note: Function 'visualizeMove' argument 1 names different: declaration 'm' definition 'move'. morris-0.3/src/mainapp.cc:204:41: note: Function 'visualizeMove' argument 1 names different: declaration 'm' definition 'move'. morris-0.3/src/mainapp.cc:315:64: style:inconclusive: Function 'setStatusbarText_withThinking' argument 1 names different: declaration 'suffix' definition 'thinkingSuffix'. [funcArgNamesDifferent] morris-0.3/src/mainapp.hh:169:57: note: Function 'setStatusbarText_withThinking' argument 1 names different: declaration 'suffix' definition 'thinkingSuffix'. morris-0.3/src/mainapp.cc:315:64: note: Function 'setStatusbarText_withThinking' argument 1 names different: declaration 'suffix' definition 'thinkingSuffix'. morris-0.3/src/mainapp.cc:366:21: performance: Passing the result of c_str() to a function that takes std::string as argument no. 1 is slow and redundant. [stlcstrParam] morris-0.3/src/ttable.cc:29:21: warning: Member variable 'TranspositionTable::lookups' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/ttable.cc:32:3: warning: Class 'TranspositionTable' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] morris-0.3/src/ttable.cc:32:3: warning: Class 'TranspositionTable' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] morris-0.3/src/ttable.cc:59:71: style:inconclusive: Function 'lookup' argument 1 names different: declaration 'h' definition 'hash'. [funcArgNamesDifferent] morris-0.3/src/ttable.hh:51:33: note: Function 'lookup' argument 1 names different: declaration 'h' definition 'hash'. morris-0.3/src/ttable.cc:59:71: note: Function 'lookup' argument 1 names different: declaration 'h' definition 'hash'. morris-0.3/src/ttable.cc:85:43: style:inconclusive: Function 'insert' argument 1 names different: declaration 'h' definition 'hash'. [funcArgNamesDifferent] morris-0.3/src/ttable.hh:52:25: note: Function 'insert' argument 1 names different: declaration 'h' definition 'hash'. morris-0.3/src/ttable.cc:85:43: note: Function 'insert' argument 1 names different: declaration 'h' definition 'hash'. morris-0.3/src/rules.cc:334:16: performance:inconclusive: Technically the member function 'RuleSpec::currentPlayerHasWon' can be static (but you may consider moving to unnamed namespace). [functionStatic] morris-0.3/src/rules.hh:81:8: note: Technically the member function 'RuleSpec::currentPlayerHasWon' can be static (but you may consider moving to unnamed namespace). morris-0.3/src/rules.cc:334:16: note: Technically the member function 'RuleSpec::currentPlayerHasWon' can be static (but you may consider moving to unnamed namespace). morris-0.3/src/rules.cc:129:85: style:inconclusive: Function 'generateTakes' argument 3 names different: declaration 'currentBoard' definition 'currBoard'. [funcArgNamesDifferent] morris-0.3/src/rules.hh:129:81: note: Function 'generateTakes' argument 3 names different: declaration 'currentBoard' definition 'currBoard'. morris-0.3/src/rules.cc:129:85: note: Function 'generateTakes' argument 3 names different: declaration 'currentBoard' definition 'currBoard'. morris-0.3/src/rules.cc:195:27: style:inconclusive: Function 'addTakesToMoveIfMillClosed' argument 3 names different: declaration 'currentBoard' definition 'currBoard'. [funcArgNamesDifferent] morris-0.3/src/rules.hh:135:95: note: Function 'addTakesToMoveIfMillClosed' argument 3 names different: declaration 'currentBoard' definition 'currBoard'. morris-0.3/src/rules.cc:195:27: note: Function 'addTakesToMoveIfMillClosed' argument 3 names different: declaration 'currentBoard' definition 'currBoard'. morris-0.3/src/rules.cc:219:70: style:inconclusive: Function 'generateMoves' argument 2 names different: declaration 'currentBoard' definition 'currBoard'. [funcArgNamesDifferent] morris-0.3/src/rules.hh:101:68: note: Function 'generateMoves' argument 2 names different: declaration 'currentBoard' definition 'currBoard'. morris-0.3/src/rules.cc:219:70: note: Function 'generateMoves' argument 2 names different: declaration 'currentBoard' definition 'currBoard'. morris-0.3/src/rules.cc:544:10: warning: Uninitialized variable: id [uninitvar] morris-0.3/src/rules.cc:534:17: note: Assuming condition is false morris-0.3/src/rules.cc:544:10: note: Uninitialized variable: id morris-0.3/src/gtkcairo_boardgui.cc:991:30: warning: Member variable 'Geometry::width_inUnits' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/gtkcairo_boardgui.cc:991:30: warning: Member variable 'Geometry::height_inUnits' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/gtkcairo_boardgui.cc:991:30: warning: Member variable 'Geometry::windowWidth_inUnits' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/gtkcairo_boardgui.cc:991:30: warning: Member variable 'Geometry::windowHeight_inUnits' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/gtkcairo_boardgui.cc:991:30: warning: Member variable 'Geometry::scale_units2pixels' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/gtkcairo_boardgui.cc:991:30: warning: Member variable 'Geometry::xoffset_board_inUnits' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/gtkcairo_boardgui.cc:991:30: warning: Member variable 'Geometry::yoffset_board_inUnits' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/gtkcairo_boardgui.cc:991:30: warning: Member variable 'Geometry::boardBorderLeft_inUnits' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/gtkcairo_boardgui.cc:991:30: warning: Member variable 'Geometry::boardBorderRight_inUnits' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/gtkcairo_boardgui.cc:991:30: warning: Member variable 'Geometry::boardBorderTop_inUnits' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/gtkcairo_boardgui.cc:991:30: warning: Member variable 'Geometry::boardBorderBottom_inUnits' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/gtkcairo_boardgui.cc:991:30: warning: Member variable 'Geometry::stackX_white_inUnits' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/gtkcairo_boardgui.cc:991:30: warning: Member variable 'Geometry::stackX_black_inUnits' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/gtkcairo_boardgui.cc:991:30: warning: Member variable 'Geometry::piece_radius_inUnits' is not initialized in the constructor. [uninitMemberVar] morris-0.3/src/gtkcairo_boardgui.cc:615:25: style: Unused private function: 'BoardGUI_GtkCairo::draw_board_complete' [unusedPrivateFunction] morris-0.3/src/gtkcairo_boardgui.hh:128:8: note: Unused private function: 'BoardGUI_GtkCairo::draw_board_complete' morris-0.3/src/gtkcairo_boardgui.cc:615:25: note: Unused private function: 'BoardGUI_GtkCairo::draw_board_complete' morris-0.3/src/gtkcairo_boardgui.cc:63:25: style: Unused private function: 'BoardGUI_GtkCairo::cb_expose_area' [unusedPrivateFunction] morris-0.3/src/gtkcairo_boardgui.hh:203:8: note: Unused private function: 'BoardGUI_GtkCairo::cb_expose_area' morris-0.3/src/gtkcairo_boardgui.cc:63:25: note: Unused private function: 'BoardGUI_GtkCairo::cb_expose_area' morris-0.3/src/gtkcairo_boardgui.cc:71:25: style: Unused private function: 'BoardGUI_GtkCairo::cb_configure_area' [unusedPrivateFunction] morris-0.3/src/gtkcairo_boardgui.hh:204:8: note: Unused private function: 'BoardGUI_GtkCairo::cb_configure_area' morris-0.3/src/gtkcairo_boardgui.cc:71:25: note: Unused private function: 'BoardGUI_GtkCairo::cb_configure_area' morris-0.3/src/gtkcairo_boardgui.cc:265:25: style: Unused private function: 'BoardGUI_GtkCairo::cb_animation_timer' [unusedPrivateFunction] morris-0.3/src/gtkcairo_boardgui.hh:206:8: note: Unused private function: 'BoardGUI_GtkCairo::cb_animation_timer' morris-0.3/src/gtkcairo_boardgui.cc:265:25: note: Unused private function: 'BoardGUI_GtkCairo::cb_animation_timer' morris-0.3/src/gtkcairo_boardgui.cc:420:25: style:inconclusive: Technically the member function 'BoardGUI_GtkCairo::draw_piece_inPixels' can be const. [functionConst] morris-0.3/src/gtkcairo_boardgui.hh:137:8: note: Technically the member function 'BoardGUI_GtkCairo::draw_piece_inPixels' can be const. morris-0.3/src/gtkcairo_boardgui.cc:420:25: note: Technically the member function 'BoardGUI_GtkCairo::draw_piece_inPixels' can be const. morris-0.3/src/gtkcairo_boardgui.cc:490:25: style:inconclusive: Technically the member function 'BoardGUI_GtkCairo::drawRect' can be const. [functionConst] morris-0.3/src/gtkcairo_boardgui.hh:198:8: note: Technically the member function 'BoardGUI_GtkCairo::drawRect' can be const. morris-0.3/src/gtkcairo_boardgui.cc:490:25: note: Technically the member function 'BoardGUI_GtkCairo::drawRect' can be const. morris-0.3/src/gtkcairo_boardgui.cc:1083:29: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtkcairo_boardgui.cc:1092:29: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtkcairo_boardgui.cc:1101:29: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtkcairo_boardgui.cc:1114:29: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtkcairo_boardgui.cc:1123:29: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtkcairo_boardgui.cc:1131:29: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtkcairo_boardgui.cc:1139:29: style: C-style pointer casting [cstyleCast] morris-0.3/src/gtkcairo_boardgui.cc:1162:3: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtkcairo_boardgui.cc:1163:3: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtkcairo_boardgui.cc:1164:3: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtkcairo_boardgui.cc:1166:3: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtkcairo_boardgui.cc:1167:3: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtkcairo_boardgui.cc:1168:3: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] morris-0.3/src/gtkcairo_boardgui.cc:747:10: style: The scope of the variable 'pl' can be reduced. [variableScope] morris-0.3/src/gtkcairo_boardgui.cc:869:14: style: The scope of the variable 'pl' can be reduced. [variableScope] morris-0.3/src/gtkcairo_boardgui.cc:415:90: style:inconclusive: Function 'draw_piece' argument 4 names different: declaration 'halfTransparent' definition 'transparent'. [funcArgNamesDifferent] morris-0.3/src/gtkcairo_boardgui.hh:136:83: note: Function 'draw_piece' argument 4 names different: declaration 'halfTransparent' definition 'transparent'. morris-0.3/src/gtkcairo_boardgui.cc:415:90: note: Function 'draw_piece' argument 4 names different: declaration 'halfTransparent' definition 'transparent'. morris-0.3/src/gtkcairo_boardgui.cc:420:100: style:inconclusive: Function 'draw_piece_inPixels' argument 4 names different: declaration 'halfTransparent' definition 'transparent'. [funcArgNamesDifferent] morris-0.3/src/gtkcairo_boardgui.hh:137:83: note: Function 'draw_piece_inPixels' argument 4 names different: declaration 'halfTransparent' definition 'transparent'. morris-0.3/src/gtkcairo_boardgui.cc:420:100: note: Function 'draw_piece_inPixels' argument 4 names different: declaration 'halfTransparent' definition 'transparent'. morris-0.3/src/gtkcairo_boardgui.cc:490:55: style:inconclusive: Function 'drawRect' argument 2 names different: declaration 'topleft' definition 'tl'. [funcArgNamesDifferent] morris-0.3/src/gtkcairo_boardgui.hh:198:35: note: Function 'drawRect' argument 2 names different: declaration 'topleft' definition 'tl'. morris-0.3/src/gtkcairo_boardgui.cc:490:55: note: Function 'drawRect' argument 2 names different: declaration 'topleft' definition 'tl'. morris-0.3/src/gtkcairo_boardgui.cc:490:67: style:inconclusive: Function 'drawRect' argument 3 names different: declaration 'bottomright' definition 'br'. [funcArgNamesDifferent] morris-0.3/src/gtkcairo_boardgui.hh:198:52: note: Function 'drawRect' argument 3 names different: declaration 'bottomright' definition 'br'. morris-0.3/src/gtkcairo_boardgui.cc:490:67: note: Function 'drawRect' argument 3 names different: declaration 'bottomright' definition 'br'. morris-0.3/src/gtkcairo_boardgui.cc:1038:59: style:inconclusive: Function 'pixel2Board' argument 1 names different: declaration 'boardCoord' definition 'pixelCoord'. [funcArgNamesDifferent] morris-0.3/src/gtkcairo_boardgui.hh:147:34: note: Function 'pixel2Board' argument 1 names different: declaration 'boardCoord' definition 'pixelCoord'. morris-0.3/src/gtkcairo_boardgui.cc:1038:59: note: Function 'pixel2Board' argument 1 names different: declaration 'boardCoord' definition 'pixelCoord'. morris-0.3/src/gtkcairo_boardgui.cc:869:14: style: Local variable 'pl' shadows outer variable [shadowVariable] morris-0.3/src/gtkcairo_boardgui.cc:747:10: note: Shadowed declaration morris-0.3/src/gtkcairo_boardgui.cc:869:14: note: Shadow variable morris-0.3/src/gtkcairo_boardgui.cc:127:16: style: Variable 'control' can be declared as reference to const [constVariableReference] morris-0.3/src/gtkcairo_boardgui.cc:245:16: style: Variable 'control' can be declared as reference to const [constVariableReference] morris-0.3/src/gtkcairo_boardgui.cc:507:16: style: Variable 'control' can be declared as reference to const [constVariableReference] morris-0.3/src/gtkcairo_boardgui.cc:626:16: style: Variable 'control' can be declared as reference to const [constVariableReference] morris-0.3/src/gtkcairo_boardgui.cc:947:16: style: Variable 'control' can be declared as reference to const [constVariableReference] morris-0.3/src/gtkcairo_boardgui.cc:63:51: style: Parameter 'widget' can be declared as pointer to const [constParameterPointer] morris-0.3/src/gtkcairo_boardgui.cc:63:75: style: Parameter 'event' can be declared as pointer to const [constParameterPointer] morris-0.3/src/gtkcairo_boardgui.cc:509:19: style: Variable 'boardGrid' can be declared as pointer to const [constVariablePointer] morris-0.3/src/gtkcairo_boardgui.cc:1081:59: style: Parameter 'event' can be declared as pointer to const. However it seems that 'button_press_area' is a callback function, if 'event' is declared with const you might also need to cast function pointer(s). [constParameterCallback] morris-0.3/src/gtkcairo_boardgui.cc:1166:3: note: You might need to cast the function pointer here morris-0.3/src/gtkcairo_boardgui.cc:1081:59: note: Parameter 'event' can be declared as pointer to const morris-0.3/src/gtkcairo_boardgui.cc:1090:61: style: Parameter 'event' can be declared as pointer to const. However it seems that 'button_release_area' is a callback function, if 'event' is declared with const you might also need to cast function pointer(s). [constParameterCallback] morris-0.3/src/gtkcairo_boardgui.cc:1167:3: note: You might need to cast the function pointer here morris-0.3/src/gtkcairo_boardgui.cc:1090:61: note: Parameter 'event' can be declared as pointer to const morris-0.3/src/gtkcairo_boardgui.cc:725:7: style: Variable 'maxPieces' is assigned a value that is never used. [unreadVariable] morris-0.3/src/gtkcairo_boardgui.cc:951:12: style: Variable 'o.player' is assigned a value that is never used. [unreadVariable] diff: 2.18.0 morris-0.3/src/configmgr.cc:48:3: warning: Class 'ConfigManager' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] head morris-0.3/src/configmgr.cc:48:3: warning: Class 'ConfigManager' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] 2.18.0 morris-0.3/src/configmgr.cc:48:3: warning: Class 'ConfigManager' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] head morris-0.3/src/configmgr.cc:48:3: warning: Class 'ConfigManager' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] head morris-0.3/src/gconf_configmgr.cc:90:18: warning: Class 'ConfigManager_GConf' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] head morris-0.3/src/gconf_configmgr.cc:90:18: warning: Class 'ConfigManager_GConf' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] head morris-0.3/src/gtk_movelog.cc:122:18: warning: Class 'MoveLog_Gtk' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] head morris-0.3/src/gtk_movelog.cc:122:18: warning: Class 'MoveLog_Gtk' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] 2.18.0 morris-0.3/src/ttable.cc:32:3: warning: Class 'TranspositionTable' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] head morris-0.3/src/ttable.cc:32:3: warning: Class 'TranspositionTable' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] 2.18.0 morris-0.3/src/ttable.cc:32:3: warning: Class 'TranspositionTable' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] head morris-0.3/src/ttable.cc:32:3: warning: Class 'TranspositionTable' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] DONE