2025-07-14 22:29
ftp://ftp.de.debian.org/debian/pool/main/m/monopd/monopd_0.10.4.orig.tar.gz
cppcheck-options: --library=posix --library=gnu --library=bsd  --inconclusive --enable=style,information --inline-suppr --template=daca2 --disable=missingInclude --suppress=unmatchedSuppression --check-library --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=normalCheckLevelConditionExpressions -D__GNUC__ --platform=unix64 -j3
platform: Linux-6.8.0-63-generic-x86_64-with-glibc2.39
python: 3.12.3
client-version: 1.3.67
compiler: g++ (Ubuntu 13.3.0-6ubuntu2~24.04) 13.3.0
cppcheck: head 2.17.0
head-info: a2600d0 (2025-07-14 12:39:20 +0200)
count: 282 281
elapsed-time: 0.6 0.6
head-timing-info:

old-timing-info:

head results:
monopd-0.10.4/src/auction.h:36:15: style:inconclusive: Technically the member function 'Auction::status' can be const. [functionConst]
monopd-0.10.4/src/player.h:41:8: style:inconclusive: Technically the member function 'Player::identified' can be const. [functionConst]
monopd-0.10.4/src/gameobject.h:36:2: style: Class 'GameObject' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
monopd-0.10.4/src/player.h:36:3: style: Class 'Player' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
monopd-0.10.4/src/player.h:45:33: performance: Function parameter 'data' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/player.h:47:34: performance: Function parameter 'data' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/player.h:48:38: performance: Function parameter 'data' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/card.cpp:32:2: performance: Variable 'm_rentMath' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList]
monopd-0.10.4/src/card.h:38:7: style:inconclusive: Technically the member function 'Card::canBeOwned' can be const. [functionConst]
monopd-0.10.4/src/card.h:49:14: style:inconclusive: Technically the member function 'Card::rentMath' can be const. [functionConst]
monopd-0.10.4/src/card.h:51:6: style:inconclusive: Technically the member function 'Card::pay' can be const. [functionConst]
monopd-0.10.4/src/card.h:52:6: style:inconclusive: Technically the member function 'Card::payHouse' can be const. [functionConst]
monopd-0.10.4/src/card.h:53:6: style:inconclusive: Technically the member function 'Card::payHotel' can be const. [functionConst]
monopd-0.10.4/src/card.h:54:6: style:inconclusive: Technically the member function 'Card::payEach' can be const. [functionConst]
monopd-0.10.4/src/card.h:55:6: style:inconclusive: Technically the member function 'Card::advance' can be const. [functionConst]
monopd-0.10.4/src/card.h:56:6: style:inconclusive: Technically the member function 'Card::advanceTo' can be const. [functionConst]
monopd-0.10.4/src/card.h:58:7: style:inconclusive: Technically the member function 'Card::toJail' can be const. [functionConst]
monopd-0.10.4/src/card.h:59:7: style:inconclusive: Technically the member function 'Card::outOfJail' can be const. [functionConst]
monopd-0.10.4/src/card.h:49:14: performance: Function 'rentMath()' should return member 'm_rentMath' by const reference. [returnByReference]
monopd-0.10.4/src/card.cpp:25:23: style:inconclusive: Function 'Card' argument 1 names different: declaration 'cardGroup' definition 'group'. [funcArgNamesDifferent]
monopd-0.10.4/src/card.h:32:18: note: Function 'Card' argument 1 names different: declaration 'cardGroup' definition 'group'.
monopd-0.10.4/src/card.cpp:25:23: note: Function 'Card' argument 1 names different: declaration 'cardGroup' definition 'group'.
monopd-0.10.4/src/cardgroup.h:34:42: performance: Function parameter 'name' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/card.h:48:31: performance: Function parameter 'rentMath' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/game.h:71:10: style:inconclusive: Technically the member function 'Game::status' can be const. [functionConst]
monopd-0.10.4/src/game.h:74:21: style:inconclusive: Technically the member function 'Game::gameType' can be const. [functionConst]
monopd-0.10.4/src/game.h:75:21: style:inconclusive: Technically the member function 'Game::bgColor' can be const. [functionConst]
monopd-0.10.4/src/game.h:76:7: style:inconclusive: Technically the member function 'Game::houses' can be const. [functionConst]
monopd-0.10.4/src/game.h:77:7: style:inconclusive: Technically the member function 'Game::hotels' can be const. [functionConst]
monopd-0.10.4/src/game.h:78:8: style:inconclusive: Technically the member function 'Game::isValid' can be const. [functionConst]
monopd-0.10.4/src/display.h:29:2: style: Class 'DisplayButton' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
monopd-0.10.4/src/display.h:43:2: style: Class 'Display' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
monopd-0.10.4/src/game.h:40:3: style: Class 'Game' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
monopd-0.10.4/src/game.h:74:21: performance: Function 'gameType()' should return member 'm_gameType' by const reference. [returnByReference]
monopd-0.10.4/src/game.h:75:21: performance: Function 'bgColor()' should return member 'm_bgColor' by const reference. [returnByReference]
monopd-0.10.4/src/debt.h:31:16: style:inconclusive: Technically the member function 'Debt::amount' can be const. [functionConst]
monopd-0.10.4/src/display.h:28:34: performance: Function parameter 'command' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/display.h:28:61: performance: Function parameter 'caption' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/display.h:48:33: performance: Function parameter 'text' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/display.h:51:35: performance: Function parameter 'command' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/display.h:51:62: performance: Function parameter 'caption' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/game.h:48:34: performance: Function parameter 'data' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/game.h:50:33: performance: Function parameter 'data' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/game.h:51:34: performance: Function parameter 'data' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/game.h:67:41: performance: Function parameter 'data' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/game.h:138:45: performance: Function parameter 'name' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/game.h:139:46: performance: Function parameter 'name' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/game.h:140:57: performance: Function parameter 'name' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/cardgroup.cpp:25:54: performance: Function parameter 'name' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/cardgroup.cpp:35:52: performance: Function parameter 'name' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/estate.h:56:6: style:inconclusive: Technically the member function 'Estate::rentByHouses' can be const. [functionConst]
monopd-0.10.4/src/display.cpp:29:2: performance: Variable 'm_command' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList]
monopd-0.10.4/src/display.cpp:30:2: performance: Variable 'm_caption' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList]
monopd-0.10.4/src/display.cpp:35:2: performance: Variable 'm_command' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList]
monopd-0.10.4/src/display.cpp:36:2: performance: Variable 'm_caption' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList]
monopd-0.10.4/src/display.cpp:58:2: performance: Variable 'm_text' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList]
monopd-0.10.4/src/display.cpp:64:2: performance: Variable 'm_text' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList]
monopd-0.10.4/src/display.cpp:40:34: style:inconclusive: Technically the member function 'DisplayButton::command' can be const. [functionConst]
monopd-0.10.4/src/display.h:30:20: note: Technically the member function 'DisplayButton::command' can be const.
monopd-0.10.4/src/display.cpp:40:34: note: Technically the member function 'DisplayButton::command' can be const.
monopd-0.10.4/src/display.cpp:45:34: style:inconclusive: Technically the member function 'DisplayButton::caption' can be const. [functionConst]
monopd-0.10.4/src/display.h:31:20: note: Technically the member function 'DisplayButton::caption' can be const.
monopd-0.10.4/src/display.cpp:45:34: note: Technically the member function 'DisplayButton::caption' can be const.
monopd-0.10.4/src/display.cpp:50:21: style:inconclusive: Technically the member function 'DisplayButton::enabled' can be const. [functionConst]
monopd-0.10.4/src/display.h:32:7: note: Technically the member function 'DisplayButton::enabled' can be const.
monopd-0.10.4/src/display.cpp:50:21: note: Technically the member function 'DisplayButton::enabled' can be const.
monopd-0.10.4/src/display.cpp:109:28: style:inconclusive: Technically the member function 'Display::text' can be const. [functionConst]
monopd-0.10.4/src/display.h:50:20: note: Technically the member function 'Display::text' can be const.
monopd-0.10.4/src/display.cpp:109:28: note: Technically the member function 'Display::text' can be const.
monopd-0.10.4/src/display.cpp:135:15: style:inconclusive: Technically the member function 'Display::clearButtons' can be const. [functionConst]
monopd-0.10.4/src/display.h:55:7: note: Technically the member function 'Display::clearButtons' can be const.
monopd-0.10.4/src/display.cpp:135:15: note: Technically the member function 'Display::clearButtons' can be const.
monopd-0.10.4/src/display.cpp:140:15: style:inconclusive: Technically the member function 'Display::clearText' can be const. [functionConst]
monopd-0.10.4/src/display.h:56:7: note: Technically the member function 'Display::clearText' can be const.
monopd-0.10.4/src/display.cpp:140:15: note: Technically the member function 'Display::clearText' can be const.
monopd-0.10.4/src/display.cpp:145:15: style:inconclusive: Technically the member function 'Display::clearEstate' can be const. [functionConst]
monopd-0.10.4/src/display.h:57:7: note: Technically the member function 'Display::clearEstate' can be const.
monopd-0.10.4/src/display.cpp:145:15: note: Technically the member function 'Display::clearEstate' can be const.
monopd-0.10.4/src/display.h:30:20: performance: Function 'command()' should return member 'm_command' by const reference. [returnByReference]
monopd-0.10.4/src/display.h:31:20: performance: Function 'caption()' should return member 'm_caption' by const reference. [returnByReference]
monopd-0.10.4/src/display.h:58:31: performance: Function 'buttons()' should return member 'm_buttons' by const reference. [returnByReference]
monopd-0.10.4/src/display.cpp:69:31: style: Local variable 'buttons' shadows outer function [shadowFunction]
monopd-0.10.4/src/display.h:58:31: note: Shadowed declaration
monopd-0.10.4/src/display.cpp:69:31: note: Shadow variable
monopd-0.10.4/src/display.cpp:27:48: performance: Function parameter 'command' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/display.cpp:27:75: performance: Function parameter 'caption' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/display.cpp:91:41: performance: Function parameter 'text' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/display.cpp:114:43: performance: Function parameter 'command' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/display.cpp:114:70: performance: Function parameter 'caption' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/estate.cpp:35:26: style:inconclusive: Function 'rent' argument 1 names different: declaration 'player' definition 'pLand'. [funcArgNamesDifferent]
monopd-0.10.4/src/estate.h:57:19: note: Function 'rent' argument 1 names different: declaration 'player' definition 'pLand'.
monopd-0.10.4/src/estate.cpp:35:26: note: Function 'rent' argument 1 names different: declaration 'player' definition 'pLand'.
monopd-0.10.4/src/estate.cpp:130:40: style:inconclusive: Function 'canToggleMortgage' argument 1 names different: declaration 'owner' definition 'p'. [funcArgNamesDifferent]
monopd-0.10.4/src/estate.h:61:33: note: Function 'canToggleMortgage' argument 1 names different: declaration 'owner' definition 'p'.
monopd-0.10.4/src/estate.cpp:130:40: note: Function 'canToggleMortgage' argument 1 names different: declaration 'owner' definition 'p'.
monopd-0.10.4/src/estate.cpp:176:42: style:inconclusive: Function 'setTakeCardGroup' argument 1 names different: declaration 'cardGroup' definition 'takeCardGroup'. [funcArgNamesDifferent]
monopd-0.10.4/src/estate.h:47:35: note: Function 'setTakeCardGroup' argument 1 names different: declaration 'cardGroup' definition 'takeCardGroup'.
monopd-0.10.4/src/estate.cpp:176:42: note: Function 'setTakeCardGroup' argument 1 names different: declaration 'cardGroup' definition 'takeCardGroup'.
monopd-0.10.4/src/estategroup.h:36:37: performance: Function parameter 'rentMath' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/estategroup.h:37:36: performance: Function parameter 'rentVar' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/estate.cpp:96:35: style: Parameter 'p' can be declared as pointer to const [constParameterPointer]
monopd-0.10.4/src/estate.cpp:105:36: style: Parameter 'p' can be declared as pointer to const [constParameterPointer]
monopd-0.10.4/src/estate.cpp:130:40: style: Parameter 'p' can be declared as pointer to const [constParameterPointer]
monopd-0.10.4/src/event.h:40:6: style:inconclusive: Technically the member function 'Event::frequency' can be const. [functionConst]
monopd-0.10.4/src/event.h:41:15: style:inconclusive: Technically the member function 'Event::type' can be const. [functionConst]
monopd-0.10.4/src/estategroup.cpp:43:27: style:inconclusive: Technically the member function 'EstateGroup::price' can be const. [functionConst]
monopd-0.10.4/src/estategroup.h:33:15: note: Technically the member function 'EstateGroup::price' can be const.
monopd-0.10.4/src/estategroup.cpp:43:27: note: Technically the member function 'EstateGroup::price' can be const.
monopd-0.10.4/src/estategroup.cpp:54:27: style:inconclusive: Technically the member function 'EstateGroup::housePrice' can be const. [functionConst]
monopd-0.10.4/src/estategroup.h:35:15: note: Technically the member function 'EstateGroup::housePrice' can be const.
monopd-0.10.4/src/estategroup.cpp:54:27: note: Technically the member function 'EstateGroup::housePrice' can be const.
monopd-0.10.4/src/estategroup.cpp:71:18: style:inconclusive: Technically the member function 'EstateGroup::rent' can be const. [functionConst]
monopd-0.10.4/src/estategroup.h:38:6: note: Technically the member function 'EstateGroup::rent' can be const.
monopd-0.10.4/src/estategroup.cpp:71:18: note: Technically the member function 'EstateGroup::rent' can be const.
monopd-0.10.4/src/event.h:47:15: warning: The class 'Event' defines member variable with name 'm_type' also defined in its parent class 'GameObject'. [duplInheritedMember]
monopd-0.10.4/src/gameobject.h:68:7: note: Parent variable 'GameObject::m_type'
monopd-0.10.4/src/event.h:47:15: note: Derived variable 'Event::m_type'
monopd-0.10.4/src/event.h:41:15: warning: The class 'Event' defines member function with name 'type' also defined in its parent class 'GameObject'. [duplInheritedMember]
monopd-0.10.4/src/gameobject.h:42:12: note: Parent function 'GameObject::type'
monopd-0.10.4/src/event.h:41:15: note: Derived function 'Event::type'
monopd-0.10.4/src/estategroup.cpp:39:14: style: The statement 'if (m_price!=price) m_price=price' is logically equivalent to 'm_price=price'. [duplicateConditionalAssign]
monopd-0.10.4/src/estategroup.cpp:40:11: note: Assignment 'm_price=price'
monopd-0.10.4/src/estategroup.cpp:39:14: note: Condition 'm_price!=price' is redundant
monopd-0.10.4/src/estategroup.cpp:50:19: style: The statement 'if (m_housePrice!=housePrice) m_housePrice=housePrice' is logically equivalent to 'm_housePrice=housePrice'. [duplicateConditionalAssign]
monopd-0.10.4/src/estategroup.cpp:51:16: note: Assignment 'm_housePrice=housePrice'
monopd-0.10.4/src/estategroup.cpp:50:19: note: Condition 'm_housePrice!=housePrice' is redundant
monopd-0.10.4/src/estategroup.cpp:61:17: style: The statement 'if (m_rentMath!=rentMath) m_rentMath=rentMath' is logically equivalent to 'm_rentMath=rentMath'. [duplicateConditionalAssign]
monopd-0.10.4/src/estategroup.cpp:62:14: note: Assignment 'm_rentMath=rentMath'
monopd-0.10.4/src/estategroup.cpp:61:17: note: Condition 'm_rentMath!=rentMath' is redundant
monopd-0.10.4/src/estategroup.cpp:67:16: style: The statement 'if (m_rentVar!=rentVar) m_rentVar=rentVar' is logically equivalent to 'm_rentVar=rentVar'. [duplicateConditionalAssign]
monopd-0.10.4/src/estategroup.cpp:68:13: note: Assignment 'm_rentVar=rentVar'
monopd-0.10.4/src/estategroup.cpp:67:16: note: Condition 'm_rentVar!=rentVar' is redundant
monopd-0.10.4/src/estategroup.cpp:30:58: performance: Function parameter 'name' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/estategroup.cpp:59:49: performance: Function parameter 'rentMath' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/estategroup.cpp:65:48: performance: Function parameter 'rentVar' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/estategroup.cpp:88:39: style: Variable 'e' can be declared as reference to const [constVariableReference]
monopd-0.10.4/src/gameconfig.cpp:23:2: performance: Variable 'm_id' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList]
monopd-0.10.4/src/gameconfig.cpp:24:2: performance: Variable 'm_name' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList]
monopd-0.10.4/src/gameconfig.cpp:25:2: performance: Variable 'm_description' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList]
monopd-0.10.4/src/gameconfig.h:27:20: style:inconclusive: Technically the member function 'GameConfig::id' can be const. [functionConst]
monopd-0.10.4/src/gameconfig.h:28:20: style:inconclusive: Technically the member function 'GameConfig::name' can be const. [functionConst]
monopd-0.10.4/src/gameconfig.h:29:20: style:inconclusive: Technically the member function 'GameConfig::description' can be const. [functionConst]
monopd-0.10.4/src/gameconfig.h:27:20: performance: Function 'id()' should return member 'm_id' by const reference. [returnByReference]
monopd-0.10.4/src/gameconfig.h:28:20: performance: Function 'name()' should return member 'm_name' by const reference. [returnByReference]
monopd-0.10.4/src/gameconfig.h:29:20: performance: Function 'description()' should return member 'm_description' by const reference. [returnByReference]
monopd-0.10.4/src/gameproperty.cpp:24:2: performance: Variable 'm_key' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList]
monopd-0.10.4/src/gameproperty.cpp:72:2: performance: Variable 'm_value' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList]
monopd-0.10.4/src/gameproperty.cpp:65:22: style:inconclusive: Technically the member function 'GameIntProperty::value' can be const. [functionConst]
monopd-0.10.4/src/gameproperty.h:45:6: note: Technically the member function 'GameIntProperty::value' can be const.
monopd-0.10.4/src/gameproperty.cpp:65:22: note: Technically the member function 'GameIntProperty::value' can be const.
monopd-0.10.4/src/gameproperty.h:28:14: performance: Function 'key()' should return member 'm_key' by const reference. [returnByReference]
monopd-0.10.4/src/gameproperty.h:56:14: performance: Function 'value()' should return member 'm_value' by const reference. [returnByReference]
monopd-0.10.4/src/gameproperty.cpp:22:64: style:inconclusive: Function 'GameProperty' argument 2 names different: declaration 'm_scope' definition 'scope'. [funcArgNamesDifferent]
monopd-0.10.4/src/gameproperty.h:27:51: note: Function 'GameProperty' argument 2 names different: declaration 'm_scope' definition 'scope'.
monopd-0.10.4/src/gameproperty.cpp:22:64: note: Function 'GameProperty' argument 2 names different: declaration 'm_scope' definition 'scope'.
monopd-0.10.4/src/io.cpp:57:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar]
monopd-0.10.4/src/listener.cpp:54:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SIG_IGN [valueFlowBailoutIncompleteVar]
monopd-0.10.4/src/listener.cpp:93:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AF_INET6 [valueFlowBailoutIncompleteVar]
monopd-0.10.4/src/listener.cpp:159:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LOG_INFO [valueFlowBailoutIncompleteVar]
monopd-0.10.4/src/listener.cpp:308:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable INET6_ADDRSTRLEN [valueFlowBailoutIncompleteVar]
monopd-0.10.4/src/listener.cpp:354:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable INET6_ADDRSTRLEN [valueFlowBailoutIncompleteVar]
monopd-0.10.4/src/game.cpp:186:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MONOPD_DATADIR [valueFlowBailoutIncompleteVar]
monopd-0.10.4/src/game.cpp:2092:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LOG_INFO [valueFlowBailoutIncompleteVar]
monopd-0.10.4/src/game.cpp:2138:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RAND_MAX [valueFlowBailoutIncompleteVar]
monopd-0.10.4/src/listenport.h:29:20: style:inconclusive: Technically the member function 'ListenPort::ipAddr' can be const. [functionConst]
monopd-0.10.4/src/listenport.h:30:6: style:inconclusive: Technically the member function 'ListenPort::port' can be const. [functionConst]
monopd-0.10.4/src/listenport.h:31:6: style:inconclusive: Technically the member function 'ListenPort::fd' can be const. [functionConst]
monopd-0.10.4/src/listenport.h:32:6: style:inconclusive: Technically the member function 'ListenPort::error' can be const. [functionConst]
monopd-0.10.4/src/socket.h:39:9: style:inconclusive: Technically the member function 'Socket::status' can be const. [functionConst]
monopd-0.10.4/src/socket.h:41:7: style:inconclusive: Technically the member function 'Socket::type' can be const. [functionConst]
monopd-0.10.4/src/socket.h:48:7: style:inconclusive: Technically the member function 'Socket::sendBufNotEmpty' can be const. [functionConst]
monopd-0.10.4/src/listenport.h:28:2: style: Class 'ListenPort' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
monopd-0.10.4/src/socket.h:37:2: style: Class 'Socket' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
monopd-0.10.4/src/listenport.h:29:20: performance: Function 'ipAddr()' should return member 'm_ipAddr' by const reference. [returnByReference]
monopd-0.10.4/src/socket.h:53:14: performance: Function 'ipAddr()' should return member 'm_ipAddr' by const reference. [returnByReference]
monopd-0.10.4/src/listener.cpp:272:42: style: C-style pointer casting [cstyleCast]
monopd-0.10.4/src/listener.cpp:274:42: style: C-style pointer casting [cstyleCast]
monopd-0.10.4/src/listener.cpp:312:61: style: C-style pointer casting [cstyleCast]
monopd-0.10.4/src/listener.cpp:378:38: style: C-style pointer casting [cstyleCast]
monopd-0.10.4/src/listener.cpp:380:38: style: C-style pointer casting [cstyleCast]
monopd-0.10.4/src/listener.cpp:312:28: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast]
monopd-0.10.4/src/listener.cpp:323:38: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast]
monopd-0.10.4/src/listener.cpp:326:38: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast]
monopd-0.10.4/src/listenport.h:27:51: performance: Function parameter 'host' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/socket.h:43:33: performance: Function parameter 'data' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/socket.h:47:36: performance: Function parameter 'data' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/socket.h:52:35: performance: Function parameter 'ipAddr' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/server.h:51:54: performance: Function parameter 'data2' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/server.h:64:46: performance: Function parameter 'id' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/server.h:64:68: performance: Function parameter 'name' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/server.h:64:92: performance: Function parameter 'description' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/server.h:70:49: performance: Function parameter 'gameType' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/gameobject.cpp:41:17: style:inconclusive: Technically the member function 'GameObject::id' can be const. [functionConst]
monopd-0.10.4/src/gameobject.h:40:6: note: Technically the member function 'GameObject::id' can be const.
monopd-0.10.4/src/gameobject.cpp:41:17: note: Technically the member function 'GameObject::id' can be const.
monopd-0.10.4/src/gameobject.cpp:51:35: style:inconclusive: Technically the member function 'GameObject::type' can be const. [functionConst]
monopd-0.10.4/src/gameobject.h:42:12: note: Technically the member function 'GameObject::type' can be const.
monopd-0.10.4/src/gameobject.cpp:51:35: note: Technically the member function 'GameObject::type' can be const.
monopd-0.10.4/src/gameobject.cpp:107:22: style: Variable 'stringProperty' can be declared as pointer to const [constVariablePointer]
monopd-0.10.4/src/gameobject.cpp:116:19: style: Variable 'intProperty' can be declared as pointer to const [constVariablePointer]
monopd-0.10.4/src/gameobject.cpp:134:20: style: Variable 'boolProperty' can be declared as pointer to const [constVariablePointer]
monopd-0.10.4/src/gameobject.cpp:338:46: style: Parameter 'object' can be declared as pointer to const [constParameterPointer]
monopd-0.10.4/src/gameobject.cpp:340:14: style: Variable 'oTmp' can be declared as pointer to const [constVariablePointer]
monopd-0.10.4/src/listenport.cpp:44:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SOCK_STREAM [valueFlowBailoutIncompleteVar]
monopd-0.10.4/src/listenport.cpp:115:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable F_GETFL [valueFlowBailoutIncompleteVar]
monopd-0.10.4/src/listenport.cpp:42:2: performance: Variable 'm_ipAddr' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList]
monopd-0.10.4/src/listenport.cpp:109:2: performance: Variable 'm_ipAddr' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList]
monopd-0.10.4/src/listenport.cpp:54:37: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast]
monopd-0.10.4/src/listenport.cpp:59:39: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast]
monopd-0.10.4/src/listenport.cpp:78:18: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast]
monopd-0.10.4/src/listenport.cpp:38:62: style:inconclusive: Function 'ListenPort' argument 2 names different: declaration 'host' definition 'ip'. [funcArgNamesDifferent]
monopd-0.10.4/src/listenport.h:27:51: note: Function 'ListenPort' argument 2 names different: declaration 'host' definition 'ip'.
monopd-0.10.4/src/listenport.cpp:38:62: note: Function 'ListenPort' argument 2 names different: declaration 'host' definition 'ip'.
monopd-0.10.4/src/listenport.cpp:38:62: performance: Function parameter 'ip' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/server.cpp:623:60: error: There is an unknown macro here somewhere. Configuration is required. If MONOPD_CONFIGDIR is a macro then please configure it. [unknownMacro]
monopd-0.10.4/src/socket.cpp:40:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Ok [valueFlowBailoutIncompleteVar]
monopd-0.10.4/src/socket.cpp:97:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable errno [valueFlowBailoutIncompleteVar]
monopd-0.10.4/src/socket.cpp:115:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar]
monopd-0.10.4/src/socket.cpp:123:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable npos [valueFlowBailoutIncompleteVar]
monopd-0.10.4/src/socket.cpp:110:14: style:inconclusive: Technically the member function 'Socket::hasReadLine' can be const. [functionConst]
monopd-0.10.4/src/socket.h:45:7: note: Technically the member function 'Socket::hasReadLine' can be const.
monopd-0.10.4/src/socket.cpp:110:14: note: Technically the member function 'Socket::hasReadLine' can be const.
monopd-0.10.4/src/socket.cpp:38:40: performance: Function parameter 'data' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/socket.cpp:139:43: performance: Function parameter 'data' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/tradecomponent.h:38:15: style:inconclusive: Technically the member function 'TradeComponent::money' can be const. [functionConst]
monopd-0.10.4/src/trade.cpp:219:10: style: The scope of the variable 'pTmp' can be reduced. [variableScope]
monopd-0.10.4/src/trade.cpp:230:6: style: The scope of the variable 'n' can be reduced. [variableScope]
monopd-0.10.4/src/trade.cpp:74:59: style:inconclusive: Function 'findMoneyObject' argument 2 names different: declaration 'targetPlayer' definition 'pTarget'. [funcArgNamesDifferent]
monopd-0.10.4/src/trade.h:46:53: note: Function 'findMoneyObject' argument 2 names different: declaration 'targetPlayer' definition 'pTarget'.
monopd-0.10.4/src/trade.cpp:74:59: note: Function 'findMoneyObject' argument 2 names different: declaration 'targetPlayer' definition 'pTarget'.
monopd-0.10.4/src/trade.cpp:261:39: performance: Function parameter 'data' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/trade.cpp:74:44: style: Parameter 'pFrom' can be declared as pointer to const [constParameterPointer]
monopd-0.10.4/src/trade.cpp:74:59: style: Parameter 'pTarget' can be declared as pointer to const [constParameterPointer]
monopd-0.10.4/src/trade.cpp:158:31: style: Parameter 'player' can be declared as pointer to const [constParameterPointer]
monopd-0.10.4/src/trade.cpp:193:42: style: Parameter 'tc' can be declared as pointer to const [constParameterPointer]
monopd-0.10.4/src/trade.cpp:150:3: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm]
monopd-0.10.4/src/trade.cpp:161:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm]
monopd-0.10.4/src/trade.cpp:170:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm]
monopd-0.10.4/src/player.cpp:1076:15: style: The statement 'if (m_estate!=estate) m_estate=estate' is logically equivalent to 'm_estate=estate'. [duplicateConditionalAssign]
monopd-0.10.4/src/player.cpp:1077:12: note: Assignment 'm_estate=estate'
monopd-0.10.4/src/player.cpp:1076:15: note: Condition 'm_estate!=estate' is redundant
monopd-0.10.4/src/player.cpp:1087:20: style: The statement 'if (m_destination!=estate) m_destination=estate' is logically equivalent to 'm_destination=estate'. [duplicateConditionalAssign]
monopd-0.10.4/src/player.cpp:1088:17: note: Assignment 'm_destination=estate'
monopd-0.10.4/src/player.cpp:1087:20: note: Condition 'm_destination!=estate' is redundant
monopd-0.10.4/src/player.cpp:85:6: style: The scope of the variable 'n' can be reduced. [variableScope]
monopd-0.10.4/src/player.cpp:168:20: style: Local variable 'estate' shadows outer function [shadowFunction]
monopd-0.10.4/src/player.h:72:11: note: Shadowed declaration
monopd-0.10.4/src/player.cpp:168:20: note: Shadow variable
monopd-0.10.4/src/player.cpp:258:12: style: Local variable 'display' shadows outer variable [shadowVariable]
monopd-0.10.4/src/player.cpp:236:10: note: Shadowed declaration
monopd-0.10.4/src/player.cpp:258:12: note: Shadow variable
monopd-0.10.4/src/player.cpp:435:11: style: Local variable 'display' shadows outer variable [shadowVariable]
monopd-0.10.4/src/player.cpp:426:10: note: Shadowed declaration
monopd-0.10.4/src/player.cpp:435:11: note: Shadow variable
monopd-0.10.4/src/player.cpp:512:10: style: Local variable 'estate' shadows outer function [shadowFunction]
monopd-0.10.4/src/player.h:72:11: note: Shadowed declaration
monopd-0.10.4/src/player.cpp:512:10: note: Shadow variable
monopd-0.10.4/src/player.cpp:547:10: style: Local variable 'estate' shadows outer function [shadowFunction]
monopd-0.10.4/src/player.h:72:11: note: Shadowed declaration
monopd-0.10.4/src/player.cpp:547:10: note: Shadow variable
monopd-0.10.4/src/player.cpp:620:11: style: Local variable 'display' shadows outer variable [shadowVariable]
monopd-0.10.4/src/player.cpp:611:10: note: Shadowed declaration
monopd-0.10.4/src/player.cpp:620:11: note: Shadow variable
monopd-0.10.4/src/player.cpp:636:10: style: Local variable 'estate' shadows outer function [shadowFunction]
monopd-0.10.4/src/player.h:72:11: note: Shadowed declaration
monopd-0.10.4/src/player.cpp:636:10: note: Shadow variable
monopd-0.10.4/src/player.cpp:729:10: style: Local variable 'estate' shadows outer function [shadowFunction]
monopd-0.10.4/src/player.h:72:11: note: Shadowed declaration
monopd-0.10.4/src/player.cpp:729:10: note: Shadow variable
monopd-0.10.4/src/player.cpp:834:11: style: Local variable 'estate' shadows outer function [shadowFunction]
monopd-0.10.4/src/player.h:72:11: note: Shadowed declaration
monopd-0.10.4/src/player.cpp:834:11: note: Shadow variable
monopd-0.10.4/src/trade.h:40:33: performance: Function parameter 'data' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/player.cpp:116:34: performance: Function parameter 'data' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/player.cpp:135:39: performance: Function parameter 'data' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/player.cpp:153:40: performance: Function parameter 'data' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/player.cpp:158:44: performance: Function parameter 'data' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/player.cpp:1119:29: style: Parameter 'card' can be declared as pointer to const [constParameterPointer]
monopd-0.10.4/src/game.cpp:1459:17: style: Comparison of a function returning boolean value using relational (<, >, <= or >=) operator. [comparisonOfFuncReturningBoolError]
monopd-0.10.4/src/game.cpp:58:15: performance: Variable 'm_bgColor' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList]
monopd-0.10.4/src/game.cpp:2157:11: style:inconclusive: Technically the member function 'Game::debts' can be const. [functionConst]
monopd-0.10.4/src/game.h:104:7: note: Technically the member function 'Game::debts' can be const.
monopd-0.10.4/src/game.cpp:2157:11: note: Technically the member function 'Game::debts' can be const.
monopd-0.10.4/src/game.cpp:1302:12: style:inconclusive: Technically the member function 'Game::pausedForDialog' can be const. [functionConst]
monopd-0.10.4/src/game.h:136:8: note: Technically the member function 'Game::pausedForDialog' can be const.
monopd-0.10.4/src/game.cpp:1302:12: note: Technically the member function 'Game::pausedForDialog' can be const.
monopd-0.10.4/src/game.cpp:645:2: warning: %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
monopd-0.10.4/src/game.cpp:651:3: warning: %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
monopd-0.10.4/src/game.cpp:98:6: style: The scope of the variable 'n' can be reduced. [variableScope]
monopd-0.10.4/src/game.cpp:96:32: style:inconclusive: Function 'ioWrite' argument 1 names different: declaration 'data' definition 'fmt'. [funcArgNamesDifferent]
monopd-0.10.4/src/game.h:47:28: note: Function 'ioWrite' argument 1 names different: declaration 'data' definition 'fmt'.
monopd-0.10.4/src/game.cpp:96:32: note: Function 'ioWrite' argument 1 names different: declaration 'data' definition 'fmt'.
monopd-0.10.4/src/game.cpp:714:30: style:inconclusive: Function 'findDebt' argument 1 names different: declaration 'player' definition 'p'. [funcArgNamesDifferent]
monopd-0.10.4/src/game.h:107:26: note: Function 'findDebt' argument 1 names different: declaration 'player' definition 'p'.
monopd-0.10.4/src/game.cpp:714:30: note: Function 'findDebt' argument 1 names different: declaration 'player' definition 'p'.
monopd-0.10.4/src/game.cpp:724:40: style:inconclusive: Function 'findDebtByCreditor' argument 1 names different: declaration 'player' definition 'p'. [funcArgNamesDifferent]
monopd-0.10.4/src/game.h:108:36: note: Function 'findDebtByCreditor' argument 1 names different: declaration 'player' definition 'p'.
monopd-0.10.4/src/game.cpp:724:40: note: Function 'findDebtByCreditor' argument 1 names different: declaration 'player' definition 'p'.
monopd-0.10.4/src/game.cpp:754:31: style:inconclusive: Function 'solveDebts' argument 1 names different: declaration 'player' definition 'pInput'. [funcArgNamesDifferent]
monopd-0.10.4/src/game.h:110:27: note: Function 'solveDebts' argument 1 names different: declaration 'player' definition 'pInput'.
monopd-0.10.4/src/game.cpp:754:31: note: Function 'solveDebts' argument 1 names different: declaration 'player' definition 'pInput'.
monopd-0.10.4/src/game.cpp:971:32: style:inconclusive: Function 'findTrade' argument 1 names different: declaration 'player' definition '_p'. [funcArgNamesDifferent]
monopd-0.10.4/src/game.h:118:28: note: Function 'findTrade' argument 1 names different: declaration 'player' definition '_p'.
monopd-0.10.4/src/game.cpp:971:32: note: Function 'findTrade' argument 1 names different: declaration 'player' definition '_p'.
monopd-0.10.4/src/game.cpp:1204:30: style:inconclusive: Function 'findEstate' argument 1 names different: declaration 'estateId' definition 'id'. [funcArgNamesDifferent]
monopd-0.10.4/src/game.h:131:26: note: Function 'findEstate' argument 1 names different: declaration 'estateId' definition 'id'.
monopd-0.10.4/src/game.cpp:1204:30: note: Function 'findEstate' argument 1 names different: declaration 'estateId' definition 'id'.
monopd-0.10.4/src/game.cpp:1479:34: style:inconclusive: Function 'kickPlayer' argument 1 names different: declaration 'player' definition 'pInput'. [funcArgNamesDifferent]
monopd-0.10.4/src/game.h:86:30: note: Function 'kickPlayer' argument 1 names different: declaration 'player' definition 'pInput'.
monopd-0.10.4/src/game.cpp:1479:34: note: Function 'kickPlayer' argument 1 names different: declaration 'player' definition 'pInput'.
monopd-0.10.4/src/game.cpp:1503:34: style:inconclusive: Function 'upgradePlayer' argument 1 names different: declaration 'player' definition 'pInput'. [funcArgNamesDifferent]
monopd-0.10.4/src/game.h:87:30: note: Function 'upgradePlayer' argument 1 names different: declaration 'player' definition 'pInput'.
monopd-0.10.4/src/game.cpp:1503:34: note: Function 'upgradePlayer' argument 1 names different: declaration 'player' definition 'pInput'.
monopd-0.10.4/src/game.cpp:1626:80: style:inconclusive: Function 'landPlayer' argument 3 names different: declaration 'rentmath' definition 'rentMath'. [funcArgNamesDifferent]
monopd-0.10.4/src/game.h:91:76: note: Function 'landPlayer' argument 3 names different: declaration 'rentmath' definition 'rentMath'.
monopd-0.10.4/src/game.cpp:1626:80: note: Function 'landPlayer' argument 3 names different: declaration 'rentmath' definition 'rentMath'.
monopd-0.10.4/src/game.cpp:1875:29: style:inconclusive: Function 'giveCard' argument 1 names different: declaration 'player' definition 'pTurn'. [funcArgNamesDifferent]
monopd-0.10.4/src/game.h:92:25: note: Function 'giveCard' argument 1 names different: declaration 'player' definition 'pTurn'.
monopd-0.10.4/src/game.cpp:1875:29: note: Function 'giveCard' argument 1 names different: declaration 'player' definition 'pTurn'.
monopd-0.10.4/src/game.cpp:2017:36: style:inconclusive: Function 'declareBankrupt' argument 1 names different: declaration 'player' definition 'pInput'. [funcArgNamesDifferent]
monopd-0.10.4/src/game.h:93:32: note: Function 'declareBankrupt' argument 1 names different: declaration 'player' definition 'pInput'.
monopd-0.10.4/src/game.cpp:2017:36: note: Function 'declareBankrupt' argument 1 names different: declaration 'player' definition 'pInput'.
monopd-0.10.4/src/game.cpp:2028:35: style:inconclusive: Function 'bankruptPlayer' argument 1 names different: declaration 'player' definition 'pBroke'. [funcArgNamesDifferent]
monopd-0.10.4/src/game.h:94:31: note: Function 'bankruptPlayer' argument 1 names different: declaration 'player' definition 'pBroke'.
monopd-0.10.4/src/game.cpp:2028:35: note: Function 'bankruptPlayer' argument 1 names different: declaration 'player' definition 'pBroke'.
monopd-0.10.4/src/game.cpp:2182:46: style:inconclusive: Function 'sendStatus' argument 2 names different: declaration 'player' definition 'p'. [funcArgNamesDifferent]
monopd-0.10.4/src/game.h:97:42: note: Function 'sendStatus' argument 2 names different: declaration 'player' definition 'p'.
monopd-0.10.4/src/game.cpp:2182:46: note: Function 'sendStatus' argument 2 names different: declaration 'player' definition 'p'.
monopd-0.10.4/src/game.cpp:2208:35: style:inconclusive: Function 'sendEstateList' argument 1 names different: declaration 'player' definition 'p'. [funcArgNamesDifferent]
monopd-0.10.4/src/game.h:98:31: note: Function 'sendEstateList' argument 1 names different: declaration 'player' definition 'p'.
monopd-0.10.4/src/game.cpp:2208:35: note: Function 'sendEstateList' argument 1 names different: declaration 'player' definition 'p'.
monopd-0.10.4/src/game.cpp:2237:40: style:inconclusive: Function 'sendEstateGroupList' argument 1 names different: declaration 'player' definition 'p'. [funcArgNamesDifferent]
monopd-0.10.4/src/game.h:99:36: note: Function 'sendEstateGroupList' argument 1 names different: declaration 'player' definition 'p'.
monopd-0.10.4/src/game.cpp:2237:40: note: Function 'sendEstateGroupList' argument 1 names different: declaration 'player' definition 'p'.
monopd-0.10.4/src/game.cpp:2244:35: style:inconclusive: Function 'sendPlayerList' argument 1 names different: declaration 'player' definition 'pOut'. [funcArgNamesDifferent]
monopd-0.10.4/src/game.h:100:31: note: Function 'sendPlayerList' argument 1 names different: declaration 'player' definition 'pOut'.
monopd-0.10.4/src/game.cpp:2244:35: note: Function 'sendPlayerList' argument 1 names different: declaration 'player' definition 'pOut'.
monopd-0.10.4/src/game.cpp:2261:35: style:inconclusive: Function 'sendFullUpdate' argument 1 names different: declaration 'player' definition 'p'. [funcArgNamesDifferent]
monopd-0.10.4/src/game.h:102:31: note: Function 'sendFullUpdate' argument 1 names different: declaration 'player' definition 'p'.
monopd-0.10.4/src/game.cpp:2261:35: note: Function 'sendFullUpdate' argument 1 names different: declaration 'player' definition 'p'.
monopd-0.10.4/src/game.cpp:2276:38: style:inconclusive: Function 'sendConfiguration' argument 1 names different: declaration 'player' definition 'p'. [funcArgNamesDifferent]
monopd-0.10.4/src/game.h:159:33: note: Function 'sendConfiguration' argument 1 names different: declaration 'player' definition 'p'.
monopd-0.10.4/src/game.cpp:2276:38: note: Function 'sendConfiguration' argument 1 names different: declaration 'player' definition 'p'.
monopd-0.10.4/src/game.cpp:2284:53: style:inconclusive: Function 'sendChildXMLUpdate' argument 2 names different: declaration 'emptyUpdate' definition 'updateEmpty'. [funcArgNamesDifferent]
monopd-0.10.4/src/game.h:80:49: note: Function 'sendChildXMLUpdate' argument 2 names different: declaration 'emptyUpdate' definition 'updateEmpty'.
monopd-0.10.4/src/game.cpp:2284:53: note: Function 'sendChildXMLUpdate' argument 2 names different: declaration 'emptyUpdate' definition 'updateEmpty'.
monopd-0.10.4/src/game.cpp:182:15: style: Local variable 'goEstate' shadows outer function [shadowFunction]
monopd-0.10.4/src/game.h:73:11: note: Shadowed declaration
monopd-0.10.4/src/game.cpp:182:15: note: Shadow variable
monopd-0.10.4/src/game.cpp:770:19: style: Local variable 'debts' shadows outer function [shadowFunction]
monopd-0.10.4/src/game.h:104:7: note: Shadowed declaration
monopd-0.10.4/src/game.cpp:770:19: note: Shadow variable
monopd-0.10.4/src/game.cpp:1910:13: style: Local variable 'display' shadows outer variable [shadowVariable]
monopd-0.10.4/src/game.cpp:1883:10: note: Shadowed declaration
monopd-0.10.4/src/game.cpp:1910:13: note: Shadow variable
monopd-0.10.4/src/game.cpp:1934:13: style: Local variable 'display' shadows outer variable [shadowVariable]
monopd-0.10.4/src/game.cpp:1883:10: note: Shadowed declaration
monopd-0.10.4/src/game.cpp:1934:13: note: Shadow variable
monopd-0.10.4/src/game.cpp:1955:15: style: Local variable 'display' shadows outer variable [shadowVariable]
monopd-0.10.4/src/game.cpp:1883:10: note: Shadowed declaration
monopd-0.10.4/src/game.cpp:1955:15: note: Shadow variable
monopd-0.10.4/src/game.cpp:1987:13: style: Local variable 'display' shadows outer variable [shadowVariable]
monopd-0.10.4/src/game.cpp:1883:10: note: Shadowed declaration
monopd-0.10.4/src/game.cpp:1987:13: note: Shadow variable
monopd-0.10.4/src/game.cpp:2213:15: style: Local variable 'bgColor' shadows outer function [shadowFunction]
monopd-0.10.4/src/game.h:75:21: note: Shadowed declaration
monopd-0.10.4/src/game.cpp:2213:15: note: Shadow variable
monopd-0.10.4/src/game.cpp:129:38: performance: Function parameter 'data' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/game.cpp:149:37: performance: Function parameter 'data' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/game.cpp:154:38: performance: Function parameter 'data' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/game.cpp:1337:49: performance: Function parameter 'name' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/game.cpp:1344:50: performance: Function parameter 'name' should be passed by const reference. [passedByValue]
monopd-0.10.4/src/game.cpp:714:30: style: Parameter 'p' can be declared as pointer to const [constParameterPointer]
monopd-0.10.4/src/game.cpp:724:40: style: Parameter 'p' can be declared as pointer to const [constParameterPointer]
monopd-0.10.4/src/game.cpp:1141:53: style: Parameter 'except' can be declared as pointer to const [constParameterPointer]
monopd-0.10.4/src/game.cpp:1178:49: style: Parameter 'estateGroup' can be declared as pointer to const [constParameterPointer]
monopd-0.10.4/src/game.cpp:1212:43: style: Parameter 'group' can be declared as pointer to const [constParameterPointer]
monopd-0.10.4/src/game.cpp:1212:58: style: Parameter 'startEstate' can be declared as pointer to const [constParameterPointer]
monopd-0.10.4/src/game.cpp:1238:42: style: Parameter 'startEstate' can be declared as pointer to const [constParameterPointer]
monopd-0.10.4/src/game.cpp:571:39: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm]
monopd-0.10.4/src/game.cpp:738:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm]
monopd-0.10.4/src/game.cpp:994:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm]
monopd-0.10.4/src/game.cpp:1230:33: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm]
monopd-0.10.4/src/game.cpp:1256:40: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm]
monopd-0.10.4/src/game.cpp:1348:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm]
monopd-0.10.4/src/game.cpp:1449:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm]
monopd-0.10.4/src/game.cpp:1551:22: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm]
monopd-0.10.4/src/game.cpp:1558:56: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm]
monopd-0.10.4/src/game.cpp:1598:23: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm]
monopd-0.10.4/src/game.cpp:1634:32: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm]
monopd-0.10.4/src/game.cpp:2151:4: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm]
monopd-0.10.4/src/game.cpp:2167:4: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm]
monopd-0.10.4/src/game.cpp:794:20: style: Variable 'eCreditor' is assigned a value that is never used. [unreadVariable]
monopd-0.10.4/src/game.cpp:1151:15: style: Variable 'eTmp' is assigned a value that is never used. [unreadVariable]
monopd-0.10.4/src/game.cpp:1346:23: style: Variable 'cardGroup' is assigned a value that is never used. [unreadVariable]
monopd-0.10.4/src/game.cpp:1356:13: style: Variable 'card' is assigned a value that is never used. [unreadVariable]
monopd-0.10.4/src/game.cpp:1676:17: style: Variable 'pOwner' is assigned a value that is never used. [unreadVariable]
monopd-0.10.4/src/game.cpp:302:116: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
monopd-0.10.4/src/game.cpp:307:107: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
monopd-0.10.4/src/game.cpp:570:54: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
monopd-0.10.4/src/game.cpp:573:4: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
monopd-0.10.4/src/game.cpp:607:3: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
monopd-0.10.4/src/game.cpp:1216:33: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
monopd-0.10.4/src/game.cpp:1222:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
monopd-0.10.4/src/game.cpp:1229:55: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
monopd-0.10.4/src/game.cpp:1242:33: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
monopd-0.10.4/src/game.cpp:1248:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
monopd-0.10.4/src/game.cpp:1255:55: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
monopd-0.10.4/src/game.cpp:1597:53: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
monopd-0.10.4/src/game.cpp:1599:4: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
monopd-0.10.4/src/game.cpp:1615:3: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
monopd-0.10.4/src/game.cpp:1633:55: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
monopd-0.10.4/src/game.cpp:1635:5: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
monopd-0.10.4/src/game.cpp:1662:4: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
monopd-0.10.4/src/game.cpp:1971:108: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
monopd-0.10.4/src/game.cpp:2211:105: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
diff:
head monopd-0.10.4/src/display.cpp:109:28: style:inconclusive: Technically the member function 'Display::text' can be const. [functionConst]
     monopd-0.10.4/src/display.h:50:20: note: Technically the member function 'Display::text' can be const.
     monopd-0.10.4/src/display.cpp:109:28: note: Technically the member function 'Display::text' can be const.
head monopd-0.10.4/src/display.cpp:135:15: style:inconclusive: Technically the member function 'Display::clearButtons' can be const. [functionConst]
     monopd-0.10.4/src/display.h:55:7: note: Technically the member function 'Display::clearButtons' can be const.
     monopd-0.10.4/src/display.cpp:135:15: note: Technically the member function 'Display::clearButtons' can be const.
head monopd-0.10.4/src/display.cpp:140:15: style:inconclusive: Technically the member function 'Display::clearText' can be const. [functionConst]
     monopd-0.10.4/src/display.h:56:7: note: Technically the member function 'Display::clearText' can be const.
     monopd-0.10.4/src/display.cpp:140:15: note: Technically the member function 'Display::clearText' can be const.
head monopd-0.10.4/src/display.cpp:145:15: style:inconclusive: Technically the member function 'Display::clearEstate' can be const. [functionConst]
     monopd-0.10.4/src/display.h:57:7: note: Technically the member function 'Display::clearEstate' can be const.
     monopd-0.10.4/src/display.cpp:145:15: note: Technically the member function 'Display::clearEstate' can be const.
head monopd-0.10.4/src/display.cpp:40:34: style:inconclusive: Technically the member function 'DisplayButton::command' can be const. [functionConst]
     monopd-0.10.4/src/display.h:30:20: note: Technically the member function 'DisplayButton::command' can be const.
     monopd-0.10.4/src/display.cpp:40:34: note: Technically the member function 'DisplayButton::command' can be const.
head monopd-0.10.4/src/display.cpp:45:34: style:inconclusive: Technically the member function 'DisplayButton::caption' can be const. [functionConst]
     monopd-0.10.4/src/display.h:31:20: note: Technically the member function 'DisplayButton::caption' can be const.
     monopd-0.10.4/src/display.cpp:45:34: note: Technically the member function 'DisplayButton::caption' can be const.
head monopd-0.10.4/src/display.cpp:50:21: style:inconclusive: Technically the member function 'DisplayButton::enabled' can be const. [functionConst]
     monopd-0.10.4/src/display.h:32:7: note: Technically the member function 'DisplayButton::enabled' can be const.
     monopd-0.10.4/src/display.cpp:50:21: note: Technically the member function 'DisplayButton::enabled' can be const.
2.17.0 monopd-0.10.4/src/display.h:30:20: style:inconclusive: Technically the member function 'DisplayButton::command' can be const. [functionConst]
     monopd-0.10.4/src/display.cpp:40:34: note: Technically the member function 'DisplayButton::command' can be const.
     monopd-0.10.4/src/display.h:30:20: note: Technically the member function 'DisplayButton::command' can be const.
2.17.0 monopd-0.10.4/src/display.h:31:20: style:inconclusive: Technically the member function 'DisplayButton::caption' can be const. [functionConst]
     monopd-0.10.4/src/display.cpp:45:34: note: Technically the member function 'DisplayButton::caption' can be const.
     monopd-0.10.4/src/display.h:31:20: note: Technically the member function 'DisplayButton::caption' can be const.
2.17.0 monopd-0.10.4/src/display.h:32:7: style:inconclusive: Technically the member function 'DisplayButton::enabled' can be const. [functionConst]
     monopd-0.10.4/src/display.cpp:50:21: note: Technically the member function 'DisplayButton::enabled' can be const.
     monopd-0.10.4/src/display.h:32:7: note: Technically the member function 'DisplayButton::enabled' can be const.
2.17.0 monopd-0.10.4/src/display.h:50:20: style:inconclusive: Technically the member function 'Display::text' can be const. [functionConst]
     monopd-0.10.4/src/display.cpp:109:28: note: Technically the member function 'Display::text' can be const.
     monopd-0.10.4/src/display.h:50:20: note: Technically the member function 'Display::text' can be const.
2.17.0 monopd-0.10.4/src/display.h:55:7: style:inconclusive: Technically the member function 'Display::clearButtons' can be const. [functionConst]
     monopd-0.10.4/src/display.cpp:135:15: note: Technically the member function 'Display::clearButtons' can be const.
     monopd-0.10.4/src/display.h:55:7: note: Technically the member function 'Display::clearButtons' can be const.
2.17.0 monopd-0.10.4/src/display.h:56:7: style:inconclusive: Technically the member function 'Display::clearText' can be const. [functionConst]
     monopd-0.10.4/src/display.cpp:140:15: note: Technically the member function 'Display::clearText' can be const.
     monopd-0.10.4/src/display.h:56:7: note: Technically the member function 'Display::clearText' can be const.
2.17.0 monopd-0.10.4/src/display.h:57:7: style:inconclusive: Technically the member function 'Display::clearEstate' can be const. [functionConst]
     monopd-0.10.4/src/display.cpp:145:15: note: Technically the member function 'Display::clearEstate' can be const.
     monopd-0.10.4/src/display.h:57:7: note: Technically the member function 'Display::clearEstate' can be const.
head monopd-0.10.4/src/estategroup.cpp:43:27: style:inconclusive: Technically the member function 'EstateGroup::price' can be const. [functionConst]
     monopd-0.10.4/src/estategroup.h:33:15: note: Technically the member function 'EstateGroup::price' can be const.
     monopd-0.10.4/src/estategroup.cpp:43:27: note: Technically the member function 'EstateGroup::price' can be const.
head monopd-0.10.4/src/estategroup.cpp:54:27: style:inconclusive: Technically the member function 'EstateGroup::housePrice' can be const. [functionConst]
     monopd-0.10.4/src/estategroup.h:35:15: note: Technically the member function 'EstateGroup::housePrice' can be const.
     monopd-0.10.4/src/estategroup.cpp:54:27: note: Technically the member function 'EstateGroup::housePrice' can be const.
head monopd-0.10.4/src/estategroup.cpp:71:18: style:inconclusive: Technically the member function 'EstateGroup::rent' can be const. [functionConst]
     monopd-0.10.4/src/estategroup.h:38:6: note: Technically the member function 'EstateGroup::rent' can be const.
     monopd-0.10.4/src/estategroup.cpp:71:18: note: Technically the member function 'EstateGroup::rent' can be const.
2.17.0 monopd-0.10.4/src/estategroup.h:33:15: style:inconclusive: Technically the member function 'EstateGroup::price' can be const. [functionConst]
     monopd-0.10.4/src/estategroup.cpp:43:27: note: Technically the member function 'EstateGroup::price' can be const.
     monopd-0.10.4/src/estategroup.h:33:15: note: Technically the member function 'EstateGroup::price' can be const.
2.17.0 monopd-0.10.4/src/estategroup.h:35:15: style:inconclusive: Technically the member function 'EstateGroup::housePrice' can be const. [functionConst]
     monopd-0.10.4/src/estategroup.cpp:54:27: note: Technically the member function 'EstateGroup::housePrice' can be const.
     monopd-0.10.4/src/estategroup.h:35:15: note: Technically the member function 'EstateGroup::housePrice' can be const.
2.17.0 monopd-0.10.4/src/estategroup.h:38:6: style:inconclusive: Technically the member function 'EstateGroup::rent' can be const. [functionConst]
     monopd-0.10.4/src/estategroup.cpp:71:18: note: Technically the member function 'EstateGroup::rent' can be const.
     monopd-0.10.4/src/estategroup.h:38:6: note: Technically the member function 'EstateGroup::rent' can be const.
head monopd-0.10.4/src/game.cpp:1302:12: style:inconclusive: Technically the member function 'Game::pausedForDialog' can be const. [functionConst]
     monopd-0.10.4/src/game.h:136:8: note: Technically the member function 'Game::pausedForDialog' can be const.
     monopd-0.10.4/src/game.cpp:1302:12: note: Technically the member function 'Game::pausedForDialog' can be const.
head monopd-0.10.4/src/game.cpp:2157:11: style:inconclusive: Technically the member function 'Game::debts' can be const. [functionConst]
     monopd-0.10.4/src/game.h:104:7: note: Technically the member function 'Game::debts' can be const.
     monopd-0.10.4/src/game.cpp:2157:11: note: Technically the member function 'Game::debts' can be const.
2.17.0 monopd-0.10.4/src/game.h:104:7: style:inconclusive: Technically the member function 'Game::debts' can be const. [functionConst]
     monopd-0.10.4/src/game.cpp:2157:11: note: Technically the member function 'Game::debts' can be const.
     monopd-0.10.4/src/game.h:104:7: note: Technically the member function 'Game::debts' can be const.
2.17.0 monopd-0.10.4/src/game.h:136:8: style:inconclusive: Technically the member function 'Game::pausedForDialog' can be const. [functionConst]
     monopd-0.10.4/src/game.cpp:1302:12: note: Technically the member function 'Game::pausedForDialog' can be const.
     monopd-0.10.4/src/game.h:136:8: note: Technically the member function 'Game::pausedForDialog' can be const.
head monopd-0.10.4/src/gameobject.cpp:41:17: style:inconclusive: Technically the member function 'GameObject::id' can be const. [functionConst]
     monopd-0.10.4/src/gameobject.h:40:6: note: Technically the member function 'GameObject::id' can be const.
     monopd-0.10.4/src/gameobject.cpp:41:17: note: Technically the member function 'GameObject::id' can be const.
head monopd-0.10.4/src/gameobject.cpp:51:35: style:inconclusive: Technically the member function 'GameObject::type' can be const. [functionConst]
     monopd-0.10.4/src/gameobject.h:42:12: note: Technically the member function 'GameObject::type' can be const.
     monopd-0.10.4/src/gameobject.cpp:51:35: note: Technically the member function 'GameObject::type' can be const.
2.17.0 monopd-0.10.4/src/gameobject.h:40:6: style:inconclusive: Technically the member function 'GameObject::id' can be const. [functionConst]
     monopd-0.10.4/src/gameobject.cpp:41:17: note: Technically the member function 'GameObject::id' can be const.
     monopd-0.10.4/src/gameobject.h:40:6: note: Technically the member function 'GameObject::id' can be const.
2.17.0 monopd-0.10.4/src/gameobject.h:42:12: style:inconclusive: Technically the member function 'GameObject::type' can be const. [functionConst]
     monopd-0.10.4/src/gameobject.cpp:51:35: note: Technically the member function 'GameObject::type' can be const.
     monopd-0.10.4/src/gameobject.h:42:12: note: Technically the member function 'GameObject::type' can be const.
head monopd-0.10.4/src/gameproperty.cpp:65:22: style:inconclusive: Technically the member function 'GameIntProperty::value' can be const. [functionConst]
     monopd-0.10.4/src/gameproperty.h:45:6: note: Technically the member function 'GameIntProperty::value' can be const.
     monopd-0.10.4/src/gameproperty.cpp:65:22: note: Technically the member function 'GameIntProperty::value' can be const.
2.17.0 monopd-0.10.4/src/gameproperty.h:45:6: style:inconclusive: Technically the member function 'GameIntProperty::value' can be const. [functionConst]
     monopd-0.10.4/src/gameproperty.cpp:65:22: note: Technically the member function 'GameIntProperty::value' can be const.
     monopd-0.10.4/src/gameproperty.h:45:6: note: Technically the member function 'GameIntProperty::value' can be const.
head monopd-0.10.4/src/listener.cpp:272:42: style: C-style pointer casting [cstyleCast]
2.17.0 monopd-0.10.4/src/listener.cpp:272:43: style: C-style pointer casting [cstyleCast]
head monopd-0.10.4/src/listener.cpp:274:42: style: C-style pointer casting [cstyleCast]
2.17.0 monopd-0.10.4/src/listener.cpp:274:43: style: C-style pointer casting [cstyleCast]
head monopd-0.10.4/src/listener.cpp:312:28: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast]
2.17.0 monopd-0.10.4/src/listener.cpp:312:29: style: C-style pointer casting [cstyleCast]
head monopd-0.10.4/src/listener.cpp:312:61: style: C-style pointer casting [cstyleCast]
head monopd-0.10.4/src/listener.cpp:323:38: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast]
2.17.0 monopd-0.10.4/src/listener.cpp:323:39: style: C-style pointer casting [cstyleCast]
head monopd-0.10.4/src/listener.cpp:326:38: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast]
2.17.0 monopd-0.10.4/src/listener.cpp:326:39: style: C-style pointer casting [cstyleCast]
head monopd-0.10.4/src/listener.cpp:378:38: style: C-style pointer casting [cstyleCast]
2.17.0 monopd-0.10.4/src/listener.cpp:378:39: style: C-style pointer casting [cstyleCast]
head monopd-0.10.4/src/listener.cpp:380:38: style: C-style pointer casting [cstyleCast]
2.17.0 monopd-0.10.4/src/listener.cpp:380:39: style: C-style pointer casting [cstyleCast]
head monopd-0.10.4/src/listenport.cpp:54:37: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast]
2.17.0 monopd-0.10.4/src/listenport.cpp:54:38: style: C-style pointer casting [cstyleCast]
head monopd-0.10.4/src/listenport.cpp:59:39: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast]
2.17.0 monopd-0.10.4/src/listenport.cpp:59:40: style: C-style pointer casting [cstyleCast]
head monopd-0.10.4/src/listenport.cpp:78:18: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast]
2.17.0 monopd-0.10.4/src/listenport.cpp:78:19: style: C-style pointer casting [cstyleCast]
head monopd-0.10.4/src/socket.cpp:110:14: style:inconclusive: Technically the member function 'Socket::hasReadLine' can be const. [functionConst]
     monopd-0.10.4/src/socket.h:45:7: note: Technically the member function 'Socket::hasReadLine' can be const.
     monopd-0.10.4/src/socket.cpp:110:14: note: Technically the member function 'Socket::hasReadLine' can be const.
2.17.0 monopd-0.10.4/src/socket.h:45:7: style:inconclusive: Technically the member function 'Socket::hasReadLine' can be const. [functionConst]
     monopd-0.10.4/src/socket.cpp:110:14: note: Technically the member function 'Socket::hasReadLine' can be const.
     monopd-0.10.4/src/socket.h:45:7: note: Technically the member function 'Socket::hasReadLine' can be const.


DONE