2025-09-01 19:20 ftp://ftp.de.debian.org/debian/pool/main/m/modem-manager-gui/modem-manager-gui_0.0.20.orig.tar.gz cppcheck-options: --library=posix --library=gnu --library=bsd --library=gtk --inconclusive --enable=style,information --inline-suppr --template=daca2 --disable=missingInclude --suppress=unmatchedSuppression --check-library --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=normalCheckLevelConditionExpressions -D__GNUC__ --platform=unix64 -j4 platform: Linux-6.12.41+deb13-amd64-x86_64-with-glibc2.41 python: 3.13.5 client-version: 1.3.67 compiler: g++ (Debian 14.2.0-19) 14.2.0 cppcheck: head 2.18.0 head-info: 2b51b48 (2025-09-01 15:35:55 +0200) count: 104 382 elapsed-time: 3.0 7.3 head-timing-info: old-timing-info: head results: modem-manager-gui/src/mmguicore.h:575:0: error: failed to evaluate #if condition, undefined function-like macro invocation: GLIB_CHECK_VERSION( ... ) [preprocessorErrorDirective] modem-manager-gui/src/mmguicore.h:575:3: error: failed to evaluate #if condition, undefined function-like macro invocation: GLIB_CHECK_VERSION( ... ) [preprocessorErrorDirective] modem-manager-gui/src/ayatana.c:108:118: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RESOURCE_DESKTOP_FILE [valueFlowBailoutIncompleteVar] modem-manager-gui/src/ayatana.c:180:109: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_MODULE_BIND_LAZY [valueFlowBailoutIncompleteVar] modem-manager-gui/src/ayatana.c:302:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RESOURCE_SYMBOLIC_ICONS_DIR [valueFlowBailoutIncompleteVar] modem-manager-gui/src/dbus-utils.c:30:59: style: Parameter 'interface' can be declared as pointer to const [constParameterPointer] modem-manager-gui/src/libpaths.c:96:82: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_KEY_FILE_NONE [valueFlowBailoutIncompleteVar] modem-manager-gui/src/libpaths.c:325:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_FILE_TEST_IS_SYMLINK [valueFlowBailoutIncompleteVar] modem-manager-gui/src/libpaths.c:483:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable O_RDONLY [valueFlowBailoutIncompleteVar] modem-manager-gui/src/ayatana.c:93:26: style: Unsigned expression 'sym' can't be negative so it is unnecessary to test it. [unsignedPositive] modem-manager-gui/src/libpaths.c:378:11: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] modem-manager-gui/src/libpaths.c:387:12: portability: Non reentrant function 'strtok' called. For threadsafe applications it is recommended to use the reentrant replacement function 'strtok_r'. [prohibitedstrtokCalled] modem-manager-gui/src/libpaths.c:299:9: style: Variable 'pathendptr' can be declared as pointer to const [constVariablePointer] modem-manager-gui/src/libpaths.c:306:9: style: Variable 'token' can be declared as pointer to const [constVariablePointer] modem-manager-gui/src/libpaths.c:434:11: style: Variable 'entry' is assigned a value that is never used. [unreadVariable] modem-manager-gui/src/modules/historyshm.c:57:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDBM_READER [valueFlowBailoutIncompleteVar] modem-manager-gui/src/modules/historyshm.c:96:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable O_RDWR [valueFlowBailoutIncompleteVar] modem-manager-gui/src/netlink.c:658:16: debug: Scope::checkVariable found variable 'value' with varid 0. [varid0] modem-manager-gui/src/notifications.c:42:113: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_MODULE_BIND_LAZY [valueFlowBailoutIncompleteVar] modem-manager-gui/src/notifications.c:113:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RESOURCE_SOUNDS_DIR [valueFlowBailoutIncompleteVar] modem-manager-gui/src/netlink.c:75:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PATH_MAX [valueFlowBailoutIncompleteVar] modem-manager-gui/src/netlink.c:97:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PATH_MAX [valueFlowBailoutIncompleteVar] modem-manager-gui/src/netlink.c:120:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PATH_MAX [valueFlowBailoutIncompleteVar] modem-manager-gui/src/netlink.c:163:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PATH_MAX [valueFlowBailoutIncompleteVar] modem-manager-gui/src/netlink.c:280:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AF_INET [valueFlowBailoutIncompleteVar] modem-manager-gui/src/netlink.c:312:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable INET6_ADDRSTRLEN [valueFlowBailoutIncompleteVar] modem-manager-gui/src/netlink.c:412:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable errno [valueFlowBailoutIncompleteVar] modem-manager-gui/src/netlink.c:446:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IFNAMSIZ [valueFlowBailoutIncompleteVar] modem-manager-gui/src/netlink.c:658:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable value [valueFlowBailoutIncompleteVar] modem-manager-gui/src/netlink.c:756:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sockaddr_nl [valueFlowBailoutIncompleteVar] modem-manager-gui/src/modules/historyshm.c:168:88: style: Redundant condition: client->shmaddr->synctime!=0. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] modem-manager-gui/src/modules/historyshm.c:113:8: warning: If memory allocation fails, then there is a possible null pointer dereference: client->shmaddr [nullPointerOutOfMemory] modem-manager-gui/src/modules/historyshm.c:104:45: note: Assuming allocation function fails modem-manager-gui/src/modules/historyshm.c:104:20: note: Assignment 'client->shmaddr=(struct _mmgui_history_shmmmgui_history_shm_t)mmap(0,sizeof(struct _mmgui_history_shm),PROT_WRITE|PROT_READ,MAP_SHARED,client->shmid,0)', assigned value is 0 modem-manager-gui/src/modules/historyshm.c:113:8: note: Null pointer dereference modem-manager-gui/src/modules/historyshm.c:129:8: warning: Either the condition 'client->shmaddr!=NULL' is redundant or there is possible null pointer dereference: client->shmaddr. [nullPointerRedundantCheck] modem-manager-gui/src/modules/historyshm.c:132:22: note: Assuming that condition 'client->shmaddr!=NULL' is not redundant modem-manager-gui/src/modules/historyshm.c:129:8: note: Null pointer dereference modem-manager-gui/src/modules/historyshm.c:223:71: style: Parameter 'context' can be declared as pointer to const. However it seems that 'mmgui_history_client_xml_get_element' is a callback function, if 'context' is declared with const you might also need to cast function pointer(s). [constParameterCallback] modem-manager-gui/src/modules/historyshm.c:203:21: note: You might need to cast the function pointer here modem-manager-gui/src/modules/historyshm.c:223:71: note: Parameter 'context' can be declared as pointer to const modem-manager-gui/src/modules/historyshm.c:223:164: style: Parameter 'data' can be declared as pointer to const. However it seems that 'mmgui_history_client_xml_get_element' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] modem-manager-gui/src/modules/historyshm.c:203:21: note: You might need to cast the function pointer here modem-manager-gui/src/modules/historyshm.c:223:164: note: Parameter 'data' can be declared as pointer to const modem-manager-gui/src/modules/historyshm.c:284:71: style: Parameter 'context' can be declared as pointer to const. However it seems that 'mmgui_history_client_xml_end_element' is a callback function, if 'context' is declared with const you might also need to cast function pointer(s). [constParameterCallback] modem-manager-gui/src/modules/historyshm.c:204:19: note: You might need to cast the function pointer here modem-manager-gui/src/modules/historyshm.c:284:71: note: Parameter 'context' can be declared as pointer to const modem-manager-gui/src/modules/historyshm.c:284:111: style: Parameter 'data' can be declared as pointer to const. However it seems that 'mmgui_history_client_xml_end_element' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] modem-manager-gui/src/modules/historyshm.c:204:19: note: You might need to cast the function pointer here modem-manager-gui/src/modules/historyshm.c:284:111: note: Parameter 'data' can be declared as pointer to const modem-manager-gui/src/modules/historyshm.c:293:9: style: Variable 'drvstr' can be declared as pointer to const [constVariablePointer] modem-manager-gui/src/modules/historyshm.c:293:18: style: Variable 'timestr' can be declared as pointer to const [constVariablePointer] modem-manager-gui/src/plugins/ofonohistory.c:419:32: error: There is an unknown macro here somewhere. Configuration is required. If G_GUINT64_FORMAT is a macro then please configure it. [unknownMacro] modem-manager-gui/src/notifications.c:34:24: style: Variable 'iterator' can be declared as pointer to const [constVariablePointer] modem-manager-gui/src/polkit.c:365:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_DBUS_CALL_FLAGS_NONE [valueFlowBailoutIncompleteVar] modem-manager-gui/src/polkit.c:401:8: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_DBUS_CALL_FLAGS_NONE [valueFlowBailoutIncompleteVar] modem-manager-gui/src/polkit.c:375:3: error: Memory leak: requestsubject [memleak] modem-manager-gui/src/polkit.c:375:3: error: Memory leak: requestdetails [memleak] modem-manager-gui/src/polkit.c:381:2: error: Memory leak: requestsubject [memleak] modem-manager-gui/src/polkit.c:381:2: error: Memory leak: requestdetails [memleak] modem-manager-gui/src/polkit.c:117:9: style: Variable 'locale' can be declared as pointer to const [constVariablePointer] modem-manager-gui/src/polkit.c:319:12: style: Variable 'variant' can be declared as pointer to const [constVariablePointer] modem-manager-gui/src/polkit.c:322:12: style: Variable 'requestsubject' can be declared as pointer to const [constVariablePointer] modem-manager-gui/src/polkit.c:323:12: style: Variable 'requestdetails' can be declared as pointer to const [constVariablePointer] modem-manager-gui/src/polkit.c:39:9: style: Unused variable: statfilecontptr [unusedVariable] modem-manager-gui/src/settings.c:28:53: style: Parameter 'filename' can be declared as pointer to const [constParameterPointer] modem-manager-gui/src/netlink.c:287:57: style: Operator '|' with one operand equal to zero is redundant. [badBitmaskCheck] modem-manager-gui/src/netlink.c:420:57: style: Operator '|' with one operand equal to zero is redundant. [badBitmaskCheck] modem-manager-gui/src/netlink.c:758:55: style: Operator '|' with one operand equal to zero is redundant. [badBitmaskCheck] modem-manager-gui/src/netlink.c:775:54: style: Operator '|' with one operand equal to zero is redundant. [badBitmaskCheck] modem-manager-gui/src/netlink.c:58:51: style: Parameter 'dirname' can be declared as pointer to const [constParameterPointer] modem-manager-gui/src/netlink.c:95:52: style: Parameter 'dirname' can be declared as pointer to const [constParameterPointer] modem-manager-gui/src/netlink.c:117:49: style: Parameter 'dirname' can be declared as pointer to const [constParameterPointer] modem-manager-gui/src/netlink.c:444:26: style: Variable 'ifstats' can be declared as pointer to const [constVariablePointer] modem-manager-gui/src/netlink.c:445:28: style: Variable 'ifstats64' can be declared as pointer to const [constVariablePointer] modem-manager-gui/src/smsdb.c:77:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_FILE_TEST_IS_DIR [valueFlowBailoutIncompleteVar] modem-manager-gui/src/smsdb.c:461:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDBM_WRCREAT [valueFlowBailoutIncompleteVar] modem-manager-gui/src/smsdb.c:552:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDBM_READER [valueFlowBailoutIncompleteVar] modem-manager-gui/src/smsdb.c:634:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDBM_READER [valueFlowBailoutIncompleteVar] modem-manager-gui/src/smsdb.c:669:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDBM_WRCREAT [valueFlowBailoutIncompleteVar] modem-manager-gui/src/smsdb.c:726:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GDBM_WRITER [valueFlowBailoutIncompleteVar] modem-manager-gui/src/svcmanager.c:603:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_DBUS_CALL_FLAGS_NONE [valueFlowBailoutIncompleteVar] modem-manager-gui/src/svcmanager.c:634:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_SOURCE_REMOVE [valueFlowBailoutIncompleteVar] modem-manager-gui/src/svcmanager.c:796:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_DBUS_CALL_FLAGS_NONE [valueFlowBailoutIncompleteVar] modem-manager-gui/src/trafficdb.c:689:45: error: There is an unknown macro here somewhere. Configuration is required. If G_GUINT64_FORMAT is a macro then please configure it. [unknownMacro] modem-manager-gui/src/ussdlist.c:63:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_FILE_TEST_IS_DIR [valueFlowBailoutIncompleteVar] modem-manager-gui/src/ussdlist.c:193:2: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] modem-manager-gui/src/svcmanager.c:219:5: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] modem-manager-gui/src/svcmanager.c:219:5: warning: %u in format string (no. 3) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] modem-manager-gui/src/svcmanager.c:219:5: warning: %u in format string (no. 4) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] modem-manager-gui/src/svcmanager.c:259:7: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] modem-manager-gui/src/svcmanager.c:262:7: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] modem-manager-gui/src/svcmanager.c:757:4: warning: %u in format string (no. 3) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] modem-manager-gui/src/svcmanager.c:767:4: warning: %u in format string (no. 3) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] modem-manager-gui/src/svcmanager.c:838:4: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] modem-manager-gui/src/svcmanager.c:610:3: error: Mismatching allocation and deallocation: services [mismatchAllocDealloc] modem-manager-gui/src/svcmanager.c:592:13: note: Mismatching allocation and deallocation: services modem-manager-gui/src/svcmanager.c:610:3: note: Mismatching allocation and deallocation: services modem-manager-gui/src/svcmanager.c:622:2: error: Mismatching allocation and deallocation: services [mismatchAllocDealloc] modem-manager-gui/src/svcmanager.c:592:13: note: Mismatching allocation and deallocation: services modem-manager-gui/src/svcmanager.c:622:2: note: Mismatching allocation and deallocation: services modem-manager-gui/src/smsdb.c:492:11: warning: %u in format string (no. 3) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] modem-manager-gui/src/smsdb.c:492:11: warning: %u in format string (no. 6) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] modem-manager-gui/src/smsdb.c:763:22: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] modem-manager-gui/src/smsdb.c:763:22: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] modem-manager-gui/src/smsdb.c:826:3: error: Memory leak: message [memleak] modem-manager-gui/src/smsdb.c:598:6: warning: Either the condition 'data!=NULL' is redundant or there is possible null pointer dereference: message. [nullPointerRedundantCheck] modem-manager-gui/src/smsdb.c:594:11: note: Assuming that condition 'data!=NULL' is not redundant modem-manager-gui/src/smsdb.c:596:10: note: message is assigned '(struct _mmgui_sms_messagemmgui_sms_message_t)data' here. modem-manager-gui/src/smsdb.c:598:6: note: Null pointer dereference modem-manager-gui/src/smsdb.c:599:10: warning: Either the condition 'data!=NULL' is redundant or there is possible null pointer dereference: message. [nullPointerRedundantCheck] modem-manager-gui/src/smsdb.c:594:11: note: Assuming that condition 'data!=NULL' is not redundant modem-manager-gui/src/smsdb.c:596:10: note: message is assigned '(struct _mmgui_sms_messagemmgui_sms_message_t)data' here. modem-manager-gui/src/smsdb.c:599:10: note: Null pointer dereference modem-manager-gui/src/smsdb.c:602:6: warning: Either the condition 'data!=NULL' is redundant or there is possible null pointer dereference: message. [nullPointerRedundantCheck] modem-manager-gui/src/smsdb.c:594:11: note: Assuming that condition 'data!=NULL' is not redundant modem-manager-gui/src/smsdb.c:596:10: note: message is assigned '(struct _mmgui_sms_messagemmgui_sms_message_t)data' here. modem-manager-gui/src/smsdb.c:602:6: note: Null pointer dereference modem-manager-gui/src/smsdb.c:603:10: warning: Either the condition 'data!=NULL' is redundant or there is possible null pointer dereference: message. [nullPointerRedundantCheck] modem-manager-gui/src/smsdb.c:594:11: note: Assuming that condition 'data!=NULL' is not redundant modem-manager-gui/src/smsdb.c:596:10: note: message is assigned '(struct _mmgui_sms_messagemmgui_sms_message_t)data' here. modem-manager-gui/src/smsdb.c:603:10: note: Null pointer dereference modem-manager-gui/src/smsdb.c:606:6: warning: Either the condition 'data!=NULL' is redundant or there is possible null pointer dereference: message. [nullPointerRedundantCheck] modem-manager-gui/src/smsdb.c:594:11: note: Assuming that condition 'data!=NULL' is not redundant modem-manager-gui/src/smsdb.c:596:10: note: message is assigned '(struct _mmgui_sms_messagemmgui_sms_message_t)data' here. modem-manager-gui/src/smsdb.c:606:6: note: Null pointer dereference modem-manager-gui/src/smsdb.c:607:16: warning: Either the condition 'data!=NULL' is redundant or there is possible null pointer dereference: message. [nullPointerRedundantCheck] modem-manager-gui/src/smsdb.c:594:11: note: Assuming that condition 'data!=NULL' is not redundant modem-manager-gui/src/smsdb.c:596:10: note: message is assigned '(struct _mmgui_sms_messagemmgui_sms_message_t)data' here. modem-manager-gui/src/smsdb.c:607:16: note: Null pointer dereference modem-manager-gui/src/smsdb.c:610:6: warning:inconclusive: Either the condition 'data!=NULL' is redundant or there is possible null pointer dereference: message. [nullPointerRedundantCheck] modem-manager-gui/src/smsdb.c:594:11: note: Assuming that condition 'data!=NULL' is not redundant modem-manager-gui/src/smsdb.c:596:12: note: Assignment 'message=(struct _mmgui_sms_messagemmgui_sms_message_t)data', assigned value is 0 modem-manager-gui/src/smsdb.c:610:6: note: Null pointer dereference modem-manager-gui/src/smsdb.c:664:9: style: Variable 'node' can be declared as pointer to const [constVariablePointer] modem-manager-gui/src/smsdb.c:833:62: style: Parameter 'context' can be declared as pointer to const. However it seems that 'mmgui_smsdb_xml_get_element' is a callback function, if 'context' is declared with const you might also need to cast function pointer(s). [constParameterCallback] modem-manager-gui/src/smsdb.c:814:21: note: You might need to cast the function pointer here modem-manager-gui/src/smsdb.c:833:62: note: Parameter 'context' can be declared as pointer to const modem-manager-gui/src/smsdb.c:833:155: style: Parameter 'data' can be declared as pointer to const. However it seems that 'mmgui_smsdb_xml_get_element' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] modem-manager-gui/src/smsdb.c:814:21: note: You might need to cast the function pointer here modem-manager-gui/src/smsdb.c:833:155: note: Parameter 'data' can be declared as pointer to const modem-manager-gui/src/smsdb.c:909:62: style: Parameter 'context' can be declared as pointer to const. However it seems that 'mmgui_smsdb_xml_end_element' is a callback function, if 'context' is declared with const you might also need to cast function pointer(s). [constParameterCallback] modem-manager-gui/src/smsdb.c:815:19: note: You might need to cast the function pointer here modem-manager-gui/src/smsdb.c:909:62: note: Parameter 'context' can be declared as pointer to const modem-manager-gui/src/smsdb.c:909:102: style: Parameter 'data' can be declared as pointer to const. However it seems that 'mmgui_smsdb_xml_end_element' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] modem-manager-gui/src/smsdb.c:815:19: note: You might need to cast the function pointer here modem-manager-gui/src/smsdb.c:909:102: note: Parameter 'data' can be declared as pointer to const modem-manager-gui/src/encoding.c:217:22: style: Redundant condition: input!=NULL. 'input==NULL || (input!=NULL && input[0]=='\0')' is equivalent to 'input==NULL || input[0]=='\0'' [redundantCondition] modem-manager-gui/src/encoding.c:462:78: style: Same expression on both sides of '&'. [duplicateExpression] modem-manager-gui/src/encoding.c:814:9: style: Variable 'newlen' is assigned a value that is never used. [unreadVariable] diff: 2.18.0 modem-manager-gui/src/addressbooks.c:164:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sockaddr_un [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/addressbooks.c:295:70: style: Parameter 'status' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/addressbooks.c:338:8: style: Variable 'bytes' is assigned a value that is never used. [unreadVariable] 2.18.0 modem-manager-gui/src/addressbooks.c:344:10: style: Variable 'bytes' is assigned a value that is never used. [unreadVariable] 2.18.0 modem-manager-gui/src/addressbooks.c:370:16: style: Condition 'res!=0' is always true [knownConditionTrueFalse] modem-manager-gui/src/addressbooks.c:343:11: note: Assuming that condition 'res>0' is not redundant modem-manager-gui/src/addressbooks.c:370:16: note: Condition 'res!=0' is always true 2.18.0 modem-manager-gui/src/addressbooks.c:375:88: style: Parameter 'suffix' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/addressbooks.c:377:17: style: Variable 'end' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/addressbooks.c:428:91: style: Parameter 'suffix' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/addressbooks.c:430:17: style: Variable 'end' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/addressbooks.c:461:109: style: Parameter 'substring' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/addressbooks.c:461:94: style: Parameter 'suffix' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/addressbooks.c:463:17: style: Variable 'end' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/addressbooks.c:581:9: warning: Uninitialized variable: vcardnum [uninitvar] modem-manager-gui/src/addressbooks.c:569:16: note: Assuming condition is false modem-manager-gui/src/addressbooks.c:581:9: note: Uninitialized variable: vcardnum 2.18.0 modem-manager-gui/src/addressbooks.c:985:116: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_MODULE_BIND_LAZY [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/connection-editor-window.c:1103:21: style: Variable 'langenv' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/connection-editor-window.c:1103:9: style: Variable 'countryid' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/connection-editor-window.c:1126:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable _NL_ADDRESS_COUNTRY_AB2 [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/connection-editor-window.c:164:9: style: Variable 'extext' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/connection-editor-window.c:175:48: style: Redundant condition: text[i]=='.'. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/connection-editor-window.c:40:9: style: Variable 'extext' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/connection-editor-window.c:51:48: style: Redundant condition: text[i]=='.'. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/contacts-page.c:168:9: style: Variable 'number' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/devices-page.c:162:2: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] 2.18.0 modem-manager-gui/src/devices-page.c:187:2: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] 2.18.0 modem-manager-gui/src/devices-page.c:215:2: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] 2.18.0 modem-manager-gui/src/devices-page.c:382:9: style: Variable 'devtype' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/devices-page.c:501:14: style: Condition 'uuid!=NULL' is always true [knownConditionTrueFalse] 2.18.0 modem-manager-gui/src/devices-page.c:536:14: style: Condition 'uuid!=NULL' is always true [knownConditionTrueFalse] 2.18.0 modem-manager-gui/src/devices-page.c:620:14: style: Condition 'uuid!=NULL' is always true [knownConditionTrueFalse] 2.18.0 modem-manager-gui/src/main.c:1111:2: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] 2.18.0 modem-manager-gui/src/main.c:1111:2: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] 2.18.0 modem-manager-gui/src/main.c:1111:2: warning: %u in format string (no. 3) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] 2.18.0 modem-manager-gui/src/main.c:1111:2: warning: %u in format string (no. 4) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] 2.18.0 modem-manager-gui/src/main.c:1762:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_DIALOG_MODAL [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/main.c:1895:39: style: Redundant condition: device->operatorname!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/main.c:2117:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_BUTTONS_OK [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/main.c:2133:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_SOURCE_REMOVE [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/main.c:2276:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_DIR_SEPARATOR_S [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/main.c:2587:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RESOURCE_UI_DIR [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/main.c:2763:111: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] 2.18.0 modem-manager-gui/src/main.c:2827:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RESOURCE_LOCALE_DOMAIN [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/main.c:2850:68: style: Parameter 'application' can be declared as pointer to const. However it seems that 'mmgui_main_application_shutdown_signal' is a callback function, if 'application' is declared with const you might also need to cast function pointer(s). [constParameterCallback] modem-manager-gui/src/main.c:3088:2: note: You might need to cast the function pointer here modem-manager-gui/src/main.c:2850:68: note: Parameter 'application' can be declared as pointer to const 2.18.0 modem-manager-gui/src/main.c:3012:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_OPTION_ARG_NONE [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/main.c:417:4: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] 2.18.0 modem-manager-gui/src/main.c:471:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_RESPONSE_YES [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/main.c:487:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_RESPONSE_CLOSE [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/main.c:497:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_SOURCE_REMOVE [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/main.c:515:85: style: Parameter 'message' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/main.c:517:20: style: Variable 'defmessage' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/main.c:545:84: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_ICON_SIZE_BUTTON [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/main.c:580:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_SOURCE_REMOVE [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/main.c:592:65: style: Parameter 'message' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/main.c:647:85: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_ICON_SIZE_BUTTON [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/main.c:743:69: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_RESPONSE_APPLY [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/main.c:764:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_RESPONSE_APPLY [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/main.c:796:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable GTK_RESPONSE_CLOSE [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/mmguicore.c:3138:40: error: There is an unknown macro here somewhere. Configuration is required. If G_GUINT64_FORMAT is a macro then please configure it. [unknownMacro] head modem-manager-gui/src/mmguicore.h:575:0: error: failed to evaluate #if condition, undefined function-like macro invocation: GLIB_CHECK_VERSION( ... ) [preprocessorErrorDirective] head modem-manager-gui/src/mmguicore.h:575:3: error: failed to evaluate #if condition, undefined function-like macro invocation: GLIB_CHECK_VERSION( ... ) [preprocessorErrorDirective] 2.18.0 modem-manager-gui/src/modules/connman112.c:113:9: style: Variable 'constr' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/connman112.c:1218:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IFNAMSIZ [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/connman112.c:1395:1: error: Memory leak: conpath [memleak] 2.18.0 modem-manager-gui/src/modules/connman112.c:1395:1: error: Memory leak: propname [memleak] 2.18.0 modem-manager-gui/src/modules/connman112.c:1395:1: error: Memory leak: propvalue [memleak] 2.18.0 modem-manager-gui/src/modules/connman112.c:1446:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IFNAMSIZ [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/connman112.c:1513:1: error: Memory leak: propname [memleak] 2.18.0 modem-manager-gui/src/modules/connman112.c:1513:1: error: Memory leak: propvalue [memleak] 2.18.0 modem-manager-gui/src/modules/connman112.c:153:18: style: Variable 'deviceid' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/connman112.c:153:9: style: Variable 'constr' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/connman112.c:1560:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IFNAMSIZ [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/connman112.c:1627:1: error: Memory leak: propname [memleak] 2.18.0 modem-manager-gui/src/modules/connman112.c:1627:1: error: Memory leak: propvalue [memleak] 2.18.0 modem-manager-gui/src/modules/connman112.c:1643:13: style: Condition 'device==NULL' is always false [knownConditionTrueFalse] 2.18.0 modem-manager-gui/src/modules/connman112.c:1878:10: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_DBUS_CALL_FLAGS_NONE [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/connman112.c:631:19: style: Variable 'dnsbuilder' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/connman112.c:809:19: style: Variable 'dnsbuilder' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/mm06.c:1136:30: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] modem-manager-gui/src/modules/mm06.c:1135:29: note: outer condition: moduledata->netproxy!=NULL modem-manager-gui/src/modules/mm06.c:1136:30: note: identical inner condition: moduledata->netproxy!=NULL 2.18.0 modem-manager-gui/src/modules/mm06.c:1531:30: style: Condition 'mmguicorelc->eventcb!=NULL' is always true [knownConditionTrueFalse] 2.18.0 modem-manager-gui/src/modules/mm06.c:1588:23: style: Array index 'i' is used before limits check. [arrayIndexThenCheck] 2.18.0 modem-manager-gui/src/modules/mm06.c:1648:24: style: Condition 'locationtypes&MODULE_INT_MODEM_LOCATION_CAPABILITY_GSM_LAC_CI' is always true [knownConditionTrueFalse] modem-manager-gui/src/modules/mm06.c:1641:22: note: Assuming that condition 'locationtypes&MODULE_INT_MODEM_LOCATION_CAPABILITY_GSM_LAC_CI' is not redundant modem-manager-gui/src/modules/mm06.c:1648:24: note: Condition 'locationtypes&MODULE_INT_MODEM_LOCATION_CAPABILITY_GSM_LAC_CI' is always true 2.18.0 modem-manager-gui/src/modules/mm06.c:187:9: style: Variable 'devidstr' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/mm06.c:189:21: warning:inconclusive: Either the condition 'devpath!=NULL' is redundant or there is possible null pointer dereference: devpath. [nullPointerRedundantCheck] modem-manager-gui/src/modules/mm06.c:622:14: note: Assuming that condition 'devpath!=NULL' is not redundant modem-manager-gui/src/modules/mm06.c:618:38: note: Calling function 'mmgui_module_device_id', 1st argument 'devpath' value is 0 modem-manager-gui/src/modules/mm06.c:189:21: note: Null pointer dereference 2.18.0 modem-manager-gui/src/modules/mm06.c:2312:41: style: Redundant condition: moduledata->cancellable!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/mm06.c:2357:7: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_DBUS_CALL_FLAGS_NONE [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/mm06.c:2385:41: style: Redundant condition: moduledata->cancellable!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/mm06.c:2404:90: style: Parameter 'pin' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/modules/mm06.c:2428:7: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_DBUS_CALL_FLAGS_NONE [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/mm06.c:2493:8: style: Variable 'index' is assigned a value that is never used. [unreadVariable] 2.18.0 modem-manager-gui/src/modules/mm06.c:2790:41: style: Redundant condition: moduledata->cancellable!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/mm06.c:2804:75: style: Redundant condition: moduledata->cancellable!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/mm06.c:2809:75: style: Parameter 'number' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/modules/mm06.c:2809:90: style: Parameter 'text' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/modules/mm06.c:2813:19: style: Variable 'builder' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/mm06.c:2814:12: style: Variable 'array' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/mm06.c:2850:6: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_DBUS_CALL_FLAGS_NONE [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/mm06.c:2900:9: style: Variable 'state' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/mm06.c:2962:41: style: Redundant condition: moduledata->cancellable!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/mm06.c:2982:75: style: Redundant condition: moduledata->cancellable!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/mm06.c:2987:76: style: Parameter 'request' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/modules/mm06.c:3039:6: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_DBUS_CALL_FLAGS_NONE [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/mm06.c:3138:41: style: Redundant condition: moduledata->cancellable!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/mm06.c:3162:75: style: Redundant condition: moduledata->cancellable!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/mm06.c:402:70: style: Parameter 'ustring' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/modules/mm06.c:417:69: style: Parameter 'ustring' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/modules/mm06.c:680:18: error: Null pointer dereference [nullPointer] 2.18.0 modem-manager-gui/src/modules/mm06.c:680:18: warning: Either the condition 'deviceproxy==NULL' is redundant or there is possible null pointer dereference: deviceproxy. [nullPointerRedundantCheck] modem-manager-gui/src/modules/mm06.c:677:19: note: Assuming that condition 'deviceproxy==NULL' is not redundant modem-manager-gui/src/modules/mm06.c:680:18: note: Null pointer dereference 2.18.0 modem-manager-gui/src/modules/mm06.c:834:55: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_CHECKSUM_MD5 [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/mm07.c:1078:55: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_CHECKSUM_MD5 [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/mm07.c:1133:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_DBUS_OBJECT_MANAGER_CLIENT_FLAGS_NONE [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/mm07.c:1399:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable next [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/mm07.c:1621:30: style: Condition 'mmguicorelc->eventcb!=NULL' is always true [knownConditionTrueFalse] 2.18.0 modem-manager-gui/src/modules/mm07.c:1636:30: style: Condition 'mmguicorelc->eventcb!=NULL' is always true [knownConditionTrueFalse] 2.18.0 modem-manager-gui/src/modules/mm07.c:1660:9: style: Variable 'locationstring' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/mm07.c:1693:23: style: Array index 'i' is used before limits check. [arrayIndexThenCheck] 2.18.0 modem-manager-gui/src/modules/mm07.c:2065:13: style: Condition 'device==NULL' is always false [knownConditionTrueFalse] 2.18.0 modem-manager-gui/src/modules/mm07.c:2306:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable next [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/mm07.c:2431:41: style: Redundant condition: moduledata->cancellable!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/mm07.c:2479:7: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_DBUS_CALL_FLAGS_NONE [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/mm07.c:2506:41: style: Redundant condition: moduledata->cancellable!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/mm07.c:2525:90: style: Parameter 'pin' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/modules/mm07.c:2549:7: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_DBUS_CALL_FLAGS_NONE [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/mm07.c:2860:45: warning: Either the condition 'smspath!=NULL' is redundant or there is possible null pointer dereference: smspath. [nullPointerRedundantCheck] modem-manager-gui/src/modules/mm07.c:2861:17: note: Assuming that condition 'smspath!=NULL' is not redundant modem-manager-gui/src/modules/mm07.c:2860:45: note: Null pointer dereference 2.18.0 modem-manager-gui/src/modules/mm07.c:2966:41: style: Redundant condition: moduledata->cancellable!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/mm07.c:2996:75: style: Redundant condition: moduledata->cancellable!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/mm07.c:3001:75: style: Parameter 'number' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/modules/mm07.c:3001:90: style: Parameter 'text' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/modules/mm07.c:3005:19: style: Variable 'builder' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/mm07.c:3006:12: style: Variable 'array' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/mm07.c:300:9: style: Variable 'objectpathid' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/mm07.c:3210:41: style: Redundant condition: moduledata->cancellable!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/mm07.c:3230:75: style: Redundant condition: moduledata->cancellable!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/mm07.c:3235:76: style: Parameter 'request' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/modules/mm07.c:3287:6: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_DBUS_CALL_FLAGS_NONE [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/mm07.c:3382:41: style: Redundant condition: moduledata->cancellable!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/mm07.c:3406:75: style: Redundant condition: moduledata->cancellable!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/mm07.c:3644:75: style: Parameter 'name' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/modules/mm07.c:3644:88: style: Parameter 'number' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/modules/mm07.c:3648:19: style: Variable 'builder' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/mm07.c:3649:12: style: Variable 'array' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/mm07.c:454:33: warning: Either the condition 'devpath!=NULL' is redundant or there is possible null pointer dereference: devpath. [nullPointerRedundantCheck] modem-manager-gui/src/modules/mm07.c:455:15: note: Assuming that condition 'devpath!=NULL' is not redundant modem-manager-gui/src/modules/mm07.c:454:33: note: Null pointer dereference 2.18.0 modem-manager-gui/src/modules/mm07.c:474:35: warning: Either the condition 'devpath!=NULL' is redundant or there is possible null pointer dereference: devpath. [nullPointerRedundantCheck] modem-manager-gui/src/modules/mm07.c:475:15: note: Assuming that condition 'devpath!=NULL' is not redundant modem-manager-gui/src/modules/mm07.c:474:35: note: Null pointer dereference 2.18.0 modem-manager-gui/src/modules/mm07.c:950:18: error: Null pointer dereference [nullPointer] 2.18.0 modem-manager-gui/src/modules/mm07.c:950:18: warning: Either the condition 'deviceproxy==NULL' is redundant or there is possible null pointer dereference: deviceproxy. [nullPointerRedundantCheck] modem-manager-gui/src/modules/mm07.c:947:19: note: Assuming that condition 'deviceproxy==NULL' is not redundant modem-manager-gui/src/modules/mm07.c:950:18: note: Null pointer dereference 2.18.0 modem-manager-gui/src/modules/nm09.c:1122:13: style: Condition 'device==NULL' is always false [knownConditionTrueFalse] 2.18.0 modem-manager-gui/src/modules/nm09.c:1182:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IFNAMSIZ [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/nm09.c:1306:77: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_KEY_FILE_NONE [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/nm09.c:173:21: style: Redundant condition: checkstate. '!A || (A && B)' is equivalent to '!A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/nm09.c:176:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IFNAMSIZ [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/nm09.c:185:14: style: Condition 'checkstate' is always true [knownConditionTrueFalse] 2.18.0 modem-manager-gui/src/modules/nm09.c:212:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IFNAMSIZ [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/nm09.c:560:3: error: Memory leak: connproxy [memleak] 2.18.0 modem-manager-gui/src/modules/nm09.c:637:28: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] 2.18.0 modem-manager-gui/src/modules/nm09.c:637:28: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] 2.18.0 modem-manager-gui/src/modules/nm09.c:637:28: warning: %u in format string (no. 3) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] 2.18.0 modem-manager-gui/src/modules/nm09.c:637:28: warning: %u in format string (no. 4) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] 2.18.0 modem-manager-gui/src/modules/nm09.c:639:28: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] 2.18.0 modem-manager-gui/src/modules/nm09.c:639:28: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] 2.18.0 modem-manager-gui/src/modules/nm09.c:639:28: warning: %u in format string (no. 3) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] 2.18.0 modem-manager-gui/src/modules/nm09.c:639:28: warning: %u in format string (no. 4) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] 2.18.0 modem-manager-gui/src/modules/nm09.c:748:106: style: Variable 'ipv6builder' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/nm09.c:748:120: style: Variable 'dnsbuilder' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/nm09.c:748:19: style: Variable 'paramsbuilder' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/nm09.c:748:35: style: Variable 'connbuilder' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/nm09.c:748:49: style: Variable 'serialbuilder' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/nm09.c:748:65: style: Variable 'pppbuilder' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/nm09.c:748:78: style: Variable 'techbuilder' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/nm09.c:748:92: style: Variable 'ipv4builder' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/nm09.c:751:10: style: Variable 'addrbytes' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/ofono109.c:1122:18: error: Null pointer dereference [nullPointer] 2.18.0 modem-manager-gui/src/modules/ofono109.c:1122:18: warning: Either the condition 'deviceproxy==NULL' is redundant or there is possible null pointer dereference: deviceproxy. [nullPointerRedundantCheck] modem-manager-gui/src/modules/ofono109.c:1119:19: note: Assuming that condition 'deviceproxy==NULL' is not redundant modem-manager-gui/src/modules/ofono109.c:1122:18: note: Null pointer dereference 2.18.0 modem-manager-gui/src/modules/ofono109.c:1175:5: error: Memory leak: propdict [memleak] 2.18.0 modem-manager-gui/src/modules/ofono109.c:1353:55: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_CHECKSUM_MD5 [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/ofono109.c:1720:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable next [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/ofono109.c:1758:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable next [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/ofono109.c:1789:16: style: Variable 'strsize' is assigned a value that is never used. [unreadVariable] 2.18.0 modem-manager-gui/src/modules/ofono109.c:2348:13: style: Condition 'device==NULL' is always false [knownConditionTrueFalse] 2.18.0 modem-manager-gui/src/modules/ofono109.c:252:44: error: Allocation with g_variant_print, g_debug doesn't release it. [leakNoVarFunctionCall] 2.18.0 modem-manager-gui/src/modules/ofono109.c:2543:41: style: Redundant condition: moduledata->cancellable!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/ofono109.c:2566:12: style: Variable 'value' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/ofono109.c:2591:7: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_DBUS_CALL_FLAGS_NONE [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/ofono109.c:2597:2: error: Memory leak: value [memleak] 2.18.0 modem-manager-gui/src/modules/ofono109.c:2618:41: style: Redundant condition: moduledata->cancellable!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/ofono109.c:2637:90: style: Parameter 'pin' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/modules/ofono109.c:2661:7: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_DBUS_CALL_FLAGS_NONE [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/ofono109.c:2689:10: style: Variable 'prevptr' is assigned a value that is never used. [unreadVariable] 2.18.0 modem-manager-gui/src/modules/ofono109.c:2692:11: style: Variable 'fieldlen' is assigned a value that is never used. [unreadVariable] 2.18.0 modem-manager-gui/src/modules/ofono109.c:2701:11: warning: Either the condition 'fieldlen<=sizeof(strbuf)' is redundant or the array 'strbuf[5]' is accessed at index 5, which is out of bounds. [arrayIndexOutOfBoundsCond] modem-manager-gui/src/modules/ofono109.c:2699:17: note: Assuming that condition 'fieldlen<=sizeof(strbuf)' is not redundant modem-manager-gui/src/modules/ofono109.c:2701:11: note: Array index out of bounds 2.18.0 modem-manager-gui/src/modules/ofono109.c:2755:3: error: Memory leak: smsparamsv [memleak] 2.18.0 modem-manager-gui/src/modules/ofono109.c:2789:2: error: Memory leak: smsparamsv [memleak] 2.18.0 modem-manager-gui/src/modules/ofono109.c:2899:41: style: Redundant condition: moduledata->cancellable!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/ofono109.c:2963:75: style: Redundant condition: moduledata->cancellable!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/ofono109.c:2968:75: style: Parameter 'number' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/modules/ofono109.c:2968:90: style: Parameter 'text' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/modules/ofono109.c:2974:19: style: Variable 'messagebuilder' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/ofono109.c:3028:7: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_DBUS_CALL_FLAGS_NONE [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/ofono109.c:3093:9: style: Variable 'state' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/ofono109.c:3158:41: style: Redundant condition: moduledata->cancellable!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/ofono109.c:3188:75: style: Redundant condition: moduledata->cancellable!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/ofono109.c:3193:76: style: Parameter 'request' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/modules/ofono109.c:3245:6: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_DBUS_CALL_FLAGS_NONE [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/ofono109.c:3392:41: style: Redundant condition: moduledata->cancellable!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/ofono109.c:3413:75: style: Redundant condition: moduledata->cancellable!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/ofono109.c:404:1: error: Memory leak: propname [memleak] 2.18.0 modem-manager-gui/src/modules/ofono109.c:404:1: error: Memory leak: propvalue [memleak] 2.18.0 modem-manager-gui/src/modules/ofono109.c:501:21: warning: Either the condition 'mmguicore->device!=NULL' is redundant or there is possible null pointer dereference: mmguicore->device. [nullPointerRedundantCheck] modem-manager-gui/src/modules/ofono109.c:504:31: note: Assuming that condition 'mmguicore->device!=NULL' is not redundant modem-manager-gui/src/modules/ofono109.c:501:21: note: Null pointer dereference 2.18.0 modem-manager-gui/src/modules/ofono109.c:507:32: style: Condition 'mmguicore->eventcb!=NULL' is always true [knownConditionTrueFalse] 2.18.0 modem-manager-gui/src/modules/ofono109.c:551:17: warning: Either the condition 'mmguicore->device!=NULL' is redundant or there is possible null pointer dereference: mmguicore->device. [nullPointerRedundantCheck] modem-manager-gui/src/modules/ofono109.c:556:32: note: Assuming that condition 'mmguicore->device!=NULL' is not redundant modem-manager-gui/src/modules/ofono109.c:551:17: note: Null pointer dereference 2.18.0 modem-manager-gui/src/modules/ofono109.c:553:22: warning: Either the condition 'mmguicore->device!=NULL' is redundant or there is possible null pointer dereference: mmguicore->device. [nullPointerRedundantCheck] modem-manager-gui/src/modules/ofono109.c:556:32: note: Assuming that condition 'mmguicore->device!=NULL' is not redundant modem-manager-gui/src/modules/ofono109.c:553:22: note: Null pointer dereference 2.18.0 modem-manager-gui/src/modules/ofono109.c:559:33: style: Condition 'mmguicore->eventcb!=NULL' is always true [knownConditionTrueFalse] 2.18.0 modem-manager-gui/src/modules/ofono109.c:571:1: error: Memory leak: propname [memleak] 2.18.0 modem-manager-gui/src/modules/ofono109.c:571:1: error: Memory leak: propvalue [memleak] 2.18.0 modem-manager-gui/src/modules/ofono109.c:644:1: error: Memory leak: propname [memleak] 2.18.0 modem-manager-gui/src/modules/ofono109.c:644:1: error: Memory leak: propvalue [memleak] 2.18.0 modem-manager-gui/src/modules/pppd245.c:125:75: style: Parameter 'parameter' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/modules/pppd245.c:127:18: style: Variable 'segstart' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/pppd245.c:127:9: style: Variable 'segend' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/pppd245.c:155:18: style: Variable 'segstart' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/pppd245.c:155:9: style: Variable 'segend' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/pppd245.c:162:23: style: Redundant condition: segend!=NULL. 'segend==NULL || (segend!=NULL && (*segend)>=dbsize)' is equivalent to 'segend==NULL || (*segend)>=dbsize' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/pppd245.c:166:25: style: Redundant condition: segstart!=NULL. 'segstart==NULL || (segstart!=NULL && segend<=segstart)' is equivalent to 'segstart==NULL || segend<=segstart' [redundantCondition] 2.18.0 modem-manager-gui/src/modules/pppd245.c:179:18: style: Variable 'segstart' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/pppd245.c:179:9: style: Variable 'segend' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/pppd245.c:223:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable O_RDONLY [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/pppd245.c:252:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IFNAMSIZ [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/pppd245.c:318:61: style: Parameter 'mmguicore' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/modules/pppd245.c:323:66: style: Parameter 'mmguicore' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/modules/pppd245.c:328:66: style: Parameter 'mmguicore' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/modules/pppd245.c:333:66: style: Parameter 'mmguicore' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/modules/pppd245.c:400:9: style: Variable 'parameter' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/modules/pppd245.c:413:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable O_RDONLY [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/modules/pppd245.c:454:9: warning: If memory allocation fails, then there is a possible null pointer dereference: dbmapping [nullPointerOutOfMemory] modem-manager-gui/src/modules/pppd245.c:435:18: note: Assuming allocation function fails modem-manager-gui/src/modules/pppd245.c:435:18: note: Assignment 'dbmapping=mmap(0,statbuf.st_size,PROT_READ,MAP_SHARED,dbfd,0)', assigned value is 0 modem-manager-gui/src/modules/pppd245.c:446:17: note: Assuming condition is false modem-manager-gui/src/modules/pppd245.c:454:9: note: Null pointer dereference 2.18.0 modem-manager-gui/src/modules/pppd245.c:505:2: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] 2.18.0 modem-manager-gui/src/modules/pppd245.c:505:2: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] 2.18.0 modem-manager-gui/src/modules/pppd245.c:562:80: style: Parameter 'mmguicore' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/modules/pppd245.c:567:74: style: Parameter 'mmguicore' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/modules/pppd245.c:97:80: style: Parameter 'entry' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/preferences-window.c:532:110: style: Parameter 'data' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/preferences-window.c:532:79: style: Parameter 'scale' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/preferences-window.c:537:101: style: Parameter 'data' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/preferences-window.c:537:70: style: Parameter 'scale' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/preferences-window.c:562:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RESOURCE_DESKTOP_FILE [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/preferences-window.c:593:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable G_FILE_TEST_IS_DIR [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/providersdb.c:319:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable RESOURCE_PROVIDERS_DB [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/scan-page.c:148:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PANGO_ELLIPSIZE_END [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/scan-page.c:50:71: style: Parameter 'object' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/scan-page.c:50:88: style: Parameter 'data' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/scan-page.c:66:69: style: Parameter 'tree_view' can be declared as pointer to const. However it seems that 'mmgui_main_scan_list_cursor_changed_signal' is a callback function, if 'tree_view' is declared with const you might also need to cast function pointer(s). [constParameterCallback] modem-manager-gui/src/scan-page.c:157:2: note: You might need to cast the function pointer here modem-manager-gui/src/scan-page.c:66:69: note: Parameter 'tree_view' can be declared as pointer to const 2.18.0 modem-manager-gui/src/scan-page.c:75:116: style: Parameter 'col' can be declared as pointer to const. However it seems that 'mmgui_main_scan_list_row_activated_signal' is a callback function, if 'col' is declared with const you might also need to cast function pointer(s). [constParameterCallback] modem-manager-gui/src/scan-page.c:159:2: note: You might need to cast the function pointer here modem-manager-gui/src/scan-page.c:75:116: note: Parameter 'col' can be declared as pointer to const 2.18.0 modem-manager-gui/src/scan-page.c:75:68: style: Parameter 'treeview' can be declared as pointer to const. However it seems that 'mmgui_main_scan_list_row_activated_signal' is a callback function, if 'treeview' is declared with const you might also need to cast function pointer(s). [constParameterCallback] modem-manager-gui/src/scan-page.c:159:2: note: You might need to cast the function pointer here modem-manager-gui/src/scan-page.c:75:68: note: Parameter 'treeview' can be declared as pointer to const 2.18.0 modem-manager-gui/src/scan-page.c:75:91: style: Parameter 'path' can be declared as pointer to const. However it seems that 'mmgui_main_scan_list_row_activated_signal' is a callback function, if 'path' is declared with const you might also need to cast function pointer(s). [constParameterCallback] modem-manager-gui/src/scan-page.c:159:2: note: You might need to cast the function pointer here modem-manager-gui/src/scan-page.c:75:91: note: Parameter 'path' can be declared as pointer to const 2.18.0 modem-manager-gui/src/sms-page.c:1042:95: style: Condition 'smscaps&MMGUI_SMS_CAPS_SEND' is always true [knownConditionTrueFalse] modem-manager-gui/src/sms-page.c:1040:22: note: Assuming that condition 'smscaps&MMGUI_SMS_CAPS_SEND' is not redundant modem-manager-gui/src/sms-page.c:1042:95: note: Condition 'smscaps&MMGUI_SMS_CAPS_SEND' is always true 2.18.0 modem-manager-gui/src/sms-page.c:1425:52: style: Redundant condition: mmguiapp->window->smsnumlisthistory!=NULL. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] 2.18.0 modem-manager-gui/src/sms-page.c:1927:68: style: Parameter 'toolbutton' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/sms-page.c:1927:89: style: Parameter 'data' can be declared as pointer to const [constParameterPointer] 2.18.0 modem-manager-gui/src/sms-page.c:1951:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PANGO_ELLIPSIZE_END [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/sms-page.c:292:27: debug: Scope::checkVariable found variable 'sendernamesvalue' with varid 0. [varid0] 2.18.0 modem-manager-gui/src/sms-page.c:292:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sendernamesvalue [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/sms-page.c:844:9: style: Variable 'lastnumber' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/strformat.c:105:32: error: There is an unknown macro here somewhere. Configuration is required. If G_GUINT64_FORMAT is a macro then please configure it. [unknownMacro] 2.18.0 modem-manager-gui/src/traffic-page.c:1043:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CAIRO_LINE_JOIN_ROUND [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/traffic-page.c:112:13: style: Variable 'timespec' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/traffic-page.c:1159:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PANGO_ELLIPSIZE_END [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/traffic-page.c:1269:36: style: int result is assigned to long variable. If the variable is long to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 modem-manager-gui/src/traffic-page.c:1272:36: style: int result is assigned to long variable. If the variable is long to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 modem-manager-gui/src/traffic-page.c:1275:36: style: int result is assigned to long variable. If the variable is long to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 modem-manager-gui/src/traffic-page.c:132:16: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] 2.18.0 modem-manager-gui/src/traffic-page.c:133:73: style: Condition 'strftime(strformat[0],sizeof(strformat[0]),"%d %B",timespec)==-1' is always false [knownConditionTrueFalse] 2.18.0 modem-manager-gui/src/traffic-page.c:165:13: style: Variable 'timespec' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/traffic-page.c:175:13: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] 2.18.0 modem-manager-gui/src/traffic-page.c:196:13: style: Variable 'timespec' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/traffic-page.c:203:13: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] 2.18.0 modem-manager-gui/src/traffic-page.c:688:38: style: int result is assigned to long variable. If the variable is long to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 modem-manager-gui/src/traffic-page.c:691:38: style: int result is assigned to long variable. If the variable is long to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 modem-manager-gui/src/traffic-page.c:694:38: style: int result is assigned to long variable. If the variable is long to avoid loss of information, then you have loss of information. [truncLongCastAssignment] 2.18.0 modem-manager-gui/src/traffic-page.c:795:28: style: Redundant condition: device!=NULL. 'device==NULL || (device!=NULL && !device->connected)' is equivalent to 'device==NULL || !device->connected' [redundantCondition] 2.18.0 modem-manager-gui/src/ussd-page.c:211:27: error: Dereferencing 'model' after it is deallocated / released [deallocuse] 2.18.0 modem-manager-gui/src/ussd-page.c:543:78: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PANGO_ELLIPSIZE_END [valueFlowBailoutIncompleteVar] 2.18.0 modem-manager-gui/src/vcard.c:148:9: style: Variable 'valuestr' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/vcard.c:159:38: style:inconclusive: Function 'vcard_parse_string' argument 1 names different: declaration 'string' definition 'srcstr'. [funcArgNamesDifferent] modem-manager-gui/src/vcard.h:25:38: note: Function 'vcard_parse_string' argument 1 names different: declaration 'string' definition 'srcstr'. modem-manager-gui/src/vcard.c:159:38: note: Function 'vcard_parse_string' argument 1 names different: declaration 'string' definition 'srcstr'. 2.18.0 modem-manager-gui/src/vcard.c:203:17: style: Variable 'row' can be declared as pointer to const [constVariablePointer] 2.18.0 modem-manager-gui/src/vcard.c:235:35: style: Condition 'contact->name2==NULL' is always true [knownConditionTrueFalse] modem-manager-gui/src/vcard.c:233:28: note: Assuming that condition 'contact->name2!=NULL' is not redundant modem-manager-gui/src/vcard.c:235:35: note: Condition 'contact->name2==NULL' is always true 2.18.0 modem-manager-gui/src/welcome-window.c:460:90: style: Parameter 'error' can be declared as pointer to const [constParameterPointer] DONE