2021-10-17 12:23 ftp://ftp.de.debian.org/debian/pool/main/m/mednafen/mednafen_1.27.1+dfsg.orig.tar.xz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp platform: Linux-5.4.0-88-generic-x86_64-with-glibc2.29 python: 3.8.10 client-version: 1.3.13 compiler: g++ (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0 cppcheck: head 2.6 head-info: 21abf315b (2021-10-17 11:05:19 +0200) count: 1895 1891 elapsed-time: 818.9 828.2 head-timing-info: Overall time: 0s old-timing-info: Overall time: 0s head results: mednafen/intl/finddomain.c:61:30: style:inconclusive: Function '_nl_find_domain' argument 1 names different: declaration '__dirname' definition 'dirname'. [funcArgNamesDifferent] mednafen/intl/gettextP.h:257:54: note: Function '_nl_find_domain' argument 1 names different: declaration '__dirname' definition 'dirname'. mednafen/intl/finddomain.c:61:30: note: Function '_nl_find_domain' argument 1 names different: declaration '__dirname' definition 'dirname'. mednafen/intl/finddomain.c:61:45: style:inconclusive: Function '_nl_find_domain' argument 2 names different: declaration '__locale' definition 'locale'. [funcArgNamesDifferent] mednafen/intl/gettextP.h:257:71: note: Function '_nl_find_domain' argument 2 names different: declaration '__locale' definition 'locale'. mednafen/intl/finddomain.c:61:45: note: Function '_nl_find_domain' argument 2 names different: declaration '__locale' definition 'locale'. mednafen/intl/finddomain.c:62:16: style:inconclusive: Function '_nl_find_domain' argument 3 names different: declaration '__domainname' definition 'domainname'. [funcArgNamesDifferent] mednafen/intl/gettextP.h:258:19: note: Function '_nl_find_domain' argument 3 names different: declaration '__domainname' definition 'domainname'. mednafen/intl/finddomain.c:62:16: note: Function '_nl_find_domain' argument 3 names different: declaration '__domainname' definition 'domainname'. mednafen/intl/finddomain.c:62:44: style:inconclusive: Function '_nl_find_domain' argument 4 names different: declaration '__domainbinding' definition 'domainbinding'. [funcArgNamesDifferent] mednafen/intl/gettextP.h:259:23: note: Function '_nl_find_domain' argument 4 names different: declaration '__domainbinding' definition 'domainbinding'. mednafen/intl/finddomain.c:62:44: note: Function '_nl_find_domain' argument 4 names different: declaration '__domainbinding' definition 'domainbinding'. mednafen/intl/localcharset.c:440:14: style: Condition 'locale==NULL' is always true [knownConditionTrueFalse] mednafen/intl/localcharset.c:431:24: note: Assignment 'locale=NULL', assigned value is 0 mednafen/intl/localcharset.c:440:14: note: Condition 'locale==NULL' is always true mednafen/intl/localcharset.c:168:71: style: Same value in both branches of ternary operator. [duplicateValueTernary] mednafen/intl/bindtextdom.c:232:12: style: Local variable 'len' shadows outer variable [shadowVariable] mednafen/intl/bindtextdom.c:204:14: note: Shadowed declaration mednafen/intl/bindtextdom.c:232:12: note: Shadow variable mednafen/intl/bindtextdom.c:261:15: style: Local variable 'len' shadows outer variable [shadowVariable] mednafen/intl/bindtextdom.c:204:14: note: Shadowed declaration mednafen/intl/bindtextdom.c:261:15: note: Shadow variable plural.c:1160:5: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] plural.c:1416:15: style: Condition 'yyn==0' is always true [knownConditionTrueFalse] plural.c:1413:16: note: Assignment 'yyn=yytable[yyn]', assigned value is greater than -1 plural.c:1414:11: note: Assuming that condition 'yyn<=0' is not redundant plural.c:1416:15: note: Condition 'yyn==0' is always true plural.y:156:21: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:158:52: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:164:96: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:172:71: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:180:72: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:188:89: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:196:89: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:204:89: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:212:89: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:220:48: style: Same expression on both sides of '-'. [duplicateExpression] plural.y:237:42: style: Same expression on both sides of '-'. [duplicateExpression] mednafen/intl/dcigettext.c:642:14: style: Obsolescent function 'getwd' called. It is recommended to use 'getcwd' instead. [prohibitedgetwdCalled] mednafen/intl/dcigettext.c:691:39: style: Redundant condition: If 'EXPR == ':'', the comparison 'EXPR != '\0'' is always true. [redundantCondition] mednafen/intl/dcigettext.c:487:25: style:inconclusive: Function 'libintl_dcigettext' argument 1 names different: declaration '__domainname' definition 'domainname'. [funcArgNamesDifferent] mednafen/intl/gettextP.h:80:46: note: Function 'libintl_dcigettext' argument 1 names different: declaration '__domainname' definition 'domainname'. mednafen/intl/dcigettext.c:487:25: note: Function 'libintl_dcigettext' argument 1 names different: declaration '__domainname' definition 'domainname'. mednafen/intl/dcigettext.c:487:49: style:inconclusive: Function 'libintl_dcigettext' argument 2 names different: declaration '__msgid1' definition 'msgid1'. [funcArgNamesDifferent] mednafen/intl/gettextP.h:81:18: note: Function 'libintl_dcigettext' argument 2 names different: declaration '__msgid1' definition 'msgid1'. mednafen/intl/dcigettext.c:487:49: note: Function 'libintl_dcigettext' argument 2 names different: declaration '__msgid1' definition 'msgid1'. mednafen/intl/dcigettext.c:487:69: style:inconclusive: Function 'libintl_dcigettext' argument 3 names different: declaration '__msgid2' definition 'msgid2'. [funcArgNamesDifferent] mednafen/intl/gettextP.h:81:40: note: Function 'libintl_dcigettext' argument 3 names different: declaration '__msgid2' definition 'msgid2'. mednafen/intl/dcigettext.c:487:69: note: Function 'libintl_dcigettext' argument 3 names different: declaration '__msgid2' definition 'msgid2'. mednafen/intl/dcigettext.c:488:10: style:inconclusive: Function 'libintl_dcigettext' argument 4 names different: declaration '__plural' definition 'plural'. [funcArgNamesDifferent] mednafen/intl/gettextP.h:82:10: note: Function 'libintl_dcigettext' argument 4 names different: declaration '__plural' definition 'plural'. mednafen/intl/dcigettext.c:488:10: note: Function 'libintl_dcigettext' argument 4 names different: declaration '__plural' definition 'plural'. mednafen/intl/dcigettext.c:488:36: style:inconclusive: Function 'libintl_dcigettext' argument 5 names different: declaration '__n' definition 'n'. [funcArgNamesDifferent] mednafen/intl/gettextP.h:82:38: note: Function 'libintl_dcigettext' argument 5 names different: declaration '__n' definition 'n'. mednafen/intl/dcigettext.c:488:36: note: Function 'libintl_dcigettext' argument 5 names different: declaration '__n' definition 'n'. mednafen/intl/dcigettext.c:488:43: style:inconclusive: Function 'libintl_dcigettext' argument 6 names different: declaration '__category' definition 'category'. [funcArgNamesDifferent] mednafen/intl/gettextP.h:83:10: note: Function 'libintl_dcigettext' argument 6 names different: declaration '__category' definition 'category'. mednafen/intl/dcigettext.c:488:43: note: Function 'libintl_dcigettext' argument 6 names different: declaration '__category' definition 'category'. mednafen/intl/tsearch.c:184:8: style: Local variable 'root' shadows outer variable [shadowVariable] mednafen/intl/dcigettext.c:277:14: note: Shadowed declaration mednafen/intl/tsearch.c:184:8: note: Shadow variable mednafen/intl/tsearch.c:284:12: style: Local variable 'root' shadows outer variable [shadowVariable] mednafen/intl/dcigettext.c:277:14: note: Shadowed declaration mednafen/intl/tsearch.c:284:12: note: Shadow variable mednafen/intl/tsearch.c:345:12: style: Local variable 'root' shadows outer variable [shadowVariable] mednafen/intl/dcigettext.c:277:14: note: Shadowed declaration mednafen/intl/tsearch.c:345:12: note: Shadow variable mednafen/intl/tsearch.c:370:8: style: Local variable 'root' shadows outer variable [shadowVariable] mednafen/intl/dcigettext.c:277:14: note: Shadowed declaration mednafen/intl/tsearch.c:370:8: note: Shadow variable mednafen/intl/tsearch.c:620:14: style: Local variable 'root' shadows outer variable [shadowVariable] mednafen/intl/dcigettext.c:277:14: note: Shadowed declaration mednafen/intl/tsearch.c:620:14: note: Shadow variable mednafen/intl/tsearch.c:643:14: style: Local variable 'root' shadows outer variable [shadowVariable] mednafen/intl/dcigettext.c:277:14: note: Shadowed declaration mednafen/intl/tsearch.c:643:14: note: Shadow variable mednafen/src/Stream.h:167:26: warning: The address of local variable 'c' might be accessed at non-zero index. [objectIndex] mednafen/src/Stream.h:167:23: note: Address of variable taken here. mednafen/src/Stream.h:167:26: note: The address of local variable 'c' might be accessed at non-zero index. mednafen/src/ExtMemStream.h:64:7: style:inconclusive: Technically the member function 'Mednafen::ExtMemStream::grow_if_necessary' can be const. [functionConst] mednafen/src/ExtMemStream.cpp:68:27: note: Technically the member function 'Mednafen::ExtMemStream::grow_if_necessary' can be const. mednafen/src/ExtMemStream.h:64:7: note: Technically the member function 'Mednafen::ExtMemStream::grow_if_necessary' can be const. mednafen/src/ExtMemStream.h:52:15: style: Virtual function 'close' is called from destructor '~ExtMemStream()' at line 43. Dynamic binding is not used. [virtualCallInConstructor] mednafen/src/ExtMemStream.cpp:43:2: note: Calling close mednafen/src/ExtMemStream.h:52:15: note: close is a virtual function mednafen/src/IPSPatcher.cpp:55:7: style: Condition '!patch_size' is always true [knownConditionTrueFalse] mednafen/src/IPSPatcher.cpp:50:6: note: Assuming that condition '!patch_size' is not redundant mednafen/src/IPSPatcher.cpp:55:7: note: Condition '!patch_size' is always true mednafen/src/MTStreamReader.h:37:2: style: Class 'MTStreamReader' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/MTStreamReader.cpp:58:10: style: C-style pointer casting [cstyleCast] mednafen/src/NativeVFS.cpp:89:0: error: #error "mkdir() missing?!" [preprocessorErrorDirective] mednafen/src/FileStream.h:91:26: error: Invalid read() argument nr 3. A non-boolean value is required. [invalidFunctionArgBool] mednafen/src/FileStream.h:78:15: style: Virtual function 'close' is called from constructor 'FileStream(const std::string&path,const uint32 mode,const int do_lock=false,const uint32 buffer_size=4096)' at line 154. Dynamic binding is not used. [virtualCallInConstructor] mednafen/src/FileStream.cpp:154:10: note: Calling close mednafen/src/FileStream.h:78:15: note: close is a virtual function mednafen/src/FileStream.h:78:15: style: Virtual function 'close' is called from constructor 'FileStream(const std::string&path,const uint32 mode,const int do_lock=false,const uint32 buffer_size=4096)' at line 167. Dynamic binding is not used. [virtualCallInConstructor] mednafen/src/FileStream.cpp:167:10: note: Calling close mednafen/src/FileStream.h:78:15: note: close is a virtual function mednafen/src/FileStream.h:78:15: style: Virtual function 'close' is called from destructor '~FileStream()' at line 184. Dynamic binding is not used. [virtualCallInConstructor] mednafen/src/FileStream.cpp:184:3: note: Calling close mednafen/src/FileStream.h:78:15: note: close is a virtual function mednafen/src/FileStream.cpp:447:14: style: Variable 'tmp_data' is assigned a value that is never used. [unreadVariable] mednafen/src/MemoryStream.cpp:41:2: performance: Variable 'data_buffer_size' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/MemoryStream.cpp:42:2: performance: Variable 'data_buffer_alloced' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/MemoryStream.cpp:100:2: performance: Variable 'data_buffer_size' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/MemoryStream.cpp:101:2: performance: Variable 'data_buffer_alloced' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/MemoryStream.h:75:7: performance:inconclusive: Technically the member function 'Mednafen::MemoryStream::mswin_utf8_convert_kludge' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/MemoryStream.cpp:349:20: note: Technically the member function 'Mednafen::MemoryStream::mswin_utf8_convert_kludge' can be static (but you may consider moving to unnamed namespace). mednafen/src/MemoryStream.h:75:7: note: Technically the member function 'Mednafen::MemoryStream::mswin_utf8_convert_kludge' can be static (but you may consider moving to unnamed namespace). mednafen/src/MemoryStream.h:69:15: style: Virtual function 'close' is called from destructor '~MemoryStream()' at line 137. Dynamic binding is not used. [virtualCallInConstructor] mednafen/src/MemoryStream.cpp:137:2: note: Calling close mednafen/src/MemoryStream.h:69:15: note: close is a virtual function mednafen/src/MemoryStream.h:42:2: style: Class 'MemoryStream' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/MemoryStream.h:43:2: style: Class 'MemoryStream' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/MemoryStream.cpp:43:7: error: Common realloc mistake: 'data_buffer' nulled but not freed upon failure [memleakOnRealloc] mednafen/src/MemoryStream.cpp:65:7: error: Common realloc mistake: 'data_buffer' nulled but not freed upon failure [memleakOnRealloc] mednafen/src/types.h:10:0: error: #error "Wrong include order for types.h" [preprocessorErrorDirective] mednafen/src/VirtualFS.cpp:169:17: error: Invalid mkdir() argument nr 2. A non-boolean value is required. [invalidFunctionArgBool] mednafen/src/Stream.cpp:253:28: error: Invalid read() argument nr 3. A non-boolean value is required. [invalidFunctionArgBool] mednafen/src/Stream.cpp:209:35: style:inconclusive: Function 'put_line' argument 1 names different: declaration 's' definition 'str'. [funcArgNamesDifferent] mednafen/src/Stream.h:229:28: note: Function 'put_line' argument 1 names different: declaration 's' definition 'str'. mednafen/src/Stream.cpp:209:35: note: Function 'put_line' argument 1 names different: declaration 's' definition 'str'. mednafen/src/apple2/notes/matrix.cpp:318:8: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] mednafen/src/cdplay/cdplay.cpp:175:18: warning: Either the condition 'adr<=0x3' is redundant or the array 'SubQBuf[3][12]' is accessed at index 3, which is out of bounds. [arrayIndexOutOfBoundsCond] mednafen/src/cdplay/cdplay.cpp:174:10: note: Assuming that condition 'adr<=0x3' is not redundant mednafen/src/cdplay/cdplay.cpp:172:21: note: Assignment to 'adr=sq[0]&0xF' mednafen/src/cdplay/cdplay.cpp:172:13: note: adr is assigned 'sq[0]&0xF' here. mednafen/src/cdplay/cdplay.cpp:175:18: note: Array index out of bounds mednafen/src/cdplay/cdplay.cpp:68:3: performance: Variable 'track' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/cdplay/cdplay.cpp:69:3: performance: Variable 'lba' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/cdplay/cdplay.cpp:70:3: performance: Variable 'final_lba' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/cdrom/CDAFReader.cpp:54:30: debug: Wrong data detected by condition !tok->next()->astOperand2() [DacaWrongData] mednafen/src/cdplay/cdplay.cpp:159:37: style: Parameter 'SubPWBuf' can be declared with const [constParameter] mednafen/src/cdrom/CDAFReader_MPC.cpp:39:2: style: Class 'CDAFReader_MPC' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/cdrom/CDAFReader_FLAC.cpp:45:13: style:inconclusive: Technically the member function 'Mednafen::CDAFReader_FLAC::eof_cb' can be const. [functionConst] mednafen/src/cdrom/CDAFReader_FLAC.cpp:131:36: note: Technically the member function 'Mednafen::CDAFReader_FLAC::eof_cb' can be const. mednafen/src/cdrom/CDAFReader_FLAC.cpp:45:13: note: Technically the member function 'Mednafen::CDAFReader_FLAC::eof_cb' can be const. mednafen/src/cdrom/CDAFReader_FLAC.cpp:47:7: performance:inconclusive: Technically the member function 'Mednafen::CDAFReader_FLAC::metadata_cb' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/cdrom/CDAFReader_FLAC.cpp:182:30: note: Technically the member function 'Mednafen::CDAFReader_FLAC::metadata_cb' can be static (but you may consider moving to unnamed namespace). mednafen/src/cdrom/CDAFReader_FLAC.cpp:47:7: note: Technically the member function 'Mednafen::CDAFReader_FLAC::metadata_cb' can be static (but you may consider moving to unnamed namespace). mednafen/src/cdrom/CDAFReader_FLAC.cpp:48:7: performance:inconclusive: Technically the member function 'Mednafen::CDAFReader_FLAC::error_cb' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/cdrom/CDAFReader_FLAC.cpp:187:30: note: Technically the member function 'Mednafen::CDAFReader_FLAC::error_cb' can be static (but you may consider moving to unnamed namespace). mednafen/src/cdrom/CDAFReader_FLAC.cpp:48:7: note: Technically the member function 'Mednafen::CDAFReader_FLAC::error_cb' can be static (but you may consider moving to unnamed namespace). mednafen/src/cdrom/CDAFReader_FLAC.cpp:34:2: style: Class 'CDAFReader_FLAC' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/cdrom/CDAFReader_FLAC.cpp:195:10: style: C-style pointer casting [cstyleCast] mednafen/src/cdrom/CDAFReader_FLAC.cpp:200:10: style: C-style pointer casting [cstyleCast] mednafen/src/cdrom/CDAFReader_FLAC.cpp:205:10: style: C-style pointer casting [cstyleCast] mednafen/src/cdrom/CDAFReader_FLAC.cpp:210:10: style: C-style pointer casting [cstyleCast] mednafen/src/cdrom/CDAFReader_FLAC.cpp:215:10: style: C-style pointer casting [cstyleCast] mednafen/src/cdrom/CDAFReader_FLAC.cpp:220:10: style: C-style pointer casting [cstyleCast] mednafen/src/cdrom/CDAFReader_FLAC.cpp:225:10: style: C-style pointer casting [cstyleCast] mednafen/src/cdrom/CDAFReader_FLAC.cpp:230:10: style: C-style pointer casting [cstyleCast] mednafen/src/cdrom/CDAFReader_Vorbis.cpp:38:2: style: Class 'CDAFReader_Vorbis' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/cdrom/CDAccess_Image.h:72:15: style: The function 'Read_Raw_Sector' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/cdrom/CDAccess.h:37:15: note: Virtual function in base class mednafen/src/cdrom/CDAccess_Image.h:72:15: note: Function in derived class mednafen/src/cdrom/CDAccess_Image.h:74:15: style: The function 'Fast_Read_Raw_PW_TSRE' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/cdrom/CDAccess.h:43:15: note: Virtual function in base class mednafen/src/cdrom/CDAccess_Image.h:74:15: note: Function in derived class mednafen/src/cdrom/CDAccess_Image.h:76:15: style: The function 'Read_TOC' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/cdrom/CDAccess.h:45:15: note: Virtual function in base class mednafen/src/cdrom/CDAccess_Image.h:76:15: note: Function in derived class mednafen/src/cdrom/CDAccess_CCD.h:34:15: style: The function 'Read_Raw_Sector' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/cdrom/CDAccess.h:37:15: note: Virtual function in base class mednafen/src/cdrom/CDAccess_CCD.h:34:15: note: Function in derived class mednafen/src/cdrom/CDAccess_CCD.h:36:15: style: The function 'Fast_Read_Raw_PW_TSRE' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/cdrom/CDAccess.h:43:15: note: Virtual function in base class mednafen/src/cdrom/CDAccess_CCD.h:36:15: note: Function in derived class mednafen/src/cdrom/CDAccess_CCD.h:38:15: style: The function 'Read_TOC' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/cdrom/CDAccess.h:45:15: note: Virtual function in base class mednafen/src/cdrom/CDAccess_CCD.h:38:15: note: Function in derived class mednafen/src/cdrom/CDInterface_MT.h:78:3: style: Class 'CDInterface_Message' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/cdrom/CDInterface_ST.h:36:2: style: Class 'CDInterface_ST' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/cdrom/CDInterface.cpp:116:84: style:inconclusive: Function 'CDInterface_Stream_Thing' argument 2 names different: declaration 'lba_arg' definition 'start_lba_arg'. [funcArgNamesDifferent] mednafen/src/cdrom/CDInterface.cpp:94:59: note: Function 'CDInterface_Stream_Thing' argument 2 names different: declaration 'lba_arg' definition 'start_lba_arg'. mednafen/src/cdrom/CDInterface.cpp:116:84: note: Function 'CDInterface_Stream_Thing' argument 2 names different: declaration 'lba_arg' definition 'start_lba_arg'. mednafen/src/cdrom/CDInterface_MT.cpp:30:38: warning: Member variable 'CDInterface_Message::parg' is not initialized in the constructor. [uninitMemberVar] mednafen/src/cdrom/CDInterface_MT.cpp:37:38: warning: Member variable 'CDInterface_Message::parg' is not initialized in the constructor. [uninitMemberVar] mednafen/src/cdrom/CDInterface_MT.cpp:46:38: warning: Member variable 'CDInterface_Message::parg' is not initialized in the constructor. [uninitMemberVar] mednafen/src/cdrom/CDInterface_MT.cpp:49:2: performance: Variable 'str_message' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/cdrom/CDInterface_MT.cpp:127:10: style: C-style pointer casting [cstyleCast] mednafen/src/cdrom/lec.cpp:252:13: style: The scope of the variable 'r' can be reduced. [variableScope] mednafen/src/cdrom/lec.cpp:296:12: style: The scope of the variable 'd' can be reduced. [variableScope] mednafen/src/cdrom/lec.cpp:392:13: style: The scope of the variable 'p01_msb' can be reduced. [variableScope] mednafen/src/cdrom/lec.cpp:392:22: style: The scope of the variable 'p01_lsb' can be reduced. [variableScope] mednafen/src/cdrom/lec.cpp:394:13: style: The scope of the variable 'p_lsb' can be reduced. [variableScope] mednafen/src/cdrom/lec.cpp:437:13: style: The scope of the variable 'q01_lsb' can be reduced. [variableScope] mednafen/src/cdrom/lec.cpp:437:22: style: The scope of the variable 'q01_msb' can be reduced. [variableScope] mednafen/src/cdrom/lec.cpp:439:13: style: The scope of the variable 'q_lsb' can be reduced. [variableScope] mednafen/src/cdrom/CDAFReader_PCM.cpp:32:2: style: Class 'CDAFReader_PCM' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/cheat_formats/psx.cpp:98:2: style:inconclusive: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] mednafen/src/compress/GZFileStream.cpp:46:2: performance: Variable 'path_save' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/compress/GZFileStream.h:56:15: style: Virtual function 'close' is called from destructor '~GZFileStream()' at line 128. Dynamic binding is not used. [virtualCallInConstructor] mednafen/src/compress/GZFileStream.cpp:128:3: note: Calling close mednafen/src/compress/GZFileStream.h:56:15: note: close is a virtual function mednafen/src/compress/GZFileStream.cpp:151:58: style:inconclusive: Function 'read' argument 3 names different: declaration 'error_on_eos' definition 'error_on_eof'. [funcArgNamesDifferent] mednafen/src/compress/GZFileStream.h:50:53: note: Function 'read' argument 3 names different: declaration 'error_on_eos' definition 'error_on_eof'. mednafen/src/compress/GZFileStream.cpp:151:58: note: Function 'read' argument 3 names different: declaration 'error_on_eos' definition 'error_on_eof'. mednafen/src/compress/ZLInflateFilter.h:51:15: style: Virtual function 'close' is called from destructor '~ZLInflateFilter()' at line 74. Dynamic binding is not used. [virtualCallInConstructor] mednafen/src/compress/ZLInflateFilter.cpp:74:3: note: Calling close mednafen/src/compress/ZLInflateFilter.h:51:15: note: close is a virtual function mednafen/src/compress/ZLInflateFilter.cpp:31:76: style:inconclusive: Function 'ZLInflateFilter' argument 2 names different: declaration 'vfcontext' definition 'vfc'. [funcArgNamesDifferent] mednafen/src/compress/ZLInflateFilter.h:44:60: note: Function 'ZLInflateFilter' argument 2 names different: declaration 'vfcontext' definition 'vfc'. mednafen/src/compress/ZLInflateFilter.cpp:31:76: note: Function 'ZLInflateFilter' argument 2 names different: declaration 'vfcontext' definition 'vfc'. mednafen/src/compress/ZIPReader.cpp:315:35: error: The address of local variable 'buf' is accessed at non-zero index. [objectIndex] mednafen/src/compress/ZIPReader.cpp:292:13: note: Address of variable taken here. mednafen/src/compress/ZIPReader.cpp:297:5: note: Assuming condition is false mednafen/src/compress/ZIPReader.cpp:315:35: note: The address of local variable 'buf' is accessed at non-zero index. mednafen/src/compress/ZIPReader.cpp:316:44: error: The address of local variable 'buf' is accessed at non-zero index. [objectIndex] mednafen/src/compress/ZIPReader.cpp:292:13: note: Address of variable taken here. mednafen/src/compress/ZIPReader.cpp:297:5: note: Assuming condition is false mednafen/src/compress/ZIPReader.cpp:316:44: note: The address of local variable 'buf' is accessed at non-zero index. mednafen/src/compress/ZIPReader.cpp:317:45: error: The address of local variable 'buf' is accessed at non-zero index. [objectIndex] mednafen/src/compress/ZIPReader.cpp:292:13: note: Address of variable taken here. mednafen/src/compress/ZIPReader.cpp:297:5: note: Assuming condition is false mednafen/src/compress/ZIPReader.cpp:317:45: note: The address of local variable 'buf' is accessed at non-zero index. mednafen/src/compress/ZIPReader.cpp:318:46: error: The address of local variable 'buf' is accessed at non-zero index. [objectIndex] mednafen/src/compress/ZIPReader.cpp:292:13: note: Address of variable taken here. mednafen/src/compress/ZIPReader.cpp:297:5: note: Assuming condition is false mednafen/src/compress/ZIPReader.cpp:318:46: note: The address of local variable 'buf' is accessed at non-zero index. mednafen/src/compress/ZIPReader.cpp:319:38: error: The address of local variable 'buf' is accessed at non-zero index. [objectIndex] mednafen/src/compress/ZIPReader.cpp:292:13: note: Address of variable taken here. mednafen/src/compress/ZIPReader.cpp:297:5: note: Assuming condition is false mednafen/src/compress/ZIPReader.cpp:319:38: note: The address of local variable 'buf' is accessed at non-zero index. mednafen/src/compress/ZIPReader.cpp:320:38: error: The address of local variable 'buf' is accessed at non-zero index. [objectIndex] mednafen/src/compress/ZIPReader.cpp:292:13: note: Address of variable taken here. mednafen/src/compress/ZIPReader.cpp:297:5: note: Assuming condition is false mednafen/src/compress/ZIPReader.cpp:320:38: note: The address of local variable 'buf' is accessed at non-zero index. mednafen/src/compress/ZIPReader.cpp:321:43: error: The address of local variable 'buf' is accessed at non-zero index. [objectIndex] mednafen/src/compress/ZIPReader.cpp:292:13: note: Address of variable taken here. mednafen/src/compress/ZIPReader.cpp:297:5: note: Assuming condition is false mednafen/src/compress/ZIPReader.cpp:321:43: note: The address of local variable 'buf' is accessed at non-zero index. mednafen/src/cputest/cputest.c:27:30: style:inconclusive: Function 'cputest_force_flags' argument 1 names different: declaration 'flags' definition 'arg'. [funcArgNamesDifferent] mednafen/src/cputest/cputest.h:60:30: note: Function 'cputest_force_flags' argument 1 names different: declaration 'flags' definition 'arg'. mednafen/src/cputest/cputest.c:27:30: note: Function 'cputest_force_flags' argument 1 names different: declaration 'flags' definition 'arg'. mednafen/src/compress/ZIPReader.h:31:2: style: Class 'ZIPReader' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/compress/ZIPReader.cpp:228:19: style: Variable 'lfh.version_need' is assigned a value that is never used. [unreadVariable] mednafen/src/compress/ZIPReader.cpp:231:19: style: Variable 'lfh.mod_time' is assigned a value that is never used. [unreadVariable] mednafen/src/compress/ZIPReader.cpp:232:19: style: Variable 'lfh.mod_date' is assigned a value that is never used. [unreadVariable] mednafen/src/compress/ZIPReader.cpp:233:19: style: Variable 'lfh.crc32' is assigned a value that is never used. [unreadVariable] mednafen/src/compress/ZIPReader.cpp:234:19: style: Variable 'lfh.comp_size' is assigned a value that is never used. [unreadVariable] mednafen/src/compress/ZIPReader.cpp:235:19: style: Variable 'lfh.uncomp_size' is assigned a value that is never used. [unreadVariable] mednafen/src/compress/ZIPReader.cpp:314:13: style: Variable 'eocdr.sig' is assigned a value that is never used. [unreadVariable] mednafen/src/compress/ZIPReader.cpp:319:16: style: Variable 'eocdr.cd_size' is assigned a value that is never used. [unreadVariable] mednafen/src/compress/ZIPReader.cpp:321:21: style: Variable 'eocdr.comment_size' is assigned a value that is never used. [unreadVariable] mednafen/src/cputest/x86_cpu.c:48:17: style: union member 'Anonymous0::i' is never used. [unusedStructMember] mednafen/src/desa68/desa68.c:471:14: style: Condition 'bit==0' is always true [knownConditionTrueFalse] mednafen/src/desa68/desa68.c:469:6: note: Assuming that condition 'bit' is not redundant mednafen/src/desa68/desa68.c:471:14: note: Condition 'bit==0' is always true mednafen/src/desa68/desa68.c:669:3: warning: Suspicious use of ; at the end of 'if' statement. [suspiciousSemicolon] mednafen/src/desa68/desa68.c:1434:27: style:inconclusive: Function 'desa68' argument 1 names different: declaration 'd' definition 'dparm'. [funcArgNamesDifferent] mednafen/src/desa68/desa68.h:224:27: note: Function 'desa68' argument 1 names different: declaration 'd' definition 'dparm'. mednafen/src/desa68/desa68.c:1434:27: note: Function 'desa68' argument 1 names different: declaration 'd' definition 'dparm'. mednafen/src/desa68/desa68.c:532:14: style: Variable 'fn' can be declared with const [constVariable] mednafen/src/apple2/apple2.cpp:282:40: style:inconclusive: Boolean expression 'LangRAMPrevA1' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/apple2/apple2.cpp:282:72: style:inconclusive: Boolean expression '(bool)(A&1)' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/apple2/apple2.cpp:283:33: style:inconclusive: Boolean expression '(bool)(A&1)' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/cdrom/SimpleFIFO.h:97:10: warning: Assert statement calls a function which may have desired side effects: 'CanWrite'. [assertWithSideEffect] mednafen/src/cdrom/scsicd.cpp:1938:34: style:inconclusive: Boolean expression '!(toc.tracks[track].control)' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/cdrom/SimpleFIFO.h:13:2: style: Class 'SimpleFIFO < uint8 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/cdrom/scsicd.cpp:1938:34: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] mednafen/src/cdrom/scsicd.cpp:2869:4: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] mednafen/src/cdrom/scsicd.cpp:2876:4: note: Found duplicate branches for 'if' and 'else'. mednafen/src/cdrom/scsicd.cpp:2869:4: note: Found duplicate branches for 'if' and 'else'. mednafen/src/cdrom/scsicd.cpp:513:26: style:inconclusive: Function 'SCSICD_SetDisc' argument 1 names different: declaration 'tray_open' definition 'new_tray_open'. [funcArgNamesDifferent] mednafen/src/cdrom/scsicd.h:100:26: note: Function 'SCSICD_SetDisc' argument 1 names different: declaration 'tray_open' definition 'new_tray_open'. mednafen/src/cdrom/scsicd.cpp:513:26: note: Function 'SCSICD_SetDisc' argument 1 names different: declaration 'tray_open' definition 'new_tray_open'. mednafen/src/cdrom/scsicd.cpp:3132:32: style:inconclusive: Function 'SCSICD_Init' argument 2 names different: declaration 'CDDATimeDiv' definition 'cdda_time_div'. [funcArgNamesDifferent] mednafen/src/cdrom/scsicd.h:93:32: note: Function 'SCSICD_Init' argument 2 names different: declaration 'CDDATimeDiv' definition 'cdda_time_div'. mednafen/src/cdrom/scsicd.cpp:3132:32: note: Function 'SCSICD_Init' argument 2 names different: declaration 'CDDATimeDiv' definition 'cdda_time_div'. mednafen/src/drivers/Joystick.h:13:21: style:inconclusive: Technically the member function 'Joystick::Name' can be const. [functionConst] mednafen/src/drivers/Joystick.cpp:189:18: style: Condition 'hicp_driver!=NULL' is always false [knownConditionTrueFalse] mednafen/src/drivers/Joystick.cpp:171:32: note: Assignment 'hicp_driver=NULL', assigned value is 0 mednafen/src/drivers/Joystick.cpp:189:18: note: Condition 'hicp_driver!=NULL' is always false mednafen/src/drivers/Joystick.cpp:194:18: style: Condition 'main_driver!=NULL' is always false [knownConditionTrueFalse] mednafen/src/drivers/Joystick.cpp:170:32: note: Assignment 'main_driver=NULL', assigned value is 0 mednafen/src/drivers/Joystick.cpp:194:18: note: Condition 'main_driver!=NULL' is always false mednafen/src/drivers/Joystick.cpp:248:18: style: Condition 'main_driver!=NULL' is always false [knownConditionTrueFalse] mednafen/src/drivers/Joystick.cpp:170:32: note: Assignment 'main_driver=NULL', assigned value is 0 mednafen/src/drivers/Joystick.cpp:248:18: note: Condition 'main_driver!=NULL' is always false mednafen/src/drivers/Joystick.cpp:253:18: style: Condition 'hicp_driver!=NULL' is always false [knownConditionTrueFalse] mednafen/src/drivers/Joystick.cpp:171:32: note: Assignment 'hicp_driver=NULL', assigned value is 0 mednafen/src/drivers/Joystick.cpp:253:18: note: Condition 'hicp_driver!=NULL' is always false mednafen/src/drivers/Joystick.cpp:59:35: style:inconclusive: Function 'Calc09xID' argument 1 names different: declaration 'num_axes' definition 'arg_num_axes'. [funcArgNamesDifferent] mednafen/src/drivers/Joystick.h:32:26: note: Function 'Calc09xID' argument 1 names different: declaration 'num_axes' definition 'arg_num_axes'. mednafen/src/drivers/Joystick.cpp:59:35: note: Function 'Calc09xID' argument 1 names different: declaration 'num_axes' definition 'arg_num_axes'. mednafen/src/drivers/Joystick.cpp:59:58: style:inconclusive: Function 'Calc09xID' argument 2 names different: declaration 'num_balls' definition 'arg_num_balls'. [funcArgNamesDifferent] mednafen/src/drivers/Joystick.h:32:45: note: Function 'Calc09xID' argument 2 names different: declaration 'num_balls' definition 'arg_num_balls'. mednafen/src/drivers/Joystick.cpp:59:58: note: Function 'Calc09xID' argument 2 names different: declaration 'num_balls' definition 'arg_num_balls'. mednafen/src/drivers/Joystick.cpp:59:82: style:inconclusive: Function 'Calc09xID' argument 3 names different: declaration 'num_hats' definition 'arg_num_hats'. [funcArgNamesDifferent] mednafen/src/drivers/Joystick.h:32:65: note: Function 'Calc09xID' argument 3 names different: declaration 'num_hats' definition 'arg_num_hats'. mednafen/src/drivers/Joystick.cpp:59:82: note: Function 'Calc09xID' argument 3 names different: declaration 'num_hats' definition 'arg_num_hats'. mednafen/src/drivers/Joystick.cpp:59:105: style:inconclusive: Function 'Calc09xID' argument 4 names different: declaration 'num_buttons' definition 'arg_num_buttons'. [funcArgNamesDifferent] mednafen/src/drivers/Joystick.h:32:84: note: Function 'Calc09xID' argument 4 names different: declaration 'num_buttons' definition 'arg_num_buttons'. mednafen/src/drivers/Joystick.cpp:59:105: note: Function 'Calc09xID' argument 4 names different: declaration 'num_buttons' definition 'arg_num_buttons'. mednafen/src/drivers/Joystick_DX5.cpp:260:2: style: Class 'JoystickDriver_DX5' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/drivers/Joystick_DX5.cpp:45:19: style: The function 'HatToAxisCompat' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/drivers/Joystick.h:27:19: note: Virtual function in base class mednafen/src/drivers/Joystick_DX5.cpp:45:19: note: Function in derived class mednafen/src/drivers/Joystick_DX5.cpp:46:15: style: The function 'SetRumble' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/drivers/Joystick.h:26:15: note: Virtual function in base class mednafen/src/drivers/Joystick_DX5.cpp:46:15: note: Function in derived class mednafen/src/drivers/Joystick_DX5.cpp:263:19: style: The function 'NumJoysticks' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/drivers/Joystick.h:55:19: note: Virtual function in base class mednafen/src/drivers/Joystick_DX5.cpp:263:19: note: Function in derived class mednafen/src/drivers/Joystick_DX5.cpp:264:20: style: The function 'GetJoystick' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/drivers/Joystick.h:56:20: note: Virtual function in base class mednafen/src/drivers/Joystick_DX5.cpp:264:20: note: Function in derived class mednafen/src/drivers/Joystick_DX5.cpp:265:15: style: The function 'UpdateJoysticks' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/drivers/Joystick.h:57:15: note: Virtual function in base class mednafen/src/drivers/Joystick_DX5.cpp:265:15: note: Function in derived class mednafen/src/drivers/Joystick_DX5.cpp:343:26: style: C-style pointer casting [cstyleCast] mednafen/src/demo/demo.cpp:546:3: portability: Using memset() on struct which contains a floating point number. [memsetClassFloat] mednafen/src/drivers/Joystick_SDL.cpp:34:2: style: Class 'Joystick_SDL' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/drivers/Joystick_SDL.cpp:39:19: style: The function 'HatToButtonCompat' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/drivers/Joystick.h:28:19: note: Virtual function in base class mednafen/src/drivers/Joystick_SDL.cpp:39:19: note: Function in derived class mednafen/src/drivers/Joystick_SDL.cpp:159:19: style: The function 'NumJoysticks' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/drivers/Joystick.h:55:19: note: Virtual function in base class mednafen/src/drivers/Joystick_SDL.cpp:159:19: note: Function in derived class mednafen/src/drivers/Joystick_SDL.cpp:160:20: style: The function 'GetJoystick' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/drivers/Joystick.h:56:20: note: Virtual function in base class mednafen/src/drivers/Joystick_SDL.cpp:160:20: note: Function in derived class mednafen/src/drivers/Joystick_SDL.cpp:161:15: style: The function 'UpdateJoysticks' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/drivers/Joystick.h:57:15: note: Virtual function in base class mednafen/src/drivers/Joystick_SDL.cpp:161:15: note: Function in derived class mednafen/src/drivers/Joystick_SDL.cpp:101:6: style: Condition 'sdl_joy' is always true [knownConditionTrueFalse] mednafen/src/drivers/Joystick_Linux.cpp:638:3: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled] mednafen/src/drivers/Joystick_Linux.cpp:646:3: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled] mednafen/src/drivers/Joystick_Linux.cpp:654:3: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled] mednafen/src/drivers/Joystick_Linux.cpp:52:14: style:inconclusive: Technically the member function 'Joystick_Linux::RumbleUsed' can be const. [functionConst] mednafen/src/drivers/Joystick_Linux.cpp:46:19: style: The function 'HatToAxisCompat' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/drivers/Joystick.h:27:19: note: Virtual function in base class mednafen/src/drivers/Joystick_Linux.cpp:46:19: note: Function in derived class mednafen/src/drivers/Joystick_Linux.cpp:50:7: style: The function 'SetRumble' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/drivers/Joystick.h:26:15: note: Virtual function in base class mednafen/src/drivers/Joystick_Linux.cpp:50:7: note: Function in derived class mednafen/src/drivers/Joystick_Linux.cpp:398:19: style: The function 'NumJoysticks' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/drivers/Joystick.h:55:19: note: Virtual function in base class mednafen/src/drivers/Joystick_Linux.cpp:398:19: note: Function in derived class mednafen/src/drivers/Joystick_Linux.cpp:399:20: style: The function 'GetJoystick' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/drivers/Joystick.h:56:20: note: Virtual function in base class mednafen/src/drivers/Joystick_Linux.cpp:399:20: note: Function in derived class mednafen/src/drivers/Joystick_Linux.cpp:400:15: style: The function 'UpdateJoysticks' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/drivers/Joystick.h:57:15: note: Virtual function in base class mednafen/src/drivers/Joystick_Linux.cpp:400:15: note: Function in derived class mednafen/src/drivers/Joystick_Linux.cpp:82:30: style: Parameter 'data' can be declared with const [constParameter] mednafen/src/drivers/Joystick_XInput.cpp:49:15: style: The function 'SetRumble' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/drivers/Joystick.h:26:15: note: Virtual function in base class mednafen/src/drivers/Joystick_XInput.cpp:49:15: note: Function in derived class mednafen/src/drivers/Joystick_XInput.cpp:50:15: style: The function 'IsAxisButton' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/drivers/Joystick.h:25:15: note: Virtual function in base class mednafen/src/drivers/Joystick_XInput.cpp:50:15: note: Function in derived class mednafen/src/drivers/Joystick_XInput.cpp:160:19: style: The function 'NumJoysticks' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/drivers/Joystick.h:55:19: note: Virtual function in base class mednafen/src/drivers/Joystick_XInput.cpp:160:19: note: Function in derived class mednafen/src/drivers/Joystick_XInput.cpp:161:20: style: The function 'GetJoystick' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/drivers/Joystick.h:56:20: note: Virtual function in base class mednafen/src/drivers/Joystick_XInput.cpp:161:20: note: Function in derived class mednafen/src/drivers/Joystick_XInput.cpp:162:15: style: The function 'UpdateJoysticks' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/drivers/Joystick.h:57:15: note: Virtual function in base class mednafen/src/drivers/Joystick_XInput.cpp:162:15: note: Function in derived class mednafen/src/drivers/TextEntry.h:37:31: style:inconclusive: Technically the member function 'TextEntry::GetKBB' can be const. [functionConst] mednafen/src/drivers/console.cpp:31:2: performance: Variable 'Scrolled' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/drivers/console.cpp:32:2: performance: Variable 'opacity' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/drivers/console.cpp:34:2: performance: Variable 'ScrolledVecTarg' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/drivers/console.cpp:35:2: performance: Variable 'LastPageSize' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/drivers/console.h:28:3: warning:inconclusive: Class 'MDFNConsole' which has virtual members does not have a virtual destructor. [virtualDestructor] mednafen/src/drivers/console.cpp:27:31: style:inconclusive: Function 'MDFNConsole' argument 1 names different: declaration 'shellstyle' definition 'setshellstyle'. [funcArgNamesDifferent] mednafen/src/drivers/console.h:27:19: note: Function 'MDFNConsole' argument 1 names different: declaration 'shellstyle' definition 'setshellstyle'. mednafen/src/drivers/console.cpp:27:31: note: Function 'MDFNConsole' argument 1 names different: declaration 'shellstyle' definition 'setshellstyle'. mednafen/src/drivers/ers.cpp:14:2: performance: Variable 'EmuClock' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/drivers/cheat.cpp:335:10: performance: Variable 'text' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/drivers/help.cpp:30:21: debug: Wrong data detected by condition !tok->next()->astOperand2() [DacaWrongData] mednafen/src/drivers/gfxdebugger.cpp:70:11: style: Expression is always true because 'else if' condition is opposite to previous condition at line 62. [multiCondition] mednafen/src/drivers/gfxdebugger.cpp:62:6: note: first condition mednafen/src/drivers/gfxdebugger.cpp:70:11: note: else if condition is opposite to first condition mednafen/src/drivers/gfxdebugger.cpp:93:5: style: Condition 'ism' is always false [knownConditionTrueFalse] mednafen/src/drivers/gfxdebugger.cpp:91:47: note: Assignment 'ism=Debugger_GT_IsInSteppingMode()', assigned value is 0 mednafen/src/drivers/gfxdebugger.cpp:93:5: note: Condition 'ism' is always false mednafen/src/cdrom/CDAccess_Image.h:101:9: performance:inconclusive: Technically the member function 'Mednafen::CDAccess_Image::GetSectorCount' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/cdrom/CDAccess_Image.cpp:171:24: note: Technically the member function 'Mednafen::CDAccess_Image::GetSectorCount' can be static (but you may consider moving to unnamed namespace). mednafen/src/cdrom/CDAccess_Image.h:101:9: note: Technically the member function 'Mednafen::CDAccess_Image::GetSectorCount' can be static (but you may consider moving to unnamed namespace). mednafen/src/cdrom/CDAccess_Image.cpp:479:19: style: Variable 'active_track' is reassigned a value before the old one has been used. [redundantAssignment] mednafen/src/cdrom/CDAccess_Image.cpp:468:20: note: active_track is assigned mednafen/src/cdrom/CDAccess_Image.cpp:479:19: note: active_track is overwritten mednafen/src/cdrom/CDAccess_Image.cpp:1293:36: style:inconclusive: Function 'Read_TOC' argument 1 names different: declaration 'toc' definition 'rtoc'. [funcArgNamesDifferent] mednafen/src/cdrom/CDAccess_Image.h:76:40: note: Function 'Read_TOC' argument 1 names different: declaration 'toc' definition 'rtoc'. mednafen/src/cdrom/CDAccess_Image.cpp:1293:36: note: Function 'Read_TOC' argument 1 names different: declaration 'toc' definition 'rtoc'. mednafen/src/drivers/debugger.cpp:527:7: style: The function 'TheEnd' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/drivers/prompt.h:19:22: note: Virtual function in base class mednafen/src/drivers/debugger.cpp:527:7: note: Function in derived class mednafen/src/drivers/debugger.cpp:235:10: style: The scope of the variable 'sa1' can be reduced. [variableScope] mednafen/src/drivers/debugger.cpp:235:19: style: The scope of the variable 'sa2' can be reduced. [variableScope] mednafen/src/drivers/debugger.cpp:637:29: style: Variable 'meow_str' is assigned a value that is never used. [unreadVariable] mednafen/src/drivers/keyboard.cpp:185:87: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] mednafen/intl/loadmsgcat.c:861:12: style: The comparison 'data == (struct mo_file_header*)-1' is always true because 'data' and '(struct mo_file_header*)-1' represent the same value. [knownConditionTrueFalse] mednafen/intl/loadmsgcat.c:791:33: note: 'data' is assigned value '(struct mo_file_header*)-1' here. mednafen/intl/loadmsgcat.c:861:12: note: The comparison 'data == (struct mo_file_header*)-1' is always true because 'data' and '(struct mo_file_header*)-1' represent the same value. mednafen/intl/loadmsgcat.c:780:42: style:inconclusive: Function '_nl_load_domain' argument 1 names different: declaration '__domain' definition 'domain_file'. [funcArgNamesDifferent] mednafen/intl/gettextP.h:261:47: note: Function '_nl_load_domain' argument 1 names different: declaration '__domain' definition 'domain_file'. mednafen/intl/loadmsgcat.c:780:42: note: Function '_nl_load_domain' argument 1 names different: declaration '__domain' definition 'domain_file'. mednafen/intl/loadmsgcat.c:781:20: style:inconclusive: Function '_nl_load_domain' argument 2 names different: declaration '__domainbinding' definition 'domainbinding'. [funcArgNamesDifferent] mednafen/intl/gettextP.h:262:25: note: Function '_nl_load_domain' argument 2 names different: declaration '__domainbinding' definition 'domainbinding'. mednafen/intl/loadmsgcat.c:781:20: note: Function '_nl_load_domain' argument 2 names different: declaration '__domainbinding' definition 'domainbinding'. mednafen/src/drivers/logdebugger.cpp:131:67: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/drivers/logdebugger.cpp:186:67: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/drivers/memdebugger.h:45:21: performance:inconclusive: Technically the member function 'MemDebugger::TextToBS' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/drivers/memdebugger.cpp:153:33: note: Technically the member function 'MemDebugger::TextToBS' can be static (but you may consider moving to unnamed namespace). mednafen/src/drivers/memdebugger.h:45:21: note: Technically the member function 'MemDebugger::TextToBS' can be static (but you may consider moving to unnamed namespace). mednafen/src/drivers/memdebugger.cpp:84:14: style: The function 'TheEnd' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/drivers/prompt.h:19:22: note: Virtual function in base class mednafen/src/drivers/memdebugger.cpp:84:14: note: Function in derived class mednafen/src/drivers/memdebugger.cpp:34:27: style: Redundant initialization for 'new_ict_game_to_utf8'. The initialized value is overwritten before it is read. [redundantInitialization] mednafen/src/drivers/memdebugger.cpp:32:31: note: new_ict_game_to_utf8 is initialized mednafen/src/drivers/memdebugger.cpp:34:27: note: new_ict_game_to_utf8 is overwritten mednafen/src/drivers/memdebugger.cpp:34:99: style: Redundant initialization for 'new_ict_utf8_to_game'. The initialized value is overwritten before it is read. [redundantInitialization] mednafen/src/drivers/memdebugger.cpp:32:67: note: new_ict_utf8_to_game is initialized mednafen/src/drivers/memdebugger.cpp:34:99: note: new_ict_utf8_to_game is overwritten mednafen/src/drivers/memdebugger.cpp:66:19: style: Variable 'ict_utf8_to_game' is reassigned a value before the old one has been used. [redundantAssignment] mednafen/src/drivers/memdebugger.cpp:62:20: note: ict_utf8_to_game is assigned mednafen/src/drivers/memdebugger.cpp:66:19: note: ict_utf8_to_game is overwritten mednafen/src/drivers/2xSaI.cpp:1107:21: style: Condition 'y1<=x1' is always true [knownConditionTrueFalse] mednafen/src/drivers/2xSaI.cpp:1102:21: note: Assuming that condition 'y1>=x1' is not redundant mednafen/src/drivers/2xSaI.cpp:1107:21: note: Condition 'y1<=x1' is always true mednafen/src/drivers/2xSaI.cpp:1144:25: style: Condition 'y2<=x1' is always true [knownConditionTrueFalse] mednafen/src/drivers/2xSaI.cpp:1139:25: note: Assuming that condition 'y2>=x1' is not redundant mednafen/src/drivers/2xSaI.cpp:1144:25: note: Condition 'y2<=x1' is always true mednafen/src/drivers/2xSaI.cpp:160:11: style: The scope of the variable 'bP' can be reduced. [variableScope] mednafen/src/drivers/2xSaI.cpp:161:11: style: The scope of the variable 'dP' can be reduced. [variableScope] mednafen/src/drivers/2xSaI.cpp:291:11: style: The scope of the variable 'bP' can be reduced. [variableScope] mednafen/src/drivers/2xSaI.cpp:292:11: style: The scope of the variable 'dP' can be reduced. [variableScope] mednafen/src/drivers/2xSaI.cpp:413:11: style: The scope of the variable 'dP' can be reduced. [variableScope] mednafen/src/drivers/2xSaI.cpp:414:11: style: The scope of the variable 'bP' can be reduced. [variableScope] mednafen/src/drivers/2xSaI.cpp:543:12: style: The scope of the variable 'dP' can be reduced. [variableScope] mednafen/src/drivers/2xSaI.cpp:544:11: style: The scope of the variable 'bP' can be reduced. [variableScope] mednafen/src/drivers/2xSaI.cpp:666:11: style: The scope of the variable 'dP' can be reduced. [variableScope] mednafen/src/drivers/2xSaI.cpp:667:11: style: The scope of the variable 'bP' can be reduced. [variableScope] mednafen/src/drivers/2xSaI.cpp:829:12: style: The scope of the variable 'dP' can be reduced. [variableScope] mednafen/src/drivers/2xSaI.cpp:830:11: style: The scope of the variable 'bP' can be reduced. [variableScope] mednafen/src/drivers/2xSaI.cpp:1026:11: style: The scope of the variable 'dP' can be reduced. [variableScope] mednafen/src/drivers/mouse.cpp:162:14: style: Unused variable: ret [unusedVariable] mednafen/src/drivers/opengl.cpp:332:91: style:inconclusive: Boolean expression 'ShaderIlace' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/drivers/opengl.cpp:334:89: style:inconclusive: Boolean expression 'ShaderIlace' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/drivers/opengl.cpp:431:80: style:inconclusive: Boolean expression 'ShaderIlace' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/drivers/opengl.cpp:774:3: warning: Class 'OpenGL_Blitter' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] mednafen/src/drivers/opengl.cpp:774:3: warning: Class 'OpenGL_Blitter' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] mednafen/src/drivers/opengl.cpp:173:7: style: Variable 'dco' is assigned a value that is never used. [unreadVariable] mednafen/src/drivers/input.cpp:1713:14: style:inconclusive: Boolean expression 'ck_af' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/drivers/input.cpp:1719:14: style:inconclusive: Boolean expression 'ck_af' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/drivers/input.cpp:1719:14: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] mednafen/src/drivers/input.cpp:1480:23: style: Condition 'Debugger_IsActive()' is always false [knownConditionTrueFalse] mednafen/src/drivers/input.cpp:1644:7: style: Condition '!Debugger_IsActive()' is always true [knownConditionTrueFalse] mednafen/src/drivers/input.cpp:1661:27: style: Condition '!Debugger_IsActive()' is always true [knownConditionTrueFalse] mednafen/src/drivers/input.cpp:1724:6: style: Condition '!Debugger_IsActive()' is always true [knownConditionTrueFalse] mednafen/src/drivers/input.cpp:2718:22: style: Condition 'Debugger_IsActive()' is always false [knownConditionTrueFalse] mednafen/src/drivers/input.cpp:2249:63: style:inconclusive: Function 'subcon' argument 2 names different: declaration 'bc' definition 'bcg'. [funcArgNamesDifferent] mednafen/src/drivers/input.cpp:91:63: note: Function 'subcon' argument 2 names different: declaration 'bc' definition 'bcg'. mednafen/src/drivers/input.cpp:2249:63: note: Function 'subcon' argument 2 names different: declaration 'bc' definition 'bcg'. mednafen/src/drivers/rmdui.cpp:182:7: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] mednafen/src/drivers/scalebit.c:131:36: style: Same expression on both sides of '-'. [duplicateExpression] mednafen/src/drivers/scalebit.c:176:46: style: Same expression on both sides of '-'. [duplicateExpression] mednafen/src/drivers/sound.cpp:381:37: style:inconclusive: Function 'Sound_GetEmuModBuffer' argument 1 names different: declaration 'max_size' definition 'max_size_bytes'. [funcArgNamesDifferent] mednafen/src/drivers/sound.h:14:37: note: Function 'Sound_GetEmuModBuffer' argument 1 names different: declaration 'max_size' definition 'max_size_bytes'. mednafen/src/drivers/sound.cpp:381:37: note: Function 'Sound_GetEmuModBuffer' argument 1 names different: declaration 'max_size' definition 'max_size_bytes'. mednafen/src/drivers/nongl.cpp:353:19: style: Redundant condition: true. 'true && (true || sl&(1U<>20)&0x3F)<<20', assigned value is 33554432 mednafen/src/gba/GBA.cpp:801:24: note: Condition 'mirroredRomSize<=0x800000' is always false mednafen/src/drivers/main.cpp:2635:33: warning: Either the condition 'WhichVideoBuffer>=0' is redundant or the array 'SoftFB[2]' is accessed at index 2, which is out of bounds. [arrayIndexOutOfBoundsCond] mednafen/src/drivers/main.cpp:2617:22: note: Assuming that condition 'WhichVideoBuffer>=0' is not redundant mednafen/src/drivers/main.cpp:2635:33: note: Array index out of bounds mednafen/src/drivers/main.cpp:2636:28: warning: Either the condition 'WhichVideoBuffer>=0' is redundant or the array 'SoftFB[2]' is accessed at index 2, which is out of bounds. [arrayIndexOutOfBoundsCond] mednafen/src/drivers/main.cpp:2617:22: note: Assuming that condition 'WhichVideoBuffer>=0' is not redundant mednafen/src/drivers/main.cpp:2636:28: note: Array index out of bounds mednafen/src/drivers/main.cpp:2637:21: warning: Either the condition 'WhichVideoBuffer>=0' is redundant or the array 'SoftFB[2]' is accessed at index 2, which is out of bounds. [arrayIndexOutOfBoundsCond] mednafen/src/drivers/main.cpp:2617:22: note: Assuming that condition 'WhichVideoBuffer>=0' is not redundant mednafen/src/drivers/main.cpp:2637:21: note: Array index out of bounds mednafen/src/drivers/main.cpp:1518:23: style: Condition 'Debugger_IsActive()' is always false [knownConditionTrueFalse] mednafen/src/gba/RTC.cpp:40:2: performance: Variable 'sec' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/gba/RTC.cpp:41:2: performance: Variable 'min' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/gba/RTC.cpp:42:2: performance: Variable 'hour' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/gba/RTC.cpp:43:2: performance: Variable 'wday' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/gba/RTC.cpp:44:2: performance: Variable 'mday' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/gba/RTC.cpp:45:2: performance: Variable 'mon' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/gba/RTC.cpp:46:2: performance: Variable 'year' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/gba/RTC.h:39:9: style:inconclusive: Technically the member function 'MDFN_IEN_GBA::RTC::Read' can be const. [functionConst] mednafen/src/gba/RTC.cpp:169:13: note: Technically the member function 'MDFN_IEN_GBA::RTC::Read' can be const. mednafen/src/gba/RTC.h:39:9: note: Technically the member function 'MDFN_IEN_GBA::RTC::Read' can be const. mednafen/src/gba/RTC.h:66:7: performance:inconclusive: Technically the member function 'MDFN_IEN_GBA::RTC::BCDInc' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/gba/RTC.cpp:99:11: note: Technically the member function 'MDFN_IEN_GBA::RTC::BCDInc' can be static (but you may consider moving to unnamed namespace). mednafen/src/gba/RTC.h:66:7: note: Technically the member function 'MDFN_IEN_GBA::RTC::BCDInc' can be static (but you may consider moving to unnamed namespace). mednafen/src/gba/Gfx.cpp:699:7: style: The scope of the variable 'm' can be reduced. [variableScope] mednafen/src/gba/Gfx.cpp:414:14: style: Variable 'startX' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/Gfx.cpp:416:12: style: Variable 'startX' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/Gfx.cpp:417:14: style: Variable 'startY' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/Gfx.cpp:419:12: style: Variable 'startY' is assigned a value that is never used. [unreadVariable] mednafen/src/hash/md5.cpp:93:9: style: Variable 'ns' can be declared with const [constVariable] mednafen/src/hash/sha1.cpp:38:2: error: Found a exit path from function with non-void return type that has missing return statement [missingReturn] mednafen/src/hash/sha256.cpp:89:55: style:inconclusive: Function 'process_block' argument 1 names different: declaration 'data' definition 'blk_data'. [funcArgNamesDifferent] mednafen/src/hash/sha256.h:67:34: note: Function 'process_block' argument 1 names different: declaration 'data' definition 'blk_data'. mednafen/src/hash/sha256.cpp:89:55: note: Function 'process_block' argument 1 names different: declaration 'data' definition 'blk_data'. mednafen/src/hw_cpu/m68k/gen.cpp:189:22: style: The scope of the variable 'op_names' can be reduced. [variableScope] mednafen/src/hw_cpu/m68k/gen.cpp:234:22: style: The scope of the variable 'op_names' can be reduced. [variableScope] mednafen/src/hw_cpu/m68k/gen.cpp:357:18: style: Local variable 'szi' shadows outer variable [shadowVariable] mednafen/src/hw_cpu/m68k/gen.cpp:305:11: note: Shadowed declaration mednafen/src/hw_cpu/m68k/gen.cpp:357:18: note: Shadow variable mednafen/src/gb/gbCodesCB.h:479:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:483:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:487:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:491:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:495:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:499:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:504:53: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:508:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:512:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:516:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:520:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:524:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:528:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:532:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:537:53: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:541:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:545:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:549:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:553:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:557:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:561:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:565:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:570:53: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:574:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:578:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:582:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:586:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:590:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:594:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:598:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:603:53: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:607:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:611:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:615:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:619:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:623:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:627:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:631:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:636:53: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:640:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:644:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:648:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:652:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:656:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:660:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:664:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:669:53: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:673:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:677:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:681:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:685:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:689:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:693:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:697:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:702:53: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:706:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:710:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:714:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:718:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:722:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:726:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:730:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:735:53: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/gb/gbCodesCB.h:739:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] mednafen/src/hw_cpu/m68k/m68k.cpp:2252:34: warning: Assert statement calls a function which may have desired side effects: 'GetSR'. [assertWithSideEffect] mednafen/src/hw_cpu/m68k/m68k.cpp:426:3: error: Found a exit path from function with non-void return type that has missing return statement [missingReturn] mednafen/src/hw_cpu/m68k/m68k.cpp:1838:2: error: Found a exit path from function with non-void return type that has missing return statement [missingReturn] mednafen/src/hw_cpu/m68k/m68k.cpp:76:2: performance: Variable 'timestamp' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/hw_cpu/m68k/m68k.cpp:77:2: performance: Variable 'XPending' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/hw_cpu/m68k/m68k.cpp:78:2: performance: Variable 'IPL' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/hw_cpu/m68k/m68k.h:124:4: performance:inconclusive: Technically the member function 'Mednafen::M68K::Read < uint32 >' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/hw_cpu/m68k/m68k.cpp:185:16: note: Technically the member function 'Mednafen::M68K::Read < uint32 >' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/m68k/m68k.h:124:4: note: Technically the member function 'Mednafen::M68K::Read < uint32 >' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/m68k/m68k.h:129:7: performance:inconclusive: Technically the member function 'Mednafen::M68K::Write < uint32 , true >' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/hw_cpu/m68k/m68k.cpp:213:19: note: Technically the member function 'Mednafen::M68K::Write < uint32 , true >' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/m68k/m68k.h:129:7: note: Technically the member function 'Mednafen::M68K::Write < uint32 , true >' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/m68k/m68k.h:129:7: performance:inconclusive: Technically the member function 'Mednafen::M68K::Write < uint16 , true >' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/hw_cpu/m68k/m68k.cpp:213:19: note: Technically the member function 'Mednafen::M68K::Write < uint16 , true >' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/m68k/m68k.h:129:7: note: Technically the member function 'Mednafen::M68K::Write < uint16 , true >' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/m68k/m68k.h:177:7: style:inconclusive: Technically the member function 'Mednafen::M68K::GetC' can be const. [functionConst] mednafen/src/hw_cpu/m68k/m68k.cpp:513:19: note: Technically the member function 'Mednafen::M68K::GetC' can be const. mednafen/src/hw_cpu/m68k/m68k.h:177:7: note: Technically the member function 'Mednafen::M68K::GetC' can be const. mednafen/src/hw_cpu/m68k/m68k.h:178:7: style:inconclusive: Technically the member function 'Mednafen::M68K::GetV' can be const. [functionConst] mednafen/src/hw_cpu/m68k/m68k.cpp:514:19: note: Technically the member function 'Mednafen::M68K::GetV' can be const. mednafen/src/hw_cpu/m68k/m68k.h:178:7: note: Technically the member function 'Mednafen::M68K::GetV' can be const. mednafen/src/hw_cpu/m68k/m68k.h:179:7: style:inconclusive: Technically the member function 'Mednafen::M68K::GetZ' can be const. [functionConst] mednafen/src/hw_cpu/m68k/m68k.cpp:515:19: note: Technically the member function 'Mednafen::M68K::GetZ' can be const. mednafen/src/hw_cpu/m68k/m68k.h:179:7: note: Technically the member function 'Mednafen::M68K::GetZ' can be const. mednafen/src/hw_cpu/m68k/m68k.h:180:7: style:inconclusive: Technically the member function 'Mednafen::M68K::GetN' can be const. [functionConst] mednafen/src/hw_cpu/m68k/m68k.cpp:516:19: note: Technically the member function 'Mednafen::M68K::GetN' can be const. mednafen/src/hw_cpu/m68k/m68k.h:180:7: note: Technically the member function 'Mednafen::M68K::GetN' can be const. mednafen/src/hw_cpu/m68k/m68k.h:181:7: style:inconclusive: Technically the member function 'Mednafen::M68K::GetX' can be const. [functionConst] mednafen/src/hw_cpu/m68k/m68k.cpp:517:19: note: Technically the member function 'Mednafen::M68K::GetX' can be const. mednafen/src/hw_cpu/m68k/m68k.h:181:7: note: Technically the member function 'Mednafen::M68K::GetX' can be const. mednafen/src/hw_cpu/m68k/m68k.h:387:7: performance:inconclusive: Technically the member function 'Mednafen::M68K::TAS' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/hw_cpu/m68k/m68k.cpp:1721:19: note: Technically the member function 'Mednafen::M68K::TAS' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/m68k/m68k.h:387:7: note: Technically the member function 'Mednafen::M68K::TAS' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/m68k/m68k.h:421:7: performance:inconclusive: Technically the member function 'Mednafen::M68K::JMP' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/hw_cpu/m68k/m68k.cpp:1980:19: note: Technically the member function 'Mednafen::M68K::JMP' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/m68k/m68k.h:421:7: note: Technically the member function 'Mednafen::M68K::JMP' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/m68k/m68k.h:450:7: performance:inconclusive: Technically the member function 'Mednafen::M68K::NOP' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/hw_cpu/m68k/m68k.cpp:2172:19: note: Technically the member function 'Mednafen::M68K::NOP' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/m68k/m68k.h:450:7: note: Technically the member function 'Mednafen::M68K::NOP' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/m68k/m68k.cpp:268:9: style: Struct 'HAM' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/hw_cpu/v810/v810_fp_ops.h:27:1: style: The class 'V810_FP_Ops' does not have a constructor although it has private member variables. [noConstructor] mednafen/src/hw_cpu/v810/v810_cpu.cpp:60:7: warning: Member variable 'V810::PC_ptr' is not initialized in the constructor. [uninitMemberVar] mednafen/src/hw_cpu/v810/v810_cpu.cpp:60:7: warning: Member variable 'V810::PC_base' is not initialized in the constructor. [uninitMemberVar] mednafen/src/hw_cpu/v810/v810_cpu.cpp:60:7: warning: Member variable 'V810::EmuMode' is not initialized in the constructor. [uninitMemberVar] mednafen/src/hw_cpu/v810/v810_cpu.cpp:60:7: warning: Member variable 'V810::VBMode' is not initialized in the constructor. [uninitMemberVar] mednafen/src/hw_cpu/v810/v810_cpu.cpp:60:7: warning: Member variable 'V810::Running' is not initialized in the constructor. [uninitMemberVar] mednafen/src/hw_cpu/v810/v810_cpu.cpp:60:7: warning: Member variable 'V810::ilevel' is not initialized in the constructor. [uninitMemberVar] mednafen/src/hw_cpu/v810/v810_cpu.cpp:60:7: warning: Member variable 'V810::in_bstr' is not initialized in the constructor. [uninitMemberVar] mednafen/src/hw_cpu/v810/v810_cpu.cpp:60:7: warning: Member variable 'V810::Cache' is not initialized in the constructor. [uninitMemberVar] mednafen/src/hw_cpu/v810/v810_cpu.cpp:60:7: warning: Member variable 'V810::have_src_cache' is not initialized in the constructor. [uninitMemberVar] mednafen/src/hw_cpu/v810/v810_cpu.cpp:60:7: warning: Member variable 'V810::have_dst_cache' is not initialized in the constructor. [uninitMemberVar] mednafen/src/hw_cpu/v810/v810_cpu.cpp:60:7: warning: Member variable 'V810::fpo' is not initialized in the constructor. [uninitMemberVar] mednafen/src/hw_cpu/v810/v810_fp_ops.h:50:16: style:inconclusive: Technically the member function 'Mednafen::V810_FP_Ops::get_flags' can be const. [functionConst] mednafen/src/hw_cpu/v810/v810_cpu.h:157:7: performance:inconclusive: Technically the member function 'Mednafen::V810::SetMemReadHandlers' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/hw_cpu/v810/v810_cpu.cpp:416:12: note: Technically the member function 'Mednafen::V810::SetMemReadHandlers' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/v810/v810_cpu.h:157:7: note: Technically the member function 'Mednafen::V810::SetMemReadHandlers' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/v810/v810_cpu.h:158:7: performance:inconclusive: Technically the member function 'Mednafen::V810::SetMemWriteHandlers' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/hw_cpu/v810/v810_cpu.cpp:423:12: note: Technically the member function 'Mednafen::V810::SetMemWriteHandlers' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/v810/v810_cpu.h:158:7: note: Technically the member function 'Mednafen::V810::SetMemWriteHandlers' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/v810/v810_cpu.h:160:7: performance:inconclusive: Technically the member function 'Mednafen::V810::SetIOReadHandlers' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/hw_cpu/v810/v810_cpu.cpp:430:12: note: Technically the member function 'Mednafen::V810::SetIOReadHandlers' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/v810/v810_cpu.h:160:7: note: Technically the member function 'Mednafen::V810::SetIOReadHandlers' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/v810/v810_cpu.h:161:7: performance:inconclusive: Technically the member function 'Mednafen::V810::SetIOWriteHandlers' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/hw_cpu/v810/v810_cpu.cpp:437:12: note: Technically the member function 'Mednafen::V810::SetIOWriteHandlers' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/v810/v810_cpu.h:161:7: note: Technically the member function 'Mednafen::V810::SetIOWriteHandlers' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/v810/v810_cpu.h:207:9: style:inconclusive: Technically the member function 'Mednafen::V810::GetPC' can be const. [functionConst] mednafen/src/hw_cpu/v810/v810_cpu.cpp:793:14: note: Technically the member function 'Mednafen::V810::GetPC' can be const. mednafen/src/hw_cpu/v810/v810_cpu.h:207:9: note: Technically the member function 'Mednafen::V810::GetPC' can be const. mednafen/src/hw_cpu/v810/v810_cpu.h:327:7: style:inconclusive: Technically the member function 'Mednafen::V810::CacheOpMemStore' can be const. [functionConst] mednafen/src/hw_cpu/v810/v810_cpu.cpp:139:19: note: Technically the member function 'Mednafen::V810::CacheOpMemStore' can be const. mednafen/src/hw_cpu/v810/v810_cpu.h:327:7: note: Technically the member function 'Mednafen::V810::CacheOpMemStore' can be const. mednafen/src/hw_cpu/v810/v810_cpu.h:328:9: style:inconclusive: Technically the member function 'Mednafen::V810::CacheOpMemLoad' can be const. [functionConst] mednafen/src/hw_cpu/v810/v810_cpu.cpp:156:21: note: Technically the member function 'Mednafen::V810::CacheOpMemLoad' can be const. mednafen/src/hw_cpu/v810/v810_cpu.h:328:9: note: Technically the member function 'Mednafen::V810::CacheOpMemLoad' can be const. mednafen/src/hw_cpu/v810/v810_cpu.h:344:9: style:inconclusive: Technically the member function 'Mednafen::V810::GetSREG' can be const. [functionConst] mednafen/src/hw_cpu/v810/v810_cpu.cpp:565:21: note: Technically the member function 'Mednafen::V810::GetSREG' can be const. mednafen/src/hw_cpu/v810/v810_cpu.h:344:9: note: Technically the member function 'Mednafen::V810::GetSREG' can be const. mednafen/src/hw_cpu/v810/v810_cpu.h:347:7: performance:inconclusive: Technically the member function 'Mednafen::V810::IsSubnormal' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/hw_cpu/v810/v810_cpu.cpp:1228:12: note: Technically the member function 'Mednafen::V810::IsSubnormal' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/v810/v810_cpu.h:347:7: note: Technically the member function 'Mednafen::V810::IsSubnormal' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/v810/v810_cpu.h:355:9: style:inconclusive: Technically the member function 'Mednafen::V810::BSTR_RWORD' can be const. [functionConst] mednafen/src/hw_cpu/v810/v810_cpu.cpp:825:21: note: Technically the member function 'Mednafen::V810::BSTR_RWORD' can be const. mednafen/src/hw_cpu/v810/v810_cpu.h:355:9: note: Technically the member function 'Mednafen::V810::BSTR_RWORD' can be const. mednafen/src/hw_cpu/v810/v810_cpu.h:356:7: style:inconclusive: Technically the member function 'Mednafen::V810::BSTR_WWORD' can be const. [functionConst] mednafen/src/hw_cpu/v810/v810_cpu.cpp:845:19: note: Technically the member function 'Mednafen::V810::BSTR_WWORD' can be const. mednafen/src/hw_cpu/v810/v810_cpu.h:356:7: note: Technically the member function 'Mednafen::V810::BSTR_WWORD' can be const. mednafen/src/hw_cpu/v810/v810_cpu.cpp:742:11: style: Unsigned expression 'which' can't be negative so it is unnecessary to test it. [unsignedPositive] mednafen/src/hw_cpu/v810/v810_cpu.cpp:774:11: style: Unsigned expression 'which' can't be negative so it is unnecessary to test it. [unsignedPositive] mednafen/src/hw_cpu/v810/v810_cpu.cpp:616:29: style: Variable 'RB_AccurateMode' is assigned a value that is never used. [unreadVariable] mednafen/src/hw_cpu/v810/v810_cpu.cpp:670:29: style: Variable 'RB_AccurateMode' is assigned a value that is never used. [unreadVariable] mednafen/src/hw_cpu/v810/v810_cpuD.cpp:252:28: style:inconclusive: Boolean expression 'opcode>0x4F' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean] mednafen/src/hw_cpu/v810/v810_cpuD.cpp:258:18: warning: Either the condition 'opcode>0x4F' is redundant or the array 'optable[80]' is accessed at index 80, which is out of bounds. [arrayIndexOutOfBoundsCond] mednafen/src/hw_cpu/v810/v810_cpuD.cpp:252:20: note: Assuming that condition 'opcode>0x4F' is not redundant mednafen/src/hw_cpu/v810/v810_cpuD.cpp:258:18: note: Array index out of bounds mednafen/src/hw_cpu/v810/v810_cpuD.cpp:258:18: warning: Either the condition 'opcode<0' is redundant or the array 'optable[80]' is accessed at index -1, which is out of bounds. [negativeIndex] mednafen/src/hw_cpu/v810/v810_cpuD.cpp:252:38: note: Assuming that condition 'opcode<0' is not redundant mednafen/src/hw_cpu/v810/v810_cpuD.cpp:258:18: note: Negative array index mednafen/src/hw_cpu/v810/v810_cpuD.cpp:231:9: style: The scope of the variable 'lowB' can be reduced. [variableScope] mednafen/src/hw_cpu/v810/v810_cpuD.cpp:231:15: style: The scope of the variable 'highB' can be reduced. [variableScope] mednafen/src/hw_cpu/v810/v810_cpuD.cpp:231:22: style: The scope of the variable 'lowB2' can be reduced. [variableScope] mednafen/src/hw_cpu/v810/v810_cpuD.cpp:231:29: style: The scope of the variable 'highB2' can be reduced. [variableScope] mednafen/src/hw_cpu/v810/v810_cpuD.cpp:232:9: style: The scope of the variable 'opcode' can be reduced. [variableScope] mednafen/src/hw_cpu/v810/v810_cpuD.cpp:229:23: style:inconclusive: Function 'v810_dis' argument 1 names different: declaration 'PC' definition 'tPC'. [funcArgNamesDifferent] mednafen/src/hw_cpu/v810/v810_cpuD.h:12:23: note: Function 'v810_dis' argument 1 names different: declaration 'PC' definition 'tPC'. mednafen/src/hw_cpu/v810/v810_cpuD.cpp:229:23: note: Function 'v810_dis' argument 1 names different: declaration 'PC' definition 'tPC'. mednafen/src/hw_cpu/v810/v810_cpuD.cpp:42:17: style: struct member 'dasms::offset' is never used. [unusedStructMember] mednafen/src/hw_cpu/v810/v810_cpuD.cpp:45:22: style: struct member 'dasms::nextElement' is never used. [unusedStructMember] mednafen/src/hw_cpu/v810/v810_fp_ops.h:71:7: performance:inconclusive: Technically the member function 'Mednafen::V810_FP_Ops::fp_is_zero' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/hw_cpu/v810/v810_fp_ops.cpp:27:19: note: Technically the member function 'Mednafen::V810_FP_Ops::fp_is_zero' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/v810/v810_fp_ops.h:71:7: note: Technically the member function 'Mednafen::V810_FP_Ops::fp_is_zero' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/v810/v810_fp_ops.h:72:7: performance:inconclusive: Technically the member function 'Mednafen::V810_FP_Ops::fp_is_inf_nan_sub' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/hw_cpu/v810/v810_fp_ops.cpp:44:19: note: Technically the member function 'Mednafen::V810_FP_Ops::fp_is_inf_nan_sub' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/v810/v810_fp_ops.h:72:7: note: Technically the member function 'Mednafen::V810_FP_Ops::fp_is_inf_nan_sub' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/v810/v810_fp_ops.h:75:7: performance:inconclusive: Technically the member function 'Mednafen::V810_FP_Ops::fpim_decode' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/hw_cpu/v810/v810_fp_ops.cpp:58:19: note: Technically the member function 'Mednafen::V810_FP_Ops::fpim_decode' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/v810/v810_fp_ops.h:75:7: note: Technically the member function 'Mednafen::V810_FP_Ops::fpim_decode' can be static (but you may consider moving to unnamed namespace). mednafen/src/hw_cpu/v810/v810_fp_ops.cpp:160:19: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/hw_cpu/z80-fuse/z80_cb.c:29:7: error: syntax error: keyword 'break' is not allowed in global scope [syntaxError] mednafen/src/hw_cpu/z80-fuse/z80.cpp:75:9: style: The scope of the variable 'j' can be reduced. [variableScope] mednafen/src/hw_cpu/z80-fuse/opcodes_base.c:28:7: error: syntax error: keyword 'break' is not allowed in global scope [syntaxError] mednafen/src/hw_cpu/z80-fuse/z80_ddfdcb.c:32:7: error: syntax error: keyword 'break' is not allowed in global scope [syntaxError] mednafen/src/hw_cpu/z80-fuse/z80_ddfd.c:36:7: error: syntax error: keyword 'break' is not allowed in global scope [syntaxError] mednafen/src/hw_cpu/z80-fuse/z80_ed.c:29:7: error: syntax error: keyword 'break' is not allowed in global scope [syntaxError] mednafen/src/hw_misc/arcade_card/arcade_card.h:47:7: style:inconclusive: Technically the member function 'Mednafen::ArcadeCard::PeekRAM' can be const. [functionConst] mednafen/src/hw_misc/arcade_card/arcade_card.cpp:334:18: note: Technically the member function 'Mednafen::ArcadeCard::PeekRAM' can be const. mednafen/src/hw_misc/arcade_card/arcade_card.h:47:7: note: Technically the member function 'Mednafen::ArcadeCard::PeekRAM' can be const. mednafen/src/hw_sound/gb_apu/Gb_Oscs.h:137:1: style: The class 'Gb_Wave' does not have a constructor although it has private member variables. [noConstructor] mednafen/src/hw_sound/gb_apu/Gb_Oscs.h:146:7: style:inconclusive: Technically the member function 'Gb_Wave::write' can be const. [functionConst] mednafen/src/hw_sound/gb_apu/Gb_Oscs.h:183:22: note: Technically the member function 'Gb_Wave::write' can be const. mednafen/src/hw_sound/gb_apu/Gb_Oscs.h:146:7: note: Technically the member function 'Gb_Wave::write' can be const. mednafen/src/hw_sound/gb_apu/Gb_Apu.h:22:7: style:inconclusive: Technically the member function 'Gb_Apu::set_output' can be const. [functionConst] mednafen/src/hw_sound/gb_apu/Gb_Apu.cpp:37:14: note: Technically the member function 'Gb_Apu::set_output' can be const. mednafen/src/hw_sound/gb_apu/Gb_Apu.h:22:7: note: Technically the member function 'Gb_Apu::set_output' can be const. mednafen/src/hw_sound/gb_apu/Gb_Apu.cpp:37:90: style:inconclusive: Function 'set_output' argument 4 names different: declaration 'chan' definition 'osc'. [funcArgNamesDifferent] mednafen/src/hw_sound/gb_apu/Gb_Apu.h:23:8: note: Function 'set_output' argument 4 names different: declaration 'chan' definition 'osc'. mednafen/src/hw_sound/gb_apu/Gb_Apu.cpp:37:90: note: Function 'set_output' argument 4 names different: declaration 'chan' definition 'osc'. mednafen/src/hw_sound/gb_apu/Gb_Apu.cpp:247:37: style:inconclusive: Function 'end_frame' argument 1 names different: declaration 'frame_length' definition 'end_time'. [funcArgNamesDifferent] mednafen/src/hw_sound/gb_apu/Gb_Apu.h:51:30: note: Function 'end_frame' argument 1 names different: declaration 'frame_length' definition 'end_time'. mednafen/src/hw_sound/gb_apu/Gb_Apu.cpp:247:37: note: Function 'end_frame' argument 1 names different: declaration 'frame_length' definition 'end_time'. mednafen/src/hw_sound/gb_apu/Gb_Apu.h:135:7: style:inconclusive: Technically the member function 'Gb_Apu::save_load2' can be const. [functionConst] mednafen/src/hw_sound/gb_apu/Gb_Apu_State.cpp:76:21: note: Technically the member function 'Gb_Apu::save_load2' can be const. mednafen/src/hw_sound/gb_apu/Gb_Apu.h:135:7: note: Technically the member function 'Gb_Apu::save_load2' can be const. mednafen/src/hw_sound/gb_apu/Gb_Apu_State.cpp:97:42: style:inconclusive: Function 'save_state' argument 1 names different: declaration 'state_out' definition 'out'. [funcArgNamesDifferent] mednafen/src/hw_sound/gb_apu/Gb_Apu.h:86:35: note: Function 'save_state' argument 1 names different: declaration 'state_out' definition 'out'. mednafen/src/hw_sound/gb_apu/Gb_Apu_State.cpp:97:42: note: Function 'save_state' argument 1 names different: declaration 'state_out' definition 'out'. mednafen/src/hw_sound/gb_apu/Gb_Oscs.cpp:195:60: style:inconclusive: Function 'write_register' argument 3 names different: declaration 'old_data' definition 'old'. [funcArgNamesDifferent] mednafen/src/hw_sound/gb_apu/Gb_Oscs.h:58:53: note: Function 'write_register' argument 3 names different: declaration 'old_data' definition 'old'. mednafen/src/hw_sound/gb_apu/Gb_Oscs.cpp:195:60: note: Function 'write_register' argument 3 names different: declaration 'old_data' definition 'old'. mednafen/src/hw_sound/pce_psg/pce_psg.cpp:117:40: error: Array 'dbtable[32][32]' accessed at index dbtable[*][32], which is out of bounds. [arrayIndexOutOfBounds] mednafen/src/hw_sound/pce_psg/pce_psg.cpp:115:33: note: Assignment 'sv=((ch->lfsr&1)<<5)-(ch->lfsr&1)', assigned value is 32 mednafen/src/hw_sound/pce_psg/pce_psg.cpp:117:40: note: Array index out of bounds mednafen/src/hw_sound/pce_psg/pce_psg.cpp:117:40: error: Array 'dbtable[32][32]' accessed at index dbtable[*][-1], which is out of bounds. [negativeIndex] mednafen/src/hw_sound/pce_psg/pce_psg.cpp:115:33: note: Assignment 'sv=((ch->lfsr&1)<<5)-(ch->lfsr&1)', assigned value is -1 mednafen/src/hw_sound/pce_psg/pce_psg.cpp:117:40: note: Negative array index mednafen/src/hw_sound/pce_psg/pce_psg.cpp:118:12: error: Array 'dbtable[32][32]' accessed at index dbtable[*][32], which is out of bounds. [arrayIndexOutOfBounds] mednafen/src/hw_sound/pce_psg/pce_psg.cpp:115:33: note: Assignment 'sv=((ch->lfsr&1)<<5)-(ch->lfsr&1)', assigned value is 32 mednafen/src/hw_sound/pce_psg/pce_psg.cpp:118:12: note: Array index out of bounds mednafen/src/hw_sound/pce_psg/pce_psg.cpp:118:12: error: Array 'dbtable[32][32]' accessed at index dbtable[*][-1], which is out of bounds. [negativeIndex] mednafen/src/hw_sound/pce_psg/pce_psg.cpp:115:33: note: Assignment 'sv=((ch->lfsr&1)<<5)-(ch->lfsr&1)', assigned value is -1 mednafen/src/hw_sound/pce_psg/pce_psg.cpp:118:12: note: Negative array index mednafen/src/hw_sound/pce_psg/pce_psg.h:145:9: style:inconclusive: Technically the member function 'Mednafen::PCE_PSG::GetRegister' can be const. [functionConst] mednafen/src/hw_sound/pce_psg/pce_psg.cpp:237:17: note: Technically the member function 'Mednafen::PCE_PSG::GetRegister' can be const. mednafen/src/hw_sound/pce_psg/pce_psg.h:145:9: note: Technically the member function 'Mednafen::PCE_PSG::GetRegister' can be const. mednafen/src/hw_sound/pce_psg/pce_psg.h:148:7: style:inconclusive: Technically the member function 'Mednafen::PCE_PSG::PeekWave' can be const. [functionConst] mednafen/src/hw_sound/pce_psg/pce_psg.cpp:209:15: note: Technically the member function 'Mednafen::PCE_PSG::PeekWave' can be const. mednafen/src/hw_sound/pce_psg/pce_psg.h:148:7: note: Technically the member function 'Mednafen::PCE_PSG::PeekWave' can be const. mednafen/src/hw_sound/sms_apu/Sms_Apu.cpp:22:10: warning: Member variable 'Sms_Osc::output_select' is not initialized in the constructor. [uninitMemberVar] mednafen/src/hw_sound/sms_apu/Sms_Apu.cpp:22:10: warning: Member variable 'Sms_Osc::delay' is not initialized in the constructor. [uninitMemberVar] mednafen/src/hw_sound/sms_apu/Sms_Apu.cpp:22:10: warning: Member variable 'Sms_Osc::last_amp' is not initialized in the constructor. [uninitMemberVar] mednafen/src/hw_sound/sms_apu/Sms_Apu.cpp:22:10: warning: Member variable 'Sms_Osc::volume' is not initialized in the constructor. [uninitMemberVar] mednafen/src/hw_sound/sms_apu/Sms_Apu.h:45:7: style:inconclusive: Technically the member function 'Sms_Apu::osc_output' can be const. [functionConst] mednafen/src/hw_sound/sms_apu/Sms_Apu.cpp:188:15: note: Technically the member function 'Sms_Apu::osc_output' can be const. mednafen/src/hw_sound/sms_apu/Sms_Apu.h:45:7: note: Technically the member function 'Sms_Apu::osc_output' can be const. mednafen/src/hw_sound/sms_apu/Sms_Apu.h:60:14: style:inconclusive: Technically the member function 'Sms_Apu::save_state' can be const. [functionConst] mednafen/src/hw_sound/sms_apu/Sms_Apu.cpp:334:15: note: Technically the member function 'Sms_Apu::save_state' can be const. mednafen/src/hw_sound/sms_apu/Sms_Apu.h:60:14: note: Technically the member function 'Sms_Apu::save_state' can be const. mednafen/src/hw_sound/sms_apu/Sms_Apu.h:84:43: style:inconclusive: Function 'output' argument 1 names different: declaration 'mono' definition 'b'. [funcArgNamesDifferent] mednafen/src/hw_sound/sms_apu/Sms_Apu.h:37:28: note: Function 'output' argument 1 names different: declaration 'mono' definition 'b'. mednafen/src/hw_sound/sms_apu/Sms_Apu.h:84:43: note: Function 'output' argument 1 names different: declaration 'mono' definition 'b'. mednafen/src/hw_sound/sms_apu/Sms_Apu.h:86:38: style:inconclusive: Function 'osc_output' argument 1 names different: declaration 'index' definition 'i'. [funcArgNamesDifferent] mednafen/src/hw_sound/sms_apu/Sms_Apu.h:44:23: note: Function 'osc_output' argument 1 names different: declaration 'index' definition 'i'. mednafen/src/hw_sound/sms_apu/Sms_Apu.h:86:38: note: Function 'osc_output' argument 1 names different: declaration 'index' definition 'i'. mednafen/src/hw_sound/sms_apu/Sms_Apu.h:86:54: style:inconclusive: Function 'osc_output' argument 2 names different: declaration 'mono' definition 'b'. [funcArgNamesDifferent] mednafen/src/hw_sound/sms_apu/Sms_Apu.h:44:43: note: Function 'osc_output' argument 2 names different: declaration 'mono' definition 'b'. mednafen/src/hw_sound/sms_apu/Sms_Apu.h:86:54: note: Function 'osc_output' argument 2 names different: declaration 'mono' definition 'b'. mednafen/src/hw_sound/sms_apu/Sms_Apu.cpp:205:31: style:inconclusive: Function 'reset' argument 1 names different: declaration 'noise_feedback' definition 'feedback'. [funcArgNamesDifferent] mednafen/src/hw_sound/sms_apu/Sms_Apu.h:48:23: note: Function 'reset' argument 1 names different: declaration 'noise_feedback' definition 'feedback'. mednafen/src/hw_sound/sms_apu/Sms_Apu.cpp:205:31: note: Function 'reset' argument 1 names different: declaration 'noise_feedback' definition 'feedback'. mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:819:3: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:593:14: warning: Either the condition 'opn_addr<0x30' is redundant or the array 'YM2612.REG[2][256]' is accessed at index YM2612.REG[0][256], which is out of bounds. [arrayIndexOutOfBoundsCond] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:586:16: note: Assuming that condition 'opn_addr<0x30' is not redundant mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:593:14: note: Array index out of bounds mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:608:14: warning: Either the condition 'opn_addr>=0x30' is redundant or the array 'YM2612.REG[2][256]' is accessed at index YM2612.REG[1][256], which is out of bounds. [arrayIndexOutOfBoundsCond] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:606:16: note: Assuming that condition 'opn_addr>=0x30' is not redundant mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:608:14: note: Array index out of bounds mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:229:6: style:inconclusive: Technically the member function 'Mednafen::Ym2612_Impl::read' can be const. [functionConst] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:617:25: note: Technically the member function 'Mednafen::Ym2612_Impl::read' can be const. mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:229:6: note: Technically the member function 'Mednafen::Ym2612_Impl::read' can be const. mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:570:2: warning: Class 'Ym2612_Emu' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:570:2: warning: Class 'Ym2612_Emu' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:981:19: style: The comparison 'version_saved != cur_version' is always false because 'version_saved' and 'cur_version' represent the same value. [knownConditionTrueFalse] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:975:22: note: 'version_saved' is assigned value 'cur_version' here. mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:981:19: note: The comparison 'version_saved != cur_version' is always false because 'version_saved' and 'cur_version' represent the same value. mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:582:31: style:inconclusive: Function 'write0' argument 1 names different: declaration 'addr' definition 'opn_addr'. [funcArgNamesDifferent] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:227:19: note: Function 'write0' argument 1 names different: declaration 'addr' definition 'opn_addr'. mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:582:31: note: Function 'write0' argument 1 names different: declaration 'addr' definition 'opn_addr'. mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:602:31: style:inconclusive: Function 'write1' argument 1 names different: declaration 'addr' definition 'opn_addr'. [funcArgNamesDifferent] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:228:19: note: Function 'write1' argument 1 names different: declaration 'addr' definition 'opn_addr'. mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:602:31: note: Function 'write1' argument 1 names different: declaration 'addr' definition 'opn_addr'. mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:979:9: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:990:11: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:994:9: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:995:9: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:996:9: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:997:9: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:998:9: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:999:9: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:1000:9: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:1001:9: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:1002:9: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:1003:9: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:1004:9: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:1005:9: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:1007:9: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:1008:9: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:1017:11: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:1020:10: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:1021:10: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:1022:10: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:1023:10: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:1024:10: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:1025:10: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:1035:11: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:1040:11: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:1044:11: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:1057:11: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:1065:11: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:1066:11: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:1068:11: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:1070:11: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:1071:11: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:1072:11: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:716:61: style: Parameter 'g' can be declared with const [constParameter] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:716:61: style: Parameter 'g' can be declared with const. However it seems that 'func' is a callback function, if 'g' is declared with const you might also need to cast function pointer(s). [constParameterCallback] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:832:26: note: You might need to cast the function pointer here mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:716:61: note: Parameter 'g' can be declared with const mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:716:61: style: Parameter 'g' can be declared with const. However it seems that 'func' is a callback function, if 'g' is declared with const you might also need to cast function pointer(s). [constParameterCallback] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:833:26: note: You might need to cast the function pointer here mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:716:61: note: Parameter 'g' can be declared with const mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:716:61: style: Parameter 'g' can be declared with const. However it seems that 'func' is a callback function, if 'g' is declared with const you might also need to cast function pointer(s). [constParameterCallback] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:834:26: note: You might need to cast the function pointer here mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:716:61: note: Parameter 'g' can be declared with const mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:716:61: style: Parameter 'g' can be declared with const. However it seems that 'func' is a callback function, if 'g' is declared with const you might also need to cast function pointer(s). [constParameterCallback] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:835:26: note: You might need to cast the function pointer here mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:716:61: note: Parameter 'g' can be declared with const mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:716:61: style: Parameter 'g' can be declared with const. However it seems that 'func' is a callback function, if 'g' is declared with const you might also need to cast function pointer(s). [constParameterCallback] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:836:26: note: You might need to cast the function pointer here mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:716:61: note: Parameter 'g' can be declared with const mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:716:61: style: Parameter 'g' can be declared with const. However it seems that 'func' is a callback function, if 'g' is declared with const you might also need to cast function pointer(s). [constParameterCallback] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:837:26: note: You might need to cast the function pointer here mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:716:61: note: Parameter 'g' can be declared with const mednafen/src/hw_sound/ym2413/emu2413.cpp:858:72: style:inconclusive: Boolean expression 'opll->slot_on_flag[14]&&opll->slot_on_flag[15]' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean] mednafen/src/hw_sound/ym2413/emu2413.cpp:878:74: style:inconclusive: Boolean expression 'opll->slot_on_flag[17]&&opll->slot_on_flag[16]' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean] mednafen/src/hw_sound/ym2413/emu2413.cpp:1308:33: style:inconclusive: Boolean expression '!((slot->pgout>>(9-5))&1)' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/hw_sound/ym2413/emu2413.cpp:1330:32: style:inconclusive: Boolean expression '!(((pgout_cym)>>(9-5))&1)' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:811:3: error: Uninitialized variable: CH_OUTd [uninitvar] mednafen/src/hw_sound/ym2413/emu2413.cpp:1308:33: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] mednafen/src/hw_sound/ym2413/emu2413.cpp:1330:32: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] mednafen/src/hw_sound/ym2612/Ym2612_Emu.cpp:819:7: style: Variable 'buf' is assigned a value that is never used. [unreadVariable] mednafen/src/hw_sound/ym2413/emu2413.cpp:979:30: style:inconclusive: Function 'EMU2413_new' argument 1 names different: declaration 'clk' definition 'new_clk'. [funcArgNamesDifferent] mednafen/src/hw_sound/ym2413/emu2413.h:93:29: note: Function 'EMU2413_new' argument 1 names different: declaration 'clk' definition 'new_clk'. mednafen/src/hw_sound/ym2413/emu2413.cpp:979:30: note: Function 'EMU2413_new' argument 1 names different: declaration 'clk' definition 'new_clk'. mednafen/src/hw_sound/ym2413/emu2413.cpp:1450:59: style:inconclusive: Function 'EMU2413_writeReg' argument 3 names different: declaration 'val' definition 'data'. [funcArgNamesDifferent] mednafen/src/hw_sound/ym2413/emu2413.h:103:53: note: Function 'EMU2413_writeReg' argument 3 names different: declaration 'val' definition 'data'. mednafen/src/hw_sound/ym2413/emu2413.cpp:1450:59: note: Function 'EMU2413_writeReg' argument 3 names different: declaration 'val' definition 'data'. mednafen/src/hw_sound/ym2413/emu2413.cpp:1687:46: style:inconclusive: Function 'EMU2413_writeIO' argument 2 names different: declaration 'reg' definition 'adr'. [funcArgNamesDifferent] mednafen/src/hw_sound/ym2413/emu2413.h:102:40: note: Function 'EMU2413_writeIO' argument 2 names different: declaration 'reg' definition 'adr'. mednafen/src/hw_sound/ym2413/emu2413.cpp:1687:46: note: Function 'EMU2413_writeIO' argument 2 names different: declaration 'reg' definition 'adr'. mednafen/src/hw_sound/ym2413/emu2413.cpp:1138:17: style: Variable 'SL' can be declared with const [constVariable] mednafen/src/hw_sound/ym2413/emu2413.cpp:342:17: style: Variable 'kltable' can be declared with const [constVariable] mednafen/src/hw_sound/ym2413/emu2413.cpp:328:10: style: Variable 'mltable' can be declared with const [constVariable] mednafen/src/hw_video/huc6270/vdc.h:181:8: style:inconclusive: Boolean expression 'A' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/hw_video/huc6270/vdc.h:261:7: style:inconclusive: Technically the member function 'Mednafen::VDC::FixTileCache' can be const. [functionConst] mednafen/src/hw_video/huc6270/vdc.cpp:47:11: note: Technically the member function 'Mednafen::VDC::FixTileCache' can be const. mednafen/src/hw_video/huc6270/vdc.h:261:7: note: Technically the member function 'Mednafen::VDC::FixTileCache' can be const. mednafen/src/hw_video/huc6270/vdc.h:271:7: style:inconclusive: Technically the member function 'Mednafen::VDC::StateExtra' can be const. [functionConst] mednafen/src/hw_video/huc6270/vdc.cpp:1721:11: note: Technically the member function 'Mednafen::VDC::StateExtra' can be const. mednafen/src/hw_video/huc6270/vdc.h:271:7: note: Technically the member function 'Mednafen::VDC::StateExtra' can be const. mednafen/src/hw_video/huc6270/vdc.h:332:9: style:inconclusive: Technically the member function 'Mednafen::VDC::GetRegister' can be const. [functionConst] mednafen/src/hw_video/huc6270/vdc.cpp:88:13: note: Technically the member function 'Mednafen::VDC::GetRegister' can be const. mednafen/src/hw_video/huc6270/vdc.h:332:9: note: Technically the member function 'Mednafen::VDC::GetRegister' can be const. mednafen/src/hw_video/huc6270/vdc.h:357:6: style:inconclusive: Technically the member function 'Mednafen::VDC::TimeFromHDSStartToBYRLatch' can be const. [functionConst] mednafen/src/hw_video/huc6270/vdc.cpp:468:10: note: Technically the member function 'Mednafen::VDC::TimeFromHDSStartToBYRLatch' can be const. mednafen/src/hw_video/huc6270/vdc.h:357:6: note: Technically the member function 'Mednafen::VDC::TimeFromHDSStartToBYRLatch' can be const. mednafen/src/hw_video/huc6270/vdc.h:358:6: style:inconclusive: Technically the member function 'Mednafen::VDC::TimeFromBYRLatchToBXRLatch' can be const. [functionConst] mednafen/src/hw_video/huc6270/vdc.cpp:481:10: note: Technically the member function 'Mednafen::VDC::TimeFromBYRLatchToBXRLatch' can be const. mednafen/src/hw_video/huc6270/vdc.h:358:6: note: Technically the member function 'Mednafen::VDC::TimeFromBYRLatchToBXRLatch' can be const. mednafen/src/hw_video/huc6270/vdc.h:421:7: style:inconclusive: Technically the member function 'Mednafen::VDC::CalcWidthStartEnd' can be const. [functionConst] mednafen/src/hw_video/huc6270/vdc.cpp:835:11: note: Technically the member function 'Mednafen::VDC::CalcWidthStartEnd' can be const. mednafen/src/hw_video/huc6270/vdc.h:421:7: note: Technically the member function 'Mednafen::VDC::CalcWidthStartEnd' can be const. mednafen/src/hw_video/huc6270/vdc.cpp:392:13: style: Variable 'NeedBGYInc' is reassigned a value before the old one has been used. [redundantAssignment] mednafen/src/hw_video/huc6270/vdc.cpp:385:14: note: NeedBGYInc is assigned mednafen/src/hw_video/huc6270/vdc.cpp:392:13: note: NeedBGYInc is overwritten mednafen/src/hw_video/huc6270/vdc.cpp:1701:36: style:inconclusive: Function 'SetVRAMSize' argument 1 names different: declaration 'par_VRAM_size' definition 'par_VRAM_Size'. [funcArgNamesDifferent] mednafen/src/hw_video/huc6270/vdc.h:66:32: note: Function 'SetVRAMSize' argument 1 names different: declaration 'par_VRAM_size' definition 'par_VRAM_Size'. mednafen/src/hw_video/huc6270/vdc.cpp:1701:36: note: Function 'SetVRAMSize' argument 1 names different: declaration 'par_VRAM_size' definition 'par_VRAM_Size'. mednafen/src/hw_video/huc6270/vdc.cpp:1727:13: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_video/huc6270/vdc.cpp:1728:13: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_video/huc6270/vdc.cpp:1729:13: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/hw_video/huc6270/vdc.cpp:1732:14: warning:inconclusive: Found suspicious operator '^' [constStatement] mednafen/src/lynx/cart.cpp:79:2: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] mednafen/src/lynx/cart.cpp:102:2: performance: Variable 'mWriteEnableBank0' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/lynx/cart.cpp:103:2: performance: Variable 'mWriteEnableBank1' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/lynx/cart.cpp:104:2: performance: Variable 'mCartRAM' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/lynx/ram.h:70:10: performance:inconclusive: Technically the member function 'CRam::ReadCycle' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/lynx/ram.h:71:10: performance:inconclusive: Technically the member function 'CRam::WriteCycle' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/lynx/rom.h:69:10: performance:inconclusive: Technically the member function 'CRom::ReadCycle' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/lynx/rom.h:70:10: performance:inconclusive: Technically the member function 'CRom::WriteCycle' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/lynx/memmap.h:79:10: performance:inconclusive: Technically the member function 'CMemMap::ReadCycle' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/lynx/memmap.h:80:10: performance:inconclusive: Technically the member function 'CMemMap::WriteCycle' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/lynx/cart.h:88:10: performance:inconclusive: Technically the member function 'CCart::ReadCycle' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/lynx/cart.h:89:10: performance:inconclusive: Technically the member function 'CCart::WriteCycle' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/lynx/cart.h:93:15: style:inconclusive: Technically the member function 'CCart::CartGetName' can be const. [functionConst] mednafen/src/lynx/cart.h:94:15: style:inconclusive: Technically the member function 'CCart::CartGetManufacturer' can be const. [functionConst] mednafen/src/lynx/cart.h:95:10: style:inconclusive: Technically the member function 'CCart::CartGetRotate' can be const. [functionConst] mednafen/src/lynx/susie.h:322:10: performance:inconclusive: Technically the member function 'CSusie::ReadCycle' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/lynx/susie.h:323:10: performance:inconclusive: Technically the member function 'CSusie::WriteCycle' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/lynx/mikie.h:193:10: performance:inconclusive: Technically the member function 'CMikie::ReadCycle' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/lynx/mikie.h:194:10: performance:inconclusive: Technically the member function 'CMikie::WriteCycle' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/lynx/mikie.h:213:15: performance:inconclusive: Technically the member function 'CMikie::SetCPUSleep' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/lynx/mikie.h:214:15: performance:inconclusive: Technically the member function 'CMikie::ClearCPUSleep' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/lynx/c65c02.h:237:14: style:inconclusive: Technically the member function 'C65C02::GetPC' can be const. [functionConst] mednafen/src/lynx/ram.h:60:3: style: Class 'CRam' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/lynx/rom.h:63:3: style: Class 'CRom' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/lynx/memmap.h:72:3: style: Class 'CMemMap' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/lynx/cart.h:74:3: style: Class 'CCart' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/lynx/susie.h:315:3: style: Class 'CSusie' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/lynx/mikie.h:182:3: style: Class 'CMikie' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/lynx/c65c02.h:135:3: style: Class 'C65C02' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/lynx/system.h:103:3: style: Class 'CSystem' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/lynx/ram.h:66:8: style: The function 'Reset' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/lynxbase.h:46:16: note: Virtual function in base class mednafen/src/lynx/ram.h:66:8: note: Function in derived class mednafen/src/lynx/ram.h:68:8: style: The function 'Poke' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/lynxbase.h:48:16: note: Virtual function in base class mednafen/src/lynx/ram.h:68:8: note: Function in derived class mednafen/src/lynx/ram.h:69:9: style: The function 'Peek' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/lynxbase.h:49:17: note: Virtual function in base class mednafen/src/lynx/ram.h:69:9: note: Function in derived class mednafen/src/lynx/ram.h:72:12: style: The function 'ObjectSize' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/lynxbase.h:53:18: note: Virtual function in base class mednafen/src/lynx/ram.h:72:12: note: Function in derived class mednafen/src/lynx/rom.h:66:8: style: The function 'Reset' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/lynxbase.h:46:16: note: Virtual function in base class mednafen/src/lynx/rom.h:66:8: note: Function in derived class mednafen/src/lynx/rom.h:67:8: style: The function 'Poke' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/lynxbase.h:48:16: note: Virtual function in base class mednafen/src/lynx/rom.h:67:8: note: Function in derived class mednafen/src/lynx/rom.h:68:9: style: The function 'Peek' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/lynxbase.h:49:17: note: Virtual function in base class mednafen/src/lynx/rom.h:68:9: note: Function in derived class mednafen/src/lynx/rom.h:71:10: style: The function 'ObjectSize' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/lynxbase.h:53:18: note: Virtual function in base class mednafen/src/lynx/rom.h:71:10: note: Function in derived class mednafen/src/lynx/memmap.h:75:8: style: The function 'Reset' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/lynxbase.h:46:16: note: Virtual function in base class mednafen/src/lynx/memmap.h:75:8: note: Function in derived class mednafen/src/lynx/memmap.h:77:8: style: The function 'Poke' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/lynxbase.h:48:16: note: Virtual function in base class mednafen/src/lynx/memmap.h:77:8: note: Function in derived class mednafen/src/lynx/memmap.h:78:9: style: The function 'Peek' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/lynxbase.h:49:17: note: Virtual function in base class mednafen/src/lynx/memmap.h:78:9: note: Function in derived class mednafen/src/lynx/memmap.h:81:10: style: The function 'ObjectSize' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/lynxbase.h:53:18: note: Virtual function in base class mednafen/src/lynx/memmap.h:81:10: note: Function in derived class mednafen/src/lynx/cart.h:85:8: style: The function 'Reset' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/lynxbase.h:46:16: note: Virtual function in base class mednafen/src/lynx/cart.h:85:8: note: Function in derived class mednafen/src/lynx/cart.h:86:8: style: The function 'Poke' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/lynxbase.h:48:16: note: Virtual function in base class mednafen/src/lynx/cart.h:86:8: note: Function in derived class mednafen/src/lynx/cart.h:87:9: style: The function 'Peek' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/lynxbase.h:49:17: note: Virtual function in base class mednafen/src/lynx/cart.h:87:9: note: Function in derived class mednafen/src/lynx/cart.h:90:8: style: The function 'BankSelect' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/lynxbase.h:52:16: note: Virtual function in base class mednafen/src/lynx/cart.h:90:8: note: Function in derived class mednafen/src/lynx/cart.h:91:10: style: The function 'ObjectSize' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/lynxbase.h:53:18: note: Virtual function in base class mednafen/src/lynx/cart.h:91:10: note: Function in derived class mednafen/src/lynx/susie.h:318:8: style: The function 'Reset' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/lynxbase.h:46:16: note: Virtual function in base class mednafen/src/lynx/susie.h:318:8: note: Function in derived class mednafen/src/lynx/susie.h:320:9: style: The function 'Peek' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/lynxbase.h:49:17: note: Virtual function in base class mednafen/src/lynx/susie.h:320:9: note: Function in derived class mednafen/src/lynx/susie.h:321:8: style: The function 'Poke' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/lynxbase.h:48:16: note: Virtual function in base class mednafen/src/lynx/susie.h:321:8: note: Function in derived class mednafen/src/lynx/susie.h:324:10: style: The function 'ObjectSize' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/lynxbase.h:53:18: note: Virtual function in base class mednafen/src/lynx/susie.h:324:10: note: Function in derived class mednafen/src/lynx/mikie.h:189:8: style: The function 'Reset' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/lynxbase.h:46:16: note: Virtual function in base class mednafen/src/lynx/mikie.h:189:8: note: Function in derived class mednafen/src/lynx/mikie.h:191:9: style: The function 'Peek' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/lynxbase.h:49:17: note: Virtual function in base class mednafen/src/lynx/mikie.h:191:9: note: Function in derived class mednafen/src/lynx/mikie.h:192:8: style: The function 'Poke' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/lynxbase.h:48:16: note: Virtual function in base class mednafen/src/lynx/mikie.h:192:8: note: Function in derived class mednafen/src/lynx/mikie.h:195:10: style: The function 'ObjectSize' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/lynxbase.h:53:18: note: Virtual function in base class mednafen/src/lynx/mikie.h:195:10: note: Function in derived class mednafen/src/lynx/system.h:107:8: style: The function 'Reset' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/sysbase.h:58:16: note: Virtual function in base class mednafen/src/lynx/system.h:107:8: note: Function in derived class mednafen/src/lynx/system.h:145:16: style: The function 'Poke_CPU' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/sysbase.h:59:16: note: Virtual function in base class mednafen/src/lynx/system.h:145:16: note: Function in derived class mednafen/src/lynx/system.h:146:16: style: The function 'Peek_CPU' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/sysbase.h:60:17: note: Virtual function in base class mednafen/src/lynx/system.h:146:16: note: Function in derived class mednafen/src/lynx/system.h:147:16: style: The function 'PokeW_CPU' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/sysbase.h:61:16: note: Virtual function in base class mednafen/src/lynx/system.h:147:16: note: Function in derived class mednafen/src/lynx/system.h:148:17: style: The function 'PeekW_CPU' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/sysbase.h:62:18: note: Virtual function in base class mednafen/src/lynx/system.h:148:17: note: Function in derived class mednafen/src/lynx/system.h:191:10: style: The function 'GetRamPointer' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/lynx/sysbase.h:64:18: note: Virtual function in base class mednafen/src/lynx/system.h:191:10: note: Function in derived class mednafen/src/lynx/c65c02.h:207:35: style: Parameter 'regs' can be declared with const [constParameter] mednafen/src/lynx/cart.cpp:270:12: style: Variable 'banktype1' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/thumb.cpp:1423:6: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/thumb.cpp:1443:6: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/thumb.cpp:1472:6: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/thumb.cpp:1533:6: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/thumb.cpp:1552:6: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/thumb.cpp:1571:6: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/thumb.cpp:1590:6: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/thumb.cpp:1609:6: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/thumb.cpp:1628:6: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/thumb.cpp:1647:6: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/thumb.cpp:1666:6: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/thumb.cpp:1695:6: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/thumb.cpp:1717:6: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/thumb.cpp:1739:6: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/thumb.cpp:1761:6: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/thumb.cpp:1783:6: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/thumb.cpp:1805:6: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/thumb.cpp:1827:6: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/thumb.cpp:1849:6: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/lynx/mikie.cpp:68:9: warning: Member variable 'CMikie::mpSkipFrame' is not initialized in the constructor. [uninitMemberVar] mednafen/src/lynx/mikie.cpp:68:9: warning: Member variable 'CMikie::mUART_Rx_input_queue' is not initialized in the constructor. [uninitMemberVar] mednafen/src/lynx/mikie.h:197:10: performance:inconclusive: Technically the member function 'CMikie::GetLfsrNext' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/lynx/mikie.cpp:274:16: note: Technically the member function 'CMikie::GetLfsrNext' can be static (but you may consider moving to unnamed namespace). mednafen/src/lynx/mikie.h:197:10: note: Technically the member function 'CMikie::GetLfsrNext' can be static (but you may consider moving to unnamed namespace). mednafen/src/lynx/mikie.cpp:1887:28: style: Expression is always true because 'else if' condition is opposite to previous condition at line 1882. [multiCondition] mednafen/src/lynx/mikie.cpp:1882:26: note: first condition mednafen/src/lynx/mikie.cpp:1887:28: note: else if condition is opposite to first condition mednafen/src/lynx/system.cpp:78:2: performance: Variable 'mFileType' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/lynx/system.cpp:182:45: style: Condition '(unsigned long)CCart::HEADER_RAW_SIZE>(unsigned long)CRam::HEADER_RAW_SIZE' is always true [knownConditionTrueFalse] mednafen/src/lynx/c65c02.cpp:317:4: style: Variable 'mPC' is reassigned a value before the old one has been used. [redundantAssignment] mednafen/src/lynx/c65c02.cpp:316:4: note: mPC is assigned mednafen/src/lynx/c65c02.cpp:317:4: note: mPC is overwritten mednafen/src/md/cart/cart.cpp:45:41: style:inconclusive: Function 'MDCart_Write8' argument 1 names different: declaration 'address' definition 'A'. [funcArgNamesDifferent] mednafen/src/md/cart/cart.h:6:41: note: Function 'MDCart_Write8' argument 1 names different: declaration 'address' definition 'A'. mednafen/src/md/cart/cart.cpp:45:41: note: Function 'MDCart_Write8' argument 1 names different: declaration 'address' definition 'A'. mednafen/src/md/cart/cart.cpp:45:50: style:inconclusive: Function 'MDCart_Write8' argument 2 names different: declaration 'value' definition 'V'. [funcArgNamesDifferent] mednafen/src/md/cart/cart.h:6:56: note: Function 'MDCart_Write8' argument 2 names different: declaration 'value' definition 'V'. mednafen/src/md/cart/cart.cpp:45:50: note: Function 'MDCart_Write8' argument 2 names different: declaration 'value' definition 'V'. mednafen/src/md/cart/cart.cpp:50:42: style:inconclusive: Function 'MDCart_Write16' argument 1 names different: declaration 'address' definition 'A'. [funcArgNamesDifferent] mednafen/src/md/cart/cart.h:7:42: note: Function 'MDCart_Write16' argument 1 names different: declaration 'address' definition 'A'. mednafen/src/md/cart/cart.cpp:50:42: note: Function 'MDCart_Write16' argument 1 names different: declaration 'address' definition 'A'. mednafen/src/md/cart/cart.cpp:50:52: style:inconclusive: Function 'MDCart_Write16' argument 2 names different: declaration 'value' definition 'V'. [funcArgNamesDifferent] mednafen/src/md/cart/cart.h:7:58: note: Function 'MDCart_Write16' argument 2 names different: declaration 'value' definition 'V'. mednafen/src/md/cart/cart.cpp:50:52: note: Function 'MDCart_Write16' argument 2 names different: declaration 'value' definition 'V'. mednafen/src/md/cart/cart.cpp:55:41: style:inconclusive: Function 'MDCart_Read8' argument 1 names different: declaration 'address' definition 'A'. [funcArgNamesDifferent] mednafen/src/md/cart/cart.h:8:41: note: Function 'MDCart_Read8' argument 1 names different: declaration 'address' definition 'A'. mednafen/src/md/cart/cart.cpp:55:41: note: Function 'MDCart_Read8' argument 1 names different: declaration 'address' definition 'A'. mednafen/src/md/cart/cart.cpp:60:43: style:inconclusive: Function 'MDCart_Read16' argument 1 names different: declaration 'address' definition 'A'. [funcArgNamesDifferent] mednafen/src/md/cart/cart.h:9:43: note: Function 'MDCart_Read16' argument 1 names different: declaration 'address' definition 'A'. mednafen/src/md/cart/cart.cpp:60:43: note: Function 'MDCart_Read16' argument 1 names different: declaration 'address' definition 'A'. mednafen/src/lynx/susie.h:342:10: style:inconclusive: Technically the member function 'CSusie::ReadPixel' can be const. [functionConst] mednafen/src/lynx/susie.cpp:868:23: note: Technically the member function 'CSusie::ReadPixel' can be const. mednafen/src/lynx/susie.h:342:10: note: Technically the member function 'CSusie::ReadPixel' can be const. mednafen/src/lynx/susie.h:344:10: style:inconclusive: Technically the member function 'CSusie::ReadCollision' can be const. [functionConst] mednafen/src/lynx/susie.cpp:913:23: note: Technically the member function 'CSusie::ReadCollision' can be const. mednafen/src/lynx/susie.h:344:10: note: Technically the member function 'CSusie::ReadCollision' can be const. mednafen/src/lynx/susie.cpp:564:8: style: Condition 'superclip' is always false [knownConditionTrueFalse] mednafen/src/lynx/susie.cpp:499:19: note: Assignment 'superclip=false', assigned value is 0 mednafen/src/lynx/susie.cpp:564:8: note: Condition 'superclip' is always false mednafen/src/lynx/susie.cpp:627:8: style: Condition 'render' is always true [knownConditionTrueFalse] mednafen/src/lynx/susie.cpp:613:13: note: Assignment 'render=true', assigned value is 1 mednafen/src/lynx/susie.cpp:627:8: note: Condition 'render' is always true mednafen/src/lynx/susie.cpp:1171:56: style: Condition 'pixel!=0x0e' is always true [knownConditionTrueFalse] mednafen/src/lynx/susie.cpp:283:6: style: The scope of the variable 'data' can be reduced. [variableScope] mednafen/src/lynx/susie.cpp:284:6: style: The scope of the variable 'everonscreen' can be reduced. [variableScope] mednafen/src/lynx/susie.cpp:501:8: style: The scope of the variable 'hsign' can be reduced. [variableScope] mednafen/src/lynx/susie.cpp:501:14: style: The scope of the variable 'vsign' can be reduced. [variableScope] mednafen/src/lynx/susie.cpp:620:9: style: The scope of the variable 'pixel_height' can be reduced. [variableScope] mednafen/src/lynx/susie.cpp:621:9: style: The scope of the variable 'pixel_width' can be reduced. [variableScope] mednafen/src/lynx/susie.cpp:622:9: style: The scope of the variable 'pixel' can be reduced. [variableScope] mednafen/src/lynx/susie.cpp:623:9: style: The scope of the variable 'hoff' can be reduced. [variableScope] mednafen/src/lynx/susie.cpp:623:14: style: The scope of the variable 'voff' can be reduced. [variableScope] mednafen/src/lynx/susie.cpp:624:9: style: The scope of the variable 'hloop' can be reduced. [variableScope] mednafen/src/lynx/susie.cpp:624:15: style: The scope of the variable 'vloop' can be reduced. [variableScope] mednafen/src/lynx/susie.cpp:625:10: style: The scope of the variable 'onscreen' can be reduced. [variableScope] mednafen/src/md/cart/map_ff.cpp:160:2: style:inconclusive: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] mednafen/src/lynx/susie.cpp:283:10: style: Variable 'data' is assigned a value that is never used. [unreadVariable] mednafen/src/lynx/susie.cpp:284:18: style: Variable 'everonscreen' is assigned a value that is never used. [unreadVariable] mednafen/src/md/cart/map_eeprom.cpp:168:2: performance: Variable 'sda' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/md/cart/map_eeprom.cpp:168:8: performance: Variable 'old_sda' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/md/cart/map_eeprom.cpp:169:2: performance: Variable 'scl' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/md/cart/map_eeprom.cpp:169:8: performance: Variable 'old_scl' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/md/cart/map_eeprom.cpp:187:2: warning: Class 'MD_Cart_Type_EEPROM' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] mednafen/src/md/cart/map_eeprom.cpp:187:2: warning: Class 'MD_Cart_Type_EEPROM' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] mednafen/src/md/cart/map_eeprom.cpp:239:74: style:inconclusive: Function 'WriteEEPROM' argument 2 names different: declaration 'value' definition 'data'. [funcArgNamesDifferent] mednafen/src/md/cart/map_eeprom.cpp:134:54: note: Function 'WriteEEPROM' argument 2 names different: declaration 'value' definition 'data'. mednafen/src/md/cart/map_eeprom.cpp:239:74: note: Function 'WriteEEPROM' argument 2 names different: declaration 'value' definition 'data'. mednafen/src/md/cart/map_realtec.cpp:52:23: warning: Member variable 'MD_Cart_Type_REALTEC::boot_mode' is not initialized in the constructor. [uninitMemberVar] mednafen/src/md/cart/map_realtec.cpp:169:2: style:inconclusive: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] mednafen/src/md/cart/map_ssf2.cpp:151:2: style:inconclusive: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] mednafen/src/md/cart/map_sram.cpp:57:20: warning: Member variable 'MD_Cart_Type_SRAM::sram_enabled' is not initialized in the constructor. [uninitMemberVar] mednafen/src/md/cart/map_sram.cpp:62:2: performance: Variable 'sram_start' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/md/cart/map_sram.cpp:63:2: performance: Variable 'sram_end' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/md/cart/map_sram.cpp:65:2: performance: Variable 'sram_size' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/md/cart/map_sram.cpp:78:2: warning: Class 'MD_Cart_Type_SRAM' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] mednafen/src/md/cart/map_sram.cpp:78:2: warning: Class 'MD_Cart_Type_SRAM' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] mednafen/src/md/cd/cd.cpp:148:20: style:inconclusive: Boolean expression 'SBRQ' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean] mednafen/src/md/cd/cd.cpp:244:27: style:inconclusive: Boolean expression 'SBRQ' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean] mednafen/src/md/cd/cd.cpp:289:12: style: Condition 'A>=0x20000' is always true [knownConditionTrueFalse] mednafen/src/md/cd/cd.cpp:285:7: note: Assuming that condition 'A<=0x1FFFF' is not redundant mednafen/src/md/cd/cd.cpp:289:12: note: Condition 'A>=0x20000' is always true mednafen/src/md/cd/cd.cpp:374:12: style: Condition 'A>=0x20000' is always true [knownConditionTrueFalse] mednafen/src/md/cd/cd.cpp:370:7: note: Assuming that condition 'A<=0x1FFFF' is not redundant mednafen/src/md/cd/cd.cpp:374:12: note: Condition 'A>=0x20000' is always true mednafen/src/md/debug.cpp:226:35: style: Unused variable: bpit [unusedVariable] mednafen/src/md/debug.cpp:166:65: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/md/debug.cpp:314:69: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/md/debug.cpp:339:69: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/md/debug.cpp:359:71: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/md/debug.cpp:375:71: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/md/genio.cpp:408:32: style:inconclusive: Function 'MDINPUT_SetInput' argument 1 names different: declaration 'port' definition 'vp'. [funcArgNamesDifferent] mednafen/src/md/genio.h:22:32: note: Function 'MDINPUT_SetInput' argument 1 names different: declaration 'port' definition 'vp'. mednafen/src/md/genio.cpp:408:32: note: Function 'MDINPUT_SetInput' argument 1 names different: declaration 'port' definition 'vp'. mednafen/src/md/input/gamepad.cpp:218:11: warning: Member variable 'Gamepad6::compat_mode' is not initialized in the constructor. [uninitMemberVar] mednafen/src/md/input/gamepad.cpp:102:2: performance: Variable 'buttons' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/md/input/gamepad.cpp:155:2: performance: Variable 'buttons' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/md/input/gamepad.cpp:220:2: performance: Variable 'buttons' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/md/input/gamepad.cpp:222:2: performance: Variable 'prev_timestamp' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/md/input/megamouse.cpp:90:9: performance: Variable 'mouse_x' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/md/input/megamouse.cpp:91:9: performance: Variable 'mouse_y' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/md/input/megamouse.cpp:92:9: performance: Variable 'buttons' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/md/input/megamouse.cpp:94:2: performance: Variable 'phase' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/md/input/megamouse.cpp:95:2: performance: Variable 'busy_until' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/md/input/multitap.h:32:15: style: Virtual function 'Power' is called from constructor 'MD_Multitap()' at line 38. Dynamic binding is not used. [virtualCallInConstructor] mednafen/src/md/input/multitap.cpp:38:2: note: Calling Power mednafen/src/md/input/multitap.h:32:15: note: Power is a virtual function mednafen/src/md/input/multitap.cpp:138:13: style: Unsigned expression 'phase' can't be negative so it is unnecessary to test it. [unsignedPositive] mednafen/src/md/system.cpp:257:7: style: struct member 'Anonymous6::compat_6button' is never used. [unusedStructMember] mednafen/src/mpcdec/crc32.c:39:67: style: Parameter 'buf' can be declared with const [constParameter] mednafen/src/minilzo/lzodefs.h:2105:0: error: #error "LZO_SIZEOF_SHORT" [preprocessorErrorDirective] mednafen/src/mpcdec/internal.h:91:51: style: Parameter 'key' can be declared with const [constParameter] mednafen/src/mpcdec/mpc_demux.c:102:21: portability: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS] mednafen/src/mpcdec/mpc_demux.c:103:39: portability: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS] mednafen/src/mpcdec/mpc_demux.c:155:57: portability: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS] mednafen/src/mpcdec/mpc_demux.c:305:24: portability: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS] mednafen/src/mpcdec/requant.c:94:39: style:inconclusive: Function 'mpc_decoder_scale_output' argument 1 names different: declaration 'p_dec' definition 'd'. [funcArgNamesDifferent] mednafen/src/mpcdec/mpcdec.h:91:52: note: Function 'mpc_decoder_scale_output' argument 1 names different: declaration 'p_dec' definition 'd'. mednafen/src/mpcdec/requant.c:94:39: note: Function 'mpc_decoder_scale_output' argument 1 names different: declaration 'p_dec' definition 'd'. mednafen/src/mpcdec/requant.c:94:49: style:inconclusive: Function 'mpc_decoder_scale_output' argument 2 names different: declaration 'scale_factor' definition 'factor'. [funcArgNamesDifferent] mednafen/src/mpcdec/mpcdec.h:91:66: note: Function 'mpc_decoder_scale_output' argument 2 names different: declaration 'scale_factor' definition 'factor'. mednafen/src/mpcdec/requant.c:94:49: note: Function 'mpc_decoder_scale_output' argument 2 names different: declaration 'scale_factor' definition 'factor'. mednafen/src/mpcdec/streaminfo.c:73:6: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] mednafen/src/mpcdec/streaminfo.c:73:6: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] mednafen/src/mpcdec/streaminfo.c:77:6: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] mednafen/src/mpcdec/streaminfo.c:77:6: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] mednafen/src/mpcdec/streaminfo.c:81:6: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] mednafen/src/mpcdec/streaminfo.c:81:6: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] mednafen/src/mpcdec/streaminfo.c:95:3: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] mednafen/src/mpcdec/streaminfo.c:95:3: warning: %u in format string (no. 3) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] mednafen/src/mpcdec/streaminfo.c:95:3: warning: %u in format string (no. 4) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] mednafen/src/mthreading/MThreading_POSIX.cpp:80:2: warning: Member variable 'Thread::t' is not initialized in the constructor. [uninitMemberVar] mednafen/src/mthreading/MThreading_POSIX.cpp:80:2: warning: Member variable 'Thread::ep' is not initialized in the constructor. [uninitMemberVar] mednafen/src/mthreading/MThreading_POSIX.cpp:80:2: warning: Member variable 'Thread::data' is not initialized in the constructor. [uninitMemberVar] mednafen/src/mthreading/MThreading_POSIX.cpp:80:2: warning: Member variable 'Thread::rv' is not initialized in the constructor. [uninitMemberVar] mednafen/src/mthreading/MThreading_POSIX.cpp:92:2: warning: Member variable 'Mutex::m' is not initialized in the constructor. [uninitMemberVar] mednafen/src/mthreading/MThreading_POSIX.cpp:101:2: warning: Member variable 'Cond::c' is not initialized in the constructor. [uninitMemberVar] mednafen/src/mthreading/MThreading_POSIX.cpp:682:2: warning: Member variable 'Sem::v' is not initialized in the constructor. [uninitMemberVar] mednafen/src/mthreading/MThreading_POSIX.cpp:110:14: style: C-style pointer casting [cstyleCast] mednafen/src/mthreading/MThreading_Win32.cpp:132:14: style: C-style pointer casting [cstyleCast] mednafen/src/mthreading/MThreading_Win32.cpp:147:13: style: C-style pointer casting [cstyleCast] mednafen/src/mthreading/MThreading_Win32.cpp:194:13: style: C-style pointer casting [cstyleCast] mednafen/src/mthreading/MThreading_Win32.cpp:238:13: style: C-style pointer casting [cstyleCast] mednafen/src/mthreading/MThreading_Win32.cpp:372:13: style: C-style pointer casting [cstyleCast] mednafen/src/mthreading/MThreading_Win32.cpp:114:19: style: Variable 'test_array' is not assigned a value. [unassignedVariable] mednafen/src/nes/boards/117.cpp:73:6: style: Condition '!IRQCount' is always true [knownConditionTrueFalse] mednafen/src/nes/boards/117.cpp:70:16: note: Assuming condition 'IRQCount' is true mednafen/src/nes/boards/117.cpp:72:3: note: IRQCount is decremented', new value is 0 mednafen/src/nes/boards/117.cpp:73:6: note: Condition '!IRQCount' is always true mednafen/src/mpcdec/mpc_decoder.c:143:19: style: Condition 'samples_left<=0' is always false [knownConditionTrueFalse] mednafen/src/mpcdec/mpc_decoder.c:141:49: note: Assignment 'samples_left=d->samples-d->decoded_samples+MPC_DECODER_SYNTH_DELAY', assigned value is greater than 480 mednafen/src/mpcdec/mpc_decoder.c:143:19: note: Condition 'samples_left<=0' is always false mednafen/src/mpcdec/mpc_decoder.c:129:36: style:inconclusive: Function 'mpc_decoder_exit' argument 1 names different: declaration 'p_dec' definition 'd'. [funcArgNamesDifferent] mednafen/src/mpcdec/mpcdec.h:84:44: note: Function 'mpc_decoder_exit' argument 1 names different: declaration 'p_dec' definition 'd'. mednafen/src/mpcdec/mpc_decoder.c:129:36: note: Function 'mpc_decoder_exit' argument 1 names different: declaration 'p_dec' definition 'd'. mednafen/src/nes/boards/16.cpp:77:22: style:inconclusive: Boolean expression 'prev_sda_in' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/nes/boards/16.cpp:96:90: style:inconclusive: Boolean expression 'scl_in' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/nes/boards/189.cpp:45:8: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] mednafen/src/nes/boards/25.cpp:108:15: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] mednafen/src/nes/boards/emu2413.cpp:597:10: style: C-style pointer casting [cstyleCast] mednafen/src/nes/boards/emu2413.cpp:885:12: style: The scope of the variable 'ret' can be reduced. [variableScope] mednafen/src/nes/boards/emu2413.cpp:900:12: style: The scope of the variable 'ret' can be reduced. [variableScope] mednafen/src/nes/boards/emu2413.cpp:969:57: style:inconclusive: Function 'OPLL_writeReg' argument 3 names different: declaration 'val' definition 'data'. [funcArgNamesDifferent] mednafen/src/nes/boards/emu2413.h:189:63: note: Function 'OPLL_writeReg' argument 3 names different: declaration 'val' definition 'data'. mednafen/src/nes/boards/emu2413.cpp:969:57: note: Function 'OPLL_writeReg' argument 3 names different: declaration 'val' definition 'data'. mednafen/src/nes/boards/emu2413.cpp:1135:42: style:inconclusive: Function 'OPLL_writeIO' argument 2 names different: declaration 'reg' definition 'adr'. [funcArgNamesDifferent] mednafen/src/nes/boards/emu2413.h:188:48: note: Function 'OPLL_writeIO' argument 2 names different: declaration 'reg' definition 'adr'. mednafen/src/nes/boards/emu2413.cpp:1135:42: note: Function 'OPLL_writeIO' argument 2 names different: declaration 'reg' definition 'adr'. mednafen/src/nes/boards/emu2413.cpp:217:12: style: Variable 'mltable' can be declared with const [constVariable] mednafen/src/nes/boards/sachen.cpp:107:6: style: The scope of the variable 'x' can be reduced. [variableScope] mednafen/src/nes/cart.cpp:134:18: portability: Undefined behaviour, pointer arithmetic 'nothing-x*2048' is out of bounds. [pointerOutOfBounds] mednafen/src/nes/cart.cpp:140:51: portability: Undefined behaviour, pointer arithmetic 'nothing-0x400*x' is out of bounds. [pointerOutOfBounds] mednafen/src/nes/debug.cpp:217:8: style: The function 'GetX' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/nes/dis6502.h:11:16: note: Virtual function in base class mednafen/src/nes/debug.cpp:217:8: note: Function in derived class mednafen/src/nes/debug.cpp:222:8: style: The function 'GetY' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/nes/dis6502.h:12:16: note: Virtual function in base class mednafen/src/nes/debug.cpp:222:8: note: Function in derived class mednafen/src/nes/debug.cpp:227:8: style: The function 'Read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/nes/dis6502.h:10:16: note: Virtual function in base class mednafen/src/nes/debug.cpp:227:8: note: Function in derived class mednafen/src/nes/debug.cpp:130:13: style: Variable 'fceuindbg' is reassigned a value before the old one has been used. [redundantAssignment] mednafen/src/nes/debug.cpp:128:14: note: fceuindbg is assigned mednafen/src/nes/debug.cpp:130:13: note: fceuindbg is overwritten mednafen/src/nes/debug.cpp:170:13: style: Variable 'fceuindbg' is reassigned a value before the old one has been used. [redundantAssignment] mednafen/src/nes/debug.cpp:161:13: note: fceuindbg is assigned mednafen/src/nes/debug.cpp:170:13: note: fceuindbg is overwritten mednafen/src/nes/debug.cpp:242:14: style: Unused variable: ret [unusedVariable] mednafen/src/nes/debug.cpp:344:36: style: Unused variable: bpit [unusedVariable] mednafen/src/nes/debug.cpp:265:66: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/nes/debug.cpp:287:70: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/nes/debug.cpp:305:72: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/nes/cart.cpp:363:32: style: Parameter 'p' can be declared with const [constParameter] mednafen/src/nes/cart.cpp:374:23: style: Parameter 'p' can be declared with const [constParameter] mednafen/src/nes/cart.cpp:381:23: style: Parameter 'p' can be declared with const [constParameter] mednafen/src/nes/cart.cpp:388:23: style: Parameter 'p' can be declared with const [constParameter] mednafen/src/nes/cart.cpp:95:55: style: Parameter 'p' can be declared with const [constParameter] mednafen/src/nes/dis6502.cpp:187:9: style: The scope of the variable 'borked' can be reduced. [variableScope] mednafen/src/nes/fds.cpp:566:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] mednafen/src/nes/ines.cpp:489:13: error: Array 'moo[1]' accessed at index 1, which is out of bounds. [arrayIndexOutOfBounds] mednafen/src/nes/ines.cpp:444:4: note: Assignment 'x=0', assigned value is 0 mednafen/src/nes/ines.cpp:448:54: note: Assuming condition is false mednafen/src/nes/ines.cpp:488:3: note: x is incremented', new value is 1 mednafen/src/nes/ines.cpp:489:13: note: Array index out of bounds mednafen/src/nes/ines.cpp:321:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] mednafen/src/nes/ines.cpp:351:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] mednafen/src/nes/input/shadow.cpp:35:35: style: Parameter 'bg' can be declared with const [constParameter] mednafen/src/nes/input/zapper.cpp:36:41: style: Parameter 'bg' can be declared with const [constParameter] mednafen/src/nes/nes.cpp:235:17: style: Variable 'LoadFunctions' can be declared with const [constVariable] mednafen/src/nes/nes.cpp:538:14: style: Variable 'lets' can be declared with const [constVariable] mednafen/src/nes/nes.cpp:145:91: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/nes/nes.cpp:500:76: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/nes/ntsc/nes_ntsc.cpp:535:0: error: #error "Need 16-bit int type" [preprocessorErrorDirective] mednafen/src/nes/ntsc/demo.c:110:1: error: Resource leak: out [resourceLeak] mednafen/src/nes/sound.cpp:942:34: style:inconclusive: Function 'MDFNNES_SetSoundRate' argument 1 names different: declaration 'Rate' definition 'rate'. [funcArgNamesDifferent] mednafen/src/nes/sound.h:32:34: note: Function 'MDFNNES_SetSoundRate' argument 1 names different: declaration 'Rate' definition 'rate'. mednafen/src/nes/sound.cpp:942:34: note: Function 'MDFNNES_SetSoundRate' argument 1 names different: declaration 'Rate' definition 'rate'. mednafen/src/nes/sound.cpp:727:92: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/nes/sound.cpp:749:94: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/nes/sound.cpp:835:92: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/nes/unif.cpp:168:22: style: The scope of the variable 'stuffo' can be reduced. [variableScope] mednafen/src/nes/x6502.cpp:655:10: style: Variable 'X.mooPI' is reassigned a value before the old one has been used. [redundantAssignment] mednafen/src/nes/x6502.cpp:609:11: note: X.mooPI is assigned mednafen/src/nes/x6502.cpp:655:10: note: X.mooPI is overwritten mednafen/src/nes/ops.h:78:12: style: Variable 'pbackus' is reassigned a value before the old one has been used. [redundantAssignment] mednafen/src/nes/ops.h:77:6: note: pbackus is assigned mednafen/src/nes/ops.h:78:12: note: pbackus is overwritten mednafen/src/ngp/T6W28_Apu.cpp:25:12: warning: Member variable 'T6W28_Osc::output' is not initialized in the constructor. [uninitMemberVar] mednafen/src/ngp/T6W28_Apu.cpp:25:12: warning: Member variable 'T6W28_Osc::output_select' is not initialized in the constructor. [uninitMemberVar] mednafen/src/ngp/T6W28_Apu.cpp:25:12: warning: Member variable 'T6W28_Osc::delay' is not initialized in the constructor. [uninitMemberVar] mednafen/src/ngp/T6W28_Apu.cpp:25:12: warning: Member variable 'T6W28_Osc::last_amp_left' is not initialized in the constructor. [uninitMemberVar] mednafen/src/ngp/T6W28_Apu.cpp:25:12: warning: Member variable 'T6W28_Osc::last_amp_right' is not initialized in the constructor. [uninitMemberVar] mednafen/src/ngp/T6W28_Apu.cpp:25:12: warning: Member variable 'T6W28_Osc::volume_left' is not initialized in the constructor. [uninitMemberVar] mednafen/src/ngp/T6W28_Apu.cpp:25:12: warning: Member variable 'T6W28_Osc::volume_right' is not initialized in the constructor. [uninitMemberVar] mednafen/src/ngp/T6W28_Apu.h:54:7: style:inconclusive: Technically the member function 'MDFN_IEN_NGP::T6W28_Apu::osc_output' can be const. [functionConst] mednafen/src/ngp/T6W28_Apu.cpp:245:17: note: Technically the member function 'MDFN_IEN_NGP::T6W28_Apu::osc_output' can be const. mednafen/src/ngp/T6W28_Apu.h:54:7: note: Technically the member function 'MDFN_IEN_NGP::T6W28_Apu::osc_output' can be const. mednafen/src/ngp/T6W28_Apu.h:69:7: style:inconclusive: Technically the member function 'MDFN_IEN_NGP::T6W28_Apu::save_state' can be const. [functionConst] mednafen/src/ngp/T6W28_Apu.cpp:375:17: note: Technically the member function 'MDFN_IEN_NGP::T6W28_Apu::save_state' can be const. mednafen/src/ngp/T6W28_Apu.h:69:7: note: Technically the member function 'MDFN_IEN_NGP::T6W28_Apu::save_state' can be const. mednafen/src/ngp/T6W28_Apu.h:89:45: style:inconclusive: Function 'output' argument 1 names different: declaration 'mono' definition 'b'. [funcArgNamesDifferent] mednafen/src/ngp/T6W28_Apu.h:46:28: note: Function 'output' argument 1 names different: declaration 'mono' definition 'b'. mednafen/src/ngp/T6W28_Apu.h:89:45: note: Function 'output' argument 1 names different: declaration 'mono' definition 'b'. mednafen/src/ngp/T6W28_Apu.h:91:40: style:inconclusive: Function 'osc_output' argument 1 names different: declaration 'index' definition 'i'. [funcArgNamesDifferent] mednafen/src/ngp/T6W28_Apu.h:53:23: note: Function 'osc_output' argument 1 names different: declaration 'index' definition 'i'. mednafen/src/ngp/T6W28_Apu.h:91:40: note: Function 'osc_output' argument 1 names different: declaration 'index' definition 'i'. mednafen/src/ngp/T6W28_Apu.h:91:56: style:inconclusive: Function 'osc_output' argument 2 names different: declaration 'mono' definition 'b'. [funcArgNamesDifferent] mednafen/src/ngp/T6W28_Apu.h:53:43: note: Function 'osc_output' argument 2 names different: declaration 'mono' definition 'b'. mednafen/src/ngp/T6W28_Apu.h:91:56: note: Function 'osc_output' argument 2 names different: declaration 'mono' definition 'b'. mednafen/src/ngp/TLCS-900h/TLCS900h_disassemble.cpp:368:8: style: Local variable 'dst' shadows outer function [shadowFunction] mednafen/src/ngp/TLCS-900h/TLCS900h_disassemble.cpp:312:13: note: Shadowed declaration mednafen/src/ngp/TLCS-900h/TLCS900h_disassemble.cpp:368:8: note: Shadow variable mednafen/src/ngp/TLCS-900h/TLCS900h_disassemble.cpp:379:8: style: Local variable 'dst' shadows outer function [shadowFunction] mednafen/src/ngp/TLCS-900h/TLCS900h_disassemble.cpp:312:13: note: Shadowed declaration mednafen/src/ngp/TLCS-900h/TLCS900h_disassemble.cpp:379:8: note: Shadow variable mednafen/src/ngp/TLCS-900h/TLCS900h_disassemble.cpp:531:8: style: Local variable 'dst' shadows outer function [shadowFunction] mednafen/src/ngp/TLCS-900h/TLCS900h_disassemble.cpp:312:13: note: Shadowed declaration mednafen/src/ngp/TLCS-900h/TLCS900h_disassemble.cpp:531:8: note: Shadow variable mednafen/src/nes/ppu/ppu.cpp:1509:3: portability: Using memset() on struct which contains a floating point number. [memsetClassFloat] mednafen/src/nes/ppu/ppu-subline.h:42:37: style: Condition 'scanline>=0' is always true [knownConditionTrueFalse] mednafen/src/nes/ppu/ppu-subline.h:26:27: note: Assuming that condition 'scanline>=0' is not redundant mednafen/src/nes/ppu/ppu-subline.h:42:37: note: Condition 'scanline>=0' is always true mednafen/src/nes/ppu/ppu.cpp:1546:17: style: C-style pointer casting [cstyleCast] mednafen/src/nes/ppu/ppu-subline.h:4:16: style: The comparison 'MMC5Mode >= 3' is always true. [knownConditionTrueFalse] mednafen/src/nes/ppu/ppu.cpp:712:26: note: 'MMC5Mode' is assigned value '3' here. mednafen/src/nes/ppu/ppu-subline.h:4:16: note: The comparison 'MMC5Mode >= 3' is always true. mednafen/src/nes/ppu/ppu-subline.h:78:17: style: The comparison 'MMC5Mode >= 3' is always true. [knownConditionTrueFalse] mednafen/src/nes/ppu/ppu.cpp:712:26: note: 'MMC5Mode' is assigned value '3' here. mednafen/src/nes/ppu/ppu-subline.h:78:17: note: The comparison 'MMC5Mode >= 3' is always true. mednafen/src/nes/ppu/ppu.cpp:687:6: style: The scope of the variable 'x' can be reduced. [variableScope] mednafen/src/nes/ppu/ppu.cpp:1141:17: style: The scope of the variable 'C' can be reduced. [variableScope] mednafen/src/nes/ppu/ppu.cpp:200:53: style:inconclusive: Function 'MDFNNES_SetPixelFormat' argument 1 names different: declaration 'nf' definition 'pixel_format'. [funcArgNamesDifferent] mednafen/src/nes/ppu/ppu.h:27:53: note: Function 'MDFNNES_SetPixelFormat' argument 1 names different: declaration 'nf' definition 'pixel_format'. mednafen/src/nes/ppu/ppu.cpp:200:53: note: Function 'MDFNNES_SetPixelFormat' argument 1 names different: declaration 'nf' definition 'pixel_format'. mednafen/src/ngp/biosHLE.cpp:143:8: style: Local variable 'interrupt' shadows outer function [shadowFunction] mednafen/src/ngp/interrupt.h:22:6: note: Shadowed declaration mednafen/src/ngp/biosHLE.cpp:143:8: note: Shadow variable mednafen/src/ngp/gfx.cpp:24:15: warning: Member variable 'NGPGFX_CLASS::C_OVR' is not initialized in the constructor. [uninitMemberVar] mednafen/src/ngp/gfx.cpp:24:15: warning: Member variable 'NGPGFX_CLASS::BLNK' is not initialized in the constructor. [uninitMemberVar] mednafen/src/ngp/gfx_scanline_mono.cpp:128:6: style: The scope of the variable 'spr' can be reduced. [variableScope] mednafen/src/ngp/gfx_scanline_mono.cpp:24:45: style: Parameter 'palette_ptr' can be declared with const [constParameter] mednafen/src/ngp/rom.cpp:91:15: style: C-style pointer casting [cstyleCast] mednafen/src/pce/dis6280.h:5:3: warning:inconclusive: Class 'Dis6280' which has virtual members does not have a virtual destructor. [virtualDestructor] mednafen/src/pce/dis6280.cpp:319:9: style: The scope of the variable 'borked' can be reduced. [variableScope] mednafen/src/pce/vce.h:52:13: style:inconclusive: Technically the member function 'MDFN_IEN_PCE::VCE::GetScanlineNo' can be const. [functionConst] mednafen/src/pce/vce.h:31:2: style: Class 'VCE' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/pce/debug.cpp:307:14: style: Unused variable: ret [unusedVariable] mednafen/src/pce/debug.cpp:503:36: style: Unused variable: bpit [unusedVariable] mednafen/src/pce/debug.cpp:209:26: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/pce/debug.cpp:387:69: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/pce/debug.cpp:422:71: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/pce/huc6280.cpp:440:10: warning: Member variable 'HuC6280::FastPageR' is not initialized in the constructor. [uninitMemberVar] mednafen/src/pce/huc6280.cpp:440:10: warning: Member variable 'HuC6280::FastMap' is not initialized in the constructor. [uninitMemberVar] mednafen/src/pce/huc6280.cpp:692:3: style: Label 'skip_T_flag_clear' is not used. [unusedLabel] mednafen/src/pce/mcgenjin.h:46:2: style: Class 'MCGenjin' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/pce/input/gamepad.cpp:44:20: warning: Member variable 'PCE_Input_Gamepad::SEL' is not initialized in the constructor. [uninitMemberVar] mednafen/src/pce/input/gamepad.cpp:44:20: warning: Member variable 'PCE_Input_Gamepad::CLR' is not initialized in the constructor. [uninitMemberVar] mednafen/src/pce/input/gamepad.cpp:44:20: warning: Member variable 'PCE_Input_Gamepad::AVPad6Which' is not initialized in the constructor. [uninitMemberVar] mednafen/src/pce/input/mouse.cpp:59:18: warning: Member variable 'PCE_Input_Mouse::SEL' is not initialized in the constructor. [uninitMemberVar] mednafen/src/pce/input/mouse.cpp:59:18: warning: Member variable 'PCE_Input_Mouse::CLR' is not initialized in the constructor. [uninitMemberVar] mednafen/src/pce/input/tsushinkb.cpp:55:22: warning: Member variable 'PCE_Input_TsushinKB::SEL' is not initialized in the constructor. [uninitMemberVar] mednafen/src/pce/input/tsushinkb.cpp:55:22: warning: Member variable 'PCE_Input_TsushinKB::CLR' is not initialized in the constructor. [uninitMemberVar] mednafen/src/pce/input/tsushinkb.cpp:55:22: warning: Member variable 'PCE_Input_TsushinKB::last_capslock' is not initialized in the constructor. [uninitMemberVar] mednafen/src/pce/pce.cpp:859:16: warning: Assert statement calls a function which may have desired side effects: 'Timestamp'. [assertWithSideEffect] mednafen/src/pce/pce.cpp:297:2: portability: Using memset() on struct which contains a floating point number. [memsetClassFloat] mednafen/src/pce/pce.cpp:391:6: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] mednafen/src/pce/pce.cpp:1127:76: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/pce/vce.cpp:110:6: warning: Member variable 'VCE::FrameDone' is not initialized in the constructor. [uninitMemberVar] mednafen/src/pce/vce.cpp:110:6: warning: Member variable 'VCE::skipframe' is not initialized in the constructor. [uninitMemberVar] mednafen/src/pce/vce.cpp:110:6: warning: Member variable 'VCE::LW' is not initialized in the constructor. [uninitMemberVar] mednafen/src/pce/vce.cpp:110:6: warning: Member variable 'VCE::scanline_out_ptr' is not initialized in the constructor. [uninitMemberVar] mednafen/src/pce/vce.cpp:110:6: warning: Member variable 'VCE::hblank' is not initialized in the constructor. [uninitMemberVar] mednafen/src/pce/vce.cpp:110:6: warning: Member variable 'VCE::vblank' is not initialized in the constructor. [uninitMemberVar] mednafen/src/pce/vce.cpp:110:6: warning: Member variable 'VCE::NeedSLReset' is not initialized in the constructor. [uninitMemberVar] mednafen/src/pce/vce.cpp:110:6: warning: Member variable 'VCE::lc263' is not initialized in the constructor. [uninitMemberVar] mednafen/src/pce/vce.cpp:110:6: warning: Member variable 'VCE::bw' is not initialized in the constructor. [uninitMemberVar] mednafen/src/pce/vce.cpp:119:2: performance: Variable 'cd_event' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/pce/vce.cpp:122:2: performance: Variable 'pitch32' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/pce/vce.cpp:770:7: style: The scope of the variable 'chip' can be reduced. [variableScope] mednafen/src/pce/vce.cpp:812:7: style: The scope of the variable 'chip' can be reduced. [variableScope] mednafen/src/pce_fast/hes.cpp:217:69: style:inconclusive: Function 'HES_Draw' argument 3 names different: declaration 'samples' definition 'SoundBuf'. [funcArgNamesDifferent] mednafen/src/pce_fast/hes.h:5:69: note: Function 'HES_Draw' argument 3 names different: declaration 'samples' definition 'SoundBuf'. mednafen/src/pce_fast/hes.cpp:217:69: note: Function 'HES_Draw' argument 3 names different: declaration 'samples' definition 'SoundBuf'. mednafen/src/pce_fast/hes.cpp:217:85: style:inconclusive: Function 'HES_Draw' argument 4 names different: declaration 'sampcount' definition 'SoundBufSize'. [funcArgNamesDifferent] mednafen/src/pce_fast/hes.h:5:84: note: Function 'HES_Draw' argument 4 names different: declaration 'sampcount' definition 'SoundBufSize'. mednafen/src/pce_fast/hes.cpp:217:85: note: Function 'HES_Draw' argument 4 names different: declaration 'sampcount' definition 'SoundBufSize'. mednafen/src/pce_fast/huc.cpp:167:13: style: The statement 'if (m_len!=sf2_required_size) m_len=sf2_required_size' is logically equivalent to 'm_len=sf2_required_size'. [duplicateConditionalAssign] mednafen/src/pce_fast/huc.cpp:168:11: note: Assignment 'm_len=sf2_required_size' mednafen/src/pce_fast/huc.cpp:167:13: note: Condition 'm_len!=sf2_required_size' is redundant mednafen/src/pce_fast/vdc.h:123:6: style: The scope of the variable 'chip' can be reduced. [variableScope] mednafen/src/pce_fast/huc6280.cpp:715:2: style: Label 'GetOutBMT' is not used. [unusedLabel] mednafen/src/pce_fast/pce.cpp:99:1: error: Found a exit path from function with non-void return type that has missing return statement [missingReturn] mednafen/src/pce_fast/pce.cpp:106:1: error: Found a exit path from function with non-void return type that has missing return statement [missingReturn] mednafen/src/pce_fast/pce.cpp:162:2: portability: Using memset() on struct which contains a floating point number. [memsetClassFloat] mednafen/src/pce_fast/psg.h:42:9: style: Class 'PCEFast_PSG' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/pce_fast/pce.cpp:489:3: performance: Passing the result of c_str() to a function that takes std::string as argument no. 1 is slow and redundant. [stlcstrParam] mednafen/src/pce_fast/pce.cpp:269:6: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] mednafen/src/pce_fast/pcecd_drive.cpp:400:31: style:inconclusive: Function 'PCECD_Drive_SetDisc' argument 1 names different: declaration 'tray_open' definition 'new_tray_open'. [funcArgNamesDifferent] mednafen/src/pce_fast/pcecd_drive.h:84:31: note: Function 'PCECD_Drive_SetDisc' argument 1 names different: declaration 'tray_open' definition 'new_tray_open'. mednafen/src/pce_fast/pcecd_drive.cpp:400:31: note: Function 'PCECD_Drive_SetDisc' argument 1 names different: declaration 'tray_open' definition 'new_tray_open'. mednafen/src/pce_fast/pcecd_drive.cpp:1221:27: style:inconclusive: Function 'PCECD_Drive_Init' argument 1 names different: declaration 'CDDATimeDiv' definition 'cdda_time_div'. [funcArgNamesDifferent] mednafen/src/pce_fast/pcecd_drive.h:77:27: note: Function 'PCECD_Drive_Init' argument 1 names different: declaration 'CDDATimeDiv' definition 'cdda_time_div'. mednafen/src/pce_fast/pcecd_drive.cpp:1221:27: note: Function 'PCECD_Drive_Init' argument 1 names different: declaration 'CDDATimeDiv' definition 'cdda_time_div'. mednafen/src/pce_fast/psg.cpp:54:19: error: Array 'dbtable[32][32]' accessed at index dbtable[*][32], which is out of bounds. [arrayIndexOutOfBounds] mednafen/src/pce_fast/psg.cpp:52:33: note: Assignment 'sv=((ch->lfsr&1)<<5)-(ch->lfsr&1)', assigned value is 32 mednafen/src/pce_fast/psg.cpp:54:19: note: Array index out of bounds mednafen/src/pce_fast/psg.cpp:54:19: error: Array 'dbtable[32][32]' accessed at index dbtable[*][-1], which is out of bounds. [negativeIndex] mednafen/src/pce_fast/psg.cpp:52:33: note: Assignment 'sv=((ch->lfsr&1)<<5)-(ch->lfsr&1)', assigned value is -1 mednafen/src/pce_fast/psg.cpp:54:19: note: Negative array index mednafen/src/pce_fast/psg.cpp:55:19: error: Array 'dbtable[32][32]' accessed at index dbtable[*][32], which is out of bounds. [arrayIndexOutOfBounds] mednafen/src/pce_fast/psg.cpp:52:33: note: Assignment 'sv=((ch->lfsr&1)<<5)-(ch->lfsr&1)', assigned value is 32 mednafen/src/pce_fast/psg.cpp:55:19: note: Array index out of bounds mednafen/src/pce_fast/psg.cpp:55:19: error: Array 'dbtable[32][32]' accessed at index dbtable[*][-1], which is out of bounds. [negativeIndex] mednafen/src/pce_fast/psg.cpp:52:33: note: Assignment 'sv=((ch->lfsr&1)<<5)-(ch->lfsr&1)', assigned value is -1 mednafen/src/pce_fast/psg.cpp:55:19: note: Negative array index mednafen/src/pcfx/debug.cpp:510:29: error: Uninitialized struct member: tmp.logical [uninitStructMember] mednafen/src/pcfx/debug.cpp:512:30: error: Uninitialized struct member: tmp.logical [uninitStructMember] mednafen/src/pcfx/debug.cpp:514:31: error: Uninitialized struct member: tmp.logical [uninitStructMember] mednafen/src/pcfx/debug.cpp:516:32: error: Uninitialized struct member: tmp.logical [uninitStructMember] mednafen/src/pcfx/debug.cpp:518:33: error: Uninitialized struct member: tmp.logical [uninitStructMember] mednafen/src/pcfx/debug.cpp:520:34: error: Uninitialized struct member: tmp.logical [uninitStructMember] mednafen/src/pcfx/debug.cpp:522:27: error: Uninitialized struct member: tmp.logical [uninitStructMember] mednafen/src/pcfx/debug.cpp:48:14: style: struct member '__PCFX_BPOINT::logical' is never used. [unusedStructMember] mednafen/src/pcfx/debug.cpp:480:37: style: Unused variable: bpit [unusedVariable] mednafen/src/pcfx/debug.cpp:256:26: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/pcfx/debug.cpp:419:65: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/md/vdp.cpp:56:8: warning: Member variable 'MDVDP::hint_pending' is not initialized in the constructor. [uninitMemberVar] mednafen/src/md/vdp.cpp:56:8: warning: Member variable 'MDVDP::vint_pending' is not initialized in the constructor. [uninitMemberVar] mednafen/src/md/vdp.cpp:56:8: warning: Member variable 'MDVDP::dma_fill' is not initialized in the constructor. [uninitMemberVar] mednafen/src/md/vdp.cpp:56:8: warning: Member variable 'MDVDP::im2_flag' is not initialized in the constructor. [uninitMemberVar] mednafen/src/md/vdp.cpp:56:8: warning: Member variable 'MDVDP::visible_frame_end' is not initialized in the constructor. [uninitMemberVar] mednafen/src/md/vdp.cpp:56:8: warning: Member variable 'MDVDP::v_counter' is not initialized in the constructor. [uninitMemberVar] mednafen/src/md/vdp.cpp:56:8: warning: Member variable 'MDVDP::v_update' is not initialized in the constructor. [uninitMemberVar] mednafen/src/md/vdp.cpp:56:8: warning: Member variable 'MDVDP::is_pal' is not initialized in the constructor. [uninitMemberVar] mednafen/src/md/vdp.cpp:56:8: warning: Member variable 'MDVDP::report_pal' is not initialized in the constructor. [uninitMemberVar] mednafen/src/md/vdp.cpp:56:8: warning: Member variable 'MDVDP::WantAutoAspect' is not initialized in the constructor. [uninitMemberVar] mednafen/src/md/vdp.cpp:56:8: warning: Member variable 'MDVDP::surface' is not initialized in the constructor. [uninitMemberVar] mednafen/src/md/vdp.cpp:56:8: warning: Member variable 'MDVDP::rect' is not initialized in the constructor. [uninitMemberVar] mednafen/src/md/vdp.cpp:56:8: warning: Member variable 'MDVDP::espec' is not initialized in the constructor. [uninitMemberVar] mednafen/src/md/vdp.cpp:60:5: performance: Variable 'UserLE' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/md/vdp.h:61:9: style:inconclusive: Technically the member function 'MDFN_IEN_MD::MDVDP::vdp_hvc_r' can be const. [functionConst] mednafen/src/md/vdp.cpp:563:15: note: Technically the member function 'MDFN_IEN_MD::MDVDP::vdp_hvc_r' can be const. mednafen/src/md/vdp.h:61:9: note: Technically the member function 'MDFN_IEN_MD::MDVDP::vdp_hvc_r' can be const. mednafen/src/md/vdp.h:64:7: performance:inconclusive: Technically the member function 'MDFN_IEN_MD::MDVDP::vdp_test_w' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/md/vdp.cpp:678:13: note: Technically the member function 'MDFN_IEN_MD::MDVDP::vdp_test_w' can be static (but you may consider moving to unnamed namespace). mednafen/src/md/vdp.h:64:7: note: Technically the member function 'MDFN_IEN_MD::MDVDP::vdp_test_w' can be static (but you may consider moving to unnamed namespace). mednafen/src/md/vdp.h:184:7: performance:inconclusive: Technically the member function 'MDFN_IEN_MD::MDVDP::RedoViewport' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/md/vdp.cpp:97:13: note: Technically the member function 'MDFN_IEN_MD::MDVDP::RedoViewport' can be static (but you may consider moving to unnamed namespace). mednafen/src/md/vdp.h:184:7: note: Technically the member function 'MDFN_IEN_MD::MDVDP::RedoViewport' can be static (but you may consider moving to unnamed namespace). mednafen/src/md/vdp.h:230:6: performance:inconclusive: Technically the member function 'MDFN_IEN_MD::MDVDP::make_lut_bg' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/md/vdp.cpp:1391:12: note: Technically the member function 'MDFN_IEN_MD::MDVDP::make_lut_bg' can be static (but you may consider moving to unnamed namespace). mednafen/src/md/vdp.h:230:6: note: Technically the member function 'MDFN_IEN_MD::MDVDP::make_lut_bg' can be static (but you may consider moving to unnamed namespace). mednafen/src/md/vdp.h:231:6: performance:inconclusive: Technically the member function 'MDFN_IEN_MD::MDVDP::make_lut_obj' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/md/vdp.cpp:1420:12: note: Technically the member function 'MDFN_IEN_MD::MDVDP::make_lut_obj' can be static (but you may consider moving to unnamed namespace). mednafen/src/md/vdp.h:231:6: note: Technically the member function 'MDFN_IEN_MD::MDVDP::make_lut_obj' can be static (but you may consider moving to unnamed namespace). mednafen/src/md/vdp.h:232:6: performance:inconclusive: Technically the member function 'MDFN_IEN_MD::MDVDP::make_lut_bg_ste' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/md/vdp.cpp:1458:12: note: Technically the member function 'MDFN_IEN_MD::MDVDP::make_lut_bg_ste' can be static (but you may consider moving to unnamed namespace). mednafen/src/md/vdp.h:232:6: note: Technically the member function 'MDFN_IEN_MD::MDVDP::make_lut_bg_ste' can be static (but you may consider moving to unnamed namespace). mednafen/src/md/vdp.h:233:6: performance:inconclusive: Technically the member function 'MDFN_IEN_MD::MDVDP::make_lut_obj_ste' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/md/vdp.cpp:1492:12: note: Technically the member function 'MDFN_IEN_MD::MDVDP::make_lut_obj_ste' can be static (but you may consider moving to unnamed namespace). mednafen/src/md/vdp.h:233:6: note: Technically the member function 'MDFN_IEN_MD::MDVDP::make_lut_obj_ste' can be static (but you may consider moving to unnamed namespace). mednafen/src/md/vdp.h:234:6: performance:inconclusive: Technically the member function 'MDFN_IEN_MD::MDVDP::make_lut_bgobj_ste' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/md/vdp.cpp:1516:12: note: Technically the member function 'MDFN_IEN_MD::MDVDP::make_lut_bgobj_ste' can be static (but you may consider moving to unnamed namespace). mednafen/src/md/vdp.h:234:6: note: Technically the member function 'MDFN_IEN_MD::MDVDP::make_lut_bgobj_ste' can be static (but you may consider moving to unnamed namespace). mednafen/src/md/vdp.h:236:7: performance:inconclusive: Technically the member function 'MDFN_IEN_MD::MDVDP::merge' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/md/vdp.cpp:1673:13: note: Technically the member function 'MDFN_IEN_MD::MDVDP::merge' can be static (but you may consider moving to unnamed namespace). mednafen/src/md/vdp.h:236:7: note: Technically the member function 'MDFN_IEN_MD::MDVDP::merge' can be static (but you may consider moving to unnamed namespace). mednafen/src/md/vdp.h:241:7: style:inconclusive: Technically the member function 'MDFN_IEN_MD::MDVDP::Recalc68KSuspend' can be const. [functionConst] mednafen/src/md/vdp.cpp:380:20: note: Technically the member function 'MDFN_IEN_MD::MDVDP::Recalc68KSuspend' can be const. mednafen/src/md/vdp.h:241:7: note: Technically the member function 'MDFN_IEN_MD::MDVDP::Recalc68KSuspend' can be const. mednafen/src/md/vdp.h:250:7: performance:inconclusive: Technically the member function 'MDFN_IEN_MD::MDVDP::Run' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/md/vdp.cpp:682:13: note: Technically the member function 'MDFN_IEN_MD::MDVDP::Run' can be static (but you may consider moving to unnamed namespace). mednafen/src/md/vdp.h:250:7: note: Technically the member function 'MDFN_IEN_MD::MDVDP::Run' can be static (but you may consider moving to unnamed namespace). mednafen/src/md/vdp.cpp:1443:20: style: Condition 's' is always true [knownConditionTrueFalse] mednafen/src/md/vdp.cpp:1812:17: style: Condition 'xpos==0' is always true [knownConditionTrueFalse] mednafen/src/md/vdp.cpp:1810:17: note: Assuming that condition 'xpos!=0' is not redundant mednafen/src/md/vdp.cpp:1812:17: note: Condition 'xpos==0' is always true mednafen/src/md/vdp.cpp:1884:17: style: Condition 'xpos==0' is always true [knownConditionTrueFalse] mednafen/src/md/vdp.cpp:1882:17: note: Assuming that condition 'xpos!=0' is not redundant mednafen/src/md/vdp.cpp:1884:17: note: Condition 'xpos==0' is always true mednafen/src/md/vdp.cpp:1235:9: style: Variable 'end' is reassigned a value before the old one has been used. [redundantAssignment] mednafen/src/md/vdp.cpp:1224:13: note: end is assigned mednafen/src/md/vdp.cpp:1235:9: note: end is overwritten mednafen/src/md/vdp.cpp:1235:9: style: Variable 'end' is reassigned a value before the old one has been used. [redundantAssignment] mednafen/src/md/vdp.cpp:1230:13: note: end is assigned mednafen/src/md/vdp.cpp:1235:9: note: end is overwritten mednafen/src/pcfx/huc6273.cpp:143:7: warning: Either the condition '(0x20-InFIFO)>0' is redundant or the array 'FIFO[32]' is accessed at index 33, which is out of bounds. [arrayIndexOutOfBoundsCond] mednafen/src/pcfx/huc6273.cpp:141:9: note: Assuming that condition '(0x20-InFIFO)>0' is not redundant mednafen/src/pcfx/huc6273.cpp:143:7: note: Array index out of bounds mednafen/src/md/vdp.cpp:873:9: style: The scope of the variable 'col' can be reduced. [variableScope] mednafen/src/md/vdp.cpp:873:14: style: The scope of the variable 'row' can be reduced. [variableScope] mednafen/src/md/vdp.cpp:874:9: style: The scope of the variable 'vcol' can be reduced. [variableScope] mednafen/src/md/vdp.cpp:874:15: style: The scope of the variable 'vrow' can be reduced. [variableScope] mednafen/src/md/vdp.cpp:875:9: style: The scope of the variable 'width' can be reduced. [variableScope] mednafen/src/md/vdp.cpp:875:16: style: The scope of the variable 'height' can be reduced. [variableScope] mednafen/src/md/vdp.cpp:876:9: style: The scope of the variable 'flipx' can be reduced. [variableScope] mednafen/src/md/vdp.cpp:876:16: style: The scope of the variable 'flipy' can be reduced. [variableScope] mednafen/src/md/vdp.cpp:877:12: style: The scope of the variable 'name' can be reduced. [variableScope] mednafen/src/md/vdp.cpp:1036:18: style: The scope of the variable 'src' can be reduced. [variableScope] mednafen/src/md/vdp.cpp:1054:18: style: The scope of the variable 'src' can be reduced. [variableScope] mednafen/src/md/vdp.cpp:1719:9: style: The scope of the variable 'height' can be reduced. [variableScope] mednafen/src/md/vdp.cpp:1787:9: style: The scope of the variable 'width' can be reduced. [variableScope] mednafen/src/md/vdp.cpp:1858:9: style: The scope of the variable 'width' can be reduced. [variableScope] mednafen/src/md/vdp.cpp:857:43: style:inconclusive: Function 'SetSurface' argument 1 names different: declaration 'espec' definition 'espec_arg'. [funcArgNamesDifferent] mednafen/src/md/vdp.h:69:37: note: Function 'SetSurface' argument 1 names different: declaration 'espec' definition 'espec_arg'. mednafen/src/md/vdp.cpp:857:43: note: Function 'SetSurface' argument 1 names different: declaration 'espec' definition 'espec_arg'. mednafen/src/md/vdp.cpp:1648:87: style:inconclusive: Function 'CopyLineSurface < uint16 >' argument 3 names different: declaration 'vp_w' definition 'width'. [funcArgNamesDifferent] mednafen/src/md/vdp.h:235:102: note: Function 'CopyLineSurface < uint16 >' argument 3 names different: declaration 'vp_w' definition 'width'. mednafen/src/md/vdp.cpp:1648:87: note: Function 'CopyLineSurface < uint16 >' argument 3 names different: declaration 'vp_w' definition 'width'. mednafen/src/md/vdp.cpp:1648:87: style:inconclusive: Function 'CopyLineSurface < uint32 >' argument 3 names different: declaration 'vp_w' definition 'width'. [funcArgNamesDifferent] mednafen/src/md/vdp.h:235:102: note: Function 'CopyLineSurface < uint32 >' argument 3 names different: declaration 'vp_w' definition 'width'. mednafen/src/md/vdp.cpp:1648:87: note: Function 'CopyLineSurface < uint32 >' argument 3 names different: declaration 'vp_w' definition 'width'. mednafen/src/md/vdp.cpp:1780:11: style: Variable 'sizetab' can be declared with const [constVariable] mednafen/src/md/vdp.cpp:1851:11: style: Variable 'sizetab' can be declared with const [constVariable] mednafen/src/md/vdp.cpp:1775:53: style: Parameter 'table' can be declared with const [constParameter] mednafen/src/md/vdp.cpp:1846:57: style: Parameter 'table' can be declared with const [constParameter] mednafen/src/md/vdp.cpp:1673:26: style: Parameter 'srca' can be declared with const [constParameter] mednafen/src/md/vdp.cpp:1673:39: style: Parameter 'srcb' can be declared with const [constParameter] mednafen/src/md/vdp.cpp:1673:64: style: Parameter 'table' can be declared with const [constParameter] mednafen/src/pcfx/input/gamepad.cpp:34:3: performance: Variable 'buttons' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/pcfx/input/gamepad.cpp:54:32: error: Signed integer overflow for expression 'FX_SIG_PAD<<28'. [integerOverflow] mednafen/src/pcfx/input/mouse.cpp:34:3: performance: Variable 'x' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/pcfx/input/mouse.cpp:35:3: performance: Variable 'y' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/pcfx/input/mouse.cpp:36:3: performance: Variable 'button' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/pcfx/input/mouse.cpp:32:2: style: Class 'PCFX_Input_Mouse' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/pcfx/input/mouse.cpp:56:29: error: Signed integer overflow for expression 'FX_SIG_MOUSE<<28'. [integerOverflow] mednafen/src/pcfx/input.cpp:89:64: style:inconclusive: Function 'TransformInput' argument 2 names different: declaration 'DisableSR' definition 'DisableSR_L'. [funcArgNamesDifferent] mednafen/src/pcfx/input.h:51:54: note: Function 'TransformInput' argument 2 names different: declaration 'DisableSR' definition 'DisableSR_L'. mednafen/src/pcfx/input.cpp:89:64: note: Function 'TransformInput' argument 2 names different: declaration 'DisableSR' definition 'DisableSR_L'. mednafen/src/pcfx/input.cpp:337:34: error: Signed integer overflow for expression 'FX_SIG_TAP<<28'. [integerOverflow] mednafen/src/pcfx/rainbow.cpp:723:70: style: Parameter 'palette_ptr' can be declared with const [constParameter] mednafen/src/pcfx/rainbow.cpp:409:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/rainbow.cpp:410:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/rainbow.cpp:411:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/rainbow.cpp:412:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/rainbow.cpp:413:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/soundbox.cpp:344:5: portability: Using memset() on struct which contains a floating point number. [memsetClassFloat] mednafen/src/pcfx/soundbox.cpp:638:45: style:inconclusive: Function 'SoundBox_Flush' argument 1 names different: declaration 'timestamp' definition 'end_timestamp'. [funcArgNamesDifferent] mednafen/src/pcfx/soundbox.h:29:45: note: Function 'SoundBox_Flush' argument 1 names different: declaration 'timestamp' definition 'end_timestamp'. mednafen/src/pcfx/soundbox.cpp:638:45: note: Function 'SoundBox_Flush' argument 1 names different: declaration 'timestamp' definition 'end_timestamp'. mednafen/src/psx/cdc.cpp:80:9: warning: Member variable 'PS_CDC::DiscChanged' is not initialized in the constructor. [uninitMemberVar] mednafen/src/psx/cdc.cpp:80:9: warning: Member variable 'PS_CDC::SubQChecksumOK' is not initialized in the constructor. [uninitMemberVar] mednafen/src/psx/cdc.cpp:80:9: warning: Member variable 'PS_CDC::HeaderBufValid' is not initialized in the constructor. [uninitMemberVar] mednafen/src/psx/cdc.cpp:80:9: warning: Member variable 'PS_CDC::StatusAfterSeek' is not initialized in the constructor. [uninitMemberVar] mednafen/src/psx/cdc.cpp:80:9: warning: Member variable 'PS_CDC::Forward' is not initialized in the constructor. [uninitMemberVar] mednafen/src/psx/cdc.cpp:80:9: warning: Member variable 'PS_CDC::Backward' is not initialized in the constructor. [uninitMemberVar] mednafen/src/psx/cdc.cpp:80:9: warning: Member variable 'PS_CDC::Muted' is not initialized in the constructor. [uninitMemberVar] mednafen/src/psx/cdc.cpp:80:9: warning: Member variable 'PS_CDC::HoldLogicalPos' is not initialized in the constructor. [uninitMemberVar] mednafen/src/psx/cdc.cpp:80:9: warning: Member variable 'PS_CDC::AsyncIRQPending' is not initialized in the constructor. [uninitMemberVar] mednafen/src/psx/cdc.cpp:80:9: warning: Member variable 'PS_CDC::SeekFinished' is not initialized in the constructor. [uninitMemberVar] mednafen/src/psx/cdc.cpp:80:9: warning: Member variable 'PS_CDC::CommandLoc_Dirty' is not initialized in the constructor. [uninitMemberVar] mednafen/src/psx/cdc.h:52:8: style:inconclusive: Technically the member function 'MDFN_IEN_PSX::PS_CDC::CalcNextEvent' can be const. [functionConst] mednafen/src/psx/cdc.cpp:119:15: note: Technically the member function 'MDFN_IEN_PSX::PS_CDC::CalcNextEvent' can be const. mednafen/src/psx/cdc.h:52:8: note: Technically the member function 'MDFN_IEN_PSX::PS_CDC::CalcNextEvent' can be const. mednafen/src/psx/cdc.h:78:7: style:inconclusive: Technically the member function 'MDFN_IEN_PSX::PS_CDC::ApplyVolume' can be const. [functionConst] mednafen/src/psx/cdc.cpp:513:21: note: Technically the member function 'MDFN_IEN_PSX::PS_CDC::ApplyVolume' can be const. mednafen/src/psx/cdc.h:78:7: note: Technically the member function 'MDFN_IEN_PSX::PS_CDC::ApplyVolume' can be const. mednafen/src/psx/cdc.h:119:7: style:inconclusive: Technically the member function 'MDFN_IEN_PSX::PS_CDC::RecalcIRQ' can be const. [functionConst] mednafen/src/psx/cdc.cpp:385:14: note: Technically the member function 'MDFN_IEN_PSX::PS_CDC::RecalcIRQ' can be const. mednafen/src/psx/cdc.h:119:7: note: Technically the member function 'MDFN_IEN_PSX::PS_CDC::RecalcIRQ' can be const. mednafen/src/psx/cdc.h:229:7: style:inconclusive: Technically the member function 'MDFN_IEN_PSX::PS_CDC::XA_Test' can be const. [functionConst] mednafen/src/psx/cdc.cpp:644:14: note: Technically the member function 'MDFN_IEN_PSX::PS_CDC::XA_Test' can be const. mednafen/src/psx/cdc.h:229:7: note: Technically the member function 'MDFN_IEN_PSX::PS_CDC::XA_Test' can be const. mednafen/src/psx/cdc.h:288:8: performance:inconclusive: Technically the member function 'MDFN_IEN_PSX::PS_CDC::Command_Init' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/psx/cdc.cpp:2477:15: note: Technically the member function 'MDFN_IEN_PSX::PS_CDC::Command_Init' can be static (but you may consider moving to unnamed namespace). mednafen/src/psx/cdc.h:288:8: note: Technically the member function 'MDFN_IEN_PSX::PS_CDC::Command_Init' can be static (but you may consider moving to unnamed namespace). mednafen/src/psx/cdc.cpp:816:65: style: Parameter 'r' can be declared with const [constParameter] mednafen/src/psx/cdc.cpp:470:32: style: Parameter 'subpw' can be declared with const [constParameter] mednafen/src/pce_fast/vdc.cpp:514:6: style: The scope of the variable 'chip' can be reduced. [variableScope] mednafen/src/pce_fast/vdc.cpp:1629:59: style:inconclusive: Function 'VDC_SetSettings' argument 2 names different: declaration 'correct_aspect' definition 'arg_correct_aspect'. [funcArgNamesDifferent] mednafen/src/pce_fast/vdc.h:199:59: note: Function 'VDC_SetSettings' argument 2 names different: declaration 'correct_aspect' definition 'arg_correct_aspect'. mednafen/src/pce_fast/vdc.cpp:1629:59: note: Function 'VDC_SetSettings' argument 2 names different: declaration 'correct_aspect' definition 'arg_correct_aspect'. mednafen/src/pce_fast/vdc.cpp:1201:13: style: Variable 'vdc' is assigned a value that is never used. [unreadVariable] mednafen/src/psx/debug.cpp:141:3: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/psx/debug.cpp:168:99: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/psx/dis.cpp:287:17: style: Checking if unsigned expression 'immediate' is less than zero. [unsignedLessThanZero] mednafen/src/psx/frontio.cpp:275:10: warning: Member variable 'FrontIO::ReceivePending' is not initialized in the constructor. [uninitMemberVar] mednafen/src/psx/frontio.cpp:275:10: warning: Member variable 'FrontIO::TransmitPending' is not initialized in the constructor. [uninitMemberVar] mednafen/src/psx/frontio.cpp:275:10: warning: Member variable 'FrontIO::ReceiveInProgress' is not initialized in the constructor. [uninitMemberVar] mednafen/src/psx/frontio.cpp:275:10: warning: Member variable 'FrontIO::TransmitInProgress' is not initialized in the constructor. [uninitMemberVar] mednafen/src/psx/frontio.cpp:275:10: warning: Member variable 'FrontIO::ReceiveBufferAvail' is not initialized in the constructor. [uninitMemberVar] mednafen/src/psx/frontio.cpp:275:10: warning: Member variable 'FrontIO::istatus' is not initialized in the constructor. [uninitMemberVar] mednafen/src/psx/frontio.cpp:275:10: warning: Member variable 'FrontIO::amct_enabled' is not initialized in the constructor. [uninitMemberVar] mednafen/src/psx/frontio.h:96:20: style:inconclusive: Technically the member function 'MDFN_IEN_PSX::FrontIO::CalcNextEventTS' can be const. [functionConst] mednafen/src/psx/frontio.cpp:344:28: note: Technically the member function 'MDFN_IEN_PSX::FrontIO::CalcNextEventTS' can be const. mednafen/src/psx/frontio.h:96:20: note: Technically the member function 'MDFN_IEN_PSX::FrontIO::CalcNextEventTS' can be const. mednafen/src/psx/frontio.cpp:137:68: style:inconclusive: Function 'GPULineHook' argument 1 names different: declaration 'line_timestamp' definition 'timestamp'. [funcArgNamesDifferent] mednafen/src/psx/frontio.h:46:64: note: Function 'GPULineHook' argument 1 names different: declaration 'line_timestamp' definition 'timestamp'. mednafen/src/psx/frontio.cpp:137:68: note: Function 'GPULineHook' argument 1 names different: declaration 'line_timestamp' definition 'timestamp'. mednafen/src/psx/frontio.cpp:198:31: style: Parameter 'emulate_multitap' can be declared with const [constParameter] mednafen/src/psx/frontio.cpp:211:38: style: Parameter 'emulate_multitap' can be declared with const [constParameter] mednafen/src/psx/gpu.cpp:1120:68: style:inconclusive: Function 'GPU_Update' argument 1 names different: declaration 'timestamp' definition 'sys_timestamp'. [funcArgNamesDifferent] mednafen/src/psx/gpu.h:230:69: note: Function 'GPU_Update' argument 1 names different: declaration 'timestamp' definition 'sys_timestamp'. mednafen/src/psx/gpu.cpp:1120:68: note: Function 'GPU_Update' argument 1 names different: declaration 'timestamp' definition 'sys_timestamp'. mednafen/src/psx/gpu.cpp:1504:40: style:inconclusive: Function 'GPU_StartFrame' argument 1 names different: declaration 'espec' definition 'espec_arg'. [funcArgNamesDifferent] mednafen/src/psx/gpu.h:228:41: note: Function 'GPU_StartFrame' argument 1 names different: declaration 'espec' definition 'espec_arg'. mednafen/src/psx/gpu.cpp:1504:40: note: Function 'GPU_StartFrame' argument 1 names different: declaration 'espec' definition 'espec_arg'. mednafen/src/psx/gpu.cpp:1291:42: error: Shifting 32-bit value by 32 bits is undefined behaviour [shiftTooManyBits] mednafen/src/psx/gpu_line.cpp:246:2: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] mednafen/src/psx/gpu_line.cpp:246:4: style: Variable 'cb' is assigned a value that is never used. [unreadVariable] mednafen/src/psx/gpu_sprite.cpp:181:2: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] mednafen/src/psx/input/dualanalog.cpp:36:15: style: Virtual function 'Power' is called from constructor 'InputDevice_DualAnalog(bool joystick_mode_)' at line 68. Dynamic binding is not used. [virtualCallInConstructor] mednafen/src/psx/input/dualanalog.cpp:68:2: note: Calling Power mednafen/src/psx/input/dualanalog.cpp:36:15: note: Power is a virtual function mednafen/src/psx/input/dualanalog.cpp:33:2: style: Class 'InputDevice_DualAnalog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/psx/cpu.h:97:9: style:inconclusive: Technically the member function 'MDFN_IEN_PSX::PS_CPU::GetBIU' can be const. [functionConst] mednafen/src/psx/cpu.cpp:259:16: note: Technically the member function 'MDFN_IEN_PSX::PS_CPU::GetBIU' can be const. mednafen/src/psx/cpu.h:97:9: note: Technically the member function 'MDFN_IEN_PSX::PS_CPU::GetBIU' can be const. mednafen/src/psx/cpu.h:237:7: style:inconclusive: Technically the member function 'MDFN_IEN_PSX::PS_CPU::CheckBreakpoints' can be const. [functionConst] mednafen/src/psx/cpu.cpp:2638:14: note: Technically the member function 'MDFN_IEN_PSX::PS_CPU::CheckBreakpoints' can be const. mednafen/src/psx/cpu.h:237:7: note: Technically the member function 'MDFN_IEN_PSX::PS_CPU::CheckBreakpoints' can be const. mednafen/src/psx/cpu.h:261:9: style:inconclusive: Technically the member function 'MDFN_IEN_PSX::PS_CPU::GetRegister' can be const. [functionConst] mednafen/src/psx/cpu.cpp:2464:16: note: Technically the member function 'MDFN_IEN_PSX::PS_CPU::GetRegister' can be const. mednafen/src/psx/cpu.h:261:9: note: Technically the member function 'MDFN_IEN_PSX::PS_CPU::GetRegister' can be const. mednafen/src/psx/cpu.h:263:7: style:inconclusive: Technically the member function 'MDFN_IEN_PSX::PS_CPU::PeekCheckICache' can be const. [functionConst] mednafen/src/psx/cpu.cpp:2587:14: note: Technically the member function 'MDFN_IEN_PSX::PS_CPU::PeekCheckICache' can be const. mednafen/src/psx/cpu.h:263:7: note: Technically the member function 'MDFN_IEN_PSX::PS_CPU::PeekCheckICache' can be const. mednafen/src/psx/input/dualshock.cpp:130:24: warning: Member variable 'InputDevice_DualShock::cur_ana_button_state' is not initialized in the constructor. [uninitMemberVar] mednafen/src/psx/input/dualshock.cpp:66:15: style: Virtual function 'Power' is called from constructor 'InputDevice_DualShock()' at line 132. Dynamic binding is not used. [virtualCallInConstructor] mednafen/src/psx/input/dualshock.cpp:132:2: note: Calling Power mednafen/src/psx/input/dualshock.cpp:66:15: note: Power is a virtual function mednafen/src/psx/gte.cpp:1171:8: style: Variable 'IR_temp' can be declared with const [constVariable] mednafen/src/psx/cpu.cpp:1083:12: style: Variable 'LDWhich' is reassigned a value before the old one has been used. [redundantAssignment] mednafen/src/psx/cpu.cpp:1080:4: note: LDWhich is assigned mednafen/src/psx/cpu.cpp:1083:12: note: LDWhich is overwritten mednafen/src/psx/cpu.cpp:1212:11: style: Variable 'LDWhich' is reassigned a value before the old one has been used. [redundantAssignment] mednafen/src/psx/cpu.cpp:1202:3: note: LDWhich is assigned mednafen/src/psx/cpu.cpp:1212:11: note: LDWhich is overwritten mednafen/src/psx/cpu.cpp:1239:11: style: Variable 'LDWhich' is reassigned a value before the old one has been used. [redundantAssignment] mednafen/src/psx/cpu.cpp:1229:3: note: LDWhich is assigned mednafen/src/psx/cpu.cpp:1239:11: note: LDWhich is overwritten mednafen/src/psx/cpu.cpp:2069:10: style: Variable 'LDWhich' is reassigned a value before the old one has been used. [redundantAssignment] mednafen/src/psx/cpu.cpp:2067:2: note: LDWhich is assigned mednafen/src/psx/cpu.cpp:2069:10: note: LDWhich is overwritten mednafen/src/psx/cpu.cpp:2090:17: style: Variable 'LDWhich' is reassigned a value before the old one has been used. [redundantAssignment] mednafen/src/psx/cpu.cpp:2088:2: note: LDWhich is assigned mednafen/src/psx/cpu.cpp:2090:17: note: LDWhich is overwritten mednafen/src/psx/cpu.cpp:2120:11: style: Variable 'LDWhich' is reassigned a value before the old one has been used. [redundantAssignment] mednafen/src/psx/cpu.cpp:2118:3: note: LDWhich is assigned mednafen/src/psx/cpu.cpp:2120:11: note: LDWhich is overwritten mednafen/src/psx/cpu.cpp:2151:11: style: Variable 'LDWhich' is reassigned a value before the old one has been used. [redundantAssignment] mednafen/src/psx/cpu.cpp:2149:3: note: LDWhich is assigned mednafen/src/psx/cpu.cpp:2151:11: note: LDWhich is overwritten mednafen/src/psx/gte.cpp:353:61: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/psx/cpu.cpp:2183:11: style: Variable 'LDWhich' is reassigned a value before the old one has been used. [redundantAssignment] mednafen/src/psx/cpu.cpp:2181:3: note: LDWhich is assigned mednafen/src/psx/cpu.cpp:2183:11: note: LDWhich is overwritten mednafen/src/psx/gte.cpp:1686:14: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/psx/cpu.cpp:2280:10: style: Variable 'LDWhich' is reassigned a value before the old one has been used. [redundantAssignment] mednafen/src/psx/cpu.cpp:2277:3: note: LDWhich is assigned mednafen/src/psx/cpu.cpp:2280:10: note: LDWhich is overwritten mednafen/src/psx/gte.cpp:353:61: error: Signed integer overflow for expression '1<<31'. [integerOverflow] mednafen/src/psx/cpu.cpp:2352:10: style: Variable 'LDWhich' is reassigned a value before the old one has been used. [redundantAssignment] mednafen/src/psx/cpu.cpp:2349:3: note: LDWhich is assigned mednafen/src/psx/cpu.cpp:2352:10: note: LDWhich is overwritten mednafen/src/psx/gte.cpp:1686:14: error: Signed integer overflow for expression '1<<31'. [integerOverflow] mednafen/src/psx/cpu.cpp:2468:11: style: Unsigned expression 'which' can't be negative so it is unnecessary to test it. [unsignedPositive] mednafen/src/psx/cpu.cpp:2544:11: style: Unsigned expression 'which' can't be negative so it is unnecessary to test it. [unsignedPositive] mednafen/src/psx/input/gamepad.cpp:36:15: style: Virtual function 'Power' is called from constructor 'InputDevice_Gamepad()' at line 66. Dynamic binding is not used. [virtualCallInConstructor] mednafen/src/psx/input/gamepad.cpp:66:2: note: Calling Power mednafen/src/psx/input/gamepad.cpp:36:15: note: Power is a virtual function mednafen/src/psx/cpu.cpp:391:52: style: Parameter 'timestamp' can be declared with const [constParameter] mednafen/src/psx/input/guncon.cpp:36:15: style: Virtual function 'Power' is called from constructor 'InputDevice_GunCon(void)' at line 81. Dynamic binding is not used. [virtualCallInConstructor] mednafen/src/psx/input/guncon.cpp:81:2: note: Calling Power mednafen/src/psx/input/guncon.cpp:36:15: note: Power is a virtual function mednafen/src/psx/input/justifier.cpp:36:15: style: Virtual function 'Power' is called from constructor 'InputDevice_Justifier(void)' at line 82. Dynamic binding is not used. [virtualCallInConstructor] mednafen/src/psx/input/justifier.cpp:82:2: note: Calling Power mednafen/src/psx/input/justifier.cpp:36:15: note: Power is a virtual function mednafen/src/psx/cpu.cpp:2644:19: error: Signed integer overflow for expression '0x3F<<26'. [integerOverflow] mednafen/src/psx/cpu.cpp:673:21: error: Signed integer overflow for expression '0x3F<<26'. [integerOverflow] mednafen/src/psx/cpu.cpp:2283:33: error: Signed integer overflow for expression '0xFF<<24'. [integerOverflow] mednafen/src/psx/cpu.cpp:2286:35: error: Signed integer overflow for expression '0xFFFF<<16'. [integerOverflow] mednafen/src/psx/cpu.cpp:2289:37: error: Signed integer overflow for expression '0xFFFFFF<<8'. [integerOverflow] mednafen/src/pcfx/king.cpp:2718:10: style: The scope of the variable 'ble_cache_any' can be reduced. [variableScope] mednafen/src/pcfx/king.cpp:1472:28: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1473:28: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1474:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1491:28: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1492:28: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1510:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1516:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1548:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1550:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1552:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1553:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1554:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1555:16: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1557:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1558:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1559:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1560:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1561:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1562:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1564:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1565:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1566:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1567:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/psx/input/mouse.cpp:36:15: style: Virtual function 'Power' is called from constructor 'InputDevice_Mouse()' at line 74. Dynamic binding is not used. [virtualCallInConstructor] mednafen/src/psx/input/mouse.cpp:74:2: note: Calling Power mednafen/src/psx/input/mouse.cpp:36:15: note: Power is a virtual function mednafen/src/pcfx/king.cpp:1569:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1570:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1572:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1573:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1575:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1576:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1578:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1579:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1582:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1583:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1584:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1585:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1586:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1587:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1613:28: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1627:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1656:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1660:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1664:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1665:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1666:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1668:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1669:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:1670:14: error: Signed integer overflow for expression '0xFFFF<<(msh?0:16)'. [integerOverflow] mednafen/src/pcfx/king.cpp:2718:24: style: Variable 'ble_cache_any' is assigned a value that is never used. [unreadVariable] mednafen/src/pcfx/king.cpp:2741:21: style: Variable 'ble_cache_any' is assigned a value that is never used. [unreadVariable] mednafen/src/pcfx/king.cpp:2765:13: style: Variable 'target' is assigned a value that is never used. [unreadVariable] mednafen/src/pcfx/king.cpp:2767:13: style: Variable 'target' is assigned a value that is never used. [unreadVariable] mednafen/src/psx/input/memcard.cpp:38:15: style: Virtual function 'Power' is called from constructor 'InputDevice_Memcard()' at line 123. Dynamic binding is not used. [virtualCallInConstructor] mednafen/src/psx/input/memcard.cpp:123:2: note: Calling Power mednafen/src/psx/input/memcard.cpp:38:15: note: Power is a virtual function mednafen/src/psx/irq.cpp:36:33: style:inconclusive: Function 'IRQ_Assert' argument 2 names different: declaration 'asserted' definition 'status'. [funcArgNamesDifferent] mednafen/src/psx/irq.h:44:33: note: Function 'IRQ_Assert' argument 2 names different: declaration 'asserted' definition 'status'. mednafen/src/psx/irq.cpp:36:33: note: Function 'IRQ_Assert' argument 2 names different: declaration 'asserted' definition 'status'. mednafen/src/psx/input/negcon.cpp:36:15: style: Virtual function 'Power' is called from constructor 'InputDevice_neGcon(void)' at line 68. Dynamic binding is not used. [virtualCallInConstructor] mednafen/src/psx/input/negcon.cpp:68:2: note: Calling Power mednafen/src/psx/input/negcon.cpp:36:15: note: Power is a virtual function mednafen/src/psx/notes/tristep.cpp:25:26: portability: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS] mednafen/src/psx/mdec.cpp:330:41: style: Parameter 'in_coeff' can be declared with const [constParameter] mednafen/src/psx/input/multitap.h:34:15: style: Virtual function 'Power' is called from constructor 'InputDevice_Multitap()' at line 106. Dynamic binding is not used. [virtualCallInConstructor] mednafen/src/psx/input/multitap.cpp:106:2: note: Calling Power mednafen/src/psx/input/multitap.h:34:15: note: Power is a virtual function mednafen/src/qtrecord.cpp:190:11: warning: Member variable 'QTRecord::OnAudioTrack' is not initialized in the constructor. [uninitMemberVar] mednafen/src/qtrecord.cpp:194:2: performance: Variable 'SoundFramesWritten' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/qtrecord.cpp:196:2: performance: Variable 'SoundRate' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/qtrecord.cpp:197:2: performance: Variable 'SoundChan' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/qtrecord.cpp:190:62: style:inconclusive: Function 'QTRecord' argument 2 names different: declaration 'spec_arg' definition 'spec'. [funcArgNamesDifferent] mednafen/src/qtrecord.h:58:53: note: Function 'QTRecord' argument 2 names different: declaration 'spec_arg' definition 'spec'. mednafen/src/qtrecord.cpp:190:62: note: Function 'QTRecord' argument 2 names different: declaration 'spec_arg' definition 'spec'. mednafen/src/quicklz/quicklz.c:160:10: warning: Redundant assignment of 'invalid' to itself. [selfAssignment] mednafen/src/quicklz/quicklz.c:180:15: warning: Redundant assignment of 'hash_counter' to itself. [selfAssignment] mednafen/src/quicklz/quicklz.c:181:14: warning: Redundant assignment of 'first_valid' to itself. [selfAssignment] mednafen/src/quicklz/quicklz.c:521:14: warning: Redundant assignment of 'first_valid' to itself. [selfAssignment] mednafen/src/quicklz/quicklz.c:522:14: warning: Redundant assignment of 'last_hashed' to itself. [selfAssignment] mednafen/src/quicklz/quicklz.c:523:12: warning: Redundant assignment of 'hashtable' to itself. [selfAssignment] mednafen/src/quicklz/quicklz.c:797:29: style: Unsigned expression '*buffersize+size-1' can't be negative so it is unnecessary to test it. [unsignedPositive] mednafen/src/quicklz/quicklz.c:870:62: style: Unsigned expression '*buffersize+qlz_size_decompressed((char*)source)-1' can't be negative so it is unnecessary to test it. [unsignedPositive] mednafen/src/quicklz/quicklz.c:380:19: style: Local variable 'offset' shadows outer variable [shadowVariable] mednafen/src/quicklz/quicklz.c:319:18: note: Shadowed declaration mednafen/src/quicklz/quicklz.c:380:19: note: Shadow variable mednafen/src/quicklz/quicklz.c:255:38: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/quicklz/quicklz.c:255:38: error: Signed integer overflow for expression '1<<31'. [integerOverflow] mednafen/src/quicklz/quicklz.c:160:10: style: Variable 'invalid' is assigned a value that is never used. [unreadVariable] mednafen/src/quicklz/quicklz.c:180:15: style: Variable 'hash_counter' is assigned a value that is never used. [unreadVariable] mednafen/src/quicklz/quicklz.c:181:14: style: Variable 'first_valid' is assigned a value that is never used. [unreadVariable] mednafen/src/quicklz/quicklz.c:521:14: style: Variable 'first_valid' is assigned a value that is never used. [unreadVariable] mednafen/src/resampler/resample.c:700:18: style: Redundant initialization for 'olen'. The initialized value is overwritten before it is read. [redundantInitialization] mednafen/src/resampler/resample.c:694:28: note: olen is initialized mednafen/src/resampler/resample.c:700:18: note: olen is overwritten mednafen/src/resampler/resample.c:371:27: style: Local variable 'sinc' shadows outer function [shadowFunction] mednafen/src/resampler/resample.c:312:21: note: Shadowed declaration mednafen/src/resampler/resample.c:371:27: note: Shadow variable mednafen/src/resampler/resample.c:422:27: style: Local variable 'sinc' shadows outer function [shadowFunction] mednafen/src/resampler/resample.c:312:21: note: Shadowed declaration mednafen/src/resampler/resample.c:422:27: note: Shadow variable mednafen/src/sexyal/convert.cpp:335:4: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] mednafen/src/psx/psx.cpp:1955:2: performance: Variable 'tags' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/psx/psx.cpp:994:8: style: Condition 'A>=0x1F801000' is always true [knownConditionTrueFalse] mednafen/src/psx/psx.cpp:992:7: note: Assuming that condition 'A>=0x1F801000' is not redundant mednafen/src/psx/psx.cpp:994:8: note: Condition 'A>=0x1F801000' is always true mednafen/src/psx/psx.cpp:884:8: style: Condition 'A>=0x1F801000' is always true [knownConditionTrueFalse] mednafen/src/psx/psx.cpp:856:7: note: Assuming that condition 'A>=0x1F801000' is not redundant mednafen/src/psx/psx.cpp:884:8: note: Condition 'A>=0x1F801000' is always true mednafen/src/psx/psx.cpp:1856:5: style: Variable 'po' is reassigned a value before the old one has been used. [redundantAssignment] mednafen/src/psx/psx.cpp:1854:5: note: po is assigned mednafen/src/psx/psx.cpp:1856:5: note: po is overwritten mednafen/src/psx/psx.cpp:1897:25: error: Signed integer overflow for expression '0x24<<26'. [integerOverflow] mednafen/src/psx/psx.cpp:1903:25: error: Signed integer overflow for expression '0x28<<26'. [integerOverflow] mednafen/src/psx/psx.cpp:170:14: style: struct member 'Anonymous29::version' is never used. [unusedStructMember] mednafen/src/psx/psx.cpp:171:7: style: struct member 'Anonymous29::hwrev' is never used. [unusedStructMember] mednafen/src/sexyal/drivers/dsound.cpp:93:10: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/dsound.cpp:224:23: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/dsound.cpp:289:23: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/dsound.cpp:374:25: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/es1370.cpp:113:13: style: Condition 'counter>1' is always false [knownConditionTrueFalse] mednafen/src/sexyal/drivers/es1370.cpp:105:21: note: Assignment 'counter=0', assigned value is 0 mednafen/src/sexyal/drivers/es1370.cpp:113:13: note: Condition 'counter>1' is always false mednafen/src/sexyal/drivers/es1370.cpp:114:3: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] mednafen/src/sexyal/drivers/es1370.cpp:232:23: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/sexyal/drivers/es1370.cpp:392:22: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/sexyal/drivers/es1370.cpp:417:22: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/sexyal/drivers/es1370.cpp:232:23: error: Signed integer overflow for expression '1<<31'. [integerOverflow] mednafen/src/sexyal/drivers/es1370.cpp:392:22: error: Signed integer overflow for expression '1<<31'. [integerOverflow] mednafen/src/sexyal/drivers/es1370.cpp:417:22: error: Signed integer overflow for expression '1<<31'. [integerOverflow] mednafen/src/sexyal/drivers/alsa.cpp:51:18: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/alsa.cpp:54:17: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/alsa.cpp:61:16: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/alsa.cpp:68:21: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/alsa.cpp:115:21: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/alsa.cpp:194:23: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/alsa.cpp:471:8: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/jack.cpp:270:4: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled] mednafen/src/sexyal/drivers/es1371.cpp:145:13: style: Condition 'counter>1' is always false [knownConditionTrueFalse] mednafen/src/sexyal/drivers/es1371.cpp:137:21: note: Assignment 'counter=0', assigned value is 0 mednafen/src/sexyal/drivers/es1371.cpp:145:13: note: Condition 'counter>1' is always false mednafen/src/sexyal/drivers/jack.cpp:277:3: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled] mednafen/src/sexyal/drivers/es1371.cpp:146:3: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] mednafen/src/sexyal/drivers/es1371.cpp:494:22: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/sexyal/drivers/es1371.cpp:494:22: error: Signed integer overflow for expression '1<<31'. [integerOverflow] mednafen/src/sexyal/drivers/es1371.cpp:337:17: style: Variable 'cur_pciid' is assigned a value that is never used. [unreadVariable] mednafen/src/sexyal/drivers/jack.cpp:67:20: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/jack.cpp:105:20: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/jack.cpp:160:20: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/jack.cpp:231:20: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/jack.cpp:299:22: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/jack.cpp:331:20: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/jack.cpp:354:7: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/openbsd.cpp:51:24: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/openbsd.cpp:74:24: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/openbsd.cpp:96:24: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/openbsd.cpp:127:26: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/openbsd.cpp:243:8: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/oss.cpp:59:3: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] mednafen/src/sexyal/drivers/oss.cpp:80:21: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/oss.cpp:109:21: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/oss.cpp:147:21: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/oss.cpp:159:23: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/oss.cpp:354:14: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/oss.cpp:55:12: style: Variable 'tmp' is assigned a value that is never used. [unreadVariable] mednafen/src/sexyal/drivers/sdl.cpp:75:19: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/sdl.cpp:134:19: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/sdl.cpp:186:19: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/sdl.cpp:243:19: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/sdl.cpp:253:19: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/sdl.cpp:270:21: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/sdl.cpp:345:7: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/wasapi.cpp:240:2: error: Memory leak: dev [memleak] mednafen/src/sexyal/drivers/wasapi.cpp:244:3: error: Memory leak: dev [memleak] mednafen/src/sexyal/drivers/wasapi.cpp:256:3: error: Memory leak: dev [memleak] mednafen/src/sexyal/drivers/wasapi.cpp:257:3: error: Memory leak: dev [memleak] mednafen/src/sexyal/drivers/wasapi.cpp:309:2: error: Memory leak: dev [memleak] mednafen/src/sexyal/drivers/wasapi.cpp:93:21: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/wasapi.cpp:229:6: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/wasapi.cpp:475:21: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/wasapi.cpp:487:21: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/wasapi.cpp:545:23: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/wasapi.cpp:106:3: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] mednafen/src/sexyal/drivers/wasapi.cpp:115:3: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] mednafen/src/sexyal/drivers/sb.cpp:315:20: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/sb.cpp:346:20: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/sb.cpp:374:20: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/sb.cpp:385:20: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/sb.cpp:401:20: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/sb.cpp:441:20: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/sb.cpp:522:20: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/sb.cpp:689:12: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/wasapish.cpp:81:23: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/wasapish.cpp:127:25: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/wasapish.cpp:210:6: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/wasapish.cpp:453:23: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/wasapish.cpp:489:23: style: C-style pointer casting [cstyleCast] mednafen/src/sexyal/drivers/wasapish.cpp:498:23: style: C-style pointer casting [cstyleCast] mednafen/src/psx/spu.cpp:268:64: style:inconclusive: Boolean expression 'dec_mode' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/psx/spu.cpp:269:38: style:inconclusive: Boolean expression 'inv_mode' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/psx/spu.cpp:269:51: style:inconclusive: Boolean expression 'dec_mode' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/psx/spu.cpp:277:16: style:inconclusive: Boolean expression 'dec_mode' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/psx/spu.cpp:277:29: style:inconclusive: Boolean expression 'inv_mode' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/psx/spu.cpp:96:2: performance: Variable 'last_quality' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/psx/spu.cpp:98:2: performance: Variable 'IntermediateBufferPos' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/psx/spu.h:70:8: style:inconclusive: Technically the member function 'MDFN_IEN_PSX::SPU_Sweep::ReadVolume' can be const. [functionConst] mednafen/src/psx/spu.cpp:250:25: note: Technically the member function 'MDFN_IEN_PSX::SPU_Sweep::ReadVolume' can be const. mednafen/src/psx/spu.h:70:8: note: Technically the member function 'MDFN_IEN_PSX::SPU_Sweep::ReadVolume' can be const. mednafen/src/psx/spu.h:148:7: performance:inconclusive: Technically the member function 'MDFN_IEN_PSX::PS_SPU::CacheEnvelope' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/psx/spu.cpp:457:14: note: Technically the member function 'MDFN_IEN_PSX::PS_SPU::CacheEnvelope' can be static (but you may consider moving to unnamed namespace). mednafen/src/psx/spu.h:148:7: note: Technically the member function 'MDFN_IEN_PSX::PS_SPU::CacheEnvelope' can be static (but you may consider moving to unnamed namespace). mednafen/src/psx/spu.h:149:7: performance:inconclusive: Technically the member function 'MDFN_IEN_PSX::PS_SPU::ResetEnvelope' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/psx/spu.cpp:484:21: note: Technically the member function 'MDFN_IEN_PSX::PS_SPU::ResetEnvelope' can be static (but you may consider moving to unnamed namespace). mednafen/src/psx/spu.h:149:7: note: Technically the member function 'MDFN_IEN_PSX::PS_SPU::ResetEnvelope' can be static (but you may consider moving to unnamed namespace). mednafen/src/psx/spu.h:150:7: performance:inconclusive: Technically the member function 'MDFN_IEN_PSX::PS_SPU::ReleaseEnvelope' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/psx/spu.cpp:493:21: note: Technically the member function 'MDFN_IEN_PSX::PS_SPU::ReleaseEnvelope' can be static (but you may consider moving to unnamed namespace). mednafen/src/psx/spu.h:150:7: note: Technically the member function 'MDFN_IEN_PSX::PS_SPU::ReleaseEnvelope' can be static (but you may consider moving to unnamed namespace). mednafen/src/psx/spu.h:151:7: performance:inconclusive: Technically the member function 'MDFN_IEN_PSX::PS_SPU::RunEnvelope' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/psx/spu.cpp:502:21: note: Technically the member function 'MDFN_IEN_PSX::PS_SPU::RunEnvelope' can be static (but you may consider moving to unnamed namespace). mednafen/src/psx/spu.h:151:7: note: Technically the member function 'MDFN_IEN_PSX::PS_SPU::RunEnvelope' can be static (but you may consider moving to unnamed namespace). mednafen/src/psx/spu.h:348:9: style:inconclusive: Technically the member function 'MDFN_IEN_PSX::PS_SPU::PeekSPURAM' can be const. [functionConst] mednafen/src/psx/spu.cpp:1433:16: note: Technically the member function 'MDFN_IEN_PSX::PS_SPU::PeekSPURAM' can be const. mednafen/src/psx/spu.h:348:9: note: Technically the member function 'MDFN_IEN_PSX::PS_SPU::PeekSPURAM' can be const. mednafen/src/psx/spu.cpp:269:38: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] mednafen/src/psx/spu.cpp:277:16: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] mednafen/src/psx/spu.cpp:473:37: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/psx/spu.cpp:473:37: error: Signed integer overflow for expression '1<<31'. [integerOverflow] mednafen/src/sms/vdp.cpp:92:9: style: The scope of the variable 'i' can be reduced. [variableScope] mednafen/src/sms/vdp.cpp:539:9: style: The scope of the variable 'iline' can be reduced. [variableScope] mednafen/src/sms/render.cpp:298:16: style: The scope of the variable 'c' can be reduced. [variableScope] mednafen/src/sms/tms.cpp:253:13: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] mednafen/src/sms/tms.cpp:258:13: note: Found duplicate branches for 'if' and 'else'. mednafen/src/sms/tms.cpp:253:13: note: Found duplicate branches for 'if' and 'else'. mednafen/src/sms/tms.cpp:112:12: style: The scope of the variable 'lb' can be reduced. [variableScope] mednafen/src/sms/tms.cpp:113:17: style: The scope of the variable 'p' can be reduced. [variableScope] mednafen/src/sms/tms.cpp:375:9: style: The scope of the variable 'name' can be reduced. [variableScope] mednafen/src/sms/tms.cpp:377:12: style: The scope of the variable 'clut' can be reduced. [variableScope] mednafen/src/sms/tms.cpp:378:12: style: The scope of the variable 'bpex' can be reduced. [variableScope] mednafen/src/sms/tms.cpp:400:12: style: The scope of the variable 'bpex' can be reduced. [variableScope] mednafen/src/sms/tms.cpp:431:12: style: The scope of the variable 'bpex' can be reduced. [variableScope] mednafen/src/sms/tms.cpp:452:12: style: The scope of the variable 'bpex' can be reduced. [variableScope] mednafen/src/sms/tms.cpp:469:12: style: The scope of the variable 'mcex' can be reduced. [variableScope] mednafen/src/sms/tms.cpp:486:12: style: The scope of the variable 'mcex' can be reduced. [variableScope] mednafen/src/sms/tms.cpp:503:9: style: The scope of the variable 'name' can be reduced. [variableScope] mednafen/src/sms/tms.cpp:505:12: style: The scope of the variable 'clut' can be reduced. [variableScope] mednafen/src/sms/tms.cpp:506:12: style: The scope of the variable 'bpex' can be reduced. [variableScope] mednafen/src/snes/src/chip/bsx/bsx_base.cpp:39:17: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] mednafen/src/snes/src/ppu/ppu.hpp:17:1: style: The class 'PPUcounter' does not have a constructor although it has private member variables. [noConstructor] mednafen/src/snes/src/smp/smp.hpp:8:3: warning: Member variable 'SMP::dp' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes/src/smp/smp.hpp:8:3: warning: Member variable 'SMP::sp' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes/src/smp/smp.hpp:8:3: warning: Member variable 'SMP::rd' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes/src/smp/smp.hpp:8:3: warning: Member variable 'SMP::wr' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes/src/smp/smp.hpp:8:3: warning: Member variable 'SMP::bit' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes/src/smp/smp.hpp:8:3: warning: Member variable 'SMP::ya' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes/src/smp/smp.hpp:8:3: warning: Member variable 'SMP::t0' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes/src/smp/smp.hpp:8:3: warning: Member variable 'SMP::t1' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes/src/smp/smp.hpp:8:3: warning: Member variable 'SMP::t2' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes/src/smp/smp.hpp:8:3: warning: Member variable 'SMP::status' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes/src/smp/core/registers.hpp:43:3: warning: Member variable 'regs_t::pc' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes/src/smp/core/registers.hpp:43:3: warning: Member variable 'regs_t::r' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes/src/system/video/video.hpp:1:1: style: The class 'Video' does not have a constructor although it has private member variables. [noConstructor] mednafen/src/snes/src/system/audio/audio.hpp:1:1: style: The class 'Audio' does not have a constructor although it has private member variables. [noConstructor] mednafen/src/snes/src/chip/superfx/superfx.hpp:3:1: style: The class 'SuperFX' does not have a constructor although it has private member variables. [noConstructor] mednafen/src/snes/src/chip/bsx/bsx.hpp:1:1: style: The class 'BSXBase' does not have a constructor although it has private member variables. [noConstructor] mednafen/src/snes/src/chip/bsx/bsx.hpp:46:1: style: The class 'BSXFlash' does not have a constructor although it has private member variables. [noConstructor] mednafen/src/snes/src/chip/sdd1/sdd1emu.hpp:36:3: warning: Member variable 'SDD1_IM::byte_ptr' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes/src/chip/sdd1/sdd1emu.hpp:36:3: warning: Member variable 'SDD1_IM::bit_count' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes/src/chip/cx4/cx4.hpp:1:1: style: The class 'Cx4' does not have a constructor although it has private member variables. [noConstructor] mednafen/src/snes/src/chip/st010/st010.hpp:1:1: style: The class 'ST010' does not have a constructor although it has private member variables. [noConstructor] mednafen/src/snes/src/memory/memory.hpp:27:16: style:inconclusive: Technically the member function 'bSNES_v059::StaticRAM::read' can be const. [functionConst] mednafen/src/snes/src/memory/memory-inline.hpp:10:18: note: Technically the member function 'bSNES_v059::StaticRAM::read' can be const. mednafen/src/snes/src/memory/memory.hpp:27:16: note: Technically the member function 'bSNES_v059::StaticRAM::read' can be const. mednafen/src/snes/src/memory/memory.hpp:49:16: style:inconclusive: Technically the member function 'bSNES_v059::MappedRAM::read' can be const. [functionConst] mednafen/src/snes/src/memory/memory-inline.hpp:47:18: note: Technically the member function 'bSNES_v059::MappedRAM::read' can be const. mednafen/src/snes/src/memory/memory.hpp:49:16: note: Technically the member function 'bSNES_v059::MappedRAM::read' can be const. mednafen/src/snes/src/system/input/input.hpp:49:21: style:inconclusive: Technically the member function 'bSNES_v059::Input::tick' can be const. [functionConst] mednafen/src/snes/src/memory/memory-inline.hpp:15:47: warning: Struct 'StaticRAM' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] mednafen/src/snes/src/memory/memory-inline.hpp:15:47: warning: Struct 'StaticRAM' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] mednafen/src/snes/src/memory/memory.hpp:32:10: style: Struct 'StaticRAM' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/snes/src/chip/sdd1/sdd1emu.hpp:52:3: style: Class 'SDD1_GCD' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/snes/src/chip/sdd1/sdd1emu.hpp:112:3: style: Class 'SDD1_CM' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/snes/src/chip/sdd1/sdd1emu.hpp:132:3: style: Class 'SDD1_OL' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/snes/src/memory/memory.hpp:13:12: style: The function 'size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:2:27: note: Virtual function in base class mednafen/src/snes/src/memory/memory.hpp:13:12: note: Function in derived class mednafen/src/snes/src/memory/memory.hpp:14:9: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:3:17: note: Virtual function in base class mednafen/src/snes/src/memory/memory.hpp:14:9: note: Function in derived class mednafen/src/snes/src/memory/memory.hpp:15:8: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:4:16: note: Virtual function in base class mednafen/src/snes/src/memory/memory.hpp:15:8: note: Function in derived class mednafen/src/snes/src/memory/memory.hpp:25:19: style: The function 'size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:2:27: note: Virtual function in base class mednafen/src/snes/src/memory/memory.hpp:25:19: note: Function in derived class mednafen/src/snes/src/memory/memory.hpp:28:15: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:4:16: note: Virtual function in base class mednafen/src/snes/src/memory/memory.hpp:28:15: note: Function in derived class mednafen/src/snes/src/memory/memory.hpp:47:19: style: The function 'size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:2:27: note: Virtual function in base class mednafen/src/snes/src/memory/memory.hpp:47:19: note: Function in derived class mednafen/src/snes/src/memory/memory.hpp:50:15: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:4:16: note: Virtual function in base class mednafen/src/snes/src/memory/memory.hpp:50:15: note: Function in derived class mednafen/src/snes/src/memory/memory.hpp:62:9: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:3:17: note: Virtual function in base class mednafen/src/snes/src/memory/memory.hpp:62:9: note: Function in derived class mednafen/src/snes/src/memory/memory.hpp:63:8: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:4:16: note: Virtual function in base class mednafen/src/snes/src/memory/memory.hpp:63:8: note: Function in derived class mednafen/src/snes/src/memory/smemory/smemory.hpp:3:8: style: The function 'load_cart' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:80:23: note: Virtual function in base class mednafen/src/snes/src/memory/smemory/smemory.hpp:3:8: note: Function in derived class mednafen/src/snes/src/memory/smemory/smemory.hpp:4:8: style: The function 'unload_cart' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:81:23: note: Virtual function in base class mednafen/src/snes/src/memory/smemory/smemory.hpp:4:8: note: Function in derived class mednafen/src/snes/src/memory/smemory/smemory.hpp:6:8: style: The function 'power' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:83:23: note: Virtual function in base class mednafen/src/snes/src/memory/smemory/smemory.hpp:6:8: note: Function in derived class mednafen/src/snes/src/memory/smemory/smemory.hpp:7:8: style: The function 'reset' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:84:23: note: Virtual function in base class mednafen/src/snes/src/memory/smemory/smemory.hpp:7:8: note: Function in derived class mednafen/src/snes/src/memory/smemory/smemory.hpp:24:8: style: The function 'serialize' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:91:16: note: Virtual function in base class mednafen/src/snes/src/memory/smemory/smemory.hpp:24:8: note: Function in derived class mednafen/src/snes/src/cpu/scpu/scpu.hpp:3:8: style: The function 'enter' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/cpu/cpu.hpp:7:16: note: Virtual function in base class mednafen/src/snes/src/cpu/scpu/scpu.hpp:3:8: note: Function in derived class mednafen/src/snes/src/cpu/scpu/scpu.hpp:5:8: style: The function 'interrupt_pending' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/cpu/core/core.hpp:16:16: note: Virtual function in base class mednafen/src/snes/src/cpu/scpu/scpu.hpp:5:8: note: Function in derived class mednafen/src/snes/src/cpu/scpu/memory/memory.hpp:6:7: style: The function 'port_read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/cpu/cpu.hpp:17:17: note: Virtual function in base class mednafen/src/snes/src/cpu/scpu/memory/memory.hpp:6:7: note: Function in derived class mednafen/src/snes/src/cpu/scpu/memory/memory.hpp:7:6: style: The function 'port_write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/cpu/cpu.hpp:18:16: note: Virtual function in base class mednafen/src/snes/src/cpu/scpu/memory/memory.hpp:7:6: note: Function in derived class mednafen/src/snes/src/cpu/scpu/memory/memory.hpp:13:6: style: The function 'op_io' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/cpu/core/core.hpp:12:16: note: Virtual function in base class mednafen/src/snes/src/cpu/scpu/memory/memory.hpp:13:6: note: Function in derived class mednafen/src/snes/src/cpu/scpu/memory/memory.hpp:14:20: style: The function 'op_read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/cpu/core/core.hpp:13:19: note: Virtual function in base class mednafen/src/snes/src/cpu/scpu/memory/memory.hpp:14:20: note: Function in derived class mednafen/src/snes/src/cpu/scpu/memory/memory.hpp:15:19: style: The function 'op_write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/cpu/core/core.hpp:14:16: note: Virtual function in base class mednafen/src/snes/src/cpu/scpu/memory/memory.hpp:15:19: note: Function in derived class mednafen/src/snes/src/cpu/scpu/mmio/mmio.hpp:6:9: style: The function 'pio' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/cpu/cpu.hpp:15:17: note: Virtual function in base class mednafen/src/snes/src/cpu/scpu/mmio/mmio.hpp:6:9: note: Function in derived class mednafen/src/snes/src/cpu/scpu/mmio/mmio.hpp:7:8: style: The function 'joylatch' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/cpu/cpu.hpp:16:16: note: Virtual function in base class mednafen/src/snes/src/cpu/scpu/mmio/mmio.hpp:7:8: note: Function in derived class mednafen/src/snes/src/cpu/scpu/timing/timing.hpp:19:8: style: The function 'scanline' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/cpu/cpu.hpp:20:16: note: Virtual function in base class mednafen/src/snes/src/cpu/scpu/timing/timing.hpp:19:8: note: Function in derived class mednafen/src/snes/src/cpu/scpu/timing/timing.hpp:22:21: style: The function 'last_cycle' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/cpu/core/core.hpp:15:16: note: Virtual function in base class mednafen/src/snes/src/cpu/scpu/timing/timing.hpp:22:21: note: Function in derived class mednafen/src/snes/src/cpu/scpu/scpu.hpp:90:8: style: The function 'power' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/cpu/cpu.hpp:21:16: note: Virtual function in base class mednafen/src/snes/src/cpu/scpu/scpu.hpp:90:8: note: Function in derived class mednafen/src/snes/src/cpu/scpu/scpu.hpp:91:8: style: The function 'reset' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/cpu/cpu.hpp:22:16: note: Virtual function in base class mednafen/src/snes/src/cpu/scpu/scpu.hpp:91:8: note: Function in derived class mednafen/src/snes/src/cpu/scpu/scpu.hpp:93:8: style: The function 'serialize' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/cpu/cpu.hpp:24:16: note: Virtual function in base class mednafen/src/snes/src/cpu/scpu/scpu.hpp:93:8: note: Function in derived class mednafen/src/snes/src/chip/superfx/bus/bus.hpp:14:12: style: The function 'size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:2:27: note: Virtual function in base class mednafen/src/snes/src/chip/superfx/bus/bus.hpp:14:12: note: Function in derived class mednafen/src/snes/src/chip/superfx/bus/bus.hpp:15:9: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:3:17: note: Virtual function in base class mednafen/src/snes/src/chip/superfx/bus/bus.hpp:15:9: note: Function in derived class mednafen/src/snes/src/chip/superfx/bus/bus.hpp:16:8: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:4:16: note: Virtual function in base class mednafen/src/snes/src/chip/superfx/bus/bus.hpp:16:8: note: Function in derived class mednafen/src/snes/src/chip/superfx/bus/bus.hpp:20:12: style: The function 'size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:2:27: note: Virtual function in base class mednafen/src/snes/src/chip/superfx/bus/bus.hpp:20:12: note: Function in derived class mednafen/src/snes/src/chip/superfx/bus/bus.hpp:21:9: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:3:17: note: Virtual function in base class mednafen/src/snes/src/chip/superfx/bus/bus.hpp:21:9: note: Function in derived class mednafen/src/snes/src/chip/superfx/bus/bus.hpp:22:8: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:4:16: note: Virtual function in base class mednafen/src/snes/src/chip/superfx/bus/bus.hpp:22:8: note: Function in derived class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:10:22: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:3:17: note: Virtual function in base class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:10:22: note: Function in derived class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:11:21: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:4:16: note: Virtual function in base class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:11:21: note: Function in derived class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:17:12: style: The function 'size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:2:27: note: Virtual function in base class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:17:12: note: Function in derived class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:18:22: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:3:17: note: Virtual function in base class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:18:22: note: Function in derived class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:19:21: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:4:16: note: Virtual function in base class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:19:21: note: Function in derived class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:23:12: style: The function 'size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:2:27: note: Virtual function in base class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:23:12: note: Function in derived class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:24:22: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:3:17: note: Virtual function in base class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:24:22: note: Function in derived class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:25:21: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:4:16: note: Virtual function in base class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:25:21: note: Function in derived class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:29:12: style: The function 'size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:2:27: note: Virtual function in base class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:29:12: note: Function in derived class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:30:22: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:3:17: note: Virtual function in base class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:30:22: note: Function in derived class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:31:21: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:4:16: note: Virtual function in base class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:31:21: note: Function in derived class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:35:12: style: The function 'size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:2:27: note: Virtual function in base class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:35:12: note: Function in derived class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:36:22: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:3:17: note: Virtual function in base class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:36:22: note: Function in derived class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:37:21: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:4:16: note: Virtual function in base class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:37:21: note: Function in derived class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:42:12: style: The function 'size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:2:27: note: Virtual function in base class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:42:12: note: Function in derived class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:43:22: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:3:17: note: Virtual function in base class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:43:22: note: Function in derived class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:44:21: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:4:16: note: Virtual function in base class mednafen/src/snes/src/chip/sa1/bus/bus.hpp:44:21: note: Function in derived class mednafen/src/snes/src/chip/sa1/memory/memory.hpp:1:19: style: The function 'op_io' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/cpu/core/core.hpp:12:16: note: Virtual function in base class mednafen/src/snes/src/chip/sa1/memory/memory.hpp:1:19: note: Function in derived class mednafen/src/snes/src/chip/sa1/sa1.hpp:25:21: style: The function 'last_cycle' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/cpu/core/core.hpp:15:16: note: Virtual function in base class mednafen/src/snes/src/chip/sa1/sa1.hpp:25:21: note: Function in derived class mednafen/src/snes/src/chip/sa1/sa1.hpp:26:21: style: The function 'interrupt_pending' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/cpu/core/core.hpp:16:16: note: Virtual function in base class mednafen/src/snes/src/chip/sa1/sa1.hpp:26:21: note: Function in derived class mednafen/src/snes/src/chip/bsx/bsx.hpp:53:12: style: The function 'size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:2:27: note: Virtual function in base class mednafen/src/snes/src/chip/bsx/bsx.hpp:53:12: note: Function in derived class mednafen/src/snes/src/chip/bsx/bsx.hpp:54:9: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:3:17: note: Virtual function in base class mednafen/src/snes/src/chip/bsx/bsx.hpp:54:9: note: Function in derived class mednafen/src/snes/src/chip/bsx/bsx.hpp:55:8: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:4:16: note: Virtual function in base class mednafen/src/snes/src/chip/bsx/bsx.hpp:55:8: note: Function in derived class mednafen/src/snes/src/chip/sdd1/sdd1.hpp:13:9: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:3:17: note: Virtual function in base class mednafen/src/snes/src/chip/sdd1/sdd1.hpp:13:9: note: Function in derived class mednafen/src/snes/src/chip/sdd1/sdd1.hpp:14:8: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:4:16: note: Virtual function in base class mednafen/src/snes/src/chip/sdd1/sdd1.hpp:14:8: note: Function in derived class mednafen/src/snes/src/chip/spc7110/spc7110.hpp:41:9: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:3:17: note: Virtual function in base class mednafen/src/snes/src/chip/spc7110/spc7110.hpp:41:9: note: Function in derived class mednafen/src/snes/src/chip/spc7110/spc7110.hpp:42:8: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:4:16: note: Virtual function in base class mednafen/src/snes/src/chip/spc7110/spc7110.hpp:42:8: note: Function in derived class mednafen/src/snes/src/chip/cx4/cx4.hpp:8:9: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:3:17: note: Virtual function in base class mednafen/src/snes/src/chip/cx4/cx4.hpp:8:9: note: Function in derived class mednafen/src/snes/src/chip/cx4/cx4.hpp:9:8: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:4:16: note: Virtual function in base class mednafen/src/snes/src/chip/cx4/cx4.hpp:9:8: note: Function in derived class mednafen/src/snes/src/chip/dsp1/dsp1.hpp:10:9: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:3:17: note: Virtual function in base class mednafen/src/snes/src/chip/dsp1/dsp1.hpp:10:9: note: Function in derived class mednafen/src/snes/src/chip/dsp1/dsp1.hpp:11:8: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:4:16: note: Virtual function in base class mednafen/src/snes/src/chip/dsp1/dsp1.hpp:11:8: note: Function in derived class mednafen/src/snes/src/chip/dsp2/dsp2.hpp:29:9: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:3:17: note: Virtual function in base class mednafen/src/snes/src/chip/dsp2/dsp2.hpp:29:9: note: Function in derived class mednafen/src/snes/src/chip/dsp2/dsp2.hpp:30:8: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:4:16: note: Virtual function in base class mednafen/src/snes/src/chip/dsp2/dsp2.hpp:30:8: note: Function in derived class mednafen/src/snes/src/chip/dsp3/dsp3.hpp:8:9: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:3:17: note: Virtual function in base class mednafen/src/snes/src/chip/dsp3/dsp3.hpp:8:9: note: Function in derived class mednafen/src/snes/src/chip/dsp3/dsp3.hpp:9:9: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:4:16: note: Virtual function in base class mednafen/src/snes/src/chip/dsp3/dsp3.hpp:9:9: note: Function in derived class mednafen/src/snes/src/chip/dsp4/dsp4.hpp:8:9: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:3:17: note: Virtual function in base class mednafen/src/snes/src/chip/dsp4/dsp4.hpp:8:9: note: Function in derived class mednafen/src/snes/src/chip/dsp4/dsp4.hpp:9:9: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:4:16: note: Virtual function in base class mednafen/src/snes/src/chip/dsp4/dsp4.hpp:9:9: note: Function in derived class mednafen/src/snes/src/chip/obc1/obc1.hpp:8:9: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:3:17: note: Virtual function in base class mednafen/src/snes/src/chip/obc1/obc1.hpp:8:9: note: Function in derived class mednafen/src/snes/src/chip/obc1/obc1.hpp:9:8: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:4:16: note: Virtual function in base class mednafen/src/snes/src/chip/obc1/obc1.hpp:9:8: note: Function in derived class mednafen/src/snes/src/chip/st010/st010.hpp:8:9: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:3:17: note: Virtual function in base class mednafen/src/snes/src/chip/st010/st010.hpp:8:9: note: Function in derived class mednafen/src/snes/src/chip/st010/st010.hpp:9:8: style: The function 'write' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] mednafen/src/snes/src/memory/memory.hpp:4:16: note: Virtual function in base class mednafen/src/snes/src/chip/st010/st010.hpp:9:8: note: Function in derived class mednafen/src/snes/src/memory/memory-inline.hpp:15:31: style:inconclusive: Function 'StaticRAM' argument 1 names different: declaration 'size' definition 'n'. [funcArgNamesDifferent] mednafen/src/snes/src/memory/memory.hpp:32:29: note: Function 'StaticRAM' argument 1 names different: declaration 'size' definition 'n'. mednafen/src/snes/src/memory/memory-inline.hpp:15:31: note: Function 'StaticRAM' argument 1 names different: declaration 'size' definition 'n'. mednafen/src/snes/src/cheat/cheat.cpp:22:49: style:inconclusive: Function 'install_read_patch' argument 1 names different: declaration 'c' definition 'code'. [funcArgNamesDifferent] mednafen/src/snes/src/cheat/cheat.hpp:20:44: note: Function 'install_read_patch' argument 1 names different: declaration 'c' definition 'code'. mednafen/src/snes/src/cheat/cheat.cpp:22:49: note: Function 'install_read_patch' argument 1 names different: declaration 'c' definition 'code'. mednafen/src/snes/src/system/interface/interface.hpp:3:8: performance:inconclusive: Technically the member function 'bSNES_v059::Interface::video_scanline' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/snes/interface.cpp:129:29: note: Technically the member function 'bSNES_v059::Interface::video_scanline' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/system/interface/interface.hpp:3:8: note: Technically the member function 'bSNES_v059::Interface::video_scanline' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/system/interface/interface.hpp:4:8: performance:inconclusive: Technically the member function 'bSNES_v059::Interface::audio_sample' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/snes/interface.cpp:219:29: note: Technically the member function 'bSNES_v059::Interface::audio_sample' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/system/interface/interface.hpp:4:8: note: Technically the member function 'bSNES_v059::Interface::audio_sample' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/system/interface/interface.hpp:5:8: performance:inconclusive: Technically the member function 'bSNES_v059::Interface::input_poll' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/snes/interface.cpp:263:29: note: Technically the member function 'bSNES_v059::Interface::input_poll' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/system/interface/interface.hpp:5:8: note: Technically the member function 'bSNES_v059::Interface::input_poll' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/system/interface/interface.hpp:6:11: performance:inconclusive: Technically the member function 'bSNES_v059::Interface::input_poll' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/snes/interface.cpp:323:32: note: Technically the member function 'bSNES_v059::Interface::input_poll' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/system/interface/interface.hpp:6:11: note: Technically the member function 'bSNES_v059::Interface::input_poll' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/interface.cpp:442:81: style: Condition 'memoryA->size()!=-1U' is always true [knownConditionTrueFalse] mednafen/src/snes/interface.cpp:443:67: style: Condition 'memoryB->size()!=-1U' is always true [knownConditionTrueFalse] mednafen/src/snes/interface.cpp:455:58: style: Condition 'memoryA->size()!=-1U' is always true [knownConditionTrueFalse] mednafen/src/snes/interface.cpp:455:34: note: Assuming that condition 'memoryA->size()!=0' is not redundant mednafen/src/snes/interface.cpp:455:58: note: Condition 'memoryA->size()!=-1U' is always true mednafen/src/snes/interface.cpp:460:58: style: Condition 'memoryB->size()!=-1U' is always true [knownConditionTrueFalse] mednafen/src/snes/interface.cpp:460:34: note: Assuming that condition 'memoryB->size()!=0' is not redundant mednafen/src/snes/interface.cpp:460:58: note: Condition 'memoryB->size()!=-1U' is always true mednafen/src/snes/interface.cpp:475:57: style: Condition 'memoryA->size()!=-1U' is always true [knownConditionTrueFalse] mednafen/src/snes/interface.cpp:475:33: note: Assuming that condition 'memoryA->size()!=0' is not redundant mednafen/src/snes/interface.cpp:475:57: note: Condition 'memoryA->size()!=-1U' is always true mednafen/src/snes/interface.cpp:478:57: style: Condition 'memoryB->size()!=-1U' is always true [knownConditionTrueFalse] mednafen/src/snes/interface.cpp:478:33: note: Assuming that condition 'memoryB->size()!=0' is not redundant mednafen/src/snes/interface.cpp:478:57: note: Condition 'memoryB->size()!=-1U' is always true mednafen/src/snes/interface.cpp:326:3: warning: %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] mednafen/src/snes/interface.cpp:326:3: warning: %d in format string (no. 3) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] mednafen/src/snes/interface.cpp:326:3: warning: %d in format string (no. 4) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] mednafen/src/snes/interface.cpp:664:7: style: The scope of the variable 'PAL' can be reduced. [variableScope] mednafen/src/snes/interface.cpp:129:113: style:inconclusive: Function 'video_scanline' argument 5 names different: declaration 'interlace' definition 'interlaced'. [funcArgNamesDifferent] mednafen/src/snes/src/system/interface/interface.hpp:3:92: note: Function 'video_scanline' argument 5 names different: declaration 'interlace' definition 'interlaced'. mednafen/src/snes/interface.cpp:129:113: note: Function 'video_scanline' argument 5 names different: declaration 'interlace' definition 'interlaced'. mednafen/src/snes/interface.cpp:74:60: style: Parameter 'CustomColorMap' can be declared with const [constParameter] mednafen/src/snes/src/chip/cx4/oam.cpp:8:10: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] mednafen/src/snes/src/chip/cx4/oam.cpp:6:40: note: outer condition: i>=0 mednafen/src/snes/src/chip/cx4/oam.cpp:8:10: note: identical inner condition: i>=0 mednafen/src/snes/src/chip/dsp2/opcodes.cpp:8:15: style: The scope of the variable 'c0' can be reduced. [variableScope] mednafen/src/snes/src/chip/dsp2/opcodes.cpp:8:19: style: The scope of the variable 'c1' can be reduced. [variableScope] mednafen/src/snes/src/chip/dsp2/opcodes.cpp:8:23: style: The scope of the variable 'c2' can be reduced. [variableScope] mednafen/src/snes/src/chip/dsp2/opcodes.cpp:8:27: style: The scope of the variable 'c3' can be reduced. [variableScope] mednafen/src/snes/src/chip/dsp2/opcodes.cpp:91:15: style: The scope of the variable 'c1' can be reduced. [variableScope] mednafen/src/snes/src/chip/dsp2/opcodes.cpp:91:19: style: The scope of the variable 'c2' can be reduced. [variableScope] mednafen/src/snes/src/chip/dsp2/opcodes.cpp:151:11: style: The scope of the variable 'j' can be reduced. [variableScope] mednafen/src/snes/src/chip/cx4/opcodes.cpp:110:18: warning: Redundant assignment of 'C41FAngleRes' to itself. [selfAssignment] mednafen/src/snes/src/chip/cx4/functions.cpp:69:10: style: Variable 'c4z' is assigned a value that is never used. [unreadVariable] mednafen/src/snes/src/chip/dsp3/dsp3emu.c:312:14: warning: Either the condition 'DSP3_BMIndex<8' is redundant or the array 'DSP3_Bitmap[8]' is accessed at index 8, which is out of bounds. [arrayIndexOutOfBoundsCond] mednafen/src/snes/src/chip/dsp3/dsp3emu.c:309:19: note: Assuming that condition 'DSP3_BMIndex<8' is not redundant mednafen/src/snes/src/chip/dsp3/dsp3emu.c:311:15: note: DSP3_BMIndex is incremented', new value is 8 mednafen/src/snes/src/chip/dsp3/dsp3emu.c:312:14: note: Array index out of bounds mednafen/src/snes/src/chip/dsp1/dsp1emu.cpp:253:16: style: Variable 'Size' is assigned a value that is never used. [unreadVariable] mednafen/src/snes/src/chip/dsp4/dsp4emu.c:787:15: style: Local variable 'win_left' shadows outer variable [shadowVariable] mednafen/src/snes/src/chip/dsp4/dsp4emu.c:565:9: note: Shadowed declaration mednafen/src/snes/src/chip/dsp4/dsp4emu.c:787:15: note: Shadow variable mednafen/src/snes/src/chip/dsp4/dsp4emu.c:787:25: style: Local variable 'win_right' shadows outer variable [shadowVariable] mednafen/src/snes/src/chip/dsp4/dsp4emu.c:565:19: note: Shadowed declaration mednafen/src/snes/src/chip/dsp4/dsp4emu.c:787:25: note: Shadow variable mednafen/src/snes/src/chip/dsp4/dsp4.cpp:17:34: style: Parameter 'addr' can be declared with const [constParameter] mednafen/src/snes/src/chip/dsp4/dsp4.cpp:21:35: style: Parameter 'addr' can be declared with const [constParameter] mednafen/src/snes/src/chip/st010/st010_op.cpp:56:8: style: The scope of the variable 'sorted' can be reduced. [variableScope] mednafen/src/snes/src/chip/superfx/bus/bus.cpp:14:11: error: syntax error [syntaxError] mednafen/src/snes/src/chip/spc7110/spc7110.cpp:360:24: style: Variable 'length' is assigned a value that is never used. [unreadVariable] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'CPU::cpu_version' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'PPUcounter::status' is not initialized in the constructor. Maybe it should be initialized directly in the class PPUcounter? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'PPUcounter::history' is not initialized in the constructor. Maybe it should be initialized directly in the class PPUcounter? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::sa1_irq' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::sa1_rdyb' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::sa1_resb' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::sa1_nmi' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::smeg' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::cpu_irqen' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::chdma_irqen' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::cpu_irqcl' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::chdma_irqcl' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::crv' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::cnv' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::civ' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::cpu_irq' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::cpu_ivsw' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::cpu_nvsw' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::cmeg' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::sa1_irqen' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::timer_irqen' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::dma_irqen' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::sa1_nmien' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::sa1_irqcl' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::timer_irqcl' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::dma_irqcl' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::sa1_nmicl' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::snv' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::siv' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::hvselb' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::ven' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::hen' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::hcnt' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::vcnt' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::cbmode' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::cb' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::dbmode' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::db' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::ebmode' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::eb' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::fbmode' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::fb' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::sbm' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::sw46' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::cbm' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::swen' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::cwen' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::bwp' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::siwp' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::ciwp' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::dmaen' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::dprio' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::cden' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::cdsel' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::dd' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::sd' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::chdend' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::dmasize' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::dmacb' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::dsa' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::dda' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::dtc' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::bbf' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::brf' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::acm' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::md' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::ma' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::mb' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::hl' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::vb' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::va' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::vbit' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::cpu_irqfl' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::chdma_irqfl' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::sa1_irqfl' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::timer_irqfl' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::dma_irqfl' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::sa1_nmifl' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::hcr' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::vcr' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::mr' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/cpu/cpu.cpp:23:6: warning: Member variable 'MMIO::overflow' is not initialized in the constructor. Maybe it should be initialized directly in the class MMIO? [uninitDerivedMemberVar] mednafen/src/snes/src/lib/libco/ucontext.c:42:10: portability: Obsolescent function 'getcontext' called. Applications are recommended to be rewritten to use POSIX threads. [prohibitedgetcontextCalled] mednafen/src/snes/src/lib/libco/ucontext.c:45:7: portability: Obsolescent function 'makecontext' called. Applications are recommended to be rewritten to use POSIX threads. [prohibitedmakecontextCalled] mednafen/src/snes/src/lib/libco/ucontext.c:64:3: portability: Obsolescent function 'swapcontext' called. Applications are recommended to be rewritten to use POSIX threads. [prohibitedswapcontextCalled] mednafen/src/snes/src/lib/libco/ucontext.c:42:32: style: Condition '!(thread->uc_stack.ss_sp=0)' is always true [knownConditionTrueFalse] mednafen/src/snes/src/cpu/scpu/timing/irq.cpp:51:21: style: Variable 'virq_enabled' is assigned a value that is never used. [unreadVariable] mednafen/src/snes/src/cpu/scpu/timing/irq.cpp:52:21: style: Variable 'hirq_enabled' is assigned a value that is never used. [unreadVariable] mednafen/src/snes/src/cartridge/cartridge.cpp:120:3: performance: Variable 'loaded' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/snes/src/memory/memory.hpp:19:9: performance:inconclusive: Technically the member function 'bSNES_v059::UnmappedMMIO::mmio_read' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/snes/src/memory/memory.cpp:22:21: note: Technically the member function 'bSNES_v059::UnmappedMMIO::mmio_read' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/memory/memory.hpp:19:9: note: Technically the member function 'bSNES_v059::UnmappedMMIO::mmio_read' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/memory/memory.hpp:20:8: performance:inconclusive: Technically the member function 'bSNES_v059::UnmappedMMIO::mmio_write' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/snes/src/memory/memory.cpp:23:20: note: Technically the member function 'bSNES_v059::UnmappedMMIO::mmio_write' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/memory/memory.hpp:20:8: note: Technically the member function 'bSNES_v059::UnmappedMMIO::mmio_write' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/memory/memory.hpp:69:12: performance:inconclusive: Technically the member function 'bSNES_v059::Bus::mirror' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/snes/src/memory/memory.cpp:38:15: note: Technically the member function 'bSNES_v059::Bus::mirror' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/memory/memory.hpp:69:12: note: Technically the member function 'bSNES_v059::Bus::mirror' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/memory/memory.cpp:69:20: style: Condition 'access.size()==-1U' is always false [knownConditionTrueFalse] mednafen/src/snes/src/cpu/core/opcode_misc.cpp:75:18: style: Condition 'regs.wai=-1' is always true [knownConditionTrueFalse] mednafen/src/snes/src/sdsp/sdsp.cpp:323:7: warning: Member variable 'sDSP::phase_index' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes/src/sdsp/sdsp.cpp:323:7: warning: Member variable 'sDSP::state' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes/src/sdsp/sdsp.cpp:323:7: warning: Member variable 'sDSP::voice' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes/src/sdsp/sdsp.hpp:5:9: style:inconclusive: Technically the member function 'bSNES_v059::sDSP::read' can be const. [functionConst] mednafen/src/snes/src/sdsp/sdsp.cpp:238:13: note: Technically the member function 'bSNES_v059::sDSP::read' can be const. mednafen/src/snes/src/sdsp/sdsp.hpp:5:9: note: Technically the member function 'bSNES_v059::sDSP::read' can be const. mednafen/src/snes/src/sdsp/sdsp.hpp:124:8: style:inconclusive: Technically the member function 'bSNES_v059::sDSP::counter_poll' can be const. [functionConst] mednafen/src/snes/src/sdsp/counter.cpp:47:19: note: Technically the member function 'bSNES_v059::sDSP::counter_poll' can be const. mednafen/src/snes/src/sdsp/sdsp.hpp:124:8: note: Technically the member function 'bSNES_v059::sDSP::counter_poll' can be const. mednafen/src/snes/src/sdsp/sdsp.hpp:154:7: style:inconclusive: Technically the member function 'bSNES_v059::sDSP::calc_fir' can be const. [functionConst] mednafen/src/snes/src/sdsp/echo.cpp:3:11: note: Technically the member function 'bSNES_v059::sDSP::calc_fir' can be const. mednafen/src/snes/src/sdsp/sdsp.hpp:154:7: note: Technically the member function 'bSNES_v059::sDSP::calc_fir' can be const. mednafen/src/snes/src/sdsp/voice.cpp:18:29: style: Parameter 'v' can be declared with const [constParameter] mednafen/src/snes/src/sdsp/voice.cpp:43:30: style: Parameter 'v' can be declared with const [constParameter] mednafen/src/snes_faust/cpu.h:152:34: style:inconclusive: Boolean expression 'active' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/snes/src/system/input/input.cpp:75:39: style:inconclusive: Boolean expression 'direction_y' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/snes/src/system/input/input.cpp:84:39: style:inconclusive: Boolean expression 'direction_x' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/snes/src/system/scheduler/scheduler.cpp:55:12: warning: Member variable 'Scheduler::clock' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes/src/system/scheduler/scheduler.cpp:55:12: warning: Member variable 'Scheduler::sync' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes/src/system/system.cpp:233:9: warning: Member variable 'System::exit_line_counter' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes/src/system/scheduler/scheduler.cpp:56:3: performance: Variable 'thread_snes' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/snes/src/system/scheduler/scheduler.cpp:57:3: performance: Variable 'thread_cpu' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/snes/src/system/scheduler/scheduler.cpp:58:3: performance: Variable 'thread_cop' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/snes/src/system/scheduler/scheduler.cpp:59:3: performance: Variable 'thread_smp' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/snes/src/system/scheduler/scheduler.cpp:60:3: performance: Variable 'thread_ppu' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/snes/src/system/scheduler/scheduler.cpp:61:3: performance: Variable 'thread_dsp' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/snes/src/system/scheduler/scheduler.cpp:62:3: performance: Variable 'thread_active' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/snes/src/system/system.cpp:234:3: performance: Variable 'region' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/snes/src/system/system.cpp:235:3: performance: Variable 'expansion' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/snes/src/system/debugger/debugger.hpp:26:9: performance:inconclusive: Technically the member function 'bSNES_v059::Debugger::read' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/snes/src/system/debugger/debugger.cpp:32:17: note: Technically the member function 'bSNES_v059::Debugger::read' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/system/debugger/debugger.hpp:26:9: note: Technically the member function 'bSNES_v059::Debugger::read' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/system/debugger/debugger.hpp:27:8: performance:inconclusive: Technically the member function 'bSNES_v059::Debugger::write' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/snes/src/system/debugger/debugger.cpp:61:16: note: Technically the member function 'bSNES_v059::Debugger::write' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/system/debugger/debugger.hpp:27:8: note: Technically the member function 'bSNES_v059::Debugger::write' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/system/video/video.hpp:20:8: performance:inconclusive: Technically the member function 'bSNES_v059::Video::draw_cursor' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/snes/src/system/video/video.cpp:23:13: note: Technically the member function 'bSNES_v059::Video::draw_cursor' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/system/video/video.hpp:20:8: note: Technically the member function 'bSNES_v059::Video::draw_cursor' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/system/audio/audio.hpp:7:8: performance:inconclusive: Technically the member function 'bSNES_v059::Audio::init' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/snes/src/system/audio/audio.cpp:63:13: note: Technically the member function 'bSNES_v059::Audio::init' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/system/audio/audio.hpp:7:8: note: Technically the member function 'bSNES_v059::Audio::init' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/system/input/input.hpp:40:8: performance:inconclusive: Technically the member function 'bSNES_v059::Input::init' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/snes/src/system/input/input.cpp:332:13: note: Technically the member function 'bSNES_v059::Input::init' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/system/input/input.hpp:40:8: note: Technically the member function 'bSNES_v059::Input::init' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/system/audio/audio.cpp:15:42: style:inconclusive: Function 'coprocessor_frequency' argument 1 names different: declaration 'frequency' definition 'input_frequency'. [funcArgNamesDifferent] mednafen/src/snes/src/system/audio/audio.hpp:4:37: note: Function 'coprocessor_frequency' argument 1 names different: declaration 'frequency' definition 'input_frequency'. mednafen/src/snes/src/system/audio/audio.cpp:15:42: note: Function 'coprocessor_frequency' argument 1 names different: declaration 'frequency' definition 'input_frequency'. mednafen/src/snes/src/system/input/input.cpp:5:29: style:inconclusive: Function 'port_read' argument 1 names different: declaration 'port' definition 'portnumber'. [funcArgNamesDifferent] mednafen/src/snes/src/system/input/input.hpp:38:24: note: Function 'port_read' argument 1 names different: declaration 'port' definition 'portnumber'. mednafen/src/snes/src/system/input/input.cpp:5:29: note: Function 'port_read' argument 1 names different: declaration 'port' definition 'portnumber'. mednafen/src/snes/src/system/input/input.cpp:271:34: style:inconclusive: Function 'port_set_device' argument 1 names different: declaration 'port' definition 'portnumber'. [funcArgNamesDifferent] mednafen/src/snes/src/system/input/input.hpp:39:29: note: Function 'port_set_device' argument 1 names different: declaration 'port' definition 'portnumber'. mednafen/src/snes/src/system/input/input.cpp:271:34: note: Function 'port_set_device' argument 1 names different: declaration 'port' definition 'portnumber'. mednafen/src/snes/src/smp/core/opcode_read.cpp:151:23: style:inconclusive: Boolean expression 'regs.p.c' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean] mednafen/src/snes/src/smp/core/opcode_read.cpp:121:23: style:inconclusive: Boolean expression 'regs.p.c' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/snes/src/smp/ssmp/memory/memory.hpp:1:7: style:inconclusive: Technically the member function 'bSNES_v059::SMP::ram_read' can be const. [functionConst] mednafen/src/snes/src/smp/ssmp/memory/memory.cpp:3:25: note: Technically the member function 'bSNES_v059::SMP::ram_read' can be const. mednafen/src/snes/src/smp/ssmp/memory/memory.hpp:1:7: note: Technically the member function 'bSNES_v059::SMP::ram_read' can be const. mednafen/src/snes/src/smp/ssmp/memory/memory.hpp:2:6: performance:inconclusive: Technically the member function 'bSNES_v059::SMP::ram_write' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/snes/src/smp/ssmp/memory/memory.cpp:9:24: note: Technically the member function 'bSNES_v059::SMP::ram_write' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/smp/ssmp/memory/memory.hpp:2:6: note: Technically the member function 'bSNES_v059::SMP::ram_write' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/smp/ssmp/memory/memory.hpp:4:7: performance:inconclusive: Technically the member function 'bSNES_v059::SMP::port_read' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/snes/src/smp/ssmp/memory/memory.cpp:16:12: note: Technically the member function 'bSNES_v059::SMP::port_read' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/smp/ssmp/memory/memory.hpp:4:7: note: Technically the member function 'bSNES_v059::SMP::port_read' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/smp/ssmp/memory/memory.hpp:5:6: performance:inconclusive: Technically the member function 'bSNES_v059::SMP::port_write' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/snes/src/smp/ssmp/memory/memory.cpp:20:11: note: Technically the member function 'bSNES_v059::SMP::port_write' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/smp/ssmp/memory/memory.hpp:5:6: note: Technically the member function 'bSNES_v059::SMP::port_write' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/smp/ssmp/timing/timing.hpp:32:19: performance:inconclusive: Technically the member function 'bSNES_v059::SMP::add_clocks' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/snes/src/smp/ssmp/timing/timing.cpp:3:11: note: Technically the member function 'bSNES_v059::SMP::add_clocks' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/smp/ssmp/timing/timing.hpp:32:19: note: Technically the member function 'bSNES_v059::SMP::add_clocks' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes_faust/cart/dsp1chip.h:206:11: warning: Member variable 'DSP1Chip::cop_x' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes_faust/cart/dsp1chip.h:206:11: warning: Member variable 'DSP1Chip::cop_y' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes_faust/cart/dsp1chip.h:206:11: warning: Member variable 'DSP1Chip::cop_z' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes_faust/cart/dsp1chip.h:206:11: warning: Member variable 'DSP1Chip::screen_cop_distance' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes_faust/cart/dsp1chip.h:206:11: warning: Member variable 'DSP1Chip::azimuth_angle' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes_faust/cart/dsp1chip.h:206:11: warning: Member variable 'DSP1Chip::zenith_angle' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes_faust/cart/dsp1chip.h:206:11: warning: Member variable 'DSP1Chip::raster_vfudge' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes_faust/cart/dsp1chip.h:206:11: warning: Member variable 'DSP1Chip::obj_rot_matrix' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes_faust/cart/dsp1chip.h:208:2: performance: Variable 'Revision' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/snes_faust/cart/dsp1chip.h:482:9: style: Variable 'sig' is reassigned a value before the old one has been used. [redundantAssignment] mednafen/src/snes_faust/cart/dsp1chip.h:480:9: note: sig is assigned mednafen/src/snes_faust/cart/dsp1chip.h:482:9: note: sig is overwritten mednafen/src/snes_faust/cart/sa1.cpp:47:34: style:inconclusive: Boolean expression 'active' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/snes_faust/cart/sa1cpu.h:39:7: performance:inconclusive: Technically the member function 'MDFN_IEN_SNES_FAUST::SA1CPU::CPU_Misc::RunDMA' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/snes_faust/cart/sa1.cpp:203:24: note: Technically the member function 'MDFN_IEN_SNES_FAUST::SA1CPU::CPU_Misc::RunDMA' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes_faust/cart/sa1cpu.h:39:7: note: Technically the member function 'MDFN_IEN_SNES_FAUST::SA1CPU::CPU_Misc::RunDMA' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes_faust/cart/sdd1.cpp:258:31: style:inconclusive: Boolean expression 'bg->run_end_bit' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/snes_faust/cart/sdd1.cpp:597:44: style: Same expression in both branches of ternary operator. [duplicateExpressionTernary] mednafen/src/snes_faust/cart/sdd1.cpp:598:45: style: Same expression in both branches of ternary operator. [duplicateExpressionTernary] mednafen/src/snes_faust/cart/superfx.cpp:291:17: style:inconclusive: Boolean expression 'ClockSelect' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean] mednafen/src/snes_faust/cart/superfx.cpp:307:24: style:inconclusive: Boolean expression 'IRQPending' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/snes_faust/cart/superfx.cpp:152:24: style:inconclusive: Technically the member function 'MDFN_IEN_SNES_FAUST::SuperFX::ReadR' can be const. [functionConst] mednafen/src/snes_faust/cart/superfx.cpp:370:24: note: Technically the member function 'MDFN_IEN_SNES_FAUST::SuperFX::ReadR' can be const. mednafen/src/snes_faust/cart/superfx.cpp:152:24: note: Technically the member function 'MDFN_IEN_SNES_FAUST::SuperFX::ReadR' can be const. mednafen/src/snes_faust/cart/superfx.cpp:158:26: style:inconclusive: Technically the member function 'MDFN_IEN_SNES_FAUST::SuperFX::CalcTNO' can be const. [functionConst] mednafen/src/snes_faust/cart/superfx.cpp:408:26: note: Technically the member function 'MDFN_IEN_SNES_FAUST::SuperFX::CalcTNO' can be const. mednafen/src/snes_faust/cart/superfx.cpp:158:26: note: Technically the member function 'MDFN_IEN_SNES_FAUST::SuperFX::CalcTNO' can be const. mednafen/src/snes_faust/cart/superfx.cpp:307:24: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] mednafen/src/snes_faust/cart/superfx.cpp:2218:16: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] mednafen/src/snes_faust/cart/superfx.cpp:2202:33: note: outer condition: bank<0x80 mednafen/src/snes_faust/cart/superfx.cpp:2218:16: note: identical inner condition: bank<0x80 mednafen/src/snes_faust/dis65816.h:37:8: style:inconclusive: Technically the member function 'Mednafen::Dis65816::IsMXHintSet' can be const. [functionConst] mednafen/src/snes_faust/dis65816.cpp:53:23: note: Technically the member function 'Mednafen::Dis65816::IsMXHintSet' can be const. mednafen/src/snes_faust/dis65816.h:37:8: note: Technically the member function 'Mednafen::Dis65816::IsMXHintSet' can be const. mednafen/src/snes_faust/dis65816.h:38:8: style:inconclusive: Technically the member function 'Mednafen::Dis65816::GetM' can be const. [functionConst] mednafen/src/snes_faust/dis65816.cpp:63:23: note: Technically the member function 'Mednafen::Dis65816::GetM' can be const. mednafen/src/snes_faust/dis65816.h:38:8: note: Technically the member function 'Mednafen::Dis65816::GetM' can be const. mednafen/src/snes_faust/dis65816.h:39:8: style:inconclusive: Technically the member function 'Mednafen::Dis65816::GetX' can be const. [functionConst] mednafen/src/snes_faust/dis65816.cpp:74:23: note: Technically the member function 'Mednafen::Dis65816::GetX' can be const. mednafen/src/snes_faust/dis65816.h:39:8: note: Technically the member function 'Mednafen::Dis65816::GetX' can be const. mednafen/src/snes_faust/input.cpp:204:2: performance: Variable 'buttons' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/snes_faust/input.cpp:481:25: style:inconclusive: Function 'INPUT_Set' argument 1 names different: declaration 'port' definition 'vport'. [funcArgNamesDifferent] mednafen/src/snes_faust/input.h:31:26: note: Function 'INPUT_Set' argument 1 names different: declaration 'port' definition 'vport'. mednafen/src/snes_faust/input.cpp:481:25: note: Function 'INPUT_Set' argument 1 names different: declaration 'port' definition 'vport'. mednafen/src/snes/src/ppu/render/windows.cpp:57:35: style:inconclusive: Boolean expression 'w1_mask' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean] mednafen/src/snes/src/ppu/render/windows.cpp:58:35: style:inconclusive: Boolean expression 'w1_mask' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/snes_faust/msu1.cpp:322:34: warning: Either the condition '(A&0x3)==0x3' is redundant or there is signed integer overflow for expression '0xFF<' can be const. [functionConst] mednafen/src/snes/src/ppu/render/bg.cpp:26:13: note: Technically the member function 'bSNES_v059::PPU::bg_get_tile < BG3 >' can be const. mednafen/src/snes/src/ppu/render/render.hpp:53:30: note: Technically the member function 'bSNES_v059::PPU::bg_get_tile < BG3 >' can be const. mednafen/src/snes/src/ppu/render/render.hpp:53:30: style:inconclusive: Technically the member function 'bSNES_v059::PPU::bg_get_tile < BG1 >' can be const. [functionConst] mednafen/src/snes/src/ppu/render/bg.cpp:26:13: note: Technically the member function 'bSNES_v059::PPU::bg_get_tile < BG1 >' can be const. mednafen/src/snes/src/ppu/render/render.hpp:53:30: note: Technically the member function 'bSNES_v059::PPU::bg_get_tile < BG1 >' can be const. mednafen/src/snes/src/ppu/render/render.hpp:53:30: style:inconclusive: Technically the member function 'bSNES_v059::PPU::bg_get_tile < BG2 >' can be const. [functionConst] mednafen/src/snes/src/ppu/render/bg.cpp:26:13: note: Technically the member function 'bSNES_v059::PPU::bg_get_tile < BG2 >' can be const. mednafen/src/snes/src/ppu/render/render.hpp:53:30: note: Technically the member function 'bSNES_v059::PPU::bg_get_tile < BG2 >' can be const. mednafen/src/snes/src/ppu/render/render.hpp:53:30: style:inconclusive: Technically the member function 'bSNES_v059::PPU::bg_get_tile < BG4 >' can be const. [functionConst] mednafen/src/snes/src/ppu/render/bg.cpp:26:13: note: Technically the member function 'bSNES_v059::PPU::bg_get_tile < BG4 >' can be const. mednafen/src/snes/src/ppu/render/render.hpp:53:30: note: Technically the member function 'bSNES_v059::PPU::bg_get_tile < BG4 >' can be const. mednafen/src/snes/src/ppu/render/render.hpp:89:15: style:inconclusive: Technically the member function 'bSNES_v059::PPU::addsub' can be const. [functionConst] mednafen/src/snes/src/ppu/render/addsub.cpp:5:20: note: Technically the member function 'bSNES_v059::PPU::addsub' can be const. mednafen/src/snes/src/ppu/render/render.hpp:89:15: note: Technically the member function 'bSNES_v059::PPU::addsub' can be const. mednafen/src/snes/src/ppu/render/render.hpp:92:15: performance:inconclusive: Technically the member function 'bSNES_v059::PPU::get_palette' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/snes/src/ppu/render/line.cpp:3:26: note: Technically the member function 'bSNES_v059::PPU::get_palette' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/ppu/render/render.hpp:92:15: note: Technically the member function 'bSNES_v059::PPU::get_palette' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/ppu/render/render.hpp:93:15: performance:inconclusive: Technically the member function 'bSNES_v059::PPU::get_direct_color' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/snes/src/ppu/render/line.cpp:11:26: note: Technically the member function 'bSNES_v059::PPU::get_direct_color' can be static (but you may consider moving to unnamed namespace). mednafen/src/snes/src/ppu/render/render.hpp:93:15: note: Technically the member function 'bSNES_v059::PPU::get_direct_color' can be static (but you may consider moving to unnamed namespace). mednafen/src/sound/Fir_Resampler.h:84:2: warning: Member variable 'Fir_Resampler::impulses' is not initialized in the constructor. [uninitMemberVar] mednafen/src/sound/Fir_Resampler.h:82:8: warning: The class 'Fir_Resampler' defines member variable with name 'impulses' also defined in its parent class 'Fir_Resampler_'. [duplInheritedMember] mednafen/src/sound/Fir_Resampler.h:71:12: note: Parent variable 'Fir_Resampler_::impulses' mednafen/src/sound/Fir_Resampler.h:82:8: note: Derived variable 'Fir_Resampler::impulses' mednafen/src/sound/Fir_Resampler.cpp:87:43: style:inconclusive: Function 'time_ratio' argument 1 names different: declaration 'factor' definition 'new_factor'. [funcArgNamesDifferent] mednafen/src/sound/Fir_Resampler.h:17:28: note: Function 'time_ratio' argument 1 names different: declaration 'factor' definition 'new_factor'. mednafen/src/sound/Fir_Resampler.cpp:87:43: note: Function 'time_ratio' argument 1 names different: declaration 'factor' definition 'new_factor'. mednafen/src/sound/Fir_Resampler.cpp:141:47: style:inconclusive: Function 'input_needed' argument 1 names different: declaration 'count' definition 'output_count'. [funcArgNamesDifferent] mednafen/src/sound/Fir_Resampler.h:51:32: note: Function 'input_needed' argument 1 names different: declaration 'count' definition 'output_count'. mednafen/src/sound/Fir_Resampler.cpp:141:47: note: Function 'input_needed' argument 1 names different: declaration 'count' definition 'output_count'. mednafen/src/sound/Blip_Buffer.h:242:2: warning: Member variable 'Blip_Synth::impulses' is not initialized in the constructor. [uninitMemberVar] mednafen/src/sound/Blip_Buffer.h:329:1: style: The class 'Blip_Reader' does not have a constructor although it has private member variables. [noConstructor] mednafen/src/sound/Blip_Buffer.h:68:6: performance:inconclusive: Technically the member function 'Blip_Buffer::output_latency' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/sound/Blip_Buffer.h:484:31: note: Technically the member function 'Blip_Buffer::output_latency' can be static (but you may consider moving to unnamed namespace). mednafen/src/sound/Blip_Buffer.h:68:6: note: Technically the member function 'Blip_Buffer::output_latency' can be static (but you may consider moving to unnamed namespace). mednafen/src/sound/Blip_Buffer.h:91:7: style:inconclusive: Technically the member function 'Blip_Buffer::mix_samples' can be const. [functionConst] mednafen/src/sound/Blip_Buffer.cpp:436:19: note: Technically the member function 'Blip_Buffer::mix_samples' can be const. mednafen/src/sound/Blip_Buffer.h:91:7: note: Technically the member function 'Blip_Buffer::mix_samples' can be const. mednafen/src/sound/Blip_Buffer.h:169:8: performance:inconclusive: Technically the member function 'Blip_Synth_Fast_::treble_eq' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/sound/Blip_Buffer.h:335:7: style:inconclusive: Technically the member function 'Blip_Reader::end' can be const. [functionConst] mednafen/src/sound/Blip_Buffer.cpp:293:10: style: Condition 'p==p2' is always false [knownConditionTrueFalse] mednafen/src/sound/Blip_Buffer.cpp:286:10: note: p2 is assigned 'blip_res-2-p' here. mednafen/src/sound/Blip_Buffer.cpp:293:10: note: Condition 'p==p2' is always false mednafen/src/sound/Blip_Buffer.cpp:411:28: style: Condition '(short)s!=s' is always false [knownConditionTrueFalse] mednafen/src/sound/Blip_Buffer.cpp:410:17: note: s is assigned 'reader_reader_accum>>(blip_sample_bits-16)' here. mednafen/src/sound/Blip_Buffer.cpp:411:28: note: Condition '(short)s!=s' is always false mednafen/src/sound/Blip_Buffer.cpp:422:28: style: Condition '(short)s!=s' is always false [knownConditionTrueFalse] mednafen/src/sound/Blip_Buffer.cpp:421:17: note: s is assigned 'reader_reader_accum>>(blip_sample_bits-16)' here. mednafen/src/sound/Blip_Buffer.cpp:422:28: note: Condition '(short)s!=s' is always false mednafen/src/sound/Blip_Buffer.cpp:46:14: portability: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS] mednafen/src/sound/Blip_Buffer.h:469:53: style:inconclusive: Function 'update' argument 1 names different: declaration 'time' definition 't'. [funcArgNamesDifferent] mednafen/src/sound/Blip_Buffer.h:213:27: note: Function 'update' argument 1 names different: declaration 'time' definition 't'. mednafen/src/sound/Blip_Buffer.h:469:53: note: Function 'update' argument 1 names different: declaration 'time' definition 't'. mednafen/src/sound/Blip_Buffer.h:469:60: style:inconclusive: Function 'update' argument 2 names different: declaration 'amplitude' definition 'amp'. [funcArgNamesDifferent] mednafen/src/sound/Blip_Buffer.h:213:37: note: Function 'update' argument 2 names different: declaration 'amplitude' definition 'amp'. mednafen/src/sound/Blip_Buffer.h:469:60: note: Function 'update' argument 2 names different: declaration 'amplitude' definition 'amp'. mednafen/src/sound/Blip_Buffer.h:476:42: style:inconclusive: Function 'blip_eq_t' argument 1 names different: declaration 'treble_db' definition 't'. [funcArgNamesDifferent] mednafen/src/sound/Blip_Buffer.h:251:20: note: Function 'blip_eq_t' argument 1 names different: declaration 'treble_db' definition 't'. mednafen/src/sound/Blip_Buffer.h:476:42: note: Function 'blip_eq_t' argument 1 names different: declaration 'treble_db' definition 't'. mednafen/src/sound/Blip_Buffer.h:478:42: style:inconclusive: Function 'blip_eq_t' argument 1 names different: declaration 'treble' definition 't'. [funcArgNamesDifferent] mednafen/src/sound/Blip_Buffer.h:254:20: note: Function 'blip_eq_t' argument 1 names different: declaration 'treble' definition 't'. mednafen/src/sound/Blip_Buffer.h:478:42: note: Function 'blip_eq_t' argument 1 names different: declaration 'treble' definition 't'. mednafen/src/sound/Blip_Buffer.h:478:50: style:inconclusive: Function 'blip_eq_t' argument 2 names different: declaration 'rolloff_freq' definition 'rf'. [funcArgNamesDifferent] mednafen/src/sound/Blip_Buffer.h:254:33: note: Function 'blip_eq_t' argument 2 names different: declaration 'rolloff_freq' definition 'rf'. mednafen/src/sound/Blip_Buffer.h:478:50: note: Function 'blip_eq_t' argument 2 names different: declaration 'rolloff_freq' definition 'rf'. mednafen/src/sound/Blip_Buffer.h:478:59: style:inconclusive: Function 'blip_eq_t' argument 3 names different: declaration 'sample_rate' definition 'sr'. [funcArgNamesDifferent] mednafen/src/sound/Blip_Buffer.h:254:52: note: Function 'blip_eq_t' argument 3 names different: declaration 'sample_rate' definition 'sr'. mednafen/src/sound/Blip_Buffer.h:478:59: note: Function 'blip_eq_t' argument 3 names different: declaration 'sample_rate' definition 'sr'. mednafen/src/sound/Blip_Buffer.h:478:68: style:inconclusive: Function 'blip_eq_t' argument 4 names different: declaration 'cutoff_freq' definition 'cf'. [funcArgNamesDifferent] mednafen/src/sound/Blip_Buffer.h:254:70: note: Function 'blip_eq_t' argument 4 names different: declaration 'cutoff_freq' definition 'cf'. mednafen/src/sound/Blip_Buffer.h:478:68: note: Function 'blip_eq_t' argument 4 names different: declaration 'cutoff_freq' definition 'cf'. mednafen/src/sound/Blip_Buffer.cpp:80:62: style:inconclusive: Function 'set_sample_rate' argument 1 names different: declaration 'samples_per_sec' definition 'new_rate'. [funcArgNamesDifferent] mednafen/src/sound/Blip_Buffer.h:37:37: note: Function 'set_sample_rate' argument 1 names different: declaration 'samples_per_sec' definition 'new_rate'. mednafen/src/sound/Blip_Buffer.cpp:80:62: note: Function 'set_sample_rate' argument 1 names different: declaration 'samples_per_sec' definition 'new_rate'. mednafen/src/sound/Blip_Buffer.cpp:80:76: style:inconclusive: Function 'set_sample_rate' argument 2 names different: declaration 'msec_length' definition 'msec'. [funcArgNamesDifferent] mednafen/src/sound/Blip_Buffer.h:37:58: note: Function 'set_sample_rate' argument 2 names different: declaration 'msec_length' definition 'msec'. mednafen/src/sound/Blip_Buffer.cpp:80:76: note: Function 'set_sample_rate' argument 2 names different: declaration 'msec_length' definition 'msec'. mednafen/src/sound/Blip_Buffer.cpp:133:60: style:inconclusive: Function 'clock_rate_factor' argument 1 names different: declaration 'clock_rate' definition 'rate'. [funcArgNamesDifferent] mednafen/src/sound/Blip_Buffer.h:100:48: note: Function 'clock_rate_factor' argument 1 names different: declaration 'clock_rate' definition 'rate'. mednafen/src/sound/Blip_Buffer.cpp:133:60: note: Function 'clock_rate_factor' argument 1 names different: declaration 'clock_rate' definition 'rate'. mednafen/src/sound/Blip_Buffer.cpp:141:34: style:inconclusive: Function 'bass_freq' argument 1 names different: declaration 'frequency' definition 'freq'. [funcArgNamesDifferent] mednafen/src/sound/Blip_Buffer.h:65:22: note: Function 'bass_freq' argument 1 names different: declaration 'frequency' definition 'freq'. mednafen/src/sound/Blip_Buffer.cpp:141:34: note: Function 'bass_freq' argument 1 names different: declaration 'frequency' definition 'freq'. mednafen/src/sound/Blip_Buffer.cpp:155:42: style:inconclusive: Function 'end_frame' argument 1 names different: declaration 'time' definition 't'. [funcArgNamesDifferent] mednafen/src/sound/Blip_Buffer.h:45:30: note: Function 'end_frame' argument 1 names different: declaration 'time' definition 't'. mednafen/src/sound/Blip_Buffer.cpp:155:42: note: Function 'end_frame' argument 1 names different: declaration 'time' definition 't'. mednafen/src/sound/Blip_Buffer.cpp:167:46: style:inconclusive: Function 'count_samples' argument 1 names different: declaration 'duration' definition 't'. [funcArgNamesDifferent] mednafen/src/sound/Blip_Buffer.h:88:34: note: Function 'count_samples' argument 1 names different: declaration 'duration' definition 't'. mednafen/src/sound/Blip_Buffer.cpp:167:46: note: Function 'count_samples' argument 1 names different: declaration 'duration' definition 't'. mednafen/src/sound/Blip_Buffer.cpp:217:34: style:inconclusive: Function 'Blip_Synth_' argument 1 names different: declaration 'impulses' definition 'p'. [funcArgNamesDifferent] mednafen/src/sound/Blip_Buffer.h:179:23: note: Function 'Blip_Synth_' argument 1 names different: declaration 'impulses' definition 'p'. mednafen/src/sound/Blip_Buffer.cpp:217:34: note: Function 'Blip_Synth_' argument 1 names different: declaration 'impulses' definition 'p'. mednafen/src/sound/Blip_Buffer.cpp:217:41: style:inconclusive: Function 'Blip_Synth_' argument 2 names different: declaration 'width' definition 'w'. [funcArgNamesDifferent] mednafen/src/sound/Blip_Buffer.h:179:37: note: Function 'Blip_Synth_' argument 2 names different: declaration 'width' definition 'w'. mednafen/src/sound/Blip_Buffer.cpp:217:41: note: Function 'Blip_Synth_' argument 2 names different: declaration 'width' definition 'w'. mednafen/src/sound/Blip_Buffer.cpp:395:62: style:inconclusive: Function 'read_samples' argument 1 names different: declaration 'dest' definition 'out'. [funcArgNamesDifferent] mednafen/src/sound/Blip_Buffer.h:51:36: note: Function 'read_samples' argument 1 names different: declaration 'dest' definition 'out'. mednafen/src/sound/Blip_Buffer.cpp:395:62: note: Function 'read_samples' argument 1 names different: declaration 'dest' definition 'out'. mednafen/src/sound/Blip_Buffer.cpp:436:53: style:inconclusive: Function 'mix_samples' argument 1 names different: declaration 'buf' definition 'in'. [funcArgNamesDifferent] mednafen/src/sound/Blip_Buffer.h:91:41: note: Function 'mix_samples' argument 1 names different: declaration 'buf' definition 'in'. mednafen/src/sound/Blip_Buffer.cpp:436:53: note: Function 'mix_samples' argument 1 names different: declaration 'buf' definition 'in'. mednafen/src/sound/Blip_Buffer.h:488:50: style: Parameter 'blip_buf' can be declared with const [constParameter] mednafen/src/snes/src/ppu/render/oam.cpp:39:52: style: Same value in both branches of ternary operator. [duplicateValueTernary] mednafen/src/sound/Stereo_Buffer.cpp:57:62: style:inconclusive: Function 'end_frame' argument 2 names different: declaration 'was_stereo' definition 'stereo'. [funcArgNamesDifferent] mednafen/src/sound/Stereo_Buffer.h:31:36: note: Function 'end_frame' argument 2 names different: declaration 'was_stereo' definition 'stereo'. mednafen/src/sound/Stereo_Buffer.cpp:57:62: note: Function 'end_frame' argument 2 names different: declaration 'was_stereo' definition 'stereo'. mednafen/src/snes_faust/snes.cpp:50:2: warning:inconclusive: Member variable 'ReadPatchInfoStruct::compare' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes_faust/snes.cpp:51:2: warning: Member variable 'ReadPatchInfoStruct::compare' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes_faust/cpu.h:110:7: style:inconclusive: Technically the member function 'MDFN_IEN_SNES_FAUST::CPU_Misc::EventHandler' can be const. [functionConst] mednafen/src/snes_faust/snes.cpp:919:16: note: Technically the member function 'MDFN_IEN_SNES_FAUST::CPU_Misc::EventHandler' can be const. mednafen/src/snes_faust/cpu.h:110:7: note: Technically the member function 'MDFN_IEN_SNES_FAUST::CPU_Misc::EventHandler' can be const. mednafen/src/snes_faust/snes.cpp:51:2: style: Struct 'ReadPatchInfoStruct' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/snes/src/ppu/render/mode7.cpp:19:9: style: The scope of the variable 'px' can be reduced. [variableScope] mednafen/src/snes/src/ppu/render/mode7.cpp:19:13: style: The scope of the variable 'py' can be reduced. [variableScope] mednafen/src/snes/src/ppu/render/bg.cpp:93:10: style: The scope of the variable 'hoffset' can be reduced. [variableScope] mednafen/src/snes/src/ppu/render/bg.cpp:93:19: style: The scope of the variable 'voffset' can be reduced. [variableScope] mednafen/src/snes/src/ppu/render/bg.cpp:93:35: style: The scope of the variable 'col' can be reduced. [variableScope] mednafen/src/snes/src/ppu/render/cache.cpp:28:30: style: The scope of the variable 'd4' can be reduced. [variableScope] mednafen/src/snes/src/ppu/render/cache.cpp:28:34: style: The scope of the variable 'd5' can be reduced. [variableScope] mednafen/src/snes/src/ppu/render/cache.cpp:28:38: style: The scope of the variable 'd6' can be reduced. [variableScope] mednafen/src/snes/src/ppu/render/cache.cpp:28:42: style: The scope of the variable 'd7' can be reduced. [variableScope] mednafen/src/sound/WAVRecord.cpp:31:2: performance: Variable 'PCMBytesWritten' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/sound/WAVRecord.cpp:33:2: performance: Variable 'SoundRate' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/sound/WAVRecord.cpp:34:2: performance: Variable 'SoundChan' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/sound/WAVRecord.cpp:28:47: style:inconclusive: Function 'WAVRecord' argument 2 names different: declaration 'SoundRate' definition 'SoundRate_arg'. [funcArgNamesDifferent] mednafen/src/sound/WAVRecord.h:35:37: note: Function 'WAVRecord' argument 2 names different: declaration 'SoundRate' definition 'SoundRate_arg'. mednafen/src/sound/WAVRecord.cpp:28:47: note: Function 'WAVRecord' argument 2 names different: declaration 'SoundRate' definition 'SoundRate_arg'. mednafen/src/sound/WAVRecord.cpp:28:69: style:inconclusive: Function 'WAVRecord' argument 3 names different: declaration 'SoundChan' definition 'SoundChan_arg'. [funcArgNamesDifferent] mednafen/src/sound/WAVRecord.h:35:55: note: Function 'WAVRecord' argument 3 names different: declaration 'SoundChan' definition 'SoundChan_arg'. mednafen/src/sound/WAVRecord.cpp:28:69: note: Function 'WAVRecord' argument 3 names different: declaration 'SoundChan' definition 'SoundChan_arg'. mednafen/src/snes/src/ppu/mmio/mmio.cpp:22:28: style:inconclusive: Function 'mmio_w2102' argument 1 names different: declaration 'value' definition 'data'. [funcArgNamesDifferent] mednafen/src/snes/src/ppu/mmio/mmio.hpp:131:23: note: Function 'mmio_w2102' argument 1 names different: declaration 'value' definition 'data'. mednafen/src/snes/src/ppu/mmio/mmio.cpp:22:28: note: Function 'mmio_w2102' argument 1 names different: declaration 'value' definition 'data'. mednafen/src/snes/src/ppu/mmio/mmio.cpp:30:28: style:inconclusive: Function 'mmio_w2103' argument 1 names different: declaration 'value' definition 'data'. [funcArgNamesDifferent] mednafen/src/snes/src/ppu/mmio/mmio.hpp:132:23: note: Function 'mmio_w2103' argument 1 names different: declaration 'value' definition 'data'. mednafen/src/snes/src/ppu/mmio/mmio.cpp:30:28: note: Function 'mmio_w2103' argument 1 names different: declaration 'value' definition 'data'. mednafen/src/snes/src/ppu/mmio/mmio.cpp:39:28: style:inconclusive: Function 'mmio_w2104' argument 1 names different: declaration 'value' definition 'data'. [funcArgNamesDifferent] mednafen/src/snes/src/ppu/mmio/mmio.hpp:133:23: note: Function 'mmio_w2104' argument 1 names different: declaration 'value' definition 'data'. mednafen/src/snes/src/ppu/mmio/mmio.cpp:39:28: note: Function 'mmio_w2104' argument 1 names different: declaration 'value' definition 'data'. mednafen/src/snes/src/ppu/render/windows.cpp:4:45: style:inconclusive: Function 'build_window_table' argument 2 names different: declaration 'mainscreen' definition 'screen'. [funcArgNamesDifferent] mednafen/src/snes/src/ppu/render/render.hpp:42:40: note: Function 'build_window_table' argument 2 names different: declaration 'mainscreen' definition 'screen'. mednafen/src/snes/src/ppu/render/windows.cpp:4:45: note: Function 'build_window_table' argument 2 names different: declaration 'mainscreen' definition 'screen'. mednafen/src/snes/src/ppu/render/line.cpp:18:12: style: Variable 'p' can be declared with const [constVariable] mednafen/src/snes/src/ppu/render/line.cpp:53:12: style: Variable 'p' can be declared with const [constVariable] mednafen/src/sound/okiadpcm.h:126:2: warning: Member variable 'OKIADPCM_Encoder::ChipType' is not initialized in the constructor. [uninitMemberVar] mednafen/src/snes/src/ppu/render/oam.cpp:204:12: style: Variable 'pri_tbl' can be declared with const [constVariable] mednafen/src/sound/okiadpcm.h:128:3: performance: Variable 'Accum' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/sound/okiadpcm.h:129:3: performance: Variable 'StepSizeIndex' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/sound/OwlResampler.cpp:47:2: portability: Using memset() on union which contains a floating point number. [memsetClassFloat] mednafen/src/sound/OwlResampler.h:119:7: style:inconclusive: Technically the member function 'Mednafen::OwlResampler::ResetBufResampState' can be const. [functionConst] mednafen/src/sound/OwlResampler.cpp:496:20: note: Technically the member function 'Mednafen::OwlResampler::ResetBufResampState' can be const. mednafen/src/sound/OwlResampler.h:119:7: note: Technically the member function 'Mednafen::OwlResampler::ResetBufResampState' can be const. mednafen/src/sound/OwlResampler.h:122:7: style:inconclusive: Technically the member function 'Mednafen::OwlResampler::GetRatio' can be const. [functionConst] mednafen/src/sound/OwlResampler.h:128:21: style:inconclusive: Technically the member function 'Mednafen::OwlResampler::GetSIMDType' can be const. [functionConst] mednafen/src/sound/OwlResampler.cpp:590:9: style: Redundant initialization for 'ratio'. The initialized value is overwritten before it is read. [redundantInitialization] mednafen/src/sound/OwlResampler.cpp:567:16: note: ratio is initialized mednafen/src/sound/OwlResampler.cpp:590:9: note: ratio is overwritten mednafen/src/sound/OwlResampler.cpp:569:10: style: The scope of the variable 'findo' can be reduced. [variableScope] mednafen/src/sound/OwlResampler.cpp:268:33: style: Parameter 'wave' can be declared with const [constParameter] mednafen/src/sound/OwlResampler.cpp:268:46: style: Parameter 'coeffs' can be declared with const [constParameter] mednafen/src/ss/cart/ar4mp.cpp:131:2: error: Non-local variable 'ExtRAM' will use pointer to local variable 'new_ExtRAM'. [danglingLifetime] mednafen/src/ss/cart/ar4mp.cpp:131:25: note: Raw pointer to smart pointer created here. mednafen/src/ss/cart/ar4mp.cpp:128:28: note: Variable created here. mednafen/src/ss/cart/ar4mp.cpp:131:2: note: Non-local variable 'ExtRAM' will use pointer to local variable 'new_ExtRAM'. mednafen/src/ss/cart.h:62:7: performance:inconclusive: Technically the member function 'MDFN_IEN_SS::CartInfo::CS01_SetRW8W16' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/ss/cart.cpp:97:16: note: Technically the member function 'MDFN_IEN_SS::CartInfo::CS01_SetRW8W16' can be static (but you may consider moving to unnamed namespace). mednafen/src/ss/cart.h:62:7: note: Technically the member function 'MDFN_IEN_SS::CartInfo::CS01_SetRW8W16' can be static (but you may consider moving to unnamed namespace). mednafen/src/ss/cart.h:63:7: performance:inconclusive: Technically the member function 'MDFN_IEN_SS::CartInfo::CS2M_SetRW8W16' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/ss/cart.cpp:114:16: note: Technically the member function 'MDFN_IEN_SS::CartInfo::CS2M_SetRW8W16' can be static (but you may consider moving to unnamed namespace). mednafen/src/ss/cart.h:63:7: note: Technically the member function 'MDFN_IEN_SS::CartInfo::CS2M_SetRW8W16' can be static (but you may consider moving to unnamed namespace). mednafen/src/ss/ss.h:102:18: style: Condition 'ss_dbg_mask&which' is always false [knownConditionTrueFalse] mednafen/src/ss/input/3dpad.cpp:28:17: warning: Member variable 'IODevice_3DPad::tl' is not initialized in the constructor. [uninitMemberVar] mednafen/src/ss/input/gun.cpp:168:33: style:inconclusive: Boolean expression 'cur_ossb' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/ss/input/gun.cpp:28:15: warning: Member variable 'IODevice_Gun::prev_ossb' is not initialized in the constructor. [uninitMemberVar] mednafen/src/ss/input/gun.cpp:28:15: warning: Member variable 'IODevice_Gun::chair_r' is not initialized in the constructor. [uninitMemberVar] mednafen/src/ss/input/gun.cpp:28:15: warning: Member variable 'IODevice_Gun::chair_g' is not initialized in the constructor. [uninitMemberVar] mednafen/src/ss/input/gun.cpp:28:15: warning: Member variable 'IODevice_Gun::chair_b' is not initialized in the constructor. [uninitMemberVar] mednafen/src/ss/input/jpkeyboard.cpp:42:22: warning: Member variable 'IODevice_JPKeyboard::tl' is not initialized in the constructor. [uninitMemberVar] mednafen/src/ss/input/keyboard.cpp:50:20: warning: Member variable 'IODevice_Keyboard::tl' is not initialized in the constructor. [uninitMemberVar] mednafen/src/ss/input/mouse.cpp:28:17: warning: Member variable 'IODevice_Mouse::tl' is not initialized in the constructor. [uninitMemberVar] mednafen/src/ss/input/mission.cpp:34:19: warning: Member variable 'IODevice_Mission::tl' is not initialized in the constructor. [uninitMemberVar] mednafen/src/ss/input/mission.cpp:34:19: warning: Member variable 'IODevice_Mission::afphase' is not initialized in the constructor. [uninitMemberVar] mednafen/src/ss/input/mission.h:31:2: style: Class 'IODevice_Mission' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/ss/input/wheel.cpp:28:17: warning: Member variable 'IODevice_Wheel::tl' is not initialized in the constructor. [uninitMemberVar] mednafen/src/ss/input/multitap.cpp:28:20: warning: Member variable 'IODevice_Multitap::devices' is not initialized in the constructor. [uninitMemberVar] mednafen/src/ss/input/multitap.cpp:28:20: warning: Member variable 'IODevice_Multitap::tl' is not initialized in the constructor. [uninitMemberVar] mednafen/src/ss/notes/gen_dsp.cpp:18:3: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] mednafen/src/ss/notes/gen_dsp.cpp:52:3: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] mednafen/src/ss/notes/gen_dsp.cpp:67:3: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] mednafen/src/ss/notes/gen_dsp.cpp:82:3: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] mednafen/src/ss/notes/gen_dsp.cpp:92:3: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] mednafen/src/ss/notes/gen_dsp.cpp:34:22: style: Variable 'd1_s' is assigned a value that is never used. [unreadVariable] mednafen/src/ss/scu_dsp_gen.cpp:172:34: error: Signed integer overflow for expression 'new_C<<31'. [integerOverflow] mednafen/src/ss/scu_dsp_gen.cpp:169:29: note: Assignment 'new_C=ALU.L&0x1', assigned value is 1 mednafen/src/ss/scu_dsp_gen.cpp:172:34: note: Integer overflow mednafen/src/sound/SwiftResampler.h:49:21: style:inconclusive: Technically the member function 'Mednafen::SwiftResampler::GetSIMDType' can be const. [functionConst] mednafen/src/sound/SwiftResampler.cpp:383:9: style: Redundant initialization for 'ratio'. The initialized value is overwritten before it is read. [redundantInitialization] mednafen/src/sound/SwiftResampler.cpp:227:15: note: ratio is initialized mednafen/src/sound/SwiftResampler.cpp:383:9: note: ratio is overwritten mednafen/src/sound/SwiftResampler.cpp:448:17: warning:inconclusive: Found suspicious operator '<' [constStatement] mednafen/src/ss/vdp1_common.h:563:6: style:inconclusive: Boolean expression 'clipped' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/ss/vdp1_common.h:563:6: style:inconclusive: Boolean expression 'transparent' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean] mednafen/src/ss/vdp1_common.h:569:4: style:inconclusive: Boolean expression 'clipped' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/ss/vdp1_common.h:569:4: style:inconclusive: Boolean expression 'transparent' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean] mednafen/src/ss/vdp1_common.h:590:6: style:inconclusive: Boolean expression 'clipped' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/ss/vdp1_common.h:590:6: style:inconclusive: Boolean expression 'transparent' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean] mednafen/src/ss/vdp1_common.h:596:4: style:inconclusive: Boolean expression 'clipped' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/ss/vdp1_common.h:596:4: style:inconclusive: Boolean expression 'transparent' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean] mednafen/src/ss/vdp1.cpp:515:29: style:inconclusive: Boolean expression 'p0.y==p1.y' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/ss/vdp1.cpp:515:52: style:inconclusive: Boolean expression 'p0.x=0' is always true [knownConditionTrueFalse] mednafen/src/ss/vdp1_common.h:99:24: note: Assignment 'error[cc]=length-(length*2-((dg<0)?1:0))', assigned value is greater than -1 mednafen/src/ss/vdp1_common.h:100:18: note: Condition 'error[cc]>=0' is always true mednafen/src/ss/smpc.cpp:252:39: style:inconclusive: Boolean expression '!(IOBusState[0]&0x40)' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/ss/smpc.cpp:252:82: style:inconclusive: Boolean expression '!(IOBusState[1]&0x40)' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/ss/smpc.cpp:252:39: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] mednafen/src/ss/smpc.cpp:407:28: style:inconclusive: Function 'SMPC_Init' argument 1 names different: declaration 'area_code' definition 'area_code_arg'. [funcArgNamesDifferent] mednafen/src/ss/smpc.h:57:28: note: Function 'SMPC_Init' argument 1 names different: declaration 'area_code' definition 'area_code_arg'. mednafen/src/ss/smpc.cpp:407:28: note: Function 'SMPC_Init' argument 1 names different: declaration 'area_code' definition 'area_code_arg'. mednafen/src/ss/smpc.cpp:407:55: style:inconclusive: Function 'SMPC_Init' argument 2 names different: declaration 'master_clock' definition 'master_clock_arg'. [funcArgNamesDifferent] mednafen/src/ss/smpc.h:57:51: note: Function 'SMPC_Init' argument 2 names different: declaration 'master_clock' definition 'master_clock_arg'. mednafen/src/ss/smpc.cpp:407:55: note: Function 'SMPC_Init' argument 2 names different: declaration 'master_clock' definition 'master_clock_arg'. mednafen/src/ss/ss.cpp:916:18: error: The address of local variable 'buf' is accessed at non-zero index. [objectIndex] mednafen/src/ss/ss.cpp:1031:20: note: Address of variable taken here. mednafen/src/ss/ss.cpp:1031:20: note: Calling function 'IsSaturnDisc', 1st argument '&buf[0]' value is lifetime=buf mednafen/src/ss/ss.cpp:916:18: note: The address of local variable 'buf' is accessed at non-zero index. mednafen/src/ss/ss.cpp:916:18: error: The address of local variable 'buf' is accessed at non-zero index. [objectIndex] mednafen/src/ss/ss.cpp:1536:22: note: Address of variable taken here. mednafen/src/ss/ss.cpp:1536:22: note: Calling function 'IsSaturnDisc', 1st argument '&buf[0]' value is lifetime=buf mednafen/src/ss/ss.cpp:916:18: note: The address of local variable 'buf' is accessed at non-zero index. mednafen/src/ss/ss.cpp:1782:7: style:inconclusive: Technically the member function 'MDFN_IEN_SS::EventsPacker::Restore' can be const. [functionConst] mednafen/src/ss/ss.cpp:1802:27: note: Technically the member function 'MDFN_IEN_SS::EventsPacker::Restore' can be const. mednafen/src/ss/ss.cpp:1782:7: note: Technically the member function 'MDFN_IEN_SS::EventsPacker::Restore' can be const. mednafen/src/ss/ss.cpp:718:5: style: The if condition is the same as the previous if condition [duplicateCondition] mednafen/src/ss/ss.cpp:712:5: note: First condition mednafen/src/ss/ss.cpp:718:5: note: Second condition mednafen/src/ss/ss.cpp:1039:5: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] mednafen/src/ss/ss.cpp:1051:3: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] mednafen/src/ss/ss.cpp:1172:4: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] mednafen/src/ss/ss.cpp:1208:4: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] mednafen/src/ss/ss.cpp:1314:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] mednafen/src/ss/ss.cpp:1517:20: style: Consider using std::any_of, std::all_of, std::none_of, or std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] mednafen/src/ss/ss.cpp:1000:14: style: struct member 'Anonymous42::str' is never used. [unusedStructMember] mednafen/src/ss/vdp2.cpp:330:20: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] mednafen/src/ss/vdp2.cpp:982:5: style: The if condition is the same as the previous if condition [duplicateCondition] mednafen/src/ss/vdp2.cpp:970:5: note: First condition mednafen/src/ss/vdp2.cpp:982:5: note: Second condition mednafen/src/ss/vdp2.cpp:1037:22: style: The scope of the variable 'tab' can be reduced. [variableScope] mednafen/src/string/string.cpp:480:17: style:inconclusive: Boolean expression '!new_in_ws' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/string/string.cpp:487:32: style:inconclusive: Boolean expression 'new_in_quote' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/string/string.cpp:490:26: style:inconclusive: Boolean expression 'new_in_ws' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/string/string.cpp:478:46: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] mednafen/src/string/string.cpp:480:17: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] mednafen/src/string/string.cpp:413:49: style:inconclusive: Function 'MDFN_strunescape' argument 1 names different: declaration 's' definition 'str'. [funcArgNamesDifferent] mednafen/src/string/string.h:73:73: note: Function 'MDFN_strunescape' argument 1 names different: declaration 's' definition 'str'. mednafen/src/string/string.cpp:413:49: note: Function 'MDFN_strunescape' argument 1 names different: declaration 's' definition 'str'. mednafen/src/string/string.cpp:422:47: style:inconclusive: Function 'MDFN_strescape' argument 1 names different: declaration 's' definition 'str'. [funcArgNamesDifferent] mednafen/src/string/string.h:75:71: note: Function 'MDFN_strescape' argument 1 names different: declaration 's' definition 'str'. mednafen/src/string/string.cpp:422:47: note: Function 'MDFN_strescape' argument 1 names different: declaration 's' definition 'str'. mednafen/src/string/string.cpp:202:6: style: Consider using std::replace_if algorithm instead of a raw loop. [useStlAlgorithm] mednafen/src/string/string.cpp:226:5: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] mednafen/src/string/string.cpp:250:5: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] mednafen/src/string/string.cpp:317:14: style: Unused variable: ret [unusedVariable] mednafen/src/time/Time_POSIX.cpp:79:12: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] mednafen/src/time/Time_POSIX.cpp:108:12: portability: Non reentrant function 'gmtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'gmtime_r'. [prohibitedgmtimeCalled] mednafen/src/time/Time_POSIX.cpp:156:3: error: Exception thrown in function declared not to throw exceptions. [throwInNoexceptFunction] mednafen/src/time/Time_Win32.cpp:436:12: error: Array 'tzperiods[6]' accessed at index 7, which is out of bounds. [arrayIndexOutOfBounds] mednafen/src/time/Time_Win32.cpp:436:38: error: Array 'tzperiods[6]' accessed at index 6, which is out of bounds. [arrayIndexOutOfBounds] mednafen/src/time/Time_Win32.cpp:443:22: error: Array 'tzperiods[6]' accessed at index 7, which is out of bounds. [arrayIndexOutOfBounds] mednafen/src/tremor/os_types.h:37:0: error: #error "ERROR" [preprocessorErrorDirective] mednafen/src/testsexp.cpp:737:4: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] mednafen/src/testsexp.cpp:130:6: style: The scope of the variable 'quality' can be reduced. [variableScope] mednafen/src/trio/triostr.c:153:9: style: struct member '_trio_string_t::content' is never used. [unusedStructMember] mednafen/src/trio/triostr.c:154:10: style: struct member '_trio_string_t::length' is never used. [unusedStructMember] mednafen/src/trio/triostr.c:155:10: style: struct member '_trio_string_t::allocated' is never used. [unusedStructMember] mednafen/src/vb/debug.cpp:297:29: error: Uninitialized struct member: tmp.logical [uninitStructMember] mednafen/src/vb/debug.cpp:299:30: error: Uninitialized struct member: tmp.logical [uninitStructMember] mednafen/src/vb/debug.cpp:301:27: error: Uninitialized struct member: tmp.logical [uninitStructMember] mednafen/src/vb/debug.cpp:49:14: style: struct member '__VB_BPOINT::logical' is never used. [unusedStructMember] mednafen/src/vb/debug.cpp:276:35: style: Unused variable: bpit [unusedVariable] mednafen/src/vb/debug.cpp:202:26: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/vb/debug.cpp:247:65: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/vb/input.cpp:69:38: style: Parameter 'timestamp' can be declared with const [constParameter] mednafen/src/vb/input.cpp:110:38: style: Parameter 'timestamp' can be declared with const [constParameter] mednafen/src/trio/trio.c:810:9: style: union member 'Anonymous1::errorNumber' is never used. [unusedStructMember] mednafen/src/trio/trio.c:867:9: style: union member 'Anonymous4::cached' is never used. [unusedStructMember] mednafen/src/trio/trio.c:4472:17: error: va_list 'args' used before va_start() was called. [va_list_usedBeforeStarted] mednafen/src/trio/trio.c:4473:64: error: va_list 'args' used before va_start() was called. [va_list_usedBeforeStarted] mednafen/src/trio/trio.c:4475:15: error: va_list 'args' used before va_start() was called. [va_list_usedBeforeStarted] mednafen/src/trio/trio.c:4525:64: error: va_list 'unused' used before va_start() was called. [va_list_usedBeforeStarted] mednafen/src/trio/trio.c:4557:17: error: va_list 'args' used before va_start() was called. [va_list_usedBeforeStarted] mednafen/src/trio/trio.c:4559:41: error: va_list 'args' used before va_start() was called. [va_list_usedBeforeStarted] mednafen/src/trio/trio.c:4562:15: error: va_list 'args' used before va_start() was called. [va_list_usedBeforeStarted] mednafen/src/trio/trio.c:4619:41: error: va_list 'unused' used before va_start() was called. [va_list_usedBeforeStarted] mednafen/src/vb/vsu.h:44:8: style:inconclusive: Technically the member function 'VSU::PeekWave' can be const. [functionConst] mednafen/src/vb/vsu.cpp:570:12: note: Technically the member function 'VSU::PeekWave' can be const. mednafen/src/vb/vsu.h:44:8: note: Technically the member function 'VSU::PeekWave' can be const. mednafen/src/vb/vsu.h:47:8: style:inconclusive: Technically the member function 'VSU::PeekModWave' can be const. [functionConst] mednafen/src/vb/vsu.cpp:588:12: note: Technically the member function 'VSU::PeekModWave' can be const. mednafen/src/vb/vsu.h:47:8: note: Technically the member function 'VSU::PeekModWave' can be const. mednafen/src/vb/vsu.h:52:7: style:inconclusive: Technically the member function 'VSU::CalcCurrentOutput' can be const. [functionConst] mednafen/src/vb/vsu.cpp:215:18: note: Technically the member function 'VSU::CalcCurrentOutput' can be const. mednafen/src/vb/vsu.h:52:7: note: Technically the member function 'VSU::CalcCurrentOutput' can be const. mednafen/src/video/Deinterlacer_Simple.h:32:2: style: Class 'Deinterlacer_Simple' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/video/Deinterlacer_Blend.h:32:2: style: Class 'Deinterlacer_Blend' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/vb/vip.cpp:110:56: style:inconclusive: Boolean expression 'cprunique' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/vb/vip.cpp:475:42: style: Parameter 'timestamp' can be declared with const [constParameter] mednafen/src/video/Deinterlacer_Blend.cpp:164:45: warning: The address of local variable 'lb' might be accessed at non-zero index. [objectIndex] mednafen/src/video/Deinterlacer_Blend.cpp:158:16: note: Address of variable taken here. mednafen/src/video/Deinterlacer_Blend.cpp:164:45: note: The address of local variable 'lb' might be accessed at non-zero index. mednafen/src/video/Deinterlacer_Blend.cpp:29:45: style:inconclusive: Function 'Deinterlacer_Blend' argument 1 names different: declaration 'gc' definition 'rg'. [funcArgNamesDifferent] mednafen/src/video/Deinterlacer_Blend.h:32:26: note: Function 'Deinterlacer_Blend' argument 1 names different: declaration 'gc' definition 'rg'. mednafen/src/video/Deinterlacer_Blend.cpp:29:45: note: Function 'Deinterlacer_Blend' argument 1 names different: declaration 'gc' definition 'rg'. mednafen/src/video/Deinterlacer_Blend.cpp:198:68: style:inconclusive: Function 'Process' argument 2 names different: declaration 'DisplayRect' definition 'dr'. [funcArgNamesDifferent] mednafen/src/video/Deinterlacer_Blend.h:35:57: note: Function 'Process' argument 2 names different: declaration 'DisplayRect' definition 'dr'. mednafen/src/video/Deinterlacer_Blend.cpp:198:68: note: Function 'Process' argument 2 names different: declaration 'DisplayRect' definition 'dr'. mednafen/src/video/png.cpp:223:3: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] mednafen/src/video/png.cpp:225:3: note: Found duplicate branches for 'if' and 'else'. mednafen/src/video/png.cpp:223:3: note: Found duplicate branches for 'if' and 'else'. mednafen/src/video/png.cpp:82:8: style: The scope of the variable 'r' can be reduced. [variableScope] mednafen/src/video/png.cpp:82:11: style: The scope of the variable 'g' can be reduced. [variableScope] mednafen/src/video/png.cpp:82:14: style: The scope of the variable 'b' can be reduced. [variableScope] mednafen/src/video/png.cpp:119:87: style:inconclusive: Function 'WriteIt' argument 3 names different: declaration 'rect' definition 'rect_in'. [funcArgNamesDifferent] mednafen/src/video/png.h:22:78: note: Function 'WriteIt' argument 3 names different: declaration 'rect' definition 'rect_in'. mednafen/src/video/png.cpp:119:87: note: Function 'WriteIt' argument 3 names different: declaration 'rect' definition 'rect_in'. mednafen/src/video/primitives.cpp:313:24: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/video/surface.cpp:37:2: performance: Variable 'w' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/video/surface.cpp:38:2: performance: Variable 'h' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/video/surface.h:114:7: style:inconclusive: Technically the member function 'Mednafen::MDFN_PixelFormat::operator==' can be const. [functionConst] mednafen/src/video/surface.h:119:7: style:inconclusive: Technically the member function 'Mednafen::MDFN_PixelFormat::operator==' can be const. [functionConst] mednafen/src/video/surface.h:124:7: style:inconclusive: Technically the member function 'Mednafen::MDFN_PixelFormat::operator!=' can be const. [functionConst] mednafen/src/video/surface.h:71:9: style: Class 'MDFN_PixelFormat' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mednafen/src/video/surface.cpp:124:18: style: C-style pointer casting [cstyleCast] mednafen/src/video/surface.cpp:232:47: style: C-style pointer casting [cstyleCast] mednafen/src/video/surface.cpp:271:52: style: C-style pointer casting [cstyleCast] mednafen/src/video/surface.cpp:205:54: style:inconclusive: Function 'SetFormat' argument 1 names different: declaration 'new_format' definition 'nf'. [funcArgNamesDifferent] mednafen/src/video/surface.h:343:41: note: Function 'SetFormat' argument 1 names different: declaration 'new_format' definition 'nf'. mednafen/src/video/surface.cpp:205:54: note: Function 'SetFormat' argument 1 names different: declaration 'new_format' definition 'nf'. mednafen/src/video/video.cpp:52:3: style: Instance of 'PNGWrite' object is destroyed immediately. [unusedScopedObject] mednafen/src/wswan/dis/disasm.h:155:10: style:inconclusive: Technically the member function 'disassembler::peek_byte' can be const. [functionConst] mednafen/src/wswan/debug.cpp:346:6: style: Redundant initialization for 'mis'. The initialized value is overwritten before it is read. [redundantInitialization] mednafen/src/wswan/debug.cpp:345:13: note: mis is initialized mednafen/src/wswan/debug.cpp:346:6: note: mis is overwritten mednafen/src/wswan/debug.cpp:76:69: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/wswan/debug.cpp:98:71: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/wswan/debug.cpp:115:73: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/wswan/debug.cpp:137:75: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/wswan/debug.cpp:154:66: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] mednafen/src/wswan/dis/dis_decode.cpp:14:3: performance: Variable 'extend8b' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/wswan/dis/dis_decode.cpp:15:3: performance: Variable 'seg_override' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/wswan/dis/dis_decode.cpp:20:3: performance: Variable 'modrm' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/wswan/dis/dis_decode.cpp:20:11: performance: Variable 'mod' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/wswan/dis/dis_decode.cpp:20:17: performance: Variable 'nnn' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/wswan/dis/dis_decode.cpp:20:23: performance: Variable 'rm' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/wswan/dis/dis_decode.cpp:21:3: performance: Variable 'sib' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/wswan/dis/dis_decode.cpp:21:9: performance: Variable 'scale' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/wswan/dis/dis_decode.cpp:21:17: performance: Variable 'index' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/wswan/dis/dis_decode.cpp:21:25: performance: Variable 'base' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/wswan/dis/dis_decode.cpp:161:20: style: C-style pointer casting [cstyleCast] mednafen/src/wswan/dis/dis_decode.cpp:165:20: style: C-style pointer casting [cstyleCast] mednafen/src/wswan/dis/dis_decode.cpp:169:20: style: C-style pointer casting [cstyleCast] mednafen/src/wswan/dis/dis_decode.cpp:173:20: style: C-style pointer casting [cstyleCast] mednafen/src/wswan/dis/dis_decode.cpp:177:20: style: C-style pointer casting [cstyleCast] mednafen/src/wswan/dis/dis_decode.cpp:202:26: style: C-style pointer casting [cstyleCast] mednafen/src/wswan/dis/dis_decode.cpp:214:40: style: C-style pointer casting [cstyleCast] mednafen/src/wswan/dis/resolve.cpp:68:44: style:inconclusive: Function 'print_datasize' argument 1 names different: declaration 'mode' definition 'size'. [funcArgNamesDifferent] mednafen/src/wswan/dis/disasm.h:186:33: note: Function 'print_datasize' argument 1 names different: declaration 'mode' definition 'size'. mednafen/src/wswan/dis/resolve.cpp:68:44: note: Function 'print_datasize' argument 1 names different: declaration 'mode' definition 'size'. mednafen/src/wswan/dis/disasm.h:108:3: warning: Member variable 'disassembler::instruction' is not initialized in the constructor. [uninitMemberVar] mednafen/src/wswan/dis/disasm.h:108:3: warning: Member variable 'disassembler::disbufptr' is not initialized in the constructor. [uninitMemberVar] mednafen/src/wswan/dis/disasm.h:108:3: warning: Member variable 'disassembler::resolve_modrm' is not initialized in the constructor. [uninitMemberVar] mednafen/src/wswan/gfx.cpp:504:48: error: syntax error [syntaxError] mednafen/src/wswan/main.cpp:303:6: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] mednafen/src/wswan/rtc.cpp:66:2: performance: Variable 'sec' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/wswan/rtc.cpp:67:2: performance: Variable 'min' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/wswan/rtc.cpp:68:2: performance: Variable 'hour' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/wswan/rtc.cpp:69:2: performance: Variable 'wday' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/wswan/rtc.cpp:70:2: performance: Variable 'mday' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/wswan/rtc.cpp:71:2: performance: Variable 'mon' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/wswan/rtc.cpp:72:2: performance: Variable 'year' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mednafen/src/wswan/rtc.cpp:53:7: performance:inconclusive: Technically the member function 'MDFN_IEN_WSWAN::GenericRTC::BCDInc' can be static (but you may consider moving to unnamed namespace). [functionStatic] mednafen/src/wswan/rtc.cpp:75:18: note: Technically the member function 'MDFN_IEN_WSWAN::GenericRTC::BCDInc' can be static (but you may consider moving to unnamed namespace). mednafen/src/wswan/rtc.cpp:53:7: note: Technically the member function 'MDFN_IEN_WSWAN::GenericRTC::BCDInc' can be static (but you may consider moving to unnamed namespace). mednafen/src/wswan/memory.cpp:438:44: style:inconclusive: Function 'WSwan_writemem20' argument 1 names different: declaration 'address' definition 'A'. [funcArgNamesDifferent] mednafen/src/wswan/memory.h:13:44: note: Function 'WSwan_writemem20' argument 1 names different: declaration 'address' definition 'A'. mednafen/src/wswan/memory.cpp:438:44: note: Function 'WSwan_writemem20' argument 1 names different: declaration 'address' definition 'A'. mednafen/src/wswan/memory.cpp:438:53: style:inconclusive: Function 'WSwan_writemem20' argument 2 names different: declaration 'data' definition 'V'. [funcArgNamesDifferent] mednafen/src/wswan/memory.h:13:58: note: Function 'WSwan_writemem20' argument 2 names different: declaration 'data' definition 'V'. mednafen/src/wswan/memory.cpp:438:53: note: Function 'WSwan_writemem20' argument 2 names different: declaration 'data' definition 'V'. mednafen/src/wswan/memory.cpp:458:47: style:inconclusive: Function 'WSwan_writemem20_WW' argument 1 names different: declaration 'address' definition 'A'. [funcArgNamesDifferent] mednafen/src/wswan/memory.h:16:47: note: Function 'WSwan_writemem20_WW' argument 1 names different: declaration 'address' definition 'A'. mednafen/src/wswan/memory.cpp:458:47: note: Function 'WSwan_writemem20_WW' argument 1 names different: declaration 'address' definition 'A'. mednafen/src/wswan/memory.cpp:458:56: style:inconclusive: Function 'WSwan_writemem20_WW' argument 2 names different: declaration 'data' definition 'V'. [funcArgNamesDifferent] mednafen/src/wswan/memory.h:16:61: note: Function 'WSwan_writemem20_WW' argument 2 names different: declaration 'data' definition 'V'. mednafen/src/wswan/memory.cpp:458:56: note: Function 'WSwan_writemem20_WW' argument 2 names different: declaration 'data' definition 'V'. mednafen/src/wswan/memory.cpp:738:65: style:inconclusive: Function 'WSwan_MemoryInit' argument 4 names different: declaration 'IsWW' definition 'IsWW_arg'. [funcArgNamesDifferent] mednafen/src/wswan/memory.h:18:65: note: Function 'WSwan_MemoryInit' argument 4 names different: declaration 'IsWW' definition 'IsWW_arg'. mednafen/src/wswan/memory.cpp:738:65: note: Function 'WSwan_MemoryInit' argument 4 names different: declaration 'IsWW' definition 'IsWW_arg'. mednafen/tests/apple2/bintodsk.cpp:27:3: error: Resource leak: ofp [resourceLeak] mednafen/tests/apple2/bintodsk.cpp:33:3: error: Resource leak: ifp [resourceLeak] mednafen/tests/apple2/bintodsk.cpp:42:3: error: Resource leak: ifp [resourceLeak] mednafen/tests/apple2/bintodsk.cpp:42:3: error: Resource leak: ofp [resourceLeak] mednafen/tests/apple2/bintodsk.cpp:48:3: error: Resource leak: ifp [resourceLeak] mednafen/tests/apple2/bintodsk.cpp:48:3: error: Resource leak: ofp [resourceLeak] mednafen/tests/apple2/gencrctab.cpp:7:11: style: The scope of the variable 'r' can be reduced. [variableScope] mednafen/tests/apple2/gencrctab.cpp:22:32: portability: Shifting signed 64-bit value by 63 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/tests/apple2/gencrctab.cpp:7:13: style: Variable 'r' is assigned a value that is never used. [unreadVariable] mednafen/tests/pce/decimal/gen-results.cpp:17:8: style: Variable 'ftab' can be declared with const [constVariable] mednafen/tests/pce/decimal/gen-results.cpp:68:8: style: Variable 'ftab' can be declared with const [constVariable] mednafen/src/wswan/v30mz.cpp:825:113: style: Variable 'I.pc' is reassigned a value before the old one has been used. [redundantAssignment] mednafen/src/wswan/v30mz.cpp:825:61: note: I.pc is assigned mednafen/src/wswan/v30mz.cpp:825:113: note: I.pc is overwritten mednafen/src/ss/cdb.cpp:771:27: style: Variable 'Partitions[pnum].LastBuf' is reassigned a value before the old one has been used. [redundantAssignment] mednafen/src/ss/cdb.cpp:761:28: note: Partitions[pnum].LastBuf is assigned mednafen/src/ss/cdb.cpp:771:27: note: Partitions[pnum].LastBuf is overwritten mednafen/src/ss/cdb.cpp:3195:73: style: Checking if unsigned expression 'NewGetSecLen' is less than zero. [unsignedLessThanZero] mednafen/src/ss/cdb.cpp:3196:73: style: Checking if unsigned expression 'NewPutSecLen' is less than zero. [unsignedLessThanZero] mednafen/src/ss/cdb.cpp:636:31: style: Parameter 'subpw' can be declared with const [constParameter] mednafen/src/ss/vdp2_render.cpp:1224:38: style:inconclusive: Boolean expression 'xmet[0]' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/ss/vdp2_render.cpp:1225:38: style:inconclusive: Boolean expression 'xmet[1]' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/ss/vdp2_render.cpp:1230:27: style:inconclusive: Boolean expression 'wval[0]' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/ss/vdp2_render.cpp:1230:37: style:inconclusive: Boolean expression 'swval' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/ss/vdp2_render.cpp:1232:27: style:inconclusive: Boolean expression 'wval[0]' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean] mednafen/src/ss/vdp2_render.cpp:1232:37: style:inconclusive: Boolean expression 'swval' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean] mednafen/src/ss/vdp2_render.cpp:1244:41: style:inconclusive: Boolean expression 'x>=Window[0].CurXStart' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/ss/vdp2_render.cpp:1245:41: style:inconclusive: Boolean expression 'x>=Window[1].CurXStart' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/ss/vdp2_render.cpp:1276:41: style:inconclusive: Boolean expression 'x>=Window[0].CurXStart' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/ss/vdp2_render.cpp:1277:41: style:inconclusive: Boolean expression 'x>=Window[1].CurXStart' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/ss/vdp2_render.cpp:1377:46: style:inconclusive: Boolean expression '!(MZCTL&0x1)' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/ss/vdp2_render.cpp:1377:100: style:inconclusive: Boolean expression '!(MZCTL&0x2)' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/ss/vdp2_render.cpp:1405:22: style:inconclusive: Boolean expression 'vcon[0]' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/ss/vdp2_render.cpp:1406:22: style:inconclusive: Boolean expression 'vcon[1]' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/ss/vdp2_render.cpp:2096:26: style:inconclusive: Boolean expression 'cce' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] mednafen/src/ss/vdp2_render.cpp:665:12: error: Array 'RotMapRegs[2][16]' accessed at index RotMapRegs[32][*], which is out of bounds. [arrayIndexOutOfBounds] mednafen/src/ss/vdp2_render.cpp:666:12: error: Array 'RotMapRegs[2][16]' accessed at index RotMapRegs[32][*], which is out of bounds. [arrayIndexOutOfBounds] mednafen/src/ss/vdp2_render.cpp:711:10: error: Array 'XScrollI[4]' accessed at index 6, which is out of bounds. [arrayIndexOutOfBounds] mednafen/src/ss/vdp2_render.cpp:719:17: error: Array 'NBG23_YCounter[2]' accessed at index 4, which is out of bounds. [arrayIndexOutOfBounds] mednafen/src/ss/vdp2_render.cpp:717:26: note: Assignment 'which=(bool)(A&0x4)', assigned value is 4 mednafen/src/ss/vdp2_render.cpp:719:17: note: Array index out of bounds mednafen/src/ss/vdp2_render.cpp:719:35: error: Array 'YScrollI[4]' accessed at index 6, which is out of bounds. [arrayIndexOutOfBounds] mednafen/src/ss/vdp2_render.cpp:717:26: note: Assignment 'which=(bool)(A&0x4)', assigned value is 4 mednafen/src/ss/vdp2_render.cpp:719:35: note: Array index out of bounds mednafen/src/ss/vdp2_render.cpp:1377:46: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] mednafen/src/ss/vdp2_render.cpp:1424:12: style: The if condition is the same as the previous if condition [duplicateCondition] mednafen/src/ss/vdp2_render.cpp:1421:12: note: First condition mednafen/src/ss/vdp2_render.cpp:1424:12: note: Second condition mednafen/src/ss/vdp2_render.cpp:1441:12: style: The if condition is the same as the previous if condition [duplicateCondition] mednafen/src/ss/vdp2_render.cpp:1438:12: note: First condition mednafen/src/ss/vdp2_render.cpp:1441:12: note: Second condition mednafen/src/ss/vdp2_render.cpp:2408:7: style: Redundant initialization for 'pix'. The initialized value is overwritten before it is read. [redundantInitialization] mednafen/src/ss/vdp2_render.cpp:2376:14: note: pix is initialized mednafen/src/ss/vdp2_render.cpp:2408:7: note: pix is overwritten mednafen/src/ss/vdp2_render.cpp:2596:13: warning: Redundant assignment of 'target[0]' to itself. [selfAssignment] mednafen/src/ss/vdp2_render.cpp:3349:45: style:inconclusive: Function 'VDP2REND_StartFrame' argument 1 names different: declaration 'espec' definition 'espec_arg'. [funcArgNamesDifferent] mednafen/src/ss/vdp2_render.h:32:45: note: Function 'VDP2REND_StartFrame' argument 1 names different: declaration 'espec' definition 'espec_arg'. mednafen/src/ss/vdp2_render.cpp:3349:45: note: Function 'VDP2REND_StartFrame' argument 1 names different: declaration 'espec' definition 'espec_arg'. mednafen/src/ss/vdp2_render.cpp:2383:10: style: Variable 'tmp_pix' can be declared with const [constVariable] mednafen/src/ss/vdp2_render.cpp:1146:7: style: Consider using std::fill algorithm instead of a raw loop. [useStlAlgorithm] mednafen/src/ss/vdp2_render.cpp:1149:7: style: Consider using std::fill algorithm instead of a raw loop. [useStlAlgorithm] mednafen/src/ss/vdp2_render.cpp:1152:6: style: Consider using std::fill algorithm instead of a raw loop. [useStlAlgorithm] mednafen/src/ss/vdp2_render.cpp:1163:8: style: Consider using std::fill algorithm instead of a raw loop. [useStlAlgorithm] mednafen/src/gba/arm.cpp:1654:13: style: Variable 'armNextPC' is reassigned a value before the old one has been used. [redundantAssignment] mednafen/src/gba/arm.cpp:1650:14: note: armNextPC is assigned mednafen/src/gba/arm.cpp:1654:13: note: armNextPC is overwritten mednafen/src/gba/arm.cpp:1720:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:1721:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:2799:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:2800:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:2847:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:2848:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:2849:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:2850:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:2851:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:2852:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:2903:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:2904:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:2961:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:2962:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:3019:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:3020:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:3081:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:3099:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:3150:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:3167:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:3184:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:3185:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:3186:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:3187:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:3188:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:3189:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:3190:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:3191:5: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:3877:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:3967:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:4042:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:4119:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:4194:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:4271:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:4388:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:4514:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:4622:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:4734:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:4842:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:4954:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:5053:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:5143:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:5218:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:5295:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:5370:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:5447:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:5564:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:5690:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:5798:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:5910:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:6018:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:6130:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] mednafen/src/gba/arm.cpp:6981:9: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/arm.cpp:7061:9: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/arm.cpp:7228:9: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/arm.cpp:7308:9: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/arm.cpp:7479:9: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/arm.cpp:7559:9: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/arm.cpp:7731:9: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] mednafen/src/gba/arm.cpp:7811:9: style: Variable 'offset' is assigned a value that is never used. [unreadVariable] diff: head mednafen/src/IPSPatcher.cpp:55:7: style: Condition '!patch_size' is always true [knownConditionTrueFalse] mednafen/src/IPSPatcher.cpp:50:6: note: Assuming that condition '!patch_size' is not redundant mednafen/src/IPSPatcher.cpp:55:7: note: Condition '!patch_size' is always true head mednafen/src/drivers/Joystick_SDL.cpp:101:6: style: Condition 'sdl_joy' is always true [knownConditionTrueFalse] 2.6 mednafen/src/drivers/Joystick_SDL.cpp:101:6: style: Condition 'sdl_joy' is always true [knownConditionTrueFalse] mednafen/src/drivers/Joystick_SDL.cpp:57:13: note: Assuming that condition 'sdl_joy==NULL' is not redundant mednafen/src/drivers/Joystick_SDL.cpp:101:6: note: Condition 'sdl_joy' is always true head mednafen/src/lynx/susie.cpp:1171:56: style: Condition 'pixel!=0x0e' is always true [knownConditionTrueFalse] 2.6 mednafen/src/lynx/susie.cpp:1171:56: style: Condition 'pixel!=0x0e' is always true [knownConditionTrueFalse] mednafen/src/lynx/susie.cpp:1169:27: note: Assuming that condition 'pixel!=0x0e' is not redundant mednafen/src/lynx/susie.cpp:1171:56: note: Condition 'pixel!=0x0e' is always true head mednafen/src/md/vdp.cpp:1443:20: style: Condition 's' is always true [knownConditionTrueFalse] 2.6 mednafen/src/md/vdp.cpp:1443:20: style: Condition 's' is always true [knownConditionTrueFalse] mednafen/src/md/vdp.cpp:1435:10: note: Assuming that condition 's==0' is not redundant mednafen/src/md/vdp.cpp:1443:20: note: Condition 's' is always true head mednafen/src/snes_faust/msu1.cpp:322:34: warning: Either the condition '(A&0x3)==0x3' is redundant or there is signed integer overflow for expression '0xFF<>(blip_sample_bits-16)' here. mednafen/src/sound/Blip_Buffer.cpp:410:17: note: s is assigned 'reader_reader_accum>>(blip_sample_bits-16)' here. mednafen/src/sound/Blip_Buffer.cpp:411:28: note: Condition '(short)s!=s' is always false head mednafen/src/sound/Blip_Buffer.cpp:411:28: style: Condition '(short)s!=s' is always false [knownConditionTrueFalse] mednafen/src/sound/Blip_Buffer.cpp:410:17: note: s is assigned 'reader_reader_accum>>(blip_sample_bits-16)' here. mednafen/src/sound/Blip_Buffer.cpp:411:28: note: Condition '(short)s!=s' is always false 2.6 mednafen/src/sound/Blip_Buffer.cpp:422:28: style: Condition '(short)s!=s' is always false [knownConditionTrueFalse] mednafen/src/sound/Blip_Buffer.cpp:421:17: note: s is assigned 'reader_reader_accum>>(blip_sample_bits-16)' here. mednafen/src/sound/Blip_Buffer.cpp:421:17: note: s is assigned 'reader_reader_accum>>(blip_sample_bits-16)' here. mednafen/src/sound/Blip_Buffer.cpp:422:28: note: Condition '(short)s!=s' is always false head mednafen/src/sound/Blip_Buffer.cpp:422:28: style: Condition '(short)s!=s' is always false [knownConditionTrueFalse] mednafen/src/sound/Blip_Buffer.cpp:421:17: note: s is assigned 'reader_reader_accum>>(blip_sample_bits-16)' here. mednafen/src/sound/Blip_Buffer.cpp:422:28: note: Condition '(short)s!=s' is always false head mednafen/src/ss/cart/ar4mp.cpp:131:2: error: Non-local variable 'ExtRAM' will use pointer to local variable 'new_ExtRAM'. [danglingLifetime] mednafen/src/ss/cart/ar4mp.cpp:131:25: note: Raw pointer to smart pointer created here. mednafen/src/ss/cart/ar4mp.cpp:128:28: note: Variable created here. mednafen/src/ss/cart/ar4mp.cpp:131:2: note: Non-local variable 'ExtRAM' will use pointer to local variable 'new_ExtRAM'. head plural.c:1416:15: style: Condition 'yyn==0' is always true [knownConditionTrueFalse] plural.c:1413:16: note: Assignment 'yyn=yytable[yyn]', assigned value is greater than -1 plural.c:1414:11: note: Assuming that condition 'yyn<=0' is not redundant plural.c:1416:15: note: Condition 'yyn==0' is always true DONE