2022-06-23 13:40 ftp://ftp.de.debian.org/debian/pool/main/m/mediainfo/mediainfo_22.03.orig.tar.gz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j1 platform: Linux-5.4.0-120-generic-x86_64-with-glibc2.29 python: 3.8.10 client-version: 1.3.24 compiler: g++ (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0 cppcheck: head 2.8 head-info: f1212e6 (2022-06-22 21:22:04 +0200) count: 104 104 elapsed-time: 4.6 5.3 head-timing-info: Tokenizer::simplifyTokens1: 0.905034s (avg. 0.0125699s - 72 result(s)) Tokenizer::simplifyTokens1::ValueFlow: 0.379599s (avg. 0.00744312s - 51 result(s)) Tokenizer::simplifyTokens1::createSymbolDatabase: 0.31431s (avg. 0.00616294s - 51 result(s)) Tokenizer::createTokens: 0.145668s (avg. 0.00196849s - 74 result(s)) Check function usage::runChecks: 0.082184s (avg. 0.00161145s - 51 result(s)) Overall time: 2.08326s old-timing-info: Tokenizer::simplifyTokens1: 1.05259s (avg. 0.0146194s - 72 result(s)) Tokenizer::simplifyTokens1::ValueFlow: 0.409782s (avg. 0.00803494s - 51 result(s)) Tokenizer::simplifyTokens1::createSymbolDatabase: 0.387034s (avg. 0.0075889s - 51 result(s)) Tokenizer::createTokens: 0.157986s (avg. 0.00213495s - 74 result(s)) Check function usage::runChecks: 0.102389s (avg. 0.00200763s - 51 result(s)) Overall time: 2.3996s head results: MediaInfo/Source/CLI/CLI_Main.cpp:78:54: style: C-style pointer casting [cstyleCast] MediaInfo/Source/CLI/CLI_Main.cpp:79:56: style: C-style pointer casting [cstyleCast] MediaInfo/Source/CLI/CLI_Main.cpp:90:166: style: C-style pointer casting [cstyleCast] MediaInfo/Source/CLI/CLI_Main.cpp:133:82: style: C-style pointer casting [cstyleCast] MediaInfo/Source/CLI/CLI_Main.cpp:148:22: style: C-style pointer casting [cstyleCast] MediaInfo/Source/CLI/CommandLine_Parser.cpp:45:17: style:inconclusive: Function 'Parse' argument 1 names different: declaration 'I' definition 'MI'. [funcArgNamesDifferent] MediaInfo/Source/CLI/CommandLine_Parser.h:21:17: note: Function 'Parse' argument 1 names different: declaration 'I' definition 'MI'. MediaInfo/Source/CLI/CommandLine_Parser.cpp:45:17: note: Function 'Parse' argument 1 names different: declaration 'I' definition 'MI'. MediaInfo/Source/Common/Core.h:85:13: style:inconclusive: Technically the member function 'Core::Kind_Get' can be const. [functionConst] MediaInfo/Source/Common/Core.cpp:430:18: note: Technically the member function 'Core::Kind_Get' can be const. MediaInfo/Source/Common/Core.h:85:13: note: Technically the member function 'Core::Kind_Get' can be const. MediaInfo/Source/Common/Core.h:94:12: performance:inconclusive: Technically the member function 'Core::Parameters' can be static (but you may consider moving to unnamed namespace). [functionStatic] MediaInfo/Source/Common/Core.cpp:484:14: note: Technically the member function 'Core::Parameters' can be static (but you may consider moving to unnamed namespace). MediaInfo/Source/Common/Core.h:94:12: note: Technically the member function 'Core::Parameters' can be static (but you may consider moving to unnamed namespace). MediaInfo/Source/Common/Core.h:95:12: performance:inconclusive: Technically the member function 'Core::StreamName' can be static (but you may consider moving to unnamed namespace). [functionStatic] MediaInfo/Source/Common/Core.cpp:471:14: note: Technically the member function 'Core::StreamName' can be static (but you may consider moving to unnamed namespace). MediaInfo/Source/Common/Core.h:95:12: note: Technically the member function 'Core::StreamName' can be static (but you may consider moving to unnamed namespace). MediaInfo/Source/Common/Core.cpp:448:31: style:inconclusive: Function 'Count_Get' argument 1 names different: declaration 'FilePos' definition 'File_Pos'. [funcArgNamesDifferent] MediaInfo/Source/Common/Core.h:90:30: note: Function 'Count_Get' argument 1 names different: declaration 'FilePos' definition 'File_Pos'. MediaInfo/Source/Common/Core.cpp:448:31: note: Function 'Count_Get' argument 1 names different: declaration 'FilePos' definition 'File_Pos'. MediaInfo/Source/Common/Preferences.cpp:48:5: performance: Variable 'FolderNames' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] MediaInfo/Source/Common/Preferences.h:69:9: performance:inconclusive: Technically the member function 'Preferences::Config_Remove' can be static (but you may consider moving to unnamed namespace). [functionStatic] MediaInfo/Source/Common/Preferences.cpp:287:18: note: Technically the member function 'Preferences::Config_Remove' can be static (but you may consider moving to unnamed namespace). MediaInfo/Source/Common/Preferences.h:69:9: note: Technically the member function 'Preferences::Config_Remove' can be static (but you may consider moving to unnamed namespace). MediaInfo/Source/Common/Preferences.h:77:9: performance:inconclusive: Technically the member function 'Preferences::InternetCheck' can be static (but you may consider moving to unnamed namespace). [functionStatic] MediaInfo/Source/Common/Preferences.cpp:540:18: note: Technically the member function 'Preferences::InternetCheck' can be static (but you may consider moving to unnamed namespace). MediaInfo/Source/Common/Preferences.h:77:9: note: Technically the member function 'Preferences::InternetCheck' can be static (but you may consider moving to unnamed namespace). MediaInfo/Source/Common/Preferences.cpp:427:16: style: Class 'ThreadInternetCheck' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] MediaInfo/Source/Common/Preferences.cpp:1468:12: style: Condition 'Pos==-1' is always false [knownConditionTrueFalse] MediaInfo/Source/Common/Preferences.cpp:984:42: style:inconclusive: Function 'ExplorerShell_Edit' argument 1 names different: declaration 'Name' definition 'Player'. [funcArgNamesDifferent] MediaInfo/Source/Common/Preferences.cpp:37:44: note: Function 'ExplorerShell_Edit' argument 1 names different: declaration 'Name' definition 'Player'. MediaInfo/Source/Common/Preferences.cpp:984:42: note: Function 'ExplorerShell_Edit' argument 1 names different: declaration 'Name' definition 'Player'. MediaInfo/Source/Common/Preferences.cpp:855:36: style: Local variable 'ShellExtension' shadows outer variable [shadowVariable] MediaInfo/Source/Common/Preferences.cpp:811:16: note: Shadowed declaration MediaInfo/Source/Common/Preferences.cpp:855:36: note: Shadow variable MediaInfo/Source/Common/Preferences.cpp:908:40: style: Local variable 'ShellExtension' shadows outer variable [shadowVariable] MediaInfo/Source/Common/Preferences.cpp:811:16: note: Shadowed declaration MediaInfo/Source/Common/Preferences.cpp:908:40: note: Shadow variable MediaInfo/Source/Common/Preferences.cpp:488:58: error: Uninitialized variable: En [legacyUninitvar] MediaInfo/Source/Common/Preferences.cpp:488:15: style: Variable 'En' is assigned a value that is never used. [unreadVariable] MediaInfo/Source/GUI/Qt/about.h:20:5: style: Class 'About' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] MediaInfo/Source/GUI/Qt/columneditsheet.h:45:12: style:inconclusive: Member variable 'ColumnEditSheet::col' is in the wrong place in the initializer list. [initializerList] MediaInfo/Source/GUI/Qt/columneditsheet.cpp:26:5: note: Member variable 'ColumnEditSheet::col' is in the wrong place in the initializer list. MediaInfo/Source/GUI/Qt/columneditsheet.h:45:12: note: Member variable 'ColumnEditSheet::col' is in the wrong place in the initializer list. MediaInfo/Source/GUI/Qt/configtreetext.h:33:13: style:inconclusive: Technically the member function 'ConfigTreeText::getName' can be const. [functionConst] MediaInfo/Source/GUI/Qt/configtreetext.cpp:123:25: note: Technically the member function 'ConfigTreeText::getName' can be const. MediaInfo/Source/GUI/Qt/configtreetext.h:33:13: note: Technically the member function 'ConfigTreeText::getName' can be const. MediaInfo/Source/GUI/Qt/configtreetext.h:35:24: style:inconclusive: Technically the member function 'ConfigTreeText::getFields' can be const. [functionConst] MediaInfo/Source/GUI/Qt/configtreetext.cpp:111:36: note: Technically the member function 'ConfigTreeText::getFields' can be const. MediaInfo/Source/GUI/Qt/configtreetext.h:35:24: note: Technically the member function 'ConfigTreeText::getFields' can be const. MediaInfo/Source/GUI/Qt/configtreetext.h:36:17: style:inconclusive: Technically the member function 'ConfigTreeText::getFields' can be const. [functionConst] MediaInfo/Source/GUI/Qt/configtreetext.cpp:115:29: note: Technically the member function 'ConfigTreeText::getFields' can be const. MediaInfo/Source/GUI/Qt/configtreetext.h:36:17: note: Technically the member function 'ConfigTreeText::getFields' can be const. MediaInfo/Source/GUI/Qt/configtreetext.h:42:5: style: Class 'ConfigTreeText' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] MediaInfo/Source/GUI/Qt/custom.h:34:13: style:inconclusive: Technically the member function 'Custom::getName' can be const. [functionConst] MediaInfo/Source/GUI/Qt/custom.cpp:112:17: note: Technically the member function 'Custom::getName' can be const. MediaInfo/Source/GUI/Qt/custom.h:34:13: note: Technically the member function 'Custom::getName' can be const. MediaInfo/Source/GUI/Qt/custom.h:35:13: style:inconclusive: Technically the member function 'Custom::getPage' can be const. [functionConst] MediaInfo/Source/GUI/Qt/custom.cpp:115:17: note: Technically the member function 'Custom::getPage' can be const. MediaInfo/Source/GUI/Qt/custom.h:35:13: note: Technically the member function 'Custom::getPage' can be const. MediaInfo/Source/GUI/Qt/custom.h:36:13: style:inconclusive: Technically the member function 'Custom::getFile' can be const. [functionConst] MediaInfo/Source/GUI/Qt/custom.cpp:118:17: note: Technically the member function 'Custom::getFile' can be const. MediaInfo/Source/GUI/Qt/custom.h:36:13: note: Technically the member function 'Custom::getFile' can be const. MediaInfo/Source/GUI/Qt/custom.h:37:13: style:inconclusive: Technically the member function 'Custom::getStream' can be const. [functionConst] MediaInfo/Source/GUI/Qt/custom.cpp:121:17: note: Technically the member function 'Custom::getStream' can be const. MediaInfo/Source/GUI/Qt/custom.h:37:13: note: Technically the member function 'Custom::getStream' can be const. MediaInfo/Source/GUI/Qt/custom.h:44:5: style: Class 'Custom' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] MediaInfo/Source/GUI/Qt/easyviewwidget.cpp:56:13: style: The scope of the variable 'box' can be reduced. [variableScope] MediaInfo/Source/GUI/Qt/editconfigtreetext.cpp:79:17: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/editconfigtreetext.cpp:80:34: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/editconfigtreetext.cpp:83:37: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/editsheet.cpp:54:36: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/editsheet.cpp:56:48: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/editsheet.cpp:58:64: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/editsheet.cpp:60:62: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/editsheet.cpp:93:43: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/editsheet.cpp:100:43: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/editsheet.cpp:106:26: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/editsheet.cpp:138:19: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/editsheet.cpp:139:20: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/editsheet.cpp:140:31: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/editsheet.cpp:141:18: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/mainwindow.h:39:5: style: Class 'MainWindow' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] MediaInfo/Source/GUI/Qt/sheetview.h:21:5: style: Class 'SheetView' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] MediaInfo/Source/GUI/Qt/mainwindow.cpp:506:10: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/mainwindow.cpp:515:18: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/mainwindow.cpp:517:22: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/mainwindow.cpp:522:34: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/mainwindow.cpp:530:38: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/mainwindow.cpp:542:18: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/mainwindow.cpp:549:18: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/mainwindow.cpp:556:18: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/mainwindow.cpp:563:18: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/mainwindow.cpp:570:18: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/mainwindow.cpp:577:18: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/mainwindow.cpp:582:18: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/mainwindow.cpp:587:18: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/mainwindow.cpp:594:18: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/mainwindow.cpp:601:18: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/mainwindow.cpp:608:18: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/mainwindow.cpp:615:18: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/mainwindow.cpp:622:18: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/mainwindow.cpp:629:18: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/mainwindow.cpp:634:18: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/mainwindow.cpp:643:18: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/mainwindow.cpp:655:73: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/mainwindow.cpp:656:80: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/Qt/mainwindow.cpp:497:19: style: The scope of the variable 'xis' can be reduced. [variableScope] MediaInfo/Source/GUI/Qt/mainwindow.cpp:717:37: style: Local variable 'A' shadows outer variable [shadowVariable] MediaInfo/Source/GUI/Qt/mainwindow.cpp:698:25: note: Shadowed declaration MediaInfo/Source/GUI/Qt/mainwindow.cpp:717:37: note: Shadow variable MediaInfo/Source/GUI/Qt/mainwindow.cpp:749:33: style: Local variable 'A' shadows outer variable [shadowVariable] MediaInfo/Source/GUI/Qt/mainwindow.cpp:698:25: note: Shadowed declaration MediaInfo/Source/GUI/Qt/mainwindow.cpp:749:33: note: Shadow variable MediaInfo/Source/GUI/Qt/mainwindow.cpp:751:33: style: Local variable 'B' shadows outer variable [shadowVariable] MediaInfo/Source/GUI/Qt/mainwindow.cpp:699:25: note: Shadowed declaration MediaInfo/Source/GUI/Qt/mainwindow.cpp:751:33: note: Shadow variable MediaInfo/Source/GUI/Qt/mainwindow.cpp:333:13: style: Variable 'textsI' can be declared as const array [constVariable] MediaInfo/Source/GUI/Qt/sheet.cpp:13:8: warning: Member variable 'Sheet::adaptColumns' is not initialized in the constructor. [uninitMemberVarPrivate] MediaInfo/Source/GUI/Qt/sheet.h:42:12: style:inconclusive: Technically the member function 'Sheet::getColumn' can be const. [functionConst] MediaInfo/Source/GUI/Qt/sheet.cpp:118:15: note: Technically the member function 'Sheet::getColumn' can be const. MediaInfo/Source/GUI/Qt/sheet.h:42:12: note: Technically the member function 'Sheet::getColumn' can be const. MediaInfo/Source/GUI/Qt/sheet.h:43:13: style:inconclusive: Technically the member function 'Sheet::getName' can be const. [functionConst] MediaInfo/Source/GUI/Qt/sheet.cpp:130:16: note: Technically the member function 'Sheet::getName' can be const. MediaInfo/Source/GUI/Qt/sheet.h:43:13: note: Technically the member function 'Sheet::getName' can be const. MediaInfo/Source/GUI/Qt/sheet.h:45:10: style:inconclusive: Technically the member function 'Sheet::getAdaptColumns' can be const. [functionConst] MediaInfo/Source/GUI/Qt/sheet.cpp:138:13: note: Technically the member function 'Sheet::getAdaptColumns' can be const. MediaInfo/Source/GUI/Qt/sheet.h:45:10: note: Technically the member function 'Sheet::getAdaptColumns' can be const. MediaInfo/Source/GUI/Qt/sheet.h:49:5: style: Class 'Sheet' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] MediaInfo/Source/GUI/UWP/SheetEditFieldControl.xaml.h:31:111: error: syntax error [syntaxError] MediaInfo/Source/GUI/VCL/GUI_Export.cpp:371:0: error: #error [preprocessorErrorDirective] MediaInfo/Source/GUI/VCL/GUI_Main.cpp:624:27: style: Condition 'ItemIndex_Save!=-1' is always true [knownConditionTrueFalse] MediaInfo/Source/GUI/VCL/GUI_Main.cpp:1112:17: style: Condition 'Position==-1' is always false [knownConditionTrueFalse] MediaInfo/Source/GUI/VCL/GUI_Main.cpp:361:94: warning: Either the condition 'Page_Sheet_X_Web[KindOfStream]' is redundant or there is possible null pointer dereference: Page_Sheet_X_Web[KindOfStream]. [nullPointerRedundantCheck] MediaInfo/Source/GUI/VCL/GUI_Main.cpp:362:37: note: Assuming that condition 'Page_Sheet_X_Web[KindOfStream]' is not redundant MediaInfo/Source/GUI/VCL/GUI_Main.cpp:361:94: note: Null pointer dereference MediaInfo/Source/GUI/VCL/GUI_Main.cpp:931:60: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/VCL/GUI_Main.cpp:1502:52: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/VCL/GUI_Main.cpp:1785:6: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/VCL/GUI_Main.cpp:738:32: style: Local variable 'A' shadows outer variable [shadowVariable] MediaInfo/Source/GUI/VCL/GUI_Main.cpp:722:28: note: Shadowed declaration MediaInfo/Source/GUI/VCL/GUI_Main.cpp:738:32: note: Shadow variable MediaInfo/Source/GUI/VCL/GUI_Main.cpp:1000:25: style: Local variable 'I' shadows outer variable [shadowVariable] MediaInfo/Source/GUI/VCL/GUI_Main.cpp:87:16: note: Shadowed declaration MediaInfo/Source/GUI/VCL/GUI_Main.cpp:1000:25: note: Shadow variable MediaInfo/Source/GUI/VCL/GUI_Preferences_Custom.h:38:16: style: Class 'TPreferences_CustomF' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] MediaInfo/Source/GUI/VCL/GUI_Preferences_Output.h:32:16: style: Class 'TPreferences_OutputF' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] MediaInfo/Source/GUI/VCL/GUI_Web.h:26:16: style: Class 'TWebF' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] MediaInfo/Source/GUI/VCL_New/GUI_Main.h:67:16: style: Class 'TGUI_Main_' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] MediaInfo/Source/GUI/VCL_New/GUI_Main_Tree.cpp:115:34: warning:inconclusive: Found suspicious equality comparison. Did you intend to assign a value instead? [constStatement] MediaInfo/Source/GUI/WxWidgets/App.cpp:23:1: error: There is an unknown macro here somewhere. Configuration is required. If IMPLEMENT_APP is a macro then please configure it. [unknownMacro] MediaInfo/Source/GUI/WxWidgets/GUI_Main.cpp:104:82: style: C-style pointer casting [cstyleCast] MediaInfo/Source/GUI/WxWidgets/GUI_Main_Easy.cpp:26:1: error: There is an unknown macro here somewhere. Configuration is required. If BEGIN_EVENT_TABLE is a macro then please configure it. [unknownMacro] MediaInfo/Source/GUI/WxWidgets/GUI_Main_Easy_Box.cpp:26:1: error: There is an unknown macro here somewhere. Configuration is required. If BEGIN_EVENT_TABLE is a macro then please configure it. [unknownMacro] MediaInfo/Source/GUI/WxWidgets/GUI_Main_Menu.cpp:69:1: error: There is an unknown macro here somewhere. Configuration is required. If BEGIN_EVENT_TABLE is a macro then please configure it. [unknownMacro] MediaInfo/Source/GUI/WxWidgets/GUI_Main_Tree.cpp:20:1: error: There is an unknown macro here somewhere. Configuration is required. If BEGIN_EVENT_TABLE is a macro then please configure it. [unknownMacro] MediaInfo/Source/PreRelease/WxWidgets/GUI_Main.cpp:17:1: error: There is an unknown macro here somewhere. Configuration is required. If BEGIN_EVENT_TABLE is a macro then please configure it. [unknownMacro] MediaInfo/Source/Common/Preferences.h:52:1: error: The one definition rule is violated, different classes/structs have the same name 'Preferences' [ctuOneDefinitionRuleViolation] MediaInfo/Source/GUI/Qt/prefs.h:19:1: note: The one definition rule is violated, different classes/structs have the same name 'Preferences' MediaInfo/Source/Common/Preferences.h:52:1: note: The one definition rule is violated, different classes/structs have the same name 'Preferences' diff: head MediaInfo/Source/GUI/Qt/mainwindow.cpp:333:13: style: Variable 'textsI' can be declared as const array [constVariable] 2.8 MediaInfo/Source/GUI/Qt/mainwindow.cpp:333:13: style: Variable 'textsI' can be declared with const [constVariable] DONE