2022-06-29 17:47 ftp://ftp.de.debian.org/debian/pool/main/m/mandelbulber2/mandelbulber2_2.20.orig.tar.xz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --inline-suppr --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j1 platform: Linux-5.4.0-121-generic-x86_64-with-glibc2.29 python: 3.8.10 client-version: 1.3.25 compiler: g++ (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0 cppcheck: head 2.8 head-info: 06b408e (2022-06-29 13:43:17 +0200) count: 481 TO! elapsed-time: 1047.1 1800.1 head-timing-info: Tokenizer::simplifyTokens1: 1038.68s (avg. 5.80269s - 179 result(s)) Tokenizer::simplifyTokens1::ValueFlow: 1022.36s (avg. 5.74358s - 178 result(s)) Tokenizer::simplifyTokens1::createSymbolDatabase: 6.51095s (avg. 0.0365784s - 178 result(s)) Tokenizer::tokenize::simplifyTemplates: 1.43858s (avg. 0.00808192s - 178 result(s)) Tokenizer::createTokens: 1.41064s (avg. 0.00770839s - 183 result(s)) Overall time: 2079.75s old-timing-info: head results: mandelbulber2-2.20/mandelbulber2/qt/anim_audio_view.h:49:2: style: Class 'cAnimAudioView' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/audio_selector.cpp:287:58: style:inconclusive: Function 'FullParameterName' argument 1 names different: declaration 'parameterName' definition 'name'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/qt/audio_selector.h:79:43: note: Function 'FullParameterName' argument 1 names different: declaration 'parameterName' definition 'name'. mandelbulber2-2.20/mandelbulber2/qt/audio_selector.cpp:287:58: note: Function 'FullParameterName' argument 1 names different: declaration 'parameterName' definition 'name'. mandelbulber2-2.20/mandelbulber2/qt/buton_load_settings_from_widget.h:45:2: style: Class 'cButtonLoadSettingsFromWidget' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/buton_load_settings_from_widget.cpp:39:71: style:inconclusive: Function 'cButtonLoadSettingsFromWidget' argument 1 names different: declaration 'parent' definition '_parent'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/qt/buton_load_settings_from_widget.h:45:41: note: Function 'cButtonLoadSettingsFromWidget' argument 1 names different: declaration 'parent' definition '_parent'. mandelbulber2-2.20/mandelbulber2/qt/buton_load_settings_from_widget.cpp:39:71: note: Function 'cButtonLoadSettingsFromWidget' argument 1 names different: declaration 'parent' definition '_parent'. mandelbulber2-2.20/mandelbulber2/qt/buton_reset_settings_from_widget.h:45:2: style: Class 'cButtonResetSettingsFromWidget' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/buton_reset_settings_from_widget.cpp:39:73: style:inconclusive: Function 'cButtonResetSettingsFromWidget' argument 1 names different: declaration 'parent' definition '_parent'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/qt/buton_reset_settings_from_widget.h:45:42: note: Function 'cButtonResetSettingsFromWidget' argument 1 names different: declaration 'parent' definition '_parent'. mandelbulber2-2.20/mandelbulber2/qt/buton_reset_settings_from_widget.cpp:39:73: note: Function 'cButtonResetSettingsFromWidget' argument 1 names different: declaration 'parent' definition '_parent'. mandelbulber2-2.20/mandelbulber2/qt/buton_save_settings_from_widget.h:45:2: style: Class 'cButtonSaveSettingsFromWidget' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/buton_save_settings_from_widget.cpp:39:71: style:inconclusive: Function 'cButtonSaveSettingsFromWidget' argument 1 names different: declaration 'parent' definition '_parent'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/qt/buton_save_settings_from_widget.h:45:41: note: Function 'cButtonSaveSettingsFromWidget' argument 1 names different: declaration 'parent' definition '_parent'. mandelbulber2-2.20/mandelbulber2/qt/buton_save_settings_from_widget.cpp:39:71: note: Function 'cButtonSaveSettingsFromWidget' argument 1 names different: declaration 'parent' definition '_parent'. mandelbulber2-2.20/mandelbulber2/qt/dock_animation.h:63:21: style: Class 'cDockAnimation' is unsafe, 'cDockAnimation::automatedWidgets' can leak by wrong usage. [unsafeClassCanLeak] mandelbulber2-2.20/mandelbulber2/qt/my_tab_bar.h:47:2: style: Class 'MyTabBar' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/dock_navigation.cpp:86:8: debug: Wrong data detected by condition !tok->next()->astOperand1() [DacaWrongData] mandelbulber2-2.20/mandelbulber2/qt/my_progress_bar.h:49:2: style: Class 'MyProgressBar' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/dock_queue.h:67:21: style: Class 'cDockQueue' is unsafe, 'cDockQueue::automatedWidgets' can leak by wrong usage. [unsafeClassCanLeak] mandelbulber2-2.20/mandelbulber2/qt/fft_view.h:48:2: style: Class 'cFFTView' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/file_select_widget.h:52:2: style: Class 'FileSelectWidget' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/preview_file_dialog.h:52:2: style: Class 'PreviewFileDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/formula_combo_box.cpp:99:43: style:inconclusive: Function 'setModelColumn' argument 1 names different: declaration 'visibleColumn' definition 'column'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/qt/formula_combo_box.h:59:26: note: Function 'setModelColumn' argument 1 names different: declaration 'visibleColumn' definition 'column'. mandelbulber2-2.20/mandelbulber2/qt/formula_combo_box.cpp:99:43: note: Function 'setModelColumn' argument 1 names different: declaration 'visibleColumn' definition 'column'. mandelbulber2-2.20/mandelbulber2/qt/gradient_edit_widget.h:49:2: style: Class 'cGradientEditWidget' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/gradient_edit_widget.cpp:126:54: style:inconclusive: Function 'AddToolButton' argument 1 names different: declaration 'button' definition 'toolbutton'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/qt/gradient_edit_widget.h:81:34: note: Function 'AddToolButton' argument 1 names different: declaration 'button' definition 'toolbutton'. mandelbulber2-2.20/mandelbulber2/qt/gradient_edit_widget.cpp:126:54: note: Function 'AddToolButton' argument 1 names different: declaration 'button' definition 'toolbutton'. mandelbulber2-2.20/mandelbulber2/qt/gradient_edit_widget.cpp:174:51: style:inconclusive: Function 'CalcButtonPosition' argument 1 names different: declaration 'colorPosition' definition 'position'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/qt/gradient_edit_widget.h:69:31: note: Function 'CalcButtonPosition' argument 1 names different: declaration 'colorPosition' definition 'position'. mandelbulber2-2.20/mandelbulber2/qt/gradient_edit_widget.cpp:174:51: note: Function 'CalcButtonPosition' argument 1 names different: declaration 'colorPosition' definition 'position'. mandelbulber2-2.20/mandelbulber2/qt/image_save_dialog.h:58:2: style: Class 'cImageSaveDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/material_selector.h:53:2: style: Class 'cMaterialSelector' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/thumbnail_widget.h:57:2: style: Class 'cThumbnailWidget' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/material_widget.h:50:2: style: Class 'cMaterialWidget' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/material_widget.cpp:101:2: error: Non-local variable 'paramsHandle' will use pointer to local variable 'params'. [danglingLifetime] mandelbulber2-2.20/mandelbulber2/qt/material_widget.cpp:226:17: note: Address of variable taken here. mandelbulber2-2.20/mandelbulber2/qt/material_widget.cpp:226:17: note: Calling function 'AssignMaterial', 1st argument '¶ms' value is lifetime=params mandelbulber2-2.20/mandelbulber2/qt/material_widget.cpp:223:22: note: Variable created here. mandelbulber2-2.20/mandelbulber2/qt/material_widget.cpp:101:2: note: Non-local variable 'paramsHandle' will use pointer to local variable 'params'. mandelbulber2-2.20/mandelbulber2/qt/material_widget.cpp:219:53: style:inconclusive: Function 'AssignMaterial' argument 1 names different: declaration 'settings' definition 'text'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/qt/material_widget.h:55:37: note: Function 'AssignMaterial' argument 1 names different: declaration 'settings' definition 'text'. mandelbulber2-2.20/mandelbulber2/qt/material_widget.cpp:219:53: note: Function 'AssignMaterial' argument 1 names different: declaration 'settings' definition 'text'. mandelbulber2-2.20/mandelbulber2/qt/player_widget.hpp:52:2: style: Class 'PlayerWidget' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/my_check_box.h:49:2: style: Class 'MyCheckBox' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/my_color_button.cpp:43:2: performance: Variable 'defaultValue' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/qt/my_color_button.h:51:2: style: Class 'MyColorButton' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/my_combo_box.h:47:2: style: Class 'MyComboBox' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/my_double_spin_box.h:51:2: style: Class 'MyDoubleSpinBox' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/my_group_box.h:49:2: style: Class 'MyGroupBox' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/my_histogram_label.cpp:44:2: performance: Variable 'barColor' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/qt/my_histogram_label.h:49:2: style: Class 'MyHistogramLabel' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/my_histogram_label.cpp:67:7: style: The scope of the variable 'maxH' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/qt/my_histogram_label.cpp:68:6: style: The scope of the variable 'extremeIndex' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/qt/my_histogram_label.cpp:69:6: style: The scope of the variable 'minIndex' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/qt/my_histogram_label.cpp:70:6: style: The scope of the variable 'maxIndex' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/qt/my_histogram_label.cpp:58:58: style:inconclusive: Function 'UpdateHistogram' argument 1 names different: declaration 'histData' definition '_histData'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/qt/my_histogram_label.h:64:41: note: Function 'UpdateHistogram' argument 1 names different: declaration 'histData' definition '_histData'. mandelbulber2-2.20/mandelbulber2/qt/my_histogram_label.cpp:58:58: note: Function 'UpdateHistogram' argument 1 names different: declaration 'histData' definition '_histData'. mandelbulber2-2.20/mandelbulber2/qt/my_line_edit.h:51:2: style: Class 'MyLineEdit' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/my_spin_box.h:51:2: style: Class 'MySpinBox' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/my_tab_widget.h:47:2: style: Class 'MyTabWidget' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/my_table_widget_anim.hpp:45:2: style: Class 'MyTableWidgetAnim' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/my_table_widget_keyframes.hpp:45:2: style: Class 'MyTableWidgetKeyframes' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/preview_file_dialog.cpp:129:57: style:inconclusive: Function 'OnCurrentChanged' argument 1 names different: declaration 'filename' definition '_filename'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/qt/preview_file_dialog.h:55:39: note: Function 'OnCurrentChanged' argument 1 names different: declaration 'filename' definition '_filename'. mandelbulber2-2.20/mandelbulber2/qt/preview_file_dialog.cpp:129:57: note: Function 'OnCurrentChanged' argument 1 names different: declaration 'filename' definition '_filename'. mandelbulber2-2.20/mandelbulber2/qt/pushbutton_anim_sound.h:47:2: style: Class 'cPushButtonAnimSound' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/system_tray.hpp:50:2: style: Class 'cSystemTray' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/time_ruler.h:49:2: style: Class 'cTimeRuler' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/qt/wave_form_view.h:59:2: style: Class 'cWaveFormView' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/algebra.hpp:476:3: performance: Variable 'x' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/src/algebra.hpp:477:3: performance: Variable 'y' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/src/algebra.cpp:476:11: style: Variable 'rot.m11' is reassigned a value before the old one has been used. [redundantAssignment] mandelbulber2-2.20/mandelbulber2/src/algebra.cpp:474:11: note: rot.m11 is assigned mandelbulber2-2.20/mandelbulber2/src/algebra.cpp:476:11: note: rot.m11 is overwritten mandelbulber2-2.20/mandelbulber2/src/parameters.hpp:48:2: warning:inconclusive: Member variable 'cParameterContainer::m_lock' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] mandelbulber2-2.20/mandelbulber2/src/animation_flight.cpp:1690:2: performance: Variable 'settingsText' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/src/color_structures.hpp:62:3: performance: Variable 'R' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/src/color_structures.hpp:63:3: performance: Variable 'G' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/src/color_structures.hpp:64:3: performance: Variable 'B' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/src/color_structures.hpp:65:3: performance: Variable 'A' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/src/color_structures.hpp:48:3: performance: Variable 'R' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/src/color_structures.hpp:49:3: performance: Variable 'G' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/src/color_structures.hpp:50:3: performance: Variable 'B' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/src/one_parameter.hpp:88:7: style:inconclusive: Technically the member function 'cOneParameter::IsGradient' can be const. [functionConst] mandelbulber2-2.20/mandelbulber2/src/cimage.hpp:215:19: style:inconclusive: Technically the member function 'cImage::GetPixelGeneric' can be const. [functionConst] mandelbulber2-2.20/mandelbulber2/src/cimage.hpp:221:16: style:inconclusive: Technically the member function 'cImage::GetPixelGeneric16' can be const. [functionConst] mandelbulber2-2.20/mandelbulber2/src/cimage.hpp:227:15: style:inconclusive: Technically the member function 'cImage::GetPixelGeneric8' can be const. [functionConst] mandelbulber2-2.20/mandelbulber2/src/stereo.h:86:10: style:inconclusive: Technically the member function 'cStereo::GetForcedEye' can be const. [functionConst] mandelbulber2-2.20/mandelbulber2/src/error_message.hpp:44:2: style: Class 'cErrorMessage' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/histogram.hpp:46:2: style: Class 'cHistogram' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/animation_flight.hpp:203:2: style: Class 'cFligtAnimRenderThread' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/primitives.h:171:2: style: Class 'cPrimitives' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/interface.hpp:62:2: style: Class 'cInterface' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/opencl_engine.h:72:2: style: Class 'cOpenClEngine' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/opencl_engine_render_fractal.h:76:2: style: Class 'cOpenClEngineRenderFractal' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/rendered_image_widget.hpp:96:2: style: Class 'RenderedImage' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/settings.hpp:60:2: style: Class 'cSettings' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/color_structures.hpp:68:2: style: Struct 'tsRGBA < quint8 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/color_structures.hpp:68:2: style: Struct 'tsRGBA < quint16 >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/color_structures.hpp:68:2: style: Struct 'tsRGBA < float >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/animation_flight.cpp:1688:57: style:inconclusive: Function 'cFligtAnimRenderThread' argument 1 names different: declaration 'settingsText' definition '_settingsText'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/animation_flight.hpp:203:34: note: Function 'cFligtAnimRenderThread' argument 1 names different: declaration 'settingsText' definition '_settingsText'. mandelbulber2-2.20/mandelbulber2/src/animation_flight.cpp:1688:57: note: Function 'cFligtAnimRenderThread' argument 1 names different: declaration 'settingsText' definition '_settingsText'. mandelbulber2-2.20/mandelbulber2/src/animation_flight.cpp:897:12: style: Local variable 'i' shadows outer variable [shadowVariable] mandelbulber2-2.20/mandelbulber2/src/animation_flight.cpp:894:11: note: Shadowed declaration mandelbulber2-2.20/mandelbulber2/src/animation_flight.cpp:897:12: note: Shadow variable mandelbulber2-2.20/mandelbulber2/src/animation_flight.cpp:1101:14: style: Local variable 'result' shadows outer variable [shadowVariable] mandelbulber2-2.20/mandelbulber2/src/animation_flight.cpp:1051:8: note: Shadowed declaration mandelbulber2-2.20/mandelbulber2/src/animation_flight.cpp:1101:14: note: Shadow variable mandelbulber2-2.20/mandelbulber2/src/primitives.h:184:31: performance: Function parameter 'point' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/primitives.h:184:47: performance: Function parameter 'position' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/primitives.h:184:66: performance: Function parameter 'normal' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/animation_flight.cpp:1688:57: style: Parameter '_settingsText' can be declared as reference to const [constParameter] mandelbulber2-2.20/mandelbulber2/src/audio_track.h:48:2: style: Class 'cAudioTrack' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/animation_keyframes.cpp:1760:2: performance: Variable 'settingsText' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/src/animation_keyframes.hpp:205:2: style: Class 'cKeyframeRenderThread' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/animation_keyframes.cpp:1758:55: style:inconclusive: Function 'cKeyframeRenderThread' argument 1 names different: declaration 'settingsText' definition '_settingsText'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/animation_keyframes.hpp:205:33: note: Function 'cKeyframeRenderThread' argument 1 names different: declaration 'settingsText' definition '_settingsText'. mandelbulber2-2.20/mandelbulber2/src/animation_keyframes.cpp:1758:55: note: Function 'cKeyframeRenderThread' argument 1 names different: declaration 'settingsText' definition '_settingsText'. mandelbulber2-2.20/mandelbulber2/src/animation_keyframes.cpp:747:12: style: Local variable 'i' shadows outer variable [shadowVariable] mandelbulber2-2.20/mandelbulber2/src/animation_keyframes.cpp:744:11: note: Shadowed declaration mandelbulber2-2.20/mandelbulber2/src/animation_keyframes.cpp:747:12: note: Shadow variable mandelbulber2-2.20/mandelbulber2/src/animation_keyframes.cpp:959:15: style: Local variable 'result' shadows outer variable [shadowVariable] mandelbulber2-2.20/mandelbulber2/src/animation_keyframes.cpp:901:8: note: Shadowed declaration mandelbulber2-2.20/mandelbulber2/src/animation_keyframes.cpp:959:15: note: Shadow variable mandelbulber2-2.20/mandelbulber2/src/animation_keyframes.cpp:1758:55: style: Parameter '_settingsText' can be declared as reference to const [constParameter] mandelbulber2-2.20/mandelbulber2/src/audio_fft_data.cpp:37:16: warning: Member variable 'cAudioFFTData::data' is not initialized in the constructor. [uninitMemberVar] mandelbulber2-2.20/mandelbulber2/src/audio_fft_data.cpp:41:9: style: Consider using std::fill algorithm instead of a raw loop. [useStlAlgorithm] mandelbulber2-2.20/mandelbulber2/src/resource_http_provider.hpp:47:2: style: Class 'cResourceHttpProvider' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/automated_widgets.hpp:46:2: style: Class 'cAutomatedWidgets' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/color_gradient.h:54:7: style:inconclusive: Technically the member function 'cColorGradient::isGrayscale' can be const. [functionConst] mandelbulber2-2.20/mandelbulber2/src/fractal.h:773:2: style: Struct 'sFractal' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/fractparams.hpp:70:2: style: Struct 'sParamRender' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/calculate_distance.cpp:97:20: style:inconclusive: Redundant initialization for 'pointFractalized'. The initialized value is overwritten before it is read. [redundantInitialization] mandelbulber2-2.20/mandelbulber2/src/calculate_distance.cpp:95:29: note: pointFractalized is initialized mandelbulber2-2.20/mandelbulber2/src/calculate_distance.cpp:97:20: note: pointFractalized is overwritten mandelbulber2-2.20/mandelbulber2/src/calculate_distance.cpp:119:22: style:inconclusive: Redundant initialization for 'pointFractalized'. The initialized value is overwritten before it is read. [redundantInitialization] mandelbulber2-2.20/mandelbulber2/src/calculate_distance.cpp:117:31: note: pointFractalized is initialized mandelbulber2-2.20/mandelbulber2/src/calculate_distance.cpp:119:22: note: pointFractalized is overwritten mandelbulber2-2.20/mandelbulber2/src/calculate_distance.cpp:191:20: style:inconclusive: Redundant initialization for 'pointFractalized'. The initialized value is overwritten before it is read. [redundantInitialization] mandelbulber2-2.20/mandelbulber2/src/calculate_distance.cpp:188:29: note: pointFractalized is initialized mandelbulber2-2.20/mandelbulber2/src/calculate_distance.cpp:191:20: note: pointFractalized is overwritten mandelbulber2-2.20/mandelbulber2/src/calculate_distance.cpp:421:17: style:inconclusive: Function 'CalculateDistanceMinPlane' argument 3 names different: declaration 'point' definition 'planePoint'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/calculate_distance.hpp:75:17: note: Function 'CalculateDistanceMinPlane' argument 3 names different: declaration 'point' definition 'planePoint'. mandelbulber2-2.20/mandelbulber2/src/calculate_distance.cpp:421:17: note: Function 'CalculateDistanceMinPlane' argument 3 names different: declaration 'point' definition 'planePoint'. mandelbulber2-2.20/mandelbulber2/src/calculate_distance.cpp:117:14: style: Local variable 'pointFractalized' shadows outer variable [shadowVariable] mandelbulber2-2.20/mandelbulber2/src/calculate_distance.cpp:95:12: note: Shadowed declaration mandelbulber2-2.20/mandelbulber2/src/calculate_distance.cpp:117:14: note: Shadow variable mandelbulber2-2.20/mandelbulber2/src/calculate_distance.cpp:118:12: style: Local variable 'reduceDisplacement' shadows outer variable [shadowVariable] mandelbulber2-2.20/mandelbulber2/src/calculate_distance.cpp:96:10: note: Shadowed declaration mandelbulber2-2.20/mandelbulber2/src/calculate_distance.cpp:118:12: note: Shadow variable mandelbulber2-2.20/mandelbulber2/src/calculate_distance.hpp:54:23: performance: Function parameter '_point' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/compute_fractal.hpp:58:22: performance: Function parameter '_point' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/calculate_distance.cpp:421:17: performance: Function parameter 'planePoint' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/calculate_distance.cpp:421:44: performance: Function parameter 'direction' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/calculate_distance.cpp:421:70: performance: Function parameter 'orthDirection' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/camera_target.cpp:44:88: style:inconclusive: Function 'SetCameraTargetRotation' argument 3 names different: declaration 'roll' definition '_roll'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/camera_target.hpp:50:74: note: Function 'SetCameraTargetRotation' argument 3 names different: declaration 'roll' definition '_roll'. mandelbulber2-2.20/mandelbulber2/src/camera_target.cpp:44:88: note: Function 'SetCameraTargetRotation' argument 3 names different: declaration 'roll' definition '_roll'. mandelbulber2-2.20/mandelbulber2/src/camera_target.cpp:39:39: performance: Function parameter '_camera' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/camera_target.cpp:39:57: performance: Function parameter '_target' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/camera_target.cpp:39:75: performance: Function parameter '_top' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/camera_target.cpp:44:54: performance: Function parameter '_camera' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/camera_target.cpp:44:72: performance: Function parameter '_target' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/camera_target.cpp:83:49: performance: Function parameter '_camera' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/camera_target.cpp:83:67: performance: Function parameter '_target' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/camera_target.cpp:83:85: performance: Function parameter '_top' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/camera_target.cpp:129:40: performance: Function parameter '_camera' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/camera_target.cpp:142:40: performance: Function parameter '_target' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/cimage.cpp:46:2: performance: Variable 'width' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/src/cimage.hpp:88:7: performance:inconclusive: Technically the member function 'cImage::ClearRGB' can be static (but you may consider moving to unnamed namespace). [functionStatic] mandelbulber2-2.20/mandelbulber2/src/cimage.cpp:179:14: note: Technically the member function 'cImage::ClearRGB' can be static (but you may consider moving to unnamed namespace). mandelbulber2-2.20/mandelbulber2/src/cimage.hpp:88:7: note: Technically the member function 'cImage::ClearRGB' can be static (but you may consider moving to unnamed namespace). mandelbulber2-2.20/mandelbulber2/src/cimage.hpp:92:7: performance:inconclusive: Technically the member function 'cImage::FreeRGB' can be static (but you may consider moving to unnamed namespace). [functionStatic] mandelbulber2-2.20/mandelbulber2/src/cimage.cpp:211:14: note: Technically the member function 'cImage::FreeRGB' can be static (but you may consider moving to unnamed namespace). mandelbulber2-2.20/mandelbulber2/src/cimage.hpp:92:7: note: Technically the member function 'cImage::FreeRGB' can be static (but you may consider moving to unnamed namespace). mandelbulber2-2.20/mandelbulber2/src/cimage.cpp:721:37: style:inconclusive: Function 'Squares' argument 2 names different: declaration 'progressiveFactor' definition 'pFactor'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/cimage.hpp:303:30: note: Function 'Squares' argument 2 names different: declaration 'progressiveFactor' definition 'pFactor'. mandelbulber2-2.20/mandelbulber2/src/cimage.cpp:721:37: note: Function 'Squares' argument 2 names different: declaration 'progressiveFactor' definition 'pFactor'. mandelbulber2-2.20/mandelbulber2/src/cimage.cpp:351:51: performance: Function parameter 'adjustments' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/test.hpp:54:3: performance: Variable 'exampleOutputPath' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/src/command_line_interface.hpp:42:2: style: Class 'cCommandLineInterface' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/opencl_hardware.h:59:2: style: Class 'cOpenClHardware' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/test.hpp:50:2: style: Class 'Test' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/common_math.cpp:170:32: style: Parameter 'p' can be declared as const array [constParameter] mandelbulber2-2.20/mandelbulber2/src/compute_fractal.cpp:49:20: style: The scope of the variable 'fractalFormulaFunction' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/displacement_map.cpp:43:31: performance: Function parameter 'point' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/dof.hpp:52:2: style: Class 'cPostRenderingDOF' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/dof.cpp:81:8: style: The scope of the variable 'percentDone' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/dof.cpp:366:80: style:inconclusive: Function 'QuickSortZBuffer < float >' argument 3 names different: declaration 'p' definition 'r'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/dof.hpp:57:69: note: Function 'QuickSortZBuffer < float >' argument 3 names different: declaration 'p' definition 'r'. mandelbulber2-2.20/mandelbulber2/src/dof.cpp:366:80: note: Function 'QuickSortZBuffer < float >' argument 3 names different: declaration 'p' definition 'r'. mandelbulber2-2.20/mandelbulber2/src/file_image.cpp:414:10: style:inconclusive: Function 'SavePNG' argument 1 names different: declaration 'filename' definition 'filenameInput'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/file_image.hpp:187:11: note: Function 'SavePNG' argument 1 names different: declaration 'filename' definition 'filenameInput'. mandelbulber2-2.20/mandelbulber2/src/file_image.cpp:414:10: note: Function 'SavePNG' argument 1 names different: declaration 'filename' definition 'filenameInput'. mandelbulber2-2.20/mandelbulber2/src/file_image.cpp:1040:11: style: Local variable 'i' shadows outer variable [shadowVariable] mandelbulber2-2.20/mandelbulber2/src/file_image.cpp:1033:33: note: Shadowed declaration mandelbulber2-2.20/mandelbulber2/src/file_image.cpp:1040:11: note: Shadow variable mandelbulber2-2.20/mandelbulber2/src/file_mesh.cpp:145:20: portability:inconclusive: Casting from double * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] mandelbulber2-2.20/mandelbulber2/src/file_mesh.cpp:147:20: portability:inconclusive: Casting from double * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] mandelbulber2-2.20/mandelbulber2/src/file_mesh.cpp:75:2: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] mandelbulber2-2.20/mandelbulber2/src/file_mesh.cpp:77:2: note: Found duplicate branches for 'if' and 'else'. mandelbulber2-2.20/mandelbulber2/src/file_mesh.cpp:75:2: note: Found duplicate branches for 'if' and 'else'. mandelbulber2-2.20/mandelbulber2/src/file_mesh.hpp:128:88: performance: Function parameter 'meshData' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/file_mesh.cpp:46:72: performance: Function parameter 'meshData' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/file_mesh.cpp:54:72: performance: Function parameter 'meshData' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/files.cpp:87:9: style: The scope of the variable 'result' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal.cpp:41:47: style:inconclusive: Function 'sFractal' argument 1 names different: declaration 'par' definition 'container'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/fractal.h:773:38: note: Function 'sFractal' argument 1 names different: declaration 'par' definition 'container'. mandelbulber2-2.20/mandelbulber2/src/fractal.cpp:41:47: note: Function 'sFractal' argument 1 names different: declaration 'par' definition 'container'. mandelbulber2-2.20/mandelbulber2/src/fractal_coloring.cpp:78:11: style: Local variable 'lineDirection' shadows outer variable [shadowVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_coloring.hpp:92:11: note: Shadowed declaration mandelbulber2-2.20/mandelbulber2/src/fractal_coloring.cpp:78:11: note: Shadow variable mandelbulber2-2.20/mandelbulber2/src/fractal_coloring.cpp:79:11: style: Local variable 'xyz000' shadows outer variable [shadowVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_coloring.hpp:93:11: note: Shadowed declaration mandelbulber2-2.20/mandelbulber2/src/fractal_coloring.cpp:79:11: note: Shadow variable mandelbulber2-2.20/mandelbulber2/src/fractal_coloring.cpp:80:11: style: Local variable 'xyzC111' shadows outer variable [shadowVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_coloring.hpp:94:11: note: Shadowed declaration mandelbulber2-2.20/mandelbulber2/src/fractal_coloring.cpp:80:11: note: Shadow variable mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:3392:31: style: Condition 'fractal->transformCommon.benesiT1Enabled' is always true [knownConditionTrueFalse] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:3387:30: note: Assuming that condition 'fractal->transformCommon.benesiT1Enabled' is not redundant mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:3392:31: note: Condition 'fractal->transformCommon.benesiT1Enabled' is always true mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:3393:14: style: Condition 'aux.i>=fractal->transformCommon.startIterations' is always true [knownConditionTrueFalse] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:3387:56: note: Assuming condition 'aux.i>=fractal->transformCommon.startIterations' is true mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:3393:14: note: Condition 'aux.i>=fractal->transformCommon.startIterations' is always true mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:3394:14: style: Condition 'aux.itransformCommon.stopIterations' is always true [knownConditionTrueFalse] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:3388:13: note: Assuming condition 'aux.itransformCommon.stopIterations' is true mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:3394:14: note: Condition 'aux.itransformCommon.stopIterations' is always true mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:264:7: style: Variable 'temp' is reassigned a value before the old one has been used. [redundantAssignment] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:253:7: note: temp is assigned mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:264:7: note: temp is overwritten mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:2855:7: style:inconclusive: Redundant initialization for 'oldZ'. The initialized value is overwritten before it is read. [redundantInitialization] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:2852:16: note: oldZ is initialized mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:2855:7: note: oldZ is overwritten mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:10853:8: style:inconclusive: Variable 'zCol' is reassigned a value before the old one has been used if variable is no semaphore variable. [redundantAssignment] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:10840:8: note: zCol is assigned mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:10853:8: note: zCol is overwritten mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:15512:7: style:inconclusive: Redundant initialization for 'zCol'. The initialized value is overwritten before it is read. [redundantInitialization] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:15487:16: note: zCol is initialized mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:15512:7: note: zCol is overwritten mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:17340:9: style:inconclusive: Redundant initialization for 'folder'. The initialized value is overwritten before it is read. [redundantInitialization] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:17337:18: note: folder is initialized mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:17340:9: note: folder is overwritten mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:17339:8: style:inconclusive: Redundant initialization for 'Tglad'. The initialized value is overwritten before it is read. [redundantInitialization] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:17338:17: note: Tglad is initialized mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:17339:8: note: Tglad is overwritten mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:17885:61: style: The comparison 'bxD < 0.0' is always false. [knownConditionTrueFalse] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:17882:17: note: 'bxD' is assigned value '0.0' here. mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:17885:61: note: The comparison 'bxD < 0.0' is always false. mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:1225:13: style: The scope of the variable 'paraAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:1226:13: style: The scope of the variable 'paraIt' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:1415:10: style: The scope of the variable 'addR' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:2566:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:2782:10: style: The scope of the variable 'useScale' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:2849:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:3030:10: style: The scope of the variable 'useScale' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:3839:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:3881:9: style: The scope of the variable 'useScale' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:3976:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:4178:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:4376:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:4798:9: style: The scope of the variable 'useScale' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:5263:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:5437:9: style: The scope of the variable 'useScale' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:7285:9: style: The scope of the variable 't' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:7286:9: style: The scope of the variable 'dot1' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:7613:9: style: The scope of the variable 'useScale' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:7752:13: style: The scope of the variable 'paraAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:7753:13: style: The scope of the variable 'paraIt' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:7958:9: style: The scope of the variable 't' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:7959:9: style: The scope of the variable 'dot1' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:9240:9: style: The scope of the variable 't' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:9241:9: style: The scope of the variable 'dot1' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:9516:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:9556:13: style: The scope of the variable 'paraAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:9557:13: style: The scope of the variable 'paraIt' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:9829:9: style: The scope of the variable 't' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:9830:9: style: The scope of the variable 'dot1' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:10612:10: style: The scope of the variable 'vecDE' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:10672:10: style: The scope of the variable 'vecDE' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:10780:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:12684:9: style: The scope of the variable 'x1' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:12685:9: style: The scope of the variable 'y1' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:14107:11: style: The scope of the variable 'paraAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:14108:11: style: The scope of the variable 'paraIt' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:14933:11: style: The scope of the variable 'paraAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:14934:11: style: The scope of the variable 'paraIt' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:15063:9: style: The scope of the variable 'paraAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:15064:9: style: The scope of the variable 'paraAddP0' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:15098:12: style: The scope of the variable 'paraIt' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:15315:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:15485:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:15493:9: style: The scope of the variable 'paraAddP0' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:15627:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:15633:9: style: The scope of the variable 'paraAddP0' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:15644:9: style: The scope of the variable 'sinAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:15693:9: style: The scope of the variable 'useScale' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:15847:9: style: The scope of the variable 'paraAddP0' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:16056:9: style: The scope of the variable 'paraAddP0' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:17327:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:17391:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:17476:9: style: The scope of the variable 'useScale' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:17582:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:17632:9: style: The scope of the variable 'useScale' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:17729:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:17816:9: style: The scope of the variable 'useScale' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:17923:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:18009:9: style: The scope of the variable 'useScale' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:18152:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:18234:9: style: The scope of the variable 'useScale' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:18357:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:18462:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:18544:9: style: The scope of the variable 'useScale' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:18586:9: style: The scope of the variable 'mengD' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:18706:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:18788:9: style: The scope of the variable 'useScale' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:18900:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:18985:9: style: The scope of the variable 'useScale' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:19084:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:19166:9: style: The scope of the variable 'useScale' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:20273:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:20279:9: style: The scope of the variable 'paraAddP0' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:20290:9: style: The scope of the variable 'sinAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:20367:9: style: The scope of the variable 'useScale' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:20710:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:20797:9: style: The scope of the variable 'useScale' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:20969:9: style: The scope of the variable 'dividend' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:20972:9: style: The scope of the variable 'useScale' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:21006:9: style: The scope of the variable 'colorAdd' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:193:9: style: Local variable 'sign' shadows outer function [shadowFunction] mandelbulber2-2.20/mandelbulber2/src/common_math.h:89:12: note: Shadowed declaration mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:193:9: note: Shadow variable mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:20467:10: style: Local variable 'temp' shadows outer variable [shadowVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:20324:11: note: Shadowed declaration mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:20467:10: note: Shadow variable mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:10027:87: style: Parameter 'aux' can be declared as reference to const [constParameter] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:11577:91: style: Parameter 'aux' can be declared as reference to const [constParameter] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:11604:83: style: Parameter 'aux' can be declared as reference to const [constParameter] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:11860:94: style: Parameter 'aux' can be declared as reference to const [constParameter] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:11877:89: style: Parameter 'aux' can be declared as reference to const [constParameter] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:12912:87: style: Parameter 'aux' can be declared as reference to const [constParameter] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:15451:89: style: Parameter 'aux' can be declared as reference to const [constParameter] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:19273:39: style: Parameter 'z' can be declared as reference to const [constParameter] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:19407:44: style: Parameter 'z' can be declared as reference to const [constParameter] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:19495:45: style: Parameter 'z' can be declared as reference to const [constParameter] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:19517:40: style: Parameter 'z' can be declared as reference to const [constParameter] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:19547:42: style: Parameter 'z' can be declared as reference to const [constParameter] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:19618:45: style: Parameter 'z' can be declared as reference to const [constParameter] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:19649:41: style: Parameter 'z' can be declared as reference to const [constParameter] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:19713:42: style: Parameter 'z' can be declared as reference to const [constParameter] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:19734:41: style: Parameter 'z' can be declared as reference to const [constParameter] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:19838:43: style: Parameter 'z' can be declared as reference to const [constParameter] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:19976:44: style: Parameter 'z' can be declared as reference to const [constParameter] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:20060:47: style: Parameter 'z' can be declared as reference to const [constParameter] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:21004:43: style: Parameter 'z' can be declared as reference to const [constParameter] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:2638:7: style: Variable 'functionEnabledN' can be declared as const array [constVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:2641:6: style: Variable 'startIterationN' can be declared as const array [constVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:2643:6: style: Variable 'stopIterationN' can be declared as const array [constVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:2857:7: style: Variable 'functionEnabledN' can be declared as const array [constVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:2860:6: style: Variable 'startIterationN' can be declared as const array [constVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:2862:6: style: Variable 'stopIterationN' can be declared as const array [constVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:3160:7: style: Variable 'functionEnabledN' can be declared as const array [constVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:3165:6: style: Variable 'startIterationN' can be declared as const array [constVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:3168:6: style: Variable 'stopIterationN' can be declared as const array [constVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:3546:7: style: Variable 'functionEnabledN' can be declared as const array [constVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:3551:6: style: Variable 'startIterationN' can be declared as const array [constVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:3554:6: style: Variable 'stopIterationN' can be declared as const array [constVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:1415:15: style: Variable 'addR' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:1466:17: style: Variable 'MinR2' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:2782:19: style: Variable 'useScale' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:3030:19: style: Variable 'useScale' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:3881:18: style: Variable 'useScale' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:4798:18: style: Variable 'useScale' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:10612:16: style: Variable 'vecDE' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:10672:16: style: Variable 'vecDE' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:13315:14: style: Variable 'temp' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:14375:12: style: Variable 'rr' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:14397:15: style: Variable 'mode' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:14675:11: style: Variable 'm' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:15064:19: style: Variable 'paraAddP0' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:15493:19: style: Variable 'paraAddP0' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:15633:19: style: Variable 'paraAddP0' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:15644:16: style: Variable 'sinAdd' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:15693:18: style: Variable 'useScale' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:15847:19: style: Variable 'paraAddP0' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:16056:19: style: Variable 'paraAddP0' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:17193:11: style: Variable 'tempZ.z' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:17476:18: style: Variable 'useScale' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:17632:18: style: Variable 'useScale' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:17816:18: style: Variable 'useScale' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:18009:18: style: Variable 'useScale' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:18234:18: style: Variable 'useScale' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:18544:18: style: Variable 'useScale' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:18586:15: style: Variable 'mengD' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:18788:18: style: Variable 'useScale' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:18985:18: style: Variable 'useScale' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:19166:18: style: Variable 'useScale' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:20279:19: style: Variable 'paraAddP0' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:20290:16: style: Variable 'sinAdd' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:20367:18: style: Variable 'useScale' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractal_formulas.cpp:20797:18: style: Variable 'useScale' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/fractparams.cpp:50:2: performance: Variable 'ambientOcclusionColor' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/src/fractparams.cpp:76:19: style: Variable 'backgroundVScale' is reassigned a value before the old one has been used. [redundantAssignment] mandelbulber2-2.20/mandelbulber2/src/fractparams.cpp:73:19: note: backgroundVScale is assigned mandelbulber2-2.20/mandelbulber2/src/fractparams.cpp:76:19: note: backgroundVScale is overwritten mandelbulber2-2.20/mandelbulber2/src/fractparams.cpp:180:9: style:inconclusive: Variable 'target' is reassigned a value before the old one has been used if variable is no semaphore variable. [redundantAssignment] mandelbulber2-2.20/mandelbulber2/src/fractparams.cpp:179:9: note: target is assigned mandelbulber2-2.20/mandelbulber2/src/fractparams.cpp:180:9: note: target is overwritten mandelbulber2-2.20/mandelbulber2/src/fractparams.cpp:40:55: style:inconclusive: Function 'sParamRender' argument 1 names different: declaration 'par' definition 'container'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/fractparams.hpp:70:42: note: Function 'sParamRender' argument 1 names different: declaration 'par' definition 'container'. mandelbulber2-2.20/mandelbulber2/src/fractparams.cpp:40:55: note: Function 'sParamRender' argument 1 names different: declaration 'par' definition 'container'. mandelbulber2-2.20/mandelbulber2/src/opencl_engine_render_ssao.h:56:2: style: Class 'cOpenClEngineRenderSSAO' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/cimage.hpp:119:60: performance:inconclusive: Function parameter 'pixel' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/cimage.hpp:123:64: performance:inconclusive: Function parameter 'pixel' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/cimage.hpp:127:59: performance:inconclusive: Function parameter 'pixel' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/cimage.hpp:131:56: performance:inconclusive: Function parameter 'pixel' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/cimage.hpp:147:61: performance:inconclusive: Function parameter 'pixel' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/cimage.hpp:151:66: performance:inconclusive: Function parameter 'pixel' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/cimage.hpp:155:63: performance:inconclusive: Function parameter 'pixel' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/cimage.hpp:159:62: performance:inconclusive: Function parameter 'pixel' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/cimage.hpp:163:60: performance:inconclusive: Function parameter 'pixel' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/histogram.hpp:84:1: error: There is an unknown macro here somewhere. Configuration is required. If Q_DECLARE_METATYPE is a macro then please configure it. [unknownMacro] mandelbulber2-2.20/mandelbulber2/src/image_scale.cpp:46:9: style: The scope of the variable 'scales' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/image_scale.cpp:46:9: style: Variable 'scales' can be declared as const array [constVariable] mandelbulber2-2.20/mandelbulber2/src/material_item_model.h:50:2: style: Class 'cMaterialItemModel' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/my_ui_loader.h:44:2: style: Class 'MyUiLoader' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/opencl_engine_render_dof.h:54:2: style: Class 'cOpenClEngineRenderDOF' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/post_effect_hdr_blur.h:48:2: style: Class 'cPostEffectHdrBlur' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/interface.cpp:667:6: style: The if condition is the same as the previous if condition [duplicateCondition] mandelbulber2-2.20/mandelbulber2/src/interface.cpp:666:6: note: First condition mandelbulber2-2.20/mandelbulber2/src/interface.cpp:667:6: note: Second condition mandelbulber2-2.20/mandelbulber2/src/interface.cpp:791:6: style: The if condition is the same as the previous if condition [duplicateCondition] mandelbulber2-2.20/mandelbulber2/src/interface.cpp:790:6: note: First condition mandelbulber2-2.20/mandelbulber2/src/interface.cpp:791:6: note: Second condition mandelbulber2-2.20/mandelbulber2/src/interface.cpp:2424:7: style: Condition 'stopRequest' is always false [knownConditionTrueFalse] mandelbulber2-2.20/mandelbulber2/src/interface.cpp:2418:16: note: Assignment 'stopRequest=false', assigned value is 0 mandelbulber2-2.20/mandelbulber2/src/interface.cpp:2424:7: note: Condition 'stopRequest' is always false mandelbulber2-2.20/mandelbulber2/src/interface.cpp:2343:4: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] mandelbulber2-2.20/mandelbulber2/src/calculate_distance.hpp:75:17: performance: Function parameter 'point' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/calculate_distance.hpp:75:39: performance: Function parameter 'direction' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/calculate_distance.hpp:75:65: performance: Function parameter 'orthDirection' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/interface.cpp:1129:49: performance: Function parameter 'point' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/interface.cpp:1937:81: style: Consider using std::any_of, std::all_of, std::none_of, or std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] mandelbulber2-2.20/mandelbulber2/src/interface.cpp:2098:5: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] mandelbulber2-2.20/mandelbulber2/src/lights.cpp:61:2: performance: Variable 'dummyLight' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/src/marchingcubes.cpp:196:7: style: Condition '!openClEnabled' is always true [knownConditionTrueFalse] mandelbulber2-2.20/mandelbulber2/src/marchingcubes.cpp:120:23: note: Assignment 'openClEnabled=false', assigned value is 0 mandelbulber2-2.20/mandelbulber2/src/marchingcubes.cpp:196:7: note: Condition '!openClEnabled' is always true mandelbulber2-2.20/mandelbulber2/src/marchingcubes.cpp:107:3: style: Throwing a copy of the caught exception instead of rethrowing the original exception. [exceptRethrowCopy] mandelbulber2-2.20/mandelbulber2/src/marchingcubes.cpp:428:24: warning: Either the condition 'tri!=-1' is redundant, otherwise there is negative array index -1. [negativeContainerIndex] mandelbulber2-2.20/mandelbulber2/src/marchingcubes.cpp:427:53: note: Assuming that condition 'tri!=-1' is not redundant mandelbulber2-2.20/mandelbulber2/src/marchingcubes.cpp:428:24: note: Negative array index mandelbulber2-2.20/mandelbulber2/src/material.cpp:82:21: style: Variable 'iridescenceEnabled' is reassigned a value before the old one has been used. [redundantAssignment] mandelbulber2-2.20/mandelbulber2/src/material.cpp:69:21: note: iridescenceEnabled is assigned mandelbulber2-2.20/mandelbulber2/src/material.cpp:82:21: note: iridescenceEnabled is overwritten mandelbulber2-2.20/mandelbulber2/src/material_item_view.h:48:2: style: Class 'cMaterialItemView' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/mesh_export.cpp:51:56: performance: Function parameter 'limitMin' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/mesh_export.cpp:51:75: performance: Function parameter 'limitMax' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/morph.cpp:77:32: style:inconclusive: Function 'AddData' argument 1 names different: declaration 'keyframe' definition 'keyFrame'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/morph.hpp:67:25: note: Function 'AddData' argument 1 names different: declaration 'keyframe' definition 'keyFrame'. mandelbulber2-2.20/mandelbulber2/src/morph.cpp:77:32: note: Function 'AddData' argument 1 names different: declaration 'keyframe' definition 'keyFrame'. mandelbulber2-2.20/mandelbulber2/src/multi_val.cpp:217:10: style: Boolean value assigned to floating point variable. [assignBoolToFloat] mandelbulber2-2.20/mandelbulber2/src/netrender_file_sender.hpp:47:2: style: Class 'cNetRenderFileSender' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/netrender_file_receiver.hpp:19:2: style: Class 'cNetRenderFileReceiver' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/netrender_file_sender.cpp:42:2: performance: Variable 'actualFileSize' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/src/netrender_file_sender.cpp:43:2: performance: Variable 'actualChunkIndex' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/src/netrender_file_sender.cpp:44:2: performance: Variable 'actualNumberOfChunks' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/src/netrender_server.cpp:518:31: portability: Assigning a pointer to an integer is not portable. [AssignmentAddressToInteger] mandelbulber2-2.20/mandelbulber2/src/netrender_server.cpp:55:2: performance: Variable 'actualId' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/src/netrender_server.cpp:57:2: performance: Variable 'portNo' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/src/netrender_server.cpp:649:17: style: Local variable 'stream' shadows outer variable [shadowVariable] mandelbulber2-2.20/mandelbulber2/src/netrender_server.cpp:613:15: note: Shadowed declaration mandelbulber2-2.20/mandelbulber2/src/netrender_server.cpp:649:17: note: Shadow variable mandelbulber2-2.20/mandelbulber2/src/netrender_server.cpp:670:16: style: Local variable 'stream' shadows outer variable [shadowVariable] mandelbulber2-2.20/mandelbulber2/src/netrender_server.cpp:613:15: note: Shadowed declaration mandelbulber2-2.20/mandelbulber2/src/netrender_server.cpp:670:16: note: Shadow variable mandelbulber2-2.20/mandelbulber2/src/nine_fractals.cpp:68:2: warning: Class 'cNineFractals' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] mandelbulber2-2.20/mandelbulber2/src/nine_fractals.cpp:68:2: warning: Class 'cNineFractals' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] mandelbulber2-2.20/mandelbulber2/src/nine_fractals.cpp:105:17: style: Redundant condition: !isBoolean. 'isBoolean || (!isBoolean && !isHybrid)' is equivalent to 'isBoolean || !isHybrid' [redundantCondition] mandelbulber2-2.20/mandelbulber2/src/nine_fractals.cpp:66:55: style:inconclusive: Function 'cNineFractals' argument 1 names different: declaration 'fractalPar' definition 'par'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/nine_fractals.hpp:58:41: note: Function 'cNineFractals' argument 1 names different: declaration 'fractalPar' definition 'par'. mandelbulber2-2.20/mandelbulber2/src/nine_fractals.cpp:66:55: note: Function 'cNineFractals' argument 1 names different: declaration 'fractalPar' definition 'par'. mandelbulber2-2.20/mandelbulber2/src/nine_fractals.cpp:174:14: style: Consider using std::fill algorithm instead of a raw loop. [useStlAlgorithm] mandelbulber2-2.20/mandelbulber2/src/old_settings.cpp:54:2: warning: Class 'cOldSettings' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] mandelbulber2-2.20/mandelbulber2/src/old_settings.cpp:54:2: warning: Class 'cOldSettings' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] mandelbulber2-2.20/mandelbulber2/src/old_settings.cpp:102:12: warning: fscanf() without field width limits can crash with huge input data. [invalidscanf] mandelbulber2-2.20/mandelbulber2/src/old_settings.cpp:105:9: warning: fscanf() without field width limits can crash with huge input data. [invalidscanf] mandelbulber2-2.20/mandelbulber2/src/old_settings.cpp:106:9: warning: fscanf() without field width limits can crash with huge input data. [invalidscanf] mandelbulber2-2.20/mandelbulber2/src/old_settings.cpp:109:9: warning: fscanf() without field width limits can crash with huge input data. [invalidscanf] mandelbulber2-2.20/mandelbulber2/src/old_settings.cpp:106:7: style: Variable 'c' is reassigned a value before the old one has been used. [redundantAssignment] mandelbulber2-2.20/mandelbulber2/src/old_settings.cpp:105:7: note: c is assigned mandelbulber2-2.20/mandelbulber2/src/old_settings.cpp:106:7: note: c is overwritten mandelbulber2-2.20/mandelbulber2/src/old_settings.cpp:109:7: style: Variable 'c' is reassigned a value before the old one has been used. [redundantAssignment] mandelbulber2-2.20/mandelbulber2/src/old_settings.cpp:106:7: note: c is assigned mandelbulber2-2.20/mandelbulber2/src/old_settings.cpp:109:7: note: c is overwritten mandelbulber2-2.20/mandelbulber2/src/old_settings.cpp:87:7: style: The scope of the variable 'str1' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/old_settings.cpp:88:7: style: The scope of the variable 'str2' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/old_settings.cpp:93:6: style: The scope of the variable 'lineCounter' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/old_settings.cpp:944:63: style:inconclusive: Function 'ConvertToNewContainer' argument 1 names different: declaration 'params' definition 'par'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/old_settings.hpp:502:50: note: Function 'ConvertToNewContainer' argument 1 names different: declaration 'params' definition 'par'. mandelbulber2-2.20/mandelbulber2/src/old_settings.cpp:944:63: note: Function 'ConvertToNewContainer' argument 1 names different: declaration 'params' definition 'par'. mandelbulber2-2.20/mandelbulber2/src/old_settings.cpp:1347:6: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] mandelbulber2-2.20/mandelbulber2/src/old_settings.cpp:109:7: style: Variable 'c' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/opencl_engine.cpp:46:47: style:inconclusive: Function 'cOpenClEngine' argument 1 names different: declaration 'hardware' definition '_hardware'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/opencl_engine.h:72:33: note: Function 'cOpenClEngine' argument 1 names different: declaration 'hardware' definition '_hardware'. mandelbulber2-2.20/mandelbulber2/src/opencl_engine.cpp:46:47: note: Function 'cOpenClEngine' argument 1 names different: declaration 'hardware' definition '_hardware'. mandelbulber2-2.20/mandelbulber2/src/opencl_engine_render_dof_phase1.h:55:2: style: Class 'cOpenClEngineRenderDOFPhase1' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/opencl_engine_render_dof_phase2.h:56:2: style: Class 'cOpenClEngineRenderDOFPhase2' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/opencl_engine_render_dof.cpp:50:65: style:inconclusive: Function 'cOpenClEngineRenderDOF' argument 1 names different: declaration '_hardware' definition 'hardware'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/opencl_engine_render_dof.h:54:42: note: Function 'cOpenClEngineRenderDOF' argument 1 names different: declaration '_hardware' definition 'hardware'. mandelbulber2-2.20/mandelbulber2/src/opencl_engine_render_dof.cpp:50:65: note: Function 'cOpenClEngineRenderDOF' argument 1 names different: declaration '_hardware' definition 'hardware'. mandelbulber2-2.20/mandelbulber2/src/opencl_scheduler.h:57:6: style:inconclusive: Technically the member function 'cOpenClScheduler::IsTileEnabled' can be const. [functionConst] mandelbulber2-2.20/mandelbulber2/src/opencl_scheduler.h:52:2: style: Class 'cOpenClScheduler' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/opencl_engine_render_fractal.cpp:74:73: style:inconclusive: Function 'cOpenClEngineRenderFractal' argument 1 names different: declaration 'hardware' definition '_hardware'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/opencl_engine_render_fractal.h:76:46: note: Function 'cOpenClEngineRenderFractal' argument 1 names different: declaration 'hardware' definition '_hardware'. mandelbulber2-2.20/mandelbulber2/src/opencl_engine_render_fractal.cpp:74:73: note: Function 'cOpenClEngineRenderFractal' argument 1 names different: declaration 'hardware' definition '_hardware'. mandelbulber2-2.20/mandelbulber2/src/opencl_engine_render_ssao.cpp:45:67: style:inconclusive: Function 'cOpenClEngineRenderSSAO' argument 1 names different: declaration 'hardware' definition '_hardware'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/opencl_engine_render_ssao.h:56:43: note: Function 'cOpenClEngineRenderSSAO' argument 1 names different: declaration 'hardware' definition '_hardware'. mandelbulber2-2.20/mandelbulber2/src/opencl_engine_render_ssao.cpp:45:67: note: Function 'cOpenClEngineRenderSSAO' argument 1 names different: declaration 'hardware' definition '_hardware'. mandelbulber2-2.20/mandelbulber2/src/opencl_global.cpp:46:16: warning: Member variable 'cGlobalOpenCl::openClEngineRenderFractal' is not initialized in the constructor. [uninitMemberVar] mandelbulber2-2.20/mandelbulber2/src/opencl_global.cpp:46:16: warning: Member variable 'cGlobalOpenCl::openClEngineRenderSSAO' is not initialized in the constructor. [uninitMemberVar] mandelbulber2-2.20/mandelbulber2/src/opencl_global.cpp:46:16: warning: Member variable 'cGlobalOpenCl::openclEngineRenderDOF' is not initialized in the constructor. [uninitMemberVar] mandelbulber2-2.20/mandelbulber2/src/opencl_global.cpp:46:16: warning: Member variable 'cGlobalOpenCl::openClHardware' is not initialized in the constructor. [uninitMemberVar] mandelbulber2-2.20/mandelbulber2/src/opencl_hardware.cpp:46:2: performance: Variable 'selectedDevicesIndices' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/src/opencl_scheduler.cpp:113:20: style: Variable 'status' can be declared as reference to const [constVariable] mandelbulber2-2.20/mandelbulber2/src/opencl_scheduler.cpp:115:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] mandelbulber2-2.20/mandelbulber2/src/orbit_trap_shape.cpp:41:40: style:inconclusive: Function 'OrbitTrapShapeDistance' argument 1 names different: declaration 'z' definition 'z4'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/orbit_trap_shape.hpp:40:40: note: Function 'OrbitTrapShapeDistance' argument 1 names different: declaration 'z' definition 'z4'. mandelbulber2-2.20/mandelbulber2/src/orbit_trap_shape.cpp:41:40: note: Function 'OrbitTrapShapeDistance' argument 1 names different: declaration 'z' definition 'z4'. mandelbulber2-2.20/mandelbulber2/src/orbit_trap_shape.cpp:41:40: performance: Function parameter 'z4' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/parameters.cpp:58:43: warning:inconclusive: Member variable 'cParameterContainer::m_lock' is not assigned a value in 'cParameterContainer::operator='. [operatorEqVarError] mandelbulber2-2.20/mandelbulber2/src/parameters.hpp:102:25: performance:inconclusive: Technically the member function 'cParameterContainer::getImageMeta' can be static (but you may consider moving to unnamed namespace). [functionStatic] mandelbulber2-2.20/mandelbulber2/src/parameters.cpp:641:45: note: Technically the member function 'cParameterContainer::getImageMeta' can be static (but you may consider moving to unnamed namespace). mandelbulber2-2.20/mandelbulber2/src/parameters.hpp:102:25: note: Technically the member function 'cParameterContainer::getImageMeta' can be static (but you may consider moving to unnamed namespace). mandelbulber2-2.20/mandelbulber2/src/parameters.cpp:192:63: performance: Function parameter 'defaultVal' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/parameters.cpp:192:77: performance: Function parameter 'minVal' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/parameters.cpp:192:87: performance: Function parameter 'maxVal' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/parameters.cpp:430:53: style: Parameter 'str' can be declared as pointer to const [constParameter] mandelbulber2-2.20/mandelbulber2/src/post_effect_hdr_blur.cpp:72:21: style: Variable 'percentDone' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/primitives.h:184:16: style: Unused private function: 'cPrimitives::Plane' [unusedPrivateFunction] mandelbulber2-2.20/mandelbulber2/src/primitives.cpp:396:9: style: The scope of the variable 'objectWave' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/primitives.cpp:410:10: style: The scope of the variable 'waveXTemp' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/primitives.cpp:411:10: style: The scope of the variable 'waveYTemp' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/primitives.cpp:286:52: performance: Function parameter '_point' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/primitives.cpp:294:50: performance: Function parameter '_point' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/primitives.cpp:318:53: performance: Function parameter '_point' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/primitives.cpp:327:56: performance: Function parameter '_point' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/primitives.cpp:338:55: performance: Function parameter '_point' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/primitives.cpp:351:53: performance: Function parameter '_point' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/primitives.cpp:361:51: performance: Function parameter '_point' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/primitives.cpp:382:57: performance: Function parameter '_point' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/primitives.cpp:442:52: performance: Function parameter '_point' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/primitives.cpp:453:44: performance: Function parameter 'point' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/primitives.cpp:116:5: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] mandelbulber2-2.20/mandelbulber2/src/progress_text.cpp:70:29: style: Condition 'filter' is always true [knownConditionTrueFalse] mandelbulber2-2.20/mandelbulber2/src/progress_text.cpp:68:17: note: Assignment 'filter=true', assigned value is 1 mandelbulber2-2.20/mandelbulber2/src/progress_text.cpp:70:29: note: Condition 'filter' is always true mandelbulber2-2.20/mandelbulber2/src/projection_3d.cpp:89:35: performance: Function parameter 'point' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/projection_3d.cpp:89:51: performance: Function parameter 'camera' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/projection_3d.cpp:89:75: performance: Function parameter 'mRotInv' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/projection_3d.cpp:93:16: style: Variable 'baseZ' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/render_queue.hpp:58:2: style: Class 'cRenderQueue' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] mandelbulber2-2.20/mandelbulber2/src/queue.cpp:716:14: style: Local variable 'j' shadows outer argument [shadowArgument] mandelbulber2-2.20/mandelbulber2/src/queue.cpp:694:49: note: Shadowed declaration mandelbulber2-2.20/mandelbulber2/src/queue.cpp:716:14: note: Shadow variable mandelbulber2-2.20/mandelbulber2/src/queue.cpp:362:3: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] mandelbulber2-2.20/mandelbulber2/src/render_image.cpp:590:33: style: C-style pointer casting [cstyleCast] mandelbulber2-2.20/mandelbulber2/src/render_image.cpp:625:44: style:inconclusive: Function 'ToDoListArrived' argument 1 names different: declaration 'done' definition 'toDo'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/render_image.hpp:87:34: note: Function 'ToDoListArrived' argument 1 names different: declaration 'done' definition 'toDo'. mandelbulber2-2.20/mandelbulber2/src/render_image.cpp:625:44: note: Function 'ToDoListArrived' argument 1 names different: declaration 'done' definition 'toDo'. mandelbulber2-2.20/mandelbulber2/src/render_job.cpp:804:60: style: Parameter 'cameraTarget' can be declared as reference to const [constParameter] mandelbulber2-2.20/mandelbulber2/src/render_queue.cpp:187:2: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] mandelbulber2-2.20/mandelbulber2/src/render_queue.cpp:192:2: note: Found duplicate branches for 'if' and 'else'. mandelbulber2-2.20/mandelbulber2/src/render_queue.cpp:187:2: note: Found duplicate branches for 'if' and 'else'. mandelbulber2-2.20/mandelbulber2/src/render_queue.cpp:209:2: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] mandelbulber2-2.20/mandelbulber2/src/render_queue.cpp:214:2: note: Found duplicate branches for 'if' and 'else'. mandelbulber2-2.20/mandelbulber2/src/render_queue.cpp:209:2: note: Found duplicate branches for 'if' and 'else'. mandelbulber2-2.20/mandelbulber2/src/render_worker.cpp:69:2: performance: Variable 'baseX' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/src/render_worker.cpp:558:2: warning: Possible leak in public function. The pointer 'AOVectorsAround' is not deallocated before it is allocated. [publicAllocationError] mandelbulber2-2.20/mandelbulber2/src/render_worker.cpp:604:47: performance: Function parameter 'point' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/render_worker.cpp:636:42: performance: Function parameter 'point' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/render_worker.cpp:824:18: performance: Function parameter 'in' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/rendered_image_widget.cpp:407:8: style: Same expression used in consecutive assignments of 'boxWidth' and 'boxHeight'. [duplicateAssignExpression] mandelbulber2-2.20/mandelbulber2/src/rendered_image_widget.cpp:408:8: note: Same expression used in consecutive assignments of 'boxWidth' and 'boxHeight'. mandelbulber2-2.20/mandelbulber2/src/rendered_image_widget.cpp:407:8: note: Same expression used in consecutive assignments of 'boxWidth' and 'boxHeight'. mandelbulber2-2.20/mandelbulber2/src/rendered_image_widget.cpp:408:8: style: Same expression used in consecutive assignments of 'boxHeight' and 'boxDepth'. [duplicateAssignExpression] mandelbulber2-2.20/mandelbulber2/src/rendered_image_widget.cpp:409:8: note: Same expression used in consecutive assignments of 'boxHeight' and 'boxDepth'. mandelbulber2-2.20/mandelbulber2/src/rendered_image_widget.cpp:408:8: note: Same expression used in consecutive assignments of 'boxHeight' and 'boxDepth'. mandelbulber2-2.20/mandelbulber2/src/rendered_image_widget.cpp:400:42: style:inconclusive: Function 'Draw3DBox' argument 3 names different: declaration 'point' definition 'p'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/rendered_image_widget.hpp:146:43: note: Function 'Draw3DBox' argument 3 names different: declaration 'point' definition 'p'. mandelbulber2-2.20/mandelbulber2/src/rendered_image_widget.cpp:400:42: note: Function 'Draw3DBox' argument 3 names different: declaration 'point' definition 'p'. mandelbulber2-2.20/mandelbulber2/src/rendered_image_widget.cpp:1085:46: style:inconclusive: Function 'SetGridType' argument 1 names different: declaration 'gridType' definition '_gridType'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/rendered_image_widget.hpp:109:32: note: Function 'SetGridType' argument 1 names different: declaration 'gridType' definition '_gridType'. mandelbulber2-2.20/mandelbulber2/src/rendered_image_widget.cpp:1085:46: note: Function 'SetGridType' argument 1 names different: declaration 'gridType' definition '_gridType'. mandelbulber2-2.20/mandelbulber2/src/rendered_image_widget.cpp:193:16: style: Local variable 'clickMode' shadows outer variable [shadowVariable] mandelbulber2-2.20/mandelbulber2/src/rendered_image_widget.hpp:173:16: note: Shadowed declaration mandelbulber2-2.20/mandelbulber2/src/rendered_image_widget.cpp:193:16: note: Shadow variable mandelbulber2-2.20/mandelbulber2/src/resource_http_provider.cpp:47:2: performance: Variable 'filename' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/src/resource_http_provider.cpp:45:55: style:inconclusive: Function 'cResourceHttpProvider' argument 1 names different: declaration 'filename' definition '_filename'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/resource_http_provider.hpp:47:33: note: Function 'cResourceHttpProvider' argument 1 names different: declaration 'filename' definition '_filename'. mandelbulber2-2.20/mandelbulber2/src/resource_http_provider.cpp:45:55: note: Function 'cResourceHttpProvider' argument 1 names different: declaration 'filename' definition '_filename'. mandelbulber2-2.20/mandelbulber2/src/resource_http_provider.cpp:45:55: style: Parameter '_filename' can be declared as reference to const [constParameter] mandelbulber2-2.20/mandelbulber2/src/scheduler.cpp:54:2: performance: Variable 'stopRequest' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/src/scheduler.cpp:51:2: warning: Class 'cScheduler' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] mandelbulber2-2.20/mandelbulber2/src/scheduler.cpp:51:2: warning: Class 'cScheduler' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] mandelbulber2-2.20/mandelbulber2/src/scheduler.cpp:75:48: style:inconclusive: Function 'ThereIsStillSomethingToDo' argument 1 names different: declaration 'ThreadId' definition 'threadId'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/scheduler.hpp:57:37: note: Function 'ThereIsStillSomethingToDo' argument 1 names different: declaration 'ThreadId' definition 'threadId'. mandelbulber2-2.20/mandelbulber2/src/scheduler.cpp:75:48: note: Function 'ThereIsStillSomethingToDo' argument 1 names different: declaration 'ThreadId' definition 'threadId'. mandelbulber2-2.20/mandelbulber2/src/settings.hpp:84:7: style:inconclusive: Technically the member function 'cSettings::PreCompatibilityMaterials' can be const. [functionConst] mandelbulber2-2.20/mandelbulber2/src/settings.cpp:1386:17: note: Technically the member function 'cSettings::PreCompatibilityMaterials' can be const. mandelbulber2-2.20/mandelbulber2/src/settings.hpp:84:7: note: Technically the member function 'cSettings::PreCompatibilityMaterials' can be const. mandelbulber2-2.20/mandelbulber2/src/settings.cpp:474:6: style: The scope of the variable 'errorCount' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/settings.cpp:475:6: style: The scope of the variable 'csvLine' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/settings.cpp:1252:6: style: The scope of the variable 'column' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/settings.cpp:80:13: style: Variable 'parameterNameFromList' can be declared as reference to const [constVariable] mandelbulber2-2.20/mandelbulber2/src/settings.cpp:1292:16: style: Variable 'parameterDescription' can be declared as reference to const [constVariable] mandelbulber2-2.20/mandelbulber2/src/shader_ambient_occlusion.cpp:47:9: style: The scope of the variable 'intense' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/shader_aux_shadow.cpp:131:12: style: Variable 'opacity' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/shader_global_illumination.cpp:70:7: style: The scope of the variable 'objectId' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/shader_global_illumination.cpp:56:7: style: Local variable 'finished' shadows outer function [shadowFunction] mandelbulber2-2.20/mandelbulber2/src/render_worker.hpp:286:7: note: Shadowed declaration mandelbulber2-2.20/mandelbulber2/src/shader_global_illumination.cpp:56:7: note: Shadow variable mandelbulber2-2.20/mandelbulber2/src/shader_global_illumination.cpp:120:15: style: Local variable 'objectColor' shadows outer argument [shadowArgument] mandelbulber2-2.20/mandelbulber2/src/shader_global_illumination.cpp:42:44: note: Shadowed declaration mandelbulber2-2.20/mandelbulber2/src/shader_global_illumination.cpp:120:15: note: Shadow variable mandelbulber2-2.20/mandelbulber2/src/shader_global_illumination.cpp:50:22: style: Variable 'inputCopy.stepCount' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/shader_global_illumination.cpp:70:16: style: Variable 'objectId' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/shader_main_shadow.cpp:130:12: style: Variable 'opacity' is assigned a value that is never used. [unreadVariable] mandelbulber2-2.20/mandelbulber2/src/shader_object.cpp:39:64: style:inconclusive: Function 'ObjectShader' argument 1 names different: declaration 'input' definition '_input'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/render_worker.hpp:222:50: note: Function 'ObjectShader' argument 1 names different: declaration 'input' definition '_input'. mandelbulber2-2.20/mandelbulber2/src/shader_object.cpp:39:64: note: Function 'ObjectShader' argument 1 names different: declaration 'input' definition '_input'. mandelbulber2-2.20/mandelbulber2/src/shader_object.cpp:40:38: style:inconclusive: Function 'ObjectShader' argument 4 names different: declaration 'iridescence' definition 'iridescenceOut'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/render_worker.hpp:223:39: note: Function 'ObjectShader' argument 4 names different: declaration 'iridescence' definition 'iridescenceOut'. mandelbulber2-2.20/mandelbulber2/src/shader_object.cpp:40:38: note: Function 'ObjectShader' argument 4 names different: declaration 'iridescence' definition 'iridescenceOut'. mandelbulber2-2.20/mandelbulber2/src/shader_specular_highlight.cpp:38:85: performance: Function parameter 'lightVector' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/shader_specular_highlight_combined.cpp:40:11: performance: Function parameter 'lightVector' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/stereo.cpp:65:11: performance: Function parameter 'camera' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/stereo.cpp:65:28: performance: Function parameter 'direction' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/stereo.cpp:65:48: performance: Function parameter 'top' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/system.cpp:414:34: style:inconclusive: Function 'CreateFolder' argument 1 names different: declaration 'name' definition 'qName'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/system.hpp:207:34: note: Function 'CreateFolder' argument 1 names different: declaration 'name' definition 'qName'. mandelbulber2-2.20/mandelbulber2/src/system.cpp:414:34: note: Function 'CreateFolder' argument 1 names different: declaration 'name' definition 'qName'. mandelbulber2-2.20/mandelbulber2/src/system.cpp:903:56: style:inconclusive: Function 'DeleteOldChache' argument 2 names different: declaration 'days' definition 'maxDays'. [funcArgNamesDifferent] mandelbulber2-2.20/mandelbulber2/src/system.hpp:206:56: note: Function 'DeleteOldChache' argument 2 names different: declaration 'days' definition 'maxDays'. mandelbulber2-2.20/mandelbulber2/src/system.cpp:903:56: note: Function 'DeleteOldChache' argument 2 names different: declaration 'days' definition 'maxDays'. mandelbulber2-2.20/mandelbulber2/src/test.cpp:584:10: style: The if condition is the same as the previous if condition [duplicateCondition] mandelbulber2-2.20/mandelbulber2/src/test.cpp:566:10: note: First condition mandelbulber2-2.20/mandelbulber2/src/test.cpp:584:10: note: Second condition mandelbulber2-2.20/mandelbulber2/src/texture.hpp:80:10: style: Unused private function: 'cTexture::LinearInterpolation' [unusedPrivateFunction] mandelbulber2-2.20/mandelbulber2/src/texture.cpp:143:21: warning: 'operator=' should check for assignment to self to avoid problems with dynamic memory. [operatorEqToSelf] mandelbulber2-2.20/mandelbulber2/src/texture.cpp:136:2: performance: Variable 'originalFileName' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] mandelbulber2-2.20/mandelbulber2/src/texture.cpp:405:18: style: The scope of the variable 'bigBitmap' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/texture.cpp:405:30: style: The scope of the variable 'smallBitmap' can be reduced. [variableScope] mandelbulber2-2.20/mandelbulber2/src/texture_mapping.cpp:44:42: performance: Function parameter 'inPoint' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/trace_behind.cpp:44:11: performance: Function parameter 'viewVector' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/voxel_export.cpp:185:7: style: Condition '!openClEnabled' is always true [knownConditionTrueFalse] mandelbulber2-2.20/mandelbulber2/src/voxel_export.cpp:106:23: note: Assignment 'openClEnabled=false', assigned value is 0 mandelbulber2-2.20/mandelbulber2/src/voxel_export.cpp:185:7: note: Condition '!openClEnabled' is always true mandelbulber2-2.20/mandelbulber2/src/voxel_export.cpp:60:32: performance: Function parameter 'limitMin' should be passed by const reference. [passedByValue] mandelbulber2-2.20/mandelbulber2/src/voxel_export.cpp:60:51: performance: Function parameter 'limitMax' should be passed by const reference. [passedByValue] DONE