2026-05-27 22:59 ftp://ftp.de.debian.org/debian/pool/main/m/maelstrom/maelstrom_4.0.1+ds2.orig.tar.xz cppcheck-options: --library=posix --library=gnu --library=bsd --inconclusive --enable=style,information --inline-suppr --template=daca2 --disable=missingInclude --suppress=unmatchedSuppression --check-library --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=normalCheckLevelConditionExpressions -D__GNUC__ --platform=unix64 -j6 platform: Linux-7.0.7+deb14-amd64-x86_64-with-glibc2.42 python: 3.13.12 client-version: 1.4.0 compiler: g++ (Debian 15.2.0-17) 15.2.0 cppcheck: head 2.20.0 head-info: 6e46c6ba (2026-05-27 18:39:55 +0200) count: 251 789 elapsed-time: 1.9 4.9 head-timing-info: old-timing-info: head results: Maelstrom-4.0.1/external/physfs/extras/physfssdl3.c:41:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_IO_SEEK_SET [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/physfs/extras/physfssdl3.c:181:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PHYSFS_ENUM_ERROR [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/physfs/extras/physfssdl3.c:205:56: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_PATHTYPE_FILE [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/physfs/extras/physfssdl3.c:280:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_MAX_UINT64 [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/physfs/extras/physfssdl3.c:159:51: style: Parameter 'userdata' can be declared as pointer to const. However it seems that 'physfssdl3storage_close' is a callback function, if 'userdata' is declared with const you might also need to cast function pointer(s). [constParameterCallback] Maelstrom-4.0.1/external/physfs/extras/physfssdl3.c:287:19: note: You might need to cast the function pointer here Maelstrom-4.0.1/external/physfs/extras/physfssdl3.c:159:51: note: Parameter 'userdata' can be declared as pointer to const Maelstrom-4.0.1/external/physfs/extras/physfssdl3.c:164:51: style: Parameter 'userdata' can be declared as pointer to const. However it seems that 'physfssdl3storage_ready' is a callback function, if 'userdata' is declared with const you might also need to cast function pointer(s). [constParameterCallback] Maelstrom-4.0.1/external/physfs/extras/physfssdl3.c:288:19: note: You might need to cast the function pointer here Maelstrom-4.0.1/external/physfs/extras/physfssdl3.c:164:51: note: Parameter 'userdata' can be declared as pointer to const Maelstrom-4.0.1/external/physfs/extras/physfssdl3.c:273:52: style: Parameter 'userdata' can be declared as pointer to const. However it seems that 'physfssdl3storage_rename' is a callback function, if 'userdata' is declared with const you might also need to cast function pointer(s). [constParameterCallback] Maelstrom-4.0.1/external/physfs/extras/physfssdl3.c:295:20: note: You might need to cast the function pointer here Maelstrom-4.0.1/external/physfs/extras/physfssdl3.c:273:52: note: Parameter 'userdata' can be declared as pointer to const Maelstrom-4.0.1/external/physfs/extras/physfssdl3.c:278:63: style: Parameter 'userdata' can be declared as pointer to const. However it seems that 'physfssdl3storage_space_remaining' is a callback function, if 'userdata' is declared with const you might also need to cast function pointer(s). [constParameterCallback] Maelstrom-4.0.1/external/physfs/extras/physfssdl3.c:296:29: note: You might need to cast the function pointer here Maelstrom-4.0.1/external/physfs/extras/physfssdl3.c:278:63: note: Parameter 'userdata' can be declared as pointer to const Maelstrom-4.0.1/utils/rapidxml.h:30:12: error: syntax error [syntaxError] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:211:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_NET_VERSION [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:291:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable errno [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:323:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EAI_SYSTEM [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:366:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable F_GETFL [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:375:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable EWOULDBLOCK [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:848:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NET_FAILURE [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:904:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NET_FAILURE [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:936:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_PROP_THREAD_CREATE_ENTRY_FUNCTION_POINTER [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:965:82: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NI_NUMERICHOST [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:1019:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SIG_IGN [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:1205:70: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NET_WAITING [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:1230:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NET_FAILURE [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:1246:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NET_FAILURE [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:1352:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AF_UNSPEC [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:1392:66: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NET_SUCCESS [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:1452:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NET_WAITING [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:1488:68: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NET_SUCCESS [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:1617:111: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NI_NUMERICSERV [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:1785:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable POLLOUT [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:1892:68: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NET_SUCCESS [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:2001:64: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SOCK_DGRAM [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:2038:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NET_FAILURE [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:2074:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NET_FAILURE [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:2148:126: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NI_NUMERICHOST [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:2322:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NET_WAITING [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/game/fastrand.cpp:33:24: style:inconclusive: Function 'SeedRandom' argument 1 names different: declaration 'seed' definition 'Seed'. [funcArgNamesDifferent] Maelstrom-4.0.1/game/fastrand.h:24:33: note: Function 'SeedRandom' argument 1 names different: declaration 'seed' definition 'Seed'. Maelstrom-4.0.1/game/fastrand.cpp:33:24: note: Function 'SeedRandom' argument 1 names different: declaration 'seed' definition 'Seed'. Maelstrom-4.0.1/game/main.cpp:145:2: error: failed to evaluate #if condition, undefined function-like macro invocation: SDL_VERSION_ATLEAST( ... ) [syntaxError] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:808:34: style: Condition '!InitInterfaceChangeNotifications()' is always false [knownConditionTrueFalse] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:808:67: note: Calling function 'InitInterfaceChangeNotifications' returns 1 Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:808:34: note: Condition '!InitInterfaceChangeNotifications()' is always false Maelstrom-4.0.1/game/myerror.cpp:35:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_LOG_CATEGORY_APPLICATION [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/game/myerror.cpp:46:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_LOG_CATEGORY_APPLICATION [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/game/myerror.cpp:30:10: style: Local variable 'mesg' shadows outer function [shadowFunction] Maelstrom-4.0.1/game/myerror.h:28:13: note: Shadowed function Maelstrom-4.0.1/game/myerror.cpp:30:10: note: Shadow local variable Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:1264:32: warning: Either the condition 'sdlnetb' is redundant or there is possible null pointer dereference: sdlnetb. [nullPointerRedundantCheck] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:1259:28: note: Assuming that condition 'sdlnetb' is not redundant Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:1264:32: note: Null pointer dereference Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:1271:31: warning: Either the condition 'b' is redundant or there is possible null pointer dereference: b. [nullPointerRedundantCheck] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:1269:22: note: Assuming that condition 'b' is not redundant Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:1271:31: note: Null pointer dereference Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:1281:35: warning: Either the condition 'b' is redundant or there is possible null pointer dereference: b. [nullPointerRedundantCheck] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:1269:22: note: Assuming that condition 'b' is not redundant Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:1281:35: note: Null pointer dereference Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:2155:18: style: Local variable 'i' shadows outer variable [shadowVariable] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:2130:14: note: Shadowed variable Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:2155:18: note: Shadow local variable Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:2167:22: style: Local variable 'i' shadows outer variable [shadowVariable] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:2130:14: note: Shadowed variable Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:2167:22: note: Shadow local variable Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:2156:30: style: Pointer expression 'latest_recv_addrs' converted to bool is always true. [knownPointerToBool] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:869:41: style: Parameter 'data' can be declared as pointer to const. However it seems that 'ResolverThread' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:936:91: note: You might need to cast the function pointer here Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:869:41: note: Parameter 'data' can be declared as pointer to const Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:1514:31: style: Variable 'i' can be declared as pointer to const [constVariablePointer] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:1587:35: style: Parameter 'server' can be declared as pointer to const [constParameterPointer] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:1918:31: style: Variable 'i' can be declared as pointer to const [constVariablePointer] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:1999:74: style: Parameter 'addr' can be declared as pointer to const [constParameterPointer] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:237:9: style: struct member 'NetworkInterfaces::index' is never used. [unusedStructMember] Maelstrom-4.0.1/game/steam.cpp:694:57: style: Parameter 'gamepad' can be declared as pointer to const [constParameterPointer] Maelstrom-4.0.1/game/steam.cpp:699:63: style: Parameter 'gamepad' can be declared as pointer to const [constParameterPointer] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.h:88:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_WINDOW_FULLSCREEN [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.h:141:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_ALPHA_OPAQUE [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.h:144:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_ALPHA_OPAQUE [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/maclib/Mac_FontServ.cpp:215:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Uint16 [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/maclib/Mac_FontServ.cpp:445:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Uint32 [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/maclib/Mac_Sound.cpp:34:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Uint8 [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/maclib/Mac_Sound.cpp:49:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_AUDIO_U8 [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/maclib/Mac_Sound.cpp:92:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/maclib/Mac_Sound.cpp:165:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Uint8 [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/maclib/Mac_Wave.cpp:186:3: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Uint32 [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/maclib/Mac_Wave.cpp:531:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Uint32 [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/maclib/Mac_Sound.h:34:9: warning: Member variable 'Wave::data' has no initializer. [uninitMemberVarNoCtor] Maelstrom-4.0.1/maclib/Mac_Sound.h:121:7: warning: Member variable 'channel::len' has no initializer. [uninitMemberVarNoCtor] Maelstrom-4.0.1/maclib/Mac_Sound.h:122:10: warning: Member variable 'channel::src' has no initializer. [uninitMemberVarNoCtor] Maelstrom-4.0.1/maclib/Mac_Sound.h:123:10: warning: Member variable 'channel::callback' has no initializer. [uninitMemberVarNoCtor] Maelstrom-4.0.1/maclib/Mac_Sound.cpp:46:2: performance: Variable 'volume' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] Maelstrom-4.0.1/maclib/Mac_Sound.h:46:8: style:inconclusive: Technically the member function 'Sound::Volume' can be const. [functionConst] Maelstrom-4.0.1/maclib/Mac_Sound.h:80:6: style:inconclusive: Technically the member function 'Sound::Playing' can be const. [functionConst] Maelstrom-4.0.1/maclib/Mac_Sound.h:94:9: style:inconclusive: Technically the member function 'Sound::Priority' can be const. [functionConst] Maelstrom-4.0.1/maclib/Mac_Sound.h:99:7: style:inconclusive: Technically the member function 'Sound::ChannelFree' can be const. [functionConst] Maelstrom-4.0.1/maclib/Mac_Sound.h:41:2: style: Class 'Sound' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] Maelstrom-4.0.1/maclib/Mac_Sound.h:42:11: style: The destructor '~Sound' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/utils/ErrorBase.h:30:11: note: Virtual destructor in base class Maelstrom-4.0.1/maclib/Mac_Sound.h:42:11: note: Destructor in derived class Maelstrom-4.0.1/maclib/Mac_Sound.cpp:31:17: style: C-style pointer casting [cstyleCast] Maelstrom-4.0.1/maclib/Mac_Sound.cpp:138:9: style: The scope of the variable 's' can be reduced. [variableScope] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.h:54:9: style: The member function 'FrameBuf::MapRGB' can be static. [functionStatic] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.h:57:7: style: The member function 'FrameBuf::GetRGB' can be static. [functionStatic] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.h:69:7: style:inconclusive: Technically the member function 'FrameBuf::GetClip' can be const. [functionConst] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.h:85:7: style:inconclusive: Technically the member function 'FrameBuf::GamepadMouseEnabled' can be const. [functionConst] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.h:133:7: style:inconclusive: Technically the member function 'FrameBuf::Fading' can be const. [functionConst] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.h:180:6: style: The member function 'FrameBuf::GetImageWidth' can be static. [functionStatic] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.h:183:6: style: The member function 'FrameBuf::GetImageHeight' can be static. [functionStatic] Maelstrom-4.0.1/maclib/Mac_FontServ.cpp:253:11: style: The member function 'FontServ::FreeFont' can be static. [functionStatic] Maelstrom-4.0.1/maclib/Mac_FontServ.h:108:7: note: The member function 'FontServ::FreeFont' can be static. Maelstrom-4.0.1/maclib/Mac_FontServ.cpp:253:11: note: The member function 'FontServ::FreeFont' can be static. Maelstrom-4.0.1/maclib/Mac_FontServ.cpp:277:11: style: The member function 'FontServ::TextWidth' can be static. [functionStatic] Maelstrom-4.0.1/maclib/Mac_FontServ.h:111:9: note: The member function 'FontServ::TextWidth' can be static. Maelstrom-4.0.1/maclib/Mac_FontServ.cpp:277:11: note: The member function 'FontServ::TextWidth' can be static. Maelstrom-4.0.1/maclib/Mac_FontServ.cpp:320:11: style: The member function 'FontServ::TextHeight' can be static. [functionStatic] Maelstrom-4.0.1/maclib/Mac_FontServ.h:112:9: note: The member function 'FontServ::TextHeight' can be static. Maelstrom-4.0.1/maclib/Mac_FontServ.cpp:320:11: note: The member function 'FontServ::TextHeight' can be static. Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < SDL_Gamepad * >' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < SDL_Gamepad * >' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] Maelstrom-4.0.1/maclib/Mac_FontServ.h:140:8: warning: The class 'FontServ' defines member function with name 'Error' also defined in its parent class 'ErrorBase'. [duplInheritedMember] Maelstrom-4.0.1/utils/ErrorBase.h:35:8: note: Parent function 'ErrorBase::Error' Maelstrom-4.0.1/maclib/Mac_FontServ.h:140:8: note: Derived function 'FontServ::Error' Maelstrom-4.0.1/screenlib/SDL_FrameBuf.h:50:11: style: The destructor '~FrameBuf' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/utils/ErrorBase.h:30:11: note: Virtual destructor in base class Maelstrom-4.0.1/screenlib/SDL_FrameBuf.h:50:11: note: Destructor in derived class Maelstrom-4.0.1/maclib/Mac_FontServ.h:104:11: style: The destructor '~FontServ' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/utils/ErrorBase.h:30:11: note: Virtual destructor in base class Maelstrom-4.0.1/maclib/Mac_FontServ.h:104:11: note: Destructor in derived class Maelstrom-4.0.1/maclib/Mac_FontServ.cpp:206:17: style: C-style pointer casting [cstyleCast] Maelstrom-4.0.1/maclib/Mac_FontServ.cpp:214:12: style: C-style pointer casting [cstyleCast] Maelstrom-4.0.1/maclib/Mac_FontServ.cpp:235:19: style: C-style pointer casting [cstyleCast] Maelstrom-4.0.1/maclib/Mac_FontServ.cpp:236:19: style: C-style pointer casting [cstyleCast] Maelstrom-4.0.1/maclib/Mac_FontServ.cpp:237:18: style: C-style pointer casting [cstyleCast] Maelstrom-4.0.1/maclib/Mac_FontServ.cpp:246:12: style: C-style pointer casting [cstyleCast] Maelstrom-4.0.1/maclib/Mac_FontServ.cpp:91:9: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] Maelstrom-4.0.1/maclib/Mac_FontServ.cpp:177:12: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] Maelstrom-4.0.1/maclib/Mac_FontServ.cpp:94:30: style:inconclusive: Function 'FontServ' argument 1 names different: declaration 'screen' definition '_screen'. [funcArgNamesDifferent] Maelstrom-4.0.1/maclib/Mac_FontServ.h:103:21: note: Function 'FontServ' argument 1 names different: declaration 'screen' definition '_screen'. Maelstrom-4.0.1/maclib/Mac_FontServ.cpp:94:30: note: Function 'FontServ' argument 1 names different: declaration 'screen' definition '_screen'. Maelstrom-4.0.1/maclib/Mac_FontServ.cpp:335:75: style:inconclusive: Function 'TextImage' argument 4 names different: declaration 'foreground' definition 'fg'. [funcArgNamesDifferent] Maelstrom-4.0.1/maclib/Mac_FontServ.h:118:17: note: Function 'TextImage' argument 4 names different: declaration 'foreground' definition 'fg'. Maelstrom-4.0.1/maclib/Mac_FontServ.cpp:335:75: note: Function 'TextImage' argument 4 names different: declaration 'foreground' definition 'fg'. Maelstrom-4.0.1/screenlib/SDL_FrameBuf.h:63:26: style: Parameter 'cliprect' can be declared as pointer to const [constParameterPointer] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.h:180:33: style: Parameter 'image' can be declared as pointer to const [constParameterPointer] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.h:183:34: style: Parameter 'image' can be declared as pointer to const [constParameterPointer] Maelstrom-4.0.1/miniz/examples/example1.c:29:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MZ_VERSION [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/miniz/examples/example2.c:48:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MZ_VERSION [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/maclib/Mac_Resource.h:35:11: warning: Member variable 'Mac_ResData::data' has no initializer. [uninitMemberVarNoCtor] Maelstrom-4.0.1/maclib/Mac_Resource.h:74:10: warning: Member variable 'resource::name' has no initializer. [uninitMemberVarNoCtor] Maelstrom-4.0.1/maclib/Mac_Resource.h:77:16: warning: Member variable 'resource::data' has no initializer. [uninitMemberVarNoCtor] Maelstrom-4.0.1/maclib/Mac_Resource.h:81:10: warning: Member variable 'resource_list::type' has no initializer. [uninitMemberVarNoCtor] Maelstrom-4.0.1/maclib/Mac_Resource.h:83:20: warning: Member variable 'resource_list::list' has no initializer. [uninitMemberVarNoCtor] Maelstrom-4.0.1/maclib/Mac_Wave.h:32:2: warning: Member variable 'Wave::soundptr' is not initialized in the constructor. [uninitMemberVar] Maelstrom-4.0.1/maclib/Mac_Wave.h:32:2: warning: Member variable 'Wave::errbuf' is not initialized in the constructor. [uninitMemberVar] Maelstrom-4.0.1/maclib/Mac_Wave.h:60:9: style:inconclusive: Technically the member function 'Wave::DataLeft' can be const. [functionConst] Maelstrom-4.0.1/maclib/Mac_Wave.h:72:9: style:inconclusive: Technically the member function 'Wave::SampleSize' can be const. [functionConst] Maelstrom-4.0.1/maclib/Mac_Wave.h:75:6: style:inconclusive: Technically the member function 'Wave::BitsPerSample' can be const. [functionConst] Maelstrom-4.0.1/maclib/Mac_Wave.h:78:6: style:inconclusive: Technically the member function 'Wave::Stereo' can be const. [functionConst] Maelstrom-4.0.1/maclib/Mac_Wave.cpp:315:8: style: The member function 'Wave::ConvertRate' can be static. [functionStatic] Maelstrom-4.0.1/maclib/Mac_Wave.h:100:9: note: The member function 'Wave::ConvertRate' can be static. Maelstrom-4.0.1/maclib/Mac_Wave.cpp:315:8: note: The member function 'Wave::ConvertRate' can be static. Maelstrom-4.0.1/maclib/Mac_Resource.h:42:2: style: Class 'Mac_Resource' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] Maelstrom-4.0.1/maclib/Mac_Wave.h:35:2: style: Class 'Wave' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] Maelstrom-4.0.1/maclib/Mac_Wave.h:39:2: style: Class 'Wave' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] Maelstrom-4.0.1/maclib/Mac_Wave.cpp:168:2: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] Maelstrom-4.0.1/maclib/Mac_Wave.cpp:176:3: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] Maelstrom-4.0.1/maclib/Mac_Wave.cpp:181:3: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] Maelstrom-4.0.1/maclib/Mac_Wave.cpp:190:3: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] Maelstrom-4.0.1/maclib/Mac_Wave.cpp:203:3: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] Maelstrom-4.0.1/maclib/Mac_Wave.cpp:208:3: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] Maelstrom-4.0.1/maclib/Mac_Wave.cpp:213:3: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] Maelstrom-4.0.1/maclib/Mac_Wave.cpp:222:8: style: Variable 'data' is reassigned a value before the old one has been used. [redundantAssignment] Maelstrom-4.0.1/maclib/Mac_Wave.cpp:216:3: note: data is assigned Maelstrom-4.0.1/maclib/Mac_Wave.cpp:222:8: note: data is overwritten Maelstrom-4.0.1/maclib/Mac_Wave.cpp:321:9: style: Variable 'input' can be declared as pointer to const [constVariablePointer] Maelstrom-4.0.1/miniz/examples/example4.c:82:102: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TINFL_FLAG_PARSE_ZLIB_HEADER [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/macres/macres.cpp:339:55: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_PIXELFORMAT_INDEX8 [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/macres/macres.cpp:438:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/miniz/examples/example4.c:54:9: error: Resource leak: pInfile [resourceLeak] Maelstrom-4.0.1/miniz/examples/example4.c:63:9: error: Resource leak: pInfile [resourceLeak] Maelstrom-4.0.1/miniz/examples/example4.c:68:9: error: Resource leak: pInfile [resourceLeak] Maelstrom-4.0.1/miniz/examples/example4.c:68:9: error: Memory leak: pCmp_data [memleak] Maelstrom-4.0.1/miniz/examples/example4.c:76:9: error: Resource leak: pInfile [resourceLeak] Maelstrom-4.0.1/miniz/examples/example4.c:76:9: error: Memory leak: pCmp_data [memleak] Maelstrom-4.0.1/miniz/examples/example4.c:86:9: error: Resource leak: pInfile [resourceLeak] Maelstrom-4.0.1/maclib/Mac_Resource.cpp:63:7: warning: Member variable 'Type_entry::Res_type' has no initializer. [uninitMemberVarNoCtor] Maelstrom-4.0.1/maclib/Mac_Resource.cpp:419:16: style:inconclusive: Technically the member function 'Mac_Resource::NumResources' can be const. [functionConst] Maelstrom-4.0.1/maclib/Mac_Resource.h:49:10: note: Technically the member function 'Mac_Resource::NumResources' can be const. Maelstrom-4.0.1/maclib/Mac_Resource.cpp:419:16: note: Technically the member function 'Mac_Resource::NumResources' can be const. Maelstrom-4.0.1/maclib/Mac_Resource.cpp:311:2: warning: Class 'Mac_Resource' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] Maelstrom-4.0.1/maclib/Mac_Resource.cpp:311:2: warning: Class 'Mac_Resource' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] Maelstrom-4.0.1/miniz/examples/example2.c:58:9: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] Maelstrom-4.0.1/miniz/examples/example2.c:59:9: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] Maelstrom-4.0.1/miniz/examples/example2.c:59:9: warning: %u in format string (no. 3) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] Maelstrom-4.0.1/miniz/examples/example4.c:19:26: style: Parameter 'argv' can be declared as const array [constParameter] Maelstrom-4.0.1/miniz/examples/example2.c:130:13: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] Maelstrom-4.0.1/miniz/examples/example2.c:131:13: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] Maelstrom-4.0.1/miniz/examples/example2.c:131:13: warning: %u in format string (no. 3) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] Maelstrom-4.0.1/maclib/Mac_Resource.cpp:102:4: style: C-style pointer casting [cstyleCast] Maelstrom-4.0.1/maclib/Mac_Resource.cpp:103:4: style: C-style pointer casting [cstyleCast] Maelstrom-4.0.1/maclib/Mac_Resource.cpp:265:19: style: C-style pointer casting [cstyleCast] Maelstrom-4.0.1/maclib/Mac_Resource.cpp:272:25: style: The scope of the variable 'cur_offset' can be reduced. [variableScope] Maelstrom-4.0.1/maclib/Mac_Resource.cpp:434:10: style: The scope of the variable 'ids' can be reduced. [variableScope] Maelstrom-4.0.1/maclib/Mac_Resource.cpp:263:41: style:inconclusive: Function 'Mac_Resource' argument 1 names different: declaration 'filename' definition 'file'. [funcArgNamesDifferent] Maelstrom-4.0.1/maclib/Mac_Resource.h:42:27: note: Function 'Mac_Resource' argument 1 names different: declaration 'filename' definition 'file'. Maelstrom-4.0.1/maclib/Mac_Resource.cpp:263:41: note: Function 'Mac_Resource' argument 1 names different: declaration 'filename' definition 'file'. Maelstrom-4.0.1/maclib/Mac_Resource.cpp:207:10: style: Local variable 'len' shadows outer variable [shadowVariable] Maelstrom-4.0.1/maclib/Mac_Resource.cpp:187:9: note: Shadowed variable Maelstrom-4.0.1/maclib/Mac_Resource.cpp:207:10: note: Shadow local variable Maelstrom-4.0.1/maclib/Mac_Resource.cpp:100:33: style: Variable 'a' can be declared as pointer to const [constVariablePointer] Maelstrom-4.0.1/maclib/Mac_Resource.cpp:100:37: style: Variable 'b' can be declared as pointer to const [constVariablePointer] Maelstrom-4.0.1/miniz/examples/example3.c:24:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Z_BEST_COMPRESSION [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/miniz/examples/example6.c:171:114: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MZ_FALSE [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/macres/macres.cpp:354:19: style: Array index 'i' is used before limits check. [arrayIndexThenCheck] Maelstrom-4.0.1/miniz/examples/example5.c:163:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable TDEFL_WRITE_ZLIB_HEADER [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/macres/macres.cpp:366:10: style: C-style pointer casting [cstyleCast] Maelstrom-4.0.1/macres/macres.cpp:383:10: style: C-style pointer casting [cstyleCast] Maelstrom-4.0.1/macres/macres.cpp:305:15: style: The scope of the variable 'entry' can be reduced. [variableScope] Maelstrom-4.0.1/macres/macres.cpp:471:19: style: The scope of the variable 'D' can be reduced. [variableScope] Maelstrom-4.0.1/macres/macres.cpp:305:15: style: Variable 'entry' can be declared as pointer to const [constVariablePointer] Maelstrom-4.0.1/macres/macres.cpp:334:15: style: Variable 'sprite_entry' can be declared as pointer to const [constVariablePointer] Maelstrom-4.0.1/macres/macres.cpp:335:15: style: Variable 'mask_entry' can be declared as pointer to const [constVariablePointer] Maelstrom-4.0.1/macres/macres.cpp:336:9: style: Variable 'mask' can be declared as pointer to const [constVariablePointer] Maelstrom-4.0.1/macres/macres.cpp:471:19: style: Variable 'D' can be declared as pointer to const [constVariablePointer] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.cpp:44:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_WINDOW_FULLSCREEN [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.cpp:112:63: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_LOGICAL_PRESENTATION_LETTERBOX [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.cpp:126:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_PEN_MOUSEID [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.cpp:174:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_GAMEPAD_AXIS_RIGHT_TRIGGER [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.cpp:279:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_GAMEPAD_AXIS_LEFTX [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.cpp:345:99: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_SCALEMODE_NEAREST [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.cpp:587:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_ALPHA_OPAQUE [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.cpp:704:57: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Uint32 [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/miniz/examples/example6.c:145:13: warning: Possible null pointer dereference: color [nullPointer] Maelstrom-4.0.1/miniz/examples/example6.c:110:36: note: Assuming allocation function fails Maelstrom-4.0.1/miniz/examples/example6.c:110:21: note: Assignment 'pImage=(unsigned char*)malloc(iXmax*3*iYmax)', assigned value is 0 Maelstrom-4.0.1/miniz/examples/example6.c:127:46: note: Assignment 'color=pImage+(iX*3)+(iY*iXmax*3)', assigned value is 0 Maelstrom-4.0.1/miniz/examples/example6.c:145:13: note: Null pointer dereference Maelstrom-4.0.1/miniz/examples/example6.c:146:13: warning: Possible null pointer dereference: color [nullPointer] Maelstrom-4.0.1/miniz/examples/example6.c:110:36: note: Assuming allocation function fails Maelstrom-4.0.1/miniz/examples/example6.c:110:21: note: Assignment 'pImage=(unsigned char*)malloc(iXmax*3*iYmax)', assigned value is 0 Maelstrom-4.0.1/miniz/examples/example6.c:127:46: note: Assignment 'color=pImage+(iX*3)+(iY*iXmax*3)', assigned value is 0 Maelstrom-4.0.1/miniz/examples/example6.c:146:13: note: Null pointer dereference Maelstrom-4.0.1/miniz/examples/example6.c:147:13: warning: Possible null pointer dereference: color [nullPointer] Maelstrom-4.0.1/miniz/examples/example6.c:110:36: note: Assuming allocation function fails Maelstrom-4.0.1/miniz/examples/example6.c:110:21: note: Assignment 'pImage=(unsigned char*)malloc(iXmax*3*iYmax)', assigned value is 0 Maelstrom-4.0.1/miniz/examples/example6.c:127:46: note: Assignment 'color=pImage+(iX*3)+(iY*iXmax*3)', assigned value is 0 Maelstrom-4.0.1/miniz/examples/example6.c:147:13: note: Null pointer dereference Maelstrom-4.0.1/miniz/examples/example6.c:177:49: warning: If resource allocation fails, then there is a possible null pointer dereference: pFile [nullPointerOutOfResources] Maelstrom-4.0.1/miniz/examples/example6.c:176:32: note: Assuming allocation function fails Maelstrom-4.0.1/miniz/examples/example6.c:176:32: note: Assignment 'pFile=fopen(pFilename,"wb")', assigned value is 0 Maelstrom-4.0.1/miniz/examples/example6.c:177:49: note: Null pointer dereference Maelstrom-4.0.1/screenlib/SDL_FrameBuf.cpp:33:11: warning: Member variable 'FrameBuf::m_width' is not initialized in the constructor. [uninitMemberVar] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.cpp:33:11: warning: Member variable 'FrameBuf::m_height' is not initialized in the constructor. [uninitMemberVar] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.cpp:319:11: style: The member function 'FrameBuf::ConvertTouchCoordinates' can be static. [functionStatic] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.h:80:7: note: The member function 'FrameBuf::ConvertTouchCoordinates' can be static. Maelstrom-4.0.1/screenlib/SDL_FrameBuf.cpp:319:11: note: The member function 'FrameBuf::ConvertTouchCoordinates' can be static. Maelstrom-4.0.1/screenlib/SDL_FrameBuf.cpp:713:11: style: The member function 'FrameBuf::FreeImage' can be static. [functionStatic] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.h:186:7: note: The member function 'FrameBuf::FreeImage' can be static. Maelstrom-4.0.1/screenlib/SDL_FrameBuf.cpp:713:11: note: The member function 'FrameBuf::FreeImage' can be static. Maelstrom-4.0.1/screenlib/SDL_FrameBuf.cpp:539:39: style:inconclusive: Function 'StretchBlit' argument 1 names different: declaration 'dstrect' definition '_dstrect'. [funcArgNamesDifferent] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.h:119:35: note: Function 'StretchBlit' argument 1 names different: declaration 'dstrect' definition '_dstrect'. Maelstrom-4.0.1/screenlib/SDL_FrameBuf.cpp:539:39: note: Function 'StretchBlit' argument 1 names different: declaration 'dstrect' definition '_dstrect'. Maelstrom-4.0.1/screenlib/SDL_FrameBuf.cpp:539:83: style:inconclusive: Function 'StretchBlit' argument 3 names different: declaration 'srcrect' definition '_srcrect'. [funcArgNamesDifferent] Maelstrom-4.0.1/screenlib/SDL_FrameBuf.h:119:78: note: Function 'StretchBlit' argument 3 names different: declaration 'srcrect' definition '_srcrect'. Maelstrom-4.0.1/screenlib/SDL_FrameBuf.cpp:539:83: note: Function 'StretchBlit' argument 3 names different: declaration 'srcrect' definition '_srcrect'. Maelstrom-4.0.1/miniz/examples/example5.c:120:5: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] Maelstrom-4.0.1/miniz/examples/example5.c:44:26: style: Parameter 'argv' can be declared as const array [constParameter] Maelstrom-4.0.1/miniz/examples/example3.c:88:5: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint] Maelstrom-4.0.1/miniz/examples/example3.c:19:26: style: Parameter 'argv' can be declared as const array [constParameter] Maelstrom-4.0.1/utils/files.c:220:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_free [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/utils/files.c:170:6: style: Condition '!InitDataPath()' is always false [knownConditionTrueFalse] Maelstrom-4.0.1/utils/files.c:170:19: note: Calling function 'InitDataPath' returns 1 Maelstrom-4.0.1/utils/files.c:170:6: note: Condition '!InitDataPath()' is always false Maelstrom-4.0.1/utils/files.c:179:6: style: Condition '!InitModPath()' is always false [knownConditionTrueFalse] Maelstrom-4.0.1/utils/files.c:179:18: note: Calling function 'InitModPath' returns 1 Maelstrom-4.0.1/utils/files.c:179:6: note: Condition '!InitModPath()' is always false Maelstrom-4.0.1/utils/files.c:219:7: style: Condition 'data' is always true [knownConditionTrueFalse] Maelstrom-4.0.1/screenlib/UITexture.cpp:111:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NUM_STRETCH_AREAS [valueFlowBailoutIncompleteVar] Maelstrom-4.0.1/screenlib/UITexture.cpp:28:12: warning: Member variable 'UITexture::m_stretchCornerSize' is not initialized in the constructor. [uninitMemberVar] Maelstrom-4.0.1/screenlib/UITexture.cpp:38:12: style: The member function 'UITexture::CalculateStretchAreas' can be static. [functionStatic] Maelstrom-4.0.1/screenlib/UITexture.h:86:7: note: The member function 'UITexture::CalculateStretchAreas' can be static. Maelstrom-4.0.1/screenlib/UITexture.cpp:38:12: note: The member function 'UITexture::CalculateStretchAreas' can be static. Maelstrom-4.0.1/screenlib/UITexture.h:37:2: style: Class 'UITexture' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] Maelstrom-4.0.1/screenlib/UITexture.cpp:58:6: style: Variable 'rect.x' is assigned an expression that holds the same value. [redundantAssignment] Maelstrom-4.0.1/screenlib/UITexture.cpp:55:9: note: rect.x is assigned 'x' here. Maelstrom-4.0.1/screenlib/UITexture.cpp:58:6: note: Variable 'rect.x' is assigned an expression that holds the same value. Maelstrom-4.0.1/utils/hashtable.c:162:42: style:inconclusive: Function 'hash_create' argument 3 names different: declaration '' definition 'keymatchfn'. [funcArgNamesDifferentUnnamed] Maelstrom-4.0.1/utils/hashtable.c:163:38: style:inconclusive: Function 'hash_create' argument 4 names different: declaration '' definition 'nukefn'. [funcArgNamesDifferentUnnamed] Maelstrom-4.0.1/utils/hashtable.c:218:50: style:inconclusive: Function 'hash_hash_string' argument 2 names different: declaration 'unused' definition 'data'. [funcArgNamesDifferent] Maelstrom-4.0.1/utils/hashtable.h:42:50: note: Function 'hash_hash_string' argument 2 names different: declaration 'unused' definition 'data'. Maelstrom-4.0.1/utils/hashtable.c:218:50: note: Function 'hash_hash_string' argument 2 names different: declaration 'unused' definition 'data'. Maelstrom-4.0.1/utils/hashtable.c:224:62: style:inconclusive: Function 'hash_keymatch_string' argument 3 names different: declaration 'unused' definition 'data'. [funcArgNamesDifferent] Maelstrom-4.0.1/utils/hashtable.h:43:62: note: Function 'hash_keymatch_string' argument 3 names different: declaration 'unused' definition 'data'. Maelstrom-4.0.1/utils/hashtable.c:224:62: note: Function 'hash_keymatch_string' argument 3 names different: declaration 'unused' definition 'data'. Maelstrom-4.0.1/utils/prefs.h:80:3: performance: Variable 'm_defaultValue' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] Maelstrom-4.0.1/utils/prefs.h:80:20: performance: Variable 'm_value' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] Maelstrom-4.0.1/utils/prefs.cpp:198:8: style:inconclusive: Technically the member function 'Prefs::GetString' can be const. [functionConst] Maelstrom-4.0.1/utils/prefs.h:50:14: note: Technically the member function 'Prefs::GetString' can be const. Maelstrom-4.0.1/utils/prefs.cpp:198:8: note: Technically the member function 'Prefs::GetString' can be const. Maelstrom-4.0.1/utils/prefs.cpp:209:8: style:inconclusive: Technically the member function 'Prefs::GetNumber' can be const. [functionConst] Maelstrom-4.0.1/utils/prefs.h:51:6: note: Technically the member function 'Prefs::GetNumber' can be const. Maelstrom-4.0.1/utils/prefs.cpp:209:8: note: Technically the member function 'Prefs::GetNumber' can be const. Maelstrom-4.0.1/utils/prefs.cpp:220:8: style:inconclusive: Technically the member function 'Prefs::GetUnsigned' can be const. [functionConst] Maelstrom-4.0.1/utils/prefs.h:52:15: note: Technically the member function 'Prefs::GetUnsigned' can be const. Maelstrom-4.0.1/utils/prefs.cpp:220:8: note: Technically the member function 'Prefs::GetUnsigned' can be const. Maelstrom-4.0.1/utils/prefs.cpp:231:8: style:inconclusive: Technically the member function 'Prefs::GetBool' can be const. [functionConst] Maelstrom-4.0.1/utils/prefs.h:53:7: note: Technically the member function 'Prefs::GetBool' can be const. Maelstrom-4.0.1/utils/prefs.cpp:231:8: note: Technically the member function 'Prefs::GetBool' can be const. Maelstrom-4.0.1/utils/prefs.h:123:4: style:inconclusive: Technically the member function 'PrefsVariable::Value' can be const. [functionConst] Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < const char * >' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < const char * >' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] Maelstrom-4.0.1/utils/prefs.h:27:2: style: Class 'Prefs' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] Maelstrom-4.0.1/utils/prefs.cpp:31:11: style: C-style pointer casting [cstyleCast] Maelstrom-4.0.1/utils/prefs.cpp:32:11: style: C-style pointer casting [cstyleCast] Maelstrom-4.0.1/utils/prefs.cpp:38:25: style: C-style pointer casting [cstyleCast] Maelstrom-4.0.1/utils/prefs.cpp:38:44: style: C-style pointer casting [cstyleCast] Maelstrom-4.0.1/utils/prefs.cpp:121:29: style: C-style pointer casting [cstyleCast] Maelstrom-4.0.1/utils/prefs.cpp:121:50: style: C-style pointer casting [cstyleCast] Maelstrom-4.0.1/utils/prefs.cpp:127:32: style: C-style pointer casting [cstyleCast] Maelstrom-4.0.1/utils/prefs.cpp:156:31: style: C-style pointer casting [cstyleCast] Maelstrom-4.0.1/utils/prefs.cpp:202:31: style: C-style pointer casting [cstyleCast] Maelstrom-4.0.1/utils/prefs.cpp:213:31: style: C-style pointer casting [cstyleCast] Maelstrom-4.0.1/utils/prefs.cpp:224:31: style: C-style pointer casting [cstyleCast] Maelstrom-4.0.1/utils/prefs.cpp:235:31: style: C-style pointer casting [cstyleCast] Maelstrom-4.0.1/miniz/miniz.c:0:0: debug: ValueFlow maximum iterations exceeded [valueFlowMaxIterations] Maelstrom-4.0.1/miniz/miniz.c:224:55: style: Condition 'tdefl_init(pComp,NULL,NULL,comp_flags)!=TDEFL_STATUS_OKAY' is always false [knownConditionTrueFalse] Maelstrom-4.0.1/miniz/miniz.c:224:23: note: Calling function 'tdefl_init' returns 0 Maelstrom-4.0.1/miniz/miniz.c:224:55: note: Condition 'tdefl_init(pComp,NULL,NULL,comp_flags)!=TDEFL_STATUS_OKAY' is always false Maelstrom-4.0.1/miniz/miniz.c:2042:77: style: Condition 'tdefl_init(pComp,pPut_buf_func,pPut_buf_user,flags)==TDEFL_STATUS_OKAY' is always true [knownConditionTrueFalse] Maelstrom-4.0.1/miniz/miniz.c:2042:32: note: Calling function 'tdefl_init' returns 0 Maelstrom-4.0.1/miniz/miniz.c:2042:77: note: Condition 'tdefl_init(pComp,pPut_buf_func,pPut_buf_user,flags)==TDEFL_STATUS_OKAY' is always true Maelstrom-4.0.1/miniz/miniz.c:1310:13: style: Unsigned expression '(1U<' definition 'pPut_buf_user'. [funcArgNamesDifferentUnnamed] Maelstrom-4.0.1/miniz/miniz.c:1987:113: style:inconclusive: Function 'tdefl_init' argument 4 names different: declaration '' definition 'flags'. [funcArgNamesDifferentUnnamed] Maelstrom-4.0.1/miniz/miniz.c:2033:120: style:inconclusive: Function 'tdefl_compress_mem_to_output' argument 4 names different: declaration '' definition 'pPut_buf_user'. [funcArgNamesDifferentUnnamed] Maelstrom-4.0.1/miniz/miniz.c:2033:139: style:inconclusive: Function 'tdefl_compress_mem_to_output' argument 5 names different: declaration '' definition 'flags'. [funcArgNamesDifferentUnnamed] Maelstrom-4.0.1/miniz/miniz.c:2965:129: style:inconclusive: Function 'tinfl_decompress_mem_to_callback' argument 4 names different: declaration '' definition 'pPut_buf_user'. [funcArgNamesDifferentUnnamed] Maelstrom-4.0.1/miniz/miniz.c:2965:148: style:inconclusive: Function 'tinfl_decompress_mem_to_callback' argument 5 names different: declaration '' definition 'flags'. [funcArgNamesDifferentUnnamed] Maelstrom-4.0.1/miniz/miniz.c:138:15: style: Local variable 'crc32' shadows outer function [shadowFunction] Maelstrom-4.0.1/miniz/miniz.h:571:21: note: Shadowed function Maelstrom-4.0.1/miniz/miniz.c:138:15: note: Shadow local variable Maelstrom-4.0.1/miniz/miniz.c:2023:65: style: Parameter 'd' can be declared as pointer to const [constParameterPointer] Maelstrom-4.0.1/miniz/miniz.c:2028:51: style: Parameter 'd' can be declared as pointer to const [constParameterPointer] Maelstrom-4.0.1/miniz/miniz.c:2447:56: style: Variable 'pOut_buf_end' can be declared as pointer to const [constVariablePointer] Maelstrom-4.0.1/miniz/miniz.c:2576:31: style: Variable 'pCode_size' can be declared as pointer to const [constVariablePointer] diff: 2.20.0 Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:2155:18: style: Local variable 'i' shadows outer variable [shadowVariable] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:2130:14: note: Shadowed declaration Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:2155:18: note: Shadow variable head Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:2155:18: style: Local variable 'i' shadows outer variable [shadowVariable] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:2130:14: note: Shadowed variable Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:2155:18: note: Shadow local variable 2.20.0 Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:2167:22: style: Local variable 'i' shadows outer variable [shadowVariable] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:2130:14: note: Shadowed declaration Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:2167:22: note: Shadow variable head Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:2167:22: style: Local variable 'i' shadows outer variable [shadowVariable] Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:2130:14: note: Shadowed variable Maelstrom-4.0.1/external/SDL_net/src/SDL_net.c:2167:22: note: Shadow local variable 2.20.0 Maelstrom-4.0.1/game/MacDialog.cpp:410:21: style: Variable 'editbox' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/game/MacDialog.h:30:1: warning: The class 'MacDialog' defines member variable with name 's_elementType' also defined in its parent class 'UIBaseElement'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIBaseElement.h:249:23: note: Parent variable 'UIBaseElement::s_elementType' Maelstrom-4.0.1/game/MacDialog.h:30:1: note: Derived variable 'MacDialog::s_elementType' 2.20.0 Maelstrom-4.0.1/game/MacDialog.h:30:1: warning: The class 'MacDialog' defines member variable with name 's_elementType' also defined in its parent class 'UIDialog'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIDialog.h:50:1: note: Parent variable 'UIDialog::s_elementType' Maelstrom-4.0.1/game/MacDialog.h:30:1: note: Derived variable 'MacDialog::s_elementType' 2.20.0 Maelstrom-4.0.1/game/MacDialog.h:30:1: warning: The class 'MacDialog' defines member variable with name 's_elementType' also defined in its parent class 'UIPanel'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIPanel.h:74:1: note: Parent variable 'UIPanel::s_elementType' Maelstrom-4.0.1/game/MacDialog.h:30:1: note: Derived variable 'MacDialog::s_elementType' 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.cpp:147:54: style: Parameter 'dialog' can be declared as pointer to const. However it seems that 'MessageDialogDone' is a callback function, if 'dialog' is declared with const you might also need to cast function pointer(s). [constParameterCallback] Maelstrom-4.0.1/game/MaelstromUI.cpp:173:38: note: You might need to cast the function pointer here Maelstrom-4.0.1/game/MaelstromUI.cpp:147:54: note: Parameter 'dialog' can be declared as pointer to const 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.cpp:149:24: style: C-style pointer casting [cstyleCast] 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.cpp:189:11: style: C-style pointer casting [cstyleCast] 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.cpp:190:21: style: C-style pointer casting [cstyleCast] 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.cpp:196:11: style: C-style pointer casting [cstyleCast] 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.cpp:197:21: style: C-style pointer casting [cstyleCast] 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.cpp:212:6: style: Condition 'quit_available' is always true [knownConditionTrueFalse] Maelstrom-4.0.1/game/MaelstromUI.cpp:210:24: note: Assignment 'quit_available=true', assigned value is 1 Maelstrom-4.0.1/game/MaelstromUI.cpp:212:6: note: Condition 'quit_available' is always true 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.cpp:227:60: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable path_suffix [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.cpp:250:30: style: C-style pointer casting [cstyleCast] 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.cpp:278:32: style: C-style pointer casting [cstyleCast] 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.cpp:462:29: style: Variable 'attr' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.cpp:489:29: style: Variable 'attr' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.cpp:515:29: style: Variable 'attr' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.cpp:94:17: style: Variable 'info' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.cpp:94:24: style: C-style pointer casting [cstyleCast] 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.h:34:11: style: The destructor '~MaelstromUI' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIManager.h:50:11: note: Virtual destructor in base class Maelstrom-4.0.1/game/MaelstromUI.h:34:11: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.h:39:21: style: The function 'CreateText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIFontInterface.h:37:21: note: Virtual function in base class Maelstrom-4.0.1/game/MaelstromUI.h:39:21: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.h:40:15: style: The function 'FreeText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIFontInterface.h:38:15: note: Virtual function in base class Maelstrom-4.0.1/game/MaelstromUI.h:40:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.h:45:21: style: The function 'CreateImage' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIImageInterface.h:30:21: note: Virtual function in base class Maelstrom-4.0.1/game/MaelstromUI.h:45:21: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.h:46:21: style: The function 'CreateImage' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIImageInterface.h:31:21: note: Virtual function in base class Maelstrom-4.0.1/game/MaelstromUI.h:46:21: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.h:47:15: style: The function 'FreeImage' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIImageInterface.h:32:15: note: Virtual function in base class Maelstrom-4.0.1/game/MaelstromUI.h:47:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.h:48:21: style: The function 'CreateBackground' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIImageInterface.h:34:21: note: Virtual function in base class Maelstrom-4.0.1/game/MaelstromUI.h:48:21: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.h:49:15: style: The function 'FreeBackground' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIImageInterface.h:35:15: note: Virtual function in base class Maelstrom-4.0.1/game/MaelstromUI.h:49:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.h:54:15: style: The function 'PlaySound' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UISoundInterface.h:28:15: note: Virtual function in base class Maelstrom-4.0.1/game/MaelstromUI.h:54:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.h:59:19: style: The function 'CreatePanel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIManager.h:138:19: note: Virtual function in base class Maelstrom-4.0.1/game/MaelstromUI.h:59:19: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.h:60:27: style: The function 'CreatePanelDelegate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIManager.h:141:27: note: Virtual function in base class Maelstrom-4.0.1/game/MaelstromUI.h:60:27: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/MaelstromUI.h:61:21: style: The function 'CreateElement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIManager.h:144:21: note: Virtual function in base class Maelstrom-4.0.1/game/MaelstromUI.h:61:21: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/about.cpp:59:4: style: Variable 'y' is reassigned a value before the old one has been used. [redundantAssignment] Maelstrom-4.0.1/game/about.cpp:55:4: note: y is assigned Maelstrom-4.0.1/game/about.cpp:59:4: note: y is overwritten 2.20.0 Maelstrom-4.0.1/game/about.cpp:79:4: style: Variable 'y' is assigned a value that is never used. [unreadVariable] 2.20.0 Maelstrom-4.0.1/game/about.h:32:2: style: Class 'AboutPanelDelegate' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.20.0 Maelstrom-4.0.1/game/about.h:32:2: warning: Member variable 'AboutPanelDelegate::objects' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/about.h:35:11: style: The destructor '~AboutPanelDelegate' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:40:11: note: Virtual destructor in base class Maelstrom-4.0.1/game/about.h:35:11: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/game/about.h:39:15: style: The function 'OnShow' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:46:15: note: Virtual function in base class Maelstrom-4.0.1/game/about.h:39:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/about.h:40:15: style: The function 'OnHide' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:49:15: note: Virtual function in base class Maelstrom-4.0.1/game/about.h:40:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/about.h:41:15: style: The function 'OnDraw' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:60:15: note: Virtual function in base class Maelstrom-4.0.1/game/about.h:41:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/continue.h:30:2: style: Class 'ContinuePanelDelegate' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.20.0 Maelstrom-4.0.1/game/continue.h:30:2: warning: Member variable 'ContinuePanelDelegate::m_timeoutLabel' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/continue.h:32:15: style: The function 'OnShow' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:46:15: note: Virtual function in base class Maelstrom-4.0.1/game/continue.h:32:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/continue.h:33:15: style: The function 'OnHide' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:49:15: note: Virtual function in base class Maelstrom-4.0.1/game/continue.h:33:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/continue.h:34:15: style: The function 'OnTick' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:56:15: note: Virtual function in base class Maelstrom-4.0.1/game/continue.h:34:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/controls.cpp:185:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_EVENT_KEY_DOWN [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/game/controls.cpp:213:25: style: The member function 'ControlsDialogDelegate::TranslateIndex' can be static. [functionStatic] Maelstrom-4.0.1/game/controls.h:98:6: note: The member function 'ControlsDialogDelegate::TranslateIndex' can be static. Maelstrom-4.0.1/game/controls.cpp:213:25: note: The member function 'ControlsDialogDelegate::TranslateIndex' can be static. 2.20.0 Maelstrom-4.0.1/game/controls.cpp:215:13: style: The scope of the variable 's_arrBrakeEnabled' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/controls.cpp:225:13: style: The scope of the variable 's_arrBrakeDisabled' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/controls.cpp:318:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_UNKNOWN [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/game/controls.cpp:448:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_GAMEPAD_BUTTON_SOUTH [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/game/controls.cpp:59:11: style:inconclusive: Technically the member function 'Controls::KeyBound' can be const. [functionConst] Maelstrom-4.0.1/game/controls.h:56:7: note: Technically the member function 'Controls::KeyBound' can be const. Maelstrom-4.0.1/game/controls.cpp:59:11: note: Technically the member function 'Controls::KeyBound' can be const. 2.20.0 Maelstrom-4.0.1/game/controls.cpp:608:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_F1 [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/game/controls.h:76:2: style: Class 'ControlsDialogDelegate' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.20.0 Maelstrom-4.0.1/game/controls.h:76:2: warning: Member variable 'ControlsDialogDelegate::m_controlBoxes' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/controls.h:76:2: warning: Member variable 'ControlsDialogDelegate::m_controlKeys' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/controls.h:76:2: warning: Member variable 'ControlsDialogDelegate::m_controlLabels' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/controls.h:76:2: warning: Member variable 'ControlsDialogDelegate::m_radioGroup' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/controls.h:78:15: style: The function 'OnLoad' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:43:15: note: Virtual function in base class Maelstrom-4.0.1/game/controls.h:78:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/controls.h:79:15: style: The function 'OnShow' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:46:15: note: Virtual function in base class Maelstrom-4.0.1/game/controls.h:79:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/controls.h:80:15: style: The function 'OnHide' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:49:15: note: Virtual function in base class Maelstrom-4.0.1/game/controls.h:80:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/controls.h:81:15: style: The function 'OnTick' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:56:15: note: Virtual function in base class Maelstrom-4.0.1/game/controls.h:81:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/controls.h:82:15: style: The function 'HandleEvent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:63:15: note: Virtual function in base class Maelstrom-4.0.1/game/controls.h:82:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/game.cpp:1191:7: style: The scope of the variable 'numbuf' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/game.cpp:1274:13: style: The scope of the variable 'bonus' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/game.cpp:1275:7: style: The scope of the variable 'numbuf' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/game.cpp:1396:7: style: The scope of the variable 'numbuf' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/game.cpp:1438:7: style: The scope of the variable 'numbuf' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/game.cpp:1497:12: style: The scope of the variable 'y' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/game.cpp:1497:9: style: The scope of the variable 'x' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/game.cpp:1642:30: style: Parameter 'sprite' can be declared as pointer to const [constParameterPointer] 2.20.0 Maelstrom-4.0.1/game/game.cpp:288:58: style: Parameter 'event' can be declared as pointer to const. However it seems that 'EventWatch' is a callback function, if 'event' is declared with const you might also need to cast function pointer(s). [constParameterCallback] Maelstrom-4.0.1/game/game.cpp:284:23: note: You might need to cast the function pointer here Maelstrom-4.0.1/game/game.cpp:288:58: note: Parameter 'event' can be declared as pointer to const 2.20.0 Maelstrom-4.0.1/game/game.cpp:298:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_EVENT_FINGER_DOWN [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/game/game.cpp:592:61: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_ALPHA_OPAQUE [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/game/game.cpp:700:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_LOGICAL_PRESENTATION_DISABLED [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/game/game.cpp:755:20: style: The member function 'GamePanelDelegate::StartZoomUI' can be static. [functionStatic] Maelstrom-4.0.1/game/game.h:53:7: note: The member function 'GamePanelDelegate::StartZoomUI' can be static. Maelstrom-4.0.1/game/game.cpp:755:20: note: The member function 'GamePanelDelegate::StartZoomUI' can be static. 2.20.0 Maelstrom-4.0.1/game/game.cpp:766:20: style: The member function 'GamePanelDelegate::StopZoomUI' can be static. [functionStatic] Maelstrom-4.0.1/game/game.h:54:7: note: The member function 'GamePanelDelegate::StopZoomUI' can be static. Maelstrom-4.0.1/game/game.cpp:766:20: note: The member function 'GamePanelDelegate::StopZoomUI' can be static. 2.20.0 Maelstrom-4.0.1/game/game.cpp:815:51: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_LOGICAL_PRESENTATION_DISABLED [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/game/game.cpp:886:6: style: Variable 'vert' is assigned a value that is never used. [unreadVariable] 2.20.0 Maelstrom-4.0.1/game/game.cpp:919:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BUFSIZ [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/game/game.h:33:2: style: Class 'GamePanelDelegate' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.20.0 Maelstrom-4.0.1/game/game.h:33:2: warning: Member variable 'GamePanelDelegate::m_airbrakes' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/game.h:33:2: warning: Member variable 'GamePanelDelegate::m_autofire' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/game.h:33:2: warning: Member variable 'GamePanelDelegate::m_background' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/game.h:33:2: warning: Member variable 'GamePanelDelegate::m_bonus' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/game.h:33:2: warning: Member variable 'GamePanelDelegate::m_fadeStep' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/game.h:33:2: warning: Member variable 'GamePanelDelegate::m_frags' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/game.h:33:2: warning: Member variable 'GamePanelDelegate::m_fragsLabel' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/game.h:33:2: warning: Member variable 'GamePanelDelegate::m_lives' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/game.h:33:2: warning: Member variable 'GamePanelDelegate::m_longfire' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/game.h:33:2: warning: Member variable 'GamePanelDelegate::m_lucky' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/game.h:33:2: warning: Member variable 'GamePanelDelegate::m_multiplayerCaption' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/game.h:33:2: warning: Member variable 'GamePanelDelegate::m_multiplayerColor' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/game.h:33:2: warning: Member variable 'GamePanelDelegate::m_multiplier' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/game.h:33:2: warning: Member variable 'GamePanelDelegate::m_paused' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/game.h:33:2: warning: Member variable 'GamePanelDelegate::m_score' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/game.h:33:2: warning: Member variable 'GamePanelDelegate::m_shield' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/game.h:33:2: warning: Member variable 'GamePanelDelegate::m_state' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/game.h:33:2: warning: Member variable 'GamePanelDelegate::m_touchControls' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/game.h:33:2: warning: Member variable 'GamePanelDelegate::m_touchFading' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/game.h:33:2: warning: Member variable 'GamePanelDelegate::m_triplefire' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/game.h:33:2: warning: Member variable 'GamePanelDelegate::m_wave' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/game.h:33:2: warning: Member variable 'GamePanelDelegate::m_zoomIn' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/game.h:33:2: warning: Member variable 'GamePanelDelegate::m_zoomOut' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/game.h:34:11: style: The destructor '~GamePanelDelegate' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:40:11: note: Virtual destructor in base class Maelstrom-4.0.1/game/game.h:34:11: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/game/game.h:36:15: style: The function 'OnLoad' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:43:15: note: Virtual function in base class Maelstrom-4.0.1/game/game.h:36:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/game.h:37:15: style: The function 'OnShow' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:46:15: note: Virtual function in base class Maelstrom-4.0.1/game/game.h:37:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/game.h:38:15: style: The function 'OnHide' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:49:15: note: Virtual function in base class Maelstrom-4.0.1/game/game.h:38:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/game.h:39:15: style: The function 'OnTick' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:56:15: note: Virtual function in base class Maelstrom-4.0.1/game/game.h:39:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/game.h:40:15: style: The function 'OnDraw' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:60:15: note: Virtual function in base class Maelstrom-4.0.1/game/game.h:40:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/game.h:41:15: style: The function 'OnAction' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:66:15: note: Virtual function in base class Maelstrom-4.0.1/game/game.h:41:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/game.h:51:7: style:inconclusive: Technically the member function 'GamePanelDelegate::ZoomGame' can be const. [functionConst] 2.20.0 Maelstrom-4.0.1/game/gameinfo.cpp:38:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_MAX_SINT32 [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/game/gameinfo.cpp:53:62: style:inconclusive: Function 'SetHost' argument 4 names different: declaration 'deathMatch' definition 'deathmatch'. [funcArgNamesDifferent] Maelstrom-4.0.1/game/gameinfo.h:141:58: note: Function 'SetHost' argument 4 names different: declaration 'deathMatch' definition 'deathmatch'. Maelstrom-4.0.1/game/gameinfo.cpp:53:62: note: Function 'SetHost' argument 4 names different: declaration 'deathMatch' definition 'deathmatch'. 2.20.0 Maelstrom-4.0.1/game/gameinfo.cpp:599:11: style:inconclusive: Technically the member function 'GameInfo::UpdateUI' can be const. [functionConst] Maelstrom-4.0.1/game/gameinfo.h:237:7: note: Technically the member function 'GameInfo::UpdateUI' can be const. Maelstrom-4.0.1/game/gameinfo.cpp:599:11: note: Technically the member function 'GameInfo::UpdateUI' can be const. 2.20.0 Maelstrom-4.0.1/game/gameinfo.cpp:792:11: style:inconclusive: Technically the member function 'GameInfo::GetPingStatus' can be const. [functionConst] Maelstrom-4.0.1/game/gameinfo.h:244:14: note: Technically the member function 'GameInfo::GetPingStatus' can be const. Maelstrom-4.0.1/game/gameinfo.cpp:792:11: note: Technically the member function 'GameInfo::GetPingStatus' can be const. 2.20.0 Maelstrom-4.0.1/game/gameinfo.h:131:7: style:inconclusive: Technically the member function 'GameInfo::operator==' can be const. [functionConst] 2.20.0 Maelstrom-4.0.1/game/gameover.cpp:118:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BUFSIZ [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/game/gameover.cpp:118:35: style: The scope of the variable 'num2' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/gameover.cpp:91:13: style: The scope of the variable 'image' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/gameover.cpp:92:13: style: The scope of the variable 'label' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/gameover.h:30:2: style: Class 'GameOverPanelDelegate' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.20.0 Maelstrom-4.0.1/game/gameover.h:30:2: warning: Member variable 'GameOverPanelDelegate::m_handle' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/gameover.h:30:2: warning: Member variable 'GameOverPanelDelegate::m_handleLabel' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/gameover.h:30:2: warning: Member variable 'GameOverPanelDelegate::m_handleSize' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/gameover.h:30:2: warning: Member variable 'GameOverPanelDelegate::m_state' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/gameover.h:32:15: style: The function 'OnShow' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:46:15: note: Virtual function in base class Maelstrom-4.0.1/game/gameover.h:32:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/gameover.h:33:15: style: The function 'OnHide' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:49:15: note: Virtual function in base class Maelstrom-4.0.1/game/gameover.h:33:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/gameover.h:34:15: style: The function 'OnTick' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:56:15: note: Virtual function in base class Maelstrom-4.0.1/game/gameover.h:34:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/gameover.h:35:15: style: The function 'HandleEvent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:63:15: note: Virtual function in base class Maelstrom-4.0.1/game/gameover.h:35:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/init.cpp:138:24: style: Variable 'node' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/game/init.cpp:139:29: style: The scope of the variable 'attr' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/init.cpp:139:29: style: Variable 'attr' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/game/init.cpp:1401:15: style: The scope of the variable 'surface' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/init.cpp:1407:9: style: Variable 'mask' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/game/init.cpp:1429:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_PIXELFORMAT_RGBA32 [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/game/init.cpp:1449:10: style: C-style pointer casting [cstyleCast] 2.20.0 Maelstrom-4.0.1/game/init.cpp:1552:28: style: The member function 'LoadingPanelDelegate::StartWaiting' can be static. [functionStatic] Maelstrom-4.0.1/game/init.h:36:7: note: The member function 'LoadingPanelDelegate::StartWaiting' can be static. Maelstrom-4.0.1/game/init.cpp:1552:28: note: The member function 'LoadingPanelDelegate::StartWaiting' can be static. 2.20.0 Maelstrom-4.0.1/game/init.cpp:1552:28: style: Unused private function: 'LoadingPanelDelegate::StartWaiting' [unusedPrivateFunction] Maelstrom-4.0.1/game/init.h:36:7: note: Unused private function: 'LoadingPanelDelegate::StartWaiting' Maelstrom-4.0.1/game/init.cpp:1552:28: note: Unused private function: 'LoadingPanelDelegate::StartWaiting' 2.20.0 Maelstrom-4.0.1/game/init.cpp:1567:28: style: The member function 'LoadingPanelDelegate::StartLoading' can be static. [functionStatic] Maelstrom-4.0.1/game/init.h:37:7: note: The member function 'LoadingPanelDelegate::StartLoading' can be static. Maelstrom-4.0.1/game/init.cpp:1567:28: note: The member function 'LoadingPanelDelegate::StartLoading' can be static. 2.20.0 Maelstrom-4.0.1/game/init.cpp:204:6: style: The scope of the variable 'fact' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/init.cpp:259:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable r [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/game/init.cpp:880:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_HINT_ORIENTATIONS [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/game/init.h:30:2: style: Class 'LoadingPanelDelegate' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.20.0 Maelstrom-4.0.1/game/init.h:32:15: style: The function 'OnShow' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:46:15: note: Virtual function in base class Maelstrom-4.0.1/game/init.h:32:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/init.h:33:15: style: The function 'HandleEvent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:63:15: note: Virtual function in base class Maelstrom-4.0.1/game/init.h:33:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/load.cpp:35:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable path_suffix [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:104:15: style: The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIElement.h:36:15: note: Virtual function in base class Maelstrom-4.0.1/game/lobby.cpp:104:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:1120:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable gameID [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:161:22: warning: Member variable 'LobbyDialogDelegate::m_controlDropdown' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:161:22: warning: Member variable 'LobbyDialogDelegate::m_deathmatch' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:161:22: warning: Member variable 'LobbyDialogDelegate::m_frags' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:161:22: warning: Member variable 'LobbyDialogDelegate::m_fragsLabel' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:161:22: warning: Member variable 'LobbyDialogDelegate::m_fragsValue' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:161:22: warning: Member variable 'LobbyDialogDelegate::m_gameInfoArea' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:161:22: warning: Member variable 'LobbyDialogDelegate::m_gameInfoPlayers' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:161:22: warning: Member variable 'LobbyDialogDelegate::m_gameListArea' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:161:22: warning: Member variable 'LobbyDialogDelegate::m_gameListElements' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:161:22: warning: Member variable 'LobbyDialogDelegate::m_hostOrJoin' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:161:22: warning: Member variable 'LobbyDialogDelegate::m_lives' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:161:22: warning: Member variable 'LobbyDialogDelegate::m_livesLabel' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:161:22: warning: Member variable 'LobbyDialogDelegate::m_livesValue' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:161:22: warning: Member variable 'LobbyDialogDelegate::m_playButton' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:166:2: performance: Variable 'm_lastPing' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:167:2: performance: Variable 'm_lastRefresh' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:168:2: performance: Variable 'm_requestSequence' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:321:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_EVENT_GAMEPAD_ADDED [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:358:44: style:inconclusive: Function 'JoinGameClicked' argument 1 names different: declaration 'element' definition '_element'. [funcArgNamesDifferent] Maelstrom-4.0.1/game/lobby.h:58:29: note: Function 'JoinGameClicked' argument 1 names different: declaration 'element' definition '_element'. Maelstrom-4.0.1/game/lobby.cpp:358:44: note: Function 'JoinGameClicked' argument 1 names different: declaration 'element' definition '_element'. 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:360:13: style: Variable 'element' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:360:23: style: C-style pointer casting [cstyleCast] 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:54:15: style: The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIElement.h:36:15: note: Virtual function in base class Maelstrom-4.0.1/game/lobby.cpp:54:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:69:28: style: Local variable 'player' shadows outer variable [shadowVariable] Maelstrom-4.0.1/game/lobby.cpp:57:26: note: Shadowed declaration Maelstrom-4.0.1/game/lobby.cpp:69:28: note: Shadow variable 2.20.0 Maelstrom-4.0.1/game/lobby.cpp:829:41: style: Parameter 'game' can be declared as reference to const [constParameterReference] 2.20.0 Maelstrom-4.0.1/game/lobby.h:43:2: style: Class 'LobbyDialogDelegate' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.20.0 Maelstrom-4.0.1/game/main.h:32:2: style: Class 'MainPanelDelegate' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.20.0 Maelstrom-4.0.1/game/main.h:34:15: style: The function 'OnLoad' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:43:15: note: Virtual function in base class Maelstrom-4.0.1/game/main.h:34:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/main.h:35:15: style: The function 'OnShow' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:46:15: note: Virtual function in base class Maelstrom-4.0.1/game/main.h:35:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/main.h:36:15: style: The function 'OnTick' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:56:15: note: Virtual function in base class Maelstrom-4.0.1/game/main.h:36:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/main.h:37:15: style: The function 'HandleEvent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:63:15: note: Virtual function in base class Maelstrom-4.0.1/game/main.h:37:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/main.h:38:15: style: The function 'OnAction' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:66:15: note: Virtual function in base class Maelstrom-4.0.1/game/main.h:38:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/make.cpp:169:17: style: The scope of the variable 'x' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/make.cpp:169:20: style: The scope of the variable 'y' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/make.cpp:169:23: style: The scope of the variable 'which' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/make.cpp:169:6: style: The scope of the variable 'newsprite' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/make.cpp:170:10: style: The scope of the variable 'xVel' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/make.cpp:170:16: style: The scope of the variable 'yVel' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/make.cpp:170:6: style: The scope of the variable 'rx' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/make.cpp:306:17: style: The scope of the variable 'xVel' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/make.cpp:306:23: style: The scope of the variable 'yVel' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/make.cpp:306:29: style: The scope of the variable 'rx' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/make.cpp:306:6: style: The scope of the variable 'newsprite' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/make.cpp:307:6: style: The scope of the variable 'x' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/make.cpp:307:9: style: The scope of the variable 'y' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/make.cpp:58:12: style: The scope of the variable 'newsprite' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/make.cpp:58:23: style: The scope of the variable 'xVel' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/make.cpp:58:29: style: The scope of the variable 'yVel' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/make.cpp:58:35: style: The scope of the variable 'rx' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/make.cpp:58:6: style: The scope of the variable 'x' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/make.cpp:58:9: style: The scope of the variable 'y' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/mods.cpp:137:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_EVENT_USER [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/game/mods.cpp:244:18: style: C-style pointer casting [cstyleCast] 2.20.0 Maelstrom-4.0.1/game/mods.h:38:7: warning:inconclusive: Member variable 'Mod::valid' is not assigned a value in 'Mod::operator='. [operatorEqVarError] 2.20.0 Maelstrom-4.0.1/game/mods.h:72:2: style: Class 'ModsDialogDelegate' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.20.0 Maelstrom-4.0.1/game/mods.h:72:2: warning: Member variable 'ModsDialogDelegate::m_radioGroup' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/mods.h:73:3: style: The destructor '~ModsDialogDelegate' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:40:11: note: Virtual destructor in base class Maelstrom-4.0.1/game/mods.h:73:3: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/game/mods.h:77:15: style: The function 'OnLoad' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:43:15: note: Virtual function in base class Maelstrom-4.0.1/game/mods.h:77:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/mods.h:78:15: style: The function 'OnShow' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:46:15: note: Virtual function in base class Maelstrom-4.0.1/game/mods.h:78:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/mods.h:79:15: style: The function 'OnHide' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIPanel.h:49:15: note: Virtual function in base class Maelstrom-4.0.1/game/mods.h:79:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/myerror.cpp:30:10: style: Local variable 'mesg' shadows outer function [shadowFunction] Maelstrom-4.0.1/game/myerror.h:28:13: note: Shadowed declaration Maelstrom-4.0.1/game/myerror.cpp:30:10: note: Shadow variable head Maelstrom-4.0.1/game/myerror.cpp:30:10: style: Local variable 'mesg' shadows outer function [shadowFunction] Maelstrom-4.0.1/game/myerror.h:28:13: note: Shadowed function Maelstrom-4.0.1/game/myerror.cpp:30:10: note: Shadow local variable 2.20.0 Maelstrom-4.0.1/game/netplay.cpp:255:43: style: C-style pointer casting [cstyleCast] 2.20.0 Maelstrom-4.0.1/game/netplay.cpp:455:15: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BUFSIZ [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/game/netplay.cpp:502:43: style: C-style pointer casting [cstyleCast] 2.20.0 Maelstrom-4.0.1/game/object.h:211:7: style:inconclusive: Technically the member function 'Object::GetPos' can be const. [functionConst] 2.20.0 Maelstrom-4.0.1/game/object.h:215:15: style: Virtual function 'SetPos' is called from constructor 'Object(int X,int Y,int Xvec,int Yvec,struct Blit*blit,int PhaseTime)' at line 45. Dynamic binding is not used. [virtualCallInConstructor] Maelstrom-4.0.1/game/object.cpp:45:2: note: Calling SetPos Maelstrom-4.0.1/game/object.h:215:15: note: SetPos is a virtual function 2.20.0 Maelstrom-4.0.1/game/object.h:305:20: style: Parameter 'R1' can be declared as pointer to const [constParameterPointer] 2.20.0 Maelstrom-4.0.1/game/object.h:305:30: style: Parameter 'R2' can be declared as pointer to const [constParameterPointer] 2.20.0 Maelstrom-4.0.1/game/object.h:305:6: style: The member function 'Object::Overlap' can be static. [functionStatic] 2.20.0 Maelstrom-4.0.1/game/object.h:76:15: style: Virtual function 'Set_TTL' is called from constructor 'Object(int X,int Y,int Xvec,int Yvec,struct Blit*blit,int PhaseTime)' at line 53. Dynamic binding is not used. [virtualCallInConstructor] Maelstrom-4.0.1/game/object.cpp:53:2: note: Calling Set_TTL Maelstrom-4.0.1/game/object.h:76:15: note: Set_TTL is a virtual function 2.20.0 Maelstrom-4.0.1/game/objects.h:113:6: style: The function 'BeenTimedOut' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:202:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:113:6: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:121:7: style: The function 'ExplodeSound' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:272:15: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:121:7: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:131:3: style: The destructor '~Multiplier' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:31:11: note: Virtual destructor in base class Maelstrom-4.0.1/game/objects.h:131:3: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:133:6: style: The function 'BeenShot' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:165:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:133:6: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:138:6: style: The function 'BeenDamaged' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:193:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:138:6: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:141:6: style: The function 'BeenTimedOut' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:202:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:141:6: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:145:7: style: The function 'Shake' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:236:15: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:145:7: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:156:3: style: The destructor '~Nova' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:31:11: note: Virtual destructor in base class Maelstrom-4.0.1/game/objects.h:156:3: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:158:6: style: The function 'BeenTimedOut' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:202:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:158:6: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:198:7: style: The function 'Shake' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:236:15: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:198:7: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:205:3: style: The destructor '~Bonus' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:31:11: note: Virtual destructor in base class Maelstrom-4.0.1/game/objects.h:205:3: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:207:6: style: The function 'BeenShot' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:165:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:207:6: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:224:6: style: The function 'BeenDamaged' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:193:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:224:6: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:227:6: style: The function 'BeenTimedOut' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:202:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:227:6: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:232:7: style: The function 'Shake' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:236:15: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:232:7: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:243:3: style: The destructor '~Shrapnel' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:31:11: note: Virtual destructor in base class Maelstrom-4.0.1/game/objects.h:243:3: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:245:6: style: The function 'BeenDamaged' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:193:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:245:6: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:255:3: style: The destructor '~DamagedShip' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:31:11: note: Virtual destructor in base class Maelstrom-4.0.1/game/objects.h:255:3: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:257:14: style: The function 'IsDangerous' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:37:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:257:14: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:261:6: style: The function 'BeenRunOver' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:179:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:261:6: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:271:6: style: The function 'BeenTimedOut' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:202:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:271:6: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:278:6: style: The function 'Explode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:208:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:278:6: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:29:3: style: The destructor '~Prize' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:31:11: note: Virtual destructor in base class Maelstrom-4.0.1/game/objects.h:29:3: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:31:14: style: The function 'IsDangerous' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:37:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:31:14: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:334:7: style: The function 'ExplodeSound' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:272:15: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:334:7: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:344:3: style: The destructor '~Gravity' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:31:11: note: Virtual destructor in base class Maelstrom-4.0.1/game/objects.h:344:3: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:346:6: style: The function 'Move' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:263:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:346:6: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:36:6: style: The function 'BeenRunOver' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:179:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:36:6: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:384:7: style: The function 'Shake' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:236:15: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:384:7: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:392:3: style: The destructor '~Homing' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:31:11: note: Virtual destructor in base class Maelstrom-4.0.1/game/objects.h:392:3: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:395:14: style: Virtual function 'AcquireTarget' is called from constructor 'Homing(int X,int Y,int xVel,int yVel)' at line 113. Dynamic binding is not used. [virtualCallInConstructor] Maelstrom-4.0.1/game/objects.cpp:113:9: note: Calling AcquireTarget Maelstrom-4.0.1/game/objects.h:395:14: note: AcquireTarget is a virtual function 2.20.0 Maelstrom-4.0.1/game/objects.h:413:6: style: The function 'Move' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:263:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:413:6: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:444:14: style: The function 'IsRock' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:40:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:444:14: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:448:14: style: The function 'BeenRunOver' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:179:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:448:14: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:457:14: style: The function 'Explode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:208:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:457:14: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:492:14: style: The function 'IsSmallRock' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:43:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:492:14: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:496:6: style: The function 'Explode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/objects.h:457:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:496:6: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:520:14: style: The function 'IsMediumRock' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:46:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:520:14: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:524:6: style: The function 'Explode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/objects.h:457:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:524:6: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:578:14: style: The function 'IsLargeRock' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:49:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:578:14: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:582:6: style: The function 'Explode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/objects.h:457:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:582:6: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:635:3: style: The destructor '~SteelRoid' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:31:11: note: Virtual destructor in base class Maelstrom-4.0.1/game/objects.h:635:3: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:637:6: style: The function 'BeenShot' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:165:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:637:6: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:645:6: style: The function 'BeenRunOver' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:179:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:645:6: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/objects.h:653:6: style: The function 'Explode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:208:14: note: Virtual function in base class Maelstrom-4.0.1/game/objects.h:653:6: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/packet.h:178:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NET_SUCCESS [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/game/packet.h:208:11: style: C-style pointer casting [cstyleCast] 2.20.0 Maelstrom-4.0.1/game/packet.h:95:6: style:inconclusive: Technically the member function 'DynamicPacket::Tell' can be const. [functionConst] 2.20.0 Maelstrom-4.0.1/game/packet.h:98:6: style:inconclusive: Technically the member function 'DynamicPacket::Size' can be const. [functionConst] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::AutoShield' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::Bonus' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::BonusMult' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::Braking' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::CameraX' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::CameraY' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::CutBonus' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::Dead' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::Frags' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::Ghost' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::LastWaveDied' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::Lives' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::NoThrust' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::Playing' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::Rotating' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::ShieldLevel' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::ShieldOn' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::Shooting' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::ShotsMissedThisWave' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::ShotsThisWave' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::Sphase' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::ThrustBlit' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::Thrusting' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::WasShielded' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::WasShooting' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::WasThrustingOrManualBraking' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:50:10: warning: Member variable 'Player::special' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/game/player.cpp:552:6: style: The scope of the variable 'i' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/player.cpp:556:7: style: Local variable 'i' shadows outer variable [shadowVariable] Maelstrom-4.0.1/game/player.cpp:552:6: note: Shadowed declaration Maelstrom-4.0.1/game/player.cpp:556:7: note: Shadow variable 2.20.0 Maelstrom-4.0.1/game/player.cpp:655:9: style:inconclusive: Technically the member function 'Player::DecodeInput' can be const. [functionConst] Maelstrom-4.0.1/game/player.h:230:7: note: Technically the member function 'Player::DecodeInput' can be const. Maelstrom-4.0.1/game/player.cpp:655:9: note: Technically the member function 'Player::DecodeInput' can be const. 2.20.0 Maelstrom-4.0.1/game/player.cpp:833:9: style:inconclusive: Technically the member function 'Player::CanGetAchievement' can be const. [functionConst] Maelstrom-4.0.1/game/player.h:168:7: note: Technically the member function 'Player::CanGetAchievement' can be const. Maelstrom-4.0.1/game/player.cpp:833:9: note: Technically the member function 'Player::CanGetAchievement' can be const. 2.20.0 Maelstrom-4.0.1/game/player.h:104:15: style: The function 'IncrBonus' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:281:15: note: Virtual function in base class Maelstrom-4.0.1/game/player.h:104:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/player.h:113:15: style: The function 'IncrShieldLevel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:277:15: note: Virtual function in base class Maelstrom-4.0.1/game/player.h:113:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/player.h:145:15: style: The function 'SetSpecial' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:275:15: note: Virtual function in base class Maelstrom-4.0.1/game/player.h:145:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/player.h:151:15: style: The function 'HitSound' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:271:15: note: Virtual function in base class Maelstrom-4.0.1/game/player.h:151:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/player.h:152:15: style: The function 'ExplodeSound' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:272:15: note: Virtual function in base class Maelstrom-4.0.1/game/player.h:152:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/player.h:157:8: style:inconclusive: Technically the member function 'Player::GetControlType' can be const. [functionConst] 2.20.0 Maelstrom-4.0.1/game/player.h:172:7: style:inconclusive: Technically the member function 'Player::GetCameraPos' can be const. [functionConst] 2.20.0 Maelstrom-4.0.1/game/player.h:40:2: style: Class 'Player' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.20.0 Maelstrom-4.0.1/game/player.h:41:3: style: The destructor '~Player' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:31:11: note: Virtual destructor in base class Maelstrom-4.0.1/game/player.h:41:3: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/game/player.h:46:14: style: The function 'IsPlayer' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:34:14: note: Virtual function in base class Maelstrom-4.0.1/game/player.h:46:14: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/player.h:49:14: style: The function 'IsDangerous' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:37:14: note: Virtual function in base class Maelstrom-4.0.1/game/player.h:49:14: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/player.h:52:14: style: The function 'IsGhost' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:55:14: note: Virtual function in base class Maelstrom-4.0.1/game/player.h:52:14: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/player.h:55:14: style: The function 'Alive' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:58:14: note: Virtual function in base class Maelstrom-4.0.1/game/player.h:55:14: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/player.h:66:14: style: The function 'BeenShot' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:165:14: note: Virtual function in base class Maelstrom-4.0.1/game/player.h:66:14: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/player.h:67:14: style: The function 'BeenRunOver' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:179:14: note: Virtual function in base class Maelstrom-4.0.1/game/player.h:67:14: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/player.h:68:14: style: The function 'BeenDamaged' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:193:14: note: Virtual function in base class Maelstrom-4.0.1/game/player.h:68:14: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/player.h:69:14: style: The function 'BeenTimedOut' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:202:14: note: Virtual function in base class Maelstrom-4.0.1/game/player.h:69:14: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/player.h:70:14: style: The function 'Explode' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:208:14: note: Virtual function in base class Maelstrom-4.0.1/game/player.h:70:14: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/player.h:71:16: style: The function 'ShotHit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:88:16: note: Virtual function in base class Maelstrom-4.0.1/game/player.h:71:16: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/player.h:72:14: style: The function 'Move' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:263:14: note: Virtual function in base class Maelstrom-4.0.1/game/player.h:72:14: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/player.h:74:15: style: The function 'BlitSprite' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:268:15: note: Virtual function in base class Maelstrom-4.0.1/game/player.h:74:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/player.h:80:15: style: The function 'IncrLives' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:283:15: note: Virtual function in base class Maelstrom-4.0.1/game/player.h:80:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/player.h:84:15: style: The function 'IncrScore' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:80:15: note: Virtual function in base class Maelstrom-4.0.1/game/player.h:84:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/player.h:94:15: style: The function 'IncrFrags' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:83:15: note: Virtual function in base class Maelstrom-4.0.1/game/player.h:94:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/player.h:98:15: style: The function 'Multiplier' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:279:15: note: Virtual function in base class Maelstrom-4.0.1/game/player.h:98:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/scores.cpp:121:25: style: C-style pointer casting [cstyleCast] 2.20.0 Maelstrom-4.0.1/game/scores.cpp:126:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_ENUM_CONTINUE [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/game/scores.cpp:36:20: style: C-style pointer casting [cstyleCast] 2.20.0 Maelstrom-4.0.1/game/scores.cpp:37:20: style: C-style pointer casting [cstyleCast] 2.20.0 Maelstrom-4.0.1/game/scores.cpp:68:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_ENUM_CONTINUE [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/game/scores.cpp:91:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable score [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/game/shenobi.h:201:15: style: The function 'BlitSprite' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:268:15: note: Virtual function in base class Maelstrom-4.0.1/game/shenobi.h:201:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/shenobi.h:210:15: style: The function 'HitSound' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:271:15: note: Virtual function in base class Maelstrom-4.0.1/game/shenobi.h:210:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/shenobi.h:213:15: style: The function 'ExplodeSound' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:272:15: note: Virtual function in base class Maelstrom-4.0.1/game/shenobi.h:213:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/shenobi.h:285:15: style: The function 'IncrFrags' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:83:15: note: Virtual function in base class Maelstrom-4.0.1/game/shenobi.h:285:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/shenobi.h:39:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable phase [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/game/shenobi.h:45:3: style: The destructor '~Shenobi' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:31:11: note: Virtual destructor in base class Maelstrom-4.0.1/game/shenobi.h:45:3: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/game/shenobi.h:52:14: style: Virtual function 'AcquireTarget' is called from constructor 'Shenobi(int X,int Y,struct Blit*blit,int ShotOdds)' at line 38. Dynamic binding is not used. [virtualCallInConstructor] Maelstrom-4.0.1/game/shenobi.h:38:12: note: Calling AcquireTarget Maelstrom-4.0.1/game/shenobi.h:52:14: note: AcquireTarget is a virtual function 2.20.0 Maelstrom-4.0.1/game/shenobi.h:71:16: style: The function 'ShotHit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:88:16: note: Virtual function in base class Maelstrom-4.0.1/game/shenobi.h:71:16: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/shenobi.h:88:14: style: The function 'Move' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/game/object.h:263:14: note: Virtual function in base class Maelstrom-4.0.1/game/shenobi.h:88:14: note: Function in derived class 2.20.0 Maelstrom-4.0.1/game/shenobi.h:89:15: style: The scope of the variable 'slope' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/shenobi.h:90:7: style: The scope of the variable 'newphase' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/game/shenobi.h:91:7: style: The scope of the variable 'coin' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/maclib/Mac_Resource.cpp:207:10: style: Local variable 'len' shadows outer variable [shadowVariable] Maelstrom-4.0.1/maclib/Mac_Resource.cpp:187:9: note: Shadowed declaration Maelstrom-4.0.1/maclib/Mac_Resource.cpp:207:10: note: Shadow variable head Maelstrom-4.0.1/maclib/Mac_Resource.cpp:207:10: style: Local variable 'len' shadows outer variable [shadowVariable] Maelstrom-4.0.1/maclib/Mac_Resource.cpp:187:9: note: Shadowed variable Maelstrom-4.0.1/maclib/Mac_Resource.cpp:207:10: note: Shadow local variable head Maelstrom-4.0.1/maclib/Mac_Resource.cpp:63:7: warning: Member variable 'Type_entry::Res_type' has no initializer. [uninitMemberVarNoCtor] head Maelstrom-4.0.1/maclib/Mac_Resource.h:35:11: warning: Member variable 'Mac_ResData::data' has no initializer. [uninitMemberVarNoCtor] head Maelstrom-4.0.1/maclib/Mac_Resource.h:74:10: warning: Member variable 'resource::name' has no initializer. [uninitMemberVarNoCtor] head Maelstrom-4.0.1/maclib/Mac_Resource.h:77:16: warning: Member variable 'resource::data' has no initializer. [uninitMemberVarNoCtor] head Maelstrom-4.0.1/maclib/Mac_Resource.h:81:10: warning: Member variable 'resource_list::type' has no initializer. [uninitMemberVarNoCtor] head Maelstrom-4.0.1/maclib/Mac_Resource.h:83:20: warning: Member variable 'resource_list::list' has no initializer. [uninitMemberVarNoCtor] head Maelstrom-4.0.1/maclib/Mac_Sound.h:121:7: warning: Member variable 'channel::len' has no initializer. [uninitMemberVarNoCtor] head Maelstrom-4.0.1/maclib/Mac_Sound.h:122:10: warning: Member variable 'channel::src' has no initializer. [uninitMemberVarNoCtor] head Maelstrom-4.0.1/maclib/Mac_Sound.h:123:10: warning: Member variable 'channel::callback' has no initializer. [uninitMemberVarNoCtor] head Maelstrom-4.0.1/maclib/Mac_Sound.h:34:9: warning: Member variable 'Wave::data' has no initializer. [uninitMemberVarNoCtor] head Maelstrom-4.0.1/miniz/examples/example3.c:19:26: style: Parameter 'argv' can be declared as const array [constParameter] head Maelstrom-4.0.1/miniz/examples/example5.c:44:26: style: Parameter 'argv' can be declared as const array [constParameter] 2.20.0 Maelstrom-4.0.1/miniz/examples/example6.c:127:46: error: Pointer addition with NULL pointer. [nullPointerArithmetic] Maelstrom-4.0.1/miniz/examples/example6.c:110:36: note: Assuming allocation function fails Maelstrom-4.0.1/miniz/examples/example6.c:110:21: note: Assignment 'pImage=(unsigned char*)malloc(iXmax*3*iYmax)', assigned value is 0 Maelstrom-4.0.1/miniz/examples/example6.c:127:46: note: Null pointer addition head Maelstrom-4.0.1/miniz/examples/example6.c:145:13: warning: Possible null pointer dereference: color [nullPointer] Maelstrom-4.0.1/miniz/examples/example6.c:110:36: note: Assuming allocation function fails Maelstrom-4.0.1/miniz/examples/example6.c:110:21: note: Assignment 'pImage=(unsigned char*)malloc(iXmax*3*iYmax)', assigned value is 0 Maelstrom-4.0.1/miniz/examples/example6.c:127:46: note: Assignment 'color=pImage+(iX*3)+(iY*iXmax*3)', assigned value is 0 Maelstrom-4.0.1/miniz/examples/example6.c:145:13: note: Null pointer dereference head Maelstrom-4.0.1/miniz/examples/example6.c:146:13: warning: Possible null pointer dereference: color [nullPointer] Maelstrom-4.0.1/miniz/examples/example6.c:110:36: note: Assuming allocation function fails Maelstrom-4.0.1/miniz/examples/example6.c:110:21: note: Assignment 'pImage=(unsigned char*)malloc(iXmax*3*iYmax)', assigned value is 0 Maelstrom-4.0.1/miniz/examples/example6.c:127:46: note: Assignment 'color=pImage+(iX*3)+(iY*iXmax*3)', assigned value is 0 Maelstrom-4.0.1/miniz/examples/example6.c:146:13: note: Null pointer dereference head Maelstrom-4.0.1/miniz/examples/example6.c:147:13: warning: Possible null pointer dereference: color [nullPointer] Maelstrom-4.0.1/miniz/examples/example6.c:110:36: note: Assuming allocation function fails Maelstrom-4.0.1/miniz/examples/example6.c:110:21: note: Assignment 'pImage=(unsigned char*)malloc(iXmax*3*iYmax)', assigned value is 0 Maelstrom-4.0.1/miniz/examples/example6.c:127:46: note: Assignment 'color=pImage+(iX*3)+(iY*iXmax*3)', assigned value is 0 Maelstrom-4.0.1/miniz/examples/example6.c:147:13: note: Null pointer dereference 2.20.0 Maelstrom-4.0.1/miniz/examples/example6.c:178:20: warning: If resource allocation fails, then there is a possible null pointer dereference: pFile [nullPointerOutOfResources] Maelstrom-4.0.1/miniz/examples/example6.c:176:32: note: Assuming allocation function fails Maelstrom-4.0.1/miniz/examples/example6.c:176:32: note: Assignment 'pFile=fopen(pFilename,"wb")', assigned value is 0 Maelstrom-4.0.1/miniz/examples/example6.c:178:20: note: Null pointer dereference 2.20.0 Maelstrom-4.0.1/miniz/miniz.c:138:15: style: Local variable 'crc32' shadows outer function [shadowFunction] Maelstrom-4.0.1/miniz/miniz.h:571:21: note: Shadowed declaration Maelstrom-4.0.1/miniz/miniz.c:138:15: note: Shadow variable head Maelstrom-4.0.1/miniz/miniz.c:138:15: style: Local variable 'crc32' shadows outer function [shadowFunction] Maelstrom-4.0.1/miniz/miniz.h:571:21: note: Shadowed function Maelstrom-4.0.1/miniz/miniz.c:138:15: note: Shadow local variable head Maelstrom-4.0.1/miniz/miniz.c:1987:113: style:inconclusive: Function 'tdefl_init' argument 4 names different: declaration '' definition 'flags'. [funcArgNamesDifferentUnnamed] head Maelstrom-4.0.1/miniz/miniz.c:1987:94: style:inconclusive: Function 'tdefl_init' argument 3 names different: declaration '' definition 'pPut_buf_user'. [funcArgNamesDifferentUnnamed] head Maelstrom-4.0.1/miniz/miniz.c:2033:120: style:inconclusive: Function 'tdefl_compress_mem_to_output' argument 4 names different: declaration '' definition 'pPut_buf_user'. [funcArgNamesDifferentUnnamed] head Maelstrom-4.0.1/miniz/miniz.c:2033:139: style:inconclusive: Function 'tdefl_compress_mem_to_output' argument 5 names different: declaration '' definition 'flags'. [funcArgNamesDifferentUnnamed] head Maelstrom-4.0.1/miniz/miniz.c:2965:129: style:inconclusive: Function 'tinfl_decompress_mem_to_callback' argument 4 names different: declaration '' definition 'pPut_buf_user'. [funcArgNamesDifferentUnnamed] head Maelstrom-4.0.1/miniz/miniz.c:2965:148: style:inconclusive: Function 'tinfl_decompress_mem_to_callback' argument 5 names different: declaration '' definition 'flags'. [funcArgNamesDifferentUnnamed] 2.20.0 Maelstrom-4.0.1/screenlib/UIArea.cpp:212:40: style: Parameter 'node' can be declared as pointer to const [constParameterPointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIArea.cpp:212:9: style: The member function 'UIArea::LoadBool' can be static. [functionStatic] Maelstrom-4.0.1/screenlib/UIArea.h:130:7: note: The member function 'UIArea::LoadBool' can be static. Maelstrom-4.0.1/screenlib/UIArea.cpp:212:9: note: The member function 'UIArea::LoadBool' can be static. 2.20.0 Maelstrom-4.0.1/screenlib/UIArea.cpp:214:29: style: Variable 'attr' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIArea.cpp:231:42: style: Parameter 'node' can be declared as pointer to const [constParameterPointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIArea.cpp:231:9: style: The member function 'UIArea::LoadNumber' can be static. [functionStatic] Maelstrom-4.0.1/screenlib/UIArea.h:131:7: note: The member function 'UIArea::LoadNumber' can be static. Maelstrom-4.0.1/screenlib/UIArea.cpp:231:9: note: The member function 'UIArea::LoadNumber' can be static. 2.20.0 Maelstrom-4.0.1/screenlib/UIArea.cpp:233:29: style: Variable 'attr' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIArea.cpp:244:42: style: Parameter 'node' can be declared as pointer to const [constParameterPointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIArea.cpp:244:9: style: The member function 'UIArea::LoadNumber' can be static. [functionStatic] Maelstrom-4.0.1/screenlib/UIArea.h:132:7: note: The member function 'UIArea::LoadNumber' can be static. Maelstrom-4.0.1/screenlib/UIArea.cpp:244:9: note: The member function 'UIArea::LoadNumber' can be static. 2.20.0 Maelstrom-4.0.1/screenlib/UIArea.cpp:246:29: style: Variable 'attr' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIArea.cpp:257:42: style: Parameter 'node' can be declared as pointer to const [constParameterPointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIArea.cpp:257:9: style: The member function 'UIArea::LoadString' can be static. [functionStatic] Maelstrom-4.0.1/screenlib/UIArea.h:133:7: note: The member function 'UIArea::LoadString' can be static. Maelstrom-4.0.1/screenlib/UIArea.cpp:257:9: note: The member function 'UIArea::LoadString' can be static. 2.20.0 Maelstrom-4.0.1/screenlib/UIArea.cpp:259:29: style: Variable 'attr' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIArea.cpp:277:50: style: Parameter 'node' can be declared as pointer to const [constParameterPointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIArea.cpp:277:9: style: The member function 'UIArea::LoadAnchorLocation' can be static. [functionStatic] Maelstrom-4.0.1/screenlib/UIArea.h:134:7: note: The member function 'UIArea::LoadAnchorLocation' can be static. Maelstrom-4.0.1/screenlib/UIArea.cpp:277:9: note: The member function 'UIArea::LoadAnchorLocation' can be static. 2.20.0 Maelstrom-4.0.1/screenlib/UIArea.cpp:279:29: style: Variable 'attr' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIArea.cpp:56:29: style: The scope of the variable 'attr' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/screenlib/UIArea.h:63:2: style: Class 'UIArea' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.20.0 Maelstrom-4.0.1/screenlib/UIArea.h:64:11: style: The destructor '~UIArea' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/utils/ErrorBase.h:30:11: note: Virtual destructor in base class Maelstrom-4.0.1/screenlib/UIArea.h:64:11: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/screenlib/UIArea.h:87:7: style:inconclusive: Technically the member function 'UIArea::GetAnchor' can be const. [functionConst] 2.20.0 Maelstrom-4.0.1/screenlib/UIBaseElement.cpp:239:42: style:inconclusive: Function 'CreateElement' argument 1 names different: declaration 'type' definition 'name'. [funcArgNamesDifferent] Maelstrom-4.0.1/screenlib/UIBaseElement.h:240:43: note: Function 'CreateElement' argument 1 names different: declaration 'type' definition 'name'. Maelstrom-4.0.1/screenlib/UIBaseElement.cpp:239:42: note: Function 'CreateElement' argument 1 names different: declaration 'type' definition 'name'. 2.20.0 Maelstrom-4.0.1/screenlib/UIBaseElement.cpp:248:29: style: The scope of the variable 'attr' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/screenlib/UIBaseElement.cpp:248:29: style: Variable 'attr' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIBaseElement.cpp:275:16: style: The member function 'UIBaseElement::LoadDrawLevel' can be static. [functionStatic] Maelstrom-4.0.1/screenlib/UIBaseElement.h:243:7: note: The member function 'UIBaseElement::LoadDrawLevel' can be static. Maelstrom-4.0.1/screenlib/UIBaseElement.cpp:275:16: note: The member function 'UIBaseElement::LoadDrawLevel' can be static. 2.20.0 Maelstrom-4.0.1/screenlib/UIBaseElement.cpp:275:52: style: Parameter 'node' can be declared as pointer to const [constParameterPointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIBaseElement.cpp:277:29: style: Variable 'attr' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIBaseElement.cpp:95:7: style: Condition '!LoadElements(child,templates)' is always false [knownConditionTrueFalse] Maelstrom-4.0.1/screenlib/UIBaseElement.cpp:95:20: note: Calling function 'LoadElements' returns 1 Maelstrom-4.0.1/screenlib/UIBaseElement.cpp:95:7: note: Condition '!LoadElements(child,templates)' is always false 2.20.0 Maelstrom-4.0.1/screenlib/UIBaseElement.h:112:14: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.20.0 Maelstrom-4.0.1/screenlib/UIBaseElement.h:130:19: style: The scope of the variable 'j' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/screenlib/UIBaseElement.h:146:13: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.20.0 Maelstrom-4.0.1/screenlib/UIBaseElement.h:153:13: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.20.0 Maelstrom-4.0.1/screenlib/UIBaseElement.h:164:18: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.20.0 Maelstrom-4.0.1/screenlib/UIBaseElement.h:198:15: style: The function 'OnRectChanged' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIArea.h:139:15: note: Virtual function in base class Maelstrom-4.0.1/screenlib/UIBaseElement.h:198:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/screenlib/UIBaseElement.h:49:2: style: Class 'UIBaseElement' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.20.0 Maelstrom-4.0.1/screenlib/UIBaseElement.h:50:2: style: Class 'UIBaseElement' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.20.0 Maelstrom-4.0.1/screenlib/UIBaseElement.h:51:11: style: The destructor '~UIBaseElement' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIArea.h:64:11: note: Virtual destructor in base class Maelstrom-4.0.1/screenlib/UIBaseElement.h:51:11: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/screenlib/UIBaseElement.h:60:11: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.20.0 Maelstrom-4.0.1/screenlib/UIBaseElement.h:88:18: style: The function 'GetAnchorElement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIArea.h:69:18: note: Virtual function in base class Maelstrom-4.0.1/screenlib/UIBaseElement.h:88:18: note: Function in derived class 2.20.0 Maelstrom-4.0.1/screenlib/UIContainer.cpp:42:29: style: Variable 'attr' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIContainer.h:35:1: warning: The class 'UIContainer' defines member variable with name 's_elementType' also defined in its parent class 'UIBaseElement'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIBaseElement.h:249:23: note: Parent variable 'UIBaseElement::s_elementType' Maelstrom-4.0.1/screenlib/UIContainer.h:35:1: note: Derived variable 'UIContainer::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIContainer.h:35:1: warning: The class 'UIContainer' defines member variable with name 's_elementType' also defined in its parent class 'UIElement'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIElement.h:128:1: note: Parent variable 'UIElement::s_elementType' Maelstrom-4.0.1/screenlib/UIContainer.h:35:1: note: Derived variable 'UIContainer::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIContainer.h:55:9: style:inconclusive: Technically the member function 'UIContainer::Spacing' can be const. [functionConst] 2.20.0 Maelstrom-4.0.1/screenlib/UIContainer.h:56:9: style:inconclusive: Technically the member function 'UIContainer::BorderSpacing' can be const. [functionConst] 2.20.0 Maelstrom-4.0.1/screenlib/UIDialog.cpp:70:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_EVENT_KEY_DOWN [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/screenlib/UIDialog.h:33:2: style: Class 'UIDialogDelegate' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.20.0 Maelstrom-4.0.1/screenlib/UIDialog.h:50:1: warning: The class 'UIDialog' defines member variable with name 's_elementType' also defined in its parent class 'UIBaseElement'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIBaseElement.h:249:23: note: Parent variable 'UIBaseElement::s_elementType' Maelstrom-4.0.1/screenlib/UIDialog.h:50:1: note: Derived variable 'UIDialog::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIDialog.h:50:1: warning: The class 'UIDialog' defines member variable with name 's_elementType' also defined in its parent class 'UIPanel'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIPanel.h:74:1: note: Parent variable 'UIPanel::s_elementType' Maelstrom-4.0.1/screenlib/UIDialog.h:50:1: note: Derived variable 'UIDialog::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIDialogButton.cpp:49:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDLK_RETURN [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/screenlib/UIDialogButton.h:29:1: warning: The class 'UIDialogButton' defines member variable with name 's_elementType' also defined in its parent class 'UIBaseElement'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIBaseElement.h:249:23: note: Parent variable 'UIBaseElement::s_elementType' Maelstrom-4.0.1/screenlib/UIDialogButton.h:29:1: note: Derived variable 'UIDialogButton::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIDialogButton.h:29:1: warning: The class 'UIDialogButton' defines member variable with name 's_elementType' also defined in its parent class 'UIElement'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIElement.h:128:1: note: Parent variable 'UIElement::s_elementType' Maelstrom-4.0.1/screenlib/UIDialogButton.h:29:1: note: Derived variable 'UIDialogButton::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIDialogButton.h:29:1: warning: The class 'UIDialogButton' defines member variable with name 's_elementType' also defined in its parent class 'UIElementButton'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIElementButton.h:30:1: note: Parent variable 'UIElementButton::s_elementType' Maelstrom-4.0.1/screenlib/UIDialogButton.h:29:1: note: Derived variable 'UIDialogButton::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIDrawEngine.cpp:100:15: style: The member function 'UIDrawEngine::LoadString' can be static. [functionStatic] Maelstrom-4.0.1/screenlib/UIDrawEngine.h:96:7: note: The member function 'UIDrawEngine::LoadString' can be static. Maelstrom-4.0.1/screenlib/UIDrawEngine.cpp:100:15: note: The member function 'UIDrawEngine::LoadString' can be static. 2.20.0 Maelstrom-4.0.1/screenlib/UIDrawEngine.cpp:100:48: style: Parameter 'node' can be declared as pointer to const [constParameterPointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIDrawEngine.cpp:102:29: style: Variable 'attr' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIDrawEngine.cpp:137:11: style: Variable 'area' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIDrawEngine.cpp:142:11: style: Variable 'area' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIDrawEngine.cpp:193:10: style: The scope of the variable 'h' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/screenlib/UIDrawEngine.cpp:193:7: style: The scope of the variable 'w' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/screenlib/UIDrawEngine.cpp:214:13: style: Variable 'image' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIDrawEngine.cpp:68:15: style: The member function 'UIDrawEngine::LoadBool' can be static. [functionStatic] Maelstrom-4.0.1/screenlib/UIDrawEngine.h:94:7: note: The member function 'UIDrawEngine::LoadBool' can be static. Maelstrom-4.0.1/screenlib/UIDrawEngine.cpp:68:15: note: The member function 'UIDrawEngine::LoadBool' can be static. 2.20.0 Maelstrom-4.0.1/screenlib/UIDrawEngine.cpp:68:46: style: Parameter 'node' can be declared as pointer to const [constParameterPointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIDrawEngine.cpp:70:29: style: Variable 'attr' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIDrawEngine.cpp:87:15: style: The member function 'UIDrawEngine::LoadNumber' can be static. [functionStatic] Maelstrom-4.0.1/screenlib/UIDrawEngine.h:95:7: note: The member function 'UIDrawEngine::LoadNumber' can be static. Maelstrom-4.0.1/screenlib/UIDrawEngine.cpp:87:15: note: The member function 'UIDrawEngine::LoadNumber' can be static. 2.20.0 Maelstrom-4.0.1/screenlib/UIDrawEngine.cpp:87:48: style: Parameter 'node' can be declared as pointer to const [constParameterPointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIDrawEngine.cpp:89:29: style: Variable 'attr' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIDrawEngine.h:104:15: style: The function 'OnDraw' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIDrawEngine.h:52:15: note: Virtual function in base class Maelstrom-4.0.1/screenlib/UIDrawEngine.h:104:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/screenlib/UIDrawEngine.h:112:15: style: The function 'OnDraw' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIDrawEngine.h:52:15: note: Virtual function in base class Maelstrom-4.0.1/screenlib/UIDrawEngine.h:112:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/screenlib/UIElement.cpp:262:44: style: Parameter 'node' can be declared as pointer to const [constParameterPointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIElement.cpp:37:2: performance: Variable 'm_fillColor' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] 2.20.0 Maelstrom-4.0.1/screenlib/UIElement.cpp:40:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_ALPHA_OPAQUE [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/screenlib/UIElement.cpp:625:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_EVENT_MOUSE_MOTION [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/screenlib/UIElement.cpp:69:10: warning: Class 'UIElement' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] 2.20.0 Maelstrom-4.0.1/screenlib/UIElement.cpp:69:10: warning: Class 'UIElement' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] 2.20.0 Maelstrom-4.0.1/screenlib/UIElement.h:112:15: style: The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIElement.h:81:15: note: Virtual function in base class Maelstrom-4.0.1/screenlib/UIElement.h:112:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/screenlib/UIElement.h:128:1: warning: The class 'UIElement' defines member variable with name 's_elementType' also defined in its parent class 'UIBaseElement'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIBaseElement.h:249:23: note: Parent variable 'UIBaseElement::s_elementType' Maelstrom-4.0.1/screenlib/UIElement.h:128:1: note: Derived variable 'UIElement::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIElement.h:131:11: style: The destructor '~UIElement' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIBaseElement.h:51:11: note: Virtual destructor in base class Maelstrom-4.0.1/screenlib/UIElement.h:131:11: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/screenlib/UIElement.h:49:15: style: The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIElement.h:36:15: note: Virtual function in base class Maelstrom-4.0.1/screenlib/UIElement.h:49:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/screenlib/UIElement.h:67:15: style: The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIElement.h:36:15: note: Virtual function in base class Maelstrom-4.0.1/screenlib/UIElement.h:67:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/screenlib/UIElement.h:94:15: style: The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIElement.h:81:15: note: Virtual function in base class Maelstrom-4.0.1/screenlib/UIElement.h:94:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/screenlib/UIElementButton.cpp:125:57: style: Parameter 'attr' can be declared as pointer to const [constParameterPointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIElementButton.cpp:133:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_KMOD_ALT [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/screenlib/UIElementButton.cpp:162:18: style: The member function 'UIElementButton::ShouldHandleKey' can be static. [functionStatic] Maelstrom-4.0.1/screenlib/UIElementButton.h:65:7: note: The member function 'UIElementButton::ShouldHandleKey' can be static. Maelstrom-4.0.1/screenlib/UIElementButton.cpp:162:18: note: The member function 'UIElementButton::ShouldHandleKey' can be static. 2.20.0 Maelstrom-4.0.1/screenlib/UIElementButton.cpp:162:72: style: Parameter 'hotkey' can be declared as pointer to const [constParameterPointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIElementButton.cpp:190:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_EVENT_KEY_DOWN [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/screenlib/UIElementButton.h:30:1: warning: The class 'UIElementButton' defines member variable with name 's_elementType' also defined in its parent class 'UIBaseElement'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIBaseElement.h:249:23: note: Parent variable 'UIBaseElement::s_elementType' Maelstrom-4.0.1/screenlib/UIElementButton.h:30:1: note: Derived variable 'UIElementButton::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIElementButton.h:30:1: warning: The class 'UIElementButton' defines member variable with name 's_elementType' also defined in its parent class 'UIElement'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIElement.h:128:1: note: Parent variable 'UIElement::s_elementType' Maelstrom-4.0.1/screenlib/UIElementButton.h:30:1: note: Derived variable 'UIElementButton::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIElementButton.h:41:11: style: The destructor '~UIElementButton' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIElement.h:131:11: note: Virtual destructor in base class Maelstrom-4.0.1/screenlib/UIElementButton.h:41:11: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/screenlib/UIElementCheckbox.cpp:52:29: style: Variable 'attr' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIElementCheckbox.h:30:1: warning: The class 'UIElementCheckbox' defines member variable with name 's_elementType' also defined in its parent class 'UIBaseElement'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIBaseElement.h:249:23: note: Parent variable 'UIBaseElement::s_elementType' Maelstrom-4.0.1/screenlib/UIElementCheckbox.h:30:1: note: Derived variable 'UIElementCheckbox::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIElementCheckbox.h:30:1: warning: The class 'UIElementCheckbox' defines member variable with name 's_elementType' also defined in its parent class 'UIElement'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIElement.h:128:1: note: Parent variable 'UIElement::s_elementType' Maelstrom-4.0.1/screenlib/UIElementCheckbox.h:30:1: note: Derived variable 'UIElementCheckbox::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIElementCheckbox.h:30:1: warning: The class 'UIElementCheckbox' defines member variable with name 's_elementType' also defined in its parent class 'UIElementButton'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIElementButton.h:30:1: note: Parent variable 'UIElementButton::s_elementType' Maelstrom-4.0.1/screenlib/UIElementCheckbox.h:30:1: note: Derived variable 'UIElementCheckbox::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIElementCheckbox.h:33:11: style: The destructor '~UIElementCheckbox' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIElementButton.h:41:11: note: Virtual destructor in base class Maelstrom-4.0.1/screenlib/UIElementCheckbox.h:33:11: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/screenlib/UIElementDropdown.cpp:59:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_EVENT_MOUSE_BUTTON_DOWN [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/screenlib/UIElementDropdown.h:30:1: warning: The class 'UIElementDropdown' defines member variable with name 's_elementType' also defined in its parent class 'UIBaseElement'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIBaseElement.h:249:23: note: Parent variable 'UIBaseElement::s_elementType' Maelstrom-4.0.1/screenlib/UIElementDropdown.h:30:1: note: Derived variable 'UIElementDropdown::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIElementDropdown.h:30:1: warning: The class 'UIElementDropdown' defines member variable with name 's_elementType' also defined in its parent class 'UIElement'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIElement.h:128:1: note: Parent variable 'UIElement::s_elementType' Maelstrom-4.0.1/screenlib/UIElementDropdown.h:30:1: note: Derived variable 'UIElementDropdown::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIElementDropdown.h:30:1: warning: The class 'UIElementDropdown' defines member variable with name 's_elementType' also defined in its parent class 'UIElementButton'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIElementButton.h:30:1: note: Parent variable 'UIElementButton::s_elementType' Maelstrom-4.0.1/screenlib/UIElementDropdown.h:30:1: note: Derived variable 'UIElementDropdown::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIElementDropdown.h:33:11: style: The destructor '~UIElementDropdown' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIElementButton.h:41:11: note: Virtual destructor in base class Maelstrom-4.0.1/screenlib/UIElementDropdown.h:33:11: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/screenlib/UIElementEditbox.cpp:38:2: warning: Class 'UIElementEditbox' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] 2.20.0 Maelstrom-4.0.1/screenlib/UIElementEditbox.cpp:38:2: warning: Class 'UIElementEditbox' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] 2.20.0 Maelstrom-4.0.1/screenlib/UIElementEditbox.cpp:75:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_EVENT_MOUSE_MOTION [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/screenlib/UIElementEditbox.h:34:1: warning: The class 'UIElementEditbox' defines member variable with name 's_elementType' also defined in its parent class 'UIBaseElement'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIBaseElement.h:249:23: note: Parent variable 'UIBaseElement::s_elementType' Maelstrom-4.0.1/screenlib/UIElementEditbox.h:34:1: note: Derived variable 'UIElementEditbox::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIElementEditbox.h:34:1: warning: The class 'UIElementEditbox' defines member variable with name 's_elementType' also defined in its parent class 'UIElement'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIElement.h:128:1: note: Parent variable 'UIElement::s_elementType' Maelstrom-4.0.1/screenlib/UIElementEditbox.h:34:1: note: Derived variable 'UIElementEditbox::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIElementEditbox.h:34:1: warning: The class 'UIElementEditbox' defines member variable with name 's_elementType' also defined in its parent class 'UIElementButton'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIElementButton.h:30:1: note: Parent variable 'UIElementButton::s_elementType' Maelstrom-4.0.1/screenlib/UIElementEditbox.h:34:1: note: Derived variable 'UIElementEditbox::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIElementEditbox.h:37:11: style: The destructor '~UIElementEditbox' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIElementButton.h:41:11: note: Virtual destructor in base class Maelstrom-4.0.1/screenlib/UIElementEditbox.h:37:11: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/screenlib/UIElementEditbox.h:63:14: warning: The class 'UIElementEditbox' defines member function with name 'GetText' also defined in its parent class 'UIElement'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIElement.h:200:14: note: Parent function 'UIElement::GetText' Maelstrom-4.0.1/screenlib/UIElementEditbox.h:63:14: note: Derived function 'UIElementEditbox::GetText' 2.20.0 Maelstrom-4.0.1/screenlib/UIElementEditbox.h:89:8: warning: The class 'UIElementEditbox' defines member variable with name 'm_text' also defined in its parent class 'UIElement'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIElement.h:283:8: note: Parent variable 'UIElement::m_text' Maelstrom-4.0.1/screenlib/UIElementEditbox.h:89:8: note: Derived variable 'UIElementEditbox::m_text' 2.20.0 Maelstrom-4.0.1/screenlib/UIElementRadio.cpp:41:10: warning: Class 'UIElementRadioGroup' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] 2.20.0 Maelstrom-4.0.1/screenlib/UIElementRadio.cpp:41:10: warning: Class 'UIElementRadioGroup' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] 2.20.0 Maelstrom-4.0.1/screenlib/UIElementRadio.h:121:1: warning: The class 'UIElementRadioButton' defines member variable with name 's_elementType' also defined in its parent class 'UIBaseElement'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIBaseElement.h:249:23: note: Parent variable 'UIBaseElement::s_elementType' Maelstrom-4.0.1/screenlib/UIElementRadio.h:121:1: note: Derived variable 'UIElementRadioButton::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIElementRadio.h:121:1: warning: The class 'UIElementRadioButton' defines member variable with name 's_elementType' also defined in its parent class 'UIElement'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIElement.h:128:1: note: Parent variable 'UIElement::s_elementType' Maelstrom-4.0.1/screenlib/UIElementRadio.h:121:1: note: Derived variable 'UIElementRadioButton::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIElementRadio.h:121:1: warning: The class 'UIElementRadioButton' defines member variable with name 's_elementType' also defined in its parent class 'UIElementButton'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIElementButton.h:30:1: note: Parent variable 'UIElementButton::s_elementType' Maelstrom-4.0.1/screenlib/UIElementRadio.h:121:1: note: Derived variable 'UIElementRadioButton::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIElementRadio.h:121:1: warning: The class 'UIElementRadioButton' defines member variable with name 's_elementType' also defined in its parent class 'UIElementCheckbox'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIElementCheckbox.h:30:1: note: Parent variable 'UIElementCheckbox::s_elementType' Maelstrom-4.0.1/screenlib/UIElementRadio.h:121:1: note: Derived variable 'UIElementRadioButton::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIElementRadio.h:46:15: style: The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIElementRadio.h:33:15: note: Virtual function in base class Maelstrom-4.0.1/screenlib/UIElementRadio.h:46:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/screenlib/UIElementRadio.h:64:15: style: The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIElementRadio.h:33:15: note: Virtual function in base class Maelstrom-4.0.1/screenlib/UIElementRadio.h:64:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/screenlib/UIElementRadio.h:85:1: warning: The class 'UIElementRadioGroup' defines member variable with name 's_elementType' also defined in its parent class 'UIBaseElement'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIBaseElement.h:249:23: note: Parent variable 'UIBaseElement::s_elementType' Maelstrom-4.0.1/screenlib/UIElementRadio.h:85:1: note: Derived variable 'UIElementRadioGroup::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIElementRadio.h:85:1: warning: The class 'UIElementRadioGroup' defines member variable with name 's_elementType' also defined in its parent class 'UIElement'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIElement.h:128:1: note: Parent variable 'UIElement::s_elementType' Maelstrom-4.0.1/screenlib/UIElementRadio.h:85:1: note: Derived variable 'UIElementRadioGroup::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIElementRadio.h:88:3: style: The destructor '~UIElementRadioGroup' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIElement.h:131:11: note: Virtual destructor in base class Maelstrom-4.0.1/screenlib/UIElementRadio.h:88:3: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/screenlib/UIElementThumbstick.cpp:105:8: style: Condition '!GetTouchAngleAndDistance(x,y,angle,distance)' is always false [knownConditionTrueFalse] Maelstrom-4.0.1/screenlib/UIElementThumbstick.cpp:105:33: note: Calling function 'GetTouchAngleAndDistance' returns 1 Maelstrom-4.0.1/screenlib/UIElementThumbstick.cpp:105:8: note: Condition '!GetTouchAngleAndDistance(x,y,angle,distance)' is always false 2.20.0 Maelstrom-4.0.1/screenlib/UIElementThumbstick.cpp:135:8: style: Condition '!GetTouchAngleAndDistance(x,y,angle,distance)' is always false [knownConditionTrueFalse] Maelstrom-4.0.1/screenlib/UIElementThumbstick.cpp:135:33: note: Calling function 'GetTouchAngleAndDistance' returns 1 Maelstrom-4.0.1/screenlib/UIElementThumbstick.cpp:135:8: note: Condition '!GetTouchAngleAndDistance(x,y,angle,distance)' is always false 2.20.0 Maelstrom-4.0.1/screenlib/UIElementThumbstick.cpp:183:22: style:inconclusive: Technically the member function 'UIElementThumbstick::GetTouchAngleAndDistance' can be const. [functionConst] Maelstrom-4.0.1/screenlib/UIElementThumbstick.h:43:7: note: Technically the member function 'UIElementThumbstick::GetTouchAngleAndDistance' can be const. Maelstrom-4.0.1/screenlib/UIElementThumbstick.cpp:183:22: note: Technically the member function 'UIElementThumbstick::GetTouchAngleAndDistance' can be const. 2.20.0 Maelstrom-4.0.1/screenlib/UIElementThumbstick.cpp:189:11: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_PI_F [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/screenlib/UIElementThumbstick.cpp:197:20: style: Variable 'state' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIElementThumbstick.cpp:38:2: performance: Variable 'm_finger' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] 2.20.0 Maelstrom-4.0.1/screenlib/UIElementThumbstick.cpp:44:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable action_enter [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/screenlib/UIElementThumbstick.cpp:73:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SDL_PI_F [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/screenlib/UIElementThumbstick.h:30:1: warning: The class 'UIElementThumbstick' defines member variable with name 's_elementType' also defined in its parent class 'UIBaseElement'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIBaseElement.h:249:23: note: Parent variable 'UIBaseElement::s_elementType' Maelstrom-4.0.1/screenlib/UIElementThumbstick.h:30:1: note: Derived variable 'UIElementThumbstick::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIElementThumbstick.h:30:1: warning: The class 'UIElementThumbstick' defines member variable with name 's_elementType' also defined in its parent class 'UIElement'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIElement.h:128:1: note: Parent variable 'UIElement::s_elementType' Maelstrom-4.0.1/screenlib/UIElementThumbstick.h:30:1: note: Derived variable 'UIElementThumbstick::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIElementThumbstick.h:33:11: style: The destructor '~UIElementThumbstick' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIElement.h:131:11: note: Virtual destructor in base class Maelstrom-4.0.1/screenlib/UIElementThumbstick.h:33:11: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/screenlib/UIManager.cpp:119:30: style: Variable 'attr' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIManager.cpp:183:34: style: Parameter 'panel' can be declared as pointer to const [constParameterPointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIManager.cpp:198:34: style: Parameter 'panel' can be declared as pointer to const [constParameterPointer] 2.20.0 Maelstrom-4.0.1/screenlib/UIManager.cpp:285:14: style: Local variable 'panel' shadows outer argument [shadowArgument] Maelstrom-4.0.1/screenlib/UIManager.cpp:277:31: note: Shadowed declaration Maelstrom-4.0.1/screenlib/UIManager.cpp:285:14: note: Shadow variable 2.20.0 Maelstrom-4.0.1/screenlib/UIManager.cpp:338:12: style:inconclusive: Technically the member function 'UIManager::IsCapturingEvents' can be const. [functionConst] Maelstrom-4.0.1/screenlib/UIManager.h:116:7: note: Technically the member function 'UIManager::IsCapturingEvents' can be const. Maelstrom-4.0.1/screenlib/UIManager.cpp:338:12: note: Technically the member function 'UIManager::IsCapturingEvents' can be const. 2.20.0 Maelstrom-4.0.1/screenlib/UIManager.cpp:33:11: style: C-style pointer casting [cstyleCast] 2.20.0 Maelstrom-4.0.1/screenlib/UIManager.cpp:365:12: style:inconclusive: Technically the member function 'UIManager::CheckCondition' can be const. [functionConst] Maelstrom-4.0.1/screenlib/UIManager.h:121:7: note: Technically the member function 'UIManager::CheckCondition' can be const. Maelstrom-4.0.1/screenlib/UIManager.cpp:365:12: note: Technically the member function 'UIManager::CheckCondition' can be const. 2.20.0 Maelstrom-4.0.1/screenlib/UIManager.h:127:15: style: The function 'OnRectChanged' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIArea.h:139:15: note: Virtual function in base class Maelstrom-4.0.1/screenlib/UIManager.h:127:15: note: Function in derived class 2.20.0 Maelstrom-4.0.1/screenlib/UIManager.h:50:11: style: The destructor '~UIManager' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIArea.h:64:11: note: Virtual destructor in base class Maelstrom-4.0.1/screenlib/UIManager.h:50:11: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/screenlib/UIManager.h:69:5: style: The member function 'UIManager::GetPanel < UIDialog >' can be static. [functionStatic] Maelstrom-4.0.1/screenlib/UIManager.h:69:5: note: The member function 'UIManager::GetPanel < UIDialog >' can be static. Maelstrom-4.0.1/screenlib/UIManager.h:69:5: note: The member function 'UIManager::GetPanel < UIDialog >' can be static. 2.20.0 Maelstrom-4.0.1/screenlib/UIManager.h:72:11: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast] 2.20.0 Maelstrom-4.0.1/screenlib/UIPanel.h:39:2: style: Class 'UIPanelDelegate' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.20.0 Maelstrom-4.0.1/screenlib/UIPanel.h:74:1: warning: The class 'UIPanel' defines member variable with name 's_elementType' also defined in its parent class 'UIBaseElement'. [duplInheritedMember] Maelstrom-4.0.1/screenlib/UIBaseElement.h:249:23: note: Parent variable 'UIBaseElement::s_elementType' Maelstrom-4.0.1/screenlib/UIPanel.h:74:1: note: Derived variable 'UIPanel::s_elementType' 2.20.0 Maelstrom-4.0.1/screenlib/UIPanel.h:77:11: style: The destructor '~UIPanel' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] Maelstrom-4.0.1/screenlib/UIBaseElement.h:51:11: note: Virtual destructor in base class Maelstrom-4.0.1/screenlib/UIPanel.h:77:11: note: Destructor in derived class 2.20.0 Maelstrom-4.0.1/screenlib/UIPanel.h:88:6: style:inconclusive: Technically the member function 'UIPanel::GetPriority' can be const. [functionConst] 2.20.0 Maelstrom-4.0.1/screenlib/UITemplates.cpp:109:35: style: C-style pointer casting [cstyleCast] 2.20.0 Maelstrom-4.0.1/screenlib/UITemplates.cpp:117:41: style:inconclusive: Function 'HashTable_Hash' argument 1 names different: declaration 'key' definition '_key'. [funcArgNamesDifferent] Maelstrom-4.0.1/screenlib/UITemplates.h:46:45: note: Function 'HashTable_Hash' argument 1 names different: declaration 'key' definition '_key'. Maelstrom-4.0.1/screenlib/UITemplates.cpp:117:41: note: Function 'HashTable_Hash' argument 1 names different: declaration 'key' definition '_key'. 2.20.0 Maelstrom-4.0.1/screenlib/UITemplates.cpp:117:53: style: Parameter 'data' can be declared as pointer to const. However it seems that 'HashTable_Hash' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] Maelstrom-4.0.1/screenlib/UITemplates.cpp:72:34: note: You might need to cast the function pointer here Maelstrom-4.0.1/screenlib/UITemplates.cpp:117:53: note: Parameter 'data' can be declared as pointer to const 2.20.0 Maelstrom-4.0.1/screenlib/UITemplates.cpp:130:45: style:inconclusive: Function 'HashTable_KeyMatch' argument 1 names different: declaration 'a' definition '_a'. [funcArgNamesDifferent] Maelstrom-4.0.1/screenlib/UITemplates.h:47:44: note: Function 'HashTable_KeyMatch' argument 1 names different: declaration 'a' definition '_a'. Maelstrom-4.0.1/screenlib/UITemplates.cpp:130:45: note: Function 'HashTable_KeyMatch' argument 1 names different: declaration 'a' definition '_a'. 2.20.0 Maelstrom-4.0.1/screenlib/UITemplates.cpp:130:61: style:inconclusive: Function 'HashTable_KeyMatch' argument 2 names different: declaration 'b' definition '_b'. [funcArgNamesDifferent] Maelstrom-4.0.1/screenlib/UITemplates.h:47:59: note: Function 'HashTable_KeyMatch' argument 2 names different: declaration 'b' definition '_b'. Maelstrom-4.0.1/screenlib/UITemplates.cpp:130:61: note: Function 'HashTable_KeyMatch' argument 2 names different: declaration 'b' definition '_b'. 2.20.0 Maelstrom-4.0.1/screenlib/UITemplates.cpp:130:71: style: Parameter 'data' can be declared as pointer to const. However it seems that 'HashTable_KeyMatch' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] Maelstrom-4.0.1/screenlib/UITemplates.cpp:73:6: note: You might need to cast the function pointer here Maelstrom-4.0.1/screenlib/UITemplates.cpp:130:71: note: Parameter 'data' can be declared as pointer to const 2.20.0 Maelstrom-4.0.1/screenlib/UITemplates.cpp:139:41: style:inconclusive: Function 'HashTable_Nuke' argument 1 names different: declaration 'key' definition '_key'. [funcArgNamesDifferent] Maelstrom-4.0.1/screenlib/UITemplates.h:48:41: note: Function 'HashTable_Nuke' argument 1 names different: declaration 'key' definition '_key'. Maelstrom-4.0.1/screenlib/UITemplates.cpp:139:41: note: Function 'HashTable_Nuke' argument 1 names different: declaration 'key' definition '_key'. 2.20.0 Maelstrom-4.0.1/screenlib/UITemplates.cpp:139:72: style: Parameter 'data' can be declared as pointer to const. However it seems that 'HashTable_Nuke' is a callback function, if 'data' is declared with const you might also need to cast function pointer(s). [constParameterCallback] Maelstrom-4.0.1/screenlib/UITemplates.cpp:74:6: note: You might need to cast the function pointer here Maelstrom-4.0.1/screenlib/UITemplates.cpp:139:72: note: Parameter 'data' can be declared as pointer to const 2.20.0 Maelstrom-4.0.1/screenlib/UITemplates.cpp:49:24: style: Variable 'node' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/screenlib/UITemplates.cpp:50:29: style: The scope of the variable 'attr' can be reduced. [variableScope] 2.20.0 Maelstrom-4.0.1/screenlib/UITemplates.cpp:50:29: style: Variable 'attr' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/screenlib/UITemplates.cpp:61:6: style: Condition 'gLoadXMLError' is always false [knownConditionTrueFalse] Maelstrom-4.0.1/screenlib/UITemplates.cpp:59:18: note: Assignment 'gLoadXMLError=NULL', assigned value is 0 Maelstrom-4.0.1/screenlib/UITemplates.cpp:61:6: note: Condition 'gLoadXMLError' is always false 2.20.0 Maelstrom-4.0.1/screenlib/UITemplates.cpp:89:51: style: Parameter 'node' can be declared as pointer to const [constParameterPointer] 2.20.0 Maelstrom-4.0.1/screenlib/UITemplates.cpp:91:29: style: Variable 'attr' can be declared as pointer to const [constVariablePointer] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < GameInfo >' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < GameInfo >' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < Gamepad >' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < Gamepad >' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < Mod * >' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < Mod * >' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < ModBox >' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < ModBox >' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < Resolution >' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < Resolution >' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < Scores >' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < Scores >' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < ThumbstickAction >' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < ThumbstickAction >' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < UIArea * >' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < UIArea * >' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < UIBaseElement * >' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < UIBaseElement * >' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < UIElementEditbox * >' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < UIElementEditbox * >' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < UIElementRadioButton * >' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < UIElementRadioButton * >' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < UIPanel * >' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < UIPanel * >' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < char * >' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] 2.20.0 Maelstrom-4.0.1/utils/array.h:33:32: warning: Class 'array < char * >' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] head Maelstrom-4.0.1/utils/hashtable.c:162:42: style:inconclusive: Function 'hash_create' argument 3 names different: declaration '' definition 'keymatchfn'. [funcArgNamesDifferentUnnamed] head Maelstrom-4.0.1/utils/hashtable.c:163:38: style:inconclusive: Function 'hash_create' argument 4 names different: declaration '' definition 'nukefn'. [funcArgNamesDifferentUnnamed] 2.20.0 Maelstrom-4.0.1/utils/loadxml.cpp:57:60: style: Parameter 'where' can be declared as pointer to const [constParameterPointer] 2.20.0 Maelstrom-4.0.1/utils/prefs.h:123:4: style:inconclusive: Technically the member function 'PrefsVariable < SDL_Keycode >::Value' can be const. [functionConst] 2.20.0 Maelstrom-4.0.1/utils/prefs.h:123:4: style:inconclusive: Technically the member function 'PrefsVariable < int >::Value' can be const. [functionConst] head Maelstrom-4.0.1/utils/rapidxml.h:30:12: error: syntax error [syntaxError] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:1004:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable m_parent [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:1027:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable m_parent [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:1436:14: warning: The class 'xml_document < char >' defines member function with name 'clear' also defined in its parent class 'memory_pool < char >'. [duplInheritedMember] Maelstrom-4.0.1/utils/rapidxml.hpp:546:14: note: Parent function 'memory_pool < char >::clear' Maelstrom-4.0.1/utils/rapidxml.hpp:1436:14: note: Derived function 'xml_document < char >::clear' 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:1453:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable lookup_whitespace [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:1462:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable lookup_node_name [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:1471:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable lookup_attribute_name [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:1480:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable lookup_text [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:1489:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable lookup_text_pure_no_ws [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:1498:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable lookup_text_pure_with_ws [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:1508:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Quote [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:1522:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Quote [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:1534:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Flags [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:1594:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Flags [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:1746:14: style: Either there is a missing 'override', or the member function 'rapidxml::xml_document < char >::parse_bom' can be static. [functionStatic] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:1746:14: style: The member function 'rapidxml::xml_document < char >::parse_bom' can be static. [functionStatic] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:1762:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Flags [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:1797:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Flags [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:1878:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Flags [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:1904:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Flags [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:1964:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Flags [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:2022:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Flags [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:2093:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Flags [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:2214:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Flags [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:2284:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Flags [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:594:15: style: The member function 'rapidxml::memory_pool < char >::align' can be static. [functionStatic] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:678:9: warning: Member variable 'xml_base < char >::m_name_size' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:678:9: warning: Member variable 'xml_base < char >::m_value_size' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:831:9: warning: Member variable 'xml_attribute < char >::m_next_attribute' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:831:9: warning: Member variable 'xml_attribute < char >::m_prev_attribute' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:869:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable m_parent [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:889:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable m_parent [valueFlowBailoutIncompleteVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:922:9: style: Class 'xml_node < char >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:922:9: warning: Member variable 'xml_node < char >::m_last_attribute' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:922:9: warning: Member variable 'xml_node < char >::m_last_node' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:922:9: warning: Member variable 'xml_node < char >::m_next_sibling' is not initialized in the constructor. [uninitMemberVar] 2.20.0 Maelstrom-4.0.1/utils/rapidxml.hpp:922:9: warning: Member variable 'xml_node < char >::m_prev_sibling' is not initialized in the constructor. [uninitMemberVar] DONE