2024-03-27 18:53 ftp://ftp.de.debian.org/debian/pool/main/l/lordsawar/lordsawar_0.3.2+frogknows.orig.tar.gz cppcheck-options: --library=posix --library=gnu --library=libsigc++ --showtime=top5 --check-library --inconclusive --enable=style,information --inline-suppr --disable=missingInclude --suppress=unmatchedSuppression --template=daca2 --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=valueFlowBailoutIncompleteVar -D__GNUC__ --platform=unix64 -j4 platform: Linux-6.1.0-0.deb11.6-amd64-x86_64-with-glibc2.31 python: 3.9.2 client-version: 1.3.45 compiler: g++ (Debian 10.2.1-6) 10.2.1 20210110 cppcheck: head 2.13.0 head-info: 4d68318 (2024-03-27 19:27:33 +0100) count: 3251 3126 elapsed-time: 70.7 671.9 head-timing-info: Tokenizer::simplifyTokens1::ValueFlow: 10.9967s (avg. 10.9967s - 1 result(s)) valueFlowCondition(SimpleConditionHandler{}, tokenlist, symboldatabase, errorLogger, settings, skippedFunctions): 10.7828s (avg. 3.59426s - 3 result(s)) valueFlowAfterAssign(tokenlist, symboldatabase, errorLogger, settings, skippedFunctions): 0.145046s (avg. 0.0483487s - 3 result(s)) Tokenizer::simplifyTokens1::simplifyTokenList1: 0.033185s (avg. 0.033185s - 1 result(s)) Tokenizer::simplifyTokens1::createSymbolDatabase: 0.028788s (avg. 0.028788s - 1 result(s)) Overall time: 11.1241s old-timing-info: Tokenizer::simplifyTokens1::ValueFlow: 665.279s (avg. 665.279s - 1 result(s)) valueFlowLifetime(tokenlist, errorLogger, settings): 658.631s (avg. 164.658s - 4 result(s)) valueFlowCondition(SimpleConditionHandler{}, tokenlist, symboldatabase, errorLogger, settings, skippedFunctions): 4.15321s (avg. 1.3844s - 3 result(s)) valueFlowAfterAssign(tokenlist, symboldatabase, errorLogger, settings, skippedFunctions): 1.28378s (avg. 0.427927s - 3 result(s)) valueFlowCondition(SymbolicConditionHandler{}, tokenlist, symboldatabase, errorLogger, settings, skippedFunctions): 0.644317s (avg. 0.214772s - 3 result(s)) Overall time: 666.144s head results: lordsawar-0.3.2/src/rectangle.h:42:24: warning: Member variable 'LwRectangle::x' is not assigned a value in 'LwRectangle::operator='. [operatorEqVarError] lordsawar-0.3.2/src/rectangle.h:42:24: warning: Member variable 'LwRectangle::y' is not assigned a value in 'LwRectangle::operator='. [operatorEqVarError] lordsawar-0.3.2/src/rectangle.h:42:24: warning: Member variable 'LwRectangle::w' is not assigned a value in 'LwRectangle::operator='. [operatorEqVarError] lordsawar-0.3.2/src/rectangle.h:42:24: warning: Member variable 'LwRectangle::h' is not assigned a value in 'LwRectangle::operator='. [operatorEqVarError] lordsawar-0.3.2/src/vector.h:37:3: warning:inconclusive: Member variable 'Vector < double >::x' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/vector.h:37:3: warning:inconclusive: Member variable 'Vector < double >::y' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/vector.h:37:3: warning:inconclusive: Member variable 'Vector < float >::x' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/vector.h:37:3: warning:inconclusive: Member variable 'Vector < float >::y' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/vector.h:37:3: warning:inconclusive: Member variable 'Vector < int >::x' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/vector.h:37:3: warning:inconclusive: Member variable 'Vector < int >::y' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/UniquelyIdentified.h:64:10: style:inconclusive: Technically the member function 'UniquelyIdentified::isUnique' can be const. [functionConst] lordsawar-0.3.2/src/vector.h:91:8: style:inconclusive: Technically the member function 'Vector < double >::toIndex' can be const. [functionConst] lordsawar-0.3.2/src/vector.h:91:8: style:inconclusive: Technically the member function 'Vector < float >::toIndex' can be const. [functionConst] lordsawar-0.3.2/src/vector.h:91:8: style:inconclusive: Technically the member function 'Vector < int >::toIndex' can be const. [functionConst] lordsawar-0.3.2/src/AICityInfo.cpp:29:5: warning: Class 'AICityInfo' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] lordsawar-0.3.2/src/AICityInfo.cpp:29:5: warning: Class 'AICityInfo' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] lordsawar-0.3.2/src/city.h:228:14: warning: The class 'City' defines member function with name 'save' also defined in its parent class 'ProdSlotlist'. [duplInheritedMember] lordsawar-0.3.2/src/prodslotlist.h:93:14: note: Parent function 'ProdSlotlist::save' lordsawar-0.3.2/src/city.h:228:14: note: Derived function 'City::save' lordsawar-0.3.2/src/city.h:271:7: warning: The class 'City' defines member function with name 'load' also defined in its parent class 'ProdSlotlist'. [duplInheritedMember] lordsawar-0.3.2/src/prodslotlist.h:193:7: note: Parent function 'ProdSlotlist::load' lordsawar-0.3.2/src/city.h:271:7: note: Derived function 'City::load' lordsawar-0.3.2/src/Positioned.h:36:6: style: Class 'Positioned' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/Positioned.h:42:6: style: Class 'Positioned' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/Immovable.h:39:6: style: Class 'Immovable' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/Immovable.h:45:6: style: Class 'Immovable' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/rectangle.h:33:5: style: Class 'LwRectangle' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/LocationBox.h:50:6: style: Class 'LocationBox' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/LocationBox.h:72:6: style: Class 'LocationBox' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/UniquelyIdentified.h:41:5: style: Class 'UniquelyIdentified' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/UniquelyIdentified.h:44:5: style: Class 'UniquelyIdentified' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/Location.h:43:6: style: Class 'Location' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/Location.h:59:6: style: Class 'Location' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/Ownable.h:36:6: style: Class 'Ownable' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/Ownable.h:42:6: style: Class 'Ownable' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/Named.h:34:6: style: Class 'Named' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/Named.h:38:6: style: Class 'Named' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/Renamable.h:36:6: style: Class 'Renamable' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/Renamable.h:42:6: style: Class 'Renamable' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/prodslot.h:45:6: style: Class 'ProdSlot' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/prodslotlist.h:54:9: style: Class 'ProdSlotlist' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/prodslotlist.h:67:9: style: Class 'ProdSlotlist' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/AICityInfo.h:45:9: style: Class 'AICityInfo' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/Threat.h:64:9: style: Class 'Threat' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/Threat.h:67:9: style: Class 'Threat' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/Threat.h:70:9: style: Class 'Threat' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/vector.h:39:3: style: Struct 'Vector < double >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/vector.h:44:3: style: Struct 'Vector < double >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/vector.h:39:3: style: Struct 'Vector < float >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/vector.h:44:3: style: Struct 'Vector < float >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/vector.h:39:3: style: Struct 'Vector < int >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/vector.h:44:3: style: Struct 'Vector < int >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/Location.h:62:6: style: The destructor '~Location' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/UniquelyIdentified.h:47:14: note: Virtual destructor in base class lordsawar-0.3.2/src/Location.h:62:6: note: Destructor in derived class lordsawar-0.3.2/src/city.h:103:10: style: The destructor '~City' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Ownable.h:45:14: note: Virtual destructor in base class lordsawar-0.3.2/src/city.h:103:10: note: Destructor in derived class lordsawar-0.3.2/src/Threat.h:73:10: style: The destructor '~Threat' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Ownable.h:45:14: note: Virtual destructor in base class lordsawar-0.3.2/src/Threat.h:73:10: note: Destructor in derived class lordsawar-0.3.2/src/Item.h:53:23: warning: The class 'Item' defines member variable with name 'd_tag' also defined in its parent class 'ItemProto'. [duplInheritedMember] lordsawar-0.3.2/src/ItemProto.h:47:23: note: Parent variable 'ItemProto::d_tag' lordsawar-0.3.2/src/Item.h:53:23: note: Derived variable 'Item::d_tag' lordsawar-0.3.2/src/Item.h:74:14: warning: The class 'Item' defines member function with name 'save' also defined in its parent class 'ItemProto'. [duplInheritedMember] lordsawar-0.3.2/src/ItemProto.h:126:14: note: Parent function 'ItemProto::save' lordsawar-0.3.2/src/Item.h:74:14: note: Derived function 'Item::save' lordsawar-0.3.2/src/Backpack.h:52:9: style: Class 'Backpack' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/xmlhelper.h:106:9: style: Class 'XML_Helper' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/xmlhelper.h:112:9: style: Class 'XML_Helper' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/ItemProto.h:114:9: style: Class 'ItemProto' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/ItemProto.h:120:9: style: Class 'ItemProto' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/Item.h:56:9: style: Class 'Item' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/Item.h:68:10: style: The destructor '~Item' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/ItemProto.h:123:18: note: Virtual destructor in base class lordsawar-0.3.2/src/Item.h:68:10: note: Destructor in derived class lordsawar-0.3.2/src/xmlhelper.h:262:46: style: Parameter 'helper' can be declared as pointer to const. However it seems that 'load' is a callback function, if 'helper' is declared with const you might also need to cast function pointer(s). [constParameterCallback] lordsawar-0.3.2/src/xmlhelper.h:255:74: note: You might need to cast the function pointer here lordsawar-0.3.2/src/xmlhelper.h:262:46: note: Parameter 'helper' can be declared as pointer to const lordsawar-0.3.2/src/Backpack.cpp:59:15: style: Variable 'retval' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/Backpack.cpp:61:12: style: Variable 'retval' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/Backpack.cpp:47:68: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Backpack.cpp:53:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Backpack.cpp:60:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Backpack.cpp:94:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Backpack.cpp:109:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Backpack.cpp:124:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Backpack.cpp:141:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Backpack.cpp:150:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Backpack.cpp:159:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Backpack.cpp:167:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Backpack.cpp:175:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Backpack.cpp:184:36: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Backpack.cpp:198:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Backpack.cpp:217:74: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Backpack.cpp:223:60: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Backpack.cpp:233:60: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/ucompose.hpp:85:17: style: Unused private function: 'Composition::stringify' [unusedPrivateFunction] lordsawar-0.3.2/src/PixMask.h:34:36: style:inconclusive: Technically the member function 'PixMask::get_pixmap' can be const. [functionConst] lordsawar-0.3.2/src/PixMask.h:35:36: style:inconclusive: Technically the member function 'PixMask::get_mask' can be const. [functionConst] lordsawar-0.3.2/src/PixMask.h:36:36: style:inconclusive: Technically the member function 'PixMask::get_gc' can be const. [functionConst] lordsawar-0.3.2/src/PixMask.h:37:10: style:inconclusive: Technically the member function 'PixMask::get_width' can be const. [functionConst] lordsawar-0.3.2/src/PixMask.h:38:10: style:inconclusive: Technically the member function 'PixMask::get_height' can be const. [functionConst] lordsawar-0.3.2/src/PixMask.h:39:10: style:inconclusive: Technically the member function 'PixMask::get_unscaled_width' can be const. [functionConst] lordsawar-0.3.2/src/PixMask.h:40:10: style:inconclusive: Technically the member function 'PixMask::get_unscaled_height' can be const. [functionConst] lordsawar-0.3.2/src/fight.h:168:36: style:inconclusive: Technically the member function 'Fight::getInitialHPs' can be const. [functionConst] lordsawar-0.3.2/src/army.h:335:14: warning: The class 'Army' defines member function with name 'saveData' also defined in its parent class 'ArmyBase'. [duplInheritedMember] lordsawar-0.3.2/src/armybase.h:212:14: note: Parent function 'ArmyBase::saveData' lordsawar-0.3.2/src/army.h:335:14: note: Derived function 'Army::saveData' lordsawar-0.3.2/src/MapBackpack.h:40:27: warning: The class 'MapBackpack' defines member variable with name 'd_tag' also defined in its parent class 'Backpack'. [duplInheritedMember] lordsawar-0.3.2/src/Backpack.h:37:23: note: Parent variable 'Backpack::d_tag' lordsawar-0.3.2/src/MapBackpack.h:40:27: note: Derived variable 'MapBackpack::d_tag' lordsawar-0.3.2/src/MapBackpack.h:55:10: warning: The class 'MapBackpack' defines member function with name 'save' also defined in its parent class 'Backpack'. [duplInheritedMember] lordsawar-0.3.2/src/Backpack.h:66:14: note: Parent function 'Backpack::save' lordsawar-0.3.2/src/MapBackpack.h:55:10: note: Derived function 'MapBackpack::save' lordsawar-0.3.2/src/AI_Diplomacy.h:31:9: style: Class 'AI_Diplomacy' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMask.h:71:6: style: Class 'PixMask' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/tilestyle.h:283:9: style: Class 'TileStyle' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/tilestyleset.h:66:9: style: Class 'TileStyleSet' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/Tile.h:84:9: style: Class 'Tile' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/armybase.h:102:9: style: Class 'ArmyBase' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/army.h:101:9: style: Class 'Army' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/army.h:104:9: style: Class 'Army' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/army.h:122:9: style: Class 'Army' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/playerlist.h:310:9: style: Class 'Playerlist' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PathCalculator.h:40:5: style: Class 'PathCalculator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PathCalculator.h:43:5: style: Class 'PathCalculator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/Movable.h:38:6: style: Class 'Movable' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/Movable.h:44:6: style: Class 'Movable' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/stack.h:77:9: style: Class 'Stack' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/SmallTile.h:130:9: style: Class 'SmallTile' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/MapBackpack.h:43:6: style: Class 'MapBackpack' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/MapBackpack.h:49:6: style: Class 'MapBackpack' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/citylist.h:385:9: style: Class 'Citylist' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:145:9: style: Class 'History_StartTurn' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:165:9: style: Class 'History_FoundSage' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:169:9: style: Class 'History_FoundSage' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:194:9: style: Class 'History_GoldTotal' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:198:9: style: Class 'History_GoldTotal' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:227:9: style: Class 'History_HeroEmerges' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:263:9: style: Class 'History_CityWon' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:267:9: style: Class 'History_CityWon' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:296:9: style: Class 'History_HeroCityWon' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:327:9: style: Class 'History_CityRazed' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:331:9: style: Class 'History_CityRazed' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:356:9: style: Class 'History_HeroQuestStarted' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:360:9: style: Class 'History_HeroQuestStarted' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:385:9: style: Class 'History_HeroQuestCompleted' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:389:9: style: Class 'History_HeroQuestCompleted' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:418:9: style: Class 'History_HeroKilledInCity' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:449:9: style: Class 'History_HeroKilledInBattle' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:453:9: style: Class 'History_HeroKilledInBattle' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:478:9: style: Class 'History_HeroKilledSearching' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:482:9: style: Class 'History_HeroKilledSearching' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:507:9: style: Class 'History_Score' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:511:9: style: Class 'History_Score' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:540:9: style: Class 'History_PlayerVanquished' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:559:9: style: Class 'History_DiplomacyPeace' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:563:9: style: Class 'History_DiplomacyPeace' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:588:9: style: Class 'History_DiplomacyWar' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:592:9: style: Class 'History_DiplomacyWar' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:617:9: style: Class 'History_DiplomacyTreachery' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:621:9: style: Class 'History_DiplomacyTreachery' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:646:9: style: Class 'History_HeroFindsAllies' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:650:9: style: Class 'History_HeroFindsAllies' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:678:2: style: Class 'History_EndTurn' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:701:9: style: Class 'History_HeroRuinExplored' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:737:9: style: Class 'History_HeroRewardRuin' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/history.h:774:9: style: Class 'History_HeroUseItem' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/overviewmap.h:60:6: style: Class 'OverviewMap' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/select-city-map.h:43:5: style: Class 'SelectCityMap' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/army.h:132:18: style: The destructor '~Army' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/armybase.h:108:18: note: Virtual destructor in base class lordsawar-0.3.2/src/army.h:132:18: note: Destructor in derived class lordsawar-0.3.2/src/stack.h:80:10: style: The destructor '~Stack' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/UniquelyIdentified.h:47:14: note: Virtual destructor in base class lordsawar-0.3.2/src/stack.h:80:10: note: Destructor in derived class lordsawar-0.3.2/src/MapBackpack.h:52:6: style: The destructor '~MapBackpack' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/UniquelyIdentified.h:47:14: note: Virtual destructor in base class lordsawar-0.3.2/src/MapBackpack.h:52:6: note: Destructor in derived class lordsawar-0.3.2/src/history.h:147:10: style: The destructor '~History_StartTurn' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:147:10: note: Destructor in derived class lordsawar-0.3.2/src/history.h:150:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:106:31: note: Virtual function in base class lordsawar-0.3.2/src/history.h:150:23: note: Function in derived class lordsawar-0.3.2/src/history.h:153:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:130:22: note: Virtual function in base class lordsawar-0.3.2/src/history.h:153:22: note: Function in derived class lordsawar-0.3.2/src/history.h:171:10: style: The destructor '~History_FoundSage' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:171:10: note: Destructor in derived class lordsawar-0.3.2/src/history.h:174:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:106:31: note: Virtual function in base class lordsawar-0.3.2/src/history.h:174:23: note: Function in derived class lordsawar-0.3.2/src/history.h:177:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:130:22: note: Virtual function in base class lordsawar-0.3.2/src/history.h:177:22: note: Function in derived class lordsawar-0.3.2/src/history.h:200:10: style: The destructor '~History_GoldTotal' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:200:10: note: Destructor in derived class lordsawar-0.3.2/src/history.h:203:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:106:31: note: Virtual function in base class lordsawar-0.3.2/src/history.h:203:23: note: Function in derived class lordsawar-0.3.2/src/history.h:206:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:130:22: note: Virtual function in base class lordsawar-0.3.2/src/history.h:206:22: note: Function in derived class lordsawar-0.3.2/src/history.h:229:10: style: The destructor '~History_HeroEmerges' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:229:10: note: Destructor in derived class lordsawar-0.3.2/src/history.h:232:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:106:31: note: Virtual function in base class lordsawar-0.3.2/src/history.h:232:23: note: Function in derived class lordsawar-0.3.2/src/history.h:235:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:130:22: note: Virtual function in base class lordsawar-0.3.2/src/history.h:235:22: note: Function in derived class lordsawar-0.3.2/src/history.h:269:10: style: The destructor '~History_CityWon' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:269:10: note: Destructor in derived class lordsawar-0.3.2/src/history.h:272:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:106:31: note: Virtual function in base class lordsawar-0.3.2/src/history.h:272:23: note: Function in derived class lordsawar-0.3.2/src/history.h:275:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:130:22: note: Virtual function in base class lordsawar-0.3.2/src/history.h:275:22: note: Function in derived class lordsawar-0.3.2/src/history.h:298:10: style: The destructor '~History_HeroCityWon' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:298:10: note: Destructor in derived class lordsawar-0.3.2/src/history.h:301:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:106:31: note: Virtual function in base class lordsawar-0.3.2/src/history.h:301:23: note: Function in derived class lordsawar-0.3.2/src/history.h:304:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:130:22: note: Virtual function in base class lordsawar-0.3.2/src/history.h:304:22: note: Function in derived class lordsawar-0.3.2/src/history.h:333:10: style: The destructor '~History_CityRazed' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:333:10: note: Destructor in derived class lordsawar-0.3.2/src/history.h:336:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:106:31: note: Virtual function in base class lordsawar-0.3.2/src/history.h:336:23: note: Function in derived class lordsawar-0.3.2/src/history.h:339:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:130:22: note: Virtual function in base class lordsawar-0.3.2/src/history.h:339:22: note: Function in derived class lordsawar-0.3.2/src/history.h:362:10: style: The destructor '~History_HeroQuestStarted' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:362:10: note: Destructor in derived class lordsawar-0.3.2/src/history.h:365:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:106:31: note: Virtual function in base class lordsawar-0.3.2/src/history.h:365:23: note: Function in derived class lordsawar-0.3.2/src/history.h:368:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:130:22: note: Virtual function in base class lordsawar-0.3.2/src/history.h:368:22: note: Function in derived class lordsawar-0.3.2/src/history.h:391:10: style: The destructor '~History_HeroQuestCompleted' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:391:10: note: Destructor in derived class lordsawar-0.3.2/src/history.h:394:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:106:31: note: Virtual function in base class lordsawar-0.3.2/src/history.h:394:23: note: Function in derived class lordsawar-0.3.2/src/history.h:397:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:130:22: note: Virtual function in base class lordsawar-0.3.2/src/history.h:397:22: note: Function in derived class lordsawar-0.3.2/src/history.h:420:10: style: The destructor '~History_HeroKilledInCity' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:420:10: note: Destructor in derived class lordsawar-0.3.2/src/history.h:423:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:106:31: note: Virtual function in base class lordsawar-0.3.2/src/history.h:423:23: note: Function in derived class lordsawar-0.3.2/src/history.h:426:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:130:22: note: Virtual function in base class lordsawar-0.3.2/src/history.h:426:22: note: Function in derived class lordsawar-0.3.2/src/history.h:455:10: style: The destructor '~History_HeroKilledInBattle' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:455:10: note: Destructor in derived class lordsawar-0.3.2/src/history.h:458:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:106:31: note: Virtual function in base class lordsawar-0.3.2/src/history.h:458:23: note: Function in derived class lordsawar-0.3.2/src/history.h:461:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:130:22: note: Virtual function in base class lordsawar-0.3.2/src/history.h:461:22: note: Function in derived class lordsawar-0.3.2/src/history.h:484:10: style: The destructor '~History_HeroKilledSearching' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:484:10: note: Destructor in derived class lordsawar-0.3.2/src/history.h:487:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:106:31: note: Virtual function in base class lordsawar-0.3.2/src/history.h:487:23: note: Function in derived class lordsawar-0.3.2/src/history.h:490:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:130:22: note: Virtual function in base class lordsawar-0.3.2/src/history.h:490:22: note: Function in derived class lordsawar-0.3.2/src/history.h:513:10: style: The destructor '~History_Score' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:513:10: note: Destructor in derived class lordsawar-0.3.2/src/history.h:516:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:106:31: note: Virtual function in base class lordsawar-0.3.2/src/history.h:516:23: note: Function in derived class lordsawar-0.3.2/src/history.h:519:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:130:22: note: Virtual function in base class lordsawar-0.3.2/src/history.h:519:22: note: Function in derived class lordsawar-0.3.2/src/history.h:542:10: style: The destructor '~History_PlayerVanquished' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:542:10: note: Destructor in derived class lordsawar-0.3.2/src/history.h:545:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:106:31: note: Virtual function in base class lordsawar-0.3.2/src/history.h:545:23: note: Function in derived class lordsawar-0.3.2/src/history.h:548:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:130:22: note: Virtual function in base class lordsawar-0.3.2/src/history.h:548:22: note: Function in derived class lordsawar-0.3.2/src/history.h:565:10: style: The destructor '~History_DiplomacyPeace' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:565:10: note: Destructor in derived class lordsawar-0.3.2/src/history.h:568:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:106:31: note: Virtual function in base class lordsawar-0.3.2/src/history.h:568:23: note: Function in derived class lordsawar-0.3.2/src/history.h:571:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:130:22: note: Virtual function in base class lordsawar-0.3.2/src/history.h:571:22: note: Function in derived class lordsawar-0.3.2/src/history.h:594:10: style: The destructor '~History_DiplomacyWar' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:594:10: note: Destructor in derived class lordsawar-0.3.2/src/history.h:597:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:106:31: note: Virtual function in base class lordsawar-0.3.2/src/history.h:597:23: note: Function in derived class lordsawar-0.3.2/src/history.h:600:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:130:22: note: Virtual function in base class lordsawar-0.3.2/src/history.h:600:22: note: Function in derived class lordsawar-0.3.2/src/history.h:623:10: style: The destructor '~History_DiplomacyTreachery' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:623:10: note: Destructor in derived class lordsawar-0.3.2/src/history.h:626:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:106:31: note: Virtual function in base class lordsawar-0.3.2/src/history.h:626:23: note: Function in derived class lordsawar-0.3.2/src/history.h:629:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:130:22: note: Virtual function in base class lordsawar-0.3.2/src/history.h:629:22: note: Function in derived class lordsawar-0.3.2/src/history.h:652:10: style: The destructor '~History_HeroFindsAllies' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:652:10: note: Destructor in derived class lordsawar-0.3.2/src/history.h:655:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:106:31: note: Virtual function in base class lordsawar-0.3.2/src/history.h:655:23: note: Function in derived class lordsawar-0.3.2/src/history.h:658:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:130:22: note: Virtual function in base class lordsawar-0.3.2/src/history.h:658:22: note: Function in derived class lordsawar-0.3.2/src/history.h:680:3: style: The destructor '~History_EndTurn' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:680:3: note: Destructor in derived class lordsawar-0.3.2/src/history.h:683:16: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:106:31: note: Virtual function in base class lordsawar-0.3.2/src/history.h:683:16: note: Function in derived class lordsawar-0.3.2/src/history.h:686:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:130:22: note: Virtual function in base class lordsawar-0.3.2/src/history.h:686:22: note: Function in derived class lordsawar-0.3.2/src/history.h:703:10: style: The destructor '~History_HeroRuinExplored' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:703:10: note: Destructor in derived class lordsawar-0.3.2/src/history.h:706:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:106:31: note: Virtual function in base class lordsawar-0.3.2/src/history.h:706:23: note: Function in derived class lordsawar-0.3.2/src/history.h:709:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:130:22: note: Virtual function in base class lordsawar-0.3.2/src/history.h:709:22: note: Function in derived class lordsawar-0.3.2/src/history.h:739:10: style: The destructor '~History_HeroRewardRuin' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:739:10: note: Destructor in derived class lordsawar-0.3.2/src/history.h:742:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:106:31: note: Virtual function in base class lordsawar-0.3.2/src/history.h:742:23: note: Function in derived class lordsawar-0.3.2/src/history.h:745:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:130:22: note: Virtual function in base class lordsawar-0.3.2/src/history.h:745:22: note: Function in derived class lordsawar-0.3.2/src/history.h:776:10: style: The destructor '~History_HeroUseItem' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:776:10: note: Destructor in derived class lordsawar-0.3.2/src/history.h:779:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:106:31: note: Virtual function in base class lordsawar-0.3.2/src/history.h:779:23: note: Function in derived class lordsawar-0.3.2/src/history.h:782:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:130:22: note: Virtual function in base class lordsawar-0.3.2/src/history.h:782:22: note: Function in derived class lordsawar-0.3.2/src/select-city-map.h:46:6: style: The destructor '~SelectCityMap' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:63:15: note: Virtual destructor in base class lordsawar-0.3.2/src/select-city-map.h:46:6: note: Destructor in derived class lordsawar-0.3.2/src/select-city-map.h:70:18: style: The function 'after_draw' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:221:18: note: Virtual function in base class lordsawar-0.3.2/src/select-city-map.h:70:18: note: Function in derived class lordsawar-0.3.2/src/AI_Diplomacy.cpp:99:8: style: The scope of the variable 'at_war' can be reduced. [variableScope] lordsawar-0.3.2/src/player.h:1731:48: performance: Function parameter 'stacks' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/stack.h:135:26: performance:inconclusive: Function parameter 'p' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/GameScenarioOptions.h:55:62: performance: Function parameter 'g' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/AI_Diplomacy.cpp:119:10: style: Variable 'first' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/AI_Diplomacy.cpp:122:14: style: Variable 'c' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/ucompose.hpp:331:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/AI_Diplomacy.cpp:90:33: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/LocationList.h:164:38: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/LocationList.h:204:38: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/LocationList.h:255:38: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/setlist.h:36:32: performance: Variable 'extension' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/AI_Analysis.h:111:14: performance:inconclusive: Technically the member function 'AI_Analysis::examineRuins' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/AI_Analysis.cpp:233:19: note: Technically the member function 'AI_Analysis::examineRuins' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/AI_Analysis.h:111:14: note: Technically the member function 'AI_Analysis::examineRuins' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/AI_Analysis.cpp:46:5: warning: Class 'AI_Analysis' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] lordsawar-0.3.2/src/AI_Analysis.cpp:46:5: warning: Class 'AI_Analysis' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] lordsawar-0.3.2/src/armyproto.h:155:7: warning: The class 'ArmyProto' defines member function with name 'saveData' also defined in its parent class 'ArmyProtoBase'. [duplInheritedMember] lordsawar-0.3.2/src/armyprotobase.h:111:7: note: Parent function 'ArmyProtoBase::saveData' lordsawar-0.3.2/src/armyproto.h:155:7: note: Derived function 'ArmyProto::saveData' lordsawar-0.3.2/src/armyproto.h:155:7: warning: The class 'ArmyProto' defines member function with name 'saveData' also defined in its parent class 'ArmyBase'. [duplInheritedMember] lordsawar-0.3.2/src/armybase.h:212:14: note: Parent function 'ArmyBase::saveData' lordsawar-0.3.2/src/armyproto.h:155:7: note: Derived function 'ArmyProto::saveData' lordsawar-0.3.2/src/hero.h:52:23: warning: The class 'Hero' defines member variable with name 'd_tag' also defined in its parent class 'Army'. [duplInheritedMember] lordsawar-0.3.2/src/army.h:72:23: note: Parent variable 'Army::d_tag' lordsawar-0.3.2/src/hero.h:52:23: note: Derived variable 'Hero::d_tag' lordsawar-0.3.2/src/shield.h:41:23: warning: The class 'Shield' defines member variable with name 'd_tag' also defined in its parent class 'Tartan'. [duplInheritedMember] lordsawar-0.3.2/src/tartan.h:46:23: note: Parent variable 'Tartan::d_tag' lordsawar-0.3.2/src/shield.h:41:23: note: Derived variable 'Shield::d_tag' lordsawar-0.3.2/src/armyprotobase.h:73:14: warning: The class 'ArmyProtoBase' defines member function with name 'setMaxMoves' also defined in its parent class 'ArmyBase'. [duplInheritedMember] lordsawar-0.3.2/src/armybase.h:123:14: note: Parent function 'ArmyBase::setMaxMoves' lordsawar-0.3.2/src/armyprotobase.h:73:14: note: Derived function 'ArmyProtoBase::setMaxMoves' lordsawar-0.3.2/src/armyprotobase.h:111:7: warning: The class 'ArmyProtoBase' defines member function with name 'saveData' also defined in its parent class 'ArmyBase'. [duplInheritedMember] lordsawar-0.3.2/src/armybase.h:212:14: note: Parent function 'ArmyBase::saveData' lordsawar-0.3.2/src/armyprotobase.h:111:7: note: Derived function 'ArmyProtoBase::saveData' lordsawar-0.3.2/src/armyset.h:98:7: warning: The class 'Armyset' defines member function with name 'save' also defined in its parent class 'Set'. [duplInheritedMember] lordsawar-0.3.2/src/set.h:87:10: note: Parent function 'Set::save' lordsawar-0.3.2/src/armyset.h:98:7: note: Derived function 'Armyset::save' lordsawar-0.3.2/src/AI_Analysis.h:55:9: style: Class 'AI_Analysis' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/stackreflist.h:36:5: style: Class 'StackReflist' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/stackreflist.h:39:5: style: Class 'StackReflist' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/stacklist.h:61:9: style: Class 'Stacklist' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/stacklist.h:64:9: style: Class 'Stacklist' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/Namable.h:38:6: style: Class 'Namable' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/Namable.h:44:6: style: Class 'Namable' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/ruinlist.h:177:9: style: Class 'Ruinlist' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/shieldstyle.h:66:9: style: Class 'ShieldStyle' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/shieldstyle.h:72:2: style: Class 'ShieldStyle' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/tartan.h:63:9: style: Class 'Tartan' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/shield.h:55:9: style: Class 'Shield' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/armyprotobase.h:42:9: style: Class 'ArmyProtoBase' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/hero.h:73:9: style: Class 'Hero' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/hero.h:85:9: style: Class 'Hero' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/armyproto.h:46:9: style: Class 'ArmyProto' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/setlist.h:36:5: style: Class 'SetList < Armyset >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/NamedLocation.h:49:14: style: The destructor '~NamedLocation' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Location.h:62:6: note: Virtual destructor in base class lordsawar-0.3.2/src/NamedLocation.h:49:14: note: Destructor in derived class lordsawar-0.3.2/src/ruin.h:91:10: style: The destructor '~Ruin' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/NamedLocation.h:49:14: note: Virtual destructor in base class lordsawar-0.3.2/src/ruin.h:91:10: note: Destructor in derived class lordsawar-0.3.2/src/shield.h:64:18: style: The destructor '~Shield' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/tartan.h:72:18: note: Virtual destructor in base class lordsawar-0.3.2/src/shield.h:64:18: note: Destructor in derived class lordsawar-0.3.2/src/armyprotobase.h:48:10: style: The destructor '~ArmyProtoBase' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/armybase.h:108:18: note: Virtual destructor in base class lordsawar-0.3.2/src/armyprotobase.h:48:10: note: Destructor in derived class lordsawar-0.3.2/src/hero.h:88:10: style: The destructor '~Hero' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/army.h:132:18: note: Virtual destructor in base class lordsawar-0.3.2/src/hero.h:88:10: note: Destructor in derived class lordsawar-0.3.2/src/hero.h:94:24: style: The function 'getName' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/army.h:242:24: note: Virtual function in base class lordsawar-0.3.2/src/hero.h:94:24: note: Function in derived class lordsawar-0.3.2/src/hero.h:97:7: style: The function 'isHero' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/army.h:233:15: note: Virtual function in base class lordsawar-0.3.2/src/hero.h:97:7: note: Function in derived class lordsawar-0.3.2/src/hero.h:103:14: style: The function 'isFlyer' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/army.h:245:22: note: Virtual function in base class lordsawar-0.3.2/src/hero.h:103:14: note: Function in derived class lordsawar-0.3.2/src/hero.h:112:17: style: The function 'getStat' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/army.h:197:25: note: Virtual function in base class lordsawar-0.3.2/src/hero.h:112:17: note: Function in derived class lordsawar-0.3.2/src/hero.h:129:14: style: The function 'save' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/army.h:319:22: note: Virtual function in base class lordsawar-0.3.2/src/hero.h:129:14: note: Function in derived class lordsawar-0.3.2/src/armyproto.h:52:10: style: The destructor '~ArmyProto' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/armyprotobase.h:48:10: note: Virtual destructor in base class lordsawar-0.3.2/src/armyproto.h:52:10: note: Destructor in derived class lordsawar-0.3.2/src/file-compat.h:33:6: performance: Variable 'type' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/file-compat.h:33:16: performance: Variable 'file_extension' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/file-compat.h:33:36: performance: Variable 'tag' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/file-compat.h:127:6: performance: Variable 'from_version' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/file-compat.h:127:24: performance: Variable 'to_version' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/file-compat.h:127:40: performance: Variable 'slot' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/Configuration.cpp:308:7: style: Condition 'try_upgrade' is always true [knownConditionTrueFalse] lordsawar-0.3.2/src/Configuration.cpp:307:22: note: Assignment 'try_upgrade=true', assigned value is 1 lordsawar-0.3.2/src/Configuration.cpp:308:7: note: Condition 'try_upgrade' is always true lordsawar-0.3.2/src/Configuration.cpp:578:84: style:inconclusive: Function 'sackingModeToString' argument 1 names different: declaration 'mode' definition 'sack'. [funcArgNamesDifferent] lordsawar-0.3.2/src/Configuration.h:153:84: note: Function 'sackingModeToString' argument 1 names different: declaration 'mode' definition 'sack'. lordsawar-0.3.2/src/Configuration.cpp:578:84: note: Function 'sackingModeToString' argument 1 names different: declaration 'mode' definition 'sack'. lordsawar-0.3.2/src/AI_Analysis.cpp:149:15: style: The scope of the variable 'tmp' can be reduced. [variableScope] lordsawar-0.3.2/src/AI_Analysis.cpp:80:38: style: Parameter 's' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/AI_Analysis.cpp:118:20: style: Variable 'strongest' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/AI_Analysis.cpp:174:51: style: Parameter 'city' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/AI_Analysis.cpp:183:40: style: Parameter 'city' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/AI_Analysis.cpp:194:35: style: Parameter 'city' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/AI_Analysis.cpp:194:48: style: Parameter 'stack' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/AI_Analysis.cpp:203:47: style: Parameter 'city' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/AI_Analysis.cpp:149:18: style: Variable 'tmp' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/AI_Analysis.cpp:105:77: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/AI_Analysis.cpp:151:57: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/setlist.h:40:14: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/setlist.h:67:33: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/setlist.h:80:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/setlist.h:91:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/setlist.h:319:33: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/setlist.h:329:33: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/setlist.h:360:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/setlist.h:388:36: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/setlist.h:402:34: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/setlist.h:416:38: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Commentator.h:44:14: performance:inconclusive: Technically the member function 'Commentator::hasComment' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/Commentator.cpp:51:19: note: Technically the member function 'Commentator::hasComment' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/Commentator.h:44:14: note: Technically the member function 'Commentator::hasComment' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/Commentator.h:46:36: performance:inconclusive: Technically the member function 'Commentator::getComments' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/Commentator.cpp:59:41: note: Technically the member function 'Commentator::getComments' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/Commentator.h:46:36: note: Technically the member function 'Commentator::getComments' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/GameMap.h:1433:9: style: Class 'GameMap' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/GameMap.h:1437:9: style: Class 'GameMap' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/Commentator.cpp:62:11: style: Local variable 'round' shadows outer function [shadowFunction] lordsawar-0.3.2/src/vector.h:226:18: note: Shadowed declaration lordsawar-0.3.2/src/Commentator.cpp:62:11: note: Shadow variable lordsawar-0.3.2/src/Commentator.cpp:114:14: style: Variable 'stack' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/Commentator.cpp:125:9: style: Variable 'capital_city' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.h:1028:22: style: Variable 't' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.h:1050:22: style: Variable 't' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/Commentator.cpp:112:103: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.h:152:7: warning: The class 'Shieldset' defines member function with name 'save' also defined in its parent class 'Set'. [duplInheritedMember] lordsawar-0.3.2/src/set.h:87:10: note: Parent function 'Set::save' lordsawar-0.3.2/src/shieldset.h:152:7: note: Derived function 'Shieldset::save' lordsawar-0.3.2/src/tileset.h:318:7: warning: The class 'Tileset' defines member function with name 'save' also defined in its parent class 'Set'. [duplInheritedMember] lordsawar-0.3.2/src/set.h:87:10: note: Parent function 'Set::save' lordsawar-0.3.2/src/tileset.h:318:7: note: Derived function 'Tileset::save' lordsawar-0.3.2/src/cityset.h:82:7: warning: The class 'Cityset' defines member function with name 'save' also defined in its parent class 'Set'. [duplInheritedMember] lordsawar-0.3.2/src/set.h:87:10: note: Parent function 'Set::save' lordsawar-0.3.2/src/cityset.h:82:7: note: Derived function 'Cityset::save' lordsawar-0.3.2/src/File.cpp:460:7: error: Common realloc mistake: 'result' nulled but not freed upon failure [memleakOnRealloc] lordsawar-0.3.2/src/File.cpp:451:12: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/File.cpp:460:16: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/File.cpp:351:38: style:inconclusive: Function 'is_writable' argument 1 names different: declaration 'path' definition 'file'. [funcArgNamesDifferent] lordsawar-0.3.2/src/File.h:113:40: note: Function 'is_writable' argument 1 names different: declaration 'path' definition 'file'. lordsawar-0.3.2/src/File.cpp:351:38: note: Function 'is_writable' argument 1 names different: declaration 'path' definition 'file'. lordsawar-0.3.2/src/File.cpp:429:36: style:inconclusive: Function 'clean_dir' argument 1 names different: declaration 'filename' definition 'dirname'. [funcArgNamesDifferent] lordsawar-0.3.2/src/File.h:131:45: note: Function 'clean_dir' argument 1 names different: declaration 'filename' definition 'dirname'. lordsawar-0.3.2/src/File.cpp:429:36: note: Function 'clean_dir' argument 1 names different: declaration 'filename' definition 'dirname'. lordsawar-0.3.2/src/File.cpp:344:33: style: Variable 'ex' can be declared as reference to const [constVariableReference] lordsawar-0.3.2/src/File.cpp:524:26: style: Variable 'ex' can be declared as reference to const [constVariableReference] lordsawar-0.3.2/src/CreateScenarioRandomize.h:54:10: performance:inconclusive: Technically the member function 'CreateScenarioRandomize::getRandomCityIncome' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/CreateScenarioRandomize.cpp:107:34: note: Technically the member function 'CreateScenarioRandomize::getRandomCityIncome' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/CreateScenarioRandomize.h:54:10: note: Technically the member function 'CreateScenarioRandomize::getRandomCityIncome' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/CreateScenarioRandomize.h:58:11: performance:inconclusive: Technically the member function 'CreateScenarioRandomize::getRandomRuinKeeper' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/CreateScenarioRandomize.cpp:115:34: note: Technically the member function 'CreateScenarioRandomize::getRandomRuinKeeper' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/CreateScenarioRandomize.h:58:11: note: Technically the member function 'CreateScenarioRandomize::getRandomRuinKeeper' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/CreateScenarioRandomize.h:59:10: performance:inconclusive: Technically the member function 'CreateScenarioRandomize::getNewRandomReward' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/CreateScenarioRandomize.cpp:159:34: note: Technically the member function 'CreateScenarioRandomize::getNewRandomReward' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/CreateScenarioRandomize.h:59:10: note: Technically the member function 'CreateScenarioRandomize::getNewRandomReward' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/CreateScenarioRandomize.h:64:7: performance:inconclusive: Technically the member function 'CreateScenarioRandomize::getBaseGold' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/CreateScenarioRandomize.cpp:172:31: note: Technically the member function 'CreateScenarioRandomize::getBaseGold' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/CreateScenarioRandomize.h:64:7: note: Technically the member function 'CreateScenarioRandomize::getBaseGold' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/CreateScenarioRandomize.h:66:6: performance:inconclusive: Technically the member function 'CreateScenarioRandomize::adjustBaseGold' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/CreateScenarioRandomize.cpp:164:30: note: Technically the member function 'CreateScenarioRandomize::adjustBaseGold' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/CreateScenarioRandomize.h:66:6: note: Technically the member function 'CreateScenarioRandomize::adjustBaseGold' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/CreateScenarioRandomize.h:82:23: performance:inconclusive: Technically the member function 'CreateScenarioRandomize::get_direction' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/CreateScenarioRandomize.cpp:123:40: note: Technically the member function 'CreateScenarioRandomize::get_direction' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/CreateScenarioRandomize.h:82:23: note: Technically the member function 'CreateScenarioRandomize::get_direction' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/temple.h:75:14: performance:inconclusive: Technically the member function 'Temple::searchable' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/CreateScenarioRandomize.cpp:46:5: warning: Class 'CreateScenarioRandomize' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] lordsawar-0.3.2/src/CreateScenarioRandomize.cpp:46:5: warning: Class 'CreateScenarioRandomize' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] lordsawar-0.3.2/src/signpost.h:45:9: style: Class 'Signpost' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/signpost.h:57:9: style: Class 'Signpost' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/SightMap.h:42:9: style: Class 'SightMap' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/reward.h:204:9: style: Class 'Reward_Gold' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/reward.h:207:2: style: Class 'Reward_Gold' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/reward.h:275:2: style: Class 'Reward_Allies' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/reward.h:371:9: style: Class 'Reward_Item' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/reward.h:380:2: style: Class 'Reward_Item' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/reward.h:447:9: style: Class 'Reward_Ruin' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/reward.h:456:2: style: Class 'Reward_Ruin' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/reward.h:540:2: style: Class 'Reward_Map' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/keeper.h:48:5: style: Class 'Keeper' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/temple.h:64:10: style: The destructor '~Temple' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/NamedLocation.h:49:14: note: Virtual destructor in base class lordsawar-0.3.2/src/temple.h:64:10: note: Destructor in derived class lordsawar-0.3.2/src/signpost.h:60:10: style: The destructor '~Signpost' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Location.h:62:6: note: Virtual destructor in base class lordsawar-0.3.2/src/signpost.h:60:10: note: Destructor in derived class lordsawar-0.3.2/src/reward.h:213:10: style: The destructor '~Reward_Gold' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/reward.h:110:18: note: Virtual destructor in base class lordsawar-0.3.2/src/reward.h:213:10: note: Destructor in derived class lordsawar-0.3.2/src/reward.h:224:14: style: The function 'save' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/reward.h:146:22: note: Virtual function in base class lordsawar-0.3.2/src/reward.h:224:14: note: Function in derived class lordsawar-0.3.2/src/reward.h:278:10: style: The destructor '~Reward_Allies' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/reward.h:110:18: note: Virtual destructor in base class lordsawar-0.3.2/src/reward.h:278:10: note: Destructor in derived class lordsawar-0.3.2/src/reward.h:292:14: style: The function 'save' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/reward.h:146:22: note: Virtual function in base class lordsawar-0.3.2/src/reward.h:292:14: note: Function in derived class lordsawar-0.3.2/src/reward.h:391:18: style: The destructor '~Reward_Item' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/reward.h:110:18: note: Virtual destructor in base class lordsawar-0.3.2/src/reward.h:391:18: note: Destructor in derived class lordsawar-0.3.2/src/reward.h:406:14: style: The function 'save' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/reward.h:146:22: note: Virtual function in base class lordsawar-0.3.2/src/reward.h:406:14: note: Function in derived class lordsawar-0.3.2/src/reward.h:467:10: style: The destructor '~Reward_Ruin' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/reward.h:110:18: note: Virtual destructor in base class lordsawar-0.3.2/src/reward.h:467:10: note: Destructor in derived class lordsawar-0.3.2/src/reward.h:482:14: style: The function 'save' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/reward.h:146:22: note: Virtual function in base class lordsawar-0.3.2/src/reward.h:482:14: note: Function in derived class lordsawar-0.3.2/src/reward.h:551:10: style: The destructor '~Reward_Map' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/reward.h:110:18: note: Virtual destructor in base class lordsawar-0.3.2/src/reward.h:551:10: note: Destructor in derived class lordsawar-0.3.2/src/reward.h:582:14: style: The function 'save' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/reward.h:146:22: note: Virtual function in base class lordsawar-0.3.2/src/reward.h:582:14: note: Function in derived class lordsawar-0.3.2/src/CreateScenarioRandomize.cpp:51:9: style: Condition '!success' is always false [knownConditionTrueFalse] lordsawar-0.3.2/src/CreateScenarioRandomize.cpp:44:20: note: Assignment 'success=true', assigned value is 1 lordsawar-0.3.2/src/CreateScenarioRandomize.cpp:51:9: note: Condition '!success' is always false lordsawar-0.3.2/src/CreateScenarioRandomize.cpp:144:69: style: Parameter 'signpost' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/CreateScenarioRandomize.cpp:148:9: style: Variable 'nearCity' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/FogMap.cpp:74:9: warning:inconclusive: Member variable 'FogMap::completely_obscured' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] lordsawar-0.3.2/src/FogMap.h:143:14: style:inconclusive: Technically the member function 'FogMap::isLoneFogTile' can be const. [functionConst] lordsawar-0.3.2/src/FogMap.cpp:195:14: note: Technically the member function 'FogMap::isLoneFogTile' can be const. lordsawar-0.3.2/src/FogMap.h:143:14: note: Technically the member function 'FogMap::isLoneFogTile' can be const. lordsawar-0.3.2/src/FogMap.cpp:59:5: warning: Class 'FogMap' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] lordsawar-0.3.2/src/FogMap.h:82:9: style: Class 'FogMap' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/FogMap.cpp:249:48: style: Parameter 'player' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/FogMap.cpp:252:11: style: Variable 'fogmap' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/FogMap.cpp:259:33: style: Parameter 'sightmap' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/AI_Allocation.cpp:1531:25: style: Comparison of a function returning boolean value using relational (<, >, <= or >=) operator. [comparisonOfFuncReturningBoolError] lordsawar-0.3.2/src/AI_Allocation.cpp:56:16: warning: Member variable 'AI_Allocation::d_stacks' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/AI_Allocation.cpp:56:16: warning: Member variable 'AI_Allocation::abort_turn' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/AI_Allocation.h:123:21: performance:inconclusive: Technically the member function 'AI_Allocation::getFreeSpotInCity' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/AI_Allocation.cpp:1041:28: note: Technically the member function 'AI_Allocation::getFreeSpotInCity' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/AI_Allocation.h:123:21: note: Technically the member function 'AI_Allocation::getFreeSpotInCity' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/AI_Allocation.h:126:21: performance:inconclusive: Technically the member function 'AI_Allocation::getFreeOtherSpotInCity' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/AI_Allocation.cpp:1008:28: note: Technically the member function 'AI_Allocation::getFreeOtherSpotInCity' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/AI_Allocation.h:126:21: note: Technically the member function 'AI_Allocation::getFreeOtherSpotInCity' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/MoveResult.h:74:14: style:inconclusive: Technically the member function 'MoveResult::getComputerSearchedTemple' can be const. [functionConst] lordsawar-0.3.2/src/MoveResult.h:77:14: style:inconclusive: Technically the member function 'MoveResult::getComputerSearchedRuin' can be const. [functionConst] lordsawar-0.3.2/src/MoveResult.h:83:14: style:inconclusive: Technically the member function 'MoveResult::getComputerPickedUpBag' can be const. [functionConst] lordsawar-0.3.2/src/path.h:54:9: style: Class 'Path' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/stacktile.h:59:5: style: Class 'StackTile' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/QuestsManager.h:259:9: style: Class 'QuestsManager' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/OwnerId.h:37:6: style: Class 'OwnerId' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/OwnerId.h:43:6: style: Class 'OwnerId' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/Quest.h:98:18: style: The destructor '~Quest' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/OwnerId.h:46:14: note: Virtual destructor in base class lordsawar-0.3.2/src/Quest.h:98:18: note: Destructor in derived class lordsawar-0.3.2/src/QKillHero.h:53:6: style: The destructor '~QuestKillHero' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:98:18: note: Virtual destructor in base class lordsawar-0.3.2/src/QKillHero.h:53:6: note: Destructor in derived class lordsawar-0.3.2/src/QKillHero.h:69:19: style: The function 'getProgress' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:164:31: note: Virtual function in base class lordsawar-0.3.2/src/QKillHero.h:69:19: note: Function in derived class lordsawar-0.3.2/src/QKillHero.h:72:10: style: The function 'getSuccessMsg' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:171:22: note: Virtual function in base class lordsawar-0.3.2/src/QKillHero.h:72:10: note: Function in derived class lordsawar-0.3.2/src/QKillHero.h:75:10: style: The function 'getExpiredMsg' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:182:22: note: Virtual function in base class lordsawar-0.3.2/src/QKillHero.h:75:10: note: Function in derived class lordsawar-0.3.2/src/QKillHero.h:84:10: style: The function 'save' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:158:22: note: Virtual function in base class lordsawar-0.3.2/src/QKillHero.h:84:10: note: Function in derived class lordsawar-0.3.2/src/QKillHero.h:100:10: style: The function 'armyDied' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:194:15: note: Virtual function in base class lordsawar-0.3.2/src/QKillHero.h:100:10: note: Function in derived class lordsawar-0.3.2/src/QKillHero.h:106:10: style: The function 'cityAction' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:212:15: note: Virtual function in base class lordsawar-0.3.2/src/QKillHero.h:106:10: note: Function in derived class lordsawar-0.3.2/src/QEnemyArmies.h:56:6: style: The destructor '~QuestEnemyArmies' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:98:18: note: Virtual destructor in base class lordsawar-0.3.2/src/QEnemyArmies.h:56:6: note: Destructor in derived class lordsawar-0.3.2/src/QEnemyArmies.h:69:19: style: The function 'getProgress' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:164:31: note: Virtual function in base class lordsawar-0.3.2/src/QEnemyArmies.h:69:19: note: Function in derived class lordsawar-0.3.2/src/QEnemyArmies.h:72:10: style: The function 'getSuccessMsg' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:171:22: note: Virtual function in base class lordsawar-0.3.2/src/QEnemyArmies.h:72:10: note: Function in derived class lordsawar-0.3.2/src/QEnemyArmies.h:75:10: style: The function 'getExpiredMsg' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:182:22: note: Virtual function in base class lordsawar-0.3.2/src/QEnemyArmies.h:75:10: note: Function in derived class lordsawar-0.3.2/src/QEnemyArmies.h:86:10: style: The function 'save' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:158:22: note: Virtual function in base class lordsawar-0.3.2/src/QEnemyArmies.h:86:10: note: Function in derived class lordsawar-0.3.2/src/QEnemyArmies.h:102:10: style: The function 'armyDied' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:194:15: note: Virtual function in base class lordsawar-0.3.2/src/QEnemyArmies.h:102:10: note: Function in derived class lordsawar-0.3.2/src/QEnemyArmies.h:108:10: style: The function 'cityAction' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:212:15: note: Virtual function in base class lordsawar-0.3.2/src/QEnemyArmies.h:108:10: note: Function in derived class lordsawar-0.3.2/src/QEnemyArmytype.h:51:6: style: The destructor '~QuestEnemyArmytype' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:98:18: note: Virtual destructor in base class lordsawar-0.3.2/src/QEnemyArmytype.h:51:6: note: Destructor in derived class lordsawar-0.3.2/src/QEnemyArmytype.h:66:19: style: The function 'getProgress' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:164:31: note: Virtual function in base class lordsawar-0.3.2/src/QEnemyArmytype.h:66:19: note: Function in derived class lordsawar-0.3.2/src/QEnemyArmytype.h:69:10: style: The function 'getSuccessMsg' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:171:22: note: Virtual function in base class lordsawar-0.3.2/src/QEnemyArmytype.h:69:10: note: Function in derived class lordsawar-0.3.2/src/QEnemyArmytype.h:72:10: style: The function 'getExpiredMsg' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:182:22: note: Virtual function in base class lordsawar-0.3.2/src/QEnemyArmytype.h:72:10: note: Function in derived class lordsawar-0.3.2/src/QEnemyArmytype.h:85:10: style: The function 'save' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:158:22: note: Virtual function in base class lordsawar-0.3.2/src/QEnemyArmytype.h:85:10: note: Function in derived class lordsawar-0.3.2/src/QEnemyArmytype.h:101:10: style: The function 'armyDied' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:194:15: note: Virtual function in base class lordsawar-0.3.2/src/QEnemyArmytype.h:101:10: note: Function in derived class lordsawar-0.3.2/src/QEnemyArmytype.h:107:10: style: The function 'cityAction' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:212:15: note: Virtual function in base class lordsawar-0.3.2/src/QEnemyArmytype.h:107:10: note: Function in derived class lordsawar-0.3.2/src/AI_Allocation.cpp:886:29: warning: Identical condition 'totalDefenderStrength' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/setlist.h:36:5: style: Class 'SetList < Cityset >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/setlist.h:36:5: style: Class 'SetList < Shieldset >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/GameScenario.h:79:10: style: The destructor '~GameScenario' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/GameScenarioOptions.h:33:18: note: Virtual destructor in base class lordsawar-0.3.2/src/GameScenario.h:79:10: note: Destructor in derived class lordsawar-0.3.2/src/port.h:55:10: style: The destructor '~Port' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Location.h:62:6: note: Virtual destructor in base class lordsawar-0.3.2/src/port.h:55:10: note: Destructor in derived class lordsawar-0.3.2/src/road.h:77:10: style: The destructor '~Road' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Location.h:62:6: note: Virtual destructor in base class lordsawar-0.3.2/src/road.h:77:10: note: Destructor in derived class lordsawar-0.3.2/src/stone.h:151:10: style: The destructor '~Stone' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Location.h:62:6: note: Virtual destructor in base class lordsawar-0.3.2/src/stone.h:151:10: note: Destructor in derived class lordsawar-0.3.2/src/real_player.h:65:18: style: The destructor '~RealPlayer' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:188:18: note: Virtual destructor in base class lordsawar-0.3.2/src/real_player.h:65:18: note: Destructor in derived class lordsawar-0.3.2/src/real_player.h:67:15: style: The function 'isComputer' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:242:15: note: Virtual function in base class lordsawar-0.3.2/src/real_player.h:67:15: note: Function in derived class lordsawar-0.3.2/src/real_player.h:69:22: style: The function 'save' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:460:22: note: Virtual function in base class lordsawar-0.3.2/src/real_player.h:69:22: note: Function in derived class lordsawar-0.3.2/src/real_player.h:71:15: style: The function 'abortTurn' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1057:22: note: Virtual function in base class lordsawar-0.3.2/src/real_player.h:71:15: note: Function in derived class lordsawar-0.3.2/src/real_player.h:73:22: style: The function 'startTurn' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1055:22: note: Virtual function in base class lordsawar-0.3.2/src/real_player.h:73:22: note: Function in derived class lordsawar-0.3.2/src/real_player.h:75:22: style: The function 'endTurn' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1067:22: note: Virtual function in base class lordsawar-0.3.2/src/real_player.h:75:22: note: Function in derived class lordsawar-0.3.2/src/real_player.h:77:22: style: The function 'invadeCity' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1016:22: note: Virtual function in base class lordsawar-0.3.2/src/real_player.h:77:22: note: Function in derived class lordsawar-0.3.2/src/real_player.h:79:22: style: The function 'chooseHero' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1019:22: note: Virtual function in base class lordsawar-0.3.2/src/real_player.h:79:22: note: Function in derived class lordsawar-0.3.2/src/real_player.h:81:25: style: The function 'chooseReward' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1022:25: note: Virtual function in base class lordsawar-0.3.2/src/real_player.h:81:25: note: Function in derived class lordsawar-0.3.2/src/real_player.h:83:22: style: The function 'heroGainsLevel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:779:22: note: Virtual function in base class lordsawar-0.3.2/src/real_player.h:83:22: note: Function in derived class lordsawar-0.3.2/src/real_player.h:85:15: style: The function 'chooseTreachery' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1025:15: note: Virtual function in base class lordsawar-0.3.2/src/real_player.h:85:15: note: Function in derived class lordsawar-0.3.2/src/real_player.h:86:28: style: The function 'chooseStat' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1028:28: note: Virtual function in base class lordsawar-0.3.2/src/real_player.h:86:28: note: Function in derived class lordsawar-0.3.2/src/real_player.h:88:22: style: The function 'chooseQuest' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1031:22: note: Virtual function in base class lordsawar-0.3.2/src/real_player.h:88:22: note: Function in derived class lordsawar-0.3.2/src/real_player.h:89:22: style: The function 'computerChooseVisitRuin' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1034:22: note: Virtual function in base class lordsawar-0.3.2/src/real_player.h:89:22: note: Function in derived class lordsawar-0.3.2/src/real_player.h:90:22: style: The function 'computerChoosePickupBag' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1036:22: note: Virtual function in base class lordsawar-0.3.2/src/real_player.h:90:22: note: Function in derived class lordsawar-0.3.2/src/real_player.h:91:22: style: The function 'computerChooseVisitTempleForBlessing' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1038:22: note: Virtual function in base class lordsawar-0.3.2/src/real_player.h:91:22: note: Function in derived class lordsawar-0.3.2/src/real_player.h:92:22: style: The function 'computerChooseVisitTempleForQuest' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1040:22: note: Virtual function in base class lordsawar-0.3.2/src/real_player.h:92:22: note: Function in derived class lordsawar-0.3.2/src/real_player.h:93:22: style: The function 'computerChooseContinueQuest' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1042:22: note: Virtual function in base class lordsawar-0.3.2/src/real_player.h:93:22: note: Function in derived class lordsawar-0.3.2/src/ai_dummy.h:63:10: style: The destructor '~AI_Dummy' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:65:18: note: Virtual destructor in base class lordsawar-0.3.2/src/ai_dummy.h:63:10: note: Destructor in derived class lordsawar-0.3.2/src/ai_dummy.h:65:15: style: The function 'isComputer' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:67:15: note: Virtual function in base class lordsawar-0.3.2/src/ai_dummy.h:65:15: note: Function in derived class lordsawar-0.3.2/src/ai_dummy.h:66:22: style: The function 'abortTurn' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:71:15: note: Virtual function in base class lordsawar-0.3.2/src/ai_dummy.h:66:22: note: Function in derived class lordsawar-0.3.2/src/ai_dummy.h:67:22: style: The function 'startTurn' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:73:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_dummy.h:67:22: note: Function in derived class lordsawar-0.3.2/src/ai_dummy.h:68:22: style: The function 'invadeCity' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:77:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_dummy.h:68:22: note: Function in derived class lordsawar-0.3.2/src/ai_dummy.h:69:22: style: The function 'chooseHero' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:79:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_dummy.h:69:22: note: Function in derived class lordsawar-0.3.2/src/ai_dummy.h:70:25: style: The function 'chooseReward' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:81:25: note: Virtual function in base class lordsawar-0.3.2/src/ai_dummy.h:70:25: note: Function in derived class lordsawar-0.3.2/src/ai_dummy.h:71:22: style: The function 'heroGainsLevel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:83:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_dummy.h:71:22: note: Function in derived class lordsawar-0.3.2/src/ai_dummy.h:72:15: style: The function 'chooseTreachery' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:85:15: note: Virtual function in base class lordsawar-0.3.2/src/ai_dummy.h:72:15: note: Function in derived class lordsawar-0.3.2/src/ai_dummy.h:73:28: style: The function 'chooseStat' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:86:28: note: Virtual function in base class lordsawar-0.3.2/src/ai_dummy.h:73:28: note: Function in derived class lordsawar-0.3.2/src/ai_dummy.h:74:22: style: The function 'chooseQuest' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:88:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_dummy.h:74:22: note: Function in derived class lordsawar-0.3.2/src/ai_dummy.h:75:22: style: The function 'computerChooseVisitRuin' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:89:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_dummy.h:75:22: note: Function in derived class lordsawar-0.3.2/src/ai_dummy.h:76:22: style: The function 'computerChoosePickupBag' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:90:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_dummy.h:76:22: note: Function in derived class lordsawar-0.3.2/src/ai_dummy.h:77:22: style: The function 'computerChooseVisitTempleForBlessing' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:91:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_dummy.h:77:22: note: Function in derived class lordsawar-0.3.2/src/ai_dummy.h:78:22: style: The function 'computerChooseVisitTempleForQuest' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:92:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_dummy.h:78:22: note: Function in derived class lordsawar-0.3.2/src/ai_dummy.h:79:22: style: The function 'computerChooseContinueQuest' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:93:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_dummy.h:79:22: note: Function in derived class lordsawar-0.3.2/src/ai_fast.h:70:10: style: The destructor '~AI_Fast' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:65:18: note: Virtual destructor in base class lordsawar-0.3.2/src/ai_fast.h:70:10: note: Destructor in derived class lordsawar-0.3.2/src/ai_fast.h:72:15: style: The function 'isComputer' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:67:15: note: Virtual function in base class lordsawar-0.3.2/src/ai_fast.h:72:15: note: Function in derived class lordsawar-0.3.2/src/ai_fast.h:75:14: style: The function 'save' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:69:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_fast.h:75:14: note: Function in derived class lordsawar-0.3.2/src/ai_fast.h:89:15: style: The function 'abortTurn' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:71:15: note: Virtual function in base class lordsawar-0.3.2/src/ai_fast.h:89:15: note: Function in derived class lordsawar-0.3.2/src/ai_fast.h:90:22: style: The function 'startTurn' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:73:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_fast.h:90:22: note: Function in derived class lordsawar-0.3.2/src/ai_fast.h:91:22: style: The function 'invadeCity' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:77:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_fast.h:91:22: note: Function in derived class lordsawar-0.3.2/src/ai_fast.h:92:22: style: The function 'chooseHero' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:79:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_fast.h:92:22: note: Function in derived class lordsawar-0.3.2/src/ai_fast.h:93:25: style: The function 'chooseReward' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:81:25: note: Virtual function in base class lordsawar-0.3.2/src/ai_fast.h:93:25: note: Function in derived class lordsawar-0.3.2/src/ai_fast.h:94:22: style: The function 'heroGainsLevel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:83:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_fast.h:94:22: note: Function in derived class lordsawar-0.3.2/src/ai_fast.h:95:15: style: The function 'chooseTreachery' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:85:15: note: Virtual function in base class lordsawar-0.3.2/src/ai_fast.h:95:15: note: Function in derived class lordsawar-0.3.2/src/ai_fast.h:96:28: style: The function 'chooseStat' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:86:28: note: Virtual function in base class lordsawar-0.3.2/src/ai_fast.h:96:28: note: Function in derived class lordsawar-0.3.2/src/ai_fast.h:97:22: style: The function 'chooseQuest' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:88:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_fast.h:97:22: note: Function in derived class lordsawar-0.3.2/src/ai_fast.h:98:22: style: The function 'computerChooseVisitRuin' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:89:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_fast.h:98:22: note: Function in derived class lordsawar-0.3.2/src/ai_fast.h:99:22: style: The function 'computerChoosePickupBag' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:90:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_fast.h:99:22: note: Function in derived class lordsawar-0.3.2/src/ai_fast.h:100:22: style: The function 'computerChooseVisitTempleForBlessing' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:91:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_fast.h:100:22: note: Function in derived class lordsawar-0.3.2/src/ai_fast.h:101:22: style: The function 'computerChooseVisitTempleForQuest' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:92:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_fast.h:101:22: note: Function in derived class lordsawar-0.3.2/src/ai_fast.h:102:22: style: The function 'computerChooseContinueQuest' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:93:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_fast.h:102:22: note: Function in derived class lordsawar-0.3.2/src/action.h:211:10: style: The destructor '~Action_Move' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:211:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:214:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:214:23: note: Function in derived class lordsawar-0.3.2/src/action.h:217:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:217:22: note: Function in derived class lordsawar-0.3.2/src/action.h:265:10: style: The destructor '~Action_Split' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:265:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:268:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:268:23: note: Function in derived class lordsawar-0.3.2/src/action.h:271:14: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:271:14: note: Function in derived class lordsawar-0.3.2/src/action.h:300:10: style: The destructor '~Action_Disband' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:300:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:303:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:303:23: note: Function in derived class lordsawar-0.3.2/src/action.h:306:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:306:22: note: Function in derived class lordsawar-0.3.2/src/action.h:336:10: style: The destructor '~Action_Fight' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:336:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:339:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:339:23: note: Function in derived class lordsawar-0.3.2/src/action.h:342:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:342:22: note: Function in derived class lordsawar-0.3.2/src/action.h:386:10: style: The destructor '~Action_Join' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:386:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:389:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:389:23: note: Function in derived class lordsawar-0.3.2/src/action.h:392:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:392:22: note: Function in derived class lordsawar-0.3.2/src/action.h:421:10: style: The destructor '~Action_Ruin' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:421:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:424:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:424:23: note: Function in derived class lordsawar-0.3.2/src/action.h:427:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:427:22: note: Function in derived class lordsawar-0.3.2/src/action.h:461:10: style: The destructor '~Action_Temple' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:461:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:464:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:464:23: note: Function in derived class lordsawar-0.3.2/src/action.h:467:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:467:22: note: Function in derived class lordsawar-0.3.2/src/action.h:497:10: style: The destructor '~Action_Occupy' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:497:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:500:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:500:23: note: Function in derived class lordsawar-0.3.2/src/action.h:503:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:503:22: note: Function in derived class lordsawar-0.3.2/src/action.h:530:10: style: The destructor '~Action_Pillage' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:530:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:533:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:533:23: note: Function in derived class lordsawar-0.3.2/src/action.h:536:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:536:22: note: Function in derived class lordsawar-0.3.2/src/action.h:563:10: style: The destructor '~Action_Sack' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:563:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:566:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:566:23: note: Function in derived class lordsawar-0.3.2/src/action.h:569:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:569:22: note: Function in derived class lordsawar-0.3.2/src/action.h:595:10: style: The destructor '~Action_Raze' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:595:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:598:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:598:23: note: Function in derived class lordsawar-0.3.2/src/action.h:601:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:601:22: note: Function in derived class lordsawar-0.3.2/src/action.h:630:10: style: The destructor '~Action_Upgrade' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:630:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:633:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:633:23: note: Function in derived class lordsawar-0.3.2/src/action.h:636:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:636:22: note: Function in derived class lordsawar-0.3.2/src/action.h:673:10: style: The destructor '~Action_Buy' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:673:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:676:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:676:23: note: Function in derived class lordsawar-0.3.2/src/action.h:679:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:679:22: note: Function in derived class lordsawar-0.3.2/src/action.h:714:10: style: The destructor '~Action_Production' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:714:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:717:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:717:23: note: Function in derived class lordsawar-0.3.2/src/action.h:720:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:720:22: note: Function in derived class lordsawar-0.3.2/src/action.h:752:10: style: The destructor '~Action_Reward' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:752:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:755:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:755:23: note: Function in derived class lordsawar-0.3.2/src/action.h:758:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:758:22: note: Function in derived class lordsawar-0.3.2/src/action.h:787:10: style: The destructor '~Action_Quest' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:787:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:790:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:790:23: note: Function in derived class lordsawar-0.3.2/src/action.h:793:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:793:22: note: Function in derived class lordsawar-0.3.2/src/action.h:838:10: style: The destructor '~Action_Equip' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:838:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:841:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:841:23: note: Function in derived class lordsawar-0.3.2/src/action.h:844:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:844:22: note: Function in derived class lordsawar-0.3.2/src/action.h:882:10: style: The destructor '~Action_Level' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:882:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:885:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:885:23: note: Function in derived class lordsawar-0.3.2/src/action.h:888:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:888:22: note: Function in derived class lordsawar-0.3.2/src/action.h:920:10: style: The destructor '~Action_ModifySignpost' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:920:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:923:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:923:23: note: Function in derived class lordsawar-0.3.2/src/action.h:926:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:926:22: note: Function in derived class lordsawar-0.3.2/src/action.h:957:10: style: The destructor '~Action_RenameCity' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:957:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:960:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:960:23: note: Function in derived class lordsawar-0.3.2/src/action.h:963:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:963:22: note: Function in derived class lordsawar-0.3.2/src/action.h:996:10: style: The destructor '~Action_Vector' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:996:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:999:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:999:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1002:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1002:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1032:10: style: The destructor '~Action_FightOrder' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1032:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1035:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1035:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1038:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1038:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1064:10: style: The destructor '~Action_Resign' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1064:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1067:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1067:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1070:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1070:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1094:10: style: The destructor '~Action_Plant' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1094:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1097:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1097:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1100:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1100:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1144:10: style: The destructor '~Action_Produce' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1144:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1147:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1147:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1150:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1150:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1210:10: style: The destructor '~Action_ProduceVectored' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1210:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1213:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1213:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1216:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1216:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1266:10: style: The destructor '~Action_DiplomacyState' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1266:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1269:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1269:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1272:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1272:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1309:10: style: The destructor '~Action_DiplomacyProposal' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1309:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1312:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1312:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1315:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1315:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1354:10: style: The destructor '~Action_DiplomacyScore' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1354:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1357:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1357:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1360:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1360:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1385:10: style: The destructor '~Action_EndTurn' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1385:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1388:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1388:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1391:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1391:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1409:10: style: The destructor '~Action_ConquerCity' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1409:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1412:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1412:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1415:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1415:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1435:10: style: The destructor '~Action_RecruitHero' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1435:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1438:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1438:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1441:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1441:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1469:10: style: The destructor '~Action_RenamePlayer' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1469:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1472:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1472:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1475:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1475:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1496:10: style: The destructor '~Action_CityTooPoorToProduce' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1496:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1499:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1499:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1502:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1502:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1525:10: style: The destructor '~Action_InitTurn' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1525:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1528:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1528:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1531:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1531:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1562:10: style: The destructor '~Action_Loot' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1562:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1565:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1565:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1568:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1568:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1599:10: style: The destructor '~Action_UseItem' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1599:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1602:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1602:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1605:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1605:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1645:10: style: The destructor '~Action_ReorderArmies' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1645:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1648:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1648:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1651:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1651:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1680:10: style: The destructor '~Action_ResetStacks' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1680:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1683:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1683:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1686:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1686:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1711:10: style: The destructor '~Action_ResetRuins' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1711:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1714:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1714:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1717:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1717:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1738:10: style: The destructor '~Action_CollectTaxesAndPayUpkeep' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1738:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1741:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1741:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1747:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1747:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1770:10: style: The destructor '~Action_Kill' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1770:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1773:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1773:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1776:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1776:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1799:10: style: The destructor '~Action_DefendStack' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1799:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1802:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1802:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1805:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1805:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1833:10: style: The destructor '~Action_UndefendStack' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1833:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1836:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1836:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1839:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1839:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1866:10: style: The destructor '~Action_ParkStack' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1866:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1869:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1869:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1872:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1872:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1900:10: style: The destructor '~Action_UnparkStack' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1900:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1903:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1903:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1906:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1906:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1931:10: style: The destructor '~Action_SelectStack' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1931:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1934:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1934:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1937:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1937:22: note: Function in derived class lordsawar-0.3.2/src/action.h:1961:10: style: The destructor '~Action_DeselectStack' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1961:10: note: Destructor in derived class lordsawar-0.3.2/src/action.h:1964:23: style: The function 'dump' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:161:31: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1964:23: note: Function in derived class lordsawar-0.3.2/src/action.h:1967:22: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:186:22: note: Virtual function in base class lordsawar-0.3.2/src/action.h:1967:22: note: Function in derived class lordsawar-0.3.2/src/turn-actionlist.h:48:10: style: The destructor '~TurnActionlist' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/OwnerId.h:46:14: note: Virtual destructor in base class lordsawar-0.3.2/src/turn-actionlist.h:48:10: note: Destructor in derived class lordsawar-0.3.2/src/heroproto.h:49:10: style: The destructor '~HeroProto' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/armyproto.h:52:10: note: Virtual destructor in base class lordsawar-0.3.2/src/heroproto.h:49:10: note: Destructor in derived class lordsawar-0.3.2/src/heroproto.h:58:22: style: The function 'save' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/armyproto.h:142:22: note: Virtual function in base class lordsawar-0.3.2/src/heroproto.h:58:22: note: Function in derived class lordsawar-0.3.2/src/GameScenario.cpp:347:58: style: Argument 'step.x*0' to function Vector < int > is always 0. Constant literal calculation disable/hide variable expression 'step.x'. [knownArgumentHiddenVariableExpression] lordsawar-0.3.2/src/GameScenario.cpp:356:46: style: Argument 'step.x*0' to function Vector < int > is always 0. Constant literal calculation disable/hide variable expression 'step.x'. [knownArgumentHiddenVariableExpression] lordsawar-0.3.2/src/GameScenario.cpp:365:46: style: Argument 'step.x*0' to function Vector < int > is always 0. Constant literal calculation disable/hide variable expression 'step.x'. [knownArgumentHiddenVariableExpression] lordsawar-0.3.2/src/turn-actionlist.h:42:67: performance: Function parameter 'actions' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/GameScenario.cpp:1252:46: performance: Function parameter 'g' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/GameScenario.cpp:248:20: style: Variable 'stile' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameScenario.cpp:296:20: style: Variable 'stile' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameScenario.cpp:742:12: style: Variable 'cs' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameScenario.cpp:745:14: style: Variable 'ss' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameScenario.cpp:748:12: style: Variable 'ts' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameScenario.cpp:761:16: style: Variable 'as' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameScenario.cpp:1233:18: style: Variable 'i' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameScenario.cpp:1348:12: style: Variable 'armyset' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameScenario.cpp:1504:17: style: class member 'DetailsLoader::t' is never used. [unusedStructMember] lordsawar-0.3.2/src/GameScenario.cpp:156:30: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameScenario.cpp:224:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameScenario.cpp:252:24: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameScenario.cpp:300:24: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameScenario.cpp:329:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameScenario.cpp:334:42: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameScenario.cpp:381:41: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameScenario.cpp:417:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameScenario.cpp:431:46: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameScenario.cpp:485:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameScenario.cpp:503:46: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameScenario.cpp:544:46: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameScenario.cpp:558:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameScenario.cpp:573:58: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameScenario.cpp:597:58: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameScenario.cpp:615:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Item.cpp:83:7: warning:inconclusive: Member variable 'Item::sdying' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] lordsawar-0.3.2/src/Item.cpp:56:3: performance: Variable 'd_type' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/Item.cpp:94:3: performance: Variable 'd_type' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/Item.cpp:96:3: performance: Variable 'd_plantable_owner_id' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/Item.cpp:106:12: warning: The class 'Item' defines member function with name 'save' also defined in its parent class 'ItemProto'. [duplInheritedMember] lordsawar-0.3.2/src/ItemProto.h:126:14: note: Parent function 'ItemProto::save' lordsawar-0.3.2/src/Item.cpp:106:12: note: Derived function 'Item::save' lordsawar-0.3.2/src/Item.cpp:53:56: style: Parameter 'plantable_owner' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/ItemProto.cpp:90:3: performance: Variable 'd_bonus' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/ItemProto.cpp:91:3: performance: Variable 'd_uses_left' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/ItemProto.cpp:93:3: performance: Variable 'd_army_type_to_kill' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/ItemProto.cpp:96:3: performance: Variable 'd_army_type_to_summon' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/ItemProto.cpp:97:3: performance: Variable 'd_building_type_to_summon_on' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/ItemProto.cpp:99:3: performance: Variable 'd_mp_to_add' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/ItemProto.cpp:101:3: performance: Variable 'd_army_type_to_raise' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/ItemProto.cpp:102:3: performance: Variable 'd_num_armies_to_raise' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/ItemProto.h:180:14: style:inconclusive: Technically the member function 'ItemProto::isCurrentlyUsable' can be const. [functionConst] lordsawar-0.3.2/src/ItemProto.cpp:397:17: note: Technically the member function 'ItemProto::isCurrentlyUsable' can be const. lordsawar-0.3.2/src/ItemProto.h:180:14: note: Technically the member function 'ItemProto::isCurrentlyUsable' can be const. lordsawar-0.3.2/src/ItemProto.cpp:275:61: style:inconclusive: Function 'bonusFlagToString' argument 1 names different: declaration 'type' definition 'bonus'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ItemProto.h:245:58: note: Function 'bonusFlagToString' argument 1 names different: declaration 'type' definition 'bonus'. lordsawar-0.3.2/src/ItemProto.cpp:275:61: note: Function 'bonusFlagToString' argument 1 names different: declaration 'type' definition 'bonus'. lordsawar-0.3.2/src/ItemProto.cpp:229:18: style: Variable 'a' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/ItemProto.cpp:240:18: style: Variable 'a' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/Itemlist.cpp:126:34: style:inconclusive: Function 'remove' argument 1 names different: declaration 'item' definition 'itemproto'. [funcArgNamesDifferent] lordsawar-0.3.2/src/Itemlist.h:69:25: note: Function 'remove' argument 1 names different: declaration 'item' definition 'itemproto'. lordsawar-0.3.2/src/Itemlist.cpp:126:34: note: Function 'remove' argument 1 names different: declaration 'item' definition 'itemproto'. lordsawar-0.3.2/src/Itemlist.cpp:140:31: style:inconclusive: Function 'add' argument 1 names different: declaration 'item' definition 'itemproto'. [funcArgNamesDifferent] lordsawar-0.3.2/src/Itemlist.h:70:29: note: Function 'add' argument 1 names different: declaration 'item' definition 'itemproto'. lordsawar-0.3.2/src/Itemlist.cpp:140:31: note: Function 'add' argument 1 names different: declaration 'item' definition 'itemproto'. lordsawar-0.3.2/src/Itemlist.cpp:118:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Itemlist.cpp:129:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/PixMaskCache.h:33:32: performance: Variable 'generate' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/PixMaskCache.h:33:45: performance: Variable 'cachesize' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/ImageCache.h:598:10: style:inconclusive: Technically the member function 'SelectorPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:615:10: style:inconclusive: Technically the member function 'ArmyPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:637:10: style:inconclusive: Technically the member function 'FlagPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:654:10: style:inconclusive: Technically the member function 'CircledArmyPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:676:10: style:inconclusive: Technically the member function 'TilePixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:709:10: style:inconclusive: Technically the member function 'CityPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:725:10: style:inconclusive: Technically the member function 'TowerPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:740:10: style:inconclusive: Technically the member function 'TemplePixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:755:10: style:inconclusive: Technically the member function 'RuinPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:770:10: style:inconclusive: Technically the member function 'DiplomacyPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:786:10: style:inconclusive: Technically the member function 'RoadPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:802:10: style:inconclusive: Technically the member function 'FogPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:817:10: style:inconclusive: Technically the member function 'BridgePixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:832:10: style:inconclusive: Technically the member function 'CursorPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:847:10: style:inconclusive: Technically the member function 'ShieldPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:865:10: style:inconclusive: Technically the member function 'ProdShieldPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:880:10: style:inconclusive: Technically the member function 'MoveBonusPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:896:10: style:inconclusive: Technically the member function 'ShipPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:911:10: style:inconclusive: Technically the member function 'PlantedStandardPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:926:10: style:inconclusive: Technically the member function 'PortPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:940:10: style:inconclusive: Technically the member function 'SignpostPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:955:10: style:inconclusive: Technically the member function 'BagPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:970:10: style:inconclusive: Technically the member function 'ExplosionPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:985:10: style:inconclusive: Technically the member function 'NewLevelPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:1001:10: style:inconclusive: Technically the member function 'DefaultTileStylePixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:1019:10: style:inconclusive: Technically the member function 'TartanPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:1037:10: style:inconclusive: Technically the member function 'EmptyTartanPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:1054:10: style:inconclusive: Technically the member function 'StatusPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:1069:10: style:inconclusive: Technically the member function 'GameButtonPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:1084:10: style:inconclusive: Technically the member function 'DialogPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/ImageCache.h:1100:10: style:inconclusive: Technically the member function 'MedalPixMaskCacheItem::operator== < float >' can be const. [functionConst] lordsawar-0.3.2/src/bridge.h:52:9: style: Class 'Bridge' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/bridge.h:64:9: style: Class 'Bridge' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < SelectorPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < ArmyPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < FlagPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < CircledArmyPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < TilePixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < CityPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < TowerPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < TemplePixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < RuinPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < DiplomacyPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < RoadPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < FogPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < BridgePixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < CursorPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < ShieldPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < ProdShieldPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < MoveBonusPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < ShipPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < PlantedStandardPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < PortPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < SignpostPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < BagPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < ExplosionPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < NewLevelPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < DefaultTileStylePixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < TartanPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < EmptyTartanPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < StatusPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < GameButtonPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < DialogPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/PixMaskCache.h:33:5: style: Class 'PixMaskCache < MedalPixMaskCacheItem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/bridge.h:67:10: style: The destructor '~Bridge' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Location.h:62:6: note: Virtual destructor in base class lordsawar-0.3.2/src/bridge.h:67:10: note: Destructor in derived class lordsawar-0.3.2/src/ImageCache.cpp:1459:7: style: Condition 'broken' is always false [knownConditionTrueFalse] lordsawar-0.3.2/src/ImageCache.cpp:1455:17: note: Assignment 'broken=false', assigned value is 0 lordsawar-0.3.2/src/ImageCache.cpp:1459:7: note: Condition 'broken' is always false lordsawar-0.3.2/src/ImageCache.cpp:1819:7: style: Condition 'broken' is always false [knownConditionTrueFalse] lordsawar-0.3.2/src/ImageCache.cpp:1814:17: note: Assignment 'broken=false', assigned value is 0 lordsawar-0.3.2/src/ImageCache.cpp:1819:7: note: Condition 'broken' is always false lordsawar-0.3.2/src/ImageCache.cpp:1831:7: style: Condition 'broken' is always false [knownConditionTrueFalse] lordsawar-0.3.2/src/ImageCache.cpp:1814:17: note: Assignment 'broken=false', assigned value is 0 lordsawar-0.3.2/src/ImageCache.cpp:1831:7: note: Condition 'broken' is always false lordsawar-0.3.2/src/ImageCache.cpp:1430:18: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/ImageCache.cpp:1463:18: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/LocationBox.cpp:67:5: performance: Variable 'd_size' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/LocationBox.cpp:70:35: style:inconclusive: Function 'addArmy' argument 1 names different: declaration 'army' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/LocationBox.h:101:26: note: Function 'addArmy' argument 1 names different: declaration 'army' definition 'a'. lordsawar-0.3.2/src/LocationBox.cpp:70:35: note: Function 'addArmy' argument 1 names different: declaration 'army' definition 'a'. lordsawar-0.3.2/src/LocationBox.cpp:98:34: style:inconclusive: Function 'isFull' argument 1 names different: declaration 'owner' definition 'p'. [funcArgNamesDifferent] lordsawar-0.3.2/src/LocationBox.h:153:25: note: Function 'isFull' argument 1 names different: declaration 'owner' definition 'p'. lordsawar-0.3.2/src/LocationBox.cpp:98:34: note: Function 'isFull' argument 1 names different: declaration 'owner' definition 'p'. lordsawar-0.3.2/src/LocationBox.cpp:111:42: style:inconclusive: Function 'getFreeStack' argument 1 names different: declaration 'owner' definition 'p'. [funcArgNamesDifferent] lordsawar-0.3.2/src/LocationBox.h:150:33: note: Function 'getFreeStack' argument 1 names different: declaration 'owner' definition 'p'. lordsawar-0.3.2/src/LocationBox.cpp:111:42: note: Function 'getFreeStack' argument 1 names different: declaration 'owner' definition 'p'. lordsawar-0.3.2/src/LocationBox.cpp:176:53: style:inconclusive: Function 'isCompletelyObscuredByFog' argument 1 names different: declaration 'player' definition 'p'. [funcArgNamesDifferent] lordsawar-0.3.2/src/LocationBox.h:114:44: note: Function 'isCompletelyObscuredByFog' argument 1 names different: declaration 'player' definition 'p'. lordsawar-0.3.2/src/LocationBox.cpp:176:53: note: Function 'isCompletelyObscuredByFog' argument 1 names different: declaration 'player' definition 'p'. lordsawar-0.3.2/src/LocationBox.cpp:119:13: style: Variable 'stile' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/LocationBox.cpp:128:13: style: Variable 'enemy' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/LocationBox.cpp:176:53: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/LocationBox.cpp:188:49: style: Parameter 'm' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/ImageCache.cpp:674:58: style:inconclusive: Function 'getArmyPic' argument 2 names different: declaration 'army' definition 'army_id'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:188:54: note: Function 'getArmyPic' argument 2 names different: declaration 'army' definition 'army_id'. lordsawar-0.3.2/src/ImageCache.cpp:674:58: note: Function 'getArmyPic' argument 2 names different: declaration 'army' definition 'army_id'. lordsawar-0.3.2/src/ImageCache.cpp:742:65: style:inconclusive: Function 'getCircledArmyPic' argument 2 names different: declaration 'army' definition 'army_id'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:193:61: note: Function 'getCircledArmyPic' argument 2 names different: declaration 'army' definition 'army_id'. lordsawar-0.3.2/src/ImageCache.cpp:742:65: note: Function 'getCircledArmyPic' argument 2 names different: declaration 'army' definition 'army_id'. lordsawar-0.3.2/src/ImageCache.cpp:884:39: style:inconclusive: Function 'getRuinPic' argument 1 names different: declaration 'r' definition 'ruin'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:228:35: note: Function 'getRuinPic' argument 1 names different: declaration 'r' definition 'ruin'. lordsawar-0.3.2/src/ImageCache.cpp:884:39: note: Function 'getRuinPic' argument 1 names different: declaration 'r' definition 'ruin'. lordsawar-0.3.2/src/ImageCache.cpp:1214:53: style:inconclusive: Function 'getDefaultTileStylePic' argument 1 names different: declaration 'tilestyle_type' definition 'type'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:348:49: note: Function 'getDefaultTileStylePic' argument 1 names different: declaration 'tilestyle_type' definition 'type'. lordsawar-0.3.2/src/ImageCache.cpp:1214:53: note: Function 'getDefaultTileStylePic' argument 1 names different: declaration 'tilestyle_type' definition 'type'. lordsawar-0.3.2/src/ImageCache.cpp:1214:67: style:inconclusive: Function 'getDefaultTileStylePic' argument 2 names different: declaration 'tilesize' definition 'size'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:349:49: note: Function 'getDefaultTileStylePic' argument 2 names different: declaration 'tilesize' definition 'size'. lordsawar-0.3.2/src/ImageCache.cpp:1214:67: note: Function 'getDefaultTileStylePic' argument 2 names different: declaration 'tilesize' definition 'size'. lordsawar-0.3.2/src/ImageCache.cpp:1227:78: style:inconclusive: Function 'getTartanPic' argument 3 names different: declaration 's' definition 'shieldset'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:355:43: note: Function 'getTartanPic' argument 3 names different: declaration 's' definition 'shieldset'. lordsawar-0.3.2/src/ImageCache.cpp:1227:78: note: Function 'getTartanPic' argument 3 names different: declaration 's' definition 'shieldset'. lordsawar-0.3.2/src/ImageCache.cpp:1242:83: style:inconclusive: Function 'getEmptyTartanPic' argument 3 names different: declaration 's' definition 'shieldset'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:361:48: note: Function 'getEmptyTartanPic' argument 3 names different: declaration 's' definition 'shieldset'. lordsawar-0.3.2/src/ImageCache.cpp:1242:83: note: Function 'getEmptyTartanPic' argument 3 names different: declaration 's' definition 'shieldset'. lordsawar-0.3.2/src/ImageCache.cpp:1774:70: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:594:55: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:1774:70: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:1845:62: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:633:51: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:1845:62: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:1905:62: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:613:51: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:1905:62: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:1960:76: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:652:58: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:1960:76: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2012:62: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:674:51: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2012:62: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2167:62: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:707:51: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2167:62: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2189:64: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:723:52: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2189:64: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2205:66: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:738:53: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2205:66: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2221:62: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:753:51: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2221:62: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2237:72: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:768:56: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2237:72: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2272:62: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:784:51: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2272:62: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2288:60: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:800:50: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2288:60: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2304:66: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:815:53: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2304:66: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2320:66: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:830:53: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2320:66: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2342:66: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:845:53: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2342:66: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2386:74: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:863:57: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2386:74: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2428:72: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:878:56: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2428:72: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2449:62: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:894:51: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2449:62: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2468:84: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:909:62: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2468:84: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2487:62: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:924:51: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2487:62: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2500:70: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:938:55: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2500:70: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2513:60: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:953:50: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2513:60: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2526:72: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:968:56: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2526:72: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2539:70: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:983:55: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2539:70: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2567:86: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:999:63: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2567:86: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2612:66: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:1016:53: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2612:66: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2698:76: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:1035:58: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2698:76: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2787:66: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:1052:53: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2787:66: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2834:74: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:1067:57: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2834:74: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2860:66: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:1082:53: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2860:66: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2928:64: style:inconclusive: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ImageCache.h:1098:52: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2928:64: note: Function 'generate' argument 1 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/ImageCache.cpp:2121:59: performance: Function parameter 'item' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/ImageCache.cpp:662:39: style: Parameter 'a' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/ImageCache.cpp:668:45: style: Parameter 'a' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/ImageCache.cpp:733:46: style: Parameter 'a' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/ImageCache.cpp:859:43: style: Parameter 't' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/ImageCache.cpp:884:39: style: Parameter 'ruin' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/ImageCache.cpp:923:39: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/ImageCache.cpp:964:43: style: Parameter 'b' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/ImageCache.cpp:1000:57: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/ImageCache.cpp:1227:78: style: Parameter 'shieldset' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/ImageCache.cpp:1242:83: style: Parameter 'shieldset' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/ImageCache.cpp:1429:11: style: Variable 'data' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/ImageCache.cpp:1462:11: style: Variable 'data' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/ImageCache.cpp:1777:11: style: Variable 'p' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/ImageCache.cpp:1848:11: style: Variable 'p' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/ImageCache.cpp:1912:11: style: Variable 'p' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/ImageCache.cpp:1965:15: style: Variable 'p' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/ImageCache.cpp:2021:18: style: Variable 'tilestyle' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/ImageCache.cpp:2170:11: style: Variable 'p' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/ImageCache.cpp:2344:16: style: Variable 'sh' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/MapBackpack.cpp:44:19: warning: The class 'MapBackpack' defines member function with name 'save' also defined in its parent class 'Backpack'. [duplInheritedMember] lordsawar-0.3.2/src/Backpack.h:66:14: note: Parent function 'Backpack::save' lordsawar-0.3.2/src/MapBackpack.cpp:44:19: note: Derived function 'MapBackpack::save' lordsawar-0.3.2/src/MapBackpack.cpp:59:57: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/MapBackpack.cpp:69:57: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/MapRenderer.cpp:32:5: performance: Variable 'd_surface' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/MapRenderer.cpp:33:5: performance: Variable 'gc' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/MapRenderer.h:59:7: performance:inconclusive: Technically the member function 'MapRenderer::render_tile' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/MapRenderer.cpp:55:19: note: Technically the member function 'MapRenderer::render_tile' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/MapRenderer.h:59:7: note: Technically the member function 'MapRenderer::render_tile' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/MapRenderer.h:43:9: style: Class 'MapRenderer' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/MapRenderer.cpp:49:44: style:inconclusive: Function 'render' argument 3 names different: declaration 'tileX' definition 'tileStartX'. [funcArgNamesDifferent] lordsawar-0.3.2/src/MapRenderer.h:53:39: note: Function 'render' argument 3 names different: declaration 'tileX' definition 'tileStartX'. lordsawar-0.3.2/src/MapRenderer.cpp:49:44: note: Function 'render' argument 3 names different: declaration 'tileX' definition 'tileStartX'. lordsawar-0.3.2/src/MapRenderer.cpp:49:60: style:inconclusive: Function 'render' argument 4 names different: declaration 'tileY' definition 'tileStartY'. [funcArgNamesDifferent] lordsawar-0.3.2/src/MapRenderer.h:53:50: note: Function 'render' argument 4 names different: declaration 'tileY' definition 'tileStartY'. lordsawar-0.3.2/src/MapRenderer.cpp:49:60: note: Function 'render' argument 4 names different: declaration 'tileY' definition 'tileStartY'. lordsawar-0.3.2/src/ImageCache.h:675:41: performance: Function parameter 'item' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/MapRenderer.cpp:58:11: style: Variable 'p' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/MapRenderer.cpp:63:12: style: Variable 'mtile' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/MapRenderer.cpp:65:14: style: Variable 'style' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/MoveResult.cpp:32:13: warning: Member variable 'MoveResult::d_result' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/MoveResult.cpp:58:47: style:inconclusive: Function 'setFightResult' argument 1 names different: declaration 'd_fightResult' definition 'fightResult'. [funcArgNamesDifferent] lordsawar-0.3.2/src/MoveResult.h:39:43: note: Function 'setFightResult' argument 1 names different: declaration 'd_fightResult' definition 'fightResult'. lordsawar-0.3.2/src/MoveResult.cpp:58:47: note: Function 'setFightResult' argument 1 names different: declaration 'd_fightResult' definition 'fightResult'. lordsawar-0.3.2/src/MoveResult.cpp:42:34: style: Parameter 's' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/CreateScenario.h:153:7: performance:inconclusive: Technically the member function 'CreateScenario::createCapitalCity' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/CreateScenario.cpp:411:22: note: Technically the member function 'CreateScenario::createCapitalCity' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/CreateScenario.h:153:7: note: Technically the member function 'CreateScenario::createCapitalCity' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/CreateScenario.h:154:7: performance:inconclusive: Technically the member function 'CreateScenario::tooNearToOtherCapitalCities' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/CreateScenario.cpp:421:22: note: Technically the member function 'CreateScenario::tooNearToOtherCapitalCities' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/CreateScenario.h:154:7: note: Technically the member function 'CreateScenario::tooNearToOtherCapitalCities' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/CreateScenario.h:164:14: performance:inconclusive: Technically the member function 'CreateScenario::setupTemples' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/CreateScenario.cpp:512:22: note: Technically the member function 'CreateScenario::setupTemples' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/CreateScenario.h:164:14: note: Technically the member function 'CreateScenario::setupTemples' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/CreateScenario.h:175:7: performance:inconclusive: Technically the member function 'CreateScenario::setupItems' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/CreateScenario.cpp:622:22: note: Technically the member function 'CreateScenario::setupItems' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/CreateScenario.h:175:7: note: Technically the member function 'CreateScenario::setupItems' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/CreateScenario.h:193:7: performance:inconclusive: Technically the member function 'CreateScenario::getRuinDifficulty' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/CreateScenario.cpp:628:22: note: Technically the member function 'CreateScenario::getRuinDifficulty' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/CreateScenario.h:193:7: note: Technically the member function 'CreateScenario::getRuinDifficulty' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/CreateScenario.h:200:7: performance:inconclusive: Technically the member function 'CreateScenario::getSignpostDifficulty' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/CreateScenario.cpp:670:22: note: Technically the member function 'CreateScenario::getSignpostDifficulty' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/CreateScenario.h:200:7: note: Technically the member function 'CreateScenario::getSignpostDifficulty' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/CreateScenario.h:206:7: performance:inconclusive: Technically the member function 'CreateScenario::getCityDifficulty' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/CreateScenario.cpp:692:22: note: Technically the member function 'CreateScenario::getCityDifficulty' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/CreateScenario.h:206:7: note: Technically the member function 'CreateScenario::getCityDifficulty' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/CreateScenario.cpp:101:5: warning: Class 'CreateScenario' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] lordsawar-0.3.2/src/CreateScenario.cpp:101:5: warning: Class 'CreateScenario' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] lordsawar-0.3.2/src/GameScenario.h:131:14: warning: The class 'GameScenario' defines member function with name 'clean_tmp_dir' also defined in its parent class 'TarFile'. [duplInheritedMember] lordsawar-0.3.2/src/tarfile.h:50:10: note: Parent function 'TarFile::clean_tmp_dir' lordsawar-0.3.2/src/GameScenario.h:131:14: note: Derived function 'GameScenario::clean_tmp_dir' lordsawar-0.3.2/src/CreateScenario.h:57:9: style: Class 'CreateScenario' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/ai_smart.h:87:9: style: Class 'AI_Smart' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/ai_smart.h:89:9: style: Class 'AI_Smart' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/CreateScenario.h:58:10: style: The destructor '~CreateScenario' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/CreateScenarioRandomize.h:39:18: note: Virtual destructor in base class lordsawar-0.3.2/src/CreateScenario.h:58:10: note: Destructor in derived class lordsawar-0.3.2/src/ai_smart.h:91:10: style: The destructor '~AI_Smart' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:65:18: note: Virtual destructor in base class lordsawar-0.3.2/src/ai_smart.h:91:10: note: Destructor in derived class lordsawar-0.3.2/src/ai_smart.h:93:15: style: The function 'isComputer' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:67:15: note: Virtual function in base class lordsawar-0.3.2/src/ai_smart.h:93:15: note: Function in derived class lordsawar-0.3.2/src/ai_smart.h:94:15: style: The function 'abortTurn' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:71:15: note: Virtual function in base class lordsawar-0.3.2/src/ai_smart.h:94:15: note: Function in derived class lordsawar-0.3.2/src/ai_smart.h:95:22: style: The function 'startTurn' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:73:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_smart.h:95:22: note: Function in derived class lordsawar-0.3.2/src/ai_smart.h:96:22: style: The function 'invadeCity' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:77:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_smart.h:96:22: note: Function in derived class lordsawar-0.3.2/src/ai_smart.h:97:22: style: The function 'chooseHero' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:79:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_smart.h:97:22: note: Function in derived class lordsawar-0.3.2/src/ai_smart.h:98:25: style: The function 'chooseReward' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:81:25: note: Virtual function in base class lordsawar-0.3.2/src/ai_smart.h:98:25: note: Function in derived class lordsawar-0.3.2/src/ai_smart.h:99:22: style: The function 'heroGainsLevel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:83:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_smart.h:99:22: note: Function in derived class lordsawar-0.3.2/src/ai_smart.h:100:15: style: The function 'chooseTreachery' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:85:15: note: Virtual function in base class lordsawar-0.3.2/src/ai_smart.h:100:15: note: Function in derived class lordsawar-0.3.2/src/ai_smart.h:101:28: style: The function 'chooseStat' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:86:28: note: Virtual function in base class lordsawar-0.3.2/src/ai_smart.h:101:28: note: Function in derived class lordsawar-0.3.2/src/ai_smart.h:102:22: style: The function 'chooseQuest' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:88:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_smart.h:102:22: note: Function in derived class lordsawar-0.3.2/src/ai_smart.h:103:22: style: The function 'computerChooseVisitRuin' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:89:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_smart.h:103:22: note: Function in derived class lordsawar-0.3.2/src/ai_smart.h:104:22: style: The function 'computerChoosePickupBag' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:90:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_smart.h:104:22: note: Function in derived class lordsawar-0.3.2/src/ai_smart.h:105:22: style: The function 'computerChooseVisitTempleForBlessing' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:91:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_smart.h:105:22: note: Function in derived class lordsawar-0.3.2/src/ai_smart.h:106:22: style: The function 'computerChooseVisitTempleForQuest' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:92:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_smart.h:106:22: note: Function in derived class lordsawar-0.3.2/src/ai_smart.h:107:22: style: The function 'computerChooseContinueQuest' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:93:22: note: Virtual function in base class lordsawar-0.3.2/src/ai_smart.h:107:22: note: Function in derived class lordsawar-0.3.2/src/CreateScenario.cpp:281:7: style: Condition '!createMap()' is always false [knownConditionTrueFalse] lordsawar-0.3.2/src/CreateScenario.cpp:281:17: note: Calling function 'createMap' returns 1 lordsawar-0.3.2/src/CreateScenario.cpp:281:7: note: Condition '!createMap()' is always false lordsawar-0.3.2/src/CreateScenario.cpp:292:7: style: Condition '!setupTemples()' is always false [knownConditionTrueFalse] lordsawar-0.3.2/src/CreateScenario.cpp:292:20: note: Calling function 'setupTemples' returns 1 lordsawar-0.3.2/src/CreateScenario.cpp:292:7: note: Condition '!setupTemples()' is always false lordsawar-0.3.2/src/CreateScenario.cpp:301:7: style: Condition '!setupRuins(GameScenario::s_play_with_quests!=GameParameters::NO_QUESTING,20,10,6)' is always false [knownConditionTrueFalse] lordsawar-0.3.2/src/CreateScenario.cpp:301:18: note: Calling function 'setupRuins' returns 1 lordsawar-0.3.2/src/CreateScenario.cpp:301:7: note: Condition '!setupRuins(GameScenario::s_play_with_quests!=GameParameters::NO_QUESTING,20,10,6)' is always false lordsawar-0.3.2/src/CreateScenario.cpp:306:7: style: Condition '!setupPlayers(g.random_turns,base_gold)' is always false [knownConditionTrueFalse] lordsawar-0.3.2/src/CreateScenario.cpp:306:20: note: Calling function 'setupPlayers' returns 1 lordsawar-0.3.2/src/CreateScenario.cpp:306:7: note: Condition '!setupPlayers(g.random_turns,base_gold)' is always false lordsawar-0.3.2/src/CreateScenario.cpp:309:7: style: Condition '!setupItems()' is always false [knownConditionTrueFalse] lordsawar-0.3.2/src/CreateScenario.cpp:309:18: note: Calling function 'setupItems' returns 1 lordsawar-0.3.2/src/CreateScenario.cpp:309:7: note: Condition '!setupItems()' is always false lordsawar-0.3.2/src/CreateScenario.cpp:312:7: style: Condition '!setupRoads()' is always false [knownConditionTrueFalse] lordsawar-0.3.2/src/CreateScenario.cpp:312:18: note: Calling function 'setupRoads' returns 1 lordsawar-0.3.2/src/CreateScenario.cpp:312:7: note: Condition '!setupRoads()' is always false lordsawar-0.3.2/src/CreateScenario.cpp:315:7: style: Condition '!setupBridges()' is always false [knownConditionTrueFalse] lordsawar-0.3.2/src/CreateScenario.cpp:315:20: note: Calling function 'setupBridges' returns 1 lordsawar-0.3.2/src/CreateScenario.cpp:315:7: note: Condition '!setupBridges()' is always false lordsawar-0.3.2/src/CreateScenario.cpp:318:7: style: Condition '!setupStandingStones(d_generator->getRoadStones())' is always false [knownConditionTrueFalse] lordsawar-0.3.2/src/CreateScenario.cpp:318:27: note: Calling function 'setupStandingStones' returns 1 lordsawar-0.3.2/src/CreateScenario.cpp:318:7: note: Condition '!setupStandingStones(d_generator->getRoadStones())' is always false lordsawar-0.3.2/src/CreateScenario.cpp:321:7: style: Condition '!distributePlayers()' is always false [knownConditionTrueFalse] lordsawar-0.3.2/src/CreateScenario.cpp:321:25: note: Calling function 'distributePlayers' returns 1 lordsawar-0.3.2/src/CreateScenario.cpp:321:7: note: Condition '!distributePlayers()' is always false lordsawar-0.3.2/src/CreateScenario.cpp:326:7: style: Condition '!setupCities(g.cities_can_produce_allies,number_of_armies_factor)' is always false [knownConditionTrueFalse] lordsawar-0.3.2/src/CreateScenario.cpp:326:19: note: Calling function 'setupCities' returns 1 lordsawar-0.3.2/src/CreateScenario.cpp:326:7: note: Condition '!setupCities(g.cities_can_produce_allies,number_of_armies_factor)' is always false lordsawar-0.3.2/src/CreateScenario.cpp:331:7: style: Condition '!setupSignposts(signpost_ratio)' is always false [knownConditionTrueFalse] lordsawar-0.3.2/src/CreateScenario.cpp:331:22: note: Calling function 'setupSignposts' returns 1 lordsawar-0.3.2/src/CreateScenario.cpp:331:7: note: Condition '!setupSignposts(signpost_ratio)' is always false lordsawar-0.3.2/src/CreateScenario.cpp:154:49: style:inconclusive: Function 'setShieldset' argument 1 names different: declaration 'shieldsname' definition 'shieldset'. [funcArgNamesDifferent] lordsawar-0.3.2/src/CreateScenario.h:70:34: note: Function 'setShieldset' argument 1 names different: declaration 'shieldsname' definition 'shieldset'. lordsawar-0.3.2/src/CreateScenario.cpp:154:49: note: Function 'setShieldset' argument 1 names different: declaration 'shieldsname' definition 'shieldset'. lordsawar-0.3.2/src/CreateScenario.cpp:170:38: style:inconclusive: Function 'setNoCities' argument 1 names different: declaration 'number' definition 'nocities'. [funcArgNamesDifferent] lordsawar-0.3.2/src/CreateScenario.h:76:30: note: Function 'setNoCities' argument 1 names different: declaration 'number' definition 'nocities'. lordsawar-0.3.2/src/CreateScenario.cpp:170:38: note: Function 'setNoCities' argument 1 names different: declaration 'number' definition 'nocities'. lordsawar-0.3.2/src/CreateScenario.cpp:177:37: style:inconclusive: Function 'setNoRuins' argument 1 names different: declaration 'number' definition 'noruins'. [funcArgNamesDifferent] lordsawar-0.3.2/src/CreateScenario.h:79:29: note: Function 'setNoRuins' argument 1 names different: declaration 'number' definition 'noruins'. lordsawar-0.3.2/src/CreateScenario.cpp:177:37: note: Function 'setNoRuins' argument 1 names different: declaration 'number' definition 'noruins'. lordsawar-0.3.2/src/CreateScenario.cpp:184:42: style:inconclusive: Function 'setNoSignposts' argument 1 names different: declaration 'number' definition 'nosignposts'. [funcArgNamesDifferent] lordsawar-0.3.2/src/CreateScenario.h:82:33: note: Function 'setNoSignposts' argument 1 names different: declaration 'number' definition 'nosignposts'. lordsawar-0.3.2/src/CreateScenario.cpp:184:42: note: Function 'setNoSignposts' argument 1 names different: declaration 'number' definition 'nosignposts'. lordsawar-0.3.2/src/CreateScenario.cpp:191:39: style:inconclusive: Function 'setNoStones' argument 1 names different: declaration 'number' definition 'nostones'. [funcArgNamesDifferent] lordsawar-0.3.2/src/CreateScenario.h:85:30: note: Function 'setNoStones' argument 1 names different: declaration 'number' definition 'nostones'. lordsawar-0.3.2/src/CreateScenario.cpp:191:39: note: Function 'setNoStones' argument 1 names different: declaration 'number' definition 'nostones'. lordsawar-0.3.2/src/CreateScenario.cpp:198:39: style:inconclusive: Function 'setNoTemples' argument 1 names different: declaration 'number' definition 'notemples'. [funcArgNamesDifferent] lordsawar-0.3.2/src/CreateScenario.h:88:31: note: Function 'setNoTemples' argument 1 names different: declaration 'number' definition 'notemples'. lordsawar-0.3.2/src/CreateScenario.cpp:198:39: note: Function 'setNoTemples' argument 1 names different: declaration 'number' definition 'notemples'. lordsawar-0.3.2/src/CreateScenario.cpp:421:76: performance: Function parameter 'capitals' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/CreateScenario.cpp:591:68: performance: Function parameter 'road_stones' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/CreateScenario.cpp:421:56: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/CreateScenario.cpp:598:13: style: Variable 'r' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/CreateScenario.cpp:707:9: style: Variable 'r' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/CreateScenario.cpp:288:55: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/CreateScenario.cpp:424:8: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/CreateScenario.cpp:533:47: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/NextTurnHotseat.h:50:18: style: The destructor '~NextTurnHotseat' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/NextTurn.h:52:18: note: Virtual destructor in base class lordsawar-0.3.2/src/NextTurnHotseat.h:50:18: note: Destructor in derived class lordsawar-0.3.2/src/NextTurnHotseat.h:59:14: style: The function 'start' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/NextTurn.h:61:22: note: Virtual function in base class lordsawar-0.3.2/src/NextTurnHotseat.h:59:14: note: Function in derived class lordsawar-0.3.2/src/NextTurnHotseat.h:67:14: style: The function 'endTurn' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/NextTurn.h:69:22: note: Virtual function in base class lordsawar-0.3.2/src/NextTurnHotseat.h:67:14: note: Function in derived class lordsawar-0.3.2/src/network-action.h:46:11: warning: The class 'NetworkAction' defines member function with name 'save' also defined in its parent class 'OwnerId'. [duplInheritedMember] lordsawar-0.3.2/src/OwnerId.h:59:10: note: Parent function 'OwnerId::save' lordsawar-0.3.2/src/network-action.h:46:11: note: Derived function 'NetworkAction::save' lordsawar-0.3.2/src/network-history.h:45:11: warning: The class 'NetworkHistory' defines member function with name 'save' also defined in its parent class 'OwnerId'. [duplInheritedMember] lordsawar-0.3.2/src/OwnerId.h:59:10: note: Parent function 'OwnerId::save' lordsawar-0.3.2/src/network-history.h:45:11: note: Derived function 'NetworkHistory::save' lordsawar-0.3.2/src/network_player.h:87:9: style: Class 'NetworkPlayer' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/network_player.h:88:9: style: Class 'NetworkPlayer' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/chat-client.h:34:3: style: Class 'ChatClient' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/network-action.h:37:6: style: Class 'NetworkAction' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/network-history.h:36:6: style: Class 'NetworkHistory' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/NextTurnNetworked.h:42:18: style: The destructor '~NextTurnNetworked' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/NextTurn.h:52:18: note: Virtual destructor in base class lordsawar-0.3.2/src/NextTurnNetworked.h:42:18: note: Destructor in derived class lordsawar-0.3.2/src/NextTurnNetworked.h:51:14: style: The function 'start' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/NextTurn.h:61:22: note: Virtual function in base class lordsawar-0.3.2/src/NextTurnNetworked.h:51:14: note: Function in derived class lordsawar-0.3.2/src/NextTurnNetworked.h:59:14: style: The function 'endTurn' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/NextTurn.h:69:22: note: Virtual function in base class lordsawar-0.3.2/src/NextTurnNetworked.h:59:14: note: Function in derived class lordsawar-0.3.2/src/network_player.h:89:10: style: The destructor '~NetworkPlayer' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:188:18: note: Virtual destructor in base class lordsawar-0.3.2/src/network_player.h:89:10: note: Destructor in derived class lordsawar-0.3.2/src/network_player.h:92:22: style: The function 'save' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:460:22: note: Virtual function in base class lordsawar-0.3.2/src/network_player.h:92:22: note: Function in derived class lordsawar-0.3.2/src/network_player.h:94:15: style: The function 'isComputer' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:242:15: note: Virtual function in base class lordsawar-0.3.2/src/network_player.h:94:15: note: Function in derived class lordsawar-0.3.2/src/network_player.h:97:15: style: The function 'abortTurn' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1057:22: note: Virtual function in base class lordsawar-0.3.2/src/network_player.h:97:15: note: Function in derived class lordsawar-0.3.2/src/network_player.h:98:22: style: The function 'startTurn' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1055:22: note: Virtual function in base class lordsawar-0.3.2/src/network_player.h:98:22: note: Function in derived class lordsawar-0.3.2/src/network_player.h:99:22: style: The function 'endTurn' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1067:22: note: Virtual function in base class lordsawar-0.3.2/src/network_player.h:99:22: note: Function in derived class lordsawar-0.3.2/src/network_player.h:100:22: style: The function 'invadeCity' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1016:22: note: Virtual function in base class lordsawar-0.3.2/src/network_player.h:100:22: note: Function in derived class lordsawar-0.3.2/src/network_player.h:101:22: style: The function 'chooseHero' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1019:22: note: Virtual function in base class lordsawar-0.3.2/src/network_player.h:101:22: note: Function in derived class lordsawar-0.3.2/src/network_player.h:103:25: style: The function 'chooseReward' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1022:25: note: Virtual function in base class lordsawar-0.3.2/src/network_player.h:103:25: note: Function in derived class lordsawar-0.3.2/src/network_player.h:104:22: style: The function 'heroGainsLevel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:779:22: note: Virtual function in base class lordsawar-0.3.2/src/network_player.h:104:22: note: Function in derived class lordsawar-0.3.2/src/network_player.h:105:15: style: The function 'chooseTreachery' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1025:15: note: Virtual function in base class lordsawar-0.3.2/src/network_player.h:105:15: note: Function in derived class lordsawar-0.3.2/src/network_player.h:106:28: style: The function 'chooseStat' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1028:28: note: Virtual function in base class lordsawar-0.3.2/src/network_player.h:106:28: note: Function in derived class lordsawar-0.3.2/src/network_player.h:107:22: style: The function 'chooseQuest' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1031:22: note: Virtual function in base class lordsawar-0.3.2/src/network_player.h:107:22: note: Function in derived class lordsawar-0.3.2/src/network_player.h:108:22: style: The function 'computerChooseVisitRuin' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1034:22: note: Virtual function in base class lordsawar-0.3.2/src/network_player.h:108:22: note: Function in derived class lordsawar-0.3.2/src/network_player.h:109:22: style: The function 'computerChoosePickupBag' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1036:22: note: Virtual function in base class lordsawar-0.3.2/src/network_player.h:109:22: note: Function in derived class lordsawar-0.3.2/src/network_player.h:110:22: style: The function 'computerChooseVisitTempleForBlessing' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1038:22: note: Virtual function in base class lordsawar-0.3.2/src/network_player.h:110:22: note: Function in derived class lordsawar-0.3.2/src/network_player.h:111:22: style: The function 'computerChooseVisitTempleForQuest' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1040:22: note: Virtual function in base class lordsawar-0.3.2/src/network_player.h:111:22: note: Function in derived class lordsawar-0.3.2/src/network_player.h:112:22: style: The function 'computerChooseContinueQuest' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:1042:22: note: Virtual function in base class lordsawar-0.3.2/src/network_player.h:112:22: note: Function in derived class lordsawar-0.3.2/src/network-action.h:40:7: style: The destructor '~NetworkAction' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/OwnerId.h:46:14: note: Virtual destructor in base class lordsawar-0.3.2/src/network-action.h:40:7: note: Destructor in derived class lordsawar-0.3.2/src/network-history.h:39:7: style: The destructor '~NetworkHistory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/OwnerId.h:46:14: note: Virtual destructor in base class lordsawar-0.3.2/src/network-history.h:39:7: note: Destructor in derived class lordsawar-0.3.2/src/game-server.h:81:4: style: The destructor '~GameServer' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/game-station.h:59:12: note: Virtual destructor in base class lordsawar-0.3.2/src/game-server.h:81:4: note: Destructor in derived class lordsawar-0.3.2/src/game-server.h:86:8: style: The function 'onActionDone' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/game-station.h:61:16: note: Virtual function in base class lordsawar-0.3.2/src/game-server.h:86:8: note: Function in derived class lordsawar-0.3.2/src/game-server.h:87:8: style: The function 'onHistoryDone' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/game-station.h:62:16: note: Virtual function in base class lordsawar-0.3.2/src/game-server.h:87:8: note: Function in derived class lordsawar-0.3.2/src/game-client.h:71:4: style: The destructor '~GameClient' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/game-station.h:59:12: note: Virtual destructor in base class lordsawar-0.3.2/src/game-client.h:71:4: note: Destructor in derived class lordsawar-0.3.2/src/game-client.h:83:8: style: The function 'onActionDone' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/game-station.h:61:16: note: Virtual function in base class lordsawar-0.3.2/src/game-client.h:83:8: note: Function in derived class lordsawar-0.3.2/src/game-client.h:86:8: style: The function 'onHistoryDone' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/game-station.h:62:16: note: Virtual function in base class lordsawar-0.3.2/src/game-client.h:86:8: note: Function in derived class lordsawar-0.3.2/src/Ownable.cpp:55:32: style:inconclusive: Function 'isFriend' argument 1 names different: declaration 'player' definition 'opponent'. [funcArgNamesDifferent] lordsawar-0.3.2/src/Ownable.h:53:28: note: Function 'isFriend' argument 1 names different: declaration 'player' definition 'opponent'. lordsawar-0.3.2/src/Ownable.cpp:55:32: note: Function 'isFriend' argument 1 names different: declaration 'player' definition 'opponent'. lordsawar-0.3.2/src/Ownable.cpp:55:32: style: Parameter 'opponent' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/NextTurnNetworked.cpp:57:46: style:inconclusive: Function 'start_player' argument 1 names different: declaration 'p' definition 'player'. [funcArgNamesDifferent] lordsawar-0.3.2/src/NextTurnNetworked.h:65:35: note: Function 'start_player' argument 1 names different: declaration 'p' definition 'player'. lordsawar-0.3.2/src/NextTurnNetworked.cpp:57:46: note: Function 'start_player' argument 1 names different: declaration 'p' definition 'player'. lordsawar-0.3.2/src/OwnerId.cpp:24:3: performance: Variable 'd_owner_id' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/PixMask.cpp:30:3: performance: Variable 'pixmap' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/PixMask.h:41:10: performance:inconclusive: Technically the member function 'PixMask::get_depth' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/PixMask.cpp:260:14: note: Technically the member function 'PixMask::get_depth' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/PixMask.h:41:10: note: Technically the member function 'PixMask::get_depth' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/PixMask.cpp:48:48: style:inconclusive: Function 'PixMask' argument 1 names different: declaration 'pixmap' definition 'p'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PixMask.h:74:44: note: Function 'PixMask' argument 1 names different: declaration 'pixmap' definition 'p'. lordsawar-0.3.2/src/PixMask.cpp:48:48: note: Function 'PixMask' argument 1 names different: declaration 'pixmap' definition 'p'. lordsawar-0.3.2/src/PixMask.cpp:48:81: style:inconclusive: Function 'PixMask' argument 2 names different: declaration 'mask' definition 'm'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PixMask.h:74:82: note: Function 'PixMask' argument 2 names different: declaration 'mask' definition 'm'. lordsawar-0.3.2/src/PixMask.cpp:48:81: note: Function 'PixMask' argument 2 names different: declaration 'mask' definition 'm'. lordsawar-0.3.2/src/PixMask.cpp:153:40: style:inconclusive: Function 'create' argument 1 names different: declaration 'file' definition 'filename'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PixMask.h:43:43: note: Function 'create' argument 1 names different: declaration 'file' definition 'filename'. lordsawar-0.3.2/src/PixMask.cpp:153:40: note: Function 'create' argument 1 names different: declaration 'file' definition 'filename'. lordsawar-0.3.2/src/PixMask.cpp:158:52: style:inconclusive: Function 'create' argument 1 names different: declaration 'buf' definition 'pixbuf'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PixMask.h:44:55: note: Function 'create' argument 1 names different: declaration 'buf' definition 'pixbuf'. lordsawar-0.3.2/src/PixMask.cpp:158:52: note: Function 'create' argument 1 names different: declaration 'buf' definition 'pixbuf'. lordsawar-0.3.2/src/PixMask.cpp:173:59: style:inconclusive: Function 'blit_centered' argument 1 names different: declaration 'pixmap' definition 'dest'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PixMask.h:61:55: note: Function 'blit_centered' argument 1 names different: declaration 'pixmap' definition 'dest'. lordsawar-0.3.2/src/PixMask.cpp:173:59: note: Function 'blit_centered' argument 1 names different: declaration 'pixmap' definition 'dest'. lordsawar-0.3.2/src/PixMask.cpp:179:50: style:inconclusive: Function 'blit' argument 1 names different: declaration 'pixmap' definition 'dest'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PixMask.h:60:46: note: Function 'blit' argument 1 names different: declaration 'pixmap' definition 'dest'. lordsawar-0.3.2/src/PixMask.cpp:179:50: note: Function 'blit' argument 1 names different: declaration 'pixmap' definition 'dest'. lordsawar-0.3.2/src/PixMask.cpp:185:50: style:inconclusive: Function 'blit' argument 1 names different: declaration 'pixmap' definition 'dest'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PixMask.h:59:46: note: Function 'blit' argument 1 names different: declaration 'pixmap' definition 'dest'. lordsawar-0.3.2/src/PixMask.cpp:185:50: note: Function 'blit' argument 1 names different: declaration 'pixmap' definition 'dest'. lordsawar-0.3.2/src/PixMask.cpp:194:67: style:inconclusive: Function 'blit' argument 2 names different: declaration 'pixmap' definition 'p'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PixMask.h:102:63: note: Function 'blit' argument 2 names different: declaration 'pixmap' definition 'p'. lordsawar-0.3.2/src/PixMask.cpp:194:67: note: Function 'blit' argument 2 names different: declaration 'pixmap' definition 'p'. lordsawar-0.3.2/src/PixMask.cpp:209:76: style:inconclusive: Function 'blit' argument 3 names different: declaration 'pixmap' definition 'p'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PixMask.h:63:72: note: Function 'blit' argument 3 names different: declaration 'pixmap' definition 'p'. lordsawar-0.3.2/src/PixMask.cpp:209:76: note: Function 'blit' argument 3 names different: declaration 'pixmap' definition 'p'. lordsawar-0.3.2/src/PixMask.cpp:215:31: style:inconclusive: Function 'scale' argument 1 names different: declaration 'pixmask' definition 'p'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PixMask.h:56:34: note: Function 'scale' argument 1 names different: declaration 'pixmask' definition 'p'. lordsawar-0.3.2/src/PixMask.cpp:215:31: note: Function 'scale' argument 1 names different: declaration 'pixmask' definition 'p'. lordsawar-0.3.2/src/PixMask.cpp:215:72: style:inconclusive: Function 'scale' argument 4 names different: declaration 'intper' definition 'interp'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PixMask.h:56:81: note: Function 'scale' argument 4 names different: declaration 'intper' definition 'interp'. lordsawar-0.3.2/src/PixMask.cpp:215:72: note: Function 'scale' argument 4 names different: declaration 'intper' definition 'interp'. lordsawar-0.3.2/src/PixMask.cpp:242:111: style:inconclusive: Function 'draw_pixbuf' argument 6 names different: declaration 'width' definition 'w'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PixMask.h:53:107: note: Function 'draw_pixbuf' argument 6 names different: declaration 'width' definition 'w'. lordsawar-0.3.2/src/PixMask.cpp:242:111: note: Function 'draw_pixbuf' argument 6 names different: declaration 'width' definition 'w'. lordsawar-0.3.2/src/PixMask.cpp:242:118: style:inconclusive: Function 'draw_pixbuf' argument 7 names different: declaration 'height' definition 'h'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PixMask.h:53:118: note: Function 'draw_pixbuf' argument 7 names different: declaration 'height' definition 'h'. lordsawar-0.3.2/src/PixMask.cpp:242:118: note: Function 'draw_pixbuf' argument 7 names different: declaration 'height' definition 'h'. lordsawar-0.3.2/src/PathCalculator.cpp:157:17: warning: Member variable 'PathCalculator::load_unload_stack' is not initialized in the copy constructor. [uninitMemberVar] lordsawar-0.3.2/src/PathCalculator.h:133:10: style: Unused private function: 'PathCalculator::dumpNodeMap' [unusedPrivateFunction] lordsawar-0.3.2/src/PathCalculator.h:54:10: style:inconclusive: Technically the member function 'PathCalculator::isReachable' can be const. [functionConst] lordsawar-0.3.2/src/PathCalculator.cpp:595:22: note: Technically the member function 'PathCalculator::isReachable' can be const. lordsawar-0.3.2/src/PathCalculator.h:54:10: note: Technically the member function 'PathCalculator::isReachable' can be const. lordsawar-0.3.2/src/PathCalculator.h:64:29: style:inconclusive: Technically the member function 'PathCalculator::getReachablePositions' can be const. [functionConst] lordsawar-0.3.2/src/PathCalculator.cpp:656:41: note: Technically the member function 'PathCalculator::getReachablePositions' can be const. lordsawar-0.3.2/src/PathCalculator.h:64:29: note: Technically the member function 'PathCalculator::getReachablePositions' can be const. lordsawar-0.3.2/src/PathCalculator.h:128:10: performance:inconclusive: Technically the member function 'PathCalculator::isBlockedDir' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/PathCalculator.cpp:386:22: note: Technically the member function 'PathCalculator::isBlockedDir' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/PathCalculator.h:128:10: note: Technically the member function 'PathCalculator::isBlockedDir' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/PathCalculator.h:131:10: style:inconclusive: Technically the member function 'PathCalculator::isBlocked' can be const. [functionConst] lordsawar-0.3.2/src/PathCalculator.cpp:432:22: note: Technically the member function 'PathCalculator::isBlocked' can be const. lordsawar-0.3.2/src/PathCalculator.h:131:10: note: Technically the member function 'PathCalculator::isBlocked' can be const. lordsawar-0.3.2/src/PathCalculator.h:133:10: style:inconclusive: Technically the member function 'PathCalculator::dumpNodeMap' can be const. [functionConst] lordsawar-0.3.2/src/PathCalculator.cpp:568:22: note: Technically the member function 'PathCalculator::dumpNodeMap' can be const. lordsawar-0.3.2/src/PathCalculator.h:133:10: note: Technically the member function 'PathCalculator::dumpNodeMap' can be const. lordsawar-0.3.2/src/PathCalculator.cpp:144:3: warning: Class 'PathCalculator' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] lordsawar-0.3.2/src/armyprodbase.h:48:9: style: Class 'ArmyProdBase' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/armyprodbase.h:51:9: style: Class 'ArmyProdBase' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/armyprodbase.h:54:10: style: The destructor '~ArmyProdBase' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/armyprotobase.h:48:10: note: Virtual destructor in base class lordsawar-0.3.2/src/armyprodbase.h:54:10: note: Destructor in derived class lordsawar-0.3.2/src/PathCalculator.cpp:47:12: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/PathCalculator.cpp:166:12: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/PathCalculator.cpp:104:53: style:inconclusive: Function 'PathCalculator' argument 2 names different: declaration 'zigzag' definition 'zig'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PathCalculator.h:40:41: note: Function 'PathCalculator' argument 2 names different: declaration 'zigzag' definition 'zig'. lordsawar-0.3.2/src/PathCalculator.cpp:104:53: note: Function 'PathCalculator' argument 2 names different: declaration 'zigzag' definition 'zig'. lordsawar-0.3.2/src/PathCalculator.cpp:104:62: style:inconclusive: Function 'PathCalculator' argument 3 names different: declaration 'enemy_city_avoidance' definition 'city_avoidance'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PathCalculator.h:40:60: note: Function 'PathCalculator' argument 3 names different: declaration 'enemy_city_avoidance' definition 'city_avoidance'. lordsawar-0.3.2/src/PathCalculator.cpp:104:62: note: Function 'PathCalculator' argument 3 names different: declaration 'enemy_city_avoidance' definition 'city_avoidance'. lordsawar-0.3.2/src/PathCalculator.cpp:104:82: style:inconclusive: Function 'PathCalculator' argument 4 names different: declaration 'enemy_stack_avoidance' definition 'stack_avoidance'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PathCalculator.h:40:91: note: Function 'PathCalculator' argument 4 names different: declaration 'enemy_stack_avoidance' definition 'stack_avoidance'. lordsawar-0.3.2/src/PathCalculator.cpp:104:82: note: Function 'PathCalculator' argument 4 names different: declaration 'enemy_stack_avoidance' definition 'stack_avoidance'. lordsawar-0.3.2/src/PathCalculator.cpp:112:95: style:inconclusive: Function 'PathCalculator' argument 4 names different: declaration 'zigzag' definition 'zig'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PathCalculator.h:46:90: note: Function 'PathCalculator' argument 4 names different: declaration 'zigzag' definition 'zig'. lordsawar-0.3.2/src/PathCalculator.cpp:112:95: note: Function 'PathCalculator' argument 4 names different: declaration 'zigzag' definition 'zig'. lordsawar-0.3.2/src/PathCalculator.cpp:112:104: style:inconclusive: Function 'PathCalculator' argument 5 names different: declaration 'enemy_city_avoidance' definition 'city_avoidance'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PathCalculator.h:46:109: note: Function 'PathCalculator' argument 5 names different: declaration 'enemy_city_avoidance' definition 'city_avoidance'. lordsawar-0.3.2/src/PathCalculator.cpp:112:104: note: Function 'PathCalculator' argument 5 names different: declaration 'enemy_city_avoidance' definition 'city_avoidance'. lordsawar-0.3.2/src/PathCalculator.cpp:112:124: style:inconclusive: Function 'PathCalculator' argument 6 names different: declaration 'enemy_stack_avoidance' definition 'stack_avoidance'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PathCalculator.h:46:140: note: Function 'PathCalculator' argument 6 names different: declaration 'enemy_stack_avoidance' definition 'stack_avoidance'. lordsawar-0.3.2/src/PathCalculator.cpp:112:124: note: Function 'PathCalculator' argument 6 names different: declaration 'enemy_stack_avoidance' definition 'stack_avoidance'. lordsawar-0.3.2/src/PathCalculator.cpp:142:53: style:inconclusive: Function 'PathCalculator' argument 2 names different: declaration 'zigzag' definition 'zig'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PathCalculator.h:43:41: note: Function 'PathCalculator' argument 2 names different: declaration 'zigzag' definition 'zig'. lordsawar-0.3.2/src/PathCalculator.cpp:142:53: note: Function 'PathCalculator' argument 2 names different: declaration 'zigzag' definition 'zig'. lordsawar-0.3.2/src/PathCalculator.cpp:142:62: style:inconclusive: Function 'PathCalculator' argument 3 names different: declaration 'enemy_city_avoidance' definition 'city_avoidance'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PathCalculator.h:43:60: note: Function 'PathCalculator' argument 3 names different: declaration 'enemy_city_avoidance' definition 'city_avoidance'. lordsawar-0.3.2/src/PathCalculator.cpp:142:62: note: Function 'PathCalculator' argument 3 names different: declaration 'enemy_city_avoidance' definition 'city_avoidance'. lordsawar-0.3.2/src/PathCalculator.cpp:142:82: style:inconclusive: Function 'PathCalculator' argument 4 names different: declaration 'enemy_stack_avoidance' definition 'stack_avoidance'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PathCalculator.h:43:91: note: Function 'PathCalculator' argument 4 names different: declaration 'enemy_stack_avoidance' definition 'stack_avoidance'. lordsawar-0.3.2/src/PathCalculator.cpp:142:82: note: Function 'PathCalculator' argument 4 names different: declaration 'enemy_stack_avoidance' definition 'stack_avoidance'. lordsawar-0.3.2/src/PathCalculator.cpp:337:78: style:inconclusive: Function 'load_or_unload' argument 3 names different: declaration 'on_ship' definition 'ship'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PathCalculator.h:99:66: note: Function 'load_or_unload' argument 3 names different: declaration 'on_ship' definition 'ship'. lordsawar-0.3.2/src/PathCalculator.cpp:337:78: note: Function 'load_or_unload' argument 3 names different: declaration 'on_ship' definition 'ship'. lordsawar-0.3.2/src/PathCalculator.cpp:437:54: style:inconclusive: Function 'calculate' argument 2 names different: declaration 'zigzag' definition 'zig'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PathCalculator.h:59:42: note: Function 'calculate' argument 2 names different: declaration 'zigzag' definition 'zig'. lordsawar-0.3.2/src/PathCalculator.cpp:437:54: note: Function 'calculate' argument 2 names different: declaration 'zigzag' definition 'zig'. lordsawar-0.3.2/src/PathCalculator.cpp:450:103: style:inconclusive: Function 'calculate' argument 5 names different: declaration 'zigzag' definition 'zig'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PathCalculator.h:56:91: note: Function 'calculate' argument 5 names different: declaration 'zigzag' definition 'zig'. lordsawar-0.3.2/src/PathCalculator.cpp:450:103: note: Function 'calculate' argument 5 names different: declaration 'zigzag' definition 'zig'. lordsawar-0.3.2/src/PathCalculator.cpp:600:101: style:inconclusive: Function 'calculateToCity' argument 5 names different: declaration 'zigzag' definition 'zig'. [funcArgNamesDifferent] lordsawar-0.3.2/src/PathCalculator.h:58:89: note: Function 'calculateToCity' argument 5 names different: declaration 'zigzag' definition 'zig'. lordsawar-0.3.2/src/PathCalculator.cpp:600:101: note: Function 'calculateToCity' argument 5 names different: declaration 'zigzag' definition 'zig'. lordsawar-0.3.2/src/PathCalculator.cpp:46:10: style: Local variable 'length' shadows outer function [shadowFunction] lordsawar-0.3.2/src/vector.h:196:10: note: Shadowed declaration lordsawar-0.3.2/src/PathCalculator.cpp:46:10: note: Shadow variable lordsawar-0.3.2/src/PathCalculator.cpp:165:10: style: Local variable 'length' shadows outer function [shadowFunction] lordsawar-0.3.2/src/vector.h:196:10: note: Shadowed declaration lordsawar-0.3.2/src/PathCalculator.cpp:165:10: note: Shadow variable lordsawar-0.3.2/src/PathCalculator.cpp:482:7: style: Local variable 'dist' shadows outer function [shadowFunction] lordsawar-0.3.2/src/vector.h:180:10: note: Shadowed declaration lordsawar-0.3.2/src/PathCalculator.cpp:482:7: note: Shadow variable lordsawar-0.3.2/src/PathCalculator.cpp:642:6: style: Local variable 'dist' shadows outer function [shadowFunction] lordsawar-0.3.2/src/vector.h:180:10: note: Shadowed declaration lordsawar-0.3.2/src/PathCalculator.cpp:642:6: note: Shadow variable lordsawar-0.3.2/src/PathCalculator.cpp:357:17: style: Variable 'enemy' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/PathCalculator.cpp:414:14: style: Variable 'target' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/PathCalculator.cpp:423:13: style: Variable 'c' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/PathCalculator.cpp:600:46: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/PathCalculator.cpp:99:23: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/PathCalculator.cpp:522:24: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/PathCalculator.cpp:546:62: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/QCityOccupy.cpp:63:5: performance: Variable 'd_city' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/QCityOccupy.h:49:6: style: The destructor '~QuestCityOccupy' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:98:18: note: Virtual destructor in base class lordsawar-0.3.2/src/QCityOccupy.h:49:6: note: Destructor in derived class lordsawar-0.3.2/src/QCityOccupy.h:65:19: style: The function 'getProgress' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:164:31: note: Virtual function in base class lordsawar-0.3.2/src/QCityOccupy.h:65:19: note: Function in derived class lordsawar-0.3.2/src/QCityOccupy.h:68:10: style: The function 'getSuccessMsg' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:171:22: note: Virtual function in base class lordsawar-0.3.2/src/QCityOccupy.h:68:10: note: Function in derived class lordsawar-0.3.2/src/QCityOccupy.h:71:10: style: The function 'getExpiredMsg' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:182:22: note: Virtual function in base class lordsawar-0.3.2/src/QCityOccupy.h:71:10: note: Function in derived class lordsawar-0.3.2/src/QCityOccupy.h:83:10: style: The function 'save' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:158:22: note: Virtual function in base class lordsawar-0.3.2/src/QCityOccupy.h:83:10: note: Function in derived class lordsawar-0.3.2/src/QCityOccupy.h:92:10: style: The function 'armyDied' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:194:15: note: Virtual function in base class lordsawar-0.3.2/src/QCityOccupy.h:92:10: note: Function in derived class lordsawar-0.3.2/src/QCityOccupy.h:113:10: style: The function 'cityAction' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:212:15: note: Virtual function in base class lordsawar-0.3.2/src/QCityOccupy.h:113:10: note: Function in derived class lordsawar-0.3.2/src/QCityOccupy.cpp:178:12: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] lordsawar-0.3.2/src/QCityOccupy.cpp:180:7: note: Found duplicate branches for 'if' and 'else'. lordsawar-0.3.2/src/QCityOccupy.cpp:178:12: note: Found duplicate branches for 'if' and 'else'. lordsawar-0.3.2/src/QCityOccupy.cpp:186:12: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] lordsawar-0.3.2/src/QCityOccupy.cpp:188:7: note: Found duplicate branches for 'if' and 'else'. lordsawar-0.3.2/src/QCityOccupy.cpp:186:12: note: Found duplicate branches for 'if' and 'else'. lordsawar-0.3.2/src/QCityOccupy.cpp:39:50: style:inconclusive: Function 'QuestCityOccupy' argument 1 names different: declaration 'q_mgr' definition 'mgr'. [funcArgNamesDifferent] lordsawar-0.3.2/src/QCityOccupy.h:46:36: note: Function 'QuestCityOccupy' argument 1 names different: declaration 'q_mgr' definition 'mgr'. lordsawar-0.3.2/src/QCityOccupy.cpp:39:50: note: Function 'QuestCityOccupy' argument 1 names different: declaration 'q_mgr' definition 'mgr'. lordsawar-0.3.2/src/QCityOccupy.cpp:60:50: style:inconclusive: Function 'QuestCityOccupy' argument 1 names different: declaration 'q_mgr' definition 'mgr'. [funcArgNamesDifferent] lordsawar-0.3.2/src/QCityOccupy.h:59:36: note: Function 'QuestCityOccupy' argument 1 names different: declaration 'q_mgr' definition 'mgr'. lordsawar-0.3.2/src/QCityOccupy.cpp:60:50: note: Function 'QuestCityOccupy' argument 1 names different: declaration 'q_mgr' definition 'mgr'. lordsawar-0.3.2/src/QCityOccupy.cpp:123:48: style:inconclusive: Function 'chooseToOccupy' argument 1 names different: declaration 'player' definition 'p'. [funcArgNamesDifferent] lordsawar-0.3.2/src/QCityOccupy.h:153:41: note: Function 'chooseToOccupy' argument 1 names different: declaration 'player' definition 'p'. lordsawar-0.3.2/src/QCityOccupy.cpp:123:48: note: Function 'chooseToOccupy' argument 1 names different: declaration 'player' definition 'p'. lordsawar-0.3.2/src/QCityOccupy.cpp:147:40: style:inconclusive: Function 'cityAction' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/QCityOccupy.h:113:27: note: Function 'cityAction' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/QCityOccupy.cpp:147:40: note: Function 'cityAction' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/QCityOccupy.cpp:153:9: style: Variable 'h' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/QCityRaze.cpp:62:3: performance: Variable 'd_city' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/QCityRaze.h:49:10: style: The destructor '~QuestCityRaze' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:98:18: note: Virtual destructor in base class lordsawar-0.3.2/src/QCityRaze.h:49:10: note: Destructor in derived class lordsawar-0.3.2/src/QCityRaze.h:69:23: style: The function 'getProgress' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:164:31: note: Virtual function in base class lordsawar-0.3.2/src/QCityRaze.h:69:23: note: Function in derived class lordsawar-0.3.2/src/QCityRaze.h:72:14: style: The function 'getSuccessMsg' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:171:22: note: Virtual function in base class lordsawar-0.3.2/src/QCityRaze.h:72:14: note: Function in derived class lordsawar-0.3.2/src/QCityRaze.h:75:14: style: The function 'getExpiredMsg' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:182:22: note: Virtual function in base class lordsawar-0.3.2/src/QCityRaze.h:75:14: note: Function in derived class lordsawar-0.3.2/src/QCityRaze.h:87:14: style: The function 'save' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:158:22: note: Virtual function in base class lordsawar-0.3.2/src/QCityRaze.h:87:14: note: Function in derived class lordsawar-0.3.2/src/QCityRaze.h:96:7: style: The function 'armyDied' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:194:15: note: Virtual function in base class lordsawar-0.3.2/src/QCityRaze.h:96:7: note: Function in derived class lordsawar-0.3.2/src/QCityRaze.h:117:7: style: The function 'cityAction' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:212:15: note: Virtual function in base class lordsawar-0.3.2/src/QCityRaze.h:117:7: note: Function in derived class lordsawar-0.3.2/src/QCityRaze.cpp:180:12: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] lordsawar-0.3.2/src/QCityRaze.cpp:182:7: note: Found duplicate branches for 'if' and 'else'. lordsawar-0.3.2/src/QCityRaze.cpp:180:12: note: Found duplicate branches for 'if' and 'else'. lordsawar-0.3.2/src/QCityRaze.cpp:38:46: style:inconclusive: Function 'QuestCityRaze' argument 1 names different: declaration 'q_mgr' definition 'mgr'. [funcArgNamesDifferent] lordsawar-0.3.2/src/QCityRaze.h:46:38: note: Function 'QuestCityRaze' argument 1 names different: declaration 'q_mgr' definition 'mgr'. lordsawar-0.3.2/src/QCityRaze.cpp:38:46: note: Function 'QuestCityRaze' argument 1 names different: declaration 'q_mgr' definition 'mgr'. lordsawar-0.3.2/src/QCityRaze.cpp:59:46: style:inconclusive: Function 'QuestCityRaze' argument 1 names different: declaration 'q_mgr' definition 'mgr'. [funcArgNamesDifferent] lordsawar-0.3.2/src/QCityRaze.h:59:38: note: Function 'QuestCityRaze' argument 1 names different: declaration 'q_mgr' definition 'mgr'. lordsawar-0.3.2/src/QCityRaze.cpp:59:46: note: Function 'QuestCityRaze' argument 1 names different: declaration 'q_mgr' definition 'mgr'. lordsawar-0.3.2/src/QCityRaze.cpp:149:38: style:inconclusive: Function 'cityAction' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/QCityRaze.h:117:24: note: Function 'cityAction' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/QCityRaze.cpp:149:38: note: Function 'cityAction' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/QCityRaze.cpp:155:9: style: Variable 'h' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/QCitySack.cpp:64:3: performance: Variable 'd_city' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/QCitySack.h:52:6: style: The destructor '~QuestCitySack' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:98:18: note: Virtual destructor in base class lordsawar-0.3.2/src/QCitySack.h:52:6: note: Destructor in derived class lordsawar-0.3.2/src/QCitySack.h:67:19: style: The function 'getProgress' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:164:31: note: Virtual function in base class lordsawar-0.3.2/src/QCitySack.h:67:19: note: Function in derived class lordsawar-0.3.2/src/QCitySack.h:70:10: style: The function 'getSuccessMsg' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:171:22: note: Virtual function in base class lordsawar-0.3.2/src/QCitySack.h:70:10: note: Function in derived class lordsawar-0.3.2/src/QCitySack.h:73:10: style: The function 'getExpiredMsg' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:182:22: note: Virtual function in base class lordsawar-0.3.2/src/QCitySack.h:73:10: note: Function in derived class lordsawar-0.3.2/src/QCitySack.h:82:10: style: The function 'save' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:158:22: note: Virtual function in base class lordsawar-0.3.2/src/QCitySack.h:82:10: note: Function in derived class lordsawar-0.3.2/src/QCitySack.h:94:10: style: The function 'armyDied' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:194:15: note: Virtual function in base class lordsawar-0.3.2/src/QCitySack.h:94:10: note: Function in derived class lordsawar-0.3.2/src/QCitySack.h:115:10: style: The function 'cityAction' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:212:15: note: Virtual function in base class lordsawar-0.3.2/src/QCitySack.h:115:10: note: Function in derived class lordsawar-0.3.2/src/QCitySack.cpp:179:12: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] lordsawar-0.3.2/src/QCitySack.cpp:181:7: note: Found duplicate branches for 'if' and 'else'. lordsawar-0.3.2/src/QCitySack.cpp:179:12: note: Found duplicate branches for 'if' and 'else'. lordsawar-0.3.2/src/QCitySack.cpp:187:12: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] lordsawar-0.3.2/src/QCitySack.cpp:189:7: note: Found duplicate branches for 'if' and 'else'. lordsawar-0.3.2/src/QCitySack.cpp:187:12: note: Found duplicate branches for 'if' and 'else'. lordsawar-0.3.2/src/QCitySack.cpp:39:46: style:inconclusive: Function 'QuestCitySack' argument 1 names different: declaration 'q_mgr' definition 'mgr'. [funcArgNamesDifferent] lordsawar-0.3.2/src/QCitySack.h:49:34: note: Function 'QuestCitySack' argument 1 names different: declaration 'q_mgr' definition 'mgr'. lordsawar-0.3.2/src/QCitySack.cpp:39:46: note: Function 'QuestCitySack' argument 1 names different: declaration 'q_mgr' definition 'mgr'. lordsawar-0.3.2/src/QCitySack.cpp:61:46: style:inconclusive: Function 'QuestCitySack' argument 1 names different: declaration 'q_mgr' definition 'mgr'. [funcArgNamesDifferent] lordsawar-0.3.2/src/QCitySack.h:62:34: note: Function 'QuestCitySack' argument 1 names different: declaration 'q_mgr' definition 'mgr'. lordsawar-0.3.2/src/QCitySack.cpp:61:46: note: Function 'QuestCitySack' argument 1 names different: declaration 'q_mgr' definition 'mgr'. lordsawar-0.3.2/src/QCitySack.cpp:148:38: style:inconclusive: Function 'cityAction' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/QCitySack.h:115:27: note: Function 'cityAction' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/QCitySack.cpp:148:38: note: Function 'cityAction' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/QCitySack.cpp:154:9: style: Variable 'h' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/QEnemyArmies.cpp:151:39: style:inconclusive: Function 'armyDied' argument 1 names different: declaration 'army' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/QEnemyArmies.h:102:25: note: Function 'armyDied' argument 1 names different: declaration 'army' definition 'a'. lordsawar-0.3.2/src/QEnemyArmies.cpp:151:39: note: Function 'armyDied' argument 1 names different: declaration 'army' definition 'a'. lordsawar-0.3.2/src/QEnemyArmies.cpp:173:41: style:inconclusive: Function 'cityAction' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/QEnemyArmies.h:108:27: note: Function 'cityAction' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/QEnemyArmies.cpp:173:41: note: Function 'cityAction' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/QEnemyArmies.cpp:39:33: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/QEnemyArmies.cpp:155:9: style: Variable 'h' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/QEnemyArmies.cpp:57:45: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/QEnemyArmytype.cpp:92:3: performance: Variable 'd_type_to_kill' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/QEnemyArmytype.cpp:37:31: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/QEnemyArmytype.cpp:156:9: style: Variable 'h' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/QEnemyArmytype.cpp:48:49: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/QEnemyArmytype.cpp:53:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/QKillHero.cpp:72:3: performance: Variable 'd_victim' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/QKillHero.cpp:40:45: style:inconclusive: Function 'QuestKillHero' argument 1 names different: declaration 'q_mgr' definition 'mgr'. [funcArgNamesDifferent] lordsawar-0.3.2/src/QKillHero.h:50:34: note: Function 'QuestKillHero' argument 1 names different: declaration 'q_mgr' definition 'mgr'. lordsawar-0.3.2/src/QKillHero.cpp:40:45: note: Function 'QuestKillHero' argument 1 names different: declaration 'q_mgr' definition 'mgr'. lordsawar-0.3.2/src/QKillHero.cpp:59:9: style: Variable 'hero' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/QKillHero.cpp:130:9: style: Variable 'v' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/QKillHero.cpp:140:11: style: Variable 'active' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/QKillHero.cpp:166:9: style: Variable 'h' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/QKillHero.cpp:148:73: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/QKillHero.cpp:149:66: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/QPillageGold.cpp:39:3: performance: Variable 'd_to_pillage' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/QPillageGold.cpp:56:3: performance: Variable 'd_to_pillage' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/QPillageGold.h:52:10: style: The destructor '~QuestPillageGold' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:98:18: note: Virtual destructor in base class lordsawar-0.3.2/src/QPillageGold.h:52:10: note: Destructor in derived class lordsawar-0.3.2/src/QPillageGold.h:68:23: style: The function 'getProgress' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:164:31: note: Virtual function in base class lordsawar-0.3.2/src/QPillageGold.h:68:23: note: Function in derived class lordsawar-0.3.2/src/QPillageGold.h:71:14: style: The function 'getSuccessMsg' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:171:22: note: Virtual function in base class lordsawar-0.3.2/src/QPillageGold.h:71:14: note: Function in derived class lordsawar-0.3.2/src/QPillageGold.h:74:14: style: The function 'getExpiredMsg' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:182:22: note: Virtual function in base class lordsawar-0.3.2/src/QPillageGold.h:74:14: note: Function in derived class lordsawar-0.3.2/src/QPillageGold.h:83:14: style: The function 'save' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:158:22: note: Virtual function in base class lordsawar-0.3.2/src/QPillageGold.h:83:14: note: Function in derived class lordsawar-0.3.2/src/QPillageGold.h:92:7: style: The function 'armyDied' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:194:15: note: Virtual function in base class lordsawar-0.3.2/src/QPillageGold.h:92:7: note: Function in derived class lordsawar-0.3.2/src/QPillageGold.h:112:7: style: The function 'cityAction' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:212:15: note: Virtual function in base class lordsawar-0.3.2/src/QPillageGold.h:112:7: note: Function in derived class lordsawar-0.3.2/src/QPillageGold.cpp:101:41: style:inconclusive: Function 'cityAction' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/QPillageGold.h:112:24: note: Function 'cityAction' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/QPillageGold.cpp:101:41: note: Function 'cityAction' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/QPillageGold.cpp:108:9: style: Variable 'h' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/Quest.cpp:39:9: style: Variable 'h' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/Quest.cpp:103:24: style: Variable 'event' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/RoadPathCalculator.cpp:31:3: warning: Class 'RoadPathCalculator' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] lordsawar-0.3.2/src/RoadPathCalculator.h:37:6: style: Class 'RoadPathCalculator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/QuestsManager.cpp:81:5: warning: Calling method 'sharedInit()' when 'this' might be invalid [thisUseAfterFree] lordsawar-0.3.2/src/QuestsManager.h:323:32: note: Assuming 's_instance' is used as 'this' lordsawar-0.3.2/src/QuestsManager.cpp:70:5: note: Delete 's_instance', invalidating 'this' lordsawar-0.3.2/src/QuestsManager.cpp:81:5: note: Call method when 'this' is invalid lordsawar-0.3.2/src/QuestsManager.cpp:519:12: warning:inconclusive: Either the condition 'q' is redundant or there is possible null pointer dereference: *it. [nullPointerRedundantCheck] lordsawar-0.3.2/src/QuestsManager.cpp:524:8: note: Assuming that condition 'q' is not redundant lordsawar-0.3.2/src/QuestsManager.cpp:521:15: note: Assignment to 'q=*it' lordsawar-0.3.2/src/QuestsManager.cpp:519:12: note: Null pointer dereference lordsawar-0.3.2/src/QuestsManager.cpp:432:36: style:inconclusive: Function 'armyDied' argument 1 names different: declaration 'army' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/QuestsManager.h:131:22: note: Function 'armyDied' argument 1 names different: declaration 'army' definition 'a'. lordsawar-0.3.2/src/QuestsManager.cpp:432:36: note: Function 'armyDied' argument 1 names different: declaration 'army' definition 'a'. lordsawar-0.3.2/src/QuestsManager.cpp:488:37: style:inconclusive: Function 'cityRazed' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/QuestsManager.h:143:23: note: Function 'cityRazed' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/QuestsManager.cpp:488:37: note: Function 'cityRazed' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/QuestsManager.cpp:488:47: style:inconclusive: Function 'cityRazed' argument 2 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/QuestsManager.h:143:36: note: Function 'cityRazed' argument 2 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/QuestsManager.cpp:488:47: note: Function 'cityRazed' argument 2 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/QuestsManager.cpp:494:38: style:inconclusive: Function 'citySacked' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/QuestsManager.h:156:24: note: Function 'citySacked' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/QuestsManager.cpp:494:38: note: Function 'citySacked' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/QuestsManager.cpp:494:48: style:inconclusive: Function 'citySacked' argument 2 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/QuestsManager.h:156:37: note: Function 'citySacked' argument 2 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/QuestsManager.cpp:494:48: note: Function 'citySacked' argument 2 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/QuestsManager.cpp:499:40: style:inconclusive: Function 'cityPillaged' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/QuestsManager.h:170:26: note: Function 'cityPillaged' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/QuestsManager.cpp:499:40: note: Function 'cityPillaged' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/QuestsManager.cpp:499:50: style:inconclusive: Function 'cityPillaged' argument 2 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/QuestsManager.h:170:39: note: Function 'cityPillaged' argument 2 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/QuestsManager.cpp:499:50: note: Function 'cityPillaged' argument 2 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/QuestsManager.cpp:504:40: style:inconclusive: Function 'cityOccupied' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/QuestsManager.h:182:26: note: Function 'cityOccupied' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/QuestsManager.cpp:504:40: note: Function 'cityOccupied' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/QuestsManager.cpp:504:50: style:inconclusive: Function 'cityOccupied' argument 2 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/QuestsManager.h:182:39: note: Function 'cityOccupied' argument 2 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/QuestsManager.cpp:504:50: note: Function 'cityOccupied' argument 2 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/QuestsManager.cpp:509:38: style:inconclusive: Function 'nextTurn' argument 1 names different: declaration 'player' definition 'p'. [funcArgNamesDifferent] lordsawar-0.3.2/src/QuestsManager.h:189:24: note: Function 'nextTurn' argument 1 names different: declaration 'player' definition 'p'. lordsawar-0.3.2/src/QuestsManager.cpp:509:38: note: Function 'nextTurn' argument 1 names different: declaration 'player' definition 'p'. lordsawar-0.3.2/src/QuestsManager.cpp:432:61: style: Parameter 'culprits' can be declared as reference to const [constParameterReference] lordsawar-0.3.2/src/QuestsManager.cpp:251:12: style: Variable 'quest' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/QuestsManager.cpp:297:10: style: Variable 'q' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/QuestsManager.cpp:454:10: style: Variable 'quest' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/QuestsManager.cpp:93:30: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/QuestsManager.cpp:270:76: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/QuestsManager.cpp:311:30: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/QuestsManager.cpp:318:39: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/QuestsManager.cpp:421:30: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/QuestsManager.cpp:470:60: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/QuestsManager.cpp:477:60: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/QuestsManager.cpp:517:39: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/ScenarioMedia.h:269:14: performance:inconclusive: Technically the member function 'ScenarioMedia::instantiateMaskedImage' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/ScenarioMedia.cpp:264:21: note: Technically the member function 'ScenarioMedia::instantiateMaskedImage' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/ScenarioMedia.h:269:14: note: Technically the member function 'ScenarioMedia::instantiateMaskedImage' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/ScenarioMedia.h:270:14: performance:inconclusive: Technically the member function 'ScenarioMedia::instantiateImage' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/ScenarioMedia.cpp:283:21: note: Technically the member function 'ScenarioMedia::instantiateImage' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/ScenarioMedia.h:270:14: note: Technically the member function 'ScenarioMedia::instantiateImage' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/ScenarioMedia.h:271:14: performance:inconclusive: Technically the member function 'ScenarioMedia::instantiateImageRow' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/ScenarioMedia.cpp:254:21: note: Technically the member function 'ScenarioMedia::instantiateImageRow' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/ScenarioMedia.h:271:14: note: Technically the member function 'ScenarioMedia::instantiateImageRow' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/ScenarioMedia.cpp:92:19: warning: Using member 'd_next_turn_name' when 'this' might be invalid [thisUseAfterFree] lordsawar-0.3.2/src/ScenarioMedia.h:226:31: note: Assuming 'd_instance' is used as 'this' lordsawar-0.3.2/src/ScenarioMedia.cpp:50:5: note: Delete 'd_instance', invalidating 'this' lordsawar-0.3.2/src/ScenarioMedia.cpp:92:19: note: Call method when 'this' is invalid lordsawar-0.3.2/src/SightMap.cpp:33:52: style:inconclusive: Function 'SightMap' argument 2 names different: declaration 'pos' definition 'p'. [funcArgNamesDifferent] lordsawar-0.3.2/src/SightMap.h:51:50: note: Function 'SightMap' argument 2 names different: declaration 'pos' definition 'p'. lordsawar-0.3.2/src/SightMap.cpp:33:52: note: Function 'SightMap' argument 2 names different: declaration 'pos' definition 'p'. lordsawar-0.3.2/src/Sage.cpp:188:42: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Threat.cpp:94:64: error: Invalid abs() argument nr 1. A non-boolean value is required. [invalidFunctionArgBool] lordsawar-0.3.2/src/Threat.cpp:49:5: warning: Class 'Threat' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] lordsawar-0.3.2/src/Threat.cpp:49:5: warning: Class 'Threat' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] lordsawar-0.3.2/src/Threat.cpp:38:23: style: Parameter 's' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/Threat.cpp:76:44: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/Threat.cpp:101:30: style: Parameter 'stack' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/Threat.cpp:177:33: style: Parameter 's' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/Threat.cpp:192:38: style: Parameter 'old_owner' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/Threat.cpp:54:76: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Threatlist.cpp:59:46: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Threatlist.cpp:77:9: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Threatlist.cpp:81:9: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Threatlist.cpp:83:33: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Threatlist.cpp:104:46: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Threatlist.cpp:133:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Threatlist.cpp:172:58: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Threatlist.cpp:178:58: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Threatlist.cpp:186:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Threatlist.cpp:204:46: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Threatlist.cpp:230:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Tile.cpp:34:3: performance: Variable 'd_moves' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/Tile.cpp:38:74: style:inconclusive: Function 'Tile' argument 4 names different: declaration 's' definition 'small'. [funcArgNamesDifferent] lordsawar-0.3.2/src/Tile.h:77:77: note: Function 'Tile' argument 4 names different: declaration 's' definition 'small'. lordsawar-0.3.2/src/Tile.cpp:38:74: note: Function 'Tile' argument 4 names different: declaration 's' definition 'small'. lordsawar-0.3.2/src/Tile.cpp:176:53: performance: Function parameter 'types' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/Tile.cpp:179:3: style: Consider using std::all_of or std::none_of algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/Tile.cpp:271:9: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/Tile.cpp:80:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Tile.cpp:243:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Tile.cpp:251:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Tile.cpp:268:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Tile.cpp:269:87: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Tile.cpp:277:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/Tile.cpp:287:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/UniquelyIdentified.cpp:28:5: performance: Variable 'd_id' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/UniquelyIdentified.cpp:39:5: performance: Variable 'd_id' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/UniquelyIdentified.h:59:10: style:inconclusive: Technically the member function 'UniquelyIdentified::syncNewId' can be const. [functionConst] lordsawar-0.3.2/src/UniquelyIdentified.cpp:51:26: note: Technically the member function 'UniquelyIdentified::syncNewId' can be const. lordsawar-0.3.2/src/UniquelyIdentified.h:59:10: note: Technically the member function 'UniquelyIdentified::syncNewId' can be const. lordsawar-0.3.2/src/Triumphs.h:61:9: style: Class 'Triumphs' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/Triumphs.cpp:112:37: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/Triumphs.h:91:34: style: Parameter 'player' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/advertised-game.cpp:50:17: warning:inconclusive: Member variable 'AdvertisedGame::pinged' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] lordsawar-0.3.2/src/advertised-game.cpp:47:3: warning: Class 'AdvertisedGame' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] lordsawar-0.3.2/src/recently-played-game.h:170:2: style: Class 'RecentlyPlayedHotseatGame' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/recently-played-game.h:208:2: style: Class 'RecentlyPlayedNetworkedGame' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/advertised-game.h:48:2: style: Class 'AdvertisedGame' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/profile.h:44:9: style: Class 'Profile' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/profile.h:50:9: style: Class 'Profile' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/network-connection.h:40:3: style: Class 'NetworkConnection' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/recently-played-game.h:176:3: style: The destructor '~RecentlyPlayedHotseatGame' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/recently-played-game.h:67:18: note: Virtual destructor in base class lordsawar-0.3.2/src/recently-played-game.h:176:3: note: Destructor in derived class lordsawar-0.3.2/src/recently-played-game.h:182:15: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/recently-played-game.h:133:15: note: Virtual function in base class lordsawar-0.3.2/src/recently-played-game.h:182:15: note: Function in derived class lordsawar-0.3.2/src/recently-played-game.h:211:3: style: The destructor '~RecentlyPlayedNetworkedGame' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/recently-played-game.h:67:18: note: Virtual destructor in base class lordsawar-0.3.2/src/recently-played-game.h:211:3: note: Destructor in derived class lordsawar-0.3.2/src/recently-played-game.h:226:15: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/recently-played-game.h:133:15: note: Virtual function in base class lordsawar-0.3.2/src/recently-played-game.h:226:15: note: Function in derived class lordsawar-0.3.2/src/advertised-game.h:51:3: style: The destructor '~AdvertisedGame' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/recently-played-game.h:211:3: note: Virtual destructor in base class lordsawar-0.3.2/src/advertised-game.h:51:3: note: Destructor in derived class lordsawar-0.3.2/src/advertised-game.h:63:15: style: The function 'doSave' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/recently-played-game.h:226:15: note: Virtual function in base class lordsawar-0.3.2/src/advertised-game.h:63:15: note: Function in derived class lordsawar-0.3.2/src/advertised-game.cpp:33:46: style:inconclusive: Function 'AdvertisedGame' argument 1 names different: declaration 'game_scenario' definition 'scen'. [funcArgNamesDifferent] lordsawar-0.3.2/src/advertised-game.h:40:31: note: Function 'AdvertisedGame' argument 1 names different: declaration 'game_scenario' definition 'scen'. lordsawar-0.3.2/src/advertised-game.cpp:33:46: note: Function 'AdvertisedGame' argument 1 names different: declaration 'game_scenario' definition 'scen'. lordsawar-0.3.2/src/advertised-game.cpp:42:82: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.h:359:14: performance:inconclusive: Technically the member function 'Action_Fight::stack_ids_to_stacks' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/action.cpp:620:20: note: Technically the member function 'Action_Fight::stack_ids_to_stacks' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/action.h:359:14: note: Technically the member function 'Action_Fight::stack_ids_to_stacks' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/action.cpp:1548:32: warning: Class 'Action_Produce' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] lordsawar-0.3.2/src/action.cpp:1632:5: warning: Class 'Action_ProduceVectored' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] lordsawar-0.3.2/src/action.cpp:1895:34: warning: Class 'Action_RecruitHero' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] lordsawar-0.3.2/src/action.cpp:2189:7: style: The scope of the variable 'ival' can be reduced. [variableScope] lordsawar-0.3.2/src/action.cpp:359:46: style:inconclusive: Function 'Action_Move' argument 1 names different: declaration 'action' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:207:40: note: Function 'Action_Move' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:359:46: note: Function 'Action_Move' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:496:48: style:inconclusive: Function 'Action_Fight' argument 1 names different: declaration 'action' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:332:35: note: Function 'Action_Fight' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:496:48: note: Function 'Action_Fight' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:683:33: style:inconclusive: Function 'Action_Join' argument 1 names different: declaration 'orig' definition 'o'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:380:28: note: Function 'Action_Join' argument 1 names different: declaration 'orig' definition 'o'. lordsawar-0.3.2/src/action.cpp:683:33: note: Function 'Action_Join' argument 1 names different: declaration 'orig' definition 'o'. lordsawar-0.3.2/src/action.cpp:683:43: style:inconclusive: Function 'Action_Join' argument 2 names different: declaration 'joining' definition 'j'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:380:41: note: Function 'Action_Join' argument 2 names different: declaration 'joining' definition 'j'. lordsawar-0.3.2/src/action.cpp:683:43: note: Function 'Action_Join' argument 2 names different: declaration 'joining' definition 'j'. lordsawar-0.3.2/src/action.cpp:694:45: style:inconclusive: Function 'Action_Join' argument 1 names different: declaration 'action' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:382:33: note: Function 'Action_Join' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:694:45: note: Function 'Action_Join' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:733:44: style:inconclusive: Function 'Action_Ruin' argument 1 names different: declaration 'action' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:417:32: note: Function 'Action_Ruin' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:733:44: note: Function 'Action_Ruin' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:954:37: style:inconclusive: Function 'Action_Buy' argument 2 names different: declaration 'slot' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:667:33: note: Function 'Action_Buy' argument 2 names different: declaration 'slot' definition 's'. lordsawar-0.3.2/src/action.cpp:954:37: note: Function 'Action_Buy' argument 2 names different: declaration 'slot' definition 's'. lordsawar-0.3.2/src/action.cpp:954:57: style:inconclusive: Function 'Action_Buy' argument 3 names different: declaration 'prod' definition 'p'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:667:56: note: Function 'Action_Buy' argument 3 names different: declaration 'prod' definition 'p'. lordsawar-0.3.2/src/action.cpp:954:57: note: Function 'Action_Buy' argument 3 names different: declaration 'prod' definition 'p'. lordsawar-0.3.2/src/action.cpp:959:42: style:inconclusive: Function 'Action_Buy' argument 1 names different: declaration 'action' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:669:31: note: Function 'Action_Buy' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:959:42: note: Function 'Action_Buy' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:1028:37: style:inconclusive: Function 'Action_Reward' argument 1 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:746:30: note: Function 'Action_Reward' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/action.cpp:1028:37: note: Function 'Action_Reward' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/action.cpp:1167:49: style:inconclusive: Function 'Action_Quest' argument 1 names different: declaration 'action' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:783:36: note: Function 'Action_Quest' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:1167:49: note: Function 'Action_Quest' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:1206:34: style:inconclusive: Function 'Action_Equip' argument 1 names different: declaration 'hero' definition 'h'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:832:28: note: Function 'Action_Equip' argument 1 names different: declaration 'hero' definition 'h'. lordsawar-0.3.2/src/action.cpp:1206:34: note: Function 'Action_Equip' argument 1 names different: declaration 'hero' definition 'h'. lordsawar-0.3.2/src/action.cpp:1206:43: style:inconclusive: Function 'Action_Equip' argument 2 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:832:40: note: Function 'Action_Equip' argument 2 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/action.cpp:1206:43: note: Function 'Action_Equip' argument 2 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/action.cpp:1212:49: style:inconclusive: Function 'Action_Equip' argument 1 names different: declaration 'action' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:834:36: note: Function 'Action_Equip' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:1212:49: note: Function 'Action_Equip' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:1324:75: style:inconclusive: Function 'Action_ModifySignpost' argument 1 names different: declaration 'action' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:916:53: note: Function 'Action_ModifySignpost' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:1324:75: note: Function 'Action_ModifySignpost' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:1554:54: style:inconclusive: Function 'Action_Produce' argument 1 names different: declaration 'action' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:1140:39: note: Function 'Action_Produce' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:1554:54: note: Function 'Action_Produce' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:1626:73: style:inconclusive: Function 'Action_ProduceVectored' argument 4 names different: declaration 'target_army_id' definition 'aid'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:1203:57: note: Function 'Action_ProduceVectored' argument 4 names different: declaration 'target_army_id' definition 'aid'. lordsawar-0.3.2/src/action.cpp:1626:73: note: Function 'Action_ProduceVectored' argument 4 names different: declaration 'target_army_id' definition 'aid'. lordsawar-0.3.2/src/action.cpp:1627:56: style:inconclusive: Function 'Action_ProduceVectored' argument 5 names different: declaration 'target_stack_id' definition 'sid'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:1204:40: note: Function 'Action_ProduceVectored' argument 5 names different: declaration 'target_stack_id' definition 'sid'. lordsawar-0.3.2/src/action.cpp:1627:56: note: Function 'Action_ProduceVectored' argument 5 names different: declaration 'target_stack_id' definition 'sid'. lordsawar-0.3.2/src/action.cpp:1635:78: style:inconclusive: Function 'Action_ProduceVectored' argument 1 names different: declaration 'action' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:1206:55: note: Function 'Action_ProduceVectored' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:1635:78: note: Function 'Action_ProduceVectored' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:1706:75: style:inconclusive: Function 'Action_DiplomacyState' argument 1 names different: declaration 'action' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:1262:53: note: Function 'Action_DiplomacyState' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:1706:75: note: Function 'Action_DiplomacyState' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:1755:84: style:inconclusive: Function 'Action_DiplomacyProposal' argument 1 names different: declaration 'action' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:1305:59: note: Function 'Action_DiplomacyProposal' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:1755:84: note: Function 'Action_DiplomacyProposal' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:1802:75: style:inconclusive: Function 'Action_DiplomacyScore' argument 1 names different: declaration 'action' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:1350:53: note: Function 'Action_DiplomacyScore' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:1802:75: note: Function 'Action_DiplomacyScore' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:1914:66: style:inconclusive: Function 'Action_RecruitHero' argument 1 names different: declaration 'action' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:1431:47: note: Function 'Action_RecruitHero' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:1914:66: note: Function 'Action_RecruitHero' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:2065:45: style:inconclusive: Function 'Action_Loot' argument 1 names different: declaration 'action' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:1558:33: note: Function 'Action_Loot' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:2065:45: note: Function 'Action_Loot' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:2121:54: style:inconclusive: Function 'Action_UseItem' argument 1 names different: declaration 'action' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:1595:39: note: Function 'Action_UseItem' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:2121:54: note: Function 'Action_UseItem' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:2173:72: style:inconclusive: Function 'Action_ReorderArmies' argument 1 names different: declaration 'action' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/action.h:1641:51: note: Function 'Action_ReorderArmies' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:2173:72: note: Function 'Action_ReorderArmies' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/action.cpp:2286:70: warning: Function 'Action_CollectTaxesAndPayUpkeep' argument order different: declaration 'toGold, fromGold' definition 'fromGold, toGold' [funcArgOrderDifferent] lordsawar-0.3.2/src/action.h:1732:45: note: Function 'Action_CollectTaxesAndPayUpkeep' argument order different: declaration 'toGold, fromGold' definition 'fromGold, toGold' lordsawar-0.3.2/src/action.cpp:2286:70: note: Function 'Action_CollectTaxesAndPayUpkeep' argument order different: declaration 'toGold, fromGold' definition 'fromGold, toGold' lordsawar-0.3.2/src/action.cpp:750:5: warning:inconclusive: Found suspicious operator '+', result is not used. [constStatement] lordsawar-0.3.2/src/action.cpp:645:72: performance: Function parameter 'stack_ids' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/action.cpp:1427:57: performance: Function parameter 'order' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/action.cpp:352:33: style: Parameter 's' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:725:32: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:725:42: style: Parameter 'explorers' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:773:38: style: Parameter 't' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:773:48: style: Parameter 's' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:809:36: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:838:38: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:867:32: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:896:32: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:925:38: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:954:30: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:992:44: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:1028:48: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:1087:20: style: Variable 'r' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/action.cpp:1092:21: style: Variable 'r' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/action.cpp:1097:20: style: Variable 'r' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/action.cpp:1102:20: style: Variable 'r' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/action.cpp:1107:18: style: Variable 'r' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/action.cpp:1206:34: style: Parameter 'h' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:1206:43: style: Parameter 'i' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:1255:34: style: Parameter 'unit' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:1290:39: style: Parameter 's' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:1319:57: style: Parameter 's' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:1354:44: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:1389:36: style: Parameter 'src' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:1510:34: style: Parameter 'hero' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:1510:46: style: Parameter 'item' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:1545:64: style: Parameter 'city' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:1699:54: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:1747:60: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:1797:54: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:1865:46: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:1894:60: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:1989:64: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:2057:34: style: Parameter 'looting_player' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:2057:58: style: Parameter 'looted_player' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:2104:38: style: Parameter 'hero' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:2104:50: style: Parameter 'item' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:2104:64: style: Parameter 'victim' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:2104:78: style: Parameter 'friendly_city' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:2104:99: style: Parameter 'enemy_city' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:2104:117: style: Parameter 'neutral_city' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:2104:137: style: Parameter 'city' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:2226:48: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:2350:47: style: Parameter 's' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:2379:51: style: Parameter 's' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:2408:43: style: Parameter 's' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:2437:47: style: Parameter 's' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:2466:47: style: Parameter 's' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/action.cpp:490:25: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/action.cpp:492:25: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/action.cpp:656:9: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/action.cpp:508:14: style: Variable 'ival' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/action.cpp:2189:12: style: Variable 'ival' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/action.cpp:417:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/action.cpp:481:45: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/action.cpp:486:45: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/action.cpp:562:61: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/action.cpp:565:61: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/action.cpp:587:63: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/action.cpp:592:63: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/action.cpp:608:37: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/action.cpp:622:82: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/action.cpp:653:75: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/action.cpp:1447:59: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/action.cpp:1470:29: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/action.cpp:2169:55: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/action.cpp:2203:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/ai_dummy.cpp:143:50: style:inconclusive: Function 'chooseHero' argument 2 names different: declaration 'c' definition 'city'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ai_dummy.h:69:56: note: Function 'chooseHero' argument 2 names different: declaration 'c' definition 'city'. lordsawar-0.3.2/src/ai_dummy.cpp:143:50: note: Function 'chooseHero' argument 2 names different: declaration 'c' definition 'city'. lordsawar-0.3.2/src/ai_dummy.cpp:81:35: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/ai_smart.cpp:324:54: style:inconclusive: Function 'scoreQuickArmyType' argument 1 names different: declaration 'proto' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ai_smart.h:127:52: note: Function 'scoreQuickArmyType' argument 1 names different: declaration 'proto' definition 'a'. lordsawar-0.3.2/src/ai_smart.cpp:324:54: note: Function 'scoreQuickArmyType' argument 1 names different: declaration 'proto' definition 'a'. lordsawar-0.3.2/src/ai_smart.cpp:333:51: style:inconclusive: Function 'scoreQuickArmyType' argument 1 names different: declaration 'proto' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ai_smart.h:129:49: note: Function 'scoreQuickArmyType' argument 1 names different: declaration 'proto' definition 'a'. lordsawar-0.3.2/src/ai_smart.cpp:333:51: note: Function 'scoreQuickArmyType' argument 1 names different: declaration 'proto' definition 'a'. lordsawar-0.3.2/src/ai_smart.cpp:342:50: style:inconclusive: Function 'scoreBestArmyType' argument 1 names different: declaration 'proto' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ai_smart.h:123:48: note: Function 'scoreBestArmyType' argument 1 names different: declaration 'proto' definition 'a'. lordsawar-0.3.2/src/ai_smart.cpp:342:50: note: Function 'scoreBestArmyType' argument 1 names different: declaration 'proto' definition 'a'. lordsawar-0.3.2/src/ai_smart.cpp:412:36: style:inconclusive: Function 'setProduction' argument 1 names different: declaration 'c' definition 'city'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ai_smart.h:117:34: note: Function 'setProduction' argument 1 names different: declaration 'c' definition 'city'. lordsawar-0.3.2/src/ai_smart.cpp:412:36: note: Function 'setProduction' argument 1 names different: declaration 'c' definition 'city'. lordsawar-0.3.2/src/ai_smart.cpp:470:50: style:inconclusive: Function 'chooseHero' argument 2 names different: declaration 'c' definition 'city'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ai_smart.h:97:56: note: Function 'chooseHero' argument 2 names different: declaration 'c' definition 'city'. lordsawar-0.3.2/src/ai_smart.cpp:470:50: note: Function 'chooseHero' argument 2 names different: declaration 'c' definition 'city'. lordsawar-0.3.2/src/ai_smart.cpp:550:11: style: Local variable 'dist' shadows outer function [shadowFunction] lordsawar-0.3.2/src/vector.h:180:10: note: Shadowed declaration lordsawar-0.3.2/src/ai_smart.cpp:550:11: note: Shadow variable lordsawar-0.3.2/src/ai_smart.cpp:94:13: style: Variable 'first_neutral' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/ai_smart.cpp:209:14: style: Variable 'army' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/ai_smart.cpp:532:9: style: Variable 'enemy' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/ai_smart.cpp:537:9: style: Variable 'c' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/ai_smart.cpp:399:77: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/ai_smart.cpp:444:76: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/ai_smart.cpp:484:62: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/ai_smart.cpp:557:12: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/ai_fast.cpp:663:39: style:inconclusive: Boolean expression 'stack_moved' is used in bitwise operation. [bitwiseOnBoolean] lordsawar-0.3.2/src/ai_fast.cpp:209:6: style: The statement 'if (found) found=false' is logically equivalent to 'found=false'. [duplicateConditionalAssign] lordsawar-0.3.2/src/ai_fast.cpp:210:10: note: Assignment 'found=false' lordsawar-0.3.2/src/ai_fast.cpp:209:6: note: Condition 'found' is redundant lordsawar-0.3.2/src/ai_fast.cpp:209:6: style: Condition 'found' is always true [knownConditionTrueFalse] lordsawar-0.3.2/src/ai_fast.cpp:207:6: note: Assuming that condition '!found' is not redundant lordsawar-0.3.2/src/ai_fast.cpp:209:6: note: Condition 'found' is always true lordsawar-0.3.2/src/ai_fast.cpp:462:33: style: Condition 's->hasHero()==true' is always true [knownConditionTrueFalse] lordsawar-0.3.2/src/ai_fast.cpp:448:28: note: Assuming that condition 's->hasHero()==false' is not redundant lordsawar-0.3.2/src/ai_fast.cpp:462:33: note: Condition 's->hasHero()==true' is always true lordsawar-0.3.2/src/ai_fast.cpp:447:16: style: The scope of the variable 'blessed' can be reduced. [variableScope] lordsawar-0.3.2/src/ai_fast.cpp:353:47: style:inconclusive: Function 'findNearOwnStackToJoin' argument 1 names different: declaration 's' definition 'src'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ai_fast.h:109:39: note: Function 'findNearOwnStackToJoin' argument 1 names different: declaration 's' definition 'src'. lordsawar-0.3.2/src/ai_fast.cpp:353:47: note: Function 'findNearOwnStackToJoin' argument 1 names different: declaration 's' definition 'src'. lordsawar-0.3.2/src/ai_fast.cpp:811:49: style:inconclusive: Function 'chooseHero' argument 2 names different: declaration 'c' definition 'city'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ai_fast.h:92:56: note: Function 'chooseHero' argument 2 names different: declaration 'c' definition 'city'. lordsawar-0.3.2/src/ai_fast.cpp:811:49: note: Function 'chooseHero' argument 2 names different: declaration 'c' definition 'city'. lordsawar-0.3.2/src/ai_fast.cpp:429:17: style: Variable 'enemy' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/ai_fast.cpp:511:20: style: Variable 'target' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/ai_fast.cpp:738:21: style: Variable 'enemy_city' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/ai_fast.cpp:769:21: style: Variable 'friendly_city' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/ai_fast.cpp:210:10: style: Variable 'found' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/ai_fast.cpp:164:71: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/ai_fast.cpp:186:90: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/ai_fast.cpp:708:60: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/ai_fast.cpp:825:62: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armybase.cpp:279:21: style: Condition 'first' is always true [knownConditionTrueFalse] lordsawar-0.3.2/src/armybase.cpp:276:24: note: Assignment 'first=true', assigned value is 1 lordsawar-0.3.2/src/armybase.cpp:279:21: note: Condition 'first' is always true lordsawar-0.3.2/src/armybase.cpp:32:36: style:inconclusive: Function 'ArmyBase' argument 1 names different: declaration 'army' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/armybase.h:99:34: note: Function 'ArmyBase' argument 1 names different: declaration 'army' definition 'a'. lordsawar-0.3.2/src/armybase.cpp:32:36: note: Function 'ArmyBase' argument 1 names different: declaration 'army' definition 'a'. lordsawar-0.3.2/src/armybase.cpp:148:57: style:inconclusive: Function 'moveFlagsToString' argument 1 names different: declaration 'move_bonus' definition 'bonus'. [funcArgNamesDifferent] lordsawar-0.3.2/src/armybase.h:207:55: note: Function 'moveFlagsToString' argument 1 names different: declaration 'move_bonus' definition 'bonus'. lordsawar-0.3.2/src/armybase.cpp:148:57: note: Function 'moveFlagsToString' argument 1 names different: declaration 'move_bonus' definition 'bonus'. lordsawar-0.3.2/src/armybase.cpp:305:21: style: Variable 'first' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/army.cpp:116:7: warning: Member variable 'Army::d_medal_bonus' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/army.cpp:355:12: warning: The class 'Army' defines member function with name 'saveData' also defined in its parent class 'ArmyBase'. [duplInheritedMember] lordsawar-0.3.2/src/armybase.h:212:14: note: Parent function 'ArmyBase::saveData' lordsawar-0.3.2/src/army.cpp:355:12: note: Derived function 'Army::saveData' lordsawar-0.3.2/src/army.cpp:135:7: style: The scope of the variable 'ival' can be reduced. [variableScope] lordsawar-0.3.2/src/army.cpp:43:24: style:inconclusive: Function 'Army' argument 1 names different: declaration 'army' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/army.h:107:26: note: Function 'Army' argument 1 names different: declaration 'army' definition 'a'. lordsawar-0.3.2/src/army.cpp:43:24: note: Function 'Army' argument 1 names different: declaration 'army' definition 'a'. lordsawar-0.3.2/src/army.cpp:43:35: style:inconclusive: Function 'Army' argument 2 names different: declaration 'owner' definition 'p'. [funcArgNamesDifferent] lordsawar-0.3.2/src/army.h:107:40: note: Function 'Army' argument 2 names different: declaration 'owner' definition 'p'. lordsawar-0.3.2/src/army.cpp:43:35: note: Function 'Army' argument 2 names different: declaration 'owner' definition 'p'. lordsawar-0.3.2/src/army.cpp:58:29: style:inconclusive: Function 'Army' argument 1 names different: declaration 'armyproto' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/army.h:104:31: note: Function 'Army' argument 1 names different: declaration 'armyproto' definition 'a'. lordsawar-0.3.2/src/army.cpp:58:29: note: Function 'Army' argument 1 names different: declaration 'armyproto' definition 'a'. lordsawar-0.3.2/src/army.cpp:58:40: style:inconclusive: Function 'Army' argument 2 names different: declaration 'owner' definition 'p'. [funcArgNamesDifferent] lordsawar-0.3.2/src/army.h:104:50: note: Function 'Army' argument 2 names different: declaration 'owner' definition 'p'. lordsawar-0.3.2/src/army.cpp:58:40: note: Function 'Army' argument 2 names different: declaration 'owner' definition 'p'. lordsawar-0.3.2/src/army.cpp:70:52: style:inconclusive: Function 'Army' argument 3 names different: declaration 'player' definition 'p'. [funcArgNamesDifferent] lordsawar-0.3.2/src/army.h:502:47: note: Function 'Army' argument 3 names different: declaration 'player' definition 'p'. lordsawar-0.3.2/src/army.cpp:70:52: note: Function 'Army' argument 3 names different: declaration 'player' definition 'p'. lordsawar-0.3.2/src/army.cpp:82:55: style:inconclusive: Function 'Army' argument 3 names different: declaration 'player' definition 'p'. [funcArgNamesDifferent] lordsawar-0.3.2/src/army.h:504:50: note: Function 'Army' argument 3 names different: declaration 'player' definition 'p'. lordsawar-0.3.2/src/army.cpp:82:55: note: Function 'Army' argument 3 names different: declaration 'player' definition 'p'. lordsawar-0.3.2/src/army.cpp:94:61: style:inconclusive: Function 'createNonUniqueArmy' argument 2 names different: declaration 'p' definition 'player'. [funcArgNamesDifferent] lordsawar-0.3.2/src/army.h:134:63: note: Function 'createNonUniqueArmy' argument 2 names different: declaration 'p' definition 'player'. lordsawar-0.3.2/src/army.cpp:94:61: note: Function 'createNonUniqueArmy' argument 2 names different: declaration 'p' definition 'player'. lordsawar-0.3.2/src/army.cpp:99:64: style:inconclusive: Function 'createNonUniqueArmy' argument 2 names different: declaration 'p' definition 'player'. [funcArgNamesDifferent] lordsawar-0.3.2/src/army.h:135:66: note: Function 'createNonUniqueArmy' argument 2 names different: declaration 'p' definition 'player'. lordsawar-0.3.2/src/army.cpp:99:64: note: Function 'createNonUniqueArmy' argument 2 names different: declaration 'p' definition 'player'. lordsawar-0.3.2/src/army.cpp:104:32: style:inconclusive: Function 'Army' argument 1 names different: declaration 'armyprodbase' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/army.h:101:34: note: Function 'Army' argument 1 names different: declaration 'armyprodbase' definition 'a'. lordsawar-0.3.2/src/army.cpp:104:32: note: Function 'Army' argument 1 names different: declaration 'armyprodbase' definition 'a'. lordsawar-0.3.2/src/army.cpp:104:43: style:inconclusive: Function 'Army' argument 2 names different: declaration 'owner' definition 'p'. [funcArgNamesDifferent] lordsawar-0.3.2/src/army.h:101:56: note: Function 'Army' argument 2 names different: declaration 'owner' definition 'p'. lordsawar-0.3.2/src/army.cpp:104:43: note: Function 'Army' argument 2 names different: declaration 'owner' definition 'p'. lordsawar-0.3.2/src/army.cpp:451:35: style:inconclusive: Function 'morph' argument 1 names different: declaration 'armyproto' definition 'army'. [funcArgNamesDifferent] lordsawar-0.3.2/src/army.h:311:30: note: Function 'morph' argument 1 names different: declaration 'armyproto' definition 'army'. lordsawar-0.3.2/src/army.cpp:451:35: note: Function 'morph' argument 1 names different: declaration 'armyproto' definition 'army'. lordsawar-0.3.2/src/army.cpp:426:14: style: Variable 'a' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/army.cpp:435:14: style: Variable 'a' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/army.cpp:444:14: style: Variable 'a' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/army.cpp:135:12: style: Variable 'ival' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/armyprodbase.cpp:43:3: performance: Variable 'd_type_id' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/armyprodbase.cpp:35:48: style:inconclusive: Function 'ArmyProdBase' argument 1 names different: declaration 'prodbase' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/armyprodbase.h:45:42: note: Function 'ArmyProdBase' argument 1 names different: declaration 'prodbase' definition 'a'. lordsawar-0.3.2/src/armyprodbase.cpp:35:48: note: Function 'ArmyProdBase' argument 1 names different: declaration 'prodbase' definition 'a'. lordsawar-0.3.2/src/armyprodbase.cpp:40:45: style:inconclusive: Function 'ArmyProdBase' argument 1 names different: declaration 'prodbase' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/armyprodbase.h:48:39: note: Function 'ArmyProdBase' argument 1 names different: declaration 'prodbase' definition 'a'. lordsawar-0.3.2/src/armyprodbase.cpp:40:45: note: Function 'ArmyProdBase' argument 1 names different: declaration 'prodbase' definition 'a'. lordsawar-0.3.2/src/armymap.h:52:18: style: The function 'after_draw' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:221:18: note: Virtual function in base class lordsawar-0.3.2/src/armymap.h:52:18: note: Function in derived class lordsawar-0.3.2/src/armymap.cpp:48:20: style: Variable 'mytile' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/armymap.cpp:38:49: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armymap.cpp:43:74: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyprotobase.cpp:59:21: warning: The class 'ArmyProtoBase' defines member function with name 'saveData' also defined in its parent class 'ArmyBase'. [duplInheritedMember] lordsawar-0.3.2/src/armybase.h:212:14: note: Parent function 'ArmyBase::saveData' lordsawar-0.3.2/src/armyprotobase.cpp:59:21: note: Derived function 'ArmyProtoBase::saveData' lordsawar-0.3.2/src/armyprotobase.cpp:31:51: style:inconclusive: Function 'ArmyProtoBase' argument 1 names different: declaration 'armyprotobase' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/armyprotobase.h:39:44: note: Function 'ArmyProtoBase' argument 1 names different: declaration 'armyprotobase' definition 'a'. lordsawar-0.3.2/src/armyprotobase.cpp:31:51: note: Function 'ArmyProtoBase' argument 1 names different: declaration 'armyprotobase' definition 'a'. lordsawar-0.3.2/src/armyproto.cpp:120:17: warning: The class 'ArmyProto' defines member function with name 'saveData' also defined in its parent class 'ArmyProtoBase'. [duplInheritedMember] lordsawar-0.3.2/src/armyprotobase.h:111:7: note: Parent function 'ArmyProtoBase::saveData' lordsawar-0.3.2/src/armyproto.cpp:120:17: note: Derived function 'ArmyProto::saveData' lordsawar-0.3.2/src/armyproto.cpp:120:17: warning: The class 'ArmyProto' defines member function with name 'saveData' also defined in its parent class 'ArmyBase'. [duplInheritedMember] lordsawar-0.3.2/src/armybase.h:212:14: note: Parent function 'ArmyBase::saveData' lordsawar-0.3.2/src/armyproto.cpp:120:17: note: Derived function 'ArmyProto::saveData' lordsawar-0.3.2/src/armyproto.cpp:36:39: style:inconclusive: Function 'ArmyProto' argument 1 names different: declaration 'armyproto' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/armyproto.h:43:36: note: Function 'ArmyProto' argument 1 names different: declaration 'armyproto' definition 'a'. lordsawar-0.3.2/src/armyproto.cpp:36:39: note: Function 'ArmyProto' argument 1 names different: declaration 'armyproto' definition 'a'. lordsawar-0.3.2/src/armyproto.cpp:223:44: style:inconclusive: Function 'clearImage' argument 1 names different: declaration 'c' definition 'col'. [funcArgNamesDifferent] lordsawar-0.3.2/src/armyproto.h:70:41: note: Function 'clearImage' argument 1 names different: declaration 'c' definition 'col'. lordsawar-0.3.2/src/armyproto.cpp:223:44: note: Function 'clearImage' argument 1 names different: declaration 'c' definition 'col'. lordsawar-0.3.2/src/armysetlist.cpp:96:53: style:inconclusive: Function 'getArmy' argument 2 names different: declaration 'index' definition 'type_id'. [funcArgNamesDifferent] lordsawar-0.3.2/src/armysetlist.h:65:48: note: Function 'getArmy' argument 2 names different: declaration 'index' definition 'type_id'. lordsawar-0.3.2/src/armysetlist.cpp:96:53: note: Function 'getArmy' argument 2 names different: declaration 'index' definition 'type_id'. lordsawar-0.3.2/src/armysetlist.cpp:114:12: style: Variable 'a' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/armysetlist.cpp:68:73: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armysetlist.cpp:75:73: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armysetlist.cpp:82:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armysetlist.cpp:122:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armysetlist.cpp:132:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armysetlist.cpp:142:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armysetlist.cpp:152:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armysetlist.cpp:162:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armysetlist.cpp:173:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armysetlist.cpp:185:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armysetlist.cpp:191:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:48:3: performance: Variable 'd_bag_name' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/armyset.cpp:49:3: performance: Variable 'd_stackship_name' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/armyset.cpp:50:3: performance: Variable 'd_standard_name' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/armyset.cpp:57:3: performance: Variable 'd_bag_name' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/armyset.cpp:58:3: performance: Variable 'd_stackship_name' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/armyset.cpp:59:3: performance: Variable 'd_standard_name' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/armyset.cpp:433:2: performance: Variable 'dir' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/armyset.cpp:137:15: warning: The class 'Armyset' defines member function with name 'save' also defined in its parent class 'Set'. [duplInheritedMember] lordsawar-0.3.2/src/set.h:87:10: note: Parent function 'Set::save' lordsawar-0.3.2/src/armyset.cpp:137:15: note: Derived function 'Armyset::save' lordsawar-0.3.2/src/armyset.cpp:74:33: style:inconclusive: Function 'Armyset' argument 1 names different: declaration 'armyset' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/armyset.h:85:32: note: Function 'Armyset' argument 1 names different: declaration 'armyset' definition 'a'. lordsawar-0.3.2/src/armyset.cpp:74:33: note: Function 'Armyset' argument 1 names different: declaration 'armyset' definition 'a'. lordsawar-0.3.2/src/armyset.cpp:234:47: style:inconclusive: Function 'lookupArmyByType' argument 1 names different: declaration 'army_type' definition 'army_type_id'. [funcArgNamesDifferent] lordsawar-0.3.2/src/armyset.h:184:39: note: Function 'lookupArmyByType' argument 1 names different: declaration 'army_type' definition 'army_type_id'. lordsawar-0.3.2/src/armyset.cpp:234:47: note: Function 'lookupArmyByType' argument 1 names different: declaration 'army_type' definition 'army_type_id'. lordsawar-0.3.2/src/armyset.cpp:329:48: style:inconclusive: Function 'validateArmyUnitImage' argument 1 names different: declaration 'a' definition 'army'. [funcArgNamesDifferent] lordsawar-0.3.2/src/armyset.h:206:40: note: Function 'validateArmyUnitImage' argument 1 names different: declaration 'a' definition 'army'. lordsawar-0.3.2/src/armyset.cpp:329:48: note: Function 'validateArmyUnitImage' argument 1 names different: declaration 'a' definition 'army'. lordsawar-0.3.2/src/armyset.cpp:350:47: style:inconclusive: Function 'validateArmyUnitName' argument 1 names different: declaration 'a' definition 'army'. [funcArgNamesDifferent] lordsawar-0.3.2/src/armyset.h:208:39: note: Function 'validateArmyUnitName' argument 1 names different: declaration 'a' definition 'army'. lordsawar-0.3.2/src/armyset.cpp:350:47: note: Function 'validateArmyUnitName' argument 1 names different: declaration 'a' definition 'army'. lordsawar-0.3.2/src/armyset.cpp:482:56: style:inconclusive: Function 'create' argument 2 names different: declaration 'unsupported' definition 'unsupported_version'. [funcArgNamesDifferent] lordsawar-0.3.2/src/armyset.h:87:55: note: Function 'create' argument 2 names different: declaration 'unsupported' definition 'unsupported_version'. lordsawar-0.3.2/src/armyset.cpp:482:56: note: Function 'create' argument 2 names different: declaration 'unsupported' definition 'unsupported_version'. lordsawar-0.3.2/src/armyset.cpp:917:40: style:inconclusive: Function 'copy' argument 1 names different: declaration 'orig' definition 'armyset'. [funcArgNamesDifferent] lordsawar-0.3.2/src/armyset.h:89:46: note: Function 'copy' argument 1 names different: declaration 'orig' definition 'armyset'. lordsawar-0.3.2/src/armyset.cpp:917:40: note: Function 'copy' argument 1 names different: declaration 'orig' definition 'armyset'. lordsawar-0.3.2/src/armyset.cpp:619:12: style: Variable 'old_armyset' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/armyset.cpp:621:14: style: Variable 'old_armyproto' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/armyset.cpp:658:12: style: Variable 'old_armyset' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/armyset.cpp:663:14: style: Variable 'new_armyproto' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/armyset.cpp:731:12: style: Variable 'old_armyset' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/armyset.cpp:736:14: style: Variable 'new_armyproto' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/armyset.cpp:876:18: style: Variable 'a' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/armyset.cpp:98:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:105:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:149:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:159:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:171:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:181:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:194:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:203:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:226:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:236:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:248:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:264:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:280:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:296:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:342:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:358:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:368:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:533:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:815:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:832:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:853:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:856:70: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:874:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:883:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:927:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/armyset.cpp:1070:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/bridgelist.cpp:128:11: style: Variable 'other' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/bridgelist.cpp:70:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/bigmap.cpp:68:5: performance: Variable 'view_pos' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/bigmap.h:59:5: style: Class 'BigMap' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/bigmap.cpp:658:44: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/bigmap.cpp:309:7: style: The scope of the variable 'tilesize' can be reduced. [variableScope] lordsawar-0.3.2/src/bigmap.cpp:84:35: style:inconclusive: Function 'set_view' argument 1 names different: declaration 'rect' definition 'new_view'. [funcArgNamesDifferent] lordsawar-0.3.2/src/bigmap.h:68:31: note: Function 'set_view' argument 1 names different: declaration 'rect' definition 'new_view'. lordsawar-0.3.2/src/bigmap.cpp:84:35: note: Function 'set_view' argument 1 names different: declaration 'rect' definition 'new_view'. lordsawar-0.3.2/src/bigmap.cpp:295:74: style:inconclusive: Function 'blit_object' argument 3 names different: declaration 'image' definition 'im'. [funcArgNamesDifferent] lordsawar-0.3.2/src/bigmap.h:131:70: note: Function 'blit_object' argument 3 names different: declaration 'image' definition 'im'. lordsawar-0.3.2/src/bigmap.cpp:295:74: note: Function 'blit_object' argument 3 names different: declaration 'image' definition 'im'. lordsawar-0.3.2/src/bigmap.cpp:84:35: performance: Function parameter 'new_view' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/bigmap.cpp:247:53: performance: Function parameter 'tile_area' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/bigmap.cpp:623:44: performance: Function parameter 'map_view' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/bigmap.cpp:631:38: performance: Function parameter 'map_view' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/bigmap.cpp:342:17: style: Variable 'tile' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/bigmap.cpp:372:22: style: Variable 'st' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/bigmap.cpp:436:11: style: Variable 'viewing' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/bigmap.cpp:476:13: style: Variable 'flag' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/bigmap.cpp:499:17: style: Variable 'm' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/bigmap.cpp:533:14: style: Variable 'city' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/bigmap.cpp:544:14: style: Variable 'ruin' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/bigmap.cpp:566:16: style: Variable 'temple' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/bigmap.cpp:573:18: style: Variable 'signpost' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/bigmap.cpp:579:14: style: Variable 'road' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/bigmap.cpp:582:22: style: Variable 'stone' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/bigmap.cpp:589:22: style: Variable 'stone' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/bigmap.cpp:597:14: style: Variable 'port' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/bigmap.cpp:603:16: style: Variable 'bridge' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/city.cpp:123:12: warning: The class 'City' defines member function with name 'save' also defined in its parent class 'ProdSlotlist'. [duplInheritedMember] lordsawar-0.3.2/src/prodslotlist.h:93:14: note: Parent function 'ProdSlotlist::save' lordsawar-0.3.2/src/city.cpp:123:12: note: Derived function 'City::save' lordsawar-0.3.2/src/vectoredunit.h:68:9: style: Class 'VectoredUnit' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/vectoredunit.h:71:10: style: The destructor '~VectoredUnit' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Ownable.h:45:14: note: Virtual destructor in base class lordsawar-0.3.2/src/vectoredunit.h:71:10: note: Destructor in derived class lordsawar-0.3.2/src/city.cpp:527:33: style: Expression is always true because 'else if' condition is opposite to previous condition at line 522. [multiCondition] lordsawar-0.3.2/src/city.cpp:522:33: note: first condition lordsawar-0.3.2/src/city.cpp:527:33: note: else if condition is opposite to first condition lordsawar-0.3.2/src/city.cpp:524:33: style: Condition 'num_production_bases>2' is always true [knownConditionTrueFalse] lordsawar-0.3.2/src/city.cpp:522:33: note: Assuming that condition 'num_production_bases<=2' is not redundant lordsawar-0.3.2/src/city.cpp:524:33: note: Condition 'num_production_bases>2' is always true lordsawar-0.3.2/src/citylist.cpp:183:11: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/citylist.cpp:188:11: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/citylist.cpp:193:11: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/citylist.cpp:198:11: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/citylist.cpp:203:11: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/citylist.cpp:211:17: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/citylist.cpp:220:14: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/city.cpp:283:37: style:inconclusive: Function 'setVectoring' argument 1 names different: declaration 'pos' definition 'p'. [funcArgNamesDifferent] lordsawar-0.3.2/src/city.h:162:39: note: Function 'setVectoring' argument 1 names different: declaration 'pos' definition 'p'. lordsawar-0.3.2/src/city.cpp:283:37: note: Function 'setVectoring' argument 1 names different: declaration 'pos' definition 'p'. lordsawar-0.3.2/src/city.cpp:554:14: style: Variable 's' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/citylist.cpp:95:35: style:inconclusive: Function 'countCities' argument 1 names different: declaration 'p' definition 'player'. [funcArgNamesDifferent] lordsawar-0.3.2/src/citylist.h:97:33: note: Function 'countCities' argument 1 names different: declaration 'p' definition 'player'. lordsawar-0.3.2/src/citylist.cpp:95:35: note: Function 'countCities' argument 1 names different: declaration 'p' definition 'player'. lordsawar-0.3.2/src/citylist.cpp:463:38: style:inconclusive: Function 'stopVectoringTo' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/citylist.h:69:29: note: Function 'stopVectoringTo' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/citylist.cpp:463:38: note: Function 'stopVectoringTo' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/citylist.cpp:208:11: style: Variable 'p' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/citylist.cpp:211:9: style: Variable 'city' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/citylist.cpp:220:9: style: Variable 'c' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/citylist.cpp:525:13: style: Variable 'c' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/citylist.cpp:85:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/citylist.cpp:99:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/citylist.cpp:112:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/citylist.cpp:122:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/citylist.cpp:154:43: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/citylist.cpp:173:46: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/citylist.cpp:427:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/citylist.cpp:449:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/citylist.cpp:465:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/citylist.cpp:479:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/citylist.cpp:492:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/citylist.cpp:503:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/citylist.cpp:523:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/citylist.cpp:538:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/citylist.cpp:554:76: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/citylist.cpp:566:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/citylist.cpp:570:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/citylist.cpp:572:38: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/citylist.cpp:594:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/citylist.cpp:607:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/citylist.cpp:618:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/city.cpp:366:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/city.cpp:415:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/city.cpp:548:75: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/citymap.h:38:6: style: The destructor '~CityMap' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:63:15: note: Virtual destructor in base class lordsawar-0.3.2/src/citymap.h:38:6: note: Destructor in derived class lordsawar-0.3.2/src/citymap.h:52:18: style: The function 'after_draw' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:221:18: note: Virtual function in base class lordsawar-0.3.2/src/citymap.h:52:18: note: Function in derived class lordsawar-0.3.2/src/citysetlist.cpp:61:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/citysetlist.cpp:69:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/citysetlist.cpp:81:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/cityset.cpp:43:2: performance: Variable 'd_cities_filename' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/cityset.cpp:44:2: performance: Variable 'd_razedcities_filename' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/cityset.cpp:45:2: performance: Variable 'd_port_filename' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/cityset.cpp:46:2: performance: Variable 'd_signpost_filename' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/cityset.cpp:47:2: performance: Variable 'd_ruins_filename' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/cityset.cpp:48:2: performance: Variable 'd_temples_filename' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/cityset.cpp:49:2: performance: Variable 'd_towers_filename' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/cityset.cpp:179:2: performance: Variable 'dir' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/cityset.cpp:251:15: warning: The class 'Cityset' defines member function with name 'save' also defined in its parent class 'Set'. [duplInheritedMember] lordsawar-0.3.2/src/set.h:87:10: note: Parent function 'Set::save' lordsawar-0.3.2/src/cityset.cpp:251:15: note: Derived function 'Cityset::save' lordsawar-0.3.2/src/connection-manager.cpp:48:42: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/cityset.cpp:237:58: style:inconclusive: Function 'save' argument 2 names different: declaration 'extension' definition 'ext'. [funcArgNamesDifferent] lordsawar-0.3.2/src/cityset.h:84:57: note: Function 'save' argument 2 names different: declaration 'extension' definition 'ext'. lordsawar-0.3.2/src/cityset.cpp:237:58: note: Function 'save' argument 2 names different: declaration 'extension' definition 'ext'. lordsawar-0.3.2/src/cityset.cpp:685:39: style:inconclusive: Function 'copy' argument 1 names different: declaration 'orig' definition 'cityset'. [funcArgNamesDifferent] lordsawar-0.3.2/src/cityset.h:78:46: note: Function 'copy' argument 1 names different: declaration 'orig' definition 'cityset'. lordsawar-0.3.2/src/cityset.cpp:685:39: note: Function 'copy' argument 1 names different: declaration 'orig' definition 'cityset'. lordsawar-0.3.2/src/editor/RenamableLocation.h:32:6: style: Class 'RenamableLocation' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/cityset.cpp:631:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/select-item-dialog.h:31:5: style: Class 'SelectItemDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/editor/backpack-editor-dialog.cpp:35:75: style:inconclusive: Function 'BackpackEditorDialog' argument 2 names different: declaration 'backpack' definition 'pack'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/backpack-editor-dialog.h:32:57: note: Function 'BackpackEditorDialog' argument 2 names different: declaration 'backpack' definition 'pack'. lordsawar-0.3.2/src/editor/backpack-editor-dialog.cpp:35:75: note: Function 'BackpackEditorDialog' argument 2 names different: declaration 'backpack' definition 'pack'. lordsawar-0.3.2/src/editor/battle-calculator-dialog.cpp:135:12: style: Variable 'tileset' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/editor/battle-calculator-dialog.cpp:514:13: style: Variable 's' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/editor/battle-calculator-dialog.cpp:517:13: style: Variable 's' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/editor/battle-calculator-dialog.cpp:522:13: style: Variable 's' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/editor/city-editor-dialog.cpp:221:23: style: The scope of the variable 'army' can be reduced. [variableScope] lordsawar-0.3.2/src/editor/city-editor-dialog.cpp:43:63: style:inconclusive: Function 'CityEditorDialog' argument 2 names different: declaration 'city' definition 'cit'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/city-editor-dialog.h:35:49: note: Function 'CityEditorDialog' argument 2 names different: declaration 'city' definition 'cit'. lordsawar-0.3.2/src/editor/city-editor-dialog.cpp:43:63: note: Function 'CityEditorDialog' argument 2 names different: declaration 'city' definition 'cit'. lordsawar-0.3.2/src/editor/city-editor-dialog.cpp:148:11: style: Variable 'player' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/editor/city-editor-dialog.cpp:431:11: style: Variable 'player' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/editor/cityset-info-dialog.cpp:31:68: style:inconclusive: Function 'CitySetInfoDialog' argument 2 names different: declaration 'cityset' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/cityset-info-dialog.h:30:53: note: Function 'CitySetInfoDialog' argument 2 names different: declaration 'cityset' definition 'c'. lordsawar-0.3.2/src/editor/cityset-info-dialog.cpp:31:68: note: Function 'CitySetInfoDialog' argument 2 names different: declaration 'cityset' definition 'c'. lordsawar-0.3.2/src/editor/armyset-window.h:36:5: style: Class 'ArmySetWindow' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/editor/editor-quit-dialog.h:28:5: style: Class 'EditorQuitDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/editor/armyset-window.cpp:1011:54: style:inconclusive: Function 'instantiateOthers' argument 3 names different: declaration 'f' definition 'filename'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/armyset-window.h:213:75: note: Function 'instantiateOthers' argument 3 names different: declaration 'f' definition 'filename'. lordsawar-0.3.2/src/editor/armyset-window.cpp:1011:54: note: Function 'instantiateOthers' argument 3 names different: declaration 'f' definition 'filename'. lordsawar-0.3.2/src/editor/armyset-window.cpp:520:75: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/armyset-window.cpp:540:8: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/armyset-window.cpp:1725:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/editablesmallmap.cpp:35:19: warning: Member variable 'EditableSmallMap::pointer' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/editor/editablesmallmap.cpp:35:19: warning: Member variable 'EditableSmallMap::pointer_size' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/editor/editablesmallmap.cpp:37:3: performance: Variable 'road_start' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/editor/editablesmallmap.cpp:38:3: performance: Variable 'road_finish' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/editor/editablesmallmap.cpp:60:47: style:inconclusive: Function 'change_map' argument 1 names different: declaration 'pos' definition 'tile'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/editablesmallmap.h:104:33: note: Function 'change_map' argument 1 names different: declaration 'pos' definition 'tile'. lordsawar-0.3.2/src/editor/editablesmallmap.cpp:60:47: note: Function 'change_map' argument 1 names different: declaration 'pos' definition 'tile'. lordsawar-0.3.2/src/editor/editablesmallmap.cpp:149:44: style:inconclusive: Function 'set_pointer' argument 1 names different: declaration 'pointer' definition 'p'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/editablesmallmap.h:62:30: note: Function 'set_pointer' argument 1 names different: declaration 'pointer' definition 'p'. lordsawar-0.3.2/src/editor/editablesmallmap.cpp:149:44: note: Function 'set_pointer' argument 1 names different: declaration 'pointer' definition 'p'. lordsawar-0.3.2/src/editor/editablesmallmap.cpp:149:68: style:inconclusive: Function 'set_pointer' argument 3 names different: declaration 'terrain' definition 't'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/editablesmallmap.h:62:60: note: Function 'set_pointer' argument 3 names different: declaration 'terrain' definition 't'. lordsawar-0.3.2/src/editor/editablesmallmap.cpp:149:68: note: Function 'set_pointer' argument 3 names different: declaration 'terrain' definition 't'. lordsawar-0.3.2/src/editor/editablesmallmap.cpp:269:56: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/cityset-window.h:34:5: style: Class 'CitySetWindow' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/editor/cityset-window.cpp:230:21: style: Condition 'msgs.empty()==true' is always true [knownConditionTrueFalse] lordsawar-0.3.2/src/editor/cityset-window.cpp:228:17: note: Assuming condition is false lordsawar-0.3.2/src/editor/cityset-window.cpp:230:21: note: Condition 'msgs.empty()==true' is always true lordsawar-0.3.2/src/editor/cityset-window.cpp:749:57: style:inconclusive: Function 'change_image' argument 1 names different: declaration 'm' definition 'msg'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/cityset-window.h:100:47: note: Function 'change_image' argument 1 names different: declaration 'm' definition 'msg'. lordsawar-0.3.2/src/editor/cityset-window.cpp:749:57: note: Function 'change_image' argument 1 names different: declaration 'm' definition 'msg'. lordsawar-0.3.2/src/editor/cityset-window.cpp:749:76: style:inconclusive: Function 'change_image' argument 2 names different: declaration 'i' definition 'imgname'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/cityset-window.h:100:64: note: Function 'change_image' argument 2 names different: declaration 'i' definition 'imgname'. lordsawar-0.3.2/src/editor/cityset-window.cpp:749:76: note: Function 'change_image' argument 2 names different: declaration 'i' definition 'imgname'. lordsawar-0.3.2/src/editor/cityset-window.cpp:749:144: style:inconclusive: Function 'change_image' argument 6 names different: declaration 'tile_width' definition 'tw'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/cityset-window.h:100:126: note: Function 'change_image' argument 6 names different: declaration 'tile_width' definition 'tw'. lordsawar-0.3.2/src/editor/cityset-window.cpp:749:144: note: Function 'change_image' argument 6 names different: declaration 'tile_width' definition 'tw'. lordsawar-0.3.2/src/editor/cityset-window.cpp:749:117: performance: Function parameter 'frames' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/editor/cityset-window.cpp:264:8: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/fight-order-editor-dialog.h:33:5: style: Class 'FightOrderEditorDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/editor/fight-order-editor-dialog.cpp:132:35: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/image-editor-dialog.cpp:43:3: performance: Variable 'd_target_filename' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/editor/image-editor-dialog.cpp:37:84: style:inconclusive: Function 'ImageEditorDialog' argument 3 names different: declaration 'num_frames' definition 'no_frames'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/image-editor-dialog.h:37:69: note: Function 'ImageEditorDialog' argument 3 names different: declaration 'num_frames' definition 'no_frames'. lordsawar-0.3.2/src/editor/image-editor-dialog.cpp:37:84: note: Function 'ImageEditorDialog' argument 3 names different: declaration 'num_frames' definition 'no_frames'. lordsawar-0.3.2/src/editor/image-file-filter.h:28:10: performance:inconclusive: Technically the member function 'ImageFileFilter::hasInvalidExt' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/editor/image-file-filter.cpp:55:23: note: Technically the member function 'ImageFileFilter::hasInvalidExt' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/editor/image-file-filter.h:28:10: note: Technically the member function 'ImageFileFilter::hasInvalidExt' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/editor/image-file-filter.h:29:10: performance:inconclusive: Technically the member function 'ImageFileFilter::add' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/editor/image-file-filter.cpp:30:23: note: Technically the member function 'ImageFileFilter::add' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/editor/image-file-filter.h:29:10: note: Technically the member function 'ImageFileFilter::add' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/editor/image-file-filter.h:30:10: performance:inconclusive: Technically the member function 'ImageFileFilter::showErrorDialog' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/editor/image-file-filter.cpp:65:23: note: Technically the member function 'ImageFileFilter::showErrorDialog' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/editor/image-file-filter.h:30:10: note: Technically the member function 'ImageFileFilter::showErrorDialog' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/editor/itemlist-dialog.h:34:5: style: Class 'ItemlistDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/editor/itemlist-dialog.cpp:66:36: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/keeper-editor-dialog.cpp:39:3: performance: Variable 'd_pos' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/editor/keeper-editor-dialog.cpp:36:114: style:inconclusive: Function 'KeeperEditorDialog' argument 4 names different: declaration 'randomize' definition 'r'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/keeper-editor-dialog.h:36:49: note: Function 'KeeperEditorDialog' argument 4 names different: declaration 'randomize' definition 'r'. lordsawar-0.3.2/src/editor/keeper-editor-dialog.cpp:36:114: note: Function 'KeeperEditorDialog' argument 4 names different: declaration 'randomize' definition 'r'. lordsawar-0.3.2/src/editor/lw-editor-dialog.cpp:28:3: performance: Variable 'xml' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/editor/main-window.h:52:5: style: Class 'MainWindow' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/editor/new-map-dialog.h:34:5: style: Class 'NewMapDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/editor/switch-sets-dialog.h:37:5: style: Class 'SwitchSetsDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/editor/shieldset-window.h:36:5: style: Class 'ShieldSetWindow' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/editor/tileset-window.h:36:5: style: Class 'TileSetWindow' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/editor/smallmap-editor-dialog.h:32:5: style: Class 'SmallmapEditorDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/editor/main-window.cpp:2206:7: style: The if condition is the same as the previous if condition [duplicateCondition] lordsawar-0.3.2/src/editor/main-window.cpp:2190:7: note: First condition lordsawar-0.3.2/src/editor/main-window.cpp:2206:7: note: Second condition lordsawar-0.3.2/src/editor/main-window.cpp:630:26: warning: Either the condition 'd_create_scenario_names' is redundant or there is possible null pointer dereference: d_create_scenario_names. [nullPointerRedundantCheck] lordsawar-0.3.2/src/editor/main-window.cpp:682:9: note: Assuming that condition 'd_create_scenario_names' is not redundant lordsawar-0.3.2/src/editor/main-window.cpp:630:26: note: Null pointer dereference lordsawar-0.3.2/src/editor/main-window.cpp:1675:39: style:inconclusive: Function 'randomize_city' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/main-window.h:241:31: note: Function 'randomize_city' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/editor/main-window.cpp:1675:39: note: Function 'randomize_city' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/editor/main-window.cpp:1700:39: style:inconclusive: Function 'randomize_ruin' argument 1 names different: declaration 'ruin' definition 'r'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/main-window.h:242:31: note: Function 'randomize_ruin' argument 1 names different: declaration 'ruin' definition 'r'. lordsawar-0.3.2/src/editor/main-window.cpp:1700:39: note: Function 'randomize_ruin' argument 1 names different: declaration 'ruin' definition 'r'. lordsawar-0.3.2/src/editor/main-window.cpp:2004:46: style:inconclusive: Function 'on_bag_selected' argument 1 names different: declaration 'pos' definition 'tile'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/main-window.h:273:38: note: Function 'on_bag_selected' argument 1 names different: declaration 'pos' definition 'tile'. lordsawar-0.3.2/src/editor/main-window.cpp:2004:46: note: Function 'on_bag_selected' argument 1 names different: declaration 'pos' definition 'tile'. lordsawar-0.3.2/src/editor/main-window.cpp:2059:54: style:inconclusive: Function 'on_road_edited' argument 2 names different: declaration 'new_type' definition 'type'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/main-window.h:274:46: note: Function 'on_road_edited' argument 2 names different: declaration 'new_type' definition 'type'. lordsawar-0.3.2/src/editor/main-window.cpp:2059:54: note: Function 'on_road_edited' argument 2 names different: declaration 'new_type' definition 'type'. lordsawar-0.3.2/src/editor/main-window.cpp:1496:72: performance: Function parameter 'objects' should be passed by const reference. However it seems that 'on_objects_selected' is a callback function. [passedByValueCallback] lordsawar-0.3.2/src/editor/main-window.cpp:1452:38: note: Function pointer used here. lordsawar-0.3.2/src/editor/main-window.cpp:1496:72: note: Function parameter 'objects' should be passed by const reference. However it seems that 'on_objects_selected' is a callback function. lordsawar-0.3.2/src/editor/main-window.cpp:2305:14: style: Variable 'i' can be declared as reference to const [constVariableReference] lordsawar-0.3.2/src/editor/main-window.cpp:1226:39: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/main-window.cpp:1257:62: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/main-window.cpp:1688:62: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/main-window.cpp:1695:62: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/main-window.cpp:1716:62: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/main-window.cpp:1723:62: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/main-window.cpp:1731:64: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/main-window.cpp:1749:64: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/main-window.cpp:1787:66: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/main-window.cpp:1794:66: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/main-window.cpp:1832:68: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/main-window.cpp:1946:36: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/main-window.cpp:1953:64: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/map-info-dialog.cpp:45:65: style:inconclusive: Function 'MapInfoDialog' argument 2 names different: declaration 'game_scenario' definition 'g'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/map-info-dialog.h:32:54: note: Function 'MapInfoDialog' argument 2 names different: declaration 'game_scenario' definition 'g'. lordsawar-0.3.2/src/editor/map-info-dialog.cpp:45:65: note: Function 'MapInfoDialog' argument 2 names different: declaration 'game_scenario' definition 'g'. lordsawar-0.3.2/src/editor/editorbigmap.cpp:65:3: performance: Variable 'mouse_pos' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/editor/editorbigmap.cpp:66:3: performance: Variable 'prev_mouse_pos' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/editor/editorbigmap.cpp:68:3: performance: Variable 'moving_objects_from' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/editor/editorbigmap.cpp:73:3: performance: Variable 'pointer_terrain' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/editor/media-dialog.cpp:156:159: performance: Function parameter 'frames' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/editor/new-map-dialog.cpp:83:3: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/past-chooser.cpp:40:3: performance: Variable 'pattern_dir' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/editor/past-chooser.cpp:43:57: style:inconclusive: Function 'set_dir' argument 1 names different: declaration 'filter' definition 'f'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/past-chooser.h:53:48: note: Function 'set_dir' argument 1 names different: declaration 'filter' definition 'f'. lordsawar-0.3.2/src/editor/past-chooser.cpp:43:57: note: Function 'set_dir' argument 1 names different: declaration 'filter' definition 'f'. lordsawar-0.3.2/src/editor/editorbigmap.cpp:78:40: style:inconclusive: Function 'set_pointer' argument 1 names different: declaration 'pointer' definition 'p'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/editorbigmap.h:59:30: note: Function 'set_pointer' argument 1 names different: declaration 'pointer' definition 'p'. lordsawar-0.3.2/src/editor/editorbigmap.cpp:78:40: note: Function 'set_pointer' argument 1 names different: declaration 'pointer' definition 'p'. lordsawar-0.3.2/src/editor/editorbigmap.cpp:78:64: style:inconclusive: Function 'set_pointer' argument 3 names different: declaration 'terrain' definition 't'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/editorbigmap.h:59:60: note: Function 'set_pointer' argument 3 names different: declaration 'terrain' definition 't'. lordsawar-0.3.2/src/editor/editorbigmap.cpp:78:64: note: Function 'set_pointer' argument 3 names different: declaration 'terrain' definition 't'. lordsawar-0.3.2/src/editor/editorbigmap.cpp:245:51: style:inconclusive: Function 'tile_to_bridge_type' argument 1 names different: declaration 'tile' definition 't'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/editorbigmap.h:103:41: note: Function 'tile_to_bridge_type' argument 1 names different: declaration 'tile' definition 't'. lordsawar-0.3.2/src/editor/editorbigmap.cpp:245:51: note: Function 'tile_to_bridge_type' argument 1 names different: declaration 'tile' definition 't'. lordsawar-0.3.2/src/editor/editorbigmap.cpp:236:31: style: Unused variable: tiles [unusedVariable] lordsawar-0.3.2/src/editor/select-hidden-ruin-dialog.h:31:5: style: Class 'SelectHiddenRuinDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/editor/players-dialog.cpp:55:76: style:inconclusive: Function 'PlayersDialog' argument 2 names different: declaration 'randomizer' definition 'random'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/players-dialog.h:35:65: note: Function 'PlayersDialog' argument 2 names different: declaration 'randomizer' definition 'random'. lordsawar-0.3.2/src/editor/players-dialog.cpp:55:76: note: Function 'PlayersDialog' argument 2 names different: declaration 'randomizer' definition 'random'. lordsawar-0.3.2/src/editor/rewardlist-dialog.cpp:63:36: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/ruin-editor-dialog.cpp:44:63: style:inconclusive: Function 'RuinEditorDialog' argument 2 names different: declaration 'ruin' definition 'r'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/ruin-editor-dialog.h:35:49: note: Function 'RuinEditorDialog' argument 2 names different: declaration 'ruin' definition 'r'. lordsawar-0.3.2/src/editor/ruin-editor-dialog.cpp:44:63: note: Function 'RuinEditorDialog' argument 2 names different: declaration 'ruin' definition 'r'. lordsawar-0.3.2/src/editor/ruin-editor-dialog.cpp:44:91: style:inconclusive: Function 'RuinEditorDialog' argument 3 names different: declaration 'randomize' definition 'randomizer'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/ruin-editor-dialog.h:36:47: note: Function 'RuinEditorDialog' argument 3 names different: declaration 'randomize' definition 'randomizer'. lordsawar-0.3.2/src/editor/ruin-editor-dialog.cpp:44:91: note: Function 'RuinEditorDialog' argument 3 names different: declaration 'randomize' definition 'randomizer'. lordsawar-0.3.2/src/editor/select-hidden-ruin-dialog.cpp:47:36: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/select-item-dialog.cpp:49:34: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/select-item-dialog.cpp:90:57: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/shieldset-info-dialog.cpp:32:74: style:inconclusive: Function 'ShieldSetInfoDialog' argument 2 names different: declaration 'shieldset' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/shieldset-info-dialog.h:30:57: note: Function 'ShieldSetInfoDialog' argument 2 names different: declaration 'shieldset' definition 's'. lordsawar-0.3.2/src/editor/shieldset-info-dialog.cpp:32:74: note: Function 'ShieldSetInfoDialog' argument 2 names different: declaration 'shieldset' definition 's'. lordsawar-0.3.2/src/editor/signpost-editor-dialog.cpp:34:75: style:inconclusive: Function 'SignpostEditorDialog' argument 2 names different: declaration 'signpost' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/signpost-editor-dialog.h:34:57: note: Function 'SignpostEditorDialog' argument 2 names different: declaration 'signpost' definition 's'. lordsawar-0.3.2/src/editor/signpost-editor-dialog.cpp:34:75: note: Function 'SignpostEditorDialog' argument 2 names different: declaration 'signpost' definition 's'. lordsawar-0.3.2/src/editor/smallmap-editor-dialog.cpp:366:7: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] lordsawar-0.3.2/src/editor/smallmap-editor-dialog.cpp:371:7: note: Found duplicate branches for 'if' and 'else'. lordsawar-0.3.2/src/editor/smallmap-editor-dialog.cpp:366:7: note: Found duplicate branches for 'if' and 'else'. lordsawar-0.3.2/src/editor/smallmap-editor-dialog.cpp:213:81: style:inconclusive: Function 'setup_pointer_radiobutton' argument 1 names different: declaration 'xml' definition 'b'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/smallmap-editor-dialog.h:89:63: note: Function 'setup_pointer_radiobutton' argument 1 names different: declaration 'xml' definition 'b'. lordsawar-0.3.2/src/editor/smallmap-editor-dialog.cpp:213:81: note: Function 'setup_pointer_radiobutton' argument 1 names different: declaration 'xml' definition 'b'. lordsawar-0.3.2/src/editor/smallmap-editor-dialog.cpp:217:58: style:inconclusive: Function 'setup_pointer_radiobutton' argument 5 names different: declaration 'size' definition 'siz'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/smallmap-editor-dialog.h:91:41: note: Function 'setup_pointer_radiobutton' argument 5 names different: declaration 'size' definition 'siz'. lordsawar-0.3.2/src/editor/smallmap-editor-dialog.cpp:217:58: note: Function 'setup_pointer_radiobutton' argument 5 names different: declaration 'size' definition 'siz'. lordsawar-0.3.2/src/editor/smallmap-editor-dialog.cpp:243:82: style:inconclusive: Function 'setup_pointer_radiobuttons' argument 1 names different: declaration 'xml' definition 'b'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/smallmap-editor-dialog.h:92:64: note: Function 'setup_pointer_radiobuttons' argument 1 names different: declaration 'xml' definition 'b'. lordsawar-0.3.2/src/editor/smallmap-editor-dialog.cpp:243:82: note: Function 'setup_pointer_radiobuttons' argument 1 names different: declaration 'xml' definition 'b'. lordsawar-0.3.2/src/editor/shieldset-window.cpp:1030:90: style:inconclusive: Function 'shield_filechooser' argument 2 names different: declaration 't' definition 'type'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/shieldset-window.h:125:78: note: Function 'shield_filechooser' argument 2 names different: declaration 't' definition 'type'. lordsawar-0.3.2/src/editor/shieldset-window.cpp:1030:90: note: Function 'shield_filechooser' argument 2 names different: declaration 't' definition 'type'. lordsawar-0.3.2/src/editor/shieldset-window.cpp:1135:55: style:inconclusive: Function 'process_tartanpic' argument 1 names different: declaration 't' definition 'type'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/shieldset-window.h:123:42: note: Function 'process_tartanpic' argument 1 names different: declaration 't' definition 'type'. lordsawar-0.3.2/src/editor/shieldset-window.cpp:1135:55: note: Function 'process_tartanpic' argument 1 names different: declaration 't' definition 'type'. lordsawar-0.3.2/src/editor/shieldset-window.cpp:1135:69: style:inconclusive: Function 'process_tartanpic' argument 2 names different: declaration 's' definition 'shield'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/shieldset-window.h:123:53: note: Function 'process_tartanpic' argument 2 names different: declaration 's' definition 'shield'. lordsawar-0.3.2/src/editor/shieldset-window.cpp:1135:69: note: Function 'process_tartanpic' argument 2 names different: declaration 's' definition 'shield'. lordsawar-0.3.2/src/editor/shieldset-window.cpp:371:9: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/editor/shieldset-window.cpp:370:8: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/shieldset-window.cpp:998:8: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/stack-editor-dialog.cpp:51:66: style:inconclusive: Function 'StackEditorDialog' argument 2 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/stack-editor-dialog.h:34:51: note: Function 'StackEditorDialog' argument 2 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/editor/stack-editor-dialog.cpp:51:66: note: Function 'StackEditorDialog' argument 2 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/editor/stack-editor-dialog.cpp:51:73: style:inconclusive: Function 'StackEditorDialog' argument 3 names different: declaration 'min_size' definition 'm'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/stack-editor-dialog.h:34:62: note: Function 'StackEditorDialog' argument 3 names different: declaration 'min_size' definition 'm'. lordsawar-0.3.2/src/editor/stack-editor-dialog.cpp:51:73: note: Function 'StackEditorDialog' argument 3 names different: declaration 'min_size' definition 'm'. lordsawar-0.3.2/src/editor/stack-editor-dialog.cpp:332:11: style: Variable 'player' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/editor/stone-editor-dialog.cpp:41:79: style:inconclusive: Function 'StoneEditorDialog' argument 3 names different: declaration 'road' definition 'r'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/stone-editor-dialog.h:33:64: note: Function 'StoneEditorDialog' argument 3 names different: declaration 'road' definition 'r'. lordsawar-0.3.2/src/editor/stone-editor-dialog.cpp:41:79: note: Function 'StoneEditorDialog' argument 3 names different: declaration 'road' definition 'r'. lordsawar-0.3.2/src/editor/temple-editor-dialog.cpp:34:69: style:inconclusive: Function 'TempleEditorDialog' argument 2 names different: declaration 'temple' definition 't'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/temple-editor-dialog.h:34:53: note: Function 'TempleEditorDialog' argument 2 names different: declaration 'temple' definition 't'. lordsawar-0.3.2/src/editor/temple-editor-dialog.cpp:34:69: note: Function 'TempleEditorDialog' argument 2 names different: declaration 'temple' definition 't'. lordsawar-0.3.2/src/editor/switch-sets-dialog.cpp:60:3: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tile-preview-dialog.cpp:34:77: style:inconclusive: Function 'TilePreviewDialog' argument 3 names different: declaration 'secondary' definition 'sec'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/tile-preview-dialog.h:32:62: note: Function 'TilePreviewDialog' argument 3 names different: declaration 'secondary' definition 'sec'. lordsawar-0.3.2/src/editor/tile-preview-dialog.cpp:34:77: note: Function 'TilePreviewDialog' argument 3 names different: declaration 'secondary' definition 'sec'. lordsawar-0.3.2/src/editor/tile-preview-dialog.cpp:101:4: style: Variable 's' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/editor/tile-preview-dialog.cpp:241:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tile-preview-dialog.cpp:256:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tile-preview-scene.cpp:71:29: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tileset-info-dialog.cpp:32:68: style:inconclusive: Function 'TileSetInfoDialog' argument 2 names different: declaration 'tileset' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/tileset-info-dialog.h:30:53: note: Function 'TileSetInfoDialog' argument 2 names different: declaration 'tileset' definition 's'. lordsawar-0.3.2/src/editor/tileset-info-dialog.cpp:32:68: note: Function 'TileSetInfoDialog' argument 2 names different: declaration 'tileset' definition 's'. lordsawar-0.3.2/src/editor/tileset-flag-editor-dialog.cpp:166:42: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tileset-flag-editor-dialog.cpp:169:63: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tileset-flag-editor-dialog.cpp:202:53: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tileset-flag-editor-dialog.cpp:205:41: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tileset-flag-editor-dialog.cpp:224:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tileset-flag-editor-dialog.cpp:227:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tileset-flag-editor-dialog.cpp:264:27: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tileset-selector-editor-dialog.cpp:141:7: style: Condition '!broken' is always true [knownConditionTrueFalse] lordsawar-0.3.2/src/editor/tileset-selector-editor-dialog.cpp:140:37: note: Calling function 'load_selector_image' returns 0 lordsawar-0.3.2/src/editor/tileset-selector-editor-dialog.cpp:140:37: note: Assignment 'broken=load_selector_image(d->get_filename())', assigned value is 0 lordsawar-0.3.2/src/editor/tileset-selector-editor-dialog.cpp:141:7: note: Condition '!broken' is always true lordsawar-0.3.2/src/editor/tileset-selector-editor-dialog.cpp:201:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tileset-selector-editor-dialog.cpp:204:63: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tileset-selector-editor-dialog.cpp:244:53: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tileset-selector-editor-dialog.cpp:247:41: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tileset-selector-editor-dialog.cpp:268:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tileset-selector-editor-dialog.cpp:271:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tileset-selector-editor-dialog.cpp:290:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tilestyle-organizer-dialog.cpp:115:35: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/editor/tilestyle-organizer-dialog.cpp:127:35: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/editor/tilestyle-organizer-dialog.cpp:271:19: style: The scope of the variable 'idstr' can be reduced. [variableScope] lordsawar-0.3.2/src/editor/tilestyle-organizer-dialog.cpp:312:19: style: The scope of the variable 'idstr' can be reduced. [variableScope] lordsawar-0.3.2/src/editor/tilestyle-organizer-dialog.cpp:347:19: style: The scope of the variable 'idstr' can be reduced. [variableScope] lordsawar-0.3.2/src/editor/tilestyle-organizer-dialog.cpp:265:121: style:inconclusive: Function 'on_categories_drop_drag_data_received' argument 2 names different: declaration 'a' definition 'x'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/tilestyle-organizer-dialog.h:97:99: note: Function 'on_categories_drop_drag_data_received' argument 2 names different: declaration 'a' definition 'x'. lordsawar-0.3.2/src/editor/tilestyle-organizer-dialog.cpp:265:121: note: Function 'on_categories_drop_drag_data_received' argument 2 names different: declaration 'a' definition 'x'. lordsawar-0.3.2/src/editor/tilestyle-organizer-dialog.cpp:265:128: style:inconclusive: Function 'on_categories_drop_drag_data_received' argument 3 names different: declaration 'b' definition 'y'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/tilestyle-organizer-dialog.h:97:106: note: Function 'on_categories_drop_drag_data_received' argument 3 names different: declaration 'b' definition 'y'. lordsawar-0.3.2/src/editor/tilestyle-organizer-dialog.cpp:265:128: note: Function 'on_categories_drop_drag_data_received' argument 3 names different: declaration 'b' definition 'y'. lordsawar-0.3.2/src/editor/tilestyle-organizer-dialog.cpp:400:61: style:inconclusive: Function 'on_drag_begin' argument 1 names different: declaration 'i' definition 'iconview'. [funcArgNamesDifferent] lordsawar-0.3.2/src/editor/tilestyle-organizer-dialog.h:103:39: note: Function 'on_drag_begin' argument 1 names different: declaration 'i' definition 'iconview'. lordsawar-0.3.2/src/editor/tilestyle-organizer-dialog.cpp:400:61: note: Function 'on_drag_begin' argument 1 names different: declaration 'i' definition 'iconview'. lordsawar-0.3.2/src/editor/tilestyle-organizer-dialog.cpp:114:7: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/editor/tilestyle-organizer-dialog.cpp:126:7: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/editor/tilestyle-organizer-dialog.cpp:113:71: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tilestyle-organizer-dialog.cpp:125:71: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tilestyle-organizer-dialog.cpp:151:71: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tilestyle-organizer-dialog.cpp:168:71: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tilestyle-organizer-dialog.cpp:252:8: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/validation-dialog.cpp:86:9: style: Variable 's' is reassigned a value before the old one has been used. [redundantAssignment] lordsawar-0.3.2/src/editor/validation-dialog.cpp:85:8: note: s is assigned lordsawar-0.3.2/src/editor/validation-dialog.cpp:86:9: note: s is overwritten lordsawar-0.3.2/src/editor/validation-dialog.cpp:32:82: performance: Function parameter 'errors' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/editor/validation-dialog.cpp:32:115: performance: Function parameter 'warnings' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/editor/validation-dialog.cpp:56:11: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/editor/validation-dialog.cpp:68:11: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/editor/validation-dialog.cpp:84:11: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/editor/validation-dialog.cpp:88:11: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/editor/tileset-window.cpp:1268:13: style: Variable 't' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/editor/tileset-window.cpp:1284:21: style: Variable 't' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/editor/tileset-window.cpp:1301:18: style: Variable 't' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/editor/tileset-window.cpp:844:6: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/editor/tileset-window.cpp:435:73: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tileset-window.cpp:765:76: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tileset-window.cpp:841:36: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tileset-window.cpp:1667:8: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/editor/tileset-window.cpp:1686:43: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/file-compat.cpp:445:15: style: The if condition is the same as the previous if condition [duplicateCondition] lordsawar-0.3.2/src/file-compat.cpp:443:15: note: First condition lordsawar-0.3.2/src/file-compat.cpp:445:15: note: Second condition lordsawar-0.3.2/src/file-compat.cpp:302:8: style: The scope of the variable 'broken' can be reduced. [variableScope] lordsawar-0.3.2/src/file-compat.cpp:498:8: style: The scope of the variable 'broken' can be reduced. [variableScope] lordsawar-0.3.2/src/file-compat.cpp:662:121: style:inconclusive: Function 'upgrade' argument 4 names different: declaration 't' definition 'type'. [funcArgNamesDifferent] lordsawar-0.3.2/src/file-compat.h:80:117: note: Function 'upgrade' argument 4 names different: declaration 't' definition 'type'. lordsawar-0.3.2/src/file-compat.cpp:662:121: note: Function 'upgrade' argument 4 names different: declaration 't' definition 'type'. lordsawar-0.3.2/src/file-compat.cpp:279:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/file-compat.cpp:291:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/file-compat.cpp:193:34: style: Variable 'l' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/file-compat.cpp:204:22: style: Variable 'l' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/file-compat.cpp:236:17: style: Variable 'upgraded' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/file-compat.cpp:66:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/file-compat.cpp:98:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/file-compat.cpp:122:8: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/file-compat.cpp:125:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/file-compat.cpp:155:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/file-compat.cpp:211:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/file-compat.cpp:219:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/file-compat.cpp:227:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/file-compat.cpp:277:35: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/file-compat.cpp:288:35: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/file-compat.cpp:342:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/file-compat.cpp:434:90: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/file-compat.cpp:618:90: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/file-compat.cpp:674:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:69:8: warning: Member variable 'Fight::d_intense_combat' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/fight.cpp:128:8: warning: Member variable 'Fight::d_turn' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/fight.cpp:128:8: warning: Member variable 'Fight::d_result' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/fight.cpp:128:8: warning: Member variable 'Fight::d_type' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/fight.cpp:128:8: warning: Member variable 'Fight::d_intense_combat' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/fight.cpp:163:8: warning: Member variable 'Fight::d_turn' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/fight.cpp:163:8: warning: Member variable 'Fight::d_result' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/fight.cpp:163:8: warning: Member variable 'Fight::d_intense_combat' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/fight.cpp:48:10: warning: Member variable 'Fighter::terrain_strength' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/fight.cpp:131:3: performance: Variable 'd_attackers' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/fight.cpp:132:3: performance: Variable 'd_defenders' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/fight.cpp:133:3: performance: Variable 'd_actions' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/fight.h:183:14: performance:inconclusive: Technically the member function 'Fight::calculateBaseStrength' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/fight.cpp:316:13: note: Technically the member function 'Fight::calculateBaseStrength' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/fight.h:183:14: note: Technically the member function 'Fight::calculateBaseStrength' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/fight.h:186:14: performance:inconclusive: Technically the member function 'Fight::calculateTerrainModifiers' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/fight.cpp:328:13: note: Technically the member function 'Fight::calculateTerrainModifiers' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/fight.h:186:14: note: Technically the member function 'Fight::calculateTerrainModifiers' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/fight.h:189:14: performance:inconclusive: Technically the member function 'Fight::calculateModifiedStrengths' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/fight.cpp:377:13: note: Technically the member function 'Fight::calculateModifiedStrengths' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/fight.h:189:14: note: Technically the member function 'Fight::calculateModifiedStrengths' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/fight.h:196:14: performance:inconclusive: Technically the member function 'Fight::calculateFinalStrengths' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/fight.cpp:518:13: note: Technically the member function 'Fight::calculateFinalStrengths' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/fight.h:196:14: note: Technically the member function 'Fight::calculateFinalStrengths' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/fight.h:216:15: performance:inconclusive: Technically the member function 'Fight::findArmyById' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/fight.cpp:253:14: note: Technically the member function 'Fight::findArmyById' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/fight.h:216:15: note: Technically the member function 'Fight::findArmyById' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/fight.cpp:437:7: style: The if condition is the same as the previous if condition [duplicateCondition] lordsawar-0.3.2/src/fight.cpp:423:7: note: First condition lordsawar-0.3.2/src/fight.cpp:437:7: note: Second condition lordsawar-0.3.2/src/fight.cpp:128:32: performance: Function parameter 'attackers' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/fight.cpp:128:61: performance: Function parameter 'defenders' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/fight.cpp:129:35: performance: Function parameter 'history' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/fight.cpp:138:42: performance: Function parameter 'attackers' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/fight.cpp:138:71: performance: Function parameter 'defenders' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/fight.cpp:163:32: performance: Function parameter 'attackers' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/fight.cpp:163:61: performance: Function parameter 'defenders' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/fight.cpp:316:55: performance: Function parameter 'fighters' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/fight.cpp:328:59: performance: Function parameter 'fighters' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/fight.cpp:377:60: performance: Function parameter 'friendly' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/fight.cpp:378:25: performance: Function parameter 'enemy' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/fight.cpp:518:58: performance: Function parameter 'friendly' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/fight.cpp:518:88: performance: Function parameter 'enemy' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/fight.cpp:88:12: style: Variable 'mtile' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/fight.cpp:152:13: style: Variable 'f' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/fight.cpp:154:13: style: Variable 'f' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/fight.cpp:460:13: style: Variable 'c' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/fight.cpp:689:47: style: Parameter 'a' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/fight.cpp:701:44: style: Parameter 'a' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/fight.cpp:753:11: style: Variable 'p' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/fight.cpp:146:17: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/fight.cpp:150:17: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/fight.cpp:153:25: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/fight.cpp:155:25: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/fight.cpp:670:7: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/fight.cpp:679:7: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/fight.cpp:693:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/fight.cpp:696:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/fight.cpp:706:7: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/fight.cpp:712:7: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/fight.cpp:552:33: style: Unused variable: fit [unusedVariable] lordsawar-0.3.2/src/fight.cpp:59:49: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:60:69: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:101:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:116:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:212:63: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:226:67: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:243:63: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:244:66: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:247:63: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:248:66: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:278:87: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:280:67: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:319:55: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:332:55: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:388:55: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:411:49: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:426:59: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:443:49: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:476:67: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:489:53: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:510:55: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:523:51: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:534:58: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:573:59: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:668:59: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:677:59: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:692:59: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:695:59: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:704:59: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:710:59: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/fight.cpp:759:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/game-actionlist.cpp:61:60: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/game-actionlist.cpp:77:68: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/game-client-decoder.cpp:41:64: performance: Function parameter 'actions' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/game-client-decoder.cpp:90:68: performance: Function parameter 'histories' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/game-client.cpp:453:7: style: The scope of the variable 'ival' can be reduced. [variableScope] lordsawar-0.3.2/src/game-client.cpp:170:55: style:inconclusive: Function 'onGotMessage' argument 2 names different: declaration 'message' definition 'payload'. [funcArgNamesDifferent] lordsawar-0.3.2/src/game-client.h:80:45: note: Function 'onGotMessage' argument 2 names different: declaration 'message' definition 'payload'. lordsawar-0.3.2/src/game-client.cpp:170:55: note: Function 'onGotMessage' argument 2 names different: declaration 'message' definition 'payload'. lordsawar-0.3.2/src/game-client.cpp:313:41: style:inconclusive: Function 'onHistoryDone' argument 1 names different: declaration 'history' definition 'h'. [funcArgNamesDifferent] lordsawar-0.3.2/src/game-client.h:86:31: note: Function 'onHistoryDone' argument 1 names different: declaration 'history' definition 'h'. lordsawar-0.3.2/src/game-client.cpp:313:41: note: Function 'onHistoryDone' argument 1 names different: declaration 'history' definition 'h'. lordsawar-0.3.2/src/game-client.cpp:327:39: style:inconclusive: Function 'onActionDone' argument 1 names different: declaration 'action' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/game-client.h:83:29: note: Function 'onActionDone' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/game-client.cpp:327:39: note: Function 'onActionDone' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/game-station.cpp:117:33: style: Condition 'reported!=1' is always false [knownConditionTrueFalse] lordsawar-0.3.2/src/game-station.cpp:117:16: note: Assuming that condition 'reported!=0' is not redundant lordsawar-0.3.2/src/game-station.cpp:117:33: note: Condition 'reported!=1' is always false lordsawar-0.3.2/src/game-station.cpp:32:69: style:inconclusive: Function 'clearNetworkActionlist' argument 1 names different: declaration 'actions' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/game-station.h:64:58: note: Function 'clearNetworkActionlist' argument 1 names different: declaration 'actions' definition 'a'. lordsawar-0.3.2/src/game-station.cpp:32:69: note: Function 'clearNetworkActionlist' argument 1 names different: declaration 'actions' definition 'a'. lordsawar-0.3.2/src/game-station.cpp:42:71: style:inconclusive: Function 'clearNetworkHistorylist' argument 1 names different: declaration 'histories' definition 'h'. [funcArgNamesDifferent] lordsawar-0.3.2/src/game-station.h:65:60: note: Function 'clearNetworkHistorylist' argument 1 names different: declaration 'histories' definition 'h'. lordsawar-0.3.2/src/game-station.cpp:42:71: note: Function 'clearNetworkHistorylist' argument 1 names different: declaration 'histories' definition 'h'. lordsawar-0.3.2/src/game-station.cpp:98:61: style:inconclusive: Function 'get_message_lobby_activity' argument 5 names different: declaration 'nickname' definition 'remainder'. [funcArgNamesDifferent] lordsawar-0.3.2/src/game-station.h:73:58: note: Function 'get_message_lobby_activity' argument 5 names different: declaration 'nickname' definition 'remainder'. lordsawar-0.3.2/src/game-station.cpp:98:61: note: Function 'get_message_lobby_activity' argument 5 names different: declaration 'nickname' definition 'remainder'. lordsawar-0.3.2/src/game-station.cpp:35:23: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/game-station.cpp:45:23: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/game-station.cpp:66:39: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/game-station.cpp:70:40: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/game-server.cpp:666:7: warning: Either the condition 'player' is redundant or there is possible null pointer dereference: player. [nullPointerRedundantCheck] lordsawar-0.3.2/src/game-server.cpp:672:7: note: Assuming that condition 'player' is not redundant lordsawar-0.3.2/src/game-server.cpp:666:7: note: Null pointer dereference lordsawar-0.3.2/src/game-server.cpp:669:37: warning: Either the condition 'player' is redundant or there is possible null pointer dereference: player. [nullPointerRedundantCheck] lordsawar-0.3.2/src/game-server.cpp:672:7: note: Assuming that condition 'player' is not redundant lordsawar-0.3.2/src/game-server.cpp:669:37: note: Null pointer dereference lordsawar-0.3.2/src/game-server.cpp:670:66: warning: Either the condition 'player' is redundant or there is possible null pointer dereference: player. [nullPointerRedundantCheck] lordsawar-0.3.2/src/game-server.cpp:672:7: note: Assuming that condition 'player' is not redundant lordsawar-0.3.2/src/game-server.cpp:670:66: note: Null pointer dereference lordsawar-0.3.2/src/game-server.cpp:249:67: style:inconclusive: Function 'onGotMessage' argument 3 names different: declaration 'message' definition 'payload'. [funcArgNamesDifferent] lordsawar-0.3.2/src/game-server.h:125:57: note: Function 'onGotMessage' argument 3 names different: declaration 'message' definition 'payload'. lordsawar-0.3.2/src/game-server.cpp:249:67: note: Function 'onGotMessage' argument 3 names different: declaration 'message' definition 'payload'. lordsawar-0.3.2/src/game-server.cpp:412:39: style:inconclusive: Function 'onActionDone' argument 1 names different: declaration 'action' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/game-server.h:86:29: note: Function 'onActionDone' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/game-server.cpp:412:39: note: Function 'onActionDone' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/game-server.cpp:466:41: style:inconclusive: Function 'onHistoryDone' argument 1 names different: declaration 'history' definition 'h'. [funcArgNamesDifferent] lordsawar-0.3.2/src/game-server.h:87:31: note: Function 'onHistoryDone' argument 1 names different: declaration 'history' definition 'h'. lordsawar-0.3.2/src/game-server.cpp:466:41: note: Function 'onHistoryDone' argument 1 names different: declaration 'history' definition 'h'. lordsawar-0.3.2/src/game-server.cpp:592:49: style:inconclusive: Function 'join' argument 2 names different: declaration 'payload' definition 'nickname_and_profile_id'. [funcArgNamesDifferent] lordsawar-0.3.2/src/game-server.h:89:39: note: Function 'join' argument 2 names different: declaration 'payload' definition 'nickname_and_profile_id'. lordsawar-0.3.2/src/game-server.cpp:592:49: note: Function 'join' argument 2 names different: declaration 'payload' definition 'nickname_and_profile_id'. lordsawar-0.3.2/src/game-server.cpp:1113:40: style:inconclusive: Function 'sendOffPlayer' argument 1 names different: declaration 'player' definition 'p'. [funcArgNamesDifferent] lordsawar-0.3.2/src/game-server.h:62:30: note: Function 'sendOffPlayer' argument 1 names different: declaration 'player' definition 'p'. lordsawar-0.3.2/src/game-server.cpp:1113:40: note: Function 'sendOffPlayer' argument 1 names different: declaration 'player' definition 'p'. lordsawar-0.3.2/src/game-server.cpp:1123:41: style:inconclusive: Function 'sendKillPlayer' argument 1 names different: declaration 'player' definition 'p'. [funcArgNamesDifferent] lordsawar-0.3.2/src/game-server.h:61:31: note: Function 'sendKillPlayer' argument 1 names different: declaration 'player' definition 'p'. lordsawar-0.3.2/src/game-server.cpp:1123:41: note: Function 'sendKillPlayer' argument 1 names different: declaration 'player' definition 'p'. lordsawar-0.3.2/src/game-server.cpp:548:16: style: Variable 'j' can be declared as reference to const [constVariableReference] lordsawar-0.3.2/src/game-server.cpp:646:16: style: Variable 'j' can be declared as reference to const [constVariableReference] lordsawar-0.3.2/src/game-server.cpp:928:18: style: Variable 'it' can be declared as reference to const [constVariableReference] lordsawar-0.3.2/src/game-server.cpp:1089:18: style: Variable 'j' can be declared as reference to const [constVariableReference] lordsawar-0.3.2/src/game-server.cpp:1093:14: style: Variable 'j' can be declared as reference to const [constVariableReference] lordsawar-0.3.2/src/game-server.cpp:1182:14: style: Variable 'i' can be declared as reference to const [constVariableReference] lordsawar-0.3.2/src/game-server.cpp:181:16: style: Variable 'part' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/game-server.cpp:417:11: style: Variable 'p' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/game-server.cpp:469:11: style: Variable 'p' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/game-server.cpp:569:14: style: Variable 'i' can be declared as pointer to const [constVariableReference] lordsawar-0.3.2/src/game-server.cpp:580:20: style: Variable 'part' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/game-server.cpp:645:14: style: Variable 'i' can be declared as pointer to const [constVariableReference] lordsawar-0.3.2/src/game-server.cpp:924:16: style: Variable 'part' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/game-server.cpp:1079:16: style: Variable 'part' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/game-server.cpp:383:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/game-server.cpp:549:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/game-server.cpp:558:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/game-server.cpp:571:7: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/game-server.cpp:646:5: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/game-server.cpp:733:2: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/game-server.cpp:749:2: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/game-server.cpp:765:2: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/game-server.cpp:790:2: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/game-server.cpp:931:6: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/game-server.cpp:47:27: style: struct member 'Participant::id_end_turn' is never used. [unusedStructMember] lordsawar-0.3.2/src/game-server.cpp:787:87: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/game.h:89:10: style:inconclusive: Technically the member function 'Game::saveGame' can be const. [functionConst] lordsawar-0.3.2/src/game.cpp:1058:12: note: Technically the member function 'Game::saveGame' can be const. lordsawar-0.3.2/src/game.h:89:10: note: Technically the member function 'Game::saveGame' can be const. lordsawar-0.3.2/src/game.h:239:10: style:inconclusive: Technically the member function 'Game::nextRound' can be const. [functionConst] lordsawar-0.3.2/src/game.cpp:1274:12: note: Technically the member function 'Game::nextRound' can be const. lordsawar-0.3.2/src/game.h:239:10: note: Technically the member function 'Game::nextRound' can be const. lordsawar-0.3.2/src/game.h:241:10: performance:inconclusive: Technically the member function 'Game::on_city_fight_finished' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/game.cpp:1315:12: note: Technically the member function 'Game::on_city_fight_finished' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/game.h:241:10: note: Technically the member function 'Game::on_city_fight_finished' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/game.h:243:10: performance:inconclusive: Technically the member function 'Game::looting_city' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/game.cpp:806:12: note: Technically the member function 'Game::looting_city' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/game.h:243:10: note: Technically the member function 'Game::looting_city' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/game.h:249:10: performance:inconclusive: Technically the member function 'Game::stack_arrives_on_tile' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/game.cpp:1389:12: note: Technically the member function 'Game::stack_arrives_on_tile' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/game.h:249:10: note: Technically the member function 'Game::stack_arrives_on_tile' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/game.h:250:10: performance:inconclusive: Technically the member function 'Game::stack_leaves_tile' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/game.cpp:1395:12: note: Technically the member function 'Game::stack_leaves_tile' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/game.h:250:10: note: Technically the member function 'Game::stack_leaves_tile' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/game.h:256:10: performance:inconclusive: Technically the member function 'Game::on_save_game' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/game.cpp:1438:12: note: Technically the member function 'Game::on_save_game' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/game.h:256:10: note: Technically the member function 'Game::on_save_game' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/game.h:257:13: performance:inconclusive: Technically the member function 'Game::on_get_round' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/game.cpp:1444:15: note: Technically the member function 'Game::on_get_round' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/game.h:257:13: note: Technically the member function 'Game::on_get_round' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/smallmap.h:51:5: style: Class 'SmallMap' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/gamebigmap.h:47:14: style: The destructor '~GameBigMap' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/bigmap.h:60:14: note: Virtual destructor in base class lordsawar-0.3.2/src/gamebigmap.h:47:14: note: Destructor in derived class lordsawar-0.3.2/src/gamebigmap.h:108:18: style: The function 'after_draw' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/bigmap.h:133:18: note: Virtual function in base class lordsawar-0.3.2/src/gamebigmap.h:108:18: note: Function in derived class lordsawar-0.3.2/src/smallmap.h:54:6: style: The destructor '~SmallMap' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:63:15: note: Virtual destructor in base class lordsawar-0.3.2/src/smallmap.h:54:6: note: Destructor in derived class lordsawar-0.3.2/src/smallmap.h:152:18: style: The function 'after_draw' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:221:18: note: Virtual function in base class lordsawar-0.3.2/src/smallmap.h:152:18: note: Function in derived class lordsawar-0.3.2/src/game.cpp:395:14: style: Variable 's.income' is reassigned a value before the old one has been used. [redundantAssignment] lordsawar-0.3.2/src/game.cpp:394:14: note: s.income is assigned lordsawar-0.3.2/src/game.cpp:395:14: note: s.income is overwritten lordsawar-0.3.2/src/game.cpp:661:40: style:inconclusive: Function 'heroGainsLevel' argument 1 names different: declaration 'a' definition 'h'. [funcArgNamesDifferent] lordsawar-0.3.2/src/game.h:230:38: note: Function 'heroGainsLevel' argument 1 names different: declaration 'a' definition 'h'. lordsawar-0.3.2/src/game.cpp:661:40: note: Function 'heroGainsLevel' argument 1 names different: declaration 'a' definition 'h'. lordsawar-0.3.2/src/game.cpp:696:53: style:inconclusive: Function 'on_city_queried' argument 2 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/game.h:212:46: note: Function 'on_city_queried' argument 2 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/game.cpp:696:53: note: Function 'on_city_queried' argument 2 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/game.cpp:707:34: style:inconclusive: Function 'on_city_visited' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/game.h:211:32: note: Function 'on_city_visited' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/game.cpp:707:34: note: Function 'on_city_visited' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/game.cpp:1142:35: style:inconclusive: Function 'on_player_died' argument 1 names different: declaration 'p' definition 'player'. [funcArgNamesDifferent] lordsawar-0.3.2/src/game.h:222:33: note: Function 'on_player_died' argument 1 names different: declaration 'p' definition 'player'. lordsawar-0.3.2/src/game.cpp:1142:35: note: Function 'on_player_died' argument 1 names different: declaration 'p' definition 'player'. lordsawar-0.3.2/src/game.cpp:508:10: style: Variable 'stack' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/game.cpp:595:11: style: Variable 'active' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/game.cpp:644:31: style: Parameter 's' can be declared as pointer to const. However it seems that 'stackUpdate' is a callback function, if 's' is declared with const you might also need to cast function pointer(s). [constParameterCallback] lordsawar-0.3.2/src/game.cpp:199:60: note: You might need to cast the function pointer here lordsawar-0.3.2/src/game.cpp:644:31: note: Parameter 's' can be declared as pointer to const lordsawar-0.3.2/src/game.cpp:746:43: style: Parameter 's' can be declared as pointer to const. However it seems that 'on_signpost_queried' is a callback function, if 's' is declared with const you might also need to cast function pointer(s). [constParameterCallback] lordsawar-0.3.2/src/game.cpp:279:29: note: You might need to cast the function pointer here lordsawar-0.3.2/src/game.cpp:746:43: note: Parameter 's' can be declared as pointer to const lordsawar-0.3.2/src/game.cpp:806:31: style: Parameter 'city' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/game.cpp:1203:13: style: Variable 'c' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/game.cpp:1217:13: style: Variable 'c' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/game.cpp:1232:11: style: Variable 'p' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/game.cpp:1331:11: style: Variable 'o' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/game.cpp:1201:45: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/game.cpp:1215:45: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gamebigmap.cpp:65:3: performance: Variable 'prev_mouse_pos' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gamebigmap.cpp:515:33: style: Condition 'd_see_opponents_stacks==false' is always true [knownConditionTrueFalse] lordsawar-0.3.2/src/gamebigmap.cpp:509:35: note: Assuming that condition 'd_see_opponents_stacks==true' is not redundant lordsawar-0.3.2/src/gamebigmap.cpp:515:33: note: Condition 'd_see_opponents_stacks==false' is always true lordsawar-0.3.2/src/gamebigmap.cpp:878:12: style: The scope of the variable 'canMoveThere' can be reduced. [variableScope] lordsawar-0.3.2/src/gamebigmap.cpp:305:8: style: Local variable 'dist' shadows outer function [shadowFunction] lordsawar-0.3.2/src/vector.h:180:10: note: Shadowed declaration lordsawar-0.3.2/src/gamebigmap.cpp:305:8: note: Shadow variable lordsawar-0.3.2/src/gamebigmap.cpp:129:11: style: Variable 'viewing' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamebigmap.cpp:290:10: style: Variable 'c' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamebigmap.cpp:443:11: style: Variable 'stack' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamebigmap.cpp:507:20: style: Variable 'st' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamebigmap.cpp:551:15: style: Variable 'stack' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamebigmap.cpp:571:11: style: Variable 'active' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamebigmap.cpp:572:11: style: Variable 'viewing' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamebigmap.cpp:607:14: style: Variable 'me' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamebigmap.cpp:629:17: style: Variable 't' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamebigmap.cpp:642:14: style: Variable 'me' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamebigmap.cpp:689:14: style: Variable 'st' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamebigmap.cpp:701:13: style: Variable 't' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamebigmap.cpp:704:14: style: Variable 'c' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamebigmap.cpp:714:14: style: Variable 'ruin' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamebigmap.cpp:735:11: style: Variable 'active' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamebigmap.cpp:736:11: style: Variable 'viewing' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamebigmap.cpp:918:15: style: Variable 'viewer' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamebigmap.cpp:992:11: style: Variable 'viewing' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamebigmap.cpp:1008:14: style: Variable 'stack' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamebigmap.cpp:1015:10: style: Variable 'city' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamebigmap.cpp:1025:10: style: Variable 'city' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamebigmap.cpp:1047:11: style: Variable 'viewing' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamebigmap.cpp:1064:13: style: Variable 'r' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamehost-client.cpp:56:17: warning: Member variable 'GamehostClient::d_connected' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/gamehost-client.cpp:56:17: warning: Member variable 'GamehostClient::d_recently_played_game_list' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/profilelist.h:77:9: style: Class 'Profilelist' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/recently-played-game-list.h:100:9: style: Class 'RecentlyPlayedGameList' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/gamehost-client.cpp:104:59: style:inconclusive: Function 'onGotMessage' argument 2 names different: declaration 'message' definition 'payload'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gamehost-client.h:86:45: note: Function 'onGotMessage' argument 2 names different: declaration 'message' definition 'payload'. lordsawar-0.3.2/src/gamehost-client.cpp:104:59: note: Function 'onGotMessage' argument 2 names different: declaration 'message' definition 'payload'. lordsawar-0.3.2/src/gamehost-client.cpp:65:71: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/gamehost-client.cpp:230:12: style: Variable 'profile' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamehost-client.cpp:244:45: style: Parameter 'game_scenario' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/gamebigmap.cpp:878:25: style: Variable 'canMoveThere' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/gamebigmap.cpp:883:2: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gamebigmap.cpp:885:16: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gamebigmap.cpp:906:4: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gamelist-client.cpp:56:17: warning: Member variable 'GamelistClient::d_connected' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/gamelist-client.cpp:56:17: warning: Member variable 'GamelistClient::d_recently_played_game_list' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/gamelist-client.cpp:106:59: style:inconclusive: Function 'onGotMessage' argument 2 names different: declaration 'message' definition 'payload'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gamelist-client.h:81:45: note: Function 'onGotMessage' argument 2 names different: declaration 'message' definition 'payload'. lordsawar-0.3.2/src/gamelist-client.cpp:106:59: note: Function 'onGotMessage' argument 2 names different: declaration 'message' definition 'payload'. lordsawar-0.3.2/src/gamelist-client.cpp:61:71: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/gamelist-client.cpp:184:36: style: Variable 'ng' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamelist.h:106:9: style: Class 'Gamelist' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/hosted-game.h:40:2: style: Class 'HostedGame' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/hosted-game.h:43:2: style: Class 'HostedGame' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/ghs/gamehost-server.h:83:8: performance:inconclusive: Technically the member function 'GamehostServer::onConnectionLost' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/ghs/gamehost-server.cpp:490:22: note: Technically the member function 'GamehostServer::onConnectionLost' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/ghs/gamehost-server.h:83:8: note: Technically the member function 'GamehostServer::onConnectionLost' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/ghs/gamehost-server.h:85:20: performance:inconclusive: Technically the member function 'GamehostServer::on_timer_registered' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/ghs/gamehost-server.cpp:495:34: note: Technically the member function 'GamehostServer::on_timer_registered' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/ghs/gamehost-server.h:85:20: note: Technically the member function 'GamehostServer::on_timer_registered' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/ghs/gamehost-server.h:90:8: performance:inconclusive: Technically the member function 'GamehostServer::on_child_setup' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/ghs/gamehost-server.cpp:281:22: note: Technically the member function 'GamehostServer::on_child_setup' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/ghs/gamehost-server.h:90:8: note: Technically the member function 'GamehostServer::on_child_setup' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/ghs/gamehost-server.h:91:8: performance:inconclusive: Technically the member function 'GamehostServer::loadProfile' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/ghs/gamehost-server.cpp:333:22: note: Technically the member function 'GamehostServer::loadProfile' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/ghs/gamehost-server.h:91:8: note: Technically the member function 'GamehostServer::loadProfile' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/ghs/gamehost-server.h:99:11: performance:inconclusive: Technically the member function 'GamehostServer::get_free_port' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/ghs/gamehost-server.cpp:272:25: note: Technically the member function 'GamehostServer::get_free_port' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/ghs/gamehost-server.h:99:11: note: Technically the member function 'GamehostServer::get_free_port' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/ghs/gamehost-server.h:105:8: performance:inconclusive: Technically the member function 'GamehostServer::waitForGameToBeConnectable' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/ghs/gamehost-server.cpp:206:22: note: Technically the member function 'GamehostServer::waitForGameToBeConnectable' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/ghs/gamehost-server.h:105:8: note: Technically the member function 'GamehostServer::waitForGameToBeConnectable' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/ghs/gamehost-server.cpp:242:7: style: Condition '!success' is always false [knownConditionTrueFalse] lordsawar-0.3.2/src/ghs/gamehost-server.cpp:241:44: note: Calling function 'waitForGameToBeConnectable' returns 1 lordsawar-0.3.2/src/ghs/gamehost-server.cpp:241:44: note: Assignment 'success=waitForGameToBeConnectable(port)', assigned value is 1 lordsawar-0.3.2/src/ghs/gamehost-server.cpp:242:7: note: Condition '!success' is always false lordsawar-0.3.2/src/ghs/gamehost-server.cpp:477:7: style:inconclusive: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] lordsawar-0.3.2/src/ghs/gamehost-server.cpp:344:71: style:inconclusive: Function 'onGotMessage' argument 3 names different: declaration 'message' definition 'payload'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ghs/gamehost-server.h:82:57: note: Function 'onGotMessage' argument 3 names different: declaration 'message' definition 'payload'. lordsawar-0.3.2/src/ghs/gamehost-server.cpp:344:71: note: Function 'onGotMessage' argument 3 names different: declaration 'message' definition 'payload'. lordsawar-0.3.2/src/ghs/gamehost-server.h:63:44: performance: Function parameter 'profile_ids' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/ghs/gamehost-server.cpp:216:31: style: Variable 'ex' can be declared as reference to const [constVariableReference] lordsawar-0.3.2/src/ghs/gamehost-server.cpp:538:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/ghs/gamehost-server.cpp:556:0: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/ghs/gamehost-server.cpp:521:39: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/ghs/gamehost-server.cpp:535:39: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/ghs/gamehost-server.cpp:554:8: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gamelist.cpp:269:23: style: Variable 'a' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gamelist.cpp:105:54: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gamelist.cpp:122:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gamelist.cpp:182:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gamelist.cpp:198:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gamelist.cpp:204:54: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gamelist.cpp:229:58: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gamelist.cpp:245:58: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gamelist.cpp:267:42: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gamelist.cpp:281:42: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/ghs/ghs-client-tool.cpp:36:3: performance: Variable 'd_host' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/ghs/ghs-client-tool.cpp:37:3: performance: Variable 'request_count' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/ghs/ghs-client-tool.cpp:40:3: performance: Variable 'd_unhost' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/ghs/ghs-client-tool.cpp:41:3: performance: Variable 'd_file_to_host' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/ghs/ghs-client-tool.h:58:8: performance:inconclusive: Technically the member function 'GhsClientTool::on_could_not_connect' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/ghs/ghs-client-tool.cpp:114:21: note: Technically the member function 'GhsClientTool::on_could_not_connect' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/ghs/ghs-client-tool.h:58:8: note: Technically the member function 'GhsClientTool::on_could_not_connect' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/ghs/ghs-client-tool.h:60:8: performance:inconclusive: Technically the member function 'GhsClientTool::on_connection_lost' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/ghs/ghs-client-tool.cpp:120:21: note: Technically the member function 'GhsClientTool::on_connection_lost' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/ghs/ghs-client-tool.h:60:8: note: Technically the member function 'GhsClientTool::on_connection_lost' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/ghs/ghs-client-tool.cpp:54:11: warning: Class 'GhsClientTool' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] lordsawar-0.3.2/src/ghs/ghs-client-tool.cpp:54:11: warning: Class 'GhsClientTool' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] lordsawar-0.3.2/src/ghs/ghs-client-tool.cpp:74:66: style:inconclusive: Function 'on_got_list_response' argument 1 names different: declaration 'list' definition 'l'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ghs/ghs-client-tool.h:52:53: note: Function 'on_got_list_response' argument 1 names different: declaration 'list' definition 'l'. lordsawar-0.3.2/src/ghs/ghs-client-tool.cpp:74:66: note: Function 'on_got_list_response' argument 1 names different: declaration 'list' definition 'l'. lordsawar-0.3.2/src/ghs/ghs-client-tool.cpp:88:72: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gls/gamelist-server.cpp:59:3: performance: Variable 'datafile' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gls/gamelist-server.h:63:8: performance:inconclusive: Technically the member function 'GamelistServer::onConnectionLost' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/gls/gamelist-server.cpp:218:22: note: Technically the member function 'GamelistServer::onConnectionLost' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/gls/gamelist-server.h:63:8: note: Technically the member function 'GamelistServer::onConnectionLost' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/gls/gamelist-server.h:65:20: performance:inconclusive: Technically the member function 'GamelistServer::on_timer_registered' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/gls/gamelist-server.cpp:223:34: note: Technically the member function 'GamelistServer::on_timer_registered' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/gls/gamelist-server.h:65:20: note: Technically the member function 'GamelistServer::on_timer_registered' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/gls/gamelist-server.cpp:141:71: style:inconclusive: Function 'onGotMessage' argument 3 names different: declaration 'message' definition 'payload'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gls/gamelist-server.h:62:57: note: Function 'onGotMessage' argument 3 names different: declaration 'message' definition 'payload'. lordsawar-0.3.2/src/gls/gamelist-server.cpp:141:71: note: Function 'onGotMessage' argument 3 names different: declaration 'message' definition 'payload'. lordsawar-0.3.2/src/gls/gls-client-tool.cpp:38:3: performance: Variable 'request_count' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gls/gls-client-tool.cpp:40:3: performance: Variable 'd_unadvertise' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gls/gls-client-tool.cpp:43:3: performance: Variable 'd_remove_all' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gls/gls-client-tool.h:58:8: performance:inconclusive: Technically the member function 'GlsClientTool::on_could_not_connect' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/gls/gls-client-tool.cpp:212:21: note: Technically the member function 'GlsClientTool::on_could_not_connect' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/gls/gls-client-tool.h:58:8: note: Technically the member function 'GlsClientTool::on_could_not_connect' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/gls/gls-client-tool.h:60:8: performance:inconclusive: Technically the member function 'GlsClientTool::on_connection_lost' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/gls/gls-client-tool.cpp:218:21: note: Technically the member function 'GlsClientTool::on_connection_lost' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/gls/gls-client-tool.h:60:8: note: Technically the member function 'GlsClientTool::on_connection_lost' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/gls/gls-client-tool.cpp:56:11: warning: Class 'GlsClientTool' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] lordsawar-0.3.2/src/gls/gls-client-tool.cpp:56:11: warning: Class 'GlsClientTool' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] lordsawar-0.3.2/src/gls/gls-client-tool.cpp:36:69: style:inconclusive: Function 'GlsClientTool' argument 3 names different: declaration 'profile' definition 'p'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gls/gls-client-tool.h:40:58: note: Function 'GlsClientTool' argument 3 names different: declaration 'profile' definition 'p'. lordsawar-0.3.2/src/gls/gls-client-tool.cpp:36:69: note: Function 'GlsClientTool' argument 3 names different: declaration 'profile' definition 'p'. lordsawar-0.3.2/src/gls/gls-client-tool.cpp:109:66: style:inconclusive: Function 'on_got_list_response' argument 1 names different: declaration 'list' definition 'l'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gls/gls-client-tool.h:54:53: note: Function 'on_got_list_response' argument 1 names different: declaration 'list' definition 'l'. lordsawar-0.3.2/src/gls/gls-client-tool.cpp:109:66: note: Function 'on_got_list_response' argument 1 names different: declaration 'list' definition 'l'. lordsawar-0.3.2/src/gls/gls-client-tool.cpp:36:113: performance: Function parameter 'unadvertise' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/gls/gls-client-tool.cpp:123:72: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gls/gls-client-tool.cpp:151:72: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gls/gls-client-tool.cpp:230:33: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/font-size.h:41:16: style:inconclusive: Technically the member function 'FontSize::get_height' can be const. [functionConst] lordsawar-0.3.2/src/gui/font-size.h:44:16: style:inconclusive: Technically the member function 'FontSize::get_width' can be const. [functionConst] lordsawar-0.3.2/src/gui/army-gains-level-dialog.cpp:38:71: style:inconclusive: Function 'ArmyGainsLevelDialog' argument 2 names different: declaration 'h' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/army-gains-level-dialog.h:32:53: note: Function 'ArmyGainsLevelDialog' argument 2 names different: declaration 'h' definition 'a'. lordsawar-0.3.2/src/gui/army-gains-level-dialog.cpp:38:71: note: Function 'ArmyGainsLevelDialog' argument 2 names different: declaration 'h' definition 'a'. lordsawar-0.3.2/src/gui/builder-cache.cpp:76:3: style: Statements following 'return' will never be executed. [unreachableCode] lordsawar-0.3.2/src/gui/builder-cache.cpp:45:72: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/buy-production-dialog.cpp:40:69: style:inconclusive: Function 'BuyProductionDialog' argument 2 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/buy-production-dialog.h:35:52: note: Function 'BuyProductionDialog' argument 2 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/gui/buy-production-dialog.cpp:40:69: note: Function 'BuyProductionDialog' argument 2 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/gui/input-helpers.h:24:56: style: Parameter 'e' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/gui/city-info-tip.cpp:33:62: style:inconclusive: Function 'CityInfoTip' argument 2 names different: declaration 'map' definition 'mpos'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/city-info-tip.h:34:53: note: Function 'CityInfoTip' argument 2 names different: declaration 'map' definition 'mpos'. lordsawar-0.3.2/src/gui/city-info-tip.cpp:33:62: note: Function 'CityInfoTip' argument 2 names different: declaration 'map' definition 'mpos'. lordsawar-0.3.2/src/gui/bar-chart.cpp:25:3: performance: Variable 'd_bars' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gui/bar-chart.cpp:26:3: performance: Variable 'd_colours' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gui/bar-chart.cpp:129:29: style: Same expression on both sides of '/'. [duplicateExpression] lordsawar-0.3.2/src/gui/bar-chart.cpp:22:44: performance: Function parameter 'bars' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/gui/bar-chart.cpp:22:71: performance: Function parameter 'colours' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/gui/bar-chart.cpp:68:30: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/bar-chart.cpp:112:57: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/city-window.cpp:45:51: style:inconclusive: Function 'CityWindow' argument 2 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/city-window.h:35:43: note: Function 'CityWindow' argument 2 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/gui/city-window.cpp:45:51: note: Function 'CityWindow' argument 2 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/gui/destination-dialog.cpp:42:65: style:inconclusive: Function 'DestinationDialog' argument 2 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/destination-dialog.h:33:50: note: Function 'DestinationDialog' argument 2 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/gui/destination-dialog.cpp:42:65: note: Function 'DestinationDialog' argument 2 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/gui/diplomacy-dialog.cpp:214:17: style:inconclusive: Function 'on_proposal_toggled' argument 2 names different: declaration 'p' definition 'player'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/diplomacy-dialog.h:37:66: note: Function 'on_proposal_toggled' argument 2 names different: declaration 'p' definition 'player'. lordsawar-0.3.2/src/gui/diplomacy-dialog.cpp:214:17: note: Function 'on_proposal_toggled' argument 2 names different: declaration 'p' definition 'player'. lordsawar-0.3.2/src/gui/destination-dialog.cpp:284:53: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/destination-dialog.cpp:308:53: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/destination-dialog.cpp:328:53: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/fight-order-dialog.cpp:32:65: style:inconclusive: Function 'FightOrderDialog' argument 2 names different: declaration 'player' definition 'theplayer'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/fight-order-dialog.h:34:51: note: Function 'FightOrderDialog' argument 2 names different: declaration 'player' definition 'theplayer'. lordsawar-0.3.2/src/gui/fight-order-dialog.cpp:32:65: note: Function 'FightOrderDialog' argument 2 names different: declaration 'player' definition 'theplayer'. lordsawar-0.3.2/src/gui/fight-order-dialog.cpp:45:35: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/fight-window.cpp:270:53: style:inconclusive: Function 'on_key_release_event' argument 1 names different: declaration 'ev' definition 'e'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/fight-window.h:80:44: note: Function 'on_key_release_event' argument 1 names different: declaration 'ev' definition 'e'. lordsawar-0.3.2/src/gui/fight-window.cpp:270:53: note: Function 'on_key_release_event' argument 1 names different: declaration 'ev' definition 'e'. lordsawar-0.3.2/src/gui/fight-window.cpp:234:18: style: Variable 'f' can be declared as reference to const [constVariableReference] lordsawar-0.3.2/src/gui/driver.cpp:90:5: performance: Variable 'game_scenario_downloaded' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gui/driver.cpp:92:5: performance: Variable 'd_load_filename' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gui/new-network-game-download-window.h:28:5: style: Class 'NewNetworkGameDownloadWindow' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/gui/new-random-map-dialog.h:33:5: style: Class 'NewRandomMapDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/gui/load-progress-window.h:29:5: style: Class 'LoadProgressWindow' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/gui/driver.cpp:1257:3: portability: %lu in format string (no. 1) requires 'unsigned long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_uint] lordsawar-0.3.2/src/gui/driver.cpp:199:3: warning: Either the condition 'game' is redundant or there is possible null pointer dereference: game. [nullPointerRedundantCheck] lordsawar-0.3.2/src/gui/driver.cpp:200:7: note: Assuming that condition 'game' is not redundant lordsawar-0.3.2/src/gui/driver.cpp:199:3: note: Null pointer dereference lordsawar-0.3.2/src/gui/driver.cpp:820:30: warning: Either the condition 'splash_window' is redundant or there is possible null pointer dereference: splash_window. [nullPointerRedundantCheck] lordsawar-0.3.2/src/gui/driver.cpp:818:7: note: Assuming that condition 'splash_window' is not redundant lordsawar-0.3.2/src/gui/driver.cpp:820:30: note: Null pointer dereference lordsawar-0.3.2/src/gui/driver.cpp:838:7: warning: Either the condition 'splash_window' is redundant or there is possible null pointer dereference: splash_window. [nullPointerRedundantCheck] lordsawar-0.3.2/src/gui/driver.cpp:834:7: note: Assuming that condition 'splash_window' is not redundant lordsawar-0.3.2/src/gui/driver.cpp:838:7: note: Null pointer dereference lordsawar-0.3.2/src/gui/driver.cpp:1424:30: warning: Either the condition 'splash_window' is redundant or there is possible null pointer dereference: splash_window. [nullPointerRedundantCheck] lordsawar-0.3.2/src/gui/driver.cpp:1421:7: note: Assuming that condition 'splash_window' is not redundant lordsawar-0.3.2/src/gui/driver.cpp:1424:30: note: Null pointer dereference lordsawar-0.3.2/src/gui/driver.cpp:921:56: style:inconclusive: Function 'on_game_scenario_downloaded' argument 1 names different: declaration 'filename' definition 'path'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/driver.h:74:52: note: Function 'on_game_scenario_downloaded' argument 1 names different: declaration 'filename' definition 'path'. lordsawar-0.3.2/src/gui/driver.cpp:921:56: note: Function 'on_game_scenario_downloaded' argument 1 names different: declaration 'filename' definition 'path'. lordsawar-0.3.2/src/gui/driver.cpp:958:24: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/driver.cpp:1303:64: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/driver.cpp:1340:64: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/game-button-box.cpp:74:46: style:inconclusive: Function 'GameButtonBox' argument 1 names different: declaration 'base' definition 'baseObject'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/game-button-box.h:34:35: note: Function 'GameButtonBox' argument 1 names different: declaration 'base' definition 'baseObject'. lordsawar-0.3.2/src/gui/game-button-box.cpp:74:46: note: Function 'GameButtonBox' argument 1 names different: declaration 'base' definition 'baseObject'. lordsawar-0.3.2/src/gui/game-button-box.cpp:92:35: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/game-lobby-dialog.cpp:163:29: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/game-lobby-dialog.cpp:180:29: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/game-lobby-dialog.cpp:497:25: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/game-lobby-dialog.cpp:520:25: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/game-lobby-dialog.cpp:548:25: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/game-lobby-dialog.cpp:568:25: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/game-lobby-dialog.cpp:598:25: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/game-lobby-dialog.cpp:648:25: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/game-lobby-dialog.cpp:872:35: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/game-preferences-dialog.cpp:139:3: performance: Variable 'mode' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gui/game-preferences-dialog.cpp:136:114: style:inconclusive: Function 'GamePreferencesDialog' argument 3 names different: declaration 'mode' definition 'play_mode'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/game-preferences-dialog.h:38:95: note: Function 'GamePreferencesDialog' argument 3 names different: declaration 'mode' definition 'play_mode'. lordsawar-0.3.2/src/gui/game-preferences-dialog.cpp:136:114: note: Function 'GamePreferencesDialog' argument 3 names different: declaration 'mode' definition 'play_mode'. lordsawar-0.3.2/src/gui/game-preferences-dialog.cpp:83:35: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/game-preferences-dialog.cpp:100:37: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/game-preferences-dialog.cpp:250:35: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/game-preferences-dialog.cpp:276:35: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/game-preferences-dialog.cpp:290:35: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/game-preferences-dialog.cpp:315:35: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/game-preferences-dialog.cpp:370:35: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/game-preferences-dialog.cpp:468:36: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/game-preferences-dialog.cpp:552:35: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/game-options-dialog.cpp:121:37: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/game-window.cpp:2809:58: error: There is an unknown macro here somewhere. Configuration is required. If PACKAGE_VERSION is a macro then please configure it. [unknownMacro] lordsawar-0.3.2/src/gui/hero-levels-dialog.cpp:60:65: style:inconclusive: Function 'HeroLevelsDialog' argument 2 names different: declaration 'player' definition 'theplayer'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/hero-levels-dialog.h:34:51: note: Function 'HeroLevelsDialog' argument 2 names different: declaration 'player' definition 'theplayer'. lordsawar-0.3.2/src/gui/hero-levels-dialog.cpp:60:65: note: Function 'HeroLevelsDialog' argument 2 names different: declaration 'player' definition 'theplayer'. lordsawar-0.3.2/src/gui/hero-levels-dialog.cpp:56:76: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/hero-levels-dialog.cpp:65:76: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/hero-dialog.cpp:45:3: performance: Variable 'pos' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gui/hero-dialog.cpp:40:51: style:inconclusive: Function 'HeroDialog' argument 2 names different: declaration 'hero' definition 'h'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/hero-dialog.h:37:43: note: Function 'HeroDialog' argument 2 names different: declaration 'hero' definition 'h'. lordsawar-0.3.2/src/gui/hero-dialog.cpp:40:51: note: Function 'HeroDialog' argument 2 names different: declaration 'hero' definition 'h'. lordsawar-0.3.2/src/gui/hero-dialog.cpp:40:66: style:inconclusive: Function 'HeroDialog' argument 3 names different: declaration 'pos' definition 'p'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/hero-dialog.h:37:61: note: Function 'HeroDialog' argument 3 names different: declaration 'pos' definition 'p'. lordsawar-0.3.2/src/gui/hero-dialog.cpp:40:66: note: Function 'HeroDialog' argument 3 names different: declaration 'pos' definition 'p'. lordsawar-0.3.2/src/gui/hero-dialog.cpp:132:43: style:inconclusive: Function 'addHistoryEvent' argument 1 names different: declaration 'event' definition 'history'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/hero-dialog.h:109:35: note: Function 'addHistoryEvent' argument 1 names different: declaration 'event' definition 'history'. lordsawar-0.3.2/src/gui/hero-dialog.cpp:132:43: note: Function 'addHistoryEvent' argument 1 names different: declaration 'event' definition 'history'. lordsawar-0.3.2/src/gui/hero-dialog.cpp:349:33: style:inconclusive: Function 'add_hero' argument 1 names different: declaration 'hero' definition 'h'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/hero-dialog.h:108:25: note: Function 'add_hero' argument 1 names different: declaration 'hero' definition 'h'. lordsawar-0.3.2/src/gui/hero-dialog.cpp:349:33: note: Function 'add_hero' argument 1 names different: declaration 'hero' definition 'h'. lordsawar-0.3.2/src/gui/hero-dialog.cpp:96:76: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/hero-dialog.cpp:232:76: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/hero-dialog.cpp:305:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/hero-dialog.cpp:323:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/hero-dialog.cpp:445:8: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/hero-dialog.cpp:455:71: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/hero-offer-dialog.cpp:39:82: style:inconclusive: Function 'HeroOfferDialog' argument 3 names different: declaration 'hero' definition 'h'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/hero-offer-dialog.h:35:69: note: Function 'HeroOfferDialog' argument 3 names different: declaration 'hero' definition 'h'. lordsawar-0.3.2/src/gui/hero-offer-dialog.cpp:39:82: note: Function 'HeroOfferDialog' argument 3 names different: declaration 'hero' definition 'h'. lordsawar-0.3.2/src/gui/hero-offer-dialog.cpp:39:91: style:inconclusive: Function 'HeroOfferDialog' argument 4 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/hero-offer-dialog.h:35:81: note: Function 'HeroOfferDialog' argument 4 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/gui/hero-offer-dialog.cpp:39:91: note: Function 'HeroOfferDialog' argument 4 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/gui/image-helpers.cpp:71:43: style:inconclusive: Function 'disassemble_row' argument 1 names different: declaration 'p' definition 'row'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/image-helpers.h:34:43: note: Function 'disassemble_row' argument 1 names different: declaration 'p' definition 'row'. lordsawar-0.3.2/src/gui/image-helpers.cpp:71:43: note: Function 'disassemble_row' argument 1 names different: declaration 'p' definition 'row'. lordsawar-0.3.2/src/gui/item-bonus-dialog.h:33:5: style: Class 'ItemBonusDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/gui/item-bonus-dialog.cpp:42:49: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/item-report-dialog.cpp:37:3: performance: Variable 'stacks' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gui/item-report-dialog.cpp:38:3: performance: Variable 'bags' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gui/item-report-dialog.cpp:34:118: style:inconclusive: Function 'ItemReportDialog' argument 3 names different: declaration 'bags' definition 'bags_of_stuff'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/item-report-dialog.h:34:104: note: Function 'ItemReportDialog' argument 3 names different: declaration 'bags' definition 'bags_of_stuff'. lordsawar-0.3.2/src/gui/item-report-dialog.cpp:34:118: note: Function 'ItemReportDialog' argument 3 names different: declaration 'bags' definition 'bags_of_stuff'. lordsawar-0.3.2/src/gui/item-report-dialog.cpp:34:118: performance: Function parameter 'bags_of_stuff' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/gui/item-report-dialog.cpp:70:8: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/history-report-dialog.cpp:679:7: style: Redundant initialization for 'pit'. The initialized value is overwritten before it is read. [redundantInitialization] lordsawar-0.3.2/src/gui/history-report-dialog.cpp:678:28: note: pit is initialized lordsawar-0.3.2/src/gui/history-report-dialog.cpp:679:7: note: pit is overwritten lordsawar-0.3.2/src/gui/history-report-dialog.cpp:707:7: style: Redundant initialization for 'pit'. The initialized value is overwritten before it is read. [redundantInitialization] lordsawar-0.3.2/src/gui/history-report-dialog.cpp:706:28: note: pit is initialized lordsawar-0.3.2/src/gui/history-report-dialog.cpp:707:7: note: pit is overwritten lordsawar-0.3.2/src/gui/history-report-dialog.cpp:741:7: style: Redundant initialization for 'pit'. The initialized value is overwritten before it is read. [redundantInitialization] lordsawar-0.3.2/src/gui/history-report-dialog.cpp:740:28: note: pit is initialized lordsawar-0.3.2/src/gui/history-report-dialog.cpp:741:7: note: pit is overwritten lordsawar-0.3.2/src/gui/history-report-dialog.cpp:770:7: style: Redundant initialization for 'pit'. The initialized value is overwritten before it is read. [redundantInitialization] lordsawar-0.3.2/src/gui/history-report-dialog.cpp:769:28: note: pit is initialized lordsawar-0.3.2/src/gui/history-report-dialog.cpp:770:7: note: pit is overwritten lordsawar-0.3.2/src/gui/history-report-dialog.cpp:171:13: error: Invalid iterator 'hit' used. [eraseDereference] lordsawar-0.3.2/src/gui/history-report-dialog.cpp:176:17: error: Invalid iterator 'hit' used. [eraseDereference] lordsawar-0.3.2/src/gui/history-report-dialog.cpp:193:41: error: Invalid iterator 'hit' used. [eraseDereference] lordsawar-0.3.2/src/gui/history-report-dialog.cpp:122:39: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/history-report-dialog.cpp:126:33: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/history-report-dialog.cpp:405:33: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/history-report-dialog.cpp:414:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/history-report-dialog.cpp:435:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/history-report-dialog.cpp:456:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/history-report-dialog.cpp:476:40: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/history-report-dialog.cpp:480:34: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/history-report-dialog.cpp:687:34: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/history-report-dialog.cpp:720:43: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/history-report-dialog.cpp:749:34: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/history-report-dialog.cpp:780:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/line-chart.cpp:29:3: performance: Variable 'd_lines' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gui/line-chart.cpp:30:3: performance: Variable 'd_colours' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gui/line-chart.cpp:32:3: performance: Variable 'd_x_axis_description' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gui/line-chart.cpp:33:3: performance: Variable 'd_y_axis_description' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gui/line-chart.cpp:206:15: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/gui/load-progress-window.cpp:25:53: style:inconclusive: Function 'LoadProgressWindow' argument 1 names different: declaration 'parent' definition 'w'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/load-progress-window.h:29:37: note: Function 'LoadProgressWindow' argument 1 names different: declaration 'parent' definition 'w'. lordsawar-0.3.2/src/gui/load-progress-window.cpp:25:53: note: Function 'LoadProgressWindow' argument 1 names different: declaration 'parent' definition 'w'. lordsawar-0.3.2/src/gui/line-chart.cpp:23:58: performance: Function parameter 'lines' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/gui/line-chart.cpp:24:29: performance: Function parameter 'colours' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/gui/line-chart.cpp:66:34: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/line-chart.cpp:75:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/line-chart.cpp:78:34: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/line-chart.cpp:101:58: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/line-chart.cpp:111:30: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/lw-dialog.cpp:28:3: performance: Variable 'xml' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gui/main-preferences-dialog.h:32:5: style: Class 'MainPreferencesDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/gui/load-scenario-dialog.h:33:5: style: Class 'LoadScenarioDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/gui/network-game-selector-dialog.cpp:149:8: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/main.cpp:75:5: performance: Variable 'load_filename' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gui/main.cpp:76:5: performance: Variable 'turn_filename' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gui/main.cpp:77:5: performance: Variable 'random_number_seed' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gui/main.cpp:78:5: performance: Variable 'port' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gui/new-profile-dialog.h:30:5: style: Class 'NewProfileDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/gui/new-network-game-dialog.cpp:90:12: style: Variable 'p' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gui/new-network-game-dialog.cpp:53:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/new-network-game-dialog.cpp:93:25: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/preferences-dialog.cpp:129:34: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/preferences-dialog.cpp:155:37: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/quest-assigned-dialog.cpp:31:69: style:inconclusive: Function 'QuestAssignedDialog' argument 2 names different: declaration 'hero' definition 'h'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/quest-assigned-dialog.h:33:52: note: Function 'QuestAssignedDialog' argument 2 names different: declaration 'hero' definition 'h'. lordsawar-0.3.2/src/gui/quest-assigned-dialog.cpp:31:69: note: Function 'QuestAssignedDialog' argument 2 names different: declaration 'hero' definition 'h'. lordsawar-0.3.2/src/gui/quest-assigned-dialog.cpp:31:79: style:inconclusive: Function 'QuestAssignedDialog' argument 3 names different: declaration 'quest' definition 'q'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/quest-assigned-dialog.h:33:65: note: Function 'QuestAssignedDialog' argument 3 names different: declaration 'quest' definition 'q'. lordsawar-0.3.2/src/gui/quest-assigned-dialog.cpp:31:79: note: Function 'QuestAssignedDialog' argument 3 names different: declaration 'quest' definition 'q'. lordsawar-0.3.2/src/gui/quest-completed-dialog.cpp:34:72: style:inconclusive: Function 'QuestCompletedDialog' argument 2 names different: declaration 'quest' definition 'q'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/quest-completed-dialog.h:33:54: note: Function 'QuestCompletedDialog' argument 2 names different: declaration 'quest' definition 'q'. lordsawar-0.3.2/src/gui/quest-completed-dialog.cpp:34:72: note: Function 'QuestCompletedDialog' argument 2 names different: declaration 'quest' definition 'q'. lordsawar-0.3.2/src/gui/quest-completed-dialog.cpp:34:83: style:inconclusive: Function 'QuestCompletedDialog' argument 3 names different: declaration 'reward' definition 'r'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/quest-completed-dialog.h:33:69: note: Function 'QuestCompletedDialog' argument 3 names different: declaration 'reward' definition 'r'. lordsawar-0.3.2/src/gui/quest-completed-dialog.cpp:34:83: note: Function 'QuestCompletedDialog' argument 3 names different: declaration 'reward' definition 'r'. lordsawar-0.3.2/src/gui/new-random-map-dialog.cpp:118:8: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/quest-report-dialog.cpp:35:3: performance: Variable 'quests' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gui/quest-report-dialog.cpp:32:79: style:inconclusive: Function 'QuestReportDialog' argument 2 names different: declaration 'quests' definition 'q'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/quest-report-dialog.h:36:64: note: Function 'QuestReportDialog' argument 2 names different: declaration 'quests' definition 'q'. lordsawar-0.3.2/src/gui/quest-report-dialog.cpp:32:79: note: Function 'QuestReportDialog' argument 2 names different: declaration 'quests' definition 'q'. lordsawar-0.3.2/src/gui/quest-report-dialog.cpp:32:88: style:inconclusive: Function 'QuestReportDialog' argument 3 names different: declaration 'preferred_hero' definition 'hero'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/quest-report-dialog.h:36:78: note: Function 'QuestReportDialog' argument 3 names different: declaration 'preferred_hero' definition 'hero'. lordsawar-0.3.2/src/gui/quest-report-dialog.cpp:32:88: note: Function 'QuestReportDialog' argument 3 names different: declaration 'preferred_hero' definition 'hero'. lordsawar-0.3.2/src/gui/quest-report-dialog.cpp:72:50: style:inconclusive: Function 'add_questing_hero' argument 1 names different: declaration 'quest' definition 'q'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/quest-report-dialog.h:67:35: note: Function 'add_questing_hero' argument 1 names different: declaration 'quest' definition 'q'. lordsawar-0.3.2/src/gui/quest-report-dialog.cpp:72:50: note: Function 'add_questing_hero' argument 1 names different: declaration 'quest' definition 'q'. lordsawar-0.3.2/src/gui/quest-report-dialog.cpp:32:79: performance: Function parameter 'q' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/gui/quest-report-dialog.cpp:56:8: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/quick-help-window.cpp:32:3: performance: Variable 'xml' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gui/ruin-report-dialog.cpp:109:11: style: Variable 'temple' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/gui/sage-dialog.cpp:38:51: style:inconclusive: Function 'SageDialog' argument 2 names different: declaration 'sage' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/sage-dialog.h:36:43: note: Function 'SageDialog' argument 2 names different: declaration 'sage' definition 's'. lordsawar-0.3.2/src/gui/sage-dialog.cpp:38:51: note: Function 'SageDialog' argument 2 names different: declaration 'sage' definition 's'. lordsawar-0.3.2/src/gui/sage-dialog.cpp:38:60: style:inconclusive: Function 'SageDialog' argument 3 names different: declaration 'hero' definition 'h'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/sage-dialog.h:36:55: note: Function 'SageDialog' argument 3 names different: declaration 'hero' definition 'h'. lordsawar-0.3.2/src/gui/sage-dialog.cpp:38:60: note: Function 'SageDialog' argument 3 names different: declaration 'hero' definition 'h'. lordsawar-0.3.2/src/gui/sage-dialog.cpp:63:61: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/report-dialog.cpp:314:62: performance: Function parameter 'scores' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/gui/report-dialog.cpp:75:51: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/report-dialog.cpp:318:30: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/stack-army-button.cpp:51:18: warning: Member variable 'StackArmyButton::d_stack' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/gui/stack-army-button.cpp:51:18: warning: Member variable 'StackArmyButton::d_army' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/gui/stack-army-button.cpp:51:50: style:inconclusive: Function 'StackArmyButton' argument 1 names different: declaration 'base' definition 'baseObject'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/stack-army-button.h:36:37: note: Function 'StackArmyButton' argument 1 names different: declaration 'base' definition 'baseObject'. lordsawar-0.3.2/src/gui/stack-army-button.cpp:51:50: note: Function 'StackArmyButton' argument 1 names different: declaration 'base' definition 'baseObject'. lordsawar-0.3.2/src/gui/splash-window.cpp:45:3: performance: Variable 'network_game_nickname' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gui/stack-info-dialog.cpp:46:3: performance: Variable 'tile' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gui/stack-info-dialog.cpp:91:60: style:inconclusive: Function 'addArmy' argument 3 names different: declaration 'a' definition 'h'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/stack-info-dialog.h:54:47: note: Function 'addArmy' argument 3 names different: declaration 'a' definition 'h'. lordsawar-0.3.2/src/gui/stack-info-dialog.cpp:91:60: note: Function 'addArmy' argument 3 names different: declaration 'a' definition 'h'. lordsawar-0.3.2/src/gui/stack-info-dialog.cpp:259:73: style:inconclusive: Function 'on_army_toggled' argument 2 names different: declaration 's' definition 'stack'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/stack-info-dialog.h:60:60: note: Function 'on_army_toggled' argument 2 names different: declaration 's' definition 'stack'. lordsawar-0.3.2/src/gui/stack-info-dialog.cpp:259:73: note: Function 'on_army_toggled' argument 2 names different: declaration 's' definition 'stack'. lordsawar-0.3.2/src/gui/stack-info-dialog.cpp:259:86: style:inconclusive: Function 'on_army_toggled' argument 3 names different: declaration 'a' definition 'army'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/stack-info-dialog.h:60:69: note: Function 'on_army_toggled' argument 3 names different: declaration 'a' definition 'army'. lordsawar-0.3.2/src/gui/stack-info-dialog.cpp:259:86: note: Function 'on_army_toggled' argument 3 names different: declaration 'a' definition 'army'. lordsawar-0.3.2/src/gui/stack-info-dialog.cpp:286:72: style:inconclusive: Function 'on_stack_toggled' argument 2 names different: declaration 's' definition 'stack'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/stack-info-dialog.h:59:59: note: Function 'on_stack_toggled' argument 2 names different: declaration 's' definition 'stack'. lordsawar-0.3.2/src/gui/stack-info-dialog.cpp:286:72: note: Function 'on_stack_toggled' argument 2 names different: declaration 's' definition 'stack'. lordsawar-0.3.2/src/gui/stack-info-dialog.cpp:78:57: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/stack-info-dialog.cpp:216:74: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/stack-info-tip.cpp:38:64: style:inconclusive: Function 'StackInfoTip' argument 2 names different: declaration 'map' definition 'mpos'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/stack-info-tip.h:35:54: note: Function 'StackInfoTip' argument 2 names different: declaration 'map' definition 'mpos'. lordsawar-0.3.2/src/gui/stack-info-tip.cpp:38:64: note: Function 'StackInfoTip' argument 2 names different: declaration 'map' definition 'mpos'. lordsawar-0.3.2/src/gui/stack-info-tip.cpp:38:81: style:inconclusive: Function 'StackInfoTip' argument 3 names different: declaration 's' definition 'stile'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/stack-info-tip.h:35:70: note: Function 'StackInfoTip' argument 3 names different: declaration 's' definition 'stile'. lordsawar-0.3.2/src/gui/stack-info-tip.cpp:38:81: note: Function 'StackInfoTip' argument 3 names different: declaration 's' definition 'stile'. lordsawar-0.3.2/src/gui/stack-info-tip.cpp:68:76: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/stack-info-tip.cpp:69:67: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/status-box.cpp:57:3: performance: Variable 'd_height_fudge_factor' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/gui/stack-tile-box.cpp:59:44: style:inconclusive: Function 'StackTileBox' argument 1 names different: declaration 'base' definition 'baseObject'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/stack-tile-box.h:38:34: note: Function 'StackTileBox' argument 1 names different: declaration 'base' definition 'baseObject'. lordsawar-0.3.2/src/gui/stack-tile-box.cpp:59:44: note: Function 'StackTileBox' argument 1 names different: declaration 'base' definition 'baseObject'. lordsawar-0.3.2/src/gui/tartan-progress-bar.h:47:5: style: Class 'TartanProgressBar' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/gui/stack-tile-box.cpp:184:74: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/status-box.cpp:54:38: style:inconclusive: Function 'StatusBox' argument 1 names different: declaration 'base' definition 'baseObject'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/status-box.h:38:31: note: Function 'StatusBox' argument 1 names different: declaration 'base' definition 'baseObject'. lordsawar-0.3.2/src/gui/status-box.cpp:54:38: note: Function 'StatusBox' argument 1 names different: declaration 'base' definition 'baseObject'. lordsawar-0.3.2/src/gui/surrender-refused-dialog.h:32:5: style: Class 'SurrenderRefusedDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/gui/surrender-dialog.cpp:27:59: style:inconclusive: Function 'SurrenderDialog' argument 2 names different: declaration 'numPlayers' definition 'numEnemies'. [funcArgNamesDifferent] lordsawar-0.3.2/src/gui/surrender-dialog.h:29:46: note: Function 'SurrenderDialog' argument 2 names different: declaration 'numPlayers' definition 'numEnemies'. lordsawar-0.3.2/src/gui/surrender-dialog.cpp:27:59: note: Function 'SurrenderDialog' argument 2 names different: declaration 'numPlayers' definition 'numEnemies'. lordsawar-0.3.2/src/MapGenerator.cpp:65:15: warning: Member variable 'MapGenerator::d_width' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/MapGenerator.cpp:65:15: warning: Member variable 'MapGenerator::d_height' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/MapGenerator.h:134:14: style:inconclusive: Technically the member function 'MapGenerator::printMap' can be const. [functionConst] lordsawar-0.3.2/src/MapGenerator.cpp:558:20: note: Technically the member function 'MapGenerator::printMap' can be const. lordsawar-0.3.2/src/MapGenerator.h:134:14: note: Technically the member function 'MapGenerator::printMap' can be const. lordsawar-0.3.2/src/MapGenerator.h:251:14: style:inconclusive: Technically the member function 'MapGenerator::seekPlain' can be const. [functionConst] lordsawar-0.3.2/src/MapGenerator.cpp:1146:20: note: Technically the member function 'MapGenerator::seekPlain' can be const. lordsawar-0.3.2/src/MapGenerator.h:251:14: note: Technically the member function 'MapGenerator::seekPlain' can be const. lordsawar-0.3.2/src/MapGenerator.h:287:14: style:inconclusive: Technically the member function 'MapGenerator::canPutBuildingTile' can be const. [functionConst] lordsawar-0.3.2/src/MapGenerator.cpp:1249:20: note: Technically the member function 'MapGenerator::canPutBuildingTile' can be const. lordsawar-0.3.2/src/MapGenerator.h:287:14: note: Technically the member function 'MapGenerator::canPutBuildingTile' can be const. lordsawar-0.3.2/src/MapGenerator.h:337:55: style:inconclusive: Technically the member function 'MapGenerator::findBridgePlaces' can be const. [functionConst] lordsawar-0.3.2/src/MapGenerator.cpp:1595:59: note: Technically the member function 'MapGenerator::findBridgePlaces' can be const. lordsawar-0.3.2/src/MapGenerator.h:337:55: note: Technically the member function 'MapGenerator::findBridgePlaces' can be const. lordsawar-0.3.2/src/MapGenerator.h:339:7: style:inconclusive: Technically the member function 'MapGenerator::calculateBlockedAvenue' can be const. [functionConst] lordsawar-0.3.2/src/MapGenerator.cpp:1438:20: note: Technically the member function 'MapGenerator::calculateBlockedAvenue' can be const. lordsawar-0.3.2/src/MapGenerator.h:339:7: note: Technically the member function 'MapGenerator::calculateBlockedAvenue' can be const. lordsawar-0.3.2/src/gui/use-item-dialog.cpp:38:30: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/triumphs-dialog.cpp:102:44: warning: Possible null pointer dereference: hero [nullPointer] lordsawar-0.3.2/src/gui/triumphs-dialog.cpp:87:27: note: Assignment 'hero=NULL', assigned value is 0 lordsawar-0.3.2/src/gui/triumphs-dialog.cpp:91:45: note: Assuming condition is false lordsawar-0.3.2/src/gui/triumphs-dialog.cpp:102:44: note: Null pointer dereference lordsawar-0.3.2/src/gui/triumphs-dialog.cpp:170:44: warning: Possible null pointer dereference: special [nullPointer] lordsawar-0.3.2/src/gui/triumphs-dialog.cpp:158:30: note: Assignment 'special=NULL', assigned value is 0 lordsawar-0.3.2/src/gui/triumphs-dialog.cpp:159:45: note: Assuming condition is false lordsawar-0.3.2/src/gui/triumphs-dialog.cpp:170:44: note: Null pointer dereference lordsawar-0.3.2/src/gui/triumphs-dialog.cpp:52:68: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/gui/use-item-on-player-dialog.h:35:5: style: Class 'UseItemOnPlayerDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/gui/use-item-on-player-dialog.cpp:54:64: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/MapGenerator.cpp:1622:54: style: Condition 'd_terrain[(j+1)*d_width+i]==Tile::WATER' is always true [knownConditionTrueFalse] lordsawar-0.3.2/src/MapGenerator.cpp:1614:48: note: Assuming that condition 'd_terrain[(j+1)*d_width+i]==Tile::WATER' is not redundant lordsawar-0.3.2/src/MapGenerator.cpp:1622:54: note: Condition 'd_terrain[(j+1)*d_width+i]==Tile::WATER' is always true lordsawar-0.3.2/src/MapGenerator.cpp:1623:54: style: Condition 'd_terrain[(j+2)*d_width+i]==Tile::WATER' is always true [knownConditionTrueFalse] lordsawar-0.3.2/src/MapGenerator.cpp:1615:48: note: Assuming that condition 'd_terrain[(j+2)*d_width+i]==Tile::WATER' is not redundant lordsawar-0.3.2/src/MapGenerator.cpp:1623:54: note: Condition 'd_terrain[(j+2)*d_width+i]==Tile::WATER' is always true lordsawar-0.3.2/src/MapGenerator.cpp:1631:54: style: Condition 'd_terrain[(j+1)*d_width+i+2]==Tile::WATER' is always true [knownConditionTrueFalse] lordsawar-0.3.2/src/MapGenerator.cpp:1616:48: note: Assuming that condition 'd_terrain[(j+1)*d_width+i+2]==Tile::WATER' is not redundant lordsawar-0.3.2/src/MapGenerator.cpp:1631:54: note: Condition 'd_terrain[(j+1)*d_width+i+2]==Tile::WATER' is always true lordsawar-0.3.2/src/MapGenerator.cpp:1632:54: style: Condition 'd_terrain[(j+2)*d_width+i+2]==Tile::WATER' is always true [knownConditionTrueFalse] lordsawar-0.3.2/src/MapGenerator.cpp:1617:48: note: Assuming that condition 'd_terrain[(j+2)*d_width+i+2]==Tile::WATER' is not redundant lordsawar-0.3.2/src/MapGenerator.cpp:1632:54: note: Condition 'd_terrain[(j+2)*d_width+i+2]==Tile::WATER' is always true lordsawar-0.3.2/src/MapGenerator.cpp:1661:54: style: Condition 'd_terrain[(j)*d_width+i+1]==Tile::WATER' is always true [knownConditionTrueFalse] lordsawar-0.3.2/src/MapGenerator.cpp:1653:48: note: Assuming that condition 'd_terrain[(j)*d_width+i+1]==Tile::WATER' is not redundant lordsawar-0.3.2/src/MapGenerator.cpp:1661:54: note: Condition 'd_terrain[(j)*d_width+i+1]==Tile::WATER' is always true lordsawar-0.3.2/src/MapGenerator.cpp:1662:54: style: Condition 'd_terrain[(j)*d_width+i+2]==Tile::WATER' is always true [knownConditionTrueFalse] lordsawar-0.3.2/src/MapGenerator.cpp:1654:48: note: Assuming that condition 'd_terrain[(j)*d_width+i+2]==Tile::WATER' is not redundant lordsawar-0.3.2/src/MapGenerator.cpp:1662:54: note: Condition 'd_terrain[(j)*d_width+i+2]==Tile::WATER' is always true lordsawar-0.3.2/src/MapGenerator.cpp:1671:54: style: Condition 'd_terrain[(j+2)*d_width+i+1]==Tile::WATER' is always true [knownConditionTrueFalse] lordsawar-0.3.2/src/MapGenerator.cpp:1655:48: note: Assuming that condition 'd_terrain[(j+2)*d_width+i+1]==Tile::WATER' is not redundant lordsawar-0.3.2/src/MapGenerator.cpp:1671:54: note: Condition 'd_terrain[(j+2)*d_width+i+1]==Tile::WATER' is always true lordsawar-0.3.2/src/MapGenerator.cpp:1672:54: style: Condition 'd_terrain[(j+2)*d_width+i+2]==Tile::WATER' is always true [knownConditionTrueFalse] lordsawar-0.3.2/src/MapGenerator.cpp:1656:48: note: Assuming that condition 'd_terrain[(j+2)*d_width+i+2]==Tile::WATER' is not redundant lordsawar-0.3.2/src/MapGenerator.cpp:1672:54: note: Condition 'd_terrain[(j+2)*d_width+i+2]==Tile::WATER' is always true lordsawar-0.3.2/src/MapGenerator.cpp:745:9: style: The scope of the variable 'max' can be reduced. [variableScope] lordsawar-0.3.2/src/MapGenerator.cpp:781:9: style: The scope of the variable 'how_many' can be reduced. [variableScope] lordsawar-0.3.2/src/MapGenerator.cpp:347:65: style:inconclusive: Function 'makeStandingStones' argument 1 names different: declaration 'roads' definition 'also_roads'. [funcArgNamesDifferent] lordsawar-0.3.2/src/MapGenerator.h:216:59: note: Function 'makeStandingStones' argument 1 names different: declaration 'roads' definition 'also_roads'. lordsawar-0.3.2/src/MapGenerator.cpp:347:65: note: Function 'makeStandingStones' argument 1 names different: declaration 'roads' definition 'also_roads'. lordsawar-0.3.2/src/MapGenerator.cpp:1060:44: style:inconclusive: Function 'makeStreamer' argument 1 names different: declaration 'type' definition 't'. [funcArgNamesDifferent] lordsawar-0.3.2/src/MapGenerator.h:178:38: note: Function 'makeStreamer' argument 1 names different: declaration 'type' definition 't'. lordsawar-0.3.2/src/MapGenerator.cpp:1060:44: note: Function 'makeStreamer' argument 1 names different: declaration 'type' definition 't'. lordsawar-0.3.2/src/MapGenerator.cpp:1060:64: style:inconclusive: Function 'makeStreamer' argument 3 names different: declaration 'width' definition 'thick'. [funcArgNamesDifferent] lordsawar-0.3.2/src/MapGenerator.h:178:61: note: Function 'makeStreamer' argument 3 names different: declaration 'width' definition 'thick'. lordsawar-0.3.2/src/MapGenerator.cpp:1060:64: note: Function 'makeStreamer' argument 3 names different: declaration 'width' definition 'thick'. lordsawar-0.3.2/src/MapGenerator.cpp:1536:55: style:inconclusive: Function 'makeAccessible' argument 1 names different: declaration 'pcl' definition 'pc_land'. [funcArgNamesDifferent] lordsawar-0.3.2/src/MapGenerator.h:303:42: note: Function 'makeAccessible' argument 1 names different: declaration 'pcl' definition 'pc_land'. lordsawar-0.3.2/src/MapGenerator.cpp:1536:55: note: Function 'makeAccessible' argument 1 names different: declaration 'pcl' definition 'pc_land'. lordsawar-0.3.2/src/MapGenerator.cpp:1536:84: style:inconclusive: Function 'makeAccessible' argument 2 names different: declaration 'pcf' definition 'pc_fly'. [funcArgNamesDifferent] lordsawar-0.3.2/src/MapGenerator.h:303:67: note: Function 'makeAccessible' argument 2 names different: declaration 'pcf' definition 'pc_fly'. lordsawar-0.3.2/src/MapGenerator.cpp:1536:84: note: Function 'makeAccessible' argument 2 names different: declaration 'pcf' definition 'pc_fly'. lordsawar-0.3.2/src/MapGenerator.cpp:887:39: style: Local variable 'dist' shadows outer function [shadowFunction] lordsawar-0.3.2/src/vector.h:180:10: note: Shadowed declaration lordsawar-0.3.2/src/MapGenerator.cpp:887:39: note: Shadow variable lordsawar-0.3.2/src/MapGenerator.cpp:905:39: style: Local variable 'dist' shadows outer function [shadowFunction] lordsawar-0.3.2/src/vector.h:180:10: note: Shadowed declaration lordsawar-0.3.2/src/MapGenerator.cpp:905:39: note: Shadow variable lordsawar-0.3.2/src/MapGenerator.cpp:1269:7: style: Local variable 'dist' shadows outer function [shadowFunction] lordsawar-0.3.2/src/vector.h:180:10: note: Shadowed declaration lordsawar-0.3.2/src/MapGenerator.cpp:1269:7: note: Shadow variable lordsawar-0.3.2/src/MapGenerator.cpp:1239:93: performance: Function parameter 'allowed' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/MapGenerator.cpp:1249:95: performance: Function parameter 'allowed' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/heroesmap.cpp:28:3: performance: Variable 'heroes' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/MapGenerator.cpp:1730:9: style: Variable 'center' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/MapGenerator.cpp:1783:13: style: Variable 'c' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/heroesmap.h:43:6: style: Class 'HeroesMap' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/heroesmap.h:46:7: style: The destructor '~HeroesMap' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:63:15: note: Virtual destructor in base class lordsawar-0.3.2/src/heroesmap.h:46:7: note: Destructor in derived class lordsawar-0.3.2/src/heroesmap.h:76:18: style: The function 'after_draw' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:221:18: note: Virtual function in base class lordsawar-0.3.2/src/heroesmap.h:76:18: note: Function in derived class lordsawar-0.3.2/src/heroesmap.cpp:26:39: style:inconclusive: Function 'HeroesMap' argument 1 names different: declaration 'heroes' definition 'h'. [funcArgNamesDifferent] lordsawar-0.3.2/src/heroesmap.h:43:33: note: Function 'HeroesMap' argument 1 names different: declaration 'heroes' definition 'h'. lordsawar-0.3.2/src/heroesmap.cpp:26:39: note: Function 'HeroesMap' argument 1 names different: declaration 'heroes' definition 'h'. lordsawar-0.3.2/src/heroesmap.cpp:26:39: performance: Function parameter 'h' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/heroesmap.cpp:39:15: style: Variable 'player' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/heroesmap.cpp:55:15: style: Variable 'active' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/MapGenerator.cpp:1254:7: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/MapGenerator.cpp:1322:20: style: Consider using std::copy_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/heroesmap.cpp:37:8: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/MapGenerator.cpp:1384:22: style: Variable 'curTer' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/MapGenerator.cpp:1384:40: style: Variable 'ajTer' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/MapGenerator.cpp:488:29: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/MapGenerator.cpp:1546:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/MapGenerator.cpp:1547:36: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/heromap.h:42:6: style: Class 'HeroMap' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/heromap.h:45:7: style: The destructor '~HeroMap' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:63:15: note: Virtual destructor in base class lordsawar-0.3.2/src/heromap.h:45:7: note: Destructor in derived class lordsawar-0.3.2/src/heromap.h:64:18: style: The function 'after_draw' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:221:18: note: Virtual function in base class lordsawar-0.3.2/src/heromap.h:64:18: note: Function in derived class lordsawar-0.3.2/src/heromap.cpp:23:24: style:inconclusive: Function 'HeroMap' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/heromap.h:42:20: note: Function 'HeroMap' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/heromap.cpp:23:24: note: Function 'HeroMap' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/hero.cpp:160:56: style:inconclusive: Function 'friendlyNameToGender' argument 1 names different: declaration 'name' definition 'str'. [funcArgNamesDifferent] lordsawar-0.3.2/src/hero.h:156:65: note: Function 'friendlyNameToGender' argument 1 names different: declaration 'name' definition 'str'. lordsawar-0.3.2/src/hero.cpp:160:56: note: Function 'friendlyNameToGender' argument 1 names different: declaration 'name' definition 'str'. lordsawar-0.3.2/src/hero.cpp:73:38: style: Unused variable: it [unusedVariable] lordsawar-0.3.2/src/heroproto.cpp:29:39: style:inconclusive: Function 'HeroProto' argument 1 names different: declaration 'heroproto' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/heroproto.h:37:36: note: Function 'HeroProto' argument 1 names different: declaration 'heroproto' definition 'a'. lordsawar-0.3.2/src/heroproto.cpp:29:39: note: Function 'HeroProto' argument 1 names different: declaration 'heroproto' definition 'a'. lordsawar-0.3.2/src/heroproto.cpp:34:39: style:inconclusive: Function 'HeroProto' argument 1 names different: declaration 'heroproto' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/heroproto.h:40:36: note: Function 'HeroProto' argument 1 names different: declaration 'heroproto' definition 'a'. lordsawar-0.3.2/src/heroproto.cpp:34:39: note: Function 'HeroProto' argument 1 names different: declaration 'heroproto' definition 'a'. lordsawar-0.3.2/src/history.cpp:312:69: style:inconclusive: Function 'History_HeroEmerges' argument 1 names different: declaration 'history' definition 'h'. [funcArgNamesDifferent] lordsawar-0.3.2/src/history.h:225:49: note: Function 'History_HeroEmerges' argument 1 names different: declaration 'history' definition 'h'. lordsawar-0.3.2/src/history.cpp:312:69: note: Function 'History_HeroEmerges' argument 1 names different: declaration 'history' definition 'h'. lordsawar-0.3.2/src/history.cpp:884:69: style:inconclusive: Function 'History_HeroUseItem' argument 1 names different: declaration 'history' definition 'h'. [funcArgNamesDifferent] lordsawar-0.3.2/src/history.h:772:49: note: Function 'History_HeroUseItem' argument 1 names different: declaration 'history' definition 'h'. lordsawar-0.3.2/src/history.cpp:884:69: note: Function 'History_HeroUseItem' argument 1 names different: declaration 'history' definition 'h'. lordsawar-0.3.2/src/history.cpp:248:44: style: Parameter 'hero' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:306:48: style: Parameter 'hero' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:306:60: style: Parameter 'city' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:344:40: style: Parameter 'city' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:373:48: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:373:57: style: Parameter 'h' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:408:44: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:437:58: style: Parameter 'h' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:466:62: style: Parameter 'h' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:495:58: style: Parameter 'h' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:495:67: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:530:62: style: Parameter 'h' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:559:64: style: Parameter 'h' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:647:56: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:676:52: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:705:64: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:734:56: style: Parameter 'h' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:793:58: style: Parameter 'h' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:793:67: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:828:54: style: Parameter 'h' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:828:63: style: Parameter 'r' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:863:48: style: Parameter 'h' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:863:57: style: Parameter 'i' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:864:50: style: Parameter 'opponent' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:864:66: style: Parameter 'friendly_city' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:865:48: style: Parameter 'enemy_city' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:865:66: style: Parameter 'neutral_city' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/history.cpp:866:48: style: Parameter 'c' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/herotemplates.cpp:74:3: warning: Calling method 'loadHeroTemplates()' when 'this' might be invalid [thisUseAfterFree] lordsawar-0.3.2/src/herotemplates.h:99:31: note: Assuming 'd_instance' is used as 'this' lordsawar-0.3.2/src/herotemplates.cpp:57:5: note: Delete 'd_instance', invalidating 'this' lordsawar-0.3.2/src/herotemplates.cpp:74:3: note: Call method when 'this' is invalid lordsawar-0.3.2/src/herotemplates.cpp:127:11: style: Variable 'p' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/herotemplates.cpp:268:24: style: Variable 'h' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/herotemplates.cpp:208:9: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/hosted-game.cpp:35:3: performance: Variable 'd_pid' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/keeper.cpp:93:11: style: Variable 'p' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/main.cpp:173:134: error: There is an unknown macro here somewhere. Configuration is required. If PACKAGE is a macro then please configure it. [unknownMacro] lordsawar-0.3.2/src/historymap.h:48:7: style: The destructor '~HistoryMap' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:63:15: note: Virtual destructor in base class lordsawar-0.3.2/src/historymap.h:48:7: note: Destructor in derived class lordsawar-0.3.2/src/historymap.h:80:19: style: The function 'after_draw' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:221:18: note: Virtual function in base class lordsawar-0.3.2/src/historymap.h:80:19: note: Function in derived class lordsawar-0.3.2/src/itemmap.cpp:27:3: performance: Variable 'stacks' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/itemmap.cpp:28:3: performance: Variable 'bags' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/itemmap.h:47:7: style: The destructor '~ItemMap' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:63:15: note: Virtual destructor in base class lordsawar-0.3.2/src/itemmap.h:47:7: note: Destructor in derived class lordsawar-0.3.2/src/itemmap.h:78:18: style: The function 'after_draw' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:221:18: note: Virtual function in base class lordsawar-0.3.2/src/itemmap.h:78:18: note: Function in derived class lordsawar-0.3.2/src/itemmap.cpp:25:79: style:inconclusive: Function 'ItemMap' argument 2 names different: declaration 'bags' definition 'bags_of_stuff'. [funcArgNamesDifferent] lordsawar-0.3.2/src/itemmap.h:44:75: note: Function 'ItemMap' argument 2 names different: declaration 'bags' definition 'bags_of_stuff'. lordsawar-0.3.2/src/itemmap.cpp:25:79: note: Function 'ItemMap' argument 2 names different: declaration 'bags' definition 'bags_of_stuff'. lordsawar-0.3.2/src/itemmap.cpp:25:36: performance: Function parameter 'item_laden_stacks' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/itemmap.cpp:25:79: performance: Function parameter 'bags_of_stuff' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/itemmap.cpp:43:8: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/itemmap.cpp:50:8: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/maptile.cpp:29:10: warning: Member variable 'Maptile::d_blocked' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/maptile.cpp:37:10: warning: Member variable 'Maptile::d_blocked' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/maptile.cpp:45:10: warning: Member variable 'Maptile::d_blocked' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/maptile.h:176:14: style:inconclusive: Technically the member function 'Maptile::isCityTerrain' can be const. [functionConst] lordsawar-0.3.2/src/maptile.cpp:131:15: note: Technically the member function 'Maptile::isCityTerrain' can be const. lordsawar-0.3.2/src/maptile.h:176:14: note: Technically the member function 'Maptile::isCityTerrain' can be const. lordsawar-0.3.2/src/maptile.h:182:14: style:inconclusive: Technically the member function 'Maptile::isRoadTerrain' can be const. [functionConst] lordsawar-0.3.2/src/maptile.cpp:139:15: note: Technically the member function 'Maptile::isRoadTerrain' can be const. lordsawar-0.3.2/src/maptile.h:182:14: note: Technically the member function 'Maptile::isRoadTerrain' can be const. lordsawar-0.3.2/src/maptile.cpp:37:40: style:inconclusive: Function 'Maptile' argument 3 names different: declaration 'type' definition 'index'. [funcArgNamesDifferent] lordsawar-0.3.2/src/maptile.h:89:39: note: Function 'Maptile' argument 3 names different: declaration 'type' definition 'index'. lordsawar-0.3.2/src/maptile.cpp:37:40: note: Function 'Maptile' argument 3 names different: declaration 'type' definition 'index'. lordsawar-0.3.2/src/maptile.cpp:125:9: style: Variable 'tile' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/namelist.cpp:34:3: performance: Variable 'd_item_tag' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/network-connection.cpp:132:20: warning: Member variable 'NetworkConnection::payload_left' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/network-connection.cpp:132:20: warning: Member variable 'NetworkConnection::payload_size' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/network-connection.cpp:132:20: warning: Member variable 'NetworkConnection::header' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/network-connection.cpp:132:20: warning: Member variable 'NetworkConnection::header_left' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/network-connection.cpp:132:20: warning: Member variable 'NetworkConnection::header_size' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/network-connection.cpp:132:20: warning: Member variable 'NetworkConnection::d_bail' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/network-connection.cpp:122:3: performance: Variable 'client' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/network-connection.cpp:136:3: performance: Variable 'client' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/network-connection.cpp:351:11: style: Condition 'd_stop' is always false [knownConditionTrueFalse] lordsawar-0.3.2/src/network-connection.cpp:348:11: note: Assuming that condition 'd_stop' is not redundant lordsawar-0.3.2/src/network-connection.cpp:351:11: note: Condition 'd_stop' is always false lordsawar-0.3.2/src/network-connection.cpp:373:19: style: Condition 'd_stop' is always false [knownConditionTrueFalse] lordsawar-0.3.2/src/network-connection.cpp:368:15: note: Assuming that condition 'd_stop' is not redundant lordsawar-0.3.2/src/network-connection.cpp:373:19: note: Condition 'd_stop' is always false lordsawar-0.3.2/src/network-connection.cpp:376:19: style: Condition 'd_stop' is always false [knownConditionTrueFalse] lordsawar-0.3.2/src/network-connection.cpp:368:15: note: Assuming that condition 'd_stop' is not redundant lordsawar-0.3.2/src/network-connection.cpp:376:19: note: Condition 'd_stop' is always false lordsawar-0.3.2/src/network-connection.cpp:379:15: style: Condition 'd_stop' is always false [knownConditionTrueFalse] lordsawar-0.3.2/src/network-connection.cpp:368:15: note: Assuming that condition 'd_stop' is not redundant lordsawar-0.3.2/src/network-connection.cpp:379:15: note: Condition 'd_stop' is always false lordsawar-0.3.2/src/network-connection.cpp:183:13: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/network-connection.cpp:271:38: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/network-connection.cpp:274:22: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/network-connection.cpp:287:16: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/network-connection.cpp:324:59: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/network-connection.cpp:117:81: style:inconclusive: Function 'NetworkConnection' argument 1 names different: declaration 'conn' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/network-connection.h:40:64: note: Function 'NetworkConnection' argument 1 names different: declaration 'conn' definition 'c'. lordsawar-0.3.2/src/network-connection.cpp:117:81: note: Function 'NetworkConnection' argument 1 names different: declaration 'conn' definition 'c'. lordsawar-0.3.2/src/network-connection.cpp:245:61: style:inconclusive: Function 'send' argument 2 names different: declaration 'payload' definition 'pay'. [funcArgNamesDifferent] lordsawar-0.3.2/src/network-connection.h:54:44: note: Function 'send' argument 2 names different: declaration 'payload' definition 'pay'. lordsawar-0.3.2/src/network-connection.cpp:245:61: note: Function 'send' argument 2 names different: declaration 'payload' definition 'pay'. lordsawar-0.3.2/src/network-connection.cpp:283:68: style:inconclusive: Function 'sendMessage' argument 2 names different: declaration 'payload' definition 'pay'. [funcArgNamesDifferent] lordsawar-0.3.2/src/network-connection.h:105:51: note: Function 'sendMessage' argument 2 names different: declaration 'payload' definition 'pay'. lordsawar-0.3.2/src/network-connection.cpp:283:68: note: Function 'sendMessage' argument 2 names different: declaration 'payload' definition 'pay'. lordsawar-0.3.2/src/network-connection.cpp:342:70: style:inconclusive: Function 'queue_message' argument 2 names different: declaration 'payload' definition 'pay'. [funcArgNamesDifferent] lordsawar-0.3.2/src/network-connection.h:104:53: note: Function 'queue_message' argument 2 names different: declaration 'payload' definition 'pay'. lordsawar-0.3.2/src/network-connection.cpp:342:70: note: Function 'queue_message' argument 2 names different: declaration 'payload' definition 'pay'. lordsawar-0.3.2/src/network-connection.cpp:90:26: style: Variable 'ex' can be declared as reference to const [constVariableReference] lordsawar-0.3.2/src/network-connection.cpp:381:44: warning: Either the condition 'messages.empty()' is redundant or expression 'messages.front()' causes access out of bounds. [containerOutOfBounds] lordsawar-0.3.2/src/network-connection.cpp:371:31: note: Assuming that condition 'messages.empty()' is not redundant lordsawar-0.3.2/src/network-connection.cpp:381:44: note: Access out of bounds lordsawar-0.3.2/src/network-connection.cpp:382:23: warning: Either the condition 'messages.empty()' is redundant or expression 'messages.pop()' causes access out of bounds. [containerOutOfBounds] lordsawar-0.3.2/src/network-connection.cpp:371:31: note: Assuming that condition 'messages.empty()' is not redundant lordsawar-0.3.2/src/network-connection.cpp:382:23: note: Access out of bounds lordsawar-0.3.2/src/network-connection.cpp:277:17: style: Variable 'wrote_all' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/network-server.h:44:8: performance:inconclusive: Technically the member function 'NetworkServer::send' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/network-server.cpp:67:21: note: Technically the member function 'NetworkServer::send' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/network-server.h:44:8: note: Technically the member function 'NetworkServer::send' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/network-server.h:45:8: performance:inconclusive: Technically the member function 'NetworkServer::sendFile' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/network-server.cpp:73:21: note: Technically the member function 'NetworkServer::sendFile' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/network-server.h:45:8: note: Technically the member function 'NetworkServer::sendFile' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/network-server.h:46:17: performance:inconclusive: Technically the member function 'NetworkServer::get_hostname' can be static (but you may consider moving to unnamed namespace). [functionStatic] lordsawar-0.3.2/src/network-server.cpp:122:30: note: Technically the member function 'NetworkServer::get_hostname' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/network-server.h:46:17: note: Technically the member function 'NetworkServer::get_hostname' can be static (but you may consider moving to unnamed namespace). lordsawar-0.3.2/src/network-server.cpp:67:32: style:inconclusive: Function 'send' argument 1 names different: declaration 'conn' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/network-server.h:44:19: note: Function 'send' argument 1 names different: declaration 'conn' definition 'c'. lordsawar-0.3.2/src/network-server.cpp:67:32: note: Function 'send' argument 1 names different: declaration 'conn' definition 'c'. lordsawar-0.3.2/src/network-server.cpp:122:49: style:inconclusive: Function 'get_hostname' argument 1 names different: declaration 'conn' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/network-server.h:46:36: note: Function 'get_hostname' argument 1 names different: declaration 'conn' definition 'c'. lordsawar-0.3.2/src/network-server.cpp:122:49: note: Function 'get_hostname' argument 1 names different: declaration 'conn' definition 'c'. lordsawar-0.3.2/src/network-action.cpp:30:16: warning: Member variable 'NetworkAction::d_action' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/network-action.cpp:40:21: warning: The class 'NetworkAction' defines member function with name 'save' also defined in its parent class 'OwnerId'. [duplInheritedMember] lordsawar-0.3.2/src/OwnerId.h:59:10: note: Parent function 'OwnerId::save' lordsawar-0.3.2/src/network-action.cpp:40:21: note: Derived function 'NetworkAction::save' lordsawar-0.3.2/src/network-history.cpp:32:17: warning: Member variable 'NetworkHistory::d_history' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/network-history.cpp:42:22: warning: The class 'NetworkHistory' defines member function with name 'save' also defined in its parent class 'OwnerId'. [duplInheritedMember] lordsawar-0.3.2/src/OwnerId.h:59:10: note: Parent function 'OwnerId::save' lordsawar-0.3.2/src/network-history.cpp:42:22: note: Derived function 'NetworkHistory::save' lordsawar-0.3.2/src/network-history.cpp:26:41: style: Parameter 'history' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/path.cpp:108:29: style:inconclusive: Function 'checkPath' argument 1 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/path.h:76:31: note: Function 'checkPath' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/path.cpp:108:29: note: Function 'checkPath' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/path.cpp:216:60: style:inconclusive: Function 'calculate' argument 3 names different: declaration 'mp' definition 'moves'. [funcArgNamesDifferent] lordsawar-0.3.2/src/path.h:129:55: note: Function 'calculate' argument 3 names different: declaration 'mp' definition 'moves'. lordsawar-0.3.2/src/path.cpp:216:60: note: Function 'calculate' argument 3 names different: declaration 'mp' definition 'moves'. lordsawar-0.3.2/src/path.cpp:282:33: style:inconclusive: Function 'calculate' argument 1 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/path.h:99:34: note: Function 'calculate' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/path.cpp:282:33: note: Function 'calculate' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/path.cpp:289:33: style:inconclusive: Function 'calculate' argument 1 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/path.h:100:34: note: Function 'calculate' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/path.cpp:289:33: note: Function 'calculate' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/path.cpp:201:10: style: Local variable 'dist' shadows outer function [shadowFunction] lordsawar-0.3.2/src/vector.h:180:10: note: Shadowed declaration lordsawar-0.3.2/src/path.cpp:201:10: note: Shadow variable lordsawar-0.3.2/src/path.cpp:142:13: style: Variable 'c' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/path.cpp:53:54: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/path.cpp:91:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/path.cpp:116:2: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/path.cpp:117:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/path.cpp:139:24: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/path.cpp:260:86: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/path.cpp:267:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/network_player.cpp:113:55: style:inconclusive: Function 'chooseHero' argument 2 names different: declaration 'c' definition 'city'. [funcArgNamesDifferent] lordsawar-0.3.2/src/network_player.h:101:56: note: Function 'chooseHero' argument 2 names different: declaration 'c' definition 'city'. lordsawar-0.3.2/src/network_player.cpp:113:55: note: Function 'chooseHero' argument 2 names different: declaration 'c' definition 'city'. lordsawar-0.3.2/src/network_player.cpp:221:48: style:inconclusive: Function 'decodeAction' argument 1 names different: declaration 'action' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/network_player.h:114:34: note: Function 'decodeAction' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/network_player.cpp:221:48: note: Function 'decodeAction' argument 1 names different: declaration 'action' definition 'a'. lordsawar-0.3.2/src/network_player.cpp:708:77: style:inconclusive: Function 'decodeActionModifySignpost' argument 1 names different: declaration 'action' definition 'act'. [funcArgNamesDifferent] lordsawar-0.3.2/src/network_player.h:140:63: note: Function 'decodeActionModifySignpost' argument 1 names different: declaration 'action' definition 'act'. lordsawar-0.3.2/src/network_player.cpp:708:77: note: Function 'decodeActionModifySignpost' argument 1 names different: declaration 'action' definition 'act'. lordsawar-0.3.2/src/network_player.cpp:211:55: performance: Function parameter 'actions' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/network_player.cpp:357:13: style: Variable 's' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/network_player.cpp:662:10: style: Variable 'stack' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/network_player.cpp:688:10: style: Variable 'stack' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/network_player.cpp:741:10: style: Variable 'stack' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/network_player.cpp:785:10: style: Variable 'expected' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/network_player.cpp:803:9: style: Variable 'army' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/network_player.cpp:848:14: style: Variable 'ally' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/network_player.cpp:853:9: style: Variable 'hero' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/network_player.cpp:899:10: style: Variable 'stack' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/network_player.cpp:925:11: style: Variable 'p' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/network_player.cpp:970:11: style: Variable 'p' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/network_player.cpp:217:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/network_player.cpp:881:82: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/network_player.cpp:940:70: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/network_player.cpp:953:55: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/network_player.cpp:957:70: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/network_player.cpp:962:55: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/overviewmap.cpp:319:46: style:inconclusive: Function 'draw_terrain_tile' argument 1 names different: declaration 'tile' definition 't'. [funcArgNamesDifferent] lordsawar-0.3.2/src/overviewmap.h:186:38: note: Function 'draw_terrain_tile' argument 1 names different: declaration 'tile' definition 't'. lordsawar-0.3.2/src/overviewmap.cpp:319:46: note: Function 'draw_terrain_tile' argument 1 names different: declaration 'tile' definition 't'. lordsawar-0.3.2/src/overviewmap.cpp:718:68: style:inconclusive: Function 'draw_target_box' argument 2 names different: declaration 'colour' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/overviewmap.h:255:59: note: Function 'draw_target_box' argument 2 names different: declaration 'colour' definition 'c'. lordsawar-0.3.2/src/overviewmap.cpp:718:68: note: Function 'draw_target_box' argument 2 names different: declaration 'colour' definition 'c'. lordsawar-0.3.2/src/overviewmap.cpp:748:70: warning: Function 'draw_radial_gradient' argument order different: declaration 'surface, inner, outer, height, width' definition 'surface, inner, outer, width, height' [funcArgOrderDifferent] lordsawar-0.3.2/src/overviewmap.h:149:68: note: Function 'draw_radial_gradient' argument order different: declaration 'surface, inner, outer, height, width' definition 'surface, inner, outer, width, height' lordsawar-0.3.2/src/overviewmap.cpp:748:70: note: Function 'draw_radial_gradient' argument order different: declaration 'surface, inner, outer, height, width' definition 'surface, inner, outer, width, height' lordsawar-0.3.2/src/overviewmap.cpp:407:14: style: Variable 'ts' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/overviewmap.cpp:513:12: style: Variable 'ts' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/overviewmap.cpp:534:13: style: Variable 'r' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/overviewmap.cpp:554:15: style: Variable 't' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/overviewmap.cpp:661:13: style: Variable 'c' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/overviewmap.cpp:422:12: style: Variable 'tiles.pos' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/overviewmap.cpp:423:12: style: Variable 'tiles.dim' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/overviewmap.cpp:532:46: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/overviewmap.cpp:552:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/overviewmap.cpp:659:45: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/portlist.cpp:71:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:98:5: warning: Calling method 'load()' when 'this' might be invalid [thisUseAfterFree] lordsawar-0.3.2/src/playerlist.h:352:28: note: Assuming 's_instance' is used as 'this' lordsawar-0.3.2/src/playerlist.cpp:78:9: note: Delete 's_instance', invalidating 'this' lordsawar-0.3.2/src/playerlist.cpp:98:5: note: Call method when 'this' is invalid lordsawar-0.3.2/src/playerlist.cpp:730:59: style:inconclusive: Function 'turnHumansInto' argument 2 names different: declaration 'num_players' definition 'number_of_players'. [funcArgNamesDifferent] lordsawar-0.3.2/src/playerlist.h:180:48: note: Function 'turnHumansInto' argument 2 names different: declaration 'num_players' definition 'number_of_players'. lordsawar-0.3.2/src/playerlist.cpp:730:59: note: Function 'turnHumansInto' argument 2 names different: declaration 'num_players' definition 'number_of_players'. lordsawar-0.3.2/src/playerlist.cpp:702:66: performance: Function parameter 'players' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/playerlist.cpp:816:45: performance: Function parameter 'order' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/playerlist.cpp:367:16: style: Variable 'deplete' can be declared as const array [constVariable] lordsawar-0.3.2/src/playerlist.cpp:610:18: style: Variable 'shieldset' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/playerlist.cpp:124:13: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:132:13: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:165:17: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:180:9: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:208:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:219:41: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:236:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:332:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:340:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:358:33: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:387:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:407:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:418:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:442:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:452:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:466:46: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:474:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:584:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:705:30: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:713:42: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:725:66: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:733:42: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:797:37: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:806:37: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:840:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:854:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:874:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:892:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:902:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:908:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:968:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:980:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/playerlist.cpp:987:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/profile.cpp:33:3: performance: Variable 'd_id' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/profilelist.cpp:114:57: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/profilelist.cpp:125:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/profilelist.cpp:152:61: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/profilelist.cpp:168:61: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/prodslotlist.cpp:159:42: style:inconclusive: Function 'addProductionBase' argument 1 names different: declaration 'index' definition 'idx'. [funcArgNamesDifferent] lordsawar-0.3.2/src/prodslotlist.h:177:36: note: Function 'addProductionBase' argument 1 names different: declaration 'index' definition 'idx'. lordsawar-0.3.2/src/prodslotlist.cpp:159:42: note: Function 'addProductionBase' argument 1 names different: declaration 'index' definition 'idx'. lordsawar-0.3.2/src/prodslotlist.cpp:194:45: style:inconclusive: Function 'removeProductionBase' argument 1 names different: declaration 'index' definition 'idx'. [funcArgNamesDifferent] lordsawar-0.3.2/src/prodslotlist.h:185:39: note: Function 'removeProductionBase' argument 1 names different: declaration 'index' definition 'idx'. lordsawar-0.3.2/src/prodslotlist.cpp:194:45: note: Function 'removeProductionBase' argument 1 names different: declaration 'index' definition 'idx'. lordsawar-0.3.2/src/prodslotlist.cpp:269:18: style: Variable 'a' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/prodslotlist.cpp:146:19: style: Variable 'index' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/prodslotlist.cpp:76:23: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:1852:12: style: Condition 'type!=-1' is always true [knownConditionTrueFalse] lordsawar-0.3.2/src/player.cpp:1848:12: note: Assuming that condition 'type<=-1' is not redundant lordsawar-0.3.2/src/player.cpp:1852:12: note: Condition 'type!=-1' is always true lordsawar-0.3.2/src/player.cpp:3149:22: style: Condition 'stackDisband(new_stack)' is always true [knownConditionTrueFalse] lordsawar-0.3.2/src/player.cpp:1962:31: note: Calling function 'doStackDisband' returns 1 lordsawar-0.3.2/src/player.cpp:1962:31: note: Assignment 'retval=doStackDisband(s)', assigned value is 1 lordsawar-0.3.2/src/player.cpp:3149:22: note: Calling function 'stackDisband' returns 1 lordsawar-0.3.2/src/player.cpp:3149:22: note: Condition 'stackDisband(new_stack)' is always true lordsawar-0.3.2/src/player.cpp:3190:24: style: Condition 'stackDisband(new_stack)' is always true [knownConditionTrueFalse] lordsawar-0.3.2/src/player.cpp:1962:31: note: Calling function 'doStackDisband' returns 1 lordsawar-0.3.2/src/player.cpp:1962:31: note: Assignment 'retval=doStackDisband(s)', assigned value is 1 lordsawar-0.3.2/src/player.cpp:3190:24: note: Calling function 'stackDisband' returns 1 lordsawar-0.3.2/src/player.cpp:3190:24: note: Condition 'stackDisband(new_stack)' is always true lordsawar-0.3.2/src/player.cpp:3364:11: style: Condition 'stack' is always true [knownConditionTrueFalse] lordsawar-0.3.2/src/player.cpp:4309:20: style: Condition 'doHeroUseItem(hero,item,victim,friendly_city,enemy_city,neutral_city,city)' is always true [knownConditionTrueFalse] lordsawar-0.3.2/src/player.cpp:4309:20: note: Calling function 'doHeroUseItem' returns 1 lordsawar-0.3.2/src/player.cpp:4309:20: note: Condition 'doHeroUseItem(hero,item,victim,friendly_city,enemy_city,neutral_city,city)' is always true lordsawar-0.3.2/src/player.cpp:2293:35: warning: Either the condition '*it' is redundant or there is possible null pointer dereference: *it. [nullPointerRedundantCheck] lordsawar-0.3.2/src/player.cpp:2289:14: note: Assuming that condition '*it' is not redundant lordsawar-0.3.2/src/player.cpp:2293:35: note: Null pointer dereference lordsawar-0.3.2/src/player.cpp:1311:14: style: Variable 'exists' is reassigned a value before the old one has been used. [redundantAssignment] lordsawar-0.3.2/src/player.cpp:1309:12: note: exists is assigned lordsawar-0.3.2/src/player.cpp:1311:14: note: exists is overwritten lordsawar-0.3.2/src/player.cpp:1446:23: style: The scope of the variable 'defender_history' can be reduced. [variableScope] lordsawar-0.3.2/src/player.cpp:1265:72: style:inconclusive: Function 'finishStackFight' argument 3 names different: declaration 'def' definition 'defender'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:521:72: note: Function 'finishStackFight' argument 3 names different: declaration 'def' definition 'defender'. lordsawar-0.3.2/src/player.cpp:1265:72: note: Function 'finishStackFight' argument 3 names different: declaration 'def' definition 'defender'. lordsawar-0.3.2/src/player.cpp:1443:40: style:inconclusive: Function 'stackSearchRuin' argument 1 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:538:40: note: Function 'stackSearchRuin' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:1443:40: note: Function 'stackSearchRuin' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:1443:49: style:inconclusive: Function 'stackSearchRuin' argument 2 names different: declaration 'ruin' definition 'r'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:538:53: note: Function 'stackSearchRuin' argument 2 names different: declaration 'ruin' definition 'r'. lordsawar-0.3.2/src/player.cpp:1443:49: note: Function 'stackSearchRuin' argument 2 names different: declaration 'ruin' definition 'r'. lordsawar-0.3.2/src/player.cpp:1499:37: style:inconclusive: Function 'stackVisitTemple' argument 1 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:553:37: note: Function 'stackVisitTemple' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:1499:37: note: Function 'stackVisitTemple' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:1499:48: style:inconclusive: Function 'stackVisitTemple' argument 2 names different: declaration 'temple' definition 't'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:553:52: note: Function 'stackVisitTemple' argument 2 names different: declaration 'temple' definition 't'. lordsawar-0.3.2/src/player.cpp:1499:48: note: Function 'stackVisitTemple' argument 2 names different: declaration 'temple' definition 't'. lordsawar-0.3.2/src/player.cpp:1526:49: style:inconclusive: Function 'heroGetQuest' argument 2 names different: declaration 'temple' definition 't'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:751:49: note: Function 'heroGetQuest' argument 2 names different: declaration 'temple' definition 't'. lordsawar-0.3.2/src/player.cpp:1526:49: note: Function 'heroGetQuest' argument 2 names different: declaration 'temple' definition 't'. lordsawar-0.3.2/src/player.cpp:1542:39: style:inconclusive: Function 'stackFightAdvise' argument 1 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:568:39: note: Function 'stackFightAdvise' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:1542:39: note: Function 'stackFightAdvise' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:1691:31: style:inconclusive: Function 'cityOccupy' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:868:31: note: Function 'cityOccupy' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/player.cpp:1691:31: note: Function 'cityOccupy' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/player.cpp:1750:32: style:inconclusive: Function 'cityPillage' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:889:32: note: Function 'cityPillage' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/player.cpp:1750:32: note: Function 'cityPillage' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/player.cpp:1800:29: style:inconclusive: Function 'citySack' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:914:29: note: Function 'citySack' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/player.cpp:1800:29: note: Function 'citySack' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/player.cpp:1820:29: style:inconclusive: Function 'cityRaze' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:936:29: note: Function 'cityRaze' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/player.cpp:1820:29: note: Function 'cityRaze' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/player.cpp:1843:38: style:inconclusive: Function 'cityBuyProduction' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:961:38: note: Function 'cityBuyProduction' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/player.cpp:1843:38: note: Function 'cityBuyProduction' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/player.cpp:1843:55: style:inconclusive: Function 'cityBuyProduction' argument 3 names different: declaration 'armytype' definition 'type'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:961:58: note: Function 'cityBuyProduction' argument 3 names different: declaration 'armytype' definition 'type'. lordsawar-0.3.2/src/player.cpp:1843:55: note: Function 'cityBuyProduction' argument 3 names different: declaration 'armytype' definition 'type'. lordsawar-0.3.2/src/player.cpp:1878:41: style:inconclusive: Function 'cityChangeProduction' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:988:41: note: Function 'cityChangeProduction' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/player.cpp:1878:41: note: Function 'cityChangeProduction' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/player.cpp:1925:32: style:inconclusive: Function 'giveReward' argument 1 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:1099:33: note: Function 'giveReward' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:1925:32: note: Function 'giveReward' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:1943:36: style:inconclusive: Function 'doStackDisband' argument 1 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:1646:36: note: Function 'doStackDisband' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:1943:36: note: Function 'doStackDisband' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:1954:34: style:inconclusive: Function 'stackDisband' argument 1 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:583:34: note: Function 'stackDisband' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:1954:34: note: Function 'stackDisband' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:1967:35: style:inconclusive: Function 'doHeroDropItem' argument 1 names different: declaration 'hero' definition 'h'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:1640:35: note: Function 'doHeroDropItem' argument 1 names different: declaration 'hero' definition 'h'. lordsawar-0.3.2/src/player.cpp:1967:35: note: Function 'doHeroDropItem' argument 1 names different: declaration 'hero' definition 'h'. lordsawar-0.3.2/src/player.cpp:1967:44: style:inconclusive: Function 'doHeroDropItem' argument 2 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:1640:47: note: Function 'doHeroDropItem' argument 2 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/player.cpp:1967:44: note: Function 'doHeroDropItem' argument 2 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/player.cpp:1984:33: style:inconclusive: Function 'heroDropItem' argument 1 names different: declaration 'hero' definition 'h'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:661:33: note: Function 'heroDropItem' argument 1 names different: declaration 'hero' definition 'h'. lordsawar-0.3.2/src/player.cpp:1984:33: note: Function 'heroDropItem' argument 1 names different: declaration 'hero' definition 'h'. lordsawar-0.3.2/src/player.cpp:1984:42: style:inconclusive: Function 'heroDropItem' argument 2 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:661:45: note: Function 'heroDropItem' argument 2 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/player.cpp:1984:42: note: Function 'heroDropItem' argument 2 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/player.cpp:1991:37: style:inconclusive: Function 'heroDropAllItems' argument 1 names different: declaration 'hero' definition 'h'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:684:37: note: Function 'heroDropAllItems' argument 1 names different: declaration 'hero' definition 'h'. lordsawar-0.3.2/src/player.cpp:1991:37: note: Function 'heroDropAllItems' argument 1 names different: declaration 'hero' definition 'h'. lordsawar-0.3.2/src/player.cpp:2007:37: style:inconclusive: Function 'doHeroPickupItem' argument 1 names different: declaration 'hero' definition 'h'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:1643:37: note: Function 'doHeroPickupItem' argument 1 names different: declaration 'hero' definition 'h'. lordsawar-0.3.2/src/player.cpp:2007:37: note: Function 'doHeroPickupItem' argument 1 names different: declaration 'hero' definition 'h'. lordsawar-0.3.2/src/player.cpp:2007:46: style:inconclusive: Function 'doHeroPickupItem' argument 2 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:1643:49: note: Function 'doHeroPickupItem' argument 2 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/player.cpp:2007:46: note: Function 'doHeroPickupItem' argument 2 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/player.cpp:2015:35: style:inconclusive: Function 'heroPickupItem' argument 1 names different: declaration 'hero' definition 'h'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:706:35: note: Function 'heroPickupItem' argument 1 names different: declaration 'hero' definition 'h'. lordsawar-0.3.2/src/player.cpp:2015:35: note: Function 'heroPickupItem' argument 1 names different: declaration 'hero' definition 'h'. lordsawar-0.3.2/src/player.cpp:2015:44: style:inconclusive: Function 'heroPickupItem' argument 2 names different: declaration 'item' definition 'i'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:706:47: note: Function 'heroPickupItem' argument 2 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/player.cpp:2015:44: note: Function 'heroPickupItem' argument 2 names different: declaration 'item' definition 'i'. lordsawar-0.3.2/src/player.cpp:2038:39: style:inconclusive: Function 'heroCompletesQuest' argument 1 names different: declaration 'hero' definition 'h'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:730:39: note: Function 'heroCompletesQuest' argument 1 names different: declaration 'hero' definition 'h'. lordsawar-0.3.2/src/player.cpp:2038:39: note: Function 'heroCompletesQuest' argument 1 names different: declaration 'hero' definition 'h'. lordsawar-0.3.2/src/player.cpp:2045:44: style:inconclusive: Function 'doResign' argument 1 names different: declaration 'history' definition 'histories'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:1654:44: note: Function 'doResign' argument 1 names different: declaration 'history' definition 'histories'. lordsawar-0.3.2/src/player.cpp:2045:44: note: Function 'doResign' argument 1 names different: declaration 'history' definition 'histories'. lordsawar-0.3.2/src/player.cpp:2078:41: style:inconclusive: Function 'doSignpostChange' argument 1 names different: declaration 'signpost' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:1650:41: note: Function 'doSignpostChange' argument 1 names different: declaration 'signpost' definition 's'. lordsawar-0.3.2/src/player.cpp:2078:41: note: Function 'doSignpostChange' argument 1 names different: declaration 'signpost' definition 's'. lordsawar-0.3.2/src/player.cpp:2083:39: style:inconclusive: Function 'signpostChange' argument 1 names different: declaration 'signpost' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:610:39: note: Function 'signpostChange' argument 1 names different: declaration 'signpost' definition 's'. lordsawar-0.3.2/src/player.cpp:2083:39: note: Function 'signpostChange' argument 1 names different: declaration 'signpost' definition 's'. lordsawar-0.3.2/src/player.cpp:2099:31: style:inconclusive: Function 'cityRename' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:804:31: note: Function 'cityRename' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/player.cpp:2099:31: note: Function 'cityRename' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/player.cpp:2127:36: style:inconclusive: Function 'vectorFromCity' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:826:35: note: Function 'vectorFromCity' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/player.cpp:2127:36: note: Function 'vectorFromCity' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/player.cpp:2208:39: style:inconclusive: Function 'heroPlantStandard' argument 1 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:637:39: note: Function 'heroPlantStandard' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:2208:39: note: Function 'heroPlantStandard' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:2241:78: style:inconclusive: Function 'getHeroes' argument 2 names different: declaration 'heroes' definition 'dst'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:1732:32: note: Function 'getHeroes' argument 2 names different: declaration 'heroes' definition 'dst'. lordsawar-0.3.2/src/player.cpp:2241:78: note: Function 'getHeroes' argument 2 names different: declaration 'heroes' definition 'dst'. lordsawar-0.3.2/src/player.cpp:2468:40: style:inconclusive: Function 'doRecruitHero' argument 1 names different: declaration 'hero' definition 'herotemplate'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:1660:40: note: Function 'doRecruitHero' argument 1 names different: declaration 'hero' definition 'herotemplate'. lordsawar-0.3.2/src/player.cpp:2468:40: note: Function 'doRecruitHero' argument 1 names different: declaration 'hero' definition 'herotemplate'. lordsawar-0.3.2/src/player.cpp:2499:37: style:inconclusive: Function 'recruitHero' argument 1 names different: declaration 'hero' definition 'heroproto'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:764:37: note: Function 'recruitHero' argument 1 names different: declaration 'hero' definition 'heroproto'. lordsawar-0.3.2/src/player.cpp:2499:37: note: Function 'recruitHero' argument 1 names different: declaration 'hero' definition 'heroproto'. lordsawar-0.3.2/src/player.cpp:2664:45: style:inconclusive: Function 'getDiplomaticScore' argument 1 names different: declaration 'p' definition 'player'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:419:38: note: Function 'getDiplomaticScore' argument 1 names different: declaration 'p' definition 'player'. lordsawar-0.3.2/src/player.cpp:2664:45: note: Function 'getDiplomaticScore' argument 1 names different: declaration 'p' definition 'player'. lordsawar-0.3.2/src/player.cpp:2689:53: style:inconclusive: Function 'improveDiplomaticRelationship' argument 1 names different: declaration 'p' definition 'player'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:1206:46: note: Function 'improveDiplomaticRelationship' argument 1 names different: declaration 'p' definition 'player'. lordsawar-0.3.2/src/player.cpp:2689:53: note: Function 'improveDiplomaticRelationship' argument 1 names different: declaration 'p' definition 'player'. lordsawar-0.3.2/src/player.cpp:2844:48: style:inconclusive: Function 'AI_maybePickUpItems' argument 2 names different: declaration 'dist' definition 'max_dist'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:1170:42: note: Function 'AI_maybePickUpItems' argument 2 names different: declaration 'dist' definition 'max_dist'. lordsawar-0.3.2/src/player.cpp:2844:48: note: Function 'AI_maybePickUpItems' argument 2 names different: declaration 'dist' definition 'max_dist'. lordsawar-0.3.2/src/player.cpp:3336:62: style:inconclusive: Function 'doCityProducesArmy' argument 2 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:1669:54: note: Function 'doCityProducesArmy' argument 2 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:3336:62: note: Function 'doCityProducesArmy' argument 2 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:3383:66: style:inconclusive: Function 'doVectoredUnitArrives' argument 2 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:1670:59: note: Function 'doVectoredUnitArrives' argument 2 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:3383:66: note: Function 'doVectoredUnitArrives' argument 2 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:4145:34: style:inconclusive: Function 'doHeroUseItem' argument 1 names different: declaration 'h' definition 'hero'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:1642:34: note: Function 'doHeroUseItem' argument 1 names different: declaration 'h' definition 'hero'. lordsawar-0.3.2/src/player.cpp:4145:34: note: Function 'doHeroUseItem' argument 1 names different: declaration 'h' definition 'hero'. lordsawar-0.3.2/src/player.cpp:4305:32: style:inconclusive: Function 'heroUseItem' argument 1 names different: declaration 'h' definition 'hero'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:712:32: note: Function 'heroUseItem' argument 1 names different: declaration 'h' definition 'hero'. lordsawar-0.3.2/src/player.cpp:4305:32: note: Function 'heroUseItem' argument 1 names different: declaration 'h' definition 'hero'. lordsawar-0.3.2/src/player.cpp:4305:58: style:inconclusive: Function 'heroUseItem' argument 3 names different: declaration 'player' definition 'victim'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:712:55: note: Function 'heroUseItem' argument 3 names different: declaration 'player' definition 'victim'. lordsawar-0.3.2/src/player.cpp:4305:58: note: Function 'heroUseItem' argument 3 names different: declaration 'player' definition 'victim'. lordsawar-0.3.2/src/player.cpp:4507:35: style:inconclusive: Function 'doStackDefend' argument 1 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:1663:35: note: Function 'doStackDefend' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:4507:35: note: Function 'doStackDefend' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:4518:37: style:inconclusive: Function 'doStackUndefend' argument 1 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:1664:37: note: Function 'doStackUndefend' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:4518:37: note: Function 'doStackUndefend' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:4529:33: style:inconclusive: Function 'doStackPark' argument 1 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:1665:33: note: Function 'doStackPark' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:4529:33: note: Function 'doStackPark' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:4549:35: style:inconclusive: Function 'doStackUnpark' argument 1 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:1666:35: note: Function 'doStackUnpark' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:4549:35: note: Function 'doStackUnpark' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:4560:35: style:inconclusive: Function 'doStackSelect' argument 1 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/player.h:1667:35: note: Function 'doStackSelect' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/player.cpp:4560:35: note: Function 'doStackSelect' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/questmap.h:46:5: style: Class 'QuestMap' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] lordsawar-0.3.2/src/questmap.h:49:6: style: The destructor '~QuestMap' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:63:15: note: Virtual destructor in base class lordsawar-0.3.2/src/questmap.h:49:6: note: Destructor in derived class lordsawar-0.3.2/src/questmap.h:86:18: style: The function 'after_draw' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:221:18: note: Virtual function in base class lordsawar-0.3.2/src/questmap.h:86:18: note: Function in derived class lordsawar-0.3.2/src/player.cpp:602:49: performance: Function parameter 'order' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/player.cpp:607:47: performance: Function parameter 'order' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/player.cpp:628:66: performance: Function parameter 'armies' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/player.cpp:640:66: performance: Function parameter 'armies' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/player.cpp:2241:48: performance: Function parameter 'stacks' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/player.cpp:4446:55: performance: Function parameter 'army_ids' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/player.cpp:4409:59: style: Parameter 'stacks' can be declared as reference to const [constParameterReference] lordsawar-0.3.2/src/player.cpp:4426:57: style: Parameter 'stacks' can be declared as reference to const [constParameterReference] lordsawar-0.3.2/src/player.cpp:149:13: style: Variable 'ait' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:153:13: style: Variable 'pit' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:347:15: style: Variable 'it' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:353:13: style: Variable 'it' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:493:15: style: Variable 'it' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:497:15: style: Variable 'it' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:793:13: style: Variable 'enemy' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:1058:15: style: Variable 'city' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:1087:10: style: Variable 'another_stack' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:1270:13: style: Variable 'pd' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:1547:9: style: Variable 'city' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:1918:23: style: Variable 'map' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:2154:9: style: Variable 'src_city' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:2166:9: style: Variable 'dest_city' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:2326:28: style: Variable 'a' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:2794:18: style: Variable 'scout' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:2859:13: style: Variable 'c' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3111:9: style: Variable 'enemy_city' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3225:13: style: Variable 'other' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3294:13: style: Variable 'enemy_city' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3392:9: style: Variable 'army' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3397:13: style: Variable 'dest' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3603:13: style: Variable 'it' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3611:13: style: Variable 'it' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3619:13: style: Variable 'it' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3646:30: style: Variable 'event' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3664:21: style: Variable 'event' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3683:17: style: Variable 'action' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3716:25: style: Variable 'event' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3724:27: style: Variable 'event' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3748:29: style: Variable 'event' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3759:27: style: Variable 'event' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3767:34: style: Variable 'event' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3775:36: style: Variable 'event' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3783:34: style: Variable 'event' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3791:36: style: Variable 'event' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3799:36: style: Variable 'event' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3807:29: style: Variable 'event' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3815:33: style: Variable 'event' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3899:26: style: Variable 'q' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3901:18: style: Variable 'enemy' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3951:17: style: Variable 'c' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3972:32: style: Variable 'qu' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3982:31: style: Variable 'qu' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:3992:30: style: Variable 'qu' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:4113:24: style: Variable 'move' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:4117:18: style: Variable 'prev' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/player.cpp:4601:28: style: Variable 'h' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/questmap.cpp:30:27: style:inconclusive: Function 'QuestMap' argument 1 names different: declaration 'quest' definition 'q'. [funcArgNamesDifferent] lordsawar-0.3.2/src/questmap.h:46:21: note: Function 'QuestMap' argument 1 names different: declaration 'quest' definition 'q'. lordsawar-0.3.2/src/questmap.cpp:30:27: note: Function 'QuestMap' argument 1 names different: declaration 'quest' definition 'q'. lordsawar-0.3.2/src/player.cpp:114:21: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/player.cpp:150:15: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/player.cpp:154:15: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/player.cpp:2361:16: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/player.cpp:3458:9: style: Consider using std::copy_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/player.cpp:3494:6: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/player.cpp:3541:6: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/player.cpp:3603:3: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/player.cpp:3611:3: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/player.cpp:3619:3: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/player.cpp:3632:2: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/player.cpp:3878:14: style: Consider using std::copy_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/player.cpp:3924:17: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/questmap.cpp:37:64: performance: Function parameter 'targets' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/questmap.cpp:47:16: style: Variable 'mytile' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/questmap.cpp:42:85: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:782:12: style: Variable 'result' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/player.cpp:140:41: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:416:68: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:456:37: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:575:34: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:1277:39: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:1280:39: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:1284:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:1288:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:1373:11: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:1456:41: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:2071:8: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:2189:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:2203:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:2214:57: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:2244:51: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:2305:11: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:2344:11: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:2360:49: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:2462:6: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:2464:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:3142:65: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:3180:65: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:3407:45: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:3440:34: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:3482:55: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:3491:55: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:3507:53: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:3529:55: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:3538:55: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:3554:53: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:3629:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:3642:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:3660:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:3705:57: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:3742:57: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:3921:75: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:3936:75: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:3964:67: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:4109:33: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:4178:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:4339:49: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:4341:71: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:4383:49: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:4385:71: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:4413:49: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:4417:71: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:4430:49: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:4434:71: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/player.cpp:4597:55: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/recently-played-game-list.cpp:202:16: style: Variable 'p' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/recently-played-game-list.cpp:238:44: style: Variable 'i' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/recently-played-game-list.cpp:240:44: style: Variable 'j' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/recently-played-game-list.cpp:107:68: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/recently-played-game-list.cpp:119:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/recently-played-game-list.cpp:224:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/recently-played-game-list.cpp:233:74: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/recently-played-game-list.cpp:259:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/recently-played-game-list.cpp:275:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/recently-played-game-list.cpp:281:68: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/recently-played-game-list.cpp:295:68: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/recently-played-game.cpp:34:3: performance: Variable 'd_id' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/recently-played-game.cpp:32:78: style:inconclusive: Function 'RecentlyPlayedGame' argument 2 names different: declaration 'profile' definition 'p'. [funcArgNamesDifferent] lordsawar-0.3.2/src/recently-played-game.h:57:66: note: Function 'RecentlyPlayedGame' argument 2 names different: declaration 'profile' definition 'p'. lordsawar-0.3.2/src/recently-played-game.cpp:32:78: note: Function 'RecentlyPlayedGame' argument 2 names different: declaration 'profile' definition 'p'. lordsawar-0.3.2/src/recently-played-game.cpp:124:68: style:inconclusive: Function 'RecentlyPlayedHotseatGame' argument 1 names different: declaration 'game_scenario' definition 'scen'. [funcArgNamesDifferent] lordsawar-0.3.2/src/recently-played-game.h:167:42: note: Function 'RecentlyPlayedHotseatGame' argument 1 names different: declaration 'game_scenario' definition 'scen'. lordsawar-0.3.2/src/recently-played-game.cpp:124:68: note: Function 'RecentlyPlayedHotseatGame' argument 1 names different: declaration 'game_scenario' definition 'scen'. lordsawar-0.3.2/src/recently-played-game.cpp:161:72: style:inconclusive: Function 'RecentlyPlayedNetworkedGame' argument 1 names different: declaration 'game_scenario' definition 'scen'. [funcArgNamesDifferent] lordsawar-0.3.2/src/recently-played-game.h:199:44: note: Function 'RecentlyPlayedNetworkedGame' argument 1 names different: declaration 'game_scenario' definition 'scen'. lordsawar-0.3.2/src/recently-played-game.cpp:161:72: note: Function 'RecentlyPlayedNetworkedGame' argument 1 names different: declaration 'game_scenario' definition 'scen'. lordsawar-0.3.2/src/recently-played-game.cpp:32:54: style: Parameter 'game_scenario' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/recently-played-game.cpp:32:78: style: Parameter 'p' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/rnd.cpp:31:3: warning: Class 'Rnd' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] lordsawar-0.3.2/src/rnd.cpp:31:3: warning: Class 'Rnd' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] lordsawar-0.3.2/src/rewardlist.cpp:104:3: warning: Calling method 'load()' when 'this' might be invalid [thisUseAfterFree] lordsawar-0.3.2/src/rewardlist.h:98:28: note: Assuming 's_instance' is used as 'this' lordsawar-0.3.2/src/rewardlist.cpp:52:9: note: Delete 's_instance', invalidating 'this' lordsawar-0.3.2/src/rewardlist.cpp:104:3: note: Call method when 'this' is invalid lordsawar-0.3.2/src/rewardlist.cpp:59:62: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/rewardlist.cpp:78:68: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/rewardlist.cpp:109:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/rewardlist.cpp:141:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/rewardlist.cpp:176:39: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/reward.cpp:220:3: performance: Variable 'd_army_type' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/reward.cpp:221:3: performance: Variable 'd_army_set' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/reward.cpp:228:3: performance: Variable 'd_army_type' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/reward.cpp:346:5: warning: Class 'Reward_Item' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] lordsawar-0.3.2/src/reward.cpp:482:3: warning: Class 'Reward_Map' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] lordsawar-0.3.2/src/reward.cpp:81:47: style:inconclusive: Function 'getRandomRewardType' argument 1 names different: declaration 'no_ruins' definition 'exclude_ruins'. [funcArgNamesDifferent] lordsawar-0.3.2/src/reward.h:171:46: note: Function 'getRandomRewardType' argument 1 names different: declaration 'no_ruins' definition 'exclude_ruins'. lordsawar-0.3.2/src/reward.cpp:81:47: note: Function 'getRandomRewardType' argument 1 names different: declaration 'no_ruins' definition 'exclude_ruins'. lordsawar-0.3.2/src/reward.cpp:94:62: style:inconclusive: Function 'createRandomReward' argument 2 names different: declaration 'no_ruins' definition 'exclude_ruins'. [funcArgNamesDifferent] lordsawar-0.3.2/src/reward.h:180:69: note: Function 'createRandomReward' argument 2 names different: declaration 'no_ruins' definition 'exclude_ruins'. lordsawar-0.3.2/src/reward.cpp:94:62: note: Function 'createRandomReward' argument 2 names different: declaration 'no_ruins' definition 'exclude_ruins'. lordsawar-0.3.2/src/reward.cpp:288:11: style: Variable 'p' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/reward.cpp:342:32: style: Parameter 'item' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/reward.cpp:395:14: style: Variable 'i' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/reward.cpp:405:32: style: Parameter 'ruin' can be declared as pointer to const [constParameterPointer] lordsawar-0.3.2/src/reward.cpp:454:13: style: Variable 'r' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/ruin.cpp:79:40: style:inconclusive: Function 'Ruin' argument 2 names different: declaration 'tile_width' definition 'width'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ruin.h:88:42: note: Function 'Ruin' argument 2 names different: declaration 'tile_width' definition 'width'. lordsawar-0.3.2/src/ruin.cpp:79:40: note: Function 'Ruin' argument 2 names different: declaration 'tile_width' definition 'width'. lordsawar-0.3.2/src/ruin.cpp:229:31: style:inconclusive: Function 'setReward' argument 1 names different: declaration 'r' definition 'reward'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ruin.h:148:25: note: Function 'setReward' argument 1 names different: declaration 'r' definition 'reward'. lordsawar-0.3.2/src/ruin.cpp:229:31: note: Function 'setReward' argument 1 names different: declaration 'r' definition 'reward'. lordsawar-0.3.2/src/ruinlist.cpp:109:17: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/ruinlist.cpp:118:11: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/ruinlist.cpp:123:11: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/ruinlist.cpp:109:9: style: Variable 'ruin' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/ruinlist.cpp:189:13: style: Variable 'ruin' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/ruinlist.cpp:203:13: style: Variable 'ruin' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/ruinlist.cpp:80:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/ruinlist.cpp:179:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/ruinlist.cpp:187:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/ruinlist.cpp:201:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/ruinlist.cpp:215:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/ruinlist.cpp:224:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/ruinlist.cpp:238:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/scenario-details.cpp:35:3: performance: Variable 'd_filename' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/ruinmap.h:47:7: style: The destructor '~RuinMap' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:63:15: note: Virtual destructor in base class lordsawar-0.3.2/src/ruinmap.h:47:7: note: Destructor in derived class lordsawar-0.3.2/src/ruinmap.h:94:19: style: The function 'after_draw' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:221:18: note: Virtual function in base class lordsawar-0.3.2/src/ruinmap.h:94:19: note: Function in derived class lordsawar-0.3.2/src/ruinmap.cpp:28:33: style:inconclusive: Function 'RuinMap' argument 1 names different: declaration 'ruin' definition 'r'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ruinmap.h:44:29: note: Function 'RuinMap' argument 1 names different: declaration 'ruin' definition 'r'. lordsawar-0.3.2/src/ruinmap.cpp:28:33: note: Function 'RuinMap' argument 1 names different: declaration 'ruin' definition 'r'. lordsawar-0.3.2/src/ruinmap.cpp:28:43: style:inconclusive: Function 'RuinMap' argument 2 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/ruinmap.h:44:42: note: Function 'RuinMap' argument 2 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/ruinmap.cpp:28:43: note: Function 'RuinMap' argument 2 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/ruinmap.cpp:39:45: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameMap.cpp:0:0: debug: ValueFlow maximum iterations exceeded [valueFlowMaxIterations] lordsawar-0.3.2/src/scenario-list.cpp:70:51: style:inconclusive: Function 'compare' argument 1 names different: declaration 'l' definition 'lhs'. [funcArgNamesDifferent] lordsawar-0.3.2/src/scenario-list.h:65:52: note: Function 'compare' argument 1 names different: declaration 'l' definition 'lhs'. lordsawar-0.3.2/src/scenario-list.cpp:70:51: note: Function 'compare' argument 1 names different: declaration 'l' definition 'lhs'. lordsawar-0.3.2/src/scenario-list.cpp:70:79: style:inconclusive: Function 'compare' argument 2 names different: declaration 'r' definition 'rhs'. [funcArgNamesDifferent] lordsawar-0.3.2/src/scenario-list.h:65:78: note: Function 'compare' argument 2 names different: declaration 'r' definition 'rhs'. lordsawar-0.3.2/src/scenario-list.cpp:70:79: note: Function 'compare' argument 2 names different: declaration 'r' definition 'rhs'. lordsawar-0.3.2/src/scenario-list.cpp:104:13: style: Variable 'f' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/scenario-list.cpp:77:58: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/scenario-list.cpp:97:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/scenario-list.cpp:122:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/set.cpp:27:6: warning:inconclusive: Member variable 'Set::d_copyright' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] lordsawar-0.3.2/src/set.cpp:21:24: style:inconclusive: Function 'Set' argument 1 names different: declaration 'file_extension' definition 'ext'. [funcArgNamesDifferent] lordsawar-0.3.2/src/set.h:30:23: note: Function 'Set' argument 1 names different: declaration 'file_extension' definition 'ext'. lordsawar-0.3.2/src/set.cpp:21:24: note: Function 'Set' argument 1 names different: declaration 'file_extension' definition 'ext'. lordsawar-0.3.2/src/set.cpp:33:24: style:inconclusive: Function 'Set' argument 1 names different: declaration 'file_extension' definition 'ext'. [funcArgNamesDifferent] lordsawar-0.3.2/src/set.h:31:23: note: Function 'Set' argument 1 names different: declaration 'file_extension' definition 'ext'. lordsawar-0.3.2/src/set.cpp:33:24: note: Function 'Set' argument 1 names different: declaration 'file_extension' definition 'ext'. lordsawar-0.3.2/src/GameMap.cpp:203:5: warning: Using member 'd_tileset' when 'this' might be invalid [thisUseAfterFree] lordsawar-0.3.2/src/GameMap.h:1478:25: note: Assuming 's_instance' is used as 'this' lordsawar-0.3.2/src/GameMap.cpp:110:9: note: Delete 's_instance', invalidating 'this' lordsawar-0.3.2/src/GameMap.cpp:203:5: note: Call method when 'this' is invalid lordsawar-0.3.2/src/GameMap.cpp:1303:12: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/GameMap.cpp:1304:12: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/GameMap.cpp:1315:12: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/GameMap.cpp:1316:12: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/GameMap.cpp:1326:12: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/GameMap.cpp:1327:12: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/shield.cpp:49:3: performance: Variable 'd_owner' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/shield.cpp:216:41: style:inconclusive: Function 'get_next_shield' argument 1 names different: declaration 'type' definition 'colour'. [funcArgNamesDifferent] lordsawar-0.3.2/src/shield.h:125:48: note: Function 'get_next_shield' argument 1 names different: declaration 'type' definition 'colour'. lordsawar-0.3.2/src/shield.cpp:216:41: note: Function 'get_next_shield' argument 1 names different: declaration 'type' definition 'colour'. lordsawar-0.3.2/src/shield.cpp:42:54: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shield.cpp:55:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shield.cpp:127:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shield.cpp:141:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shield.cpp:201:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shield.cpp:208:42: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameMap.cpp:560:7: style: The scope of the variable 'destx' can be reduced. [variableScope] lordsawar-0.3.2/src/GameMap.cpp:560:18: style: The scope of the variable 'desty' can be reduced. [variableScope] lordsawar-0.3.2/src/select-city-map.cpp:26:16: warning: Member variable 'SelectCityMap::d_selected_city' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/GameMap.cpp:86:24: style:inconclusive: Function 'getInstance' argument 2 names different: declaration 'Shieldsetname' definition 'ShieldsetName'. [funcArgNamesDifferent] lordsawar-0.3.2/src/GameMap.h:88:23: note: Function 'getInstance' argument 2 names different: declaration 'Shieldsetname' definition 'ShieldsetName'. lordsawar-0.3.2/src/GameMap.cpp:86:24: note: Function 'getInstance' argument 2 names different: declaration 'Shieldsetname' definition 'ShieldsetName'. lordsawar-0.3.2/src/GameMap.cpp:87:24: style:inconclusive: Function 'getInstance' argument 3 names different: declaration 'Citysetname' definition 'CitysetName'. [funcArgNamesDifferent] lordsawar-0.3.2/src/GameMap.h:89:23: note: Function 'getInstance' argument 3 names different: declaration 'Citysetname' definition 'CitysetName'. lordsawar-0.3.2/src/GameMap.cpp:87:24: note: Function 'getInstance' argument 3 names different: declaration 'Citysetname' definition 'CitysetName'. lordsawar-0.3.2/src/GameMap.cpp:115:18: style:inconclusive: Function 'GameMap' argument 3 names different: declaration 'Citysetname' definition 'CitysetName'. [funcArgNamesDifferent] lordsawar-0.3.2/src/GameMap.h:1434:17: note: Function 'GameMap' argument 3 names different: declaration 'Citysetname' definition 'CitysetName'. lordsawar-0.3.2/src/GameMap.cpp:115:18: note: Function 'GameMap' argument 3 names different: declaration 'Citysetname' definition 'CitysetName'. lordsawar-0.3.2/src/GameMap.cpp:141:43: style:inconclusive: Function 'processStyles' argument 1 names different: declaration 'styles' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/GameMap.h:1449:35: note: Function 'processStyles' argument 1 names different: declaration 'styles' definition 's'. lordsawar-0.3.2/src/GameMap.cpp:141:43: note: Function 'processStyles' argument 1 names different: declaration 'styles' definition 's'. lordsawar-0.3.2/src/GameMap.cpp:1105:69: style:inconclusive: Function 'getEnemyStacks' argument 1 names different: declaration 'posns' definition 'positions'. [funcArgNamesDifferent] lordsawar-0.3.2/src/GameMap.h:482:68: note: Function 'getEnemyStacks' argument 1 names different: declaration 'posns' definition 'positions'. lordsawar-0.3.2/src/GameMap.cpp:1105:69: note: Function 'getEnemyStacks' argument 1 names different: declaration 'posns' definition 'positions'. lordsawar-0.3.2/src/GameMap.cpp:1188:34: style:inconclusive: Function 'groupStacks' argument 1 names different: declaration 's' definition 'stack'. [funcArgNamesDifferent] lordsawar-0.3.2/src/GameMap.h:365:33: note: Function 'groupStacks' argument 1 names different: declaration 's' definition 'stack'. lordsawar-0.3.2/src/GameMap.cpp:1188:34: note: Function 'groupStacks' argument 1 names different: declaration 's' definition 'stack'. lordsawar-0.3.2/src/GameMap.cpp:1216:36: style:inconclusive: Function 'canJoin' argument 1 names different: declaration 'stack' definition 'src'. [funcArgNamesDifferent] lordsawar-0.3.2/src/GameMap.h:407:35: note: Function 'canJoin' argument 1 names different: declaration 'stack' definition 'src'. lordsawar-0.3.2/src/GameMap.cpp:1216:36: note: Function 'canJoin' argument 1 names different: declaration 'stack' definition 'src'. lordsawar-0.3.2/src/GameMap.cpp:1216:53: style:inconclusive: Function 'canJoin' argument 2 names different: declaration 'pos' definition 'dest'. [funcArgNamesDifferent] lordsawar-0.3.2/src/GameMap.h:407:54: note: Function 'canJoin' argument 2 names different: declaration 'pos' definition 'dest'. lordsawar-0.3.2/src/GameMap.cpp:1216:53: note: Function 'canJoin' argument 2 names different: declaration 'pos' definition 'dest'. lordsawar-0.3.2/src/GameMap.cpp:1225:38: style:inconclusive: Function 'canAddArmy' argument 1 names different: declaration 'pos' definition 'dest'. [funcArgNamesDifferent] lordsawar-0.3.2/src/GameMap.h:417:37: note: Function 'canAddArmy' argument 1 names different: declaration 'pos' definition 'dest'. lordsawar-0.3.2/src/GameMap.cpp:1225:38: note: Function 'canAddArmy' argument 1 names different: declaration 'pos' definition 'dest'. lordsawar-0.3.2/src/GameMap.cpp:1773:31: style:inconclusive: Function 'putStone' argument 1 names different: declaration 't' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/GameMap.h:1167:23: note: Function 'putStone' argument 1 names different: declaration 't' definition 's'. lordsawar-0.3.2/src/GameMap.cpp:1773:31: note: Function 'putStone' argument 1 names different: declaration 't' definition 's'. lordsawar-0.3.2/src/GameMap.cpp:2173:44: style:inconclusive: Function 'getLocation' argument 1 names different: declaration 'pos' definition 'tile'. [funcArgNamesDifferent] lordsawar-0.3.2/src/GameMap.h:1375:36: note: Function 'getLocation' argument 1 names different: declaration 'pos' definition 'tile'. lordsawar-0.3.2/src/GameMap.cpp:2173:44: note: Function 'getLocation' argument 1 names different: declaration 'pos' definition 'tile'. lordsawar-0.3.2/src/GameMap.cpp:2419:37: style:inconclusive: Function 'eraseTile' argument 1 names different: declaration 'pos' definition 'tile'. [funcArgNamesDifferent] lordsawar-0.3.2/src/GameMap.h:1350:36: note: Function 'eraseTile' argument 1 names different: declaration 'pos' definition 'tile'. lordsawar-0.3.2/src/GameMap.cpp:2419:37: note: Function 'eraseTile' argument 1 names different: declaration 'pos' definition 'tile'. lordsawar-0.3.2/src/select-city-map.cpp:48:19: style: Variable 'owner' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:868:44: performance: Function parameter 'r' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/GameMap.cpp:1105:69: performance: Function parameter 'positions' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/GameMap.cpp:1713:41: performance: Function parameter 'rect' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/GameMap.cpp:1722:42: performance: Function parameter 'rect' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/GameMap.cpp:2406:38: performance: Function parameter 'r' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/GameMap.cpp:144:12: style: Variable 'tileset' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:252:14: style: Variable 'tileset' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:288:14: style: Variable 'tileset' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:316:17: style: Variable 'style' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:428:25: style: Variable 'c' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:517:16: style: Variable 'from' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:518:16: style: Variable 'to' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:633:12: style: Variable 'tileset' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:634:12: style: Variable 'mtile' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:726:12: style: Variable 'tileset' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:734:15: style: Variable 'tilestyle' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:738:19: style: Variable 'nextstyle' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:765:19: style: Variable 'nextstyle' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:841:12: style: Variable 'tileset' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:914:12: style: Variable 'tileset' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:950:12: style: Variable 'tileset' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:968:9: style: Variable 'road' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:971:9: style: Variable 'city' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:974:11: style: Variable 'temple' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:977:9: style: Variable 'ruin' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:1134:9: style: Variable 'lhero' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:1135:9: style: Variable 'rhero' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:1144:9: style: Variable 'larmy' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:1145:9: style: Variable 'rarmy' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:1151:14: style: Variable 's' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:1256:12: style: Variable 'tileset' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:1538:14: style: Variable 'old_signpost' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:1548:10: style: Variable 'old_port' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:1558:12: style: Variable 'old_bridge' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:1569:10: style: Variable 'old_road' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:1587:10: style: Variable 'old_ruin' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:1597:12: style: Variable 'old_temple' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:1607:10: style: Variable 'old_city' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:1617:11: style: Variable 'old_stone' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:1677:9: style: Variable 'c' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:1934:12: style: Variable 'tileset' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:2289:9: style: Variable 'center' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:2360:12: style: Variable 'ts' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:2366:12: style: Variable 'ts' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:2443:28: style: Variable 'rr' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:2531:11: style: Variable 'temple' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:2535:9: style: Variable 'ruin' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:2567:25: style: Variable 'city' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:2568:27: style: Variable 'temple' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:2569:25: style: Variable 'ruin' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:2570:29: style: Variable 'sign' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:2595:15: style: Variable 'other' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/GameMap.cpp:594:16: style: Variable 'found' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/GameMap.cpp:2598:24: style: Variable 'dest' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/GameMap.cpp:1109:33: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameMap.cpp:1199:65: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameMap.cpp:1211:65: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameMap.cpp:1282:29: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameMap.cpp:1368:59: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameMap.cpp:1388:65: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameMap.cpp:1397:17: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameMap.cpp:1400:63: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameMap.cpp:2141:76: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameMap.cpp:2143:71: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameMap.cpp:2163:76: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameMap.cpp:2165:71: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameMap.cpp:2228:28: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameMap.cpp:2559:69: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameMap.cpp:2611:31: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/GameMap.cpp:2620:75: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldsetlist.cpp:81:14: style: Variable 's' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/shieldsetlist.cpp:89:14: style: Variable 's' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/shieldsetlist.cpp:62:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldsetlist.cpp:70:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldsetlist.cpp:98:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldsetlist.cpp:110:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.cpp:152:2: performance: Variable 'dir' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/shieldset.cpp:224:17: warning: The class 'Shieldset' defines member function with name 'save' also defined in its parent class 'Set'. [duplInheritedMember] lordsawar-0.3.2/src/set.h:87:10: note: Parent function 'Set::save' lordsawar-0.3.2/src/shieldset.cpp:224:17: note: Derived function 'Shieldset::save' lordsawar-0.3.2/src/shieldset.cpp:201:60: style:inconclusive: Function 'create' argument 2 names different: declaration 'unsupported' definition 'unsupported_version'. [funcArgNamesDifferent] lordsawar-0.3.2/src/shieldset.h:216:57: note: Function 'create' argument 2 names different: declaration 'unsupported' definition 'unsupported_version'. lordsawar-0.3.2/src/shieldset.cpp:201:60: note: Function 'create' argument 2 names different: declaration 'unsupported' definition 'unsupported_version'. lordsawar-0.3.2/src/shieldset.cpp:210:60: style:inconclusive: Function 'save' argument 2 names different: declaration 'extension' definition 'ext'. [funcArgNamesDifferent] lordsawar-0.3.2/src/shieldset.h:154:57: note: Function 'save' argument 2 names different: declaration 'extension' definition 'ext'. lordsawar-0.3.2/src/shieldset.cpp:210:60: note: Function 'save' argument 2 names different: declaration 'extension' definition 'ext'. lordsawar-0.3.2/src/shieldset.cpp:414:45: style:inconclusive: Function 'copy' argument 1 names different: declaration 'orig' definition 'shieldset'. [funcArgNamesDifferent] lordsawar-0.3.2/src/shieldset.h:218:50: note: Function 'copy' argument 1 names different: declaration 'orig' definition 'shieldset'. lordsawar-0.3.2/src/shieldset.cpp:414:45: note: Function 'copy' argument 1 names different: declaration 'orig' definition 'shieldset'. lordsawar-0.3.2/src/shieldset.cpp:428:60: style:inconclusive: Function 'setHeightsAndWidthsFromImages' argument 1 names different: declaration 's' definition 'ss'. [funcArgNamesDifferent] lordsawar-0.3.2/src/shieldset.h:144:57: note: Function 'setHeightsAndWidthsFromImages' argument 1 names different: declaration 's' definition 'ss'. lordsawar-0.3.2/src/shieldset.cpp:428:60: note: Function 'setHeightsAndWidthsFromImages' argument 1 names different: declaration 's' definition 'ss'. lordsawar-0.3.2/src/shieldset.cpp:572:62: style:inconclusive: Function 'uninstantiateSameNamedImages' argument 1 names different: declaration 'imgname' definition 'name'. [funcArgNamesDifferent] lordsawar-0.3.2/src/shieldset.h:211:58: note: Function 'uninstantiateSameNamedImages' argument 1 names different: declaration 'imgname' definition 'name'. lordsawar-0.3.2/src/shieldset.cpp:572:62: note: Function 'uninstantiateSameNamedImages' argument 1 names different: declaration 'imgname' definition 'name'. lordsawar-0.3.2/src/shieldset.cpp:451:18: style: Variable 'image' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/shieldset.cpp:484:18: style: Variable 'image' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/shieldset.cpp:517:18: style: Variable 'image' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/shieldset.cpp:393:13: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/shieldset.cpp:50:54: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.cpp:77:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.cpp:84:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.cpp:86:74: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.cpp:97:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.cpp:107:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.cpp:236:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.cpp:245:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.cpp:255:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.cpp:290:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.cpp:292:74: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.cpp:322:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.cpp:326:74: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.cpp:350:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.cpp:376:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.cpp:388:59: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.cpp:390:89: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.cpp:448:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.cpp:449:66: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.cpp:481:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.cpp:482:66: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.cpp:514:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.cpp:515:66: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.cpp:544:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldset.cpp:546:74: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/shieldstyle.cpp:33:3: performance: Variable 'd_type' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/shieldstyle.cpp:34:3: performance: Variable 'd_image_name' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/shieldstyle.cpp:47:3: performance: Variable 'd_type' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/shieldstyle.cpp:48:3: performance: Variable 'd_image_name' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/shieldstyle.cpp:113:93: style:inconclusive: Function 'instantiateImages' argument 4 names different: declaration 'broke' definition 'broken'. [funcArgNamesDifferent] lordsawar-0.3.2/src/shieldstyle.h:109:50: note: Function 'instantiateImages' argument 4 names different: declaration 'broke' definition 'broken'. lordsawar-0.3.2/src/shieldstyle.cpp:113:93: note: Function 'instantiateImages' argument 4 names different: declaration 'broke' definition 'broken'. lordsawar-0.3.2/src/signpostlist.cpp:70:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/signpostlist.cpp:92:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/snd.cpp:271:32: style: The scope of the variable 'bgmap' can be reduced. [variableScope] lordsawar-0.3.2/src/snd.cpp:272:41: style: The scope of the variable 'map' can be reduced. [variableScope] lordsawar-0.3.2/src/snd.cpp:143:14: style: Variable 'item' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/snd.cpp:334:14: style: Variable 'item' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/snd.cpp:49:7: style: struct member 'Impl::placeholder' is never used. [unusedStructMember] lordsawar-0.3.2/src/snd.cpp:271:38: style: Variable 'bgmap' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/snd.cpp:272:45: style: Variable 'map' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/snd.cpp:275:15: style: Variable 'bgmap' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/snd.cpp:276:13: style: Variable 'map' is assigned a value that is never used. [unreadVariable] lordsawar-0.3.2/src/snd.cpp:105:59: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/smallmap.cpp:82:58: style:inconclusive: Function 'center_view_on_tile' argument 2 names different: declaration 'slide' definition 'slide_me'. [funcArgNamesDifferent] lordsawar-0.3.2/src/smallmap.h:103:52: note: Function 'center_view_on_tile' argument 2 names different: declaration 'slide' definition 'slide_me'. lordsawar-0.3.2/src/smallmap.cpp:82:58: note: Function 'center_view_on_tile' argument 2 names different: declaration 'slide' definition 'slide_me'. lordsawar-0.3.2/src/smallmap.cpp:96:59: style:inconclusive: Function 'center_view_on_pixel' argument 2 names different: declaration 'slide' definition 'slide_me'. [funcArgNamesDifferent] lordsawar-0.3.2/src/smallmap.h:114:53: note: Function 'center_view_on_pixel' argument 2 names different: declaration 'slide' definition 'slide_me'. lordsawar-0.3.2/src/smallmap.cpp:96:59: note: Function 'center_view_on_pixel' argument 2 names different: declaration 'slide' definition 'slide_me'. lordsawar-0.3.2/src/smallmap.cpp:48:37: performance: Function parameter 'new_view' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/smallmap.cpp:189:39: performance: Function parameter 'new_view' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/smallmap.cpp:127:11: style: Variable 'p' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/stackreflist.cpp:36:46: style:inconclusive: Function 'StackReflist' argument 1 names different: declaration 'stacks' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/stackreflist.h:39:36: note: Function 'StackReflist' argument 1 names different: declaration 'stacks' definition 's'. lordsawar-0.3.2/src/stackreflist.cpp:36:46: note: Function 'StackReflist' argument 1 names different: declaration 'stacks' definition 's'. lordsawar-0.3.2/src/stackreflist.cpp:55:36: style:inconclusive: Function 'addStack' argument 1 names different: declaration 's' definition 'stack'. [funcArgNamesDifferent] lordsawar-0.3.2/src/stackreflist.h:44:26: note: Function 'addStack' argument 1 names different: declaration 's' definition 'stack'. lordsawar-0.3.2/src/stackreflist.cpp:55:36: note: Function 'addStack' argument 1 names different: declaration 's' definition 'stack'. lordsawar-0.3.2/src/stackreflist.cpp:61:37: style:inconclusive: Function 'contains' argument 1 names different: declaration 'stack_id' definition 'id'. [funcArgNamesDifferent] lordsawar-0.3.2/src/stackreflist.h:50:27: note: Function 'contains' argument 1 names different: declaration 'stack_id' definition 'id'. lordsawar-0.3.2/src/stackreflist.cpp:61:37: note: Function 'contains' argument 1 names different: declaration 'stack_id' definition 'id'. lordsawar-0.3.2/src/stackreflist.cpp:68:40: style:inconclusive: Function 'removeStack' argument 1 names different: declaration 'stack_id' definition 'id'. [funcArgNamesDifferent] lordsawar-0.3.2/src/stackreflist.h:47:30: note: Function 'removeStack' argument 1 names different: declaration 'stack_id' definition 'id'. lordsawar-0.3.2/src/stackreflist.cpp:68:40: note: Function 'removeStack' argument 1 names different: declaration 'stack_id' definition 'id'. lordsawar-0.3.2/src/stackreflist.cpp:114:44: style:inconclusive: Function 'changeOwnership' argument 1 names different: declaration 'new_owner' definition 'new_player'. [funcArgNamesDifferent] lordsawar-0.3.2/src/stackreflist.h:57:34: note: Function 'changeOwnership' argument 1 names different: declaration 'new_owner' definition 'new_player'. lordsawar-0.3.2/src/stackreflist.cpp:114:44: note: Function 'changeOwnership' argument 1 names different: declaration 'new_owner' definition 'new_player'. lordsawar-0.3.2/src/stackreflist.cpp:36:46: performance: Function parameter 's' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/stackreflist.cpp:70:10: style: Variable 's' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/stackreflist.cpp:84:14: style: Variable 's' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/stackreflist.cpp:130:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/stackreflist.cpp:28:63: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stackreflist.cpp:38:67: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stackreflist.cpp:109:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stackreflist.cpp:116:61: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stackreflist.cpp:127:61: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:505:11: style: Condition '!added' is always false [knownConditionTrueFalse] lordsawar-0.3.2/src/stacklist.cpp:504:36: note: Calling function 'addPositionToMap' returns 1 lordsawar-0.3.2/src/stacklist.cpp:504:36: note: Assignment 'added=addPositionToMap(stack)', assigned value is 1 lordsawar-0.3.2/src/stacklist.cpp:505:11: note: Condition '!added' is always false lordsawar-0.3.2/src/stacklist.cpp:113:8: portability: %lu in format string (no. 1) requires 'unsigned long' but the argument type is 'std::size_t {aka unsigned long}'. [invalidPrintfArgType_uint] lordsawar-0.3.2/src/stacklist.cpp:121:21: portability: %lu in format string (no. 1) requires 'unsigned long' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_uint] lordsawar-0.3.2/src/stacklist.cpp:64:36: style:inconclusive: Function 'deleteStack' argument 1 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/stacklist.h:229:40: note: Function 'deleteStack' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/stacklist.cpp:64:36: note: Function 'deleteStack' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/stacklist.cpp:324:33: style:inconclusive: Function 'flRemove' argument 1 names different: declaration 'stack' definition 'object'. [funcArgNamesDifferent] lordsawar-0.3.2/src/stacklist.h:207:30: note: Function 'flRemove' argument 1 names different: declaration 'stack' definition 'object'. lordsawar-0.3.2/src/stacklist.cpp:324:33: note: Function 'flRemove' argument 1 names different: declaration 'stack' definition 'object'. lordsawar-0.3.2/src/stacklist.cpp:486:41: style:inconclusive: Function 'addPositionToMap' argument 1 names different: declaration 's' definition 'stack'. [funcArgNamesDifferent] lordsawar-0.3.2/src/stacklist.h:316:31: note: Function 'addPositionToMap' argument 1 names different: declaration 's' definition 'stack'. lordsawar-0.3.2/src/stacklist.cpp:486:41: note: Function 'addPositionToMap' argument 1 names different: declaration 's' definition 'stack'. lordsawar-0.3.2/src/stacklist.cpp:538:48: style:inconclusive: Function 'on_stack_starts_moving' argument 1 names different: declaration 's' definition 'stack'. [funcArgNamesDifferent] lordsawar-0.3.2/src/stacklist.h:299:38: note: Function 'on_stack_starts_moving' argument 1 names different: declaration 's' definition 'stack'. lordsawar-0.3.2/src/stacklist.cpp:538:48: note: Function 'on_stack_starts_moving' argument 1 names different: declaration 's' definition 'stack'. lordsawar-0.3.2/src/stacklist.cpp:543:47: style:inconclusive: Function 'on_stack_stops_moving' argument 1 names different: declaration 's' definition 'stack'. [funcArgNamesDifferent] lordsawar-0.3.2/src/stacklist.h:302:37: note: Function 'on_stack_stops_moving' argument 1 names different: declaration 's' definition 'stack'. lordsawar-0.3.2/src/stacklist.cpp:543:47: note: Function 'on_stack_stops_moving' argument 1 names different: declaration 's' definition 'stack'. lordsawar-0.3.2/src/stacklist.cpp:240:13: style: Variable 'player' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/stacklist.cpp:366:16: style: Variable 's' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/stacklist.cpp:412:14: style: Variable 'stack' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/stacklist.cpp:437:13: style: Variable 'enemy' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/stacklist.cpp:456:16: style: Variable 's' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/stacklist.cpp:473:13: style: Variable 'hero_locale' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/stacklist.cpp:479:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/stacklist.cpp:51:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:54:71: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:55:83: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:67:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:70:72: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:80:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:83:72: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:93:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:100:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:106:46: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:115:79: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:134:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:143:46: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:144:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:170:24: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:183:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:194:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:204:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:218:68: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:247:38: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:248:9: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:302:46: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:354:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:364:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:399:61: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:410:30: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:431:78: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:454:30: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:471:76: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:477:5: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:555:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:562:74: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:582:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:594:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:605:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:616:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:630:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:641:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:651:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:661:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacklist.cpp:676:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacktile.cpp:69:8: style: Condition 'first' is always true [knownConditionTrueFalse] lordsawar-0.3.2/src/stacktile.cpp:63:16: note: Assignment 'first=true', assigned value is 1 lordsawar-0.3.2/src/stacktile.cpp:69:8: note: Condition 'first' is always true lordsawar-0.3.2/src/stacktile.cpp:180:41: style:inconclusive: Function 'getEnemyStack' argument 1 names different: declaration 'notowner' definition 'owner'. [funcArgNamesDifferent] lordsawar-0.3.2/src/stacktile.h:115:34: note: Function 'getEnemyStack' argument 1 names different: declaration 'notowner' definition 'owner'. lordsawar-0.3.2/src/stacktile.cpp:180:41: note: Function 'getEnemyStack' argument 1 names different: declaration 'notowner' definition 'owner'. lordsawar-0.3.2/src/stacktile.cpp:210:34: style:inconclusive: Function 'contains' argument 1 names different: declaration 'stack_id' definition 'id'. [funcArgNamesDifferent] lordsawar-0.3.2/src/stacktile.h:124:27: note: Function 'contains' argument 1 names different: declaration 'stack_id' definition 'id'. lordsawar-0.3.2/src/stacktile.cpp:210:34: note: Function 'contains' argument 1 names different: declaration 'stack_id' definition 'id'. lordsawar-0.3.2/src/stacktile.cpp:223:45: style:inconclusive: Function 'group' argument 2 names different: declaration 's' definition 'stack'. [funcArgNamesDifferent] lordsawar-0.3.2/src/stacktile.h:97:38: note: Function 'group' argument 2 names different: declaration 's' definition 'stack'. lordsawar-0.3.2/src/stacktile.cpp:223:45: note: Function 'group' argument 2 names different: declaration 's' definition 'stack'. lordsawar-0.3.2/src/stacktile.cpp:229:53: style:inconclusive: Function 'groupStacks' argument 2 names different: declaration 's' definition 'stack'. [funcArgNamesDifferent] lordsawar-0.3.2/src/stacktile.h:132:46: note: Function 'groupStacks' argument 2 names different: declaration 's' definition 'stack'. lordsawar-0.3.2/src/stacktile.cpp:229:53: note: Function 'groupStacks' argument 2 names different: declaration 's' definition 'stack'. lordsawar-0.3.2/src/stacktile.cpp:132:15: style: Variable 'p' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/stacktile.cpp:187:15: style: Variable 'p' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/stacktile.cpp:202:15: style: Variable 'p' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/stacktile.cpp:254:21: style: Unused variable: armies [unusedVariable] lordsawar-0.3.2/src/stacktile.cpp:99:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacktile.cpp:113:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacktile.cpp:121:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacktile.cpp:141:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacktile.cpp:156:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacktile.cpp:169:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacktile.cpp:183:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacktile.cpp:198:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacktile.cpp:212:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacktile.cpp:240:77: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacktile.cpp:255:77: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacktile.cpp:258:65: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacktile.cpp:278:76: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stacktile.cpp:293:76: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stone.cpp:261:19: style: Condition 'stones.empty()' is always false [knownConditionTrueFalse] lordsawar-0.3.2/src/stone.cpp:259:60: note: Calling function 'getSuitableTypes' returns size=40 lordsawar-0.3.2/src/stone.cpp:259:60: note: Assignment 'stones=Stone::getSuitableTypes()', assigned value is size=40 lordsawar-0.3.2/src/stone.cpp:261:19: note: Condition 'stones.empty()' is always false lordsawar-0.3.2/src/tarfile.h:45:19: style:inconclusive: Technically the member function 'TarFile::getFileFromConfigurationFile' can be const. [functionConst] lordsawar-0.3.2/src/tarfile.cpp:54:24: note: Technically the member function 'TarFile::getFileFromConfigurationFile' can be const. lordsawar-0.3.2/src/tarfile.h:45:19: note: Technically the member function 'TarFile::getFileFromConfigurationFile' can be const. lordsawar-0.3.2/src/tarfile.h:46:10: style:inconclusive: Technically the member function 'TarFile::replaceFileInCfgFile' can be const. [functionConst] lordsawar-0.3.2/src/tarfile.cpp:86:15: note: Technically the member function 'TarFile::replaceFileInCfgFile' can be const. lordsawar-0.3.2/src/tarfile.h:46:10: note: Technically the member function 'TarFile::replaceFileInCfgFile' can be const. lordsawar-0.3.2/src/tarfile.h:47:10: style:inconclusive: Technically the member function 'TarFile::addFileInCfgFile' can be const. [functionConst] lordsawar-0.3.2/src/tarfile.cpp:108:15: note: Technically the member function 'TarFile::addFileInCfgFile' can be const. lordsawar-0.3.2/src/tarfile.h:47:10: note: Technically the member function 'TarFile::addFileInCfgFile' can be const. lordsawar-0.3.2/src/tarfile.h:48:10: style:inconclusive: Technically the member function 'TarFile::removeFileInCfgFile' can be const. [functionConst] lordsawar-0.3.2/src/tarfile.cpp:71:15: note: Technically the member function 'TarFile::removeFileInCfgFile' can be const. lordsawar-0.3.2/src/tarfile.h:48:10: note: Technically the member function 'TarFile::removeFileInCfgFile' can be const. lordsawar-0.3.2/src/tarfile.cpp:169:39: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tarfile.cpp:185:38: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stonelist.cpp:71:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tarhelper.cpp:154:41: style:inconclusive: Function 'saveFile' argument 1 names different: declaration 'file' definition 'filename'. [funcArgNamesDifferent] lordsawar-0.3.2/src/tarhelper.h:39:33: note: Function 'saveFile' argument 1 names different: declaration 'file' definition 'filename'. lordsawar-0.3.2/src/tarhelper.cpp:154:41: note: Function 'saveFile' argument 1 names different: declaration 'file' definition 'filename'. lordsawar-0.3.2/src/tarhelper.cpp:396:44: style:inconclusive: Function 'replaceFile' argument 1 names different: declaration 'old_filename' definition 'filename'. [funcArgNamesDifferent] lordsawar-0.3.2/src/tarhelper.h:73:36: note: Function 'replaceFile' argument 1 names different: declaration 'old_filename' definition 'filename'. lordsawar-0.3.2/src/tarhelper.cpp:396:44: note: Function 'replaceFile' argument 1 names different: declaration 'old_filename' definition 'filename'. lordsawar-0.3.2/src/tarhelper.cpp:396:68: style:inconclusive: Function 'replaceFile' argument 2 names different: declaration 'new_filename' definition 'newfilename'. [funcArgNamesDifferent] lordsawar-0.3.2/src/tarhelper.h:73:64: note: Function 'replaceFile' argument 2 names different: declaration 'new_filename' definition 'newfilename'. lordsawar-0.3.2/src/tarhelper.cpp:396:68: note: Function 'replaceFile' argument 2 names different: declaration 'new_filename' definition 'newfilename'. lordsawar-0.3.2/src/tarhelper.cpp:182:78: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tarhelper.cpp:298:72: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tarhelper.cpp:368:27: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tartan.cpp:46:30: style:inconclusive: Function 'Tartan' argument 1 names different: declaration 's' definition 't'. [funcArgNamesDifferent] lordsawar-0.3.2/src/tartan.h:66:31: note: Function 'Tartan' argument 1 names different: declaration 's' definition 't'. lordsawar-0.3.2/src/tartan.cpp:46:30: note: Function 'Tartan' argument 1 names different: declaration 's' definition 't'. lordsawar-0.3.2/src/templelist.cpp:99:11: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/templelist.cpp:109:61: style:inconclusive: Function 'getNearestVisibleAndUsefulTemple' argument 1 names different: declaration 'stack' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/templelist.h:85:50: note: Function 'getNearestVisibleAndUsefulTemple' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/templelist.cpp:109:61: note: Function 'getNearestVisibleAndUsefulTemple' argument 1 names different: declaration 'stack' definition 's'. lordsawar-0.3.2/src/templelist.cpp:77:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/templelist.cpp:174:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tilesetlist.cpp:99:14: style: Variable 'smalltile' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/tilesetlist.cpp:64:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tilesetlist.cpp:71:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tilesetlist.cpp:78:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tileset.cpp:396:14: error: Array 'ids[65535]' accessed at index 65535, which is out of bounds. [arrayIndexOutOfBounds] lordsawar-0.3.2/src/tileset.cpp:394:30: note: Assuming that condition 'i<=65535' is not redundant lordsawar-0.3.2/src/tileset.cpp:396:14: note: Array index out of bounds lordsawar-0.3.2/src/tileset.cpp:83:10: warning:inconclusive: Member variable 'Tileset::d_tiletypes' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] lordsawar-0.3.2/src/tileset.cpp:52:3: performance: Variable 'd_large_selector' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/tileset.cpp:53:3: performance: Variable 'd_small_selector' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/tileset.cpp:54:3: performance: Variable 'd_fog' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/tileset.cpp:55:3: performance: Variable 'd_roads' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/tileset.cpp:56:3: performance: Variable 'd_standing_stones' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/tileset.cpp:57:3: performance: Variable 'd_bridges' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/tileset.cpp:58:3: performance: Variable 'd_flags' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/tileset.cpp:86:3: performance: Variable 'd_large_selector' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/tileset.cpp:87:3: performance: Variable 'd_small_selector' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/tileset.cpp:88:3: performance: Variable 'd_explosion' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/tileset.cpp:89:3: performance: Variable 'd_fog' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/tileset.cpp:90:3: performance: Variable 'd_roads' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/tileset.cpp:91:3: performance: Variable 'd_standing_stones' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/tileset.cpp:92:3: performance: Variable 'd_bridges' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/tileset.cpp:93:3: performance: Variable 'd_flags' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/tileset.cpp:94:3: performance: Variable 'd_road_color' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/tileset.cpp:95:3: performance: Variable 'd_ruin_color' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/tileset.cpp:96:3: performance: Variable 'd_temple_color' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/tileset.cpp:475:2: performance: Variable 'dir' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] lordsawar-0.3.2/src/tileset.cpp:334:15: warning: The class 'Tileset' defines member function with name 'save' also defined in its parent class 'Set'. [duplInheritedMember] lordsawar-0.3.2/src/set.h:87:10: note: Parent function 'Set::save' lordsawar-0.3.2/src/tileset.cpp:334:15: note: Derived function 'Tileset::save' lordsawar-0.3.2/src/tileset.cpp:83:34: style:inconclusive: Function 'Tileset' argument 1 names different: declaration 'tileset' definition 't'. [funcArgNamesDifferent] lordsawar-0.3.2/src/tileset.h:86:32: note: Function 'Tileset' argument 1 names different: declaration 'tileset' definition 't'. lordsawar-0.3.2/src/tileset.cpp:83:34: note: Function 'Tileset' argument 1 names different: declaration 'tileset' definition 't'. lordsawar-0.3.2/src/tileset.cpp:365:58: style:inconclusive: Function 'save' argument 2 names different: declaration 'extension' definition 'ext'. [funcArgNamesDifferent] lordsawar-0.3.2/src/tileset.h:320:57: note: Function 'save' argument 2 names different: declaration 'extension' definition 'ext'. lordsawar-0.3.2/src/tileset.cpp:365:58: note: Function 'save' argument 2 names different: declaration 'extension' definition 'ext'. lordsawar-0.3.2/src/tileset.cpp:964:39: style:inconclusive: Function 'copy' argument 1 names different: declaration 'orig' definition 'tileset'. [funcArgNamesDifferent] lordsawar-0.3.2/src/tileset.h:345:46: note: Function 'copy' argument 1 names different: declaration 'orig' definition 'tileset'. lordsawar-0.3.2/src/tileset.cpp:964:39: note: Function 'copy' argument 1 names different: declaration 'orig' definition 'tileset'. lordsawar-0.3.2/src/tilestyle.cpp:29:12: warning: Member variable 'TileStyle::d_type' is not initialized in the constructor. [uninitMemberVar] lordsawar-0.3.2/src/tilestyle.cpp:145:8: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] lordsawar-0.3.2/src/tilestyle.cpp:146:3: note: Found duplicate branches for 'if' and 'else'. lordsawar-0.3.2/src/tilestyle.cpp:145:8: note: Found duplicate branches for 'if' and 'else'. lordsawar-0.3.2/src/tileset.cpp:327:9: style: Variable 'tile' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/tileset.cpp:873:22: style: Variable 'tilestyle' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/tileset.cpp:929:11: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] lordsawar-0.3.2/src/tileset.cpp:170:90: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tileset.cpp:172:86: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tileset.cpp:385:90: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tileset.cpp:387:86: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tileset.cpp:407:90: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tileset.cpp:409:86: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tileset.cpp:430:57: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tileset.cpp:535:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tileset.cpp:766:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tileset.cpp:840:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tileset.cpp:868:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tileset.cpp:871:70: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tileset.cpp:912:68: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tileset.cpp:923:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tileset.cpp:925:28: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tileset.cpp:927:30: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tileset.cpp:958:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tileset.cpp:988:57: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tileset.cpp:1359:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/tilestyleset.cpp:49:42: style:inconclusive: Function 'TileStyleSet' argument 1 names different: declaration 'pngfilename' definition 'file'. [funcArgNamesDifferent] lordsawar-0.3.2/src/tilestyleset.h:57:36: note: Function 'TileStyleSet' argument 1 names different: declaration 'pngfilename' definition 'file'. lordsawar-0.3.2/src/tilestyleset.cpp:49:42: note: Function 'TileStyleSet' argument 1 names different: declaration 'pngfilename' definition 'file'. lordsawar-0.3.2/src/tilestyleset.cpp:121:59: style:inconclusive: Function 'loadImages' argument 2 names different: declaration 'image_filename' definition 'filename'. [funcArgNamesDifferent] lordsawar-0.3.2/src/tilestyleset.h:109:46: note: Function 'loadImages' argument 2 names different: declaration 'image_filename' definition 'filename'. lordsawar-0.3.2/src/tilestyleset.cpp:121:59: note: Function 'loadImages' argument 2 names different: declaration 'image_filename' definition 'filename'. lordsawar-0.3.2/src/stack.cpp:64:8: warning:inconclusive: Member variable 'Stack::sdying' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] lordsawar-0.3.2/src/stack.cpp:64:8: warning:inconclusive: Member variable 'Stack::smoving' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] lordsawar-0.3.2/src/stack.cpp:64:8: warning:inconclusive: Member variable 'Stack::smoved' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] lordsawar-0.3.2/src/stack.cpp:64:8: warning:inconclusive: Member variable 'Stack::sgrouped' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] lordsawar-0.3.2/src/stack.cpp:74:25: warning: Either the condition 's.d_path==NULL' is redundant or there is possible null pointer dereference: s.d_path. [nullPointerRedundantCheck] lordsawar-0.3.2/src/stack.cpp:70:16: note: Assuming that condition 's.d_path==NULL' is not redundant lordsawar-0.3.2/src/stack.cpp:74:25: note: Null pointer dereference lordsawar-0.3.2/src/stack.cpp:64:35: style:inconclusive: Function 'Stack' argument 2 names different: declaration 'unique' definition 'uniq'. [funcArgNamesDifferent] lordsawar-0.3.2/src/stack.h:74:36: note: Function 'Stack' argument 2 names different: declaration 'unique' definition 'uniq'. lordsawar-0.3.2/src/stack.cpp:64:35: note: Function 'Stack' argument 2 names different: declaration 'unique' definition 'uniq'. lordsawar-0.3.2/src/stack.cpp:699:46: style:inconclusive: Function 'armyCompareStrength' argument 1 names different: declaration 'left' definition 'lhs'. [funcArgNamesDifferent] lordsawar-0.3.2/src/stack.h:484:47: note: Function 'armyCompareStrength' argument 1 names different: declaration 'left' definition 'lhs'. lordsawar-0.3.2/src/stack.cpp:699:46: note: Function 'armyCompareStrength' argument 1 names different: declaration 'left' definition 'lhs'. lordsawar-0.3.2/src/stack.cpp:699:63: style:inconclusive: Function 'armyCompareStrength' argument 2 names different: declaration 'right' definition 'rhs'. [funcArgNamesDifferent] lordsawar-0.3.2/src/stack.h:484:65: note: Function 'armyCompareStrength' argument 2 names different: declaration 'right' definition 'rhs'. lordsawar-0.3.2/src/stack.cpp:699:63: note: Function 'armyCompareStrength' argument 2 names different: declaration 'right' definition 'rhs'. lordsawar-0.3.2/src/stack.cpp:704:48: style:inconclusive: Function 'armyCompareFightOrder' argument 1 names different: declaration 'left' definition 'lhs'. [funcArgNamesDifferent] lordsawar-0.3.2/src/stack.h:483:49: note: Function 'armyCompareFightOrder' argument 1 names different: declaration 'left' definition 'lhs'. lordsawar-0.3.2/src/stack.cpp:704:48: note: Function 'armyCompareFightOrder' argument 1 names different: declaration 'left' definition 'lhs'. lordsawar-0.3.2/src/stack.cpp:704:65: style:inconclusive: Function 'armyCompareFightOrder' argument 2 names different: declaration 'right' definition 'rhs'. [funcArgNamesDifferent] lordsawar-0.3.2/src/stack.h:483:67: note: Function 'armyCompareFightOrder' argument 2 names different: declaration 'right' definition 'rhs'. lordsawar-0.3.2/src/stack.cpp:704:65: note: Function 'armyCompareFightOrder' argument 2 names different: declaration 'right' definition 'rhs'. lordsawar-0.3.2/src/stack.cpp:715:33: style:inconclusive: Function 'sortByStrength' argument 1 names different: declaration 'reverse' definition 'rev'. [funcArgNamesDifferent] lordsawar-0.3.2/src/stack.h:204:34: note: Function 'sortByStrength' argument 1 names different: declaration 'reverse' definition 'rev'. lordsawar-0.3.2/src/stack.cpp:715:33: note: Function 'sortByStrength' argument 1 names different: declaration 'reverse' definition 'rev'. lordsawar-0.3.2/src/stack.cpp:722:34: style:inconclusive: Function 'sortForViewing' argument 1 names different: declaration 'reverse' definition 'rev'. [funcArgNamesDifferent] lordsawar-0.3.2/src/stack.h:202:27: note: Function 'sortForViewing' argument 1 names different: declaration 'reverse' definition 'rev'. lordsawar-0.3.2/src/stack.cpp:722:34: note: Function 'sortForViewing' argument 1 names different: declaration 'reverse' definition 'rev'. lordsawar-0.3.2/src/stack.cpp:1027:25: style:inconclusive: Function 'join' argument 1 names different: declaration 'join' definition 's'. [funcArgNamesDifferent] lordsawar-0.3.2/src/stack.h:210:19: note: Function 'join' argument 1 names different: declaration 'join' definition 's'. lordsawar-0.3.2/src/stack.cpp:1027:25: note: Function 'join' argument 1 names different: declaration 'join' definition 's'. lordsawar-0.3.2/src/stack.cpp:1338:49: style:inconclusive: Function 'removeArmiesWithoutArmyType' argument 1 names different: declaration 'armyset_id' definition 'armyset'. [funcArgNamesDifferent] lordsawar-0.3.2/src/stack.h:255:50: note: Function 'removeArmiesWithoutArmyType' argument 1 names different: declaration 'armyset_id' definition 'armyset'. lordsawar-0.3.2/src/stack.cpp:1338:49: note: Function 'removeArmiesWithoutArmyType' argument 1 names different: declaration 'armyset_id' definition 'armyset'. lordsawar-0.3.2/src/stack.cpp:686:42: performance: Function parameter 'values' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/stack.cpp:978:44: performance: Function parameter 'armies' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/stack.cpp:986:46: performance: Function parameter 'armies' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/stack.cpp:1310:42: performance: Function parameter 'ids' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/stack.cpp:397:12: style: Variable 'tile' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/stack.cpp:644:10: style: Variable 'h' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/stack.cpp:1087:17: style: Variable 'hero' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/stack.cpp:1156:17: style: Variable 'backpack' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/stack.cpp:1170:17: style: Variable 'backpack' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/stack.cpp:1179:17: style: Variable 'ruin' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/stack.cpp:1343:16: style: Variable 'a' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/stack.cpp:1344:18: style: Variable 'armyproto' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/stack.cpp:1368:12: style: Variable 'mtile' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/stack.cpp:76:58: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:111:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:160:51: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:181:55: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:193:55: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:282:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:290:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:355:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:364:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:386:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:420:66: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:463:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:481:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:494:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:537:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:575:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:614:62: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:640:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:654:69: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:678:69: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:690:28: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:733:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:743:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:754:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:780:58: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:811:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:827:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:837:29: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:857:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:900:63: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:929:63: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:963:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:981:74: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:993:76: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:997:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:1021:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:1029:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:1083:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:1098:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:1109:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:1123:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:1138:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:1151:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:1165:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:1176:38: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:1203:50: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:1217:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:1232:56: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:1249:33: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:1259:37: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:1270:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:1282:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:1300:32: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:1320:51: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:1332:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:1341:42: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/stack.cpp:1349:13: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/turn-actionlist.cpp:47:22: warning: The class 'TurnActionlist' defines member function with name 'save' also defined in its parent class 'OwnerId'. [duplInheritedMember] lordsawar-0.3.2/src/OwnerId.h:59:10: note: Parent function 'OwnerId::save' lordsawar-0.3.2/src/turn-actionlist.cpp:47:22: note: Derived function 'TurnActionlist::save' lordsawar-0.3.2/src/turn-actionlist.cpp:27:74: performance: Function parameter 'actions' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/turn-actionlist.cpp:75:13: style: Variable 'a' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/turn-actionlist.cpp:35:60: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/turn-actionlist.cpp:54:68: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/utils/import.cpp:1147:25: style: Condition 'ar.enemyminus' is always true [knownConditionTrueFalse] lordsawar-0.3.2/src/utils/import.cpp:1145:13: note: Assuming that condition 'ar.enemyminus' is not redundant lordsawar-0.3.2/src/utils/import.cpp:1147:25: note: Condition 'ar.enemyminus' is always true lordsawar-0.3.2/src/utils/import.cpp:937:7: warning: fscanf() without field width limits can crash with huge input data. [invalidscanf] lordsawar-0.3.2/src/utils/import.cpp:501:28: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/utils/import.cpp:715:63: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/utils/import.cpp:716:64: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/utils/import.cpp:982:23: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/utils/import.cpp:983:23: style: C-style pointer casting [cstyleCast] lordsawar-0.3.2/src/utils/import.cpp:272:20: style: Variable '*ts' is reassigned a value before the old one has been used. [redundantAssignment] lordsawar-0.3.2/src/utils/import.cpp:271:20: note: *ts is assigned lordsawar-0.3.2/src/utils/import.cpp:272:20: note: *ts is overwritten lordsawar-0.3.2/src/utils/import.cpp:1254:7: style: Same expression used in consecutive assignments of 'fhero' and 'rhero'. [duplicateAssignExpression] lordsawar-0.3.2/src/utils/import.cpp:1255:7: note: Same expression used in consecutive assignments of 'fhero' and 'rhero'. lordsawar-0.3.2/src/utils/import.cpp:1254:7: note: Same expression used in consecutive assignments of 'fhero' and 'rhero'. lordsawar-0.3.2/src/utils/import.cpp:982:18: style: Variable 'l' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/utils/import.cpp:983:18: style: Variable 'r' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/utils/import.cpp:1001:35: style: Parameter 'lhs' can be declared as pointer to const. However it seems that 'compare_army_strength' is a callback function, if 'lhs' is declared with const you might also need to cast function pointer(s). [constParameterCallback] lordsawar-0.3.2/src/utils/import.cpp:1017:15: note: You might need to cast the function pointer here lordsawar-0.3.2/src/utils/import.cpp:1001:35: note: Parameter 'lhs' can be declared as pointer to const lordsawar-0.3.2/src/utils/import.cpp:1001:51: style: Parameter 'rhs' can be declared as pointer to const. However it seems that 'compare_army_strength' is a callback function, if 'rhs' is declared with const you might also need to cast function pointer(s). [constParameterCallback] lordsawar-0.3.2/src/utils/import.cpp:1017:15: note: You might need to cast the function pointer here lordsawar-0.3.2/src/utils/import.cpp:1001:51: note: Parameter 'rhs' can be declared as pointer to const lordsawar-0.3.2/src/utils/import.cpp:1237:10: error: Out of bounds access in expression 'order[i]' because 'order' is empty. [containerOutOfBounds] lordsawar-0.3.2/src/utils/import.cpp:1234:44: note: Assignment 'order=std::vector()', assigned value is size=0 lordsawar-0.3.2/src/utils/import.cpp:1237:10: note: Access out of bounds lordsawar-0.3.2/src/utils/import.cpp:1240:10: error: Out of bounds access in expression 'order[fight_order_no_boat[c]]' because 'order' is empty. [containerOutOfBounds] lordsawar-0.3.2/src/utils/import.cpp:1234:44: note: Assignment 'order=std::vector()', assigned value is size=0 lordsawar-0.3.2/src/utils/import.cpp:1240:10: note: Access out of bounds lordsawar-0.3.2/src/utils/import.cpp:1014:69: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/utils/import.cpp:1021:8: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/utils/import.cpp:1239:69: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/utils/import.cpp:1246:62: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/utils/upgrade-file.cpp:73:8: style: The scope of the variable 'same_version' can be reduced. [variableScope] lordsawar-0.3.2/src/vectoredunitlist.cpp:178:57: style:inconclusive: Function 'removeVectoredUnitsGoingTo' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/vectoredunitlist.h:82:47: note: Function 'removeVectoredUnitsGoingTo' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/vectoredunitlist.cpp:178:57: note: Function 'removeVectoredUnitsGoingTo' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/vectoredunitlist.cpp:218:60: style:inconclusive: Function 'removeVectoredUnitsComingFrom' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/vectoredunitlist.h:110:50: note: Function 'removeVectoredUnitsComingFrom' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/vectoredunitlist.cpp:218:60: note: Function 'removeVectoredUnitsComingFrom' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/vectoredunitlist.cpp:234:54: style:inconclusive: Function 'getVectoredUnitsGoingTo' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/vectoredunitlist.h:172:37: note: Function 'getVectoredUnitsGoingTo' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/vectoredunitlist.cpp:234:54: note: Function 'getVectoredUnitsGoingTo' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/vectoredunitlist.cpp:278:48: style:inconclusive: Function 'changeDestination' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/vectoredunitlist.h:123:31: note: Function 'changeDestination' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/vectoredunitlist.cpp:278:48: note: Function 'changeDestination' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/vectoredunitlist.cpp:114:13: style: Variable 'c' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/vectoredunitlist.cpp:65:62: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/vectoredunitlist.cpp:81:70: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/vectoredunitlist.cpp:112:62: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/vectoredunitlist.cpp:131:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/vectoredunitlist.cpp:147:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/vectoredunitlist.cpp:173:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/vectoredunitlist.cpp:192:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/vectoredunitlist.cpp:207:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/vectoredunitlist.cpp:229:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/vectoredunitlist.cpp:236:68: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/vectoredunitlist.cpp:246:68: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/vectoredunitlist.cpp:256:68: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/vectoredunitlist.cpp:268:68: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/vectoredunitlist.cpp:281:62: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/vectoredunitlist.cpp:301:44: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/xmlhelper.cpp:554:13: style: Condition 'd_failed' is always false [knownConditionTrueFalse] lordsawar-0.3.2/src/xmlhelper.cpp:529:16: note: Assuming that condition 'd_failed' is not redundant lordsawar-0.3.2/src/xmlhelper.cpp:554:13: note: Condition 'd_failed' is always false lordsawar-0.3.2/src/xmlhelper.cpp:558:7: style: Condition '!d_failed' is always true [knownConditionTrueFalse] lordsawar-0.3.2/src/xmlhelper.cpp:529:16: note: Assuming that condition 'd_failed' is not redundant lordsawar-0.3.2/src/xmlhelper.cpp:558:7: note: Condition '!d_failed' is always true lordsawar-0.3.2/src/xmlhelper.cpp:388:18: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] lordsawar-0.3.2/src/xmlhelper.cpp:168:41: style:inconclusive: Function 'saveData' argument 1 names different: declaration 'identifier' definition 'name'. [funcArgNamesDifferent] lordsawar-0.3.2/src/xmlhelper.h:150:30: note: Function 'saveData' argument 1 names different: declaration 'identifier' definition 'name'. lordsawar-0.3.2/src/xmlhelper.cpp:168:41: note: Function 'saveData' argument 1 names different: declaration 'identifier' definition 'name'. lordsawar-0.3.2/src/xmlhelper.cpp:201:41: style:inconclusive: Function 'saveData' argument 1 names different: declaration 'identifier' definition 'name'. [funcArgNamesDifferent] lordsawar-0.3.2/src/xmlhelper.h:143:37: note: Function 'saveData' argument 1 names different: declaration 'identifier' definition 'name'. lordsawar-0.3.2/src/xmlhelper.cpp:201:41: note: Function 'saveData' argument 1 names different: declaration 'identifier' definition 'name'. lordsawar-0.3.2/src/xmlhelper.cpp:222:41: style:inconclusive: Function 'saveData' argument 1 names different: declaration 'identifier' definition 'name'. [funcArgNamesDifferent] lordsawar-0.3.2/src/xmlhelper.h:144:37: note: Function 'saveData' argument 1 names different: declaration 'identifier' definition 'name'. lordsawar-0.3.2/src/xmlhelper.cpp:222:41: note: Function 'saveData' argument 1 names different: declaration 'identifier' definition 'name'. lordsawar-0.3.2/src/xmlhelper.cpp:243:41: style:inconclusive: Function 'saveData' argument 1 names different: declaration 'identifier' definition 'name'. [funcArgNamesDifferent] lordsawar-0.3.2/src/xmlhelper.h:145:37: note: Function 'saveData' argument 1 names different: declaration 'identifier' definition 'name'. lordsawar-0.3.2/src/xmlhelper.cpp:243:41: note: Function 'saveData' argument 1 names different: declaration 'identifier' definition 'name'. lordsawar-0.3.2/src/xmlhelper.cpp:264:41: style:inconclusive: Function 'saveData' argument 1 names different: declaration 'identifier' definition 'name'. [funcArgNamesDifferent] lordsawar-0.3.2/src/xmlhelper.h:146:37: note: Function 'saveData' argument 1 names different: declaration 'identifier' definition 'name'. lordsawar-0.3.2/src/xmlhelper.cpp:264:41: note: Function 'saveData' argument 1 names different: declaration 'identifier' definition 'name'. lordsawar-0.3.2/src/xmlhelper.cpp:288:41: style:inconclusive: Function 'saveData' argument 1 names different: declaration 'identifier' definition 'name'. [funcArgNamesDifferent] lordsawar-0.3.2/src/xmlhelper.h:147:37: note: Function 'saveData' argument 1 names different: declaration 'identifier' definition 'name'. lordsawar-0.3.2/src/xmlhelper.cpp:288:41: note: Function 'saveData' argument 1 names different: declaration 'identifier' definition 'name'. lordsawar-0.3.2/src/xmlhelper.cpp:309:41: style:inconclusive: Function 'saveData' argument 1 names different: declaration 'identifier' definition 'name'. [funcArgNamesDifferent] lordsawar-0.3.2/src/xmlhelper.h:149:37: note: Function 'saveData' argument 1 names different: declaration 'identifier' definition 'name'. lordsawar-0.3.2/src/xmlhelper.cpp:309:41: note: Function 'saveData' argument 1 names different: declaration 'identifier' definition 'name'. lordsawar-0.3.2/src/xmlhelper.cpp:779:83: style:inconclusive: Function 'on_start_element' argument 2 names different: declaration 'properties' definition 'a'. [funcArgNamesDifferent] lordsawar-0.3.2/src/xmlhelper.h:203:92: note: Function 'on_start_element' argument 2 names different: declaration 'properties' definition 'a'. lordsawar-0.3.2/src/xmlhelper.cpp:779:83: note: Function 'on_start_element' argument 2 names different: declaration 'properties' definition 'a'. lordsawar-0.3.2/src/xmlhelper.cpp:808:53: style:inconclusive: Function 'on_characters' argument 1 names different: declaration 'characters' definition 'text'. [funcArgNamesDifferent] lordsawar-0.3.2/src/xmlhelper.h:205:57: note: Function 'on_characters' argument 1 names different: declaration 'characters' definition 'text'. lordsawar-0.3.2/src/xmlhelper.cpp:808:53: note: Function 'on_characters' argument 1 names different: declaration 'characters' definition 'text'. lordsawar-0.3.2/src/xmlhelper.cpp:645:16: style: Variable 'envlang' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/xmlhelper.cpp:657:9: style: Variable 'first_underscore' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/xmlhelper.cpp:106:98: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/xmlhelper.cpp:613:5: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/vectormap.h:138:18: style: The function 'after_draw' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:221:18: note: Virtual function in base class lordsawar-0.3.2/src/vectormap.h:138:18: note: Function in derived class lordsawar-0.3.2/src/vectormap.cpp:145:17: style: Redundant initialization for 'line_colour'. The initialized value is overwritten before it is read. [redundantInitialization] lordsawar-0.3.2/src/vectormap.cpp:143:25: note: line_colour is initialized lordsawar-0.3.2/src/vectormap.cpp:145:17: note: line_colour is overwritten lordsawar-0.3.2/src/vectormap.cpp:32:28: style:inconclusive: Function 'VectorMap' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/vectormap.h:90:21: note: Function 'VectorMap' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/vectormap.cpp:32:28: note: Function 'VectorMap' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/vectormap.cpp:32:50: style:inconclusive: Function 'VectorMap' argument 2 names different: declaration 'vector' definition 'v'. [funcArgNamesDifferent] lordsawar-0.3.2/src/vectormap.h:90:46: note: Function 'VectorMap' argument 2 names different: declaration 'vector' definition 'v'. lordsawar-0.3.2/src/vectormap.cpp:32:50: note: Function 'VectorMap' argument 2 names different: declaration 'vector' definition 'v'. lordsawar-0.3.2/src/vectormap.cpp:40:51: style:inconclusive: Function 'draw_planted_standard' argument 1 names different: declaration 'pos' definition 'flag'. [funcArgNamesDifferent] lordsawar-0.3.2/src/vectormap.h:172:44: note: Function 'draw_planted_standard' argument 1 names different: declaration 'pos' definition 'flag'. lordsawar-0.3.2/src/vectormap.cpp:40:51: note: Function 'draw_planted_standard' argument 1 names different: declaration 'pos' definition 'flag'. lordsawar-0.3.2/src/vectormap.cpp:52:34: style:inconclusive: Function 'draw_city' argument 1 names different: declaration 'city' definition 'c'. [funcArgNamesDifferent] lordsawar-0.3.2/src/vectormap.h:152:27: note: Function 'draw_city' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/vectormap.cpp:52:34: note: Function 'draw_city' argument 1 names different: declaration 'city' definition 'c'. lordsawar-0.3.2/src/vectormap.cpp:358:18: style: Local variable 'dist' shadows outer function [shadowFunction] lordsawar-0.3.2/src/vector.h:180:10: note: Shadowed declaration lordsawar-0.3.2/src/vectormap.cpp:358:18: note: Shadow variable lordsawar-0.3.2/src/vectormap.cpp:409:18: style: Local variable 'dist' shadows outer function [shadowFunction] lordsawar-0.3.2/src/vector.h:180:10: note: Shadowed declaration lordsawar-0.3.2/src/vectormap.cpp:409:18: note: Shadow variable lordsawar-0.3.2/src/vectormap.cpp:102:47: performance: Function parameter 'citylist' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/vectormap.cpp:161:46: performance: Function parameter 'srcs' should be passed by const reference. [passedByValue] lordsawar-0.3.2/src/vectormap.cpp:52:46: style: Parameter 'type' can be declared as reference to const [constParameterReference] lordsawar-0.3.2/src/vectormap.cpp:52:58: style: Parameter 'prod' can be declared as reference to const [constParameterReference] lordsawar-0.3.2/src/vectormap.cpp:173:13: style: Variable 'c' can be declared as pointer to const [constVariablePointer] lordsawar-0.3.2/src/vectormap.cpp:107:53: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/vectormap.cpp:167:45: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/vectormap.cpp:184:47: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/vectormap.cpp:188:57: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] lordsawar-0.3.2/src/roadlist.cpp:90:42: style:inconclusive: Function 'calculateType' argument 1 names different: declaration 'tile' definition 't'. [funcArgNamesDifferent] lordsawar-0.3.2/src/roadlist.h:53:33: note: Function 'calculateType' argument 1 names different: declaration 'tile' definition 't'. lordsawar-0.3.2/src/roadlist.cpp:90:42: note: Function 'calculateType' argument 1 names different: declaration 'tile' definition 't'. lordsawar-0.3.2/src/roadlist.cpp:71:52: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] diff: head lordsawar-0.3.2/src/CreateScenario.h:58:10: style: The destructor '~CreateScenario' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/CreateScenarioRandomize.h:39:18: note: Virtual destructor in base class lordsawar-0.3.2/src/CreateScenario.h:58:10: note: Destructor in derived class head lordsawar-0.3.2/src/GameScenario.h:79:10: style: The destructor '~GameScenario' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/GameScenarioOptions.h:33:18: note: Virtual destructor in base class lordsawar-0.3.2/src/GameScenario.h:79:10: note: Destructor in derived class head lordsawar-0.3.2/src/Item.h:68:10: style: The destructor '~Item' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/ItemProto.h:123:18: note: Virtual destructor in base class lordsawar-0.3.2/src/Item.h:68:10: note: Destructor in derived class head lordsawar-0.3.2/src/Location.h:62:6: style: The destructor '~Location' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/UniquelyIdentified.h:47:14: note: Virtual destructor in base class lordsawar-0.3.2/src/Location.h:62:6: note: Destructor in derived class head lordsawar-0.3.2/src/MapBackpack.h:52:6: style: The destructor '~MapBackpack' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/UniquelyIdentified.h:47:14: note: Virtual destructor in base class lordsawar-0.3.2/src/MapBackpack.h:52:6: note: Destructor in derived class 2.13.0 lordsawar-0.3.2/src/MapRenderer.cpp:96:20: warning: Either the condition 'style->getImage()==NULL' is redundant or there is possible null pointer dereference: style->getImage(). [nullPointerRedundantCheck] lordsawar-0.3.2/src/MapRenderer.cpp:75:29: note: Assuming that condition 'style->getImage()==NULL' is not redundant lordsawar-0.3.2/src/MapRenderer.cpp:96:20: note: Null pointer dereference head lordsawar-0.3.2/src/NamedLocation.h:49:14: style: The destructor '~NamedLocation' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Location.h:62:6: note: Virtual destructor in base class lordsawar-0.3.2/src/NamedLocation.h:49:14: note: Destructor in derived class head lordsawar-0.3.2/src/NextTurnHotseat.h:50:18: style: The destructor '~NextTurnHotseat' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/NextTurn.h:52:18: note: Virtual destructor in base class lordsawar-0.3.2/src/NextTurnHotseat.h:50:18: note: Destructor in derived class head lordsawar-0.3.2/src/NextTurnNetworked.h:42:18: style: The destructor '~NextTurnNetworked' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/NextTurn.h:52:18: note: Virtual destructor in base class lordsawar-0.3.2/src/NextTurnNetworked.h:42:18: note: Destructor in derived class head lordsawar-0.3.2/src/QCityOccupy.h:49:6: style: The destructor '~QuestCityOccupy' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:98:18: note: Virtual destructor in base class lordsawar-0.3.2/src/QCityOccupy.h:49:6: note: Destructor in derived class head lordsawar-0.3.2/src/QCityRaze.h:49:10: style: The destructor '~QuestCityRaze' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:98:18: note: Virtual destructor in base class lordsawar-0.3.2/src/QCityRaze.h:49:10: note: Destructor in derived class head lordsawar-0.3.2/src/QCitySack.h:52:6: style: The destructor '~QuestCitySack' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:98:18: note: Virtual destructor in base class lordsawar-0.3.2/src/QCitySack.h:52:6: note: Destructor in derived class head lordsawar-0.3.2/src/QEnemyArmies.h:56:6: style: The destructor '~QuestEnemyArmies' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:98:18: note: Virtual destructor in base class lordsawar-0.3.2/src/QEnemyArmies.h:56:6: note: Destructor in derived class head lordsawar-0.3.2/src/QEnemyArmytype.h:51:6: style: The destructor '~QuestEnemyArmytype' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:98:18: note: Virtual destructor in base class lordsawar-0.3.2/src/QEnemyArmytype.h:51:6: note: Destructor in derived class head lordsawar-0.3.2/src/QKillHero.h:53:6: style: The destructor '~QuestKillHero' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:98:18: note: Virtual destructor in base class lordsawar-0.3.2/src/QKillHero.h:53:6: note: Destructor in derived class head lordsawar-0.3.2/src/QPillageGold.h:52:10: style: The destructor '~QuestPillageGold' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Quest.h:98:18: note: Virtual destructor in base class lordsawar-0.3.2/src/QPillageGold.h:52:10: note: Destructor in derived class head lordsawar-0.3.2/src/Quest.h:98:18: style: The destructor '~Quest' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/OwnerId.h:46:14: note: Virtual destructor in base class lordsawar-0.3.2/src/Quest.h:98:18: note: Destructor in derived class head lordsawar-0.3.2/src/Threat.h:73:10: style: The destructor '~Threat' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Ownable.h:45:14: note: Virtual destructor in base class lordsawar-0.3.2/src/Threat.h:73:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1032:10: style: The destructor '~Action_FightOrder' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1032:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1064:10: style: The destructor '~Action_Resign' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1064:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1094:10: style: The destructor '~Action_Plant' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1094:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1144:10: style: The destructor '~Action_Produce' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1144:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1210:10: style: The destructor '~Action_ProduceVectored' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1210:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1266:10: style: The destructor '~Action_DiplomacyState' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1266:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1309:10: style: The destructor '~Action_DiplomacyProposal' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1309:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1354:10: style: The destructor '~Action_DiplomacyScore' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1354:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1385:10: style: The destructor '~Action_EndTurn' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1385:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1409:10: style: The destructor '~Action_ConquerCity' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1409:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1435:10: style: The destructor '~Action_RecruitHero' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1435:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1469:10: style: The destructor '~Action_RenamePlayer' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1469:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1496:10: style: The destructor '~Action_CityTooPoorToProduce' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1496:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1525:10: style: The destructor '~Action_InitTurn' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1525:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1562:10: style: The destructor '~Action_Loot' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1562:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1599:10: style: The destructor '~Action_UseItem' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1599:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1645:10: style: The destructor '~Action_ReorderArmies' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1645:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1680:10: style: The destructor '~Action_ResetStacks' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1680:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1711:10: style: The destructor '~Action_ResetRuins' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1711:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1738:10: style: The destructor '~Action_CollectTaxesAndPayUpkeep' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1738:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1770:10: style: The destructor '~Action_Kill' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1770:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1799:10: style: The destructor '~Action_DefendStack' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1799:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1833:10: style: The destructor '~Action_UndefendStack' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1833:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1866:10: style: The destructor '~Action_ParkStack' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1866:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1900:10: style: The destructor '~Action_UnparkStack' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1900:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1931:10: style: The destructor '~Action_SelectStack' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1931:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:1961:10: style: The destructor '~Action_DeselectStack' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:1961:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:211:10: style: The destructor '~Action_Move' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:211:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:265:10: style: The destructor '~Action_Split' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:265:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:300:10: style: The destructor '~Action_Disband' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:300:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:336:10: style: The destructor '~Action_Fight' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:336:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:386:10: style: The destructor '~Action_Join' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:386:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:421:10: style: The destructor '~Action_Ruin' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:421:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:461:10: style: The destructor '~Action_Temple' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:461:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:497:10: style: The destructor '~Action_Occupy' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:497:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:530:10: style: The destructor '~Action_Pillage' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:530:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:563:10: style: The destructor '~Action_Sack' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:563:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:595:10: style: The destructor '~Action_Raze' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:595:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:630:10: style: The destructor '~Action_Upgrade' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:630:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:673:10: style: The destructor '~Action_Buy' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:673:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:714:10: style: The destructor '~Action_Production' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:714:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:752:10: style: The destructor '~Action_Reward' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:752:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:787:10: style: The destructor '~Action_Quest' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:787:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:838:10: style: The destructor '~Action_Equip' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:838:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:882:10: style: The destructor '~Action_Level' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:882:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:920:10: style: The destructor '~Action_ModifySignpost' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:920:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:957:10: style: The destructor '~Action_RenameCity' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:957:10: note: Destructor in derived class head lordsawar-0.3.2/src/action.h:996:10: style: The destructor '~Action_Vector' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/action.h:158:18: note: Virtual destructor in base class lordsawar-0.3.2/src/action.h:996:10: note: Destructor in derived class head lordsawar-0.3.2/src/advertised-game.h:51:3: style: The destructor '~AdvertisedGame' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/recently-played-game.h:211:3: note: Virtual destructor in base class lordsawar-0.3.2/src/advertised-game.h:51:3: note: Destructor in derived class head lordsawar-0.3.2/src/ai_dummy.h:63:10: style: The destructor '~AI_Dummy' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:65:18: note: Virtual destructor in base class lordsawar-0.3.2/src/ai_dummy.h:63:10: note: Destructor in derived class head lordsawar-0.3.2/src/ai_fast.h:70:10: style: The destructor '~AI_Fast' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:65:18: note: Virtual destructor in base class lordsawar-0.3.2/src/ai_fast.h:70:10: note: Destructor in derived class head lordsawar-0.3.2/src/ai_smart.h:91:10: style: The destructor '~AI_Smart' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/real_player.h:65:18: note: Virtual destructor in base class lordsawar-0.3.2/src/ai_smart.h:91:10: note: Destructor in derived class head lordsawar-0.3.2/src/army.h:132:18: style: The destructor '~Army' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/armybase.h:108:18: note: Virtual destructor in base class lordsawar-0.3.2/src/army.h:132:18: note: Destructor in derived class head lordsawar-0.3.2/src/armyprodbase.h:54:10: style: The destructor '~ArmyProdBase' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/armyprotobase.h:48:10: note: Virtual destructor in base class lordsawar-0.3.2/src/armyprodbase.h:54:10: note: Destructor in derived class head lordsawar-0.3.2/src/armyproto.h:52:10: style: The destructor '~ArmyProto' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/armyprotobase.h:48:10: note: Virtual destructor in base class lordsawar-0.3.2/src/armyproto.h:52:10: note: Destructor in derived class head lordsawar-0.3.2/src/armyprotobase.h:48:10: style: The destructor '~ArmyProtoBase' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/armybase.h:108:18: note: Virtual destructor in base class lordsawar-0.3.2/src/armyprotobase.h:48:10: note: Destructor in derived class 2.13.0 lordsawar-0.3.2/src/armyset.cpp:485:37: warning: Uninitialized variable: unsupported_version [uninitvar] lordsawar-0.3.2/src/setlist.h:283:37: note: Calling function 'create', 2nd argument 'unsupported_version' value is lordsawar-0.3.2/src/armyset.cpp:485:37: note: Uninitialized variable: unsupported_version head lordsawar-0.3.2/src/bridge.h:67:10: style: The destructor '~Bridge' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Location.h:62:6: note: Virtual destructor in base class lordsawar-0.3.2/src/bridge.h:67:10: note: Destructor in derived class head lordsawar-0.3.2/src/city.h:103:10: style: The destructor '~City' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Ownable.h:45:14: note: Virtual destructor in base class lordsawar-0.3.2/src/city.h:103:10: note: Destructor in derived class head lordsawar-0.3.2/src/citymap.h:38:6: style: The destructor '~CityMap' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:63:15: note: Virtual destructor in base class lordsawar-0.3.2/src/citymap.h:38:6: note: Destructor in derived class head lordsawar-0.3.2/src/game-client.h:71:4: style: The destructor '~GameClient' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/game-station.h:59:12: note: Virtual destructor in base class lordsawar-0.3.2/src/game-client.h:71:4: note: Destructor in derived class head lordsawar-0.3.2/src/game-server.h:81:4: style: The destructor '~GameServer' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/game-station.h:59:12: note: Virtual destructor in base class lordsawar-0.3.2/src/game-server.h:81:4: note: Destructor in derived class head lordsawar-0.3.2/src/game.cpp:806:31: style: Parameter 'city' can be declared as pointer to const [constParameterPointer] 2.13.0 lordsawar-0.3.2/src/gamebigmap.cpp:629:17: style: The scope of the variable 't' can be reduced. [variableScope] head lordsawar-0.3.2/src/gamebigmap.h:47:14: style: The destructor '~GameBigMap' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/bigmap.h:60:14: note: Virtual destructor in base class lordsawar-0.3.2/src/gamebigmap.h:47:14: note: Destructor in derived class head lordsawar-0.3.2/src/hero.h:88:10: style: The destructor '~Hero' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/army.h:132:18: note: Virtual destructor in base class lordsawar-0.3.2/src/hero.h:88:10: note: Destructor in derived class head lordsawar-0.3.2/src/heroesmap.h:46:7: style: The destructor '~HeroesMap' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:63:15: note: Virtual destructor in base class lordsawar-0.3.2/src/heroesmap.h:46:7: note: Destructor in derived class head lordsawar-0.3.2/src/heromap.h:45:7: style: The destructor '~HeroMap' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:63:15: note: Virtual destructor in base class lordsawar-0.3.2/src/heromap.h:45:7: note: Destructor in derived class head lordsawar-0.3.2/src/heroproto.h:49:10: style: The destructor '~HeroProto' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/armyproto.h:52:10: note: Virtual destructor in base class lordsawar-0.3.2/src/heroproto.h:49:10: note: Destructor in derived class head lordsawar-0.3.2/src/history.h:147:10: style: The destructor '~History_StartTurn' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:147:10: note: Destructor in derived class head lordsawar-0.3.2/src/history.h:171:10: style: The destructor '~History_FoundSage' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:171:10: note: Destructor in derived class head lordsawar-0.3.2/src/history.h:200:10: style: The destructor '~History_GoldTotal' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:200:10: note: Destructor in derived class head lordsawar-0.3.2/src/history.h:229:10: style: The destructor '~History_HeroEmerges' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:229:10: note: Destructor in derived class head lordsawar-0.3.2/src/history.h:269:10: style: The destructor '~History_CityWon' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:269:10: note: Destructor in derived class head lordsawar-0.3.2/src/history.h:298:10: style: The destructor '~History_HeroCityWon' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:298:10: note: Destructor in derived class head lordsawar-0.3.2/src/history.h:333:10: style: The destructor '~History_CityRazed' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:333:10: note: Destructor in derived class head lordsawar-0.3.2/src/history.h:362:10: style: The destructor '~History_HeroQuestStarted' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:362:10: note: Destructor in derived class head lordsawar-0.3.2/src/history.h:391:10: style: The destructor '~History_HeroQuestCompleted' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:391:10: note: Destructor in derived class head lordsawar-0.3.2/src/history.h:420:10: style: The destructor '~History_HeroKilledInCity' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:420:10: note: Destructor in derived class head lordsawar-0.3.2/src/history.h:455:10: style: The destructor '~History_HeroKilledInBattle' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:455:10: note: Destructor in derived class head lordsawar-0.3.2/src/history.h:484:10: style: The destructor '~History_HeroKilledSearching' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:484:10: note: Destructor in derived class head lordsawar-0.3.2/src/history.h:513:10: style: The destructor '~History_Score' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:513:10: note: Destructor in derived class head lordsawar-0.3.2/src/history.h:542:10: style: The destructor '~History_PlayerVanquished' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:542:10: note: Destructor in derived class head lordsawar-0.3.2/src/history.h:565:10: style: The destructor '~History_DiplomacyPeace' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:565:10: note: Destructor in derived class head lordsawar-0.3.2/src/history.h:594:10: style: The destructor '~History_DiplomacyWar' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:594:10: note: Destructor in derived class head lordsawar-0.3.2/src/history.h:623:10: style: The destructor '~History_DiplomacyTreachery' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:623:10: note: Destructor in derived class head lordsawar-0.3.2/src/history.h:652:10: style: The destructor '~History_HeroFindsAllies' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:652:10: note: Destructor in derived class head lordsawar-0.3.2/src/history.h:680:3: style: The destructor '~History_EndTurn' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:680:3: note: Destructor in derived class head lordsawar-0.3.2/src/history.h:703:10: style: The destructor '~History_HeroRuinExplored' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:703:10: note: Destructor in derived class head lordsawar-0.3.2/src/history.h:739:10: style: The destructor '~History_HeroRewardRuin' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:739:10: note: Destructor in derived class head lordsawar-0.3.2/src/history.h:776:10: style: The destructor '~History_HeroUseItem' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/history.h:103:18: note: Virtual destructor in base class lordsawar-0.3.2/src/history.h:776:10: note: Destructor in derived class head lordsawar-0.3.2/src/historymap.h:48:7: style: The destructor '~HistoryMap' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:63:15: note: Virtual destructor in base class lordsawar-0.3.2/src/historymap.h:48:7: note: Destructor in derived class head lordsawar-0.3.2/src/itemmap.h:47:7: style: The destructor '~ItemMap' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:63:15: note: Virtual destructor in base class lordsawar-0.3.2/src/itemmap.h:47:7: note: Destructor in derived class head lordsawar-0.3.2/src/network-action.h:40:7: style: The destructor '~NetworkAction' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/OwnerId.h:46:14: note: Virtual destructor in base class lordsawar-0.3.2/src/network-action.h:40:7: note: Destructor in derived class 2.13.0 lordsawar-0.3.2/src/network-connection.cpp:381:44: warning: Either the condition 'messages.empty()' is redundant or expression 'messages.front()' cause access out of bounds. [containerOutOfBounds] lordsawar-0.3.2/src/network-connection.cpp:371:31: note: Assuming that condition 'messages.empty()' is not redundant lordsawar-0.3.2/src/network-connection.cpp:381:44: note: Access out of bounds head lordsawar-0.3.2/src/network-connection.cpp:381:44: warning: Either the condition 'messages.empty()' is redundant or expression 'messages.front()' causes access out of bounds. [containerOutOfBounds] lordsawar-0.3.2/src/network-connection.cpp:371:31: note: Assuming that condition 'messages.empty()' is not redundant lordsawar-0.3.2/src/network-connection.cpp:381:44: note: Access out of bounds 2.13.0 lordsawar-0.3.2/src/network-connection.cpp:382:23: warning: Either the condition 'messages.empty()' is redundant or expression 'messages.pop()' cause access out of bounds. [containerOutOfBounds] lordsawar-0.3.2/src/network-connection.cpp:371:31: note: Assuming that condition 'messages.empty()' is not redundant lordsawar-0.3.2/src/network-connection.cpp:382:23: note: Access out of bounds head lordsawar-0.3.2/src/network-connection.cpp:382:23: warning: Either the condition 'messages.empty()' is redundant or expression 'messages.pop()' causes access out of bounds. [containerOutOfBounds] lordsawar-0.3.2/src/network-connection.cpp:371:31: note: Assuming that condition 'messages.empty()' is not redundant lordsawar-0.3.2/src/network-connection.cpp:382:23: note: Access out of bounds 2.13.0 lordsawar-0.3.2/src/network-connection.cpp:384:15: style: Condition 'd_stop' is always false [knownConditionTrueFalse] lordsawar-0.3.2/src/network-connection.cpp:368:15: note: Assuming that condition 'd_stop' is not redundant lordsawar-0.3.2/src/network-connection.cpp:384:15: note: Condition 'd_stop' is always false head lordsawar-0.3.2/src/network-history.h:39:7: style: The destructor '~NetworkHistory' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/OwnerId.h:46:14: note: Virtual destructor in base class lordsawar-0.3.2/src/network-history.h:39:7: note: Destructor in derived class head lordsawar-0.3.2/src/network_player.h:89:10: style: The destructor '~NetworkPlayer' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:188:18: note: Virtual destructor in base class lordsawar-0.3.2/src/network_player.h:89:10: note: Destructor in derived class head lordsawar-0.3.2/src/port.h:55:10: style: The destructor '~Port' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Location.h:62:6: note: Virtual destructor in base class lordsawar-0.3.2/src/port.h:55:10: note: Destructor in derived class head lordsawar-0.3.2/src/questmap.h:49:6: style: The destructor '~QuestMap' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:63:15: note: Virtual destructor in base class lordsawar-0.3.2/src/questmap.h:49:6: note: Destructor in derived class head lordsawar-0.3.2/src/real_player.h:65:18: style: The destructor '~RealPlayer' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/player.h:188:18: note: Virtual destructor in base class lordsawar-0.3.2/src/real_player.h:65:18: note: Destructor in derived class head lordsawar-0.3.2/src/recently-played-game.h:176:3: style: The destructor '~RecentlyPlayedHotseatGame' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/recently-played-game.h:67:18: note: Virtual destructor in base class lordsawar-0.3.2/src/recently-played-game.h:176:3: note: Destructor in derived class head lordsawar-0.3.2/src/recently-played-game.h:211:3: style: The destructor '~RecentlyPlayedNetworkedGame' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/recently-played-game.h:67:18: note: Virtual destructor in base class lordsawar-0.3.2/src/recently-played-game.h:211:3: note: Destructor in derived class 2.13.0 lordsawar-0.3.2/src/reward.cpp:280:20: style: Condition 'percent<100' is always true [knownConditionTrueFalse] lordsawar-0.3.2/src/reward.cpp:265:29: note: Assignment 'percent=Rnd::rand()%100', assigned value is less than 100 lordsawar-0.3.2/src/reward.cpp:280:20: note: Condition 'percent<100' is always true head lordsawar-0.3.2/src/reward.h:213:10: style: The destructor '~Reward_Gold' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/reward.h:110:18: note: Virtual destructor in base class lordsawar-0.3.2/src/reward.h:213:10: note: Destructor in derived class head lordsawar-0.3.2/src/reward.h:278:10: style: The destructor '~Reward_Allies' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/reward.h:110:18: note: Virtual destructor in base class lordsawar-0.3.2/src/reward.h:278:10: note: Destructor in derived class head lordsawar-0.3.2/src/reward.h:391:18: style: The destructor '~Reward_Item' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/reward.h:110:18: note: Virtual destructor in base class lordsawar-0.3.2/src/reward.h:391:18: note: Destructor in derived class head lordsawar-0.3.2/src/reward.h:467:10: style: The destructor '~Reward_Ruin' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/reward.h:110:18: note: Virtual destructor in base class lordsawar-0.3.2/src/reward.h:467:10: note: Destructor in derived class head lordsawar-0.3.2/src/reward.h:551:10: style: The destructor '~Reward_Map' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/reward.h:110:18: note: Virtual destructor in base class lordsawar-0.3.2/src/reward.h:551:10: note: Destructor in derived class head lordsawar-0.3.2/src/road.h:77:10: style: The destructor '~Road' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Location.h:62:6: note: Virtual destructor in base class lordsawar-0.3.2/src/road.h:77:10: note: Destructor in derived class head lordsawar-0.3.2/src/ruin.h:91:10: style: The destructor '~Ruin' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/NamedLocation.h:49:14: note: Virtual destructor in base class lordsawar-0.3.2/src/ruin.h:91:10: note: Destructor in derived class head lordsawar-0.3.2/src/ruinmap.h:47:7: style: The destructor '~RuinMap' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:63:15: note: Virtual destructor in base class lordsawar-0.3.2/src/ruinmap.h:47:7: note: Destructor in derived class head lordsawar-0.3.2/src/select-city-map.h:46:6: style: The destructor '~SelectCityMap' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:63:15: note: Virtual destructor in base class lordsawar-0.3.2/src/select-city-map.h:46:6: note: Destructor in derived class head lordsawar-0.3.2/src/shield.h:64:18: style: The destructor '~Shield' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/tartan.h:72:18: note: Virtual destructor in base class lordsawar-0.3.2/src/shield.h:64:18: note: Destructor in derived class head lordsawar-0.3.2/src/signpost.h:60:10: style: The destructor '~Signpost' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Location.h:62:6: note: Virtual destructor in base class lordsawar-0.3.2/src/signpost.h:60:10: note: Destructor in derived class head lordsawar-0.3.2/src/smallmap.h:54:6: style: The destructor '~SmallMap' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/overviewmap.h:63:15: note: Virtual destructor in base class lordsawar-0.3.2/src/smallmap.h:54:6: note: Destructor in derived class 2.13.0 lordsawar-0.3.2/src/snd.cpp:321:5: error: Memory leak: item [memleak] head lordsawar-0.3.2/src/stack.h:80:10: style: The destructor '~Stack' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/UniquelyIdentified.h:47:14: note: Virtual destructor in base class lordsawar-0.3.2/src/stack.h:80:10: note: Destructor in derived class head lordsawar-0.3.2/src/stone.h:151:10: style: The destructor '~Stone' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Location.h:62:6: note: Virtual destructor in base class lordsawar-0.3.2/src/stone.h:151:10: note: Destructor in derived class head lordsawar-0.3.2/src/temple.h:64:10: style: The destructor '~Temple' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/NamedLocation.h:49:14: note: Virtual destructor in base class lordsawar-0.3.2/src/temple.h:64:10: note: Destructor in derived class 2.13.0 lordsawar-0.3.2/src/tileset.cpp:412:11: style: Consider using std::any_of, std::all_of, std::none_of algorithm instead of a raw loop. [useStlAlgorithm] 2.13.0 lordsawar-0.3.2/src/tileset.cpp:527:33: warning: Uninitialized variable: unsupported_version [uninitvar] lordsawar-0.3.2/src/setlist.h:283:37: note: Calling function 'create', 2nd argument 'unsupported_version' value is lordsawar-0.3.2/src/tileset.cpp:527:33: note: Uninitialized variable: unsupported_version head lordsawar-0.3.2/src/turn-actionlist.h:48:10: style: The destructor '~TurnActionlist' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/OwnerId.h:46:14: note: Virtual destructor in base class lordsawar-0.3.2/src/turn-actionlist.h:48:10: note: Destructor in derived class 2.13.0 lordsawar-0.3.2/src/utils/import.cpp:1237:10: error: Out of bounds access in expression 'order[i]' because 'order' is empty and 'i' may be non-zero. [containerOutOfBounds] lordsawar-0.3.2/src/utils/import.cpp:1234:44: note: Assignment 'order=std::vector()', assigned value is size=0 lordsawar-0.3.2/src/utils/import.cpp:1237:10: note: Access out of bounds head lordsawar-0.3.2/src/utils/import.cpp:1237:10: error: Out of bounds access in expression 'order[i]' because 'order' is empty. [containerOutOfBounds] lordsawar-0.3.2/src/utils/import.cpp:1234:44: note: Assignment 'order=std::vector()', assigned value is size=0 lordsawar-0.3.2/src/utils/import.cpp:1237:10: note: Access out of bounds 2.13.0 lordsawar-0.3.2/src/utils/import.cpp:1240:10: error: Out of bounds access in expression 'order[fight_order_no_boat[c]]' because 'order' is empty and 'fight_order_no_boat[c]' may be non-zero. [containerOutOfBounds] lordsawar-0.3.2/src/utils/import.cpp:1234:44: note: Assignment 'order=std::vector()', assigned value is size=0 lordsawar-0.3.2/src/utils/import.cpp:1240:10: note: Access out of bounds head lordsawar-0.3.2/src/utils/import.cpp:1240:10: error: Out of bounds access in expression 'order[fight_order_no_boat[c]]' because 'order' is empty. [containerOutOfBounds] lordsawar-0.3.2/src/utils/import.cpp:1234:44: note: Assignment 'order=std::vector()', assigned value is size=0 lordsawar-0.3.2/src/utils/import.cpp:1240:10: note: Access out of bounds head lordsawar-0.3.2/src/vectoredunit.h:71:10: style: The destructor '~VectoredUnit' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] lordsawar-0.3.2/src/Ownable.h:45:14: note: Virtual destructor in base class lordsawar-0.3.2/src/vectoredunit.h:71:10: note: Destructor in derived class DONE