2021-09-19 17:52 ftp://ftp.de.debian.org/debian/pool/main/libs/libsolv/libsolv_0.7.17.orig.tar.gz cppcheck-options: --library=posix --library=gnu --library=bsd --library=zlib -j4 --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -rp=temp -D__GNUC__ --platform=unix64 temp platform: Linux-5.10.0-8-amd64-x86_64-with-glibc2.31 python: 3.9.2 client-version: 1.3.12 compiler: g++ (Debian 10.2.1-6) 10.2.1 20210110 cppcheck: head 2.5 head-info: c76e6345c (2021-09-19 15:20:57 +0200) count: 297 TO! elapsed-time: 13.2 1800.1 head-timing-info: Overall time: 0s old-timing-info: head results: libsolv-0.7.17/examples/solv/fastestmirror.c:76:25: error: Invalid connect() argument nr 1. The value is -1 but the valid values are '0:'. [invalidFunctionArg] libsolv-0.7.17/examples/solv/fastestmirror.c:74:21: note: Assignment 'socks[i]=-1', assigned value is -1 libsolv-0.7.17/examples/solv/fastestmirror.c:76:25: note: Invalid argument libsolv-0.7.17/examples/solv/repoinfo.c:127:9: style: Variable 'l' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/ext/repo_appdata.c:540:23: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled] libsolv-0.7.17/ext/repo_appdata.c:327:7: style: Local variable 'id' shadows outer variable [shadowVariable] libsolv-0.7.17/ext/repo_appdata.c:297:6: note: Shadowed declaration libsolv-0.7.17/ext/repo_appdata.c:327:7: note: Shadow variable libsolv-0.7.17/ext/repo_appdata.c:468:59: style: Parameter 's' can be declared with const [constParameter] libsolv-0.7.17/ext/repo_autopattern.c:33:11: style: Condition 'd1>='0'' is always false [knownConditionTrueFalse] libsolv-0.7.17/ext/repo_autopattern.c:30:25: note: Assuming condition 'p[1]' is true libsolv-0.7.17/ext/repo_autopattern.c:32:14: note: Assignment 'd1=p[1]', assigned value is 1 libsolv-0.7.17/ext/repo_autopattern.c:33:11: note: Condition 'd1>='0'' is always false libsolv-0.7.17/ext/repo_autopattern.c:35:16: style: Condition 'd1>='a'' is always false [knownConditionTrueFalse] libsolv-0.7.17/ext/repo_autopattern.c:30:25: note: Assuming condition 'p[1]' is true libsolv-0.7.17/ext/repo_autopattern.c:32:14: note: Assignment 'd1=p[1]', assigned value is 1 libsolv-0.7.17/ext/repo_autopattern.c:35:16: note: Condition 'd1>='a'' is always false libsolv-0.7.17/ext/repo_autopattern.c:37:16: style: Condition 'd1>='A'' is always false [knownConditionTrueFalse] libsolv-0.7.17/ext/repo_autopattern.c:30:25: note: Assuming condition 'p[1]' is true libsolv-0.7.17/ext/repo_autopattern.c:32:14: note: Assignment 'd1=p[1]', assigned value is 1 libsolv-0.7.17/ext/repo_autopattern.c:37:16: note: Condition 'd1>='A'' is always false libsolv-0.7.17/ext/repo_autopattern.c:41:11: style: Condition 'd2>='0'' is always false [knownConditionTrueFalse] libsolv-0.7.17/ext/repo_autopattern.c:30:33: note: Assuming condition 'p[2]' is true libsolv-0.7.17/ext/repo_autopattern.c:32:25: note: Assignment 'd2=p[2]', assigned value is 1 libsolv-0.7.17/ext/repo_autopattern.c:41:11: note: Condition 'd2>='0'' is always false libsolv-0.7.17/ext/repo_autopattern.c:43:16: style: Condition 'd2>='a'' is always false [knownConditionTrueFalse] libsolv-0.7.17/ext/repo_autopattern.c:30:33: note: Assuming condition 'p[2]' is true libsolv-0.7.17/ext/repo_autopattern.c:32:25: note: Assignment 'd2=p[2]', assigned value is 1 libsolv-0.7.17/ext/repo_autopattern.c:43:16: note: Condition 'd2>='a'' is always false libsolv-0.7.17/ext/repo_autopattern.c:45:16: style: Condition 'd2>='A'' is always false [knownConditionTrueFalse] libsolv-0.7.17/ext/repo_autopattern.c:30:33: note: Assuming condition 'p[2]' is true libsolv-0.7.17/ext/repo_autopattern.c:32:25: note: Assignment 'd2=p[2]', assigned value is 1 libsolv-0.7.17/ext/repo_autopattern.c:45:16: note: Condition 'd2>='A'' is always false libsolv-0.7.17/ext/repo_autopattern.c:49:11: style: Condition 'd1!=-1' is always false [knownConditionTrueFalse] libsolv-0.7.17/ext/repo_autopattern.c:40:12: note: Assignment 'd1=-1', assigned value is -1 libsolv-0.7.17/ext/repo_autopattern.c:49:11: note: Condition 'd1!=-1' is always false libsolv-0.7.17/ext/repo_autopattern.c:406:7: style: Local variable 'evr' shadows outer variable [shadowVariable] libsolv-0.7.17/ext/repo_autopattern.c:330:16: note: Shadowed declaration libsolv-0.7.17/ext/repo_autopattern.c:406:7: note: Shadow variable libsolv-0.7.17/ext/repo_conda.c:299:13: style: Variable 'type' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/ext/repo_conda.c:301:18: style: Variable 'type' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/ext/repo_cudf.c:45:7: style: Variable 'evr' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/examples/solv/solv.c:865:5: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] libsolv-0.7.17/examples/solv/solv.c:826:11: style: Local variable 'p' shadows outer variable [shadowVariable] libsolv-0.7.17/examples/solv/solv.c:211:6: note: Shadowed declaration libsolv-0.7.17/examples/solv/solv.c:826:11: note: Shadow variable libsolv-0.7.17/examples/solv/solv.c:859:8: style: Local variable 'p' shadows outer variable [shadowVariable] libsolv-0.7.17/examples/solv/solv.c:211:6: note: Shadowed declaration libsolv-0.7.17/examples/solv/solv.c:859:8: note: Shadow variable libsolv-0.7.17/ext/repo_products.c:325:23: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled] libsolv-0.7.17/ext/repo_products.c:390:46: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] libsolv-0.7.17/ext/repo_deb.c:288:37: warning: Logical conjunction always evaluates to false: EXPR == ' ' && EXPR == '\t'. [incorrectLogicOperator] libsolv-0.7.17/ext/repo_deb.c:285:10: style: Local variable 'q' shadows outer variable [shadowVariable] libsolv-0.7.17/ext/repo_deb.c:270:13: note: Shadowed declaration libsolv-0.7.17/ext/repo_deb.c:285:10: note: Shadow variable libsolv-0.7.17/ext/repo_deb.c:565:44: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] libsolv-0.7.17/ext/repo_deb.c:180:7: style: Variable 'evr' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/ext/repo_releasefile_products.c:143:19: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled] libsolv-0.7.17/ext/repo_releasefile_products.c:81:14: style: Local variable 'ptr1' shadows outer variable [shadowVariable] libsolv-0.7.17/ext/repo_releasefile_products.c:48:15: note: Shadowed declaration libsolv-0.7.17/ext/repo_releasefile_products.c:81:14: note: Shadow variable libsolv-0.7.17/ext/repo_arch.c:824:20: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled] libsolv-0.7.17/ext/repo_arch.c:270:14: style: Condition 'l>1' is always false [knownConditionTrueFalse] libsolv-0.7.17/ext/repo_arch.c:268:8: note: Assuming condition 'l' is true libsolv-0.7.17/ext/repo_arch.c:270:14: note: Condition 'l>1' is always false libsolv-0.7.17/ext/repo_arch.c:444:7: style: Condition 's' is always true [knownConditionTrueFalse] libsolv-0.7.17/ext/repo_arch.c:437:7: note: Assuming that condition '!s' is not redundant libsolv-0.7.17/ext/repo_arch.c:444:7: note: Condition 's' is always true libsolv-0.7.17/ext/repo_arch.c:486:7: style: Condition 'l' is always true [knownConditionTrueFalse] libsolv-0.7.17/ext/repo_arch.c:484:7: note: Assuming that condition '!l' is not redundant libsolv-0.7.17/ext/repo_arch.c:486:7: note: Condition 'l' is always true libsolv-0.7.17/ext/repo_arch.c:344:43: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] libsolv-0.7.17/ext/repo_pubkey.c:474:18: style: Condition 'x>=192' is always true [knownConditionTrueFalse] libsolv-0.7.17/ext/repo_pubkey.c:472:13: note: Assuming that condition 'x<192' is not redundant libsolv-0.7.17/ext/repo_pubkey.c:474:18: note: Condition 'x>=192' is always true libsolv-0.7.17/ext/repo_pubkey.c:826:22: error: Pointer addition with NULL pointer. [nullPointerArithmetic] libsolv-0.7.17/ext/repo_pubkey.c:816:15: note: Assignment 'buf=0', assigned value is 0 libsolv-0.7.17/ext/repo_pubkey.c:821:20: note: Assuming condition is false libsolv-0.7.17/ext/repo_pubkey.c:826:22: note: Null pointer addition libsolv-0.7.17/ext/repo_pubkey.c:855:44: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] libsolv-0.7.17/ext/repo_pubkey.c:992:43: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] libsolv-0.7.17/ext/repo_pubkey.c:887:30: style: Parameter 'sig' can be declared with const [constParameter] libsolv-0.7.17/ext/repo_pubkey.c:897:33: style: Parameter 'pkt' can be declared with const [constParameter] libsolv-0.7.17/ext/repo_rpmmd.c:543:19: style: Local variable 'd' shadows outer variable [shadowVariable] libsolv-0.7.17/ext/repo_rpmmd.c:531:18: note: Shadowed declaration libsolv-0.7.17/ext/repo_rpmmd.c:543:19: note: Shadow variable libsolv-0.7.17/ext/repo_rpmmd.c:675:16: style: Local variable 'str' shadows outer variable [shadowVariable] libsolv-0.7.17/ext/repo_rpmmd.c:637:15: note: Shadowed declaration libsolv-0.7.17/ext/repo_rpmmd.c:675:16: note: Shadow variable libsolv-0.7.17/ext/repo_rpmmd.c:562:11: style: Variable 'ht[h]' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/ext/repo_testcase.c:609:8: error: Array 'sp[5]' accessed at index sp[*][-1], which is out of bounds. [negativeIndex] libsolv-0.7.17/ext/repo_testcase.c:407:19: style: Local variable 's' shadows outer argument [shadowArgument] libsolv-0.7.17/ext/repo_testcase.c:398:64: note: Shadowed declaration libsolv-0.7.17/ext/repo_testcase.c:407:19: note: Shadow variable libsolv-0.7.17/ext/repo_testcase.c:398:64: style: Parameter 's' can be declared with const [constParameter] libsolv-0.7.17/ext/repo_zyppdb.c:170:23: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled] libsolv-0.7.17/ext/repo_zyppdb.c:189:12: warning: Either the condition 'dir' is redundant or there is possible null pointer dereference: dir. [nullPointerRedundantCheck] libsolv-0.7.17/ext/repo_zyppdb.c:168:7: note: Assuming that condition 'dir' is not redundant libsolv-0.7.17/ext/repo_zyppdb.c:189:12: note: Null pointer dereference libsolv-0.7.17/ext/repo_updateinfoxml.c:306:25: style: Local variable 'name' shadows outer argument [shadowArgument] libsolv-0.7.17/ext/repo_updateinfoxml.c:208:66: note: Shadowed declaration libsolv-0.7.17/ext/repo_updateinfoxml.c:306:25: note: Shadow variable libsolv-0.7.17/ext/repo_updateinfoxml.c:346:21: style: Local variable 'name' shadows outer argument [shadowArgument] libsolv-0.7.17/ext/repo_updateinfoxml.c:208:66: note: Shadowed declaration libsolv-0.7.17/ext/repo_updateinfoxml.c:346:21: note: Shadow variable libsolv-0.7.17/ext/solv_xfopen.c:51:0: error: #error Need to implement custom I/O [preprocessorErrorDirective] libsolv-0.7.17/ext/solv_zchunk.c:61:9: style: Condition 'p=endp' is false libsolv-0.7.17/ext/solv_zchunk.c:61:9: note: Condition 'p0' is always true [knownConditionTrueFalse] libsolv-0.7.17/src/conda.c:340:10: note: Assuming that condition 'r==0' is not redundant libsolv-0.7.17/src/conda.c:342:10: note: Condition 'r>0' is always true libsolv-0.7.17/src/conda.c:221:31: warning: Either the condition 'r1' is redundant or there is pointer arithmetic with NULL pointer. [nullPointerArithmeticRedundantCheck] libsolv-0.7.17/src/conda.c:219:7: note: Assuming that condition 'r1' is not redundant libsolv-0.7.17/src/conda.c:221:31: note: Null pointer addition libsolv-0.7.17/src/conda.c:262:17: style: Variable 'j' is reassigned a value before the old one has been used. [redundantAssignment] libsolv-0.7.17/src/conda.c:261:5: note: j is assigned libsolv-0.7.17/src/conda.c:262:17: note: j is overwritten libsolv-0.7.17/src/conda.c:137:21: style: Clarify calculation precedence for '-' and '?'. [clarifyCalculation] libsolv-0.7.17/ext/repo_rpmdb.c:1372:22: style:inconclusive: Function 'rpm_state_free' argument 1 names different: declaration 'rpmstate' definition 'state'. [funcArgNamesDifferent] libsolv-0.7.17/ext/repo_rpmdb.h:40:35: note: Function 'rpm_state_free' argument 1 names different: declaration 'rpmstate' definition 'state'. libsolv-0.7.17/ext/repo_rpmdb.c:1372:22: note: Function 'rpm_state_free' argument 1 names different: declaration 'rpmstate' definition 'state'. libsolv-0.7.17/ext/repo_rpmdb.c:1902:44: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] libsolv-0.7.17/ext/repo_rpmdb.c:761:77: style: Parameter 'di' can be declared with const [constParameter] libsolv-0.7.17/src/diskusage.c:91:72: error: syntax error: ~) [syntaxError] libsolv-0.7.17/src/evr.c:160:9: style: Variable 'r' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/fileprovides.c:439:3: error: Address of local auto-variable assigned to a function parameter. [autoVariables] libsolv-0.7.17/src/fileprovides.c:454:4: error: Address of local auto-variable assigned to a function parameter. [autoVariables] libsolv-0.7.17/ext/testcase.c:1459:19: style: Expression is always true because 'else if' condition is opposite to previous condition at line 1457. [multiCondition] libsolv-0.7.17/ext/testcase.c:1457:19: note: first condition libsolv-0.7.17/ext/testcase.c:1459:19: note: else if condition is opposite to first condition libsolv-0.7.17/ext/testcase.c:421:9: warning:inconclusive: Possible null pointer dereference: repo [nullPointer] libsolv-0.7.17/ext/testcase.c:406:16: note: Assignment 'repo=0', assigned value is 0 libsolv-0.7.17/ext/testcase.c:407:21: note: Assuming condition is false libsolv-0.7.17/ext/testcase.c:421:9: note: Null pointer dereference libsolv-0.7.17/ext/testcase.c:1917:14: style: Checking if unsigned expression 'rl' is less than zero. [unsignedLessThanZero] libsolv-0.7.17/ext/testcase.c:1945:14: style: Checking if unsigned expression 'rl' is less than zero. [unsignedLessThanZero] libsolv-0.7.17/ext/testcase.c:1237:41: style:inconclusive: Function 'testcase_solverresult' argument 2 names different: declaration 'flags' definition 'resultflags'. [funcArgNamesDifferent] libsolv-0.7.17/ext/testcase.h:41:54: note: Function 'testcase_solverresult' argument 2 names different: declaration 'flags' definition 'resultflags'. libsolv-0.7.17/ext/testcase.c:1237:41: note: Function 'testcase_solverresult' argument 2 names different: declaration 'flags' definition 'resultflags'. libsolv-0.7.17/ext/testcase.c:1412:14: style: Local variable 's' shadows outer variable [shadowVariable] libsolv-0.7.17/ext/testcase.c:1242:15: note: Shadowed declaration libsolv-0.7.17/ext/testcase.c:1412:14: note: Shadow variable libsolv-0.7.17/ext/testcase.c:1430:15: style: Local variable 's' shadows outer variable [shadowVariable] libsolv-0.7.17/ext/testcase.c:1242:15: note: Shadowed declaration libsolv-0.7.17/ext/testcase.c:1430:15: note: Shadow variable libsolv-0.7.17/ext/testcase.c:1436:15: style: Local variable 's' shadows outer variable [shadowVariable] libsolv-0.7.17/ext/testcase.c:1242:15: note: Shadowed declaration libsolv-0.7.17/ext/testcase.c:1436:15: note: Shadow variable libsolv-0.7.17/ext/testcase.c:1443:15: style: Local variable 's' shadows outer variable [shadowVariable] libsolv-0.7.17/ext/testcase.c:1242:15: note: Shadowed declaration libsolv-0.7.17/ext/testcase.c:1443:15: note: Shadow variable libsolv-0.7.17/ext/testcase.c:1451:11: style: Local variable 'p' shadows outer variable [shadowVariable] libsolv-0.7.17/ext/testcase.c:1241:6: note: Shadowed declaration libsolv-0.7.17/ext/testcase.c:1451:11: note: Shadow variable libsolv-0.7.17/ext/testcase.c:1475:11: style: Local variable 'i' shadows outer variable [shadowVariable] libsolv-0.7.17/ext/testcase.c:1240:7: note: Shadowed declaration libsolv-0.7.17/ext/testcase.c:1475:11: note: Shadow variable libsolv-0.7.17/ext/testcase.c:1487:11: style: Local variable 'p' shadows outer variable [shadowVariable] libsolv-0.7.17/ext/testcase.c:1241:6: note: Shadowed declaration libsolv-0.7.17/ext/testcase.c:1487:11: note: Shadow variable libsolv-0.7.17/ext/testcase.c:1488:20: style: Local variable 's' shadows outer variable [shadowVariable] libsolv-0.7.17/ext/testcase.c:1242:15: note: Shadowed declaration libsolv-0.7.17/ext/testcase.c:1488:20: note: Shadow variable libsolv-0.7.17/ext/testcase.c:2350:18: style: Local variable 's' shadows outer variable [shadowVariable] libsolv-0.7.17/ext/testcase.c:1983:23: note: Shadowed declaration libsolv-0.7.17/ext/testcase.c:2350:18: note: Shadow variable libsolv-0.7.17/ext/testcase.c:1735:23: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] libsolv-0.7.17/ext/testcase.c:2327:23: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] libsolv-0.7.17/ext/testcase.c:1735:23: error: Signed integer overflow for expression '1<<31'. [integerOverflow] libsolv-0.7.17/ext/testcase.c:2327:23: error: Signed integer overflow for expression '1<<31'. [integerOverflow] libsolv-0.7.17/src/pool.c:322:12: warning: Identical inner 'return' condition is always true. [identicalInnerCondition] libsolv-0.7.17/src/pool.c:321:7: note: outer condition: *da libsolv-0.7.17/src/pool.c:322:12: note: identical inner condition: *da libsolv-0.7.17/src/pool.c:298:38: style:inconclusive: Function 'pool_set_installed' argument 2 names different: declaration 'repo' definition 'installed'. [funcArgNamesDifferent] libsolv-0.7.17/src/pool.h:269:59: note: Function 'pool_set_installed' argument 2 names different: declaration 'repo' definition 'installed'. libsolv-0.7.17/src/pool.c:298:38: note: Function 'pool_set_installed' argument 2 names different: declaration 'repo' definition 'installed'. libsolv-0.7.17/src/pool.c:2043:46: style:inconclusive: Function 'pool_prepend_rootdir' argument 2 names different: declaration 'dir' definition 'path'. [funcArgNamesDifferent] libsolv-0.7.17/src/pool.h:276:59: note: Function 'pool_prepend_rootdir' argument 2 names different: declaration 'dir' definition 'path'. libsolv-0.7.17/src/pool.c:2043:46: note: Function 'pool_prepend_rootdir' argument 2 names different: declaration 'dir' definition 'path'. libsolv-0.7.17/src/pool.c:2053:50: style:inconclusive: Function 'pool_prepend_rootdir_tmp' argument 2 names different: declaration 'dir' definition 'path'. [funcArgNamesDifferent] libsolv-0.7.17/src/pool.h:277:69: note: Function 'pool_prepend_rootdir_tmp' argument 2 names different: declaration 'dir' definition 'path'. libsolv-0.7.17/src/pool.c:2053:50: note: Function 'pool_prepend_rootdir_tmp' argument 2 names different: declaration 'dir' definition 'path'. libsolv-0.7.17/src/policy.c:916:13: style: Condition 'r==0' is always true [knownConditionTrueFalse] libsolv-0.7.17/src/policy.c:911:11: note: Assignment 'r=0', assigned value is 0 libsolv-0.7.17/src/policy.c:916:13: note: Condition 'r==0' is always true libsolv-0.7.17/src/policy.c:1451:43: style:inconclusive: Function 'policy_is_illegal' argument 2 names different: declaration 's1' definition 'is'. [funcArgNamesDifferent] libsolv-0.7.17/src/policy.h:35:55: note: Function 'policy_is_illegal' argument 2 names different: declaration 's1' definition 'is'. libsolv-0.7.17/src/policy.c:1451:43: note: Function 'policy_is_illegal' argument 2 names different: declaration 's1' definition 'is'. libsolv-0.7.17/src/policy.c:1451:57: style:inconclusive: Function 'policy_is_illegal' argument 3 names different: declaration 's2' definition 's'. [funcArgNamesDifferent] libsolv-0.7.17/src/policy.h:35:69: note: Function 'policy_is_illegal' argument 3 names different: declaration 's2' definition 's'. libsolv-0.7.17/src/policy.c:1451:57: note: Function 'policy_is_illegal' argument 3 names different: declaration 's2' definition 's'. libsolv-0.7.17/src/policy.c:1575:69: style:inconclusive: Function 'policy_findupdatepackages' argument 4 names different: declaration 'allowall' definition 'allow_all'. [funcArgNamesDifferent] libsolv-0.7.17/src/policy.h:36:81: note: Function 'policy_findupdatepackages' argument 4 names different: declaration 'allowall' definition 'allow_all'. libsolv-0.7.17/src/policy.c:1575:69: note: Function 'policy_findupdatepackages' argument 4 names different: declaration 'allowall' definition 'allow_all'. libsolv-0.7.17/src/policy.c:1093:17: style: Local variable 's' shadows outer variable [shadowVariable] libsolv-0.7.17/src/policy.c:1079:17: note: Shadowed declaration libsolv-0.7.17/src/policy.c:1093:17: note: Shadow variable libsolv-0.7.17/src/poolvendor.c:64:16: style: Comparing expression of type 'signed int' against value 2147483648. Condition is always false. [compareValueOutOfTypeRangeError] libsolv-0.7.17/src/poolvendor.c:64:16: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] libsolv-0.7.17/src/poolvendor.c:64:16: error: Signed integer overflow for expression '1<<31'. [integerOverflow] libsolv-0.7.17/src/order.c:161:71: style: Condition 'trans->transaction_installed[from-pool->installed->start]>0' is always true [knownConditionTrueFalse] libsolv-0.7.17/src/order.c:158:65: note: Assuming condition 'trans->transaction_installed[from-pool->installed->start]' is true libsolv-0.7.17/src/order.c:161:71: note: Condition 'trans->transaction_installed[from-pool->installed->start]>0' is always true libsolv-0.7.17/src/order.c:180:69: style: Condition 'trans->transaction_installed[to-pool->installed->start]>0' is always true [knownConditionTrueFalse] libsolv-0.7.17/src/order.c:177:65: note: Assuming condition 'trans->transaction_installed[to-pool->installed->start]' is true libsolv-0.7.17/src/order.c:180:69: note: Condition 'trans->transaction_installed[to-pool->installed->start]>0' is always true libsolv-0.7.17/src/queue.h:37:7: warning: Either the condition 'q' is redundant or there is possible null pointer dereference: q. [nullPointerRedundantCheck] libsolv-0.7.17/src/order.c:1397:7: note: Assuming that condition 'q' is not redundant libsolv-0.7.17/src/order.c:1381:15: note: Calling function 'queue_empty', 1st argument 'q' value is 0 libsolv-0.7.17/src/queue.h:37:7: note: Null pointer dereference libsolv-0.7.17/src/order.c:795:38: style: Local variable 'od' shadows outer variable [shadowVariable] libsolv-0.7.17/src/order.c:779:20: note: Shadowed declaration libsolv-0.7.17/src/order.c:795:38: note: Shadow variable libsolv-0.7.17/src/order.c:1017:17: style: Local variable 's' shadows outer variable [shadowVariable] libsolv-0.7.17/src/order.c:777:13: note: Shadowed declaration libsolv-0.7.17/src/order.c:1017:17: note: Shadow variable libsolv-0.7.17/src/order.c:1047:12: style: Local variable 'k' shadows outer variable [shadowVariable] libsolv-0.7.17/src/order.c:778:13: note: Shadowed declaration libsolv-0.7.17/src/order.c:1047:12: note: Shadow variable libsolv-0.7.17/src/order.c:1072:18: style: Local variable 's' shadows outer variable [shadowVariable] libsolv-0.7.17/src/order.c:777:13: note: Shadowed declaration libsolv-0.7.17/src/order.c:1072:18: note: Shadow variable libsolv-0.7.17/src/order.c:654:41: style: Parameter 'cycle' can be declared with const [constParameter] libsolv-0.7.17/src/cleandeps.c:300:11: style: Local variable 'count' shadows outer variable [shadowVariable] libsolv-0.7.17/src/cleandeps.c:243:19: note: Shadowed declaration libsolv-0.7.17/src/cleandeps.c:300:11: note: Shadow variable libsolv-0.7.17/src/cleandeps.c:768:14: style: Local variable 's' shadows outer variable [shadowVariable] libsolv-0.7.17/src/cleandeps.c:658:13: note: Shadowed declaration libsolv-0.7.17/src/cleandeps.c:768:14: note: Shadow variable libsolv-0.7.17/src/repo.c:1215:18: style: Condition 'marker<0' is always false [knownConditionTrueFalse] libsolv-0.7.17/src/repo.c:1212:7: note: Assuming condition 'marker' is true libsolv-0.7.17/src/repo.c:1215:18: note: Condition 'marker<0' is always false libsolv-0.7.17/src/repo.c:1295:29: style: Condition 'keyname>=SOLVABLE_NAME' is always true [knownConditionTrueFalse] libsolv-0.7.17/src/repo.c:1294:15: note: Assuming that condition 'keyname>=SOLVABLE_NAME' is not redundant libsolv-0.7.17/src/repo.c:1295:29: note: Condition 'keyname>=SOLVABLE_NAME' is always true libsolv-0.7.17/src/repo.c:1295:57: style: Condition 'keyname<=RPM_RPMDBID' is always true [knownConditionTrueFalse] libsolv-0.7.17/src/repo.c:1294:43: note: Assuming that condition 'keyname<=RPM_RPMDBID' is not redundant libsolv-0.7.17/src/repo.c:1295:57: note: Condition 'keyname<=RPM_RPMDBID' is always true libsolv-0.7.17/src/repo.c:910:34: style:inconclusive: Function 'repo_search' argument 3 names different: declaration 'key' definition 'keyname'. [funcArgNamesDifferent] libsolv-0.7.17/src/repo.h:173:39: note: Function 'repo_search' argument 3 names different: declaration 'key' definition 'keyname'. libsolv-0.7.17/src/repo.c:910:34: note: Function 'repo_search' argument 3 names different: declaration 'key' definition 'keyname'. libsolv-0.7.17/src/repo.c:1333:16: style: Local variable 'data' shadows outer variable [shadowVariable] libsolv-0.7.17/src/repo.c:1326:13: note: Shadowed declaration libsolv-0.7.17/src/repo.c:1333:16: note: Shadow variable libsolv-0.7.17/src/repodata.c:1464:13: style: Condition 'l<0' is always false [knownConditionTrueFalse] libsolv-0.7.17/src/repodata.c:1463:23: note: Assignment 'l=strlen(str)-strlen(ma->match)', assigned value is greater than -1 libsolv-0.7.17/src/repodata.c:1464:13: note: Condition 'l<0' is always false libsolv-0.7.17/src/repodata.c:1499:13: style: Condition 'l<0' is always false [knownConditionTrueFalse] libsolv-0.7.17/src/repodata.c:1498:28: note: Assignment 'l=strlen(basename)-strlen(match)', assigned value is greater than -1 libsolv-0.7.17/src/repodata.c:1499:13: note: Condition 'l<0' is always false libsolv-0.7.17/src/repodata.c:3147:21: style: Condition '(x>>35)!=0' is always true [knownConditionTrueFalse] libsolv-0.7.17/src/repodata.c:3145:9: note: Assuming that condition 'x>=0x100000000' is not redundant libsolv-0.7.17/src/repodata.c:3147:21: note: Condition '(x>>35)!=0' is always true libsolv-0.7.17/src/repodata.c:781:5: warning: Label 'case_CHKSUM_TYPES' is not used. Should this be a 'case' of the enclosing switch()? [unusedLabelSwitch] libsolv-0.7.17/src/repodata.c:1034:5: warning: Label 'case_CHKSUM_TYPES' is not used. Should this be a 'case' of the enclosing switch()? [unusedLabelSwitch] libsolv-0.7.17/src/repodata.c:1161:5: warning: Label 'case_CHKSUM_TYPES' is not used. Should this be a 'case' of the enclosing switch()? [unusedLabelSwitch] libsolv-0.7.17/src/repodata.c:2224:5: warning: Label 'case_CHKSUM_TYPES' is not used. Should this be a 'case' of the enclosing switch()? [unusedLabelSwitch] libsolv-0.7.17/src/repodata.c:2240:2: warning: Label 'case_CHKSUM_TYPES' is not used. Should this be a 'case' of the enclosing switch()? [unusedLabelSwitch] libsolv-0.7.17/src/repodata.c:3017:5: warning: Label 'case_CHKSUM_TYPES' is not used. Should this be a 'case' of the enclosing switch()? [unusedLabelSwitch] libsolv-0.7.17/src/repodata.c:3212:6: warning: Label 'case_CHKSUM_TYPES' is not used. Should this be a 'case' of the enclosing switch()? [unusedLabelSwitch] libsolv-0.7.17/src/repodata.c:3252:6: warning: Label 'case_CHKSUM_TYPES' is not used. Should this be a 'case' of the enclosing switch()? [unusedLabelSwitch] libsolv-0.7.17/src/repodata.c:1482:56: style:inconclusive: Function 'datamatcher_checkbasename' argument 2 names different: declaration 'str' definition 'basename'. [funcArgNamesDifferent] libsolv-0.7.17/src/dataiterator.h:85:61: note: Function 'datamatcher_checkbasename' argument 2 names different: declaration 'str' definition 'basename'. libsolv-0.7.17/src/repodata.c:1482:56: note: Function 'datamatcher_checkbasename' argument 2 names different: declaration 'str' definition 'basename'. libsolv-0.7.17/src/repodata.c:2334:42: style:inconclusive: Function 'repodata_extend_block' argument 2 names different: declaration 'p' definition 'start'. [funcArgNamesDifferent] libsolv-0.7.17/src/repodata.h:249:47: note: Function 'repodata_extend_block' argument 2 names different: declaration 'p' definition 'start'. libsolv-0.7.17/src/repodata.c:2334:42: note: Function 'repodata_extend_block' argument 2 names different: declaration 'p' definition 'start'. libsolv-0.7.17/src/repodata.c:2630:30: style:inconclusive: Function 'repodata_set_bin_checksum' argument 5 names different: declaration 'buf' definition 'str'. [funcArgNamesDifferent] libsolv-0.7.17/src/repodata.h:277:32: note: Function 'repodata_set_bin_checksum' argument 5 names different: declaration 'buf' definition 'str'. libsolv-0.7.17/src/repodata.c:2630:30: note: Function 'repodata_set_bin_checksum' argument 5 names different: declaration 'buf' definition 'str'. libsolv-0.7.17/src/repodata.c:2969:65: style:inconclusive: Function 'repodata_add_fixarray' argument 4 names different: declaration 'ghandle' definition 'handle'. [funcArgNamesDifferent] libsolv-0.7.17/src/repodata.h:291:70: note: Function 'repodata_add_fixarray' argument 4 names different: declaration 'ghandle' definition 'handle'. libsolv-0.7.17/src/repodata.c:2969:65: note: Function 'repodata_add_fixarray' argument 4 names different: declaration 'ghandle' definition 'handle'. libsolv-0.7.17/src/repodata.c:2977:66: style:inconclusive: Function 'repodata_add_flexarray' argument 4 names different: declaration 'ghandle' definition 'handle'. [funcArgNamesDifferent] libsolv-0.7.17/src/repodata.h:292:71: note: Function 'repodata_add_flexarray' argument 4 names different: declaration 'ghandle' definition 'handle'. libsolv-0.7.17/src/repodata.c:2977:66: note: Function 'repodata_add_flexarray' argument 4 names different: declaration 'ghandle' definition 'handle'. libsolv-0.7.17/src/repodata.c:3892:47: style:inconclusive: Function 'repodata_set_filelisttype' argument 2 names different: declaration 'filelisttype' definition 'type'. [funcArgNamesDifferent] libsolv-0.7.17/src/repodata.h:219:52: note: Function 'repodata_set_filelisttype' argument 2 names different: declaration 'filelisttype' definition 'type'. libsolv-0.7.17/src/repodata.c:3892:47: note: Function 'repodata_set_filelisttype' argument 2 names different: declaration 'filelisttype' definition 'type'. libsolv-0.7.17/src/repodata.c:1544:24: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] libsolv-0.7.17/src/repodata.c:1599:25: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] libsolv-0.7.17/src/repodata.c:1619:17: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] libsolv-0.7.17/src/repodata.c:1719:22: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] libsolv-0.7.17/src/repodata.c:1835:22: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] libsolv-0.7.17/src/repodata.c:2039:17: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] libsolv-0.7.17/src/repodata.c:2040:31: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] libsolv-0.7.17/src/repodata.c:2188:18: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] libsolv-0.7.17/src/repodata.c:2202:17: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] libsolv-0.7.17/src/repodata.c:1544:24: error: Signed integer overflow for expression '1<<31'. [integerOverflow] libsolv-0.7.17/src/repodata.c:1599:25: error: Signed integer overflow for expression '1<<31'. [integerOverflow] libsolv-0.7.17/src/repodata.c:1619:17: error: Signed integer overflow for expression '1<<31'. [integerOverflow] libsolv-0.7.17/src/repodata.c:1719:22: error: Signed integer overflow for expression '1<<31'. [integerOverflow] libsolv-0.7.17/src/repodata.c:1835:22: error: Signed integer overflow for expression '1<<31'. [integerOverflow] libsolv-0.7.17/src/repodata.c:2039:17: error: Signed integer overflow for expression '1<<31'. [integerOverflow] libsolv-0.7.17/src/repodata.c:2040:31: error: Signed integer overflow for expression '1<<31'. [integerOverflow] libsolv-0.7.17/src/repodata.c:2188:18: error: Signed integer overflow for expression '1<<31'. [integerOverflow] libsolv-0.7.17/src/repodata.c:2202:17: error: Signed integer overflow for expression '1<<31'. [integerOverflow] libsolv-0.7.17/src/repodata.c:1177:9: style: struct member 'subschema_data::cbdata' is never used. [unusedStructMember] libsolv-0.7.17/src/repodata.c:715:6: style: Variable 'dp' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/repodata.c:808:10: style: Variable 'dp' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/repopage.c:207:21: style: Local variable 'hval' shadows outer variable [shadowVariable] libsolv-0.7.17/src/repopage.c:112:20: note: Shadowed declaration libsolv-0.7.17/src/repopage.c:207:21: note: Shadow variable libsolv-0.7.17/src/repopage.c:209:21: style: Local variable 'try' shadows outer variable [shadowVariable] libsolv-0.7.17/src/repopage.c:113:20: note: Shadowed declaration libsolv-0.7.17/src/repopage.c:209:21: note: Shadow variable libsolv-0.7.17/src/repopage.c:345:18: style: Local variable 'hval' shadows outer variable [shadowVariable] libsolv-0.7.17/src/repopage.c:112:20: note: Shadowed declaration libsolv-0.7.17/src/repopage.c:345:18: note: Shadow variable libsolv-0.7.17/src/repo_write.c:754:2: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak] libsolv-0.7.17/src/repo_write.c:380:10: style: Local variable 'id' shadows outer variable [shadowVariable] libsolv-0.7.17/src/repo_write.c:369:6: note: Shadowed declaration libsolv-0.7.17/src/repo_write.c:380:10: note: Shadow variable libsolv-0.7.17/src/repo_write.c:393:7: style: Local variable 'id' shadows outer variable [shadowVariable] libsolv-0.7.17/src/repo_write.c:369:6: note: Shadowed declaration libsolv-0.7.17/src/repo_write.c:393:7: note: Shadow variable libsolv-0.7.17/src/repo_write.c:822:74: style: Parameter 'key' can be declared with const [constParameter] libsolv-0.7.17/src/repo_write.c:1009:53: style: Parameter 'repodataused' can be declared with const [constParameter] libsolv-0.7.17/src/selection.c:1471:13: style: Local variable 'q' shadows outer variable [shadowVariable] libsolv-0.7.17/src/selection.c:1466:9: note: Shadowed declaration libsolv-0.7.17/src/selection.c:1471:13: note: Shadow variable libsolv-0.7.17/src/selection.c:1543:13: style: Local variable 'q' shadows outer variable [shadowVariable] libsolv-0.7.17/src/selection.c:1539:9: note: Shadowed declaration libsolv-0.7.17/src/selection.c:1543:13: note: Shadow variable libsolv-0.7.17/src/selection.c:2006:12: style: Local variable 'p' shadows outer variable [shadowVariable] libsolv-0.7.17/src/selection.c:1922:6: note: Shadowed declaration libsolv-0.7.17/src/selection.c:2006:12: note: Shadow variable libsolv-0.7.17/src/selection.c:2020:12: style: Local variable 'p' shadows outer variable [shadowVariable] libsolv-0.7.17/src/selection.c:1922:6: note: Shadowed declaration libsolv-0.7.17/src/selection.c:2020:12: note: Shadow variable libsolv-0.7.17/src/selection.c:977:65: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] libsolv-0.7.17/src/selection.c:1335:17: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] libsolv-0.7.17/src/selection.c:1335:17: error: Signed integer overflow for expression '1<<31'. [integerOverflow] libsolv-0.7.17/src/selection.c:118:4: style: Variable 'p' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha1.c:113:17: style: union member 'CHAR64LONG16::c' is never used. [unusedStructMember] libsolv-0.7.17/src/sha1.c:157:7: style: Variable 'a' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha1.c:157:11: style: Variable 'b' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha1.c:157:15: style: Variable 'c' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha1.c:157:19: style: Variable 'd' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha1.c:157:23: style: Variable 'e' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha1.c:224:7: style: Variable 'i' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha2.c:438:4: style: Variable 'a' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha2.c:438:8: style: Variable 'b' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha2.c:438:12: style: Variable 'c' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha2.c:438:16: style: Variable 'd' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha2.c:438:20: style: Variable 'e' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha2.c:438:24: style: Variable 'f' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha2.c:438:28: style: Variable 'g' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha2.c:438:32: style: Variable 'h' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha2.c:438:37: style: Variable 'T1' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha2.c:551:14: style: Variable 'usedspace' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha2.c:568:12: style: Variable 'usedspace' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha2.c:735:4: style: Variable 'a' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha2.c:735:8: style: Variable 'b' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha2.c:735:12: style: Variable 'c' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha2.c:735:16: style: Variable 'd' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha2.c:735:20: style: Variable 'e' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha2.c:735:24: style: Variable 'f' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha2.c:735:28: style: Variable 'g' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha2.c:735:32: style: Variable 'h' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha2.c:735:37: style: Variable 'T1' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha2.c:846:14: style: Variable 'usedspace' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/sha2.c:863:12: style: Variable 'usedspace' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/repo_solv.c:323:22: style: Condition '(sx>>25)!=0' is always true [knownConditionTrueFalse] libsolv-0.7.17/src/repo_solv.c:319:10: note: Assuming that condition 'sx<(1<<22)' is not redundant libsolv-0.7.17/src/repo_solv.c:323:22: note: Condition '(sx>>25)!=0' is always true libsolv-0.7.17/src/repo_solv.c:131:42: style: Parameter 'map' can be declared with const [constParameter] libsolv-0.7.17/src/repo_solv.c:131:62: style: Parameter 'end' can be declared with const [constParameter] libsolv-0.7.17/src/repo_solv.c:374:59: style: Parameter 'map' can be declared with const [constParameter] libsolv-0.7.17/src/solvable.c:507:15: style: Condition 'bt1!=bt2' is always false [knownConditionTrueFalse] libsolv-0.7.17/src/solvable.c:505:7: note: Assuming condition 'bt1' is true libsolv-0.7.17/src/solvable.c:507:15: note: Condition 'bt1!=bt2' is always false libsolv-0.7.17/src/solver_util.c:57:49: style: Parameter 'm' can be declared with const [constParameter] libsolv-0.7.17/src/solverdebug.c:463:46: style:inconclusive: Function 'solver_printproblemruleinfo' argument 2 names different: declaration 'rule' definition 'probr'. [funcArgNamesDifferent] libsolv-0.7.17/src/solverdebug.h:31:58: note: Function 'solver_printproblemruleinfo' argument 2 names different: declaration 'rule' definition 'probr'. libsolv-0.7.17/src/solverdebug.c:463:46: note: Function 'solver_printproblemruleinfo' argument 2 names different: declaration 'rule' definition 'probr'. libsolv-0.7.17/src/suse.c:307:66: style: Parameter 'map' can be declared with const [constParameter] libsolv-0.7.17/src/transaction.c:583:60: style:inconclusive: Function 'transaction_classify_pkgs' argument 3 names different: declaration 'type' definition 'class'. [funcArgNamesDifferent] libsolv-0.7.17/src/transaction.h:111:72: note: Function 'transaction_classify_pkgs' argument 3 names different: declaration 'type' definition 'class'. libsolv-0.7.17/src/transaction.c:583:60: note: Function 'transaction_classify_pkgs' argument 3 names different: declaration 'type' definition 'class'. libsolv-0.7.17/src/util.c:92:24: style: Condition 'xblock' is always true [knownConditionTrueFalse] libsolv-0.7.17/src/util.c:90:31: note: Assignment 'xblock=(block+1)<<5', assigned value is greater than 31 libsolv-0.7.17/src/util.c:92:24: note: Condition 'xblock' is always true libsolv-0.7.17/src/util.c:32:3: style: Statements following return, break, continue, goto or throw will never be executed. [unreachableCode] libsolv-0.7.17/src/qsort_r.c:105:17: style:inconclusive: Function 'solv_sort' argument 1 names different: declaration 'base' definition 'a'. [funcArgNamesDifferent] libsolv-0.7.17/src/util.h:38:29: note: Function 'solv_sort' argument 1 names different: declaration 'base' definition 'a'. libsolv-0.7.17/src/qsort_r.c:105:17: note: Function 'solv_sort' argument 1 names different: declaration 'base' definition 'a'. libsolv-0.7.17/src/qsort_r.c:105:27: style:inconclusive: Function 'solv_sort' argument 2 names different: declaration 'nmemb' definition 'n'. [funcArgNamesDifferent] libsolv-0.7.17/src/util.h:38:42: note: Function 'solv_sort' argument 2 names different: declaration 'nmemb' definition 'n'. libsolv-0.7.17/src/qsort_r.c:105:27: note: Function 'solv_sort' argument 2 names different: declaration 'nmemb' definition 'n'. libsolv-0.7.17/src/qsort_r.c:105:37: style:inconclusive: Function 'solv_sort' argument 3 names different: declaration 'size' definition 'es'. [funcArgNamesDifferent] libsolv-0.7.17/src/util.h:38:56: note: Function 'solv_sort' argument 3 names different: declaration 'size' definition 'es'. libsolv-0.7.17/src/qsort_r.c:105:37: note: Function 'solv_sort' argument 3 names different: declaration 'size' definition 'es'. libsolv-0.7.17/src/qsort_r.c:105:59: style:inconclusive: Function 'solv_sort' argument 5 names different: declaration 'compard' definition 'thunk'. [funcArgNamesDifferent] libsolv-0.7.17/src/util.h:38:119: note: Function 'solv_sort' argument 5 names different: declaration 'compard' definition 'thunk'. libsolv-0.7.17/src/qsort_r.c:105:59: note: Function 'solv_sort' argument 5 names different: declaration 'compard' definition 'thunk'. libsolv-0.7.17/src/userinstalled.c:315:52: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] libsolv-0.7.17/src/userinstalled.c:348:79: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] libsolv-0.7.17/src/userinstalled.c:353:75: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] libsolv-0.7.17/src/userinstalled.c:363:79: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] libsolv-0.7.17/tools/cudftest.c:129:24: style: Variable 'ofp' is reassigned a value before the old one has been used. [redundantAssignment] libsolv-0.7.17/tools/cudftest.c:128:7: note: ofp is assigned libsolv-0.7.17/tools/cudftest.c:129:24: note: ofp is overwritten libsolv-0.7.17/tools/dumpsolv.c:458:8: style: Condition 'openrepo' is always false [knownConditionTrueFalse] libsolv-0.7.17/tools/dumpsolv.c:448:22: note: Assignment 'openrepo=0', assigned value is 0 libsolv-0.7.17/tools/dumpsolv.c:458:8: note: Condition 'openrepo' is always false libsolv-0.7.17/tools/dumpsolv.c:470:12: style: Condition 'open' is always false [knownConditionTrueFalse] libsolv-0.7.17/tools/dumpsolv.c:456:15: note: Assignment 'open=0', assigned value is 0 libsolv-0.7.17/tools/dumpsolv.c:470:12: note: Condition 'open' is always false libsolv-0.7.17/tools/testsolv.c:358:18: error:inconclusive: Using pointer to local variable 'reportsolutiondata' that is out of scope. [invalidLifetime] libsolv-0.7.17/tools/testsolv.c:239:36: note: Address of variable taken here. libsolv-0.7.17/tools/testsolv.c:234:34: note: Variable created here. libsolv-0.7.17/tools/testsolv.c:358:18: note: Using pointer to local variable 'reportsolutiondata' that is out of scope. libsolv-0.7.17/tools/testsolv.c:360:18: error:inconclusive: Using pointer to local variable 'reportsolutiondata' that is out of scope. [invalidLifetime] libsolv-0.7.17/tools/testsolv.c:239:36: note: Address of variable taken here. libsolv-0.7.17/tools/testsolv.c:234:34: note: Variable created here. libsolv-0.7.17/tools/testsolv.c:360:18: note: Using pointer to local variable 'reportsolutiondata' that is out of scope. libsolv-0.7.17/tools/testsolv.c:362:11: error:inconclusive: Using pointer to local variable 'reportsolutiondata' that is out of scope. [invalidLifetime] libsolv-0.7.17/tools/testsolv.c:239:36: note: Address of variable taken here. libsolv-0.7.17/tools/testsolv.c:234:34: note: Variable created here. libsolv-0.7.17/tools/testsolv.c:362:11: note: Using pointer to local variable 'reportsolutiondata' that is out of scope. libsolv-0.7.17/tools/testsolv.c:363:14: error:inconclusive: Using pointer to local variable 'reportsolutiondata' that is out of scope. [invalidLifetime] libsolv-0.7.17/tools/testsolv.c:239:36: note: Address of variable taken here. libsolv-0.7.17/tools/testsolv.c:234:34: note: Variable created here. libsolv-0.7.17/tools/testsolv.c:363:14: note: Using pointer to local variable 'reportsolutiondata' that is out of scope. libsolv-0.7.17/tools/testsolv.c:180:11: style: Local variable 'p' shadows outer variable [shadowVariable] libsolv-0.7.17/tools/testsolv.c:98:15: note: Shadowed declaration libsolv-0.7.17/tools/testsolv.c:180:11: note: Shadow variable libsolv-0.7.17/tools/testsolv.c:259:18: style: Local variable 'p' shadows outer variable [shadowVariable] libsolv-0.7.17/tools/testsolv.c:98:15: note: Shadowed declaration libsolv-0.7.17/tools/testsolv.c:259:18: note: Shadow variable libsolv-0.7.17/win32/getopt.c:21:2: warning:inconclusive: Found suspicious operator '&&' [constStatement] libsolv-0.7.17/src/rules.c:2385:7: style: Variable 'p' is reassigned a value before the old one has been used. [redundantAssignment] libsolv-0.7.17/src/rules.c:2333:8: note: p is assigned libsolv-0.7.17/src/rules.c:2385:7: note: p is overwritten libsolv-0.7.17/src/rules.c:2385:7: style: Variable 'p' is reassigned a value before the old one has been used. [redundantAssignment] libsolv-0.7.17/src/rules.c:2357:8: note: p is assigned libsolv-0.7.17/src/rules.c:2385:7: note: p is overwritten libsolv-0.7.17/src/rules.c:2385:7: style: Variable 'p' is reassigned a value before the old one has been used. [redundantAssignment] libsolv-0.7.17/src/rules.c:2376:8: note: p is assigned libsolv-0.7.17/src/rules.c:2385:7: note: p is overwritten libsolv-0.7.17/src/rules.c:2394:7: style: Variable 'p' is reassigned a value before the old one has been used. [redundantAssignment] libsolv-0.7.17/src/rules.c:2385:7: note: p is assigned libsolv-0.7.17/src/rules.c:2394:7: note: p is overwritten libsolv-0.7.17/src/rules.c:1901:18: style: Local variable 'ps' shadows outer variable [shadowVariable] libsolv-0.7.17/src/rules.c:1846:13: note: Shadowed declaration libsolv-0.7.17/src/rules.c:1901:18: note: Shadow variable libsolv-0.7.17/src/rules.c:1975:15: style: Local variable 's' shadows outer variable [shadowVariable] libsolv-0.7.17/src/rules.c:1938:13: note: Shadowed declaration libsolv-0.7.17/src/rules.c:1975:15: note: Shadow variable libsolv-0.7.17/src/rules.c:2004:15: style: Local variable 's' shadows outer variable [shadowVariable] libsolv-0.7.17/src/rules.c:1938:13: note: Shadowed declaration libsolv-0.7.17/src/rules.c:2004:15: note: Shadow variable libsolv-0.7.17/src/rules.c:3590:10: style: Local variable 'p' shadows outer argument [shadowArgument] libsolv-0.7.17/src/rules.c:3585:40: note: Shadowed declaration libsolv-0.7.17/src/rules.c:3590:10: note: Shadow variable libsolv-0.7.17/src/rules.c:3643:11: style: Local variable 'i' shadows outer variable [shadowVariable] libsolv-0.7.17/src/rules.c:3633:7: note: Shadowed declaration libsolv-0.7.17/src/rules.c:3643:11: note: Shadow variable libsolv-0.7.17/src/rules.c:3780:8: style: Local variable 'p2' shadows outer variable [shadowVariable] libsolv-0.7.17/src/rules.c:3736:10: note: Shadowed declaration libsolv-0.7.17/src/rules.c:3780:8: note: Shadow variable libsolv-0.7.17/src/rules.c:3787:8: style: Local variable 'p2' shadows outer variable [shadowVariable] libsolv-0.7.17/src/rules.c:3736:10: note: Shadowed declaration libsolv-0.7.17/src/rules.c:3787:8: note: Shadow variable libsolv-0.7.17/src/rules.c:1315:45: style: Parameter 's' can be declared with const [constParameter] libsolv-0.7.17/src/rules.c:2394:7: style: Variable 'p' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/rules.c:2464:7: style: Variable 'p' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/rules.c:2490:7: style: Variable 'p' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/rules.c:2874:23: style: Variable 'type' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/win32/regexec.c:415:22: style: Condition 'match_eo==-1' is always false [knownConditionTrueFalse] libsolv-0.7.17/win32/regexec.c:956:25: style: Condition 'pmatch[i].rm_so==-1' is always false [knownConditionTrueFalse] libsolv-0.7.17/win32/regexec.c:956:50: style: Condition 'pmatch[i].rm_eo==-1' is always false [knownConditionTrueFalse] libsolv-0.7.17/win32/regexec.c:966:25: style: Condition 'pmatch[i].rm_eo==-1' is always false [knownConditionTrueFalse] libsolv-0.7.17/win32/regexec.c:267:3: style: Checking if unsigned expression 'pos_add_next=mbtowc(&next_c,str_byte,MB_LEN_MAX)' is less than zero. [unsignedLessThanZero] libsolv-0.7.17/win32/regexec.c:267:3: style: Checking if unsigned expression 'pos_add_next' is less than zero. [unsignedLessThanZero] libsolv-0.7.17/win32/regexec.c:274:20: style: Checking if unsigned expression 'match_eo' is less than zero. [unsignedLessThanZero] libsolv-0.7.17/win32/regexec.c:324:7: style: Checking if unsigned expression 'pos_add_next=mbtowc(&next_c,str_byte,MB_LEN_MAX)' is less than zero. [unsignedLessThanZero] libsolv-0.7.17/win32/regexec.c:324:7: style: Checking if unsigned expression 'pos_add_next' is less than zero. [unsignedLessThanZero] libsolv-0.7.17/win32/regexec.c:457:18: style: Unsigned expression 'match_eo' can't be negative so it is unnecessary to test it. [unsignedPositive] libsolv-0.7.17/win32/regexec.c:695:3: style: Checking if unsigned expression 'pos_add_next=mbtowc(&next_c,str_byte,MB_LEN_MAX)' is less than zero. [unsignedLessThanZero] libsolv-0.7.17/win32/regexec.c:695:3: style: Checking if unsigned expression 'pos_add_next' is less than zero. [unsignedLessThanZero] libsolv-0.7.17/win32/regexec.c:804:9: style: Checking if unsigned expression 'pos_add_next=mbtowc(&next_c,str_byte,MB_LEN_MAX)' is less than zero. [unsignedLessThanZero] libsolv-0.7.17/win32/regexec.c:804:9: style: Checking if unsigned expression 'pos_add_next' is less than zero. [unsignedLessThanZero] libsolv-0.7.17/win32/regexec.c:818:5: style: Checking if unsigned expression 'pos_add_next=mbtowc(&next_c,str_byte,MB_LEN_MAX)' is less than zero. [unsignedLessThanZero] libsolv-0.7.17/win32/regexec.c:818:5: style: Checking if unsigned expression 'pos_add_next' is less than zero. [unsignedLessThanZero] libsolv-0.7.17/win32/regexec.c:884:23: style: Checking if unsigned expression 'match_eo' is less than zero. [unsignedLessThanZero] libsolv-0.7.17/win32/regexec.c:906:18: style: Unsigned expression 'match_eo' can't be negative so it is unnecessary to test it. [unsignedPositive] libsolv-0.7.17/win32/regexec.c:938:16: style: Unsigned expression 'match_eo' can't be negative so it is unnecessary to test it. [unsignedPositive] libsolv-0.7.17/win32/regexec.c:931:39: style: Parameter 'tags' can be declared with const [constParameter] libsolv-0.7.17/win32/regexec.c:99:50: style: Parameter 'tag_directions' can be declared with const [constParameter] libsolv-0.7.17/win32/regexec.c:100:19: style: Parameter 't1' can be declared with const [constParameter] libsolv-0.7.17/win32/regexec.c:100:33: style: Parameter 't2' can be declared with const [constParameter] libsolv-0.7.17/win32/regcomp.c:541:25: error: Invalid mbtowc() argument nr 3. The value is -1 but the valid values are '0:'. [invalidFunctionArg] libsolv-0.7.17/win32/regcomp.c:576:27: error: Invalid mbtowc() argument nr 3. The value is -1 but the valid values are '0:'. [invalidFunctionArg] libsolv-0.7.17/win32/regcomp.c:920:25: error: Invalid mbtowc() argument nr 3. The value is -1 but the valid values are '0:'. [invalidFunctionArg] libsolv-0.7.17/win32/regcomp.c:2517:23: style: Condition 'trans->state==NULL' is always true [knownConditionTrueFalse] libsolv-0.7.17/win32/regcomp.c:2495:26: note: Assuming that condition 'trans->state!=NULL' is not redundant libsolv-0.7.17/win32/regcomp.c:2517:23: note: Condition 'trans->state==NULL' is always true libsolv-0.7.17/win32/regcomp.c:2060:13: style: Parameter 'tags' can be declared with const [constParameter] libsolv-0.7.17/win32/regcomp.c:2472:27: style: Parameter 'offs' can be declared with const [constParameter] libsolv-0.7.17/win32/regcomp.c:1657:19: style: Variable 'minimal_tag' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/solver.c:3179:17: warning: Identical inner 'return' condition is always true. [identicalInnerCondition] libsolv-0.7.17/src/solver.c:3178:12: note: outer condition: a[0]-b[0] libsolv-0.7.17/src/solver.c:3179:17: note: identical inner condition: a[0]-b[0] libsolv-0.7.17/src/solver.c:983:7: style: Condition 'record_proof' is always true [knownConditionTrueFalse] libsolv-0.7.17/src/solver.c:967:22: note: Assignment 'record_proof=1', assigned value is 1 libsolv-0.7.17/src/solver.c:983:7: note: Condition 'record_proof' is always true libsolv-0.7.17/src/solver.c:3838:10: style: Variable 'p' is reassigned a value before the old one has been used. [redundantAssignment] libsolv-0.7.17/src/solver.c:3829:8: note: p is assigned libsolv-0.7.17/src/solver.c:3838:10: note: p is overwritten libsolv-0.7.17/src/solver.c:4684:3: style: Variable 'p' is reassigned a value before the old one has been used. [redundantAssignment] libsolv-0.7.17/src/solver.c:4680:3: note: p is assigned libsolv-0.7.17/src/solver.c:4684:3: note: p is overwritten libsolv-0.7.17/src/solver.c:1856:10: style: Local variable 'p' shadows outer variable [shadowVariable] libsolv-0.7.17/src/solver.c:1849:6: note: Shadowed declaration libsolv-0.7.17/src/solver.c:1856:10: note: Shadow variable libsolv-0.7.17/src/solver.c:2017:10: style: Local variable 'installed' shadows outer variable [shadowVariable] libsolv-0.7.17/src/solver.c:1914:9: note: Shadowed declaration libsolv-0.7.17/src/solver.c:2017:10: note: Shadow variable libsolv-0.7.17/src/solver.c:2228:23: style: Local variable 'p' shadows outer variable [shadowVariable] libsolv-0.7.17/src/solver.c:2213:6: note: Shadowed declaration libsolv-0.7.17/src/solver.c:2228:23: note: Shadow variable libsolv-0.7.17/src/solver.c:4664:7: style: Variable 'p' is assigned a value that is never used. [unreadVariable] libsolv-0.7.17/src/solver.c:4684:3: style: Variable 'p' is assigned a value that is never used. [unreadVariable] DONE