2022-06-23 06:44 ftp://ftp.de.debian.org/debian/pool/main/libp/libpwizlite/libpwizlite_3.0.4.orig.tar.gz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j1 platform: Linux-4.19.0-18-amd64-x86_64-with-debian-10.12 python: 3.7.3 client-version: 1.3.24 compiler: g++ (Debian 8.3.0-6) 8.3.0 cppcheck: head 2.8 head-info: f1212e6 (2022-06-22 21:22:04 +0200) count: 391 349 elapsed-time: 327.9 56.0 head-timing-info: Tokenizer::simplifyTokens1: 325.134s (avg. 8.7874s - 37 result(s)) Tokenizer::simplifyTokens1::ValueFlow: 308.835s (avg. 8.82385s - 35 result(s)) Tokenizer::tokenize::setVarId (2): 6.143s (avg. 0.175514s - 35 result(s)) Tokenizer::tokenize::setVarId: 6.11239s (avg. 0.17464s - 35 result(s)) Tokenizer::simplifyTokens1::createSymbolDatabase: 1.17967s (avg. 0.0337049s - 35 result(s)) Overall time: 650.418s old-timing-info: Tokenizer::simplifyTokens1: 53.393s (avg. 1.44305s - 37 result(s)) Tokenizer::simplifyTokens1::ValueFlow: 40.6454s (avg. 1.1613s - 35 result(s)) Tokenizer::tokenize::setVarId: 4.3892s (avg. 0.125406s - 35 result(s)) Tokenizer::tokenize::setVarId (2): 4.37856s (avg. 0.125102s - 35 result(s)) Tokenizer::simplifyTokens1::createSymbolDatabase: 1.17189s (avg. 0.0334824s - 35 result(s)) Overall time: 106.953s head results: libpwizlite-3.0.4/src/pwiz/data/common/cv.hpp:15668:5: warning: Member variable 'CVTermInfo::isObsolete' is not initialized in the constructor. [uninitMemberVar] libpwizlite-3.0.4/src/pwiz/data/common/diff_std.hpp:344:10: style:inconclusive: Technically the member function 'pwiz::data::diff_impl::HasID::operator()' can be const. [functionConst] libpwizlite-3.0.4/src/pwiz/data/common/ParamTypes.cpp:251:10: style:inconclusive: Technically the member function 'pwiz::data::::HasName::operator()' can be const. [functionConst] libpwizlite-3.0.4/src/pwiz/data/common/ParamTypes.hpp:104:5: style: Struct 'CVParam' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/common/ParamTypes.hpp:153:5: style: Struct 'CVParamIs' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/common/ParamTypes.hpp:166:5: style: Struct 'CVParamIsChildOf' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/common/ParamTypes.hpp:199:5: style: Struct 'UserParam' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/common/ParamTypes.hpp:354:5: style: Struct 'ParamGroup' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/common/diff_std.hpp:43:5: style: Struct 'BaseDiffConfig' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/common/diff_std.hpp:343:5: style: Struct 'HasID' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/common/ParamTypes.cpp:250:5: style: Struct 'HasName' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/common/diff_std.hpp:144:5: style: Struct 'Diff < ParamContainer , BaseDiffConfig , ParamContainer >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/common/ParamTypes.cpp:214:24: style: Local variable 'cvParam' shadows outer function [shadowFunction] libpwizlite-3.0.4/src/pwiz/data/common/ParamTypes.hpp:259:13: note: Shadowed declaration libpwizlite-3.0.4/src/pwiz/data/common/ParamTypes.cpp:214:24: note: Shadow variable libpwizlite-3.0.4/src/pwiz/data/common/ParamTypes.hpp:86:37: performance: Function parameter '_value' should be passed by const reference. [passedByValue] libpwizlite-3.0.4/src/pwiz/data/common/cv.cpp:25058:10: style:inconclusive: Technically the member function 'pwiz::cv::::StringEquals::operator()' can be const. [functionConst] libpwizlite-3.0.4/src/pwiz/data/common/cv.cpp:24975:5: style: Class 'CVTermData' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/common/cv.cpp:25060:5: style: Struct 'StringEquals' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/common/diff_std.hpp:144:5: style: Struct 'Diff' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/BinaryDataEncoder.cpp:87:11: style:inconclusive: Technically the member function 'DoubleToFloat < double , float >::operator()' can be const. [functionConst] libpwizlite-3.0.4/src/pwiz/data/msdata/BinaryDataEncoder.cpp:87:11: style:inconclusive: Technically the member function 'DoubleToFloat < std :: int64_t , std :: int32_t >::operator()' can be const. [functionConst] libpwizlite-3.0.4/src/pwiz/data/msdata/BinaryDataEncoder.hpp:81:5: style: Class 'BinaryDataEncoder' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/BinaryDataEncoder.cpp:58:5: style: Class 'Impl' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/BinaryDataEncoder.cpp:510:58: style: C-style pointer casting [cstyleCast] libpwizlite-3.0.4/src/pwiz/data/msdata/BinaryDataEncoder.cpp:521:55: style: C-style pointer casting [cstyleCast] libpwizlite-3.0.4/src/pwiz/data/msdata/BinaryDataEncoder.cpp:532:56: style: C-style pointer casting [cstyleCast] libpwizlite-3.0.4/src/pwiz/data/msdata/BinaryDataEncoder.cpp:107:16: style: C-style pointer casting [cstyleCast] libpwizlite-3.0.4/src/pwiz/data/msdata/BinaryDataEncoder.cpp:290:50: portability: Casting from const double * to const unsigned long long * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/BinaryDataEncoder.cpp:463:70: style:inconclusive: Function 'decode' argument 2 names different: declaration 'len' definition 'length'. [funcArgNamesDifferent] libpwizlite-3.0.4/src/pwiz/data/msdata/BinaryDataEncoder.cpp:65:49: note: Function 'decode' argument 2 names different: declaration 'len' definition 'length'. libpwizlite-3.0.4/src/pwiz/data/msdata/BinaryDataEncoder.cpp:463:70: note: Function 'decode' argument 2 names different: declaration 'len' definition 'length'. libpwizlite-3.0.4/src/pwiz/data/msdata/BinaryDataEncoder.cpp:578:70: style:inconclusive: Function 'decode' argument 2 names different: declaration 'len' definition 'length'. [funcArgNamesDifferent] libpwizlite-3.0.4/src/pwiz/data/msdata/BinaryDataEncoder.cpp:66:49: note: Function 'decode' argument 2 names different: declaration 'len' definition 'length'. libpwizlite-3.0.4/src/pwiz/data/msdata/BinaryDataEncoder.cpp:578:70: note: Function 'decode' argument 2 names different: declaration 'len' definition 'length'. libpwizlite-3.0.4/src/pwiz/data/msdata/BinaryDataEncoder.cpp:762:42: style: Variable 'usedConfig' is assigned a value that is never used. [unreadVariable] libpwizlite-3.0.4/src/pwiz/data/msdata/ChromatogramListBase.hpp:47:17: performance:inconclusive: Technically the member function 'pwiz::msdata::ChromatogramListBase::polarityStringForFilter' can be static (but you may consider moving to unnamed namespace). [functionStatic] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:65:5: style: Struct 'SourceFile' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:109:5: style: Struct 'Sample' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:187:5: style: Struct 'Software' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:217:5: style: Struct 'ScanSettings' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:243:5: style: Struct 'InstrumentConfiguration' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:281:5: style: Struct 'DataProcessing' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/Index_mzML.hpp:42:5: style: Class 'index_error' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/ChromatogramListBase.hpp:42:59: style: The function 'dataProcessingPtr' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:818:59: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/ChromatogramListBase.hpp:42:59: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:756:20: style: The function 'size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:691:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:756:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:757:18: style: The function 'empty' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:694:18: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:757:18: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:758:37: style: The function 'spectrumIdentity' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:697:37: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:758:37: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:759:25: style: The function 'spectrum' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:714:25: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:759:25: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:760:59: style: The function 'dataProcessingPtr' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:729:59: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:760:59: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:836:20: style: The function 'size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:794:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:836:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:838:41: style: The function 'chromatogramIdentity' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:800:41: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:838:41: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:839:29: style: The function 'chromatogram' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:808:29: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:839:29: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:840:59: style: The function 'dataProcessingPtr' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:818:59: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:840:59: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/ChromatogramList_mzML.cpp:53:20: style: The function 'size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:794:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/ChromatogramList_mzML.cpp:53:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/ChromatogramList_mzML.cpp:54:41: style: The function 'chromatogramIdentity' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:800:41: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/ChromatogramList_mzML.cpp:54:41: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/ChromatogramList_mzML.cpp:55:20: style: The function 'find' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:803:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/ChromatogramList_mzML.cpp:55:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/ChromatogramList_mzML.cpp:56:29: style: The function 'chromatogram' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:808:29: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/ChromatogramList_mzML.cpp:56:29: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:65:34: performance: Function parameter '_id' should be passed by const reference. [passedByValue] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:66:34: performance: Function parameter '_name' should be passed by const reference. [passedByValue] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:67:34: performance: Function parameter '_location' should be passed by const reference. [passedByValue] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:109:30: performance: Function parameter '_id' should be passed by const reference. [passedByValue] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:110:30: performance: Function parameter '_name' should be passed by const reference. [passedByValue] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:151:5: style: Class 'ReaderFail' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzXML.hpp:51:9: style: Struct 'index_not_found' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_mzML.hpp:57:5: style: Class 'Serializer_mzML' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_mzXML.hpp:57:5: style: Class 'Serializer_mzXML' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MSn.hpp:42:5: style: Class 'Serializer_MSn' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_mz5.hpp:48:5: style: Class 'Serializer_mz5' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_mz5.hpp:54:5: style: Class 'Serializer_mz5' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:181:22: style: The function 'identify' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:111:25: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:181:22: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:196:18: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:115:18: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:196:18: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:210:18: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:122:18: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:210:18: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:223:18: style: The function 'readIds' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:128:18: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:223:18: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:260:22: style: The function 'getType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:134:22: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:260:22: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:261:18: style: The function 'getCvType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:137:18: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:261:18: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:271:38: style: The function 'getFileExtensions' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:141:38: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:271:38: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:39:25: style: The function 'identify' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:111:25: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:39:25: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:40:18: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:115:18: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:40:18: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:41:18: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:122:18: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:41:18: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:42:25: style: The function 'getType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:134:22: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:42:25: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:43:18: style: The function 'getCvType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:137:18: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:43:18: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:44:38: style: The function 'getFileExtensions' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:141:38: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:44:38: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:55:25: style: The function 'identify' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:111:25: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:55:25: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:56:18: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:115:18: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:56:18: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:57:18: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:122:18: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:57:18: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:58:25: style: The function 'getType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:134:22: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:58:25: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:59:18: style: The function 'getCvType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:137:18: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:59:18: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:60:38: style: The function 'getFileExtensions' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:141:38: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:60:38: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:67:25: style: The function 'identify' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:111:25: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:67:25: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:68:18: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:115:18: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:68:18: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:69:18: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:122:18: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:69:18: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:70:25: style: The function 'getType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:134:22: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:70:25: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:71:18: style: The function 'getCvType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:137:18: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:71:18: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:72:38: style: The function 'getFileExtensions' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:141:38: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:72:38: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:79:25: style: The function 'identify' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:111:25: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:79:25: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:80:18: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:115:18: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:80:18: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:81:18: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:122:18: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:81:18: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:88:25: style: The function 'getType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:134:22: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:88:25: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:89:18: style: The function 'getCvType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:137:18: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:89:18: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:90:38: style: The function 'getFileExtensions' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:141:38: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:90:38: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:98:25: style: The function 'identify' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:79:25: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:98:25: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:99:25: style: The function 'getType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:134:22: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:99:25: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:100:18: style: The function 'getCvType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:137:18: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:100:18: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:101:38: style: The function 'getFileExtensions' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:141:38: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:101:38: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:108:25: style: The function 'identify' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:111:25: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:108:25: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:109:18: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:115:18: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:109:18: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:110:18: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:122:18: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:110:18: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:111:25: style: The function 'getType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:134:22: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:111:25: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:112:18: style: The function 'getCvType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:137:18: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:112:18: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:113:38: style: The function 'getFileExtensions' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:141:38: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:113:38: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:120:25: style: The function 'identify' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:111:25: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:120:25: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:121:18: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:115:18: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:121:18: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:122:18: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:122:18: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:122:18: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:123:25: style: The function 'getType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:134:22: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:123:25: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:124:18: style: The function 'getCvType' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:137:18: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:124:18: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:125:38: style: The function 'getFileExtensions' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:141:38: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:125:38: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumListBase.hpp:47:59: style: The function 'dataProcessingPtr' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:729:59: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumListBase.hpp:47:59: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumListBase.hpp:53:18: style: The function 'warn_once' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:732:18: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumListBase.hpp:53:18: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.cpp:214:43: style:inconclusive: Function 'read' argument 4 names different: declaration 'runIndex' definition 'runsIndex'. [funcArgNamesDifferent] libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.hpp:56:97: note: Function 'read' argument 4 names different: declaration 'runIndex' definition 'runsIndex'. libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.cpp:214:43: note: Function 'read' argument 4 names different: declaration 'runIndex' definition 'runsIndex'. libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.cpp:145:37: style: Local variable 'config' shadows outer argument [shadowArgument] libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.cpp:132:52: note: Shadowed declaration libpwizlite-3.0.4/src/pwiz/data/msdata/DefaultReaderList.cpp:145:37: note: Shadow variable libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1734:5: warning: Member variable 'HandlerBinaryDataArray::binaryDataArray' is not initialized in the constructor. [uninitMemberVar] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1734:5: warning: Member variable 'HandlerBinaryDataArray::integerDataArray' is not initialized in the constructor. [uninitMemberVar] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1727:20: warning: The struct 'HandlerBinaryDataArray' defines member variable with name 'paramContainer' also defined in its parent struct 'HandlerParamContainer'. [duplInheritedMember] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:255:21: note: Parent variable 'HandlerParamContainer::paramContainer' libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1727:20: note: Derived variable 'HandlerBinaryDataArray::paramContainer' libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:77:5: style: Struct 'HandlerCV' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:128:5: style: Struct 'HandlerUserParam' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:187:5: style: Struct 'HandlerCVParam' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:257:5: style: Struct 'HandlerParamContainer' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:304:5: style: Struct 'HandlerNamedParamContainer' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:339:5: style: Struct 'HandlerParamGroup' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:418:5: style: Struct 'HandlerSourceFile' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:493:5: style: Struct 'HandlerFileDescription' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:570:5: style: Struct 'HandlerSample' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:633:5: style: Struct 'HandlerComponent' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:690:5: style: Struct 'HandlerComponentList' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:757:5: style: Struct 'HandlerSoftware' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:827:5: style: Struct 'HandlerInstrumentConfiguration' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:897:5: style: Struct 'HandlerProcessingMethod' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:960:5: style: Struct 'HandlerDataProcessing' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1072:5: style: Struct 'HandlerScanSettings' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1248:5: style: Struct 'HandlerPrecursor' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1349:5: style: Struct 'HandlerProduct' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1459:5: style: Struct 'HandlerScan' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1574:5: style: Struct 'HandlerScanList' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1734:5: style: Struct 'HandlerBinaryDataArray' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:2115:5: style: Struct 'HandlerSpectrum' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:2300:5: style: Struct 'HandlerChromatogram' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:2431:5: style: Struct 'HandlerSpectrumListSimple' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:2532:5: style: Struct 'HandlerChromatogramListSimple' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:2631:5: style: Struct 'HandlerRun' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:2781:5: style: Struct 'HandlerMSData' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:308:20: style: The function 'startElement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:261:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:308:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:343:20: style: The function 'startElement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:261:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:343:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:422:20: style: The function 'startElement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:261:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:422:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:574:20: style: The function 'startElement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:261:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:574:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:637:20: style: The function 'startElement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:261:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:637:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:759:20: style: The function 'startElement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:261:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:759:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:831:20: style: The function 'startElement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:261:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:831:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:901:20: style: The function 'startElement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:261:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:901:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:964:20: style: The function 'startElement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:261:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:964:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1077:20: style: The function 'startElement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:261:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1077:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1256:20: style: The function 'startElement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:261:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1256:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1463:20: style: The function 'startElement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:261:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1463:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1578:20: style: The function 'startElement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:261:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1578:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1747:20: style: The function 'startElement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:261:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1747:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:2129:20: style: The function 'startElement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:261:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:2129:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:2306:20: style: The function 'startElement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:261:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:2306:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:2436:20: style: The function 'startElement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:261:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:2436:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:2537:20: style: The function 'startElement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:261:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:2537:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:2635:20: style: The function 'startElement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:261:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:2635:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:166:70: style:inconclusive: Function 'write' argument 2 names different: declaration 'cv' definition 'cvParam'. [funcArgNamesDifferent] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.hpp:73:70: note: Function 'write' argument 2 names different: declaration 'cv' definition 'cvParam'. libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:166:70: note: Function 'write' argument 2 names different: declaration 'cv' definition 'cvParam'. libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:555:69: style:inconclusive: Function 'write' argument 2 names different: declaration 'sf' definition 'sample'. [funcArgNamesDifferent] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.hpp:97:69: note: Function 'write' argument 2 names different: declaration 'sf' definition 'sample'. libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:555:69: note: Function 'write' argument 2 names different: declaration 'sf' definition 'sample'. libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1391:73: style:inconclusive: Function 'write' argument 2 names different: declaration 'selectionWindow' definition 'scanWindow'. [funcArgNamesDifferent] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.hpp:153:73: note: Function 'write' argument 2 names different: declaration 'selectionWindow' definition 'scanWindow'. libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1391:73: note: Function 'write' argument 2 names different: declaration 'selectionWindow' definition 'scanWindow'. libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1053:31: style: Local variable 'attributes' shadows outer variable [shadowVariable] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1035:27: note: Shadowed declaration libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1053:31: note: Shadow variable libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1799:44: style: Local variable 'binaryDataArray' shadows outer variable [shadowVariable] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1731:22: note: Shadowed declaration libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1799:44: note: Shadow variable libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1824:45: style: Local variable 'binaryDataArray' shadows outer variable [shadowVariable] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1731:22: note: Shadowed declaration libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1824:45: note: Shadow variable libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1937:35: style: Local variable 'config' shadows outer variable [shadowVariable] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1726:31: note: Shadowed declaration libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1937:35: note: Shadow variable libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:2064:31: style: Local variable 'attributes' shadows outer variable [shadowVariable] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:2045:27: note: Shadowed declaration libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:2064:31: note: Shadow variable libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:2077:31: style: Local variable 'attributes' shadows outer variable [shadowVariable] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:2045:27: note: Shadowed declaration libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:2077:31: note: Shadow variable libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:2809:22: performance: Inefficient usage of string::find() in condition; string::starts_with() could be faster. [stlIfStrFind] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1790:33: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1815:33: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] libpwizlite-3.0.4/src/pwiz/data/msdata/Index_mzML.cpp:108:5: warning: Member variable 'HandlerOffset::legacyIdRefToNativeId' is not initialized in the constructor. [uninitMemberVar] libpwizlite-3.0.4/src/pwiz/data/msdata/Index_mzML.cpp:179:5: warning: Member variable 'HandlerIndexList::inSpectrumIndex_' is not initialized in the constructor. [uninitMemberVar] libpwizlite-3.0.4/src/pwiz/data/msdata/Index_mzML.cpp:74:5: style: Class 'HandlerIndexListOffset' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/LegacyAdapter.cpp:55:12: performance:inconclusive: Technically the member function 'pwiz::msdata::Impl::get' can be static (but you may consider moving to unnamed namespace). [functionStatic] libpwizlite-3.0.4/src/pwiz/data/msdata/LegacyAdapter.cpp:94:40: note: Technically the member function 'pwiz::msdata::Impl::get' can be static (but you may consider moving to unnamed namespace). libpwizlite-3.0.4/src/pwiz/data/msdata/LegacyAdapter.cpp:55:12: note: Technically the member function 'pwiz::msdata::Impl::get' can be static (but you may consider moving to unnamed namespace). libpwizlite-3.0.4/src/pwiz/data/msdata/LegacyAdapter.cpp:143:13: style: Local variable 'model' shadows outer function [shadowFunction] libpwizlite-3.0.4/src/pwiz/data/msdata/LegacyAdapter.hpp:69:17: note: Shadowed declaration libpwizlite-3.0.4/src/pwiz/data/msdata/LegacyAdapter.cpp:143:13: note: Shadow variable libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.cpp:1345:10: style:inconclusive: Technically the member function 'HasID < DataProcessing >::operator()' can be const. [functionConst] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.cpp:1343:5: style: Struct 'HasID < DataProcessing >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.cpp:1179:17: style: Condition '!accepted' is always true [knownConditionTrueFalse] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.cpp:1177:17: note: Assuming that condition 'accepted' is not redundant libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.cpp:1179:17: note: Condition '!accepted' is always true libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.cpp:598:12: style: The scope of the variable 'indexEquals' can be reduced. [variableScope] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.cpp:1112:21: style: Unsigned expression 'result' can't be negative so it is unnecessary to test it. [unsignedPositive] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.cpp:736:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] libpwizlite-3.0.4/src/pwiz/data/msdata/MSDataFile.hpp:44:5: style: Struct 'MSDataFile' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/TextWriter.hpp:48:5: style: Class 'TextWriter' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:572:13: style: Expression 'log(1 + x)' can be replaced by 'log1p(x)' to avoid loss of precision. [unpreciseMathCall] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:599:13: style: Expression 'log(1 + x)' can be replaced by 'log1p(x)' to avoid loss of precision. [unpreciseMathCall] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:623:24: style: Expression 'exp(x) - 1' can be replaced by 'expm1(x)' to avoid loss of precision. [unpreciseMathCall] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:60:25: portability:inconclusive: Casting from double * to unsigned char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:73:25: portability:inconclusive: Casting from double * to unsigned char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:153:9: style: The scope of the variable 'mask' can be reduced. [variableScope] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:153:15: style: The scope of the variable 'm' can be reduced. [variableScope] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:244:12: style: The scope of the variable 'extrapol' can be reduced. [variableScope] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:245:12: style: The scope of the variable 'diff' can be reduced. [variableScope] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:268:15: style: The scope of the variable 'extrapol' can be reduced. [variableScope] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:269:9: style: The scope of the variable 'diff' can be reduced. [variableScope] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:340:18: style: The scope of the variable 'init' can be reduced. [variableScope] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:446:19: style: The scope of the variable 'count' can be reduced. [variableScope] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:496:12: style: The scope of the variable 'i' can be reduced. [variableScope] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:568:12: style: The scope of the variable 'x' can be reduced. [variableScope] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:592:20: style: The scope of the variable 'x' can be reduced. [variableScope] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:614:20: style: The scope of the variable 'x' can be reduced. [variableScope] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:102:22: portability: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:173:22: portability: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:117:22: warning: Either the condition 'init==mask' is redundant or there is signed integer overflow for expression 'mask>>(4*i)'. [integerOverflowCond] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:96:16: note: Assignment 'mask=0xf0000000', assigned value is -268435456 libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:114:21: note: Assuming that condition 'init==mask' is not redundant libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:114:21: note: Assuming that condition 'init==mask' is not redundant libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:117:22: note: Integer overflow libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:520:27: error: Uninitialized variable: ri [uninitvar] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:521:27: error: Uninitialized variable: di [uninitvar] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:522:29: error: Uninitialized variable: half [uninitvar] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:524:30: error: Uninitialized variable: count [uninitvar] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.cpp:70:5: performance: Variable 'isolationMzAndMobilityFilter' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.cpp:255:73: style:inconclusive: Function 'identifyAsReader' argument 1 names different: declaration 'filename' definition 'filepath'. [funcArgNamesDifferent] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.hpp:187:59: note: Function 'identifyAsReader' argument 1 names different: declaration 'filename' definition 'filepath'. libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.cpp:255:73: note: Function 'identifyAsReader' argument 1 names different: declaration 'filename' definition 'filepath'. libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.cpp:266:20: style: Local variable 'result' shadows outer variable [shadowVariable] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.cpp:263:21: note: Shadowed declaration libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.cpp:266:20: note: Shadow variable libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.cpp:178:16: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.cpp:189:16: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.cpp:275:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] libpwizlite-3.0.4/src/pwiz/data/msdata/Reader.cpp:263:21: style: Unused variable: result [unusedVariable] libpwizlite-3.0.4/src/pwiz/data/msdata/References.cpp:41:10: style:inconclusive: Technically the member function 'pwiz::msdata::References::HasID::operator()' can be const. [functionConst] libpwizlite-3.0.4/src/pwiz/data/msdata/References.cpp:39:5: style: Struct 'HasID' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/References.cpp:138:44: style:inconclusive: Function 'resolve' argument 1 names different: declaration 'dataProcesssing' definition 'dataProcessing'. [funcArgNamesDifferent] libpwizlite-3.0.4/src/pwiz/data/msdata/References.hpp:45:44: note: Function 'resolve' argument 1 names different: declaration 'dataProcesssing' definition 'dataProcessing'. libpwizlite-3.0.4/src/pwiz/data/msdata/References.cpp:138:44: note: Function 'resolve' argument 1 names different: declaration 'dataProcesssing' definition 'dataProcessing'. libpwizlite-3.0.4/src/pwiz/data/msdata/References.cpp:144:42: style:inconclusive: Function 'resolve' argument 1 names different: declaration 'dataProcesssing' definition 'scanSettings'. [funcArgNamesDifferent] libpwizlite-3.0.4/src/pwiz/data/msdata/References.hpp:46:42: note: Function 'resolve' argument 1 names different: declaration 'dataProcesssing' definition 'scanSettings'. libpwizlite-3.0.4/src/pwiz/data/msdata/References.cpp:144:42: note: Function 'resolve' argument 1 names different: declaration 'dataProcesssing' definition 'scanSettings'. libpwizlite-3.0.4/src/pwiz/data/msdata/References.cpp:177:38: style:inconclusive: Function 'resolve' argument 1 names different: declaration 'List' definition 'scanList'. [funcArgNamesDifferent] libpwizlite-3.0.4/src/pwiz/data/msdata/References.hpp:50:38: note: Function 'resolve' argument 1 names different: declaration 'List' definition 'scanList'. libpwizlite-3.0.4/src/pwiz/data/msdata/References.cpp:177:38: note: Function 'resolve' argument 1 names different: declaration 'List' definition 'scanList'. libpwizlite-3.0.4/src/pwiz/data/msdata/References.cpp:65:73: style: Local variable 'it' shadows outer variable [shadowVariable] libpwizlite-3.0.4/src/pwiz/data/msdata/References.cpp:55:64: note: Shadowed declaration libpwizlite-3.0.4/src/pwiz/data/msdata/References.cpp:65:73: note: Shadow variable libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MGF.cpp:52:10: performance:inconclusive: Technically the member function 'pwiz::msdata::Impl::read' can be static (but you may consider moving to unnamed namespace). [functionStatic] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MGF.cpp:170:28: note: Technically the member function 'pwiz::msdata::Impl::read' can be static (but you may consider moving to unnamed namespace). libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MGF.cpp:52:10: note: Technically the member function 'pwiz::msdata::Impl::read' can be static (but you may consider moving to unnamed namespace). libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MGF.cpp:101:24: style: Local variable 'scan' shadows outer variable [shadowVariable] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MGF.cpp:84:15: note: Shadowed declaration libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MGF.cpp:101:24: note: Shadow variable libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MGF.cpp:78:19: style: Variable 'sl' can be declared as reference to const [constVariable] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumInfo.hpp:71:5: style: Struct 'SpectrumInfo' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MSn.cpp:57:9: style: Class 'Impl' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MSn.cpp:260:24: style: C-style pointer casting [cstyleCast] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MSn.cpp:261:50: style: C-style pointer casting [cstyleCast] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MSn.cpp:266:24: style: C-style pointer casting [cstyleCast] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MSn.cpp:267:50: style: C-style pointer casting [cstyleCast] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MSn.cpp:313:22: portability:inconclusive: Casting from double * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MSn.cpp:318:22: portability:inconclusive: Casting from double * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MSn.cpp:327:18: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MSn.cpp:332:22: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MSn.cpp:335:22: portability:inconclusive: Casting from double * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MSn.cpp:340:22: portability:inconclusive: Casting from double * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MSn.cpp:342:22: portability:inconclusive: Casting from double * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MSn.cpp:345:22: portability:inconclusive: Casting from double * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MSn.cpp:349:22: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MSn.cpp:386:22: portability:inconclusive: Casting from double * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MSn.cpp:394:22: portability:inconclusive: Casting from double * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MSn.cpp:395:22: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MSn.cpp:396:22: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MSn.cpp:413:26: portability:inconclusive: Casting from double * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MSn.cpp:416:26: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MSn.cpp:446:19: style: Variable 'sl' can be declared as reference to const [constVariable] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_mzML.cpp:49:5: style: Class 'Impl' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_mzXML.cpp:1294:5: warning: Member variable 'Handler_mzXML::hasCentroidDataProcessing' is not initialized in the constructor. [uninitMemberVar] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_mzXML.cpp:52:5: style: Class 'Impl' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_mzXML.cpp:1159:26: style: Local variable 'name' shadows outer argument [shadowArgument] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_mzXML.cpp:1103:47: note: Shadowed declaration libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_mzXML.cpp:1159:26: note: Shadow variable libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_mzXML.cpp:1262:26: style: Local variable 'name' shadows outer argument [shadowArgument] libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_mzXML.cpp:1232:47: note: Shadowed declaration libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_mzXML.cpp:1262:26: note: Shadow variable libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumInfo.cpp:35:29: warning: Member variable 'SpectrumInfo::dataSize' is not initialized in the constructor. [uninitMemberVar] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_BTDX.cpp:106:5: warning: Member variable 'HandlerPeaks::basePeakMz_' is not initialized in the constructor. [uninitMemberVar] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_BTDX.cpp:331:5: style: Class 'HandlerIndexCreator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_BTDX.cpp:52:20: style: The function 'size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:691:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_BTDX.cpp:52:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_BTDX.cpp:53:37: style: The function 'spectrumIdentity' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:697:37: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_BTDX.cpp:53:37: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_BTDX.cpp:56:25: style: The function 'spectrum' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:714:25: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_BTDX.cpp:56:25: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MGF.cpp:391:13: style: Assignment of function parameter has no effect outside the function. [uselessAssignmentArg] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MGF.cpp:53:12: style: The function 'size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:691:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MGF.cpp:53:12: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MGF.cpp:55:29: style: The function 'spectrumIdentity' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:697:37: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MGF.cpp:55:29: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MGF.cpp:92:17: style: The function 'spectrum' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:714:25: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MGF.cpp:92:17: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MSn.cpp:84:10: style:inconclusive: Technically the member function 'pwiz::msdata::::MSnScanInfo::readSpectrumHeader' can be const. [functionConst] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MSn.cpp:454:10: performance:inconclusive: Technically the member function 'pwiz::msdata::::SpectrumList_MSnImpl::calculateMassOverCharge' can be static (but you may consider moving to unnamed namespace). [functionStatic] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MSn.cpp:137:10: style: The function 'size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:691:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MSn.cpp:137:10: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MSn.cpp:139:27: style: The function 'spectrumIdentity' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:697:37: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MSn.cpp:139:27: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MSn.cpp:168:15: style: The function 'spectrum' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:714:25: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MSn.cpp:168:15: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MSn.cpp:562:32: style: C-style pointer casting [cstyleCast] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MSn.cpp:574:28: style: C-style pointer casting [cstyleCast] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MSn.cpp:88:20: portability:inconclusive: Casting from double * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MSn.cpp:89:20: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MSn.cpp:93:24: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MSn.cpp:94:24: portability:inconclusive: Casting from double * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MSn.cpp:95:24: portability:inconclusive: Casting from double * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MSn.cpp:96:24: portability:inconclusive: Casting from double * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MSn.cpp:97:24: portability:inconclusive: Casting from double * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MSn.cpp:98:24: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MSn.cpp:500:25: portability:inconclusive: Casting from double * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MSn.cpp:520:27: portability:inconclusive: Casting from double * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MSn.cpp:521:27: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MSn.cpp:522:27: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MSn.cpp:602:21: portability:inconclusive: Casting from double * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_MSn.cpp:603:21: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzML.cpp:74:24: warning: Member variable 'SpectrumList_mzMLImpl::indexed_' is not initialized in the constructor. [uninitMemberVar] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzML.cpp:54:20: style: The function 'size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:691:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzML.cpp:54:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzML.cpp:55:37: style: The function 'spectrumIdentity' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:697:37: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzML.cpp:55:37: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzML.cpp:56:20: style: The function 'find' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:700:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzML.cpp:56:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzML.cpp:57:23: style: The function 'findSpotID' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:709:23: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzML.cpp:57:23: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzML.cpp:58:25: style: The function 'spectrum' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:714:25: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzML.cpp:58:25: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzML.cpp:59:25: style: The function 'spectrum' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:725:25: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzML.cpp:59:25: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzML.cpp:60:25: style: The function 'spectrum' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:719:25: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzML.cpp:60:25: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzXML.cpp:119:5: warning: Member variable 'HandlerPrecursor::scan' is not initialized in the constructor. [uninitMemberVar] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzXML.cpp:693:5: style: Class 'HandlerIndexOffset' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzXML.cpp:726:5: style: Struct 'HandlerOffset' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzXML.cpp:51:20: style: The function 'size' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:691:20: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzXML.cpp:51:20: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzXML.cpp:52:37: style: The function 'spectrumIdentity' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:697:37: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzXML.cpp:52:37: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzXML.cpp:54:25: style: The function 'spectrum' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:725:25: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzXML.cpp:54:25: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzXML.cpp:55:25: style: The function 'spectrum' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:714:25: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzXML.cpp:55:25: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzXML.cpp:56:25: style: The function 'spectrum' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:719:25: note: Virtual function in base class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzXML.cpp:56:25: note: Function in derived class libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumList_mzXML.cpp:84:7: style: Exception should be caught by reference. [catchExceptionByValue] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumWorkerThreads.cpp:189:23: style: The scope of the variable 'tasks' can be reduced. [variableScope] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumWorkerThreads.cpp:190:20: style: The scope of the variable 'taskQueue' can be reduced. [variableScope] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumWorkerThreads.cpp:191:27: style: The scope of the variable 'taskMRU' can be reduced. [variableScope] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumWorkerThreads.cpp:123:19: style: Local variable 'task' shadows outer variable [shadowVariable] libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumWorkerThreads.cpp:116:15: note: Shadowed declaration libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumWorkerThreads.cpp:123:19: note: Shadow variable libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumWorkerThreads.cpp:116:15: style: Variable 'task' can be declared as reference to const [constVariable] libpwizlite-3.0.4/src/pwiz/utility/minimxml/SAXParser.hpp:472:13: warning: Member variable 'attribute::name' is not initialized in the constructor. [uninitMemberVar] libpwizlite-3.0.4/src/pwiz/utility/minimxml/SAXParser.hpp:472:13: warning: Member variable 'attribute::value' is not initialized in the constructor. [uninitMemberVar] libpwizlite-3.0.4/src/pwiz/utility/minimxml/SAXParser.hpp:472:13: warning: Member variable 'attribute::needsUnescape' is not initialized in the constructor. [uninitMemberVar] libpwizlite-3.0.4/src/pwiz/utility/minimxml/SAXParser.hpp:619:17: performance:inconclusive: Technically the member function 'pwiz::minimxml::SAXParser::Handler::getAttribute' can be static (but you may consider moving to unnamed namespace). [functionStatic] libpwizlite-3.0.4/src/pwiz/utility/minimxml/SAXParser.hpp:645:25: performance:inconclusive: Technically the member function 'pwiz::minimxml::SAXParser::Handler::getAttribute' can be static (but you may consider moving to unnamed namespace). [functionStatic] libpwizlite-3.0.4/src/pwiz/utility/minimxml/SAXParser.hpp:418:21: performance:inconclusive: Technically the member function 'pwiz::minimxml::SAXParser::Handler::Attributes::test_invariant' can be static (but you may consider moving to unnamed namespace). [functionStatic] libpwizlite-3.0.4/src/pwiz/utility/minimxml/SAXParser.hpp:455:14: style:inconclusive: Technically the member function 'pwiz::minimxml::SAXParser::Handler::Attributes::setParserIndex' can be const. [functionConst] libpwizlite-3.0.4/src/pwiz/utility/minimxml/SAXParser.cpp:151:17: style:inconclusive: Technically the member function 'pwiz::minimxml::SAXParser::::StartTag::getName' can be const. [functionConst] libpwizlite-3.0.4/src/pwiz/utility/minimxml/SAXParser.cpp:184:10: performance:inconclusive: Technically the member function 'pwiz::minimxml::SAXParser::::HandlerWrangler::verifyNoDelegate' can be static (but you may consider moving to unnamed namespace). [functionStatic] libpwizlite-3.0.4/src/pwiz/utility/minimxml/SAXParser.hpp:72:5: style: Class 'saxstring' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/utility/minimxml/SAXParser.hpp:80:5: style: Class 'saxstring' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/utility/minimxml/SAXParser.hpp:344:9: style: Struct 'Status' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/utility/minimxml/SAXParser.cpp:117:5: style: Struct 'ProcessingInstruction' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/utility/minimxml/SAXParser.cpp:165:5: style: Struct 'HandlerInfo' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/utility/minimxml/SAXParser.cpp:179:5: style: Class 'HandlerWrangler' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] libpwizlite-3.0.4/src/pwiz/utility/minimxml/SAXParser.cpp:375:22: style: Condition 'i+3=end' is not redundant libpwizlite-3.0.4/src/pwiz/utility/minimxml/SAXParser.cpp:375:22: note: Condition 'i+3' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/common/diff_std.hpp:144:5: style: Struct 'Diff' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/common/diff_std.hpp:43:5: style: Struct 'BaseDiffConfig' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/BinaryDataEncoder.hpp:81:5: style: Class 'BinaryDataEncoder' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1072:5: style: Struct 'HandlerScanSettings' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1248:5: style: Struct 'HandlerPrecursor' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:128:5: style: Struct 'HandlerUserParam' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1349:5: style: Struct 'HandlerProduct' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1459:5: style: Struct 'HandlerScan' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1574:5: style: Struct 'HandlerScanList' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:1734:5: style: Struct 'HandlerBinaryDataArray' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:187:5: style: Struct 'HandlerCVParam' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:2431:5: style: Struct 'HandlerSpectrumListSimple' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:2532:5: style: Struct 'HandlerChromatogramListSimple' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:257:5: style: Struct 'HandlerParamContainer' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:339:5: style: Struct 'HandlerParamGroup' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:418:5: style: Struct 'HandlerSourceFile' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:493:5: style: Struct 'HandlerFileDescription' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:570:5: style: Struct 'HandlerSample' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:633:5: style: Struct 'HandlerComponent' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:690:5: style: Struct 'HandlerComponentList' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:757:5: style: Struct 'HandlerSoftware' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:77:5: style: Struct 'HandlerCV' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:827:5: style: Struct 'HandlerInstrumentConfiguration' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:897:5: style: Struct 'HandlerProcessingMethod' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/IO.cpp:960:5: style: Struct 'HandlerDataProcessing' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:109:5: style: Struct 'Sample' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:187:5: style: Struct 'Software' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:217:5: style: Struct 'ScanSettings' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:243:5: style: Struct 'InstrumentConfiguration' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:281:5: style: Struct 'DataProcessing' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/MSData.hpp:65:5: style: Struct 'SourceFile' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] 2.8 libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:117:22: warning: Either the condition 'init==mask' is redundant or there is signed integer overflow for expression 'mask>>(4*i)'. [integerOverflowCond] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:114:21: note: Assuming that condition 'init==mask' is not redundant libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:114:21: note: Assuming that condition 'init==mask' is not redundant libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:117:22: note: Integer overflow head libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:117:22: warning: Either the condition 'init==mask' is redundant or there is signed integer overflow for expression 'mask>>(4*i)'. [integerOverflowCond] libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:96:16: note: Assignment 'mask=0xf0000000', assigned value is -268435456 libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:114:21: note: Assuming that condition 'init==mask' is not redundant libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:114:21: note: Assuming that condition 'init==mask' is not redundant libpwizlite-3.0.4/src/pwiz/data/msdata/MSNumpress.cpp:117:22: note: Integer overflow head libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MGF.cpp:78:19: style: Variable 'sl' can be declared as reference to const [constVariable] 2.8 libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MGF.cpp:78:19: style: Variable 'sl' can be declared with const [constVariable] head libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MSn.cpp:446:19: style: Variable 'sl' can be declared as reference to const [constVariable] 2.8 libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_MSn.cpp:446:19: style: Variable 'sl' can be declared with const [constVariable] head libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_mz5.hpp:48:5: style: Class 'Serializer_mz5' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_mzML.hpp:57:5: style: Class 'Serializer_mzML' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/Serializer_mzXML.hpp:57:5: style: Class 'Serializer_mzXML' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumWorkerThreads.cpp:116:15: style: Variable 'task' can be declared as reference to const [constVariable] 2.8 libpwizlite-3.0.4/src/pwiz/data/msdata/SpectrumWorkerThreads.cpp:116:15: style: Variable 'task' can be declared with const [constVariable] head libpwizlite-3.0.4/src/pwiz/utility/minimxml/SAXParser.hpp:344:9: style: Struct 'Status' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/utility/minimxml/SAXParser.hpp:72:5: style: Class 'saxstring' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/utility/misc/IntegerSet.hpp:47:9: style: Struct 'Interval' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head libpwizlite-3.0.4/src/pwiz/utility/misc/IterationListener.cpp:113:9: style: Struct 'CallbackInfo' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] DONE