2022-06-29 09:14
ftp://ftp.de.debian.org/debian/pool/main/libf/libfilezilla/libfilezilla_0.37.2.orig.tar.bz2
cppcheck-options: --library=posix --library=gnu  --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j2
platform: Linux-5.4.0-110-generic-x86_64-with-glibc2.29
python: 3.8.10
client-version: 1.3.24
compiler: g++ (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
cppcheck: head 2.8
head-info: b90a726 (2022-06-29 07:22:26 +0200)
count: 99 96
elapsed-time: 3.3 3.4
head-timing-info:
 Overall time: 0s

old-timing-info:
 Overall time: 0s

head results:
libfilezilla-0.37.2/demos/events.cpp:23:2: style: Class 'handler' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
libfilezilla-0.37.2/demos/https.cpp:145:28: style: Parameter 'argv' can be declared as const array [constParameter]
libfilezilla-0.37.2/demos/timer_fizzbuzz.cpp:17:3: performance: Variable 'fizz_' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList]
libfilezilla-0.37.2/demos/timer_fizzbuzz.cpp:13:2: style: Class 'fizzbuzz' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
libfilezilla-0.37.2/lib/libfilezilla/string.hpp:400:80: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm]
libfilezilla-0.37.2/lib/libfilezilla/hash.hpp:29:2: style: Class 'hash_accumulator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
libfilezilla-0.37.2/lib/encryption.cpp:309:58: style:inconclusive: Function 'decrypt' argument 1 names different: declaration 'chiper' definition 'cipher'. [funcArgNamesDifferent]
libfilezilla-0.37.2/lib/libfilezilla/encryption.hpp:162:75: note: Function 'decrypt' argument 1 names different: declaration 'chiper' definition 'cipher'.
libfilezilla-0.37.2/lib/encryption.cpp:309:58: note: Function 'decrypt' argument 1 names different: declaration 'chiper' definition 'cipher'.
libfilezilla-0.37.2/lib/encryption.cpp:314:54: style:inconclusive: Function 'decrypt' argument 1 names different: declaration 'chiper' definition 'cipher'. [funcArgNamesDifferent]
libfilezilla-0.37.2/lib/libfilezilla/encryption.hpp:163:71: note: Function 'decrypt' argument 1 names different: declaration 'chiper' definition 'cipher'.
libfilezilla-0.37.2/lib/encryption.cpp:314:54: note: Function 'decrypt' argument 1 names different: declaration 'chiper' definition 'cipher'.
libfilezilla-0.37.2/lib/encryption.cpp:553:58: style:inconclusive: Function 'decrypt' argument 1 names different: declaration 'chiper' definition 'cipher'. [funcArgNamesDifferent]
libfilezilla-0.37.2/lib/libfilezilla/encryption.hpp:267:75: note: Function 'decrypt' argument 1 names different: declaration 'chiper' definition 'cipher'.
libfilezilla-0.37.2/lib/encryption.cpp:553:58: note: Function 'decrypt' argument 1 names different: declaration 'chiper' definition 'cipher'.
libfilezilla-0.37.2/lib/encryption.cpp:558:54: style:inconclusive: Function 'decrypt' argument 1 names different: declaration 'chiper' definition 'cipher'. [funcArgNamesDifferent]
libfilezilla-0.37.2/lib/libfilezilla/encryption.hpp:268:71: note: Function 'decrypt' argument 1 names different: declaration 'chiper' definition 'cipher'.
libfilezilla-0.37.2/lib/encryption.cpp:558:54: note: Function 'decrypt' argument 1 names different: declaration 'chiper' definition 'cipher'.
libfilezilla-0.37.2/lib/encryption.cpp:350:24: style: Local variable 'key' shadows outer function [shadowFunction]
libfilezilla-0.37.2/lib/libfilezilla/encryption.hpp:213:30: note: Shadowed declaration
libfilezilla-0.37.2/lib/encryption.cpp:350:24: note: Shadow variable
libfilezilla-0.37.2/lib/libfilezilla/event.hpp:91:17: style: The function 'derived_type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride]
libfilezilla-0.37.2/lib/libfilezilla/event.hpp:46:17: note: Virtual function in base class
libfilezilla-0.37.2/lib/libfilezilla/event.hpp:91:17: note: Function in derived class
libfilezilla-0.37.2/lib/event_handler.cpp:12:16: warning:inconclusive: Member variable 'event_handler::removing_' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy]
libfilezilla-0.37.2/lib/event_loop.cpp:91:27: style: Condition 'active_handler_==handler' is always true [knownConditionTrueFalse]
libfilezilla-0.37.2/lib/event_loop.cpp:89:22: note: Assuming that condition 'active_handler_==handler' is not redundant
libfilezilla-0.37.2/lib/event_loop.cpp:91:27: note: Condition 'active_handler_==handler' is always true
libfilezilla-0.37.2/lib/event_loop.cpp:304:15: style: Variable 'v' can be declared as reference to const [constVariable]
libfilezilla-0.37.2/lib/libfilezilla/file.hpp:101:9: style:inconclusive: Technically the member function 'fz::file::fd' can be const. [functionConst]
libfilezilla-0.37.2/lib/file.cpp:275:9: style: Local variable 'fd' shadows outer function [shadowFunction]
libfilezilla-0.37.2/lib/libfilezilla/file.hpp:101:9: note: Shadowed declaration
libfilezilla-0.37.2/lib/file.cpp:275:9: note: Shadow variable
libfilezilla-0.37.2/lib/impersonation.cpp:27:2: warning: Member variable 'passwd_holder::pwd_buffer_' is not initialized in the constructor. [uninitMemberVar]
libfilezilla-0.37.2/lib/hostname_lookup.cpp:110:46: style: Condition '!res' is always true [knownConditionTrueFalse]
libfilezilla-0.37.2/lib/hostname_lookup.cpp:104:6: note: Assuming that condition 'res' is not redundant
libfilezilla-0.37.2/lib/hostname_lookup.cpp:110:46: note: Condition '!res' is always true
libfilezilla-0.37.2/lib/hostname_lookup.cpp:151:50: style: Parameter 'lookup' can be declared as pointer to const [constParameter]
libfilezilla-0.37.2/lib/libfilezilla/invoker.hpp:22:2: style: Class 'thread_invoker' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
libfilezilla-0.37.2/lib/libfilezilla/json.hpp:183:2: style: Struct 'json_array_iterator < false >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
libfilezilla-0.37.2/lib/libfilezilla/json.hpp:183:2: style: Struct 'json_array_iterator < true >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
libfilezilla-0.37.2/lib/json.cpp:249:42: style:inconclusive: Function 'parse' argument 1 names different: declaration 'v' definition 's'. [funcArgNamesDifferent]
libfilezilla-0.37.2/lib/libfilezilla/json.hpp:158:44: note: Function 'parse' argument 1 names different: declaration 'v' definition 's'.
libfilezilla-0.37.2/lib/json.cpp:249:42: note: Function 'parse' argument 1 names different: declaration 'v' definition 's'.
libfilezilla-0.37.2/lib/json.cpp:438:44: style: Local variable 'children' shadows outer function [shadowFunction]
libfilezilla-0.37.2/lib/libfilezilla/json.hpp:94:9: note: Shadowed declaration
libfilezilla-0.37.2/lib/json.cpp:438:44: note: Shadow variable
libfilezilla-0.37.2/lib/json.cpp:490:21: style: Local variable 'children' shadows outer function [shadowFunction]
libfilezilla-0.37.2/lib/libfilezilla/json.hpp:94:9: note: Shadowed declaration
libfilezilla-0.37.2/lib/json.cpp:490:21: note: Shadow variable
libfilezilla-0.37.2/lib/libfilezilla/json.hpp:211:47: style: Parameter 'j' can be declared as reference to const [constParameter]
libfilezilla-0.37.2/lib/json.cpp:123:14: style: Variable 'c' can be declared as reference to const [constVariable]
libfilezilla-0.37.2/lib/libfilezilla/logger.hpp:140:15: performance:inconclusive: Technically the member function 'fz::logger_interface::assume_strings_are_utf8' can be static (but you may consider moving to unnamed namespace). [functionStatic]
libfilezilla-0.37.2/lib/libfilezilla/logger.hpp:143:15: performance:inconclusive: Technically the member function 'fz::logger_interface::assume_strings_are_utf8' can be static (but you may consider moving to unnamed namespace). [functionStatic]
libfilezilla-0.37.2/lib/libfilezilla/logger.hpp:146:15: performance:inconclusive: Technically the member function 'fz::logger_interface::assume_strings_are_utf8' can be static (but you may consider moving to unnamed namespace). [functionStatic]
libfilezilla-0.37.2/lib/libfilezilla/logger.hpp:151:11: performance:inconclusive: Technically the member function 'fz::logger_interface::assume_strings_are_utf8' can be static (but you may consider moving to unnamed namespace). [functionStatic]
libfilezilla-0.37.2/lib/local_filesys.cpp:629:18: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled]
libfilezilla-0.37.2/lib/local_filesys.cpp:778:18: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled]
libfilezilla-0.37.2/lib/local_filesys.cpp:866:9: style: Obsolescent function 'utime' called. It is recommended to use 'utimensat' instead. [prohibitedutimeCalled]
libfilezilla-0.37.2/lib/local_filesys.cpp:1041:10: style: Local variable 't' shadows outer variable [shadowVariable]
libfilezilla-0.37.2/lib/local_filesys.cpp:1011:7: note: Shadowed declaration
libfilezilla-0.37.2/lib/local_filesys.cpp:1041:10: note: Shadow variable
libfilezilla-0.37.2/lib/local_filesys.cpp:1234:13: style: Local variable 'err' shadows outer variable [shadowVariable]
libfilezilla-0.37.2/lib/local_filesys.cpp:1202:12: note: Shadowed declaration
libfilezilla-0.37.2/lib/local_filesys.cpp:1234:13: note: Shadow variable
libfilezilla-0.37.2/lib/libfilezilla/nonowning_buffer.hpp:66:10: style:inconclusive: Technically the member function 'fz::nonowning_buffer::operator[]' can be const. [functionConst]
libfilezilla-0.37.2/lib/libfilezilla/rate_limiter.hpp:187:2: warning: Member variable 'rate_limiter::data_' is not initialized in the constructor. [uninitMemberVar]
libfilezilla-0.37.2/lib/libfilezilla/rate_limiter.hpp:69:25: style: The function 'operator()' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride]
libfilezilla-0.37.2/lib/libfilezilla/event_handler.hpp:79:15: note: Virtual function in base class
libfilezilla-0.37.2/lib/libfilezilla/rate_limiter.hpp:69:25: note: Function in derived class
libfilezilla-0.37.2/lib/rate_limited_layer.cpp:117:66: style: Parameter 'limiter' can be declared as reference to const [constParameter]
libfilezilla-0.37.2/lib/rate_limited_layer.cpp:178:64: style: Parameter 'limiter' can be declared as pointer to const [constParameter]
libfilezilla-0.37.2/lib/rate_limited_layer.cpp:169:32: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm]
libfilezilla-0.37.2/lib/rate_limited_layer.cpp:181:32: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm]
libfilezilla-0.37.2/lib/process.cpp:701:2: style: Class 'impl' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
libfilezilla-0.37.2/lib/libfilezilla/recursive_remove.hpp:36:7: style:inconclusive: Technically the member function 'fz::recursive_remove::remove' can be const. [functionConst]
libfilezilla-0.37.2/lib/recursive_remove.cpp:26:24: note: Technically the member function 'fz::recursive_remove::remove' can be const.
libfilezilla-0.37.2/lib/libfilezilla/recursive_remove.hpp:36:7: note: Technically the member function 'fz::recursive_remove::remove' can be const.
libfilezilla-0.37.2/lib/recursive_remove.cpp:145:13: style: Consider using std::any_of, std::all_of, std::none_of, or std::accumulate algorithm instead of a raw loop. [useStlAlgorithm]
libfilezilla-0.37.2/lib/recursive_remove.cpp:153:12: style: Consider using std::any_of, std::all_of, std::none_of, or std::accumulate algorithm instead of a raw loop. [useStlAlgorithm]
libfilezilla-0.37.2/lib/libfilezilla/rate_limiter.hpp:283:7: style:inconclusive: Technically the member function 'fz::bucket::waiting' can be const. [functionConst]
libfilezilla-0.37.2/lib/rate_limiter.cpp:651:14: note: Technically the member function 'fz::bucket::waiting' can be const.
libfilezilla-0.37.2/lib/libfilezilla/rate_limiter.hpp:283:7: note: Technically the member function 'fz::bucket::waiting' can be const.
libfilezilla-0.37.2/lib/libfilezilla/rate_limiter.hpp:257:15: style: Virtual function 'remove_bucket' is called from destructor '~bucket()' at line 495. Dynamic binding is not used. [virtualCallInConstructor]
libfilezilla-0.37.2/lib/rate_limiter.cpp:495:2: note: Calling remove_bucket
libfilezilla-0.37.2/lib/libfilezilla/rate_limiter.hpp:257:15: note: remove_bucket is a virtual function
libfilezilla-0.37.2/lib/rate_limiter.cpp:401:82: style:inconclusive: Function 'distribute_overflow' argument 2 names different: declaration 'tokens' definition 'overflow'. [funcArgNamesDifferent]
libfilezilla-0.37.2/lib/libfilezilla/rate_limiter.hpp:225:95: note: Function 'distribute_overflow' argument 2 names different: declaration 'tokens' definition 'overflow'.
libfilezilla-0.37.2/lib/rate_limiter.cpp:401:82: note: Function 'distribute_overflow' argument 2 names different: declaration 'tokens' definition 'overflow'.
libfilezilla-0.37.2/lib/rate_limiter.cpp:230:9: style: Local variable 'weight' shadows outer function [shadowFunction]
libfilezilla-0.37.2/lib/libfilezilla/rate_limiter.hpp:220:35: note: Shadowed declaration
libfilezilla-0.37.2/lib/rate_limiter.cpp:230:9: note: Shadow variable
libfilezilla-0.37.2/lib/rate_limiter.cpp:312:10: style: Local variable 'weight' shadows outer function [shadowFunction]
libfilezilla-0.37.2/lib/libfilezilla/rate_limiter.hpp:220:35: note: Shadowed declaration
libfilezilla-0.37.2/lib/rate_limiter.cpp:312:10: note: Shadow variable
libfilezilla-0.37.2/lib/socket_errors.cpp:27:14: style: struct member 'Error::name' is never used. [unusedStructMember]
libfilezilla-0.37.2/lib/socket_errors.cpp:28:14: style: struct member 'Error::description' is never used. [unusedStructMember]
libfilezilla-0.37.2/lib/libfilezilla/socket.hpp:535:6: style:inconclusive: Technically the member function 'fz::socket::ideal_send_buffer_size' can be const. [functionConst]
libfilezilla-0.37.2/lib/socket.cpp:1609:13: note: Technically the member function 'fz::socket::ideal_send_buffer_size' can be const.
libfilezilla-0.37.2/lib/libfilezilla/socket.hpp:535:6: note: Technically the member function 'fz::socket::ideal_send_buffer_size' can be const.
libfilezilla-0.37.2/lib/socket.cpp:965:4: warning: Class 'socket_base' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor]
libfilezilla-0.37.2/lib/socket.cpp:965:4: warning: Class 'socket_base' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq]
libfilezilla-0.37.2/lib/socket.cpp:640:36: style: Condition 'bind.empty()' is always false [knownConditionTrueFalse]
libfilezilla-0.37.2/lib/socket.cpp:634:7: note: Assuming that condition '!bind.empty()' is not redundant
libfilezilla-0.37.2/lib/socket.cpp:640:36: note: Condition 'bind.empty()' is always false
libfilezilla-0.37.2/lib/socket.cpp:1513:22: style: C-style pointer casting [cstyleCast]
libfilezilla-0.37.2/lib/socket.cpp:1548:23: style: C-style pointer casting [cstyleCast]
libfilezilla-0.37.2/lib/socket.cpp:1537:12: style: Local variable 'flags' shadows outer function [shadowFunction]
libfilezilla-0.37.2/lib/libfilezilla/socket.hpp:562:6: note: Shadowed declaration
libfilezilla-0.37.2/lib/socket.cpp:1537:12: note: Shadow variable
libfilezilla-0.37.2/lib/string.cpp:185:5: warning: Return value of function mbsnrtowcs() is not used. [ignoredReturnValue]
libfilezilla-0.37.2/lib/string.cpp:372:5: warning: Return value of function wcsnrtombs() is not used. [ignoredReturnValue]
libfilezilla-0.37.2/lib/string.cpp:265:3: performance: Variable 'cd' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList]
libfilezilla-0.37.2/lib/thread_pool.cpp:18:2: style: Class 'pooled_thread_impl' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
libfilezilla-0.37.2/lib/libfilezilla/time.hpp:269:25: style:inconclusive: Technically the member function 'fz::datetime::clamped' can be const. [functionConst]
libfilezilla-0.37.2/lib/time.cpp:204:16: note: Technically the member function 'fz::datetime::clamped' can be const.
libfilezilla-0.37.2/lib/libfilezilla/time.hpp:269:25: note: Technically the member function 'fz::datetime::clamped' can be const.
libfilezilla-0.37.2/lib/time.cpp:915:13: warning: Identical inner 'if' condition is always true. [identicalInnerCondition]
libfilezilla-0.37.2/lib/time.cpp:914:12: note: outer condition: year<1000
libfilezilla-0.37.2/lib/time.cpp:915:13: note: identical inner condition: year<1000
libfilezilla-0.37.2/lib/time.cpp:134:44: style:inconclusive: Function 'datetime' argument 1 names different: declaration 's' definition 'str'. [funcArgNamesDifferent]
libfilezilla-0.37.2/lib/libfilezilla/time.hpp:74:44: note: Function 'datetime' argument 1 names different: declaration 's' definition 'str'.
libfilezilla-0.37.2/lib/time.cpp:134:44: note: Function 'datetime' argument 1 names different: declaration 's' definition 'str'.
libfilezilla-0.37.2/lib/time.cpp:139:45: style:inconclusive: Function 'datetime' argument 1 names different: declaration 's' definition 'str'. [funcArgNamesDifferent]
libfilezilla-0.37.2/lib/libfilezilla/time.hpp:75:45: note: Function 'datetime' argument 1 names different: declaration 's' definition 'str'.
libfilezilla-0.37.2/lib/time.cpp:139:45: note: Function 'datetime' argument 1 names different: declaration 's' definition 'str'.
libfilezilla-0.37.2/lib/time.cpp:669:49: style:inconclusive: Function 'format' argument 1 names different: declaration 'format' definition 'fmt'. [funcArgNamesDifferent]
libfilezilla-0.37.2/lib/libfilezilla/time.hpp:198:40: note: Function 'format' argument 1 names different: declaration 'format' definition 'fmt'.
libfilezilla-0.37.2/lib/time.cpp:669:49: note: Function 'format' argument 1 names different: declaration 'format' definition 'fmt'.
libfilezilla-0.37.2/lib/time.cpp:685:51: style:inconclusive: Function 'format' argument 1 names different: declaration 'format' definition 'fmt'. [funcArgNamesDifferent]
libfilezilla-0.37.2/lib/libfilezilla/time.hpp:199:42: note: Function 'format' argument 1 names different: declaration 'format' definition 'fmt'.
libfilezilla-0.37.2/lib/time.cpp:685:51: note: Function 'format' argument 1 names different: declaration 'format' definition 'fmt'.
libfilezilla-0.37.2/lib/tls_layer.cpp:6:93: style:inconclusive: Function 'tls_layer' argument 3 names different: declaration 'layer' definition 'next_layer'. [funcArgNamesDifferent]
libfilezilla-0.37.2/lib/libfilezilla/tls_layer.hpp:65:82: note: Function 'tls_layer' argument 3 names different: declaration 'layer' definition 'next_layer'.
libfilezilla-0.37.2/lib/tls_layer.cpp:6:93: note: Function 'tls_layer' argument 3 names different: declaration 'layer' definition 'next_layer'.
libfilezilla-0.37.2/lib/tls_layer.cpp:161:58: style:inconclusive: Function 'set_alpn' argument 1 names different: declaration 'alpns' definition 'alpn'. [funcArgNamesDifferent]
libfilezilla-0.37.2/lib/libfilezilla/tls_layer.hpp:189:48: note: Function 'set_alpn' argument 1 names different: declaration 'alpns' definition 'alpn'.
libfilezilla-0.37.2/lib/tls_layer.cpp:161:58: note: Function 'set_alpn' argument 1 names different: declaration 'alpns' definition 'alpn'.
libfilezilla-0.37.2/lib/libfilezilla/tls_system_trust_store.hpp:32:2: style: Class 'tls_system_trust_store' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
libfilezilla-0.37.2/lib/tls_system_trust_store_impl.hpp:21:2: style: Class 'tls_system_trust_store_impl' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
libfilezilla-0.37.2/lib/tls_layer_impl.cpp:74:10: style: C-style pointer casting [cstyleCast]
libfilezilla-0.37.2/lib/tls_layer_impl.cpp:79:10: style: C-style pointer casting [cstyleCast]
libfilezilla-0.37.2/lib/tls_layer_impl.cpp:1742:7: style: The scope of the variable 'hostnameMismatch' can be reduced. [variableScope]
libfilezilla-0.37.2/lib/tls_layer_impl.cpp:681:59: style:inconclusive: Function 'on_socket_event' argument 1 names different: declaration 'source' definition 's'. [funcArgNamesDifferent]
libfilezilla-0.37.2/lib/tls_layer_impl.hpp:128:44: note: Function 'on_socket_event' argument 1 names different: declaration 'source' definition 's'.
libfilezilla-0.37.2/lib/tls_layer_impl.cpp:681:59: note: Function 'on_socket_event' argument 1 names different: declaration 'source' definition 's'.
libfilezilla-0.37.2/lib/tls_layer_impl.cpp:1082:53: style:inconclusive: Function 'read' argument 2 names different: declaration 'size' definition 'len'. [funcArgNamesDifferent]
libfilezilla-0.37.2/lib/tls_layer_impl.hpp:53:38: note: Function 'read' argument 2 names different: declaration 'size' definition 'len'.
libfilezilla-0.37.2/lib/tls_layer_impl.cpp:1082:53: note: Function 'read' argument 2 names different: declaration 'size' definition 'len'.
libfilezilla-0.37.2/lib/tls_layer_impl.cpp:1117:60: style:inconclusive: Function 'write' argument 2 names different: declaration 'size' definition 'len'. [funcArgNamesDifferent]
libfilezilla-0.37.2/lib/tls_layer_impl.hpp:54:45: note: Function 'write' argument 2 names different: declaration 'size' definition 'len'.
libfilezilla-0.37.2/lib/tls_layer_impl.cpp:1117:60: note: Function 'write' argument 2 names different: declaration 'size' definition 'len'.
libfilezilla-0.37.2/lib/tls_layer_impl.cpp:1491:73: style:inconclusive: Function 'certificate_is_blacklisted' argument 1 names different: declaration 'certificates' definition 'certs'. [funcArgNamesDifferent]
libfilezilla-0.37.2/lib/tls_layer_impl.hpp:116:58: note: Function 'certificate_is_blacklisted' argument 1 names different: declaration 'certificates' definition 'certs'.
libfilezilla-0.37.2/lib/tls_layer_impl.cpp:1491:73: note: Function 'certificate_is_blacklisted' argument 1 names different: declaration 'certificates' definition 'certs'.
libfilezilla-0.37.2/lib/tls_layer_impl.cpp:346:7: style: Local variable 'read' shadows outer function [shadowFunction]
libfilezilla-0.37.2/lib/tls_layer_impl.hpp:53:6: note: Shadowed declaration
libfilezilla-0.37.2/lib/tls_layer_impl.cpp:346:7: note: Shadow variable
libfilezilla-0.37.2/lib/tls_layer_impl.cpp:643:6: style: Local variable 'read' shadows outer function [shadowFunction]
libfilezilla-0.37.2/lib/tls_layer_impl.hpp:53:6: note: Shadowed declaration
libfilezilla-0.37.2/lib/tls_layer_impl.cpp:643:6: note: Shadow variable
libfilezilla-0.37.2/lib/translate.cpp:29:43: style:inconclusive: Function 'translate' argument 1 names different: declaration 'source' definition 't'. [funcArgNamesDifferent]
libfilezilla-0.37.2/lib/libfilezilla/translate.hpp:26:59: note: Function 'translate' argument 1 names different: declaration 'source' definition 't'.
libfilezilla-0.37.2/lib/translate.cpp:29:43: note: Function 'translate' argument 1 names different: declaration 'source' definition 't'.
libfilezilla-0.37.2/lib/libfilezilla/glue/windows.hpp:7:0: error: #error "You included a file you should not include" [preprocessorErrorDirective]
libfilezilla-0.37.2/lib/windows/poller.hpp:51:0: error: #error windows/poller.hpp is not for non-Windows [preprocessorErrorDirective]
libfilezilla-0.37.2/lib/libfilezilla/glue/registry.hpp:74:0: error: #error This file is for Windows only [preprocessorErrorDirective]
libfilezilla-0.37.2/tests/eventloop.cpp:43:2: style: Class 'target' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
libfilezilla-0.37.2/tests/eventloop.cpp:112:2: style: Class 'target2' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
libfilezilla-0.37.2/tests/eventloop.cpp:218:2: style: Class 'timer_handler' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
libfilezilla-0.37.2/tests/ratelimit.cpp:8:2: style: Struct 'handler' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
libfilezilla-0.37.2/tests/socket.cpp:190:2: style: Struct 'client' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
libfilezilla-0.37.2/tests/socket.cpp:223:2: style: Struct 'server' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
libfilezilla-0.37.2/tests/socket.cpp:101:9: style: Local variable 'error' shadows outer argument [shadowArgument]
libfilezilla-0.37.2/tests/socket.cpp:83:94: note: Shadowed declaration
libfilezilla-0.37.2/tests/socket.cpp:101:9: note: Shadow variable
libfilezilla-0.37.2/tests/socket.cpp:147:9: style: Local variable 'error' shadows outer argument [shadowArgument]
libfilezilla-0.37.2/tests/socket.cpp:83:94: note: Shadowed declaration
libfilezilla-0.37.2/tests/socket.cpp:147:9: note: Shadow variable
libfilezilla-0.37.2/tests/socket.cpp:252:9: style: Local variable 'error' shadows outer argument [shadowArgument]
libfilezilla-0.37.2/tests/socket.cpp:242:89: note: Shadowed declaration
libfilezilla-0.37.2/tests/socket.cpp:252:9: note: Shadow variable
libfilezilla-0.37.2/tests/socket.cpp:83:54: style: Parameter 'source' can be declared as pointer to const [constParameter]
diff:
head libfilezilla-0.37.2/demos/https.cpp:145:28: style: Parameter 'argv' can be declared as const array [constParameter]
2.8 libfilezilla-0.37.2/demos/https.cpp:145:28: style: Parameter 'argv' can be declared with const [constParameter]
head libfilezilla-0.37.2/lib/event_loop.cpp:304:15: style: Variable 'v' can be declared as reference to const [constVariable]
head libfilezilla-0.37.2/lib/hostname_lookup.cpp:151:50: style: Parameter 'lookup' can be declared as pointer to const [constParameter]
2.8 libfilezilla-0.37.2/lib/hostname_lookup.cpp:151:50: style: Parameter 'lookup' can be declared with const [constParameter]
head libfilezilla-0.37.2/lib/json.cpp:123:14: style: Variable 'c' can be declared as reference to const [constVariable]
head libfilezilla-0.37.2/lib/libfilezilla/json.hpp:211:47: style: Parameter 'j' can be declared as reference to const [constParameter]
2.8 libfilezilla-0.37.2/lib/libfilezilla/json.hpp:211:47: style: Parameter 'j' can be declared with const [constParameter]
head libfilezilla-0.37.2/lib/rate_limited_layer.cpp:117:66: style: Parameter 'limiter' can be declared as reference to const [constParameter]
2.8 libfilezilla-0.37.2/lib/rate_limited_layer.cpp:117:66: style: Parameter 'limiter' can be declared with const [constParameter]
head libfilezilla-0.37.2/lib/rate_limited_layer.cpp:178:64: style: Parameter 'limiter' can be declared as pointer to const [constParameter]
2.8 libfilezilla-0.37.2/lib/rate_limited_layer.cpp:178:64: style: Parameter 'limiter' can be declared with const [constParameter]
head libfilezilla-0.37.2/lib/string.cpp:185:5: warning: Return value of function mbsnrtowcs() is not used. [ignoredReturnValue]
head libfilezilla-0.37.2/tests/socket.cpp:83:54: style: Parameter 'source' can be declared as pointer to const [constParameter]
2.8 libfilezilla-0.37.2/tests/socket.cpp:83:54: style: Parameter 'source' can be declared with const [constParameter]


DONE