2022-06-29 06:37 ftp://ftp.de.debian.org/debian/pool/main/libc/libcitadel/libcitadel_917.orig.tar.gz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j2 platform: Linux-5.4.0-110-generic-x86_64-with-glibc2.29 python: 3.8.10 client-version: 1.3.24 compiler: g++ (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0 cppcheck: head 2.8 head-info: b90a726 (2022-06-29 07:22:26 +0200) count: 137 137 elapsed-time: 6.2 8.1 head-timing-info: Overall time: 0s old-timing-info: Overall time: 0s head results: libcitadel/lib/b64/cdecode.c:16:17: warning: Either the condition 'value_in>decoding_size' is redundant or the array 'decoding[80]' is accessed at index 80, which is out of bounds. [arrayIndexOutOfBoundsCond] libcitadel/lib/b64/cdecode.c:15:31: note: Assuming that condition 'value_in>decoding_size' is not redundant libcitadel/lib/b64/cdecode.c:16:17: note: Array index out of bounds libcitadel/lib/hash.c:927:12: warning: Identical condition 'Hash==NULL', second condition is always false [identicalConditionAfterEarlyExit] libcitadel/lib/hash.c:923:11: note: If condition 'Hash==NULL' is true, the function will return/exit libcitadel/lib/hash.c:927:12: note: Testing identical condition 'Hash==NULL' libcitadel/lib/hash.c:602:20: style: Condition 'SearchPos>0' is always true [knownConditionTrueFalse] libcitadel/lib/hash.c:585:20: note: Assuming that condition 'SearchPos>0' is not redundant libcitadel/lib/hash.c:589:41: note: Assuming condition is false libcitadel/lib/hash.c:602:20: note: Condition 'SearchPos>0' is always true libcitadel/lib/hash.c:930:20: style: Condition 'At->Position>Hash->nLookupTableItems' is always false [knownConditionTrueFalse] libcitadel/lib/hash.c:928:20: note: Assuming that condition 'At->Position>=Hash->nLookupTableItems' is not redundant libcitadel/lib/hash.c:930:20: note: Condition 'At->Position>Hash->nLookupTableItems' is always false libcitadel/lib/hash.c:982:20: style: Condition 'At->Position>Hash->nLookupTableItems' is always false [knownConditionTrueFalse] libcitadel/lib/hash.c:980:20: note: Assuming that condition 'At->Position>=Hash->nLookupTableItems' is not redundant libcitadel/lib/hash.c:982:20: note: Condition 'At->Position>Hash->nLookupTableItems' is always false libcitadel/lib/hash.c:1018:20: style: Condition 'At->Position>Hash->nLookupTableItems' is always false [knownConditionTrueFalse] libcitadel/lib/hash.c:1016:20: note: Assuming that condition 'At->Position>=Hash->nLookupTableItems' is not redundant libcitadel/lib/hash.c:1018:20: note: Condition 'At->Position>Hash->nLookupTableItems' is always false libcitadel/lib/hash.c:1051:20: style: Condition 'At->Position>Hash->nLookupTableItems' is always false [knownConditionTrueFalse] libcitadel/lib/hash.c:1049:20: note: Assuming that condition 'At->Position>=Hash->nLookupTableItems' is not redundant libcitadel/lib/hash.c:1051:20: note: Condition 'At->Position>Hash->nLookupTableItems' is always false libcitadel/lib/hash.c:1073:20: style: Condition 'At->Position>Hash->nLookupTableItems' is always false [knownConditionTrueFalse] libcitadel/lib/hash.c:1071:20: note: Assuming that condition 'At->Position>=Hash->nLookupTableItems' is not redundant libcitadel/lib/hash.c:1073:20: note: Condition 'At->Position>Hash->nLookupTableItems' is always false libcitadel/lib/hash.c:792:59: style:inconclusive: Function 'GetKey' argument 4 names different: declaration 'Data' definition 'Payload'. [funcArgNamesDifferent] libcitadel/lib/libcitadel.h:532:59: note: Function 'GetKey' argument 4 names different: declaration 'Data' definition 'Payload'. libcitadel/lib/hash.c:792:59: note: Function 'GetKey' argument 4 names different: declaration 'Data' definition 'Payload'. libcitadel/lib/hash.c:1282:22: style:inconclusive: Function 'ParseMSet' argument 1 names different: declaration 'MsetList' definition 'MSetList'. [funcArgNamesDifferent] libcitadel/lib/libcitadel.h:556:22: note: Function 'ParseMSet' argument 1 names different: declaration 'MsetList' definition 'MSetList'. libcitadel/lib/hash.c:1282:22: note: Function 'ParseMSet' argument 1 names different: declaration 'MsetList' definition 'MSetList'. libcitadel/lib/html_to_ascii.c:54:16: style: Variable 'inbuf_len' is assigned a value that is never used. [unreadVariable] libcitadel/lib/html_to_ascii.c:608:3: style: Variable 'output_len' is assigned a value that is never used. [unreadVariable] libcitadel/lib/mime_parser.c:1058:26: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled] libcitadel/lib/mime_parser.c:524:46: style: Redundant condition: If 'EXPR > 10', the comparison 'EXPR != -1' is always true. [redundantCondition] libcitadel/lib/mime_parser.c:548:46: style: Redundant condition: If 'EXPR > 10', the comparison 'EXPR != -1' is always true. [redundantCondition] libcitadel/lib/mime_parser.c:304:3: warning: Either the condition 'decoded==NULL' is redundant or there is possible null pointer dereference: decoded. [nullPointerRedundantCheck] libcitadel/lib/mime_parser.c:332:14: note: Assuming that condition 'decoded==NULL' is not redundant libcitadel/lib/mime_parser.c:304:3: note: Null pointer dereference libcitadel/lib/mime_parser.c:331:3: warning: Either the condition 'decoded==NULL' is redundant or there is possible null pointer dereference: decoded. [nullPointerRedundantCheck] libcitadel/lib/mime_parser.c:332:14: note: Assuming that condition 'decoded==NULL' is not redundant libcitadel/lib/mime_parser.c:331:3: note: Null pointer dereference libcitadel/lib/mime_parser.c:643:13: warning: Either the condition 'part_start!=NULL' is redundant or there is overflow in pointer subtraction. [nullPointerArithmeticRedundantCheck] libcitadel/lib/mime_parser.c:660:21: note: Assuming that condition 'part_start!=NULL' is not redundant libcitadel/lib/mime_parser.c:647:17: note: Assignment to 'part_start=ptr' libcitadel/lib/mime_parser.c:643:13: note: Null pointer subtraction libcitadel/lib/mime_parser.c:559:13: style: Variable 'srch' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/lib/mime_parser.c:558:8: note: srch is assigned libcitadel/lib/mime_parser.c:559:13: note: srch is overwritten libcitadel/lib/mime_parser.c:145:26: style: Same expression on both sides of '||'. [duplicateExpression] libcitadel/lib/mime_parser.c:397:16: style: Parameter 'content_end' can be declared as pointer to const [constParameter] libcitadel/lib/stringbuf.c:800:15: style: Condition 'Buf->buf==pEnd' is always false [knownConditionTrueFalse] libcitadel/lib/stringbuf.c:796:11: note: Assuming condition 'pEnd==Buf->buf' is false libcitadel/lib/stringbuf.c:798:21: note: Assuming condition is false libcitadel/lib/stringbuf.c:800:15: note: Condition 'Buf->buf==pEnd' is always false libcitadel/lib/stringbuf.c:2727:13: style: Condition 'target!=NULL' is always true [knownConditionTrueFalse] libcitadel/lib/stringbuf.c:2722:34: note: Assuming condition 'target==NULL' is false libcitadel/lib/stringbuf.c:2727:13: note: Condition 'target!=NULL' is always true libcitadel/lib/stringbuf.c:3594:12: style: Condition 'pch!=NULL' is always true [knownConditionTrueFalse] libcitadel/lib/stringbuf.c:5050:17: style: Condition 'rlen>0' is always true [knownConditionTrueFalse] libcitadel/lib/stringbuf.c:5044:12: note: Assuming that condition 'rlen<1' is not redundant libcitadel/lib/stringbuf.c:5050:17: note: Condition 'rlen>0' is always true libcitadel/lib/stringbuf.c:5224:17: style: Condition 'rlen>0' is always true [knownConditionTrueFalse] libcitadel/lib/stringbuf.c:5218:12: note: Assuming that condition 'rlen<1' is not redundant libcitadel/lib/stringbuf.c:5224:17: note: Condition 'rlen>0' is always true libcitadel/lib/stringbuf.c:2740:4: warning: %x in format string (no. 1) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int] libcitadel/lib/stringbuf.c:3245:5: warning: %x in format string (no. 1) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int] libcitadel/lib/stringbuf.c:5654:4: warning: %x in format string (no. 1) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int] libcitadel/lib/stringbuf.c:1664:3: warning: Either the condition '(s)==NULL' is redundant or there is pointer arithmetic with NULL pointer. [nullPointerArithmeticRedundantCheck] libcitadel/lib/stringbuf.c:1657:10: note: Assuming that condition '(s)==NULL' is not redundant libcitadel/lib/stringbuf.c:1664:3: note: Null pointer addition libcitadel/lib/stringbuf.c:1732:12: warning: Either the condition '(s)==NULL' is redundant or there is pointer arithmetic with NULL pointer. [nullPointerArithmeticRedundantCheck] libcitadel/lib/stringbuf.c:1722:29: note: Assuming that condition '(s)==NULL' is not redundant libcitadel/lib/stringbuf.c:1731:12: note: Assignment '*pStart=s', assigned value is 0 libcitadel/lib/stringbuf.c:1732:12: note: Null pointer addition libcitadel/lib/stringbuf.c:3578:45: warning: Either the condition 'UserEnd==NULL' is redundant or there is overflow in pointer subtraction. [nullPointerArithmeticRedundantCheck] libcitadel/lib/stringbuf.c:3577:44: note: Assuming that condition 'UserEnd==NULL' is not redundant libcitadel/lib/stringbuf.c:3578:45: note: Null pointer subtraction libcitadel/lib/stringbuf.c:3585:51: warning: Either the condition 'EmailEnd==NULL' is redundant or there is overflow in pointer subtraction. [nullPointerArithmeticRedundantCheck] libcitadel/lib/stringbuf.c:3584:46: note: Assuming that condition 'EmailEnd==NULL' is not redundant libcitadel/lib/stringbuf.c:3585:51: note: Null pointer subtraction libcitadel/lib/stringbuf.c:1458:16: style: Variable 'dest->BufUsed' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/lib/stringbuf.c:1442:19: note: dest->BufUsed is assigned libcitadel/lib/stringbuf.c:1458:16: note: dest->BufUsed is overwritten libcitadel/lib/stringbuf.c:1678:17: style: Variable 'dest->BufUsed' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/lib/stringbuf.c:1651:19: note: dest->BufUsed is assigned libcitadel/lib/stringbuf.c:1678:17: note: dest->BufUsed is overwritten libcitadel/lib/stringbuf.c:3424:12: style: Variable 'LinePos' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/lib/stringbuf.c:3418:13: note: LinePos is assigned libcitadel/lib/stringbuf.c:3424:12: note: LinePos is overwritten libcitadel/lib/stringbuf.c:2922:61: style:inconclusive: Function 'StrBufDestroyStreamContext' argument 2 names different: declaration 'Stream' definition 'vStream'. [funcArgNamesDifferent] libcitadel/lib/libcitadel.h:352:61: note: Function 'StrBufDestroyStreamContext' argument 2 names different: declaration 'Stream' definition 'vStream'. libcitadel/lib/stringbuf.c:2922:61: note: Function 'StrBufDestroyStreamContext' argument 2 names different: declaration 'Stream' definition 'vStream'. libcitadel/lib/stringbuf.c:2965:117: style:inconclusive: Function 'StrBufStreamTranscode' argument 6 names different: declaration 'Stream' definition 'vStream'. [funcArgNamesDifferent] libcitadel/lib/libcitadel.h:353:117: note: Function 'StrBufStreamTranscode' argument 6 names different: declaration 'Stream' definition 'vStream'. libcitadel/lib/stringbuf.c:2965:117: note: Function 'StrBufStreamTranscode' argument 6 names different: declaration 'Stream' definition 'vStream'. libcitadel/lib/stringbuf.c:5093:19: style:inconclusive: Function 'StrBufTCP_read_buffered_line_fast' argument 2 names different: declaration 'buf' definition 'IOBuf'. [funcArgNamesDifferent] libcitadel/lib/libcitadel.h:235:19: note: Function 'StrBufTCP_read_buffered_line_fast' argument 2 names different: declaration 'buf' definition 'IOBuf'. libcitadel/lib/stringbuf.c:5093:19: note: Function 'StrBufTCP_read_buffered_line_fast' argument 2 names different: declaration 'buf' definition 'IOBuf'. libcitadel/lib/stringbuf.c:5367:36: style:inconclusive: Function 'StrBufReadBLOBBuffered' argument 1 names different: declaration 'Buf' definition 'Blob'. [funcArgNamesDifferent] libcitadel/lib/libcitadel.h:220:36: note: Function 'StrBufReadBLOBBuffered' argument 1 names different: declaration 'Buf' definition 'Blob'. libcitadel/lib/stringbuf.c:5367:36: note: Function 'StrBufReadBLOBBuffered' argument 1 names different: declaration 'Buf' definition 'Blob'. libcitadel/lib/stringbuf.c:5369:20: style:inconclusive: Function 'StrBufReadBLOBBuffered' argument 3 names different: declaration 'BufPos' definition 'Pos'. [funcArgNamesDifferent] libcitadel/lib/libcitadel.h:222:20: note: Function 'StrBufReadBLOBBuffered' argument 3 names different: declaration 'BufPos' definition 'Pos'. libcitadel/lib/stringbuf.c:5369:20: note: Function 'StrBufReadBLOBBuffered' argument 3 names different: declaration 'BufPos' definition 'Pos'. libcitadel/lib/stringbuf.c:4100:8: style: Variable 'm' is assigned a value that is never used. [unreadVariable] libcitadel/lib/stringbuf.c:4131:15: style: Variable 'm' is assigned a value that is never used. [unreadVariable] libcitadel/lib/stringbuf.c:4421:14: style: Variable 'aptr' is assigned a value that is never used. [unreadVariable] libcitadel/lib/stringbuf.c:4423:14: style: Variable 'aptr' is assigned a value that is never used. [unreadVariable] libcitadel/lib/stringbuf.c:4562:10: style: Unused variable: sent [unusedVariable] libcitadel/lib/stringbuf.c:4562:16: style: Unused variable: pipesize [unusedVariable] libcitadel/lib/stringbuf.c:4722:16: style: Unused variable: pipesize [unusedVariable] libcitadel/lib/stringbuf.c:4794:16: style: Unused variable: pipesize [unusedVariable] libcitadel/lib/stringbuf.c:5549:14: style: Variable 'aptr' is assigned a value that is never used. [unreadVariable] libcitadel/lib/stringbuf.c:5551:14: style: Variable 'aptr' is assigned a value that is never used. [unreadVariable] libcitadel/lib/tools.c:647:11: style: Variable 'len' is assigned a value that is never used. [unreadVariable] libcitadel/lib/vcard.c:188:8: warning: Either the condition '(ptr)==NULL' is redundant or there is possible null pointer dereference: ptr. [nullPointerRedundantCheck] libcitadel/lib/vcard.c:185:31: note: Assuming that condition '(ptr)==NULL' is not redundant libcitadel/lib/vcard.c:188:8: note: Null pointer dereference libcitadel/lib/vcard.c:213:38: style:inconclusive: Function 'vcard_get_prop' argument 5 names different: declaration 'return_propname' definition 'get_propname'. [funcArgNamesDifferent] libcitadel/lib/libcitadel.h:494:22: note: Function 'vcard_get_prop' argument 5 names different: declaration 'return_propname' definition 'get_propname'. libcitadel/lib/vcard.c:213:38: note: Function 'vcard_get_prop' argument 5 names different: declaration 'return_propname' definition 'get_propname'. libcitadel/lib/vcard.c:305:14: style: Variable 'is_utf8' is assigned a value that is never used. [unreadVariable] libcitadel/lib/wildfire.c:51:12: style:inconclusive: Function 'WildFireMessage' argument 3 names different: declaration 'lineno' definition 'LineNo'. [funcArgNamesDifferent] libcitadel/lib/libcitadel.h:661:12: note: Function 'WildFireMessage' argument 3 names different: declaration 'lineno' definition 'LineNo'. libcitadel/lib/wildfire.c:51:12: note: Function 'WildFireMessage' argument 3 names different: declaration 'lineno' definition 'LineNo'. libcitadel/lib/vnote.c:164:6: warning: %x in format string (no. 1) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int] libcitadel/lib/vnote.c:164:6: warning: %x in format string (no. 2) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int] libcitadel/lib/vnote.c:164:6: warning: %x in format string (no. 3) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int] libcitadel/lib/xdgmime/test-mime-data.c:130:7: error: Resource leak: file [resourceLeak] libcitadel/lib/xdgmime/xdgmime.c:146:4: error: Common realloc mistake: '_xdg_mime_caches' nulled but not freed upon failure [memleakOnRealloc] libcitadel/lib/xdgmime/xdgmime.c:648:41: style:inconclusive: Function 'xdg_mime_unalias_mime_type' argument 1 names different: declaration 'mime' definition 'mime_type'. [funcArgNamesDifferent] libcitadel/lib/xdgmime/xdgmime.h:98:58: note: Function 'xdg_mime_unalias_mime_type' argument 1 names different: declaration 'mime' definition 'mime_type'. libcitadel/lib/xdgmime/xdgmime.c:648:41: note: Function 'xdg_mime_unalias_mime_type' argument 1 names different: declaration 'mime' definition 'mime_type'. libcitadel/lib/xdgmime/xdgmime.c:763:42: style:inconclusive: Function 'xdg_mime_mime_type_subclass' argument 1 names different: declaration 'mime_a' definition 'mime'. [funcArgNamesDifferent] libcitadel/lib/xdgmime/xdgmime.h:89:65: note: Function 'xdg_mime_mime_type_subclass' argument 1 names different: declaration 'mime_a' definition 'mime'. libcitadel/lib/xdgmime/xdgmime.c:763:42: note: Function 'xdg_mime_mime_type_subclass' argument 1 names different: declaration 'mime_a' definition 'mime'. libcitadel/lib/xdgmime/xdgmime.c:764:21: style:inconclusive: Function 'xdg_mime_mime_type_subclass' argument 2 names different: declaration 'mime_b' definition 'base'. [funcArgNamesDifferent] libcitadel/lib/xdgmime/xdgmime.h:90:23: note: Function 'xdg_mime_mime_type_subclass' argument 2 names different: declaration 'mime_b' definition 'base'. libcitadel/lib/xdgmime/xdgmime.c:764:21: note: Function 'xdg_mime_mime_type_subclass' argument 2 names different: declaration 'mime_b' definition 'base'. libcitadel/lib/xdgmime/xdgmimeglob.c:341:19: style:inconclusive: Function '_xdg_glob_hash_lookup_file_name' argument 2 names different: declaration 'text' definition 'file_name'. [funcArgNamesDifferent] libcitadel/lib/xdgmime/xdgmimeglob.h:58:25: note: Function '_xdg_glob_hash_lookup_file_name' argument 2 names different: declaration 'text' definition 'file_name'. libcitadel/lib/xdgmime/xdgmimeglob.c:341:19: note: Function '_xdg_glob_hash_lookup_file_name' argument 2 names different: declaration 'text' definition 'file_name'. libcitadel/lib/xdgmime/xdgmimecache.c:771:49: style:inconclusive: Function '_xdg_mime_cache_mime_type_subclass' argument 1 names different: declaration 'mime_a' definition 'mime'. [funcArgNamesDifferent] libcitadel/lib/xdgmime/xdgmimecache.h:68:72: note: Function '_xdg_mime_cache_mime_type_subclass' argument 1 names different: declaration 'mime_a' definition 'mime'. libcitadel/lib/xdgmime/xdgmimecache.c:771:49: note: Function '_xdg_mime_cache_mime_type_subclass' argument 1 names different: declaration 'mime_a' definition 'mime'. libcitadel/lib/xdgmime/xdgmimecache.c:772:21: style:inconclusive: Function '_xdg_mime_cache_mime_type_subclass' argument 2 names different: declaration 'mime_b' definition 'base'. [funcArgNamesDifferent] libcitadel/lib/xdgmime/xdgmimecache.h:69:23: note: Function '_xdg_mime_cache_mime_type_subclass' argument 2 names different: declaration 'mime_b' definition 'base'. libcitadel/lib/xdgmime/xdgmimecache.c:772:21: note: Function '_xdg_mime_cache_mime_type_subclass' argument 2 names different: declaration 'mime_b' definition 'base'. libcitadel/lib/xdgmime/xdgmimecache.c:81:11: style: struct member '_XdgMimeCache::size' is never used. [unusedStructMember] libcitadel/lib/xdgmime/xdgmimeint.c:70:22: style: Variable 'bytelength' is assigned a value that is never used. [unreadVariable] libcitadel/lib/xdgmime/xdgmimeparent.c:115:24: error: Uninitialized variable: &key.n_parents [uninitvar] libcitadel/lib/xdgmime/xdgmimemagic.c:683:13: style: Condition 'had_match' is always true [knownConditionTrueFalse] libcitadel/lib/xdgmime/xdgmimemagic.c:188:4: error: Common realloc mistake: 'retval' nulled but not freed upon failure [memleakOnRealloc] libcitadel/lib/xdgmime/xdgmimemagic.c:223:26: style: Variable 'number_string[pos]' is assigned a value that is never used. [unreadVariable] libcitadel/tests/hashlist_test.c:306:8: style: Variable 'pTest' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/hashlist_test.c:305:8: note: pTest is assigned libcitadel/tests/hashlist_test.c:306:8: note: pTest is overwritten libcitadel/tests/hashlist_test.c:307:8: style: Variable 'pTest' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/hashlist_test.c:306:8: note: pTest is assigned libcitadel/tests/hashlist_test.c:307:8: note: pTest is overwritten libcitadel/tests/html_to_ascii_test.c:117:9: style: Variable 'Source' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/html_to_ascii_test.c:113:9: note: Source is assigned libcitadel/tests/html_to_ascii_test.c:117:9: note: Source is overwritten libcitadel/tests/hashlist_test.c:307:8: style: Variable 'pTest' is assigned a value that is never used. [unreadVariable] libcitadel/tests/html_to_ascii_test.c:181:10: style: Variable 'pTest' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/html_to_ascii_test.c:180:10: note: pTest is assigned libcitadel/tests/html_to_ascii_test.c:181:10: note: pTest is overwritten libcitadel/tests/html_to_ascii_test.c:182:10: style: Variable 'pTest' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/html_to_ascii_test.c:181:10: note: pTest is assigned libcitadel/tests/html_to_ascii_test.c:182:10: note: pTest is overwritten libcitadel/tests/html_to_ascii_test.c:183:10: style: Variable 'pTest' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/html_to_ascii_test.c:182:10: note: pTest is assigned libcitadel/tests/html_to_ascii_test.c:183:10: note: pTest is overwritten libcitadel/tests/html_to_ascii_test.c:183:10: style: Variable 'pTest' is assigned a value that is never used. [unreadVariable] libcitadel/tests/html_to_ascii_test.c:186:10: style: Variable 'pTest' is assigned a value that is never used. [unreadVariable] libcitadel/tests/html_to_ascii_test.c:190:10: style: Variable 'pTest' is assigned a value that is never used. [unreadVariable] libcitadel/tests/html_to_ascii_test.c:193:10: style: Variable 'pTest' is assigned a value that is never used. [unreadVariable] libcitadel/tests/mimeparser_test.c:132:9: style: Variable 'rc' is assigned a value that is never used. [unreadVariable] libcitadel/tests/mimeparser_test.c:153:7: style: Variable 'rc' is assigned a value that is never used. [unreadVariable] libcitadel/tests/mimeparser_test.c:156:7: style: Variable 'rc' is assigned a value that is never used. [unreadVariable] libcitadel/tests/stringbuf_conversion.c:271:9: style: Variable 'Source' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/stringbuf_conversion.c:267:9: note: Source is assigned libcitadel/tests/stringbuf_conversion.c:271:9: note: Source is overwritten libcitadel/tests/stringbuf_conversion.c:395:10: style: Variable 'pTest' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/stringbuf_conversion.c:394:10: note: pTest is assigned libcitadel/tests/stringbuf_conversion.c:395:10: note: pTest is overwritten libcitadel/tests/stringbuf_conversion.c:396:10: style: Variable 'pTest' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/stringbuf_conversion.c:395:10: note: pTest is assigned libcitadel/tests/stringbuf_conversion.c:396:10: note: pTest is overwritten libcitadel/tests/stringbuf_conversion.c:397:10: style: Variable 'pTest' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/stringbuf_conversion.c:396:10: note: pTest is assigned libcitadel/tests/stringbuf_conversion.c:397:10: note: pTest is overwritten libcitadel/tests/stringbuf_conversion.c:384:10: style: Variable 'pTest' is assigned a value that is never used. [unreadVariable] libcitadel/tests/stringbuf_conversion.c:387:10: style: Variable 'pTest' is assigned a value that is never used. [unreadVariable] libcitadel/tests/stringbuf_conversion.c:390:10: style: Variable 'pTest' is assigned a value that is never used. [unreadVariable] libcitadel/tests/stringbuf_conversion.c:397:10: style: Variable 'pTest' is assigned a value that is never used. [unreadVariable] libcitadel/tests/stringbuf_conversion.c:402:11: style: Variable 'pTest' is assigned a value that is never used. [unreadVariable] libcitadel/tests/stringbuf_conversion.c:406:16: style: Variable 'pTest' is assigned a value that is never used. [unreadVariable] libcitadel/tests/stringbuf_conversion.c:409:16: style: Variable 'pTest' is assigned a value that is never used. [unreadVariable] libcitadel/tests/stringbuf_conversion.c:412:16: style: Variable 'pTest' is assigned a value that is never used. [unreadVariable] libcitadel/tests/stringbuf_conversion.c:415:16: style: Variable 'pTest' is assigned a value that is never used. [unreadVariable] libcitadel/tests/stringbuf_conversion.c:418:16: style: Variable 'pTest' is assigned a value that is never used. [unreadVariable] libcitadel/tests/stringbuf_conversion.c:421:16: style: Variable 'pTest' is assigned a value that is never used. [unreadVariable] libcitadel/tests/stringbuf_IO_test.c:102:6: portability: Non reentrant function 'getprotobyname' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getprotobyname_r'. [prohibitedgetprotobynameCalled] libcitadel/tests/stringbuf_IO_test.c:122:3: error: Resource leak: s [resourceLeak] libcitadel/tests/stringbuf_IO_test.c:126:3: error: Resource leak: s [resourceLeak] libcitadel/tests/stringbuf_IO_test.c:292:6: style: Local variable 'blobsize' shadows outer variable [shadowVariable] libcitadel/tests/stringbuf_IO_test.c:59:5: note: Shadowed declaration libcitadel/tests/stringbuf_IO_test.c:292:6: note: Shadow variable libcitadel/tests/stringbuf_IO_test.c:414:9: style: Variable 'pTest' is assigned a value that is never used. [unreadVariable] libcitadel/tests/stringbuf_IO_test.c:416:9: style: Variable 'pTest' is assigned a value that is never used. [unreadVariable] libcitadel/tests/stringbuf_IO_test.c:418:9: style: Variable 'pTest' is assigned a value that is never used. [unreadVariable] libcitadel/tests/stringbuf_stream.c:119:10: style: Variable 'err' is assigned a value that is never used. [unreadVariable] libcitadel/tests/stringbuf_test.c:135:6: style: Variable 'len' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/stringbuf_test.c:118:6: note: len is assigned libcitadel/tests/stringbuf_test.c:135:6: note: len is overwritten libcitadel/tests/stringbuf_test.c:592:8: style: Variable 'pTest' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/stringbuf_test.c:591:8: note: pTest is assigned libcitadel/tests/stringbuf_test.c:592:8: note: pTest is overwritten libcitadel/tests/stringbuf_test.c:593:8: style: Variable 'pTest' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/stringbuf_test.c:592:8: note: pTest is assigned libcitadel/tests/stringbuf_test.c:593:8: note: pTest is overwritten libcitadel/tests/stringbuf_test.c:594:8: style: Variable 'pTest' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/stringbuf_test.c:593:8: note: pTest is assigned libcitadel/tests/stringbuf_test.c:594:8: note: pTest is overwritten libcitadel/tests/stringbuf_test.c:598:8: style: Variable 'pTest' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/stringbuf_test.c:594:8: note: pTest is assigned libcitadel/tests/stringbuf_test.c:598:8: note: pTest is overwritten libcitadel/tests/stringbuf_test.c:599:8: style: Variable 'pTest' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/stringbuf_test.c:598:8: note: pTest is assigned libcitadel/tests/stringbuf_test.c:599:8: note: pTest is overwritten libcitadel/tests/stringbuf_test.c:600:8: style: Variable 'pTest' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/stringbuf_test.c:599:8: note: pTest is assigned libcitadel/tests/stringbuf_test.c:600:8: note: pTest is overwritten libcitadel/tests/stringbuf_test.c:601:8: style: Variable 'pTest' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/stringbuf_test.c:600:8: note: pTest is assigned libcitadel/tests/stringbuf_test.c:601:8: note: pTest is overwritten libcitadel/tests/stringbuf_test.c:602:8: style: Variable 'pTest' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/stringbuf_test.c:601:8: note: pTest is assigned libcitadel/tests/stringbuf_test.c:602:8: note: pTest is overwritten libcitadel/tests/stringbuf_test.c:603:8: style: Variable 'pTest' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/stringbuf_test.c:602:8: note: pTest is assigned libcitadel/tests/stringbuf_test.c:603:8: note: pTest is overwritten libcitadel/tests/stringbuf_test.c:604:8: style: Variable 'pTest' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/stringbuf_test.c:603:8: note: pTest is assigned libcitadel/tests/stringbuf_test.c:604:8: note: pTest is overwritten libcitadel/tests/stringbuf_test.c:608:8: style: Variable 'pTest' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/stringbuf_test.c:604:8: note: pTest is assigned libcitadel/tests/stringbuf_test.c:608:8: note: pTest is overwritten libcitadel/tests/stringbuf_test.c:609:8: style: Variable 'pTest' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/stringbuf_test.c:608:8: note: pTest is assigned libcitadel/tests/stringbuf_test.c:609:8: note: pTest is overwritten libcitadel/tests/stringbuf_test.c:610:8: style: Variable 'pTest' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/stringbuf_test.c:609:8: note: pTest is assigned libcitadel/tests/stringbuf_test.c:610:8: note: pTest is overwritten libcitadel/tests/stringbuf_test.c:611:8: style: Variable 'pTest' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/stringbuf_test.c:610:8: note: pTest is assigned libcitadel/tests/stringbuf_test.c:611:8: note: pTest is overwritten libcitadel/tests/stringbuf_test.c:612:9: style: Variable 'pTest' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/stringbuf_test.c:611:8: note: pTest is assigned libcitadel/tests/stringbuf_test.c:612:9: note: pTest is overwritten libcitadel/tests/stringbuf_test.c:615:8: style: Variable 'pTest' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/stringbuf_test.c:612:9: note: pTest is assigned libcitadel/tests/stringbuf_test.c:615:8: note: pTest is overwritten libcitadel/tests/stringbuf_test.c:618:8: style: Variable 'pTest' is reassigned a value before the old one has been used. [redundantAssignment] libcitadel/tests/stringbuf_test.c:615:8: note: pTest is assigned libcitadel/tests/stringbuf_test.c:618:8: note: pTest is overwritten libcitadel/tests/stringbuf_test.c:429:8: style: Variable 'n' is assigned a value that is never used. [unreadVariable] libcitadel/tests/stringbuf_test.c:445:6: style: Variable 'n' is assigned a value that is never used. [unreadVariable] libcitadel/tests/stringbuf_test.c:618:8: style: Variable 'pTest' is assigned a value that is never used. [unreadVariable] libcitadel/tests/stringbuf_test.c:628:14: style: Variable 'Run' is assigned a value that is never used. [unreadVariable] libcitadel/tests/stripallbut_test.c:100:5: style: Variable 'l' is assigned a value that is never used. [unreadVariable] libcitadel/tests/stripallbut_test.c:124:8: style: Variable 'pTest' is assigned a value that is never used. [unreadVariable] libcitadel/tests/token_test.c:14:8: style: Variable 'i' is assigned a value that is never used. [unreadVariable] libcitadel/tests/token_test.c:10:10: style: Unused variable: lostr [unusedVariable] libcitadel/tests/token_test.c:11:10: style: Unused variable: histr [unusedVariable] diff: head libcitadel/lib/mime_parser.c:397:16: style: Parameter 'content_end' can be declared as pointer to const [constParameter] 2.8 libcitadel/lib/mime_parser.c:397:16: style: Parameter 'content_end' can be declared with const [constParameter] DONE