2025-11-18 00:53
ftp://ftp.de.debian.org/debian/pool/main/k/knavalbattle/knavalbattle_25.04.0.orig.tar.xz
cppcheck-options: --library=posix --library=gnu --library=bsd --library=qt --library=kde  --inconclusive --enable=style,information --inline-suppr --template=daca2 --disable=missingInclude --suppress=unmatchedSuppression --check-library --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=normalCheckLevelConditionExpressions -D__GNUC__ --platform=unix64 -j90
platform: Linux-6.8.0-87-generic-x86_64-with-glibc2.39
python: 3.12.3
client-version: 1.3.69
compiler: g++ (Ubuntu 13.3.0-6ubuntu2~24.04) 13.3.0
cppcheck: head 2.18.0
head-info: d8b6e08 (2025-11-17 23:40:03 +0100)
count: 121 121
elapsed-time: 0.1 0.1
head-timing-info:

old-timing-info:

head results:
knavalbattle-25.04.0/src/ai/dummyai.cpp:21:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PLAYING [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/ai/ai.cpp:20:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable x [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/ai/ai.cpp:42:62: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable x [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/element.cpp:25:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ALIVE [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/settings.cpp:16:37: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FullName [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/hitinfo.h:27:5: style: Struct 'HitInfo' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
knavalbattle-25.04.0/src/element.h:29:5: style: Class 'Element' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
knavalbattle-25.04.0/src/kbsrenderer.cpp:36:16: style: The statement 'if (m_size!=sz) m_size=sz' is logically equivalent to 'm_size=sz'. [duplicateConditionalAssign]
knavalbattle-25.04.0/src/kbsrenderer.cpp:37:16: note: Assignment 'm_size=sz'
knavalbattle-25.04.0/src/kbsrenderer.cpp:36:16: note: Condition 'm_size!=sz' is redundant
knavalbattle-25.04.0/src/kbsrenderer.cpp:54:42: style:inconclusive: Function 'toReal' argument 1 names different: declaration 'p' definition 'c'. [funcArgNamesDifferent]
knavalbattle-25.04.0/src/kbsrenderer.h:39:33: note: Function 'toReal' argument 1 names different: declaration 'p' definition 'c'.
knavalbattle-25.04.0/src/kbsrenderer.cpp:54:42: note: Function 'toReal' argument 1 names different: declaration 'p' definition 'c'.
knavalbattle-25.04.0/src/ai/smartai.cpp:100:81: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DEAD [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/ai/smartai.cpp:122:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable HIT [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/audioplayer.cpp:48:129: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LocateDirectory [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/ai/smartai.cpp:150:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable x [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/sprite.cpp:29:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable green [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/ai/smartai.cpp:160:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable HIT [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/sprite.cpp:36:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable red [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/ai/smartai.cpp:180:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable x [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/ai/smartai.cpp:194:50: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable y [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/ai/smartai.cpp:227:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KNAVALBATTLE_LOG [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/ai/smartai.cpp:258:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KNAVALBATTLE_LOG [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/ai/smartai.cpp:274:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable HIT [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/ai/smartai.cpp:296:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PLAYING [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/main.cpp:31:9: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KNAVALBATTLE_VERSION_STRING [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/animation.h:39:18: style: Virtual function 'stop' is called from destructor '~AnimationGroup()' at line 21. Dynamic binding is not used. [virtualCallInConstructor]
knavalbattle-25.04.0/src/animation.cpp:21:5: note: Calling stop
knavalbattle-25.04.0/src/animation.h:39:18: note: stop is a virtual function
knavalbattle-25.04.0/src/ships.h:27:20: performance: Function 'shipsName()' should return member 'm_shipsName' by const reference. [returnByReference]
knavalbattle-25.04.0/src/ships.h:28:20: performance: Function 'pluralShipsName()' should return member 'm_shipsPluralName' by const reference. [returnByReference]
knavalbattle-25.04.0/src/statswidget.cpp:34:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Antialiasing [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/button.cpp:73:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Antialiasing [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/button.cpp:138:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BRIGHTNESS_NORMAL [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/button.cpp:175:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable BRIGHTNESS_NORMAL [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/button.cpp:192:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KNAVALBATTLE_LOG [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/spritefactory.cpp:18:41: style: Parameter 'ship' can be declared as pointer to const [constParameterPointer]
knavalbattle-25.04.0/src/chatwidget.cpp:32:54: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Maximum [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/chatwidget.cpp:56:52: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KeyPress [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/entity.h:58:13: performance: Function 'nick()' should return member 'm_nick' by const reference. [returnByReference]
knavalbattle-25.04.0/src/networkdialog.cpp:34:74: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Ok [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/networkdialog.cpp:174:84: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ServicePtrRole [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/mainwindow.cpp:33:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Hard [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/mainwindow.cpp:62:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable triggered [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/mainwindow.cpp:115:60: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable StateReverse [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/entity.cpp:23:37: style:inconclusive: Function 'setNick' argument 1 names different: declaration 'nick' definition 'nickname'. [funcArgNamesDifferent]
knavalbattle-25.04.0/src/entity.h:61:41: note: Function 'setNick' argument 1 names different: declaration 'nick' definition 'nickname'.
knavalbattle-25.04.0/src/entity.cpp:23:37: note: Function 'setNick' argument 1 names different: declaration 'nick' definition 'nickname'.
knavalbattle-25.04.0/src/grid.h:43:5: warning: Class 'Grid' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor]
knavalbattle-25.04.0/src/grid.h:43:5: warning: Class 'Grid' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq]
knavalbattle-25.04.0/src/grid.h:26:5: style: Class 'Grid' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
knavalbattle-25.04.0/src/sea.cpp:32:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PLACING_SHIPS [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/sea.cpp:40:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PLACING_SHIPS [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/sea.cpp:48:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PLACING_SHIPS [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/sea.cpp:110:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PLAYER_A [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/sea.cpp:146:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PLAYER_A [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/sea.cpp:151:5: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PLACING_SHIPS [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/sea.cpp:157:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PLAYER_A [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/ai/smartai.cpp:310:73: style:inconclusive: Function 'notify' argument 3 names different: declaration 'hit' definition 'info'. [funcArgNamesDifferent]
knavalbattle-25.04.0/src/ai/smartai.h:38:68: note: Function 'notify' argument 3 names different: declaration 'hit' definition 'info'.
knavalbattle-25.04.0/src/ai/smartai.cpp:310:73: note: Function 'notify' argument 3 names different: declaration 'hit' definition 'info'.
knavalbattle-25.04.0/src/message.cpp:70:55: style:inconclusive: Function 'NotificationMessage' argument 1 names different: declaration 'm_move' definition 'move'. [funcArgNamesDifferent]
knavalbattle-25.04.0/src/message.h:100:38: note: Function 'NotificationMessage' argument 1 names different: declaration 'm_move' definition 'move'.
knavalbattle-25.04.0/src/message.cpp:70:55: note: Function 'NotificationMessage' argument 1 names different: declaration 'm_move' definition 'move'.
knavalbattle-25.04.0/src/message.cpp:86:41: style:inconclusive: Function 'ChatMessage' argument 1 names different: declaration 'nick' definition 'nickname'. [funcArgNamesDifferent]
knavalbattle-25.04.0/src/message.h:155:41: note: Function 'ChatMessage' argument 1 names different: declaration 'nick' definition 'nickname'.
knavalbattle-25.04.0/src/message.cpp:86:41: note: Function 'ChatMessage' argument 1 names different: declaration 'nick' definition 'nickname'.
knavalbattle-25.04.0/src/welcomescreen.cpp:46:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable x [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/welcomescreen.cpp:149:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KNAVALBATTLE_LOG [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/chatwidget.cpp:57:24: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast]
knavalbattle-25.04.0/src/chatwidget.cpp:54:52: style:inconclusive: Function 'eventFilter' argument 2 names different: declaration 'e' definition 'event'. [funcArgNamesDifferent]
knavalbattle-25.04.0/src/chatwidget.h:39:40: note: Function 'eventFilter' argument 2 names different: declaration 'e' definition 'event'.
knavalbattle-25.04.0/src/chatwidget.cpp:54:52: note: Function 'eventFilter' argument 2 names different: declaration 'e' definition 'event'.
knavalbattle-25.04.0/src/chatwidget.cpp:82:62: style:inconclusive: Function 'display' argument 2 names different: declaration 'message' definition 'text'. [funcArgNamesDifferent]
knavalbattle-25.04.0/src/chatwidget.h:36:54: note: Function 'display' argument 2 names different: declaration 'message' definition 'text'.
knavalbattle-25.04.0/src/chatwidget.cpp:82:62: note: Function 'display' argument 2 names different: declaration 'message' definition 'text'.
knavalbattle-25.04.0/src/chatwidget.cpp:87:41: style:inconclusive: Function 'display' argument 1 names different: declaration 'message' definition 'text'. [funcArgNamesDifferent]
knavalbattle-25.04.0/src/chatwidget.h:37:33: note: Function 'display' argument 1 names different: declaration 'message' definition 'text'.
knavalbattle-25.04.0/src/chatwidget.cpp:87:41: note: Function 'display' argument 1 names different: declaration 'message' definition 'text'.
knavalbattle-25.04.0/src/playerentity.cpp:41:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable COMPAT_KBS3 [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/playerentity.cpp:192:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KNAVALBATTLE_LOG [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/grid.h:43:5: warning: Class 'Grid < Element >' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor]
knavalbattle-25.04.0/src/grid.h:43:5: warning: Class 'Grid < Element >' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq]
knavalbattle-25.04.0/src/grid.h:43:5: warning: Class 'Grid < bool >' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor]
knavalbattle-25.04.0/src/grid.h:43:5: warning: Class 'Grid < bool >' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq]
knavalbattle-25.04.0/src/ships.cpp:52:69: style: Parameter 'ships' can be declared as reference to const [constParameterReference]
knavalbattle-25.04.0/src/grid.h:26:5: style: Class 'Grid < Element >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
knavalbattle-25.04.0/src/grid.h:26:5: style: Class 'Grid < bool >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
knavalbattle-25.04.0/src/sea.h:71:25: performance: Function 'enemyShips()' should return member 'm_enemyShips' by const reference. [returnByReference]
knavalbattle-25.04.0/src/sea.h:72:25: performance: Function 'myShips()' should return member 'm_myShips' by const reference. [returnByReference]
knavalbattle-25.04.0/src/ships.cpp:96:9: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm]
knavalbattle-25.04.0/src/ships.cpp:108:13: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm]
knavalbattle-25.04.0/src/sea.cpp:109:31: style: Checking if unsigned expression 'otherField()->ships()' is less than zero. [unsignedLessThanZero]
knavalbattle-25.04.0/src/sea.cpp:124:57: style:inconclusive: Function 'at' argument 2 names different: declaration 'pos' definition 'c'. [funcArgNamesDifferent]
knavalbattle-25.04.0/src/sea.h:63:56: note: Function 'at' argument 2 names different: declaration 'pos' definition 'c'.
knavalbattle-25.04.0/src/sea.cpp:124:57: note: Function 'at' argument 2 names different: declaration 'pos' definition 'c'.
knavalbattle-25.04.0/src/sea.cpp:90:14: style: Variable 'e' can be declared as reference to const [constVariableReference]
knavalbattle-25.04.0/src/battlefieldview.cpp:63:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ScrollBarAlwaysOff [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/battlefieldview.cpp:310:64: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LeftButton [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/networkdialog.cpp:100:19: style: Local variable 'port' shadows outer function [shadowFunction]
knavalbattle-25.04.0/src/networkdialog.h:36:9: note: Shadowed declaration
knavalbattle-25.04.0/src/networkdialog.cpp:100:19: note: Shadow variable
knavalbattle-25.04.0/src/welcomescreen.cpp:81:21: style: Variable 'other' can be declared as pointer to const [constVariablePointer]
knavalbattle-25.04.0/src/controller.cpp:35:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KNAVALBATTLE_LOG [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/controller.cpp:47:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KNAVALBATTLE_LOG [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/controller.cpp:72:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable QueuedConnection [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/controller.cpp:116:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KNAVALBATTLE_LOG [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/controller.cpp:178:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KNAVALBATTLE_LOG [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/controller.cpp:215:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KNAVALBATTLE_LOG [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/controller.cpp:305:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KNAVALBATTLE_LOG [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/controller.cpp:314:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KNAVALBATTLE_LOG [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/playerentity.cpp:197:59: style:inconclusive: Function 'notifyNick' argument 2 names different: declaration 'text' definition 'nickname'. [funcArgNamesDifferent]
knavalbattle-25.04.0/src/playerentity.h:37:56: note: Function 'notifyNick' argument 2 names different: declaration 'text' definition 'nickname'.
knavalbattle-25.04.0/src/playerentity.cpp:197:59: note: Function 'notifyNick' argument 2 names different: declaration 'text' definition 'nickname'.
knavalbattle-25.04.0/src/playerentity.cpp:166:12: style: Variable 'next' can be declared as pointer to const [constVariablePointer]
knavalbattle-25.04.0/src/networkentity.cpp:161:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable COMPAT_KBS3 [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/protocol.cpp:34:88: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MSGTYPE [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/protocol.cpp:163:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KNAVALBATTLE_LOG [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/protocol.cpp:320:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KNAVALBATTLE_LOG [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/battlefieldview.cpp:20:18: warning: Member variable 'BattleFieldView::m_player' is not initialized in the constructor. [uninitMemberVar]
knavalbattle-25.04.0/src/battlefieldview.cpp:20:18: warning: Member variable 'BattleFieldView::m_status' is not initialized in the constructor. [uninitMemberVar]
knavalbattle-25.04.0/src/playfield.cpp:143:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Name [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/playfield.cpp:163:43: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Name [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/playfield.cpp:242:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PrimaryAction [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/playfield.cpp:310:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PrimaryAction [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/playfield.cpp:336:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KNAVALBATTLE_LOG [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/battlefieldview.cpp:81:13: style: Same expression used in consecutive assignments of 'width' and 'height'. [duplicateAssignExpression]
knavalbattle-25.04.0/src/battlefieldview.cpp:82:13: note: Same expression used in consecutive assignments of 'width' and 'height'.
knavalbattle-25.04.0/src/battlefieldview.cpp:81:13: note: Same expression used in consecutive assignments of 'width' and 'height'.
knavalbattle-25.04.0/src/battlefieldview.cpp:190:57: style:inconclusive: Function 'addSprite' argument 2 names different: declaration 'ship' definition 'sprite'. [funcArgNamesDifferent]
knavalbattle-25.04.0/src/battlefieldview.h:74:44: note: Function 'addSprite' argument 2 names different: declaration 'ship' definition 'sprite'.
knavalbattle-25.04.0/src/battlefieldview.cpp:190:57: note: Function 'addSprite' argument 2 names different: declaration 'ship' definition 'sprite'.
knavalbattle-25.04.0/src/seaview.cpp:138:14: style: Variable 'item' can be declared as pointer to const [constVariablePointer]
knavalbattle-25.04.0/src/battlefield.cpp:277:43: style:inconclusive: Function 'isNearShip' argument 1 names different: declaration 'c' definition 'pos'. [funcArgNamesDifferent]
knavalbattle-25.04.0/src/battlefield.h:54:34: note: Function 'isNearShip' argument 1 names different: declaration 'c' definition 'pos'.
knavalbattle-25.04.0/src/battlefield.cpp:277:43: note: Function 'isNearShip' argument 1 names different: declaration 'c' definition 'pos'.
knavalbattle-25.04.0/src/battlefield.cpp:79:11: style: Variable 'ship' can be declared as pointer to const [constVariablePointer]
knavalbattle-25.04.0/src/simplemenu.cpp:88:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Accepted [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/simplemenu.cpp:100:36: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Accepted [valueFlowBailoutIncompleteVar]
knavalbattle-25.04.0/src/controller.cpp:19:99: style:inconclusive: Function 'Controller' argument 3 names different: declaration 'battleConfiguration' definition 'battleShipsConfiguration'. [funcArgNamesDifferent]
knavalbattle-25.04.0/src/controller.h:45:110: note: Function 'Controller' argument 3 names different: declaration 'battleConfiguration' definition 'battleShipsConfiguration'.
knavalbattle-25.04.0/src/controller.cpp:19:99: note: Function 'Controller' argument 3 names different: declaration 'battleConfiguration' definition 'battleShipsConfiguration'.
knavalbattle-25.04.0/src/controller.cpp:114:18: style: Variable 'entity' can be declared as pointer to const [constVariablePointer]
knavalbattle-25.04.0/src/controller.cpp:139:18: style: Variable 'source' can be declared as pointer to const [constVariablePointer]
knavalbattle-25.04.0/src/controller.cpp:300:13: style: Variable 'chat_sender' can be declared as pointer to const [constVariablePointer]
knavalbattle-25.04.0/src/controller.cpp:290:41: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm]
knavalbattle-25.04.0/src/networkentity.cpp:19:88: style:inconclusive: Function 'NetworkEntity' argument 4 names different: declaration 'device' definition 'protocol'. [funcArgNamesDifferent]
knavalbattle-25.04.0/src/networkentity.h:27:77: note: Function 'NetworkEntity' argument 4 names different: declaration 'device' definition 'protocol'.
knavalbattle-25.04.0/src/networkentity.cpp:19:88: note: Function 'NetworkEntity' argument 4 names different: declaration 'device' definition 'protocol'.
knavalbattle-25.04.0/src/networkentity.cpp:44:45: style:inconclusive: Function 'notifyShips' argument 1 names different: declaration 'winner' definition 'player'. [funcArgNamesDifferent]
knavalbattle-25.04.0/src/networkentity.h:37:34: note: Function 'notifyShips' argument 1 names different: declaration 'winner' definition 'player'.
knavalbattle-25.04.0/src/networkentity.cpp:44:45: note: Function 'notifyShips' argument 1 names different: declaration 'winner' definition 'player'.
knavalbattle-25.04.0/src/networkentity.cpp:101:14: style: Local variable 'hit' shadows outer function [shadowFunction]
knavalbattle-25.04.0/src/networkentity.h:40:10: note: Shadowed declaration
knavalbattle-25.04.0/src/networkentity.cpp:101:14: note: Shadow variable
knavalbattle-25.04.0/src/networkentity.cpp:51:20: style: Variable 'ship' can be declared as pointer to const [constVariablePointer]
knavalbattle-25.04.0/src/simplemenu.cpp:75:9: warning: Either the condition 'dialog' is redundant or there is possible null pointer dereference: dialog. [nullPointerRedundantCheck]
knavalbattle-25.04.0/src/simplemenu.cpp:76:13: note: Assuming that condition 'dialog' is not redundant
knavalbattle-25.04.0/src/simplemenu.cpp:75:9: note: Null pointer dereference
knavalbattle-25.04.0/src/simplemenu.cpp:88:9: warning: Either the condition 'dialog' is redundant or there is possible null pointer dereference: dialog. [nullPointerRedundantCheck]
knavalbattle-25.04.0/src/simplemenu.cpp:89:13: note: Assuming that condition 'dialog' is not redundant
knavalbattle-25.04.0/src/simplemenu.cpp:88:9: note: Null pointer dereference
knavalbattle-25.04.0/src/simplemenu.cpp:100:9: warning: Either the condition 'dialog' is redundant or there is possible null pointer dereference: dialog. [nullPointerRedundantCheck]
knavalbattle-25.04.0/src/simplemenu.cpp:101:13: note: Assuming that condition 'dialog' is not redundant
knavalbattle-25.04.0/src/simplemenu.cpp:100:9: note: Null pointer dereference
knavalbattle-25.04.0/src/simplemenu.cpp:51:55: style:inconclusive: Function 'finalize' argument 2 names different: declaration 'nick' definition 'nickname'. [funcArgNamesDifferent]
knavalbattle-25.04.0/src/simplemenu.h:45:41: note: Function 'finalize' argument 2 names different: declaration 'nick' definition 'nickname'.
knavalbattle-25.04.0/src/simplemenu.cpp:51:55: note: Function 'finalize' argument 2 names different: declaration 'nick' definition 'nickname'.
diff:
2.18.0 knavalbattle-25.04.0/src/grid.h:43:5: warning: Class 'Grid < Element >' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor]
head knavalbattle-25.04.0/src/grid.h:43:5: warning: Class 'Grid < Element >' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor]
2.18.0 knavalbattle-25.04.0/src/grid.h:43:5: warning: Class 'Grid < Element >' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq]
head knavalbattle-25.04.0/src/grid.h:43:5: warning: Class 'Grid < Element >' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq]
2.18.0 knavalbattle-25.04.0/src/grid.h:43:5: warning: Class 'Grid < bool >' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor]
head knavalbattle-25.04.0/src/grid.h:43:5: warning: Class 'Grid < bool >' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor]
2.18.0 knavalbattle-25.04.0/src/grid.h:43:5: warning: Class 'Grid < bool >' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq]
head knavalbattle-25.04.0/src/grid.h:43:5: warning: Class 'Grid < bool >' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq]
2.18.0 knavalbattle-25.04.0/src/grid.h:43:5: warning: Class 'Grid' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor]
head knavalbattle-25.04.0/src/grid.h:43:5: warning: Class 'Grid' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor]
2.18.0 knavalbattle-25.04.0/src/grid.h:43:5: warning: Class 'Grid' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq]
head knavalbattle-25.04.0/src/grid.h:43:5: warning: Class 'Grid' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq]


DONE