2026-05-02 19:16
ftp://ftp.de.debian.org/debian/pool/main/k/kf6-kdesu/kf6-kdesu_6.23.0.orig.tar.xz
cppcheck-options: --library=posix --library=gnu --library=bsd --library=qt --library=kde --library=motif  --inconclusive --enable=style,information --inline-suppr --template=daca2 --disable=missingInclude --suppress=unmatchedSuppression --check-library --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=normalCheckLevelConditionExpressions -D__GNUC__ --platform=unix64 -j1
platform: Linux-6.8.0-111-generic-x86_64-with-glibc2.39
python: 3.12.3
client-version: 1.3.70
compiler: g++ (Ubuntu 14.2.0-4ubuntu2~24.04.1) 14.2.0
cppcheck: head 2.20.0
head-info: e5c4a73 (2026-05-01 11:10:43 +0200)
count: 99 98
elapsed-time: 0.7 0.6
head-timing-info:

old-timing-info:

head results:
kdesu-6.23.0/autotests/kdesutest.cpp:37:56: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CMAKE_RUNTIME_OUTPUT_DIRECTORY [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/autotests/kdesutest.cpp:44:75: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CMAKE_HOME_DIRECTORY [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/autotests/kdesutest.cpp:55:75: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CMAKE_HOME_DIRECTORY [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/autotests/kdesutest.cpp:66:75: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CMAKE_HOME_DIRECTORY [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/autotests/kdesutest.cpp:77:75: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CMAKE_HOME_DIRECTORY [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/autotests/kdesutest.cpp:88:73: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CMAKE_HOME_DIRECTORY [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/autotests/kdesutest.cpp:99:73: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CMAKE_HOME_DIRECTORY [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/client.cpp:66:8: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sock [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/client.cpp:72:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sockfd [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/client.cpp:79:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sockfd [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/client.cpp:183:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable sockfd [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/client.cpp:385:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KDE_INSTALL_FULL_LIBEXECDIR_KF [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/client.cpp:398:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable daemon [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/client.cpp:97:64: error: Null pointer dereference: (struct sockaddr_un*)0 [nullPointer]
kdesu-6.23.0/src/client.cpp:97:38: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast]
kdesu-6.23.0/src/client.cpp:306:9: style: The scope of the variable 'index' can be reduced. [variableScope]
kdesu-6.23.0/src/client.cpp:307:9: style: The scope of the variable 'pos' can be reduced. [variableScope]
kdesu-6.23.0/src/kcookie.cpp:72:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KSU_LOG [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/kdesu_stub.c:207:16: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stdout [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/kdesu_stub.c:256:10: portability: Non reentrant function 'getpwnam' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getpwnam_r'. [prohibitedgetpwnamCalled]
kdesu-6.23.0/src/kdesu_stub.c:128:21: style: Parameter 'src' can be declared as pointer to const [constParameterPointer]
kdesu-6.23.0/src/kdesu_stub.c:198:20: style: Variable 'pw' can be declared as pointer to const [constVariablePointer]
kdesu-6.23.0/src/kdesud/autotests/kdesudtest.cpp:20:10: style: Either there is a missing 'override', or the member function 'KDESu::KdeSudTest::initTestCase' can be static. [functionStatic]
kdesu-6.23.0/src/kdesud/autotests/kdesudtest.cpp:25:16: style:inconclusive: Either there is a missing 'override', or the member function 'KDESu::KdeSudTest::escape' can be const. [functionConst]
kdesu-6.23.0/src/kdesud/lexer.h:19:5: style: Class 'Lexer' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
kdesu-6.23.0/src/kdesud/handler.cpp:44:30: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SchedNormal [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/kdesud/handler.cpp:67:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable errno [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/kdesud/handler.cpp:158:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KSUD_LOG [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/kdesud/handler.cpp:35:20: warning: Member variable 'ConnectionHandler::m_Timeout' is not initialized in the constructor. [uninitMemberVar]
kdesu-6.23.0/src/kdesud/handler.cpp:104:31: style: The member function 'ConnectionHandler::makeKey' can be static. [functionStatic]
kdesu-6.23.0/src/kdesud/handler.h:45:16: note: The member function 'ConnectionHandler::makeKey' can be static.
kdesu-6.23.0/src/kdesud/handler.cpp:104:31: note: The member function 'ConnectionHandler::makeKey' can be static.
kdesu-6.23.0/src/kdesud/handler.h:25:5: style: Class 'ConnectionHandler' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
kdesu-6.23.0/src/kdesud/handler.cpp:60:9: style: The scope of the variable 'ret' can be reduced. [variableScope]
kdesu-6.23.0/src/kdesud/handler.cpp:104:43: style:inconclusive: Function 'makeKey' argument 1 names different: declaration 'namspace' definition '_namespace'. [funcArgNamesDifferent]
kdesu-6.23.0/src/kdesud/handler.h:45:28: note: Function 'makeKey' argument 1 names different: declaration 'namspace' definition '_namespace'.
kdesu-6.23.0/src/kdesud/handler.cpp:104:43: note: Function 'makeKey' argument 1 names different: declaration 'namspace' definition '_namespace'.
kdesu-6.23.0/src/kdesud/handler.cpp:155:45: performance: Function parameter 'buf' should be passed by const reference. [passedByValue]
kdesu-6.23.0/src/kdesud/kdesud.cpp:126:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KSUD_LOG [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/kdesud/kdesud.cpp:207:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KSUD_LOG [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/kdesud/kdesud.cpp:230:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KSUD_LOG [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/kdesud/kdesud.cpp:344:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KSUD_LOG [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/kdesud/kdesud.cpp:418:5: warning: Return value of function pipe2() is not used. [ignoredReturnValue]
kdesu-6.23.0/src/kdesud/kdesud.cpp:269:9: style: Struct 'fd_ScopeGuard' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
kdesu-6.23.0/src/kdesud/kdesud.cpp:334:14: style: Return value 'r==0' is always false [knownConditionTrueFalse]
kdesu-6.23.0/src/kdesud/kdesud.cpp:322:14: note: Assignment 'r=-1', assigned value is -1
kdesu-6.23.0/src/kdesud/kdesud.cpp:334:14: note: Return value 'r==0' is always false
kdesu-6.23.0/src/kdesud/kdesud.cpp:343:9: style: Condition '!prevent_tracing()' is always true [knownConditionTrueFalse]
kdesu-6.23.0/src/kdesud/kdesud.cpp:322:14: note: Assignment 'r=-1', assigned value is -1
kdesu-6.23.0/src/kdesud/kdesud.cpp:343:25: note: Calling function 'prevent_tracing' returns 0
kdesu-6.23.0/src/kdesud/kdesud.cpp:343:9: note: Condition '!prevent_tracing()' is always true
kdesu-6.23.0/src/kdesud/kdesud.cpp:293:22: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast]
kdesu-6.23.0/src/kdesud/kdesud.cpp:300:51: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast]
kdesu-6.23.0/src/kdesud/kdesud.cpp:306:54: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast]
kdesu-6.23.0/src/kdesud/kdesud.cpp:311:54: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast]
kdesu-6.23.0/src/kdesud/kdesud.cpp:512:37: warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast]
kdesu-6.23.0/src/kdesud/kdesud.cpp:205:22: style:inconclusive: Function 'signal_exit' argument 1 names different: declaration '<unnamed>' definition 'sig'. [funcArgNamesDifferentUnnamed]
kdesu-6.23.0/src/kdesud/kdesud.cpp:136:27: style: Variable 'dirEnt' can be declared as pointer to const [constVariablePointer]
kdesu-6.23.0/src/kdesud/lexer.cpp:16:5: performance: Variable 'm_Input' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList]
kdesu-6.23.0/src/kdesud/repo.cpp:62:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable group [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/kdesud/repo.cpp:81:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable group [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/kdesud/repo.cpp:99:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable group [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/kdesud/repo.cpp:111:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KSUD_LOG [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/kdesud/repo.cpp:148:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable value [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/kdesud/repo.cpp:163:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable timeout [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/kdesud/repo.cpp:112:13: style: The scope of the variable 'pos' can be reduced. [variableScope]
kdesu-6.23.0/src/kdesud/repo.cpp:158:14: style: The scope of the variable 't' can be reduced. [variableScope]
kdesu-6.23.0/src/kdesud/secure.cpp:99:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KSUD_LOG [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/kdesud/secure.cpp:91:36: style:inconclusive: Function 'SocketSecurity' argument 1 names different: declaration 'fd' definition 'sockfd'. [funcArgNamesDifferent]
kdesu-6.23.0/src/kdesud/secure.h:22:33: note: Function 'SocketSecurity' argument 1 names different: declaration 'fd' definition 'sockfd'.
kdesu-6.23.0/src/kdesud/secure.cpp:91:36: note: Function 'SocketSecurity' argument 1 names different: declaration 'fd' definition 'sockfd'.
kdesu-6.23.0/src/ptyprocess.cpp:97:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WNOHANG [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/ptyprocess.cpp:136:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KSU_LOG [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/ptyprocess.cpp:188:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable F_GETFL [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/ptyprocess.cpp:293:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KSU_LOG [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/ptyprocess.cpp:375:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KSU_LOG [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/ptyprocess.cpp:441:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable errno [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/ptyprocess.cpp:505:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NSIG [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/ptyprocess.cpp:385:13: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled]
kdesu-6.23.0/src/ptyprocess.cpp:115:13: warning: Member variable 'PtyProcess::m_pid' is not initialized in the constructor. [uninitMemberVar]
kdesu-6.23.0/src/ptyprocess.cpp:120:13: warning: Member variable 'PtyProcess::m_pid' is not initialized in the constructor. [uninitMemberVar]
kdesu-6.23.0/src/ptyprocess.cpp:251:18: style:inconclusive: Technically the member function 'KDESu::PtyProcess::writeLine' can be const. [functionConst]
kdesu-6.23.0/src/ptyprocess.h:102:10: note: Technically the member function 'KDESu::PtyProcess::writeLine' can be const.
kdesu-6.23.0/src/ptyprocess.cpp:251:18: note: Technically the member function 'KDESu::PtyProcess::writeLine' can be const.
kdesu-6.23.0/src/ptyprocess_p.h:27:16: warning: Class 'PtyProcessPrivate' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor]
kdesu-6.23.0/src/ptyprocess_p.h:27:16: warning: Class 'PtyProcessPrivate' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq]
kdesu-6.23.0/src/ptyprocess.cpp:345:5: warning: If memory allocation fails, then there is a possible null pointer dereference: argp [nullPointerOutOfMemory]
kdesu-6.23.0/src/ptyprocess.cpp:342:46: note: Assuming allocation function fails
kdesu-6.23.0/src/ptyprocess.cpp:342:25: note: Assignment 'argp=(const char**)malloc((args.count()+2)*sizeof(char*))', assigned value is 0
kdesu-6.23.0/src/ptyprocess.cpp:345:5: note: Null pointer dereference
kdesu-6.23.0/src/ptyprocess.cpp:347:9: warning: If memory allocation fails, then there is a possible null pointer dereference: argp [nullPointerOutOfMemory]
kdesu-6.23.0/src/ptyprocess.cpp:342:46: note: Assuming allocation function fails
kdesu-6.23.0/src/ptyprocess.cpp:342:25: note: Assignment 'argp=(const char**)malloc((args.count()+2)*sizeof(char*))', assigned value is 0
kdesu-6.23.0/src/ptyprocess.cpp:346:34: note: Assuming container is not empty
kdesu-6.23.0/src/ptyprocess.cpp:347:9: note: Null pointer dereference
kdesu-6.23.0/src/ptyprocess.cpp:350:5: warning: If memory allocation fails, then there is a possible null pointer dereference: argp [nullPointerOutOfMemory]
kdesu-6.23.0/src/ptyprocess.cpp:342:46: note: Assuming allocation function fails
kdesu-6.23.0/src/ptyprocess.cpp:342:25: note: Assignment 'argp=(const char**)malloc((args.count()+2)*sizeof(char*))', assigned value is 0
kdesu-6.23.0/src/ptyprocess.cpp:346:34: note: Assuming container is not empty
kdesu-6.23.0/src/ptyprocess.cpp:350:5: note: Null pointer dereference
kdesu-6.23.0/src/ptyprocess.cpp:342:25: style: C-style pointer casting [cstyleCast]
kdesu-6.23.0/src/ptyprocess.cpp:234:9: style: The scope of the variable 'pos' can be reduced. [variableScope]
kdesu-6.23.0/src/ptyprocess.cpp:251:57: style:inconclusive: Function 'writeLine' argument 2 names different: declaration 'addNewline' definition 'addnl'. [funcArgNamesDifferent]
kdesu-6.23.0/src/ptyprocess.h:102:49: note: Function 'writeLine' argument 2 names different: declaration 'addNewline' definition 'addnl'.
kdesu-6.23.0/src/ptyprocess.cpp:251:57: note: Function 'writeLine' argument 2 names different: declaration 'addNewline' definition 'addnl'.
kdesu-6.23.0/src/ptyprocess.cpp:261:58: style:inconclusive: Function 'unreadLine' argument 2 names different: declaration 'addNewline' definition 'addnl'. [funcArgNamesDifferent]
kdesu-6.23.0/src/ptyprocess.h:111:50: note: Function 'unreadLine' argument 2 names different: declaration 'addNewline' definition 'addnl'.
kdesu-6.23.0/src/ptyprocess.cpp:261:58: note: Function 'unreadLine' argument 2 names different: declaration 'addNewline' definition 'addnl'.
kdesu-6.23.0/src/sshprocess.cpp:97:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KSU_LOG [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/sshprocess.cpp:218:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable stderr [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/stubprocess.h:106:16: warning: The class 'StubProcess' defines member variable with name 'm_command' also defined in its parent class 'PtyProcess'. [duplInheritedMember]
kdesu-6.23.0/src/ptyprocess.h:215:16: note: Parent variable 'PtyProcess::m_command'
kdesu-6.23.0/src/stubprocess.h:106:16: note: Derived variable 'StubProcess::m_command'
kdesu-6.23.0/src/sshprocess.cpp:29:5: style: Class 'SshProcessPrivate' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
kdesu-6.23.0/src/sshprocess.h:88:10: style: The function 'virtual_hook' overrides a function in a base class but just delegates back to the base class. [uselessOverride]
kdesu-6.23.0/src/stubprocess.h:84:10: note: Virtual function in base class
kdesu-6.23.0/src/sshprocess.h:88:10: note: Function in derived class
kdesu-6.23.0/src/sshprocess.cpp:133:9: style: Variable 'ret' is reassigned a value before the old one has been used. [redundantAssignment]
kdesu-6.23.0/src/sshprocess.cpp:124:13: note: ret is assigned
kdesu-6.23.0/src/sshprocess.cpp:133:9: note: ret is overwritten
kdesu-6.23.0/src/sshprocess.cpp:76:5: style: Variable 'd' can be declared as pointer to const [constVariablePointer]
kdesu-6.23.0/src/stubprocess.cpp:215:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KSU_LOG [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/stubprocess.h:117:5: style: Unused private function: 'StubProcess::d_func' [unusedPrivateFunction]
kdesu-6.23.0/src/stubprocess.h:117:5: note: Unused private function: 'StubProcess::d_func'
kdesu-6.23.0/src/stubprocess.h:117:5: note: Unused private function: 'StubProcess::d_func'
kdesu-6.23.0/src/stubprocess.cpp:33:5: performance: Variable 'm_user' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList]
kdesu-6.23.0/src/stubprocess.cpp:36:5: warning: Class 'StubProcess' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor]
kdesu-6.23.0/src/stubprocess.cpp:36:5: warning: Class 'StubProcess' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq]
kdesu-6.23.0/src/stubprocess.h:84:10: style: The function 'virtual_hook' overrides a function in a base class but just delegates back to the base class. [uselessOverride]
kdesu-6.23.0/src/ptyprocess.h:206:18: note: Virtual function in base class
kdesu-6.23.0/src/stubprocess.h:84:10: note: Function in derived class
kdesu-6.23.0/src/stubprocess.cpp:188:24: style: Local variable 'tmp' shadows outer variable [shadowVariable]
kdesu-6.23.0/src/stubprocess.cpp:120:16: note: Shadowed declaration
kdesu-6.23.0/src/stubprocess.cpp:188:24: note: Shadow variable
kdesu-6.23.0/src/suprocess.cpp:65:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable KSU_LOG [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/suprocess.cpp:123:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SchedNormal [valueFlowBailoutIncompleteVar]
kdesu-6.23.0/src/suprocess.h:92:10: style: The function 'virtual_hook' overrides a function in a base class but just delegates back to the base class. [uselessOverride]
kdesu-6.23.0/src/stubprocess.h:84:10: note: Virtual function in base class
kdesu-6.23.0/src/suprocess.h:92:10: note: Function in derived class
kdesu-6.23.0/src/suprocess.cpp:74:5: style: Variable 'd' can be declared as pointer to const [constVariablePointer]
kdesu-6.23.0/src/suprocess.cpp:81:5: style: Variable 'd' can be declared as pointer to const [constVariablePointer]
diff:
head kdesu-6.23.0/src/kdesud/kdesud.cpp:205:22: style:inconclusive: Function 'signal_exit' argument 1 names different: declaration '<unnamed>' definition 'sig'. [funcArgNamesDifferentUnnamed]


DONE