2022-06-28 22:07
ftp://ftp.de.debian.org/debian/pool/main/j/john/john_1.8.0.orig.tar.gz
cppcheck-options: --library=posix --library=gnu  --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j1
platform: Linux-5.4.0-121-generic-x86_64-with-glibc2.29
python: 3.8.10
client-version: 1.3.24
compiler: g++ (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
cppcheck: head 2.8
head-info: 1852944 (2022-06-28 22:52:35 +0200)
count: 86 82
elapsed-time: 24.3 22.9
head-timing-info:
 Tokenizer::simplifyTokens1: 7.003s (avg. 0.129685s - 54 result(s))
 Tokenizer::simplifyTokens1::ValueFlow: 5.00369s (avg. 0.0944093s - 53 result(s))
 Tokenizer::simplifyTokens1::createSymbolDatabase: 1.45953s (avg. 0.0275384s - 53 result(s))
 Tokenizer::createTokens: 0.22716s (avg. 0.00420667s - 54 result(s))
 Other::runChecks: 0.129594s (avg. 0.00244517s - 53 result(s))
 Overall time: 14.486s

old-timing-info:
 Tokenizer::simplifyTokens1: 6.6145s (avg. 0.122491s - 54 result(s))
 Tokenizer::simplifyTokens1::ValueFlow: 4.6833s (avg. 0.0883641s - 53 result(s))
 Tokenizer::simplifyTokens1::createSymbolDatabase: 1.44468s (avg. 0.0272582s - 53 result(s))
 Tokenizer::createTokens: 0.217699s (avg. 0.00403146s - 54 result(s))
 Tokenizer::simplifyTokens1::setValueType: 0.112983s (avg. 0.00213175s - 53 result(s))
 Overall time: 13.6297s

head results:
john-1.8.0/src/AFS_fmt.c:289:27: style: Parameter 'pcount' can be declared as pointer to const [constParameter]
john-1.8.0/src/AFS_fmt.c:83:10: style: union member 'Anonymous1::dummy' is never used. [unusedStructMember]
john-1.8.0/src/AFS_fmt.c:95:9: style: union member 'Anonymous2::dummy' is never used. [unusedStructMember]
john-1.8.0/src/AFS_fmt.c:300:10: style: union member 'Anonymous3::dummy' is never used. [unusedStructMember]
john-1.8.0/src/BF_fmt.c:232:27: style: Parameter 'pcount' can be declared as pointer to const [constParameter]
john-1.8.0/src/BSDI_fmt.c:342:27: style: Parameter 'pcount' can be declared as pointer to const [constParameter]
john-1.8.0/src/BSDI_fmt.c:262:10: style: union member 'Anonymous1::dummy' is never used. [unusedStructMember]
john-1.8.0/src/DES_bs.c:178:27: style: Parameter 'key' can be declared as pointer to const [constParameter]
john-1.8.0/src/DES_bs.c:268:55: style: Parameter 'raw' can be declared as pointer to const [constParameter]
john-1.8.0/src/DES_bs.c:305:42: style: Parameter 'raw' can be declared as pointer to const [constParameter]
john-1.8.0/src/DES_bs.c:449:34: style: Parameter 'binary' can be declared as pointer to const [constParameter]
john-1.8.0/src/DES_bs.c:493:34: style: Parameter 'binary' can be declared as pointer to const [constParameter]
john-1.8.0/src/DES_bs_b.c:1455:26: style:inconclusive: Function 'DES_bs_crypt_LM' argument 1 names different: declaration 'keys_count' definition 'pcount'. [funcArgNamesDifferent]
john-1.8.0/src/DES_bs.h:152:33: note: Function 'DES_bs_crypt_LM' argument 1 names different: declaration 'keys_count' definition 'pcount'.
john-1.8.0/src/DES_bs_b.c:1455:26: note: Function 'DES_bs_crypt_LM' argument 1 names different: declaration 'keys_count' definition 'pcount'.
john-1.8.0/src/DES_bs_b.c:1455:26: style: Parameter 'pcount' can be declared as pointer to const [constParameter]
john-1.8.0/src/DES_fmt.c:278:27: style: Parameter 'pcount' can be declared as pointer to const [constParameter]
john-1.8.0/src/DES_fmt.c:69:10: style: union member 'Anonymous1::dummy' is never used. [unusedStructMember]
john-1.8.0/src/DES_std.c:625:41: style: Variable 'j' is reassigned a value before the old one has been used. [redundantAssignment]
john-1.8.0/src/DES_std.c:624:4: note: j is assigned
john-1.8.0/src/DES_std.c:625:41: note: j is overwritten
john-1.8.0/src/DES_std.c:946:42: style:inconclusive: Function 'DES_std_crypt' argument 2 names different: declaration 'out' definition 'DES_out'. [funcArgNamesDifferent]
john-1.8.0/src/DES_std.h:165:49: note: Function 'DES_std_crypt' argument 2 names different: declaration 'out' definition 'DES_out'.
john-1.8.0/src/DES_std.c:946:42: note: Function 'DES_std_crypt' argument 2 names different: declaration 'out' definition 'DES_out'.
john-1.8.0/src/DES_std.c:598:28: style: Parameter 'key' can be declared as pointer to const [constParameter]
john-1.8.0/src/DES_std.c:617:28: style: Parameter 'key' can be declared as pointer to const [constParameter]
john-1.8.0/src/DES_std.c:1080:32: style: Parameter 'in' can be declared as const array [constParameter]
john-1.8.0/src/DES_std.c:1096:32: style: Parameter 'in' can be declared as const array [constParameter]
john-1.8.0/src/DES_std.c:48:9: style: union member 'Anonymous0::dummy' is never used. [unusedStructMember]
john-1.8.0/src/MD5_fmt.c:203:27: style: Parameter 'pcount' can be declared as pointer to const [constParameter]
john-1.8.0/src/MD5_std.c:427:22: style: Array index 'length' is used before limits check. [arrayIndexThenCheck]
john-1.8.0/src/MD5_std.c:483:49: style: Parameter 'x' can be declared as const array [constParameter]
john-1.8.0/src/bench.c:79:13: style: Condition 'cond>0' is always true [knownConditionTrueFalse]
john-1.8.0/src/bench.c:79:13: note: Assuming that condition 'cond>0' is not redundant
john-1.8.0/src/bench.c:79:13: note: Condition 'cond>0' is always true
john-1.8.0/src/bench.c:82:13: style: Condition 'cond<0' is always false [knownConditionTrueFalse]
john-1.8.0/src/bench.c:79:13: note: Assuming that condition 'cond>0' is not redundant
john-1.8.0/src/bench.c:82:13: note: Condition 'cond<0' is always false
john-1.8.0/src/bench.c:216:27: style: Parameter 'crypts' can be declared as pointer to const [constParameter]
john-1.8.0/src/c3_fmt.c:173:2: warning:inconclusive: The buffer 'out' may not be null-terminated after the call to strncpy(). [terminateStrncpy]
john-1.8.0/src/c3_fmt.c:146:19: portability: Non reentrant function 'crypt' called. For threadsafe applications it is recommended to use the reentrant replacement function 'crypt_r'. [prohibitedcryptCalled]
john-1.8.0/src/c3_fmt.c:410:16: portability: Non reentrant function 'crypt' called. For threadsafe applications it is recommended to use the reentrant replacement function 'crypt_r'. [prohibitedcryptCalled]
john-1.8.0/src/c3_fmt.c:95:13: style: Condition 'length>=13' is always true [knownConditionTrueFalse]
john-1.8.0/src/c3_fmt.c:88:13: note: Assuming that condition 'length<13' is not redundant
john-1.8.0/src/c3_fmt.c:95:13: note: Condition 'length>=13' is always true
john-1.8.0/src/c3_fmt.c:350:27: style: Parameter 'pcount' can be declared as pointer to const [constParameter]
john-1.8.0/src/charset.c:179:5: style: Suspicious condition (assignment + comparison); Clarify expression with parentheses. [clarifyCondition]
john-1.8.0/src/charset.c:659:3: error: Resource handle 'file' freed twice. [doubleFree]
john-1.8.0/src/charset.c:649:3: note: Resource handle 'file' freed twice.
john-1.8.0/src/charset.c:659:3: note: Resource handle 'file' freed twice.
john-1.8.0/src/charset.c:185:39: portability: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS]
john-1.8.0/src/charset.c:186:39: portability: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS]
john-1.8.0/src/charset.c:187:39: portability: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS]
john-1.8.0/src/compiler.c:904:13: error: syntax error [syntaxError]
john-1.8.0/src/config.c:207:18: style: Local variable 'error' shadows outer function [shadowFunction]
john-1.8.0/src/misc.h:24:13: note: Shadowed declaration
john-1.8.0/src/config.c:207:18: note: Shadow variable
john-1.8.0/src/dummy.c:236:27: style: Parameter 'pcount' can be declared as pointer to const [constParameter]
john-1.8.0/src/formats.c:252:33: style: Parameter 'fields' can be declared as const array [constParameter]
john-1.8.0/src/inc.c:610:4: warning: %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
john-1.8.0/src/inc.c:681:4: warning: %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
john-1.8.0/src/inc.c:345:46: style: Variable 'key' is reassigned a value before the old one has been used. [redundantAssignment]
john-1.8.0/src/inc.c:344:6: note: key is assigned
john-1.8.0/src/inc.c:345:46: note: key is overwritten
john-1.8.0/src/inc.c:260:6: style: Local variable 'error' shadows outer function [shadowFunction]
john-1.8.0/src/misc.h:24:13: note: Shadowed declaration
john-1.8.0/src/inc.c:260:6: note: Shadow variable
john-1.8.0/src/inc.c:651:11: style: Local variable 'max_count' shadows outer variable [shadowVariable]
john-1.8.0/src/inc.c:376:30: note: Shadowed declaration
john-1.8.0/src/inc.c:651:11: note: Shadow variable
john-1.8.0/src/inc.c:299:8: style: Parameter 'char1' can be declared as pointer to const [constParameter]
john-1.8.0/src/inc.c:302:7: style: Variable 'key_e' is not assigned a value. [unassignedVariable]
john-1.8.0/src/john.c:317:10: style: Local variable 'status' shadows outer variable [shadowVariable]
john-1.8.0/src/status.h:35:27: note: Shadowed declaration
john-1.8.0/src/john.c:317:10: note: Shadow variable
john-1.8.0/src/list.c:56:16: warning: Either the condition 'comma' is redundant or there is pointer arithmetic with NULL pointer. [nullPointerArithmeticRedundantCheck]
john-1.8.0/src/list.c:57:7: note: Assuming that condition 'comma' is not redundant
john-1.8.0/src/list.c:56:16: note: Null pointer addition
john-1.8.0/src/loader.c:143:11: style: Condition 'size>0' is always true [knownConditionTrueFalse]
john-1.8.0/src/loader.c:141:13: note: Assignment 'size=4', assigned value is 4
john-1.8.0/src/loader.c:143:11: note: Condition 'size>0' is always true
john-1.8.0/src/rpp.c:155:24: warning: Either the condition '(index=ctx->count-1)>=0' is redundant or the array 'ctx->ranges[16]' is accessed at index -1, which is out of bounds. [negativeIndex]
john-1.8.0/src/rpp.c:153:31: note: Assuming that condition '(index=ctx->count-1)>=0' is not redundant
john-1.8.0/src/rpp.c:157:12: note: index is decremented', new value is -1
john-1.8.0/src/rpp.c:155:24: note: Negative array index
john-1.8.0/src/rpp.c:191:21: warning: Either the condition 'ctx->refs_count>0' is redundant or the array 'ctx->refs[16]' is accessed at index -1, which is out of bounds. [negativeIndex]
john-1.8.0/src/rpp.c:188:22: note: Assuming that condition 'ctx->refs_count>0' is not redundant
john-1.8.0/src/rpp.c:189:35: note: Assignment 'ref_index=ctx->refs_count-1', assigned value is 0
john-1.8.0/src/rpp.c:196:12: note: ref_index is decremented', new value is -1
john-1.8.0/src/rpp.c:191:21: note: Negative array index
john-1.8.0/src/rules.c:353:26: warning: Either the condition 'length<0x80-1' is redundant or the array 'word[1]' is accessed at index 126, which is out of bounds. [arrayIndexOutOfBoundsCond]
john-1.8.0/src/rules.c:352:16: note: Assuming that condition 'length<0x80-1' is not redundant
john-1.8.0/src/rules.c:353:26: note: Array index out of bounds
john-1.8.0/src/single.c:362:6: style: Local variable 'status' shadows outer variable [shadowVariable]
john-1.8.0/src/status.h:35:27: note: Shadowed declaration
john-1.8.0/src/single.c:362:6: note: Shadow variable
john-1.8.0/src/status.c:96:48: style: Parameter 'c' can be declared as pointer to const [constParameter]
john-1.8.0/src/trip_fmt.c:489:27: style: Parameter 'pcount' can be declared as pointer to const [constParameter]
john-1.8.0/src/trip_fmt.c:82:10: style: union member 'Anonymous1::dummy' is never used. [unusedStructMember]
john-1.8.0/src/unique.c:50:23: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
john-1.8.0/src/unique.c:202:19: note: Address of variable taken here.
john-1.8.0/src/unique.c:202:19: note: Calling function 'get_int', 1st argument '(unsigned int*)&buffer.data[current]' value is lifetime=data
john-1.8.0/src/unique.c:50:23: note: The address of local variable 'data' is accessed at non-zero index.
john-1.8.0/src/unique.c:50:23: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
john-1.8.0/src/unique.c:206:27: note: Address of variable taken here.
john-1.8.0/src/unique.c:207:22: note: Calling function 'get_int', 1st argument 'last' value is lifetime=data
john-1.8.0/src/unique.c:50:23: note: The address of local variable 'data' is accessed at non-zero index.
john-1.8.0/src/unique.c:50:23: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
john-1.8.0/src/unique.c:172:17: note: Address of variable taken here.
john-1.8.0/src/unique.c:172:17: note: Calling function 'get_int', 1st argument '(unsigned int*)&buffer.data[ptr]' value is lifetime=data
john-1.8.0/src/unique.c:50:23: note: The address of local variable 'data' is accessed at non-zero index.
john-1.8.0/src/unique.c:50:23: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
john-1.8.0/src/unique.c:146:27: note: Address of variable taken here.
john-1.8.0/src/unique.c:147:22: note: Calling function 'get_int', 1st argument 'last' value is lifetime=data
john-1.8.0/src/unique.c:50:23: note: The address of local variable 'data' is accessed at non-zero index.
john-1.8.0/src/unique.c:51:23: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
john-1.8.0/src/unique.c:202:19: note: Address of variable taken here.
john-1.8.0/src/unique.c:202:19: note: Calling function 'get_int', 1st argument '(unsigned int*)&buffer.data[current]' value is lifetime=data
john-1.8.0/src/unique.c:51:23: note: The address of local variable 'data' is accessed at non-zero index.
john-1.8.0/src/unique.c:51:23: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
john-1.8.0/src/unique.c:206:27: note: Address of variable taken here.
john-1.8.0/src/unique.c:207:22: note: Calling function 'get_int', 1st argument 'last' value is lifetime=data
john-1.8.0/src/unique.c:51:23: note: The address of local variable 'data' is accessed at non-zero index.
john-1.8.0/src/unique.c:51:23: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
john-1.8.0/src/unique.c:172:17: note: Address of variable taken here.
john-1.8.0/src/unique.c:172:17: note: Calling function 'get_int', 1st argument '(unsigned int*)&buffer.data[ptr]' value is lifetime=data
john-1.8.0/src/unique.c:51:23: note: The address of local variable 'data' is accessed at non-zero index.
john-1.8.0/src/unique.c:51:23: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
john-1.8.0/src/unique.c:146:27: note: Address of variable taken here.
john-1.8.0/src/unique.c:147:22: note: Calling function 'get_int', 1st argument 'last' value is lifetime=data
john-1.8.0/src/unique.c:51:23: note: The address of local variable 'data' is accessed at non-zero index.
john-1.8.0/src/unique.c:52:23: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
john-1.8.0/src/unique.c:202:19: note: Address of variable taken here.
john-1.8.0/src/unique.c:202:19: note: Calling function 'get_int', 1st argument '(unsigned int*)&buffer.data[current]' value is lifetime=data
john-1.8.0/src/unique.c:52:23: note: The address of local variable 'data' is accessed at non-zero index.
john-1.8.0/src/unique.c:52:23: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
john-1.8.0/src/unique.c:206:27: note: Address of variable taken here.
john-1.8.0/src/unique.c:207:22: note: Calling function 'get_int', 1st argument 'last' value is lifetime=data
john-1.8.0/src/unique.c:52:23: note: The address of local variable 'data' is accessed at non-zero index.
john-1.8.0/src/unique.c:52:23: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
john-1.8.0/src/unique.c:172:17: note: Address of variable taken here.
john-1.8.0/src/unique.c:172:17: note: Calling function 'get_int', 1st argument '(unsigned int*)&buffer.data[ptr]' value is lifetime=data
john-1.8.0/src/unique.c:52:23: note: The address of local variable 'data' is accessed at non-zero index.
john-1.8.0/src/unique.c:52:23: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
john-1.8.0/src/unique.c:146:27: note: Address of variable taken here.
john-1.8.0/src/unique.c:147:22: note: Calling function 'get_int', 1st argument 'last' value is lifetime=data
john-1.8.0/src/unique.c:52:23: note: The address of local variable 'data' is accessed at non-zero index.
john-1.8.0/src/unique.c:60:7: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
john-1.8.0/src/unique.c:206:27: note: Address of variable taken here.
john-1.8.0/src/unique.c:202:13: note: Calling function 'put_int', 1st argument 'last' value is lifetime=data
john-1.8.0/src/unique.c:60:7: note: The address of local variable 'data' is accessed at non-zero index.
john-1.8.0/src/unique.c:60:7: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
john-1.8.0/src/unique.c:203:5: note: Address of variable taken here.
john-1.8.0/src/unique.c:203:5: note: Calling function 'put_int', 1st argument '(unsigned int*)&buffer.data[current]' value is lifetime=data
john-1.8.0/src/unique.c:60:7: note: The address of local variable 'data' is accessed at non-zero index.
john-1.8.0/src/unique.c:60:7: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
john-1.8.0/src/unique.c:153:3: note: Address of variable taken here.
john-1.8.0/src/unique.c:153:3: note: Calling function 'put_int', 1st argument '(unsigned int*)&buffer.data[ptr]' value is lifetime=data
john-1.8.0/src/unique.c:60:7: note: The address of local variable 'data' is accessed at non-zero index.
john-1.8.0/src/unique.c:60:7: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
john-1.8.0/src/unique.c:164:2: note: Address of variable taken here.
john-1.8.0/src/unique.c:164:2: note: Calling function 'put_int', 1st argument '(unsigned int*)&buffer.data[ptr]' value is lifetime=data
john-1.8.0/src/unique.c:60:7: note: The address of local variable 'data' is accessed at non-zero index.
john-1.8.0/src/unique.c:61:7: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
john-1.8.0/src/unique.c:206:27: note: Address of variable taken here.
john-1.8.0/src/unique.c:202:13: note: Calling function 'put_int', 1st argument 'last' value is lifetime=data
john-1.8.0/src/unique.c:61:7: note: The address of local variable 'data' is accessed at non-zero index.
john-1.8.0/src/unique.c:61:7: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
john-1.8.0/src/unique.c:203:5: note: Address of variable taken here.
john-1.8.0/src/unique.c:203:5: note: Calling function 'put_int', 1st argument '(unsigned int*)&buffer.data[current]' value is lifetime=data
john-1.8.0/src/unique.c:61:7: note: The address of local variable 'data' is accessed at non-zero index.
john-1.8.0/src/unique.c:61:7: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
john-1.8.0/src/unique.c:153:3: note: Address of variable taken here.
john-1.8.0/src/unique.c:153:3: note: Calling function 'put_int', 1st argument '(unsigned int*)&buffer.data[ptr]' value is lifetime=data
john-1.8.0/src/unique.c:61:7: note: The address of local variable 'data' is accessed at non-zero index.
john-1.8.0/src/unique.c:61:7: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
john-1.8.0/src/unique.c:164:2: note: Address of variable taken here.
john-1.8.0/src/unique.c:164:2: note: Calling function 'put_int', 1st argument '(unsigned int*)&buffer.data[ptr]' value is lifetime=data
john-1.8.0/src/unique.c:61:7: note: The address of local variable 'data' is accessed at non-zero index.
john-1.8.0/src/unique.c:62:7: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
john-1.8.0/src/unique.c:206:27: note: Address of variable taken here.
john-1.8.0/src/unique.c:202:13: note: Calling function 'put_int', 1st argument 'last' value is lifetime=data
john-1.8.0/src/unique.c:62:7: note: The address of local variable 'data' is accessed at non-zero index.
john-1.8.0/src/unique.c:62:7: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
john-1.8.0/src/unique.c:203:5: note: Address of variable taken here.
john-1.8.0/src/unique.c:203:5: note: Calling function 'put_int', 1st argument '(unsigned int*)&buffer.data[current]' value is lifetime=data
john-1.8.0/src/unique.c:62:7: note: The address of local variable 'data' is accessed at non-zero index.
john-1.8.0/src/unique.c:62:7: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
john-1.8.0/src/unique.c:153:3: note: Address of variable taken here.
john-1.8.0/src/unique.c:153:3: note: Calling function 'put_int', 1st argument '(unsigned int*)&buffer.data[ptr]' value is lifetime=data
john-1.8.0/src/unique.c:62:7: note: The address of local variable 'data' is accessed at non-zero index.
john-1.8.0/src/unique.c:62:7: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
john-1.8.0/src/unique.c:164:2: note: Address of variable taken here.
john-1.8.0/src/unique.c:164:2: note: Calling function 'put_int', 1st argument '(unsigned int*)&buffer.data[ptr]' value is lifetime=data
john-1.8.0/src/unique.c:62:7: note: The address of local variable 'data' is accessed at non-zero index.
john-1.8.0/src/unique.c:226:24: warning: Either the condition '(fd=open(name,O_RDWR|O_CREAT|O_EXCL,0600))<0' is redundant or fdopen() argument nr 1 can have invalid value. The value is -1 but the valid values are '0:'. [invalidFunctionArg]
john-1.8.0/src/unique.c:224:57: note: Assuming that condition '(fd=open(name,O_RDWR|O_CREAT|O_EXCL,0600))<0' is not redundant
john-1.8.0/src/unique.c:226:24: note: Invalid argument
john-1.8.0/src/rules.c:999:15: error: Using argument start that points at uninitialized variable ctx [ctuuninitvar]
john-1.8.0/src/wordlist.c:203:27: note: Calling function rules_count, 1st argument is uninitialized
john-1.8.0/src/rules.c:1020:16: note: Calling function rules_check, 1st argument is uninitialized
john-1.8.0/src/rules.c:999:15: note: Using argument start
diff:
head john-1.8.0/src/AFS_fmt.c:289:27: style: Parameter 'pcount' can be declared as pointer to const [constParameter]
2.8 john-1.8.0/src/AFS_fmt.c:289:27: style: Parameter 'pcount' can be declared with const [constParameter]
head john-1.8.0/src/BF_fmt.c:232:27: style: Parameter 'pcount' can be declared as pointer to const [constParameter]
2.8 john-1.8.0/src/BF_fmt.c:232:27: style: Parameter 'pcount' can be declared with const [constParameter]
head john-1.8.0/src/BSDI_fmt.c:342:27: style: Parameter 'pcount' can be declared as pointer to const [constParameter]
2.8 john-1.8.0/src/BSDI_fmt.c:342:27: style: Parameter 'pcount' can be declared with const [constParameter]
head john-1.8.0/src/DES_bs.c:178:27: style: Parameter 'key' can be declared as pointer to const [constParameter]
2.8 john-1.8.0/src/DES_bs.c:178:27: style: Parameter 'key' can be declared with const [constParameter]
head john-1.8.0/src/DES_bs.c:268:55: style: Parameter 'raw' can be declared as pointer to const [constParameter]
2.8 john-1.8.0/src/DES_bs.c:268:55: style: Parameter 'raw' can be declared with const [constParameter]
head john-1.8.0/src/DES_bs.c:305:42: style: Parameter 'raw' can be declared as pointer to const [constParameter]
2.8 john-1.8.0/src/DES_bs.c:305:42: style: Parameter 'raw' can be declared with const [constParameter]
head john-1.8.0/src/DES_bs.c:449:34: style: Parameter 'binary' can be declared as pointer to const [constParameter]
2.8 john-1.8.0/src/DES_bs.c:449:34: style: Parameter 'binary' can be declared with const [constParameter]
head john-1.8.0/src/DES_bs.c:493:34: style: Parameter 'binary' can be declared as pointer to const [constParameter]
2.8 john-1.8.0/src/DES_bs.c:493:34: style: Parameter 'binary' can be declared with const [constParameter]
head john-1.8.0/src/DES_bs_b.c:1455:26: style: Parameter 'pcount' can be declared as pointer to const [constParameter]
2.8 john-1.8.0/src/DES_bs_b.c:1455:26: style: Parameter 'pcount' can be declared with const [constParameter]
head john-1.8.0/src/DES_fmt.c:278:27: style: Parameter 'pcount' can be declared as pointer to const [constParameter]
2.8 john-1.8.0/src/DES_fmt.c:278:27: style: Parameter 'pcount' can be declared with const [constParameter]
head john-1.8.0/src/DES_std.c:1080:32: style: Parameter 'in' can be declared as const array [constParameter]
2.8 john-1.8.0/src/DES_std.c:1080:32: style: Parameter 'in' can be declared with const [constParameter]
head john-1.8.0/src/DES_std.c:1096:32: style: Parameter 'in' can be declared as const array [constParameter]
2.8 john-1.8.0/src/DES_std.c:1096:32: style: Parameter 'in' can be declared with const [constParameter]
head john-1.8.0/src/DES_std.c:598:28: style: Parameter 'key' can be declared as pointer to const [constParameter]
2.8 john-1.8.0/src/DES_std.c:598:28: style: Parameter 'key' can be declared with const [constParameter]
head john-1.8.0/src/DES_std.c:617:28: style: Parameter 'key' can be declared as pointer to const [constParameter]
2.8 john-1.8.0/src/DES_std.c:617:28: style: Parameter 'key' can be declared with const [constParameter]
2.8 john-1.8.0/src/DES_std.c:728:35: style: Parameter 'binary' can be declared with const [constParameter]
head john-1.8.0/src/MD5_fmt.c:203:27: style: Parameter 'pcount' can be declared as pointer to const [constParameter]
2.8 john-1.8.0/src/MD5_fmt.c:203:27: style: Parameter 'pcount' can be declared with const [constParameter]
head john-1.8.0/src/MD5_std.c:483:49: style: Parameter 'x' can be declared as const array [constParameter]
2.8 john-1.8.0/src/MD5_std.c:483:49: style: Parameter 'x' can be declared with const [constParameter]
head john-1.8.0/src/bench.c:216:27: style: Parameter 'crypts' can be declared as pointer to const [constParameter]
2.8 john-1.8.0/src/bench.c:216:27: style: Parameter 'crypts' can be declared with const [constParameter]
head john-1.8.0/src/bench.c:79:13: style: Condition 'cond>0' is always true [knownConditionTrueFalse]
     john-1.8.0/src/bench.c:79:13: note: Assuming that condition 'cond>0' is not redundant
     john-1.8.0/src/bench.c:79:13: note: Condition 'cond>0' is always true
head john-1.8.0/src/bench.c:82:13: style: Condition 'cond<0' is always false [knownConditionTrueFalse]
     john-1.8.0/src/bench.c:79:13: note: Assuming that condition 'cond>0' is not redundant
     john-1.8.0/src/bench.c:82:13: note: Condition 'cond<0' is always false
head john-1.8.0/src/c3_fmt.c:350:27: style: Parameter 'pcount' can be declared as pointer to const [constParameter]
2.8 john-1.8.0/src/c3_fmt.c:350:27: style: Parameter 'pcount' can be declared with const [constParameter]
head john-1.8.0/src/dummy.c:236:27: style: Parameter 'pcount' can be declared as pointer to const [constParameter]
2.8 john-1.8.0/src/dummy.c:236:27: style: Parameter 'pcount' can be declared with const [constParameter]
head john-1.8.0/src/formats.c:252:33: style: Parameter 'fields' can be declared as const array [constParameter]
2.8 john-1.8.0/src/formats.c:252:33: style: Parameter 'fields' can be declared with const [constParameter]
head john-1.8.0/src/inc.c:299:8: style: Parameter 'char1' can be declared as pointer to const [constParameter]
2.8 john-1.8.0/src/inc.c:299:8: style: Parameter 'char1' can be declared with const [constParameter]
head john-1.8.0/src/status.c:96:48: style: Parameter 'c' can be declared as pointer to const [constParameter]
2.8 john-1.8.0/src/status.c:96:48: style: Parameter 'c' can be declared with const [constParameter]
head john-1.8.0/src/trip_fmt.c:489:27: style: Parameter 'pcount' can be declared as pointer to const [constParameter]
2.8 john-1.8.0/src/trip_fmt.c:489:27: style: Parameter 'pcount' can be declared with const [constParameter]
head john-1.8.0/src/unique.c:60:7: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
     john-1.8.0/src/unique.c:206:27: note: Address of variable taken here.
     john-1.8.0/src/unique.c:202:13: note: Calling function 'put_int', 1st argument 'last' value is lifetime=data
     john-1.8.0/src/unique.c:60:7: note: The address of local variable 'data' is accessed at non-zero index.
head john-1.8.0/src/unique.c:61:7: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
     john-1.8.0/src/unique.c:206:27: note: Address of variable taken here.
     john-1.8.0/src/unique.c:202:13: note: Calling function 'put_int', 1st argument 'last' value is lifetime=data
     john-1.8.0/src/unique.c:61:7: note: The address of local variable 'data' is accessed at non-zero index.
head john-1.8.0/src/unique.c:62:7: error: The address of local variable 'data' is accessed at non-zero index. [objectIndex]
     john-1.8.0/src/unique.c:206:27: note: Address of variable taken here.
     john-1.8.0/src/unique.c:202:13: note: Calling function 'put_int', 1st argument 'last' value is lifetime=data
     john-1.8.0/src/unique.c:62:7: note: The address of local variable 'data' is accessed at non-zero index.


DONE