2025-11-27 07:25 ftp://ftp.de.debian.org/debian/pool/main/j/jag/jag_0.3.8.orig.tar.bz2 cppcheck-options: --library=posix --library=gnu --library=bsd --library=motif --library=qt --library=sdl --inconclusive --enable=style,information --inline-suppr --template=daca2 --disable=missingInclude --suppress=unmatchedSuppression --check-library --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning --suppress=normalCheckLevelConditionExpressions -D__GNUC__ --platform=unix64 -j4 platform: Linux-6.12.57+deb13-amd64-x86_64-with-glibc2.41 python: 3.13.5 client-version: 1.3.67 compiler: g++ (Debian 14.2.0-19) 14.2.0 cppcheck: head 2.18.0 head-info: 9486fde (2025-11-26 08:20:02 +0100) count: 341 341 elapsed-time: 0.9 1.0 head-timing-info: old-timing-info: head results: jag-0.3.8/src/baseitem.h:55:14: style: The destructor '~PixmapItem' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/baseitem.h:38:12: note: Virtual destructor in base class jag-0.3.8/src/baseitem.h:55:14: note: Destructor in derived class jag-0.3.8/src/baseitem.h:57:10: style: The function 'advance' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/baseitem.h:40:16: note: Virtual function in base class jag-0.3.8/src/baseitem.h:57:10: note: Function in derived class jag-0.3.8/src/baseitem.h:59:10: style: The function 'paint' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/baseitem.h:42:16: note: Virtual function in base class jag-0.3.8/src/baseitem.h:59:10: note: Function in derived class jag-0.3.8/src/baseitem.h:74:14: style: The destructor '~TextItem' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/baseitem.h:38:12: note: Virtual destructor in base class jag-0.3.8/src/baseitem.h:74:14: note: Destructor in derived class jag-0.3.8/src/baseitem.h:76:18: style: The function 'advance' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/baseitem.h:40:16: note: Virtual function in base class jag-0.3.8/src/baseitem.h:76:18: note: Function in derived class jag-0.3.8/src/baseitem.h:78:18: style: The function 'paint' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/baseitem.h:42:16: note: Virtual function in base class jag-0.3.8/src/baseitem.h:78:18: note: Function in derived class jag-0.3.8/src/clocktool.h:38:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AutoTool [valueFlowBailoutIncompleteVar] jag-0.3.8/src/bighammertool.cpp:45:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ToolActive [valueFlowBailoutIncompleteVar] jag-0.3.8/src/bombtool.cpp:45:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ToolOutOfRange [valueFlowBailoutIncompleteVar] jag-0.3.8/src/scene_if.h:99:55: style: Obsolete function 'qrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqrandCalled] jag-0.3.8/src/scene_if.h:97:30: style:inconclusive: Technically the member function 'IScene::gameItems' can be const. [functionConst] jag-0.3.8/src/scene_if.h:99:16: style:inconclusive: Technically the member function 'IScene::randomItemId' can be const. [functionConst] jag-0.3.8/src/gamebonus.h:69:3: style: Struct 'BonusInfo' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] jag-0.3.8/src/gameitem.h:38:5: style: Class 'GameItem' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] jag-0.3.8/src/clocktool.h:36:14: style: The destructor '~ClockTool' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:53:12: note: Virtual destructor in base class jag-0.3.8/src/clocktool.h:36:14: note: Destructor in derived class jag-0.3.8/src/clocktool.h:38:22: style: The function 'type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:55:20: note: Virtual function in base class jag-0.3.8/src/clocktool.h:38:22: note: Function in derived class jag-0.3.8/src/clocktool.h:40:18: style: The function 'checkToolClick' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:86:16: note: Virtual function in base class jag-0.3.8/src/clocktool.h:40:18: note: Function in derived class jag-0.3.8/src/bighammertool.h:36:12: style: The destructor '~BigHammerTool' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:53:12: note: Virtual destructor in base class jag-0.3.8/src/bighammertool.h:36:12: note: Destructor in derived class jag-0.3.8/src/bighammertool.h:38:14: style: The function 'checkItemState' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:83:22: note: Virtual function in base class jag-0.3.8/src/bighammertool.h:38:14: note: Function in derived class jag-0.3.8/src/bighammertool.h:39:8: style: The function 'checkItemClick' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:82:16: note: Virtual function in base class jag-0.3.8/src/bighammertool.h:39:8: note: Function in derived class jag-0.3.8/src/bighammertool.cpp:43:16: style: Variable 'pi' can be declared as reference to const [constVariableReference] jag-0.3.8/src/bombtool.h:36:12: style: The destructor '~BombTool' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:53:12: note: Virtual destructor in base class jag-0.3.8/src/bombtool.h:36:12: note: Destructor in derived class jag-0.3.8/src/bombtool.h:38:14: style: The function 'checkItemState' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:83:22: note: Virtual function in base class jag-0.3.8/src/bombtool.h:38:14: note: Function in derived class jag-0.3.8/src/bombtool.h:39:8: style: The function 'checkItemClick' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:82:16: note: Virtual function in base class jag-0.3.8/src/bombtool.h:39:8: note: Function in derived class jag-0.3.8/src/bombtool.cpp:49:16: style: Local variable 'pi' shadows outer variable [shadowVariable] jag-0.3.8/src/bombtool.cpp:43:14: note: Shadowed declaration jag-0.3.8/src/bombtool.cpp:49:16: note: Shadow variable jag-0.3.8/src/bombtool.cpp:78:18: style: Local variable 'pi' shadows outer variable [shadowVariable] jag-0.3.8/src/bombtool.cpp:62:14: note: Shadowed declaration jag-0.3.8/src/bombtool.cpp:78:18: note: Shadow variable jag-0.3.8/src/bombtool.cpp:43:14: style: Variable 'pi' can be declared as reference to const [constVariableReference] jag-0.3.8/src/bombtool.cpp:49:16: style: Variable 'pi' can be declared as reference to const [constVariableReference] jag-0.3.8/src/bombtool.cpp:62:14: style: Variable 'pi' can be declared as reference to const [constVariableReference] jag-0.3.8/src/bombtool.cpp:78:18: style: Variable 'pi' can be declared as reference to const [constVariableReference] jag-0.3.8/src/displaywrapper.cpp:236:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] jag-0.3.8/src/displaywrapper.cpp:310:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable width [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/levelwidget.cpp:59:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LeftButton [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/levelwidget.cpp:73:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LeftButton [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/levelwidget.h:39:10: style:inconclusive: Either there is a missing 'override', or the member function 'LevelWidget::isMousePressed' can be const. [functionConst] jag-0.3.8/src/editor/levelwidget.h:36:5: style: Class 'LevelWidget' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] jag-0.3.8/src/consttools.h:43:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ConstTool [valueFlowBailoutIncompleteVar] jag-0.3.8/src/consttools.cpp:40:58: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SmoothTransformation [valueFlowBailoutIncompleteVar] jag-0.3.8/src/consttools.cpp:68:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable white [valueFlowBailoutIncompleteVar] jag-0.3.8/src/consttools.cpp:101:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable white [valueFlowBailoutIncompleteVar] jag-0.3.8/src/consttools.cpp:134:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable white [valueFlowBailoutIncompleteVar] jag-0.3.8/src/consttools.cpp:167:18: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable white [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/levelpack.cpp:127:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Close [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/levelpack.h:36:5: style: Class 'LevelPackDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] jag-0.3.8/src/gamewidget.h:40:5: style: Class 'GameWidget' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] jag-0.3.8/src/consttools.h:41:12: style: The destructor '~ConstBonus' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:53:12: note: Virtual destructor in base class jag-0.3.8/src/consttools.h:41:12: note: Destructor in derived class jag-0.3.8/src/consttools.h:43:20: style: The function 'type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:55:20: note: Virtual function in base class jag-0.3.8/src/consttools.h:43:20: note: Function in derived class jag-0.3.8/src/consttools.h:60:14: style: The destructor '~MagBonus' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/consttools.h:41:12: note: Virtual destructor in base class jag-0.3.8/src/consttools.h:60:14: note: Destructor in derived class jag-0.3.8/src/consttools.h:62:18: style: The function 'checkToolClick' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:86:16: note: Virtual function in base class jag-0.3.8/src/consttools.h:62:18: note: Function in derived class jag-0.3.8/src/consttools.h:63:18: style: The function 'advanceAndPaint' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:77:16: note: Virtual function in base class jag-0.3.8/src/consttools.h:63:18: note: Function in derived class jag-0.3.8/src/consttools.h:73:14: style: The destructor '~TimerBonus' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/consttools.h:41:12: note: Virtual destructor in base class jag-0.3.8/src/consttools.h:73:14: note: Destructor in derived class jag-0.3.8/src/consttools.h:75:18: style: The function 'checkToolClick' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:86:16: note: Virtual function in base class jag-0.3.8/src/consttools.h:75:18: note: Function in derived class jag-0.3.8/src/consttools.h:76:18: style: The function 'advanceAndPaint' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:77:16: note: Virtual function in base class jag-0.3.8/src/consttools.h:76:18: note: Function in derived class jag-0.3.8/src/consttools.h:86:14: style: The destructor '~ScoreBonus' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/consttools.h:41:12: note: Virtual destructor in base class jag-0.3.8/src/consttools.h:86:14: note: Destructor in derived class jag-0.3.8/src/consttools.h:88:18: style: The function 'checkToolClick' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:86:16: note: Virtual function in base class jag-0.3.8/src/consttools.h:88:18: note: Function in derived class jag-0.3.8/src/consttools.h:89:18: style: The function 'advanceAndPaint' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:77:16: note: Virtual function in base class jag-0.3.8/src/consttools.h:89:18: note: Function in derived class jag-0.3.8/src/consttools.h:99:14: style: The destructor '~ClockBonus' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/consttools.h:41:12: note: Virtual destructor in base class jag-0.3.8/src/consttools.h:99:14: note: Destructor in derived class jag-0.3.8/src/consttools.h:101:18: style: The function 'checkToolClick' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:86:16: note: Virtual function in base class jag-0.3.8/src/consttools.h:101:18: note: Function in derived class jag-0.3.8/src/consttools.h:102:18: style: The function 'advanceAndPaint' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:77:16: note: Virtual function in base class jag-0.3.8/src/consttools.h:102:18: note: Function in derived class jag-0.3.8/src/editor/levelpack.cpp:157:17: style: Local variable 'files' shadows outer function [shadowFunction] jag-0.3.8/src/editor/levelpack.h:45:17: note: Shadowed declaration jag-0.3.8/src/editor/levelpack.cpp:157:17: note: Shadow variable jag-0.3.8/src/editor/mainwindow.h:58:5: style: Class 'MainWindow' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] jag-0.3.8/src/displaywrapper.cpp:164:17: warning: Member variable 'DisplayWrapper::base_widget' is not initialized in the constructor. [uninitMemberVar] jag-0.3.8/src/displaywrapper.cpp:174:22: performance:inconclusive: Technically the member function 'DisplayWrapper::readScreenSubSection' can be static (but you may consider moving to unnamed namespace). [functionStatic] jag-0.3.8/src/displaywrapper.h:69:8: note: Technically the member function 'DisplayWrapper::readScreenSubSection' can be static (but you may consider moving to unnamed namespace). jag-0.3.8/src/displaywrapper.cpp:174:22: note: Technically the member function 'DisplayWrapper::readScreenSubSection' can be static (but you may consider moving to unnamed namespace). jag-0.3.8/src/displaywrapper.cpp:232:11: style: The scope of the variable 'line' can be reduced. [variableScope] jag-0.3.8/src/displaywrapper.cpp:231:11: style: Local variable 'modes' shadows outer variable [shadowVariable] jag-0.3.8/src/displaywrapper.h:79:24: note: Shadowed declaration jag-0.3.8/src/displaywrapper.cpp:231:11: note: Shadow variable jag-0.3.8/src/displaywrapper.cpp:384:21: style: Variable 'sizes' can be declared as pointer to const [constVariablePointer] jag-0.3.8/src/gamebackground.cpp:62:20: style: Obsolete function 'qrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqrandCalled] jag-0.3.8/src/gamebackground.cpp:76:22: style: Obsolete function 'qrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqrandCalled] jag-0.3.8/src/gamebackground.cpp:110:23: style: Obsolete function 'qrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqrandCalled] jag-0.3.8/src/gamebackground.cpp:111:23: style: Obsolete function 'qrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqrandCalled] jag-0.3.8/src/gamebackground.cpp:46:3: warning: Member variable 'BgPrivate::currentBgIdx' is not initialized in the constructor. [uninitMemberVar] jag-0.3.8/src/gamebackground.cpp:46:3: warning: Member variable 'BgPrivate::transBgIdx' is not initialized in the constructor. [uninitMemberVar] jag-0.3.8/src/gamebackground.cpp:46:3: warning: Member variable 'BgPrivate::frame' is not initialized in the constructor. [uninitMemberVar] jag-0.3.8/src/gameprofile.h:60:8: style:inconclusive: Technically the member function 'LevelPackInfo::isPuzzle' can be const. [functionConst] jag-0.3.8/src/gameprofile.h:143:10: style:inconclusive: Either there is a missing 'override', or the member function 'GameProfile::isGameStarted' can be const. [functionConst] jag-0.3.8/src/gameprofile.h:146:10: style:inconclusive: Either there is a missing 'override', or the member function 'GameProfile::isGamePaused' can be const. [functionConst] jag-0.3.8/src/gameprofile.h:149:17: style:inconclusive: Either there is a missing 'override', or the member function 'GameProfile::themesList' can be const. [functionConst] jag-0.3.8/src/gameprofile.h:163:10: style:inconclusive: Either there is a missing 'override', or the member function 'GameProfile::isAccelerated' can be const. [functionConst] jag-0.3.8/src/gamebackground.cpp:133:3: warning: Class 'GameBackground' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] jag-0.3.8/src/gamebackground.cpp:133:3: warning: Class 'GameBackground' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] jag-0.3.8/src/gameprofile.h:51:3: style: Struct 'LevelPackInfo' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] jag-0.3.8/src/gameprofile.h:75:5: style: Struct 'PlayerInfo' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] jag-0.3.8/src/gameprofile.h:120:5: style: Class 'GameProfile' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] jag-0.3.8/src/gameprofile.h:149:17: performance: Function 'themesList()' should return member 'm_themes' by const reference. [returnByReference] jag-0.3.8/src/gamebackground.cpp:95:21: style: Condition 'frame>=480' is always true [knownConditionTrueFalse] jag-0.3.8/src/gamebackground.cpp:93:21: note: Assuming that condition 'frame<480' is not redundant jag-0.3.8/src/gamebackground.cpp:95:21: note: Condition 'frame>=480' is always true jag-0.3.8/src/gamecontrol.cpp:133:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LeftButton [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamecontrol.cpp:142:5: style: Obsolete function 'qsrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqsrandCalled] jag-0.3.8/src/gamemenu.h:79:10: style:inconclusive: Either there is a missing 'override', or the member function 'MenuWidget::isActive' can be const. [functionConst] jag-0.3.8/src/gamescene.h:60:5: style: Class 'GameScene' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] jag-0.3.8/src/gamemenu.h:53:5: style: Class 'ConfirmDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] jag-0.3.8/src/gamemenu.h:72:5: style: Class 'MenuWidget' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] jag-0.3.8/src/gameitem.cpp:39:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IdleState [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gameitem.cpp:28:11: warning: Member variable 'GameItem::myCount' is not initialized in the constructor. [uninitMemberVar] jag-0.3.8/src/gamecontrol.cpp:124:59: style:inconclusive: Function 'mousePressEvent' argument 1 names different: declaration 'event' definition 'mouseEvent'. [funcArgNamesDifferent] jag-0.3.8/src/gamescene.h:73:52: note: Function 'mousePressEvent' argument 1 names different: declaration 'event' definition 'mouseEvent'. jag-0.3.8/src/gamecontrol.cpp:124:59: note: Function 'mousePressEvent' argument 1 names different: declaration 'event' definition 'mouseEvent'. jag-0.3.8/src/gamecontrol.cpp:151:60: style:inconclusive: Function 'mouseMoveEvent' argument 1 names different: declaration 'event' definition 'mouseEvent'. [funcArgNamesDifferent] jag-0.3.8/src/gamescene.h:72:51: note: Function 'mouseMoveEvent' argument 1 names different: declaration 'event' definition 'mouseEvent'. jag-0.3.8/src/gamecontrol.cpp:151:60: note: Function 'mouseMoveEvent' argument 1 names different: declaration 'event' definition 'mouseEvent'. jag-0.3.8/src/gamebonus.cpp:46:58: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SmoothTransformation [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamebonus.cpp:242:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable white [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamebonus.cpp:279:68: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable gray [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamebonus.cpp:328:56: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable darkGray [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:70:48: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SelectAll [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:132:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Yes [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:152:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Yes [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:224:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WriteOnly [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:302:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:375:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Yes [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:390:32: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Yes [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:434:79: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UserRole [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:544:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PartiallyChecked [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:560:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PartiallyChecked [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:568:47: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PartiallyChecked [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:629:46: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Checked [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:672:56: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Unchecked [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:723:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UserRole [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:802:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ItemIsEnabled [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:828:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UserRole [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:844:35: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UserRole [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:906:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:926:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WriteOnly [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:937:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WriteOnly [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:970:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:1116:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UserRole [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:1159:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UserRole [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:1200:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable UserRole [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:1229:25: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Yes [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:1253:64: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SmoothTransformation [valueFlowBailoutIncompleteVar] jag-0.3.8/src/editor/mainwindow.cpp:1268:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Close [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamemenu.cpp:60:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamemenu.cpp:162:28: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AlignCenter [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamepaint.cpp:46:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Antialiasing [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamepaint.cpp:262:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable white [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamepaint.cpp:285:73: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable magenta [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamepaint.cpp:417:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable white [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamebonus.cpp:82:12: warning: Member variable 'GameBonus::diff' is not initialized in the constructor. [uninitMemberVar] jag-0.3.8/src/gamebonus.cpp:82:12: warning: Member variable 'GameBonus::puzzle' is not initialized in the constructor. [uninitMemberVar] jag-0.3.8/src/gamebonus.cpp:45:3: performance: Variable 'pixmap' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] jag-0.3.8/src/gamepaint.cpp:286:21: style: Obsolete function 'qrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqrandCalled] jag-0.3.8/src/gamepaint.cpp:286:41: style: Obsolete function 'qrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqrandCalled] jag-0.3.8/src/gamepaint.cpp:299:16: style: Obsolete function 'qrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqrandCalled] jag-0.3.8/src/gamepaint.cpp:300:16: style: Obsolete function 'qrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqrandCalled] jag-0.3.8/src/gameprofile.cpp:192:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gameprofile.cpp:278:67: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AllDirs [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gameprofile.cpp:292:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gameprofile.cpp:319:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamebonus.cpp:38:35: style:inconclusive: Function 'BonusInfo' argument 1 names different: declaration 'rect' definition '_rect'. [funcArgNamesDifferent] jag-0.3.8/src/gamebonus.h:69:26: note: Function 'BonusInfo' argument 1 names different: declaration 'rect' definition '_rect'. jag-0.3.8/src/gamebonus.cpp:38:35: note: Function 'BonusInfo' argument 1 names different: declaration 'rect' definition '_rect'. jag-0.3.8/src/gamebonus.cpp:38:46: style:inconclusive: Function 'BonusInfo' argument 2 names different: declaration 'score' definition '_score'. [funcArgNamesDifferent] jag-0.3.8/src/gamebonus.h:69:36: note: Function 'BonusInfo' argument 2 names different: declaration 'score' definition '_score'. jag-0.3.8/src/gamebonus.cpp:38:46: note: Function 'BonusInfo' argument 2 names different: declaration 'score' definition '_score'. jag-0.3.8/src/gamebonus.cpp:39:53: style:inconclusive: Function 'BonusInfo' argument 4 names different: declaration 'name' definition '_name'. [funcArgNamesDifferent] jag-0.3.8/src/gamebonus.h:71:28: note: Function 'BonusInfo' argument 4 names different: declaration 'name' definition '_name'. jag-0.3.8/src/gamebonus.cpp:39:53: note: Function 'BonusInfo' argument 4 names different: declaration 'name' definition '_name'. jag-0.3.8/src/gamebonus.cpp:39:75: style:inconclusive: Function 'BonusInfo' argument 5 names different: declaration 'comment' definition '_comment'. [funcArgNamesDifferent] jag-0.3.8/src/gamebonus.h:71:54: note: Function 'BonusInfo' argument 5 names different: declaration 'comment' definition '_comment'. jag-0.3.8/src/gamebonus.cpp:39:75: note: Function 'BonusInfo' argument 5 names different: declaration 'comment' definition '_comment'. jag-0.3.8/src/gamebonus.cpp:49:35: style:inconclusive: Function 'BonusInfo' argument 1 names different: declaration 'rect' definition '_rect'. [funcArgNamesDifferent] jag-0.3.8/src/gamebonus.h:73:26: note: Function 'BonusInfo' argument 1 names different: declaration 'rect' definition '_rect'. jag-0.3.8/src/gamebonus.cpp:49:35: note: Function 'BonusInfo' argument 1 names different: declaration 'rect' definition '_rect'. jag-0.3.8/src/gamebonus.cpp:49:46: style:inconclusive: Function 'BonusInfo' argument 2 names different: declaration 'score' definition '_score'. [funcArgNamesDifferent] jag-0.3.8/src/gamebonus.h:73:36: note: Function 'BonusInfo' argument 2 names different: declaration 'score' definition '_score'. jag-0.3.8/src/gamebonus.cpp:49:46: note: Function 'BonusInfo' argument 2 names different: declaration 'score' definition '_score'. jag-0.3.8/src/gamebonus.cpp:49:69: style:inconclusive: Function 'BonusInfo' argument 3 names different: declaration 'pixmap' definition '_pixmap'. [funcArgNamesDifferent] jag-0.3.8/src/gamebonus.h:73:58: note: Function 'BonusInfo' argument 3 names different: declaration 'pixmap' definition '_pixmap'. jag-0.3.8/src/gamebonus.cpp:49:69: note: Function 'BonusInfo' argument 3 names different: declaration 'pixmap' definition '_pixmap'. jag-0.3.8/src/gamebonus.cpp:49:93: style:inconclusive: Function 'BonusInfo' argument 4 names different: declaration 'name' definition '_name'. [funcArgNamesDifferent] jag-0.3.8/src/gamebonus.h:73:81: note: Function 'BonusInfo' argument 4 names different: declaration 'name' definition '_name'. jag-0.3.8/src/gamebonus.cpp:49:93: note: Function 'BonusInfo' argument 4 names different: declaration 'name' definition '_name'. jag-0.3.8/src/gamebonus.cpp:49:115: style:inconclusive: Function 'BonusInfo' argument 5 names different: declaration 'comment' definition '_comment'. [funcArgNamesDifferent] jag-0.3.8/src/gamebonus.h:73:102: note: Function 'BonusInfo' argument 5 names different: declaration 'comment' definition '_comment'. jag-0.3.8/src/gamebonus.cpp:49:115: note: Function 'BonusInfo' argument 5 names different: declaration 'comment' definition '_comment'. jag-0.3.8/src/gamebonus.cpp:58:26: style:inconclusive: Function 'BonusInfo' argument 1 names different: declaration 'score' definition '_score'. [funcArgNamesDifferent] jag-0.3.8/src/gamebonus.h:75:17: note: Function 'BonusInfo' argument 1 names different: declaration 'score' definition '_score'. jag-0.3.8/src/gamebonus.cpp:58:26: note: Function 'BonusInfo' argument 1 names different: declaration 'score' definition '_score'. jag-0.3.8/src/gamebonus.cpp:58:49: style:inconclusive: Function 'BonusInfo' argument 2 names different: declaration 'pixmap' definition '_pixmap'. [funcArgNamesDifferent] jag-0.3.8/src/gamebonus.h:75:39: note: Function 'BonusInfo' argument 2 names different: declaration 'pixmap' definition '_pixmap'. jag-0.3.8/src/gamebonus.cpp:58:49: note: Function 'BonusInfo' argument 2 names different: declaration 'pixmap' definition '_pixmap'. jag-0.3.8/src/gamebonus.cpp:58:73: style:inconclusive: Function 'BonusInfo' argument 3 names different: declaration 'name' definition '_name'. [funcArgNamesDifferent] jag-0.3.8/src/gamebonus.h:75:62: note: Function 'BonusInfo' argument 3 names different: declaration 'name' definition '_name'. jag-0.3.8/src/gamebonus.cpp:58:73: note: Function 'BonusInfo' argument 3 names different: declaration 'name' definition '_name'. jag-0.3.8/src/gamebonus.cpp:58:95: style:inconclusive: Function 'BonusInfo' argument 4 names different: declaration 'comment' definition '_comment'. [funcArgNamesDifferent] jag-0.3.8/src/gamebonus.h:75:83: note: Function 'BonusInfo' argument 4 names different: declaration 'comment' definition '_comment'. jag-0.3.8/src/gamebonus.cpp:58:95: note: Function 'BonusInfo' argument 4 names different: declaration 'comment' definition '_comment'. jag-0.3.8/src/gamebonus.cpp:66:37: style:inconclusive: Function 'BonusInfo' argument 1 names different: declaration 'name' definition '_name'. [funcArgNamesDifferent] jag-0.3.8/src/gamebonus.h:77:28: note: Function 'BonusInfo' argument 1 names different: declaration 'name' definition '_name'. jag-0.3.8/src/gamebonus.cpp:66:37: note: Function 'BonusInfo' argument 1 names different: declaration 'name' definition '_name'. jag-0.3.8/src/gamebonus.cpp:66:59: style:inconclusive: Function 'BonusInfo' argument 2 names different: declaration 'comment' definition '_comment'. [funcArgNamesDifferent] jag-0.3.8/src/gamebonus.h:77:49: note: Function 'BonusInfo' argument 2 names different: declaration 'comment' definition '_comment'. jag-0.3.8/src/gamebonus.cpp:66:59: note: Function 'BonusInfo' argument 2 names different: declaration 'comment' definition '_comment'. jag-0.3.8/src/gamebonus.cpp:73:37: style: Parameter 'source' can be declared as pointer to const [constParameterPointer] jag-0.3.8/src/gamepaint.cpp:286:14: style: The scope of the variable 'idx1' can be reduced. [variableScope] jag-0.3.8/src/gamepaint.cpp:286:34: style: The scope of the variable 'idx2' can be reduced. [variableScope] jag-0.3.8/src/gamepaint.cpp:100:57: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] jag-0.3.8/src/gamepaint.cpp:138:56: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] jag-0.3.8/src/gamepaint.cpp:345:55: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] jag-0.3.8/src/gamepaint.cpp:358:54: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] jag-0.3.8/src/gamepaint.cpp:400:22: style: Variable 'pi' can be declared as reference to const [constVariableReference] jag-0.3.8/src/gameprofile.cpp:90:5: performance: Variable 'userPath' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] jag-0.3.8/src/gameprofile.cpp:200:22: style: The scope of the variable 'index' can be reduced. [variableScope] jag-0.3.8/src/gamesound.cpp:70:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MIX_MAX_VOLUME [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamesound.cpp:121:17: performance:inconclusive: Either there is a missing 'override', or the member function 'GameSound::stopSound' can be static. [functionStatic] jag-0.3.8/src/gamesound.h:68:10: note: Either there is a missing 'override', or the member function 'GameSound::stopSound' can be static. jag-0.3.8/src/gamesound.cpp:121:17: note: Either there is a missing 'override', or the member function 'GameSound::stopSound' can be static. jag-0.3.8/src/gamesound.cpp:127:17: performance:inconclusive: Either there is a missing 'override', or the member function 'GameSound::stopAllSounds' can be static. [functionStatic] jag-0.3.8/src/gamesound.h:69:10: note: Either there is a missing 'override', or the member function 'GameSound::stopAllSounds' can be static. jag-0.3.8/src/gamesound.cpp:127:17: note: Either there is a missing 'override', or the member function 'GameSound::stopAllSounds' can be static. jag-0.3.8/src/editor/mainwindow.cpp:241:43: style: Obsolete function 'qrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqrandCalled] jag-0.3.8/src/gamestatics.cpp:53:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AlignCenter [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamestatics.cpp:223:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AlignLeft [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamestatics.cpp:265:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable white [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamestatics.cpp:103:46: style: Obsolete function 'qrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqrandCalled] jag-0.3.8/src/gamestatics.cpp:103:68: style: Obsolete function 'qrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqrandCalled] jag-0.3.8/src/gamestatics.cpp:123:46: style: Obsolete function 'qrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqrandCalled] jag-0.3.8/src/gamestatics.cpp:123:68: style: Obsolete function 'qrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqrandCalled] jag-0.3.8/src/gamestatics.cpp:36:9: warning: Member variable 'IScene::rows' is not initialized in the constructor. [uninitMemberVar] jag-0.3.8/src/gamestatics.cpp:36:9: warning: Member variable 'IScene::cols' is not initialized in the constructor. [uninitMemberVar] jag-0.3.8/src/gamestatics.cpp:36:9: warning: Member variable 'IScene::xoff' is not initialized in the constructor. [uninitMemberVar] jag-0.3.8/src/gamestatics.cpp:36:9: warning: Member variable 'IScene::yoff' is not initialized in the constructor. [uninitMemberVar] jag-0.3.8/src/gamestatics.cpp:36:9: warning: Member variable 'IScene::score' is not initialized in the constructor. [uninitMemberVar] jag-0.3.8/src/gamestatics.cpp:36:9: warning: Member variable 'IScene::level' is not initialized in the constructor. [uninitMemberVar] jag-0.3.8/src/gamestatics.cpp:250:14: performance:inconclusive: Technically the member function 'IScene::drawTransRect' can be static (but you may consider moving to unnamed namespace). [functionStatic] jag-0.3.8/src/scene_if.h:83:10: note: Technically the member function 'IScene::drawTransRect' can be static (but you may consider moving to unnamed namespace). jag-0.3.8/src/gamestatics.cpp:250:14: note: Technically the member function 'IScene::drawTransRect' can be static (but you may consider moving to unnamed namespace). jag-0.3.8/src/gamestatics.cpp:234:14: performance:inconclusive: Technically the member function 'IScene::setDefaultGameCursor' can be static (but you may consider moving to unnamed namespace). [functionStatic] jag-0.3.8/src/scene_if.h:108:10: note: Technically the member function 'IScene::setDefaultGameCursor' can be static (but you may consider moving to unnamed namespace). jag-0.3.8/src/gamestatics.cpp:234:14: note: Technically the member function 'IScene::setDefaultGameCursor' can be static (but you may consider moving to unnamed namespace). jag-0.3.8/src/gamestat.cpp:113:71: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable black [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamestatics.cpp:217:26: style:inconclusive: Function 'addTime' argument 1 names different: declaration 'time' definition 'timeAdd'. [funcArgNamesDifferent] jag-0.3.8/src/scene_if.h:106:22: note: Function 'addTime' argument 1 names different: declaration 'time' definition 'timeAdd'. jag-0.3.8/src/gamestatics.cpp:217:26: note: Function 'addTime' argument 1 names different: declaration 'time' definition 'timeAdd'. jag-0.3.8/src/gamestatics.cpp:250:99: style:inconclusive: Function 'drawTransRect' argument 5 names different: declaration 'opacity' definition 'op'. [funcArgNamesDifferent] jag-0.3.8/src/scene_if.h:85:30: note: Function 'drawTransRect' argument 5 names different: declaration 'opacity' definition 'op'. jag-0.3.8/src/gamestatics.cpp:250:99: note: Function 'drawTransRect' argument 5 names different: declaration 'opacity' definition 'op'. jag-0.3.8/src/gamestock.cpp:52:74: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SmoothTransformation [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamestat.cpp:34:11: warning: Member variable 'StatInfo::code' is not initialized in the constructor. [uninitMemberVar] jag-0.3.8/src/gamestat.cpp:34:11: warning: Member variable 'StatInfo::level_time' is not initialized in the constructor. [uninitMemberVar] jag-0.3.8/src/gamestat.cpp:34:11: warning: Member variable 'StatInfo::level_score' is not initialized in the constructor. [uninitMemberVar] jag-0.3.8/src/gamestat.cpp:34:11: warning: Member variable 'StatInfo::level_targets_all' is not initialized in the constructor. [uninitMemberVar] jag-0.3.8/src/gamestat.cpp:34:11: warning: Member variable 'StatInfo::level_targets_left' is not initialized in the constructor. [uninitMemberVar] jag-0.3.8/src/editor/mainwindow.cpp:214:14: style: The scope of the variable 'mix' can be reduced. [variableScope] jag-0.3.8/src/editor/mainwindow.cpp:728:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] jag-0.3.8/src/editor/mainwindow.cpp:728:91: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] jag-0.3.8/src/editor/mainwindow.cpp:729:49: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] jag-0.3.8/src/editor/mainwindow.cpp:729:83: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] jag-0.3.8/src/editor/mainwindow.cpp:730:49: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] jag-0.3.8/src/editor/mainwindow.cpp:730:83: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] jag-0.3.8/src/editor/mainwindow.cpp:731:47: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] jag-0.3.8/src/editor/mainwindow.cpp:731:80: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] jag-0.3.8/src/editor/mainwindow.cpp:732:47: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] jag-0.3.8/src/editor/mainwindow.cpp:732:80: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] jag-0.3.8/src/editor/mainwindow.cpp:733:49: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] jag-0.3.8/src/editor/mainwindow.cpp:733:85: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] jag-0.3.8/src/editor/mainwindow.cpp:734:51: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] jag-0.3.8/src/editor/mainwindow.cpp:734:88: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] jag-0.3.8/src/gamescene.cpp:57:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FramelessWindowHint [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamescene.cpp:145:96: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SmoothTransformation [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamescene.cpp:273:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AlignCenter [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamescene.cpp:340:27: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamescene.cpp:1453:67: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SmoothTransformation [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamewidget.cpp:66:40: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SmartViewportUpdate [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamewidget.cpp:120:31: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable black [valueFlowBailoutIncompleteVar] jag-0.3.8/src/randomkilltool.h:38:42: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AutoTool [valueFlowBailoutIncompleteVar] jag-0.3.8/src/mixertool.h:38:44: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AutoTool [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gametools.cpp:75:64: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SmoothTransformation [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gametools.cpp:102:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable white [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gametools.cpp:308:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable lightGray [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamewidget.cpp:46:3: style: Obsolete function 'qsrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqsrandCalled] jag-0.3.8/src/gamewidget.cpp:184:13: style: Obsolete function 'qrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqrandCalled] jag-0.3.8/src/gamexml.cpp:35:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable WriteOnly [valueFlowBailoutIncompleteVar] jag-0.3.8/src/gamexml.cpp:118:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] jag-0.3.8/src/hammertool.cpp:45:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ToolActive [valueFlowBailoutIncompleteVar] jag-0.3.8/src/hammertool.h:36:12: style: The destructor '~HammerTool' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:53:12: note: Virtual destructor in base class jag-0.3.8/src/hammertool.h:36:12: note: Destructor in derived class jag-0.3.8/src/hammertool.h:38:14: style: The function 'checkItemState' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:83:22: note: Virtual function in base class jag-0.3.8/src/hammertool.h:38:14: note: Function in derived class jag-0.3.8/src/hammertool.h:39:8: style: The function 'checkItemClick' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:82:16: note: Virtual function in base class jag-0.3.8/src/hammertool.h:39:8: note: Function in derived class jag-0.3.8/src/hammertool.cpp:43:16: style: Variable 'pi' can be declared as reference to const [constVariableReference] jag-0.3.8/src/hammertool.cpp:55:14: style: Variable 'pi' can be declared as reference to const [constVariableReference] jag-0.3.8/src/gametools.cpp:58:11: warning: Member variable 'GameTool::bonusInfo' is not initialized in the constructor. [uninitMemberVar] jag-0.3.8/src/gametools.cpp:74:3: performance: Variable 'myPixmap' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] jag-0.3.8/src/gametools.cpp:82:16: performance:inconclusive: Either there is a missing 'override', or the member function 'GameTool::setCurrent' can be static. [functionStatic] jag-0.3.8/src/gametools.h:58:8: note: Either there is a missing 'override', or the member function 'GameTool::setCurrent' can be static. jag-0.3.8/src/gametools.cpp:82:16: note: Either there is a missing 'override', or the member function 'GameTool::setCurrent' can be static. jag-0.3.8/src/gametools.cpp:271:15: style:inconclusive: Technically the member function 'ToolSet::writeProfile' can be const. [functionConst] jag-0.3.8/src/gametools.h:116:10: note: Technically the member function 'ToolSet::writeProfile' can be const. jag-0.3.8/src/gametools.cpp:271:15: note: Technically the member function 'ToolSet::writeProfile' can be const. jag-0.3.8/src/gametools.cpp:407:15: style:inconclusive: Technically the member function 'ToolSet::checkMouseHover' can be const. [functionConst] jag-0.3.8/src/gametools.h:131:10: note: Technically the member function 'ToolSet::checkMouseHover' can be const. jag-0.3.8/src/gametools.cpp:407:15: note: Technically the member function 'ToolSet::checkMouseHover' can be const. jag-0.3.8/src/smallhammertool.h:36:12: style: The destructor '~SmallHammerTool' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:53:12: note: Virtual destructor in base class jag-0.3.8/src/smallhammertool.h:36:12: note: Destructor in derived class jag-0.3.8/src/smallhammertool.h:38:14: style: The function 'checkItemState' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:83:22: note: Virtual function in base class jag-0.3.8/src/smallhammertool.h:38:14: note: Function in derived class jag-0.3.8/src/smallhammertool.h:39:8: style: The function 'checkItemClick' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:82:16: note: Virtual function in base class jag-0.3.8/src/smallhammertool.h:39:8: note: Function in derived class jag-0.3.8/src/thundertool.h:36:12: style: The destructor '~ThunderTool' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:53:12: note: Virtual destructor in base class jag-0.3.8/src/thundertool.h:36:12: note: Destructor in derived class jag-0.3.8/src/thundertool.h:38:14: style: The function 'checkItemState' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:83:22: note: Virtual function in base class jag-0.3.8/src/thundertool.h:38:14: note: Function in derived class jag-0.3.8/src/main.cpp:70:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Close [valueFlowBailoutIncompleteVar] jag-0.3.8/src/thundertool.h:39:8: style: The function 'checkItemClick' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:82:16: note: Virtual function in base class jag-0.3.8/src/thundertool.h:39:8: note: Function in derived class jag-0.3.8/src/randomkilltool.h:36:12: style: The destructor '~RandomKillTool' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:53:12: note: Virtual destructor in base class jag-0.3.8/src/randomkilltool.h:36:12: note: Destructor in derived class jag-0.3.8/src/randomkilltool.h:38:20: style: The function 'type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:55:20: note: Virtual function in base class jag-0.3.8/src/randomkilltool.h:38:20: note: Function in derived class jag-0.3.8/src/randomkilltool.h:40:16: style: The function 'checkToolClick' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:86:16: note: Virtual function in base class jag-0.3.8/src/randomkilltool.h:40:16: note: Function in derived class jag-0.3.8/src/mixertool.h:36:14: style: The destructor '~MixerTool' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:53:12: note: Virtual destructor in base class jag-0.3.8/src/mixertool.h:36:14: note: Destructor in derived class jag-0.3.8/src/mixertool.h:38:22: style: The function 'type' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:55:20: note: Virtual function in base class jag-0.3.8/src/mixertool.h:38:22: note: Function in derived class jag-0.3.8/src/mixertool.h:40:18: style: The function 'checkToolClick' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:86:16: note: Virtual function in base class jag-0.3.8/src/mixertool.h:40:18: note: Function in derived class jag-0.3.8/src/unblocktool.h:36:12: style: The destructor '~UnblockTool' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:53:12: note: Virtual destructor in base class jag-0.3.8/src/unblocktool.h:36:12: note: Destructor in derived class jag-0.3.8/src/unblocktool.h:38:22: style: The function 'checkItemState' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:83:22: note: Virtual function in base class jag-0.3.8/src/unblocktool.h:38:22: note: Function in derived class jag-0.3.8/src/unblocktool.h:39:16: style: The function 'checkItemClick' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:82:16: note: Virtual function in base class jag-0.3.8/src/unblocktool.h:39:16: note: Function in derived class jag-0.3.8/src/twintool.h:36:12: style: The destructor '~TwinTool' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:53:12: note: Virtual destructor in base class jag-0.3.8/src/twintool.h:36:12: note: Destructor in derived class jag-0.3.8/src/twintool.h:38:14: style: The function 'checkItemState' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:83:22: note: Virtual function in base class jag-0.3.8/src/twintool.h:38:14: note: Function in derived class jag-0.3.8/src/twintool.h:39:8: style: The function 'checkItemClick' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] jag-0.3.8/src/gametools.h:82:16: note: Virtual function in base class jag-0.3.8/src/twintool.h:39:8: note: Function in derived class jag-0.3.8/src/gametools.cpp:256:8: style: Variable 'diff' is reassigned a value before the old one has been used. [redundantAssignment] jag-0.3.8/src/gametools.cpp:251:8: note: diff is assigned jag-0.3.8/src/gametools.cpp:256:8: note: diff is overwritten jag-0.3.8/src/gametools.cpp:238:15: style: Local variable 'tool' shadows outer function [shadowFunction] jag-0.3.8/src/gametools.h:108:22: note: Shadowed declaration jag-0.3.8/src/gametools.cpp:238:15: note: Shadow variable jag-0.3.8/src/gametools.cpp:294:15: style: Local variable 'tool' shadows outer function [shadowFunction] jag-0.3.8/src/gametools.h:108:22: note: Shadowed declaration jag-0.3.8/src/gametools.cpp:294:15: note: Shadow variable jag-0.3.8/src/gametools.cpp:319:15: style: Local variable 'tool' shadows outer function [shadowFunction] jag-0.3.8/src/gametools.h:108:22: note: Shadowed declaration jag-0.3.8/src/gametools.cpp:319:15: note: Shadow variable jag-0.3.8/src/gametools.cpp:328:15: style: Local variable 'tool' shadows outer function [shadowFunction] jag-0.3.8/src/gametools.h:108:22: note: Shadowed declaration jag-0.3.8/src/gametools.cpp:328:15: note: Shadow variable jag-0.3.8/src/gametools.cpp:411:15: style: Local variable 'tool' shadows outer function [shadowFunction] jag-0.3.8/src/gametools.h:108:22: note: Shadowed declaration jag-0.3.8/src/gametools.cpp:411:15: note: Shadow variable jag-0.3.8/src/main.cpp:112:13: style: Condition '!langpath.isEmpty()' is always true [knownConditionTrueFalse] jag-0.3.8/src/gametools.cpp:411:15: style: Variable 'tool' can be declared as pointer to const [constVariablePointer] jag-0.3.8/src/mixertool.cpp:64:22: style: Obsolete function 'qrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqrandCalled] jag-0.3.8/src/randomkilltool.cpp:64:22: style: Obsolete function 'qrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqrandCalled] jag-0.3.8/src/menucontrol.cpp:140:94: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MatchFixedString [valueFlowBailoutIncompleteVar] jag-0.3.8/src/menucontrol.cpp:186:76: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MatchFixedString [valueFlowBailoutIncompleteVar] jag-0.3.8/src/menucontrol.cpp:208:98: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable MatchFixedString [valueFlowBailoutIncompleteVar] jag-0.3.8/src/menucontrol.cpp:229:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] jag-0.3.8/src/menucontrol.cpp:318:45: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Close [valueFlowBailoutIncompleteVar] jag-0.3.8/src/menucontrol.cpp:415:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FramelessWindowHint [valueFlowBailoutIncompleteVar] jag-0.3.8/src/menucontrol.cpp:464:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Normal [valueFlowBailoutIncompleteVar] jag-0.3.8/src/menucontrol.cpp:486:61: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable Cancel [valueFlowBailoutIncompleteVar] jag-0.3.8/src/menucontrol.cpp:556:24: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ReadOnly [valueFlowBailoutIncompleteVar] jag-0.3.8/src/smallhammertool.cpp:45:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ToolActive [valueFlowBailoutIncompleteVar] jag-0.3.8/src/smallhammertool.cpp:43:16: style: Variable 'pi' can be declared as reference to const [constVariableReference] jag-0.3.8/src/smallhammertool.cpp:55:14: style: Variable 'pi' can be declared as reference to const [constVariableReference] jag-0.3.8/src/thundertool.cpp:45:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ToolOutOfRange [valueFlowBailoutIncompleteVar] jag-0.3.8/src/thundertool.cpp:75:16: style: Local variable 'pi' shadows outer variable [shadowVariable] jag-0.3.8/src/thundertool.cpp:67:14: note: Shadowed declaration jag-0.3.8/src/thundertool.cpp:75:16: note: Shadow variable jag-0.3.8/src/thundertool.cpp:43:14: style: Variable 'pi1' can be declared as reference to const [constVariableReference] jag-0.3.8/src/thundertool.cpp:49:16: style: Variable 'pi' can be declared as reference to const [constVariableReference] jag-0.3.8/src/thundertool.cpp:67:14: style: Variable 'pi' can be declared as reference to const [constVariableReference] jag-0.3.8/src/thundertool.cpp:75:16: style: Variable 'pi' can be declared as reference to const [constVariableReference] jag-0.3.8/src/menucontrol.cpp:567:29: style: Variable 'curlang' is assigned a value that is never used. [unreadVariable] jag-0.3.8/src/menucontrol.cpp:567:21: style: Variable 'curlang' is assigned a value that is never used. [unreadVariable] jag-0.3.8/src/twintool.cpp:46:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ToolActive [valueFlowBailoutIncompleteVar] jag-0.3.8/src/unblocktool.cpp:45:14: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ToolActive [valueFlowBailoutIncompleteVar] jag-0.3.8/src/twintool.cpp:40:14: style: Variable 'pi' can be declared as reference to const [constVariableReference] jag-0.3.8/src/twintool.cpp:41:14: style: Variable 'pi1' can be declared as reference to const [constVariableReference] jag-0.3.8/src/twintool.cpp:54:14: style: Variable 'pi' can be declared as reference to const [constVariableReference] jag-0.3.8/src/twintool.cpp:65:20: style: Variable 'pi1' can be declared as reference to const [constVariableReference] jag-0.3.8/src/unblocktool.cpp:43:16: style: Variable 'pi' can be declared as reference to const [constVariableReference] jag-0.3.8/src/gamescene.cpp:182:3: style: Obsolete function 'qsrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqsrandCalled] jag-0.3.8/src/gamescene.cpp:475:27: style: Obsolete function 'qrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqrandCalled] jag-0.3.8/src/gamescene.cpp:702:40: style: Obsolete function 'qrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqrandCalled] jag-0.3.8/src/gamescene.cpp:716:54: style: Obsolete function 'qrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqrandCalled] jag-0.3.8/src/gamescene.cpp:1452:31: style: Obsolete function 'qrand' called. It is recommended to use 'QRandomGenerator' instead. [prohibitedqrandCalled] jag-0.3.8/src/gamescene.cpp:1019:11: style: Condition '!is_fill' is always true [knownConditionTrueFalse] jag-0.3.8/src/gamescene.cpp:1012:11: note: Assuming that condition 'is_fill' is not redundant jag-0.3.8/src/gamescene.cpp:1019:11: note: Condition '!is_fill' is always true jag-0.3.8/src/gamescene.cpp:1019:23: style: Condition '!is_fall' is always true [knownConditionTrueFalse] jag-0.3.8/src/gamescene.cpp:1012:22: note: Assuming that condition 'is_fall' is not redundant jag-0.3.8/src/gamescene.cpp:1019:23: note: Condition '!is_fall' is always true jag-0.3.8/src/gamescene.cpp:1019:35: style: Condition '!is_remove' is always true [knownConditionTrueFalse] jag-0.3.8/src/gamescene.cpp:1012:33: note: Assuming that condition 'is_remove' is not redundant jag-0.3.8/src/gamescene.cpp:1019:35: note: Condition '!is_remove' is always true jag-0.3.8/src/gamescene.cpp:575:40: style: C-style pointer casting [cstyleCast] jag-0.3.8/src/gamescene.cpp:576:43: style: C-style pointer casting [cstyleCast] jag-0.3.8/src/gamescene.cpp:577:40: style: C-style pointer casting [cstyleCast] jag-0.3.8/src/gamescene.cpp:578:43: style: C-style pointer casting [cstyleCast] jag-0.3.8/src/gamescene.cpp:959:15: style: The scope of the variable 'check_moves' can be reduced. [variableScope] jag-0.3.8/src/gamescene.cpp:942:38: style:inconclusive: Function 'scheduleItemMove' argument 1 names different: declaration 'row1' definition 'r1'. [funcArgNamesDifferent] jag-0.3.8/src/gamescene.h:153:31: note: Function 'scheduleItemMove' argument 1 names different: declaration 'row1' definition 'r1'. jag-0.3.8/src/gamescene.cpp:942:38: note: Function 'scheduleItemMove' argument 1 names different: declaration 'row1' definition 'r1'. jag-0.3.8/src/gamescene.cpp:942:45: style:inconclusive: Function 'scheduleItemMove' argument 2 names different: declaration 'col1' definition 'c1'. [funcArgNamesDifferent] jag-0.3.8/src/gamescene.h:153:41: note: Function 'scheduleItemMove' argument 2 names different: declaration 'col1' definition 'c1'. jag-0.3.8/src/gamescene.cpp:942:45: note: Function 'scheduleItemMove' argument 2 names different: declaration 'col1' definition 'c1'. jag-0.3.8/src/gamescene.cpp:942:53: style:inconclusive: Function 'scheduleItemMove' argument 3 names different: declaration 'row2' definition 'r2'. [funcArgNamesDifferent] jag-0.3.8/src/gamescene.h:153:51: note: Function 'scheduleItemMove' argument 3 names different: declaration 'row2' definition 'r2'. jag-0.3.8/src/gamescene.cpp:942:53: note: Function 'scheduleItemMove' argument 3 names different: declaration 'row2' definition 'r2'. jag-0.3.8/src/gamescene.cpp:942:60: style:inconclusive: Function 'scheduleItemMove' argument 4 names different: declaration 'col2' definition 'c2'. [funcArgNamesDifferent] jag-0.3.8/src/gamescene.h:153:61: note: Function 'scheduleItemMove' argument 4 names different: declaration 'col2' definition 'c2'. jag-0.3.8/src/gamescene.cpp:942:60: note: Function 'scheduleItemMove' argument 4 names different: declaration 'col2' definition 'c2'. jag-0.3.8/src/gamescene.cpp:573:13: style: Local variable 'currentRow' shadows outer variable [shadowVariable] jag-0.3.8/src/gamescene.h:176:9: note: Shadowed declaration jag-0.3.8/src/gamescene.cpp:573:13: note: Shadow variable jag-0.3.8/src/gamescene.cpp:573:29: style: Local variable 'currentCol' shadows outer variable [shadowVariable] jag-0.3.8/src/gamescene.h:176:21: note: Shadowed declaration jag-0.3.8/src/gamescene.cpp:573:29: note: Shadow variable jag-0.3.8/src/gamescene.cpp:574:13: style: Local variable 'targetRow' shadows outer variable [shadowVariable] jag-0.3.8/src/gamescene.h:177:9: note: Shadowed declaration jag-0.3.8/src/gamescene.cpp:574:13: note: Shadow variable jag-0.3.8/src/gamescene.cpp:574:28: style: Local variable 'targetCol' shadows outer variable [shadowVariable] jag-0.3.8/src/gamescene.h:177:20: note: Shadowed declaration jag-0.3.8/src/gamescene.cpp:574:28: note: Shadow variable jag-0.3.8/src/gamescene.cpp:602:13: style: Local variable 'currentRow' shadows outer variable [shadowVariable] jag-0.3.8/src/gamescene.h:176:9: note: Shadowed declaration jag-0.3.8/src/gamescene.cpp:602:13: note: Shadow variable jag-0.3.8/src/gamescene.cpp:602:29: style: Local variable 'currentCol' shadows outer variable [shadowVariable] jag-0.3.8/src/gamescene.h:176:21: note: Shadowed declaration jag-0.3.8/src/gamescene.cpp:602:29: note: Shadow variable jag-0.3.8/src/gamescene.cpp:603:13: style: Local variable 'targetRow' shadows outer variable [shadowVariable] jag-0.3.8/src/gamescene.h:177:9: note: Shadowed declaration jag-0.3.8/src/gamescene.cpp:603:13: note: Shadow variable jag-0.3.8/src/gamescene.cpp:603:30: style: Local variable 'targetCol' shadows outer variable [shadowVariable] jag-0.3.8/src/gamescene.h:177:20: note: Shadowed declaration jag-0.3.8/src/gamescene.cpp:603:30: note: Shadow variable jag-0.3.8/src/gamescene.cpp:913:20: style: Local variable 'pi1' shadows outer variable [shadowVariable] jag-0.3.8/src/gamescene.cpp:903:18: note: Shadowed declaration jag-0.3.8/src/gamescene.cpp:913:20: note: Shadow variable jag-0.3.8/src/gamescene.cpp:924:20: style: Local variable 'pi1' shadows outer variable [shadowVariable] jag-0.3.8/src/gamescene.cpp:903:18: note: Shadowed declaration jag-0.3.8/src/gamescene.cpp:924:20: note: Shadow variable jag-0.3.8/src/gamescene.cpp:192:16: style: Variable 'pi' can be declared as reference to const [constVariableReference] jag-0.3.8/src/gamescene.cpp:639:19: style: Variable 'pi1' can be declared as reference to const [constVariableReference] jag-0.3.8/src/gamescene.cpp:640:19: style: Variable 'pi2' can be declared as reference to const [constVariableReference] jag-0.3.8/src/gamescene.cpp:641:19: style: Variable 'pi3' can be declared as reference to const [constVariableReference] jag-0.3.8/src/gamescene.cpp:648:19: style: Variable 'pi4' can be declared as reference to const [constVariableReference] jag-0.3.8/src/gamescene.cpp:655:19: style: Variable 'pi5' can be declared as reference to const [constVariableReference] jag-0.3.8/src/gamescene.cpp:668:19: style: Variable 'pi1' can be declared as reference to const [constVariableReference] jag-0.3.8/src/gamescene.cpp:669:19: style: Variable 'pi2' can be declared as reference to const [constVariableReference] jag-0.3.8/src/gamescene.cpp:670:19: style: Variable 'pi3' can be declared as reference to const [constVariableReference] jag-0.3.8/src/gamescene.cpp:677:19: style: Variable 'pi4' can be declared as reference to const [constVariableReference] jag-0.3.8/src/gamescene.cpp:684:19: style: Variable 'pi5' can be declared as reference to const [constVariableReference] jag-0.3.8/src/gamescene.cpp:738:16: style: Variable 'pi' can be declared as reference to const [constVariableReference] jag-0.3.8/src/gamescene.cpp:749:18: style: Variable 'pi1' can be declared as reference to const [constVariableReference] jag-0.3.8/src/gamescene.cpp:778:16: style: Variable 'pi' can be declared as reference to const [constVariableReference] jag-0.3.8/src/gamescene.cpp:789:18: style: Variable 'pi1' can be declared as reference to const [constVariableReference] jag-0.3.8/src/gamescene.cpp:898:18: style: Variable 'pi' can be declared as reference to const [constVariableReference] jag-0.3.8/src/gamescene.cpp:903:18: style: Variable 'pi1' can be declared as reference to const [constVariableReference] jag-0.3.8/src/gamescene.cpp:913:20: style: Variable 'pi1' can be declared as reference to const [constVariableReference] jag-0.3.8/src/gamescene.cpp:924:20: style: Variable 'pi1' can be declared as reference to const [constVariableReference] jag-0.3.8/src/gamescene.cpp:1144:16: style: Variable 'pi' can be declared as reference to const [constVariableReference] diff: 2.18.0 jag-0.3.8/src/gamebackground.cpp:133:3: warning: Class 'GameBackground' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] head jag-0.3.8/src/gamebackground.cpp:133:3: warning: Class 'GameBackground' does not have a copy constructor which is recommended since it has dynamic memory/resource management. [noCopyConstructor] 2.18.0 jag-0.3.8/src/gamebackground.cpp:133:3: warning: Class 'GameBackground' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] head jag-0.3.8/src/gamebackground.cpp:133:3: warning: Class 'GameBackground' does not have a operator= which is recommended since it has dynamic memory/resource management. [noOperatorEq] DONE