2024-04-17 13:01 ftp://ftp.de.debian.org/debian/pool/main/i/ippl/ippl_1.4.14.orig.tar.gz cppcheck-options: --library=posix --library=gnu --library=bsd --inconclusive --enable=style,information --inline-suppr --template=daca2 --disable=missingInclude --suppress=unmatchedSuppression --check-library --debug-warnings --suppress=autoNoType --suppress=valueFlowBailout --suppress=bailoutUninitVar --suppress=symbolDatabaseWarning -D__GNUC__ --platform=unix64 -j1 platform: Linux-5.15.0-102-generic-x86_64-with-glibc2.35 python: 3.10.12 client-version: 1.3.56 compiler: g++ (Ubuntu 12.3.0-1ubuntu1~22.04) 12.3.0 cppcheck: head 2.13.0 head-info: 3a212f1 (2024-04-17 11:43:08 +0200) count: 59 42 elapsed-time: 0.5 0.4 head-timing-info: old-timing-info: head results: ippl-1.4.14/Source/configuration.c:104:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable DEFAULT_USER [valueFlowBailoutIncompleteVar] ippl-1.4.14/Source/configuration.c:80:16: portability: Assigning an integer to a pointer is not portable. [AssignmentIntegerToAddress] ippl-1.4.14/Source/filter.c:85:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IPPROTO_ICMP [valueFlowBailoutIncompleteVar] ippl-1.4.14/Source/filter.c:147:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FNM_NOESCAPE [valueFlowBailoutIncompleteVar] ippl-1.4.14/Source/filter.c:224:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IPPROTO_ICMP [valueFlowBailoutIncompleteVar] ippl-1.4.14/Source/filter.c:310:19: style: Obsolescent function 'gethostbyname' called. It is recommended to use 'getaddrinfo' instead. [prohibitedgethostbynameCalled] ippl-1.4.14/Source/filter.c:205:36: style:inconclusive: Function 'do_log' argument 1 names different: declaration 'saddr' definition 'from'. [funcArgNamesDifferent] ippl-1.4.14/Source/filter.h:79:36: note: Function 'do_log' argument 1 names different: declaration 'saddr' definition 'from'. ippl-1.4.14/Source/filter.c:205:36: note: Function 'do_log' argument 1 names different: declaration 'saddr' definition 'from'. ippl-1.4.14/Source/filter.c:205:54: style:inconclusive: Function 'do_log' argument 2 names different: declaration 'daddr' definition 'to'. [funcArgNamesDifferent] ippl-1.4.14/Source/filter.h:79:55: note: Function 'do_log' argument 2 names different: declaration 'daddr' definition 'to'. ippl-1.4.14/Source/filter.c:205:54: note: Function 'do_log' argument 2 names different: declaration 'daddr' definition 'to'. ippl-1.4.14/Source/filter.c:114:82: style: Parameter 'name' can be declared as pointer to const [constParameterPointer] ippl-1.4.14/Source/filter.c:300:20: style: Variable 'host' can be declared as pointer to const [constVariablePointer] ippl-1.4.14/Source/icmp.c:230:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ihl [valueFlowBailoutIncompleteVar] ippl-1.4.14/Source/icmp.c:292:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable icmphdr [valueFlowBailoutIncompleteVar] ippl-1.4.14/Source/ident.c:61:20: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable AF_INET [valueFlowBailoutIncompleteVar] ippl-1.4.14/Source/ident.c:96:7: error: Width 64 given in format string (no. 3) is larger than destination buffer 'user[64]', use %63s to prevent overflowing it. [invalidScanfFormatWidth] ippl-1.4.14/Source/log.c:76:21: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LOG_NOTICE [valueFlowBailoutIncompleteVar] ippl-1.4.14/Source/log.c:123:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LOG_DAEMON [valueFlowBailoutIncompleteVar] ippl-1.4.14/Source/log.c:194:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable O_WRONLY [valueFlowBailoutIncompleteVar] ippl-1.4.14/Source/log.c:164:3: warning:inconclusive: The buffer 'last_message' may not be null-terminated after the call to strncpy(). [terminateStrncpy] ippl-1.4.14/Source/log.c:150:24: style: Obsolete function 'asctime' called. It is recommended to use 'strftime' instead. [prohibitedasctimeCalled] ippl-1.4.14/Source/log.c:150:32: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] ippl-1.4.14/Source/log.c:158:22: style: Obsolete function 'asctime' called. It is recommended to use 'strftime' instead. [prohibitedasctimeCalled] ippl-1.4.14/Source/log.c:158:30: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] ippl-1.4.14/Source/log.c:151:5: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] ippl-1.4.14/Source/log.c:90:44: style: Parameter 'filename' can be declared as pointer to const [constParameterPointer] ippl-1.4.14/Source/log.c:112:22: style: Parameter 'fd' can be declared as pointer to const. However it seems that 'dummy_open' is a callback function, if 'fd' is declared with const you might also need to cast function pointer(s). [constParameterCallback] ippl-1.4.14/Source/log.c:58:14: note: You might need to cast the function pointer here ippl-1.4.14/Source/log.c:112:22: note: Parameter 'fd' can be declared as pointer to const ippl-1.4.14/Source/log.c:113:23: style: Parameter 'fd' can be declared as pointer to const. However it seems that 'dummy_close' is a callback function, if 'fd' is declared with const you might also need to cast function pointer(s). [constParameterCallback] ippl-1.4.14/Source/log.c:81:15: note: You might need to cast the function pointer here ippl-1.4.14/Source/log.c:113:23: note: Parameter 'fd' can be declared as pointer to const ippl-1.4.14/Source/log.c:121:23: style: Parameter 'level' can be declared as pointer to const. However it seems that 'syslog_open' is a callback function, if 'level' is declared with const you might also need to cast function pointer(s). [constParameterCallback] ippl-1.4.14/Source/log.c:80:14: note: You might need to cast the function pointer here ippl-1.4.14/Source/log.c:121:23: note: Parameter 'level' can be declared as pointer to const ippl-1.4.14/Source/log.c:132:30: style: Parameter 'entry' can be declared as pointer to const [constParameterPointer] ippl-1.4.14/Source/log.c:206:22: style: Parameter 'fd' can be declared as pointer to const. However it seems that 'file_close' is a callback function, if 'fd' is declared with const you might also need to cast function pointer(s). [constParameterCallback] ippl-1.4.14/Source/log.c:100:15: note: You might need to cast the function pointer here ippl-1.4.14/Source/log.c:206:22: note: Parameter 'fd' can be declared as pointer to const ippl-1.4.14/Source/main.c:77:34: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable VERSION [valueFlowBailoutIncompleteVar] ippl-1.4.14/Source/main.c:96:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SIG_BLOCK [valueFlowBailoutIncompleteVar] ippl-1.4.14/Source/main.c:230:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PATH_MAX [valueFlowBailoutIncompleteVar] ippl-1.4.14/Source/main.c:293:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PID_FILE [valueFlowBailoutIncompleteVar] ippl-1.4.14/Source/main.c:342:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PID_FILE [valueFlowBailoutIncompleteVar] ippl-1.4.14/Source/main.c:393:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CONFIGURATION_FILE [valueFlowBailoutIncompleteVar] ippl-1.4.14/Source/main.c:123:13: portability: Non reentrant function 'getpwnam' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getpwnam_r'. [prohibitedgetpwnamCalled] ippl-1.4.14/Source/main.c:231:24: style: Variable 'long_options' can be declared as const array [constVariable] ippl-1.4.14/Source/netutils.c:108:49: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable in_addr [valueFlowBailoutIncompleteVar] ippl-1.4.14/Source/netutils.c:108:8: style: Obsolescent function 'gethostbyaddr' called. It is recommended to use 'getnameinfo' instead. [prohibitedgethostbyaddrCalled] ippl-1.4.14/Source/netutils.c:244:8: portability: Non reentrant function 'getservbyport' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getservbyport_r'. [prohibitedgetservbyportCalled] ippl-1.4.14/Source/netutils.c:105:19: style: Variable 'he' can be declared as pointer to const [constVariablePointer] ippl-1.4.14/Source/netutils.c:240:27: style: Parameter 'proto' can be declared as pointer to const [constParameterPointer] ippl-1.4.14/Source/netutils.c:241:19: style: Variable 'se' can be declared as pointer to const [constVariablePointer] ippl-1.4.14/Source/pidfile.c:73:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable errno [valueFlowBailoutIncompleteVar] ippl-1.4.14/Source/pidfile.c:90:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable O_RDWR [valueFlowBailoutIncompleteVar] ippl-1.4.14/Source/pidfile.c:106:7: error: Resource handle 'fd' freed twice. [doubleFree] ippl-1.4.14/Source/pidfile.c:91:17: note: Resource handle 'fd' freed twice. ippl-1.4.14/Source/pidfile.c:106:7: note: Resource handle 'fd' freed twice. ippl-1.4.14/Source/pidfile.c:107:7: error: Resource leak: f [resourceLeak] ippl-1.4.14/Source/pidfile.c:113:7: error: Resource handle 'fd' freed twice. [doubleFree] ippl-1.4.14/Source/pidfile.c:91:17: note: Resource handle 'fd' freed twice. ippl-1.4.14/Source/pidfile.c:113:7: note: Resource handle 'fd' freed twice. ippl-1.4.14/Source/pidfile.c:114:7: error: Resource leak: f [resourceLeak] ippl-1.4.14/Source/pidfile.c:116:3: error: Resource handle 'fd' freed twice. [doubleFree] ippl-1.4.14/Source/pidfile.c:91:17: note: Resource handle 'fd' freed twice. ippl-1.4.14/Source/pidfile.c:116:3: note: Resource handle 'fd' freed twice. ippl-1.4.14/Source/pidfile.c:118:3: error: Resource leak: f [resourceLeak] ippl-1.4.14/Source/pidfile.c:41:21: style: Parameter 'pidfile' can be declared as pointer to const [constParameterPointer] ippl-1.4.14/Source/pidfile.c:84:22: style: Parameter 'pidfile' can be declared as pointer to const [constParameterPointer] ippl-1.4.14/Source/pidfile.c:126:23: style: Parameter 'pidfile' can be declared as pointer to const [constParameterPointer] ippl-1.4.14/Source/tcp.c:80:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable saddr [valueFlowBailoutIncompleteVar] ippl-1.4.14/Source/tcp.c:179:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable saddr [valueFlowBailoutIncompleteVar] ippl-1.4.14/Source/tcp.c:249:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable tcphdr [valueFlowBailoutIncompleteVar] ippl-1.4.14/Source/udp.c:70:26: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable ihl [valueFlowBailoutIncompleteVar] ippl-1.4.14/Source/udp.c:134:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable udphdr [valueFlowBailoutIncompleteVar] diff: head ippl-1.4.14/Source/filter.c:147:38: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable FNM_NOESCAPE [valueFlowBailoutIncompleteVar] head ippl-1.4.14/Source/filter.c:224:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable IPPROTO_ICMP [valueFlowBailoutIncompleteVar] head ippl-1.4.14/Source/icmp.c:292:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable icmphdr [valueFlowBailoutIncompleteVar] head ippl-1.4.14/Source/log.c:112:22: style: Parameter 'fd' can be declared as pointer to const. However it seems that 'dummy_open' is a callback function, if 'fd' is declared with const you might also need to cast function pointer(s). [constParameterCallback] ippl-1.4.14/Source/log.c:58:14: note: You might need to cast the function pointer here ippl-1.4.14/Source/log.c:112:22: note: Parameter 'fd' can be declared as pointer to const head ippl-1.4.14/Source/log.c:113:23: style: Parameter 'fd' can be declared as pointer to const. However it seems that 'dummy_close' is a callback function, if 'fd' is declared with const you might also need to cast function pointer(s). [constParameterCallback] ippl-1.4.14/Source/log.c:81:15: note: You might need to cast the function pointer here ippl-1.4.14/Source/log.c:113:23: note: Parameter 'fd' can be declared as pointer to const head ippl-1.4.14/Source/log.c:121:23: style: Parameter 'level' can be declared as pointer to const. However it seems that 'syslog_open' is a callback function, if 'level' is declared with const you might also need to cast function pointer(s). [constParameterCallback] ippl-1.4.14/Source/log.c:80:14: note: You might need to cast the function pointer here ippl-1.4.14/Source/log.c:121:23: note: Parameter 'level' can be declared as pointer to const head ippl-1.4.14/Source/log.c:123:22: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable LOG_DAEMON [valueFlowBailoutIncompleteVar] head ippl-1.4.14/Source/log.c:194:39: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable O_WRONLY [valueFlowBailoutIncompleteVar] head ippl-1.4.14/Source/main.c:230:13: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PATH_MAX [valueFlowBailoutIncompleteVar] head ippl-1.4.14/Source/main.c:293:17: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PID_FILE [valueFlowBailoutIncompleteVar] head ippl-1.4.14/Source/main.c:342:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable PID_FILE [valueFlowBailoutIncompleteVar] head ippl-1.4.14/Source/main.c:393:33: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable CONFIGURATION_FILE [valueFlowBailoutIncompleteVar] head ippl-1.4.14/Source/main.c:96:19: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable SIG_BLOCK [valueFlowBailoutIncompleteVar] head ippl-1.4.14/Source/pidfile.c:90:29: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable O_RDWR [valueFlowBailoutIncompleteVar] head ippl-1.4.14/Source/tcp.c:179:23: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable saddr [valueFlowBailoutIncompleteVar] head ippl-1.4.14/Source/tcp.c:249:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable tcphdr [valueFlowBailoutIncompleteVar] head ippl-1.4.14/Source/udp.c:134:12: debug: valueFlowConditionExpressions bailout: Skipping function due to incomplete variable udphdr [valueFlowBailoutIncompleteVar] DONE