2022-06-22 16:19
ftp://ftp.de.debian.org/debian/pool/main/i/instead/instead_3.3.2.orig.tar.gz
cppcheck-options: --library=posix --library=gnu  --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j1
platform: Linux-5.4.0-120-generic-x86_64-with-glibc2.29
python: 3.8.10
client-version: 1.3.24
compiler: g++ (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
cppcheck: head 2.8
head-info: 650f409 (2022-06-22 08:46:48 +0200)
count: 130 132
elapsed-time: 136.0 206.2
head-timing-info:
 Tokenizer::simplifyTokens1: 43.4065s (avg. 0.86813s - 50 result(s))
 Tokenizer::simplifyTokens1::ValueFlow: 41.7195s (avg. 0.834389s - 50 result(s))
 Tokenizer::simplifyTokens1::createSymbolDatabase: 0.831327s (avg. 0.0166265s - 50 result(s))
 Tokenizer::createTokens: 0.249923s (avg. 0.0046282s - 54 result(s))
 UnusedVar::runChecks: 0.233548s (avg. 0.00467096s - 50 result(s))
 Overall time: 87.5263s

old-timing-info:
 Tokenizer::simplifyTokens1: 66.6204s (avg. 1.33241s - 50 result(s))
 Tokenizer::simplifyTokens1::ValueFlow: 65.0329s (avg. 1.30066s - 50 result(s))
 Tokenizer::simplifyTokens1::createSymbolDatabase: 0.793234s (avg. 0.0158647s - 50 result(s))
 Tokenizer::createTokens: 0.229117s (avg. 0.00424291s - 54 result(s))
 UnusedVar::runChecks: 0.227786s (avg. 0.00455572s - 50 result(s))
 Overall time: 133.907s

head results:
instead-3.3.2/src/SDL2_rotozoom.c:814:32: style: Condition 'src->format->BitsPerPixel==16' is always false [knownConditionTrueFalse]
instead-3.3.2/src/SDL2_rotozoom.c:813:32: note: Assuming that condition 'src->format->BitsPerPixel==8' is not redundant
instead-3.3.2/src/SDL2_rotozoom.c:814:32: note: Condition 'src->format->BitsPerPixel==16' is always false
instead-3.3.2/src/SDL2_rotozoom.c:815:32: style: Condition 'src->format->BitsPerPixel==24' is always false [knownConditionTrueFalse]
instead-3.3.2/src/SDL2_rotozoom.c:813:32: note: Assuming that condition 'src->format->BitsPerPixel==8' is not redundant
instead-3.3.2/src/SDL2_rotozoom.c:815:32: note: Condition 'src->format->BitsPerPixel==24' is always false
instead-3.3.2/src/SDL2_rotozoom.c:125:22: warning: Either the condition 'rz_dst==NULL' is redundant or there is possible null pointer dereference: dst. [nullPointerRedundantCheck]
instead-3.3.2/src/SDL2_rotozoom.c:1596:29: note: Assuming that condition 'rz_dst==NULL' is not redundant
instead-3.3.2/src/SDL2_rotozoom.c:1595:39: note: Calling function '_shrinkSurfaceRGBA', 2nd argument 'rz_dst' value is 0
instead-3.3.2/src/SDL2_rotozoom.c:125:22: note: Null pointer dereference
instead-3.3.2/src/SDL2_rotozoom.c:126:9: warning: Either the condition 'rz_dst==NULL' is redundant or there is possible null pointer dereference: dst. [nullPointerRedundantCheck]
instead-3.3.2/src/SDL2_rotozoom.c:1596:29: note: Assuming that condition 'rz_dst==NULL' is not redundant
instead-3.3.2/src/SDL2_rotozoom.c:1595:39: note: Calling function '_shrinkSurfaceRGBA', 2nd argument 'rz_dst' value is 0
instead-3.3.2/src/SDL2_rotozoom.c:126:9: note: Null pointer dereference
instead-3.3.2/src/SDL2_rotozoom.c:128:18: warning: Either the condition 'rz_dst==NULL' is redundant or there is possible null pointer dereference: dst. [nullPointerRedundantCheck]
instead-3.3.2/src/SDL2_rotozoom.c:1596:29: note: Assuming that condition 'rz_dst==NULL' is not redundant
instead-3.3.2/src/SDL2_rotozoom.c:1595:39: note: Calling function '_shrinkSurfaceRGBA', 2nd argument 'rz_dst' value is 0
instead-3.3.2/src/SDL2_rotozoom.c:128:18: note: Null pointer dereference
instead-3.3.2/src/SDL2_rotozoom.c:1586:2: warning: Either the condition 'rz_dst==NULL' is redundant or there is possible null pointer dereference: rz_dst. [nullPointerRedundantCheck]
instead-3.3.2/src/SDL2_rotozoom.c:1596:29: note: Assuming that condition 'rz_dst==NULL' is not redundant
instead-3.3.2/src/SDL2_rotozoom.c:1586:2: note: Null pointer dereference
instead-3.3.2/src/SDL2_rotozoom.c:532:5: style: Variable 'sp' is assigned a value that is never used. [unreadVariable]
instead-3.3.2/src/SDL_anigif.c:138:57: style:inconclusive: Function 'AG_LoadGIF' argument 3 names different: declaration 'maxFrames' definition 'size'. [funcArgNamesDifferent]
instead-3.3.2/src/SDL_anigif.h:48:74: note: Function 'AG_LoadGIF' argument 3 names different: declaration 'maxFrames' definition 'size'.
instead-3.3.2/src/SDL_anigif.c:138:57: note: Function 'AG_LoadGIF' argument 3 names different: declaration 'maxFrames' definition 'size'.
instead-3.3.2/src/SDL_anigif.c:283:58: style:inconclusive: Function 'AG_LoadGIF_RW' argument 3 names different: declaration 'size' definition 'maxFrames'. [funcArgNamesDifferent]
instead-3.3.2/src/SDL_anigif.h:52:75: note: Function 'AG_LoadGIF_RW' argument 3 names different: declaration 'size' definition 'maxFrames'.
instead-3.3.2/src/SDL_anigif.c:283:58: note: Function 'AG_LoadGIF_RW' argument 3 names different: declaration 'size' definition 'maxFrames'.
instead-3.3.2/src/SDL_anigif.c:95:16: style: struct member 'gifdata::code' is never used. [unusedStructMember]
instead-3.3.2/src/SDL_anigif.c:95:22: style: struct member 'gifdata::incode' is never used. [unusedStructMember]
instead-3.3.2/src/SDL_anigif.c:440:7: style: Variable 'flag' is assigned a value that is never used. [unreadVariable]
instead-3.3.2/src/SDL_anigif.c:453:8: style: Variable 'flag' is assigned a value that is never used. [unreadVariable]
instead-3.3.2/src/SDL_gfxBlitFunc.c:411:90: style: Parameter 'dstrect' can be declared as pointer to const [constParameter]
instead-3.3.2/src/SDL_gfxBlitFunc.c:320:3: style: Variable 'pixel' is assigned a value that is never used. [unreadVariable]
instead-3.3.2/src/SDL_gfxBlitFunc.c:433:8: style: Variable 'dr.w' is assigned a value that is never used. [unreadVariable]
instead-3.3.2/src/SDL_gfxBlitFunc.c:434:8: style: Variable 'dr.h' is assigned a value that is never used. [unreadVariable]
instead-3.3.2/src/SDL_rotozoom.c:137:22: warning: Either the condition 'rz_dst==NULL' is redundant or there is possible null pointer dereference: dst. [nullPointerRedundantCheck]
instead-3.3.2/src/SDL_rotozoom.c:1652:29: note: Assuming that condition 'rz_dst==NULL' is not redundant
instead-3.3.2/src/SDL_rotozoom.c:1651:39: note: Calling function '_shrinkSurfaceRGBA', 2nd argument 'rz_dst' value is 0
instead-3.3.2/src/SDL_rotozoom.c:137:22: note: Null pointer dereference
instead-3.3.2/src/SDL_rotozoom.c:138:9: warning: Either the condition 'rz_dst==NULL' is redundant or there is possible null pointer dereference: dst. [nullPointerRedundantCheck]
instead-3.3.2/src/SDL_rotozoom.c:1652:29: note: Assuming that condition 'rz_dst==NULL' is not redundant
instead-3.3.2/src/SDL_rotozoom.c:1651:39: note: Calling function '_shrinkSurfaceRGBA', 2nd argument 'rz_dst' value is 0
instead-3.3.2/src/SDL_rotozoom.c:138:9: note: Null pointer dereference
instead-3.3.2/src/SDL_rotozoom.c:140:18: warning: Either the condition 'rz_dst==NULL' is redundant or there is possible null pointer dereference: dst. [nullPointerRedundantCheck]
instead-3.3.2/src/SDL_rotozoom.c:1652:29: note: Assuming that condition 'rz_dst==NULL' is not redundant
instead-3.3.2/src/SDL_rotozoom.c:1651:39: note: Calling function '_shrinkSurfaceRGBA', 2nd argument 'rz_dst' value is 0
instead-3.3.2/src/SDL_rotozoom.c:140:18: note: Null pointer dereference
instead-3.3.2/src/SDL_rotozoom.c:1642:2: warning: Either the condition 'rz_dst==NULL' is redundant or there is possible null pointer dereference: rz_dst. [nullPointerRedundantCheck]
instead-3.3.2/src/SDL_rotozoom.c:1652:29: note: Assuming that condition 'rz_dst==NULL' is not redundant
instead-3.3.2/src/SDL_rotozoom.c:1642:2: note: Null pointer dereference
instead-3.3.2/src/game.c:465:15: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled]
instead-3.3.2/src/game.c:486:15: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled]
instead-3.3.2/src/game.c:2507:13: style: The if condition is the same as the previous if condition [duplicateCondition]
instead-3.3.2/src/game.c:2490:13: note: First condition
instead-3.3.2/src/game.c:2507:13: note: Second condition
instead-3.3.2/src/game.c:886:6: style: Condition 'browse_dialog' is always false [knownConditionTrueFalse]
instead-3.3.2/src/game.c:1407:7: style: Redundant initialization for 'img2'. The initialized value is overwritten before it is read. [redundantInitialization]
instead-3.3.2/src/game.c:1366:13: note: img2 is initialized
instead-3.3.2/src/game.c:1407:7: note: img2 is overwritten
instead-3.3.2/src/game.c:74:35: style:inconclusive: Function 'game_res_err_msg' argument 1 names different: declaration 's' definition 'filename'. [funcArgNamesDifferent]
instead-3.3.2/src/game.h:99:43: note: Function 'game_res_err_msg' argument 1 names different: declaration 's' definition 'filename'.
instead-3.3.2/src/game.c:74:35: note: Function 'game_res_err_msg' argument 1 names different: declaration 's' definition 'filename'.
instead-3.3.2/src/game.c:92:25: style:inconclusive: Function 'is_game' argument 1 names different: declaration 'games' definition 'path'. [funcArgNamesDifferent]
instead-3.3.2/src/game.h:94:32: note: Function 'is_game' argument 1 names different: declaration 'games' definition 'path'.
instead-3.3.2/src/game.c:92:25: note: Function 'is_game' argument 1 names different: declaration 'games' definition 'path'.
instead-3.3.2/src/game.c:92:43: style:inconclusive: Function 'is_game' argument 2 names different: declaration 'name' definition 'n'. [funcArgNamesDifferent]
instead-3.3.2/src/game.h:94:51: note: Function 'is_game' argument 2 names different: declaration 'name' definition 'n'.
instead-3.3.2/src/game.c:92:43: note: Function 'is_game' argument 2 names different: declaration 'name' definition 'n'.
instead-3.3.2/src/game.c:502:22: style:inconclusive: Function 'games_remove' argument 1 names different: declaration 'nr' definition 'gtr'. [funcArgNamesDifferent]
instead-3.3.2/src/game.h:95:29: note: Function 'games_remove' argument 1 names different: declaration 'nr' definition 'gtr'.
instead-3.3.2/src/game.c:502:22: note: Function 'games_remove' argument 1 names different: declaration 'nr' definition 'gtr'.
instead-3.3.2/src/game.c:1041:27: style:inconclusive: Function 'game_init' argument 1 names different: declaration 'game' definition 'name'. [funcArgNamesDifferent]
instead-3.3.2/src/game.h:71:34: note: Function 'game_init' argument 1 names different: declaration 'game' definition 'name'.
instead-3.3.2/src/game.c:1041:27: note: Function 'game_init' argument 1 names different: declaration 'game' definition 'name'.
instead-3.3.2/src/game.c:1623:8: style: Local variable 'menu' shadows outer variable [shadowVariable]
instead-3.3.2/src/game.c:522:14: note: Shadowed declaration
instead-3.3.2/src/game.c:1623:8: note: Shadow variable
instead-3.3.2/src/game.c:3609:8: style: Local variable 'x' shadows outer variable [shadowVariable]
instead-3.3.2/src/game.c:3569:13: note: Shadowed declaration
instead-3.3.2/src/game.c:3609:8: note: Shadow variable
instead-3.3.2/src/game.c:3609:11: style: Local variable 'y' shadows outer variable [shadowVariable]
instead-3.3.2/src/game.c:3569:20: note: Shadowed declaration
instead-3.3.2/src/game.c:3609:11: note: Shadow variable
instead-3.3.2/src/game.c:1731:26: style: Parameter 'p' can be declared as pointer to const [constParameter]
instead-3.3.2/src/game.c:1685:10: style: Variable 'pos' is assigned a value that is never used. [unreadVariable]
instead-3.3.2/src/graphics.c:4039:8: style: Array index 'cjk' is used before limits check. [arrayIndexThenCheck]
instead-3.3.2/src/graphics.c:823:6: style: The if condition is the same as the previous if condition [duplicateCondition]
instead-3.3.2/src/graphics.c:820:6: note: First condition
instead-3.3.2/src/graphics.c:823:6: note: Second condition
instead-3.3.2/src/graphics.c:589:24: style: Condition 's' is always true [knownConditionTrueFalse]
instead-3.3.2/src/graphics.c:5133:8: style: Condition '!ptr' is always false [knownConditionTrueFalse]
instead-3.3.2/src/graphics.c:5590:48: style: Condition '!fade_fg' is always false [knownConditionTrueFalse]
instead-3.3.2/src/graphics.c:497:27: style:inconclusive: Function 'gfx_free_image' argument 1 names different: declaration 'pixmap' definition 'p'. [funcArgNamesDifferent]
instead-3.3.2/src/graphics.h:123:34: note: Function 'gfx_free_image' argument 1 names different: declaration 'pixmap' definition 'p'.
instead-3.3.2/src/graphics.c:497:27: note: Function 'gfx_free_image' argument 1 names different: declaration 'pixmap' definition 'p'.
instead-3.3.2/src/graphics.c:1425:25: style:inconclusive: Function 'gfx_stop_gif' argument 1 names different: declaration 'img' definition 'p'. [funcArgNamesDifferent]
instead-3.3.2/src/graphics.h:236:32: note: Function 'gfx_stop_gif' argument 1 names different: declaration 'img' definition 'p'.
instead-3.3.2/src/graphics.c:1425:25: note: Function 'gfx_stop_gif' argument 1 names different: declaration 'img' definition 'p'.
instead-3.3.2/src/graphics.c:1445:26: style:inconclusive: Function 'gfx_start_gif' argument 1 names different: declaration 'img' definition 'p'. [funcArgNamesDifferent]
instead-3.3.2/src/graphics.h:234:34: note: Function 'gfx_start_gif' argument 1 names different: declaration 'img' definition 'p'.
instead-3.3.2/src/graphics.c:1445:26: note: Function 'gfx_start_gif' argument 1 names different: declaration 'img' definition 'p'.
instead-3.3.2/src/graphics.c:3709:46: style:inconclusive: Function 'txt_layout_words' argument 2 names different: declaration 'w' definition 'v'. [funcArgNamesDifferent]
instead-3.3.2/src/graphics.h:184:54: note: Function 'txt_layout_words' argument 2 names different: declaration 'w' definition 'v'.
instead-3.3.2/src/graphics.c:3709:46: note: Function 'txt_layout_words' argument 2 names different: declaration 'w' definition 'v'.
instead-3.3.2/src/graphics.c:4310:25: style:inconclusive: Function 'xref_update' argument 1 names different: declaration 'xref' definition 'pxref'. [funcArgNamesDifferent]
instead-3.3.2/src/graphics.h:233:32: note: Function 'xref_update' argument 1 names different: declaration 'xref' definition 'pxref'.
instead-3.3.2/src/graphics.c:4310:25: note: Function 'xref_update' argument 1 names different: declaration 'xref' definition 'pxref'.
instead-3.3.2/src/graphics.c:5509:46: style:inconclusive: Function 'txt_layout_real_size' argument 2 names different: declaration 'w' definition 'pw'. [funcArgNamesDifferent]
instead-3.3.2/src/graphics.h:210:54: note: Function 'txt_layout_real_size' argument 2 names different: declaration 'w' definition 'pw'.
instead-3.3.2/src/graphics.c:5509:46: note: Function 'txt_layout_real_size' argument 2 names different: declaration 'w' definition 'pw'.
instead-3.3.2/src/graphics.c:5509:55: style:inconclusive: Function 'txt_layout_real_size' argument 3 names different: declaration 'h' definition 'ph'. [funcArgNamesDifferent]
instead-3.3.2/src/graphics.h:210:62: note: Function 'txt_layout_real_size' argument 3 names different: declaration 'h' definition 'ph'.
instead-3.3.2/src/graphics.c:5509:55: note: Function 'txt_layout_real_size' argument 3 names different: declaration 'h' definition 'ph'.
instead-3.3.2/src/graphics.c:5802:24: style:inconclusive: Function 'gfx_set_icon' argument 1 names different: declaration 'icon' definition 'ic'. [funcArgNamesDifferent]
instead-3.3.2/src/graphics.h:104:31: note: Function 'gfx_set_icon' argument 1 names different: declaration 'icon' definition 'ic'.
instead-3.3.2/src/graphics.c:5802:24: note: Function 'gfx_set_icon' argument 1 names different: declaration 'icon' definition 'ic'.
instead-3.3.2/src/graphics.c:1036:9: style: Local variable 'img' shadows outer variable [shadowVariable]
instead-3.3.2/src/graphics.c:1010:8: note: Shadowed declaration
instead-3.3.2/src/graphics.c:1036:9: note: Shadow variable
instead-3.3.2/src/graphics.c:343:38: style: Parameter 'g' can be declared as pointer to const [constParameter]
instead-3.3.2/src/input.c:342:29: style:inconclusive: Function 'input' argument 1 names different: declaration 'ev' definition 'inp'. [funcArgNamesDifferent]
instead-3.3.2/src/input.h:54:29: note: Function 'input' argument 1 names different: declaration 'ev' definition 'inp'.
instead-3.3.2/src/input.c:342:29: note: Function 'input' argument 1 names different: declaration 'ev' definition 'inp'.
instead-3.3.2/src/instead/idf.c:307:15: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled]
instead-3.3.2/src/instead/idf.c:145:28: style:inconclusive: Function 'idf_init' argument 1 names different: declaration 'path' definition 'fname'. [funcArgNamesDifferent]
instead-3.3.2/src/instead/idf.h:33:35: note: Function 'idf_init' argument 1 names different: declaration 'path' definition 'fname'.
instead-3.3.2/src/instead/idf.c:145:28: note: Function 'idf_init' argument 1 names different: declaration 'path' definition 'fname'.
instead-3.3.2/src/instead/idf.c:296:9: style: Local variable 'd' shadows outer variable [shadowVariable]
instead-3.3.2/src/instead/idf.c:253:7: note: Shadowed declaration
instead-3.3.2/src/instead/idf.c:296:9: note: Shadow variable
instead-3.3.2/src/instead/idf.c:404:9: style: Local variable 'p' shadows outer variable [shadowVariable]
instead-3.3.2/src/instead/idf.c:344:8: note: Shadowed declaration
instead-3.3.2/src/instead/idf.c:404:9: note: Shadow variable
instead-3.3.2/src/instead/idf.c:416:8: style: Local variable 'rc' shadows outer variable [shadowVariable]
instead-3.3.2/src/instead/idf.c:342:6: note: Shadowed declaration
instead-3.3.2/src/instead/idf.c:416:8: note: Shadow variable
instead-3.3.2/src/instead/instead.c:1345:34: style:inconclusive: Function 'instead_set_lang' argument 1 names different: declaration 'lang' definition 'opt_lang'. [funcArgNamesDifferent]
instead-3.3.2/src/instead/instead.h:90:42: note: Function 'instead_set_lang' argument 1 names different: declaration 'lang' definition 'opt_lang'.
instead-3.3.2/src/instead/instead.c:1345:34: note: Function 'instead_set_lang' argument 1 names different: declaration 'lang' definition 'opt_lang'.
instead-3.3.2/src/instead/instead.c:535:7: style: Local variable 'rc' shadows outer variable [shadowVariable]
instead-3.3.2/src/instead/instead.c:525:6: note: Shadowed declaration
instead-3.3.2/src/instead/instead.c:535:7: note: Shadow variable
instead-3.3.2/src/instead/instead.c:599:17: style: Variable 'i' is assigned a value that is never used. [unreadVariable]
instead-3.3.2/src/instead/instead.c:849:10: style: Variable 'len' is assigned a value that is never used. [unreadVariable]
instead-3.3.2/src/instead/instead.c:891:8: style: Variable 'l' is assigned a value that is never used. [unreadVariable]
instead-3.3.2/src/instead/instead.c:1264:17: style: Variable 'i' is assigned a value that is never used. [unreadVariable]
instead-3.3.2/src/instead/lfs.c:56:15: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled]
instead-3.3.2/src/instead/list.c:154:59: style:inconclusive: Function 'list_check_node' argument 1 names different: declaration 'n' definition 'node'. [funcArgNamesDifferent]
instead-3.3.2/src/instead/list.h:280:59: note: Function 'list_check_node' argument 1 names different: declaration 'n' definition 'node'.
instead-3.3.2/src/instead/list.c:154:59: note: Function 'list_check_node' argument 1 names different: declaration 'n' definition 'node'.
instead-3.3.2/src/instead/snprintf.c:1504:2: error: va_list 'aq' used before va_start() was called. [va_list_usedBeforeStarted]
instead-3.3.2/src/instead/snprintf.c:1505:35: error: va_list 'aq' used before va_start() was called. [va_list_usedBeforeStarted]
instead-3.3.2/src/instead/tinymt32.h:79:26: error: Signed integer overflow for expression '-((int32_t)(y&1))'. [integerOverflow]
instead-3.3.2/src/instead/tinymt32.h:80:26: error: Signed integer overflow for expression '-((int32_t)(y&1))'. [integerOverflow]
instead-3.3.2/src/instead/tinymt32.h:95:11: error: Signed integer overflow for expression '-((int32_t)(t1&1))'. [integerOverflow]
instead-3.3.2/src/instead/util.c:29:26: style:inconclusive: Function 'get_utf8' argument 1 names different: declaration 'p' definition 'sp'. [funcArgNamesDifferent]
instead-3.3.2/src/instead/util.h:31:33: note: Function 'get_utf8' argument 1 names different: declaration 'p' definition 'sp'.
instead-3.3.2/src/instead/util.c:29:26: note: Function 'get_utf8' argument 1 names different: declaration 'p' definition 'sp'.
instead-3.3.2/src/instead/util.c:617:34: style:inconclusive: Function 'is_absolute_path' argument 1 names different: declaration 'p' definition 'path'. [funcArgNamesDifferent]
instead-3.3.2/src/instead/util.h:45:41: note: Function 'is_absolute_path' argument 1 names different: declaration 'p' definition 'path'.
instead-3.3.2/src/instead/util.c:617:34: note: Function 'is_absolute_path' argument 1 names different: declaration 'p' definition 'path'.
instead-3.3.2/src/instead_paths.c:38:7: style: Local variable 'instead_path' shadows outer function [shadowFunction]
instead-3.3.2/src/instead/instead.h:99:14: note: Shadowed declaration
instead-3.3.2/src/instead_paths.c:38:7: note: Shadow variable
instead-3.3.2/src/instead_sound.c:379:22: style:inconclusive: Function 'sound_put' argument 1 names different: declaration 'sn' definition 's'. [funcArgNamesDifferent]
instead-3.3.2/src/game.h:149:29: note: Function 'sound_put' argument 1 names different: declaration 'sn' definition 's'.
instead-3.3.2/src/instead_sound.c:379:22: note: Function 'sound_put' argument 1 names different: declaration 'sn' definition 's'.
instead-3.3.2/src/instead_sound.c:627:6: style: Local variable 'channels' shadows outer variable [shadowVariable]
instead-3.3.2/src/instead_sound.c:82:16: note: Shadowed declaration
instead-3.3.2/src/instead_sound.c:627:6: note: Shadow variable
instead-3.3.2/src/instead_sound.c:120:35: style: Parameter 'snd' can be declared as pointer to const [constParameter]
instead-3.3.2/src/instead_sprites.c:1205:45: style: Variable 'col[3]' is assigned a value that is never used. [unreadVariable]
instead-3.3.2/src/instead_sprites.c:1929:12: style: Variable 'nodes' is assigned a value that is never used. [unreadVariable]
instead-3.3.2/src/main.c:847:37: style:inconclusive: Function 'profile_load' argument 1 names different: declaration 'path' definition 'prof'. [funcArgNamesDifferent]
instead-3.3.2/src/main.c:239:37: note: Function 'profile_load' argument 1 names different: declaration 'path' definition 'prof'.
instead-3.3.2/src/main.c:847:37: note: Function 'profile_load' argument 1 names different: declaration 'path' definition 'prof'.
instead-3.3.2/src/main.c:597:7: style: Local variable 'i' shadows outer variable [shadowVariable]
instead-3.3.2/src/main.c:346:6: note: Shadowed declaration
instead-3.3.2/src/main.c:597:7: note: Shadow variable
instead-3.3.2/src/menu.c:104:9: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled]
instead-3.3.2/src/menu.c:106:9: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled]
instead-3.3.2/src/menu.c:1029:15: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled]
instead-3.3.2/src/menu.c:1046:15: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled]
instead-3.3.2/src/menu.c:190:8: style: Condition '!i' is always false [knownConditionTrueFalse]
instead-3.3.2/src/menu.c:89:17: style: Variable 'months' can be declared as const array [constVariable]
instead-3.3.2/src/menu.c:977:38: style: Variable 'p' is assigned a value that is never used. [unreadVariable]
instead-3.3.2/src/s60.c:147:26: style:inconclusive: Function 'game_save_path' argument 1 names different: declaration 'rc' definition 'cr'. [funcArgNamesDifferent]
instead-3.3.2/src/game.h:127:34: note: Function 'game_save_path' argument 1 names different: declaration 'rc' definition 'cr'.
instead-3.3.2/src/s60.c:147:26: note: Function 'game_save_path' argument 1 names different: declaration 'rc' definition 'cr'.
instead-3.3.2/src/s60.c:187:22: style:inconclusive: Function 'sdl_path' argument 1 names different: declaration 'path' definition 'p'. [funcArgNamesDifferent]
instead-3.3.2/src/utils.h:61:29: note: Function 'sdl_path' argument 1 names different: declaration 'path' definition 'p'.
instead-3.3.2/src/s60.c:187:22: note: Function 'sdl_path' argument 1 names different: declaration 'path' definition 'p'.
instead-3.3.2/src/sound.c:200:42: style:inconclusive: Function 'snd_load_mem' argument 2 names different: declaration 'buf' definition 'data'. [funcArgNamesDifferent]
instead-3.3.2/src/sound.h:25:49: note: Function 'snd_load_mem' argument 2 names different: declaration 'buf' definition 'data'.
instead-3.3.2/src/sound.c:200:42: note: Function 'snd_load_mem' argument 2 names different: declaration 'buf' definition 'data'.
instead-3.3.2/src/sound.c:265:25: style:inconclusive: Function 'snd_free_wav' argument 1 names different: declaration 'chunk' definition 'w'. [funcArgNamesDifferent]
instead-3.3.2/src/sound.h:17:32: note: Function 'snd_free_wav' argument 1 names different: declaration 'chunk' definition 'w'.
instead-3.3.2/src/sound.c:265:25: note: Function 'snd_free_wav' argument 1 names different: declaration 'chunk' definition 'w'.
instead-3.3.2/src/sound.c:316:24: style:inconclusive: Function 'snd_play_mus' argument 1 names different: declaration 'music' definition 'fname'. [funcArgNamesDifferent]
instead-3.3.2/src/sound.h:26:31: note: Function 'snd_play_mus' argument 1 names different: declaration 'music' definition 'fname'.
instead-3.3.2/src/sound.c:316:24: note: Function 'snd_play_mus' argument 1 names different: declaration 'music' definition 'fname'.
instead-3.3.2/src/sound.c:290:8: style: Local variable 'mus' shadows outer variable [shadowVariable]
instead-3.3.2/src/sound.c:46:14: note: Shadowed declaration
instead-3.3.2/src/sound.c:290:8: note: Shadow variable
instead-3.3.2/src/themes.c:1248:15: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled]
instead-3.3.2/src/themes.c:1266:15: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled]
instead-3.3.2/src/themes.c:698:8: style: Local variable 'val' shadows outer argument [shadowArgument]
instead-3.3.2/src/themes.c:690:36: note: Shadowed declaration
instead-3.3.2/src/themes.c:698:8: note: Shadow variable
instead-3.3.2/src/unix.c:227:7: portability: Non reentrant function 'getpwuid' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getpwuid_r'. [prohibitedgetpwuidCalled]
instead-3.3.2/src/unix.c:282:7: portability: Non reentrant function 'getpwuid' called. For threadsafe applications it is recommended to use the reentrant replacement function 'getpwuid_r'. [prohibitedgetpwuidCalled]
instead-3.3.2/src/unix.c:290:26: style:inconclusive: Function 'game_save_path' argument 1 names different: declaration 'rc' definition 'cr'. [funcArgNamesDifferent]
instead-3.3.2/src/game.h:127:34: note: Function 'game_save_path' argument 1 names different: declaration 'rc' definition 'cr'.
instead-3.3.2/src/unix.c:290:26: note: Function 'game_save_path' argument 1 names different: declaration 'rc' definition 'cr'.
instead-3.3.2/src/unix.c:330:22: style:inconclusive: Function 'sdl_path' argument 1 names different: declaration 'path' definition 'p'. [funcArgNamesDifferent]
instead-3.3.2/src/utils.h:61:29: note: Function 'sdl_path' argument 1 names different: declaration 'path' definition 'p'.
instead-3.3.2/src/unix.c:330:22: note: Function 'sdl_path' argument 1 names different: declaration 'path' definition 'p'.
instead-3.3.2/src/utils.c:452:15: portability: Non reentrant function 'readdir' called. For threadsafe applications it is recommended to use the reentrant replacement function 'readdir_r'. [prohibitedreaddirCalled]
instead-3.3.2/src/utils.c:375:89: style:inconclusive: Function 'lookup_lang_tag' argument 4 names different: declaration 'lang' definition 'opt_lang'. [funcArgNamesDifferent]
instead-3.3.2/src/utils.h:46:96: note: Function 'lookup_lang_tag' argument 4 names different: declaration 'lang' definition 'opt_lang'.
instead-3.3.2/src/utils.c:375:89: note: Function 'lookup_lang_tag' argument 4 names different: declaration 'lang' definition 'opt_lang'.
instead-3.3.2/src/utils.c:386:104: style:inconclusive: Function 'lookup_lang_tag_idf' argument 5 names different: declaration 'lang' definition 'opt_lang'. [funcArgNamesDifferent]
instead-3.3.2/src/utils.h:47:111: note: Function 'lookup_lang_tag_idf' argument 5 names different: declaration 'lang' definition 'opt_lang'.
instead-3.3.2/src/utils.c:386:104: note: Function 'lookup_lang_tag_idf' argument 5 names different: declaration 'lang' definition 'opt_lang'.
instead-3.3.2/src/utils.c:472:14: style: Variable 'map' can be declared as const array [constVariable]
instead-3.3.2/src/wince.c:103:22: style:inconclusive: Function 'sdl_path' argument 1 names different: declaration 'path' definition 'p'. [funcArgNamesDifferent]
instead-3.3.2/src/utils.h:61:29: note: Function 'sdl_path' argument 1 names different: declaration 'path' definition 'p'.
instead-3.3.2/src/wince.c:103:22: note: Function 'sdl_path' argument 1 names different: declaration 'path' definition 'p'.
instead-3.3.2/src/wince.c:212:27: style:inconclusive: Function 'game_save_path' argument 1 names different: declaration 'rc' definition 'cr'. [funcArgNamesDifferent]
instead-3.3.2/src/game.h:127:34: note: Function 'game_save_path' argument 1 names different: declaration 'rc' definition 'cr'.
instead-3.3.2/src/wince.c:212:27: note: Function 'game_save_path' argument 1 names different: declaration 'rc' definition 'cr'.
instead-3.3.2/src/windows.c:311:2: warning: Return value of function freopen() is not used. [ignoredReturnValue]
instead-3.3.2/src/windows.c:312:2: warning: Return value of function freopen() is not used. [ignoredReturnValue]
instead-3.3.2/src/windows.c:313:2: warning: Return value of function freopen() is not used. [ignoredReturnValue]
instead-3.3.2/src/windows.c:141:22: style:inconclusive: Function 'sdl_path' argument 1 names different: declaration 'path' definition 'p'. [funcArgNamesDifferent]
instead-3.3.2/src/utils.h:61:29: note: Function 'sdl_path' argument 1 names different: declaration 'path' definition 'p'.
instead-3.3.2/src/windows.c:141:22: note: Function 'sdl_path' argument 1 names different: declaration 'path' definition 'p'.
instead-3.3.2/src/windows.c:264:27: style:inconclusive: Function 'game_save_path' argument 1 names different: declaration 'rc' definition 'cr'. [funcArgNamesDifferent]
instead-3.3.2/src/game.h:127:34: note: Function 'game_save_path' argument 1 names different: declaration 'rc' definition 'cr'.
instead-3.3.2/src/windows.c:264:27: note: Function 'game_save_path' argument 1 names different: declaration 'rc' definition 'cr'.
instead-3.3.2/src/winrt.c:107:22: style:inconclusive: Function 'sdl_path' argument 1 names different: declaration 'path' definition 'p'. [funcArgNamesDifferent]
instead-3.3.2/src/utils.h:61:29: note: Function 'sdl_path' argument 1 names different: declaration 'path' definition 'p'.
instead-3.3.2/src/winrt.c:107:22: note: Function 'sdl_path' argument 1 names different: declaration 'path' definition 'p'.
instead-3.3.2/src/winrt.c:213:27: style:inconclusive: Function 'game_save_path' argument 1 names different: declaration 'rc' definition 'cr'. [funcArgNamesDifferent]
instead-3.3.2/src/game.h:127:34: note: Function 'game_save_path' argument 1 names different: declaration 'rc' definition 'cr'.
instead-3.3.2/src/winrt.c:213:27: note: Function 'game_save_path' argument 1 names different: declaration 'rc' definition 'cr'.
instead-3.3.2/src/zlib/deflate.c:161:32: style: struct member 'static_tree_desc_s::dummy' is never used. [unusedStructMember]
instead-3.3.2/src/zlib/deflate.c:352:30: style: Variable 'hash_head' is assigned a value that is never used. [unreadVariable]
instead-3.3.2/src/zlib/deflate.c:1669:9: style: Variable 'bflush' is assigned a value that is never used. [unreadVariable]
instead-3.3.2/src/zlib/example.c:334:9: warning: %ld in format string (no. 1) requires 'long' but the argument type is 'unsigned long'. [invalidPrintfArgType_sint]
instead-3.3.2/src/zlib/gzio.c:550:14: style: Condition 'b==buf' is always true [knownConditionTrueFalse]
instead-3.3.2/src/zlib/gzio.c:545:13: note: b is assigned 'buf' here.
instead-3.3.2/src/zlib/gzio.c:546:23: note: Assuming condition is false
instead-3.3.2/src/zlib/gzio.c:550:14: note: Condition 'b==buf' is always true
instead-3.3.2/src/zlib/gzio.c:19:28: style: struct member 'internal_state::dummy' is never used. [unusedStructMember]
instead-3.3.2/src/zlib/inflate.c:1314:11: style:inconclusive: Function 'inflateSyncPoint' argument 1 names different: declaration 'z' definition 'strm'. [funcArgNamesDifferent]
instead-3.3.2/src/zlib/zlib.h:1350:49: note: Function 'inflateSyncPoint' argument 1 names different: declaration 'z' definition 'strm'.
instead-3.3.2/src/zlib/inflate.c:1314:11: note: Function 'inflateSyncPoint' argument 1 names different: declaration 'z' definition 'strm'.
instead-3.3.2/src/zlib/inftrees.c:34:21: style: Parameter 'lens' can be declared as pointer to const [constParameter]
instead-3.3.2/src/zlib/trees.c:1147:14: style:inconclusive: Function 'bi_reverse' argument 1 names different: declaration 'value' definition 'code'. [funcArgNamesDifferent]
instead-3.3.2/src/zlib/trees.c:156:27: note: Function 'bi_reverse' argument 1 names different: declaration 'value' definition 'code'.
instead-3.3.2/src/zlib/trees.c:1147:14: note: Function 'bi_reverse' argument 1 names different: declaration 'value' definition 'code'.
instead-3.3.2/src/zlib/trees.c:1148:9: style:inconclusive: Function 'bi_reverse' argument 2 names different: declaration 'length' definition 'len'. [funcArgNamesDifferent]
instead-3.3.2/src/zlib/trees.c:156:27: note: Function 'bi_reverse' argument 2 names different: declaration 'length' definition 'len'.
instead-3.3.2/src/zlib/trees.c:1148:9: note: Function 'bi_reverse' argument 2 names different: declaration 'length' definition 'len'.
instead-3.3.2/src/zlib/trees.c:580:11: style: Parameter 'bl_count' can be declared as pointer to const [constParameter]
instead-3.3.2/src/zlib/zutil.c:305:31: style: Same expression on both sides of '-'. [duplicateExpression]
instead-3.3.2/src/zlib/zutil.c:301:12: style: Parameter 'opaque' can be declared as pointer to const [constParameter]
instead-3.3.2/src/zlib/zutil.c:311:12: style: Parameter 'opaque' can be declared as pointer to const [constParameter]
instead-3.3.2/src/zlib/zutil.c:11:33: style: struct member 'internal_state::dummy' is never used. [unusedStructMember]
instead-3.3.2/src/SDL2_rotozoom.c:125:22: warning: Null pointer dereference: dst [ctunullpointer]
instead-3.3.2/src/SDL2_rotozoom.c:1596:29: note: Assuming that condition 'rz_dst==NULL' is not redundant
instead-3.3.2/src/SDL2_rotozoom.c:1595:30: note: Calling function _shrinkSurfaceRGBA, 2nd argument is null
instead-3.3.2/src/SDL2_rotozoom.c:125:22: note: Dereferencing argument dst that is null
instead-3.3.2/src/SDL_rotozoom.c:137:22: warning: Null pointer dereference: dst [ctunullpointer]
instead-3.3.2/src/SDL_rotozoom.c:1652:29: note: Assuming that condition 'rz_dst==NULL' is not redundant
instead-3.3.2/src/SDL_rotozoom.c:1651:30: note: Calling function _shrinkSurfaceRGBA, 2nd argument is null
instead-3.3.2/src/SDL_rotozoom.c:137:22: note: Dereferencing argument dst that is null
diff:
head instead-3.3.2/src/SDL_gfxBlitFunc.c:411:90: style: Parameter 'dstrect' can be declared as pointer to const [constParameter]
2.8 instead-3.3.2/src/SDL_gfxBlitFunc.c:411:90: style: Parameter 'dstrect' can be declared with const [constParameter]
head instead-3.3.2/src/game.c:1731:26: style: Parameter 'p' can be declared as pointer to const [constParameter]
2.8 instead-3.3.2/src/game.c:1731:26: style: Parameter 'p' can be declared with const [constParameter]
2.8 instead-3.3.2/src/graphics.c:1064:3: error: Memory leak: filename [memleak]
head instead-3.3.2/src/graphics.c:343:38: style: Parameter 'g' can be declared as pointer to const [constParameter]
2.8 instead-3.3.2/src/graphics.c:343:38: style: Parameter 'g' can be declared with const [constParameter]
2.8 instead-3.3.2/src/instead/tinymt32.c:93:57: style: Parameter 'init_key' can be declared with const [constParameter]
head instead-3.3.2/src/instead_sound.c:120:35: style: Parameter 'snd' can be declared as pointer to const [constParameter]
2.8 instead-3.3.2/src/instead_sound.c:120:35: style: Parameter 'snd' can be declared with const [constParameter]
head instead-3.3.2/src/menu.c:89:17: style: Variable 'months' can be declared as const array [constVariable]
2.8 instead-3.3.2/src/menu.c:89:17: style: Variable 'months' can be declared with const [constVariable]
head instead-3.3.2/src/utils.c:472:14: style: Variable 'map' can be declared as const array [constVariable]
2.8 instead-3.3.2/src/utils.c:472:14: style: Variable 'map' can be declared with const [constVariable]
head instead-3.3.2/src/zlib/inftrees.c:34:21: style: Parameter 'lens' can be declared as pointer to const [constParameter]
2.8 instead-3.3.2/src/zlib/inftrees.c:34:21: style: Parameter 'lens' can be declared with const [constParameter]
head instead-3.3.2/src/zlib/trees.c:580:11: style: Parameter 'bl_count' can be declared as pointer to const [constParameter]
2.8 instead-3.3.2/src/zlib/trees.c:580:11: style: Parameter 'bl_count' can be declared with const [constParameter]
head instead-3.3.2/src/zlib/zutil.c:301:12: style: Parameter 'opaque' can be declared as pointer to const [constParameter]
2.8 instead-3.3.2/src/zlib/zutil.c:301:12: style: Parameter 'opaque' can be declared with const [constParameter]
head instead-3.3.2/src/zlib/zutil.c:311:12: style: Parameter 'opaque' can be declared as pointer to const [constParameter]
2.8 instead-3.3.2/src/zlib/zutil.c:311:12: style: Parameter 'opaque' can be declared with const [constParameter]


DONE