2022-06-22 09:17 ftp://ftp.de.debian.org/debian/pool/main/g/gromacs/gromacs_2022~rc1.orig.tar.gz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j2 platform: Linux-5.4.0-110-generic-x86_64-with-glibc2.29 python: 3.8.10 client-version: 1.3.24 compiler: g++ (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0 cppcheck: head 2.8 head-info: 650f409 (2022-06-22 08:46:48 +0200) count: 4293 4277 elapsed-time: 122.5 106.8 head-timing-info: Overall time: 0s old-timing-info: Overall time: 0s head results: gromacs-2022-rc1/api/gmxapi/cpp/session.cpp:60:16: warning: Member variable 'SignalManager::runner_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/api/gmxapi/cpp/session.cpp:60:55: style:inconclusive: Function 'SignalManager' argument 1 names different: declaration 'mdStopHandlerBuilder' definition 'stopHandlerBuilder'. [funcArgNamesDifferent] gromacs-2022-rc1/api/gmxapi/cpp/mdsignals.h:109:53: note: Function 'SignalManager' argument 1 names different: declaration 'mdStopHandlerBuilder' definition 'stopHandlerBuilder'. gromacs-2022-rc1/api/gmxapi/cpp/session.cpp:60:55: note: Function 'SignalManager' argument 1 names different: declaration 'mdStopHandlerBuilder' definition 'stopHandlerBuilder'. gromacs-2022-rc1/api/gmxapi/cpp/tests/restraint.cpp:119:1: error: syntax error [syntaxError] gromacs-2022-rc1/api/gmxapi/cpp/tests/runner.cpp:95:1: error: syntax error [syntaxError] gromacs-2022-rc1/api/gmxapi/cpp/tests/stopsignaler.cpp:178:1: error: syntax error [syntaxError] gromacs-2022-rc1/api/gmxapi/cpp/tests/version.cpp:65:1: error: syntax error [syntaxError] gromacs-2022-rc1/api/gmxapi/cpp/tpr.cpp:355:7: performance:inconclusive: Technically the member function 'gmxapicompat::GmxMdParamsImpl::extract' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/api/gmxapi/cpp/tpr.cpp:464:21: style: Variable 'irInstance' can be declared as reference to const [constVariable] gromacs-2022-rc1/api/gmxapi/cpp/tpr.cpp:337:21: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/api/gmxapi/cpp/tpr.cpp:341:21: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/api/gmxapi/cpp/tpr.cpp:345:21: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/api/gmxapi/cpp/tpr.cpp:349:21: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/api/gmxapi/cpp/workflow/tests/workflow.cpp:74:1: error: syntax error [syntaxError] gromacs-2022-rc1/api/nblib/listed_forces/tests/bondtypes.cpp:115:1: error: syntax error [syntaxError] gromacs-2022-rc1/api/nblib/listed_forces/tests/calculator.cpp:134:1: error: syntax error [syntaxError] gromacs-2022-rc1/api/nblib/listed_forces/tests/conversions.cpp:86:1: error: syntax error [syntaxError] gromacs-2022-rc1/api/nblib/listed_forces/tests/helpers.cpp:101:1: error: syntax error [syntaxError] gromacs-2022-rc1/api/nblib/listed_forces/tests/gmxcalculator.cpp:154:51: style: Parameter 'interactionElement' can be declared as reference to const [constParameter] gromacs-2022-rc1/api/nblib/listed_forces/tests/shiftforces.cpp:113:1: error: syntax error [syntaxError] gromacs-2022-rc1/api/nblib/listed_forces/tests/transformations.cpp:77:1: error: syntax error [syntaxError] gromacs-2022-rc1/api/nblib/listed_forces/tests/typetests.cpp:129:1: error: syntax error [syntaxError] gromacs-2022-rc1/api/nblib/tests/box.cpp:63:1: error: syntax error [syntaxError] gromacs-2022-rc1/api/nblib/tests/gmxcalculator.cpp:73:1: error: syntax error [syntaxError] gromacs-2022-rc1/api/nblib/tests/interactions.cpp:124:1: error: syntax error [syntaxError] gromacs-2022-rc1/api/nblib/tests/molecules.cpp:67:1: error: syntax error [syntaxError] gromacs-2022-rc1/api/nblib/tests/nbkernelsystem.cpp:83:1: error: syntax error [syntaxError] gromacs-2022-rc1/api/nblib/tests/nbnxmsetup.cpp:79:1: error: syntax error [syntaxError] gromacs-2022-rc1/api/nblib/tests/particletype.cpp:63:1: error: syntax error [syntaxError] gromacs-2022-rc1/api/nblib/tests/simstate.cpp:75:1: error: syntax error [syntaxError] gromacs-2022-rc1/api/nblib/tests/topology.cpp:79:1: error: syntax error [syntaxError] gromacs-2022-rc1/api/nblib/tests/tpr.cpp:83:1: error: syntax error [syntaxError] gromacs-2022-rc1/api/nblib/topology.cpp:133:15: style: Variable 'expansionArrayStage2' can be declared as reference to const [constVariable] gromacs-2022-rc1/api/nblib/util/tests/setup.cpp:69:1: error: syntax error [syntaxError] gromacs-2022-rc1/api/nblib/util/tests/traits.cpp:63:1: error: syntax error [syntaxError] gromacs-2022-rc1/cmake/HipSyclTest/main.cpp:38:0: error: #error "__HIPSYCL__ macro not defined. Please check your hipSYCL installation." [preprocessorErrorDirective] gromacs-2022-rc1/cmake/TestFileOffsetBits.cpp:6:7: style: Variable 'off_t_is_large' can be declared as const array [constVariable] gromacs-2022-rc1/cmake/TestFileOffsetBits.cpp:7:10: error: Uninitialized variable: off_t_is_large [uninitvar] gromacs-2022-rc1/cmake/TestFileOffsetBits.cpp:6:7: style: Variable 'off_t_is_large' is not assigned a value. [unassignedVariable] gromacs-2022-rc1/cmake/TestGlibcVersion.cpp:9:0: error: #error A glibc version prior to 2.23 was found [preprocessorErrorDirective] gromacs-2022-rc1/cmake/TestInlineASM_gcc_x86.cpp:24:0: error: #error Cannot detect whether this is a 32-bit or 64-bit x86 build. [preprocessorErrorDirective] gromacs-2022-rc1/cmake/TestIntelLLVM.cpp:2:0: error: #error [preprocessorErrorDirective] gromacs-2022-rc1/cmake/TestPipes.cpp:13:3: error: Resource leak: fp [resourceLeak] gromacs-2022-rc1/cmake/TestSIGUSR1.cpp:6:9: style: Variable 'i' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/cmake/TestVMD.cpp:6:6: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/cmake/TestVMD.cpp:26:20: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/cmake/TestVMD.cpp:29:6: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/cmake/TestX86.cpp:6:0: error: #error This is not x86 [preprocessorErrorDirective] gromacs-2022-rc1/python_packaging/sample_restraint/src/cpp/ensemblepotential.cpp:221:17: style: Consider using std::fill algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/python_packaging/sample_restraint/src/cpp/ensemblepotential.cpp:299:61: debug: Wrong data detected by condition !tok->next()->astOperand2() [DacaWrongData] gromacs-2022-rc1/python_packaging/sample_restraint/src/pythonmodule/export_plugin.cpp:157:9: performance: Variable 'name_' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] gromacs-2022-rc1/python_packaging/sample_restraint/src/pythonmodule/export_plugin.cpp:278:9: performance: Variable 'name_' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] gromacs-2022-rc1/python_packaging/sample_restraint/src/pythonmodule/export_plugin.cpp:172:26: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/python_packaging/sample_restraint/src/pythonmodule/export_plugin.cpp:296:26: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/python_packaging/sample_restraint/tests/test_bounding_restraint.cpp:26:1: error: syntax error [syntaxError] gromacs-2022-rc1/python_packaging/sample_restraint/tests/test_histogram.cpp:25:1: error: syntax error [syntaxError] gromacs-2022-rc1/python_packaging/src/gmxapi/export_context.cpp:84:20: style: Consider using std::copy algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/python_packaging/src/gmxapi/pycontext.cpp:103:53: style:inconclusive: Function 'addMDModule' argument 1 names different: declaration 'forceProvider' definition 'force_object'. [funcArgNamesDifferent] gromacs-2022-rc1/python_packaging/src/gmxapi/pycontext.h:70:46: note: Function 'addMDModule' argument 1 names different: declaration 'forceProvider' definition 'force_object'. gromacs-2022-rc1/python_packaging/src/gmxapi/pycontext.cpp:103:53: note: Function 'addMDModule' argument 1 names different: declaration 'forceProvider' definition 'force_object'. gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:199:2: warning: Member variable 'FFTKernelGenKeyParams::nonSquareKernelOrder' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:199:2: warning: Member variable 'FFTKernelGenKeyParams::fft_preCallback' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:199:2: warning: Member variable 'FFTKernelGenKeyParams::fft_postCallback' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:528:2: warning: Member variable 'FFTPlan::preCallback' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:528:2: warning: Member variable 'FFTPlan::postCallbackParam' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:66:2: warning: Member variable 'StatData::doubleNanoSec' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:66:2: warning: Member variable 'StatData::batchSize' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:66:2: warning: Member variable 'StatData::dim' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:66:2: warning: Member variable 'StatData::plHandle' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:66:2: warning: Member variable 'StatData::planX' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:66:2: warning: Member variable 'StatData::planY' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:66:2: warning: Member variable 'StatData::planZ' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:66:2: warning: Member variable 'StatData::planTX' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:66:2: warning: Member variable 'StatData::planTY' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:66:2: warning: Member variable 'StatData::planTZ' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:66:2: warning: Member variable 'StatData::planRCcopy' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:66:2: warning: Member variable 'StatData::planCopy' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:66:2: warning: Member variable 'StatData::gen' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:66:2: warning: Member variable 'StatData::iDist' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:66:2: warning: Member variable 'StatData::oDist' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:66:2: warning: Member variable 'StatData::placeness' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:69:2: warning: Member variable 'StatData::doubleNanoSec' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/library/lock.h:131:2: warning:inconclusive: Member variable 'lockRAII < false >::mutex' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] gromacs-2022-rc1/src/external/clFFT/src/library/lock.h:131:2: warning:inconclusive: Member variable 'lockRAII < false >::mAttr' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] gromacs-2022-rc1/src/external/clFFT/src/library/lock.h:131:2: warning:inconclusive: Member variable 'lockRAII < false >::tstream' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:462:18: style:inconclusive: Member variable 'FFTPlan::planTX' is in the wrong place in the initializer list. [initializerList] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:564:6: note: Member variable 'FFTPlan::planTX' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:462:18: note: Member variable 'FFTPlan::planTX' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:515:21: style:inconclusive: Member variable 'FFTPlan::plHandle' is in the wrong place in the initializer list. [initializerList] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:575:9: note: Member variable 'FFTPlan::plHandle' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:515:21: note: Member variable 'FFTPlan::plHandle' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:506:7: style:inconclusive: Member variable 'FFTPlan::hasPreCallback' is in the wrong place in the initializer list. [initializerList] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:576:6: note: Member variable 'FFTPlan::hasPreCallback' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:506:7: note: Member variable 'FFTPlan::hasPreCallback' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:38:12: style:inconclusive: Member variable 'StatData::kernel' is in the wrong place in the initializer list. [initializerList] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:71:22: note: Member variable 'StatData::kernel' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:38:12: note: Member variable 'StatData::kernel' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:56:24: style:inconclusive: Member variable 'StatData::lengths' is in the wrong place in the initializer list. [initializerList] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:76:3: note: Member variable 'StatData::lengths' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:56:24: note: Member variable 'StatData::lengths' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:62:24: style:inconclusive: Member variable 'StatData::enqueueLocalWorkSize' is in the wrong place in the initializer list. [initializerList] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:76:58: note: Member variable 'StatData::enqueueLocalWorkSize' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:62:24: note: Member variable 'StatData::enqueueLocalWorkSize' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:61:22: style:inconclusive: Member variable 'StatData::placeness' is in the wrong place in the initializer list. [initializerList] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:76:93: note: Member variable 'StatData::placeness' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:61:22: note: Member variable 'StatData::placeness' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/library/private.h:120:3: style: Class 'tofstreamRAII' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/external/clFFT/src/library/lock.h:145:3: style: Class 'lockRAII < false >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:210:7: style: The function 'Start' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.h:67:15: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:210:7: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:217:7: style: The function 'Stop' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.h:74:15: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:217:7: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:231:7: style: The function 'Clear' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.h:81:15: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:231:7: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:238:7: style: The function 'Reset' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.h:88:15: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:238:7: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:240:7: style: The function 'Reserve' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.h:90:15: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:240:7: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:242:9: style: The function 'getUniqueID' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.h:92:17: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:242:9: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:245:7: style: The function 'setNormalize' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.h:95:15: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:245:7: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:247:7: style: The function 'Print' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.h:97:15: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:247:7: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:252:9: style: The function 'pruneOutliers' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.h:102:17: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:252:9: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:253:24: style: The function 'pruneOutliers' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.h:103:32: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:253:24: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/accessors.cpp:120:27: style: Redundant condition: If 'dir == -1', the comparison 'dir == -1' is always true. [redundantCondition] gromacs-2022-rc1/src/external/clFFT/src/library/accessors.cpp:143:27: style: Redundant condition: If 'dir == -1', the comparison 'dir == -1' is always true. [redundantCondition] gromacs-2022-rc1/src/external/clFFT/src/library/repo.h:58:26: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/clFFT/src/library/repo.h:66:17: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/clFFT/src/library/accessors.cpp:772:50: style: Parameter 'userdata' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.h:236:4: warning: Class 'TwiddleTableLarge' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.h:236:4: warning: Class 'TwiddleTableLarge' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.h:229:3: style: Class 'TwiddleTableLarge' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/external/clFFT/src/library/action.h:37:21: style: The function 'getGenerator' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:345:44: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:37:21: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:53:21: style: The function 'getGenerator' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:345:44: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:53:21: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:71:21: style: The function 'getGenerator' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:345:44: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:71:21: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:86:21: style: The function 'getGenerator' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:345:44: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:86:21: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:101:21: style: The function 'getGenerator' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:345:44: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:101:21: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:131:17: style: The function 'generateKernel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:350:44: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:131:17: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:132:17: style: The function 'getWorkSizes' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:351:44: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:132:17: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:135:10: style: The function 'buildForwardKernel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:365:18: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:135:10: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:136:10: style: The function 'buildBackwardKernel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:366:18: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:136:10: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:173:17: style: The function 'generateKernel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:350:44: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:173:17: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:174:17: style: The function 'getWorkSizes' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:351:44: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:174:17: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:177:10: style: The function 'buildForwardKernel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:365:18: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:177:10: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:178:10: style: The function 'buildBackwardKernel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:366:18: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:178:10: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:217:17: style: The function 'generateKernel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:350:44: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:217:17: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:218:17: style: The function 'getWorkSizes' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:351:44: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:218:17: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:221:10: style: The function 'buildForwardKernel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:365:18: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:221:10: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:222:10: style: The function 'buildBackwardKernel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:366:18: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:222:10: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:259:17: style: The function 'generateKernel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:350:44: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:259:17: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:260:17: style: The function 'getWorkSizes' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:351:44: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:260:17: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:263:10: style: The function 'buildForwardKernel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:365:18: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:263:10: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:264:10: style: The function 'buildBackwardKernel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:366:18: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:264:10: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:300:17: style: The function 'generateKernel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:350:44: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:300:17: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:301:17: style: The function 'getWorkSizes' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:351:44: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:301:17: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:304:10: style: The function 'buildForwardKernel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:365:18: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:304:10: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:305:10: style: The function 'buildBackwardKernel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:366:18: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/library/action.h:305:10: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/library/action.transpose.cpp:364:42: style: Condition 'this->signature.nonSquareKernelType==NON_SQUARE_TRANS_TRANSPOSE_BATCHED_LEADING' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/external/clFFT/src/library/action.transpose.cpp:348:45: note: Assuming that condition 'this->signature.nonSquareKernelType==NON_SQUARE_TRANS_TRANSPOSE_BATCHED_LEADING' is not redundant gromacs-2022-rc1/src/external/clFFT/src/library/action.transpose.cpp:364:42: note: Condition 'this->signature.nonSquareKernelType==NON_SQUARE_TRANS_TRANSPOSE_BATCHED_LEADING' is always true gromacs-2022-rc1/src/external/clFFT/src/library/action.transpose.cpp:481:5: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] gromacs-2022-rc1/src/external/clFFT/src/library/action.transpose.cpp:483:5: note: Found duplicate branches for 'if' and 'else'. gromacs-2022-rc1/src/external/clFFT/src/library/action.transpose.cpp:481:5: note: Found duplicate branches for 'if' and 'else'. gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.h:892:25: style: The scope of the variable 'C7SFR' can be reduced. [variableScope] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.h:991:25: style: The scope of the variable 'C7SBR' can be reduced. [variableScope] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.h:1090:25: style: The scope of the variable 'C7SFC' can be reduced. [variableScope] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.h:1151:25: style: The scope of the variable 'C7SBC' can be reduced. [variableScope] gromacs-2022-rc1/src/external/clFFT/src/library/action.transpose.cpp:339:87: style:inconclusive: Function 'getWorkSizes' argument 1 names different: declaration 'globalws' definition 'globalWS'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/clFFT/src/library/action.h:301:52: note: Function 'getWorkSizes' argument 1 names different: declaration 'globalws' definition 'globalWS'. gromacs-2022-rc1/src/external/clFFT/src/library/action.transpose.cpp:339:87: note: Function 'getWorkSizes' argument 1 names different: declaration 'globalws' definition 'globalWS'. gromacs-2022-rc1/src/external/clFFT/src/library/action.transpose.cpp:339:120: style:inconclusive: Function 'getWorkSizes' argument 2 names different: declaration 'localws' definition 'localWS'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/clFFT/src/library/action.h:301:84: note: Function 'getWorkSizes' argument 2 names different: declaration 'localws' definition 'localWS'. gromacs-2022-rc1/src/external/clFFT/src/library/action.transpose.cpp:339:120: note: Function 'getWorkSizes' argument 2 names different: declaration 'localws' definition 'localWS'. gromacs-2022-rc1/src/external/clFFT/src/library/action.transpose.cpp:725:84: style:inconclusive: Function 'getWorkSizes' argument 1 names different: declaration 'globalws' definition 'globalWS'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/clFFT/src/library/action.h:260:56: note: Function 'getWorkSizes' argument 1 names different: declaration 'globalws' definition 'globalWS'. gromacs-2022-rc1/src/external/clFFT/src/library/action.transpose.cpp:725:84: note: Function 'getWorkSizes' argument 1 names different: declaration 'globalws' definition 'globalWS'. gromacs-2022-rc1/src/external/clFFT/src/library/action.transpose.cpp:725:117: style:inconclusive: Function 'getWorkSizes' argument 2 names different: declaration 'localws' definition 'localWS'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/clFFT/src/library/action.h:260:88: note: Function 'getWorkSizes' argument 2 names different: declaration 'localws' definition 'localWS'. gromacs-2022-rc1/src/external/clFFT/src/library/action.transpose.cpp:725:117: note: Function 'getWorkSizes' argument 2 names different: declaration 'localws' definition 'localWS'. gromacs-2022-rc1/src/external/clFFT/src/library/action.transpose.cpp:480:12: style: Local variable 'global_item_size' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/external/clFFT/src/library/action.transpose.cpp:346:12: note: Shadowed declaration gromacs-2022-rc1/src/external/clFFT/src/library/action.transpose.cpp:480:12: note: Shadow variable gromacs-2022-rc1/src/external/clFFT/src/library/action.transpose.cpp:434:25: style: Variable 'num_elements_loaded' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:348:44: performance:inconclusive: Technically the member function 'FFTAction::writeKernel' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/external/clFFT/src/library/enqueue.cpp:672:24: note: Technically the member function 'FFTAction::writeKernel' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:348:44: note: Technically the member function 'FFTAction::writeKernel' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:359:17: performance:inconclusive: Technically the member function 'FFTAction::selectBufferArguments' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/external/clFFT/src/library/enqueue.cpp:100:24: note: Technically the member function 'FFTAction::selectBufferArguments' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:359:17: note: Technically the member function 'FFTAction::selectBufferArguments' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.h:257:9: style: Struct 'CacheEntry' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/external/clFFT/src/library/private.h:120:3: style: Class 'tofstreamRAII < std :: ofstream , std :: string >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/external/clFFT/src/library/enqueue.cpp:94:32: style:inconclusive: Function 'FFTAction' argument 1 names different: declaration 'plan' definition 'fftPlan'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:331:25: note: Function 'FFTAction' argument 1 names different: declaration 'plan' definition 'fftPlan'. gromacs-2022-rc1/src/external/clFFT/src/library/enqueue.cpp:94:32: note: Function 'FFTAction' argument 1 names different: declaration 'plan' definition 'fftPlan'. gromacs-2022-rc1/src/external/clFFT/src/library/enqueue.cpp:100:56: style:inconclusive: Function 'selectBufferArguments' argument 1 names different: declaration 'plan' definition 'fftPlan'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/clFFT/src/library/plan.h:359:49: note: Function 'selectBufferArguments' argument 1 names different: declaration 'plan' definition 'fftPlan'. gromacs-2022-rc1/src/external/clFFT/src/library/enqueue.cpp:100:56: note: Function 'selectBufferArguments' argument 1 names different: declaration 'plan' definition 'fftPlan'. gromacs-2022-rc1/src/external/clFFT/src/library/lock.h:131:2: warning:inconclusive: Member variable 'lockRAII::mutex' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] gromacs-2022-rc1/src/external/clFFT/src/library/lock.h:131:2: warning:inconclusive: Member variable 'lockRAII::mAttr' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] gromacs-2022-rc1/src/external/clFFT/src/library/lock.h:131:2: warning:inconclusive: Member variable 'lockRAII::tstream' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:93:30: warning: Member variable 'CacheEntry::m_handle' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:195:53: warning: 'operator=' should check for assignment to self to avoid problems with dynamic memory. [operatorEqToSelf] gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.h:147:16: style:inconclusive: Technically the member function 'FFTBinaryLookup::getProgram' can be const. [functionConst] gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:660:29: note: Technically the member function 'FFTBinaryLookup::getProgram' can be const. gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.h:147:16: note: Technically the member function 'FFTBinaryLookup::getProgram' can be const. gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.h:260:14: style:inconclusive: Technically the member function 'FFTBinaryLookup::CacheEntry::successful_creation' can be const. [functionConst] gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:109:35: note: Technically the member function 'FFTBinaryLookup::CacheEntry::successful_creation' can be const. gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.h:260:14: note: Technically the member function 'FFTBinaryLookup::CacheEntry::successful_creation' can be const. gromacs-2022-rc1/src/external/clFFT/src/library/lock.h:145:3: style: Class 'lockRAII' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:104:14: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:233:42: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:238:40: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:343:45: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:356:45: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:367:25: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:371:25: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:507:20: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:508:20: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:577:63: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:228:42: portability:inconclusive: Casting from double * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:599:65: style:inconclusive: Function 'buildProgramFromSource' argument 1 names different: declaration 'filename' definition 'source'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.h:153:59: note: Function 'buildProgramFromSource' argument 1 names different: declaration 'filename' definition 'source'. gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:599:65: note: Function 'buildProgramFromSource' argument 1 names different: declaration 'filename' definition 'source'. gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:503:29: style: Local variable 'filename' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:492:25: note: Shadowed declaration gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:503:29: note: Shadow variable gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:248:56: style: Parameter 'data' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:683:14: performance: Passing the result of c_str() to a function that takes std::string as argument no. 1 is slow and redundant. [stlcstrParam] gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:731:9: performance: Passing the result of c_str() to a function that takes std::string as argument no. 1 is slow and redundant. [stlcstrParam] gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:734:9: performance: Passing the result of c_str() to a function that takes std::string as argument no. 1 is slow and redundant. [stlcstrParam] gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:737:9: performance: Passing the result of c_str() to a function that takes std::string as argument no. 1 is slow and redundant. [stlcstrParam] gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:740:9: performance: Passing the result of c_str() to a function that takes std::string as argument no. 1 is slow and redundant. [stlcstrParam] gromacs-2022-rc1/src/external/clFFT/src/library/generator.copy.cpp:102:22: style:inconclusive: Technically the member function 'CopyKernel < P_SINGLE >::OffsetCalc' can be const. [functionConst] gromacs-2022-rc1/src/external/clFFT/src/library/generator.copy.cpp:102:22: style:inconclusive: Technically the member function 'CopyKernel < P_DOUBLE >::OffsetCalc' can be const. [functionConst] gromacs-2022-rc1/src/external/clFFT/src/library/generator.copy.cpp:127:9: style: Class 'CopyKernel < P_SINGLE >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/external/clFFT/src/library/generator.copy.cpp:127:9: style: Class 'CopyKernel < P_DOUBLE >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/external/clFFT/src/library/generator.copy.cpp:582:73: style:inconclusive: Function 'getWorkSizes' argument 1 names different: declaration 'globalws' definition 'globalWS'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/clFFT/src/library/action.h:132:56: note: Function 'getWorkSizes' argument 1 names different: declaration 'globalws' definition 'globalWS'. gromacs-2022-rc1/src/external/clFFT/src/library/generator.copy.cpp:582:73: note: Function 'getWorkSizes' argument 1 names different: declaration 'globalws' definition 'globalWS'. gromacs-2022-rc1/src/external/clFFT/src/library/generator.copy.cpp:582:105: style:inconclusive: Function 'getWorkSizes' argument 2 names different: declaration 'localws' definition 'localWS'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/clFFT/src/library/action.h:132:88: note: Function 'getWorkSizes' argument 2 names different: declaration 'localws' definition 'localWS'. gromacs-2022-rc1/src/external/clFFT/src/library/generator.copy.cpp:582:105: note: Function 'getWorkSizes' argument 2 names different: declaration 'localws' definition 'localWS'. gromacs-2022-rc1/src/external/clFFT/src/library/generator.copy.cpp:162:20: style: Variable 'sfx' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/external/clFFT/src/library/generator.copy.cpp:322:16: style: Variable 'inF2' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/external/clFFT/src/library/generator.copy.cpp:327:11: style: Variable 'inF2' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/external/clFFT/src/library/generator.transpose.cpp:1727:21: style: Expression is always true because 'else if' condition is opposite to previous condition at line 1656. [multiCondition] gromacs-2022-rc1/src/external/clFFT/src/library/generator.transpose.cpp:1656:17: note: first condition gromacs-2022-rc1/src/external/clFFT/src/library/generator.transpose.cpp:1727:21: note: else if condition is opposite to first condition gromacs-2022-rc1/src/external/clFFT/src/library/generator.transpose.cpp:1840:13: style: Expression is always true because 'else if' condition is opposite to previous condition at line 1771. [multiCondition] gromacs-2022-rc1/src/external/clFFT/src/library/generator.transpose.cpp:1771:17: note: first condition gromacs-2022-rc1/src/external/clFFT/src/library/generator.transpose.cpp:1840:13: note: else if condition is opposite to first condition gromacs-2022-rc1/src/external/clFFT/src/library/generator.transpose.cpp:331:9: style: The scope of the variable 'swap_id' can be reduced. [variableScope] gromacs-2022-rc1/src/external/clFFT/src/library/generator.transpose.cpp:430:14: style: The scope of the variable 'dtInput' can be reduced. [variableScope] gromacs-2022-rc1/src/external/clFFT/src/library/generator.transpose.cpp:431:14: style: The scope of the variable 'dtOutput' can be reduced. [variableScope] gromacs-2022-rc1/src/external/clFFT/src/library/generator.transpose.cpp:585:19: style: The scope of the variable 'start_inx' can be reduced. [variableScope] gromacs-2022-rc1/src/external/clFFT/src/library/generator.transpose.cpp:947:14: style: Unused variable: tmpBuffType [unusedVariable] gromacs-2022-rc1/src/external/clFFT/src/library/generator.transpose.cpp:1067:116: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] gromacs-2022-rc1/src/external/clFFT/src/library/generator.transpose.gcn.cpp:1200:82: style:inconclusive: Function 'getWorkSizes' argument 1 names different: declaration 'globalws' definition 'globalWS'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/clFFT/src/library/action.h:218:56: note: Function 'getWorkSizes' argument 1 names different: declaration 'globalws' definition 'globalWS'. gromacs-2022-rc1/src/external/clFFT/src/library/generator.transpose.gcn.cpp:1200:82: note: Function 'getWorkSizes' argument 1 names different: declaration 'globalws' definition 'globalWS'. gromacs-2022-rc1/src/external/clFFT/src/library/generator.transpose.gcn.cpp:1200:115: style:inconclusive: Function 'getWorkSizes' argument 2 names different: declaration 'localws' definition 'localWS'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/clFFT/src/library/action.h:218:88: note: Function 'getWorkSizes' argument 2 names different: declaration 'localws' definition 'localWS'. gromacs-2022-rc1/src/external/clFFT/src/library/generator.transpose.gcn.cpp:1200:115: note: Function 'getWorkSizes' argument 2 names different: declaration 'localws' definition 'localWS'. gromacs-2022-rc1/src/external/clFFT/src/library/generator.transpose.gcn.cpp:106:16: style: struct member 'tile::col' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/clFFT/src/library/generator.transpose.gcn.cpp:112:16: style: struct member 'tile::row' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/clFFT/src/include/sharedLibrary.h:64:0: error: #error "unsupported platform" [preprocessorErrorDirective] gromacs-2022-rc1/src/external/clFFT/src/library/md5sum.cpp:106:9: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/clFFT/src/library/md5sum.cpp:239:11: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/clFFT/src/library/md5sum.cpp:104:14: style: The scope of the variable 'saved_a' can be reduced. [variableScope] gromacs-2022-rc1/src/external/clFFT/src/library/md5sum.cpp:104:23: style: The scope of the variable 'saved_b' can be reduced. [variableScope] gromacs-2022-rc1/src/external/clFFT/src/library/md5sum.cpp:104:32: style: The scope of the variable 'saved_c' can be reduced. [variableScope] gromacs-2022-rc1/src/external/clFFT/src/library/md5sum.cpp:104:41: style: The scope of the variable 'saved_d' can be reduced. [variableScope] gromacs-2022-rc1/src/external/clFFT/src/library/md5sum.cpp:221:22: style: The scope of the variable 'available' can be reduced. [variableScope] gromacs-2022-rc1/src/external/clFFT/src/library/md5sum.cpp:305:59: style:inconclusive: Function 'md5sum' argument 3 names different: declaration 'md5sum' definition 'md5string'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/clFFT/src/library/md5sum.h:49:60: note: Function 'md5sum' argument 3 names different: declaration 'md5sum' definition 'md5string'. gromacs-2022-rc1/src/external/clFFT/src/library/md5sum.cpp:305:59: note: Function 'md5sum' argument 3 names different: declaration 'md5sum' definition 'md5string'. gromacs-2022-rc1/src/external/clFFT/src/library/plan.cpp:518:25: style: The if condition is the same as the previous if condition [duplicateCondition] gromacs-2022-rc1/src/external/clFFT/src/library/plan.cpp:511:25: note: First condition gromacs-2022-rc1/src/external/clFFT/src/library/plan.cpp:518:25: note: Second condition gromacs-2022-rc1/src/external/clFFT/src/library/plan.cpp:638:12: style: The scope of the variable 'in_1d' can be reduced. [variableScope] gromacs-2022-rc1/src/external/clFFT/src/library/plan.cpp:638:19: style: The scope of the variable 'in_x' can be reduced. [variableScope] gromacs-2022-rc1/src/external/clFFT/src/library/plan.cpp:638:25: style: The scope of the variable 'count' can be reduced. [variableScope] gromacs-2022-rc1/src/external/clFFT/src/library/plan.cpp:181:38: performance: Function parameter 'ext' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/external/clFFT/src/library/plan.cpp:581:48: style: Variable 'pow2flag' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/external/clFFT/src/library/plan.cpp:594:48: style: Variable 'pow2flag' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/external/clFFT/src/library/plan.cpp:608:48: style: Variable 'pow2flag' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/external/clFFT/src/library/repo.cpp:361:14: style: Local variable 'sLock' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/external/clFFT/src/library/repo.cpp:352:13: note: Shadowed declaration gromacs-2022-rc1/src/external/clFFT/src/library/repo.cpp:361:14: note: Shadow variable gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.CPU.cpp:110:2: performance: Variable 'clkFrequency' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.CPU.cpp:116:3: performance: Variable 'clkFrequency' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.CPU.cpp:82:7: style:inconclusive: Technically the member function 'PruneRange::operator()' can be const. [functionConst] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.CPU.h:134:7: style: The function 'Start' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.h:67:15: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.CPU.h:134:7: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.CPU.h:141:7: style: The function 'Stop' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.h:74:15: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.CPU.h:141:7: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.CPU.h:148:7: style: The function 'Clear' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.h:81:15: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.CPU.h:148:7: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.CPU.h:155:7: style: The function 'Reset' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.h:88:15: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.CPU.h:155:7: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.CPU.h:157:7: style: The function 'Reserve' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.h:90:15: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.CPU.h:157:7: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.CPU.h:159:9: style: The function 'getUniqueID' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.h:92:17: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.CPU.h:159:9: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.CPU.h:162:7: style: The function 'setNormalize' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.h:95:15: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.CPU.h:162:7: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.CPU.h:164:7: style: The function 'Print' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.h:97:15: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.CPU.h:164:7: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.CPU.h:169:9: style: The function 'pruneOutliers' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.h:102:17: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.CPU.h:169:9: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.CPU.h:170:24: style: The function 'pruneOutliers' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.h:103:32: note: Virtual function in base class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.CPU.h:170:24: note: Function in derived class gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:137:9: style:inconclusive: Member variable 'GpuStatTimer::currSample' is in the wrong place in the initializer list. [initializerList] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.cpp:139:74: note: Member variable 'GpuStatTimer::currSample' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:137:9: note: Member variable 'GpuStatTimer::currSample' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.cpp:163:31: style:inconclusive: Function 'Reserve' argument 1 names different: declaration 'nEvents' definition 'nE'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:240:23: note: Function 'Reserve' argument 1 names different: declaration 'nEvents' definition 'nE'. gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.cpp:163:31: note: Function 'Reserve' argument 1 names different: declaration 'nEvents' definition 'nE'. gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.cpp:163:42: style:inconclusive: Function 'Reserve' argument 2 names different: declaration 'nSamples' definition 'nS'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:240:39: note: Function 'Reserve' argument 2 names different: declaration 'nSamples' definition 'nS'. gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.cpp:163:42: note: Function 'Reserve' argument 2 names different: declaration 'nSamples' definition 'nS'. gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.cpp:204:91: style:inconclusive: Function 'AddSample' argument 4 names different: declaration 'numQueuesAndEvents' definition 'numEvents'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.h:223:91: note: Function 'AddSample' argument 4 names different: declaration 'numQueuesAndEvents' definition 'numEvents'. gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.cpp:204:91: note: Function 'AddSample' argument 4 names different: declaration 'numQueuesAndEvents' definition 'numEvents'. gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.cpp:108:23: performance: Function parameter 'm' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.cpp:418:23: style: Variable 'tableThird' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.cpp:419:24: style: Variable 'tableFourth' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/external/clFFT/src/statTimer/statisticalTimer.GPU.cpp:420:23: style: Variable 'tableFifth' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:26:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:27:11: style: The scope of the variable 'ti2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:27:16: style: The scope of the variable 'tr2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:60:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:61:21: style: The scope of the variable 'di2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:61:26: style: The scope of the variable 'di3' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:61:41: style: The scope of the variable 'dr2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:61:46: style: The scope of the variable 'dr3' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:112:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:113:11: style: The scope of the variable 'ci2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:113:16: style: The scope of the variable 'ci3' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:113:21: style: The scope of the variable 'ci4' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:113:26: style: The scope of the variable 'cr2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:113:31: style: The scope of the variable 'cr3' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:113:36: style: The scope of the variable 'cr4' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:176:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:177:31: style: The scope of the variable 'di3' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:177:36: style: The scope of the variable 'di4' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:177:41: style: The scope of the variable 'di5' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:177:46: style: The scope of the variable 'di2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:178:19: style: The scope of the variable 'dr3' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:178:24: style: The scope of the variable 'dr4' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:178:29: style: The scope of the variable 'dr5' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:178:34: style: The scope of the variable 'dr2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:262:15: style: The scope of the variable 'idlj' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:262:49: style: The scope of the variable 'lc' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:262:57: style: The scope of the variable 'idj' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:391:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:391:15: style: The scope of the variable 'ic' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:392:11: style: The scope of the variable 'ti2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:392:16: style: The scope of the variable 'tr2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:423:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:423:15: style: The scope of the variable 'ic' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:424:11: style: The scope of the variable 'ti2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:424:16: style: The scope of the variable 'tr2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:540:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:540:15: style: The scope of the variable 'ic' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:541:11: style: The scope of the variable 'ci2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:541:16: style: The scope of the variable 'ci3' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:541:21: style: The scope of the variable 'ci4' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:541:26: style: The scope of the variable 'cr2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:541:31: style: The scope of the variable 'cr3' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:541:36: style: The scope of the variable 'cr4' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:541:46: style: The scope of the variable 'ti2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:541:51: style: The scope of the variable 'ti3' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:541:56: style: The scope of the variable 'ti4' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:541:71: style: The scope of the variable 'tr3' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:541:76: style: The scope of the variable 'tr4' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:600:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:600:15: style: The scope of the variable 'ic' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:601:11: style: The scope of the variable 'ci2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:601:16: style: The scope of the variable 'ci3' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:601:21: style: The scope of the variable 'ci4' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:601:26: style: The scope of the variable 'cr2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:601:31: style: The scope of the variable 'cr3' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:601:36: style: The scope of the variable 'cr4' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:601:51: style: The scope of the variable 'ti3' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:601:56: style: The scope of the variable 'ti4' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:794:9: style: The scope of the variable 'idij' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:794:45: style: The scope of the variable 'lc' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:794:53: style: The scope of the variable 'is' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:795:11: style: The scope of the variable 'dc2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:795:21: style: The scope of the variable 'ai2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:795:31: style: The scope of the variable 'ar2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:795:36: style: The scope of the variable 'ds2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:795:56: style: The scope of the variable 'ar1h' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:964:33: style: The scope of the variable 'j2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:964:37: style: The scope of the variable 'ic' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:964:45: style: The scope of the variable 'lc' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:965:11: style: The scope of the variable 'dc2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:965:21: style: The scope of the variable 'ai2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:965:31: style: The scope of the variable 'ar2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:965:36: style: The scope of the variable 'ds2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:967:26: style: The scope of the variable 'ar1h' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:1140:9: style: The scope of the variable 'idot' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:1141:17: style: The scope of the variable 'l2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:1142:17: style: The scope of the variable 'ip' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:1142:45: style: The scope of the variable 'ido' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:1142:50: style: The scope of the variable 'idl1' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:1232:9: style: The scope of the variable 'idot' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:1233:21: style: The scope of the variable 'l2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:1234:9: style: The scope of the variable 'ld' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:1234:21: style: The scope of the variable 'ip' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:1235:9: style: The scope of the variable 'ido' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:1235:14: style: The scope of the variable 'ipm' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:1282:13: style: The scope of the variable 'l1' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:1282:25: style: The scope of the variable 'kh' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:1282:33: style: The scope of the variable 'ip' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:1282:56: style: The scope of the variable 'ido' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:1282:61: style: The scope of the variable 'idl1' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:1343:17: style: The scope of the variable 'l2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:1343:29: style: The scope of the variable 'ip' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:1343:52: style: The scope of the variable 'ido' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:1343:57: style: The scope of the variable 'idl1' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:1401:17: style: The scope of the variable 'l2' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:1402:9: style: The scope of the variable 'ld' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:1402:21: style: The scope of the variable 'ip' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:1403:9: style: The scope of the variable 'ido' can be reduced. [variableScope] gromacs-2022-rc1/src/external/fftpack/fftpack.cpp:1403:14: style: The scope of the variable 'ipm' can be reduced. [variableScope] gromacs-2022-rc1/src/external/googletest/googlemock/test/gmock-actions_test.cc:97:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googlemock/test/gmock-cardinalities_test.cc:62:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:1993:3: warning: Member variable 'Pass < P_SINGLE >::fft_preCallback' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:1993:3: warning: Member variable 'Pass < P_SINGLE >::fft_postCallback' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:1993:3: warning: Member variable 'Pass < P_DOUBLE >::fft_preCallback' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:1993:3: warning: Member variable 'Pass < P_DOUBLE >::fft_postCallback' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:664:8: style: Unused private function: 'Pass < P_SINGLE >::RegIndex' [unusedPrivateFunction] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:664:8: style: Unused private function: 'Pass < P_DOUBLE >::RegIndex' [unusedPrivateFunction] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:2820:8: style:inconclusive: Member variable 'Kernel < P_SINGLE >::r2c2r' is in the wrong place in the initializer list. [initializerList] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:2958:23: note: Member variable 'Kernel < P_SINGLE >::r2c2r' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:2820:8: note: Member variable 'Kernel < P_SINGLE >::r2c2r' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:2820:8: style:inconclusive: Member variable 'Kernel < P_DOUBLE >::r2c2r' is in the wrong place in the initializer list. [initializerList] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:2958:23: note: Member variable 'Kernel < P_DOUBLE >::r2c2r' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:2820:8: note: Member variable 'Kernel < P_DOUBLE >::r2c2r' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:611:10: style:inconclusive: Member variable 'Pass < P_SINGLE >::algL' is in the wrong place in the initializer list. [initializerList] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:1997:4: note: Member variable 'Pass < P_SINGLE >::algL' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:611:10: note: Member variable 'Pass < P_SINGLE >::algL' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:627:8: style:inconclusive: Member variable 'Pass < P_SINGLE >::r2c' is in the wrong place in the initializer list. [initializerList] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:1998:4: note: Member variable 'Pass < P_SINGLE >::r2c' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:627:8: note: Member variable 'Pass < P_SINGLE >::r2c' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:625:10: style:inconclusive: Member variable 'Pass < P_SINGLE >::numB1' is in the wrong place in the initializer list. [initializerList] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:2000:4: note: Member variable 'Pass < P_SINGLE >::numB1' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:625:10: note: Member variable 'Pass < P_SINGLE >::numB1' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:611:10: style:inconclusive: Member variable 'Pass < P_DOUBLE >::algL' is in the wrong place in the initializer list. [initializerList] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:1997:4: note: Member variable 'Pass < P_DOUBLE >::algL' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:611:10: note: Member variable 'Pass < P_DOUBLE >::algL' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:627:8: style:inconclusive: Member variable 'Pass < P_DOUBLE >::r2c' is in the wrong place in the initializer list. [initializerList] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:1998:4: note: Member variable 'Pass < P_DOUBLE >::r2c' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:627:8: note: Member variable 'Pass < P_DOUBLE >::r2c' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:625:10: style:inconclusive: Member variable 'Pass < P_DOUBLE >::numB1' is in the wrong place in the initializer list. [initializerList] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:2000:4: note: Member variable 'Pass < P_DOUBLE >::numB1' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:625:10: note: Member variable 'Pass < P_DOUBLE >::numB1' is in the wrong place in the initializer list. gromacs-2022-rc1/src/external/googletest/googlemock/test/gmock-function-mocker_test.cc:297:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:2834:22: style:inconclusive: Technically the member function 'Kernel < P_SINGLE >::IterRegs' can be const. [functionConst] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:2834:22: style:inconclusive: Technically the member function 'Kernel < P_DOUBLE >::IterRegs' can be const. [functionConst] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:646:15: performance:inconclusive: Technically the member function 'Pass < P_SINGLE >::RegBase' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:652:15: performance:inconclusive: Technically the member function 'Pass < P_SINGLE >::RegBaseAndCount' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:658:15: performance:inconclusive: Technically the member function 'Pass < P_SINGLE >::RegBaseAndCountAndPos' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:646:15: performance:inconclusive: Technically the member function 'Pass < P_DOUBLE >::RegBase' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:652:15: performance:inconclusive: Technically the member function 'Pass < P_DOUBLE >::RegBaseAndCount' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:658:15: performance:inconclusive: Technically the member function 'Pass < P_DOUBLE >::RegBaseAndCountAndPos' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:534:4: warning: Class 'TwiddleTable' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:534:4: warning: Class 'TwiddleTable' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:530:3: style: Class 'TwiddleTable' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:2957:9: style: Class 'Kernel < P_SINGLE >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:2957:9: style: Class 'Kernel < P_DOUBLE >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/external/googletest/googlemock/test/gmock-internal-utils_test.cc:275:3: error: There is an unknown macro here somewhere. Configuration is required. If GTEST_INTENTIONAL_CONST_COND_POP_ is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:2497:20: style: Redundant condition: halfLds. '!halfLds || (halfLds && position==0)' is equivalent to '!halfLds || position==0' [redundantCondition] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:3705:11: style: The if condition is the same as the previous if condition [duplicateCondition] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:3704:11: note: First condition gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:3705:11: note: Second condition gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:3734:10: style: The if condition is the same as the previous if condition [duplicateCondition] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:3733:10: note: First condition gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:3734:10: note: Second condition gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:3908:12: style: The if condition is the same as the previous if condition [duplicateCondition] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:3907:12: note: First condition gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:3908:12: note: Second condition gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:3925:11: style: The if condition is the same as the previous if condition [duplicateCondition] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:3924:11: note: First condition gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:3925:11: note: Second condition gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:4040:10: style: The if condition is the same as the previous if condition [duplicateCondition] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:4039:10: note: First condition gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:4040:10: note: Second condition gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:4424:10: style: The if condition is the same as the previous if condition [duplicateCondition] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:4423:10: note: First condition gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:4424:10: note: Second condition gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:2083:7: style: The if condition is the same as the previous if condition [duplicateCondition] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:2082:7: note: First condition gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:2083:7: note: Second condition gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:1006:35: style: Condition 'nextPass==NULL' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:998:53: note: Assuming that condition 'nextPass==NULL' is not redundant gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:1006:35: note: Condition 'nextPass==NULL' is always true gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:1009:35: style: Condition 'nextPass==NULL' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:998:53: note: Assuming that condition 'nextPass==NULL' is not redundant gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:1006:44: note: Assuming condition is false gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:1009:35: note: Condition 'nextPass==NULL' is always true gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:459:43: style: Redundant initialization for 'maxWorkGroupSize'. The initialized value is overwritten before it is read. [redundantInitialization] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:454:28: note: maxWorkGroupSize is initialized gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:459:43: note: maxWorkGroupSize is overwritten gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:3016:11: style: The scope of the variable 'pid' can be reduced. [variableScope] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:858:9: style: The scope of the variable 'swapElement' can be reduced. [variableScope] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:4630:77: style:inconclusive: Function 'getWorkSizes' argument 1 names different: declaration 'globalws' definition 'globalWS'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/clFFT/src/library/action.h:174:56: note: Function 'getWorkSizes' argument 1 names different: declaration 'globalws' definition 'globalWS'. gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:4630:77: note: Function 'getWorkSizes' argument 1 names different: declaration 'globalws' definition 'globalWS'. gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:4630:109: style:inconclusive: Function 'getWorkSizes' argument 2 names different: declaration 'localws' definition 'localWS'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/clFFT/src/library/action.h:174:88: note: Function 'getWorkSizes' argument 2 names different: declaration 'localws' definition 'localWS'. gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:4630:109: note: Function 'getWorkSizes' argument 2 names different: declaration 'localws' definition 'localWS'. gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:4258:58: style: Local variable 'p' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:3385:53: note: Shadowed declaration gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:4258:58: note: Shadow variable gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:2045:63: performance: Function parameter 'precallbackParam' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:2051:65: performance: Function parameter 'postcallbackParam' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/external/googletest/googlemock/test/gmock-matchers_test.cc:173:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googlemock/test/gmock-more-actions_test.cc:1460:39: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:179:8: style: struct member 'ParamRead::halfLds' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:301:11: style: struct member 'SpecRecord::workGroupSize' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/googletest/googlemock/test/gmock-nice-strict_test.cc:239:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:302:11: style: struct member 'SpecRecord::numTransforms' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:303:11: style: struct member 'SpecRecord::numPasses' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:304:11: style: struct member 'SpecRecord::radices' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:203:15: style: Variable 'strLds' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/external/googletest/googlemock/test/gmock-pp-string_test.cc:61:3: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:1555:23: style: Variable 'rType' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/external/googletest/googlemock/test/gmock-pp_test.cc:23:35: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:553:25: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:563:25: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:3280:85: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:3388:86: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:3392:34: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:3421:48: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] gromacs-2022-rc1/src/external/clFFT/src/library/generator.stockham.cpp:4258:97: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] gromacs-2022-rc1/src/external/googletest/googlemock/test/gmock-spec-builders_test.cc:123:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googlemock/test/gmock_leak_test_.cc:58:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googlemock/test/gmock_stress_test.cc:197:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/samples/sample10_unittest.cc:94:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/samples/sample1_unittest.cc:100:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/samples/sample2.cc:49:32: style:inconclusive: Function 'Set' argument 1 names different: declaration 'c_string' definition 'a_c_string'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/googletest/googletest/samples/sample2.h:77:24: note: Function 'Set' argument 1 names different: declaration 'c_string' definition 'a_c_string'. gromacs-2022-rc1/src/external/googletest/googletest/samples/sample2.cc:49:32: note: Function 'Set' argument 1 names different: declaration 'c_string' definition 'a_c_string'. gromacs-2022-rc1/src/external/googletest/googletest/samples/sample2_unittest.cc:77:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/samples/sample3_unittest.cc:120:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/samples/sample5_unittest.cc:97:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/samples/sample6_unittest.cc:97:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/samples/sample7_unittest.cc:79:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/samples/sample8_unittest.cc:107:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/samples/sample9_unittest.cc:90:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/src/gtest.cc:5540:7: error: There is an unknown macro here somewhere. Configuration is required. If GTEST_DISABLE_MSC_WARNINGS_PUSH_ is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/external/googletest/googletest/test/googletest-death-test-test.cc:1439:29: error: There is an unknown macro here somewhere. Configuration is required. If ; is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/external/googletest/googletest/test/googletest-failfast-unittest_.cc:48:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/test/googletest-filter-unittest_.cc:49:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/test/googletest-filepath-test.cc:97:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/test/googletest-global-environment-unittest_.cc:50:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/test/googletest-listener-test.cc:226:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/test/googletest-message-test.cc:50:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/test/googletest-options-test.cc:63:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/test/googletest-output-test_.cc:105:26: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/test/googletest-param-test-invalid-name1-test_.cc:36:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/test/googletest-param-test-invalid-name2-test_.cc:41:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/test/googletest-port-test.cc:67:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/test/googletest-param-test-test.cc:1087:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/test/googletest-shuffle-test_.cc:49:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/test/googletest-printers-test.cc:302:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/test/googletest-test-part-test.cc:56:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/test/gtest-typed-test_test.cc:164:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/test/gtest-unittest-api_test.cc:100:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/test/gtest_environment_test.cc:103:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/test/gtest_premature_exit_test.cc:79:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/test/gtest_repeat_test.cc:73:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/googletest/googletest/test/gtest_pred_impl_unittest.cc:93:8: style:inconclusive: Technically the member function 'PredFunctor1::operator()' can be const. [functionConst] gromacs-2022-rc1/src/external/googletest/googletest/test/gtest_pred_impl_unittest.cc:479:8: style:inconclusive: Technically the member function 'PredFunctor2::operator()' can be const. [functionConst] gromacs-2022-rc1/src/external/googletest/googletest/test/gtest_pred_impl_unittest.cc:907:8: style:inconclusive: Technically the member function 'PredFunctor3::operator()' can be const. [functionConst] gromacs-2022-rc1/src/external/googletest/googletest/test/gtest_pred_impl_unittest.cc:1377:8: style:inconclusive: Technically the member function 'PredFunctor4::operator()' can be const. [functionConst] gromacs-2022-rc1/src/external/googletest/googletest/test/gtest_pred_impl_unittest.cc:1889:8: style:inconclusive: Technically the member function 'PredFunctor5::operator()' can be const. [functionConst] gromacs-2022-rc1/src/external/googletest/googletest/test/gtest_sole_header_test.cc:43:27: error: There is an unknown macro here somewhere. Configuration is required. If ; is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/external/googletest/googletest/test/gtest_unittest.cc:5393:26: error: syntax error [syntaxError] gromacs-2022-rc1/src/external/muparser/samples/example1/example1.cpp:145:41: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] gromacs-2022-rc1/src/external/muparser/samples/example1/example1.cpp:141:32: note: Assignment 'iBits=sizeof(iVal)*8', assigned value is 32 gromacs-2022-rc1/src/external/muparser/samples/example1/example1.cpp:145:41: note: Shift gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:214:20: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:215:20: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:216:20: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:217:20: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:218:20: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:219:20: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:220:20: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:221:20: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:222:20: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:214:20: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:215:20: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:216:20: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:217:20: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:218:20: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:219:20: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:220:20: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:221:20: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:681:24: style: The scope of the variable 'fp_old' can be reduced. [variableScope] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:681:39: style: The scope of the variable 'parc' can be reduced. [variableScope] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:874:18: style: The scope of the variable 'kmax' can be reduced. [variableScope] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:875:12: style: The scope of the variable 'ajnorm' can be reduced. [variableScope] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:1164:32: style: The scope of the variable 'xabs' can be reduced. [variableScope] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:1241:32: style: The scope of the variable 'xabs' can be reduced. [variableScope] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:832:45: style:inconclusive: Function 'lm_qrfac' argument 3 names different: declaration 'a' definition 'A'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:36:45: note: Function 'lm_qrfac' argument 3 names different: declaration 'a' definition 'A'. gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:832:45: note: Function 'lm_qrfac' argument 3 names different: declaration 'a' definition 'A'. gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:832:59: style:inconclusive: Function 'lm_qrfac' argument 4 names different: declaration 'ipvt' definition 'Pivot'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:36:59: note: Function 'lm_qrfac' argument 4 names different: declaration 'ipvt' definition 'Pivot'. gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:832:59: note: Function 'lm_qrfac' argument 4 names different: declaration 'ipvt' definition 'Pivot'. gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:833:19: style:inconclusive: Function 'lm_qrfac' argument 5 names different: declaration 'rdiag' definition 'Rdiag'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:37:19: note: Function 'lm_qrfac' argument 5 names different: declaration 'rdiag' definition 'Rdiag'. gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:833:19: note: Function 'lm_qrfac' argument 5 names different: declaration 'rdiag' definition 'Rdiag'. gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:833:40: style:inconclusive: Function 'lm_qrfac' argument 6 names different: declaration 'acnorm' definition 'Acnorm'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:37:40: note: Function 'lm_qrfac' argument 6 names different: declaration 'acnorm' definition 'Acnorm'. gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:833:40: note: Function 'lm_qrfac' argument 6 names different: declaration 'acnorm' definition 'Acnorm'. gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:833:62: style:inconclusive: Function 'lm_qrfac' argument 7 names different: declaration 'wa' definition 'W'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:37:62: note: Function 'lm_qrfac' argument 7 names different: declaration 'wa' definition 'W'. gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:833:62: note: Function 'lm_qrfac' argument 7 names different: declaration 'wa' definition 'W'. gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:605:19: style: Parameter 'diag' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:975:39: style: Parameter 'qtb' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:975:19: style: Parameter 'diag' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:974:61: style: Parameter 'ipvt' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/muparser/src/muParserBytecode.cpp:378:8: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/muparser/src/muParserBase.cpp:1292:23: warning: Either the condition 'stArgCount.empty()' is redundant or expression 'stArgCount.top()' cause access out of bounds. [containerOutOfBounds] gromacs-2022-rc1/src/external/muparser/src/muParserBase.cpp:1289:25: note: Assuming that condition 'stArgCount.empty()' is not redundant gromacs-2022-rc1/src/external/muparser/src/muParserBase.cpp:1292:23: note: Access out of bounds gromacs-2022-rc1/src/external/muparser/src/muParserBase.cpp:1313:21: warning: Either the condition 'stArgCount.empty()' is redundant or expression 'stArgCount.top()' cause access out of bounds. [containerOutOfBounds] gromacs-2022-rc1/src/external/muparser/src/muParserBase.cpp:1310:25: note: Assuming that condition 'stArgCount.empty()' is not redundant gromacs-2022-rc1/src/external/muparser/src/muParserBase.cpp:1313:21: note: Access out of bounds gromacs-2022-rc1/src/external/muparser/src/muParserInt.cpp:186:42: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] gromacs-2022-rc1/src/external/muparser/src/muParserInt.cpp:182:23: note: Assignment 'iBits=sizeof(iVal)*8', assigned value is 32 gromacs-2022-rc1/src/external/muparser/src/muParserInt.cpp:186:42: note: Shift gromacs-2022-rc1/src/external/muparser/src/muParserTest.cpp:908:5: error: There is an unknown macro here somewhere. Configuration is required. If _T is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/external/muparser/src/muParserTokenReader.cpp:787:13: style: Redundant initialization for 'item'. The initialized value is overwritten before it is read. [redundantInitialization] gromacs-2022-rc1/src/external/muparser/src/muParserTokenReader.cpp:786:49: note: item is initialized gromacs-2022-rc1/src/external/muparser/src/muParserTokenReader.cpp:787:13: note: item is overwritten gromacs-2022-rc1/src/external/thread_mpi/src/alltoall.cpp:74:31: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/alltoall.cpp:107:41: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/alltoall.cpp:129:25: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/alltoall.cpp:130:25: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/alltoall.cpp:150:52: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/alltoall.cpp:186:31: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/alltoall.cpp:219:41: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/alltoall.cpp:242:25: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/alltoall.cpp:243:25: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/alltoall.cpp:265:32: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/alltoall.cpp:173:57: style: Parameter 'sdispls' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/thread_mpi/src/alltoall.cpp:175:57: style: Parameter 'rdispls' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/thread_mpi/src/bcast.cpp:68:31: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/collective.cpp:151:16: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/collective.cpp:156:20: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/collective.cpp:161:22: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/collective.cpp:184:11: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/collective.cpp:185:11: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/collective.cpp:186:11: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/collective.cpp:198:17: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/collective.cpp:225:11: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/collective.cpp:236:21: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/collective.cpp:385:16: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/collective.cpp:196:9: style: The scope of the variable 'ret' can be reduced. [variableScope] gromacs-2022-rc1/src/external/thread_mpi/src/collective.cpp:440:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/external/thread_mpi/src/collective.cpp:193:41: style:inconclusive: Function 'tMPI_Coll_env_init' argument 1 names different: declaration 'mev' definition 'cev'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/thread_mpi/src/impl.h:800:41: note: Function 'tMPI_Coll_env_init' argument 1 names different: declaration 'mev' definition 'cev'. gromacs-2022-rc1/src/external/thread_mpi/src/collective.cpp:193:41: note: Function 'tMPI_Coll_env_init' argument 1 names different: declaration 'mev' definition 'cev'. gromacs-2022-rc1/src/external/thread_mpi/src/collective.cpp:218:45: style:inconclusive: Function 'tMPI_Coll_env_destroy' argument 1 names different: declaration 'mev' definition 'cev'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/thread_mpi/src/impl.h:802:45: note: Function 'tMPI_Coll_env_destroy' argument 1 names different: declaration 'mev' definition 'cev'. gromacs-2022-rc1/src/external/thread_mpi/src/collective.cpp:218:45: note: Function 'tMPI_Coll_env_destroy' argument 1 names different: declaration 'mev' definition 'cev'. gromacs-2022-rc1/src/external/thread_mpi/src/collective.cpp:228:43: style:inconclusive: Function 'tMPI_Coll_sync_init' argument 1 names different: declaration 'msc' definition 'csync'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/thread_mpi/src/impl.h:805:43: note: Function 'tMPI_Coll_sync_init' argument 1 names different: declaration 'msc' definition 'csync'. gromacs-2022-rc1/src/external/thread_mpi/src/collective.cpp:228:43: note: Function 'tMPI_Coll_sync_init' argument 1 names different: declaration 'msc' definition 'csync'. gromacs-2022-rc1/src/external/thread_mpi/src/collective.cpp:248:47: style:inconclusive: Function 'tMPI_Coll_sync_destroy' argument 1 names different: declaration 'msc' definition 'csync'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/thread_mpi/src/impl.h:807:47: note: Function 'tMPI_Coll_sync_destroy' argument 1 names different: declaration 'msc' definition 'csync'. gromacs-2022-rc1/src/external/thread_mpi/src/collective.cpp:248:47: note: Function 'tMPI_Coll_sync_destroy' argument 1 names different: declaration 'msc' definition 'csync'. gromacs-2022-rc1/src/external/thread_mpi/src/collective.cpp:263:64: style:inconclusive: Function 'tMPI_Get_cev' argument 3 names different: declaration 'synct' definition 'counter'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/thread_mpi/src/collective.h:40:64: note: Function 'tMPI_Get_cev' argument 3 names different: declaration 'synct' definition 'counter'. gromacs-2022-rc1/src/external/thread_mpi/src/collective.cpp:263:64: note: Function 'tMPI_Get_cev' argument 3 names different: declaration 'synct' definition 'counter'. gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:159:13: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:165:24: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:216:32: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:222:26: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:237:39: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:251:28: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:257:28: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:274:18: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:290:20: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:372:10: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:373:10: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:484:57: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:491:43: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:565:63: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:588:27: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:589:26: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:597:35: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:598:35: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:663:23: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:666:26: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:667:26: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:671:30: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:672:27: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:678:17: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:738:18: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:739:18: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:761:14: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:414:9: style: The scope of the variable 'ret' can be reduced. [variableScope] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:555:25: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:555:28: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:774:61: style: Parameter 'th' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/thread_mpi/src/errhandler.cpp:160:48: style: Parameter 'function' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/thread_mpi/src/errhandler.cpp:212:42: style: Parameter 'comm' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/thread_mpi/src/errhandler.cpp:230:39: style: Parameter 'comm' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/thread_mpi/src/gather.cpp:69:31: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/gather.cpp:99:33: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/gather.cpp:100:33: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/gather.cpp:127:36: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/gather.cpp:149:57: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/gather.cpp:176:31: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/gather.cpp:206:33: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/gather.cpp:207:33: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/gather.cpp:234:36: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/gather.cpp:255:57: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/gather.cpp:169:55: style: Parameter 'displs' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/thread_mpi/src/list.cpp:77:20: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/list.cpp:88:16: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/list.cpp:108:16: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/group.cpp:68:11: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/group.cpp:110:11: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/group.cpp:128:19: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/group.cpp:129:19: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/group.cpp:181:51: style: Parameter 'ranks' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/thread_mpi/src/once.cpp:174:26: error:inconclusive: Returning pointer to local variable 'size' that will be invalid when returning. [returnDanglingLifetime] gromacs-2022-rc1/src/external/thread_mpi/src/once.cpp:174:52: note: Address of variable taken here. gromacs-2022-rc1/src/external/thread_mpi/src/once.cpp:174:52: note: Passed to 'tMPI_Once_wait'. gromacs-2022-rc1/src/external/thread_mpi/src/once.cpp:162:12: note: Return pointer. gromacs-2022-rc1/src/external/thread_mpi/src/once.cpp:133:24: note: Passed to initializer list. gromacs-2022-rc1/src/external/thread_mpi/src/once.cpp:172:44: note: Variable created here. gromacs-2022-rc1/src/external/thread_mpi/src/once.cpp:174:26: note: Returning pointer to local variable 'size' that will be invalid when returning. gromacs-2022-rc1/src/external/thread_mpi/src/once.cpp:75:40: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/once.cpp:114:40: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/once.cpp:168:19: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_send_recv.cpp:69:31: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_send_recv.cpp:89:47: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_send_recv.cpp:111:36: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_send_recv.cpp:161:36: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_send_recv.cpp:194:47: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_send_recv.cpp:250:31: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_send_recv.cpp:274:46: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_send_recv.cpp:292:36: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_protocol.cpp:129:29: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_protocol.cpp:200:24: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_protocol.cpp:265:21: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_protocol.cpp:277:24: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_protocol.cpp:400:30: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_protocol.cpp:501:23: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_protocol.cpp:664:12: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_protocol.cpp:1095:29: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_protocol.cpp:964:25: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_protocol.cpp:1060:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_protocol.cpp:1113:34: style: The scope of the variable 'rev' can be reduced. [variableScope] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_protocol.cpp:332:56: style:inconclusive: Function 'tMPI_Send_env_list_return' argument 1 names different: declaration 'ev' definition 'sev'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_protocol.cpp:79:56: note: Function 'tMPI_Send_env_list_return' argument 1 names different: declaration 'ev' definition 'sev'. gromacs-2022-rc1/src/external/thread_mpi/src/p2p_protocol.cpp:332:56: note: Function 'tMPI_Send_env_list_return' argument 1 names different: declaration 'ev' definition 'sev'. gromacs-2022-rc1/src/external/thread_mpi/src/p2p_protocol.cpp:469:63: style:inconclusive: Function 'tMPI_Recv_env_list_add' argument 2 names different: declaration 'ev' definition 'rev'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_protocol.cpp:109:63: note: Function 'tMPI_Recv_env_list_add' argument 2 names different: declaration 'ev' definition 'rev'. gromacs-2022-rc1/src/external/thread_mpi/src/p2p_protocol.cpp:469:63: note: Function 'tMPI_Recv_env_list_add' argument 2 names different: declaration 'ev' definition 'rev'. gromacs-2022-rc1/src/external/thread_mpi/src/p2p_protocol.cpp:480:56: style:inconclusive: Function 'tMPI_Recv_env_list_remove' argument 1 names different: declaration 'ev' definition 'rev'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_protocol.cpp:111:56: note: Function 'tMPI_Recv_env_list_remove' argument 1 names different: declaration 'ev' definition 'rev'. gromacs-2022-rc1/src/external/thread_mpi/src/p2p_protocol.cpp:480:56: note: Function 'tMPI_Recv_env_list_remove' argument 1 names different: declaration 'ev' definition 'rev'. gromacs-2022-rc1/src/external/thread_mpi/src/p2p_protocol.cpp:1058:53: style:inconclusive: Function 'tMPI_Wait_process_incoming' argument 1 names different: declaration 'th' definition 'cur'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/thread_mpi/src/p2p.h:50:53: note: Function 'tMPI_Wait_process_incoming' argument 1 names different: declaration 'th' definition 'cur'. gromacs-2022-rc1/src/external/thread_mpi/src/p2p_protocol.cpp:1058:53: note: Function 'tMPI_Wait_process_incoming' argument 1 names different: declaration 'th' definition 'cur'. gromacs-2022-rc1/src/external/thread_mpi/src/p2p_wait.cpp:65:31: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_wait.cpp:113:31: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_wait.cpp:232:31: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_wait.cpp:272:31: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_wait.cpp:326:31: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_wait.cpp:372:31: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_wait.cpp:431:31: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_wait.cpp:476:31: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/p2p_wait.cpp:176:58: style: Parameter 'array_of_requests' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/thread_mpi/src/reduce_fast.cpp:66:11: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/reduce_fast.cpp:76:11: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/reduce.cpp:79:34: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/reduce.cpp:166:25: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/reduce.cpp:173:25: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/reduce.cpp:247:34: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/reduce.cpp:271:19: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/reduce.cpp:288:35: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/reduce.cpp:321:15: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/reduce.cpp:133:19: style: The scope of the variable 'a' can be reduced. [variableScope] gromacs-2022-rc1/src/external/thread_mpi/src/reduce.cpp:133:23: style: The scope of the variable 'b' can be reduced. [variableScope] gromacs-2022-rc1/src/external/thread_mpi/src/reduce.cpp:134:19: style: The scope of the variable 'ret' can be reduced. [variableScope] gromacs-2022-rc1/src/external/thread_mpi/src/scan.cpp:65:34: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/scan.cpp:117:17: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/scan.cpp:121:17: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/scatter.cpp:70:31: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/scatter.cpp:112:43: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/scatter.cpp:174:33: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/scatter.cpp:206:31: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/scatter.cpp:249:43: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/scatter.cpp:311:33: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/scatter.cpp:198:62: style: Parameter 'displs' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/thread_mpi/src/scatter.cpp:93:47: style: Variable 'total_send_size' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/external/thread_mpi/src/scatter.cpp:110:40: style: Variable 'total_send_size' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/external/thread_mpi/src/scatter.cpp:230:47: style: Variable 'total_send_size' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/external/thread_mpi/src/scatter.cpp:247:40: style: Variable 'total_send_size' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_malloc.cpp:65:17: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_malloc.cpp:76:17: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_init.cpp:159:24: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_init.cpp:164:30: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_init.cpp:250:16: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_init.cpp:386:31: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_init.cpp:437:24: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_init.cpp:450:20: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_init.cpp:477:35: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_init.cpp:789:15: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_init.cpp:799:33: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_init.cpp:422:9: style: The scope of the variable 'ret' can be reduced. [variableScope] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_init.cpp:554:9: style: The scope of the variable 'ret' can be reduced. [variableScope] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_init.cpp:586:9: style: The scope of the variable 'ret' can be reduced. [variableScope] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_init.cpp:625:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_init.cpp:169:21: style: Parameter 'argc' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_init.cpp:418:29: style: Parameter 'argc' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:109:44: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:221:44: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:272:31: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:274:39: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:275:39: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:304:48: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:373:21: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:374:21: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:375:21: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:263:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:363:10: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:292:43: style:inconclusive: Function 'tMPI_Cart_destroy' argument 1 names different: declaration 'top' definition 'cart'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/thread_mpi/src/impl.h:758:43: note: Function 'tMPI_Cart_destroy' argument 1 names different: declaration 'top' definition 'cart'. gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:292:43: note: Function 'tMPI_Cart_destroy' argument 1 names different: declaration 'top' definition 'cart'. gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:139:41: style: Parameter 'coords' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:216:62: style: Parameter 'periods' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:216:51: style: Parameter 'dims' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:259:66: style: Parameter 'dims' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:260:33: style: Parameter 'periods' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_ops.h:103:1: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_ops.h:104:1: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_ops.h:106:1: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_ops.h:94:1: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_ops.h:97:1: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_ops.h:99:1: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_ops.h:100:1: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_ops.h:110:1: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_ops.h:111:1: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_ops.h:112:1: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/type.cpp:242:26: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/type.cpp:248:20: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/thread_mpi/src/type.cpp:261:42: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:845:10: performance:inconclusive: Technically the member function 'tinyxml2::XMLNode::DeleteChild' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:699:15: note: Technically the member function 'tinyxml2::XMLNode::DeleteChild' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:845:10: note: Technically the member function 'tinyxml2::XMLNode::DeleteChild' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:911:10: performance:inconclusive: Technically the member function 'tinyxml2::XMLNode::InsertChildPreamble' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:940:15: note: Technically the member function 'tinyxml2::XMLNode::InsertChildPreamble' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:911:10: note: Technically the member function 'tinyxml2::XMLNode::InsertChildPreamble' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1700:10: performance:inconclusive: Technically the member function 'tinyxml2::XMLDocument::DeleteNode' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1800:19: note: Technically the member function 'tinyxml2::XMLDocument::DeleteNode' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1700:10: note: Technically the member function 'tinyxml2::XMLDocument::DeleteNode' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:263:8: style:inconclusive: Technically the member function 'DynArray < const char * , 10 >::operator[]' can be const. [functionConst] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:291:8: style:inconclusive: Technically the member function 'DynArray < const char * , 10 >::Mem' can be const. [functionConst] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:958:5: style: Class 'XMLText' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:988:5: style: Class 'XMLComment' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1026:5: style: Class 'XMLDeclaration' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1060:5: style: Class 'XMLUnknown' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1517:5: style: Class 'XMLElement' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1555:5: style: Class 'XMLDocument' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1820:5: style: Class 'XMLHandle' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1824:5: style: Class 'XMLHandle' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1903:5: style: Class 'XMLConstHandle' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1906:5: style: Class 'XMLConstHandle' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:2016:5: style: Class 'XMLPrinter' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:935:18: style: The function 'Accept' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:888:18: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:935:18: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:937:22: style: The function 'ToText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:670:23: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:937:22: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:940:28: style: The function 'ToText' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:693:30: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:940:28: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:953:11: style: The function 'ParseDeep' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:891:19: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:953:11: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:954:22: style: The function 'ShallowClone' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:856:22: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:954:22: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:955:18: style: The function 'ShallowEqual' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:864:18: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:955:18: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:974:25: style: The function 'ToComment' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:674:26: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:974:25: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:977:31: style: The function 'ToComment' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:696:32: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:977:31: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:981:18: style: The function 'Accept' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:888:18: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:981:18: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:983:11: style: The function 'ParseDeep' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:891:19: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:983:11: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:984:22: style: The function 'ShallowClone' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:856:22: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:984:22: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:985:18: style: The function 'ShallowEqual' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:864:18: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:985:18: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1012:29: style: The function 'ToDeclaration' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:682:29: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1012:29: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1015:35: style: The function 'ToDeclaration' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:702:35: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1015:35: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1019:18: style: The function 'Accept' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:888:18: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1019:18: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1021:11: style: The function 'ParseDeep' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:891:19: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1021:11: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1022:22: style: The function 'ShallowClone' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:856:22: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1022:22: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1023:18: style: The function 'ShallowEqual' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:864:18: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1023:18: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1046:25: style: The function 'ToUnknown' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:686:26: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1046:25: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1049:31: style: The function 'ToUnknown' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:705:32: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1049:31: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1053:18: style: The function 'Accept' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:888:18: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1053:18: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1055:11: style: The function 'ParseDeep' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:891:19: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1055:11: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1056:22: style: The function 'ShallowClone' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:856:22: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1056:22: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1057:18: style: The function 'ShallowEqual' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:864:18: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1057:18: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1189:25: style: The function 'ToElement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:666:26: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1189:25: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1192:31: style: The function 'ToElement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:690:32: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1192:31: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1195:18: style: The function 'Accept' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:888:18: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1195:18: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1512:11: style: The function 'ParseDeep' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:891:19: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1512:11: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1513:22: style: The function 'ShallowClone' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:856:22: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1513:22: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1514:18: style: The function 'ShallowEqual' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:864:18: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1514:18: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1558:26: style: The function 'ToDocument' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:678:26: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1558:26: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1561:32: style: The function 'ToDocument' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:699:33: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1561:32: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1657:18: style: The function 'Accept' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:888:18: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1657:18: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1731:22: style: The function 'ShallowClone' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:856:22: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1731:22: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1734:18: style: The function 'ShallowEqual' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:864:18: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1734:18: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:2053:18: style: The function 'VisitEnter' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:478:18: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:2053:18: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:2054:18: style: The function 'VisitExit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:482:18: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:2054:18: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:2058:18: style: The function 'VisitEnter' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:487:18: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:2058:18: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:2059:18: style: The function 'VisitExit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:491:18: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:2059:18: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:2061:18: style: The function 'Visit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:500:18: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:2061:18: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:2062:18: style: The function 'Visit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:504:18: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:2062:18: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:2063:18: style: The function 'Visit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:496:18: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:2063:18: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:2064:18: style: The function 'Visit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:508:18: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:2064:18: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:351:10: style: The function 'Clear' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:335:18: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:351:10: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:364:17: style: The function 'ItemSize' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:331:17: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:364:17: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:371:19: style: The function 'Alloc' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:332:19: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:371:19: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:395:18: style: The function 'Free' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:333:18: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:395:18: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:412:10: style: The function 'SetTracked' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:334:18: note: Virtual function in base class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:412:10: note: Function in derived class gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:372:21: style: Condition '*(p+2)=='x'' is always false [knownConditionTrueFalse] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:365:27: note: Assuming condition '*(p+2)' is true gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:372:21: note: Condition '*(p+2)=='x'' is always false gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:417:18: style: Condition '!(*q)' is always false [knownConditionTrueFalse] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:365:27: note: Assuming condition '*(p+2)' is true gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:417:18: note: Condition '!(*q)' is always false gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:408:9: portability: %d in format string (no. 3) requires 'int' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:408:9: portability: %d in format string (no. 5) requires 'int' but the argument type is 'size_t {aka unsigned long}'. [invalidPrintfArgType_sint] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:122:33: style:inconclusive: Function 'ParseText' argument 1 names different: declaration 'in' definition 'p'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:185:28: note: Function 'ParseText' argument 1 names different: declaration 'in' definition 'p'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:122:33: note: Function 'ParseText' argument 1 names different: declaration 'in' definition 'p'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:142:33: style:inconclusive: Function 'ParseName' argument 1 names different: declaration 'in' definition 'p'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:186:28: note: Function 'ParseName' argument 1 names different: declaration 'in' definition 'p'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:142:33: note: Function 'ParseName' argument 1 names different: declaration 'in' definition 'p'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:293:52: style:inconclusive: Function 'ReadBOM' argument 2 names different: declaration 'hasBOM' definition 'bom'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:603:54: note: Function 'ReadBOM' argument 2 names different: declaration 'hasBOM' definition 'bom'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:293:52: note: Function 'ReadBOM' argument 2 names different: declaration 'hasBOM' definition 'bom'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:654:37: style:inconclusive: Function 'SetValue' argument 1 names different: declaration 'val' definition 'str'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:723:32: note: Function 'SetValue' argument 1 names different: declaration 'val' definition 'str'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:654:37: note: Function 'SetValue' argument 1 names different: declaration 'val' definition 'str'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:980:46: style:inconclusive: Function 'ShallowClone' argument 1 names different: declaration 'document' definition 'doc'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:954:49: note: Function 'ShallowClone' argument 1 names different: declaration 'document' definition 'doc'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:980:46: note: Function 'ShallowClone' argument 1 names different: declaration 'document' definition 'doc'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1029:49: style:inconclusive: Function 'ShallowClone' argument 1 names different: declaration 'document' definition 'doc'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:984:49: note: Function 'ShallowClone' argument 1 names different: declaration 'document' definition 'doc'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1029:49: note: Function 'ShallowClone' argument 1 names different: declaration 'document' definition 'doc'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1079:53: style:inconclusive: Function 'ShallowClone' argument 1 names different: declaration 'document' definition 'doc'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1022:49: note: Function 'ShallowClone' argument 1 names different: declaration 'document' definition 'doc'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1079:53: note: Function 'ShallowClone' argument 1 names different: declaration 'document' definition 'doc'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1129:49: style:inconclusive: Function 'ShallowClone' argument 1 names different: declaration 'document' definition 'doc'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1056:49: note: Function 'ShallowClone' argument 1 names different: declaration 'document' definition 'doc'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1129:49: note: Function 'ShallowClone' argument 1 names different: declaration 'document' definition 'doc'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1193:41: style:inconclusive: Function 'SetName' argument 1 names different: declaration 'name' definition 'n'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1160:31: note: Function 'SetName' argument 1 names different: declaration 'name' definition 'n'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1193:41: note: Function 'SetName' argument 1 names different: declaration 'name' definition 'n'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1244:46: style:inconclusive: Function 'SetAttribute' argument 1 names different: declaration 'value' definition 'v'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1140:36: note: Function 'SetAttribute' argument 1 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1244:46: note: Function 'SetAttribute' argument 1 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1250:38: style:inconclusive: Function 'SetAttribute' argument 1 names different: declaration 'value' definition 'v'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1142:28: note: Function 'SetAttribute' argument 1 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1250:38: note: Function 'SetAttribute' argument 1 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1258:43: style:inconclusive: Function 'SetAttribute' argument 1 names different: declaration 'value' definition 'v'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1144:33: note: Function 'SetAttribute' argument 1 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1258:43: note: Function 'SetAttribute' argument 1 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1266:39: style:inconclusive: Function 'SetAttribute' argument 1 names different: declaration 'value' definition 'v'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1146:29: note: Function 'SetAttribute' argument 1 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1266:39: note: Function 'SetAttribute' argument 1 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1273:41: style:inconclusive: Function 'SetAttribute' argument 1 names different: declaration 'value' definition 'v'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1148:31: note: Function 'SetAttribute' argument 1 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1273:41: note: Function 'SetAttribute' argument 1 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1280:40: style:inconclusive: Function 'SetAttribute' argument 1 names different: declaration 'value' definition 'v'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1150:30: note: Function 'SetAttribute' argument 1 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1280:40: note: Function 'SetAttribute' argument 1 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1350:31: style:inconclusive: Function 'SetText' argument 1 names different: declaration 'value' definition 'v'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1457:23: note: Function 'SetText' argument 1 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1350:31: note: Function 'SetText' argument 1 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1358:36: style:inconclusive: Function 'SetText' argument 1 names different: declaration 'value' definition 'v'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1459:28: note: Function 'SetText' argument 1 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1358:36: note: Function 'SetText' argument 1 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1366:32: style:inconclusive: Function 'SetText' argument 1 names different: declaration 'value' definition 'v'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1461:24: note: Function 'SetText' argument 1 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1366:32: note: Function 'SetText' argument 1 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1374:33: style:inconclusive: Function 'SetText' argument 1 names different: declaration 'value' definition 'v'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1465:25: note: Function 'SetText' argument 1 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1374:33: note: Function 'SetText' argument 1 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1382:34: style:inconclusive: Function 'SetText' argument 1 names different: declaration 'value' definition 'v'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1463:26: note: Function 'SetText' argument 1 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1382:34: note: Function 'SetText' argument 1 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1574:48: style:inconclusive: Function 'ParseDeep' argument 2 names different: declaration 'endTag' definition 'strPair'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1512:40: note: Function 'ParseDeep' argument 2 names different: declaration 'endTag' definition 'strPair'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1574:48: note: Function 'ParseDeep' argument 2 names different: declaration 'endTag' definition 'strPair'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1603:49: style:inconclusive: Function 'ShallowClone' argument 1 names different: declaration 'document' definition 'doc'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1513:49: note: Function 'ShallowClone' argument 1 names different: declaration 'document' definition 'doc'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1603:49: note: Function 'ShallowClone' argument 1 names different: declaration 'document' definition 'doc'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1745:50: style:inconclusive: Function 'NewComment' argument 1 names different: declaration 'comment' definition 'str'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1670:41: note: Function 'NewComment' argument 1 names different: declaration 'comment' definition 'str'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1745:50: note: Function 'NewComment' argument 1 names different: declaration 'comment' definition 'str'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1755:44: style:inconclusive: Function 'NewText' argument 1 names different: declaration 'text' definition 'str'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1676:35: note: Function 'NewText' argument 1 names different: declaration 'text' definition 'str'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1755:44: note: Function 'NewText' argument 1 names different: declaration 'text' definition 'str'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1765:58: style:inconclusive: Function 'NewDeclaration' argument 1 names different: declaration 'text' definition 'str'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1688:49: note: Function 'NewDeclaration' argument 1 names different: declaration 'text' definition 'str'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1765:58: note: Function 'NewDeclaration' argument 1 names different: declaration 'text' definition 'str'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1775:50: style:inconclusive: Function 'NewUnknown' argument 1 names different: declaration 'text' definition 'str'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1694:41: note: Function 'NewUnknown' argument 1 names different: declaration 'text' definition 'str'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1775:50: note: Function 'NewUnknown' argument 1 names different: declaration 'text' definition 'str'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1891:42: style:inconclusive: Function 'Parse' argument 1 names different: declaration 'xml' definition 'p'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1575:33: note: Function 'Parse' argument 1 names different: declaration 'xml' definition 'p'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1891:42: note: Function 'Parse' argument 1 names different: declaration 'xml' definition 'p'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1891:52: style:inconclusive: Function 'Parse' argument 2 names different: declaration 'nBytes' definition 'len'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1575:45: note: Function 'Parse' argument 2 names different: declaration 'nBytes' definition 'len'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:1891:52: note: Function 'Parse' argument 2 names different: declaration 'nBytes' definition 'len'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:2054:51: style:inconclusive: Function 'PrintString' argument 2 names different: declaration 'restrictedEntitySet' definition 'restricted'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:2104:41: note: Function 'PrintString' argument 2 names different: declaration 'restrictedEntitySet' definition 'restricted'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:2054:51: note: Function 'PrintString' argument 2 names different: declaration 'restrictedEntitySet' definition 'restricted'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:2092:50: style:inconclusive: Function 'PushHeader' argument 2 names different: declaration 'writeDeclaration' definition 'writeDec'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:2020:42: note: Function 'PushHeader' argument 2 names different: declaration 'writeDeclaration' definition 'writeDec'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:2092:50: note: Function 'PushHeader' argument 2 names different: declaration 'writeDeclaration' definition 'writeDec'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:2132:55: style:inconclusive: Function 'PushAttribute' argument 2 names different: declaration 'value' definition 'v'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:2027:47: note: Function 'PushAttribute' argument 2 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:2132:55: note: Function 'PushAttribute' argument 2 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:2140:60: style:inconclusive: Function 'PushAttribute' argument 2 names different: declaration 'value' definition 'v'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:2028:52: note: Function 'PushAttribute' argument 2 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:2140:60: note: Function 'PushAttribute' argument 2 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:2148:56: style:inconclusive: Function 'PushAttribute' argument 2 names different: declaration 'value' definition 'v'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:2029:48: note: Function 'PushAttribute' argument 2 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:2148:56: note: Function 'PushAttribute' argument 2 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:2156:58: style:inconclusive: Function 'PushAttribute' argument 2 names different: declaration 'value' definition 'v'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:2030:50: note: Function 'PushAttribute' argument 2 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.cpp:2156:58: note: Function 'PushAttribute' argument 2 names different: declaration 'value' definition 'v'. gromacs-2022-rc1/src/external/tng_io/external/zlib/deflate.c:155:32: style: struct member 'static_tree_desc_s::dummy' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/tng_io/external/zlib/deflate.c:1842:9: style: Variable 'bflush' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/external/tng_io/external/zlib/inftrees.c:34:21: style: Parameter 'lens' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/external/zlib/inflate.c:1501:17: style: Variable 'state->sane' is reassigned a value before the old one has been used. [redundantAssignment] gromacs-2022-rc1/src/external/tng_io/external/zlib/inflate.c:1497:17: note: state->sane is assigned gromacs-2022-rc1/src/external/tng_io/external/zlib/inflate.c:1501:17: note: state->sane is overwritten gromacs-2022-rc1/src/external/tng_io/external/zlib/trees.c:1155:14: style:inconclusive: Function 'bi_reverse' argument 1 names different: declaration 'value' definition 'code'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tng_io/external/zlib/trees.c:152:27: note: Function 'bi_reverse' argument 1 names different: declaration 'value' definition 'code'. gromacs-2022-rc1/src/external/tng_io/external/zlib/trees.c:1155:14: note: Function 'bi_reverse' argument 1 names different: declaration 'value' definition 'code'. gromacs-2022-rc1/src/external/tng_io/external/zlib/trees.c:1156:9: style:inconclusive: Function 'bi_reverse' argument 2 names different: declaration 'length' definition 'len'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tng_io/external/zlib/trees.c:152:27: note: Function 'bi_reverse' argument 2 names different: declaration 'length' definition 'len'. gromacs-2022-rc1/src/external/tng_io/external/zlib/trees.c:1156:9: note: Function 'bi_reverse' argument 2 names different: declaration 'length' definition 'len'. gromacs-2022-rc1/src/external/tng_io/external/zlib/trees.c:578:11: style: Parameter 'bl_count' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/external/zlib/zutil.c:308:31: style: Same expression on both sides of '-'. [duplicateExpression] gromacs-2022-rc1/src/external/tng_io/external/zlib/zutil.c:304:12: style: Parameter 'opaque' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/external/zlib/zutil.c:314:12: style: Parameter 'opaque' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/external/zlib/zutil.c:11:33: style: struct member 'internal_state::dummy' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/tng_io/src/compression/bwt.c:25:92: style: Parameter 'nrepeat' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/bwt.c:25:72: style: Parameter 'vals' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/bwt.c:308:40: style: Parameter 'input' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/bwlzh.c:166:11: style: The if condition is the same as the previous if condition [duplicateCondition] gromacs-2022-rc1/src/external/tng_io/src/compression/bwlzh.c:162:11: note: First condition gromacs-2022-rc1/src/external/tng_io/src/compression/bwlzh.c:166:11: note: Second condition gromacs-2022-rc1/src/external/tng_io/src/compression/bwlzh.c:317:19: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/external/tng_io/src/compression/bwlzh.c:202:15: note: Shadowed declaration gromacs-2022-rc1/src/external/tng_io/src/compression/bwlzh.c:317:19: note: Shadow variable gromacs-2022-rc1/src/external/tng_io/src/compression/bwlzh.c:357:27: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/external/tng_io/src/compression/bwlzh.c:202:15: note: Shadowed declaration gromacs-2022-rc1/src/external/tng_io/src/compression/bwlzh.c:357:27: note: Shadow variable gromacs-2022-rc1/src/external/tng_io/src/compression/bwlzh.c:381:27: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/external/tng_io/src/compression/bwlzh.c:202:15: note: Shadowed declaration gromacs-2022-rc1/src/external/tng_io/src/compression/bwlzh.c:381:27: note: Shadow variable gromacs-2022-rc1/src/external/tng_io/src/compression/bwlzh.c:424:23: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/external/tng_io/src/compression/bwlzh.c:202:15: note: Shadowed declaration gromacs-2022-rc1/src/external/tng_io/src/compression/bwlzh.c:424:23: note: Shadow variable gromacs-2022-rc1/src/external/tng_io/src/compression/bwlzh.c:665:27: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/external/tng_io/src/compression/bwlzh.c:605:15: note: Shadowed declaration gromacs-2022-rc1/src/external/tng_io/src/compression/bwlzh.c:665:27: note: Shadow variable gromacs-2022-rc1/src/external/tng_io/src/compression/coder.c:40:57: style:inconclusive: Function 'Ptngc_coder_deinit' argument 1 names different: declaration 'coder' definition 'coder_inst'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tng_io/include/compression/coder.h:31:57: note: Function 'Ptngc_coder_deinit' argument 1 names different: declaration 'coder' definition 'coder_inst'. gromacs-2022-rc1/src/external/tng_io/src/compression/coder.c:40:57: note: Function 'Ptngc_coder_deinit' argument 1 names different: declaration 'coder' definition 'coder_inst'. gromacs-2022-rc1/src/external/tng_io/src/compression/coder.c:45:64: style:inconclusive: Function 'Ptngc_out8bits' argument 1 names different: declaration 'coder' definition 'coder_inst'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tng_io/include/compression/coder.h:39:53: note: Function 'Ptngc_out8bits' argument 1 names different: declaration 'coder' definition 'coder_inst'. gromacs-2022-rc1/src/external/tng_io/src/compression/coder.c:45:64: note: Function 'Ptngc_out8bits' argument 1 names different: declaration 'coder' definition 'coder_inst'. gromacs-2022-rc1/src/external/tng_io/src/compression/coder.c:60:58: style:inconclusive: Function 'Ptngc_write_pattern' argument 1 names different: declaration 'coder' definition 'coder_inst'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tng_io/include/compression/coder.h:41:58: note: Function 'Ptngc_write_pattern' argument 1 names different: declaration 'coder' definition 'coder_inst'. gromacs-2022-rc1/src/external/tng_io/src/compression/coder.c:60:58: note: Function 'Ptngc_write_pattern' argument 1 names different: declaration 'coder' definition 'coder_inst'. gromacs-2022-rc1/src/external/tng_io/src/compression/coder.c:80:65: style:inconclusive: Function 'Ptngc_writebits' argument 1 names different: declaration 'coder' definition 'coder_inst'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tng_io/include/compression/coder.h:43:54: note: Function 'Ptngc_writebits' argument 1 names different: declaration 'coder' definition 'coder_inst'. gromacs-2022-rc1/src/external/tng_io/src/compression/coder.c:80:65: note: Function 'Ptngc_writebits' argument 1 names different: declaration 'coder' definition 'coder_inst'. gromacs-2022-rc1/src/external/tng_io/src/compression/coder.c:92:56: style:inconclusive: Function 'Ptngc_write32bits' argument 1 names different: declaration 'coder' definition 'coder_inst'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tng_io/include/compression/coder.h:44:56: note: Function 'Ptngc_write32bits' argument 1 names different: declaration 'coder' definition 'coder_inst'. gromacs-2022-rc1/src/external/tng_io/src/compression/coder.c:92:56: note: Function 'Ptngc_write32bits' argument 1 names different: declaration 'coder' definition 'coder_inst'. gromacs-2022-rc1/src/external/tng_io/src/compression/coder.c:115:58: style:inconclusive: Function 'Ptngc_writemanybits' argument 1 names different: declaration 'coder' definition 'coder_inst'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tng_io/include/compression/coder.h:45:58: note: Function 'Ptngc_writemanybits' argument 1 names different: declaration 'coder' definition 'coder_inst'. gromacs-2022-rc1/src/external/tng_io/src/compression/coder.c:115:58: note: Function 'Ptngc_writemanybits' argument 1 names different: declaration 'coder' definition 'coder_inst'. gromacs-2022-rc1/src/external/tng_io/src/compression/coder.c:214:55: style:inconclusive: Function 'Ptngc_pack_flush' argument 1 names different: declaration 'coder' definition 'coder_inst'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tng_io/include/compression/coder.h:40:55: note: Function 'Ptngc_pack_flush' argument 1 names different: declaration 'coder' definition 'coder_inst'. gromacs-2022-rc1/src/external/tng_io/src/compression/coder.c:214:55: note: Function 'Ptngc_pack_flush' argument 1 names different: declaration 'coder' definition 'coder_inst'. gromacs-2022-rc1/src/external/tng_io/src/compression/coder.c:221:65: style:inconclusive: Function 'Ptngc_pack_array' argument 1 names different: declaration 'coder' definition 'coder_inst'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tng_io/include/compression/coder.h:32:65: note: Function 'Ptngc_pack_array' argument 1 names different: declaration 'coder' definition 'coder_inst'. gromacs-2022-rc1/src/external/tng_io/src/compression/coder.c:221:65: note: Function 'Ptngc_pack_array' argument 1 names different: declaration 'coder' definition 'coder_inst'. gromacs-2022-rc1/src/external/tng_io/src/compression/coder.c:492:56: style:inconclusive: Function 'Ptngc_unpack_array' argument 1 names different: declaration 'coder' definition 'coder_inst'. [funcArgNamesDifferent] gromacs-2022-rc1/src/external/tng_io/include/compression/coder.h:33:56: note: Function 'Ptngc_unpack_array' argument 1 names different: declaration 'coder' definition 'coder_inst'. gromacs-2022-rc1/src/external/tng_io/src/compression/coder.c:492:56: note: Function 'Ptngc_unpack_array' argument 1 names different: declaration 'coder' definition 'coder_inst'. gromacs-2022-rc1/src/external/tng_io/src/compression/dict.c:24:46: style: Parameter 'vals' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/huffman.c:220:41: style: Parameter 'dict' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/huffman.c:219:47: style: Parameter 'vals' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/huffman.c:470:43: style: Parameter 'huffman_dict_unpacked' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/huffman.c:25:19: style: struct member 'htree_leaf::nodeleaf' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/tng_io/src/compression/huffman.c:33:19: style: struct member 'htree_node::nodeleaf' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/tng_io/src/compression/lz77.c:309:41: style: Parameter 'data' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/lz77.c:311:35: style: Parameter 'offsets' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/mtf.c:62:51: style: Parameter 'vals' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/mtf.c:81:52: style: Parameter 'vals' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/mtf.c:138:53: style: Parameter 'valsmtf' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/mtf.c:176:43: style: Parameter 'vals' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/mtf.c:177:37: style: Parameter 'dict' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/mtf.c:218:45: style: Parameter 'valsmtf' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/mtf.c:219:39: style: Parameter 'dict' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/rle.c:39:43: style: Parameter 'vals' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/rle.c:71:45: style: Parameter 'rle' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/vals16.c:16:46: style: Parameter 'vals' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/vals16.c:48:48: style: Parameter 'vals16' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:31:38: style: Parameter 'x' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:51:43: style: Parameter 'x' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:95:42: style: Parameter 'quant' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:110:42: style: Parameter 'quant' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:150:47: style: Parameter 'quant' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:168:53: style: Parameter 'quant' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:185:51: style: Parameter 'quant' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:226:47: style: Parameter 'quant' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:247:53: style: Parameter 'quant' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:264:51: style: Parameter 'quant' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:294:43: style: Parameter 'buf' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:1856:60: style: Parameter 'algo' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:1866:52: style: Parameter 'algo' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:1876:60: style: Parameter 'algo' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:1886:52: style: Parameter 'algo' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/xtc2.c:355:28: style: Parameter 'in' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/xtc2.c:362:33: style: Parameter 'input' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/xtc2.c:362:45: style: Parameter 'minint' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/xtc2.c:594:31: style: Parameter 'input_ptr' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/xtc2.c:594:88: style: Parameter 'minint' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/xtc2.c:685:89: style: Parameter 'new_large_ints' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/xtc3.c:462:44: style: Parameter 'ints' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/xtc3.c:473:66: style: Parameter 'input' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/xtc3.c:798:42: style: Parameter 'ints' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/compression/xtc3.c:1702:35: style: Parameter 'minint' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/tests/compression/testsuite.c:80:27: style: Parameter 'base' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/tests/compression/testsuite.c:213:26: style: Parameter 'intbox' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/tests/compression/testsuite.c:225:29: style: Parameter 'intbox' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/tests/compression/testsuite.c:237:27: style: Parameter 'arr1' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/tests/compression/testsuite.c:237:39: style: Parameter 'arr2' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:13761:9: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:13874:9: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:7553:5: error: Address of local auto-variable assigned to a function parameter. [autoVariables] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:7594:5: error: Address of local auto-variable assigned to a function parameter. [autoVariables] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:8022:5: error: Address of local auto-variable assigned to a function parameter. [autoVariables] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:15187:17: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:10617:21: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:10615:20: note: outer condition: file_pos>0 gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:10617:21: note: identical inner condition: file_pos>0 gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:10646:21: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:10644:20: note: outer condition: file_pos>0 gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:10646:21: note: identical inner condition: file_pos>0 gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:10676:21: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:10674:20: note: outer condition: file_pos>0 gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:10676:21: note: identical inner condition: file_pos>0 gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:1048:59: style: Condition '*((const char*)&block->header_contents_size)!=0x00' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:1049:65: style: Condition '*((const char*)(&block->header_contents_size)+7)==0x00' is always false [knownConditionTrueFalse] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:14399:21: style: Condition 'first_frame!=frame_set->first_frame' is always false [knownConditionTrueFalse] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:14389:17: note: first_frame is assigned 'frame_set->first_frame' here. gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:14392:13: note: Assuming condition is false gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:14399:21: note: Condition 'first_frame!=frame_set->first_frame' is always false gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:14402:21: style: Condition 'first_frame!=frame_set->first_frame' is always false [knownConditionTrueFalse] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:14389:17: note: first_frame is assigned 'frame_set->first_frame' here. gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:14392:13: note: Assuming condition is false gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:14402:21: note: Condition 'first_frame!=frame_set->first_frame' is always false gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:14749:20: style: Condition 'first_frame!=frame_set->first_frame' is always false [knownConditionTrueFalse] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:14730:17: note: first_frame is assigned 'frame_set->first_frame' here. gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:14733:13: note: Assuming condition is false gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:14749:20: note: Condition 'first_frame!=frame_set->first_frame' is always false gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:3613:17: error: Memory leak: frame_set.molecule_cnt_list [memleak] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:3986:17: error: Memory leak: mapping.real_particle_numbers [memleak] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:5418:9: error: Memory leak: data.block_name [memleak] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:9287:13: error: Memory leak: dest.input_file_path [memleak] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:9376:5: error: Memory leak: dest.output_file_path [memleak] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:4291:47: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:4300:41: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:4345:47: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:4355:51: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:4364:41: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:4374:45: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:4386:47: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:4393:41: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:4432:47: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:4441:41: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:4486:47: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:4495:51: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:4504:41: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:4513:45: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:4525:47: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:4534:41: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:4602:17: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:4617:17: portability:inconclusive: Casting from double * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:6038:34: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:6091:34: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:14062:55: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:14080:55: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:14130:45: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:14142:45: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:14620:55: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:14632:45: portability: Casting between char * and float * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:14661:55: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:14673:45: portability: Casting between char * and double * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:15161:5: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:15165:5: note: Found duplicate branches for 'if' and 'else'. gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:15161:5: note: Found duplicate branches for 'if' and 'else'. gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:4319:86: style: Same expression on both sides of '||'. [duplicateExpression] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:4460:86: style: Same expression on both sides of '||'. [duplicateExpression] gromacs-2022-rc1/src/external/tng_io/src/tests/tng_io_testing.c:840:10: style: Variable 'stat' is reassigned a value before the old one has been used. [redundantAssignment] gromacs-2022-rc1/src/external/tng_io/src/tests/tng_io_testing.c:774:10: note: stat is assigned gromacs-2022-rc1/src/external/tng_io/src/tests/tng_io_testing.c:840:10: note: stat is overwritten gromacs-2022-rc1/src/external/tng_io/src/tests/tng_io_testing.c:1322:10: style: Variable 'stat' is reassigned a value before the old one has been used. [redundantAssignment] gromacs-2022-rc1/src/external/tng_io/src/tests/tng_io_testing.c:1318:10: note: stat is assigned gromacs-2022-rc1/src/external/tng_io/src/tests/tng_io_testing.c:1322:10: note: stat is overwritten gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:163:13: style: struct member 'tng_trajectory_frame_set::n_mapping_blocks' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:165:34: style: struct member 'tng_trajectory_frame_set::mappings' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:167:13: style: struct member 'tng_trajectory_frame_set::first_frame' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:169:13: style: struct member 'tng_trajectory_frame_set::n_frames' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:172:13: style: struct member 'tng_trajectory_frame_set::n_written_frames' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:175:13: style: struct member 'tng_trajectory_frame_set::n_unwritten_frames' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:180:14: style: struct member 'tng_trajectory_frame_set::molecule_cnt_list' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:183:13: style: struct member 'tng_trajectory_frame_set::n_particles' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:185:13: style: struct member 'tng_trajectory_frame_set::next_frame_set_file_pos' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:187:13: style: struct member 'tng_trajectory_frame_set::prev_frame_set_file_pos' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:189:13: style: struct member 'tng_trajectory_frame_set::medium_stride_next_frame_set_file_pos' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:191:13: style: struct member 'tng_trajectory_frame_set::medium_stride_prev_frame_set_file_pos' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:193:13: style: struct member 'tng_trajectory_frame_set::long_stride_next_frame_set_file_pos' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:195:13: style: struct member 'tng_trajectory_frame_set::long_stride_prev_frame_set_file_pos' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:197:12: style: struct member 'tng_trajectory_frame_set::first_frame_time' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:201:9: style: struct member 'tng_trajectory_frame_set::n_particle_data_blocks' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:203:22: style: struct member 'tng_trajectory_frame_set::tr_particle_data' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:205:9: style: struct member 'tng_trajectory_frame_set::n_data_blocks' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:207:22: style: struct member 'tng_trajectory_frame_set::tr_data' is never used. [unusedStructMember] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:4233:32: style: Variable 'algo_find_n_frames' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:4569:20: style: Variable 'd_dest' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:4570:19: style: Variable 'f_dest' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:13721:20: style: Variable 'values' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:13761:16: style: Variable 'values' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/external/tng_io/src/lib/tng_io.c:13874:16: style: Variable 'values' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/analysisdata/datastorage.cpp:589:30: style: Local variable 'pointSet' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/analysisdata/datastorage.cpp:361:29: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/analysisdata/datastorage.cpp:589:30: note: Shadow variable gromacs-2022-rc1/src/gromacs/analysisdata/datastorage.cpp:621:37: style: Local variable 'builder' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/analysisdata/datastorage.cpp:338:31: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/analysisdata/datastorage.cpp:621:37: note: Shadow variable gromacs-2022-rc1/src/gromacs/analysisdata/modules/histogram.h:235:5: style: Class 'AnalysisHistogramSettings' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/analysisdata/tests/analysisdata.cpp:115:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/analysisdata/tests/arraydata.cpp:96:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/analysisdata/tests/average.cpp:172:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/analysisdata/tests/histogram.cpp:83:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/analysisdata/tests/datatest.cpp:89:36: style: Local variable 'pointSet' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/analysisdata/tests/datatest.h:166:42: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/analysisdata/tests/datatest.cpp:89:36: note: Shadow variable gromacs-2022-rc1/src/gromacs/analysisdata/tests/datatest.cpp:95:36: style: Local variable 'pointSet' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/analysisdata/tests/datatest.h:166:42: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/analysisdata/tests/datatest.cpp:95:36: note: Shadow variable gromacs-2022-rc1/src/gromacs/analysisdata/tests/datatest.cpp:102:36: style: Local variable 'pointSet' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/analysisdata/tests/datatest.h:166:42: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/analysisdata/tests/datatest.cpp:102:36: note: Shadow variable gromacs-2022-rc1/src/gromacs/analysisdata/tests/datatest.cpp:110:36: style: Local variable 'pointSet' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/analysisdata/tests/datatest.h:166:42: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/analysisdata/tests/datatest.cpp:110:36: note: Shadow variable gromacs-2022-rc1/src/gromacs/analysisdata/tests/datatest.cpp:150:33: style: Local variable 'frame' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/analysisdata/tests/datatest.h:231:39: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/analysisdata/tests/datatest.cpp:150:33: note: Shadow variable gromacs-2022-rc1/src/gromacs/analysisdata/tests/lifetime.cpp:134:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/analysisdata/tests/datatest.cpp:156:33: style: Local variable 'frame' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/analysisdata/tests/datatest.h:231:39: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/analysisdata/tests/datatest.cpp:156:33: note: Shadow variable gromacs-2022-rc1/src/gromacs/analysisdata/tests/datatest.cpp:162:33: style: Local variable 'frame' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/analysisdata/tests/datatest.h:231:39: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/analysisdata/tests/datatest.cpp:162:33: note: Shadow variable gromacs-2022-rc1/src/gromacs/analysisdata/tests/datatest.cpp:168:33: style: Local variable 'frame' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/analysisdata/tests/datatest.h:231:39: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/analysisdata/tests/datatest.cpp:168:33: note: Shadow variable gromacs-2022-rc1/src/gromacs/analysisdata/tests/mock_datamodule.cpp:301:5: style: Class 'StaticDataFrameHeaderChecker' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biaswriter.h:116:26: style:inconclusive: Technically the member function 'gmx::AwhEnergyBlock::data' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biaswriter.h:133:5: style: Class 'BiasWriter' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/applied_forces/awh/awh.cpp:171:32: style:inconclusive: Function 'Awh' argument 8 names different: declaration 'numLambdaStates' definition 'numFepLambdaStates'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/applied_forces/awh/awh.h:143:31: note: Function 'Awh' argument 8 names different: declaration 'numLambdaStates' definition 'numFepLambdaStates'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/awh.cpp:171:32: note: Function 'Awh' argument 8 names different: declaration 'numLambdaStates' definition 'numFepLambdaStates'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/awh.cpp:172:32: style:inconclusive: Function 'Awh' argument 9 names different: declaration 'lambdaState' definition 'fepLambdaState'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/applied_forces/awh/awh.h:144:31: note: Function 'Awh' argument 9 names different: declaration 'lambdaState' definition 'fepLambdaState'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/awh.cpp:172:32: note: Function 'Awh' argument 9 names different: declaration 'lambdaState' definition 'fepLambdaState'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/dimparams.h:124:22: style: Local variable 'fepDimParams' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/applied_forces/awh/dimparams.h:139:25: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/applied_forces/awh/dimparams.h:124:22: note: Shadow variable gromacs-2022-rc1/src/gromacs/applied_forces/awh/correlationgrid.h:103:77: performance:inconclusive: Function parameter 'data' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/applied_forces/awh/awh.cpp:148:64: performance:inconclusive: Function parameter 'biasCoupledToSystem' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/applied_forces/awh/awh.cpp:291:23: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/applied_forces/awh/bias.cpp:362:43: style:inconclusive: Function 'Bias' argument 4 names different: declaration 'dimParams' definition 'dimParamsInit'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/applied_forces/awh/bias.h:169:41: note: Function 'Bias' argument 4 names different: declaration 'dimParams' definition 'dimParamsInit'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/bias.cpp:362:43: note: Function 'Bias' argument 4 names different: declaration 'dimParams' definition 'dimParamsInit'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/bias.cpp:134:23: style: Local variable 'isSampleCoordStep' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/applied_forces/awh/bias.h:364:10: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/applied_forces/awh/bias.cpp:134:23: note: Shadow variable gromacs-2022-rc1/src/gromacs/applied_forces/awh/bias.cpp:362:43: performance:inconclusive: Function parameter 'dimParamsInit' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/applied_forces/awh/bias.cpp:432:67: performance:inconclusive: Function parameter 'neighborLambdaDhdl' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/applied_forces/awh/bias.cpp:258:20: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasgrid.cpp:828:41: style: The comparison 'c_numPointsPerSigma >= 1.0' is always true. [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasgrid.h:191:52: note: 'c_numPointsPerSigma' is assigned value '1.0' here. gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasgrid.cpp:828:41: note: The comparison 'c_numPointsPerSigma >= 1.0' is always true. gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasgrid.cpp:265:54: style:inconclusive: Function 'linearArrayIndexToMultiDim' argument 2 names different: declaration 'ndim' definition 'numDimensions'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasgrid.h:312:54: note: Function 'linearArrayIndexToMultiDim' argument 2 names different: declaration 'ndim' definition 'numDimensions'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasgrid.cpp:265:54: note: Function 'linearArrayIndexToMultiDim' argument 2 names different: declaration 'ndim' definition 'numDimensions'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasgrid.cpp:294:63: style:inconclusive: Function 'multiDimArrayIndexToLinear' argument 2 names different: declaration 'numDim' definition 'numDimensions'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasgrid.h:295:63: note: Function 'multiDimArrayIndexToLinear' argument 2 names different: declaration 'numDim' definition 'numDimensions'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasgrid.cpp:294:63: note: Function 'multiDimArrayIndexToLinear' argument 2 names different: declaration 'numDim' definition 'numDimensions'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasgrid.cpp:490:44: style:inconclusive: Function 'advancePointInSubgrid' argument 3 names different: declaration 'subgridNpoints' definition 'subgridNumPoints'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasgrid.h:335:44: note: Function 'advancePointInSubgrid' argument 3 names different: declaration 'subgridNpoints' definition 'subgridNumPoints'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasgrid.cpp:490:44: note: Function 'advancePointInSubgrid' argument 3 names different: declaration 'subgridNpoints' definition 'subgridNumPoints'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasgrid.cpp:728:16: style: Local variable 'point' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasgrid.h:214:22: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasgrid.cpp:728:16: note: Shadow variable gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasgrid.cpp:819:14: style: Local variable 'numPoints' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasgrid.h:208:12: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasgrid.cpp:819:14: note: Shadow variable gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasparams.cpp:228:50: performance:inconclusive: Function parameter 'dimParams' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasparams.cpp:185:25: style: Unused variable: x [unusedVariable] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biassharing.cpp:70:62: performance:inconclusive: Function parameter 'localShareIndices' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biassharing.cpp:273:59: performance:inconclusive: Function parameter 'data' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biassharing.cpp:278:60: performance:inconclusive: Function parameter 'data' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biassharing.cpp:283:59: performance:inconclusive: Function parameter 'data' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biassharing.cpp:288:62: performance:inconclusive: Function parameter 'data' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:1414:23: style: The scope of the variable 'bias' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:585:73: style:inconclusive: Function 'getSkippedUpdateHistogramScaleFactors' argument 2 names different: declaration 'weighthistScaling' definition 'weightHistScaling'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.h:304:66: note: Function 'getSkippedUpdateHistogramScaleFactors' argument 2 names different: declaration 'weighthistScaling' definition 'weightHistScaling'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:585:73: note: Function 'getSkippedUpdateHistogramScaleFactors' argument 2 names different: declaration 'weighthistScaling' definition 'weightHistScaling'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:586:73: style:inconclusive: Function 'getSkippedUpdateHistogramScaleFactors' argument 3 names different: declaration 'logPmfsumScaling' definition 'logPmfSumScaling'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.h:305:66: note: Function 'getSkippedUpdateHistogramScaleFactors' argument 3 names different: declaration 'logPmfsumScaling' definition 'logPmfSumScaling'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:586:73: note: Function 'getSkippedUpdateHistogramScaleFactors' argument 3 names different: declaration 'logPmfsumScaling' definition 'logPmfSumScaling'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:595:16: style: Local variable 'histogramSize' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.h:521:26: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:595:16: note: Shadow variable gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:894:13: style: Local variable 'notVisitedHigh' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:842:10: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:894:13: note: Shadow variable gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:895:13: style: Local variable 'notVisitedLow' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:841:10: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:895:13: note: Shadow variable gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:1126:12: style: Local variable 'newHistogramSize' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.h:378:12: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:1126:12: note: Shadow variable gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:1826:18: style: Local variable 'histogramSize' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.h:521:26: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:1826:18: note: Shadow variable gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:256:60: performance:inconclusive: Function parameter 'dimParams' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:471:62: performance:inconclusive: Function parameter 'neighborLambdaDhdl' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:472:62: performance:inconclusive: Function parameter 'forceWorkBuffer' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:501:58: performance:inconclusive: Function parameter 'probWeightNeighbor' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:502:58: performance:inconclusive: Function parameter 'neighborLambdaDhdl' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:1065:84: performance:inconclusive: Function parameter 'dimParams' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:1208:86: performance:inconclusive: Function parameter 'dimParams' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:1210:83: performance:inconclusive: Function parameter 'neighborLambdaEnergies' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:1299:63: performance:inconclusive: Function parameter 'dimParams' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:1380:65: performance:inconclusive: Function parameter 'probWeightNeighbor' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:1525:71: performance:inconclusive: Function parameter 'dimParams' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:1790:62: performance:inconclusive: Function parameter 'dimParams' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:669:16: style: Variable 'pointIndex' can be declared as reference to const [constVariable] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:1099:15: style: Variable 'globalIndex' can be declared as reference to const [constVariable] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:154:18: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:1107:9: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:1292:11: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:842:30: style: Variable 'notVisitedHigh' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biaswriter.cpp:385:73: style:inconclusive: Function 'writeToEnergySubblocks' argument 2 names different: declaration 'subblock' definition 'sub'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biaswriter.h:147:65: note: Function 'writeToEnergySubblocks' argument 2 names different: declaration 'subblock' definition 'sub'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/biaswriter.cpp:385:73: note: Function 'writeToEnergySubblocks' argument 2 names different: declaration 'subblock' definition 'sub'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/biaswriter.cpp:230:25: style: Variable 'point' can be declared as reference to const [constVariable] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biaswriter.cpp:207:23: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biaswriter.cpp:232:21: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/applied_forces/awh/biaswriter.cpp:240:23: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/applied_forces/awh/coordstate.cpp:134:70: performance:inconclusive: Function parameter 'probWeightNeighbor' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/applied_forces/awh/correlationgrid.cpp:84:53: style:inconclusive: Function 'CorrelationGrid' argument 2 names different: declaration 'numDims' definition 'numDim'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/applied_forces/awh/correlationgrid.h:91:40: note: Function 'CorrelationGrid' argument 2 names different: declaration 'numDims' definition 'numDim'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/correlationgrid.cpp:84:53: note: Function 'CorrelationGrid' argument 2 names different: declaration 'numDims' definition 'numDim'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/correlationhistory.cpp:76:83: style:inconclusive: Function 'initCorrelationGridHistoryFromState' argument 1 names different: declaration 'corrGrid' definition 'correlationGrid'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/applied_forces/awh/correlationhistory.h:67:83: note: Function 'initCorrelationGridHistoryFromState' argument 1 names different: declaration 'corrGrid' definition 'correlationGrid'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/correlationhistory.cpp:76:83: note: Function 'initCorrelationGridHistoryFromState' argument 1 names different: declaration 'corrGrid' definition 'correlationGrid'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/correlationhistory.cpp:89:59: style:inconclusive: Function 'updateCorrelationGridHistory' argument 1 names different: declaration 'corrGridHist' definition 'correlationGridHistory'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/applied_forces/awh/correlationhistory.h:84:59: note: Function 'updateCorrelationGridHistory' argument 1 names different: declaration 'corrGridHist' definition 'correlationGridHistory'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/correlationhistory.cpp:89:59: note: Function 'updateCorrelationGridHistory' argument 1 names different: declaration 'corrGridHist' definition 'correlationGridHistory'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/correlationhistory.cpp:90:59: style:inconclusive: Function 'updateCorrelationGridHistory' argument 2 names different: declaration 'corrGrid' definition 'correlationGrid'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/applied_forces/awh/correlationhistory.h:84:96: note: Function 'updateCorrelationGridHistory' argument 2 names different: declaration 'corrGrid' definition 'correlationGrid'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/correlationhistory.cpp:90:59: note: Function 'updateCorrelationGridHistory' argument 2 names different: declaration 'corrGrid' definition 'correlationGrid'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/histogramsize.cpp:115:12: style: Local variable 'newHistogramSize' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/applied_forces/awh/histogramsize.h:126:12: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/applied_forces/awh/histogramsize.cpp:115:12: note: Shadow variable gromacs-2022-rc1/src/gromacs/applied_forces/awh/histogramsize.cpp:213:67: performance:inconclusive: Function parameter 'pointStates' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/applied_forces/awh/histogramsize.cpp:214:67: performance:inconclusive: Function parameter 'weightsumCovering' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/applied_forces/awh/tests/awh_setup.cpp:231:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/applied_forces/awh/tests/bias.cpp:144:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/applied_forces/awh/read_params.cpp:511:9: style: Variable 'opt' is reassigned a value before the old one has been used. [redundantAssignment] gromacs-2022-rc1/src/gromacs/applied_forces/awh/read_params.cpp:505:9: note: opt is assigned gromacs-2022-rc1/src/gromacs/applied_forces/awh/read_params.cpp:511:9: note: opt is overwritten gromacs-2022-rc1/src/gromacs/applied_forces/awh/read_params.cpp:1289:67: style:inconclusive: Function 'checkAwhParams' argument 2 names different: declaration 'inputrec' definition 'ir'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/applied_forces/awh/read_params.h:72:67: note: Function 'checkAwhParams' argument 2 names different: declaration 'inputrec' definition 'ir'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/read_params.cpp:1289:67: note: Function 'checkAwhParams' argument 2 names different: declaration 'inputrec' definition 'ir'. gromacs-2022-rc1/src/gromacs/applied_forces/awh/read_params.cpp:1367:13: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/applied_forces/awh/tests/bias_fep_lambda_state.cpp:137:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/applied_forces/awh/tests/biasstate.cpp:114:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/applied_forces/densityfitting/densityfitting.cpp:188:13: style:inconclusive: Technically the member function 'gmx::::DensityFittingSimulationParameterSetup::periodicBoundaryConditionType' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/applied_forces/densityfitting/densityfitting.cpp:114:17: warning: Either the condition 'localAtomSet_==nullptr' is redundant or there is possible null pointer dereference: localAtomSet_. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/applied_forces/densityfitting/densityfitting.cpp:108:27: note: Assuming that condition 'localAtomSet_==nullptr' is not redundant gromacs-2022-rc1/src/gromacs/applied_forces/densityfitting/densityfitting.cpp:114:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/applied_forces/densityfitting/densityfitting.cpp:128:17: warning: Either the condition 'transformationToDensityLattice_==nullptr' is redundant or there is possible null pointer dereference: transformationToDensityLattice_. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/applied_forces/densityfitting/densityfitting.cpp:123:45: note: Assuming that condition 'transformationToDensityLattice_==nullptr' is not redundant gromacs-2022-rc1/src/gromacs/applied_forces/densityfitting/densityfitting.cpp:128:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/applied_forces/densityfitting/densityfitting.cpp:140:16: warning: Either the condition 'referenceDensity_==nullptr' is redundant or there is possible null pointer dereference: referenceDensity_. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/applied_forces/densityfitting/densityfitting.cpp:136:31: note: Assuming that condition 'referenceDensity_==nullptr' is not redundant gromacs-2022-rc1/src/gromacs/applied_forces/densityfitting/densityfitting.cpp:140:16: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/applied_forces/densityfitting/densityfitting.cpp:168:23: warning: Either the condition 'referenceDensity_==nullptr' is redundant or there is possible null pointer dereference: referenceDensity_. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/applied_forces/densityfitting/densityfitting.cpp:162:31: note: Assuming that condition 'referenceDensity_==nullptr' is not redundant gromacs-2022-rc1/src/gromacs/applied_forces/densityfitting/densityfitting.cpp:168:23: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/applied_forces/densityfitting/densityfitting.cpp:169:45: warning: Either the condition 'referenceDensity_==nullptr' is redundant or there is possible null pointer dereference: referenceDensity_. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/applied_forces/densityfitting/densityfitting.cpp:162:31: note: Assuming that condition 'referenceDensity_==nullptr' is not redundant gromacs-2022-rc1/src/gromacs/applied_forces/densityfitting/densityfitting.cpp:169:45: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/applied_forces/densityfitting/densityfitting.cpp:195:17: warning: Either the condition 'pbcType_==nullptr' is redundant or there is possible null pointer dereference: pbcType_. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/applied_forces/densityfitting/densityfitting.cpp:190:22: note: Assuming that condition 'pbcType_==nullptr' is not redundant gromacs-2022-rc1/src/gromacs/applied_forces/densityfitting/densityfitting.cpp:195:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/applied_forces/densityfitting/densityfitting.cpp:171:35: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/applied_forces/densityfitting/tests/densityfitting.cpp:123:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/applied_forces/densityfitting/tests/densityfittingamplitudelookup.cpp:66:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/applied_forces/densityfitting/tests/densityfittingoptions.cpp:134:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/applied_forces/electricfield.cpp:226:67: style:inconclusive: Function 'initMdpTransform' argument 1 names different: declaration 'transform' definition 'rules'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/applied_forces/electricfield.cpp:167:56: note: Function 'initMdpTransform' argument 1 names different: declaration 'transform' definition 'rules'. gromacs-2022-rc1/src/gromacs/applied_forces/electricfield.cpp:226:67: note: Function 'initMdpTransform' argument 1 names different: declaration 'transform' definition 'rules'. gromacs-2022-rc1/src/gromacs/applied_forces/qmmm/qmmm.cpp:139:13: style:inconclusive: Technically the member function 'gmx::::QMMMSimulationParameterSetup::periodicBoundaryConditionType' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/applied_forces/qmmm/qmmm.cpp:108:17: warning: Either the condition 'localQMAtomSet_==nullptr' is redundant or there is possible null pointer dereference: localQMAtomSet_. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/applied_forces/qmmm/qmmm.cpp:104:29: note: Assuming that condition 'localQMAtomSet_==nullptr' is not redundant gromacs-2022-rc1/src/gromacs/applied_forces/qmmm/qmmm.cpp:108:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/applied_forces/qmmm/qmmm.cpp:121:17: warning: Either the condition 'localMMAtomSet_==nullptr' is redundant or there is possible null pointer dereference: localMMAtomSet_. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/applied_forces/qmmm/qmmm.cpp:117:29: note: Assuming that condition 'localMMAtomSet_==nullptr' is not redundant gromacs-2022-rc1/src/gromacs/applied_forces/qmmm/qmmm.cpp:121:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/applied_forces/qmmm/qmmm.cpp:146:17: warning: Either the condition 'pbcType_==nullptr' is redundant or there is possible null pointer dereference: pbcType_. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/applied_forces/qmmm/qmmm.cpp:141:22: note: Assuming that condition 'pbcType_==nullptr' is not redundant gromacs-2022-rc1/src/gromacs/applied_forces/qmmm/qmmm.cpp:146:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/applied_forces/qmmm/qmmm.cpp:161:17: warning: Either the condition 'logger_==nullptr' is redundant or there is possible null pointer dereference: logger_. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/applied_forces/qmmm/qmmm.cpp:157:21: note: Assuming that condition 'logger_==nullptr' is not redundant gromacs-2022-rc1/src/gromacs/applied_forces/qmmm/qmmm.cpp:161:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/applied_forces/qmmm/tests/qmmm.cpp:114:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/applied_forces/qmmm/qmmmtopologypreprocessor.h:112:5: style: Class 'QMMMTopologyPreprocessor' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/applied_forces/qmmm/tests/qmmmforceprovider.cpp:92:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/applied_forces/qmmm/tests/qmmminputgenerator.cpp:103:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/applied_forces/qmmm/tests/qmmmtopologypreprocessor.cpp:136:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/applied_forces/qmmm/tests/qmmmoptions.cpp:184:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/applied_forces/tests/electricfield.cpp:130:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/commandline/cmdlinehelpwriter.cpp:470:10: style:inconclusive: Technically the member function 'gmx::Impl::formatBugs' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/commandline/cmdlinehelpwriter.cpp:480:35: note: Technically the member function 'gmx::Impl::formatBugs' can be const. gromacs-2022-rc1/src/gromacs/commandline/cmdlinehelpwriter.cpp:470:10: note: Technically the member function 'gmx::Impl::formatBugs' can be const. gromacs-2022-rc1/src/gromacs/commandline/cmdlinehelpwriter.cpp:515:90: style:inconclusive: Function 'setKnownIssues' argument 1 names different: declaration 'bug' definition 'bugs'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/commandline/cmdlinehelpwriter.h:108:71: note: Function 'setKnownIssues' argument 1 names different: declaration 'bug' definition 'bugs'. gromacs-2022-rc1/src/gromacs/commandline/cmdlinehelpwriter.cpp:515:90: note: Function 'setKnownIssues' argument 1 names different: declaration 'bug' definition 'bugs'. gromacs-2022-rc1/src/gromacs/commandline/cmdlinehelpmodule.cpp:397:21: style: Local variable 'name' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/commandline/cmdlinehelpmodule.cpp:357:23: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/commandline/cmdlinehelpmodule.cpp:397:21: note: Shadow variable gromacs-2022-rc1/src/gromacs/commandline/cmdlinemodulemanager.cpp:389:22: warning: Either the condition 'moduleIter==modules_.end()' is redundant or there is possible dereference of an invalid iterator: moduleIter. [derefInvalidIteratorRedundantCheck] gromacs-2022-rc1/src/gromacs/commandline/cmdlinemodulemanager.cpp:384:28: note: Assuming that condition 'moduleIter==modules_.end()' is not redundant gromacs-2022-rc1/src/gromacs/commandline/cmdlinemodulemanager.cpp:389:22: note: Dereference of an invalid iterator gromacs-2022-rc1/src/gromacs/commandline/tests/cmdlinehelpmodule.cpp:83:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/commandline/tests/cmdlinehelpwriter.cpp:102:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/commandline/tests/cmdlinemodulemanager.cpp:80:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/commandline/tests/cmdlineparser.cpp:95:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/commandline/tests/cmdlinemodulemanagertest.cpp:161:12: error: Reference to local variable returned. [returnReference] gromacs-2022-rc1/src/gromacs/commandline/tests/cmdlinemodulemanagertest.cpp:158:62: note: Raw pointer to smart pointer created here. gromacs-2022-rc1/src/gromacs/commandline/tests/cmdlinemodulemanagertest.cpp:161:12: note: Reference to local variable returned. gromacs-2022-rc1/src/gromacs/commandline/tests/cmdlinemodulemanagertest.cpp:161:12: warning: Access of moved variable '*'. [accessMoved] gromacs-2022-rc1/src/gromacs/commandline/tests/cmdlinemodulemanagertest.cpp:160:44: note: Calling std::move(modulePtr) gromacs-2022-rc1/src/gromacs/commandline/tests/cmdlinemodulemanagertest.cpp:161:12: note: Access of moved variable '*'. gromacs-2022-rc1/src/gromacs/commandline/tests/cmdlineprogramcontext.cpp:117:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/commandline/tests/filenm.cpp:68:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/commandline/viewit.cpp:77:17: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/commandline/viewit.cpp:77:30: style: The scope of the variable 'env' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/commandline/viewit.cpp:78:17: style: The scope of the variable 'cmd' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/commandline/viewit.cpp:79:17: style: The scope of the variable 'ftp' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/commandline/viewit.cpp:79:22: style: The scope of the variable 'n' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/commandline/tests/pargs.cpp:129:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/compat/tests/mp11.cpp:75:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/compat/tests/pointers.cpp:81:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/coordinateio/outputadaptercontainer.h:107:42: style:inconclusive: Technically the member function 'gmx::OutputAdapterContainer::getAdapters' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/coordinateio/outputadapters/setatoms.h:97:5: warning:inconclusive: Member variable 'SetAtoms::moduleRequirements_' is not assigned in the move constructor. Should it be moved? [missingMemberCopy] gromacs-2022-rc1/src/gromacs/coordinateio/outputadapters/setstarttime.cpp:67:40: style:inconclusive: Function 'setInitialTime' argument 1 names different: declaration 'initialTime' definition 'initialTimeFromFrame'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/coordinateio/outputadapters/setstarttime.h:96:30: note: Function 'setInitialTime' argument 1 names different: declaration 'initialTime' definition 'initialTimeFromFrame'. gromacs-2022-rc1/src/gromacs/coordinateio/outputadapters/setstarttime.cpp:67:40: note: Function 'setInitialTime' argument 1 names different: declaration 'initialTime' definition 'initialTimeFromFrame'. gromacs-2022-rc1/src/gromacs/coordinateio/tests/builder.cpp:93:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/coordinateio/tests/outputadaptercontainer.cpp:70:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/coordinateio/tests/outputadapters.cpp:59:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/coordinateio/tests/requirements.cpp:63:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/coordinateio/tests/setatoms.cpp:106:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/coordinateio/tests/setbothtime.cpp:108:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/coordinateio/tests/setstarttime.cpp:91:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/coordinateio/tests/settimestep.cpp:91:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/correlationfunctions/autocorr.cpp:135:16: style: The scope of the variable 'j3' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/correlationfunctions/autocorr.cpp:135:28: style: The scope of the variable 'n' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/correlationfunctions/autocorr.cpp:320:11: style: The scope of the variable 'rij' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/correlationfunctions/autocorr.cpp:556:14: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/correlationfunctions/autocorr.cpp:553:46: style:inconclusive: Function 'low_do_autocorr' argument 16 names different: declaration 'nfitparm' definition 'eFitFn'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/correlationfunctions/autocorr.h:194:46: note: Function 'low_do_autocorr' argument 16 names different: declaration 'nfitparm' definition 'eFitFn'. gromacs-2022-rc1/src/gromacs/correlationfunctions/autocorr.cpp:553:46: note: Function 'low_do_autocorr' argument 16 names different: declaration 'nfitparm' definition 'eFitFn'. gromacs-2022-rc1/src/gromacs/correlationfunctions/autocorr.cpp:218:22: style: Local variable 'xj' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/correlationfunctions/autocorr.cpp:137:10: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/correlationfunctions/autocorr.cpp:218:22: note: Shadow variable gromacs-2022-rc1/src/gromacs/correlationfunctions/autocorr.cpp:218:26: style: Local variable 'xk' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/correlationfunctions/autocorr.cpp:137:14: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/correlationfunctions/autocorr.cpp:218:26: note: Shadow variable gromacs-2022-rc1/src/gromacs/correlationfunctions/autocorr.cpp:608:14: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/correlationfunctions/autocorr.cpp:556:14: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/correlationfunctions/autocorr.cpp:608:14: note: Shadow variable gromacs-2022-rc1/src/gromacs/correlationfunctions/autocorr.cpp:727:46: style: Parameter 'pa' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/gromacs/correlationfunctions/expfit.cpp:147:12: style: The scope of the variable 'erfarg' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/correlationfunctions/expfit.cpp:323:23: style: The scope of the variable 'omega' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/correlationfunctions/expfit.cpp:323:30: style: The scope of the variable 'wv' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/correlationfunctions/expfit.cpp:323:38: style: The scope of the variable 'ec' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/correlationfunctions/expfit.cpp:323:42: style: The scope of the variable 'es' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/correlationfunctions/expfit.cpp:324:12: style: The scope of the variable 'wv_max' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/correlationfunctions/expfit.cpp:356:20: style: The scope of the variable 'v1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/correlationfunctions/expfit.cpp:356:24: style: The scope of the variable 'v2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/correlationfunctions/expfit.cpp:358:12: style: The scope of the variable 'fa1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/correlationfunctions/expfit.cpp:599:13: style: The scope of the variable 'fp' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/correlationfunctions/expfit.cpp:601:23: style: The scope of the variable 'ttt' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/correlationfunctions/expfit.cpp:747:22: style: The scope of the variable 'tail_corr' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/correlationfunctions/expfit.cpp:747:50: style: The scope of the variable 'c_start' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/correlationfunctions/expfit.cpp:747:59: style: The scope of the variable 'ct_estimate' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/correlationfunctions/expfit.cpp:721:26: style: Local variable 'ttt' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/correlationfunctions/expfit.cpp:601:23: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/correlationfunctions/expfit.cpp:721:26: note: Shadow variable gromacs-2022-rc1/src/gromacs/correlationfunctions/integrate.cpp:95:26: style: The scope of the variable 'w' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/correlationfunctions/tests/autocorr.cpp:178:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/correlationfunctions/tests/correlationdataset.cpp:77:48: style:inconclusive: Function 'getValue' argument 2 names different: declaration 't' definition 'time'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/correlationfunctions/tests/correlationdataset.h:74:32: note: Function 'getValue' argument 2 names different: declaration 't' definition 'time'. gromacs-2022-rc1/src/gromacs/correlationfunctions/tests/correlationdataset.cpp:77:48: note: Function 'getValue' argument 2 names different: declaration 't' definition 'time'. gromacs-2022-rc1/src/gromacs/correlationfunctions/tests/manyautocorrelation.cpp:66:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/domdec/atomdistribution.cpp:74:9: style: Local variable 'numRanks' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/domdec/atomdistribution.cpp:52:12: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/domdec/atomdistribution.cpp:74:9: note: Shadow variable gromacs-2022-rc1/src/gromacs/domdec/box.cpp:238:58: performance:inconclusive: Function parameter 'x' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/domdec/box.cpp:311:50: performance:inconclusive: Function parameter 'x' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/domdec/collect.cpp:267:56: style:inconclusive: Function 'dd_collect_state' argument 2 names different: declaration 'localState' definition 'state_local'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/domdec/collect.h:65:56: note: Function 'dd_collect_state' argument 2 names different: declaration 'localState' definition 'state_local'. gromacs-2022-rc1/src/gromacs/domdec/collect.cpp:267:56: note: Function 'dd_collect_state' argument 2 names different: declaration 'localState' definition 'state_local'. gromacs-2022-rc1/src/gromacs/domdec/collect.cpp:267:78: style:inconclusive: Function 'dd_collect_state' argument 3 names different: declaration 'globalState' definition 'state'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/domdec/collect.h:65:77: note: Function 'dd_collect_state' argument 3 names different: declaration 'globalState' definition 'state'. gromacs-2022-rc1/src/gromacs/domdec/collect.cpp:267:78: note: Function 'dd_collect_state' argument 3 names different: declaration 'globalState' definition 'state'. gromacs-2022-rc1/src/gromacs/domdec/collect.cpp:175:18: style: Local variable 'rank' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/domdec/collect.cpp:168:13: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/domdec/collect.cpp:175:18: note: Shadow variable gromacs-2022-rc1/src/gromacs/domdec/collect.cpp:201:21: style: Local variable 'localAtom' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/domdec/collect.cpp:169:13: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/domdec/collect.cpp:201:21: note: Shadow variable gromacs-2022-rc1/src/gromacs/domdec/collect.cpp:62:52: performance:inconclusive: Function parameter 'localCGNumbers' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/domdec/collect.cpp:250:52: performance:inconclusive: Function parameter 'localCGNumbers' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/domdec/collect.cpp:251:52: performance:inconclusive: Function parameter 'localVector' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/domdec/collect.cpp:252:52: performance:inconclusive: Function parameter 'globalVector' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/domdec/cellsizes.cpp:202:85: style:inconclusive: Function 'set_dd_cell_sizes_slb' argument 4 names different: declaration 'numPulses' definition 'npulse'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/domdec/cellsizes.h:78:85: note: Function 'set_dd_cell_sizes_slb' argument 4 names different: declaration 'numPulses' definition 'npulse'. gromacs-2022-rc1/src/gromacs/domdec/cellsizes.cpp:202:85: note: Function 'set_dd_cell_sizes_slb' argument 4 names different: declaration 'numPulses' definition 'npulse'. gromacs-2022-rc1/src/gromacs/domdec/cellsizes.cpp:441:18: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/domdec/cellsizes.cpp:409:15: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/domdec/cellsizes.cpp:441:18: note: Shadow variable gromacs-2022-rc1/src/gromacs/domdec/cellsizes.cpp:481:22: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/domdec/cellsizes.cpp:409:15: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/domdec/cellsizes.cpp:481:22: note: Shadow variable gromacs-2022-rc1/src/gromacs/domdec/cellsizes.cpp:489:22: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/domdec/cellsizes.cpp:409:15: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/domdec/cellsizes.cpp:489:22: note: Shadow variable gromacs-2022-rc1/src/gromacs/domdec/distribute.cpp:452:16: style: Same expression used in consecutive assignments of 'nat_min' and 'nat_max'. [duplicateAssignExpression] gromacs-2022-rc1/src/gromacs/domdec/distribute.cpp:453:16: note: Same expression used in consecutive assignments of 'nat_min' and 'nat_max'. gromacs-2022-rc1/src/gromacs/domdec/distribute.cpp:452:16: note: Same expression used in consecutive assignments of 'nat_min' and 'nat_max'. gromacs-2022-rc1/src/gromacs/domdec/distribute.cpp:153:58: performance:inconclusive: Function parameter 'globalVec' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/domdec/distribute.cpp:154:58: performance:inconclusive: Function parameter 'localVec' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/domdec/dlbtiming.h:88:5: style: Class 'DDBalanceRegionHandler' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/domdec/dlbtiming.cpp:139:55: style:inconclusive: Function 'closeRegionGpuImpl' argument 1 names different: declaration 'waitCyclesGpuInCpuRegion' definition 'waitGpuCyclesInCpuRegion'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/domdec/dlbtiming.h:198:35: note: Function 'closeRegionGpuImpl' argument 1 names different: declaration 'waitCyclesGpuInCpuRegion' definition 'waitGpuCyclesInCpuRegion'. gromacs-2022-rc1/src/gromacs/domdec/dlbtiming.cpp:139:55: note: Function 'closeRegionGpuImpl' argument 1 names different: declaration 'waitCyclesGpuInCpuRegion' definition 'waitGpuCyclesInCpuRegion'. gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:448:25: style: Condition 'shiftForcesNeedPbc' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:413:17: note: Assuming that condition '!shiftForcesNeedPbc' is not redundant gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:442:33: note: Assuming container is not empty gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:448:25: note: Condition 'shiftForcesNeedPbc' is always true gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:1702:13: warning:inconclusive: Possible null pointer dereference: slb_frac [nullPointer] gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:1684:22: note: Assignment 'slb_frac=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:1702:13: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:1704:20: warning:inconclusive: Possible null pointer dereference: slb_frac [nullPointer] gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:1684:22: note: Assignment 'slb_frac=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:1704:20: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:1710:13: warning:inconclusive: Possible null pointer dereference: slb_frac [nullPointer] gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:1684:22: note: Assignment 'slb_frac=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:1710:13: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:1711:62: warning:inconclusive: Possible null pointer dereference: slb_frac [nullPointer] gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:1684:22: note: Assignment 'slb_frac=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:1711:62: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:1797:17: style: The scope of the variable 'dlbNotSupportedErr' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:2646:9: style: The scope of the variable 'npulse_d_max' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:2647:9: style: The scope of the variable 'npulse_d' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:299:30: style: Local variable 'd' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:272:14: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:299:30: note: Shadow variable gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:417:30: style: Local variable 'd' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:366:14: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:417:30: note: Shadow variable gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:428:30: style: Local variable 'd' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:366:14: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:428:30: note: Shadow variable gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:433:30: style: Local variable 'd' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:366:14: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:433:30: note: Shadow variable gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:451:34: style: Local variable 'd' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:366:14: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:451:34: note: Shadow variable gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:835:83: performance:inconclusive: Function parameter 'pmeRanks' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:1629:62: performance:inconclusive: Function parameter 'pmeRanks' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:1952:65: performance:inconclusive: Function parameter 'updateGroupingsPerMoleculeType' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:2027:69: performance:inconclusive: Function parameter 'updateGroupingPerMoleculeType' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:1966:29: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:2010:13: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:1445:13: error: Uninitialized variable: bDiv [uninitvar] gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:1441:27: note: Assuming condition is false gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:1445:13: note: Uninitialized variable: bDiv gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:1947:12: error: Uninitialized struct member: comm.dlbState [uninitStructMember] gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:2646:22: style: Variable 'npulse_d_max' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/domdec/domdec.cpp:2647:22: style: Variable 'npulse_d' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/domdec/domdec_setup.cpp:108:27: style: Condition 'fac->empty()' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/domdec/domdec_setup.cpp:969:66: performance:inconclusive: Function parameter 'xGlobal' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/domdec/domdec_specatomcomm.cpp:101:35: style: Local variable 'spas' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/domdec/domdec_specatomcomm.cpp:79:31: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/domdec/domdec_specatomcomm.cpp:101:35: note: Shadow variable gromacs-2022-rc1/src/gromacs/domdec/domdec_specatomcomm.cpp:264:23: style: Local variable 'vbuf' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/domdec/domdec_specatomcomm.cpp:200:19: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/domdec/domdec_specatomcomm.cpp:264:23: note: Shadow variable gromacs-2022-rc1/src/gromacs/domdec/domdec_specatomcomm.cpp:269:23: style: Local variable 'vbuf' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/domdec/domdec_specatomcomm.cpp:200:19: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/domdec/domdec_specatomcomm.cpp:269:23: note: Shadow variable gromacs-2022-rc1/src/gromacs/domdec/domdec_specatomcomm.cpp:327:23: style: Local variable 'vbuf' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/domdec/domdec_specatomcomm.cpp:297:19: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/domdec/domdec_specatomcomm.cpp:327:23: note: Shadow variable gromacs-2022-rc1/src/gromacs/domdec/domdec_specatomcomm.cpp:332:23: style: Local variable 'vbuf' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/domdec/domdec_specatomcomm.cpp:297:19: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/domdec/domdec_specatomcomm.cpp:332:23: note: Shadow variable gromacs-2022-rc1/src/gromacs/domdec/dump.cpp:62:12: style: The scope of the variable 'fname' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/domdec/dump.cpp:62:27: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/domdec/dump.cpp:63:12: style: The scope of the variable 'out' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/domdec/dump.cpp:64:12: style: The scope of the variable 'a' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/domdec/dump.cpp:64:15: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/domdec/dump.cpp:64:18: style: The scope of the variable 'd' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/domdec/dump.cpp:64:21: style: The scope of the variable 'z' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/domdec/dump.cpp:64:24: style: The scope of the variable 'x' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/domdec/dump.cpp:192:14: style: The scope of the variable 'c' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/domdec/localatomsetdata.h:79:51: performance:inconclusive: Function parameter 'globalAtomIndex' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/domdec/localatomsetdata.cpp:61:58: style:inconclusive: Function 'LocalAtomSetData' argument 1 names different: declaration 'globalAtomIndex' definition 'globalIndex'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/domdec/localatomsetdata.h:96:53: note: Function 'LocalAtomSetData' argument 1 names different: declaration 'globalAtomIndex' definition 'globalIndex'. gromacs-2022-rc1/src/gromacs/domdec/localatomsetdata.cpp:61:58: note: Function 'LocalAtomSetData' argument 1 names different: declaration 'globalAtomIndex' definition 'globalIndex'. gromacs-2022-rc1/src/gromacs/domdec/localatomsetmanager.h:100:10: style:inconclusive: Technically the member function 'gmx::LocalAtomSetManager::setIndicesInDomainDecomposition' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/domdec/localatomsetmanager.cpp:89:27: note: Technically the member function 'gmx::LocalAtomSetManager::setIndicesInDomainDecomposition' can be const. gromacs-2022-rc1/src/gromacs/domdec/localatomsetmanager.h:100:10: note: Technically the member function 'gmx::LocalAtomSetManager::setIndicesInDomainDecomposition' can be const. gromacs-2022-rc1/src/gromacs/domdec/localtopologychecker.cpp:204:30: style: Local variable 'a' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/domdec/localtopologychecker.cpp:193:25: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/domdec/localtopologychecker.cpp:204:30: note: Shadow variable gromacs-2022-rc1/src/gromacs/domdec/localtopology.cpp:420:13: style: The scope of the variable 'tiatoms' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/domdec/localtopology.cpp:151:16: error: Out of bounds access in 'tiatoms[1]', if 'tiatoms' size is 1 and '1' is 1 [containerOutOfBounds] gromacs-2022-rc1/src/gromacs/domdec/localtopology.cpp:156:16: error: Out of bounds access in 'tiatoms[1]', if 'tiatoms' size is 1 and '1' is 1 [containerOutOfBounds] gromacs-2022-rc1/src/gromacs/domdec/localtopology.cpp:927:35: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/domdec/makebondedlinks.cpp:124:10: warning:inconclusive: Possible null pointer dereference: link [nullPointer] gromacs-2022-rc1/src/gromacs/domdec/makebondedlinks.cpp:100:22: note: Assignment 'link=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/domdec/makebondedlinks.cpp:124:10: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/domdec/makebondedlinks.cpp:125:5: warning:inconclusive: Possible null pointer dereference: link [nullPointer] gromacs-2022-rc1/src/gromacs/domdec/makebondedlinks.cpp:100:22: note: Assignment 'link=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/domdec/makebondedlinks.cpp:125:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/domdec/makebondedlinks.cpp:126:5: warning:inconclusive: Possible null pointer dereference: link [nullPointer] gromacs-2022-rc1/src/gromacs/domdec/makebondedlinks.cpp:100:22: note: Assignment 'link=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/domdec/makebondedlinks.cpp:126:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/domdec/makebondedlinks.cpp:128:5: warning:inconclusive: Possible null pointer dereference: link [nullPointer] gromacs-2022-rc1/src/gromacs/domdec/makebondedlinks.cpp:100:22: note: Assignment 'link=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/domdec/makebondedlinks.cpp:128:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/domdec/makebondedlinks.cpp:176:25: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/domdec/makebondedlinks.cpp:156:21: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/domdec/makebondedlinks.cpp:176:25: note: Shadow variable gromacs-2022-rc1/src/gromacs/domdec/redistribute.cpp:439:5: warning: Member variable 'PbcAndFlag::moveFlag' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/domdec/domdec_internal.h:363:22: style: Unused private function: 'DDBuffer < int >::acquire' [unusedPrivateFunction] gromacs-2022-rc1/src/gromacs/domdec/domdec_internal.h:372:10: style: Unused private function: 'DDBuffer < int >::release' [unusedPrivateFunction] gromacs-2022-rc1/src/gromacs/domdec/domdec_internal.h:363:22: style: Unused private function: 'DDBuffer < gmx :: RVec >::acquire' [unusedPrivateFunction] gromacs-2022-rc1/src/gromacs/domdec/domdec_internal.h:372:10: style: Unused private function: 'DDBuffer < gmx :: RVec >::release' [unusedPrivateFunction] gromacs-2022-rc1/src/gromacs/domdec/redistribute.cpp:948:24: style: Local variable 'nvr' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/domdec/redistribute.cpp:779:19: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/domdec/redistribute.cpp:948:24: note: Shadow variable gromacs-2022-rc1/src/gromacs/domdec/tests/haloexchange_mpi.cpp:519:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/domdec/tests/hashedmap.cpp:71:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/domdec/tests/localatomsetmanager.cpp:77:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/domdec/partition.cpp:719:33: style: The scope of the variable 'dim' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/domdec/partition.cpp:1827:37: style: The scope of the variable 'dim' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/domdec/partition.cpp:1829:28: style: The scope of the variable 'c' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/domdec/partition.cpp:1836:37: style: The scope of the variable 'v_d' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/domdec/partition.cpp:2768:17: style: The scope of the variable 'sbuf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/domdec/partition.cpp:346:21: style: Local variable 'pos' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/domdec/partition.cpp:182:13: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/domdec/partition.cpp:346:21: note: Shadow variable gromacs-2022-rc1/src/gromacs/domdec/partition.cpp:871:21: style: Local variable 'pos' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/domdec/partition.cpp:799:17: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/domdec/partition.cpp:871:21: note: Shadow variable gromacs-2022-rc1/src/gromacs/domdec/partition.cpp:2429:21: style: Local variable 'd' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/domdec/partition.cpp:2248:28: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/domdec/partition.cpp:2429:21: note: Shadow variable gromacs-2022-rc1/src/gromacs/domdec/partition.cpp:1346:78: performance:inconclusive: Function parameter 'atomInfoForEachMoleculeBlock' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/domdec/partition.cpp:2534:59: performance:inconclusive: Function parameter 'vectorToSort' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/domdec/partition.cpp:367:24: style: Variable 'pos' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/energyanalysis/tests/legacyenergy.cpp:83:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/ewald/calculate_spline_moduli.cpp:88:73: style:inconclusive: Function 'make_bspline_moduli' argument 5 names different: declaration 'order' definition 'pme_order'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/ewald/calculate_spline_moduli.h:43:73: note: Function 'make_bspline_moduli' argument 5 names different: declaration 'order' definition 'pme_order'. gromacs-2022-rc1/src/gromacs/ewald/calculate_spline_moduli.cpp:88:73: note: Function 'make_bspline_moduli' argument 5 names different: declaration 'order' definition 'pme_order'. gromacs-2022-rc1/src/gromacs/essentialdynamics/edsam.cpp:277:12: style: struct member 't_do_edsam::xcoll' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/essentialdynamics/edsam.cpp:281:14: style: struct member 't_do_edsam::xc_ref' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/essentialdynamics/edsam.cpp:282:14: style: struct member 't_do_edsam::shifts_xcoll' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/essentialdynamics/edsam.cpp:283:14: style: struct member 't_do_edsam::extra_shifts_xcoll' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/essentialdynamics/edsam.cpp:284:14: style: struct member 't_do_edsam::shifts_xc_ref' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/essentialdynamics/edsam.cpp:285:14: style: struct member 't_do_edsam::extra_shifts_xc_ref' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/essentialdynamics/edsam.cpp:295:26: style: struct member 't_ed_buffer::fit_to_ref' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/essentialdynamics/edsam.cpp:296:26: style: struct member 't_ed_buffer::do_edfit' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/essentialdynamics/edsam.cpp:297:26: style: struct member 't_ed_buffer::do_edsam' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/essentialdynamics/edsam.cpp:298:26: style: struct member 't_ed_buffer::do_radcon' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/ewald/pme.h:526:42: error: There is an unknown macro here somewhere. Configuration is required. If pme_gpu_get_f_ready_synchronizer is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/ewald/pme_gather_sycl.cpp:200:19: style:inconclusive: Boolean expression 'iy>=ny' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] gromacs-2022-rc1/src/gromacs/ewald/pme_gather_sycl.cpp:210:23: style:inconclusive: Boolean expression 'ix>=nx' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] gromacs-2022-rc1/src/gromacs/ewald/pme_gather_sycl.cpp:562:24: style: Local variable 'chargeCheck' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/ewald/pme_gather_sycl.cpp:467:19: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/ewald/pme_gather_sycl.cpp:562:24: note: Shadow variable gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_internal.h:430:42: error: There is an unknown macro here somewhere. Configuration is required. If pme_gpu_get_forces_ready_synchronizer is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::splineKernelSingle' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::splineKernelThPerAtom4Single' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::spreadKernelSingle' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::spreadKernelThPerAtom4Single' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::splineAndSpreadKernelSingle' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::splineAndSpreadKernelThPerAtom4Single' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::splineAndSpreadKernelWriteSplinesSingle' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::splineAndSpreadKernelWriteSplinesThPerAtom4Single' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::splineKernelDual' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::splineKernelThPerAtom4Dual' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::spreadKernelDual' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::spreadKernelThPerAtom4Dual' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::splineAndSpreadKernelDual' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::splineAndSpreadKernelThPerAtom4Dual' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::splineAndSpreadKernelWriteSplinesDual' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::splineAndSpreadKernelWriteSplinesThPerAtom4Dual' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::gatherKernelSingle' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::gatherKernelThPerAtom4Single' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::gatherKernelReadSplinesSingle' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::gatherKernelReadSplinesThPerAtom4Single' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::gatherKernelDual' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::gatherKernelThPerAtom4Dual' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::gatherKernelReadSplinesDual' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::gatherKernelReadSplinesThPerAtom4Dual' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::solveYZXKernelA' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::solveXYZKernelA' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::solveYZXEnergyKernelA' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::solveXYZEnergyKernelA' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::solveYZXKernelB' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::solveXYZKernelB' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::solveYZXEnergyKernelB' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_gpu_program_impl.cpp:48:20: warning: Member variable 'PmeGpuProgramImpl::solveXYZEnergyKernelB' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/ewald/pme_grid.cpp:278:10: style: The scope of the variable 'ix' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_grid.cpp:278:14: style: The scope of the variable 'iy' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_grid.cpp:278:18: style: The scope of the variable 'iz' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_grid.cpp:279:10: style: The scope of the variable 'pmeidx' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_grid.cpp:279:18: style: The scope of the variable 'fftidx' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_grid.cpp:374:27: style: The scope of the variable 'ix' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_grid.cpp:374:31: style: The scope of the variable 'iy' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_grid.cpp:375:10: style: The scope of the variable 'pmeidx' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_grid.cpp:375:18: style: The scope of the variable 'fftidx' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_grid.cpp:428:31: style: The scope of the variable 'ny_x' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_grid.cpp:485:31: style: The scope of the variable 'ny_x' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_grid.cpp:704:13: style: The scope of the variable 'x' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_grid.cpp:704:16: style: The scope of the variable 'y' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_grid.cpp:704:19: style: The scope of the variable 'z' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_grid.cpp:912:12: style: The scope of the variable 't' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_load_balancing.cpp:926:52: performance:inconclusive: Function parameter 'x' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/ewald/pme_pp.cpp:490:9: portability: Using memset() on struct which contains a floating point number. [memsetClassFloat] gromacs-2022-rc1/src/gromacs/ewald/pme_pp.cpp:575:9: style:inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch] gromacs-2022-rc1/src/gromacs/ewald/pme_pp.cpp:582:9: note: Found duplicate branches for 'if' and 'else'. gromacs-2022-rc1/src/gromacs/ewald/pme_pp.cpp:575:9: note: Found duplicate branches for 'if' and 'else'. gromacs-2022-rc1/src/gromacs/ewald/pme_pp.cpp:120:27: style: The scope of the variable 'cnb' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_pp.cpp:380:62: style:inconclusive: Function 'gmx_pme_send_coordinates' argument 10 names different: declaration 'reinitGpuPmePpComms' definition 'receiveCoordinateAddressFromPme'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/ewald/pme_pp.h:89:62: note: Function 'gmx_pme_send_coordinates' argument 10 names different: declaration 'reinitGpuPmePpComms' definition 'receiveCoordinateAddressFromPme'. gromacs-2022-rc1/src/gromacs/ewald/pme_pp.cpp:380:62: note: Function 'gmx_pme_send_coordinates' argument 10 names different: declaration 'reinitGpuPmePpComms' definition 'receiveCoordinateAddressFromPme'. gromacs-2022-rc1/src/gromacs/ewald/pme_pp.cpp:322:57: performance:inconclusive: Function parameter 'chargeA' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/ewald/pme_pp.cpp:323:57: performance:inconclusive: Function parameter 'chargeB' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/ewald/pme_pp.cpp:324:57: performance:inconclusive: Function parameter 'sqrt_c6A' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/ewald/pme_pp.cpp:325:57: performance:inconclusive: Function parameter 'sqrt_c6B' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/ewald/pme_pp.cpp:326:57: performance:inconclusive: Function parameter 'sigmaA' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/ewald/pme_pp.cpp:327:57: performance:inconclusive: Function parameter 'sigmaB' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/ewald/pme_pp.cpp:374:62: performance:inconclusive: Function parameter 'x' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/ewald/pme_redistribute.cpp:292:45: style: The scope of the variable 'node' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_redistribute.cpp:344:21: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/ewald/pme_redistribute.cpp:292:22: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/ewald/pme_redistribute.cpp:344:21: note: Shadow variable gromacs-2022-rc1/src/gromacs/ewald/pme_redistribute.cpp:435:25: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/ewald/pme_redistribute.cpp:405:42: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/ewald/pme_redistribute.cpp:435:25: note: Shadow variable gromacs-2022-rc1/src/gromacs/ewald/pme_redistribute.cpp:454:25: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/ewald/pme_redistribute.cpp:405:42: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/ewald/pme_redistribute.cpp:454:25: note: Shadow variable gromacs-2022-rc1/src/gromacs/ewald/pme_solve.cpp:337:34: style: The scope of the variable 'ky' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_solve.cpp:337:38: style: The scope of the variable 'kz' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_solve.cpp:338:59: style: The scope of the variable 'iy' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_solve.cpp:338:63: style: The scope of the variable 'iz' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_solve.cpp:338:76: style: The scope of the variable 'kxend' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_solve.cpp:604:34: style: The scope of the variable 'ky' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_solve.cpp:604:38: style: The scope of the variable 'kz' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_solve.cpp:605:42: style: The scope of the variable 'iy' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_solve.cpp:605:63: style: The scope of the variable 'iz' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_solve.cpp:605:67: style: The scope of the variable 'kxstart' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_solve.cpp:605:76: style: The scope of the variable 'kxend' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_solve.cpp:74:11: style: struct member 'pme_solve_work_t::tmp1_alloc' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/ewald/pme_spread_sycl.cpp:125:23: style:inconclusive: Boolean expression 'iy>=ny' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] gromacs-2022-rc1/src/gromacs/ewald/pme_spread_sycl.cpp:140:27: style:inconclusive: Boolean expression 'ix>=nx' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] gromacs-2022-rc1/src/gromacs/ewald/pme_spread_sycl.cpp:341:25: style: Local variable 'atomCharge' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/ewald/pme_spread_sycl.cpp:280:21: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/ewald/pme_spread_sycl.cpp:341:25: note: Shadow variable gromacs-2022-rc1/src/gromacs/ewald/pme_spread.cpp:68:17: style: The scope of the variable 'idxptr' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_spread.cpp:68:25: style: The scope of the variable 'tix' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/tests/pme.cpp:84:41: error: There is an unknown macro here somewhere. Configuration is required. If ; is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/ewald/pme_spread.cpp:68:30: style: The scope of the variable 'tiy' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_spread.cpp:68:35: style: The scope of the variable 'tiz' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_spread.cpp:69:17: style: The scope of the variable 'xptr' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_spread.cpp:70:17: style: The scope of the variable 'fptr' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_spread.cpp:186:25: style: The scope of the variable 'end' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_spread.cpp:278:14: style: The scope of the variable 'ii' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_spread.cpp:333:23: style: The scope of the variable 'n' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_spread.cpp:472:34: style: The scope of the variable 'fx' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_spread.cpp:472:46: style: The scope of the variable 'tx1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_spread.cpp:472:61: style: The scope of the variable 'ox' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_spread.cpp:477:32: style: The scope of the variable 'pmegrid_g' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_spread.cpp:721:10: style: The scope of the variable 'send_index0' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_spread.cpp:726:9: style: The scope of the variable 'recv_size_y' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_spread.cpp:727:9: style: The scope of the variable 'size_yx' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/ewald/pme_spread.cpp:271:38: style: Parameter 'fractx' can be declared as const array [constParameter] gromacs-2022-rc1/src/gromacs/ewald/pme_spread.cpp:767:27: style: Variable 'sendptr' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/ewald/tests/pmebsplinetest.cpp:129:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/ewald/tests/pmetestcommon.cpp:98:72: style:inconclusive: Function 'getSkipMessagesIfNecessary' argument 3 names different: declaration 'mode' definition 'codePath'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/ewald/tests/pmetestcommon.h:134:72: note: Function 'getSkipMessagesIfNecessary' argument 3 names different: declaration 'mode' definition 'codePath'. gromacs-2022-rc1/src/gromacs/ewald/tests/pmetestcommon.cpp:98:72: note: Function 'getSkipMessagesIfNecessary' argument 3 names different: declaration 'mode' definition 'codePath'. gromacs-2022-rc1/src/gromacs/ewald/tests/pmetestcommon.cpp:1043:39: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/fft/fft.cpp:117:23: style: The scope of the variable 'ret' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fft/fft.cpp:134:23: style: The scope of the variable 'ret' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fft/fft.cpp:167:17: style: The scope of the variable 'done2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fft/fft.cpp:168:10: style: The scope of the variable 'i1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fft/fft.cpp:168:14: style: The scope of the variable 'i1c' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fft/fft.cpp:168:28: style: The scope of the variable 'kmi' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fft/fft.cpp:68:37: style:inconclusive: Function 'gmx_fft_init_many_1d' argument 1 names different: declaration 'fft' definition 'pfft'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fft/fft.h:146:37: note: Function 'gmx_fft_init_many_1d' argument 1 names different: declaration 'fft' definition 'pfft'. gromacs-2022-rc1/src/gromacs/fft/fft.cpp:68:37: note: Function 'gmx_fft_init_many_1d' argument 1 names different: declaration 'fft' definition 'pfft'. gromacs-2022-rc1/src/gromacs/fft/fft.cpp:91:42: style:inconclusive: Function 'gmx_fft_init_many_1d_real' argument 1 names different: declaration 'fft' definition 'pfft'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fft/fft.h:177:42: note: Function 'gmx_fft_init_many_1d_real' argument 1 names different: declaration 'fft' definition 'pfft'. gromacs-2022-rc1/src/gromacs/fft/fft.cpp:91:42: note: Function 'gmx_fft_init_many_1d_real' argument 1 names different: declaration 'fft' definition 'pfft'. gromacs-2022-rc1/src/gromacs/fft/fft.cpp:114:31: style:inconclusive: Function 'gmx_fft_many_1d' argument 1 names different: declaration 'setup' definition 'fft'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fft/fft.h:238:31: note: Function 'gmx_fft_many_1d' argument 1 names different: declaration 'setup' definition 'fft'. gromacs-2022-rc1/src/gromacs/fft/fft.cpp:114:31: note: Function 'gmx_fft_many_1d' argument 1 names different: declaration 'setup' definition 'fft'. gromacs-2022-rc1/src/gromacs/fft/fft.cpp:131:36: style:inconclusive: Function 'gmx_fft_many_1d_real' argument 1 names different: declaration 'setup' definition 'fft'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fft/fft.h:287:36: note: Function 'gmx_fft_many_1d_real' argument 1 names different: declaration 'setup' definition 'fft'. gromacs-2022-rc1/src/gromacs/fft/fft.cpp:131:36: note: Function 'gmx_fft_many_1d_real' argument 1 names different: declaration 'setup' definition 'fft'. gromacs-2022-rc1/src/gromacs/fft/fft.cpp:149:37: style:inconclusive: Function 'gmx_many_fft_destroy' argument 1 names different: declaration 'setup' definition 'fft'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fft/fft.h:338:37: note: Function 'gmx_many_fft_destroy' argument 1 names different: declaration 'setup' definition 'fft'. gromacs-2022-rc1/src/gromacs/fft/fft.cpp:149:37: note: Function 'gmx_many_fft_destroy' argument 1 names different: declaration 'setup' definition 'fft'. gromacs-2022-rc1/src/gromacs/fft/fft_fftpack.cpp:192:11: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fft/fft_fftw3.cpp:139:9: error: There is an unknown macro here somewhere. Configuration is required. If GMX_CATCH_ALL_AND_EXIT_WITH_FATAL_ERROR is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:1343:13: style: The if condition is the same as the previous if condition [duplicateCondition] gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:1241:13: note: First condition gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:1343:13: note: Second condition gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:330:22: style: Condition 'P[1]>0' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:210:20: note: Assignment 'P[1]=1', assigned value is 1 gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:248:28: note: Assuming condition is false gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:330:22: note: Condition 'P[1]>0' is always true gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:1195:13: style: Condition 'bParallelDim' is always false [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:1184:28: note: Assignment 'bParallelDim=0', assigned value is 0 gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:1195:13: note: Condition 'bParallelDim' is always false gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:788:22: style: The scope of the variable 'in_z' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:788:28: style: The scope of the variable 'out_z' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:853:22: style: The scope of the variable 'out_x' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:853:29: style: The scope of the variable 'in_x' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:917:22: style: The scope of the variable 'out_z' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:917:29: style: The scope of the variable 'in_z' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:1139:36: style: The scope of the variable 'bParallelDim' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:161:45: style:inconclusive: Function 'fft5d_plan_3d' argument 1 names different: declaration 'N' definition 'NG'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fft/fft5d.h:131:38: note: Function 'fft5d_plan_3d' argument 1 names different: declaration 'N' definition 'NG'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:161:45: note: Function 'fft5d_plan_3d' argument 1 names different: declaration 'N' definition 'NG'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:162:45: style:inconclusive: Function 'fft5d_plan_3d' argument 2 names different: declaration 'M' definition 'MG'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fft/fft5d.h:132:38: note: Function 'fft5d_plan_3d' argument 2 names different: declaration 'M' definition 'MG'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:162:45: note: Function 'fft5d_plan_3d' argument 2 names different: declaration 'M' definition 'MG'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:163:45: style:inconclusive: Function 'fft5d_plan_3d' argument 3 names different: declaration 'K' definition 'KG'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fft/fft5d.h:133:38: note: Function 'fft5d_plan_3d' argument 3 names different: declaration 'K' definition 'KG'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:163:45: note: Function 'fft5d_plan_3d' argument 3 names different: declaration 'K' definition 'KG'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:166:45: style:inconclusive: Function 'fft5d_plan_3d' argument 6 names different: declaration 'lin' definition 'rlin'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fft/fft5d.h:136:38: note: Function 'fft5d_plan_3d' argument 6 names different: declaration 'lin' definition 'rlin'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:166:45: note: Function 'fft5d_plan_3d' argument 6 names different: declaration 'lin' definition 'rlin'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:167:45: style:inconclusive: Function 'fft5d_plan_3d' argument 7 names different: declaration 'lin2' definition 'rlout'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fft/fft5d.h:137:38: note: Function 'fft5d_plan_3d' argument 7 names different: declaration 'lin2' definition 'rlout'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:167:45: note: Function 'fft5d_plan_3d' argument 7 names different: declaration 'lin2' definition 'rlout'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:168:45: style:inconclusive: Function 'fft5d_plan_3d' argument 8 names different: declaration 'lout2' definition 'rlout2'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fft/fft5d.h:138:38: note: Function 'fft5d_plan_3d' argument 8 names different: declaration 'lout2' definition 'rlout2'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:168:45: note: Function 'fft5d_plan_3d' argument 8 names different: declaration 'lout2' definition 'rlout2'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:169:45: style:inconclusive: Function 'fft5d_plan_3d' argument 9 names different: declaration 'lout3' definition 'rlout3'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fft/fft5d.h:139:38: note: Function 'fft5d_plan_3d' argument 9 names different: declaration 'lout3' definition 'rlout3'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:169:45: note: Function 'fft5d_plan_3d' argument 9 names different: declaration 'lout3' definition 'rlout3'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:1552:43: style:inconclusive: Function 'fft5d_plan_3d_cart' argument 1 names different: declaration 'N' definition 'NG'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fft/fft5d.h:144:43: note: Function 'fft5d_plan_3d_cart' argument 1 names different: declaration 'N' definition 'NG'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:1552:43: note: Function 'fft5d_plan_3d_cart' argument 1 names different: declaration 'N' definition 'NG'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:1553:43: style:inconclusive: Function 'fft5d_plan_3d_cart' argument 2 names different: declaration 'M' definition 'MG'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fft/fft5d.h:145:43: note: Function 'fft5d_plan_3d_cart' argument 2 names different: declaration 'M' definition 'MG'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:1553:43: note: Function 'fft5d_plan_3d_cart' argument 2 names different: declaration 'M' definition 'MG'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:1554:43: style:inconclusive: Function 'fft5d_plan_3d_cart' argument 3 names different: declaration 'K' definition 'KG'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fft/fft5d.h:146:43: note: Function 'fft5d_plan_3d_cart' argument 3 names different: declaration 'K' definition 'KG'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:1554:43: note: Function 'fft5d_plan_3d_cart' argument 3 names different: declaration 'K' definition 'KG'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:1558:43: style:inconclusive: Function 'fft5d_plan_3d_cart' argument 7 names different: declaration 'lin' definition 'rlin'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fft/fft5d.h:150:43: note: Function 'fft5d_plan_3d_cart' argument 7 names different: declaration 'lin' definition 'rlin'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:1558:43: note: Function 'fft5d_plan_3d_cart' argument 7 names different: declaration 'lin' definition 'rlin'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:1559:43: style:inconclusive: Function 'fft5d_plan_3d_cart' argument 8 names different: declaration 'lin2' definition 'rlout'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fft/fft5d.h:151:43: note: Function 'fft5d_plan_3d_cart' argument 8 names different: declaration 'lin2' definition 'rlout'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:1559:43: note: Function 'fft5d_plan_3d_cart' argument 8 names different: declaration 'lin2' definition 'rlout'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:1560:43: style:inconclusive: Function 'fft5d_plan_3d_cart' argument 9 names different: declaration 'lout2' definition 'rlout2'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fft/fft5d.h:152:43: note: Function 'fft5d_plan_3d_cart' argument 9 names different: declaration 'lout2' definition 'rlout2'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:1560:43: note: Function 'fft5d_plan_3d_cart' argument 9 names different: declaration 'lout2' definition 'rlout2'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:1561:43: style:inconclusive: Function 'fft5d_plan_3d_cart' argument 10 names different: declaration 'lout3' definition 'rlout3'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fft/fft5d.h:153:43: note: Function 'fft5d_plan_3d_cart' argument 10 names different: declaration 'lout3' definition 'rlout3'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:1561:43: note: Function 'fft5d_plan_3d_cart' argument 10 names different: declaration 'lout3' definition 'rlout3'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:1608:104: style:inconclusive: Function 'fft5d_compare_data' argument 5 names different: declaration 'normarlize' definition 'normalize'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fft/fft5d.h:155:110: note: Function 'fft5d_compare_data' argument 5 names different: declaration 'normarlize' definition 'normalize'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:1608:104: note: Function 'fft5d_compare_data' argument 5 names different: declaration 'normarlize' definition 'normalize'. gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:164:45: style: Parameter 'comm' can be declared as const array [constParameter] gromacs-2022-rc1/src/gromacs/fft/fft_mkl.cpp:162:16: style: The if condition is the same as the previous if condition [duplicateCondition] gromacs-2022-rc1/src/gromacs/fft/fft_mkl.cpp:157:16: note: First condition gromacs-2022-rc1/src/gromacs/fft/fft_mkl.cpp:162:16: note: Second condition gromacs-2022-rc1/src/gromacs/fft/fft_mkl.cpp:567:9: style: The scope of the variable 'd' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fft/gpu_3dfft_heffte.cpp:154:20: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/gromacs/fft/gpu_3dfft_sycl_mkl.cpp:65:0: error: #error This file can only be compiled with Intel DPC++ compiler [preprocessorErrorDirective] gromacs-2022-rc1/src/gromacs/fft/gpu_3dfft_sycl_rocfft.cpp:75:0: error: #error This file can only be compiled with hipSYCL enabled [preprocessorErrorDirective] gromacs-2022-rc1/src/gromacs/fft/tests/fft_mpi.cpp:218:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/fft/tests/fft.cpp:193:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/fileio/confio.cpp:435:11: warning: Either the condition 'x==nullptr' is redundant or there is possible null pointer dereference: x. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/fileio/confio.cpp:430:11: note: Assuming that condition 'x==nullptr' is not redundant gromacs-2022-rc1/src/gromacs/fileio/confio.cpp:435:11: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/fileio/confio.cpp:213:16: style: The scope of the variable 'g96_line' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:351:18: style: The scope of the variable 'nm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:453:14: style: The scope of the variable 'magic' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:455:17: style: The scope of the variable 'zero' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:816:23: style: The scope of the variable 'fr' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:893:12: style: The scope of the variable 'ne' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:893:16: style: The scope of the variable 'ns' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:894:12: style: The scope of the variable 'esum_all' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:894:22: style: The scope of the variable 'eav_all' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:1170:24: style: The scope of the variable 'boxvel_nm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:1176:18: style: The scope of the variable 'ind0' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:1177:18: style: The scope of the variable 'ind1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:1178:31: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:1178:34: style: The scope of the variable 'ni' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:1179:18: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:1180:18: style: The scope of the variable 'bufi' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:1336:13: style: The scope of the variable 'ii' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:1337:17: style: The scope of the variable 'len' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:1426:10: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:1426:13: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:1426:16: style: The scope of the variable 'k' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:1427:10: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:1427:19: style: The scope of the variable 'bs' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:252:32: style:inconclusive: Function 'init_enxframe' argument 1 names different: declaration 'ef' definition 'fr'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/enxio.h:159:32: note: Function 'init_enxframe' argument 1 names different: declaration 'ef' definition 'fr'. gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:252:32: note: Function 'init_enxframe' argument 1 names different: declaration 'ef' definition 'fr'. gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:266:32: style:inconclusive: Function 'free_enxframe' argument 1 names different: declaration 'ef' definition 'fr'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/enxio.h:161:32: note: Function 'free_enxframe' argument 1 names different: declaration 'ef' definition 'fr'. gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:266:32: note: Function 'free_enxframe' argument 1 names different: declaration 'ef' definition 'fr'. gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:281:38: style:inconclusive: Function 'add_blocks_enxframe' argument 1 names different: declaration 'ef' definition 'fr'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/enxio.h:193:38: note: Function 'add_blocks_enxframe' argument 1 names different: declaration 'ef' definition 'fr'. gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:281:38: note: Function 'add_blocks_enxframe' argument 1 names different: declaration 'ef' definition 'fr'. gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:391:56: style:inconclusive: Function 'do_enxnms' argument 3 names different: declaration 'enms' definition 'nms'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/enxio.h:174:56: note: Function 'do_enxnms' argument 3 names different: declaration 'enms' definition 'nms'. gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:391:56: note: Function 'do_enxnms' argument 3 names different: declaration 'enms' definition 'nms'. gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:1082:13: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:965:14: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:1082:13: note: Shadow variable gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:1176:18: style: Variable 'ind0' can be declared as const array [constVariable] gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:1177:18: style: Variable 'ind1' can be declared as const array [constVariable] gromacs-2022-rc1/src/gromacs/fileio/checkpoint.cpp:1647:33: warning: Either the condition 'enerhist!=nullptr' is redundant or there is possible null pointer dereference: enerhist. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/fileio/checkpoint.cpp:1642:23: note: Assuming that condition 'enerhist!=nullptr' is not redundant gromacs-2022-rc1/src/gromacs/fileio/checkpoint.cpp:1647:33: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/fileio/checkpoint.cpp:652:63: portability: Casting between char * and const float * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/gromacs/fileio/checkpoint.cpp:665:63: portability: Casting between char * and const double * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/gromacs/fileio/checkpoint.cpp:678:23: portability: Casting between const char * and const double * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/gromacs/fileio/checkpoint.cpp:688:22: portability: Casting between const char * and const float * which have an incompatible binary data representation. [invalidPointerCast] gromacs-2022-rc1/src/gromacs/fileio/checkpoint.cpp:515:10: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/checkpoint.cpp:995:15: style: The scope of the variable 'reti' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/checkpoint.cpp:2628:15: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/espio.cpp:359:27: style: Condition 'level==2' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/fileio/espio.cpp:357:26: note: Assuming that condition 'level==2' is not redundant gromacs-2022-rc1/src/gromacs/fileio/espio.cpp:359:27: note: Condition 'level==2' is always true gromacs-2022-rc1/src/gromacs/fileio/espio.cpp:404:61: style: Condition '!bFoundParticles' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/fileio/espio.cpp:402:49: note: Assuming that condition '!bFoundParticles' is not redundant gromacs-2022-rc1/src/gromacs/fileio/espio.cpp:404:61: note: Condition '!bFoundParticles' is always true gromacs-2022-rc1/src/gromacs/fileio/espio.cpp:105:10: style: The scope of the variable 'word' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/espio.cpp:131:10: style: The scope of the variable 'word' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/filetypes.cpp:277:17: style: The scope of the variable 'eptr' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/g96io.cpp:61:48: style: The scope of the variable 'oldres' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/g96io.cpp:61:56: style: The scope of the variable 'newres' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/g96io.cpp:61:64: style: The scope of the variable 'shift' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/g96io.cpp:62:14: style: The scope of the variable 'anm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/g96io.cpp:62:27: style: The scope of the variable 'resnm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/g96io.cpp:172:36: style: The scope of the variable 'shift' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/gmxfio.cpp:301:11: error: Cyclic reverse analysis. [cppcheckError] gromacs-2022-rc1/src/gromacs/fileio/gmxfio_xdr.cpp:320:34: portability:inconclusive: Casting from double * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] gromacs-2022-rc1/src/gromacs/fileio/gmxfio_xdr.cpp:342:34: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] gromacs-2022-rc1/src/gromacs/fileio/gmxfio_xdr.cpp:619:50: style:inconclusive: Function 'gmx_fio_doe_opaque' argument 2 names different: declaration 'item' definition 'data'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/gmxfio_xdr.h:82:46: note: Function 'gmx_fio_doe_opaque' argument 2 names different: declaration 'item' definition 'data'. gromacs-2022-rc1/src/gromacs/fileio/gmxfio_xdr.cpp:619:50: note: Function 'gmx_fio_doe_opaque' argument 2 names different: declaration 'item' definition 'data'. gromacs-2022-rc1/src/gromacs/fileio/gmxfio_xdr.cpp:385:19: style: Local variable 'cptr' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/fileio/gmxfio_xdr.cpp:159:27: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/fileio/gmxfio_xdr.cpp:385:19: note: Shadow variable gromacs-2022-rc1/src/gromacs/fileio/groio.cpp:214:14: warning:inconclusive: The buffer 'oldresname' may not be null-terminated after the call to strncpy(). [terminateStrncpy] gromacs-2022-rc1/src/gromacs/fileio/groio.cpp:481:9: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/groio.cpp:481:16: style: The scope of the variable 'resind' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/matio.cpp:1046:38: warning: Either the condition 'c<0' is redundant or the array 'mapper[89]' is accessed at index -1, which is out of bounds. [negativeIndex] gromacs-2022-rc1/src/gromacs/fileio/matio.cpp:1028:24: note: Assuming that condition 'c<0' is not redundant gromacs-2022-rc1/src/gromacs/fileio/matio.cpp:1046:38: note: Negative array index gromacs-2022-rc1/src/gromacs/fileio/matio.cpp:149:9: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/fileio/matio.cpp:230:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/matio.cpp:821:13: style: The scope of the variable 'nlo' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/matio.cpp:1205:35: style:inconclusive: Function 'write_xpm' argument 9 names different: declaration 't_x' definition 'axis_x'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/matio.h:207:35: note: Function 'write_xpm' argument 9 names different: declaration 't_x' definition 'axis_x'. gromacs-2022-rc1/src/gromacs/fileio/matio.cpp:1205:35: note: Function 'write_xpm' argument 9 names different: declaration 't_x' definition 'axis_x'. gromacs-2022-rc1/src/gromacs/fileio/matio.cpp:1206:35: style:inconclusive: Function 'write_xpm' argument 10 names different: declaration 't_y' definition 'axis_y'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/matio.h:208:35: note: Function 'write_xpm' argument 10 names different: declaration 't_y' definition 'axis_y'. gromacs-2022-rc1/src/gromacs/fileio/matio.cpp:1206:35: note: Function 'write_xpm' argument 10 names different: declaration 't_y' definition 'axis_y'. gromacs-2022-rc1/src/gromacs/fileio/matio.cpp:926:18: style: Variable 'c' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/fileio/md5.cpp:441:17: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/fileio/md5.cpp:429:29: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/fileio/md5.cpp:441:17: note: Shadow variable gromacs-2022-rc1/src/gromacs/fileio/mrcdensitymap.cpp:176:67: style:inconclusive: Function 'Impl' argument 1 names different: declaration 'fileName' definition 'filename'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/mrcdensitymap.cpp:166:38: note: Function 'Impl' argument 1 names different: declaration 'fileName' definition 'filename'. gromacs-2022-rc1/src/gromacs/fileio/mrcdensitymap.cpp:176:67: note: Function 'Impl' argument 1 names different: declaration 'fileName' definition 'filename'. gromacs-2022-rc1/src/gromacs/fileio/mrcserializer.cpp:149:5: error: Found a exit path from function with non-void return type that has missing return statement [missingReturn] gromacs-2022-rc1/src/gromacs/fileio/mrcserializer.cpp:306:87: style:inconclusive: Function 'serializeMrcDensityMapHeader' argument 2 names different: declaration 'mrcHeader' definition 'mrcFile'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/mrcserializer.h:54:87: note: Function 'serializeMrcDensityMapHeader' argument 2 names different: declaration 'mrcHeader' definition 'mrcFile'. gromacs-2022-rc1/src/gromacs/fileio/mrcserializer.cpp:306:87: note: Function 'serializeMrcDensityMapHeader' argument 2 names different: declaration 'mrcHeader' definition 'mrcFile'. gromacs-2022-rc1/src/gromacs/fileio/oenv.cpp:210:5: error: There is an unknown macro here somewhere. Configuration is required. If GMX_CATCH_ALL_AND_EXIT_WITH_FATAL_ERROR is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/fileio/mtxio.cpp:85:18: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/mtxio.cpp:86:15: style: The scope of the variable 'sz' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/mtxio.cpp:155:15: style: The scope of the variable 'sz' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:462:32: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:812:32: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:184:54: style: The scope of the variable 'tmp' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:352:32: style: The scope of the variable 'num' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:419:40: style: The scope of the variable 'mindiff' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:419:55: style: The scope of the variable 'diff' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:420:18: style: The scope of the variable 'lint1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:420:25: style: The scope of the variable 'lint2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:420:32: style: The scope of the variable 'lint3' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:420:39: style: The scope of the variable 'oldlint1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:420:49: style: The scope of the variable 'oldlint2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:420:59: style: The scope of the variable 'oldlint3' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:421:18: style: The scope of the variable 'minidx' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:421:26: style: The scope of the variable 'maxidx' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:422:67: style: The scope of the variable 'luip' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:423:18: style: The scope of the variable 'flag' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:424:37: style: The scope of the variable 'larger' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:424:48: style: The scope of the variable 'is_small' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:424:75: style: The scope of the variable 'prevrun' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:425:23: style: The scope of the variable 'lf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:431:18: style: The scope of the variable 'inv_precision' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:432:18: style: The scope of the variable 'errval' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:433:18: style: The scope of the variable 'rc' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:1116:15: style: The scope of the variable 'ret' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:1152:15: style: The scope of the variable 'ret' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:1191:15: style: The scope of the variable 'ret' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:1235:15: style: The scope of the variable 'ret' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:1282:15: style: The scope of the variable 'ret' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:1351:15: style: The scope of the variable 'fr' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:1430:15: style: The scope of the variable 't' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/libxdrf.cpp:1431:15: style: The scope of the variable 'dt' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/pdbio.cpp:165:5: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/fileio/pdbio.cpp:160:37: style: The scope of the variable 'sg' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/pdbio.cpp:161:13: style: The scope of the variable 'fa' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/pdbio.cpp:161:17: style: The scope of the variable 'fb' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/pdbio.cpp:161:45: style: The scope of the variable 'cosa' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/pdbio.cpp:161:51: style: The scope of the variable 'cosb' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/pdbio.cpp:161:57: style: The scope of the variable 'cosg' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/pdbio.cpp:161:63: style: The scope of the variable 'sing' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/pdbio.cpp:304:19: style: The scope of the variable 'altloc' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/pdbio.cpp:562:27: style: The scope of the variable 'len' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/pdbio.cpp:794:9: style: The scope of the variable 'n' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/pdbio.cpp:520:6: style: Variable 'j' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/fileio/tests/checkpoint.cpp:67:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/fileio/tests/confio.cpp:201:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/fileio/tests/fileioxdrserializer.cpp:121:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/fileio/readinp.cpp:174:10: style:inconclusive: Technically the member function 'inp_comp::operator()' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/fileio/readinp.cpp:350:29: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/readinp.cpp:350:44: style: The scope of the variable 'warn_buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/readinp.cpp:387:29: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/readinp.cpp:387:44: style: The scope of the variable 'warn_buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/readinp.cpp:424:29: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/tests/filemd5.cpp:94:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/fileio/readinp.cpp:424:44: style: The scope of the variable 'warn_buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/readinp.cpp:492:29: style: The scope of the variable 'n' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/readinp.cpp:493:29: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/tests/mrcdensitymap.cpp:94:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/fileio/tests/mrcdensitymapheader.cpp:67:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/fileio/tests/mrcserializer.cpp:70:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/fileio/tests/tngio.cpp:66:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/fileio/tests/readinp.cpp:71:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/fileio/tests/xvgio.cpp:100:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:115:74: style:inconclusive: Function 'gmx_tng_open' argument 3 names different: declaration 'tng_data_p' definition 'gmx_tng'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/tngio.h:65:74: note: Function 'gmx_tng_open' argument 3 names different: declaration 'tng_data_p' definition 'gmx_tng'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:115:74: note: Function 'gmx_tng_open' argument 3 names different: declaration 'tng_data_p' definition 'gmx_tng'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:193:42: style:inconclusive: Function 'gmx_tng_close' argument 1 names different: declaration 'tng' definition 'gmx_tng'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/tngio.h:68:42: note: Function 'gmx_tng_close' argument 1 names different: declaration 'tng' definition 'gmx_tng'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:193:42: note: Function 'gmx_tng_close' argument 1 names different: declaration 'tng' definition 'gmx_tng'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:547:54: style:inconclusive: Function 'gmx_tng_prepare_md_writing' argument 1 names different: declaration 'tng' definition 'gmx_tng'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/tngio.h:85:54: note: Function 'gmx_tng_prepare_md_writing' argument 1 names different: declaration 'tng' definition 'gmx_tng'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:547:54: note: Function 'gmx_tng_prepare_md_writing' argument 1 names different: declaration 'tng' definition 'gmx_tng'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:752:61: style:inconclusive: Function 'gmx_tng_set_compression_precision' argument 1 names different: declaration 'tng' definition 'gmx_tng'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/tngio.h:91:61: note: Function 'gmx_tng_set_compression_precision' argument 1 names different: declaration 'tng' definition 'gmx_tng'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:752:61: note: Function 'gmx_tng_set_compression_precision' argument 1 names different: declaration 'tng' definition 'gmx_tng'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:762:60: style:inconclusive: Function 'gmx_tng_prepare_low_prec_writing' argument 1 names different: declaration 'tng' definition 'gmx_tng'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/tngio.h:100:60: note: Function 'gmx_tng_prepare_low_prec_writing' argument 1 names different: declaration 'tng' definition 'gmx_tng'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:762:60: note: Function 'gmx_tng_prepare_low_prec_writing' argument 1 names different: declaration 'tng' definition 'gmx_tng'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:778:42: style:inconclusive: Function 'gmx_fwrite_tng' argument 1 names different: declaration 'tng' definition 'gmx_tng'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/tngio.h:117:42: note: Function 'gmx_fwrite_tng' argument 1 names different: declaration 'tng' definition 'gmx_tng'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:778:42: note: Function 'gmx_fwrite_tng' argument 1 names different: declaration 'tng' definition 'gmx_tng'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:983:38: style:inconclusive: Function 'fflush_tng' argument 1 names different: declaration 'tng' definition 'gmx_tng'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/tngio.h:133:38: note: Function 'fflush_tng' argument 1 names different: declaration 'tng' definition 'gmx_tng'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:983:38: note: Function 'fflush_tng' argument 1 names different: declaration 'tng' definition 'gmx_tng'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:996:60: style:inconclusive: Function 'gmx_tng_get_time_of_final_frame' argument 1 names different: declaration 'tng' definition 'gmx_tng'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/tngio.h:140:60: note: Function 'gmx_tng_get_time_of_final_frame' argument 1 names different: declaration 'tng' definition 'gmx_tng'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:996:60: note: Function 'gmx_tng_get_time_of_final_frame' argument 1 names different: declaration 'tng' definition 'gmx_tng'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:1171:55: style:inconclusive: Function 'gmx_write_tng_from_trxframe' argument 1 names different: declaration 'output' definition 'gmx_tng_output'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/tngio.h:162:55: note: Function 'gmx_write_tng_from_trxframe' argument 1 names different: declaration 'output' definition 'gmx_tng_output'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:1171:55: note: Function 'gmx_write_tng_from_trxframe' argument 1 names different: declaration 'output' definition 'gmx_tng_output'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:1296:55: style:inconclusive: Function 'gmx_tng_setup_atom_subgroup' argument 1 names different: declaration 'tng' definition 'gmx_tng'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/tngio.h:167:55: note: Function 'gmx_tng_setup_atom_subgroup' argument 1 names different: declaration 'tng' definition 'gmx_tng'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:1296:55: note: Function 'gmx_tng_setup_atom_subgroup' argument 1 names different: declaration 'tng' definition 'gmx_tng'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:1395:55: style:inconclusive: Function 'gmx_read_next_tng_frame' argument 1 names different: declaration 'input' definition 'gmx_tng_input'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/tngio.h:170:55: note: Function 'gmx_read_next_tng_frame' argument 1 names different: declaration 'input' definition 'gmx_tng_input'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:1395:55: note: Function 'gmx_read_next_tng_frame' argument 1 names different: declaration 'input' definition 'gmx_tng_input'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:1582:57: style:inconclusive: Function 'gmx_print_tng_molecule_system' argument 1 names different: declaration 'input' definition 'gmx_tng_input'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/tngio.h:176:57: note: Function 'gmx_print_tng_molecule_system' argument 1 names different: declaration 'input' definition 'gmx_tng_input'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:1582:57: note: Function 'gmx_print_tng_molecule_system' argument 1 names different: declaration 'input' definition 'gmx_tng_input'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:1738:74: style:inconclusive: Function 'gmx_get_tng_data_block_types_of_next_frame' argument 1 names different: declaration 'input' definition 'gmx_tng_input'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/tngio.h:179:74: note: Function 'gmx_get_tng_data_block_types_of_next_frame' argument 1 names different: declaration 'input' definition 'gmx_tng_input'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:1738:74: note: Function 'gmx_get_tng_data_block_types_of_next_frame' argument 1 names different: declaration 'input' definition 'gmx_tng_input'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:1774:73: style:inconclusive: Function 'gmx_get_tng_data_next_frame_of_block_type' argument 1 names different: declaration 'input' definition 'gmx_tng_input'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/tngio.h:189:73: note: Function 'gmx_get_tng_data_next_frame_of_block_type' argument 1 names different: declaration 'input' definition 'gmx_tng_input'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:1774:73: note: Function 'gmx_get_tng_data_next_frame_of_block_type' argument 1 names different: declaration 'input' definition 'gmx_tng_input'. gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:90:22: style: struct member 'gmx_tng_trajectory::tng' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:91:22: style: struct member 'gmx_tng_trajectory::lastStepDataIsValid' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:93:22: style: struct member 'gmx_tng_trajectory::lastTimeDataIsValid' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:94:22: style: struct member 'gmx_tng_trajectory::lastTime' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:95:22: style: struct member 'gmx_tng_trajectory::timePerFrameIsSet' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:96:22: style: struct member 'gmx_tng_trajectory::boxOutputInterval' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/fileio/tngio.cpp:97:22: style: struct member 'gmx_tng_trajectory::lambdaOutputInterval' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/fileio/trrio.cpp:363:67: style:inconclusive: Function 'gmx_trr_read_frame_data' argument 2 names different: declaration 'sh' definition 'header'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/trrio.h:108:74: note: Function 'gmx_trr_read_frame_data' argument 2 names different: declaration 'sh' definition 'header'. gromacs-2022-rc1/src/gromacs/fileio/trrio.cpp:363:67: note: Function 'gmx_trr_read_frame_data' argument 2 names different: declaration 'sh' definition 'header'. gromacs-2022-rc1/src/gromacs/fileio/trxio.cpp:94:26: style: struct member 't_trxstatus::DT' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/fileio/trxio.cpp:94:30: style: struct member 't_trxstatus::BOX' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/fileio/vmdio.cpp:274:17: style: The scope of the variable 'err' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/warninp.cpp:81:49: style:inconclusive: Function 'set_warning_line' argument 2 names different: declaration 'fn' definition 's'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/warninp.h:60:49: note: Function 'set_warning_line' argument 2 names different: declaration 'fn' definition 's'. gromacs-2022-rc1/src/gromacs/fileio/warninp.cpp:81:49: note: Function 'set_warning_line' argument 2 names different: declaration 'fn' definition 's'. gromacs-2022-rc1/src/gromacs/fileio/writeps.cpp:146:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/xtcio.cpp:78:32: style:inconclusive: Function 'open_xtc' argument 1 names different: declaration 'filename' definition 'fn'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/fileio/xtcio.h:59:39: note: Function 'open_xtc' argument 1 names different: declaration 'filename' definition 'fn'. gromacs-2022-rc1/src/gromacs/fileio/xtcio.cpp:78:32: note: Function 'open_xtc' argument 1 names different: declaration 'filename' definition 'fn'. gromacs-2022-rc1/src/gromacs/fileio/tpxio.cpp:1026:20: style: The scope of the variable 'k' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/tpxio.cpp:1441:18: style: Local variable 'idum' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/fileio/tpxio.cpp:1026:23: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/fileio/tpxio.cpp:1441:18: note: Shadow variable gromacs-2022-rc1/src/gromacs/fileio/tpxio.cpp:1442:18: style: Local variable 'rdum' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/fileio/tpxio.cpp:1027:14: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/fileio/tpxio.cpp:1442:18: note: Shadow variable gromacs-2022-rc1/src/gromacs/fileio/xvgr.cpp:727:14: warning:inconclusive: Possible null pointer dereference: yy [nullPointer] gromacs-2022-rc1/src/gromacs/fileio/xvgr.cpp:723:19: note: Assignment 'yy=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/fileio/xvgr.cpp:727:14: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/fileio/xvgr.cpp:730:13: warning:inconclusive: Possible null pointer dereference: yy [nullPointer] gromacs-2022-rc1/src/gromacs/fileio/xvgr.cpp:723:19: note: Assignment 'yy=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/fileio/xvgr.cpp:730:13: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/fileio/xvgr.cpp:230:10: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/xvgr.cpp:298:10: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/xvgr.cpp:382:10: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/xvgr.cpp:383:10: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/xvgr.cpp:512:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/xvgr.cpp:512:19: style: The scope of the variable 'is' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/xvgr.cpp:513:9: style: The scope of the variable 'cur' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/xvgr.cpp:533:24: style: The scope of the variable 'ptr1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/xvgr.cpp:861:46: style: The scope of the variable 'n' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/xvgr.cpp:343:10: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/fileio/xvgr.cpp:344:10: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/anadih.cpp:188:11: style: The scope of the variable 'Dih' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/anadih.cpp:189:11: style: The scope of the variable 'cur_bin' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/anadih.cpp:763:15: style: The scope of the variable 'ind' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/anadih.cpp:799:11: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/gmxana/binsearch.cpp:73:26: style:inconclusive: Function 'insertionSort' argument 1 names different: declaration 'ar' definition 'arr'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxana/binsearch.h:43:26: note: Function 'insertionSort' argument 1 names different: declaration 'ar' definition 'arr'. gromacs-2022-rc1/src/gromacs/gmxana/binsearch.cpp:73:26: note: Function 'insertionSort' argument 1 names different: declaration 'ar' definition 'arr'. gromacs-2022-rc1/src/gromacs/gmxana/binsearch.cpp:73:46: style:inconclusive: Function 'insertionSort' argument 3 names different: declaration 'start' definition 'startndx'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxana/binsearch.h:43:45: note: Function 'insertionSort' argument 3 names different: declaration 'start' definition 'startndx'. gromacs-2022-rc1/src/gromacs/gmxana/binsearch.cpp:73:46: note: Function 'insertionSort' argument 3 names different: declaration 'start' definition 'startndx'. gromacs-2022-rc1/src/gromacs/gmxana/binsearch.cpp:73:60: style:inconclusive: Function 'insertionSort' argument 4 names different: declaration 'end' definition 'endndx'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxana/binsearch.h:43:56: note: Function 'insertionSort' argument 4 names different: declaration 'end' definition 'endndx'. gromacs-2022-rc1/src/gromacs/gmxana/binsearch.cpp:73:60: note: Function 'insertionSort' argument 4 names different: declaration 'end' definition 'endndx'. gromacs-2022-rc1/src/gromacs/gmxana/binsearch.cpp:109:30: style:inconclusive: Function 'BinarySearch' argument 1 names different: declaration 'ar' definition 'array'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxana/binsearch.h:45:30: note: Function 'BinarySearch' argument 1 names different: declaration 'ar' definition 'array'. gromacs-2022-rc1/src/gromacs/gmxana/binsearch.cpp:109:30: note: Function 'BinarySearch' argument 1 names different: declaration 'ar' definition 'array'. gromacs-2022-rc1/src/gromacs/gmxana/binsearch.cpp:109:41: style:inconclusive: Function 'BinarySearch' argument 2 names different: declaration 'start' definition 'low'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxana/binsearch.h:45:38: note: Function 'BinarySearch' argument 2 names different: declaration 'start' definition 'low'. gromacs-2022-rc1/src/gromacs/gmxana/binsearch.cpp:109:41: note: Function 'BinarySearch' argument 2 names different: declaration 'start' definition 'low'. gromacs-2022-rc1/src/gromacs/gmxana/binsearch.cpp:109:50: style:inconclusive: Function 'BinarySearch' argument 3 names different: declaration 'end' definition 'high'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxana/binsearch.h:45:49: note: Function 'BinarySearch' argument 3 names different: declaration 'end' definition 'high'. gromacs-2022-rc1/src/gromacs/gmxana/binsearch.cpp:109:50: note: Function 'BinarySearch' argument 3 names different: declaration 'end' definition 'high'. gromacs-2022-rc1/src/gromacs/gmxana/cmat.cpp:151:24: style:inconclusive: Function 'mat_energy' argument 1 names different: declaration 'mat' definition 'm'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxana/cmat.h:84:31: note: Function 'mat_energy' argument 1 names different: declaration 'mat' definition 'm'. gromacs-2022-rc1/src/gromacs/gmxana/cmat.cpp:151:24: note: Function 'mat_energy' argument 1 names different: declaration 'mat' definition 'm'. gromacs-2022-rc1/src/gromacs/gmxana/cmat.cpp:240:47: style:inconclusive: Function 'rmsd_distribution' argument 2 names different: declaration 'm' definition 'rms'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxana/cmat.h:90:54: note: Function 'rmsd_distribution' argument 2 names different: declaration 'm' definition 'rms'. gromacs-2022-rc1/src/gromacs/gmxana/cmat.cpp:240:47: note: Function 'rmsd_distribution' argument 2 names different: declaration 'm' definition 'rms'. gromacs-2022-rc1/src/gromacs/gmxana/dens_filter.cpp:50:42: style:inconclusive: Function 'convolution' argument 2 names different: declaration 'in' definition 'x'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxana/dens_filter.h:42:49: note: Function 'convolution' argument 2 names different: declaration 'in' definition 'x'. gromacs-2022-rc1/src/gromacs/gmxana/dens_filter.cpp:50:42: note: Function 'convolution' argument 2 names different: declaration 'in' definition 'x'. gromacs-2022-rc1/src/gromacs/gmxana/dens_filter.cpp:93:35: style:inconclusive: Function 'periodic_convolution' argument 1 names different: declaration 'dsize' definition 'datasize'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxana/dens_filter.h:43:42: note: Function 'periodic_convolution' argument 1 names different: declaration 'dsize' definition 'datasize'. gromacs-2022-rc1/src/gromacs/gmxana/dens_filter.cpp:93:35: note: Function 'periodic_convolution' argument 1 names different: declaration 'dsize' definition 'datasize'. gromacs-2022-rc1/src/gromacs/gmxana/dens_filter.cpp:93:51: style:inconclusive: Function 'periodic_convolution' argument 2 names different: declaration 'in' definition 'x'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxana/dens_filter.h:43:55: note: Function 'periodic_convolution' argument 2 names different: declaration 'in' definition 'x'. gromacs-2022-rc1/src/gromacs/gmxana/dens_filter.cpp:93:51: note: Function 'periodic_convolution' argument 2 names different: declaration 'in' definition 'x'. gromacs-2022-rc1/src/gromacs/gmxana/dens_filter.cpp:93:58: style:inconclusive: Function 'periodic_convolution' argument 3 names different: declaration 'ksize' definition 'kernelsize'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxana/dens_filter.h:43:63: note: Function 'periodic_convolution' argument 3 names different: declaration 'ksize' definition 'kernelsize'. gromacs-2022-rc1/src/gromacs/gmxana/dens_filter.cpp:93:58: note: Function 'periodic_convolution' argument 3 names different: declaration 'ksize' definition 'kernelsize'. gromacs-2022-rc1/src/gromacs/gmxana/dens_filter.cpp:131:33: style:inconclusive: Function 'gausskernel' argument 2 names different: declaration 'size' definition 'n'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxana/dens_filter.h:44:44: note: Function 'gausskernel' argument 2 names different: declaration 'size' definition 'n'. gromacs-2022-rc1/src/gromacs/gmxana/dens_filter.cpp:131:33: note: Function 'gausskernel' argument 2 names different: declaration 'size' definition 'n'. gromacs-2022-rc1/src/gromacs/gmxana/cluster_methods.cpp:511:25: style: The scope of the variable 'maxval' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/fitahx.cpp:53:15: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/fitahx.cpp:69:12: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:218:79: warning:inconclusive: Possible null pointer dereference: sy [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:999:105: note: Calling function 'write_xvgr_graphs', 11th argument 'nullptr' value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:218:79: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:574:32: warning:inconclusive: Possible null pointer dereference: inprod [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:506:37: note: Assignment 'inprod=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:574:32: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:577:17: warning:inconclusive: Possible null pointer dereference: inprod [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:506:37: note: Assignment 'inprod=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:577:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:601:21: warning:inconclusive: Possible null pointer dereference: inprod [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:506:37: note: Assignment 'inprod=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:601:21: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:1475:18: warning:inconclusive: Possible null pointer dereference: iout [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:1464:16: note: Assignment 'iout=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:1475:18: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:498:18: style: The scope of the variable 'nat' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:498:26: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:498:35: style: The scope of the variable 'vec' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:498:40: style: The scope of the variable 'nfr' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:498:58: style: The scope of the variable 'snew_size' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:498:69: style: The scope of the variable 'frame' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:501:32: style: The scope of the variable 'imin' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:501:38: style: The scope of the variable 'imax' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:502:18: style: The scope of the variable 'pmin' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:502:25: style: The scope of the variable 'pmax' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:503:18: style: The scope of the variable 'all_at' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:507:46: style: The scope of the variable 'c' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:508:18: style: The scope of the variable 'ylabel' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:693:18: style: The scope of the variable 'out' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:896:24: style: The scope of the variable 'v' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:958:21: style: The scope of the variable 'v' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:1128:29: style: The scope of the variable 'd' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:687:18: style: Local variable 'atoms' shadows outer argument [shadowArgument] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:480:45: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:687:18: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:688:18: style: Local variable 'x' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:505:26: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:688:18: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:690:18: style: Local variable 'box' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:504:18: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:690:18: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:693:18: style: Local variable 'out' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:499:18: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:693:18: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:324:39: style: Parameter 'eignr1' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:428:45: style: Parameter 'outvec' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:425:45: style: Parameter 'eignr2' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:493:45: style: Parameter 'outvec' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:490:45: style: Parameter 'eignr' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:890:48: style: Parameter 'eignr' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:950:42: style: Parameter 'eignr' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:359:21: warning:inconclusive: Possible null pointer dereference: tmp [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:317:18: note: Assignment 'tmp=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:359:21: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:361:23: warning:inconclusive: Possible null pointer dereference: tmp [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:317:18: note: Assignment 'tmp=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:361:23: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:362:39: warning:inconclusive: Possible null pointer dereference: tmp [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:317:18: note: Assignment 'tmp=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:362:39: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:942:26: warning:inconclusive: Possible null pointer dereference: buf2 [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:936:22: note: Assignment 'buf2=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:942:26: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:943:13: warning:inconclusive: Possible null pointer dereference: buf2 [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:936:22: note: Assignment 'buf2=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:943:13: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:951:26: warning:inconclusive: Possible null pointer dereference: buf [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:947:25: note: Assignment 'buf=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:951:26: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:316:12: style: The scope of the variable 'av' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:316:16: style: The scope of the variable 'var' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:427:16: style: The scope of the variable 'prev_bs' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:427:25: style: The scope of the variable 'nbs' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:730:11: style: The scope of the variable 'kt' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:732:11: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:771:28: style: The scope of the variable 'fluc' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:1161:23: style: The scope of the variable 'out' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:1162:26: style: The scope of the variable 'nlast' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:1162:45: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:1164:33: style: The scope of the variable 'cum1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:1164:39: style: The scope of the variable 'cum2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:1164:45: style: The scope of the variable 'cum3' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:1164:51: style: The scope of the variable 'cum4' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:201:16: style: Local variable 'chi2' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:167:13: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:201:16: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:201:23: style: Local variable 'a' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:167:19: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_analyze.cpp:201:23: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_angle.cpp:403:17: style: The if condition is the same as the previous if condition [duplicateCondition] gromacs-2022-rc1/src/gromacs/gmxana/gmx_angle.cpp:374:17: note: First condition gromacs-2022-rc1/src/gromacs/gmxana/gmx_angle.cpp:403:17: note: Second condition gromacs-2022-rc1/src/gromacs/gmxana/gmx_angle.cpp:67:28: style: The scope of the variable 'k' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_angle.cpp:67:31: style: The scope of the variable 'l' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_angle.cpp:174:19: style: The scope of the variable 'mode' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_angle.cpp:435:18: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_angle.cpp:176:19: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_angle.cpp:435:18: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_angle.cpp:440:22: style: Local variable 'j' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_angle.cpp:176:22: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_angle.cpp:440:22: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_awh.cpp:305:5: performance: Variable 'baseFilename_' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] gromacs-2022-rc1/src/gromacs/gmxana/gmx_awh.cpp:314:63: style:inconclusive: Function 'initializeAwhOutputFile' argument 1 names different: declaration 'subBlockStart' definition 'subblockStart'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxana/gmx_awh.cpp:124:55: note: Function 'initializeAwhOutputFile' argument 1 names different: declaration 'subBlockStart' definition 'subblockStart'. gromacs-2022-rc1/src/gromacs/gmxana/gmx_awh.cpp:314:63: note: Function 'initializeAwhOutputFile' argument 1 names different: declaration 'subBlockStart' definition 'subblockStart'. gromacs-2022-rc1/src/gromacs/gmxana/dlist.cpp:200:70: style: Condition 'atm.Cn[1]!=-1' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bundle.cpp:96:19: style: The scope of the variable 'div' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bundle.cpp:159:56: style: Parameter 'fr' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:609:5: warning:inconclusive: Either the condition '!sc' is redundant or there is possible null pointer dereference: sc. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:812:9: note: Assuming that condition '!sc' is not redundant gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:815:26: note: Calling function 'sample_coll_init', 1st argument 'sc' value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:609:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:610:5: warning:inconclusive: Either the condition '!sc' is redundant or there is possible null pointer dereference: sc. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:812:9: note: Assuming that condition '!sc' is not redundant gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:815:26: note: Calling function 'sample_coll_init', 1st argument 'sc' value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:610:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:611:5: warning:inconclusive: Either the condition '!sc' is redundant or there is possible null pointer dereference: sc. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:812:9: note: Assuming that condition '!sc' is not redundant gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:815:26: note: Calling function 'sample_coll_init', 1st argument 'sc' value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:611:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:613:5: warning:inconclusive: Either the condition '!sc' is redundant or there is possible null pointer dereference: sc. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:812:9: note: Assuming that condition '!sc' is not redundant gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:815:26: note: Calling function 'sample_coll_init', 1st argument 'sc' value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:613:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:614:5: warning:inconclusive: Either the condition '!sc' is redundant or there is possible null pointer dereference: sc. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:812:9: note: Assuming that condition '!sc' is not redundant gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:815:26: note: Calling function 'sample_coll_init', 1st argument 'sc' value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:614:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:615:5: warning:inconclusive: Either the condition '!sc' is redundant or there is possible null pointer dereference: sc. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:812:9: note: Assuming that condition '!sc' is not redundant gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:815:26: note: Calling function 'sample_coll_init', 1st argument 'sc' value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:615:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:616:5: warning:inconclusive: Either the condition '!sc' is redundant or there is possible null pointer dereference: sc. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:812:9: note: Assuming that condition '!sc' is not redundant gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:815:26: note: Calling function 'sample_coll_init', 1st argument 'sc' value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:616:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:618:5: warning:inconclusive: Either the condition '!sc' is redundant or there is possible null pointer dereference: sc. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:812:9: note: Assuming that condition '!sc' is not redundant gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:815:26: note: Calling function 'sample_coll_init', 1st argument 'sc' value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:618:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:619:5: warning:inconclusive: Either the condition '!sc' is redundant or there is possible null pointer dereference: sc. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:812:9: note: Assuming that condition '!sc' is not redundant gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:815:26: note: Calling function 'sample_coll_init', 1st argument 'sc' value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:619:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:745:16: warning: Either the condition '!sc' is redundant or there is possible null pointer dereference: sc. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:812:9: note: Assuming that condition '!sc' is not redundant gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:821:31: note: Calling function 'sample_coll_insert_sample', 1st argument 'sc' value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:745:16: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:746:9: warning: Either the condition '!sc' is redundant or there is possible null pointer dereference: sc. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:812:9: note: Assuming that condition '!sc' is not redundant gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:821:31: note: Calling function 'sample_coll_insert_sample', 1st argument 'sc' value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:746:9: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:1015:18: warning:inconclusive: Possible null pointer dereference: setnames [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:988:32: note: Assignment 'setnames=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:1015:18: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:3196:17: warning:inconclusive: Possible null pointer dereference: nhists [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:3047:36: note: Assignment 'nhists=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:3196:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:3197:17: warning:inconclusive: Possible null pointer dereference: npts [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:3048:36: note: Assignment 'npts=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:3197:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:3198:17: warning:inconclusive: Possible null pointer dereference: lambdas [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:3049:36: note: Assignment 'lambdas=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:3198:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:3199:17: warning:inconclusive: Possible null pointer dereference: samples_rawdh [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:3046:36: note: Assignment 'samples_rawdh=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:3199:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:3301:13: warning:inconclusive: Possible null pointer dereference: samples_rawdh [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:3046:36: note: Assignment 'samples_rawdh=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:3301:13: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:3316:17: warning:inconclusive: Possible null pointer dereference: lambdas [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:3049:36: note: Assignment 'lambdas=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:3316:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:325:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:429:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:1011:31: style: The scope of the variable 'buf2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:1204:12: style: The scope of the variable 'delta_lambda' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:1428:17: style: The scope of the variable 'new_start' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:1428:28: style: The scope of the variable 'new_end' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:1640:17: style: The scope of the variable 'DG1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:1640:27: style: The scope of the variable 'dDG1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:2001:12: style: The scope of the variable 'npee' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:2001:18: style: The scope of the variable 'p' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:2006:14: style: The scope of the variable 'dg_min' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:2006:22: style: The scope of the variable 'dg_max' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:2163:18: style: The scope of the variable 's' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:2163:21: style: The scope of the variable 's2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:2623:35: style: The scope of the variable 'ptr' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:2626:14: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:2811:19: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:1323:33: style: Local variable 'end_t' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:1302:29: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:1323:33: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:3278:32: style: Local variable 'j' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:3039:23: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:3278:32: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:742:88: style: Parameter 'r' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:92:19: style: struct member 'xvg_t::ftp' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:104:19: style: struct member 'xvg_t::next' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:104:26: style: struct member 'xvg_t::prev' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:3070:65: style: Variable 'old_start_lambda' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:3070:83: style: Variable 'delta_lambda' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_chi.cpp:512:18: warning: fscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxana/gmx_chi.cpp:501:17: style: The scope of the variable 'leg' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_chi.cpp:1441:12: style: The scope of the variable 'chi_lookup' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_chi.cpp:684:22: style: Local variable 'j' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_chi.cpp:556:9: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_chi.cpp:684:22: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_chi.cpp:723:26: style: Local variable 'j' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_chi.cpp:556:9: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_chi.cpp:723:26: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_chi.cpp:746:17: style: Local variable 'j' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_chi.cpp:556:9: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_chi.cpp:746:17: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_chi.cpp:813:26: style: Local variable 'j' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_chi.cpp:746:17: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_chi.cpp:813:26: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_clustsize.cpp:382:30: style: Local variable 'j' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_clustsize.cpp:106:15: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_clustsize.cpp:382:30: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_confrms.cpp:541:17: style: The scope of the variable 'name1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_confrms.cpp:541:25: style: The scope of the variable 'name2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_confrms.cpp:548:37: style: The scope of the variable 'fit_x' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_cluster.cpp:1196:9: style: The if condition is the same as the previous if condition [duplicateCondition] gromacs-2022-rc1/src/gromacs/gmxana/gmx_cluster.cpp:1141:9: note: First condition gromacs-2022-rc1/src/gromacs/gmxana/gmx_cluster.cpp:1196:9: note: Second condition gromacs-2022-rc1/src/gromacs/gmxana/gmx_cluster.cpp:208:18: warning:inconclusive: Possible null pointer dereference: xx [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_cluster.cpp:187:24: note: Assignment 'xx=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_cluster.cpp:208:18: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_cluster.cpp:212:40: warning:inconclusive: Possible null pointer dereference: xx [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_cluster.cpp:187:24: note: Assignment 'xx=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_cluster.cpp:212:40: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_cluster.cpp:130:11: style: The scope of the variable 'xi' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_cluster.cpp:231:26: style: The scope of the variable 'ci' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_cluster.cpp:453:29: style: The scope of the variable 'nstr' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_cluster.cpp:453:58: style: The scope of the variable 'midstr' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_cluster.cpp:888:34: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_cluster.cpp:889:13: style: The scope of the variable 'nrms' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_cluster.cpp:893:24: style: The scope of the variable 'usextps' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_cluster.cpp:893:34: style: The scope of the variable 'x1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_cluster.cpp:894:17: style: The scope of the variable 'fn' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_cluster.cpp:906:22: style: The scope of the variable 'd1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_cluster.cpp:906:28: style: The scope of the variable 'd2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_cluster.cpp:907:27: style: The scope of the variable 'buf1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_cluster.cpp:427:54: style: Parameter 'frameindices' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:341:13: warning:inconclusive: Possible null pointer dereference: refr [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:381:25: note: Assignment 'xshfr=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:652:54: note: Calling function 'calc_mjdsp', 6th argument 'xshfr' value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:341:13: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:478:28: warning:inconclusive: Possible null pointer dereference: mjdsp [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:406:19: note: Assignment 'mjdsp=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:478:28: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:479:28: warning:inconclusive: Possible null pointer dereference: mu [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:403:19: note: Assignment 'mu=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:479:28: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:480:28: warning:inconclusive: Possible null pointer dereference: mtrans [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:412:20: note: Assignment 'mtrans=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:480:28: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:481:17: warning:inconclusive: Possible null pointer dereference: dsp2 [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:407:19: note: Assignment 'dsp2=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:481:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:482:17: warning:inconclusive: Possible null pointer dereference: xshfr [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:381:25: note: Assignment 'xshfr=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:482:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:492:9: warning:inconclusive: Possible null pointer dereference: time [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:385:25: note: Assignment 'time=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:492:9: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:494:13: warning:inconclusive: Possible null pointer dereference: time [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:385:25: note: Assignment 'time=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:494:13: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:498:13: warning:inconclusive: Possible null pointer dereference: time [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:385:25: note: Assignment 'time=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:498:13: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:517:36: warning:inconclusive: Possible null pointer dereference: xp [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:404:19: note: Assignment 'xp=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:517:36: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:523:69: warning:inconclusive: Possible null pointer dereference: mtrans [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:412:20: note: Assignment 'mtrans=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:523:69: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:529:22: warning:inconclusive: Possible null pointer dereference: mu [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:403:19: note: Assignment 'mu=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:529:22: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:611:27: warning:inconclusive: Possible null pointer dereference: mtrans [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:412:20: note: Assignment 'mtrans=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:611:27: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:612:22: warning:inconclusive: Possible null pointer dereference: mu [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:403:19: note: Assignment 'mu=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:612:22: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:612:31: warning:inconclusive: Possible null pointer dereference: mtrans [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:412:20: note: Assignment 'mtrans=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:612:31: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:613:25: warning:inconclusive: Possible null pointer dereference: mu [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:403:19: note: Assignment 'mu=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:613:25: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:615:22: warning:inconclusive: Possible null pointer dereference: mtrans [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:412:20: note: Assignment 'mtrans=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:615:22: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:616:22: warning:inconclusive: Possible null pointer dereference: mu [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:403:19: note: Assignment 'mu=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:616:22: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:620:17: warning:inconclusive: Possible null pointer dereference: time [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:385:25: note: Assignment 'time=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:620:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:621:17: warning:inconclusive: Possible null pointer dereference: mtrans [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:412:20: note: Assignment 'mtrans=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:621:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:622:17: warning:inconclusive: Possible null pointer dereference: mtrans [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:412:20: note: Assignment 'mtrans=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:622:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:623:17: warning:inconclusive: Possible null pointer dereference: mtrans [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:412:20: note: Assignment 'mtrans=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:623:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:628:17: warning:inconclusive: Possible null pointer dereference: time [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:385:25: note: Assignment 'time=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:628:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:629:17: warning:inconclusive: Possible null pointer dereference: mu [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:403:19: note: Assignment 'mu=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:629:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:630:17: warning:inconclusive: Possible null pointer dereference: mu [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:403:19: note: Assignment 'mu=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:630:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:631:17: warning:inconclusive: Possible null pointer dereference: mu [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:403:19: note: Assignment 'mu=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:631:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:762:57: warning:inconclusive: Possible null pointer dereference: time [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:385:25: note: Assignment 'time=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:762:57: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:763:55: warning:inconclusive: Possible null pointer dereference: time [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:385:25: note: Assignment 'time=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:763:55: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:770:28: warning:inconclusive: Possible null pointer dereference: time [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:385:25: note: Assignment 'time=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:770:28: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:771:28: warning:inconclusive: Possible null pointer dereference: dsp2 [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:407:19: note: Assignment 'dsp2=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:771:28: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:104:20: style: The scope of the variable 'k' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:104:23: style: The scope of the variable 'l' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:204:17: style: The scope of the variable 'k' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:204:20: style: The scope of the variable 'l' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_current.cpp:285:10: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_density.cpp:118:13: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxana/gmx_density.cpp:194:18: style: The scope of the variable 'invvol' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_density.cpp:361:18: style: The scope of the variable 'invvol' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_density.cpp:719:17: style: The scope of the variable 'nr_electrons' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densmap.cpp:140:23: style: The scope of the variable 'label' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:405:14: warning:inconclusive: Possible null pointer dereference: int1 [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:397:29: note: Assignment 'int1=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:405:14: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:406:14: warning:inconclusive: Possible null pointer dereference: int2 [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:398:29: note: Assignment 'int2=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:406:14: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:409:18: warning:inconclusive: Possible null pointer dereference: int1 [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:397:29: note: Assignment 'int1=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:409:18: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_dielectric.cpp:79:50: warning: Either the condition 'nbegin==0' is redundant or the array 'x[0]' is accessed at index -1, which is out of bounds. [negativeIndex] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dielectric.cpp:73:35: note: Assuming that condition 'nbegin==0' is not redundant gromacs-2022-rc1/src/gromacs/gmxana/gmx_dielectric.cpp:79:50: note: Negative array index gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:410:18: warning:inconclusive: Possible null pointer dereference: int2 [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:398:29: note: Assignment 'int2=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:410:18: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:411:25: warning:inconclusive: Possible null pointer dereference: int1 [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:397:29: note: Assignment 'int1=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:411:25: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:412:25: warning:inconclusive: Possible null pointer dereference: int2 [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:398:29: note: Assignment 'int2=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:412:25: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:459:21: warning:inconclusive: Possible null pointer dereference: int1 [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:397:29: note: Assignment 'int1=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:459:21: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:460:21: warning:inconclusive: Possible null pointer dereference: int1 [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:397:29: note: Assignment 'int1=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:460:21: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:461:21: warning:inconclusive: Possible null pointer dereference: int2 [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:398:29: note: Assignment 'int2=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:461:21: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:462:21: warning:inconclusive: Possible null pointer dereference: int2 [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:398:29: note: Assignment 'int2=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:462:21: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:543:25: warning:inconclusive: Possible null pointer dereference: fit1 [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:393:26: note: Assignment 'fit1=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:543:25: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:544:25: warning:inconclusive: Possible null pointer dereference: fit2 [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:393:43: note: Assignment 'fit2=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:544:25: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:560:21: warning:inconclusive: Possible null pointer dereference: int1 [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:397:29: note: Assignment 'int1=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:560:21: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:560:53: warning:inconclusive: Possible null pointer dereference: fit1 [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:393:26: note: Assignment 'fit1=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:560:53: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:561:21: warning:inconclusive: Possible null pointer dereference: int1 [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:397:29: note: Assignment 'int1=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:561:21: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:561:53: warning:inconclusive: Possible null pointer dereference: fit1 [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:393:26: note: Assignment 'fit1=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:561:53: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:575:21: warning:inconclusive: Possible null pointer dereference: int2 [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:398:29: note: Assignment 'int2=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:575:21: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:575:53: warning:inconclusive: Possible null pointer dereference: fit2 [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:393:43: note: Assignment 'fit2=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:575:53: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:576:21: warning:inconclusive: Possible null pointer dereference: int2 [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:398:29: note: Assignment 'int2=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:576:21: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:576:53: warning:inconclusive: Possible null pointer dereference: fit2 [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:393:43: note: Assignment 'fit2=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:576:53: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:383:19: style: The scope of the variable 'xvg' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:384:19: style: The scope of the variable 'zDensavg' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:385:25: style: The scope of the variable 'k' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:387:19: style: The scope of the variable 'ndx1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:387:25: style: The scope of the variable 'ndx2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:387:32: style: The scope of the variable 'zperm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_densorder.cpp:390:19: style: The scope of the variable 'sigma1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dielectric.cpp:93:22: style: The scope of the variable 'i0' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dielectric.cpp:93:26: style: The scope of the variable 'i1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_disre.cpp:165:32: style: The scope of the variable 'n' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_disre.cpp:560:59: style: The scope of the variable 'label' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_disre.cpp:753:23: style: The scope of the variable 'leg' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_disre.cpp:716:21: style: Local variable 'ntop' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_disre.cpp:89:12: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_disre.cpp:716:21: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_disre.cpp:810:20: style: Local variable 'top' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_disre.cpp:87:18: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_disre.cpp:810:20: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_do_dssp.cpp:237:9: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxana/gmx_do_dssp.cpp:296:9: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxana/gmx_do_dssp.cpp:284:12: style: The scope of the variable 'n' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_do_dssp.cpp:352:11: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_do_dssp.cpp:352:14: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_do_dssp.cpp:354:11: style: The scope of the variable 'fp' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_do_dssp.cpp:392:11: style: The scope of the variable 'ss_count' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_do_dssp.cpp:530:23: style: The scope of the variable 'tapein' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_do_dssp.cpp:530:32: style: The scope of the variable 'tapeout' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_do_dssp.cpp:531:28: style: The scope of the variable 'acc' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_do_dssp.cpp:533:23: style: The scope of the variable 'leg' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_do_dssp.cpp:404:13: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/gmxana/gmx_do_dssp.cpp:436:15: style: Consider using std::fill algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dos.cpp:138:12: style: The scope of the variable 'fd' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dipoles.cpp:1052:18: style: Condition 'bCont' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dipoles.cpp:918:18: warning:inconclusive: Possible null pointer dereference: muall [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dipoles.cpp:851:35: note: Assignment 'muall=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_dipoles.cpp:918:18: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_dipoles.cpp:925:22: warning:inconclusive: Possible null pointer dereference: muall [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dipoles.cpp:851:35: note: Assignment 'muall=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_dipoles.cpp:925:22: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_dipoles.cpp:143:10: style: The scope of the variable 'cy' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dipoles.cpp:309:12: style: The scope of the variable 'vol' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dipoles.cpp:456:14: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dipoles.cpp:458:14: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dipoles.cpp:490:12: style: The scope of the variable 'mtot' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dipoles.cpp:490:18: style: The scope of the variable 'qtot' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dipoles.cpp:491:25: style: The scope of the variable 'a0' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dipoles.cpp:491:29: style: The scope of the variable 'a1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dipoles.cpp:821:17: style: The scope of the variable 'leg_cosaver' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dipoles.cpp:827:17: style: The scope of the variable 'leg_adip' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dipoles.cpp:830:20: style: The scope of the variable 'outdd' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dipoles.cpp:841:20: style: The scope of the variable 'mode' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dipoles.cpp:846:41: style: The scope of the variable 'invtel' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dipoles.cpp:1532:21: style: The scope of the variable 'm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dipoles.cpp:1065:30: style: Variable 'M4[m]' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dipoles.cpp:1318:19: style: Variable 'M4[m]' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dyecoupl.cpp:202:29: warning: Operator '|' with one operand equal to zero is redundant. [badBitmaskCheck] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dyecoupl.cpp:105:10: style: The scope of the variable 'allocblock' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dyecoupl.cpp:108:10: style: The scope of the variable 'natoms' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dyecoupl.cpp:115:17: style: The scope of the variable 'bin' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dyecoupl.cpp:119:17: style: The scope of the variable 'rkleg' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dyecoupl.cpp:120:17: style: The scope of the variable 'rhleg' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dyecoupl.cpp:121:17: style: The scope of the variable 'khleg' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dyecoupl.cpp:122:17: style: The scope of the variable 'ieleg' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dyecoupl.cpp:126:9: style: The scope of the variable 'rkcount' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dyecoupl.cpp:126:22: style: The scope of the variable 'rblocksallocated' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_dyecoupl.cpp:126:44: style: The scope of the variable 'kblocksallocated' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_enemat.cpp:623:17: style: The if condition is the same as the previous if condition [duplicateCondition] gromacs-2022-rc1/src/gromacs/gmxana/gmx_enemat.cpp:619:17: note: First condition gromacs-2022-rc1/src/gromacs/gmxana/gmx_enemat.cpp:623:17: note: Second condition gromacs-2022-rc1/src/gromacs/gmxana/gmx_enemat.cpp:641:17: style: The if condition is the same as the previous if condition [duplicateCondition] gromacs-2022-rc1/src/gromacs/gmxana/gmx_enemat.cpp:637:17: note: First condition gromacs-2022-rc1/src/gromacs/gmxana/gmx_enemat.cpp:641:17: note: Second condition gromacs-2022-rc1/src/gromacs/gmxana/gmx_enemat.cpp:423:21: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxana/gmx_enemat.cpp:179:23: style: The scope of the variable 'out' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_enemat.cpp:190:39: style: The scope of the variable 'fn' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_enemat.cpp:194:31: style: The scope of the variable 'etot' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_enemat.cpp:195:23: style: The scope of the variable 'beta' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_enemat.cpp:195:29: style: The scope of the variable 'expE' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_enemat.cpp:195:37: style: The scope of the variable 'e' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_enemat.cpp:195:41: style: The scope of the variable 'eaver' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_enemat.cpp:196:23: style: The scope of the variable 'label' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_enemat.cpp:199:23: style: The scope of the variable 'neref' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_filter.cpp:111:53: style: The scope of the variable 'xn' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_gyrate.cpp:77:13: style: The scope of the variable 'ii' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_gyrate.cpp:127:38: style: The scope of the variable 'ii' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_gyrate.cpp:243:23: style: The scope of the variable 'legI' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:1947:14: style: Expression is always true because 'else if' condition is opposite to previous condition at line 1852. [multiCondition] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:1852:9: note: first condition gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:1947:14: note: else if condition is opposite to first condition gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:156:9: warning:inconclusive: Possible null pointer dereference: newnm [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:139:25: note: Assignment 'newnm=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:156:9: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:158:35: warning:inconclusive: Possible null pointer dereference: newnm [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:139:25: note: Assignment 'newnm=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:158:35: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:333:12: style: The scope of the variable 'fac' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:447:27: style: The scope of the variable 'nee' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:448:17: style: The scope of the variable 'sum' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:448:22: style: The scope of the variable 'sum2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:448:34: style: The scope of the variable 'see2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:449:17: style: The scope of the variable 'np' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:453:20: style: The scope of the variable 'sx' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:453:24: style: The scope of the variable 'sy' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:453:28: style: The scope of the variable 'sxx' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:453:33: style: The scope of the variable 'sxy' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:630:17: style: The scope of the variable 'sum' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:727:15: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:728:16: style: The scope of the variable 'v' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:728:19: style: The scope of the variable 'h' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:728:69: style: The scope of the variable 'varet' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:900:11: style: The scope of the variable 'fp' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:902:17: style: The scope of the variable 'Dt' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:902:21: style: The scope of the variable 'aver' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:902:27: style: The scope of the variable 'stddev' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:902:35: style: The scope of the variable 'errest' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:902:43: style: The scope of the variable 'delta_t' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:902:52: style: The scope of the variable 'totaldrift' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:906:17: style: The scope of the variable 'beta' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:906:27: style: The scope of the variable 'expE' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:906:33: style: The scope of the variable 'expEtot' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:908:17: style: The scope of the variable 'nexact' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:908:25: style: The scope of the variable 'nnotexact' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:909:17: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:909:20: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:909:23: style: The scope of the variable 'nout' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:910:27: style: The scope of the variable 'eebuf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:1285:18: style: The scope of the variable 'ravgleg' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:1414:17: style: The scope of the variable 'dhdl' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:1415:17: style: The scope of the variable 'title' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:1415:32: style: The scope of the variable 'label_x' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:1415:49: style: The scope of the variable 'label_y' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:1416:17: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:1418:23: style: The scope of the variable 'k' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:1421:18: style: The scope of the variable 'setnr' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:1530:25: style: The scope of the variable 'x0' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:1788:24: style: The scope of the variable 'setnm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:1809:45: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:1812:23: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:1116:25: style: Local variable 'leg' shadows outer argument [shadowArgument] gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:892:50: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_energy.cpp:1116:25: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_hydorder.cpp:325:30: warning:inconclusive: Possible null pointer dereference: index [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hydorder.cpp:290:28: note: Assignment 'index=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_hydorder.cpp:325:30: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_hydorder.cpp:78:17: style: The scope of the variable 'ix' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_lie.cpp:165:41: style: The scope of the variable 'ct' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_lie.cpp:165:44: style: Variable 'ct' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_make_edi.cpp:545:12: style: The scope of the variable 'f0' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_make_edi.cpp:545:21: style: The scope of the variable 'f1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_make_edi.cpp:547:12: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_make_edi.cpp:83:11: style: struct member 'edix::sqrtm' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/gmxana/gmx_mdmat.cpp:208:32: style: The scope of the variable 'fp' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_mindist.cpp:351:23: warning: Invalid std::sqrt() argument nr 1. The value is -1e+12 but the valid values are '0.0:'. [invalidFunctionArg] gromacs-2022-rc1/src/gromacs/gmxana/gmx_mindist.cpp:286:14: note: Assignment 'rmax2=-1e12', assigned value is -1e+12.0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_mindist.cpp:288:20: note: Assuming condition is false gromacs-2022-rc1/src/gromacs/gmxana/gmx_mindist.cpp:351:23: note: Invalid argument gromacs-2022-rc1/src/gromacs/gmxana/gmx_mindist.cpp:251:15: style: The scope of the variable 'jx' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_mindist.cpp:256:11: style: The scope of the variable 'nmin_j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_mindist.cpp:256:19: style: The scope of the variable 'nmax_j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_mindist.cpp:723:20: style: The scope of the variable 'resnr' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_mindist.cpp:826:17: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_mindist.cpp:713:14: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_mindist.cpp:385:18: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_mindist.cpp:713:14: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_mindist.cpp:973:14: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_mindist.cpp:826:17: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_mindist.cpp:973:14: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_mindist.cpp:751:48: style: Parameter 'resindex' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmeig.cpp:105:19: style: The scope of the variable 'ft' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmeig.cpp:195:12: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmeig.cpp:196:12: style: The scope of the variable 'row' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmeig.cpp:196:17: style: The scope of the variable 'col' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmeig.cpp:198:12: style: The scope of the variable 'katom' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmeig.cpp:513:31: style: The scope of the variable 'k' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmeig.cpp:520:25: style: The scope of the variable 'qcleg' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmens.cpp:181:18: warning:inconclusive: Possible null pointer dereference: iout [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmens.cpp:171:16: note: Assignment 'iout=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmens.cpp:181:18: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2791:13: style: The if condition is the same as the previous if condition [duplicateCondition] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2777:13: note: First condition gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2791:13: note: Second condition gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:735:14: style: Condition 'datable' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2043:16: style: Condition 'acType!=AC_NN' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2029:14: note: Assignment 'acType=AC_LUZAR', assigned value is 3 gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2043:16: note: Condition 'acType!=AC_NN' is always true gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2115:29: style: Condition 'bContact' is always false [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2102:31: note: Assuming that condition 'bContact' is not redundant gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2115:29: note: Condition 'bContact' is always false gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:1804:21: style: Variable 'tl.ndelta' is reassigned a value before the old one has been used. [redundantAssignment] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:1790:17: note: tl.ndelta is assigned gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:1804:21: note: tl.ndelta is overwritten gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:303:17: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:303:20: style: The scope of the variable 'n' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:424:25: style: The scope of the variable 'hh' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:614:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:646:12: style: The scope of the variable 'n' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:699:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:750:19: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:752:16: style: The scope of the variable 'nr1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:752:21: style: The scope of the variable 'nr2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:752:26: style: The scope of the variable 'nr3' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:1295:17: style: The scope of the variable 'hh' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:1470:36: style: The scope of the variable 'ii' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:1470:44: style: The scope of the variable 'id' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:1830:18: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:1833:14: style: The scope of the variable 'tmp' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:1833:19: style: The scope of the variable 'sn2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:1833:37: style: The scope of the variable 'sk2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2335:14: style: The scope of the variable 'ddd' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2647:23: style: The scope of the variable 'trrStatus' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2658:40: style: The scope of the variable 'k' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2658:47: style: The scope of the variable 'ogrp' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2659:23: style: The scope of the variable 'xi' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2659:31: style: The scope of the variable 'yi' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2659:35: style: The scope of the variable 'zi' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2659:39: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2660:23: style: The scope of the variable 'xj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2660:27: style: The scope of the variable 'yj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2660:31: style: The scope of the variable 'zj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2660:35: style: The scope of the variable 'aj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2660:39: style: The scope of the variable 'xjj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2660:44: style: The scope of the variable 'yjj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2660:49: style: The scope of the variable 'zjj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2663:23: style: The scope of the variable 'grp' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2663:42: style: The scope of the variable 'resdist' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2663:51: style: The scope of the variable 'ihb' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2672:23: style: The scope of the variable 'ii' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2673:23: style: The scope of the variable 'threadNr' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:3513:22: style: The scope of the variable 'id' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:3513:26: style: The scope of the variable 'ia' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:3513:30: style: The scope of the variable 'hh' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:3513:34: style: The scope of the variable 'x' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:3513:37: style: The scope of the variable 'y' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2652:23: style: Local variable 'grpnames' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:113:20: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2652:23: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2714:21: style: Local variable 'leg' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2664:23: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2714:21: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:3513:30: style: Local variable 'hh' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2672:27: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:3513:30: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:3513:34: style: Local variable 'x' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2654:23: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:3513:34: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:3561:25: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2658:30: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:3561:25: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:3585:16: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2658:30: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:3585:16: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:3585:19: style: Local variable 'j' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2658:37: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:3585:19: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2279:67: style: Parameter 'hb' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2642:17: style: Variable 'hbmap' can be declared as const array [constVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2644:17: style: Variable 'hbrgb' can be declared as const array [constVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:3525:27: style: Consider using std::fill algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:913:29: warning:inconclusive: Division of result of sizeof() on pointer type. [divideSizeof] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:1788:17: style: Variable 'tl.n1' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:1789:17: style: Variable 'tl.nparams' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:1791:17: style: Variable 'tl.t' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:1792:17: style: Variable 'tl.ct' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:1793:17: style: Variable 'tl.nt' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:1794:17: style: Variable 'tl.kt' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:1795:17: style: Variable 'tl.sigma_ct' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:1796:17: style: Variable 'tl.sigma_nt' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:1797:17: style: Variable 'tl.sigma_kt' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:1804:21: style: Variable 'tl.ndelta' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmr.cpp:525:26: warning:inconclusive: Possible null pointer dereference: orsel [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmr.cpp:516:25: note: Assignment 'orsel=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmr.cpp:525:26: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmr.cpp:110:18: style: The scope of the variable 'k' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmr.cpp:110:21: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmr.cpp:203:20: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmr.cpp:203:33: style: The scope of the variable 'natom' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmr.cpp:275:16: style: The scope of the variable 'rsum' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmr.cpp:275:22: style: The scope of the variable 'rav' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmr.cpp:423:28: style: The scope of the variable 'odtleg' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmr.cpp:423:38: style: The scope of the variable 'otenleg' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmr.cpp:428:17: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmr.cpp:225:21: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmr.cpp:203:11: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmr.cpp:225:21: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmr.cpp:271:73: style: Parameter 'bounds' can be declared as const array [constParameter] gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmtraj.cpp:140:16: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmtraj.cpp:148:16: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/gmxana/gmx_polystat.cpp:95:15: style: The scope of the variable 'd' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_polystat.cpp:160:23: style: The scope of the variable 'sum_eed2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_polystat.cpp:160:47: style: The scope of the variable 'sum_gyro' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_polystat.cpp:163:29: style: The scope of the variable 'ymax' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_polystat.cpp:163:35: style: The scope of the variable 'ymin' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_polystat.cpp:170:23: style: The scope of the variable 'legp' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_polystat.cpp:170:29: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_potential.cpp:81:12: style: The scope of the variable 'sum' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_order.cpp:94:11: style: The scope of the variable 'ix' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_order.cpp:1026:12: style: The scope of the variable 'ngrps' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_order.cpp:1027:13: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_order.cpp:1028:17: style: The scope of the variable 'top' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_order.cpp:1031:14: style: The scope of the variable 'a' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsdist.cpp:199:13: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsdist.cpp:204:20: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsdist.cpp:197:9: warning:inconclusive: Possible null pointer dereference: equiv [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsdist.cpp:191:13: note: Assignment 'equiv=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsdist.cpp:197:9: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsdist.cpp:99:11: style: The scope of the variable 'xi' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsdist.cpp:185:57: style: The scope of the variable 'lp' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsdist.cpp:186:20: style: The scope of the variable 'na' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsdist.cpp:296:18: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsdist.cpp:296:21: style: The scope of the variable 'anmil' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsdist.cpp:296:28: style: The scope of the variable 'anmjl' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsdist.cpp:296:41: style: The scope of the variable 'rnrj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsdist.cpp:296:47: style: The scope of the variable 'gi' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsdist.cpp:296:60: style: The scope of the variable 'neq' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsdist.cpp:297:15: style: The scope of the variable 'anmi' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsdist.cpp:297:22: style: The scope of the variable 'anmj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsdist.cpp:493:15: style: The scope of the variable 'gi' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsdist.cpp:728:26: style: The scope of the variable 'noe_index' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsdist.cpp:520:65: style: Parameter 'noe_gr' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsf.cpp:132:56: warning:inconclusive: Possible null pointer dereference: U [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsf.cpp:538:36: note: Calling function 'average_residues', 2nd argument 'nullptr' value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsf.cpp:132:56: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsf.cpp:254:17: style: The scope of the variable 'resind' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsf.cpp:273:17: style: The scope of the variable 'leg' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rotacf.cpp:98:19: style: The scope of the variable 'mode' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_saltbr.cpp:176:9: warning:inconclusive: Possible null pointer dereference: time [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_saltbr.cpp:172:14: note: Assignment 'time=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_saltbr.cpp:176:9: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_saltbr.cpp:131:24: style: The scope of the variable 'out' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_saltbr.cpp:131:33: style: The scope of the variable 'fp' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_saltbr.cpp:132:24: style: The scope of the variable 'title' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_saltbr.cpp:135:24: style: The scope of the variable 'fn' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_saltbr.cpp:136:24: style: The scope of the variable 'nset' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_saltbr.cpp:142:27: style: The scope of the variable 'm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_saltbr.cpp:142:30: style: The scope of the variable 'nnn' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_sham.cpp:76:16: style: The scope of the variable 'dd' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_sham.cpp:470:61: style: The scope of the variable 'bi' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rms.cpp:166:17: style: The scope of the variable 'whatlabel' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rms.cpp:180:21: style: The scope of the variable 'fitgraphlabel' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rms.cpp:203:21: style: The scope of the variable 'natoms_trx2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rms.cpp:204:18: style: The scope of the variable 'm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rms.cpp:206:35: style: The scope of the variable 'maxframe2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rms.cpp:218:18: style: The scope of the variable 'ncons' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rms.cpp:221:62: style: The scope of the variable 'axis2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rms.cpp:221:70: style: The scope of the variable 'del_xaxis' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rms.cpp:221:82: style: The scope of the variable 'del_yaxis' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rms.cpp:224:79: style: The scope of the variable 'delta_tot' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rms.cpp:225:14: style: The scope of the variable 'delta_xsize' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rms.cpp:225:31: style: The scope of the variable 'del_lev' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rms.cpp:225:46: style: The scope of the variable 'mx' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rms.cpp:225:50: style: The scope of the variable 'my' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rms.cpp:225:54: style: The scope of the variable 'abs_my' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rms.cpp:699:9: style: The scope of the variable 'teller2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rms.cpp:700:9: style: The scope of the variable 'frame2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rms.cpp:218:24: style: Variable 'ncons' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_rms.cpp:700:18: style: Variable 'frame2' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_sorient.cpp:64:26: style: The scope of the variable 'iter' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_sorient.cpp:126:38: style: The scope of the variable 'n' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_spatial.cpp:172:23: style: The scope of the variable 'v' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_spol.cpp:66:26: style: The scope of the variable 'iter' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_spol.cpp:119:21: style: The scope of the variable 'm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_tcaf.cpp:148:18: warning:inconclusive: Possible null pointer dereference: tcafc [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_tcaf.cpp:109:28: note: Assignment 'tcafc=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_tcaf.cpp:148:18: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_tcaf.cpp:190:21: warning:inconclusive: Possible null pointer dereference: tcafc [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_tcaf.cpp:109:28: note: Assignment 'tcafc=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_tcaf.cpp:190:21: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_tcaf.cpp:220:17: warning:inconclusive: Possible null pointer dereference: tcafc [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_tcaf.cpp:109:28: note: Assignment 'tcafc=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_tcaf.cpp:220:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_tcaf.cpp:221:52: warning:inconclusive: Possible null pointer dereference: tcafc [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_tcaf.cpp:109:28: note: Assignment 'tcafc=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_tcaf.cpp:221:52: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_tcaf.cpp:224:13: warning:inconclusive: Possible null pointer dereference: tcafc [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_tcaf.cpp:109:28: note: Assignment 'tcafc=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_tcaf.cpp:224:13: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_vanhove.cpp:206:9: warning:inconclusive: Possible null pointer dereference: time [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_vanhove.cpp:187:14: note: Assignment 'time=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_vanhove.cpp:206:9: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_vanhove.cpp:207:23: warning:inconclusive: Possible null pointer dereference: sbox [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_vanhove.cpp:188:14: note: Assignment 'sbox=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_vanhove.cpp:207:23: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_vanhove.cpp:212:14: warning:inconclusive: Possible null pointer dereference: sx [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_vanhove.cpp:189:14: note: Assignment 'sx=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_vanhove.cpp:212:14: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_vanhove.cpp:215:36: warning:inconclusive: Possible null pointer dereference: sx [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_vanhove.cpp:189:14: note: Assignment 'sx=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_vanhove.cpp:215:36: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_vanhove.cpp:227:11: warning:inconclusive: Possible null pointer dereference: time [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_vanhove.cpp:187:14: note: Assignment 'time=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_vanhove.cpp:227:11: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_vanhove.cpp:146:58: style: The scope of the variable 'tickx' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_vanhove.cpp:146:66: style: The scope of the variable 'ticky' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_vanhove.cpp:147:38: style: The scope of the variable 'legend' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_velacc.cpp:104:16: style: The scope of the variable 'k' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_velacc.cpp:104:19: style: The scope of the variable 'l' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_velacc.cpp:215:42: style: The scope of the variable 'counter_dim' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_traj.cpp:848:23: warning: Operator '|' with one operand equal to zero is redundant. [badBitmaskCheck] gromacs-2022-rc1/src/gromacs/gmxana/gmx_traj.cpp:107:22: style: The scope of the variable 'mtot' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_traj.cpp:164:35: style: The scope of the variable 'xav' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_traj.cpp:189:35: style: The scope of the variable 'xav' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_traj.cpp:193:21: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_traj.cpp:365:15: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_traj.cpp:385:15: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_traj.cpp:444:11: style: The scope of the variable 'fp' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_traj.cpp:446:11: style: The scope of the variable 'maxi' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_traj.cpp:447:11: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_traj.cpp:447:14: style: The scope of the variable 'm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_traj.cpp:447:17: style: The scope of the variable 'onedim' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_traj.cpp:567:16: style: The scope of the variable 'in' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_traj.cpp:695:21: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_traj.cpp:705:18: style: The scope of the variable 'box_leg' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_traj.cpp:1204:18: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_traj.cpp:695:18: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_traj.cpp:1204:18: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_traj.cpp:1211:14: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_traj.cpp:695:18: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/gmx_traj.cpp:1211:14: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_traj.cpp:229:49: style: Parameter 'index' can be declared as const array [constParameter] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wheel.cpp:85:18: style: The scope of the variable 'sl' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wheel.cpp:90:15: style: The scope of the variable 'sign' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_xpm2ps.cpp:1188:12: style: The scope of the variable 'rmat1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_xpm2ps.cpp:1188:21: style: The scope of the variable 'rmat2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_xpm2ps.cpp:1360:16: style: Variable 'm' can be declared as reference to const [constVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_xpm2ps.cpp:1412:16: style: Variable 'm' can be declared as reference to const [constVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_xpm2ps.cpp:751:10: style: Variable 'major_fact' can be declared as const array [constVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_xpm2ps.cpp:752:10: style: Variable 'minor_fact' can be declared as const array [constVariable] gromacs-2022-rc1/src/gromacs/gmxana/gmx_xpm2ps.cpp:804:22: style: Unused variable: psr [unusedVariable] gromacs-2022-rc1/src/gromacs/gmxana/hxprops.cpp:113:13: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/hxprops.cpp:155:17: style: The scope of the variable 'a1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/hxprops.cpp:179:13: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/hxprops.cpp:179:17: style: The scope of the variable 'aj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/hxprops.cpp:179:21: style: The scope of the variable 'ak' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/hxprops.cpp:179:25: style: The scope of the variable 'al' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/hxprops.cpp:204:16: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/hxprops.cpp:475:13: style: The scope of the variable 'ao' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/nrama.cpp:78:17: style: The scope of the variable 'dd' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/nrama.cpp:160:12: style: The scope of the variable 'found' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/nrama.cpp:212:17: style: The scope of the variable 'ft' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/nrama.cpp:212:21: style: The scope of the variable 'ftype' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/nrama.cpp:212:28: style: The scope of the variable 'nra' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/nrama.cpp:214:14: style: The scope of the variable 'dd' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:124:13: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:160:10: warning:inconclusive: Possible null pointer dereference: gsans [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:156:25: note: Assignment 'gsans=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:160:10: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:162:5: warning:inconclusive: Possible null pointer dereference: gsans [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:156:25: note: Assignment 'gsans=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:162:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:219:5: warning:inconclusive: Possible null pointer dereference: pr [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:203:47: note: Assignment 'pr=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:219:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:230:5: warning:inconclusive: Possible null pointer dereference: pr [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:203:47: note: Assignment 'pr=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:230:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:232:10: warning:inconclusive: Possible null pointer dereference: pr [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:203:47: note: Assignment 'pr=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:232:10: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:351:17: warning:inconclusive: Possible null pointer dereference: pr [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:203:47: note: Assignment 'pr=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:351:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:361:31: warning:inconclusive: Possible null pointer dereference: pr [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:203:47: note: Assignment 'pr=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:361:31: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:364:10: warning:inconclusive: Possible null pointer dereference: pr [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:203:47: note: Assignment 'pr=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:364:10: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:365:21: warning:inconclusive: Possible null pointer dereference: pr [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:203:47: note: Assignment 'pr=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:365:21: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/powerspect.cpp:59:28: style:inconclusive: Function 'powerspectavg' argument 1 names different: declaration 'interface' definition 'intftab'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxana/powerspect.h:52:35: note: Function 'powerspectavg' argument 1 names different: declaration 'interface' definition 'intftab'. gromacs-2022-rc1/src/gromacs/gmxana/powerspect.cpp:59:28: note: Function 'powerspectavg' argument 1 names different: declaration 'interface' definition 'intftab'. gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:367:9: warning:inconclusive: Possible null pointer dereference: pr [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:203:47: note: Assignment 'pr=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:367:9: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/powerspect.cpp:59:41: style:inconclusive: Function 'powerspectavg' argument 2 names different: declaration 't' definition 'tsteps'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxana/powerspect.h:52:50: note: Function 'powerspectavg' argument 2 names different: declaration 't' definition 'tsteps'. gromacs-2022-rc1/src/gromacs/gmxana/powerspect.cpp:59:41: note: Function 'powerspectavg' argument 2 names different: declaration 't' definition 'tsteps'. gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:382:5: warning:inconclusive: Possible null pointer dereference: sq [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:378:40: note: Assignment 'sq=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:382:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/powerspect.cpp:119:70: style:inconclusive: Function 'powerspectavg_intf' argument 4 names different: declaration 'xbins' definition 'xb'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxana/powerspect.h:57:65: note: Function 'powerspectavg_intf' argument 4 names different: declaration 'xbins' definition 'xb'. gromacs-2022-rc1/src/gromacs/gmxana/powerspect.cpp:119:70: note: Function 'powerspectavg_intf' argument 4 names different: declaration 'xbins' definition 'xb'. gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:383:10: warning:inconclusive: Possible null pointer dereference: sq [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:378:40: note: Assignment 'sq=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:383:10: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/powerspect.cpp:119:78: style:inconclusive: Function 'powerspectavg_intf' argument 5 names different: declaration 'ybins' definition 'yb'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxana/powerspect.h:58:65: note: Function 'powerspectavg_intf' argument 5 names different: declaration 'ybins' definition 'yb'. gromacs-2022-rc1/src/gromacs/gmxana/powerspect.cpp:119:78: note: Function 'powerspectavg_intf' argument 5 names different: declaration 'ybins' definition 'yb'. gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:783:32: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:779:24: note: outer condition: maxloc>maxglob gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:783:32: note: identical inner condition: maxloc>maxglob gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:384:10: warning:inconclusive: Possible null pointer dereference: sq [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:378:40: note: Assignment 'sq=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:384:10: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/powerspect.cpp:119:115: performance:inconclusive: Function parameter 'outfiles' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:385:21: warning:inconclusive: Possible null pointer dereference: sq [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:378:40: note: Assignment 'sq=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:385:21: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:387:9: warning:inconclusive: Possible null pointer dereference: sq [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:378:40: note: Assignment 'sq=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:387:9: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:105:44: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:213:30: style: The scope of the variable 'mc_max' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:291:42: style: Local variable 'dist' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:204:42: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxana/nsfactor.cpp:291:42: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:444:15: warning:inconclusive: Possible null pointer dereference: ptr [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:2781:36: note: Assignment 'tmpbuf=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:2791:30: note: Calling function 'fgets3', 2nd argument 'tmpbuf' value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:444:15: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:1523:22: warning:inconclusive: Possible null pointer dereference: filename [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:1504:23: note: Assignment 'filename=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:1523:22: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:1531:21: warning:inconclusive: Possible null pointer dereference: filename [nullPointer] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:1504:23: note: Assignment 'filename=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:1531:21: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:536:25: style: The scope of the variable 'nGrptot' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:725:24: style: The scope of the variable 'total' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:799:16: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:800:66: style: The scope of the variable 'zsym' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:801:13: style: The scope of the variable 'z' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:838:21: style: The scope of the variable 'imin' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:908:16: style: The scope of the variable 'blockBase' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:1027:13: style: The scope of the variable 'jm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:1064:12: style: The scope of the variable 'r' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:1289:67: style: The scope of the variable 'maxchange' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:1289:90: style: The scope of the variable 'stddev' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:1740:44: style: The scope of the variable 't' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:2320:18: style: The scope of the variable 'ncorr' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:2320:25: style: The scope of the variable 'ntot' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:2320:45: style: The scope of the variable 'restart' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:2498:17: style: The scope of the variable 'ntot' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:2611:10: style: The scope of the variable 'bBoundary' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:2656:40: style: The scope of the variable 'nHist' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:2656:47: style: The scope of the variable 'winmin' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:2656:55: style: The scope of the variable 'groupmin' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:2657:38: style: The scope of the variable 'pos' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:2657:57: style: The scope of the variable 'diff' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:2657:63: style: The scope of the variable 'fAv' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:2657:68: style: The scope of the variable 'distmin' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:2658:12: style: The scope of the variable 'fp' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:2780:21: style: The scope of the variable 'n' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/gmx_wham.cpp:3010:17: style: The scope of the variable 'en_unit_label' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/princ.cpp:100:20: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/princ.cpp:211:13: style: The scope of the variable 'ii' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/princ.cpp:227:13: style: The scope of the variable 'ii' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/princ.cpp:266:13: style: The scope of the variable 'ii' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/princ.cpp:280:12: style: The scope of the variable 'ii' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/princ.cpp:291:15: style: The scope of the variable 'm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/tests/entropy.cpp:94:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/gmxana/tests/gmx_chi.cpp:144:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/gmxana/tests/gmx_make_ndx.cpp:75:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/gmxana/tests/gmx_traj.cpp:79:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/gmxana/tests/gmx_mindist.cpp:99:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/gmxana/sfactor.cpp:299:13: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxana/sfactor.cpp:281:27: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/sfactor.cpp:381:16: style: The scope of the variable 'nrc' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/sfactor.cpp:382:16: style: The scope of the variable 'fndx' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/sfactor.cpp:622:12: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/sfactor.cpp:623:23: style: The scope of the variable 'k2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxana/sfactor.cpp:89:14: style: struct member 'structure_factor::n_groups' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/gmxana/thermochemistry.cpp:169:94: style:inconclusive: Function 'calcQuasiHarmonicEntropy' argument 3 names different: declaration 'linear' definition 'bLinear'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxana/thermochemistry.h:147:94: note: Function 'calcQuasiHarmonicEntropy' argument 3 names different: declaration 'linear' definition 'bLinear'. gromacs-2022-rc1/src/gromacs/gmxana/thermochemistry.cpp:169:94: note: Function 'calcQuasiHarmonicEntropy' argument 3 names different: declaration 'linear' definition 'bLinear'. gromacs-2022-rc1/src/gromacs/gmxana/thermochemistry.cpp:201:90: style:inconclusive: Function 'calcSchlitterEntropy' argument 3 names different: declaration 'linear' definition 'bLinear'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxana/thermochemistry.h:132:90: note: Function 'calcSchlitterEntropy' argument 3 names different: declaration 'linear' definition 'bLinear'. gromacs-2022-rc1/src/gromacs/gmxana/thermochemistry.cpp:201:90: note: Function 'calcSchlitterEntropy' argument 3 names different: declaration 'linear' definition 'bLinear'. gromacs-2022-rc1/src/gromacs/gmxlib/nonbonded/tests/nb_free_energy.cpp:499:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/gmxlib/nrnb.cpp:293:17: style: The scope of the variable 'mni' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxlib/nrnb.cpp:410:12: style: The scope of the variable 'wallclocktime' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxlib/nrnb.cpp:403:25: style:inconclusive: Function 'print_perf' argument 2 names different: declaration 'nodetime' definition 'time_per_thread'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxlib/nrnb.h:209:35: note: Function 'print_perf' argument 2 names different: declaration 'nodetime' definition 'time_per_thread'. gromacs-2022-rc1/src/gromacs/gmxlib/nrnb.cpp:403:25: note: Function 'print_perf' argument 2 names different: declaration 'nodetime' definition 'time_per_thread'. gromacs-2022-rc1/src/gromacs/gmxlib/nrnb.cpp:404:25: style:inconclusive: Function 'print_perf' argument 3 names different: declaration 'realtime' definition 'time_per_node'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxlib/nrnb.h:209:52: note: Function 'print_perf' argument 3 names different: declaration 'realtime' definition 'time_per_node'. gromacs-2022-rc1/src/gromacs/gmxlib/nrnb.cpp:404:25: note: Function 'print_perf' argument 3 names different: declaration 'realtime' definition 'time_per_node'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/add_par.cpp:105:82: style:inconclusive: Function 'search_jtype' argument 3 names different: declaration 'bFirstRes' definition 'bNterm'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/add_par.h:64:82: note: Function 'search_jtype' argument 3 names different: declaration 'bFirstRes' definition 'bNterm'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/add_par.cpp:105:82: note: Function 'search_jtype' argument 3 names different: declaration 'bFirstRes' definition 'bNterm'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/convparm.cpp:451:51: performance:inconclusive: Function parameter 'forceparams' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxlib/nonbonded/nb_free_energy.cpp:763:42: style: Local variable 'divisor' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxlib/nonbonded/nb_free_energy.cpp:757:38: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxlib/nonbonded/nb_free_energy.cpp:763:42: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxlib/nonbonded/nb_free_energy.cpp:74:26: style: struct member 'ScalarDataTypes::simdRealWidth' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/gmxlib/nonbonded/nb_free_energy.cpp:75:26: style: struct member 'ScalarDataTypes::simdIntWidth' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_ad.cpp:348:9: style: The scope of the variable 'start' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_ad.cpp:392:10: style: The scope of the variable 'a' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_ad.cpp:506:14: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_ad.cpp:506:17: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_ad.cpp:506:20: style: The scope of the variable 'j1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_ad.cpp:506:24: style: The scope of the variable 'k' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_ad.cpp:506:27: style: The scope of the variable 'k1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_ad.cpp:506:31: style: The scope of the variable 'l' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_ad.cpp:506:34: style: The scope of the variable 'l1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_ad.cpp:506:38: style: The scope of the variable 'e' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_ad.cpp:507:14: style: The scope of the variable 'excl' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_ad.cpp:690:50: style: The scope of the variable 'name' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_ad.cpp:587:53: style:inconclusive: Function 'gen_pad' argument 7 names different: declaration 'circ_bonds' definition 'cyclicBondsIndex'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_ad.h:59:53: note: Function 'gen_pad' argument 7 names different: declaration 'circ_bonds' definition 'cyclicBondsIndex'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_ad.cpp:587:53: note: Function 'gen_pad' argument 7 names different: declaration 'circ_bonds' definition 'cyclicBondsIndex'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_ad.cpp:738:54: style: Local variable 'atoms' shadows outer argument [shadowArgument] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_ad.cpp:581:53: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_ad.cpp:738:54: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_ad.cpp:757:62: style: Local variable 'atoms' shadows outer argument [shadowArgument] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_ad.cpp:581:53: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_ad.cpp:757:62: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_ad.cpp:250:26: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_ad.cpp:335:24: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/gmxpreprocess/editconf.cpp:97:10: style: The scope of the variable 'ii' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/editconf.cpp:97:14: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/editconf.cpp:97:17: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/editconf.cpp:221:17: style: The scope of the variable 'n' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/editconf.cpp:380:11: style: The scope of the variable 'edge' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/editconf.cpp:382:29: style: The scope of the variable 'nat' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/editconf.cpp:383:14: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/editconf.cpp:384:11: style: The scope of the variable 'rectedge' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/editconf.cpp:535:25: style: The scope of the variable 'resind' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/editconf.cpp:733:59: style: The scope of the variable 'itype' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/editconf.cpp:733:66: style: The scope of the variable 'ntype' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/editconf.cpp:734:42: style: The scope of the variable 'c6' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/editconf.cpp:734:46: style: The scope of the variable 'c12' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/editconf.cpp:987:15: style: Local variable 'index' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/editconf.cpp:739:23: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/editconf.cpp:987:15: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/editconf.cpp:1361:18: style: Local variable 'index' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/editconf.cpp:739:23: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/editconf.cpp:1361:18: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/editconf.cpp:1363:22: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/editconf.cpp:733:45: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/editconf.cpp:1363:22: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/editconf.cpp:384:11: style: Variable 'rectedge' can be declared as const array [constVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genhydro.cpp:599:55: style:inconclusive: Function 'add_h' argument 11 names different: declaration 'bMissing' definition 'bAllowMissing'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genhydro.h:82:55: note: Function 'add_h' argument 11 names different: declaration 'bMissing' definition 'bAllowMissing'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/genhydro.cpp:599:55: note: Function 'add_h' argument 11 names different: declaration 'bMissing' definition 'bAllowMissing'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/genhydro.cpp:173:53: performance: Function parameter 'localAtomName' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genhydro.cpp:306:74: performance:inconclusive: Function parameter 'cyclicBondsIndex' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genhydro.cpp:358:68: performance:inconclusive: Function parameter 'cyclicBondsIndex' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genhydro.cpp:449:66: performance:inconclusive: Function parameter 'globalPatches' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genhydro.cpp:452:66: performance:inconclusive: Function parameter 'ntdb' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genhydro.cpp:453:66: performance:inconclusive: Function parameter 'ctdb' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genhydro.cpp:454:66: performance:inconclusive: Function parameter 'rN' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genhydro.cpp:455:66: performance:inconclusive: Function parameter 'rC' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genhydro.cpp:457:66: performance:inconclusive: Function parameter 'cyclicBondsIndex' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genhydro.cpp:592:55: performance:inconclusive: Function parameter 'globalPatches' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genhydro.cpp:595:55: performance:inconclusive: Function parameter 'ntdb' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genhydro.cpp:596:55: performance:inconclusive: Function parameter 'ctdb' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genhydro.cpp:597:55: performance:inconclusive: Function parameter 'rN' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genhydro.cpp:598:55: performance:inconclusive: Function parameter 'rC' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genhydro.cpp:600:55: performance:inconclusive: Function parameter 'cyclicBondsIndex' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genion.cpp:231:20: style: Condition 'r<0' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genion.cpp:220:15: note: Assuming that condition 'r==0' is not redundant gromacs-2022-rc1/src/gromacs/gmxpreprocess/genion.cpp:231:20: note: Condition 'r<0' is always true gromacs-2022-rc1/src/gromacs/gmxpreprocess/genion.cpp:338:13: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genion.cpp:208:31: style: The scope of the variable 'starta' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genion.cpp:208:39: style: The scope of the variable 'startr' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genion.cpp:208:47: style: The scope of the variable 'npi' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genion.cpp:208:52: style: The scope of the variable 'nni' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genion.cpp:290:42: style: The scope of the variable 'temp' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genion.cpp:495:23: style: The scope of the variable 'repl' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genion.cpp:497:23: style: The scope of the variable 'nw' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genion.cpp:497:27: style: The scope of the variable 'nsa' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genion.cpp:497:32: style: The scope of the variable 'nsalt' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genion.cpp:160:49: warning:inconclusive: Either the condition 'solventMoleculesForReplacement->empty()' is redundant or expression 'solventMoleculesForReplacement->back()' cause access out of bounds. [containerOutOfBounds] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genion.cpp:145:57: note: Assuming that condition 'solventMoleculesForReplacement->empty()' is not redundant gromacs-2022-rc1/src/gromacs/gmxpreprocess/genion.cpp:160:49: note: Access out of bounds gromacs-2022-rc1/src/gromacs/gmxpreprocess/genion.cpp:166:46: warning:inconclusive: Either the condition 'solventMoleculesForReplacement->empty()' is redundant or expression 'solventMoleculesForReplacement->back()' cause access out of bounds. [containerOutOfBounds] gromacs-2022-rc1/src/gromacs/gmxpreprocess/genion.cpp:145:57: note: Assuming that condition 'solventMoleculesForReplacement->empty()' is not redundant gromacs-2022-rc1/src/gromacs/gmxpreprocess/genion.cpp:166:46: note: Access out of bounds gromacs-2022-rc1/src/gromacs/gmxpreprocess/gmxcpp.cpp:106:13: style: Condition 'ptr' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gmxcpp.cpp:758:14: style: Condition 'handle' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gmxcpp.cpp:243:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gmxcpp.cpp:551:15: style: The scope of the variable 'status' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gmxcpp.cpp:345:50: style:inconclusive: Function 'cpp_open_file' argument 2 names different: declaration 'handlep' definition 'handle'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gmxcpp.h:64:50: note: Function 'cpp_open_file' argument 2 names different: declaration 'handlep' definition 'handle'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/gmxcpp.cpp:345:50: note: Function 'cpp_open_file' argument 2 names different: declaration 'handlep' definition 'handle'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/gmxcpp.cpp:648:29: style: Local variable 'ptr' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gmxcpp.cpp:631:25: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/gmxcpp.cpp:648:29: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/gmxcpp.cpp:216:69: style: Parameter 'definesFromParent' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gmxcpp.cpp:217:69: style: Parameter 'includesFromParent' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gmxcpp.cpp:202:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gmxcpp.cpp:377:17: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gmxcpp.cpp:709:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gmxcpp.cpp:775:21: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gpp_atomtype.cpp:305:78: style:inconclusive: Function 'renumberTypes' argument 3 names different: declaration 'wallAtomType' definition 'wall_atomtype'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gpp_atomtype.h:219:88: note: Function 'renumberTypes' argument 3 names different: declaration 'wallAtomType' definition 'wall_atomtype'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/gpp_atomtype.cpp:305:78: note: Function 'renumberTypes' argument 3 names different: declaration 'wallAtomType' definition 'wall_atomtype'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/gpp_atomtype.cpp:306:78: style:inconclusive: Function 'renumberTypes' argument 4 names different: declaration 'verbose' definition 'bVerbose'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gpp_atomtype.h:219:107: note: Function 'renumberTypes' argument 4 names different: declaration 'verbose' definition 'bVerbose'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/gpp_atomtype.cpp:306:78: note: Function 'renumberTypes' argument 4 names different: declaration 'verbose' definition 'bVerbose'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/gpp_atomtype.cpp:392:61: style:inconclusive: Function 'copyTot_atomtypes' argument 1 names different: declaration 'atypes' definition 'atomtypes'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gpp_atomtype.h:226:41: note: Function 'copyTot_atomtypes' argument 1 names different: declaration 'atypes' definition 'atomtypes'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/gpp_atomtype.cpp:392:61: note: Function 'copyTot_atomtypes' argument 1 names different: declaration 'atypes' definition 'atomtypes'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:819:66: style: Condition 'i!=atHZ' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:819:55: note: Assuming that condition 'bDoZ' is not redundant gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:816:19: note: Assuming that condition 'i<(bDoZ?atNR:atHZ)' is not redundant gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:819:66: note: Condition 'i!=atHZ' is always true gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:304:53: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:348:53: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:587:10: style: The scope of the variable 'bNterm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:623:10: style: The scope of the variable 'bNterm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:1667:55: style:inconclusive: Function 'do_vsites' argument 7 names different: declaration 'dummy_type' definition 'vsite_type'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.h:66:55: note: Function 'do_vsites' argument 7 names different: declaration 'dummy_type' definition 'vsite_type'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:1667:55: note: Function 'do_vsites' argument 7 names different: declaration 'dummy_type' definition 'vsite_type'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:1670:55: style:inconclusive: Function 'do_vsites' argument 10 names different: declaration 'bVSiteAromatics' definition 'bVsiteAromatics'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.h:69:55: note: Function 'do_vsites' argument 10 names different: declaration 'bVSiteAromatics' definition 'bVsiteAromatics'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:1670:55: note: Function 'do_vsites' argument 10 names different: declaration 'bVSiteAromatics' definition 'bVsiteAromatics'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:2166:29: style: Local variable 'k' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:1674:13: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:2166:29: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:583:61: performance:inconclusive: Function parameter 'rtpFFDB' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:619:62: performance:inconclusive: Function parameter 'rtpFFDB' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:867:68: performance:inconclusive: Function parameter 'plist' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:870:68: performance:inconclusive: Function parameter 'vsitetop' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:956:68: performance:inconclusive: Function parameter 'vsitetop' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:1251:68: performance:inconclusive: Function parameter 'vsitetop' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:1408:68: performance:inconclusive: Function parameter 'vsitetop' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:1661:55: performance:inconclusive: Function parameter 'rtpFFDB' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:564:27: style: Parameter 'o2n' can be declared as const array [constParameter] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:2053:26: style: Variable 'Hat_vsite_type' can be declared as const array [constVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gpp_nextnb.cpp:177:21: style: The scope of the variable 'j_index' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gpp_nextnb.cpp:178:25: style: The scope of the variable 'nrs' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gpp_nextnb.cpp:178:30: style: The scope of the variable 'nr_of_sortables' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/gpp_nextnb.cpp:434:79: performance:inconclusive: Function parameter 'plist' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/h_db.cpp:91:10: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/h_db.cpp:155:13: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/h_db.cpp:74:47: style:inconclusive: Function 'print_ab' argument 2 names different: declaration 'ab' definition 'hack'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/h_db.h:64:47: note: Function 'print_ab' argument 2 names different: declaration 'ab' definition 'hack'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/h_db.cpp:74:47: note: Function 'print_ab' argument 2 names different: declaration 'ab' definition 'hack'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/h_db.cpp:85:57: style:inconclusive: Function 'read_ab' argument 3 names different: declaration 'ab' definition 'hack'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/h_db.h:52:57: note: Function 'read_ab' argument 3 names different: declaration 'ab' definition 'hack'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/h_db.cpp:85:57: note: Function 'read_ab' argument 3 names different: declaration 'ab' definition 'hack'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/grompp.cpp:276:14: style: The scope of the variable 'tat' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/grompp.cpp:345:10: style: The scope of the variable 'min_steps_warn' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/grompp.cpp:350:18: style: The scope of the variable 'bWater' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/grompp.cpp:350:26: style: The scope of the variable 'bWarn' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/grompp.cpp:1194:12: style: The scope of the variable 'p' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/grompp.cpp:1194:15: style: The scope of the variable 'q' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/grompp.cpp:1237:12: style: The scope of the variable 'offset' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/grompp.cpp:1333:16: style: The scope of the variable 'count_mol' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/grompp.cpp:1868:14: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/grompp.cpp:773:27: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/grompp.cpp:598:33: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/grompp.cpp:773:27: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/grompp.cpp:2082:21: style: Local variable 'fn' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/grompp.cpp:1989:17: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/grompp.cpp:2082:21: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/grompp.cpp:508:14: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/gmxpreprocess/grompp.cpp:874:20: style: Consider using std::fill or std::generate algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/gmxpreprocess/grompp.cpp:1629:31: style: Consider using std::any_of, std::all_of, std::none_of, or std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/gmxpreprocess/hizzie.cpp:175:75: style:inconclusive: Function 'set_histp' argument 5 names different: declaration 'distance' definition 'dist'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/hizzie.h:47:75: note: Function 'set_histp' argument 5 names different: declaration 'distance' definition 'dist'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/hizzie.cpp:175:75: note: Function 'set_histp' argument 5 names different: declaration 'distance' definition 'dist'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/hizzie.cpp:184:21: style: Local variable 'hbond' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/gmxpreprocess/hizzie.cpp:76:13: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/hizzie.cpp:184:21: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/nm2type.cpp:92:17: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/nm2type.cpp:206:22: style: The scope of the variable 'nb' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/nm2type.cpp:208:11: style: The scope of the variable 'aname_i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/nm2type.cpp:330:18: style: The scope of the variable 'atomnr' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/nm2type.cpp:202:37: style:inconclusive: Function 'nm2type' argument 7 names different: declaration 'bond' definition 'bonds'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/nm2type.h:70:37: note: Function 'nm2type' argument 7 names different: declaration 'bond' definition 'bonds'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/nm2type.cpp:202:37: note: Function 'nm2type' argument 7 names different: declaration 'bond' definition 'bonds'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2top.cpp:419:9: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2top.cpp:418:14: warning:inconclusive: Possible null pointer dereference: model [nullPointer] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2top.cpp:414:13: note: Assignment 'model=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2top.cpp:418:14: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2top.cpp:419:29: warning:inconclusive: Possible null pointer dereference: model [nullPointer] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2top.cpp:414:13: note: Assignment 'model=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2top.cpp:419:29: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2top.cpp:457:15: warning:inconclusive: Possible null pointer dereference: model [nullPointer] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2top.cpp:414:13: note: Assignment 'model=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2top.cpp:457:15: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2top.cpp:468:18: style: The scope of the variable 'prevresind' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2top.cpp:1015:11: style: The scope of the variable 'key' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2top.cpp:1016:11: style: The scope of the variable 'bRM' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2top.cpp:1681:19: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2top.cpp:1563:45: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2top.cpp:1681:19: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2top.cpp:1003:64: performance:inconclusive: Function parameter 'rtpFFDB' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2top.cpp:1385:68: performance:inconclusive: Function parameter 'x' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2top.cpp:1548:53: performance:inconclusive: Function parameter 'ssbonds' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2top.cpp:1048:60: error: Out of bounds access in expression 'usedPpResidues->back()' because 'usedPpResidues' is empty. [containerOutOfBounds] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2top.cpp:1052:48: error: Out of bounds access in expression 'usedPpResidues->front()' because 'usedPpResidues' is empty. [containerOutOfBounds] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2top.cpp:1113:56: error: Out of bounds access in expression 'usedPpResidues->at(pos)' because 'usedPpResidues' is empty and 'pos' may be non-zero. [containerOutOfBounds] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pgutil.cpp:63:10: style: The scope of the variable 'message_buffer' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::bNewRTP_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::bInter_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::bCysMan_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::bLysMan_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::bAspMan_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::bGluMan_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::bHisMan_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::bGlnMan_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::bArgMan_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::bTerMan_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::bUnA_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::bHeavyH_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::bSort_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::bAllowMissing_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::bRemoveH_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::bDeuterate_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::bVerbose_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::bChargeGroups_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::bCmap_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::bRenumRes_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::bRTPresname_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::bIndexSet_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::bOutputSet_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::bWat_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::bITP_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::forcefield_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::ffdir_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::ffname_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1584:5: warning: Member variable 'pdb2gmx::watermodel_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:2505:37: style: Condition '!tdblist.empty()' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:2492:34: note: Assuming that condition 'tdblist.empty()' is not redundant gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:2505:37: note: Condition '!tdblist.empty()' is always true gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:2547:37: style: Condition '!tdblist.empty()' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:2534:34: note: Assuming that condition 'tdblist.empty()' is not redundant gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:2547:37: note: Condition '!tdblist.empty()' is always true gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:313:24: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:465:11: style: The scope of the variable 'resnm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:560:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:561:9: style: The scope of the variable 'nzero' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:562:9: style: The scope of the variable 'nnotone' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:666:16: style: The scope of the variable 'new_natom' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:666:27: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1075:9: style: The scope of the variable 'endWarnings' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1300:17: style: The scope of the variable 'old_this_chainid' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1302:17: style: The scope of the variable 'old_this_chainnum' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1307:17: style: The scope of the variable 'prev_atomnum' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1308:17: style: The scope of the variable 'prev_atomname' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1310:17: style: The scope of the variable 'prev_resname' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1312:17: style: The scope of the variable 'prev_resnum' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1314:17: style: The scope of the variable 'prev_chainid' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1976:32: style: The scope of the variable 'ssbonds' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1979:17: style: The scope of the variable 'prev_atomnum' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1980:17: style: The scope of the variable 'prev_atomname' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1982:17: style: The scope of the variable 'prev_resname' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1984:17: style: The scope of the variable 'prev_resnum' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1986:17: style: The scope of the variable 'prev_chainid' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1988:17: style: The scope of the variable 'prev_chainnumber' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:2661:21: style: The scope of the variable 'suffix' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:2299:18: style: Local variable 'j' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:2246:22: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:2299:18: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:2304:18: style: Local variable 'j' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:2246:22: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:2304:18: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:2678:22: style: Local variable 'k' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:2656:13: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:2678:22: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:2866:18: style: Local variable 'j' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:2246:22: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:2866:18: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:2875:18: style: Local variable 'j' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:2246:22: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:2875:18: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:261:65: performance:inconclusive: Function parameter 'rr' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:266:65: performance:inconclusive: Function parameter 'rr' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:271:65: performance:inconclusive: Function parameter 'rr' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:276:65: performance:inconclusive: Function parameter 'rr' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:281:65: performance:inconclusive: Function parameter 'rr' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:286:65: performance:inconclusive: Function parameter 'rr' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:396:51: performance:inconclusive: Function parameter 'rr' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1424:65: performance:inconclusive: Function parameter 'rtpFFDB' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:1425:65: performance:inconclusive: Function parameter 'rr' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/pdb2gmx.cpp:239:85: performance:inconclusive: Function parameter 'rr' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readpull.cpp:100:13: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readpull.cpp:396:10: style: The scope of the variable 'nscan' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readrot.cpp:76:15: style: The scope of the variable 'rotg' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readrot.cpp:234:10: style: The scope of the variable 'warn_buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readrot.cpp:326:18: style: The scope of the variable 'ig' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readrot.cpp:327:15: style: The scope of the variable 'rotg' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readrot.cpp:326:21: style: Variable 'ig' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/resall.cpp:95:17: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/resall.cpp:145:13: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/resall.cpp:181:17: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/resall.cpp:71:13: style: The scope of the variable 'in' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/resall.cpp:319:11: style: The scope of the variable 'nparam' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/resall.cpp:321:11: style: The scope of the variable 'bNextResidue' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/resall.cpp:321:25: style: The scope of the variable 'bError' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/resall.cpp:310:58: style:inconclusive: Function 'readResidueDatabase' argument 1 names different: declaration 'resdb' definition 'rrdb'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/resall.h:104:58: note: Function 'readResidueDatabase' argument 1 names different: declaration 'resdb' definition 'rrdb'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/resall.cpp:310:58: note: Function 'readResidueDatabase' argument 1 names different: declaration 'resdb' definition 'rrdb'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/solvate.cpp:719:13: warning: Either the condition 'atomsSolvent' is redundant or there is possible null pointer dereference: atomsSolvent. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/gmxpreprocess/solvate.cpp:727:9: note: Assuming that condition 'atomsSolvent' is not redundant gromacs-2022-rc1/src/gromacs/gmxpreprocess/solvate.cpp:719:13: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxpreprocess/solvate.cpp:720:13: warning: Either the condition 'atomsSolvent' is redundant or there is possible null pointer dereference: atomsSolvent. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/gmxpreprocess/solvate.cpp:727:9: note: Assuming that condition 'atomsSolvent' is not redundant gromacs-2022-rc1/src/gromacs/gmxpreprocess/solvate.cpp:720:13: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxpreprocess/solvate.cpp:741:17: style: The scope of the variable 'fpin' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/solvate.cpp:741:24: style: The scope of the variable 'fpout' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/solvate.cpp:742:17: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/solvate.cpp:742:34: style: The scope of the variable 'buf2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/solvate.cpp:742:49: style: The scope of the variable 'temp' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/solvate.cpp:744:17: style: The scope of the variable 'line' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/solvate.cpp:745:17: style: The scope of the variable 'bSystem' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/solvate.cpp:922:17: style: The scope of the variable 'conf_prot' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/solvate.cpp:826:22: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/solvate.cpp:746:17: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/solvate.cpp:826:22: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/specbond.cpp:91:13: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/specbond.cpp:190:32: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/specbond.cpp:252:33: style: Local variable 'buf' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/specbond.cpp:190:32: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/specbond.cpp:252:33: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/specbond.cpp:261:33: style: Local variable 'buf' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/specbond.cpp:190:32: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/specbond.cpp:261:33: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/tests/editconf.cpp:104:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/gmxpreprocess/ter_db.cpp:103:10: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/ter_db.cpp:294:25: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/tests/genconf.cpp:83:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/gmxpreprocess/ter_db.cpp:349:25: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/ter_db.cpp:366:17: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/tests/genion.cpp:105:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/gmxpreprocess/tests/genrestr.cpp:76:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/gmxpreprocess/tests/gpp_atomtype.cpp:77:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/gmxpreprocess/tests/grompp_directives.cpp:85:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/gmxpreprocess/tests/insert_molecules.cpp:77:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/gmxpreprocess/tests/pdb2gmx.cpp:129:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/gmxpreprocess/tests/readir.cpp:158:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/gmxpreprocess/tests/solvate.cpp:79:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/gmxpreprocess/tomorse.cpp:77:17: warning: fscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/topdirs.cpp:376:15: style: The scope of the variable 'D' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/topdirs.cpp:411:15: style: The scope of the variable 'd0' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/topdirs.cpp:412:15: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/topio.cpp:621:45: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/topio.cpp:1185:15: warning:inconclusive: Possible null pointer dereference: qm_arr [nullPointer] gromacs-2022-rc1/src/gromacs/gmxpreprocess/topio.cpp:1141:20: note: Assignment 'qm_arr=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxpreprocess/topio.cpp:1185:15: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxpreprocess/topio.cpp:111:37: style: The scope of the variable 'atomNumbers' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/topio.cpp:1380:26: style: The scope of the variable 'nat_mol' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/topio.cpp:1381:21: style: The scope of the variable 'molb' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/topio.cpp:1055:53: style:inconclusive: Function 'do_top' argument 7 names different: declaration 'plist' definition 'interactions'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/topio.h:75:53: note: Function 'do_top' argument 7 names different: declaration 'plist' definition 'interactions'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/topio.cpp:1055:53: note: Function 'do_top' argument 7 names different: declaration 'plist' definition 'interactions'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/topio.cpp:1059:53: style:inconclusive: Function 'do_top' argument 11 names different: declaration 'atype' definition 'atypes'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/topio.h:79:53: note: Function 'do_top' argument 11 names different: declaration 'atype' definition 'atypes'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/topio.cpp:1059:53: note: Function 'do_top' argument 11 names different: declaration 'atype' definition 'atypes'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/topio.cpp:1344:13: style: Local variable 'j' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/topio.cpp:1310:9: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/topio.cpp:1344:13: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/topio.cpp:1055:53: performance:inconclusive: Function parameter 'interactions' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:857:25: style: Condition 'nn>nrfpA' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:846:16: note: Assuming that condition 'nn==nrfpA' is not redundant gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:857:25: note: Condition 'nn>nrfpA' is always true gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1005:25: style: Condition 'nn>nrfpA' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:994:16: note: Assuming that condition 'nn==nrfpA' is not redundant gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1005:25: note: Condition 'nn>nrfpA' is always true gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1276:28: style: Condition 'read_cmap>nrfpA' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1263:19: note: Assuming that condition 'read_cmap==nrfpA' is not redundant gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1276:28: note: Condition 'read_cmap>nrfpA' is always true gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:325:15: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:410:29: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:421:29: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:434:29: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:444:29: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:472:29: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:483:29: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:497:29: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:508:29: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1063:9: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1241:14: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1431:9: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1453:13: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1512:10: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:2503:9: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:2488:47: warning:inconclusive: Possible null pointer dereference: atc [nullPointer] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:2409:22: note: Assignment 'atc=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:2488:47: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:2490:34: warning:inconclusive: Possible null pointer dereference: weight [nullPointer] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:2410:22: note: Assignment 'weight=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:2490:34: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:817:17: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:912:12: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1061:17: style: The scope of the variable 'bId' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1576:24: style: The scope of the variable 'ti' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1576:28: style: The scope of the variable 'tj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1576:32: style: The scope of the variable 'ntype' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1858:17: style: The scope of the variable 'asformat' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1862:17: style: The scope of the variable 'ccformat' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1864:17: style: The scope of the variable 'format' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:74:48: style:inconclusive: Function 'generate_nbparams' argument 2 names different: declaration 'funct' definition 'ftype'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.h:66:48: note: Function 'generate_nbparams' argument 2 names different: declaration 'funct' definition 'ftype'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:74:48: note: Function 'generate_nbparams' argument 2 names different: declaration 'funct' definition 'ftype'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:75:48: style:inconclusive: Function 'generate_nbparams' argument 3 names different: declaration 'plist' definition 'interactions'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.h:67:48: note: Function 'generate_nbparams' argument 3 names different: declaration 'plist' definition 'interactions'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:75:48: note: Function 'generate_nbparams' argument 3 names different: declaration 'plist' definition 'interactions'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:76:48: style:inconclusive: Function 'generate_nbparams' argument 4 names different: declaration 'atype' definition 'atypes'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.h:68:48: note: Function 'generate_nbparams' argument 4 names different: declaration 'atype' definition 'atypes'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:76:48: note: Function 'generate_nbparams' argument 4 names different: declaration 'atype' definition 'atypes'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:239:69: style:inconclusive: Function 'copy_nbparams' argument 3 names different: declaration 'plist' definition 'interactions'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.h:135:69: note: Function 'copy_nbparams' argument 3 names different: declaration 'plist' definition 'interactions'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:239:69: note: Function 'copy_nbparams' argument 3 names different: declaration 'plist' definition 'interactions'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:304:41: style:inconclusive: Function 'push_at' argument 3 names different: declaration 'bat' definition 'bondAtomType'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.h:73:41: note: Function 'push_at' argument 3 names different: declaration 'bat' definition 'bondAtomType'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:304:41: note: Function 'push_at' argument 3 names different: declaration 'bat' definition 'bondAtomType'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:802:48: style:inconclusive: Function 'push_bt' argument 5 names different: declaration 'bat' definition 'bondAtomType'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.h:84:48: note: Function 'push_bt' argument 5 names different: declaration 'bat' definition 'bondAtomType'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:802:48: note: Function 'push_bt' argument 5 names different: declaration 'bat' definition 'bondAtomType'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:884:58: style:inconclusive: Function 'push_dihedraltype' argument 3 names different: declaration 'bat' definition 'bondAtomType'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.h:90:58: note: Function 'push_dihedraltype' argument 3 names different: declaration 'bat' definition 'bondAtomType'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:884:58: note: Function 'push_dihedraltype' argument 3 names different: declaration 'bat' definition 'bondAtomType'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1050:69: style:inconclusive: Function 'push_nbt' argument 3 names different: declaration 'atype' definition 'atypes'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.h:102:69: note: Function 'push_nbt' argument 3 names different: declaration 'atype' definition 'atypes'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1050:69: note: Function 'push_nbt' argument 3 names different: declaration 'atype' definition 'atypes'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1050:83: style:inconclusive: Function 'push_nbt' argument 4 names different: declaration 'plines' definition 'pline'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.h:102:82: note: Function 'push_nbt' argument 4 names different: declaration 'plines' definition 'pline'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1050:83: note: Function 'push_nbt' argument 4 names different: declaration 'plines' definition 'pline'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1186:54: style:inconclusive: Function 'push_cmaptype' argument 4 names different: declaration 'at' definition 'atomtypes'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.h:97:54: note: Function 'push_cmaptype' argument 4 names different: declaration 'at' definition 'atomtypes'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1186:54: note: Function 'push_cmaptype' argument 4 names different: declaration 'at' definition 'atomtypes'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1187:54: style:inconclusive: Function 'push_cmaptype' argument 5 names different: declaration 'bat' definition 'bondAtomType'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.h:98:54: note: Function 'push_cmaptype' argument 5 names different: declaration 'bat' definition 'bondAtomType'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1187:54: note: Function 'push_cmaptype' argument 5 names different: declaration 'bat' definition 'bondAtomType'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1422:71: style:inconclusive: Function 'push_atom' argument 3 names different: declaration 'atype' definition 'atypes'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.h:104:78: note: Function 'push_atom' argument 3 names different: declaration 'atype' definition 'atypes'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1422:71: note: Function 'push_atom' argument 3 names different: declaration 'atype' definition 'atypes'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1847:50: style:inconclusive: Function 'push_bond' argument 5 names different: declaration 'atype' definition 'atypes'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.h:110:50: note: Function 'push_bond' argument 5 names different: declaration 'atype' definition 'atypes'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1847:50: note: Function 'push_bond' argument 5 names different: declaration 'atype' definition 'atypes'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:2314:50: style:inconclusive: Function 'push_cmap' argument 5 names different: declaration 'atype' definition 'atypes'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.h:123:50: note: Function 'push_cmap' argument 5 names different: declaration 'atype' definition 'atypes'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:2314:50: note: Function 'push_cmap' argument 5 names different: declaration 'atype' definition 'atypes'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:591:18: style: Local variable 'message' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:578:14: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:591:18: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:874:14: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:817:17: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:874:14: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1022:14: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:912:12: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1022:14: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1039:14: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:912:12: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1039:14: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:2299:39: style: Local variable 'forceParam' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1993:37: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:2299:39: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1732:75: performance:inconclusive: Function parameter 'atomTypes' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:1765:61: performance:inconclusive: Function parameter 'atomTypes' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:2311:50: performance:inconclusive: Function parameter 'bondtype' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:2650:18: style: Consider using std::copy algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toppush.cpp:2691:36: style: Consider using std::any_of, std::all_of, std::none_of, or std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toputil.cpp:83:29: style: The scope of the variable 'bSwapParity' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toputil.cpp:202:10: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toputil.cpp:249:17: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toputil.cpp:249:20: style: The scope of the variable 'ri' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toputil.cpp:250:17: style: The scope of the variable 'tpA' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toputil.cpp:250:22: style: The scope of the variable 'tpB' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toputil.cpp:252:17: style: The scope of the variable 'qres' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/toputil.cpp:353:121: performance:inconclusive: Function parameter 'plist' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:1011:25: style: The scope of the variable 'bKeep' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:1011:32: style: The scope of the variable 'bRemove' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:1011:41: style: The scope of the variable 'bAllFD' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:1549:39: style: The scope of the variable 'pindex' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:1550:39: style: The scope of the variable 'at2vc' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:781:50: style:inconclusive: Function 'set_vsites' argument 3 names different: declaration 'atype' definition 'atypes'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.h:55:50: note: Function 'set_vsites' argument 3 names different: declaration 'atype' definition 'atypes'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:781:50: note: Function 'set_vsites' argument 3 names different: declaration 'atype' definition 'atypes'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:1542:60: style:inconclusive: Function 'clean_vsite_bondeds' argument 1 names different: declaration 'ps' definition 'plist'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.h:67:60: note: Function 'clean_vsite_bondeds' argument 1 names different: declaration 'ps' definition 'plist'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:1542:60: note: Function 'clean_vsite_bondeds' argument 1 names different: declaration 'ps' definition 'plist'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:1095:44: style: Local variable 'atoms' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:1033:34: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:1095:44: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:1277:17: style: Local variable 'atom' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:1260:25: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:1277:17: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:412:75: performance:inconclusive: Function parameter 'bonds' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:413:75: performance:inconclusive: Function parameter 'angles' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:493:77: performance:inconclusive: Function parameter 'bonds' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:494:77: performance:inconclusive: Function parameter 'angles' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:520:78: performance:inconclusive: Function parameter 'bonds' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:521:78: performance:inconclusive: Function parameter 'angles' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:552:78: performance:inconclusive: Function parameter 'bonds' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:553:78: performance:inconclusive: Function parameter 'angles' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:647:77: performance:inconclusive: Function parameter 'bonds' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:648:77: performance:inconclusive: Function parameter 'angles' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:713:78: performance:inconclusive: Function parameter 'bonds' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:714:78: performance:inconclusive: Function parameter 'angles' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:361:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:379:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/gmxpreprocess/vsite_parm.cpp:135:9: style: struct member 'Atom2VsiteBond::ftype' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/gmxpreprocess/x2top.cpp:333:14: style: The scope of the variable 'tp' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/x2top.cpp:389:43: style: The scope of the variable 'fp' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/x2top.cpp:133:34: style: Local variable 'atoms' shadows outer argument [shadowArgument] gromacs-2022-rc1/src/gromacs/gmxpreprocess/x2top.cpp:99:42: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/x2top.cpp:133:34: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/x2top.cpp:328:63: performance:inconclusive: Function parameter 'plist' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gpu_utils/device_context.h:73:5: style: Class 'DeviceContext' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/gmxpreprocess/xlate.cpp:84:14: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/gmxpreprocess/xlate.cpp:73:19: style: The scope of the variable '_ptr' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/xlate.cpp:74:22: style: The scope of the variable 'na' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/xlate.cpp:155:33: style: The scope of the variable 'resind' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/xlate.cpp:158:19: style: The scope of the variable 'bReorderedNum' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/xlate.cpp:158:34: style: The scope of the variable 'bRenamed' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/xlate.cpp:159:19: style: The scope of the variable 'bStartTerm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/xlate.cpp:159:31: style: The scope of the variable 'bEndTerm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/xlate.cpp:149:58: style:inconclusive: Function 'rename_atoms' argument 5 names different: declaration 'restp' definition 'localPpResidue'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gmxpreprocess/xlate.h:60:58: note: Function 'rename_atoms' argument 5 names different: declaration 'restp' definition 'localPpResidue'. gromacs-2022-rc1/src/gromacs/gmxpreprocess/xlate.cpp:149:58: note: Function 'rename_atoms' argument 5 names different: declaration 'restp' definition 'localPpResidue'. gromacs-2022-rc1/src/gromacs/gpu_utils/device_stream_manager.cpp:89:58: performance:inconclusive: Function parameter 'simulationWork' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/gpu_utils/devicebuffer_sycl.h:269:8: performance:inconclusive: Technically the member function 'gmx::internal::NullAccessor::get_pointer' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/gromacs/gpu_utils/devicebuffer_sycl.h:271:10: performance:inconclusive: Technically the member function 'gmx::internal::NullAccessor::bind' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/gromacs/gpu_utils/devicebuffer_sycl.h:231:5: style: Class 'DeviceAccessor' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/gpu_utils/devicebuffer_sycl.h:236:5: style: Class 'DeviceAccessor' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/gpu_utils/devicebuffer_sycl.h:265:5: style: Struct 'NullAccessor' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/gpu_utils/hostallocator.h:142:5: style: Class 'HostAllocationPolicy' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/gpu_utils/hostallocator.cpp:58:58: style:inconclusive: Function 'HostAllocationPolicy' argument 1 names different: declaration 'policy' definition 'pinningPolicy'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/gpu_utils/hostallocator.h:142:40: note: Function 'HostAllocationPolicy' argument 1 names different: declaration 'policy' definition 'pinningPolicy'. gromacs-2022-rc1/src/gromacs/gpu_utils/hostallocator.cpp:58:58: note: Function 'HostAllocationPolicy' argument 1 names different: declaration 'policy' definition 'pinningPolicy'. gromacs-2022-rc1/src/gromacs/gpu_utils/devicebuffer_sycl.h:251:70: style: Parameter 'buffer' can be declared as reference to const [constParameter] gromacs-2022-rc1/src/gromacs/gpu_utils/oclutils.h:137:116: style: Same expression on both sides of '&&'. [duplicateExpression] gromacs-2022-rc1/src/gromacs/gpu_utils/oclutils.h:137:157: style: Same expression '!std::is_same_v' found multiple times in chain of '&&' operators. [duplicateExpression] gromacs-2022-rc1/src/gromacs/gpu_utils/tests/clfftinitializer.cpp:58:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/gpu_utils/tests/device_availability.cpp:89:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/gpu_utils/tests/device_stream_manager.cpp:106:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/gpu_utils/tests/hostallocator.cpp:184:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/hardware/cpuinfo.cpp:1092:10: warning: Member variable 'CpuInfo::supportLevel_' is not initialized in the constructor. [uninitMemberVarPrivate] gromacs-2022-rc1/src/gromacs/hardware/cpuinfo.cpp:128:58: style: Parameter 'c' can be declared as reference to const [constParameter] gromacs-2022-rc1/src/gromacs/hardware/cpuinfo.cpp:131:59: style: Parameter 'c' can be declared as reference to const [constParameter] gromacs-2022-rc1/src/gromacs/hardware/cpuinfo.cpp:554:37: style: Parameter 'c' can be declared as reference to const [constParameter] gromacs-2022-rc1/src/gromacs/hardware/device_management_common.cpp:134:50: style: Parameter 'deviceInfo' can be declared as reference to const [constParameter] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:207:10: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:243:20: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:1574:17: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:1953:20: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:1954:17: style: The scope of the variable 'warn_buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:2930:23: style: The scope of the variable 'warn_buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:3039:36: style: The scope of the variable 'na_tot' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:3040:40: style: The scope of the variable 'nrdf_uc' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:3334:10: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:3334:13: style: The scope of the variable 'k' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:3385:34: style: The scope of the variable 'gind' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:3386:18: style: The scope of the variable 'swapg' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:3429:13: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/hardware/identifyavx512fmaunits.cpp:309:13: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] gromacs-2022-rc1/src/gromacs/hardware/identifyavx512fmaunits.cpp:305:9: note: outer condition: !initialized gromacs-2022-rc1/src/gromacs/hardware/identifyavx512fmaunits.cpp:309:13: note: identical inner condition: !initialized gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:3549:15: style: The scope of the variable 'nstcmin' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:3551:30: style: The scope of the variable 'bAnneal' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:4309:17: style: The scope of the variable 'c6i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:4309:27: style: The scope of the variable 'c12i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:4441:37: style: The scope of the variable 'c' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:4445:31: style: The scope of the variable 'warn_buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:1585:15: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:1574:17: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:1585:15: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:1593:15: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:1574:17: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:1593:15: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:1603:15: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:1574:17: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:1603:15: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:1640:15: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:1574:17: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:1640:15: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:1673:19: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:1574:17: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:1673:19: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:1690:15: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:1574:17: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:1690:15: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:2547:29: style: Local variable 'stream' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:1961:28: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:2547:29: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:3576:14: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:3550:15: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:3576:14: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:3922:18: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:3550:15: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:3922:18: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:4470:20: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:4441:31: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:4470:20: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:4507:13: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:4441:31: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:4507:13: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:4646:14: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:4441:31: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:4646:14: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:4660:27: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:4441:31: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:4660:27: note: Shadow variable gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:1596:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:1677:28: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:2107:27: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/hardware/tests/hardwaretopology.cpp:97:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/gmxpreprocess/readir.cpp:3385:29: style: Variable 'i' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/hardware/printhardware.cpp:76:20: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/imd/imdsocket.cpp:201:9: style: Condition 'ret' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/imd/imdsocket.cpp:198:12: note: Assignment 'ret=-1', assigned value is -1 gromacs-2022-rc1/src/gromacs/imd/imdsocket.cpp:201:9: note: Condition 'ret' is always true gromacs-2022-rc1/src/gromacs/imd/imdsocket.cpp:224:9: style: Condition 'ret' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/imd/imdsocket.cpp:221:12: note: Assignment 'ret=-1', assigned value is -1 gromacs-2022-rc1/src/gromacs/imd/imdsocket.cpp:224:9: note: Condition 'ret' is always true gromacs-2022-rc1/src/gromacs/imd/imdsocket.cpp:435:13: style: Condition 'ret<0' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/imd/imdsocket.cpp:402:16: note: Assignment 'ret=-1', assigned value is -1 gromacs-2022-rc1/src/gromacs/imd/imdsocket.cpp:435:13: note: Condition 'ret<0' is always true gromacs-2022-rc1/src/gromacs/imd/imdsocket.cpp:362:13: style: The comparison 'ret == -1' is always true. [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/imd/imdsocket.cpp:348:16: note: 'ret' is assigned value '-1' here. gromacs-2022-rc1/src/gromacs/imd/imdsocket.cpp:362:13: note: The comparison 'ret == -1' is always true. gromacs-2022-rc1/src/gromacs/imd/imdsocket.cpp:388:13: style: The comparison 'ret == -1' is always true. [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/imd/imdsocket.cpp:372:16: note: 'ret' is assigned value '-1' here. gromacs-2022-rc1/src/gromacs/imd/imdsocket.cpp:388:13: note: The comparison 'ret == -1' is always true. gromacs-2022-rc1/src/gromacs/imd/imdsocket.cpp:346:34: style: Parameter 'sock' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/dasum.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/daxpy.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/eigensolver.cpp:50:93: style:inconclusive: Function 'eigensolver' argument 6 names different: declaration 'eigenvec' definition 'eigenvectors'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/linearalgebra/eigensolver.h:64:93: note: Function 'eigensolver' argument 6 names different: declaration 'eigenvec' definition 'eigenvectors'. gromacs-2022-rc1/src/gromacs/linearalgebra/eigensolver.cpp:50:93: note: Function 'eigensolver' argument 6 names different: declaration 'eigenvec' definition 'eigenvectors'. gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/dcopy.cpp:4:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/ddot.cpp:4:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/dgemm.cpp:9:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/dgemv.cpp:9:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/dger.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/dnrm2.cpp:7:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/drot.cpp:4:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/dscal.cpp:4:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/dswap.cpp:4:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_arpack.cpp:52:13: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/imd/imd.h:203:10: style:inconclusive: Technically the member function 'gmx::ImdSession::fillEnergyRecord' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/imd/imd.cpp:1596:18: note: Technically the member function 'gmx::ImdSession::fillEnergyRecord' can be const. gromacs-2022-rc1/src/gromacs/imd/imd.h:203:10: note: Technically the member function 'gmx::ImdSession::fillEnergyRecord' can be const. gromacs-2022-rc1/src/gromacs/imd/imd.h:159:5: style: Class 'ImdSession' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/imd/imd.cpp:156:5: style: Class 'Impl' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/dsymv.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/dsyr2.cpp:9:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/dsyr2k.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/dtrmm.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/dtrmv.cpp:7:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/imd/imd.cpp:1271:30: warning: Either the condition 'cr' is redundant or there is possible null pointer dereference: cr. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/imd/imd.cpp:1284:9: note: Assuming that condition 'cr' is not redundant gromacs-2022-rc1/src/gromacs/imd/imd.cpp:1271:30: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/imd/imd.cpp:519:42: portability:inconclusive: Casting from float * to char * is not portable due to different binary data representations on different platforms. [invalidPointerCast] gromacs-2022-rc1/src/gromacs/imd/imd.cpp:395:24: style: The scope of the variable 'countread' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/imd/imd.cpp:433:24: style: The scope of the variable 'countwritten' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/imd/imd.cpp:1591:95: performance:inconclusive: Function parameter 'coords' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/dtrsm.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/idamax.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/isamax.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/sasum.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/saxpy.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/scopy.cpp:4:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/sdot.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/sgemm.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/sgemv.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/sger.cpp:7:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/snrm2.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/srot.cpp:4:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/sscal.cpp:4:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/sswap.cpp:4:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/ssymv.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/ssyr2.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/ssyr2k.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/strmm.cpp:7:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/strmv.cpp:7:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_blas/strsm.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dbdsdc.cpp:10:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dbdsqr.cpp:10:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dgebd2.cpp:4:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dgebrd.cpp:7:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dgelq2.cpp:4:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dgelqf.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dgeqr2.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dgeqrf.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dgetf2.cpp:9:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dgesdd.cpp:10:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dgetrf.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dgetri.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dgetrs.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlabrd.cpp:7:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlacpy.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlae2.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlaed6.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlaebz.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlaev2.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlagtf.cpp:10:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlamrg.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlagts.cpp:10:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlange.cpp:7:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlanst.cpp:7:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlansy.cpp:7:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlapy2.cpp:7:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlarf.cpp:10:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlar1vx.cpp:8:6: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlarfg.cpp:10:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlarfb.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlarnv.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlarft.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlarrbx.cpp:9:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlarrex.cpp:13:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlarrfx.cpp:11:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlarrvx.cpp:11:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlartg.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlaruv.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlas2.cpp:7:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlascl.cpp:10:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlasd0.cpp:4:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlasd1.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlasd3.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlasd2.cpp:9:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlasd5.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlasd4.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlasd6.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlasd7.cpp:9:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlasd8.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlasda.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlasdt.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlasdq.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlaset.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlasq1.cpp:9:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlasq3.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlasq2.cpp:12:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlasq5.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlasq4.cpp:7:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlasq6.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlasr.cpp:7:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlasrt.cpp:4:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlasrt2.cpp:3:6: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlassq.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlasv2.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlaswp.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dlatrd.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dorgbr.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dorg2r.cpp:7:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dorglq.cpp:9:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dorgl2.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dorm2l.cpp:4:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dorgqr.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dorm2r.cpp:4:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dormbr.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dorml2.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dormlq.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dormql.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dormqr.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dormtr.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dstebz.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dstegr.cpp:9:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dstein.cpp:9:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dsterf.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dsteqr.cpp:9:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dstevr.cpp:14:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dsyevr.cpp:10:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dsytd2.cpp:10:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dsytrd.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dtrti2.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/dtrtri.cpp:9:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/ilasrt2.cpp:4:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sbdsdc.cpp:10:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sgebd2.cpp:4:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sbdsqr.cpp:10:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sgelq2.cpp:4:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sgebrd.cpp:7:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sgelqf.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sgeqr2.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sgeqrf.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sgesdd.cpp:10:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sgetf2.cpp:9:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sgetrf.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sgetri.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sgetrs.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slacpy.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slabrd.cpp:7:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slae2.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slaebz.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slaev2.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slaed6.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slagtf.cpp:10:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slagts.cpp:10:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slamrg.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slange.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slanst.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slansy.cpp:7:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slapy2.cpp:7:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slar1vx.cpp:8:6: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slarf.cpp:10:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slarfb.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slarfg.cpp:10:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slarft.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slarnv.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slarrbx.cpp:9:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slarrex.cpp:13:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slarrfx.cpp:11:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slarrvx.cpp:11:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slartg.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slaruv.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slas2.cpp:7:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slascl.cpp:10:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slasd0.cpp:4:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slasd1.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slasd2.cpp:9:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slasd3.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slasd4.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slasd5.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slasd6.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slasd7.cpp:9:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slasd8.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slasda.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slasdq.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slasdt.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slaset.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slasq1.cpp:9:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slasq2.cpp:12:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slasq3.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slasq4.cpp:7:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slasq5.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slasq6.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slasr.cpp:7:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slasrt.cpp:4:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slasrt2.cpp:3:6: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slassq.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slasv2.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slaswp.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/slatrd.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sorg2r.cpp:7:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sorgbr.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sorgl2.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sorglq.cpp:9:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sorgqr.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sorm2l.cpp:4:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sorm2r.cpp:4:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sormbr.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sorml2.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sormlq.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sormql.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sormqr.cpp:5:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sormtr.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sstebz.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sstegr.cpp:9:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sstein.cpp:9:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/ssteqr.cpp:9:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/ssterf.cpp:8:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/sstevr.cpp:14:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/ssyevr.cpp:10:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/ssytd2.cpp:10:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/ssytrd.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/strti2.cpp:6:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/gmx_lapack/strtri.cpp:9:1: error: There is an unknown macro here somewhere. Configuration is required. If F77_FUNC is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/linearalgebra/matrix.cpp:128:14: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/linearalgebra/matrix.cpp:128:17: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/linearalgebra/matrix.cpp:129:32: style: The scope of the variable 'id' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/linearalgebra/matrix.cpp:193:12: style: The scope of the variable 'ax' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/linearalgebra/matrix.cpp:190:39: style:inconclusive: Function 'multi_regression' argument 2 names different: declaration 'ny' definition 'nrow'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/linearalgebra/matrix.h:51:39: note: Function 'multi_regression' argument 2 names different: declaration 'ny' definition 'nrow'. gromacs-2022-rc1/src/gromacs/linearalgebra/matrix.cpp:190:39: note: Function 'multi_regression' argument 2 names different: declaration 'ny' definition 'nrow'. gromacs-2022-rc1/src/gromacs/linearalgebra/matrix.cpp:190:60: style:inconclusive: Function 'multi_regression' argument 4 names different: declaration 'nx' definition 'ncol'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/linearalgebra/matrix.h:51:58: note: Function 'multi_regression' argument 4 names different: declaration 'nx' definition 'ncol'. gromacs-2022-rc1/src/gromacs/linearalgebra/matrix.cpp:190:60: note: Function 'multi_regression' argument 4 names different: declaration 'nx' definition 'ncol'. gromacs-2022-rc1/src/gromacs/linearalgebra/matrix.cpp:190:53: style: Parameter 'y' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/gromacs/linearalgebra/sparsematrix.cpp:198:16: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/gromacs/linearalgebra/sparsematrix.cpp:199:16: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/gromacs/linearalgebra/sparsematrix.cpp:242:15: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/gromacs/linearalgebra/sparsematrix.cpp:247:68: style: Parameter 'x' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/gromacs/linearalgebra/nrjac.cpp:64:34: style: The scope of the variable 'sm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/linearalgebra/nrjac.cpp:192:21: style: Parameter 'm' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/gromacs/listed_forces/disre.cpp:84:16: style: The scope of the variable 'hist' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/disre.cpp:80:40: style:inconclusive: Function 'init_disres' argument 9 names different: declaration 'disresdata' definition 'dd'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/listed_forces/disre.h:98:40: note: Function 'init_disres' argument 9 names different: declaration 'disresdata' definition 'dd'. gromacs-2022-rc1/src/gromacs/listed_forces/disre.cpp:80:40: note: Function 'init_disres' argument 9 names different: declaration 'disresdata' definition 'dd'. gromacs-2022-rc1/src/gromacs/listed_forces/disre.cpp:299:44: style:inconclusive: Function 'calc_disres_R_6' argument 4 names different: declaration 'fa' definition 'forceatoms'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/listed_forces/disre.h:109:44: note: Function 'calc_disres_R_6' argument 4 names different: declaration 'fa' definition 'forceatoms'. gromacs-2022-rc1/src/gromacs/listed_forces/disre.cpp:299:44: note: Function 'calc_disres_R_6' argument 4 names different: declaration 'fa' definition 'forceatoms'. gromacs-2022-rc1/src/gromacs/listed_forces/disre.cpp:302:44: style:inconclusive: Function 'calc_disres_R_6' argument 7 names different: declaration 'disresdata' definition 'dd'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/listed_forces/disre.h:112:44: note: Function 'calc_disres_R_6' argument 7 names different: declaration 'disresdata' definition 'dd'. gromacs-2022-rc1/src/gromacs/listed_forces/disre.cpp:302:44: note: Function 'calc_disres_R_6' argument 7 names different: declaration 'disresdata' definition 'dd'. gromacs-2022-rc1/src/gromacs/listed_forces/disre.cpp:639:48: style:inconclusive: Function 'update_disres_history' argument 1 names different: declaration 'disresdata' definition 'dd'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/listed_forces/disre.h:132:48: note: Function 'update_disres_history' argument 1 names different: declaration 'disresdata' definition 'dd'. gromacs-2022-rc1/src/gromacs/listed_forces/disre.cpp:639:48: note: Function 'update_disres_history' argument 1 names different: declaration 'disresdata' definition 'dd'. gromacs-2022-rc1/src/gromacs/listed_forces/listed_internal.h:65:5: style: Class 'WorkDivision' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/listed_forces/listed_forces_gpu_impl.cpp:81:9: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:271:19: style: The scope of the variable 'ki' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:271:23: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:271:29: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:271:33: style: The scope of the variable 'aj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:341:19: style: The scope of the variable 'ki' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:341:23: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:341:29: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:341:33: style: The scope of the variable 'aj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:398:19: style: The scope of the variable 'ki' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:398:23: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:398:29: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:398:33: style: The scope of the variable 'aj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:638:13: style: The scope of the variable 'ki' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:638:17: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:638:21: style: The scope of the variable 'aj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:638:25: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:728:13: style: The scope of the variable 'ki' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:728:17: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:728:21: style: The scope of the variable 'aj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:728:25: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:775:13: style: The scope of the variable 'ki' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:775:17: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:775:21: style: The scope of the variable 'aj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:775:25: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:835:10: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:835:13: style: The scope of the variable 'm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:835:16: style: The scope of the variable 'aO' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:835:20: style: The scope of the variable 'aH1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:835:25: style: The scope of the variable 'aH2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:835:30: style: The scope of the variable 'aD' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:835:34: style: The scope of the variable 'aS' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:835:38: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:835:44: style: The scope of the variable 'type0' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:835:51: style: The scope of the variable 'ki' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:977:13: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:977:19: style: The scope of the variable 'a1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:977:23: style: The scope of the variable 'da1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:977:28: style: The scope of the variable 'a2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:977:32: style: The scope of the variable 'da2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:1283:16: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:1283:20: style: The scope of the variable 'aj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:1283:24: style: The scope of the variable 'ak' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:1283:28: style: The scope of the variable 't1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:1283:32: style: The scope of the variable 't2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:1283:36: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:1611:16: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:1611:20: style: The scope of the variable 'aj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:1611:24: style: The scope of the variable 'ak' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:1611:36: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2285:13: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2285:19: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2285:23: style: The scope of the variable 'aj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2285:27: style: The scope of the variable 'ak' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2285:31: style: The scope of the variable 'al' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2352:16: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2352:22: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2352:26: style: The scope of the variable 'aj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2353:10: style: The scope of the variable 't1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2492:10: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2492:14: style: The scope of the variable 'aj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2492:18: style: The scope of the variable 'ak' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2492:22: style: The scope of the variable 'al' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2492:29: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2605:18: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2605:22: style: The scope of the variable 'aj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2605:26: style: The scope of the variable 'ak' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2605:30: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2606:12: style: The scope of the variable 't1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2606:16: style: The scope of the variable 't2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2709:16: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2709:22: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2709:26: style: The scope of the variable 'aj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2709:30: style: The scope of the variable 'ak' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2709:34: style: The scope of the variable 'al' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2712:10: style: The scope of the variable 't1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2712:14: style: The scope of the variable 't2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2833:10: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2833:16: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2833:20: style: The scope of the variable 'aj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2833:24: style: The scope of the variable 'ak' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2833:28: style: The scope of the variable 'al' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2834:10: style: The scope of the variable 't1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:2834:14: style: The scope of the variable 't2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3492:13: style: The scope of the variable 'ki' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3492:17: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3492:21: style: The scope of the variable 'aj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3492:25: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3551:13: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3551:17: style: The scope of the variable 'aj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3551:21: style: The scope of the variable 'ak' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3551:25: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3623:13: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3623:17: style: The scope of the variable 'aj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3623:21: style: The scope of the variable 'ak' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3623:25: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3623:34: style: The scope of the variable 't1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3623:38: style: The scope of the variable 't2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3697:13: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3697:17: style: The scope of the variable 'aj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3697:21: style: The scope of the variable 'ak' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3697:25: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3697:34: style: The scope of the variable 't1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3697:38: style: The scope of the variable 't2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3832:13: style: The scope of the variable 'ki' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3832:17: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3832:21: style: The scope of the variable 'aj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3832:25: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3832:31: style: The scope of the variable 'table' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3889:13: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3889:17: style: The scope of the variable 'aj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3889:21: style: The scope of the variable 'ak' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3889:33: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3889:39: style: The scope of the variable 'table' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3971:13: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3971:19: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3971:23: style: The scope of the variable 'aj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3971:27: style: The scope of the variable 'ak' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3971:31: style: The scope of the variable 'al' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:3971:35: style: The scope of the variable 'table' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/bonded.cpp:4011:20: style: struct member 'BondedInteractions::nrnbIndex' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/listed_forces/orires.cpp:673:14: style: The scope of the variable 'ex' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/orires.cpp:673:18: style: The scope of the variable 'power' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/orires.cpp:404:44: style:inconclusive: Function 'calc_orires_dev' argument 3 names different: declaration 'fa' definition 'forceatoms'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/listed_forces/orires.h:82:53: note: Function 'calc_orires_dev' argument 3 names different: declaration 'fa' definition 'forceatoms'. gromacs-2022-rc1/src/gromacs/listed_forces/orires.cpp:404:44: note: Function 'calc_orires_dev' argument 3 names different: declaration 'fa' definition 'forceatoms'. gromacs-2022-rc1/src/gromacs/listed_forces/orires.cpp:409:44: style:inconclusive: Function 'calc_orires_dev' argument 8 names different: declaration 'oriresdata' definition 'od'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/listed_forces/orires.h:87:53: note: Function 'calc_orires_dev' argument 8 names different: declaration 'oriresdata' definition 'od'. gromacs-2022-rc1/src/gromacs/listed_forces/orires.cpp:409:44: note: Function 'calc_orires_dev' argument 8 names different: declaration 'oriresdata' definition 'od'. gromacs-2022-rc1/src/gromacs/listed_forces/orires.cpp:457:26: style: Local variable 'x' shadows outer argument [shadowArgument] gromacs-2022-rc1/src/gromacs/listed_forces/orires.cpp:407:44: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/listed_forces/orires.cpp:457:26: note: Shadow variable gromacs-2022-rc1/src/gromacs/listed_forces/orires.cpp:276:22: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/listed_forces/orires.cpp:470:19: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/listed_forces/position_restraints.cpp:203:25: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/position_restraints.cpp:203:32: style: The scope of the variable 'd' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/position_restraints.cpp:203:35: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/position_restraints.cpp:346:25: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/position_restraints.cpp:346:32: style: The scope of the variable 'd' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/position_restraints.cpp:346:35: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/position_restraints.cpp:347:22: style: The scope of the variable 'pr' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/tests/bonded.cpp:651:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/listed_forces/tests/pairs.cpp:442:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/listed_forces/tests/position_restraints.cpp:151:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/listed_forces/pairs.cpp:539:24: style: The scope of the variable 'itype' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/pairs.cpp:539:31: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/pairs.cpp:539:35: style: The scope of the variable 'aj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/pairs.cpp:539:39: style: The scope of the variable 'gid' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/listed_forces/pairs.cpp:958:45: style:inconclusive: Function 'do_pairs' argument 17 names different: declaration 'havePerturbedPairs' definition 'havePerturbedInteractions'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/listed_forces/pairs.h:84:45: note: Function 'do_pairs' argument 17 names different: declaration 'havePerturbedPairs' definition 'havePerturbedInteractions'. gromacs-2022-rc1/src/gromacs/listed_forces/pairs.cpp:958:45: note: Function 'do_pairs' argument 17 names different: declaration 'havePerturbedPairs' definition 'havePerturbedInteractions'. gromacs-2022-rc1/src/gromacs/math/3dtransforms.cpp:146:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/math/3dtransforms.cpp:146:12: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/math/3dtransforms.cpp:165:9: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/math/coordinatetransformation.cpp:62:5: style: Class 'Impl' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/math/coordinatetransformation.cpp:102:50: performance:inconclusive: Function parameter 'coordinates' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/math/coordinatetransformation.cpp:112:64: performance:inconclusive: Function parameter 'coordinates' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/math/densityfittingforce.h:79:5: style: Class 'DensityFittingForce' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/math/exponentialmovingaverage.h:94:5: style: Class 'ExponentialMovingAverage' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/math/gausstransform.h:120:27: style:inconclusive: Technically the member function 'gmx::GaussianOn1DLattice::view' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/math/gausstransform.cpp:191:44: note: Technically the member function 'gmx::GaussianOn1DLattice::view' can be const. gromacs-2022-rc1/src/gromacs/math/gausstransform.h:120:27: note: Technically the member function 'gmx::GaussianOn1DLattice::view' can be const. gromacs-2022-rc1/src/gromacs/math/gausstransform.cpp:179:46: style:inconclusive: Function 'GaussianOn1DLattice' argument 1 names different: declaration 'numGridPointsForSpreadingHalfWidth' definition 'numGridPointsForSpreadingHalfWidth_'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/math/gausstransform.h:87:29: note: Function 'GaussianOn1DLattice' argument 1 names different: declaration 'numGridPointsForSpreadingHalfWidth' definition 'numGridPointsForSpreadingHalfWidth_'. gromacs-2022-rc1/src/gromacs/math/gausstransform.cpp:179:46: note: Function 'GaussianOn1DLattice' argument 1 names different: declaration 'numGridPointsForSpreadingHalfWidth' definition 'numGridPointsForSpreadingHalfWidth_'. gromacs-2022-rc1/src/gromacs/math/gausstransform.cpp:186:57: style:inconclusive: Function 'spread' argument 2 names different: declaration 'latticeOffset' definition 'dx'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/math/gausstransform.h:118:40: note: Function 'spread' argument 2 names different: declaration 'latticeOffset' definition 'dx'. gromacs-2022-rc1/src/gromacs/math/gausstransform.cpp:186:57: note: Function 'spread' argument 2 names different: declaration 'latticeOffset' definition 'dx'. gromacs-2022-rc1/src/gromacs/math/gausstransform.cpp:347:94: style:inconclusive: Function 'add' argument 1 names different: declaration 'localParamters' definition 'localParameters'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/math/gausstransform.cpp:323:74: note: Function 'add' argument 1 names different: declaration 'localParamters' definition 'localParameters'. gromacs-2022-rc1/src/gromacs/math/gausstransform.cpp:347:94: note: Function 'add' argument 1 names different: declaration 'localParamters' definition 'localParameters'. gromacs-2022-rc1/src/gromacs/math/gausstransform.cpp:398:81: style:inconclusive: Function 'GaussTransform3D' argument 2 names different: declaration 'globalParameters' definition 'kernelShapeParameters'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/math/gausstransform.h:175:67: note: Function 'GaussTransform3D' argument 2 names different: declaration 'globalParameters' definition 'kernelShapeParameters'. gromacs-2022-rc1/src/gromacs/math/gausstransform.cpp:398:81: note: Function 'GaussTransform3D' argument 2 names different: declaration 'globalParameters' definition 'kernelShapeParameters'. gromacs-2022-rc1/src/gromacs/math/do_fit.cpp:297:16: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/math/optimization.cpp:52:80: style:inconclusive: Function 'nelderMead' argument 2 names different: declaration 'initialGuess' definition 'initalGuess'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/math/optimization.h:124:80: note: Function 'nelderMead' argument 2 names different: declaration 'initialGuess' definition 'initalGuess'. gromacs-2022-rc1/src/gromacs/math/optimization.cpp:52:80: note: Function 'nelderMead' argument 2 names different: declaration 'initialGuess' definition 'initalGuess'. gromacs-2022-rc1/src/gromacs/math/tests/arrayrefwithpadding.cpp:68:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/math/tests/coordinatetransformation.cpp:87:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/math/tests/densityfit.cpp:79:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/math/tests/densityfittingforce.cpp:86:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/math/tests/dofit.cpp:71:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/math/tests/exponentialmovingaverage.cpp:64:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/math/tests/gausstransform.cpp:83:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/math/tests/functions.cpp:81:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/math/tests/invertmatrix.cpp:81:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/math/tests/matrix.cpp:76:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/math/tests/neldermead.cpp:81:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/math/tests/multidimarray.cpp:90:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/math/tests/optimization.cpp:75:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/math/tests/paddedvector.cpp:86:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/math/tests/vectypes.cpp:75:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/math/veccompare.cpp:137:12: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/math/veccompare.cpp:137:15: style: The scope of the variable 'm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/math/veccompare.cpp:138:12: style: The scope of the variable 'd' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/math/veccompare.cpp:138:15: style: The scope of the variable 'ssd' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/boxdeformation.h:69:10: style:inconclusive: Technically the member function 'gmx::BoxDeformation::apply' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/mdlib/boxdeformation.cpp:110:22: note: Technically the member function 'gmx::BoxDeformation::apply' can be const. gromacs-2022-rc1/src/gromacs/mdlib/boxdeformation.h:69:10: note: Technically the member function 'gmx::BoxDeformation::apply' can be const. gromacs-2022-rc1/src/gromacs/math/vecdump.cpp:51:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/math/vecdump.cpp:66:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/math/vecdump.cpp:66:12: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/math/vecdump.cpp:107:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/math/vecdump.cpp:122:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/math/vecdump.cpp:122:12: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/math/vecdump.cpp:176:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/math/vecdump.cpp:176:12: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/math/vecdump.cpp:203:17: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/math/vecdump.cpp:203:20: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/math/vecdump.cpp:240:17: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/math/vecdump.cpp:240:20: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/math/vecdump.cpp:105:93: style:inconclusive: Function 'pr_bvec' argument 6 names different: declaration 'bShowNnumbers' definition 'bShowNumbers'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/math/vecdump.h:48:93: note: Function 'pr_bvec' argument 6 names different: declaration 'bShowNnumbers' definition 'bShowNumbers'. gromacs-2022-rc1/src/gromacs/math/vecdump.cpp:105:93: note: Function 'pr_bvec' argument 6 names different: declaration 'bShowNnumbers' definition 'bShowNumbers'. gromacs-2022-rc1/src/gromacs/mdlib/compute_io.cpp:100:13: style: The scope of the variable 'nchars' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/compute_io.cpp:106:23: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/mdlib/compute_io.cpp:100:20: style: Variable 'nchars' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/mdlib/calc_verletbuf.cpp:852:20: style: The scope of the variable 'ib' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/calc_verletbuf.cpp:839:53: style:inconclusive: Function 'calcVerletBufferSize' argument 3 names different: declaration 'inputrec' definition 'ir'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdlib/calc_verletbuf.h:122:53: note: Function 'calcVerletBufferSize' argument 3 names different: declaration 'inputrec' definition 'ir'. gromacs-2022-rc1/src/gromacs/mdlib/calc_verletbuf.cpp:839:53: note: Function 'calcVerletBufferSize' argument 3 names different: declaration 'inputrec' definition 'ir'. gromacs-2022-rc1/src/gromacs/mdlib/calc_verletbuf.cpp:425:21: style: Local variable 'a' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/calc_verletbuf.cpp:332:55: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/calc_verletbuf.cpp:425:21: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/calc_verletbuf.cpp:1249:17: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/mdlib/energydrifttracker.h:62:5: style: Class 'EnergyDriftTracker' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/mdlib/enerdata_utils.cpp:284:26: style: Local variable 'dlam' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/enerdata_utils.cpp:279:22: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/enerdata_utils.cpp:284:26: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/enerdata_utils.cpp:176:21: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/mdlib/ebin.cpp:139:18: style: The scope of the variable 'm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/ebin.cpp:140:15: style: The scope of the variable 'e' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/ebin.cpp:140:18: style: The scope of the variable 'invmm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/ebin.cpp:140:25: style: The scope of the variable 'diff' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/ebin.cpp:141:20: style: The scope of the variable 'egs' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/coupling.cpp:409:31: style: The scope of the variable 'kT' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/coupling.cpp:411:13: style: The scope of the variable 'ivxi' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/coupling.cpp:411:20: style: The scope of the variable 'ixi' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/coupling.cpp:602:10: style: The scope of the variable 'n' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/coupling.cpp:602:13: style: The scope of the variable 'm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/coupling.cpp:1316:14: style: The scope of the variable 'bRandomize' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/coupling.cpp:1616:64: style:inconclusive: Function 'init_npt_vars' argument 3 names different: declaration 'Mass' definition 'MassQ'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdlib/coupling.h:159:64: note: Function 'init_npt_vars' argument 3 names different: declaration 'Mass' definition 'MassQ'. gromacs-2022-rc1/src/gromacs/mdlib/coupling.cpp:1616:64: note: Function 'init_npt_vars' argument 3 names different: declaration 'Mass' definition 'MassQ'. gromacs-2022-rc1/src/gromacs/mdlib/coupling.cpp:104:57: performance:inconclusive: Function parameter 'cTC' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/coupling.cpp:360:77: performance:inconclusive: Function parameter 'cTC' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/coupling.cpp:361:77: performance:inconclusive: Function parameter 'invMass' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/coupling.cpp:362:77: performance:inconclusive: Function parameter 'v' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/expanded.cpp:218:17: style: The scope of the variable 'totalsamples' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/expanded.cpp:334:14: style: The scope of the variable 'min_nvalm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/expanded.cpp:334:25: style: The scope of the variable 'min_nvalp' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/expanded.cpp:334:36: style: The scope of the variable 'maxc' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/expanded.cpp:338:14: style: The scope of the variable 'dwp_array' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/expanded.cpp:338:26: style: The scope of the variable 'dwm_array' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/expanded.cpp:340:13: style: The scope of the variable 'lam_variance' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/expanded.cpp:341:13: style: The scope of the variable 'p_k' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/expanded.cpp:1160:20: style: The scope of the variable 'ifep' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/expanded.cpp:1160:26: style: The scope of the variable 'jfep' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/expanded.cpp:1341:34: style: The scope of the variable 'totalsamples' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/expanded.cpp:1580:66: performance:inconclusive: Function parameter 'cTC' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/force.cpp:101:27: warning: Member variable 'CpuPpLongRangeNonbondeds::homenr_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/mdlib/force.cpp:101:27: warning: Member variable 'CpuPpLongRangeNonbondeds::havePerturbed_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/mdlib/forcerec.cpp:981:19: style: The scope of the variable 'fcdata' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/forcerec.cpp:306:21: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/mdlib/gmx_omp_nthreads.cpp:414:17: style: Condition 'nth_max==nth_min' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/mdlib/gmx_omp_nthreads.cpp:408:21: note: nth_max is assigned 'modth.gnth' here. gromacs-2022-rc1/src/gromacs/mdlib/gmx_omp_nthreads.cpp:407:21: note: nth_min is assigned 'modth.gnth' here. gromacs-2022-rc1/src/gromacs/mdlib/gmx_omp_nthreads.cpp:414:17: note: Condition 'nth_max==nth_min' is always true gromacs-2022-rc1/src/gromacs/mdlib/gpuforcereduction.h:93:10: performance:inconclusive: Technically the member function 'gmx::GpuForceReduction::registerNbnxmForce' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/gromacs/mdlib/gpuforcereduction_impl_stubs.cpp:79:25: note: Technically the member function 'gmx::GpuForceReduction::registerNbnxmForce' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/gromacs/mdlib/gpuforcereduction.h:93:10: note: Technically the member function 'gmx::GpuForceReduction::registerNbnxmForce' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/gromacs/mdlib/gpuforcereduction.h:99:10: performance:inconclusive: Technically the member function 'gmx::GpuForceReduction::registerRvecForce' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/gromacs/mdlib/gpuforcereduction_impl_stubs.cpp:85:25: note: Technically the member function 'gmx::GpuForceReduction::registerRvecForce' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/gromacs/mdlib/gpuforcereduction.h:99:10: note: Technically the member function 'gmx::GpuForceReduction::registerRvecForce' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/gromacs/mdlib/gmx_omp_nthreads.cpp:185:14: style: The scope of the variable 'buffer' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/gpuforcereduction.h:116:10: performance:inconclusive: Technically the member function 'gmx::GpuForceReduction::reinit' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/gromacs/mdlib/gpuforcereduction_impl_stubs.cpp:68:25: note: Technically the member function 'gmx::GpuForceReduction::reinit' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/gromacs/mdlib/gpuforcereduction.h:116:10: note: Technically the member function 'gmx::GpuForceReduction::reinit' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/gromacs/mdlib/gmx_omp_nthreads.cpp:447:49: style:inconclusive: Function 'gmx_omp_nthreads_init' argument 1 names different: declaration 'fplog' definition 'mdlog'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdlib/gmx_omp_nthreads.h:75:49: note: Function 'gmx_omp_nthreads_init' argument 1 names different: declaration 'fplog' definition 'mdlog'. gromacs-2022-rc1/src/gromacs/mdlib/gmx_omp_nthreads.cpp:447:49: note: Function 'gmx_omp_nthreads_init' argument 1 names different: declaration 'fplog' definition 'mdlog'. gromacs-2022-rc1/src/gromacs/mdlib/gpuforcereduction.h:124:10: performance:inconclusive: Technically the member function 'gmx::GpuForceReduction::execute' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/gromacs/mdlib/gpuforcereduction_impl_stubs.cpp:97:25: note: Technically the member function 'gmx::GpuForceReduction::execute' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/gromacs/mdlib/gpuforcereduction.h:124:10: note: Technically the member function 'gmx::GpuForceReduction::execute' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/gromacs/mdlib/gmx_omp_nthreads.cpp:453:49: style:inconclusive: Function 'gmx_omp_nthreads_init' argument 7 names different: declaration 'bCurrNodePMEOnly' definition 'bThisNodePMEOnly'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdlib/gmx_omp_nthreads.h:81:49: note: Function 'gmx_omp_nthreads_init' argument 7 names different: declaration 'bCurrNodePMEOnly' definition 'bThisNodePMEOnly'. gromacs-2022-rc1/src/gromacs/mdlib/gmx_omp_nthreads.cpp:453:49: note: Function 'gmx_omp_nthreads_init' argument 7 names different: declaration 'bCurrNodePMEOnly' definition 'bThisNodePMEOnly'. gromacs-2022-rc1/src/gromacs/mdlib/groupcoord.cpp:268:71: style:inconclusive: Function 'get_sum_of_positions' argument 3 names different: declaration 'nr' definition 'nat'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdlib/groupcoord.h:170:65: note: Function 'get_sum_of_positions' argument 3 names different: declaration 'nr' definition 'nat'. gromacs-2022-rc1/src/gromacs/mdlib/groupcoord.cpp:268:71: note: Function 'get_sum_of_positions' argument 3 names different: declaration 'nr' definition 'nat'. gromacs-2022-rc1/src/gromacs/mdlib/groupcoord.cpp:304:68: style:inconclusive: Function 'get_center' argument 4 names different: declaration 'center' definition 'rcenter'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdlib/groupcoord.h:154:62: note: Function 'get_center' argument 4 names different: declaration 'center' definition 'rcenter'. gromacs-2022-rc1/src/gromacs/mdlib/groupcoord.cpp:304:68: note: Function 'get_center' argument 4 names different: declaration 'center' definition 'rcenter'. gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:1103:21: style: Condition 'bDoDHDL' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:1031:31: note: Assuming that condition 'bDoDHDL' is not redundant gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:1103:21: note: Condition 'bDoDHDL' is always true gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:156:24: style: The scope of the variable 'pres_nm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:158:24: style: The scope of the variable 'surft_nm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:159:24: style: The scope of the variable 'mu_nm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:160:24: style: The scope of the variable 'vcos_nm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:161:24: style: The scope of the variable 'visc_nm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:165:29: style: The scope of the variable 'gnm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:167:29: style: The scope of the variable 'bufi' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:168:39: style: The scope of the variable 'nj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:644:17: style: The scope of the variable 'lambdastate' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:645:15: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:645:35: style: The scope of the variable 'nsetsbegin' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:648:39: style: The scope of the variable 'lambda_name_str' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:857:16: style: The scope of the variable 'kk' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:857:20: style: The scope of the variable 'n' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:857:23: style: The scope of the variable 'gid' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:848:64: style:inconclusive: Function 'addDataAtEnergyStep' argument 7 names different: declaration 'lastbox' definition 'box'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.h:192:54: note: Function 'addDataAtEnergyStep' argument 7 names different: declaration 'lastbox' definition 'box'. gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:848:64: note: Function 'addDataAtEnergyStep' argument 7 names different: declaration 'lastbox' definition 'box'. gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:656:15: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:645:15: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:656:15: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:761:19: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:645:15: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:761:19: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:809:25: style: Local variable 'buf' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:681:17: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:809:25: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:1384:25: style: Local variable 'padding' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:1366:17: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:1384:25: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:204:14: style: Consider using std::fill algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:347:14: style: Consider using std::fill algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:367:13: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:598:13: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/mdlib/energyoutput.cpp:660:13: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/mdlib/lincs_gpu.cpp:420:18: style: Local variable 'pair' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/lincs_gpu.cpp:407:14: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/lincs_gpu.cpp:420:18: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/lincs_gpu.cpp:334:13: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/mdlib/lincs_gpu_internal_sycl.cpp:325:20: style: Local variable 'dx' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/lincs_gpu_internal_sycl.cpp:248:16: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/lincs_gpu_internal_sycl.cpp:325:20: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/lincs_gpu_internal_sycl.cpp:344:19: style: Local variable 'sol' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/lincs_gpu_internal_sycl.cpp:251:15: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/lincs_gpu_internal_sycl.cpp:344:19: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/lincs_gpu_internal_sycl.cpp:377:24: style: Local variable 'tmp' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/lincs_gpu_internal_sycl.cpp:289:16: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/lincs_gpu_internal_sycl.cpp:377:24: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/lincs_gpu_internal_sycl.cpp:392:24: style: Local variable 'tmp' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/lincs_gpu_internal_sycl.cpp:289:16: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/lincs_gpu_internal_sycl.cpp:392:24: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:97:5: warning: Member variable 'AtomPair::index1' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:97:5: warning: Member variable 'AtomPair::index2' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:2159:24: style: The comparison 'simd_width > 1' is always false. [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:240:31: note: 'simd_width' is assigned value '1' here. gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:2159:24: note: The comparison 'simd_width > 1' is always false. gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:1466:52: style:inconclusive: Function 'init_lincs' argument 4 names different: declaration 'atomsToConstraintsPerMolType' definition 'atomToConstraintsPerMolType'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdlib/lincs.h:84:52: note: Function 'init_lincs' argument 4 names different: declaration 'atomsToConstraintsPerMolType' definition 'atomToConstraintsPerMolType'. gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:1466:52: note: Function 'init_lincs' argument 4 names different: declaration 'atomsToConstraintsPerMolType' definition 'atomToConstraintsPerMolType'. gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:2387:54: style:inconclusive: Function 'constrain_lincs' argument 8 names different: declaration 'x' definition 'xPadded'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdlib/lincs.h:112:54: note: Function 'constrain_lincs' argument 8 names different: declaration 'x' definition 'xPadded'. gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:2387:54: note: Function 'constrain_lincs' argument 8 names different: declaration 'x' definition 'xPadded'. gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:2388:54: style:inconclusive: Function 'constrain_lincs' argument 9 names different: declaration 'xprime' definition 'xprimePadded'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdlib/lincs.h:113:54: note: Function 'constrain_lincs' argument 9 names different: declaration 'xprime' definition 'xprimePadded'. gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:2388:54: note: Function 'constrain_lincs' argument 9 names different: declaration 'xprime' definition 'xprimePadded'. gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:1403:28: style: Local variable 'iap' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:1396:20: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:1403:28: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:1419:36: style: Local variable 'iap' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:1403:28: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:1419:36: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:986:54: performance:inconclusive: Function parameter 'invmass' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:1582:101: performance:inconclusive: Function parameter 'v' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:1973:46: performance:inconclusive: Function parameter 'invmass' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:2384:54: performance:inconclusive: Function parameter 'invmass' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:2389:54: performance:inconclusive: Function parameter 'min_proj' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/md_support.cpp:264:57: performance:inconclusive: Function parameter 'x' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:1714:53: error: Array index -1 is out of bounds. [negativeContainerIndex] gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:1719:30: note: Assignment 'b=-1', assigned value is -1 gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:1714:53: note: Negative array index gromacs-2022-rc1/src/gromacs/mdlib/md_support.cpp:265:57: performance:inconclusive: Function parameter 'v' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.h:101:5: style: Struct 't_mde_delta_h_coll' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:369:15: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:369:18: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:369:21: style: The scope of the variable 'n' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:370:15: style: The scope of the variable 'lambda_vec' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:109:13: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:82:9: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:109:13: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:259:26: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:225:13: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:259:26: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:390:19: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:369:15: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:390:19: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:400:19: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:369:15: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:400:19: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:448:23: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:369:15: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:448:23: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:520:23: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:369:15: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:520:23: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:540:23: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:369:15: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:540:23: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:555:23: style: Local variable 'j' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:369:18: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:555:23: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:394:17: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:544:21: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/mdlib/mdebin_bar.cpp:585:14: style: Variable 'n' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/mdlib/mdatoms.cpp:123:105: style:inconclusive: Function 'makeMDAtoms' argument 4 names different: declaration 'useGpuForPme' definition 'rankHasPmeGpuTask'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdlib/mdatoms.h:108:99: note: Function 'makeMDAtoms' argument 4 names different: declaration 'useGpuForPme' definition 'rankHasPmeGpuTask'. gromacs-2022-rc1/src/gromacs/mdlib/mdatoms.cpp:123:105: note: Function 'makeMDAtoms' argument 4 names different: declaration 'useGpuForPme' definition 'rankHasPmeGpuTask'. gromacs-2022-rc1/src/gromacs/mdlib/mdoutf.cpp:117:18: style: The scope of the variable 'appendMode' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/mdoutf.cpp:117:38: style: The scope of the variable 'writeMode' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/mdoutf.cpp:117:57: style: The scope of the variable 'filemode' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/mdoutf.cpp:119:18: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/mdoutf.cpp:413:14: style: Local variable 'buf' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/mdoutf.cpp:306:15: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/mdoutf.cpp:413:14: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/perf_est.cpp:206:17: style: The scope of the variable 'nbonds' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/rbin.cpp:73:16: style: The scope of the variable 'rest' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/rbin.cpp:108:16: style: The scope of the variable 'rest' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:279:19: style: The scope of the variable 'gid' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:386:20: style: The scope of the variable 'at' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:468:19: style: The scope of the variable 'c' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:468:22: style: The scope of the variable 'outsidesum' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:561:20: style: The scope of the variable 'k' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:567:14: style: The scope of the variable 'dist' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:723:24: style: The scope of the variable 'mol_id' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:723:32: style: The scope of the variable 'at' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:723:36: style: The scope of the variable 'block' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:852:15: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:852:21: style: The scope of the variable 'natom' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:852:28: style: The scope of the variable 'nmol' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:1025:23: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:1025:26: style: The scope of the variable 'rm_bonded_at' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:1025:40: style: The scope of the variable 'fr_id' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:1025:47: style: The scope of the variable 'fr_i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:1025:57: style: The scope of the variable 'tmp_id' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:1025:65: style: The scope of the variable 'warn' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:1026:23: style: The scope of the variable 'ng' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:1026:27: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:1026:30: style: The scope of the variable 'max_lip_rm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:1026:42: style: The scope of the variable 'ins_grp_id' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:1026:54: style: The scope of the variable 'ntype' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:1026:61: style: The scope of the variable 'lip_rm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:1029:32: style: The scope of the variable 'rest_at' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:1031:23: style: The scope of the variable 'mem_p' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:1032:23: style: The scope of the variable 'rm_p' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:1036:23: style: The scope of the variable 'pbc' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:606:38: style: Local variable 'k' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:561:20: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:606:38: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:676:26: style: Local variable 'k' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:561:20: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:676:26: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:970:29: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:922:11: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:970:29: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:1355:21: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:1025:23: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:1355:21: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:608:39: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:678:27: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/mdlib/membed.cpp:1110:20: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/mdlib/settle.cpp:155:13: warning: Member variable 'SettleData::numSettles_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/mdlib/settle.h:121:5: style: Class 'SettleData' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/mdlib/settle_gpu_internal_sycl.cpp:386:63: style:inconclusive: Function 'launchSettleGpuKernel' argument 2 names different: declaration 'd_atomIds' definition 'd_settles'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdlib/settle_gpu_internal.h:77:63: note: Function 'launchSettleGpuKernel' argument 2 names different: declaration 'd_atomIds' definition 'd_settles'. gromacs-2022-rc1/src/gromacs/mdlib/settle_gpu_internal_sycl.cpp:386:63: note: Function 'launchSettleGpuKernel' argument 2 names different: declaration 'd_atomIds' definition 'd_settles'. gromacs-2022-rc1/src/gromacs/mdlib/settle.cpp:279:39: style: The scope of the variable 'ow1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/settle.cpp:279:44: style: The scope of the variable 'hw2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/settle.cpp:279:49: style: The scope of the variable 'hw3' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/settle.cpp:114:29: warning: Function 'settleParameters' argument order different: declaration 'mO, mH, dOH, invmO, invmH, dHH' definition 'mO, mH, invmO, invmH, dOH, dHH' [funcArgOrderDifferent] gromacs-2022-rc1/src/gromacs/mdlib/settle.h:112:40: note: Function 'settleParameters' argument order different: declaration 'mO, mH, dOH, invmO, invmH, dHH' definition 'mO, mH, invmO, invmH, dOH, dHH' gromacs-2022-rc1/src/gromacs/mdlib/settle.cpp:114:29: note: Function 'settleParameters' argument order different: declaration 'mO, mH, dOH, invmO, invmH, dHH' definition 'mO, mH, invmO, invmH, dOH, dHH' gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:395:60: style: The comparison 'error == 0' is always true. [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:392:17: note: 'error' is assigned value '0' here. gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:395:60: note: The comparison 'error == 0' is always true. gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:398:48: style: The comparison 'error == 0' is always true. [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:392:17: note: 'error' is assigned value '0' here. gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:398:48: note: The comparison 'error == 0' is always true. gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:643:10: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:643:14: style: The scope of the variable 'aj' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:720:13: style: The scope of the variable 'n0' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:720:23: style: The scope of the variable 'blen' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:720:29: style: The scope of the variable 'type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:280:34: style:inconclusive: Function 'cshake' argument 5 names different: declaration 'dist2' definition 'constraint_distance_squared'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdlib/shake.h:135:34: note: Function 'cshake' argument 5 names different: declaration 'dist2' definition 'constraint_distance_squared'. gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:280:34: note: Function 'cshake' argument 5 names different: declaration 'dist2' definition 'constraint_distance_squared'. gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:281:34: style:inconclusive: Function 'cshake' argument 6 names different: declaration 'xp' definition 'positions'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdlib/shake.h:136:34: note: Function 'cshake' argument 6 names different: declaration 'xp' definition 'positions'. gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:281:34: note: Function 'cshake' argument 6 names different: declaration 'xp' definition 'positions'. gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:283:34: style:inconclusive: Function 'cshake' argument 8 names different: declaration 'rij' definition 'initial_displacements'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdlib/shake.h:138:34: note: Function 'cshake' argument 8 names different: declaration 'rij' definition 'initial_displacements'. gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:283:34: note: Function 'cshake' argument 8 names different: declaration 'rij' definition 'initial_displacements'. gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:450:49: performance:inconclusive: Function parameter 'prime' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:703:51: performance:inconclusive: Function parameter 'invmass' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:706:51: performance:inconclusive: Function parameter 'x_s' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:707:51: performance:inconclusive: Function parameter 'prime' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:825:52: performance:inconclusive: Function parameter 'invmass' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:828:52: performance:inconclusive: Function parameter 'x_s' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:829:52: performance:inconclusive: Function parameter 'xprime' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:830:52: performance:inconclusive: Function parameter 'vprime' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/shake.cpp:836:52: performance:inconclusive: Function parameter 'v' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/simulationsignal.h:149:10: style:inconclusive: Technically the member function 'gmx::SimulationSignaller::setSignals' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/mdlib/simulationsignal.cpp:119:27: note: Technically the member function 'gmx::SimulationSignaller::setSignals' can be const. gromacs-2022-rc1/src/gromacs/mdlib/simulationsignal.h:149:10: note: Technically the member function 'gmx::SimulationSignaller::setSignals' can be const. gromacs-2022-rc1/src/gromacs/mdlib/simulationsignal.h:96:5: style: Class 'SimulationSignal' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/mdlib/splitter.cpp:248:30: style: The scope of the variable 'isid' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/tests/calc_verletbuf.cpp:74:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdlib/tests/calcvir.cpp:88:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdlib/tests/constr.cpp:360:35: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdlib/tests/constrtestdata.cpp:79:5: performance: Variable 'title_' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] gromacs-2022-rc1/src/gromacs/mdlib/tests/constrtestdata.cpp:83:5: performance: Variable 'masses_' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] gromacs-2022-rc1/src/gromacs/mdlib/tests/constrtestdata.cpp:123:23: style: Variable 'ir_.efep' is reassigned a value before the old one has been used. [redundantAssignment] gromacs-2022-rc1/src/gromacs/mdlib/tests/constrtestdata.cpp:98:17: note: ir_.efep is assigned gromacs-2022-rc1/src/gromacs/mdlib/tests/constrtestdata.cpp:123:23: note: ir_.efep is overwritten gromacs-2022-rc1/src/gromacs/mdlib/tests/constrtestrunners.h:137:5: style: Class 'LincsDeviceConstraintsRunner' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/mdlib/tests/constrtestrunners.cpp:130:19: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/mdlib/tests/ebin.cpp:88:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdlib/tests/energydrifttracker.cpp:63:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdlib/tests/energyoutput.cpp:578:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdlib/tests/expanded.cpp:72:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdlib/tests/freeenergyparameters.cpp:152:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdlib/tests/leapfrog.cpp:206:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdlib/tests/leapfrogtestrunners.h:121:5: style: Class 'LeapFrogDeviceTestRunner' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/mdlib/tests/settle.cpp:309:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdlib/tests/settletestdata.h:106:5: style: Class 'SettleTestData' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/mdlib/tests/settletestdata.cpp:107:14: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/tests/settletestdata.cpp:89:16: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/tests/settletestdata.cpp:107:14: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/tests/settletestdata.cpp:127:14: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdlib/tests/settletestdata.cpp:89:16: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/tests/settletestdata.cpp:127:14: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/tests/settletestrunners.h:137:5: style: Class 'SettleDeviceTestRunner' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/mdlib/tests/settletestrunners.cpp:61:59: performance:inconclusive: Function parameter 'pbc' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/tests/shake.cpp:252:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdlib/tests/simulationsignal.cpp:77:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdlib/tests/updategroupscog.cpp:78:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdlib/tests/updategroups.cpp:172:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdlib/tests/wholemoleculetransform.cpp:101:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdlib/tgroup.cpp:53:19: style: The scope of the variable 'tcstat' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdlib/tgroup.cpp:49:86: style:inconclusive: Function 'sum_ekin' argument 4 names different: declaration 'bEkinFullStep' definition 'bEkinAveVel'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdlib/tgroup.h:45:86: note: Function 'sum_ekin' argument 4 names different: declaration 'bEkinFullStep' definition 'bEkinAveVel'. gromacs-2022-rc1/src/gromacs/mdlib/tgroup.cpp:49:86: note: Function 'sum_ekin' argument 4 names different: declaration 'bEkinFullStep' definition 'bEkinAveVel'. gromacs-2022-rc1/src/gromacs/mdlib/sim_util.cpp:2019:28: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/mdlib/update_constrain_gpu_internal.h:63:5: style: Struct 'ScalingMatrix' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/mdlib/update_constrain_gpu_internal_sycl.cpp:61:79: performance: Function parameter 'scalingMatrix' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/updategroupscog.cpp:115:23: style: Local variable 'cogIndex' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/mdlib/updategroupscog.h:112:9: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/updategroupscog.cpp:115:23: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/updategroups.cpp:485:21: style: Consider using std::count_if algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/mdlib/vsite.cpp:352:1: error: There is an unknown macro here somewhere. Configuration is required. If GCC_DIAGNOSTIC_IGNORE is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/mdlib/update.cpp:1599:83: style:inconclusive: Function 'update_coords' argument 13 names different: declaration 'UpdatePart' definition 'updatePart'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdlib/update.cpp:128:73: note: Function 'update_coords' argument 13 names different: declaration 'UpdatePart' definition 'updatePart'. gromacs-2022-rc1/src/gromacs/mdlib/update.cpp:1599:83: note: Function 'update_coords' argument 13 names different: declaration 'UpdatePart' definition 'updatePart'. gromacs-2022-rc1/src/gromacs/mdlib/update.cpp:1546:10: style: Local variable 'xp' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/mdlib/update.cpp:169:25: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdlib/update.cpp:1546:10: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdlib/vcm.cpp:69:5: performance: Variable 'mode' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] gromacs-2022-rc1/src/gromacs/mdlib/vcm.cpp:612:54: performance:inconclusive: Function parameter 'x' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/vcm.cpp:613:54: performance:inconclusive: Function parameter 'v' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/wall.cpp:171:51: performance:inconclusive: Function parameter 'typeA' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/wall.cpp:172:51: performance:inconclusive: Function parameter 'typeB' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdlib/wall.cpp:248:38: error: Uninitialized variable: ntw [uninitvar] gromacs-2022-rc1/src/gromacs/mdlib/wall.cpp:194:23: note: Assuming condition is false gromacs-2022-rc1/src/gromacs/mdlib/wall.cpp:248:38: note: Uninitialized variable: ntw gromacs-2022-rc1/src/gromacs/mdrun/mdmodules.h:189:31: style:inconclusive: Technically the member function 'gmx::MDModules::notifiers' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/mdrun/mdmodules.cpp:201:38: note: Technically the member function 'gmx::MDModules::notifiers' can be const. gromacs-2022-rc1/src/gromacs/mdrun/mdmodules.h:189:31: note: Technically the member function 'gmx::MDModules::notifiers' can be const. gromacs-2022-rc1/src/gromacs/mdrun/mimic.cpp:147:23: style: The scope of the variable 't' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/mimic.cpp:150:23: style: The scope of the variable 'force_flags' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/mimic.cpp:157:12: style: The scope of the variable 'cycles' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/md.cpp:171:18: style: The scope of the variable 't' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/md.cpp:177:18: style: The scope of the variable 'force_flags' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/md.cpp:179:15: style: The scope of the variable 'm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/md.cpp:192:15: style: The scope of the variable 'cycles' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/md.cpp:196:15: style: The scope of the variable 'sbuf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/md.cpp:196:34: style: The scope of the variable 'sbuf2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/md.cpp:202:10: style: The scope of the variable 'bInteractiveMDstep' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/md.cpp:1042:17: style: Local variable 'cglo_flags' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdrun/md.cpp:625:18: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdrun/md.cpp:1042:17: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdrun/md.cpp:202:29: style: Variable 'bInteractiveMDstep' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/mdrun/replicaexchange.cpp:513:11: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/replicaexchange.cpp:544:13: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/replicaexchange.cpp:573:11: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/replicaexchange.cpp:574:11: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/replicaexchange.cpp:871:40: style: The scope of the variable 'm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/replicaexchange.cpp:871:46: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/replicaexchange.cpp:871:55: style: The scope of the variable 'ap' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/replicaexchange.cpp:871:59: style: The scope of the variable 'bp' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/replicaexchange.cpp:871:63: style: The scope of the variable 'i0' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/replicaexchange.cpp:871:67: style: The scope of the variable 'i1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/replicaexchange.cpp:1212:12: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/replicaexchange.cpp:1269:9: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/replicaexchange.cpp:1271:9: style: The scope of the variable 'exchange_partner' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/replicaexchange.cpp:1353:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/replicaexchange.cpp:625:60: style: Parameter 'dest' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/gromacs/mdrun/replicaexchange.cpp:641:11: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/mdrun/rerun.cpp:181:23: style: The scope of the variable 'force_flags' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/rerun.cpp:190:12: style: The scope of the variable 'cycles' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/minimize.cpp:3395:35: style: Variable 'state_work_x[atom][d]' is reassigned a value before the old one has been used. [redundantAssignment] gromacs-2022-rc1/src/gromacs/mdrun/minimize.cpp:3333:43: note: state_work_x[atom][d] is assigned gromacs-2022-rc1/src/gromacs/mdrun/minimize.cpp:3395:35: note: state_work_x[atom][d] is overwritten gromacs-2022-rc1/src/gromacs/mdrun/minimize.cpp:3395:35: style: Variable 'state_work_x[atom][d]' is reassigned a value before the old one has been used. [redundantAssignment] gromacs-2022-rc1/src/gromacs/mdrun/minimize.cpp:3337:43: note: state_work_x[atom][d] is assigned gromacs-2022-rc1/src/gromacs/mdrun/minimize.cpp:3395:35: note: state_work_x[atom][d] is overwritten gromacs-2022-rc1/src/gromacs/mdrun/minimize.cpp:273:42: style: The scope of the variable 'm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/minimize.cpp:273:45: style: The scope of the variable 'gf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/minimize.cpp:2221:14: style: Local variable 'step' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdrun/minimize.cpp:2016:9: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdrun/minimize.cpp:2221:14: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdrun/simulationinput.cpp:52:61: style:inconclusive: Function 'applyGlobalSimulationState' argument 4 names different: declaration 'inputrec' definition 'inputRecord'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdrun/simulationinput.h:118:61: note: Function 'applyGlobalSimulationState' argument 4 names different: declaration 'inputrec' definition 'inputRecord'. gromacs-2022-rc1/src/gromacs/mdrun/simulationinput.cpp:52:61: note: Function 'applyGlobalSimulationState' argument 4 names different: declaration 'inputrec' definition 'inputRecord'. gromacs-2022-rc1/src/gromacs/mdrun/simulationinput.cpp:53:61: style:inconclusive: Function 'applyGlobalSimulationState' argument 5 names different: declaration 'globalTopology' definition 'molecularTopology'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdrun/simulationinput.h:119:61: note: Function 'applyGlobalSimulationState' argument 5 names different: declaration 'globalTopology' definition 'molecularTopology'. gromacs-2022-rc1/src/gromacs/mdrun/simulationinput.cpp:53:61: note: Function 'applyGlobalSimulationState' argument 5 names different: declaration 'globalTopology' definition 'molecularTopology'. gromacs-2022-rc1/src/gromacs/mdrun/simulationinput.cpp:63:53: style:inconclusive: Function 'applyLocalState' argument 5 names different: declaration 'ir' definition 'inputRecord'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdrun/simulationinput.h:156:53: note: Function 'applyLocalState' argument 5 names different: declaration 'ir' definition 'inputRecord'. gromacs-2022-rc1/src/gromacs/mdrun/simulationinput.cpp:63:53: note: Function 'applyLocalState' argument 5 names different: declaration 'ir' definition 'inputRecord'. gromacs-2022-rc1/src/gromacs/mdrun/simulationinput.cpp:67:53: style:inconclusive: Function 'applyLocalState' argument 9 names different: declaration 'notifiers' definition 'mdModulesNotifiers'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdrun/simulationinput.h:160:53: note: Function 'applyLocalState' argument 9 names different: declaration 'notifiers' definition 'mdModulesNotifiers'. gromacs-2022-rc1/src/gromacs/mdrun/simulationinput.cpp:67:53: note: Function 'applyLocalState' argument 9 names different: declaration 'notifiers' definition 'mdModulesNotifiers'. gromacs-2022-rc1/src/gromacs/mdrun/shellfc.cpp:833:16: style: The scope of the variable 'w_dt' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/shellfc.cpp:936:56: style:inconclusive: Function 'relax_shell_flexcon' argument 1 names different: declaration 'log' definition 'fplog'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdrun/shellfc.h:96:62: note: Function 'relax_shell_flexcon' argument 1 names different: declaration 'log' definition 'fplog'. gromacs-2022-rc1/src/gromacs/mdrun/shellfc.cpp:936:56: note: Function 'relax_shell_flexcon' argument 1 names different: declaration 'log' definition 'fplog'. gromacs-2022-rc1/src/gromacs/mdrun/shellfc.cpp:951:56: style:inconclusive: Function 'relax_shell_flexcon' argument 16 names different: declaration 'x' definition 'xPadded'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdrun/shellfc.h:111:62: note: Function 'relax_shell_flexcon' argument 16 names different: declaration 'x' definition 'xPadded'. gromacs-2022-rc1/src/gromacs/mdrun/shellfc.cpp:951:56: note: Function 'relax_shell_flexcon' argument 16 names different: declaration 'x' definition 'xPadded'. gromacs-2022-rc1/src/gromacs/mdrun/shellfc.cpp:952:56: style:inconclusive: Function 'relax_shell_flexcon' argument 17 names different: declaration 'v' definition 'vPadded'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdrun/shellfc.h:112:62: note: Function 'relax_shell_flexcon' argument 17 names different: declaration 'v' definition 'vPadded'. gromacs-2022-rc1/src/gromacs/mdrun/shellfc.cpp:952:56: note: Function 'relax_shell_flexcon' argument 17 names different: declaration 'v' definition 'vPadded'. gromacs-2022-rc1/src/gromacs/mdrun/shellfc.cpp:1347:47: style:inconclusive: Function 'done_shellfc' argument 2 names different: declaration 'shellfc' definition 'shfc'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdrun/shellfc.h:131:47: note: Function 'done_shellfc' argument 2 names different: declaration 'shellfc' definition 'shfc'. gromacs-2022-rc1/src/gromacs/mdrun/shellfc.cpp:1347:47: note: Function 'done_shellfc' argument 2 names different: declaration 'shellfc' definition 'shfc'. gromacs-2022-rc1/src/gromacs/mdrun/shellfc.cpp:306:23: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdrun/shellfc.cpp:243:10: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdrun/shellfc.cpp:306:23: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdrun/shellfc.cpp:157:54: performance:inconclusive: Function parameter 'v' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdrun/shellfc.cpp:280:16: error: Uninitialized struct member: shfc.numForceEvaluations [uninitStructMember] gromacs-2022-rc1/src/gromacs/mdrun/shellfc.cpp:280:16: error: Uninitialized struct member: shfc.numConvergedIterations [uninitStructMember] gromacs-2022-rc1/src/gromacs/mdrun/simulatorbuilder.h:290:5: style: Class 'IonSwapping' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/mdrun/simulatorbuilder.h:326:5: style: Class 'BoxDeformationHandle' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/mdrun/tpi.cpp:123:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/tpi.cpp:171:52: style: The scope of the variable 'V' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/tpi.cpp:180:40: style: The scope of the variable 'frame_step' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrunutility/tests/threadaffinity.cpp:54:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdrun/tpi.cpp:181:50: style: The scope of the variable 'step' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/tpi.cpp:185:23: style: The scope of the variable 'ptr' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/tpi.cpp:185:41: style: The scope of the variable 'leg' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrunutility/tests/threadaffinity_mpi.cpp:69:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdrun/tpi.cpp:191:51: style: The scope of the variable 'logV' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/tpi.cpp:191:57: style: The scope of the variable 'bUlogV' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrunutility/printtime.cpp:58:12: style: The scope of the variable 'dt' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/tpi.cpp:193:23: style: The scope of the variable 'tpid_leg' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrunutility/printtime.cpp:58:16: style: The scope of the variable 'elapsed_seconds' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/tpi.cpp:601:14: style: Local variable 'x' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdrun/tpi.cpp:320:10: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdrun/tpi.cpp:601:14: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdrunutility/printtime.cpp:58:33: style: The scope of the variable 'time_per_step' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrunutility/printtime.cpp:110:32: style:inconclusive: Function 'print_date_and_time' argument 1 names different: declaration 'log' definition 'fplog'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdrunutility/printtime.h:68:32: note: Function 'print_date_and_time' argument 1 names different: declaration 'log' definition 'fplog'. gromacs-2022-rc1/src/gromacs/mdrunutility/printtime.cpp:110:32: note: Function 'print_date_and_time' argument 1 names different: declaration 'log' definition 'fplog'. gromacs-2022-rc1/src/gromacs/mdrunutility/printtime.cpp:110:43: style:inconclusive: Function 'print_date_and_time' argument 2 names different: declaration 'rank' definition 'nodeid'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdrunutility/printtime.h:68:41: note: Function 'print_date_and_time' argument 2 names different: declaration 'rank' definition 'nodeid'. gromacs-2022-rc1/src/gromacs/mdrunutility/printtime.cpp:110:43: note: Function 'print_date_and_time' argument 2 names different: declaration 'rank' definition 'nodeid'. gromacs-2022-rc1/src/gromacs/mdrunutility/multisim.cpp:359:26: style: The comparison 'rank == 0' is always true. [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/mdrunutility/multisim.cpp:355:24: note: 'rank' is assigned value '0' here. gromacs-2022-rc1/src/gromacs/mdrunutility/multisim.cpp:359:26: note: The comparison 'rank == 0' is always true. gromacs-2022-rc1/src/gromacs/mdrunutility/handlerestart.cpp:346:21: style: Local variable 'logFilename' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/mdrunutility/handlerestart.cpp:295:17: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdrunutility/handlerestart.cpp:346:21: note: Shadow variable gromacs-2022-rc1/src/gromacs/mdspan/tests/accessor_policy.cpp:58:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdspan/tests/extensions.cpp:73:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdrunutility/threadaffinity.cpp:370:35: style: Condition 'nthread_local>1' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/mdrunutility/threadaffinity.cpp:364:27: note: Assuming that condition 'nthread_local>1' is not redundant gromacs-2022-rc1/src/gromacs/mdrunutility/threadaffinity.cpp:370:35: note: Condition 'nthread_local>1' is always true gromacs-2022-rc1/src/gromacs/mdspan/tests/extents.cpp:159:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdspan/tests/layouts.cpp:135:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdspan/tests/mdspan.cpp:281:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdtypes/checkpointdata.cpp:83:14: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/mdtypes/forcebuffers.h:100:31: style:inconclusive: Technically the member function 'gmx::ForceBuffersView::forceWithPadding' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/mdtypes/forcebuffers.h:117:31: style:inconclusive: Technically the member function 'gmx::ForceBuffersView::forceMtsCombinedWithPadding' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/mdtypes/df_history.cpp:45:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdtypes/df_history.cpp:119:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdtypes/iforceprovider.h:93:45: performance:inconclusive: Function parameter 'x' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdtypes/iforceprovider.h:95:45: performance:inconclusive: Function parameter 'chargeA' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdtypes/iforceprovider.h:96:45: performance:inconclusive: Function parameter 'massT' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/mdtypes/iforceprovider.h:119:26: style: Parameter 'ptr' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/gromacs/mdtypes/tests/checkpointdata.cpp:463:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdtypes/tests/forcebuffers.cpp:58:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdtypes/tests/multipletimestepping.cpp:85:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdtypes/interaction_const.h:118:9: style: Struct 'SoftCoreParameters' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/mdtypes/tests/observablesreducer.cpp:71:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/mdtypes/threaded_force_buffer.h:144:20: style:inconclusive: Technically the member function 'ThreadForceBuffer < RVec >::shiftForces' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/mdtypes/inputrec.cpp:90:13: warning: Member variable 't_inputrec::opts' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/mdtypes/threaded_force_buffer.h:147:20: style:inconclusive: Technically the member function 'ThreadForceBuffer < RVec >::energyTerms' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/mdtypes/threaded_force_buffer.h:144:20: style:inconclusive: Technically the member function 'ThreadForceBuffer < rvec4 >::shiftForces' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/mdtypes/threaded_force_buffer.h:147:20: style:inconclusive: Technically the member function 'ThreadForceBuffer < rvec4 >::energyTerms' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/mdtypes/threaded_force_buffer.cpp:258:22: style: Local variable 'threadForceBuffer' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/mdtypes/threaded_force_buffer.h:203:48: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/mdtypes/threaded_force_buffer.cpp:258:22: note: Shadow variable gromacs-2022-rc1/src/gromacs/modularsimulator/statepropagatordata.h:176:5: warning: Member variable 'StatePropagatorData::totalNumAtoms_' is not initialized in the constructor. [uninitMemberVarPrivate] gromacs-2022-rc1/src/gromacs/modularsimulator/statepropagatordata.h:176:5: warning: Member variable 'StatePropagatorData::localNAtoms_' is not initialized in the constructor. [uninitMemberVarPrivate] gromacs-2022-rc1/src/gromacs/modularsimulator/statepropagatordata.h:176:5: warning: Member variable 'StatePropagatorData::ddpCount_' is not initialized in the constructor. [uninitMemberVarPrivate] gromacs-2022-rc1/src/gromacs/modularsimulator/statepropagatordata.h:176:5: warning: Member variable 'StatePropagatorData::ddpCountCgGl_' is not initialized in the constructor. [uninitMemberVarPrivate] gromacs-2022-rc1/src/gromacs/modularsimulator/statepropagatordata.h:176:5: warning: Member variable 'StatePropagatorData::vvResetVelocities_' is not initialized in the constructor. [uninitMemberVarPrivate] gromacs-2022-rc1/src/gromacs/modularsimulator/statepropagatordata.h:176:5: warning: Member variable 'StatePropagatorData::isRegularSimulationEnd_' is not initialized in the constructor. [uninitMemberVarPrivate] gromacs-2022-rc1/src/gromacs/modularsimulator/statepropagatordata.h:176:5: warning: Member variable 'StatePropagatorData::lastStep_' is not initialized in the constructor. [uninitMemberVarPrivate] gromacs-2022-rc1/src/gromacs/modularsimulator/statepropagatordata.h:176:5: warning: Member variable 'StatePropagatorData::globalState_' is not initialized in the constructor. [uninitMemberVarPrivate] gromacs-2022-rc1/src/gromacs/modularsimulator/statepropagatordata.h:176:5: warning: Member variable 'StatePropagatorData::localState_' is not initialized in the constructor. [uninitMemberVarPrivate] gromacs-2022-rc1/src/gromacs/mdrun/runner.cpp:2367:5: performance: Variable 'libraryWorldCommunicator_' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] gromacs-2022-rc1/src/gromacs/modularsimulator/simulatoralgorithm.h:326:5: style: Class 'ModularSimulatorAlgorithmBuilderHelper' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/mdrun/runner.cpp:2368:5: performance: Variable 'simulationCommunicator_' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] gromacs-2022-rc1/src/gromacs/mdrun/runner.h:180:10: performance:inconclusive: Technically the member function 'gmx::Mdrunner::spawnThreads' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/gromacs/mdrun/runner.cpp:435:16: note: Technically the member function 'gmx::Mdrunner::spawnThreads' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/gromacs/mdrun/runner.h:180:10: note: Technically the member function 'gmx::Mdrunner::spawnThreads' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/gromacs/modularsimulator/andersentemperaturecoupling.cpp:70:79: performance:inconclusive: Function parameter 'referenceTemperature' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/modularsimulator/andersentemperaturecoupling.cpp:71:79: performance:inconclusive: Function parameter 'couplingTime' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/modularsimulator/signallers.h:497:16: style: Variable 'client' can be declared as reference to const [constVariable] gromacs-2022-rc1/src/gromacs/modularsimulator/domdechelper.h:198:23: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/mdtypes/inputrec.cpp:149:10: style: The scope of the variable 'g' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdtypes/inputrec.cpp:563:9: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdtypes/inputrec.cpp:824:17: style: The scope of the variable 'infbuf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdtypes/state.cpp:70:14: warning: Member variable 'ekinstate_t::hasReadEkinState' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/mdtypes/state.cpp:383:5: performance: Variable 'lambda' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] gromacs-2022-rc1/src/gromacs/mdrun/runner.cpp:662:12: style: The scope of the variable 'delta_t' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/mdrun/runner.cpp:2226:71: style:inconclusive: Function 'addPotential' argument 1 names different: declaration 'restraint' definition 'puller'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/mdrun/runner.h:171:60: note: Function 'addPotential' argument 1 names different: declaration 'restraint' definition 'puller'. gromacs-2022-rc1/src/gromacs/mdrun/runner.cpp:2226:71: note: Function 'addPotential' argument 1 names different: declaration 'restraint' definition 'puller'. gromacs-2022-rc1/src/gromacs/modularsimulator/firstorderpressurecoupling.h:132:10: style:inconclusive: Technically the member function 'gmx::FirstOrderPressureCoupling::conservedEnergyContribution' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/modularsimulator/firstorderpressurecoupling.cpp:138:34: note: Technically the member function 'gmx::FirstOrderPressureCoupling::conservedEnergyContribution' can be const. gromacs-2022-rc1/src/gromacs/modularsimulator/firstorderpressurecoupling.h:132:10: note: Technically the member function 'gmx::FirstOrderPressureCoupling::conservedEnergyContribution' can be const. gromacs-2022-rc1/src/gromacs/modularsimulator/firstorderpressurecoupling.cpp:107:102: style:inconclusive: Function 'scheduleTask' argument 3 names different: declaration 'function' definition 'registerRunFunction'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/modularsimulator/firstorderpressurecoupling.h:86:72: note: Function 'scheduleTask' argument 3 names different: declaration 'function' definition 'registerRunFunction'. gromacs-2022-rc1/src/gromacs/modularsimulator/firstorderpressurecoupling.cpp:107:102: note: Function 'scheduleTask' argument 3 names different: declaration 'function' definition 'registerRunFunction'. gromacs-2022-rc1/src/gromacs/modularsimulator/freeenergyperturbationdata.h:84:20: style:inconclusive: Technically the member function 'gmx::FreeEnergyPerturbationData::lambdaView' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/modularsimulator/freeenergyperturbationdata.cpp:124:44: note: Technically the member function 'gmx::FreeEnergyPerturbationData::lambdaView' can be const. gromacs-2022-rc1/src/gromacs/modularsimulator/freeenergyperturbationdata.h:84:20: note: Technically the member function 'gmx::FreeEnergyPerturbationData::lambdaView' can be const. gromacs-2022-rc1/src/gromacs/modularsimulator/energydata.cpp:188:24: style: Condition 'isMasterRank_' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/modularsimulator/energydata.cpp:177:9: note: Assuming that condition '!isMasterRank_' is not redundant gromacs-2022-rc1/src/gromacs/modularsimulator/energydata.cpp:188:24: note: Condition 'isMasterRank_' is always true gromacs-2022-rc1/src/gromacs/modularsimulator/energydata.cpp:160:61: style:inconclusive: Function 'trajectoryWriterSetup' argument 1 names different: declaration 'mdoutf' definition 'outf'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/modularsimulator/energydata.h:424:44: note: Function 'trajectoryWriterSetup' argument 1 names different: declaration 'mdoutf' definition 'outf'. gromacs-2022-rc1/src/gromacs/modularsimulator/energydata.cpp:160:61: note: Function 'trajectoryWriterSetup' argument 1 names different: declaration 'mdoutf' definition 'outf'. gromacs-2022-rc1/src/gromacs/modularsimulator/energydata.cpp:165:36: style:inconclusive: Function 'setup' argument 1 names different: declaration 'mdoutf' definition 'outf'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/modularsimulator/energydata.h:240:28: note: Function 'setup' argument 1 names different: declaration 'mdoutf' definition 'outf'. gromacs-2022-rc1/src/gromacs/modularsimulator/energydata.cpp:165:36: note: Function 'setup' argument 1 names different: declaration 'mdoutf' definition 'outf'. gromacs-2022-rc1/src/gromacs/modularsimulator/mttk.cpp:168:11: warning:inconclusive: Member variable 'MttkData::referenceTemperature_' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] gromacs-2022-rc1/src/gromacs/modularsimulator/mttk.cpp:168:11: warning:inconclusive: Member variable 'MttkData::identifier_' is not assigned in the copy constructor. Should it be copied? [missingMemberCopy] gromacs-2022-rc1/src/gromacs/modularsimulator/mttk.h:236:10: style:inconclusive: Technically the member function 'gmx::MttkPropagatorConnection::setPositionScaling' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/modularsimulator/mttk.cpp:396:32: note: Technically the member function 'gmx::MttkPropagatorConnection::setPositionScaling' can be const. gromacs-2022-rc1/src/gromacs/modularsimulator/mttk.h:236:10: note: Technically the member function 'gmx::MttkPropagatorConnection::setPositionScaling' can be const. gromacs-2022-rc1/src/gromacs/modularsimulator/mttk.h:238:10: style:inconclusive: Technically the member function 'gmx::MttkPropagatorConnection::setVelocityScaling' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/modularsimulator/mttk.cpp:408:32: note: Technically the member function 'gmx::MttkPropagatorConnection::setVelocityScaling' can be const. gromacs-2022-rc1/src/gromacs/modularsimulator/mttk.h:238:10: note: Technically the member function 'gmx::MttkPropagatorConnection::setVelocityScaling' can be const. gromacs-2022-rc1/src/gromacs/modularsimulator/mttk.cpp:75:16: style: Local variable 'referencePressure' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/modularsimulator/mttk.h:136:10: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/modularsimulator/mttk.cpp:75:16: note: Shadow variable gromacs-2022-rc1/src/gromacs/modularsimulator/pmeloadbalancehelper.h:104:33: style:inconclusive: Technically the member function 'gmx::PmeLoadBalanceHelper::loadBalancingObject' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/modularsimulator/pmeloadbalancehelper.cpp:136:51: note: Technically the member function 'gmx::PmeLoadBalanceHelper::loadBalancingObject' can be const. gromacs-2022-rc1/src/gromacs/modularsimulator/pmeloadbalancehelper.h:104:33: note: Technically the member function 'gmx::PmeLoadBalanceHelper::loadBalancingObject' can be const. gromacs-2022-rc1/src/gromacs/modularsimulator/referencetemperaturemanager.h:88:5: style: Class 'ReferenceTemperatureManager' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/modularsimulator/nosehooverchains.cpp:228:19: style: Local variable 'numTemperatureGroups' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/modularsimulator/nosehooverchains.h:124:9: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/modularsimulator/nosehooverchains.cpp:228:19: note: Shadow variable gromacs-2022-rc1/src/gromacs/modularsimulator/simulatoralgorithm.cpp:119:5: performance: Variable 'signalHelper_' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] gromacs-2022-rc1/src/gromacs/modularsimulator/simulatoralgorithm.cpp:204:40: style: The scope of the variable 'sbuf2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/modularsimulator/trajectoryelement.cpp:65:76: style:inconclusive: Function 'TrajectoryElement' argument 14 names different: declaration 'simulationsSharingState' definition 'simulationsShareState'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/modularsimulator/trajectoryelement.h:144:61: note: Function 'TrajectoryElement' argument 14 names different: declaration 'simulationsSharingState' definition 'simulationsShareState'. gromacs-2022-rc1/src/gromacs/modularsimulator/trajectoryelement.cpp:65:76: note: Function 'TrajectoryElement' argument 14 names different: declaration 'simulationsSharingState' definition 'simulationsShareState'. gromacs-2022-rc1/src/gromacs/nbnxm/pairlist.h:215:5: error: There is an unknown macro here somewhere. Configuration is required. If MSVC_DIAGNOSTIC_IGNORE is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/modularsimulator/trajectoryelement.cpp:149:20: style: Variable 'callback' can be declared as reference to const [constVariable] gromacs-2022-rc1/src/gromacs/modularsimulator/simulatoralgorithm.cpp:150:9: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] gromacs-2022-rc1/src/gromacs/modularsimulator/trajectoryelement.cpp:156:20: style: Variable 'callback' can be declared as reference to const [constVariable] gromacs-2022-rc1/src/gromacs/modularsimulator/propagator.cpp:568:31: warning: Member variable 'Propagator < IntegrationStage :: PositionsOnly >::doSinglePositionScaling_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/modularsimulator/propagator.cpp:568:31: warning: Member variable 'Propagator < IntegrationStage :: PositionsOnly >::doGroupPositionScaling_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/modularsimulator/propagator.cpp:568:31: warning: Member variable 'Propagator < IntegrationStage :: VelocitiesOnly >::doSinglePositionScaling_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/modularsimulator/propagator.cpp:568:31: warning: Member variable 'Propagator < IntegrationStage :: VelocitiesOnly >::doGroupPositionScaling_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/modularsimulator/propagator.cpp:568:31: warning: Member variable 'Propagator < IntegrationStage :: LeapFrog >::doSinglePositionScaling_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/modularsimulator/propagator.cpp:568:31: warning: Member variable 'Propagator < IntegrationStage :: LeapFrog >::doGroupPositionScaling_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/nbnxm/benchmark/bench_setup.cpp:272:13: style: Condition '!addedInstance' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/nbnxm/benchmark/bench_setup.cpp:261:30: note: Assignment 'addedInstance=false', assigned value is 0 gromacs-2022-rc1/src/gromacs/nbnxm/benchmark/bench_setup.cpp:272:13: note: Condition '!addedInstance' is always true gromacs-2022-rc1/src/gromacs/modularsimulator/propagator.cpp:568:31: warning: Member variable 'Propagator < IntegrationStage :: VelocityVerletPositionsAndVelocities >::doSinglePositionScaling_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/modularsimulator/propagator.cpp:568:31: warning: Member variable 'Propagator < IntegrationStage :: VelocityVerletPositionsAndVelocities >::doGroupPositionScaling_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/modularsimulator/propagator.cpp:568:31: warning: Member variable 'Propagator < IntegrationStage :: ScaleVelocities >::doSinglePositionScaling_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/modularsimulator/propagator.cpp:568:31: warning: Member variable 'Propagator < IntegrationStage :: ScaleVelocities >::doGroupPositionScaling_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/modularsimulator/propagator.cpp:568:31: warning: Member variable 'Propagator < IntegrationStage :: ScalePositions >::doSinglePositionScaling_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/modularsimulator/propagator.cpp:568:31: warning: Member variable 'Propagator < IntegrationStage :: ScalePositions >::doGroupPositionScaling_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/nbnxm/gridset.cpp:96:10: warning: Member variable 'GridSet::numColumnsMax_' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/nbnxm/grid.h:189:9: style: Struct 'Geometry' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/nbnxm/gridset.cpp:68:13: style: Local variable 'numGrids' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/nbnxm/gridset.cpp:58:12: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/nbnxm/gridset.cpp:68:13: note: Shadow variable gromacs-2022-rc1/src/gromacs/nbnxm/gridset.cpp:73:26: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/modularsimulator/velocityscalingtemperaturecoupling.cpp:325:10: style:inconclusive: Technically the member function 'gmx::NoseHooverTemperatureCoupling::integral' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/modularsimulator/velocityscalingtemperaturecoupling.cpp:215:5: style: Class 'VRescaleTemperatureCoupling' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/modularsimulator/velocityscalingtemperaturecoupling.cpp:771:47: performance:inconclusive: Function parameter 'temperatures' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/nbnxm/benchmark/bench_system.cpp:208:9: warning: Struct 'BenchmarkSystem' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] gromacs-2022-rc1/src/gromacs/nbnxm/benchmark/bench_system.cpp:208:9: warning: Struct 'BenchmarkSystem' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] gromacs-2022-rc1/src/gromacs/nbnxm/benchmark/bench_system.cpp:208:9: warning: Struct 'BenchmarkSystem' does not have a destructor which is recommended since it has dynamic memory/resource allocation(s). [noDestructor] gromacs-2022-rc1/src/gromacs/nbnxm/kernels_reference/kernel_gpu_ref.cpp:87:18: style: Consider using std::fill algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/nbnxm/kernels_simd_2xmm/kernel_prune.cpp:54:61: style:inconclusive: Function 'nbnxn_kernel_prune_2xnn' argument 3 names different: declaration 'shift_vec' definition 'shiftvec'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/nbnxm/kernels_simd_2xmm/kernel_prune.h:66:61: note: Function 'nbnxn_kernel_prune_2xnn' argument 3 names different: declaration 'shift_vec' definition 'shiftvec'. gromacs-2022-rc1/src/gromacs/nbnxm/kernels_simd_2xmm/kernel_prune.cpp:54:61: note: Function 'nbnxn_kernel_prune_2xnn' argument 3 names different: declaration 'shift_vec' definition 'shiftvec'. gromacs-2022-rc1/src/gromacs/nbnxm/opencl/nbnxm_ocl.cpp:741:9: style: The if condition is the same as the previous if condition [duplicateCondition] gromacs-2022-rc1/src/gromacs/nbnxm/opencl/nbnxm_ocl.cpp:734:9: note: First condition gromacs-2022-rc1/src/gromacs/nbnxm/opencl/nbnxm_ocl.cpp:741:9: note: Second condition gromacs-2022-rc1/src/gromacs/nbnxm/tests/kernelsetup.cpp:65:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/nbnxm/nbnxm_gpu_data_mgmt.cpp:1061:17: style: The if condition is the same as the previous if condition [duplicateCondition] gromacs-2022-rc1/src/gromacs/nbnxm/nbnxm_gpu_data_mgmt.cpp:1056:17: note: First condition gromacs-2022-rc1/src/gromacs/nbnxm/nbnxm_gpu_data_mgmt.cpp:1061:17: note: Second condition gromacs-2022-rc1/src/gromacs/onlinehelp/helptopic.cpp:147:31: style: Local variable 'title' shadows outer argument [shadowArgument] gromacs-2022-rc1/src/gromacs/onlinehelp/helptopic.cpp:140:77: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/onlinehelp/helptopic.cpp:147:31: note: Shadow variable gromacs-2022-rc1/src/gromacs/onlinehelp/helptopic.cpp:162:27: style: Local variable 'title' shadows outer argument [shadowArgument] gromacs-2022-rc1/src/gromacs/onlinehelp/helptopic.cpp:140:77: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/onlinehelp/helptopic.cpp:162:27: note: Shadow variable gromacs-2022-rc1/src/gromacs/onlinehelp/helptopic.cpp:184:27: style: Local variable 'name' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/onlinehelp/helptopic.h:111:17: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/onlinehelp/helptopic.cpp:184:27: note: Shadow variable gromacs-2022-rc1/src/gromacs/onlinehelp/helptopic.cpp:185:27: style: Local variable 'title' shadows outer argument [shadowArgument] gromacs-2022-rc1/src/gromacs/onlinehelp/helptopic.cpp:140:77: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/onlinehelp/helptopic.cpp:185:27: note: Shadow variable gromacs-2022-rc1/src/gromacs/onlinehelp/helpwritercontext.h:265:10: performance:inconclusive: Technically the member function 'gmx::HelpWriterContext::writeOptionListStart' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/gromacs/onlinehelp/helpwritercontext.cpp:584:25: note: Technically the member function 'gmx::HelpWriterContext::writeOptionListStart' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/gromacs/onlinehelp/helpwritercontext.h:265:10: note: Technically the member function 'gmx::HelpWriterContext::writeOptionListStart' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/gromacs/onlinehelp/helpwritercontext.h:287:10: performance:inconclusive: Technically the member function 'gmx::HelpWriterContext::writeOptionListEnd' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/gromacs/onlinehelp/helpwritercontext.cpp:642:25: note: Technically the member function 'gmx::HelpWriterContext::writeOptionListEnd' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/gromacs/onlinehelp/helpwritercontext.h:287:10: note: Technically the member function 'gmx::HelpWriterContext::writeOptionListEnd' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/gromacs/nbnxm/sycl/nbnxm_sycl_kernel.cpp:783:83: style:inconclusive: Boolean expression 'nbSci.shift==gmx::c_centralShiftIndex' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean] gromacs-2022-rc1/src/gromacs/nbnxm/sycl/nbnxm_sycl_kernel.cpp:855:90: style:inconclusive: Boolean expression 'nonSelfInteraction' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean] gromacs-2022-rc1/src/gromacs/onlinehelp/tests/helpmanager.cpp:94:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/onlinehelp/tests/helpformat.cpp:78:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/onlinehelp/tests/helpwritercontext.cpp:94:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/nbnxm/sycl/nbnxm_sycl_kernel.cpp:783:83: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] gromacs-2022-rc1/src/gromacs/options/behaviorcollection.h:90:10: style:inconclusive: Technically the member function 'gmx::OptionsBehaviorCollection::optionsFinished' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/options/behaviorcollection.cpp:72:33: note: Technically the member function 'gmx::OptionsBehaviorCollection::optionsFinished' can be const. gromacs-2022-rc1/src/gromacs/options/behaviorcollection.h:90:10: note: Technically the member function 'gmx::OptionsBehaviorCollection::optionsFinished' can be const. gromacs-2022-rc1/src/gromacs/options/options.cpp:125:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/options/tests/abstractoptionstorage.cpp:163:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/options/optionsvisitor.cpp:60:55: style: Parameter 'optionInfo' can be declared as reference to const [constParameter] gromacs-2022-rc1/src/gromacs/options/tests/filenameoption.cpp:81:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/options/tests/filenameoptionmanager.cpp:82:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/options/tests/repeatingsection.cpp:66:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/options/tests/optionsassigner.cpp:84:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/options/tests/timeunitmanager.cpp:72:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/options/tests/treesupport.cpp:105:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/options/filenameoption.cpp:220:13: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/options/optionsassigner.cpp:177:5: warning:inconclusive: Either the condition 'section==nullptr' is redundant or there is possible null pointer dereference: section. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/options/optionsassigner.cpp:172:17: note: Assuming that condition 'section==nullptr' is not redundant gromacs-2022-rc1/src/gromacs/options/optionsassigner.cpp:177:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/options/filenameoption.cpp:80:9: style: struct member 'FileTypeMapping::fileType' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/options/basicoptions.h:413:27: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/options/basicoptions.cpp:290:19: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/options/basicoptions.cpp:379:19: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/options/treesupport.cpp:152:5: style: Class 'TreeCheckHelper' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/pbcutil/mshift.cpp:75:5: style: Class 'EdgesGenerator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/pbcutil/mshift.cpp:106:16: style: The scope of the variable 'np' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/pbcutil/mshift.cpp:693:16: style: The scope of the variable 'nerror_tot' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/pbcutil/mshift.cpp:415:72: style:inconclusive: Function 'mk_graph' argument 3 names different: declaration 'shiftAtomEnd' definition 'at_end'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/pbcutil/mshift.h:112:49: note: Function 'mk_graph' argument 3 names different: declaration 'shiftAtomEnd' definition 'at_end'. gromacs-2022-rc1/src/gromacs/pbcutil/mshift.cpp:415:72: note: Function 'mk_graph' argument 3 names different: declaration 'shiftAtomEnd' definition 'at_end'. gromacs-2022-rc1/src/gromacs/pbcutil/mshift.cpp:90:17: style: Local variable 'edges' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/pbcutil/mshift.cpp:81:42: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/pbcutil/mshift.cpp:90:17: note: Shadow variable gromacs-2022-rc1/src/gromacs/pbcutil/mshift.cpp:793:13: style: Local variable 'npbcdim' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/pbcutil/mshift.cpp:694:16: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/pbcutil/mshift.cpp:793:13: note: Shadow variable gromacs-2022-rc1/src/gromacs/pbcutil/tests/com.cpp:189:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/pbcutil/tests/mshift.cpp:121:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/pbcutil/rmpbc.cpp:171:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/pbcutil/rmpbc.cpp:217:14: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/pbcutil/rmpbc.cpp:237:14: style: The scope of the variable 'pbcType' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/pbcutil/rmpbc.cpp:238:14: style: The scope of the variable 'gr' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/pbcutil/rmpbc.cpp:69:35: style: struct member 'gmx_rmpbc::ePBC' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pbcutil/tests/pbcenums.cpp:61:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/pbcutil/pbcmethods.cpp:49:24: style: The scope of the variable 'j0' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/pbcutil/pbcmethods.cpp:49:28: style: The scope of the variable 'j1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/pbcutil/pbcmethods.cpp:50:15: style: The scope of the variable 'imin' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/pbcutil/pbcmethods.cpp:50:21: style: The scope of the variable 'jmin' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/pbcutil/pbcmethods.cpp:255:12: style: The scope of the variable 'mtot' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/pbcutil/pbcmethods.cpp:398:10: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/pbcutil/pbcmethods.cpp:398:13: style: The scope of the variable 'm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/pbcutil/pbcmethods.cpp:398:16: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/pulling/pull_internal.h:156:5: style: Struct 'pull_coord_work_t' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/pulling/output.cpp:404:19: style: The scope of the variable 'm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/pulling/output.cpp:405:12: style: The scope of the variable 'setname' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/pulling/output.cpp:405:21: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/pulling/output.cpp:519:17: style: The scope of the variable 'px_appended' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/pulling/output.cpp:519:30: style: The scope of the variable 'pf_appended' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/pbcutil/pbc.cpp:1094:21: style: The scope of the variable 'd2trial' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/pbcutil/pbc.cpp:1414:18: style: The scope of the variable 'm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/pbcutil/pbc.cpp:329:17: style: Variable 'order' can be declared as const array [constVariable] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:94:9: style: struct member 'sort_along_vec_t::ind' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:108:9: style: struct member 'gmx_slabdata::nat' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:114:11: style: struct member 'gmx_slabdata::x' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:116:11: style: struct member 'gmx_slabdata::ref' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:118:11: style: struct member 'gmx_slabdata::weight' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:129:11: style: struct member 'gmx_potfit::degangle' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:131:11: style: struct member 'gmx_potfit::V' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:133:13: style: struct member 'gmx_potfit::rotmat' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:143:9: style: struct member 'gmx_enfrotgrp::groupIndex' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:156:11: style: struct member 'gmx_enfrotgrp::f_rot_loc' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:160:11: style: struct member 'gmx_enfrotgrp::xc_ref_length' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:166:11: style: struct member 'gmx_enfrotgrp::xc' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:168:11: style: struct member 'gmx_enfrotgrp::xc_shifts' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:170:11: style: struct member 'gmx_enfrotgrp::xc_eshifts' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:172:11: style: struct member 'gmx_enfrotgrp::xc_old' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:174:11: style: struct member 'gmx_enfrotgrp::xc_norm' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:176:11: style: struct member 'gmx_enfrotgrp::xc_ref_sorted' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:178:10: style: struct member 'gmx_enfrotgrp::xc_sortind' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:180:11: style: struct member 'gmx_enfrotgrp::mc' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:182:11: style: struct member 'gmx_enfrotgrp::mc_sorted' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:194:11: style: struct member 'gmx_enfrotgrp::xr_loc' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pullcoordexpressionparser.h:91:12: performance:inconclusive: Technically the member function 'gmx::PullCoordExpressionParser::evaluate' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/gromacs/pulling/pullcoordexpressionparser.cpp:75:35: note: Technically the member function 'gmx::PullCoordExpressionParser::evaluate' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/gromacs/pulling/pullcoordexpressionparser.h:91:12: note: Technically the member function 'gmx::PullCoordExpressionParser::evaluate' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:196:11: style: struct member 'gmx_enfrotgrp::x_loc_pbc' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:198:11: style: struct member 'gmx_enfrotgrp::m_loc' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:202:9: style: struct member 'gmx_enfrotgrp::nslabs_alloc' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:204:9: style: struct member 'gmx_enfrotgrp::slab_first' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:206:9: style: struct member 'gmx_enfrotgrp::slab_last' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:208:9: style: struct member 'gmx_enfrotgrp::slab_first_ref' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:210:9: style: struct member 'gmx_enfrotgrp::slab_last_ref' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:212:9: style: struct member 'gmx_enfrotgrp::slab_buffer' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:214:10: style: struct member 'gmx_enfrotgrp::firstatom' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:216:10: style: struct member 'gmx_enfrotgrp::lastatom' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:218:11: style: struct member 'gmx_enfrotgrp::slab_center' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:220:11: style: struct member 'gmx_enfrotgrp::slab_center_ref' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:222:11: style: struct member 'gmx_enfrotgrp::slab_weights' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:224:11: style: struct member 'gmx_enfrotgrp::slab_torque_v' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:228:11: style: struct member 'gmx_enfrotgrp::gn_atom' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:230:10: style: struct member 'gmx_enfrotgrp::gn_slabind' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:232:11: style: struct member 'gmx_enfrotgrp::slab_innersumvec' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:234:19: style: struct member 'gmx_enfrotgrp::slab_data' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/pull_rotation.cpp:238:17: style: struct member 'gmx_enfrotgrp::PotAngleFit' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/pulling/tests/pull.cpp:166:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/random/tabulatednormaldistribution.h:240:17: performance:inconclusive: Technically the member function 'TabulatedNormalDistribution < real , detail :: c_TabulatedNormalDistributionDefaultBits >::min' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/gromacs/random/tests/exponentialdistribution.cpp:83:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/random/tabulatednormaldistribution.h:248:17: performance:inconclusive: Technically the member function 'TabulatedNormalDistribution < real , detail :: c_TabulatedNormalDistributionDefaultBits >::max' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/gromacs/random/tests/gammadistribution.cpp:88:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/random/tests/normaldistribution.cpp:76:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/pulling/transformationcoordinate.cpp:201:73: performance:inconclusive: Function parameter 'variableCoords' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/random/tests/tabulatednormaldistribution.cpp:75:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/random/tests/threefry.cpp:62:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/random/tests/uniformintdistribution.cpp:76:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/random/tests/uniformrealdistribution.cpp:74:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/restraint/tests/manager.cpp:66:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/restraint/restraintmdmodule.cpp:134:39: style: Redundant initialization for 'aLocal'. The initialized value is overwritten before it is read. [redundantInitialization] gromacs-2022-rc1/src/gromacs/restraint/restraintmdmodule.cpp:131:23: note: aLocal is initialized gromacs-2022-rc1/src/gromacs/restraint/restraintmdmodule.cpp:134:39: note: aLocal is overwritten gromacs-2022-rc1/src/gromacs/restraint/restraintmdmodule.cpp:146:39: style: Redundant initialization for 'bLocal'. The initialized value is overwritten before it is read. [redundantInitialization] gromacs-2022-rc1/src/gromacs/restraint/restraintmdmodule.cpp:145:23: note: bLocal is initialized gromacs-2022-rc1/src/gromacs/restraint/restraintmdmodule.cpp:146:39: note: bLocal is overwritten gromacs-2022-rc1/src/gromacs/pulling/pullutil.cpp:506:18: style: Local variable 'cw' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/pulling/pullutil.cpp:496:14: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/pulling/pullutil.cpp:506:18: note: Shadow variable gromacs-2022-rc1/src/gromacs/pulling/pullutil.cpp:507:18: style: Local variable 'sw' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/pulling/pullutil.cpp:497:14: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/pulling/pullutil.cpp:507:18: note: Shadow variable gromacs-2022-rc1/src/gromacs/pulling/pullutil.cpp:640:30: style: Local variable 't' shadows outer argument [shadowArgument] gromacs-2022-rc1/src/gromacs/pulling/pullutil.cpp:527:42: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/pulling/pullutil.cpp:640:30: note: Shadow variable gromacs-2022-rc1/src/gromacs/pulling/pullutil.cpp:649:30: style: Local variable 't' shadows outer argument [shadowArgument] gromacs-2022-rc1/src/gromacs/pulling/pullutil.cpp:527:42: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/pulling/pullutil.cpp:649:30: note: Shadow variable gromacs-2022-rc1/src/gromacs/pulling/pullutil.cpp:680:26: style: Local variable 't' shadows outer argument [shadowArgument] gromacs-2022-rc1/src/gromacs/pulling/pullutil.cpp:527:42: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/pulling/pullutil.cpp:680:26: note: Shadow variable gromacs-2022-rc1/src/gromacs/pulling/pullutil.cpp:690:26: style: Local variable 't' shadows outer argument [shadowArgument] gromacs-2022-rc1/src/gromacs/pulling/pullutil.cpp:527:42: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/pulling/pullutil.cpp:690:26: note: Shadow variable gromacs-2022-rc1/src/gromacs/pulling/pullutil.cpp:147:94: performance:inconclusive: Function parameter 'x' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/pulling/pullutil.cpp:912:71: performance:inconclusive: Function parameter 'x' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/pulling/pullutil.cpp:951:71: performance:inconclusive: Function parameter 'x' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/pulling/pullutil.cpp:1093:51: performance:inconclusive: Function parameter 'masses' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/pulling/pullutil.cpp:320:35: style: Variable 'group1' can be declared as reference to const [constVariable] gromacs-2022-rc1/src/gromacs/selection/centerofmass.cpp:58:12: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/selection/centerofmass.cpp:200:16: style: The scope of the variable 'bChanged' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/selection/centerofmass.cpp:201:16: style: The scope of the variable 'm' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/selection/centerofmass.cpp:201:19: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/selection/centerofmass.cpp:201:22: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/selection/centerofmass.cpp:201:26: style: The scope of the variable 'iter' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/selection/centerofmass.cpp:529:57: style:inconclusive: Function 'gmx_calc_comg_f_blocka' argument 2 names different: declaration 'x' definition 'f'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/selection/centerofmass.h:168:57: note: Function 'gmx_calc_comg_f_blocka' argument 2 names different: declaration 'x' definition 'f'. gromacs-2022-rc1/src/gromacs/selection/centerofmass.cpp:529:57: note: Function 'gmx_calc_comg_f_blocka' argument 2 names different: declaration 'x' definition 'f'. gromacs-2022-rc1/src/gromacs/selection/centerofmass.cpp:529:102: style:inconclusive: Function 'gmx_calc_comg_f_blocka' argument 5 names different: declaration 'xout' definition 'fout'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/selection/centerofmass.h:168:102: note: Function 'gmx_calc_comg_f_blocka' argument 5 names different: declaration 'xout' definition 'fout'. gromacs-2022-rc1/src/gromacs/selection/centerofmass.cpp:529:102: note: Function 'gmx_calc_comg_f_blocka' argument 5 names different: declaration 'xout' definition 'fout'. gromacs-2022-rc1/src/gromacs/pulling/pull.cpp:1585:24: style: The scope of the variable 'pcrd' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/pulling/pull.cpp:134:58: style:inconclusive: Function 'pull_group_work_t' argument 3 names different: declaration 'setPbcRefToPrevStepCOM' definition 'bSetPbcRefToPrevStepCOM'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/pulling/pull_internal.h:102:43: note: Function 'pull_group_work_t' argument 3 names different: declaration 'setPbcRefToPrevStepCOM' definition 'bSetPbcRefToPrevStepCOM'. gromacs-2022-rc1/src/gromacs/pulling/pull.cpp:134:58: note: Function 'pull_group_work_t' argument 3 names different: declaration 'setPbcRefToPrevStepCOM' definition 'bSetPbcRefToPrevStepCOM'. gromacs-2022-rc1/src/gromacs/pulling/pull.cpp:1153:25: style: Local variable 'j' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/pulling/pull.cpp:843:29: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/pulling/pull.cpp:1153:25: note: Shadow variable gromacs-2022-rc1/src/gromacs/pulling/pull.cpp:215:55: performance:inconclusive: Function parameter 'masses' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/pulling/pull.cpp:303:71: performance:inconclusive: Function parameter 'masses' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/pulling/pull.cpp:337:66: performance:inconclusive: Function parameter 'masses' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/pulling/pull.cpp:1582:60: performance:inconclusive: Function parameter 'masses' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/pulling/pull.cpp:1647:43: performance:inconclusive: Function parameter 'x' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/pulling/pull.cpp:1712:43: performance:inconclusive: Function parameter 'masses' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/pulling/pull.cpp:1717:43: performance:inconclusive: Function parameter 'x' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/pulling/pull.cpp:1718:43: performance:inconclusive: Function parameter 'xp' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/pulling/pull.cpp:1719:43: performance:inconclusive: Function parameter 'v' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/pulling/pull.cpp:2454:81: performance:inconclusive: Function parameter 'masses' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/pulling/pull.cpp:2455:81: performance:inconclusive: Function parameter 'x' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/pulling/pull.cpp:2468:50: performance:inconclusive: Function parameter 'masses' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/pulling/pull.cpp:2229:22: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/pulling/pull.cpp:1467:38: warning: Either the condition 'coord_index<0' is redundant, otherwise there is negative array index -1. [negativeContainerIndex] gromacs-2022-rc1/src/gromacs/pulling/pull.cpp:1456:21: note: Assuming that condition 'coord_index<0' is not redundant gromacs-2022-rc1/src/gromacs/pulling/pull.cpp:1467:38: note: Negative array index gromacs-2022-rc1/src/gromacs/selection/selectioncollection_impl.h:220:10: performance:inconclusive: Technically the member function 'gmx::SelectionEvaluator::evaluateFinal' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/gromacs/selection/evaluate.cpp:469:26: note: Technically the member function 'gmx::SelectionEvaluator::evaluateFinal' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/gromacs/selection/selectioncollection_impl.h:220:10: note: Technically the member function 'gmx::SelectionEvaluator::evaluateFinal' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/gromacs/selection/evaluate.cpp:423:56: style:inconclusive: Function 'evaluate' argument 1 names different: declaration 'sc' definition 'coll'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/selection/selectioncollection_impl.h:216:40: note: Function 'evaluate' argument 1 names different: declaration 'sc' definition 'coll'. gromacs-2022-rc1/src/gromacs/selection/evaluate.cpp:423:56: note: Function 'evaluate' argument 1 names different: declaration 'sc' definition 'coll'. gromacs-2022-rc1/src/gromacs/selection/evaluate.cpp:469:61: style:inconclusive: Function 'evaluateFinal' argument 1 names different: declaration 'sc' definition 'coll'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/selection/selectioncollection_impl.h:220:45: note: Function 'evaluateFinal' argument 1 names different: declaration 'sc' definition 'coll'. gromacs-2022-rc1/src/gromacs/selection/evaluate.cpp:469:61: note: Function 'evaluateFinal' argument 1 names different: declaration 'sc' definition 'coll'. gromacs-2022-rc1/src/gromacs/selection/evaluate.cpp:458:34: style: Local variable 'sel' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/selection/evaluate.cpp:430:33: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/selection/evaluate.cpp:458:34: note: Shadow variable gromacs-2022-rc1/src/gromacs/selection/indexutil.cpp:235:5: warning: Either the condition 'destName!=nullptr' is redundant or there is possible null pointer dereference: destName. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/selection/indexutil.cpp:242:18: note: Assuming that condition 'destName!=nullptr' is not redundant gromacs-2022-rc1/src/gromacs/selection/indexutil.cpp:235:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/selection/indexutil.cpp:1369:15: style: The scope of the variable 'bi' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/selection/nbsearch.cpp:415:5: performance: Variable 'cutoff_' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] gromacs-2022-rc1/src/gromacs/selection/nbsearch.h:113:5: style: Class 'AnalysisNeighborhoodPositions' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/selection/nbsearch.h:127:5: style: Class 'AnalysisNeighborhoodPositions' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/selection/nbsearch.cpp:718:80: style:inconclusive: Function 'initCellRange' argument 2 names different: declaration 'cell' definition 'currCell'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/selection/nbsearch.cpp:233:52: note: Function 'initCellRange' argument 2 names different: declaration 'cell' definition 'currCell'. gromacs-2022-rc1/src/gromacs/selection/nbsearch.cpp:718:80: note: Function 'initCellRange' argument 2 names different: declaration 'cell' definition 'currCell'. scanner.cpp:2170:5: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] gromacs-2022-rc1/src/gromacs/selection/position.cpp:223:49: style:inconclusive: Function 'gmx_ana_pos_set_nr' argument 2 names different: declaration 'n' definition 'nr'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/selection/position.h:98:49: note: Function 'gmx_ana_pos_set_nr' argument 2 names different: declaration 'n' definition 'nr'. gromacs-2022-rc1/src/gromacs/selection/position.cpp:223:49: note: Function 'gmx_ana_pos_set_nr' argument 2 names different: declaration 'n' definition 'nr'. scanner.cpp:1160:11: style: Condition '!yyg->yy_did_buffer_switch_on_eof' is always true [knownConditionTrueFalse] scanner.cpp:1139:40: note: Assignment 'yyg->yy_did_buffer_switch_on_eof=0', assigned value is 0 scanner.cpp:1160:11: note: Condition '!yyg->yy_did_buffer_switch_on_eof' is always true scanner.cpp:1592:2: warning: Either the condition '!b' is redundant or there is possible null pointer dereference: b. [nullPointerRedundantCheck] scanner.cpp:1589:7: note: Assuming that condition '!b' is not redundant scanner.cpp:1592:2: note: Null pointer dereference scanner.cpp:1597:2: warning: Either the condition '!b' is redundant or there is possible null pointer dereference: b. [nullPointerRedundantCheck] scanner.cpp:1589:7: note: Assuming that condition '!b' is not redundant scanner.cpp:1597:2: note: Null pointer dereference scanner.cpp:1598:9: warning: Either the condition '!b' is redundant or there is possible null pointer dereference: b. [nullPointerRedundantCheck] scanner.cpp:1589:7: note: Assuming that condition '!b' is not redundant scanner.cpp:1598:9: note: Null pointer dereference scanner.cpp:1806:2: warning: Either the condition '!b' is redundant or there is possible null pointer dereference: b. [nullPointerRedundantCheck] scanner.cpp:1803:7: note: Assuming that condition '!b' is not redundant scanner.cpp:1806:2: note: Null pointer dereference scanner.cpp:1807:2: warning: Either the condition '!b' is redundant or there is possible null pointer dereference: b. [nullPointerRedundantCheck] scanner.cpp:1803:7: note: Assuming that condition '!b' is not redundant scanner.cpp:1807:2: note: Null pointer dereference scanner.cpp:1808:2: warning: Either the condition '!b' is redundant or there is possible null pointer dereference: b. [nullPointerRedundantCheck] scanner.cpp:1803:7: note: Assuming that condition '!b' is not redundant scanner.cpp:1808:2: note: Null pointer dereference scanner.cpp:1809:2: warning: Either the condition '!b' is redundant or there is possible null pointer dereference: b. [nullPointerRedundantCheck] scanner.cpp:1803:7: note: Assuming that condition '!b' is not redundant scanner.cpp:1809:2: note: Null pointer dereference scanner.cpp:1810:2: warning: Either the condition '!b' is redundant or there is possible null pointer dereference: b. [nullPointerRedundantCheck] scanner.cpp:1803:7: note: Assuming that condition '!b' is not redundant scanner.cpp:1810:2: note: Null pointer dereference scanner.cpp:1811:2: warning: Either the condition '!b' is redundant or there is possible null pointer dereference: b. [nullPointerRedundantCheck] scanner.cpp:1803:7: note: Assuming that condition '!b' is not redundant scanner.cpp:1811:2: note: Null pointer dereference scanner.cpp:1812:2: warning: Either the condition '!b' is redundant or there is possible null pointer dereference: b. [nullPointerRedundantCheck] scanner.cpp:1803:7: note: Assuming that condition '!b' is not redundant scanner.cpp:1812:2: note: Null pointer dereference scanner.cpp:1813:2: warning: Either the condition '!b' is redundant or there is possible null pointer dereference: b. [nullPointerRedundantCheck] scanner.cpp:1803:7: note: Assuming that condition '!b' is not redundant scanner.cpp:1813:2: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/selection/selectionoptionmanager.cpp:245:69: style:inconclusive: Function 'SelectionOptionManager' argument 1 names different: declaration 'selections' definition 'collection'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/selection/selectionoptionmanager.h:90:58: note: Function 'SelectionOptionManager' argument 1 names different: declaration 'selections' definition 'collection'. gromacs-2022-rc1/src/gromacs/selection/selectionoptionmanager.cpp:245:69: note: Function 'SelectionOptionManager' argument 1 names different: declaration 'selections' definition 'collection'. scanner.cpp:1814:2: warning: Either the condition '!b' is redundant or there is possible null pointer dereference: b. [nullPointerRedundantCheck] scanner.cpp:1803:7: note: Assuming that condition '!b' is not redundant scanner.cpp:1814:2: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/selection/poscalc.cpp:864:28: style: The scope of the variable 'bnr' can be reduced. [variableScope] scanner.cpp:1867:2: warning: Either the condition '!b' is redundant or there is possible null pointer dereference: b. [nullPointerRedundantCheck] scanner.cpp:1861:7: note: Assuming that condition '!b' is not redundant scanner.cpp:1867:2: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/selection/poscalc.cpp:865:21: style: The scope of the variable 'i' can be reduced. [variableScope] scanner.cpp:816:30: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/gromacs/selection/poscalc.cpp:865:24: style: The scope of the variable 'bi' can be reduced. [variableScope] scanner.cpp:1206:30: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/gromacs/selection/selection.cpp:94:16: warning: Either the condition 'child' is redundant or there is possible null pointer dereference: child. [nullPointerRedundantCheck] gromacs-2022-rc1/src/gromacs/selection/selection.cpp:114:13: note: Assuming that condition 'child' is not redundant gromacs-2022-rc1/src/gromacs/selection/selection.cpp:94:16: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/selection/poscalc.cpp:865:28: style: The scope of the variable 'bj' can be reduced. [variableScope] scanner.cpp:1272:20: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/gromacs/selection/poscalc.cpp:865:32: style: The scope of the variable 'bo' can be reduced. [variableScope] scanner.cpp:1274:25: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/gromacs/selection/poscalc.cpp:1178:9: style: The scope of the variable 'i' can be reduced. [variableScope] scanner.cpp:1323:41: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/gromacs/selection/params.cpp:994:69: warning: Function '_gmx_sel_parse_params' argument order different: declaration 'params, nparam, param, root, scanner' definition 'pparams, nparam, params, root, scanner' [funcArgOrderDifferent] gromacs-2022-rc1/src/gromacs/selection/parsetree.h:550:69: note: Function '_gmx_sel_parse_params' argument order different: declaration 'params, nparam, param, root, scanner' definition 'pparams, nparam, params, root, scanner' gromacs-2022-rc1/src/gromacs/selection/params.cpp:994:69: note: Function '_gmx_sel_parse_params' argument order different: declaration 'params, nparam, param, root, scanner' definition 'pparams, nparam, params, root, scanner' gromacs-2022-rc1/src/gromacs/selection/poscalc.cpp:1178:12: style: The scope of the variable 'bi' can be reduced. [variableScope] scanner.cpp:1343:30: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/gromacs/selection/poscalc.cpp:1178:16: style: The scope of the variable 'bj' can be reduced. [variableScope] scanner.cpp:1375:30: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/gromacs/selection/poscalc.cpp:144:33: warning: Either the condition 'ii>=0' is redundant, otherwise there is negative array index -1. [negativeContainerIndex] gromacs-2022-rc1/src/gromacs/selection/poscalc.cpp:142:27: note: Assuming that condition 'ii>=0' is not redundant gromacs-2022-rc1/src/gromacs/selection/poscalc.cpp:141:33: note: Assignment to 'ii=index[i]' gromacs-2022-rc1/src/gromacs/selection/poscalc.cpp:141:26: note: ii is assigned 'index[i]' here. gromacs-2022-rc1/src/gromacs/selection/poscalc.cpp:144:33: note: Negative array index scanner.cpp:1402:30: style: C-style pointer casting [cstyleCast] scanner.cpp:1448:30: style: C-style pointer casting [cstyleCast] scanner.cpp:1506:7: style: C-style pointer casting [cstyleCast] scanner.cpp:1521:30: style: C-style pointer casting [cstyleCast] scanner.cpp:1539:30: style: C-style pointer casting [cstyleCast] scanner.cpp:1571:30: style: C-style pointer casting [cstyleCast] scanner.cpp:1588:7: style: C-style pointer casting [cstyleCast] scanner.cpp:1597:17: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/gromacs/selection/selvalue.cpp:80:9: style: The scope of the variable 'i' can be reduced. [variableScope] scanner.cpp:1614:30: style: C-style pointer casting [cstyleCast] scanner.cpp:1623:19: style: C-style pointer casting [cstyleCast] scanner.cpp:1625:18: style: C-style pointer casting [cstyleCast] scanner.cpp:1636:30: style: C-style pointer casting [cstyleCast] scanner.cpp:1663:30: style: C-style pointer casting [cstyleCast] scanner.cpp:1693:30: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/gromacs/selection/selmethod.cpp:342:30: style: Local variable 'param' shadows outer argument [shadowArgument] gromacs-2022-rc1/src/gromacs/selection/selmethod.cpp:135:65: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/selection/selmethod.cpp:342:30: note: Shadow variable scanner.cpp:1724:30: style: C-style pointer casting [cstyleCast] scanner.cpp:1745:30: style: C-style pointer casting [cstyleCast] scanner.cpp:1754:27: style: C-style pointer casting [cstyleCast] scanner.cpp:1773:27: style: C-style pointer casting [cstyleCast] scanner.cpp:1802:7: style: C-style pointer casting [cstyleCast] scanner.cpp:1851:8: style: C-style pointer casting [cstyleCast] scanner.cpp:1878:27: style: C-style pointer casting [cstyleCast] scanner.cpp:1908:30: style: C-style pointer casting [cstyleCast] scanner.cpp:1917:30: style: C-style pointer casting [cstyleCast] scanner.cpp:1930:30: style: C-style pointer casting [cstyleCast] scanner.cpp:1943:30: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/gromacs/selection/selectioncollection.cpp:495:9: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] scanner.cpp:1952:30: style: C-style pointer casting [cstyleCast] scanner.cpp:1961:30: style: C-style pointer casting [cstyleCast] scanner.cpp:1971:30: style: C-style pointer casting [cstyleCast] scanner.cpp:1981:30: style: C-style pointer casting [cstyleCast] scanner.cpp:1991:30: style: C-style pointer casting [cstyleCast] scanner.cpp:2006:30: style: C-style pointer casting [cstyleCast] scanner.cpp:2023:30: style: C-style pointer casting [cstyleCast] scanner.cpp:2029:30: style: C-style pointer casting [cstyleCast] scanner.cpp:2035:30: style: C-style pointer casting [cstyleCast] scanner.cpp:2041:30: style: C-style pointer casting [cstyleCast] scanner.cpp:2062:23: style: C-style pointer casting [cstyleCast] scanner.cpp:2095:23: style: C-style pointer casting [cstyleCast] scanner.cpp:2113:30: style: C-style pointer casting [cstyleCast] scanner.cpp:2147:30: style: C-style pointer casting [cstyleCast] scanner.cpp:2203:27: style: C-style pointer casting [cstyleCast] scanner.cpp:2210:27: style: C-style pointer casting [cstyleCast] scanner.cpp:2220:27: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/gromacs/selection/sm_compare.cpp:511:27: style: The scope of the variable 'a' can be reduced. [variableScope] scanner.cpp:2225:27: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/gromacs/selection/sm_compare.cpp:511:30: style: The scope of the variable 'b' can be reduced. [variableScope] scanner.cpp:2227:8: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/gromacs/selection/sm_compare.cpp:512:27: style: The scope of the variable 'bAccept' can be reduced. [variableScope] scanner.cpp:1295:3: style: Redundant initialization for 'c'. The initialized value is overwritten before it is read. [redundantInitialization] scanner.cpp:1295:3: note: c is initialized scanner.cpp:1295:3: note: c is overwritten gromacs-2022-rc1/src/gromacs/selection/sm_compare.cpp:560:27: style: The scope of the variable 'bAccept' can be reduced. [variableScope] scanner.cpp:1254:23: style: Checking if unsigned expression 'num_to_read' is less than zero. [unsignedLessThanZero] scanner.cpp:1267:19: style: Checking if unsigned expression 'new_size' is less than zero. [unsignedLessThanZero] scanner.cpp:1372:59: style:inconclusive: Function 'yy_try_NUL_trans' argument 1 names different: declaration 'current_state' definition 'yy_current_state'. [funcArgNamesDifferent] scanner.cpp:350:54: note: Function 'yy_try_NUL_trans' argument 1 names different: declaration 'current_state' definition 'yy_current_state'. scanner.cpp:1372:59: note: Function 'yy_try_NUL_trans' argument 1 names different: declaration 'current_state' definition 'yy_current_state'. gromacs-2022-rc1/src/gromacs/selection/tests/indexutil.cpp:72:1: error: syntax error [syntaxError] parser.cpp:1514:11: style: C-style pointer casting [cstyleCast] scanner.cpp:1399:40: style:inconclusive: Function 'yyunput' argument 2 names different: declaration 'buf_ptr' definition 'yy_bp'. [funcArgNamesDifferent] scanner.cpp:687:38: note: Function 'yyunput' argument 2 names different: declaration 'buf_ptr' definition 'yy_bp'. scanner.cpp:1399:40: note: Function 'yyunput' argument 2 names different: declaration 'buf_ptr' definition 'yy_bp'. parser.cpp:1682:7: style:inconclusive: Statements following return, break, continue, goto or throw will never be executed. [unreachableCode] scanner.cpp:1829:57: style:inconclusive: Function '_gmx_sel_yy_scan_string' argument 1 names different: declaration 'yy_str' definition 'yystr'. [funcArgNamesDifferent] scanner.cpp:309:56: note: Function '_gmx_sel_yy_scan_string' argument 1 names different: declaration 'yy_str' definition 'yystr'. scanner.cpp:1829:57: note: Function '_gmx_sel_yy_scan_string' argument 1 names different: declaration 'yy_str' definition 'yystr'. gromacs-2022-rc1/src/gromacs/selection/sm_insolidangle.cpp:393:35: style: The scope of the variable 'c' can be reduced. [variableScope] parser.cpp:1522:28: style:inconclusive: Function '_gmx_sel_yypstate_delete' argument 1 names different: declaration 'ps' definition 'yyps'. [funcArgNamesDifferent] parser.cpp:278:51: note: Function '_gmx_sel_yypstate_delete' argument 1 names different: declaration 'ps' definition 'yyps'. parser.cpp:1522:28: note: Function '_gmx_sel_yypstate_delete' argument 1 names different: declaration 'ps' definition 'yyps'. scanner.cpp:1842:57: style:inconclusive: Function '_gmx_sel_yy_scan_bytes' argument 1 names different: declaration 'bytes' definition 'yybytes'. [funcArgNamesDifferent] scanner.cpp:310:55: note: Function '_gmx_sel_yy_scan_bytes' argument 1 names different: declaration 'bytes' definition 'yybytes'. scanner.cpp:1842:57: note: Function '_gmx_sel_yy_scan_bytes' argument 1 names different: declaration 'bytes' definition 'yybytes'. gromacs-2022-rc1/src/gromacs/selection/sm_insolidangle.cpp:431:32: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/selection/tests/nbsearch.cpp:873:1: error: syntax error [syntaxError] parser.cpp:1554:25: style:inconclusive: Function '_gmx_sel_yypush_parse' argument 1 names different: declaration 'ps' definition 'yyps'. [funcArgNamesDifferent] parser.cpp:275:47: note: Function '_gmx_sel_yypush_parse' argument 1 names different: declaration 'ps' definition 'yyps'. parser.cpp:1554:25: note: Function '_gmx_sel_yypush_parse' argument 1 names different: declaration 'ps' definition 'yyps'. scanner.cpp:1842:77: style:inconclusive: Function '_gmx_sel_yy_scan_bytes' argument 2 names different: declaration 'len' definition '_yybytes_len'. [funcArgNamesDifferent] scanner.cpp:310:71: note: Function '_gmx_sel_yy_scan_bytes' argument 2 names different: declaration 'len' definition '_yybytes_len'. scanner.cpp:1842:77: note: Function '_gmx_sel_yy_scan_bytes' argument 2 names different: declaration 'len' definition '_yybytes_len'. gromacs-2022-rc1/src/gromacs/selection/selelem.cpp:301:37: style: Local variable 'child' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/selection/selelem.h:483:33: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/selection/selelem.cpp:301:37: note: Shadow variable gromacs-2022-rc1/src/gromacs/selection/sm_insolidangle.cpp:686:15: style: The scope of the variable 'c' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/selection/tests/poscalc.cpp:349:1: error: syntax error [syntaxError] parser.cpp:1554:35: style:inconclusive: Function '_gmx_sel_yypush_parse' argument 2 names different: declaration 'pushed_char' definition 'yypushed_char'. [funcArgNamesDifferent] parser.cpp:275:55: note: Function '_gmx_sel_yypush_parse' argument 2 names different: declaration 'pushed_char' definition 'yypushed_char'. parser.cpp:1554:35: note: Function '_gmx_sel_yypush_parse' argument 2 names different: declaration 'pushed_char' definition 'yypushed_char'. scanner.cpp:2039:33: style:inconclusive: Function '_gmx_sel_yyset_debug' argument 1 names different: declaration 'debug_flag' definition '_bdebug'. [funcArgNamesDifferent] scanner.cpp:647:32: note: Function '_gmx_sel_yyset_debug' argument 1 names different: declaration 'debug_flag' definition '_bdebug'. scanner.cpp:2039:33: note: Function '_gmx_sel_yyset_debug' argument 1 names different: declaration 'debug_flag' definition '_bdebug'. gromacs-2022-rc1/src/gromacs/selection/selelem.cpp:353:33: style: Local variable 'child' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/selection/selelem.h:483:33: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/selection/selelem.cpp:353:33: note: Shadow variable parser.cpp:1554:65: style:inconclusive: Function '_gmx_sel_yypush_parse' argument 3 names different: declaration 'pushed_val' definition 'yypushed_val'. [funcArgNamesDifferent] parser.cpp:275:83: note: Function '_gmx_sel_yypush_parse' argument 3 names different: declaration 'pushed_val' definition 'yypushed_val'. parser.cpp:1554:65: note: Function '_gmx_sel_yypush_parse' argument 3 names different: declaration 'pushed_val' definition 'yypushed_val'. scanner.cpp:2054:35: style:inconclusive: Function '_gmx_sel_yylex_init' argument 1 names different: declaration 'scanner' definition 'ptr_yy_globals'. [funcArgNamesDifferent] scanner.cpp:636:36: note: Function '_gmx_sel_yylex_init' argument 1 names different: declaration 'scanner' definition 'ptr_yy_globals'. scanner.cpp:2054:35: note: Function '_gmx_sel_yylex_init' argument 1 names different: declaration 'scanner' definition 'ptr_yy_globals'. gromacs-2022-rc1/src/gromacs/selection/selelem.cpp:374:33: style: Local variable 'child' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/selection/selelem.h:483:33: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/selection/selelem.cpp:374:33: note: Shadow variable gromacs-2022-rc1/src/gromacs/selection/tests/selectioncollection.cpp:98:1: error: syntax error [syntaxError] parser.cpp:1554:88: style:inconclusive: Function '_gmx_sel_yypush_parse' argument 4 names different: declaration 'pushed_loc' definition 'yypushed_loc'. [funcArgNamesDifferent] parser.cpp:275:104: note: Function '_gmx_sel_yypush_parse' argument 4 names different: declaration 'pushed_loc' definition 'yypushed_loc'. parser.cpp:1554:88: note: Function '_gmx_sel_yypush_parse' argument 4 names different: declaration 'pushed_loc' definition 'yypushed_loc'. scanner.cpp:2083:45: style:inconclusive: Function '_gmx_sel_yylex_init_extra' argument 1 names different: declaration 'user_defined' definition 'yy_user_defined'. [funcArgNamesDifferent] scanner.cpp:638:46: note: Function '_gmx_sel_yylex_init_extra' argument 1 names different: declaration 'user_defined' definition 'yy_user_defined'. scanner.cpp:2083:45: note: Function '_gmx_sel_yylex_init_extra' argument 1 names different: declaration 'user_defined' definition 'yy_user_defined'. gromacs-2022-rc1/src/gromacs/selection/selelem.cpp:402:33: style: Local variable 'child' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/selection/selelem.h:483:33: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/selection/selelem.cpp:402:33: note: Shadow variable gromacs-2022-rc1/src/gromacs/selection/tests/selectionoption.cpp:108:1: error: syntax error [syntaxError] parser.cpp:994:55: style: Parameter 'yytop' can be declared as pointer to const [constParameter] scanner.cpp:2083:71: style:inconclusive: Function '_gmx_sel_yylex_init_extra' argument 2 names different: declaration 'scanner' definition 'ptr_yy_globals'. [funcArgNamesDifferent] scanner.cpp:638:69: note: Function '_gmx_sel_yylex_init_extra' argument 2 names different: declaration 'scanner' definition 'ptr_yy_globals'. scanner.cpp:2083:71: note: Function '_gmx_sel_yylex_init_extra' argument 2 names different: declaration 'scanner' definition 'ptr_yy_globals'. parser.cpp:1554:88: style: Parameter 'yypushed_loc' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/gromacs/selection/sm_keywords.cpp:467:25: style: The scope of the variable 'val' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/selection/sm_keywords.cpp:587:12: error: Uninitialized struct member: data.v [uninitStructMember] gromacs-2022-rc1/src/gromacs/simd/tests/scalar.cpp:73:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/simd/tests/scalar_math.cpp:77:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/simd/tests/scalar_util.cpp:80:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/simd/support.cpp:253:23: style: Condition 'compiled==SimdType::X86_Avx512' is always false [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/simd/support.cpp:229:37: note: Assignment 'compiled=simdCompiled()', assigned value is 0 gromacs-2022-rc1/src/gromacs/simd/support.cpp:253:23: note: Condition 'compiled==SimdType::X86_Avx512' is always false gromacs-2022-rc1/src/gromacs/simd/support.cpp:227:30: style:inconclusive: Function 'simdCheck' argument 1 names different: declaration 's' definition 'wanted'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/simd/support.h:96:25: note: Function 'simdCheck' argument 1 names different: declaration 's' definition 'wanted'. gromacs-2022-rc1/src/gromacs/simd/support.cpp:227:30: note: Function 'simdCheck' argument 1 names different: declaration 's' definition 'wanted'. gromacs-2022-rc1/src/gromacs/selection/tests/toputils.cpp:165:14: style: Local variable 'atoms' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/selection/tests/toputils.h:114:17: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/selection/tests/toputils.cpp:165:14: note: Shadow variable gromacs-2022-rc1/src/gromacs/selection/tests/toputils.cpp:195:14: style: Local variable 'atoms' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/selection/tests/toputils.h:114:17: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/selection/tests/toputils.cpp:195:14: note: Shadow variable gromacs-2022-rc1/src/gromacs/selection/tests/toputils.cpp:268:14: style: Local variable 'atoms' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/selection/tests/toputils.h:114:17: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/selection/tests/toputils.cpp:268:14: note: Shadow variable gromacs-2022-rc1/src/gromacs/selection/tests/toputils.cpp:287:21: style: Local variable 'atoms' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/selection/tests/toputils.h:114:17: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/selection/tests/toputils.cpp:287:21: note: Shadow variable gromacs-2022-rc1/src/gromacs/selection/tests/toputils.cpp:193:20: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:117:12: style: The scope of the variable 'yy' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:117:16: style: The scope of the variable 'yx' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:117:20: style: The scope of the variable 'xx' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:117:24: style: The scope of the variable 'sx' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:117:28: style: The scope of the variable 'sy' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:117:32: style: The scope of the variable 'dy' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:117:36: style: The scope of the variable 'chi2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:117:42: style: The scope of the variable 'chi2aa' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:117:50: style: The scope of the variable 'd2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:118:12: style: The scope of the variable 'ssxx' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:118:18: style: The scope of the variable 'ssyy' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:118:24: style: The scope of the variable 'ssxy' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:119:12: style: The scope of the variable 'w' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:119:15: style: The scope of the variable 'wtot' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:119:21: style: The scope of the variable 'yx_nw' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:119:28: style: The scope of the variable 'sy_nw' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:119:35: style: The scope of the variable 'sx_nw' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:119:42: style: The scope of the variable 'yy_nw' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:119:49: style: The scope of the variable 'xx_nw' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:119:56: style: The scope of the variable 'dx2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:119:61: style: The scope of the variable 'dy2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:70:33: style:inconclusive: Function 'gmx_stats_free' argument 1 names different: declaration 'stats' definition 'gstats'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/statistics/statistics.h:76:33: note: Function 'gmx_stats_free' argument 1 names different: declaration 'stats' definition 'gstats'. gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:70:33: note: Function 'gmx_stats_free' argument 1 names different: declaration 'stats' definition 'gstats'. gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:81:38: style:inconclusive: Function 'gmx_stats_add_point' argument 1 names different: declaration 'stats' definition 'gstats'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/statistics/statistics.h:86:38: note: Function 'gmx_stats_add_point' argument 1 names different: declaration 'stats' definition 'gstats'. gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:81:38: note: Function 'gmx_stats_add_point' argument 1 names different: declaration 'stats' definition 'gstats'. gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:239:35: style:inconclusive: Function 'gmx_stats_get_ab' argument 1 names different: declaration 'stats' definition 'gstats'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/statistics/statistics.h:100:35: note: Function 'gmx_stats_get_ab' argument 1 names different: declaration 'stats' definition 'gstats'. gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:239:35: note: Function 'gmx_stats_get_ab' argument 1 names different: declaration 'stats' definition 'gstats'. gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:270:40: style:inconclusive: Function 'gmx_stats_get_average' argument 1 names different: declaration 'stats' definition 'gstats'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/statistics/statistics.h:108:40: note: Function 'gmx_stats_get_average' argument 1 names different: declaration 'stats' definition 'gstats'. gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:270:40: note: Function 'gmx_stats_get_average' argument 1 names different: declaration 'stats' definition 'gstats'. gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:283:60: style:inconclusive: Function 'gmx_stats_get_ase' argument 1 names different: declaration 'stats' definition 'gstats'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/statistics/statistics.h:116:60: note: Function 'gmx_stats_get_ase' argument 1 names different: declaration 'stats' definition 'gstats'. gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:283:60: note: Function 'gmx_stats_get_ase' argument 1 names different: declaration 'stats' definition 'gstats'. gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:54:23: style: struct member 'gmx_stats::sigma_aa' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/statistics/statistics.cpp:58:17: style: struct member 'gmx_stats::np_c' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:174:5: style: Struct 'swap_group' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:1015:13: warning:inconclusive: Possible null pointer dereference: nGroup [nullPointer] gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:995:19: note: Assignment 'nGroup=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:1015:13: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:1021:13: warning:inconclusive: Possible null pointer dereference: nGroup [nullPointer] gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:995:19: note: Assignment 'nGroup=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:1021:13: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/tables/tests/splinetable.cpp:83:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:1381:27: warning:inconclusive: Possible null pointer dereference: x_pbc [nullPointer] gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:1324:24: note: Assignment 'x_pbc=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:1381:27: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:1462:21: warning:inconclusive: Possible null pointer dereference: indIons [nullPointer] gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:1489:23: note: Assignment 'indAnions=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:1524:24: note: Calling function 'copyIndicesToGroup', 1st argument 'indAnions' value is 0 gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:1462:21: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:925:22: style: The scope of the variable 'g' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:1555:22: style: The scope of the variable 'gs' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:2057:25: style: The scope of the variable 'isol' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:2057:31: style: The scope of the variable 'iion' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:2155:24: style: Local variable 'g' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:2132:20: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:2155:24: note: Shadow variable gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:2172:24: style: Local variable 'g' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:2132:20: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:2172:24: note: Shadow variable gromacs-2022-rc1/src/gromacs/tables/splineutil.cpp:327:22: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/tables/splineutil.cpp:318:25: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/tables/splineutil.cpp:327:22: note: Shadow variable gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:2244:24: style: Local variable 'g' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:2132:20: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:2244:24: note: Shadow variable gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:1945:13: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/swap/swapcoords.cpp:997:19: style: Variable 'ind' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/taskassignment/reportgpuusage.cpp:88:55: style:inconclusive: Function 'reportGpuUsage' argument 4 names different: declaration 'numPpRanks' definition 'numRanks'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/taskassignment/reportgpuusage.h:83:55: note: Function 'reportGpuUsage' argument 4 names different: declaration 'numPpRanks' definition 'numRanks'. gromacs-2022-rc1/src/gromacs/taskassignment/reportgpuusage.cpp:88:55: note: Function 'reportGpuUsage' argument 4 names different: declaration 'numPpRanks' definition 'numRanks'. gromacs-2022-rc1/src/gromacs/taskassignment/findallgputasks.cpp:205:20: style: Consider using std::copy algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/taskassignment/tests/usergpuids.cpp:124:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/timing/tests/timing.cpp:80:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/timing/cyclecounter.cpp:189:5: style: Statements following return, break, continue, goto or throw will never be executed. [unreachableCode] gromacs-2022-rc1/src/gromacs/tables/forcetable.cpp:103:5: warning: Member variable 't_tabledata::nx' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/tables/forcetable.cpp:103:5: warning: Member variable 't_tabledata::nx0' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/tables/forcetable.cpp:103:5: warning: Member variable 't_tabledata::tabscale' is not initialized in the constructor. [uninitMemberVar] gromacs-2022-rc1/src/gromacs/taskassignment/taskassignment.h:259:22: style:inconclusive: Technically the member function 'gmx::GpuTaskAssignments::deviceIdsAssigned' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/taskassignment/taskassignment.h:197:5: style: Class 'GpuTaskAssignments' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/tables/forcetable.cpp:127:12: style: The scope of the variable 'br' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tables/forcetable.cpp:127:16: style: The scope of the variable 'br2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tables/forcetable.cpp:127:21: style: The scope of the variable 'br4' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tables/forcetable.cpp:127:26: style: The scope of the variable 'r6' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tables/forcetable.cpp:127:30: style: The scope of the variable 'factor' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/taskassignment/taskassignment.cpp:146:21: style: Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/tables/forcetable.cpp:152:14: style: The scope of the variable 'v_r0' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/taskassignment/taskassignment.cpp:191:31: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/tables/forcetable.cpp:153:14: style: The scope of the variable 'x_r0' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tables/forcetable.cpp:400:15: style: The scope of the variable 'nn0' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tables/forcetable.cpp:444:26: style: The scope of the variable 'b' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tables/forcetable.cpp:585:14: style: The scope of the variable 'start' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tables/forcetable.cpp:585:21: style: The scope of the variable 'end' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tables/forcetable.cpp:781:20: style: The scope of the variable 'p' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tables/forcetable.cpp:783:12: style: The scope of the variable 'r' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tables/forcetable.cpp:783:15: style: The scope of the variable 'r2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tables/forcetable.cpp:783:19: style: The scope of the variable 'r6' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tables/forcetable.cpp:783:23: style: The scope of the variable 'rc2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tables/forcetable.cpp:784:18: style: The scope of the variable 'Vtab' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tables/forcetable.cpp:784:24: style: The scope of the variable 'Ftab' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tables/forcetable.cpp:1394:19: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/convert_tpr.cpp:407:16: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/check.cpp:443:29: style: The scope of the variable 'k' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/check.cpp:453:16: style: The scope of the variable 'atom_vdw' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/timing/wallcycle.cpp:570:12: style: The scope of the variable 'nnodes_str' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/timing/wallcycle.cpp:571:12: style: The scope of the variable 'nthreads_str' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/timing/wallcycle.cpp:572:12: style: The scope of the variable 'ncalls_str' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/timing/wallcycle.cpp:573:12: style: The scope of the variable 'wallt' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/timing/wallcycle.cpp:689:48: style: The scope of the variable 'tot_cpu_overlap' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/timing/wallcycle.cpp:689:65: style: The scope of the variable 'gpu_cpu_ratio' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/timing/wallcycle.cpp:692:17: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/timing/wallcycle.cpp:898:21: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/tools/dump.cpp:99:16: style: The scope of the variable 'gp' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/dump.cpp:100:16: style: The scope of the variable 'indent' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/dump.cpp:100:24: style: The scope of the variable 'atot' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/dump.cpp:300:15: style: The scope of the variable 'indent' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/dump.cpp:573:43: style: The scope of the variable 'k' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/eneconv.cpp:74:18: style: The scope of the variable 'k' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/eneconv.cpp:74:21: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/eneconv.cpp:232:14: style: The scope of the variable 'inputstring' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/eneconv.cpp:701:29: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/tools/eneconv.cpp:468:46: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/tools/eneconv.cpp:701:29: note: Shadow variable gromacs-2022-rc1/src/gromacs/tools/mk_angndx.cpp:172:22: style: The scope of the variable 'ftype' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/mk_angndx.cpp:235:24: style: The scope of the variable 'ftype' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/tests/convert-tpr.cpp:80:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/tools/tests/dump.cpp:85:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/tools/tests/helpwriting.cpp:71:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/tools/tests/report_methods.cpp:102:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/tools/tests/trjconv.cpp:74:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/tools/make_ndx.cpp:394:39: style: Condition 'c==' '' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/tools/make_ndx.cpp:381:15: note: Assuming that condition 'c!=' '' is not redundant gromacs-2022-rc1/src/gromacs/tools/make_ndx.cpp:394:39: note: Condition 'c==' '' is always true gromacs-2022-rc1/src/gromacs/tools/make_ndx.cpp:466:58: style: Condition 'c==' '' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/tools/make_ndx.cpp:453:15: note: Assuming that condition 'c!=' '' is not redundant gromacs-2022-rc1/src/gromacs/tools/make_ndx.cpp:466:58: note: Condition 'c==' '' is always true gromacs-2022-rc1/src/gromacs/tools/make_ndx.cpp:1313:21: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/tools/pme_error.cpp:1044:17: portability: %g in format string (no. 2) requires 'double' but the argument type is 'int {aka signed int}'. [invalidPrintfArgType_float] gromacs-2022-rc1/src/gromacs/tools/make_ndx.cpp:77:18: style: The scope of the variable 'i2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/make_ndx.cpp:279:11: style: The scope of the variable 's' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/make_ndx.cpp:279:15: style: The scope of the variable 'sp' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/make_ndx.cpp:280:11: style: The scope of the variable 'c' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/make_ndx.cpp:512:23: style: The scope of the variable 'resnr' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/make_ndx.cpp:653:11: style: The scope of the variable 'name' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/make_ndx.cpp:766:24: style: The scope of the variable 'name' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/make_ndx.cpp:767:13: style: The scope of the variable 'resind' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/make_ndx.cpp:768:10: style: The scope of the variable 'a' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/make_ndx.cpp:807:10: style: The scope of the variable 'buf' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/make_ndx.cpp:809:13: style: The scope of the variable 'a' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/pme_error.cpp:125:10: style: The scope of the variable 'nrq_mol' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/make_ndx.cpp:930:19: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/make_ndx.cpp:931:22: style: The scope of the variable 'nr1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/make_ndx.cpp:1094:45: style: The scope of the variable 'resind' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/make_ndx.cpp:1137:14: style: The scope of the variable 'ostring' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/make_ndx.cpp:1533:23: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/make_ndx.cpp:1538:31: style: The scope of the variable 'block2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjcat.cpp:86:18: style: The scope of the variable 'ok' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjcat.cpp:186:14: style: The scope of the variable 'inputstring' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjcat.cpp:489:33: style: The scope of the variable 'frame' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjcat.cpp:489:40: style: The scope of the variable 'frame_out' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjcat.cpp:493:23: style: The scope of the variable 'n_append' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjcat.cpp:495:23: style: The scope of the variable 'cont_type' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjcat.cpp:496:23: style: The scope of the variable 'readtime' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjcat.cpp:500:34: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjcat.cpp:504:32: style: The scope of the variable 'ftpout' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjcat.cpp:504:45: style: The scope of the variable 'prevEndStep' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjcat.cpp:504:62: style: The scope of the variable 'filetype' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjcat.cpp:646:21: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/tools/trjcat.cpp:489:30: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/tools/trjcat.cpp:646:21: note: Shadow variable gromacs-2022-rc1/src/gromacs/tools/trjcat.cpp:790:21: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/tools/trjcat.cpp:489:30: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/tools/trjcat.cpp:790:21: note: Shadow variable gromacs-2022-rc1/src/gromacs/tools/trjcat.cpp:504:39: style: Variable 'ftpout' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/topology/atomprop.cpp:324:12: style: The scope of the variable 'fac' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/topology/atomprop.cpp:327:10: style: Local variable 'printWarning' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/topology/atomprop.cpp:357:13: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/topology/atomprop.cpp:327:10: note: Shadow variable gromacs-2022-rc1/src/gromacs/topology/atomprop.cpp:325:12: style: Variable 'def' can be declared as const array [constVariable] gromacs-2022-rc1/src/gromacs/topology/atomprop.cpp:388:30: style: Unused variable: tmpResidueName [unusedVariable] gromacs-2022-rc1/src/gromacs/tools/tune_pme.cpp:1928:46: style: Condition '0==std::strncmp(opt,"-s",2)' is always false [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/tools/tune_pme.cpp:356:28: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/tools/tune_pme.cpp:1516:9: warning:inconclusive: Possible null pointer dereference: nPMEnodes [nullPointer] gromacs-2022-rc1/src/gromacs/tools/tune_pme.cpp:1465:26: note: Assignment 'nPMEnodes=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/tools/tune_pme.cpp:1516:9: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/tools/tune_pme.cpp:1517:76: warning:inconclusive: Possible null pointer dereference: nPMEnodes [nullPointer] gromacs-2022-rc1/src/gromacs/tools/tune_pme.cpp:1465:26: note: Assignment 'nPMEnodes=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/tools/tune_pme.cpp:1517:76: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/tools/tune_pme.cpp:688:16: style: The scope of the variable 'cp' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/tune_pme.cpp:1200:17: style: The scope of the variable 'opt' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/tune_pme.cpp:1284:12: style: The scope of the variable 'npme' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/tune_pme.cpp:1284:18: style: The scope of the variable 'npp' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/tune_pme.cpp:1973:17: style: The scope of the variable 'name' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/tune_pme.cpp:2223:11: style: The scope of the variable 'guessPMEnodes' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/tune_pme.cpp:427:16: style: Variable 's' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/topology/block.cpp:110:10: warning:inconclusive: Possible null pointer dereference: block [nullPointer] gromacs-2022-rc1/src/gromacs/topology/block.cpp:107:23: note: Assignment 'block=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/block.cpp:110:10: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/block.cpp:291:10: style: The scope of the variable 'ok' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/topology/block.cpp:50:54: style:inconclusive: Function 'setAllBlocksSizeOne' argument 1 names different: declaration 'numBlocks' definition 'numBlocksToSet'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/topology/block.h:110:34: note: Function 'setAllBlocksSizeOne' argument 1 names different: declaration 'numBlocks' definition 'numBlocksToSet'. gromacs-2022-rc1/src/gromacs/topology/block.cpp:50:54: note: Function 'setAllBlocksSizeOne' argument 1 names different: declaration 'numBlocks' definition 'numBlocksToSet'. gromacs-2022-rc1/src/gromacs/topology/block.cpp:348:91: style:inconclusive: Function 'pr_listoflists' argument 4 names different: declaration 'block' definition 'lists'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/topology/block.h:225:91: note: Function 'pr_listoflists' argument 4 names different: declaration 'block' definition 'lists'. gromacs-2022-rc1/src/gromacs/topology/block.cpp:348:91: note: Function 'pr_listoflists' argument 4 names different: declaration 'block' definition 'lists'. gromacs-2022-rc1/src/gromacs/topology/block.cpp:291:13: style: Variable 'ok' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:159:5: warning:inconclusive: Possible null pointer dereference: atoms [nullPointer] gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:195:20: note: Assignment 'dst=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:198:18: note: Calling function 'init_t_atoms', 1st argument 'dst' value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:159:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:160:5: warning:inconclusive: Possible null pointer dereference: atoms [nullPointer] gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:195:20: note: Assignment 'dst=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:198:18: note: Calling function 'init_t_atoms', 1st argument 'dst' value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:160:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:161:10: warning:inconclusive: Possible null pointer dereference: atoms [nullPointer] gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:195:20: note: Assignment 'dst=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:198:18: note: Calling function 'init_t_atoms', 1st argument 'dst' value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:161:10: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:162:5: warning:inconclusive: Possible null pointer dereference: atoms [nullPointer] gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:195:20: note: Assignment 'dst=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:198:18: note: Calling function 'init_t_atoms', 1st argument 'dst' value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:162:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:163:5: warning:inconclusive: Possible null pointer dereference: atoms [nullPointer] gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:195:20: note: Assignment 'dst=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:198:18: note: Calling function 'init_t_atoms', 1st argument 'dst' value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:163:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:164:10: warning:inconclusive: Possible null pointer dereference: atoms [nullPointer] gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:195:20: note: Assignment 'dst=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:198:18: note: Calling function 'init_t_atoms', 1st argument 'dst' value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:164:10: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:165:10: warning:inconclusive: Possible null pointer dereference: atoms [nullPointer] gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:195:20: note: Assignment 'dst=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:198:18: note: Calling function 'init_t_atoms', 1st argument 'dst' value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:165:10: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:166:5: warning:inconclusive: Possible null pointer dereference: atoms [nullPointer] gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:195:20: note: Assignment 'dst=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:198:18: note: Calling function 'init_t_atoms', 1st argument 'dst' value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:166:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:167:5: warning:inconclusive: Possible null pointer dereference: atoms [nullPointer] gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:195:20: note: Assignment 'dst=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:198:18: note: Calling function 'init_t_atoms', 1st argument 'dst' value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:167:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:168:5: warning:inconclusive: Possible null pointer dereference: atoms [nullPointer] gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:195:20: note: Assignment 'dst=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:198:18: note: Calling function 'init_t_atoms', 1st argument 'dst' value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:168:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:169:5: warning:inconclusive: Possible null pointer dereference: atoms [nullPointer] gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:195:20: note: Assignment 'dst=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:198:18: note: Calling function 'init_t_atoms', 1st argument 'dst' value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:169:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:170:5: warning:inconclusive: Possible null pointer dereference: atoms [nullPointer] gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:195:20: note: Assignment 'dst=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:198:18: note: Calling function 'init_t_atoms', 1st argument 'dst' value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:170:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:171:9: warning:inconclusive: Possible null pointer dereference: atoms [nullPointer] gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:195:20: note: Assignment 'dst=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:198:18: note: Calling function 'init_t_atoms', 1st argument 'dst' value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:171:9: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:173:14: warning:inconclusive: Possible null pointer dereference: atoms [nullPointer] gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:195:20: note: Assignment 'dst=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:198:18: note: Calling function 'init_t_atoms', 1st argument 'dst' value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:173:14: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:177:9: warning:inconclusive: Possible null pointer dereference: atoms [nullPointer] gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:195:20: note: Assignment 'dst=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:198:18: note: Calling function 'init_t_atoms', 1st argument 'dst' value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:177:9: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:209:9: warning:inconclusive: Possible null pointer dereference: dst [nullPointer] gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:195:20: note: Assignment 'dst=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:209:9: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:227:5: warning:inconclusive: Possible null pointer dereference: dst [nullPointer] gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:195:20: note: Assignment 'dst=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:227:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:228:5: warning:inconclusive: Possible null pointer dereference: dst [nullPointer] gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:195:20: note: Assignment 'dst=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:228:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:229:5: warning:inconclusive: Possible null pointer dereference: dst [nullPointer] gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:195:20: note: Assignment 'dst=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:229:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:230:5: warning:inconclusive: Possible null pointer dereference: dst [nullPointer] gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:195:20: note: Assignment 'dst=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:230:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:231:5: warning:inconclusive: Possible null pointer dereference: dst [nullPointer] gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:195:20: note: Assignment 'dst=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:231:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:232:5: warning:inconclusive: Possible null pointer dereference: dst [nullPointer] gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:195:20: note: Assignment 'dst=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:232:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:235:9: warning:inconclusive: Possible null pointer dereference: dst [nullPointer] gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:195:20: note: Assignment 'dst=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:235:9: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/idef.h:378:5: style: Class 'InteractionDefinitions' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:103:34: style:inconclusive: Function 'done_atomtypes' argument 1 names different: declaration 'at' definition 'atype'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/topology/atoms.h:163:34: note: Function 'done_atomtypes' argument 1 names different: declaration 'at' definition 'atype'. gromacs-2022-rc1/src/gromacs/topology/atoms.cpp:103:34: note: Function 'done_atomtypes' argument 1 names different: declaration 'at' definition 'atype'. gromacs-2022-rc1/src/gromacs/topology/index.cpp:460:46: style: Array index 'n' is used before limits check. [arrayIndexThenCheck] gromacs-2022-rc1/src/gromacs/topology/index.cpp:463:41: style: Array index 'n' is used before limits check. [arrayIndexThenCheck] gromacs-2022-rc1/src/gromacs/topology/index.cpp:501:42: style: Array index 'n' is used before limits check. [arrayIndexThenCheck] gromacs-2022-rc1/src/gromacs/topology/index.cpp:505:37: style: Array index 'n' is used before limits check. [arrayIndexThenCheck] gromacs-2022-rc1/src/gromacs/topology/invblock.cpp:54:9: warning:inconclusive: Possible null pointer dereference: invblock [nullPointer] gromacs-2022-rc1/src/gromacs/topology/invblock.cpp:48:21: note: Assignment 'invblock=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/invblock.cpp:54:9: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/invblock.cpp:60:17: warning:inconclusive: Possible null pointer dereference: invblock [nullPointer] gromacs-2022-rc1/src/gromacs/topology/invblock.cpp:48:21: note: Assignment 'invblock=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/invblock.cpp:60:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/invblock.cpp:86:9: warning:inconclusive: Possible null pointer dereference: invblock [nullPointer] gromacs-2022-rc1/src/gromacs/topology/invblock.cpp:80:21: note: Assignment 'invblock=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/invblock.cpp:86:9: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/invblock.cpp:92:17: warning:inconclusive: Possible null pointer dereference: invblock [nullPointer] gromacs-2022-rc1/src/gromacs/topology/invblock.cpp:80:21: note: Assignment 'invblock=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/invblock.cpp:92:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/index.cpp:667:20: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] gromacs-2022-rc1/src/gromacs/topology/index.cpp:661:16: note: outer condition: nwater>0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:667:20: note: identical inner condition: nwater>0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:674:18: style: Condition 'nion>0' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/topology/index.cpp:661:28: note: Assuming that condition 'nion>0' is not redundant gromacs-2022-rc1/src/gromacs/topology/index.cpp:674:18: note: Condition 'nion>0' is always true gromacs-2022-rc1/src/gromacs/topology/index.cpp:746:20: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/topology/index.cpp:868:17: warning: scanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/topology/index.cpp:647:25: warning:inconclusive: Possible null pointer dereference: gb [nullPointer] gromacs-2022-rc1/src/gromacs/topology/index.cpp:955:24: note: Assignment 'grps=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:968:24: note: Calling function 'analyse', 2nd argument 'grps' value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:647:25: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/index.cpp:649:31: warning:inconclusive: Possible null pointer dereference: gn [nullPointer] gromacs-2022-rc1/src/gromacs/topology/index.cpp:954:24: note: Assignment 'gnames=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:968:30: note: Calling function 'analyse', 3rd argument 'gnames' value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:649:31: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/index.cpp:719:5: warning:inconclusive: Possible null pointer dereference: b [nullPointer] gromacs-2022-rc1/src/gromacs/topology/index.cpp:714:19: note: Assignment 'b=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:719:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/index.cpp:720:5: warning:inconclusive: Possible null pointer dereference: b [nullPointer] gromacs-2022-rc1/src/gromacs/topology/index.cpp:714:19: note: Assignment 'b=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:720:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/index.cpp:721:5: warning:inconclusive: Possible null pointer dereference: b [nullPointer] gromacs-2022-rc1/src/gromacs/topology/index.cpp:714:19: note: Assignment 'b=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:721:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/index.cpp:722:5: warning:inconclusive: Possible null pointer dereference: b [nullPointer] gromacs-2022-rc1/src/gromacs/topology/index.cpp:714:19: note: Assignment 'b=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:722:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/index.cpp:723:6: warning:inconclusive: Possible null pointer dereference: grpname [nullPointer] gromacs-2022-rc1/src/gromacs/topology/index.cpp:954:24: note: Assignment 'gnames=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:962:32: note: Calling function 'init_index', 2nd argument 'gnames' value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:723:6: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/index.cpp:764:26: warning:inconclusive: Possible null pointer dereference: b [nullPointer] gromacs-2022-rc1/src/gromacs/topology/index.cpp:714:19: note: Assignment 'b=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:764:26: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/index.cpp:766:16: warning:inconclusive: Possible null pointer dereference: b [nullPointer] gromacs-2022-rc1/src/gromacs/topology/index.cpp:714:19: note: Assignment 'b=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:766:16: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/index.cpp:767:22: warning:inconclusive: Possible null pointer dereference: b [nullPointer] gromacs-2022-rc1/src/gromacs/topology/index.cpp:714:19: note: Assignment 'b=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:767:22: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/index.cpp:769:17: warning:inconclusive: Possible null pointer dereference: b [nullPointer] gromacs-2022-rc1/src/gromacs/topology/index.cpp:714:19: note: Assignment 'b=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:769:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/index.cpp:967:14: warning:inconclusive: Possible null pointer dereference: grps [nullPointer] gromacs-2022-rc1/src/gromacs/topology/index.cpp:955:24: note: Assignment 'grps=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:967:14: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/index.cpp:975:22: warning:inconclusive: Possible null pointer dereference: gnames [nullPointer] gromacs-2022-rc1/src/gromacs/topology/index.cpp:954:24: note: Assignment 'gnames=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:975:22: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/index.cpp:978:17: warning:inconclusive: Possible null pointer dereference: gnames [nullPointer] gromacs-2022-rc1/src/gromacs/topology/index.cpp:954:24: note: Assignment 'gnames=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:978:17: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/index.cpp:980:12: warning:inconclusive: Possible null pointer dereference: gnames [nullPointer] gromacs-2022-rc1/src/gromacs/topology/index.cpp:954:24: note: Assignment 'gnames=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:980:12: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/index.cpp:992:5: warning:inconclusive: Possible null pointer dereference: c [nullPointer] gromacs-2022-rc1/src/gromacs/topology/index.cpp:989:24: note: Assignment 'c=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:992:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/index.cpp:993:5: warning:inconclusive: Possible null pointer dereference: c [nullPointer] gromacs-2022-rc1/src/gromacs/topology/index.cpp:989:24: note: Assignment 'c=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:993:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/index.cpp:994:26: warning:inconclusive: Possible null pointer dereference: c [nullPointer] gromacs-2022-rc1/src/gromacs/topology/index.cpp:989:24: note: Assignment 'c=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:994:26: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/index.cpp:996:9: warning:inconclusive: Possible null pointer dereference: c [nullPointer] gromacs-2022-rc1/src/gromacs/topology/index.cpp:989:24: note: Assignment 'c=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:996:9: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/index.cpp:1000:13: warning:inconclusive: Possible null pointer dereference: c [nullPointer] gromacs-2022-rc1/src/gromacs/topology/index.cpp:989:24: note: Assignment 'c=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:1000:13: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/index.cpp:1001:13: warning:inconclusive: Possible null pointer dereference: c [nullPointer] gromacs-2022-rc1/src/gromacs/topology/index.cpp:989:24: note: Assignment 'c=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:1001:13: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/index.cpp:1002:13: warning:inconclusive: Possible null pointer dereference: c [nullPointer] gromacs-2022-rc1/src/gromacs/topology/index.cpp:989:24: note: Assignment 'c=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:1002:13: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/index.cpp:1019:5: warning:inconclusive: Possible null pointer dereference: c [nullPointer] gromacs-2022-rc1/src/gromacs/topology/index.cpp:989:24: note: Assignment 'c=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/index.cpp:1019:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/tests/exclusionblocks.cpp:164:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/topology/index.cpp:63:10: style: The scope of the variable 'c' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/topology/index.cpp:386:10: style: The scope of the variable 'ndx_name' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/topology/tests/idef.cpp:62:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/topology/index.cpp:792:15: style: The scope of the variable 'string' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/topology/index.cpp:271:18: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/topology/index.cpp:230:26: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/topology/index.cpp:271:18: note: Shadow variable gromacs-2022-rc1/src/gromacs/topology/tests/mtop.cpp:128:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/topology/index.cpp:577:25: style: Local variable 'resnm' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/topology/index.cpp:571:21: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/topology/index.cpp:577:25: note: Shadow variable gromacs-2022-rc1/src/gromacs/topology/index.cpp:602:26: style: Local variable 'aid' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/topology/index.cpp:560:22: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/topology/index.cpp:602:26: note: Shadow variable gromacs-2022-rc1/src/gromacs/topology/index.cpp:612:30: style: Local variable 'aid' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/topology/index.cpp:602:26: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/topology/index.cpp:612:30: note: Shadow variable gromacs-2022-rc1/src/gromacs/topology/index.cpp:626:30: style: Local variable 'aid' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/topology/index.cpp:602:26: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/topology/index.cpp:626:30: note: Shadow variable gromacs-2022-rc1/src/gromacs/topology/tests/symtab.cpp:172:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/topology/index.cpp:687:48: style: Parameter 'index' can be declared as const array [constParameter] gromacs-2022-rc1/src/gromacs/topology/tests/topsort.cpp:109:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/topology/mtop_util.h:83:5: style: Class 'AtomProxy' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/topology/mtop_util.h:167:5: style: Class 'IListProxy' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/topology/mtop_util.cpp:203:5: warning:inconclusive: Possible null pointer dereference: aloop [nullPointer] gromacs-2022-rc1/src/gromacs/topology/mtop_util.cpp:199:45: note: Assignment 'aloop=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/mtop_util.cpp:203:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/mtop_util.cpp:204:5: warning:inconclusive: Possible null pointer dereference: aloop [nullPointer] gromacs-2022-rc1/src/gromacs/topology/mtop_util.cpp:199:45: note: Assignment 'aloop=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/mtop_util.cpp:204:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/mtop_util.cpp:205:5: warning:inconclusive: Possible null pointer dereference: aloop [nullPointer] gromacs-2022-rc1/src/gromacs/topology/mtop_util.cpp:199:45: note: Assignment 'aloop=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/mtop_util.cpp:205:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/mtop_util.cpp:206:5: warning:inconclusive: Possible null pointer dereference: aloop [nullPointer] gromacs-2022-rc1/src/gromacs/topology/mtop_util.cpp:199:45: note: Assignment 'aloop=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/mtop_util.cpp:206:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/mtop_util.cpp:243:61: style:inconclusive: Function 'IListIterator' argument 2 names different: declaration 'mblock' definition 'molblock'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/topology/mtop_util.h:188:59: note: Function 'IListIterator' argument 2 names different: declaration 'mblock' definition 'molblock'. gromacs-2022-rc1/src/gromacs/topology/mtop_util.cpp:243:61: note: Function 'IListIterator' argument 2 names different: declaration 'mblock' definition 'molblock'. gromacs-2022-rc1/src/gromacs/topology/mtop_util.cpp:1016:35: style: Parameter 'symtab' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/gromacs/topology/mtop_util.cpp:84:22: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/topology/mtop_util.cpp:94:14: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/topology/mtop_util.cpp:301:11: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/topology/mtop_util.cpp:341:11: style: Variable 'i' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/topology/mtop_util.cpp:341:35: style: Variable 'size' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/topology/symtab.h:93:5: style: Class 'StringTable' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/topology/symtab.h:135:5: style: Class 'StringTable' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/topology/symtab.cpp:259:5: warning:inconclusive: Possible null pointer dereference: symbuf [nullPointer] gromacs-2022-rc1/src/gromacs/topology/symtab.cpp:256:24: note: Assignment 'symbuf=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/symtab.cpp:259:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/symtab.cpp:260:10: warning:inconclusive: Possible null pointer dereference: symbuf [nullPointer] gromacs-2022-rc1/src/gromacs/topology/symtab.cpp:256:24: note: Assignment 'symbuf=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/symtab.cpp:260:10: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/symtab.cpp:261:5: warning:inconclusive: Possible null pointer dereference: symbuf [nullPointer] gromacs-2022-rc1/src/gromacs/topology/symtab.cpp:256:24: note: Assignment 'symbuf=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/symtab.cpp:261:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/symtab.cpp:326:5: warning:inconclusive: Possible null pointer dereference: symtab [nullPointer] gromacs-2022-rc1/src/gromacs/topology/symtab.cpp:336:28: note: Assignment 'copySymtab=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/symtab.cpp:338:17: note: Calling function 'open_symtab', 1st argument 'copySymtab' value is 0 gromacs-2022-rc1/src/gromacs/topology/symtab.cpp:326:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/symtab.cpp:327:5: warning:inconclusive: Possible null pointer dereference: symtab [nullPointer] gromacs-2022-rc1/src/gromacs/topology/symtab.cpp:336:28: note: Assignment 'copySymtab=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/symtab.cpp:338:17: note: Calling function 'open_symtab', 1st argument 'copySymtab' value is 0 gromacs-2022-rc1/src/gromacs/topology/symtab.cpp:327:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/symtab.cpp:344:28: warning:inconclusive: Possible null pointer dereference: copySymtab [nullPointer] gromacs-2022-rc1/src/gromacs/topology/symtab.cpp:336:28: note: Assignment 'copySymtab=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/symtab.cpp:344:28: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/symtab.cpp:363:5: warning:inconclusive: Possible null pointer dereference: copySymtab [nullPointer] gromacs-2022-rc1/src/gromacs/topology/symtab.cpp:336:28: note: Assignment 'copySymtab=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/topology/symtab.cpp:363:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/topology/symtab.cpp:235:48: style:inconclusive: Function 'get_symtab_handle' argument 2 names different: declaration 'index' definition 'name'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/topology/symtab.h:329:48: note: Function 'get_symtab_handle' argument 2 names different: declaration 'index' definition 'name'. gromacs-2022-rc1/src/gromacs/topology/symtab.cpp:235:48: note: Function 'get_symtab_handle' argument 2 names different: declaration 'index' definition 'name'. gromacs-2022-rc1/src/gromacs/topology/topsort.cpp:184:83: performance:inconclusive: Function parameter 'atomInfo' should be passed by const reference. [passedByValue] gromacs-2022-rc1/src/gromacs/trajectory/energyframe.cpp:86:12: warning: Either the condition 'valueIterator==values_.end()' is redundant or there is possible dereference of an invalid iterator: valueIterator. [derefInvalidIteratorRedundantCheck] gromacs-2022-rc1/src/gromacs/trajectory/energyframe.cpp:81:23: note: Assuming that condition 'valueIterator==values_.end()' is not redundant gromacs-2022-rc1/src/gromacs/trajectory/energyframe.cpp:86:12: note: Dereference of an invalid iterator gromacs-2022-rc1/src/gromacs/trajectoryanalysis/analysismodule.h:440:10: style:inconclusive: Technically the member function 'gmx::TrajectoryAnalysisModule::finishFrameSerial' can be const. [functionConst] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/analysismodule.cpp:343:32: note: Technically the member function 'gmx::TrajectoryAnalysisModule::finishFrameSerial' can be const. gromacs-2022-rc1/src/gromacs/trajectoryanalysis/analysismodule.h:440:10: note: Technically the member function 'gmx::TrajectoryAnalysisModule::finishFrameSerial' can be const. gromacs-2022-rc1/src/gromacs/trajectoryanalysis/analysismodule.cpp:307:80: warning: Either the condition 'index<0' is redundant, otherwise there is negative array index -1. [negativeContainerIndex] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/analysismodule.cpp:303:15: note: Assuming that condition 'index<0' is not redundant gromacs-2022-rc1/src/gromacs/trajectoryanalysis/analysismodule.cpp:307:80: note: Negative array index gromacs-2022-rc1/src/gromacs/trajectory/trajectoryframe.cpp:113:5: performance: Variable 'box_' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/extract_cluster.cpp:197:53: style:inconclusive: Function 'analyzeFrame' argument 2 names different: declaration 'fr' definition 'frame'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/extract_cluster.cpp:84:58: note: Function 'analyzeFrame' argument 2 names different: declaration 'fr' definition 'frame'. gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/extract_cluster.cpp:197:53: note: Function 'analyzeFrame' argument 2 names different: declaration 'fr' definition 'frame'. gromacs-2022-rc1/src/gromacs/topology/topology.h:231:5: style: Struct 'gmx_localtop_t' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/msd.cpp:108:9: style: Class 'MsdColumnProxy' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/msd.cpp:637:20: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/angle.cpp:319:5: performance: Variable 'averageModule_' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/rdf.cpp:556:29: style: Local variable 'i' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/rdf.cpp:541:22: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/rdf.cpp:556:29: note: Shadow variable gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:118:9: warning:inconclusive: Possible null pointer dereference: c [nullPointer] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:163:19: note: Assignment 'c=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:179:21: note: Calling function 'add_rec', 1st argument 'c' value is 0 gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:118:9: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:139:9: warning:inconclusive: Possible null pointer dereference: c [nullPointer] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:163:19: note: Assignment 'c=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:179:21: note: Calling function 'add_rec', 1st argument 'c' value is 0 gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:139:9: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:169:9: warning:inconclusive: Possible null pointer dereference: c [nullPointer] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:163:19: note: Assignment 'c=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:169:9: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:186:14: warning:inconclusive: Possible null pointer dereference: c [nullPointer] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:163:19: note: Assignment 'c=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:186:14: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:190:49: warning:inconclusive: Possible null pointer dereference: c [nullPointer] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:163:19: note: Assignment 'c=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:190:49: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:232:29: warning:inconclusive: Possible null pointer dereference: xnew [nullPointer] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:213:18: note: Assignment 'xnew=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:232:29: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:240:13: warning:inconclusive: Possible null pointer dereference: xnew [nullPointer] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:213:18: note: Assignment 'xnew=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:240:13: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:241:13: warning:inconclusive: Possible null pointer dereference: xnew [nullPointer] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:213:18: note: Assignment 'xnew=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:241:13: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:242:13: warning:inconclusive: Possible null pointer dereference: xnew [nullPointer] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:213:18: note: Assignment 'xnew=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:242:13: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:272:13: warning:inconclusive: Possible null pointer dereference: xnew [nullPointer] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:213:18: note: Assignment 'xnew=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:272:13: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:273:13: warning:inconclusive: Possible null pointer dereference: xnew [nullPointer] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:213:18: note: Assignment 'xnew=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:273:13: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:274:13: warning:inconclusive: Possible null pointer dereference: xnew [nullPointer] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:213:18: note: Assignment 'xnew=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/sasa.cpp:274:13: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:178:20: style: Local variable 'a' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:167:16: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:178:20: note: Shadow variable gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:394:28: style: Local variable 'x' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:364:24: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:394:28: note: Shadow variable gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:395:28: style: Local variable 'y' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:365:24: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:395:28: note: Shadow variable gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:396:28: style: Local variable 'z' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:366:24: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:396:28: note: Shadow variable gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:397:28: style: Local variable 'd' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:367:24: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:397:28: note: Shadow variable gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:375:32: style: Local variable 'x' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:364:24: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:375:32: note: Shadow variable gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:376:32: style: Local variable 'y' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:365:24: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:376:32: note: Shadow variable gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:377:32: style: Local variable 'z' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:366:24: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:377:32: note: Shadow variable gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:378:32: style: Local variable 'd' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:367:24: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:378:32: note: Shadow variable gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:385:32: style: Local variable 'x' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:364:24: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:385:32: note: Shadow variable gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:386:32: style: Local variable 'y' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:365:24: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:386:32: note: Shadow variable gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:387:32: style: Local variable 'z' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:366:24: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:387:32: note: Shadow variable gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:388:32: style: Local variable 'd' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:367:24: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:388:32: note: Shadow variable gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:408:13: style: Local variable 'tn' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:356:9: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:408:13: note: Shadow variable gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:469:26: style: Local variable 'x' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:458:28: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:469:26: note: Shadow variable gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:470:26: style: Local variable 'y' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:459:28: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:470:26: note: Shadow variable gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:471:26: style: Local variable 'z' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:460:28: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:471:26: note: Shadow variable gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:472:26: style: Local variable 'd' shadows outer variable [shadowVariable] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:461:28: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/trajectoryanalysis/modules/surfacearea.cpp:472:26: note: Shadow variable gromacs-2022-rc1/src/gromacs/trajectoryanalysis/tests/angle.cpp:73:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/tests/clustsize.cpp:99:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/tests/cmdlinerunner.cpp:110:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/tests/convert_trj.cpp:77:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/tests/distance.cpp:72:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/tests/extract_cluster.cpp:137:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/tests/freevolume.cpp:72:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/tests/msd.cpp:194:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/tests/pairdist.cpp:87:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/tests/rdf.cpp:85:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/tests/sasa.cpp:91:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/tests/select.cpp:85:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/tests/surfacearea.cpp:227:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/tests/topologyinformation.cpp:132:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/tests/trajectory.cpp:81:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/tests/unionfind.cpp:64:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/utility/alignedallocator.cpp:250:23: style: Condition 'pageSize==-1' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/utility/alignedallocator.cpp:248:17: note: Assignment 'pageSize=-1', assigned value is -1 gromacs-2022-rc1/src/gromacs/utility/alignedallocator.cpp:250:23: note: Condition 'pageSize==-1' is always true gromacs-2022-rc1/src/gromacs/utility/alignedallocator.cpp:235:10: style: Local variable 'pageSize' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/utility/alignedallocator.h:115:13: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/utility/alignedallocator.cpp:235:10: note: Shadow variable gromacs-2022-rc1/src/gromacs/trajectoryanalysis/topologyinformation.cpp:80:11: style: Local variable 'x' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/topologyinformation.h:148:26: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/trajectoryanalysis/topologyinformation.cpp:80:11: note: Shadow variable gromacs-2022-rc1/src/gromacs/trajectoryanalysis/topologyinformation.cpp:80:25: style: Local variable 'v' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/trajectoryanalysis/topologyinformation.h:157:26: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/trajectoryanalysis/topologyinformation.cpp:80:25: note: Shadow variable gromacs-2022-rc1/src/gromacs/utility/binaryinformation.cpp:232:1: error: Found a exit path from function with non-void return type that has missing return statement [missingReturn] gromacs-2022-rc1/src/gromacs/utility/coolstuff.cpp:133:21: style: struct member 'Quote::text' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/utility/coolstuff.cpp:134:21: style: struct member 'Quote::author' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/utility/cstringutil.cpp:273:18: warning:inconclusive: Possible null pointer dereference: dest [nullPointer] gromacs-2022-rc1/src/gromacs/utility/cstringutil.cpp:269:18: note: Assignment 'dest=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/utility/cstringutil.cpp:273:18: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/utility/cstringutil.cpp:288:13: warning:inconclusive: Possible null pointer dereference: dest [nullPointer] gromacs-2022-rc1/src/gromacs/utility/cstringutil.cpp:280:18: note: Assignment 'dest=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/utility/cstringutil.cpp:288:13: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/utility/cstringutil.cpp:289:5: warning:inconclusive: Possible null pointer dereference: dest [nullPointer] gromacs-2022-rc1/src/gromacs/utility/cstringutil.cpp:280:18: note: Assignment 'dest=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/utility/cstringutil.cpp:289:5: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/utility/cstringutil.cpp:412:13: warning:inconclusive: Possible null pointer dereference: b2 [nullPointer] gromacs-2022-rc1/src/gromacs/utility/cstringutil.cpp:403:19: note: Assignment 'b2=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/utility/cstringutil.cpp:412:13: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/utility/cstringutil.cpp:423:13: warning:inconclusive: Possible null pointer dereference: b2 [nullPointer] gromacs-2022-rc1/src/gromacs/utility/cstringutil.cpp:403:19: note: Assignment 'b2=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/utility/cstringutil.cpp:423:13: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/utility/cstringutil.cpp:231:19: style: The scope of the variable 'ch2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/utility/cstringutil.cpp:247:19: style: The scope of the variable 'ch2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/utility/cstringutil.cpp:78:20: style:inconclusive: Function 'fgets2' argument 1 names different: declaration 's' definition 'line'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/utility/cstringutil.h:70:20: note: Function 'fgets2' argument 1 names different: declaration 's' definition 'line'. gromacs-2022-rc1/src/gromacs/utility/cstringutil.cpp:78:20: note: Function 'fgets2' argument 1 names different: declaration 's' definition 'line'. gromacs-2022-rc1/src/gromacs/utility/cstringutil.cpp:231:23: style: Variable 'ch2' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/utility/cstringutil.cpp:247:23: style: Variable 'ch2' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/gromacs/utility/directoryenumerator.cpp:218:10: performance:inconclusive: Technically the member function 'gmx::Impl::nextFile' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/gromacs/utility/datafilefinder.h:89:5: style: Class 'DataFileOptions' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/utility/datafilefinder.h:93:5: style: Class 'DataFileOptions' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/utility/fatalerror.cpp:235:5: style: Statements following return, break, continue, goto or throw will never be executed. [unreachableCode] gromacs-2022-rc1/src/gromacs/utility/fatalerror.cpp:131:19: style: Variable 'map' can be declared as const array [constVariable] gromacs-2022-rc1/src/gromacs/utility/futil.cpp:493:5: error: There is an unknown macro here somewhere. Configuration is required. If GMX_CATCH_ALL_AND_EXIT_WITH_FATAL_ERROR is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/utility/filestream.cpp:230:40: style:inconclusive: Function 'write' argument 1 names different: declaration 'text' definition 'str'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/utility/filestream.h:167:28: note: Function 'write' argument 1 names different: declaration 'text' definition 'str'. gromacs-2022-rc1/src/gromacs/utility/filestream.cpp:230:40: note: Function 'write' argument 1 names different: declaration 'text' definition 'str'. gromacs-2022-rc1/src/gromacs/utility/inmemoryserializer.cpp:132:5: style: Class 'Impl' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/utility/logger.h:97:21: error: There is an unknown macro here somewhere. Configuration is required. If appendTextFormatted is a macro then please configure it. [unknownMacro] gromacs-2022-rc1/src/gromacs/utility/keyvaluetree.h:110:5: style: Class 'KeyValueTreePath' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/utility/keyvaluetree.h:112:5: style: Class 'KeyValueTreePath' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/utility/loggerbuilder.h:138:5: style: Class 'LoggerOwner' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/gromacs/utility/keyvaluetree.h:119:14: style: Local variable 'elements' shadows outer function [shadowFunction] gromacs-2022-rc1/src/gromacs/utility/keyvaluetree.h:139:37: note: Shadowed declaration gromacs-2022-rc1/src/gromacs/utility/keyvaluetree.h:119:14: note: Shadow variable gromacs-2022-rc1/src/gromacs/utility/keyvaluetreeserializer.cpp:67:30: style: struct member 'Serializer::typeTag' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/utility/keyvaluetreeserializer.cpp:68:30: style: struct member 'Serializer::serialize' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/utility/keyvaluetreetransform.cpp:486:22: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/gromacs/utility/keyvaluetreeserializer.cpp:69:30: style: struct member 'Serializer::deserialize' is never used. [unusedStructMember] gromacs-2022-rc1/src/gromacs/utility/physicalnodecommunicator.h:83:10: performance:inconclusive: Technically the member function 'gmx::PhysicalNodeCommunicator::barrier' can be static (but you may consider moving to unnamed namespace). [functionStatic] gromacs-2022-rc1/src/gromacs/utility/physicalnodecommunicator.cpp:114:32: note: Technically the member function 'gmx::PhysicalNodeCommunicator::barrier' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/gromacs/utility/physicalnodecommunicator.h:83:10: note: Technically the member function 'gmx::PhysicalNodeCommunicator::barrier' can be static (but you may consider moving to unnamed namespace). gromacs-2022-rc1/src/gromacs/utility/programcontext.cpp:100:47: style:inconclusive: Function 'setProgramContext' argument 1 names different: declaration 'context' definition 'programContext'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/utility/programcontext.h:211:47: note: Function 'setProgramContext' argument 1 names different: declaration 'context' definition 'programContext'. gromacs-2022-rc1/src/gromacs/utility/programcontext.cpp:100:47: note: Function 'setProgramContext' argument 1 names different: declaration 'context' definition 'programContext'. gromacs-2022-rc1/src/gromacs/utility/stringstream.cpp:54:44: style:inconclusive: Function 'write' argument 1 names different: declaration 'text' definition 'str'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/utility/stringstream.h:71:28: note: Function 'write' argument 1 names different: declaration 'text' definition 'str'. gromacs-2022-rc1/src/gromacs/utility/stringstream.cpp:54:44: note: Function 'write' argument 1 names different: declaration 'text' definition 'str'. gromacs-2022-rc1/src/gromacs/utility/strdb.cpp:111:12: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/gromacs/utility/strdb.cpp:60:20: warning:inconclusive: Possible null pointer dereference: line0 [nullPointer] gromacs-2022-rc1/src/gromacs/utility/strdb.cpp:53:19: note: Assignment 'line0=nullptr', assigned value is 0 gromacs-2022-rc1/src/gromacs/utility/strdb.cpp:60:20: note: Null pointer dereference gromacs-2022-rc1/src/gromacs/utility/tests/alignedallocator.cpp:88:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/utility/sysinfo.cpp:154:5: style: Obsolescent function 'ctime_r' called. It is recommended to use 'strftime' instead. [prohibitedctime_rCalled] gromacs-2022-rc1/src/gromacs/utility/tests/arrayref.cpp:70:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/utility/stringutil.cpp:440:20: style: Condition 'lineLength==0' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/utility/stringutil.cpp:433:24: note: Assuming that condition 'lineEnd>lineStart' is not redundant gromacs-2022-rc1/src/gromacs/utility/stringutil.cpp:439:39: note: Assignment 'lineLength=lineEnd-lineStart', assigned value is less than 1 gromacs-2022-rc1/src/gromacs/utility/stringutil.cpp:440:20: note: Condition 'lineLength==0' is always true gromacs-2022-rc1/src/gromacs/utility/tests/cstringutil.cpp:77:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/utility/tests/defaultinitializationallocator.cpp:66:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/utility/tests/enumerationhelpers.cpp:67:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/utility/tests/fixedcapacityvector.cpp:63:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/utility/tests/inmemoryserializer.cpp:187:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/utility/tests/keyvaluetreeserializer.cpp:119:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/utility/tests/keyvaluetreetransform.cpp:110:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/utility/tests/listoflists.cpp:72:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/utility/tests/logger.cpp:63:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/utility/tests/mdmodulesnotifier.cpp:98:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/utility/tests/message_string_collector.cpp:72:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/utility/tests/path.cpp:79:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/utility/tests/physicalnodecommunicator.cpp:55:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/utility/tests/physicalnodecommunicator_mpi.cpp:58:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/utility/tests/range.cpp:67:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/utility/strconvert.cpp:60:33: style:inconclusive: Function 'boolFromString' argument 1 names different: declaration 'str' definition 'value'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/utility/strconvert.h:68:33: note: Function 'boolFromString' argument 1 names different: declaration 'str' definition 'value'. gromacs-2022-rc1/src/gromacs/utility/strconvert.cpp:60:33: note: Function 'boolFromString' argument 1 names different: declaration 'str' definition 'value'. gromacs-2022-rc1/src/gromacs/utility/tests/strconvert.cpp:63:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/utility/tests/stringtoenumvalueconverter.cpp:94:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/utility/tests/stringutil.cpp:90:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/utility/tests/template_mp.cpp:73:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/utility/tests/textreader.cpp:88:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/utility/tests/textwriter.cpp:69:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/utility/textreader.cpp:111:40: style:inconclusive: Function 'readLine' argument 1 names different: declaration 'line' definition 'linePtr'. [funcArgNamesDifferent] gromacs-2022-rc1/src/gromacs/utility/textreader.h:140:32: note: Function 'readLine' argument 1 names different: declaration 'line' definition 'linePtr'. gromacs-2022-rc1/src/gromacs/utility/textreader.cpp:111:40: note: Function 'readLine' argument 1 names different: declaration 'line' definition 'linePtr'. gromacs-2022-rc1/src/programs/mdrun/tests/checkpoint.cpp:105:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/programs/mdrun/tests/compressed_x_output.cpp:70:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/programs/mdrun/tests/constantacceleration.cpp:105:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/programs/mdrun/tests/densityfittingmodule.cpp:162:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/programs/mdrun/tests/dispersion_correction.cpp:67:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/programs/mdrun/tests/domain_decomposition.cpp:62:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/programs/mdrun/tests/ewaldsurfaceterm.cpp:89:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/programs/mdrun/tests/exactcontinuation.cpp:356:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/programs/mdrun/tests/freeenergy.cpp:92:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/programs/mdrun/tests/freezegroups.cpp:182:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/programs/mdrun/tests/grompp.cpp:74:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/programs/mdrun/tests/initialconstraints.cpp:75:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/programs/mdrun/tests/interactiveMD.cpp:81:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/programs/mdrun/tests/mimic.cpp:102:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/programs/mdrun/tests/minimize.cpp:98:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:159:22: warning: scanf() without field width limits can crash with huge input data. [invalidscanf] gromacs-2022-rc1/src/programs/mdrun/tests/multiple_time_stepping.cpp:83:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/programs/mdrun/tests/energycomparison.cpp:92:14: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/programs/mdrun/tests/multisim.cpp:77:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/programs/mdrun/tests/normalmodes.cpp:91:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/programs/mdrun/tests/orires.cpp:67:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/programs/mdrun/tests/outputfiles.cpp:75:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/programs/mdrun/tests/periodicactions.cpp:173:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/programs/mdrun/tests/energyreader.cpp:66:80: style:inconclusive: Function 'openEnergyFileToReadTerms' argument 2 names different: declaration 'requiredEnergyTermNames' definition 'namesOfRequiredEnergyTerms'. [funcArgNamesDifferent] gromacs-2022-rc1/src/programs/mdrun/tests/energyreader.h:92:80: note: Function 'openEnergyFileToReadTerms' argument 2 names different: declaration 'requiredEnergyTermNames' definition 'namesOfRequiredEnergyTerms'. gromacs-2022-rc1/src/programs/mdrun/tests/energyreader.cpp:66:80: note: Function 'openEnergyFileToReadTerms' argument 2 names different: declaration 'requiredEnergyTermNames' definition 'namesOfRequiredEnergyTerms'. gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:115:22: style: The scope of the variable 'yesno' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/mdrun/tests/pmetest.cpp:287:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:116:22: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/mdrun/tests/pull.cpp:182:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:457:9: style: The scope of the variable 'pbc_enum' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/mdrun/tests/replicaexchange.cpp:104:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:473:17: style: The scope of the variable 'unitcell_enum' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/mdrun/tests/replicaexchange_equivalence.cpp:127:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:485:17: style: The scope of the variable 'ecenter' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/mdrun/tests/rerun.cpp:166:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:487:9: style: The scope of the variable 'fit_enum' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/mdrun/tests/simple_mdrun.cpp:106:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:579:18: style: The scope of the variable 'file_nr' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/mdrun/tests/simulator.cpp:83:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:581:18: style: The scope of the variable 'flags' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:585:18: style: The scope of the variable 'm' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/mdrun/tests/swapcoords.cpp:73:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:585:21: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/mdrun/tests/tabulated_bonded_interactions.cpp:124:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:585:24: style: The scope of the variable 'd' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/mdrun/tests/termination.cpp:84:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:585:27: style: The scope of the variable 'frame' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:585:34: style: The scope of the variable 'outframe' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/mdrun/tests/tpitest.cpp:109:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:585:44: style: The scope of the variable 'natoms' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:585:65: style: The scope of the variable 'newstep' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:585:78: style: The scope of the variable 'model_nr' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/mdrun/tests/simulatorcomparison.cpp:91:50: style:inconclusive: Function 'compareEnergies' argument 4 names different: declaration 'maxNumFrams' definition 'maxNumFrames'. [funcArgNamesDifferent] gromacs-2022-rc1/src/programs/mdrun/tests/simulatorcomparison.h:72:50: note: Function 'compareEnergies' argument 4 names different: declaration 'maxNumFrams' definition 'maxNumFrames'. gromacs-2022-rc1/src/programs/mdrun/tests/simulatorcomparison.cpp:91:50: note: Function 'compareEnergies' argument 4 names different: declaration 'maxNumFrams' definition 'maxNumFrames'. gromacs-2022-rc1/src/programs/mdrun/tests/virtualsites.cpp:561:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:599:17: style: The scope of the variable 'ndrop' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:599:34: style: The scope of the variable 'drop0' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:599:45: style: The scope of the variable 'drop1' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:599:56: style: The scope of the variable 'dropuse' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:603:17: style: The scope of the variable 'nfitdim' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:608:17: style: The scope of the variable 'frameNumberToPrint' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:615:17: style: The scope of the variable 'out_file2' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:615:34: style: The scope of the variable 'charpt' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:618:17: style: The scope of the variable 'top_title' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:618:33: style: The scope of the variable 'timestr' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:618:46: style: The scope of the variable 'stepstr' can be reduced. [variableScope] gromacs-2022-rc1/src/gromacs/tools/trjconv.cpp:618:59: style: The scope of the variable 'filemode' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/filter.cpp:91:12: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/programs/view/dialogs.cpp:260:16: style: The scope of the variable 'nskip' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/dialogs.cpp:260:23: style: The scope of the variable 'nwait' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/dialogs.cpp:276:23: style: Variable 'bBond' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/programs/view/dialogs.cpp:281:23: style: Variable 'bBond' is assigned a value that is never used. [unreadVariable] gromacs-2022-rc1/src/programs/view/nleg.cpp:147:11: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/programs/view/nleg.cpp:69:18: style: The scope of the variable 'nb' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/buttons.cpp:89:28: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/programs/view/nleg.cpp:69:22: style: The scope of the variable 'mij' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/buttons.cpp:104:17: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/programs/view/nleg.cpp:118:27: style: The scope of the variable 'i0' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/buttons.cpp:128:12: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/programs/view/nleg.cpp:118:42: style: The scope of the variable 'y' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/buttons.cpp:208:39: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/programs/view/molps.cpp:103:11: style: The scope of the variable 'ic' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/nleg.cpp:118:45: style: The scope of the variable 'x1' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/buttons.cpp:61:16: style: The scope of the variable 'wd' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/molps.cpp:103:16: style: The scope of the variable 'jc' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/nleg.cpp:118:49: style: The scope of the variable 'x0' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/pulldown.cpp:56:11: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/programs/view/buttons.cpp:85:15: style: The scope of the variable 'bbox' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/molps.cpp:104:11: style: The scope of the variable 'xi' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/nleg.cpp:119:24: style: The scope of the variable 'cind' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/pulldown.cpp:54:20: style: The scope of the variable 'x' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/buttons.cpp:99:15: style: The scope of the variable 'vbox' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/molps.cpp:104:15: style: The scope of the variable 'yi' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/pulldown.cpp:54:23: style: The scope of the variable 'x1' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/buttons.cpp:100:15: style: The scope of the variable 'y0' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/molps.cpp:104:19: style: The scope of the variable 'xj' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/pulldown.cpp:54:30: style: The scope of the variable 'nsel' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/buttons.cpp:173:23: style: The scope of the variable 'ID' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/molps.cpp:104:23: style: The scope of the variable 'yj' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/molps.cpp:105:11: style: The scope of the variable 'xm' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/logo.cpp:110:13: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/programs/view/molps.cpp:105:15: style: The scope of the variable 'ym' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/molps.cpp:137:15: style: The scope of the variable 'obj' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/popup.cpp:58:14: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/programs/view/popup.cpp:94:10: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/programs/view/xdlghi.cpp:106:17: style: The scope of the variable 'edlg' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/xmb.cpp:67:19: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/testutils/stringtest.cpp:70:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/testutils/test_device.cpp:70:5: style: Class 'Impl' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/testutils/testasserts.cpp:74:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/testutils/testfilemanager.cpp:125:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/programs/view/x11.cpp:75:18: style: The scope of the variable 'fontlist' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/x11.cpp:299:24: style: The scope of the variable 'v_name' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/x11.cpp:301:16: style: The scope of the variable 'v_class' can be reduced. [variableScope] gromacs-2022-rc1/src/testutils/tests/interactivetest.cpp:135:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/testutils/tests/mpitest.cpp:70:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/testutils/tests/refdata_tests.cpp:96:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/testutils/tests/testasserts_tests.cpp:68:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/testutils/tests/xvgtest_tests.cpp:69:1: error: syntax error [syntaxError] gromacs-2022-rc1/src/testutils/testmatchers.cpp:133:5: style: Class 'RVecMatcher < real >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/programs/view/manager.cpp:461:21: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled] gromacs-2022-rc1/src/testutils/testmatchers.cpp:72:5: style: Class 'FloatTypeMatcher < float >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/testutils/testmatchers.cpp:72:5: style: Class 'FloatTypeMatcher < double >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/testutils/testmatchers.cpp:72:5: style: Class 'FloatTypeMatcher < real >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/programs/view/nmol.cpp:330:15: style: The scope of the variable 'ai' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/nmol.cpp:331:15: style: The scope of the variable 'bAdd' can be reduced. [variableScope] gromacs-2022-rc1/src/testutils/textblockmatchers.cpp:90:28: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm] gromacs-2022-rc1/src/programs/view/manager.cpp:88:17: style: The scope of the variable 'delta' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/nmol.cpp:382:15: style: The scope of the variable 'obj' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/manager.cpp:88:24: style: The scope of the variable 'ftype' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/nmol.cpp:433:20: style: The scope of the variable 'j' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/manager.cpp:168:19: style: The scope of the variable 'col' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/nmol.cpp:433:23: style: The scope of the variable 'k' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/manager.cpp:304:13: style: The scope of the variable 'm0' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/nmol.cpp:310:35: style: Parameter 'zz' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/programs/view/manager.cpp:304:17: style: The scope of the variable 'm1' can be reduced. [variableScope] gromacs-2022-rc1/src/testutils/refdata_xml.cpp:183:27: style:inconclusive: Function 'readEntry' argument 1 names different: declaration 'node' definition 'element'. [funcArgNamesDifferent] gromacs-2022-rc1/src/testutils/refdata_xml.cpp:94:27: note: Function 'readEntry' argument 1 names different: declaration 'node' definition 'element'. gromacs-2022-rc1/src/testutils/refdata_xml.cpp:183:27: note: Function 'readEntry' argument 1 names different: declaration 'node' definition 'element'. gromacs-2022-rc1/src/programs/view/xdlg.cpp:458:23: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/testutils/refdata_xml.cpp:361:80: style:inconclusive: Function 'writeReferenceDataFile' argument 2 names different: declaration 'root' definition 'rootEntry'. [funcArgNamesDifferent] gromacs-2022-rc1/src/testutils/refdata_xml.h:78:80: note: Function 'writeReferenceDataFile' argument 2 names different: declaration 'root' definition 'rootEntry'. gromacs-2022-rc1/src/testutils/refdata_xml.cpp:361:80: note: Function 'writeReferenceDataFile' argument 2 names different: declaration 'root' definition 'rootEntry'. gromacs-2022-rc1/src/programs/view/xdlg.cpp:216:16: style: The scope of the variable 'old_x' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/xdlg.cpp:216:23: style: The scope of the variable 'old_y' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/xdlg.cpp:330:16: style: The scope of the variable 'dlgitem' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/xdlg.cpp:459:16: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/xdlg.cpp:459:19: style: The scope of the variable 'nWndProc' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/xdlg.cpp:685:16: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/testutils/cmdlinetest.cpp:84:5: style: Class 'Impl' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/programs/view/xdlg.cpp:717:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/testutils/cmdlinetest.cpp:85:5: style: Class 'Impl' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] gromacs-2022-rc1/src/programs/view/xdlg.cpp:198:18: style: Local variable 'id' shadows outer argument [shadowArgument] gromacs-2022-rc1/src/programs/view/xdlg.cpp:160:38: note: Shadowed declaration gromacs-2022-rc1/src/programs/view/xdlg.cpp:198:18: note: Shadow variable gromacs-2022-rc1/src/programs/view/xdlg.cpp:236:18: style: Local variable 'id' shadows outer argument [shadowArgument] gromacs-2022-rc1/src/programs/view/xdlg.cpp:213:37: note: Shadowed declaration gromacs-2022-rc1/src/programs/view/xdlg.cpp:236:18: note: Shadow variable gromacs-2022-rc1/src/programs/view/xdlgitem.cpp:606:17: style: C-style pointer casting [cstyleCast] gromacs-2022-rc1/src/programs/view/xdlgitem.cpp:71:17: style: The scope of the variable 'et' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/xdlgitem.cpp:100:20: style: The scope of the variable 'c' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/xdlgitem.cpp:309:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/xdlgitem.cpp:309:12: style: The scope of the variable 'sl' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/xdlgitem.cpp:328:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/xdlgitem.cpp:345:9: style: The scope of the variable 'i' can be reduced. [variableScope] gromacs-2022-rc1/src/programs/view/xdlgitem.cpp:343:37: style: Parameter 'pos' can be declared as pointer to const [constParameter] gromacs-2022-rc1/src/testutils/simulationdatabase.cpp:65:22: style: struct member 'DatabaseEntry::validPpRankCounts' is never used. [unusedStructMember] diff: head gromacs-2022-rc1/api/gmxapi/cpp/tpr.cpp:464:21: style: Variable 'irInstance' can be declared as reference to const [constVariable] head gromacs-2022-rc1/api/nblib/listed_forces/tests/gmxcalculator.cpp:154:51: style: Parameter 'interactionElement' can be declared as reference to const [constParameter] 2.8 gromacs-2022-rc1/api/nblib/listed_forces/tests/gmxcalculator.cpp:154:51: style: Parameter 'interactionElement' can be declared with const [constParameter] head gromacs-2022-rc1/api/nblib/topology.cpp:133:15: style: Variable 'expansionArrayStage2' can be declared as reference to const [constVariable] 2.8 gromacs-2022-rc1/api/nblib/topology.cpp:133:15: style: Variable 'expansionArrayStage2' can be declared with const [constVariable] head gromacs-2022-rc1/cmake/TestFileOffsetBits.cpp:6:7: style: Variable 'off_t_is_large' can be declared as const array [constVariable] 2.8 gromacs-2022-rc1/cmake/TestFileOffsetBits.cpp:6:7: style: Variable 'off_t_is_large' can be declared with const [constVariable] head gromacs-2022-rc1/src/external/clFFT/src/library/accessors.cpp:772:50: style: Parameter 'userdata' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/clFFT/src/library/accessors.cpp:772:50: style: Parameter 'userdata' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:248:56: style: Parameter 'data' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/clFFT/src/library/fft_binary_lookup.cpp:248:56: style: Parameter 'data' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:605:19: style: Parameter 'diag' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:605:19: style: Parameter 'diag' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:974:61: style: Parameter 'ipvt' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:974:61: style: Parameter 'ipvt' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:975:19: style: Parameter 'diag' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:975:19: style: Parameter 'diag' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:975:39: style: Parameter 'qtb' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/lmfit/lmmin.cpp:975:39: style: Parameter 'qtb' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/thread_mpi/src/alltoall.cpp:173:57: style: Parameter 'sdispls' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/thread_mpi/src/alltoall.cpp:173:57: style: Parameter 'sdispls' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/thread_mpi/src/alltoall.cpp:175:57: style: Parameter 'rdispls' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/thread_mpi/src/alltoall.cpp:175:57: style: Parameter 'rdispls' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:774:61: style: Parameter 'th' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/thread_mpi/src/comm.cpp:774:61: style: Parameter 'th' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/thread_mpi/src/errhandler.cpp:160:48: style: Parameter 'function' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/thread_mpi/src/errhandler.cpp:160:48: style: Parameter 'function' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/thread_mpi/src/errhandler.cpp:212:42: style: Parameter 'comm' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/thread_mpi/src/errhandler.cpp:212:42: style: Parameter 'comm' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/thread_mpi/src/errhandler.cpp:230:39: style: Parameter 'comm' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/thread_mpi/src/errhandler.cpp:230:39: style: Parameter 'comm' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/thread_mpi/src/gather.cpp:169:55: style: Parameter 'displs' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/thread_mpi/src/gather.cpp:169:55: style: Parameter 'displs' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/thread_mpi/src/group.cpp:181:51: style: Parameter 'ranks' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/thread_mpi/src/group.cpp:181:51: style: Parameter 'ranks' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/thread_mpi/src/p2p_wait.cpp:176:58: style: Parameter 'array_of_requests' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/thread_mpi/src/p2p_wait.cpp:176:58: style: Parameter 'array_of_requests' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/thread_mpi/src/scatter.cpp:198:62: style: Parameter 'displs' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/thread_mpi/src/scatter.cpp:198:62: style: Parameter 'displs' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_init.cpp:169:21: style: Parameter 'argc' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_init.cpp:169:21: style: Parameter 'argc' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_init.cpp:418:29: style: Parameter 'argc' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/thread_mpi/src/tmpi_init.cpp:418:29: style: Parameter 'argc' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:139:41: style: Parameter 'coords' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:139:41: style: Parameter 'coords' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:216:51: style: Parameter 'dims' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:216:51: style: Parameter 'dims' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:216:62: style: Parameter 'periods' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:216:62: style: Parameter 'periods' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:259:66: style: Parameter 'dims' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:259:66: style: Parameter 'dims' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:260:33: style: Parameter 'periods' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/thread_mpi/src/topology.cpp:260:33: style: Parameter 'periods' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:1555:5: style: Class 'XMLDocument' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head gromacs-2022-rc1/src/external/tinyxml2/tinyxml2.h:2016:5: style: Class 'XMLPrinter' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head gromacs-2022-rc1/src/external/tng_io/external/zlib/inftrees.c:34:21: style: Parameter 'lens' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/external/zlib/inftrees.c:34:21: style: Parameter 'lens' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/external/zlib/trees.c:578:11: style: Parameter 'bl_count' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/external/zlib/trees.c:578:11: style: Parameter 'bl_count' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/external/zlib/zutil.c:304:12: style: Parameter 'opaque' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/external/zlib/zutil.c:304:12: style: Parameter 'opaque' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/external/zlib/zutil.c:314:12: style: Parameter 'opaque' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/external/zlib/zutil.c:314:12: style: Parameter 'opaque' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/bwt.c:25:72: style: Parameter 'vals' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/bwt.c:25:72: style: Parameter 'vals' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/bwt.c:25:92: style: Parameter 'nrepeat' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/bwt.c:25:92: style: Parameter 'nrepeat' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/bwt.c:308:40: style: Parameter 'input' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/bwt.c:308:40: style: Parameter 'input' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/dict.c:24:46: style: Parameter 'vals' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/dict.c:24:46: style: Parameter 'vals' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/huffman.c:219:47: style: Parameter 'vals' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/huffman.c:219:47: style: Parameter 'vals' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/huffman.c:220:41: style: Parameter 'dict' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/huffman.c:220:41: style: Parameter 'dict' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/huffman.c:470:43: style: Parameter 'huffman_dict_unpacked' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/huffman.c:470:43: style: Parameter 'huffman_dict_unpacked' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/lz77.c:309:41: style: Parameter 'data' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/lz77.c:309:41: style: Parameter 'data' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/lz77.c:311:35: style: Parameter 'offsets' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/lz77.c:311:35: style: Parameter 'offsets' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/mtf.c:138:53: style: Parameter 'valsmtf' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/mtf.c:138:53: style: Parameter 'valsmtf' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/mtf.c:176:43: style: Parameter 'vals' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/mtf.c:176:43: style: Parameter 'vals' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/mtf.c:177:37: style: Parameter 'dict' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/mtf.c:177:37: style: Parameter 'dict' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/mtf.c:218:45: style: Parameter 'valsmtf' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/mtf.c:218:45: style: Parameter 'valsmtf' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/mtf.c:219:39: style: Parameter 'dict' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/mtf.c:219:39: style: Parameter 'dict' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/mtf.c:62:51: style: Parameter 'vals' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/mtf.c:62:51: style: Parameter 'vals' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/mtf.c:81:52: style: Parameter 'vals' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/mtf.c:81:52: style: Parameter 'vals' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/rle.c:39:43: style: Parameter 'vals' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/rle.c:39:43: style: Parameter 'vals' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/rle.c:71:45: style: Parameter 'rle' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/rle.c:71:45: style: Parameter 'rle' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:110:42: style: Parameter 'quant' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:110:42: style: Parameter 'quant' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:150:47: style: Parameter 'quant' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:150:47: style: Parameter 'quant' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:168:53: style: Parameter 'quant' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:168:53: style: Parameter 'quant' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:1856:60: style: Parameter 'algo' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:1856:60: style: Parameter 'algo' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:185:51: style: Parameter 'quant' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:185:51: style: Parameter 'quant' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:1866:52: style: Parameter 'algo' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:1866:52: style: Parameter 'algo' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:1876:60: style: Parameter 'algo' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:1876:60: style: Parameter 'algo' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:1886:52: style: Parameter 'algo' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:1886:52: style: Parameter 'algo' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:226:47: style: Parameter 'quant' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:226:47: style: Parameter 'quant' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:247:53: style: Parameter 'quant' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:247:53: style: Parameter 'quant' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:264:51: style: Parameter 'quant' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:264:51: style: Parameter 'quant' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:294:43: style: Parameter 'buf' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:294:43: style: Parameter 'buf' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:31:38: style: Parameter 'x' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:31:38: style: Parameter 'x' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:51:43: style: Parameter 'x' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:51:43: style: Parameter 'x' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:95:42: style: Parameter 'quant' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/tng_compress.c:95:42: style: Parameter 'quant' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/vals16.c:16:46: style: Parameter 'vals' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/vals16.c:16:46: style: Parameter 'vals' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/vals16.c:48:48: style: Parameter 'vals16' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/vals16.c:48:48: style: Parameter 'vals16' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/xtc2.c:355:28: style: Parameter 'in' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/xtc2.c:355:28: style: Parameter 'in' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/xtc2.c:362:33: style: Parameter 'input' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/xtc2.c:362:33: style: Parameter 'input' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/xtc2.c:362:45: style: Parameter 'minint' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/xtc2.c:362:45: style: Parameter 'minint' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/xtc2.c:594:31: style: Parameter 'input_ptr' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/xtc2.c:594:31: style: Parameter 'input_ptr' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/xtc2.c:594:88: style: Parameter 'minint' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/xtc2.c:594:88: style: Parameter 'minint' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/xtc2.c:685:89: style: Parameter 'new_large_ints' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/xtc2.c:685:89: style: Parameter 'new_large_ints' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/xtc3.c:1702:35: style: Parameter 'minint' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/xtc3.c:1702:35: style: Parameter 'minint' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/xtc3.c:462:44: style: Parameter 'ints' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/xtc3.c:462:44: style: Parameter 'ints' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/xtc3.c:473:66: style: Parameter 'input' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/xtc3.c:473:66: style: Parameter 'input' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/compression/xtc3.c:798:42: style: Parameter 'ints' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/compression/xtc3.c:798:42: style: Parameter 'ints' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/tests/compression/testsuite.c:213:26: style: Parameter 'intbox' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/tests/compression/testsuite.c:213:26: style: Parameter 'intbox' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/tests/compression/testsuite.c:225:29: style: Parameter 'intbox' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/tests/compression/testsuite.c:225:29: style: Parameter 'intbox' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/tests/compression/testsuite.c:237:27: style: Parameter 'arr1' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/tests/compression/testsuite.c:237:27: style: Parameter 'arr1' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/tests/compression/testsuite.c:237:39: style: Parameter 'arr2' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/tests/compression/testsuite.c:237:39: style: Parameter 'arr2' can be declared with const [constParameter] head gromacs-2022-rc1/src/external/tng_io/src/tests/compression/testsuite.c:80:27: style: Parameter 'base' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/external/tng_io/src/tests/compression/testsuite.c:80:27: style: Parameter 'base' can be declared with const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/analysisdata/datastorage.cpp:854:45: style: Variable 'storedFrame' can be declared with const [constVariable] head gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:1099:15: style: Variable 'globalIndex' can be declared as reference to const [constVariable] head gromacs-2022-rc1/src/gromacs/applied_forces/awh/biasstate.cpp:669:16: style: Variable 'pointIndex' can be declared as reference to const [constVariable] head gromacs-2022-rc1/src/gromacs/applied_forces/awh/biaswriter.cpp:230:25: style: Variable 'point' can be declared as reference to const [constVariable] head gromacs-2022-rc1/src/gromacs/correlationfunctions/autocorr.cpp:727:46: style: Parameter 'pa' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/correlationfunctions/autocorr.cpp:727:46: style: Parameter 'pa' can be declared with const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/domdec/redistribute.cpp:625:29: style: The scope of the variable 'pbcAndFlags' can be reduced. [variableScope] head gromacs-2022-rc1/src/gromacs/ewald/pme_spread.cpp:271:38: style: Parameter 'fractx' can be declared as const array [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/ewald/pme_spread.cpp:271:38: style: Parameter 'fractx' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:164:45: style: Parameter 'comm' can be declared as const array [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/fft/fft5d.cpp:164:45: style: Parameter 'comm' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:1176:18: style: Variable 'ind0' can be declared as const array [constVariable] 2.8 gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:1176:18: style: Variable 'ind0' can be declared with const [constVariable] head gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:1177:18: style: Variable 'ind1' can be declared as const array [constVariable] 2.8 gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:1177:18: style: Variable 'ind1' can be declared with const [constVariable] 2.8 gromacs-2022-rc1/src/gromacs/fileio/enxio.cpp:297:72: style: Parameter 'prev' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:324:39: style: Parameter 'eignr1' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:324:39: style: Parameter 'eignr1' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:425:45: style: Parameter 'eignr2' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:425:45: style: Parameter 'eignr2' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:428:45: style: Parameter 'outvec' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:428:45: style: Parameter 'outvec' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:490:45: style: Parameter 'eignr' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:490:45: style: Parameter 'eignr' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:493:45: style: Parameter 'outvec' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:493:45: style: Parameter 'outvec' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:890:48: style: Parameter 'eignr' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:890:48: style: Parameter 'eignr' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:950:42: style: Parameter 'eignr' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/gmxana/gmx_anaeig.cpp:950:42: style: Parameter 'eignr' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:742:88: style: Parameter 'r' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/gmxana/gmx_bar.cpp:742:88: style: Parameter 'r' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/gmxana/gmx_bundle.cpp:159:56: style: Parameter 'fr' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/gmxana/gmx_bundle.cpp:159:56: style: Parameter 'fr' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/gmxana/gmx_cluster.cpp:427:54: style: Parameter 'frameindices' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/gmxana/gmx_cluster.cpp:427:54: style: Parameter 'frameindices' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/gmxana/gmx_dipoles.cpp:1052:18: style: Condition 'bCont' is always true [knownConditionTrueFalse] head gromacs-2022-rc1/src/gromacs/gmxana/gmx_dyecoupl.cpp:202:29: warning: Operator '|' with one operand equal to zero is redundant. [badBitmaskCheck] head gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2279:67: style: Parameter 'hb' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2279:67: style: Parameter 'hb' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2642:17: style: Variable 'hbmap' can be declared as const array [constVariable] 2.8 gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2642:17: style: Variable 'hbmap' can be declared with const [constVariable] head gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2644:17: style: Variable 'hbrgb' can be declared as const array [constVariable] 2.8 gromacs-2022-rc1/src/gromacs/gmxana/gmx_hbond.cpp:2644:17: style: Variable 'hbrgb' can be declared with const [constVariable] head gromacs-2022-rc1/src/gromacs/gmxana/gmx_mindist.cpp:751:48: style: Parameter 'resindex' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/gmxana/gmx_mindist.cpp:751:48: style: Parameter 'resindex' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmr.cpp:271:73: style: Parameter 'bounds' can be declared as const array [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/gmxana/gmx_nmr.cpp:271:73: style: Parameter 'bounds' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsdist.cpp:520:65: style: Parameter 'noe_gr' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/gmxana/gmx_rmsdist.cpp:520:65: style: Parameter 'noe_gr' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/gmxana/gmx_traj.cpp:229:49: style: Parameter 'index' can be declared as const array [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/gmxana/gmx_traj.cpp:229:49: style: Parameter 'index' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/gmxana/gmx_traj.cpp:848:23: warning: Operator '|' with one operand equal to zero is redundant. [badBitmaskCheck] head gromacs-2022-rc1/src/gromacs/gmxana/gmx_xpm2ps.cpp:1360:16: style: Variable 'm' can be declared as reference to const [constVariable] head gromacs-2022-rc1/src/gromacs/gmxana/gmx_xpm2ps.cpp:1412:16: style: Variable 'm' can be declared as reference to const [constVariable] head gromacs-2022-rc1/src/gromacs/gmxana/gmx_xpm2ps.cpp:751:10: style: Variable 'major_fact' can be declared as const array [constVariable] 2.8 gromacs-2022-rc1/src/gromacs/gmxana/gmx_xpm2ps.cpp:751:10: style: Variable 'major_fact' can be declared with const [constVariable] head gromacs-2022-rc1/src/gromacs/gmxana/gmx_xpm2ps.cpp:752:10: style: Variable 'minor_fact' can be declared as const array [constVariable] 2.8 gromacs-2022-rc1/src/gromacs/gmxana/gmx_xpm2ps.cpp:752:10: style: Variable 'minor_fact' can be declared with const [constVariable] head gromacs-2022-rc1/src/gromacs/gmxpreprocess/editconf.cpp:384:11: style: Variable 'rectedge' can be declared as const array [constVariable] 2.8 gromacs-2022-rc1/src/gromacs/gmxpreprocess/editconf.cpp:384:11: style: Variable 'rectedge' can be declared with const [constVariable] head gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:2053:26: style: Variable 'Hat_vsite_type' can be declared as const array [constVariable] 2.8 gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:2053:26: style: Variable 'Hat_vsite_type' can be declared with const [constVariable] head gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:564:27: style: Parameter 'o2n' can be declared as const array [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/gmxpreprocess/gen_vsite.cpp:564:27: style: Parameter 'o2n' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/gmxpreprocess/gmxcpp.cpp:216:69: style: Parameter 'definesFromParent' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/gmxpreprocess/gmxcpp.cpp:216:69: style: Parameter 'definesFromParent' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/gmxpreprocess/gmxcpp.cpp:217:69: style: Parameter 'includesFromParent' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/gmxpreprocess/gmxcpp.cpp:217:69: style: Parameter 'includesFromParent' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/gpu_utils/devicebuffer_sycl.h:251:70: style: Parameter 'buffer' can be declared as reference to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/gpu_utils/devicebuffer_sycl.h:251:70: style: Parameter 'buffer' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/gpu_utils/hostallocator.h:142:5: style: Class 'HostAllocationPolicy' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head gromacs-2022-rc1/src/gromacs/hardware/cpuinfo.cpp:128:58: style: Parameter 'c' can be declared as reference to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/hardware/cpuinfo.cpp:128:58: style: Parameter 'c' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/hardware/cpuinfo.cpp:131:59: style: Parameter 'c' can be declared as reference to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/hardware/cpuinfo.cpp:131:59: style: Parameter 'c' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/hardware/cpuinfo.cpp:554:37: style: Parameter 'c' can be declared as reference to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/hardware/cpuinfo.cpp:554:37: style: Parameter 'c' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/hardware/device_management_common.cpp:134:50: style: Parameter 'deviceInfo' can be declared as reference to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/hardware/device_management_common.cpp:134:50: style: Parameter 'deviceInfo' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/imd/imdsocket.cpp:346:34: style: Parameter 'sock' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/imd/imdsocket.cpp:346:34: style: Parameter 'sock' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/linearalgebra/matrix.cpp:190:53: style: Parameter 'y' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/linearalgebra/matrix.cpp:190:53: style: Parameter 'y' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/linearalgebra/nrjac.cpp:192:21: style: Parameter 'm' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/linearalgebra/nrjac.cpp:192:21: style: Parameter 'm' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/linearalgebra/sparsematrix.cpp:247:68: style: Parameter 'x' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/linearalgebra/sparsematrix.cpp:247:68: style: Parameter 'x' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:1714:53: error: Array index -1 is out of bounds. [negativeContainerIndex] gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:1719:30: note: Assignment 'b=-1', assigned value is -1 gromacs-2022-rc1/src/gromacs/mdlib/lincs.cpp:1714:53: note: Negative array index head gromacs-2022-rc1/src/gromacs/mdlib/simulationsignal.h:96:5: style: Class 'SimulationSignal' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] head gromacs-2022-rc1/src/gromacs/mdrun/replicaexchange.cpp:625:60: style: Parameter 'dest' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/mdrun/replicaexchange.cpp:625:60: style: Parameter 'dest' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/mdtypes/iforceprovider.h:119:26: style: Parameter 'ptr' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/mdtypes/iforceprovider.h:119:26: style: Parameter 'ptr' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/modularsimulator/energydata.cpp:188:24: style: Condition 'isMasterRank_' is always true [knownConditionTrueFalse] gromacs-2022-rc1/src/gromacs/modularsimulator/energydata.cpp:177:9: note: Assuming that condition '!isMasterRank_' is not redundant gromacs-2022-rc1/src/gromacs/modularsimulator/energydata.cpp:188:24: note: Condition 'isMasterRank_' is always true head gromacs-2022-rc1/src/gromacs/modularsimulator/signallers.h:497:16: style: Variable 'client' can be declared as reference to const [constVariable] head gromacs-2022-rc1/src/gromacs/modularsimulator/trajectoryelement.cpp:149:20: style: Variable 'callback' can be declared as reference to const [constVariable] head gromacs-2022-rc1/src/gromacs/modularsimulator/trajectoryelement.cpp:156:20: style: Variable 'callback' can be declared as reference to const [constVariable] head gromacs-2022-rc1/src/gromacs/options/optionsvisitor.cpp:60:55: style: Parameter 'optionInfo' can be declared as reference to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/options/optionsvisitor.cpp:60:55: style: Parameter 'optionInfo' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/pbcutil/pbc.cpp:329:17: style: Variable 'order' can be declared as const array [constVariable] 2.8 gromacs-2022-rc1/src/gromacs/pbcutil/pbc.cpp:329:17: style: Variable 'order' can be declared with const [constVariable] head gromacs-2022-rc1/src/gromacs/pulling/pullutil.cpp:320:35: style: Variable 'group1' can be declared as reference to const [constVariable] 2.8 gromacs-2022-rc1/src/gromacs/selection/params.cpp:210:60: style: Parameter 'param' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/topology/atomprop.cpp:325:12: style: Variable 'def' can be declared as const array [constVariable] 2.8 gromacs-2022-rc1/src/gromacs/topology/atomprop.cpp:325:12: style: Variable 'def' can be declared with const [constVariable] head gromacs-2022-rc1/src/gromacs/topology/index.cpp:687:48: style: Parameter 'index' can be declared as const array [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/topology/index.cpp:687:48: style: Parameter 'index' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/topology/mtop_util.cpp:1016:35: style: Parameter 'symtab' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/gromacs/topology/mtop_util.cpp:1016:35: style: Parameter 'symtab' can be declared with const [constParameter] head gromacs-2022-rc1/src/gromacs/utility/fatalerror.cpp:131:19: style: Variable 'map' can be declared as const array [constVariable] head gromacs-2022-rc1/src/programs/view/nmol.cpp:310:35: style: Parameter 'zz' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/programs/view/nmol.cpp:310:35: style: Parameter 'zz' can be declared with const [constParameter] head gromacs-2022-rc1/src/programs/view/xdlgitem.cpp:343:37: style: Parameter 'pos' can be declared as pointer to const [constParameter] 2.8 gromacs-2022-rc1/src/programs/view/xdlgitem.cpp:343:37: style: Parameter 'pos' can be declared with const [constParameter] head parser.cpp:1554:88: style: Parameter 'yypushed_loc' can be declared as pointer to const [constParameter] 2.8 parser.cpp:1554:88: style: Parameter 'yypushed_loc' can be declared with const [constParameter] head parser.cpp:994:55: style: Parameter 'yytop' can be declared as pointer to const [constParameter] 2.8 parser.cpp:994:55: style: Parameter 'yytop' can be declared with const [constParameter] DONE