2022-06-22 08:04 ftp://ftp.de.debian.org/debian/pool/main/g/golly/golly_3.3.orig.tar.gz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp -j2 platform: Linux-5.4.0-110-generic-x86_64-with-glibc2.29 python: 3.8.10 client-version: 1.3.24 compiler: g++ (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0 cppcheck: head 2.8 head-info: 650f409 (2022-06-22 08:46:48 +0200) count: 1077 1076 elapsed-time: 42.8 54.8 head-timing-info: Overall time: 0s old-timing-info: Overall time: 0s head results: golly-3.3-src/Rules/TreeGenerators/LifeOnTheEdge.cpp:54:4: portability: %d in format string (no. 1) requires 'int' but the argument type is 'std::size_t {aka unsigned long}'. [invalidPrintfArgType_sint] golly-3.3-src/Rules/TreeGenerators/LifeOnTheEdge.cpp:18:12: style: Parameter 'a' can be declared as pointer to const [constParameter] golly-3.3-src/Rules/TableGenerators/make-ruletable.cpp:552:14: style: The scope of the variable 'ne' can be reduced. [variableScope] golly-3.3-src/Rules/TableGenerators/make-ruletable.cpp:552:17: style: The scope of the variable 'nw' can be reduced. [variableScope] golly-3.3-src/Rules/TableGenerators/make-ruletable.cpp:552:20: style: The scope of the variable 'sw' can be reduced. [variableScope] golly-3.3-src/Rules/TableGenerators/make-ruletable.cpp:552:25: style: The scope of the variable 'se' can be reduced. [variableScope] golly-3.3-src/Rules/TableGenerators/make-ruletable.cpp:277:61: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/Rules/TableGenerators/make-ruletable.cpp:278:64: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/Rules/TableGenerators/make-ruletable.cpp:279:69: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/Rules/TableGenerators/make-ruletable.cpp:280:70: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/Rules/TableGenerators/make-ruletable.cpp:281:75: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/Rules/TableGenerators/make-ruletable.cpp:282:76: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/Rules/TableGenerators/make-ruletable.cpp:283:81: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/Rules/TableGenerators/make-ruletable.cpp:284:82: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/Rules/TableGenerators/make-ruletable.cpp:285:87: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/Rules/TableGenerators/make-ruletable.cpp:291:61: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/Rules/TableGenerators/make-ruletable.cpp:292:64: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/Rules/TableGenerators/make-ruletable.cpp:293:67: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/Rules/TableGenerators/make-ruletable.cpp:294:70: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/Rules/TableGenerators/make-ruletable.cpp:295:73: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/Rules/TableGenerators/make-ruletable.cpp:325:74: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/Rules/TableGenerators/make-ruletable.cpp:336:93: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/Rules/TableGenerators/make-ruletable.cpp:357:19: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/Rules/TableGenerators/make-ruletable.cpp:453:82: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/Rules/TableGenerators/make-ruletable.cpp:509:70: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/Rules/TableGenerators/make-ruletable.cpp:543:70: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/Rules/TreeGenerators/LifeOnTheSlope.cpp:60:4: portability: %d in format string (no. 1) requires 'int' but the argument type is 'std::size_t {aka unsigned long}'. [invalidPrintfArgType_sint] golly-3.3-src/Rules/TreeGenerators/LifeOnTheSlope.cpp:17:12: style: Parameter 'a' can be declared as pointer to const [constParameter] golly-3.3-src/Rules/TreeGenerators/RuleTreeGen.cpp:50:4: portability: %d in format string (no. 1) requires 'int' but the argument type is 'std::size_t {aka unsigned long}'. [invalidPrintfArgType_sint] golly-3.3-src/Rules/TreeGenerators/RuleTreeGen.cpp:14:12: style: Parameter 'a' can be declared as pointer to const [constParameter] golly-3.3-src/cmdline/RuleTableToTree.cpp:179:15: warning: Redundant assignment of 'n_states' to itself. [selfAssignment] golly-3.3-src/cmdline/bgolly.cpp:219:4: warning: Member variable 'cmdbase::iargs' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/cmdline/bgolly.cpp:219:4: warning: Member variable 'cmdbase::sarg' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/cmdline/bgolly.cpp:318:17: style: The function 'doit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/cmdline/bgolly.cpp:230:17: note: Virtual function in base class golly-3.3-src/cmdline/bgolly.cpp:318:17: note: Function in derived class golly-3.3-src/cmdline/bgolly.cpp:326:17: style: The function 'doit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/cmdline/bgolly.cpp:230:17: note: Virtual function in base class golly-3.3-src/cmdline/bgolly.cpp:326:17: note: Function in derived class golly-3.3-src/cmdline/bgolly.cpp:344:17: style: The function 'doit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/cmdline/bgolly.cpp:230:17: note: Virtual function in base class golly-3.3-src/cmdline/bgolly.cpp:344:17: note: Function in derived class golly-3.3-src/cmdline/bgolly.cpp:351:17: style: The function 'doit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/cmdline/bgolly.cpp:230:17: note: Virtual function in base class golly-3.3-src/cmdline/bgolly.cpp:351:17: note: Function in derived class golly-3.3-src/cmdline/bgolly.cpp:358:17: style: The function 'doit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/cmdline/bgolly.cpp:230:17: note: Virtual function in base class golly-3.3-src/cmdline/bgolly.cpp:358:17: note: Function in derived class golly-3.3-src/cmdline/bgolly.cpp:364:17: style: The function 'doit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/cmdline/bgolly.cpp:230:17: note: Virtual function in base class golly-3.3-src/cmdline/bgolly.cpp:364:17: note: Function in derived class golly-3.3-src/cmdline/bgolly.cpp:370:17: style: The function 'doit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/cmdline/bgolly.cpp:230:17: note: Virtual function in base class golly-3.3-src/cmdline/bgolly.cpp:370:17: note: Function in derived class golly-3.3-src/cmdline/bgolly.cpp:377:17: style: The function 'doit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/cmdline/bgolly.cpp:230:17: note: Virtual function in base class golly-3.3-src/cmdline/bgolly.cpp:377:17: note: Function in derived class golly-3.3-src/cmdline/bgolly.cpp:384:17: style: The function 'doit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/cmdline/bgolly.cpp:230:17: note: Virtual function in base class golly-3.3-src/cmdline/bgolly.cpp:384:17: note: Function in derived class golly-3.3-src/cmdline/bgolly.cpp:393:17: style: The function 'nextloopinner' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/cmdline/bgolly.cpp:255:17: note: Virtual function in base class golly-3.3-src/cmdline/bgolly.cpp:393:17: note: Function in derived class golly-3.3-src/cmdline/bgolly.cpp:396:17: style: The function 'doit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/cmdline/bgolly.cpp:230:17: note: Virtual function in base class golly-3.3-src/cmdline/bgolly.cpp:396:17: note: Function in derived class golly-3.3-src/cmdline/bgolly.cpp:404:17: style: The function 'nextloopinner' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/cmdline/bgolly.cpp:255:17: note: Virtual function in base class golly-3.3-src/cmdline/bgolly.cpp:404:17: note: Function in derived class golly-3.3-src/cmdline/bgolly.cpp:408:17: style: The function 'doit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/cmdline/bgolly.cpp:230:17: note: Virtual function in base class golly-3.3-src/cmdline/bgolly.cpp:408:17: note: Function in derived class golly-3.3-src/cmdline/bgolly.cpp:417:17: style: The function 'doit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/cmdline/bgolly.cpp:230:17: note: Virtual function in base class golly-3.3-src/cmdline/bgolly.cpp:417:17: note: Function in derived class golly-3.3-src/cmdline/bgolly.cpp:425:17: style: The function 'doit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/cmdline/bgolly.cpp:230:17: note: Virtual function in base class golly-3.3-src/cmdline/bgolly.cpp:425:17: note: Function in derived class golly-3.3-src/cmdline/bgolly.cpp:456:17: style: The function 'doit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/cmdline/bgolly.cpp:230:17: note: Virtual function in base class golly-3.3-src/cmdline/bgolly.cpp:456:17: note: Function in derived class golly-3.3-src/cmdline/bgolly.cpp:464:17: style: The function 'doit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/cmdline/bgolly.cpp:230:17: note: Virtual function in base class golly-3.3-src/cmdline/bgolly.cpp:464:17: note: Function in derived class golly-3.3-src/cmdline/bgolly.cpp:470:17: style: The function 'doit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/cmdline/bgolly.cpp:230:17: note: Virtual function in base class golly-3.3-src/cmdline/bgolly.cpp:470:17: note: Function in derived class golly-3.3-src/cmdline/bgolly.cpp:476:17: style: The function 'doit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/cmdline/bgolly.cpp:230:17: note: Virtual function in base class golly-3.3-src/cmdline/bgolly.cpp:476:17: note: Function in derived class golly-3.3-src/cmdline/bgolly.cpp:482:17: style: The function 'doit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/cmdline/bgolly.cpp:230:17: note: Virtual function in base class golly-3.3-src/cmdline/bgolly.cpp:482:17: note: Function in derived class golly-3.3-src/cmdline/bgolly.cpp:293:26: style:inconclusive: Redundant condition: If 'EXPR > ' '', the comparison 'EXPR' is always true. [redundantCondition] golly-3.3-src/cmdline/bgolly.cpp:284:16: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf] golly-3.3-src/cmdline/bgolly.cpp:434:19: style: C-style pointer casting [cstyleCast] golly-3.3-src/cmdline/bgolly.cpp:436:19: style: C-style pointer casting [cstyleCast] golly-3.3-src/cmdline/bgolly.cpp:440:19: style: C-style pointer casting [cstyleCast] golly-3.3-src/cmdline/bgolly.cpp:539:15: style: C-style pointer casting [cstyleCast] golly-3.3-src/cmdline/bgolly.cpp:546:15: style: C-style pointer casting [cstyleCast] golly-3.3-src/cmdline/bgolly.cpp:551:16: style: C-style pointer casting [cstyleCast] golly-3.3-src/cmdline/bgolly.cpp:556:15: style: C-style pointer casting [cstyleCast] golly-3.3-src/cmdline/bgolly.cpp:447:14: style: Local variable 'imp' shadows outer variable [shadowVariable] golly-3.3-src/cmdline/bgolly.cpp:36:11: note: Shadowed declaration golly-3.3-src/cmdline/bgolly.cpp:447:14: note: Shadow variable golly-3.3-src/gollybase/bigint.h:124:8: style:inconclusive: Technically the member function 'bigint::mod_smallint' can be const. [functionConst] golly-3.3-src/gollybase/bigint.cpp:415:13: note: Technically the member function 'bigint::mod_smallint' can be const. golly-3.3-src/gollybase/bigint.h:124:8: note: Technically the member function 'bigint::mod_smallint' can be const. golly-3.3-src/gollybase/bigint.h:155:9: performance:inconclusive: Technically the member function 'bigint::ensurework' can be static (but you may consider moving to unnamed namespace). [functionStatic] golly-3.3-src/gollybase/bigint.cpp:352:14: note: Technically the member function 'bigint::ensurework' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gollybase/bigint.h:155:9: note: Technically the member function 'bigint::ensurework' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gollybase/util.h:96:11: performance:inconclusive: Technically the member function 'hperf::getReportInterval' can be static (but you may consider moving to unnamed namespace). [functionStatic] golly-3.3-src/gollybase/util.h:99:9: performance:inconclusive: Technically the member function 'hperf::setReportInterval' can be static (but you may consider moving to unnamed namespace). [functionStatic] golly-3.3-src/gollybase/bigint.h:93:4: style: Class 'bigint' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] golly-3.3-src/gollybase/bigint.h:94:4: style: Class 'bigint' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] golly-3.3-src/gollybase/bigint.h:95:4: style: Class 'bigint' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] golly-3.3-src/gollybase/bigint.h:96:4: style: Class 'bigint' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] golly-3.3-src/gollybase/util.h:26:4: style: Class 'linereader' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] golly-3.3-src/gollybase/bigint.cpp:493:8: style: The scope of the variable 'carry' can be reduced. [variableScope] golly-3.3-src/gollybase/bigint.cpp:644:10: style: The scope of the variable 'k_1_10000' can be reduced. [variableScope] golly-3.3-src/gollybase/bigint.cpp:348:16: portability: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS] golly-3.3-src/gollybase/bigint.cpp:104:41: style:inconclusive: Function 'operator=' argument 1 names different: declaration 'a' definition 'b'. [funcArgNamesDifferent] golly-3.3-src/gollybase/bigint.h:101:36: note: Function 'operator=' argument 1 names different: declaration 'a' definition 'b'. golly-3.3-src/gollybase/bigint.cpp:104:41: note: Function 'operator=' argument 1 names different: declaration 'a' definition 'b'. golly-3.3-src/gollybase/bigint.cpp:729:30: style:inconclusive: Function 'tochararr' argument 1 names different: declaration 'ar' definition 'fillme'. [funcArgNamesDifferent] golly-3.3-src/gollybase/bigint.h:140:25: note: Function 'tochararr' argument 1 names different: declaration 'ar' definition 'fillme'. golly-3.3-src/gollybase/bigint.cpp:729:30: note: Function 'tochararr' argument 1 names different: declaration 'ar' definition 'fillme'. golly-3.3-src/gollybase/bigint.cpp:729:42: style:inconclusive: Function 'tochararr' argument 2 names different: declaration 'siz' definition 'n'. [funcArgNamesDifferent] golly-3.3-src/gollybase/bigint.h:140:33: note: Function 'tochararr' argument 2 names different: declaration 'siz' definition 'n'. golly-3.3-src/gollybase/bigint.cpp:729:42: note: Function 'tochararr' argument 2 names different: declaration 'siz' definition 'n'. golly-3.3-src/gollybase/bigint.cpp:160:24: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] golly-3.3-src/gollybase/bigint.cpp:274:32: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] golly-3.3-src/gollybase/bigint.cpp:287:19: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] golly-3.3-src/gollybase/bigint.cpp:300:25: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] golly-3.3-src/gollybase/bigint.cpp:313:18: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] golly-3.3-src/gollybase/bigint.cpp:328:18: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] golly-3.3-src/gollybase/bigint.cpp:394:25: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] golly-3.3-src/gollybase/bigint.cpp:444:22: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] golly-3.3-src/gollybase/bigint.cpp:446:22: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. See condition at line 443. [shiftTooManyBitsSigned] golly-3.3-src/gollybase/bigint.cpp:443:13: note: Assuming that condition 'i>31' is not redundant golly-3.3-src/gollybase/bigint.cpp:446:22: note: Shift golly-3.3-src/gollybase/bigint.cpp:476:26: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] golly-3.3-src/gollybase/bigint.cpp:692:24: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] golly-3.3-src/gollybase/bigint.cpp:712:19: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] golly-3.3-src/gollybase/bigint.cpp:711:22: note: Assuming that condition 'i<32' is not redundant golly-3.3-src/gollybase/bigint.cpp:712:19: note: Shift golly-3.3-src/gollybase/bigint.cpp:721:19: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] golly-3.3-src/gollybase/bigint.cpp:720:19: note: Assuming that condition 'i<32' is not redundant golly-3.3-src/gollybase/bigint.cpp:721:19: note: Shift golly-3.3-src/gollybase/bigint.cpp:737:21: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] golly-3.3-src/gollybase/bigint.cpp:309:11: style: Variable 'tsz' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gollybase/bigint.cpp:324:11: style: Variable 'tsz' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gollybase/bigint.cpp:369:12: style: Variable 'c' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gollybase/lifealgo.h:38:4: warning: Member variable 'timeline_t::base' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/lifealgo.h:38:4: warning: Member variable 'timeline_t::expo' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/lifealgo.h:47:4: warning: Member variable 'lifealgo::boundedplane' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/lifealgo.h:47:4: warning: Member variable 'lifealgo::sphere' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/lifealgo.h:47:4: warning: Member variable 'lifealgo::htwist' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/lifealgo.h:47:4: warning: Member variable 'lifealgo::vtwist' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/lifealgo.h:47:4: warning: Member variable 'lifealgo::hshift' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/lifealgo.h:47:4: warning: Member variable 'lifealgo::vshift' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/lifealgo.h:47:4: warning: Member variable 'lifealgo::maxCellStates' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/generationsalgo.cpp:76:18: warning: Member variable 'generationsalgo::rule3x3' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/liferender.h:29:8: style:inconclusive: Technically the member function 'liferender::justState' can be const. [functionConst] golly-3.3-src/gollybase/lifepoll.h:30:8: style:inconclusive: Technically the member function 'lifepoll::isInterrupted' can be const. [functionConst] golly-3.3-src/gollybase/lifepoll.h:72:8: style:inconclusive: Technically the member function 'lifepoll::isCalculating' can be const. [functionConst] golly-3.3-src/gollybase/lifealgo.h:64:18: style:inconclusive: Technically the member function 'lifealgo::getIncrement' can be const. [functionConst] golly-3.3-src/gollybase/lifealgo.h:65:18: style:inconclusive: Technically the member function 'lifealgo::getGeneration' can be const. [functionConst] golly-3.3-src/gollybase/lifealgo.h:103:18: style:inconclusive: Technically the member function 'lifealgo::gettimelinestart' can be const. [functionConst] golly-3.3-src/gollybase/lifealgo.h:104:18: style:inconclusive: Technically the member function 'lifealgo::gettimelineend' can be const. [functionConst] golly-3.3-src/gollybase/lifealgo.h:105:18: style:inconclusive: Technically the member function 'lifealgo::gettimelineinc' can be const. [functionConst] golly-3.3-src/gollybase/lifealgo.h:106:8: style:inconclusive: Technically the member function 'lifealgo::getframecount' can be const. [functionConst] golly-3.3-src/gollybase/lifealgo.h:107:8: style:inconclusive: Technically the member function 'lifealgo::isrecording' can be const. [functionConst] golly-3.3-src/gollybase/ghashbase.h:49:9: performance:inconclusive: Technically the member function 'ghsetup_t::prefetch' can be static (but you may consider moving to unnamed namespace). [functionStatic] golly-3.3-src/gollybase/generationsalgo.h:51:8: performance:inconclusive: Technically the member function 'generationsalgo::flipBits' can be static (but you may consider moving to unnamed namespace). [functionStatic] golly-3.3-src/gollybase/generationsalgo.cpp:224:22: note: Technically the member function 'generationsalgo::flipBits' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gollybase/generationsalgo.h:51:8: note: Technically the member function 'generationsalgo::flipBits' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gollybase/generationsalgo.h:52:8: performance:inconclusive: Technically the member function 'generationsalgo::rotateBits90Clockwise' can be static (but you may consider moving to unnamed namespace). [functionStatic] golly-3.3-src/gollybase/generationsalgo.cpp:229:22: note: Technically the member function 'generationsalgo::rotateBits90Clockwise' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gollybase/generationsalgo.h:52:8: note: Technically the member function 'generationsalgo::rotateBits90Clockwise' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gollybase/generationsalgo.h:60:9: performance:inconclusive: Technically the member function 'generationsalgo::removeChar' can be static (but you may consider moving to unnamed namespace). [functionStatic] golly-3.3-src/gollybase/generationsalgo.cpp:672:23: note: Technically the member function 'generationsalgo::removeChar' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gollybase/generationsalgo.h:60:9: note: Technically the member function 'generationsalgo::removeChar' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gollybase/liferender.h:28:4: style: Class 'liferender' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] golly-3.3-src/gollybase/liferender.h:57:17: style: The function 'stateblit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/liferender.h:49:17: note: Virtual function in base class golly-3.3-src/gollybase/liferender.h:57:17: note: Function in derived class golly-3.3-src/gollybase/ghashbase.h:69:17: style: The function 'clearall' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:53:17: note: Virtual function in base class golly-3.3-src/gollybase/ghashbase.h:69:17: note: Function in derived class golly-3.3-src/gollybase/ghashbase.h:70:16: style: The function 'setcell' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:55:16: note: Virtual function in base class golly-3.3-src/gollybase/ghashbase.h:70:16: note: Function in derived class golly-3.3-src/gollybase/ghashbase.h:71:16: style: The function 'getcell' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:56:16: note: Virtual function in base class golly-3.3-src/gollybase/ghashbase.h:71:16: note: Function in derived class golly-3.3-src/gollybase/ghashbase.h:72:16: style: The function 'nextcell' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:57:16: note: Virtual function in base class golly-3.3-src/gollybase/ghashbase.h:72:16: note: Function in derived class golly-3.3-src/gollybase/ghashbase.h:73:17: style: The function 'endofpattern' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:60:17: note: Virtual function in base class golly-3.3-src/gollybase/ghashbase.h:73:17: note: Function in derived class golly-3.3-src/gollybase/ghashbase.h:74:17: style: The function 'setIncrement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:61:17: note: Virtual function in base class golly-3.3-src/gollybase/ghashbase.h:74:17: note: Function in derived class golly-3.3-src/gollybase/ghashbase.h:75:17: style: The function 'setIncrement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:62:17: note: Virtual function in base class golly-3.3-src/gollybase/ghashbase.h:75:17: note: Function in derived class golly-3.3-src/gollybase/ghashbase.h:76:17: style: The function 'setGeneration' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:63:17: note: Virtual function in base class golly-3.3-src/gollybase/ghashbase.h:76:17: note: Function in derived class golly-3.3-src/gollybase/ghashbase.h:77:26: style: The function 'getPopulation' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:66:26: note: Virtual function in base class golly-3.3-src/gollybase/ghashbase.h:77:26: note: Function in derived class golly-3.3-src/gollybase/ghashbase.h:78:16: style: The function 'isEmpty' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:67:16: note: Virtual function in base class golly-3.3-src/gollybase/ghashbase.h:78:16: note: Function in derived class golly-3.3-src/gollybase/ghashbase.h:79:16: style: The function 'hyperCapable' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:69:16: note: Virtual function in base class golly-3.3-src/gollybase/ghashbase.h:79:16: note: Function in derived class golly-3.3-src/gollybase/ghashbase.h:80:17: style: The function 'setMaxMemory' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:70:17: note: Virtual function in base class golly-3.3-src/gollybase/ghashbase.h:80:17: note: Function in derived class golly-3.3-src/gollybase/ghashbase.h:81:16: style: The function 'getMaxMemory' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:71:16: note: Virtual function in base class golly-3.3-src/gollybase/ghashbase.h:81:16: note: Function in derived class golly-3.3-src/gollybase/ghashbase.h:82:24: style: The function 'setrule' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:72:24: note: Virtual function in base class golly-3.3-src/gollybase/ghashbase.h:82:24: note: Function in derived class golly-3.3-src/gollybase/ghashbase.h:83:24: style: The function 'getrule' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:73:24: note: Virtual function in base class golly-3.3-src/gollybase/ghashbase.h:83:24: note: Function in derived class golly-3.3-src/gollybase/ghashbase.h:84:17: style: The function 'step' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:74:17: note: Virtual function in base class golly-3.3-src/gollybase/ghashbase.h:84:17: note: Function in derived class golly-3.3-src/gollybase/ghashbase.h:85:18: style: The function 'getcurrentstate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:95:18: note: Virtual function in base class golly-3.3-src/gollybase/ghashbase.h:85:18: note: Function in derived class golly-3.3-src/gollybase/ghashbase.h:86:17: style: The function 'setcurrentstate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:96:17: note: Virtual function in base class golly-3.3-src/gollybase/ghashbase.h:86:17: note: Function in derived class golly-3.3-src/gollybase/ghashbase.h:92:17: style: The function 'draw' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:75:17: note: Virtual function in base class golly-3.3-src/gollybase/ghashbase.h:92:17: note: Function in derived class golly-3.3-src/gollybase/ghashbase.h:93:17: style: The function 'fit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:76:17: note: Virtual function in base class golly-3.3-src/gollybase/ghashbase.h:93:17: note: Function in derived class golly-3.3-src/gollybase/ghashbase.h:94:17: style: The function 'lowerRightPixel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:78:17: note: Virtual function in base class golly-3.3-src/gollybase/ghashbase.h:94:17: note: Function in derived class golly-3.3-src/gollybase/ghashbase.h:95:17: style: The function 'findedges' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:77:17: note: Virtual function in base class golly-3.3-src/gollybase/ghashbase.h:95:17: note: Function in derived class golly-3.3-src/gollybase/ghashbase.h:96:24: style: The function 'readmacrocell' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:81:24: note: Virtual function in base class golly-3.3-src/gollybase/ghashbase.h:96:24: note: Function in derived class golly-3.3-src/gollybase/ghashbase.h:97:24: style: The function 'writeNativeFormat' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:79:24: note: Virtual function in base class golly-3.3-src/gollybase/ghashbase.h:97:24: note: Function in derived class golly-3.3-src/gollybase/generationsalgo.h:14:18: style: The function 'slowcalc' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/ghashbase.h:64:18: note: Virtual function in base class golly-3.3-src/gollybase/generationsalgo.h:14:18: note: Function in derived class golly-3.3-src/gollybase/generationsalgo.h:16:24: style: The function 'setrule' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/ghashbase.h:82:24: note: Virtual function in base class golly-3.3-src/gollybase/generationsalgo.h:16:24: note: Function in derived class golly-3.3-src/gollybase/generationsalgo.h:17:24: style: The function 'getrule' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/ghashbase.h:83:24: note: Virtual function in base class golly-3.3-src/gollybase/generationsalgo.h:17:24: note: Function in derived class golly-3.3-src/gollybase/generationsalgo.h:18:24: style: The function 'DefaultRule' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:88:24: note: Virtual function in base class golly-3.3-src/gollybase/generationsalgo.h:18:24: note: Function in derived class golly-3.3-src/gollybase/generationsalgo.h:19:16: style: The function 'NumCellStates' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:90:16: note: Virtual function in base class golly-3.3-src/gollybase/generationsalgo.h:19:16: note: Function in derived class golly-3.3-src/gollybase/generationsalgo.cpp:996:14: style: Condition '*t==0' is always false [knownConditionTrueFalse] golly-3.3-src/gollybase/generationsalgo.cpp:334:28: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/generationsalgo.cpp:343:34: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/generationsalgo.cpp:366:34: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/generationsalgo.cpp:380:40: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/generationsalgo.cpp:714:24: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/generationsalgo.cpp:727:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/generationsalgo.cpp:729:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/generationsalgo.cpp:961:36: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/generationsalgo.cpp:186:8: style: The scope of the variable 'mask' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:187:8: style: The scope of the variable 'nbrs' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:188:8: style: The scope of the variable 'nhood' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:189:8: style: The scope of the variable 'i' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:190:8: style: The scope of the variable 'j' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:258:8: style: The scope of the variable 'xorbit' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:260:8: style: The scope of the variable 'x' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:261:8: style: The scope of the variable 'offset' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:299:9: style: The scope of the variable 'current' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:317:9: style: The scope of the variable 'current' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:325:8: style: The scope of the variable 'lindex' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:443:8: style: The scope of the variable 'k' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:443:11: style: The scope of the variable 'm' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:483:8: style: The scope of the variable 'bits' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:484:8: style: The scope of the variable 'negative' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:485:8: style: The scope of the variable 'setbits' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:486:8: style: The scope of the variable 'maxbits' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:487:8: style: The scope of the variable 'letter' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:488:8: style: The scope of the variable 'j' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:548:8: style: The scope of the variable 'np' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:691:9: style: The scope of the variable 'c' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:732:10: style: The scope of the variable 'charpos' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:733:8: style: The scope of the variable 'digit' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:734:8: style: The scope of the variable 'maxdigit' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:737:10: style: The scope of the variable 'slashpos2' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:740:9: style: The scope of the variable 'underscore_used' can be reduced. [variableScope] golly-3.3-src/gollybase/generationsalgo.cpp:726:50: style:inconclusive: Function 'setrule' argument 1 names different: declaration 's' definition 'rulestring'. [funcArgNamesDifferent] golly-3.3-src/gollybase/generationsalgo.h:16:44: note: Function 'setrule' argument 1 names different: declaration 's' definition 'rulestring'. golly-3.3-src/gollybase/generationsalgo.cpp:726:50: note: Function 'setrule' argument 1 names different: declaration 's' definition 'rulestring'. golly-3.3-src/gollybase/generationsalgo.cpp:187:13: style: Variable 'nbrs' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gollybase/generationsalgo.cpp:188:14: style: Variable 'nhood' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gollybase/generationsalgo.cpp:189:10: style: Variable 'i' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gollybase/generationsalgo.cpp:190:10: style: Variable 'j' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gollybase/generationsalgo.cpp:260:10: style: Variable 'x' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gollybase/generationsalgo.cpp:321:15: style: Variable 'normal' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gollybase/generationsalgo.cpp:324:22: style: Variable 'letterindex' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gollybase/generationsalgo.cpp:325:15: style: Variable 'lindex' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gollybase/generationsalgo.cpp:326:15: style: Variable 'nindex' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gollybase/generationsalgo.cpp:403:11: style: Variable 'c' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gollybase/generationsalgo.cpp:405:22: style: Variable 'index' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gollybase/generationsalgo.cpp:487:15: style: Variable 'letter' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gollybase/generationsalgo.cpp:548:11: style: Variable 'np' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gollybase/generationsalgo.cpp:579:16: style: Variable 'k' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gollybase/generationsalgo.cpp:582:15: style: Variable 'k' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gollybase/ghashbase.h:203:8: performance:inconclusive: Technically the member function 'ghashbase::log2' can be static (but you may consider moving to unnamed namespace). [functionStatic] golly-3.3-src/gollybase/ghashbase.cpp:1472:16: note: Technically the member function 'ghashbase::log2' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gollybase/ghashbase.h:203:8: note: Technically the member function 'ghashbase::log2' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gollybase/ghashbase.cpp:842:17: style: Condition 'depth>=32' is always false [knownConditionTrueFalse] golly-3.3-src/gollybase/ghashbase.cpp:820:17: note: Assuming that condition 'depth>=32' is not redundant golly-3.3-src/gollybase/ghashbase.cpp:842:17: note: Condition 'depth>=32' is always false golly-3.3-src/gollybase/ghashbase.cpp:843:20: style: Condition 'depth==32' is always false [knownConditionTrueFalse] golly-3.3-src/gollybase/ghashbase.cpp:820:17: note: Assuming that condition 'depth>=32' is not redundant golly-3.3-src/gollybase/ghashbase.cpp:843:20: note: Condition 'depth==32' is always false golly-3.3-src/gollybase/ghashbase.cpp:442:7: warning: Either the condition 'freeghnodes==0' is redundant or there is possible null pointer dereference: freeghnodes. [nullPointerRedundantCheck] golly-3.3-src/gollybase/ghashbase.cpp:439:23: note: Assuming that condition 'freeghnodes==0' is not redundant golly-3.3-src/gollybase/ghashbase.cpp:442:7: note: Null pointer dereference golly-3.3-src/gollybase/ghashbase.cpp:1246:4: warning: Either the condition 'stack==0' is redundant or there is possible null pointer dereference: stack. [nullPointerRedundantCheck] golly-3.3-src/gollybase/ghashbase.cpp:1242:17: note: Assuming that condition 'stack==0' is not redundant golly-3.3-src/gollybase/ghashbase.cpp:1246:4: note: Null pointer dereference golly-3.3-src/gollybase/ghashbase.cpp:443:33: warning: Either the condition 'freeghnodes==0' is redundant or there is pointer arithmetic with NULL pointer. [nullPointerArithmeticRedundantCheck] golly-3.3-src/gollybase/ghashbase.cpp:439:23: note: Assuming that condition 'freeghnodes==0' is not redundant golly-3.3-src/gollybase/ghashbase.cpp:443:33: note: Null pointer addition golly-3.3-src/gollybase/ghashbase.cpp:95:15: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:112:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:115:25: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:173:11: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:175:12: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:179:26: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:181:32: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:193:17: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:195:9: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:229:10: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:232:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:233:40: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:236:10: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:388:23: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:389:47: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:390:47: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:391:47: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:392:21: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:393:47: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:394:47: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:395:47: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:396:21: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:397:47: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:398:47: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:399:47: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:400:21: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:401:47: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:402:47: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:403:47: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:438:21: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:462:16: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:474:16: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:485:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:505:11: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:605:16: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:606:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:661:11: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:674:21: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:684:31: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:716:19: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:732:22: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:784:21: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:829:19: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:877:19: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1037:19: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1038:11: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1109:25: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1152:15: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1157:7: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1160:7: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1241:15: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1270:7: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1271:11: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1312:15: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1315:15: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1327:29: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1360:7: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1381:4: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1449:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1552:16: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1673:30: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1719:7: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1723:19: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1724:18: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1732:20: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1754:7: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1761:18: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1771:20: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1793:19: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1794:18: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1815:20: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1870:24: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1874:24: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1887:26: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1896:24: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashbase.cpp:1850:20: style: Variable '*p' is reassigned a value before the old one has been used. [redundantAssignment] golly-3.3-src/gollybase/ghashbase.cpp:1848:20: note: *p is assigned golly-3.3-src/gollybase/ghashbase.cpp:1850:20: note: *p is overwritten golly-3.3-src/gollybase/ghashbase.cpp:414:44: style:inconclusive: Function 'dorecurs_ghleaf' argument 1 names different: declaration 'n' definition 'nw'. [funcArgNamesDifferent] golly-3.3-src/gollybase/ghashbase.h:175:36: note: Function 'dorecurs_ghleaf' argument 1 names different: declaration 'n' definition 'nw'. golly-3.3-src/gollybase/ghashbase.cpp:414:44: note: Function 'dorecurs_ghleaf' argument 1 names different: declaration 'n' definition 'nw'. golly-3.3-src/gollybase/ghashbase.cpp:414:68: style:inconclusive: Function 'dorecurs_ghleaf' argument 3 names different: declaration 't' definition 'sw'. [funcArgNamesDifferent] golly-3.3-src/gollybase/ghashbase.h:175:59: note: Function 'dorecurs_ghleaf' argument 3 names different: declaration 't' definition 'sw'. golly-3.3-src/gollybase/ghashbase.cpp:414:68: note: Function 'dorecurs_ghleaf' argument 3 names different: declaration 't' definition 'sw'. golly-3.3-src/gollybase/ghashbase.cpp:415:44: style:inconclusive: Function 'dorecurs_ghleaf' argument 4 names different: declaration 'e' definition 'se'. [funcArgNamesDifferent] golly-3.3-src/gollybase/ghashbase.h:175:70: note: Function 'dorecurs_ghleaf' argument 4 names different: declaration 'e' definition 'se'. golly-3.3-src/gollybase/ghashbase.cpp:415:44: note: Function 'dorecurs_ghleaf' argument 4 names different: declaration 'e' definition 'se'. golly-3.3-src/gollybase/ghashbase.cpp:614:34: style:inconclusive: Function 'setMaxMemory' argument 1 names different: declaration 'm' definition 'newmemlimit'. [funcArgNamesDifferent] golly-3.3-src/gollybase/ghashbase.h:80:34: note: Function 'setMaxMemory' argument 1 names different: declaration 'm' definition 'newmemlimit'. golly-3.3-src/gollybase/ghashbase.cpp:614:34: note: Function 'setMaxMemory' argument 1 names different: declaration 'm' definition 'newmemlimit'. golly-3.3-src/gollybase/ghashbase.cpp:660:8: style: Local variable 'depth' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/ghashbase.h:114:8: note: Shadowed declaration golly-3.3-src/gollybase/ghashbase.cpp:660:8: note: Shadow variable golly-3.3-src/gollybase/ghashbase.cpp:696:8: style: Local variable 'depth' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/ghashbase.h:114:8: note: Shadowed declaration golly-3.3-src/gollybase/ghashbase.cpp:696:8: note: Shadow variable golly-3.3-src/gollybase/ghashbase.cpp:1071:8: style: Local variable 'depth' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/ghashbase.h:114:8: note: Shadowed declaration golly-3.3-src/gollybase/ghashbase.cpp:1071:8: note: Shadow variable golly-3.3-src/gollybase/ghashbase.cpp:1221:8: style: Local variable 'depth' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/ghashbase.h:114:8: note: Shadowed declaration golly-3.3-src/gollybase/ghashbase.cpp:1221:8: note: Shadow variable golly-3.3-src/gollybase/ghashbase.cpp:1518:8: style: Local variable 'depth' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/ghashbase.h:114:8: note: Shadowed declaration golly-3.3-src/gollybase/ghashbase.cpp:1518:8: note: Shadow variable golly-3.3-src/gollybase/ghashbase.cpp:1628:28: style: Local variable 'i' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/ghashbase.cpp:1545:16: note: Shadowed declaration golly-3.3-src/gollybase/ghashbase.cpp:1628:28: note: Shadow variable golly-3.3-src/gollybase/ghashbase.cpp:1824:8: style: Local variable 'depth' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/ghashbase.h:114:8: note: Shadowed declaration golly-3.3-src/gollybase/ghashbase.cpp:1824:8: note: Shadow variable golly-3.3-src/gollybase/ghashbase.cpp:261:43: style: Parameter 'su' can be declared as reference to const [constParameter] golly-3.3-src/gollybase/ghashbase.cpp:752:16: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. See condition at line 747. [shiftTooManyBitsSigned] golly-3.3-src/gollybase/ghashbase.cpp:747:17: note: Assuming that condition 'depth>31' is not redundant golly-3.3-src/gollybase/ghashbase.cpp:752:16: note: Shift golly-3.3-src/gollybase/ghashbase.cpp:846:16: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. See condition at line 820. [shiftTooManyBitsSigned] golly-3.3-src/gollybase/ghashbase.cpp:820:17: note: Assuming that condition 'depth>=32' is not redundant golly-3.3-src/gollybase/ghashbase.cpp:846:16: note: Shift golly-3.3-src/gollybase/ghashbase.cpp:946:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. See condition at line 945. [shiftTooManyBitsSigned] golly-3.3-src/gollybase/ghashbase.cpp:945:14: note: Assuming that condition 'depth<=31' is not redundant golly-3.3-src/gollybase/ghashbase.cpp:946:9: note: Shift golly-3.3-src/gollybase/ghashbase.cpp:947:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. See condition at line 945. [shiftTooManyBitsSigned] golly-3.3-src/gollybase/ghashbase.cpp:945:14: note: Assuming that condition 'depth<=31' is not redundant golly-3.3-src/gollybase/ghashbase.cpp:947:9: note: Shift golly-3.3-src/gollybase/ghashbase.cpp:949:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] golly-3.3-src/gollybase/ghashbase.cpp:950:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] golly-3.3-src/gollybase/ghashbase.cpp:976:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. See condition at line 975. [shiftTooManyBitsSigned] golly-3.3-src/gollybase/ghashbase.cpp:975:14: note: Assuming that condition 'depth<=31' is not redundant golly-3.3-src/gollybase/ghashbase.cpp:976:9: note: Shift golly-3.3-src/gollybase/ghashbase.cpp:977:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. See condition at line 975. [shiftTooManyBitsSigned] golly-3.3-src/gollybase/ghashbase.cpp:975:14: note: Assuming that condition 'depth<=31' is not redundant golly-3.3-src/gollybase/ghashbase.cpp:977:9: note: Shift golly-3.3-src/gollybase/ghashbase.cpp:979:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] golly-3.3-src/gollybase/ghashbase.cpp:980:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] golly-3.3-src/gollybase/ghashbase.cpp:997:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. See condition at line 996. [shiftTooManyBitsSigned] golly-3.3-src/gollybase/ghashbase.cpp:996:14: note: Assuming that condition 'depth<=31' is not redundant golly-3.3-src/gollybase/ghashbase.cpp:997:9: note: Shift golly-3.3-src/gollybase/ghashbase.cpp:998:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. See condition at line 996. [shiftTooManyBitsSigned] golly-3.3-src/gollybase/ghashbase.cpp:996:14: note: Assuming that condition 'depth<=31' is not redundant golly-3.3-src/gollybase/ghashbase.cpp:998:9: note: Shift golly-3.3-src/gollybase/ghashbase.cpp:1000:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] golly-3.3-src/gollybase/ghashbase.cpp:1001:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] golly-3.3-src/gollybase/ghashbase.cpp:752:16: warning: Either the condition 'depth>31' is redundant or there is signed integer overflow for expression '1<31' is not redundant golly-3.3-src/gollybase/ghashbase.cpp:752:16: note: Integer overflow golly-3.3-src/gollybase/ghashbase.cpp:846:16: warning: Either the condition 'depth>=32' is redundant or there is signed integer overflow for expression '1<=32' is not redundant golly-3.3-src/gollybase/ghashbase.cpp:846:16: note: Integer overflow golly-3.3-src/gollybase/ghashbase.h:212:9: performance:inconclusive: Technically the member function 'ghashbase::drawpixel' can be static (but you may consider moving to unnamed namespace). [functionStatic] golly-3.3-src/gollybase/ghashdraw.cpp:45:17: note: Technically the member function 'ghashbase::drawpixel' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gollybase/ghashbase.h:212:9: note: Technically the member function 'ghashbase::drawpixel' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gollybase/ghashbase.h:214:9: performance:inconclusive: Technically the member function 'ghashbase::draw4x4_1' can be static (but you may consider moving to unnamed namespace). [functionStatic] golly-3.3-src/gollybase/ghashdraw.cpp:84:17: note: Technically the member function 'ghashbase::draw4x4_1' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gollybase/ghashbase.h:214:9: note: Technically the member function 'ghashbase::draw4x4_1' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gollybase/ghashdraw.cpp:453:21: style: The if condition is the same as the previous if condition [duplicateCondition] golly-3.3-src/gollybase/ghashdraw.cpp:447:21: note: First condition golly-3.3-src/gollybase/ghashdraw.cpp:453:21: note: Second condition golly-3.3-src/gollybase/ghashdraw.cpp:636:21: style: The if condition is the same as the previous if condition [duplicateCondition] golly-3.3-src/gollybase/ghashdraw.cpp:630:21: note: First condition golly-3.3-src/gollybase/ghashdraw.cpp:636:21: note: Second condition golly-3.3-src/gollybase/ghashdraw.cpp:668:28: style: Condition 'currdepth>=0' is always true [knownConditionTrueFalse] golly-3.3-src/gollybase/ghashdraw.cpp:636:21: note: Assuming that condition 'currdepth==-1' is not redundant golly-3.3-src/gollybase/ghashdraw.cpp:668:28: note: Condition 'currdepth>=0' is always true golly-3.3-src/gollybase/ghashdraw.cpp:185:27: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashdraw.cpp:246:32: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashdraw.cpp:383:17: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ghashdraw.cpp:233:32: style:inconclusive: Function 'draw' argument 1 names different: declaration 'view' definition 'viewarg'. [funcArgNamesDifferent] golly-3.3-src/gollybase/ghashbase.h:92:32: note: Function 'draw' argument 1 names different: declaration 'view' definition 'viewarg'. golly-3.3-src/gollybase/ghashdraw.cpp:233:32: note: Function 'draw' argument 1 names different: declaration 'view' definition 'viewarg'. golly-3.3-src/gollybase/ghashdraw.cpp:233:53: style:inconclusive: Function 'draw' argument 2 names different: declaration 'renderer' definition 'rendererarg'. [funcArgNamesDifferent] golly-3.3-src/gollybase/ghashbase.h:92:50: note: Function 'draw' argument 2 names different: declaration 'renderer' definition 'rendererarg'. golly-3.3-src/gollybase/ghashdraw.cpp:233:53: note: Function 'draw' argument 2 names different: declaration 'renderer' definition 'rendererarg'. golly-3.3-src/gollybase/ghashdraw.cpp:420:35: style:inconclusive: Function 'findedges' argument 1 names different: declaration 't' definition 'ptop'. [funcArgNamesDifferent] golly-3.3-src/gollybase/ghashbase.h:95:35: note: Function 'findedges' argument 1 names different: declaration 't' definition 'ptop'. golly-3.3-src/gollybase/ghashdraw.cpp:420:35: note: Function 'findedges' argument 1 names different: declaration 't' definition 'ptop'. golly-3.3-src/gollybase/ghashdraw.cpp:420:49: style:inconclusive: Function 'findedges' argument 2 names different: declaration 'l' definition 'pleft'. [funcArgNamesDifferent] golly-3.3-src/gollybase/ghashbase.h:95:46: note: Function 'findedges' argument 2 names different: declaration 'l' definition 'pleft'. golly-3.3-src/gollybase/ghashdraw.cpp:420:49: note: Function 'findedges' argument 2 names different: declaration 'l' definition 'pleft'. golly-3.3-src/gollybase/ghashdraw.cpp:420:64: style:inconclusive: Function 'findedges' argument 3 names different: declaration 'b' definition 'pbottom'. [funcArgNamesDifferent] golly-3.3-src/gollybase/ghashbase.h:95:57: note: Function 'findedges' argument 3 names different: declaration 'b' definition 'pbottom'. golly-3.3-src/gollybase/ghashdraw.cpp:420:64: note: Function 'findedges' argument 3 names different: declaration 'b' definition 'pbottom'. golly-3.3-src/gollybase/ghashdraw.cpp:420:81: style:inconclusive: Function 'findedges' argument 4 names different: declaration 'r' definition 'pright'. [funcArgNamesDifferent] golly-3.3-src/gollybase/ghashbase.h:95:68: note: Function 'findedges' argument 4 names different: declaration 'r' definition 'pright'. golly-3.3-src/gollybase/ghashdraw.cpp:420:81: note: Function 'findedges' argument 4 names different: declaration 'r' definition 'pright'. golly-3.3-src/gollybase/ghashdraw.cpp:348:15: style: Local variable 'z' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/ghashdraw.cpp:290:12: note: Shadowed declaration golly-3.3-src/gollybase/ghashdraw.cpp:348:15: note: Shadow variable golly-3.3-src/gollybase/ghashdraw.cpp:803:8: style: Local variable 'mag' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/ghashbase.h:149:38: note: Shadowed declaration golly-3.3-src/gollybase/ghashdraw.cpp:803:8: note: Shadow variable golly-3.3-src/gollybase/ghashdraw.cpp:84:46: style: Parameter 'z' can be declared as pointer to const [constParameter] golly-3.3-src/gollybase/hlifealgo.h:143:9: performance:inconclusive: Technically the member function 'setup_t::prefetch' can be static (but you may consider moving to unnamed namespace). [functionStatic] golly-3.3-src/gollybase/hlifealgo.h:156:17: style: The function 'clearall' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:53:17: note: Virtual function in base class golly-3.3-src/gollybase/hlifealgo.h:156:17: note: Function in derived class golly-3.3-src/gollybase/hlifealgo.h:157:16: style: The function 'setcell' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:55:16: note: Virtual function in base class golly-3.3-src/gollybase/hlifealgo.h:157:16: note: Function in derived class golly-3.3-src/gollybase/hlifealgo.h:158:16: style: The function 'getcell' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:56:16: note: Virtual function in base class golly-3.3-src/gollybase/hlifealgo.h:158:16: note: Function in derived class golly-3.3-src/gollybase/hlifealgo.h:159:16: style: The function 'nextcell' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:57:16: note: Virtual function in base class golly-3.3-src/gollybase/hlifealgo.h:159:16: note: Function in derived class golly-3.3-src/gollybase/hlifealgo.h:160:17: style: The function 'endofpattern' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:60:17: note: Virtual function in base class golly-3.3-src/gollybase/hlifealgo.h:160:17: note: Function in derived class golly-3.3-src/gollybase/hlifealgo.h:161:17: style: The function 'setIncrement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:61:17: note: Virtual function in base class golly-3.3-src/gollybase/hlifealgo.h:161:17: note: Function in derived class golly-3.3-src/gollybase/hlifealgo.h:162:17: style: The function 'setIncrement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:62:17: note: Virtual function in base class golly-3.3-src/gollybase/hlifealgo.h:162:17: note: Function in derived class golly-3.3-src/gollybase/hlifealgo.h:163:17: style: The function 'setGeneration' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:63:17: note: Virtual function in base class golly-3.3-src/gollybase/hlifealgo.h:163:17: note: Function in derived class golly-3.3-src/gollybase/hlifealgo.h:164:26: style: The function 'getPopulation' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:66:26: note: Virtual function in base class golly-3.3-src/gollybase/hlifealgo.h:164:26: note: Function in derived class golly-3.3-src/gollybase/hlifealgo.h:165:16: style: The function 'isEmpty' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:67:16: note: Virtual function in base class golly-3.3-src/gollybase/hlifealgo.h:165:16: note: Function in derived class golly-3.3-src/gollybase/hlifealgo.h:166:16: style: The function 'hyperCapable' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:69:16: note: Virtual function in base class golly-3.3-src/gollybase/hlifealgo.h:166:16: note: Function in derived class golly-3.3-src/gollybase/hlifealgo.h:167:17: style: The function 'setMaxMemory' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:70:17: note: Virtual function in base class golly-3.3-src/gollybase/hlifealgo.h:167:17: note: Function in derived class golly-3.3-src/gollybase/hlifealgo.h:168:16: style: The function 'getMaxMemory' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:71:16: note: Virtual function in base class golly-3.3-src/gollybase/hlifealgo.h:168:16: note: Function in derived class golly-3.3-src/gollybase/hlifealgo.h:169:24: style: The function 'setrule' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:72:24: note: Virtual function in base class golly-3.3-src/gollybase/hlifealgo.h:169:24: note: Function in derived class golly-3.3-src/gollybase/hlifealgo.h:170:24: style: The function 'getrule' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:73:24: note: Virtual function in base class golly-3.3-src/gollybase/hlifealgo.h:170:24: note: Function in derived class golly-3.3-src/gollybase/hlifealgo.h:171:17: style: The function 'step' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:74:17: note: Virtual function in base class golly-3.3-src/gollybase/hlifealgo.h:171:17: note: Function in derived class golly-3.3-src/gollybase/hlifealgo.h:172:18: style: The function 'getcurrentstate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:95:18: note: Virtual function in base class golly-3.3-src/gollybase/hlifealgo.h:172:18: note: Function in derived class golly-3.3-src/gollybase/hlifealgo.h:173:17: style: The function 'setcurrentstate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:96:17: note: Virtual function in base class golly-3.3-src/gollybase/hlifealgo.h:173:17: note: Function in derived class golly-3.3-src/gollybase/hlifealgo.h:179:17: style: The function 'draw' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:75:17: note: Virtual function in base class golly-3.3-src/gollybase/hlifealgo.h:179:17: note: Function in derived class golly-3.3-src/gollybase/hlifealgo.h:180:17: style: The function 'fit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:76:17: note: Virtual function in base class golly-3.3-src/gollybase/hlifealgo.h:180:17: note: Function in derived class golly-3.3-src/gollybase/hlifealgo.h:181:17: style: The function 'lowerRightPixel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:78:17: note: Virtual function in base class golly-3.3-src/gollybase/hlifealgo.h:181:17: note: Function in derived class golly-3.3-src/gollybase/hlifealgo.h:182:17: style: The function 'findedges' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:77:17: note: Virtual function in base class golly-3.3-src/gollybase/hlifealgo.h:182:17: note: Function in derived class golly-3.3-src/gollybase/hlifealgo.h:183:24: style: The function 'readmacrocell' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:81:24: note: Virtual function in base class golly-3.3-src/gollybase/hlifealgo.h:183:24: note: Function in derived class golly-3.3-src/gollybase/hlifealgo.h:184:24: style: The function 'writeNativeFormat' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:79:24: note: Virtual function in base class golly-3.3-src/gollybase/hlifealgo.h:184:24: note: Function in derived class golly-3.3-src/gollybase/hlifedraw.cpp:113:30: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifedraw.cpp:168:25: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifedraw.cpp:381:15: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifedraw.cpp:231:32: style:inconclusive: Function 'draw' argument 1 names different: declaration 'view' definition 'viewarg'. [funcArgNamesDifferent] golly-3.3-src/gollybase/hlifealgo.h:179:32: note: Function 'draw' argument 1 names different: declaration 'view' definition 'viewarg'. golly-3.3-src/gollybase/hlifedraw.cpp:231:32: note: Function 'draw' argument 1 names different: declaration 'view' definition 'viewarg'. golly-3.3-src/gollybase/hlifedraw.cpp:231:53: style:inconclusive: Function 'draw' argument 2 names different: declaration 'renderer' definition 'rendererarg'. [funcArgNamesDifferent] golly-3.3-src/gollybase/hlifealgo.h:179:50: note: Function 'draw' argument 2 names different: declaration 'renderer' definition 'rendererarg'. golly-3.3-src/gollybase/hlifedraw.cpp:231:53: note: Function 'draw' argument 2 names different: declaration 'renderer' definition 'rendererarg'. golly-3.3-src/gollybase/hlifedraw.cpp:419:35: style:inconclusive: Function 'findedges' argument 1 names different: declaration 't' definition 'ptop'. [funcArgNamesDifferent] golly-3.3-src/gollybase/hlifealgo.h:182:35: note: Function 'findedges' argument 1 names different: declaration 't' definition 'ptop'. golly-3.3-src/gollybase/hlifedraw.cpp:419:35: note: Function 'findedges' argument 1 names different: declaration 't' definition 'ptop'. golly-3.3-src/gollybase/hlifedraw.cpp:419:49: style:inconclusive: Function 'findedges' argument 2 names different: declaration 'l' definition 'pleft'. [funcArgNamesDifferent] golly-3.3-src/gollybase/hlifealgo.h:182:46: note: Function 'findedges' argument 2 names different: declaration 'l' definition 'pleft'. golly-3.3-src/gollybase/hlifedraw.cpp:419:49: note: Function 'findedges' argument 2 names different: declaration 'l' definition 'pleft'. golly-3.3-src/gollybase/hlifedraw.cpp:419:64: style:inconclusive: Function 'findedges' argument 3 names different: declaration 'b' definition 'pbottom'. [funcArgNamesDifferent] golly-3.3-src/gollybase/hlifealgo.h:182:57: note: Function 'findedges' argument 3 names different: declaration 'b' definition 'pbottom'. golly-3.3-src/gollybase/hlifedraw.cpp:419:64: note: Function 'findedges' argument 3 names different: declaration 'b' definition 'pbottom'. golly-3.3-src/gollybase/hlifedraw.cpp:419:81: style:inconclusive: Function 'findedges' argument 4 names different: declaration 'r' definition 'pright'. [funcArgNamesDifferent] golly-3.3-src/gollybase/hlifealgo.h:182:68: note: Function 'findedges' argument 4 names different: declaration 'r' definition 'pright'. golly-3.3-src/gollybase/hlifedraw.cpp:419:81: note: Function 'findedges' argument 4 names different: declaration 'r' definition 'pright'. golly-3.3-src/gollybase/hlifedraw.cpp:347:13: style: Local variable 'z' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/hlifedraw.cpp:289:10: note: Shadowed declaration golly-3.3-src/gollybase/hlifedraw.cpp:347:13: note: Shadow variable golly-3.3-src/gollybase/hlifedraw.cpp:799:8: style: Local variable 'mag' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/hlifealgo.h:236:38: note: Shadowed declaration golly-3.3-src/gollybase/hlifedraw.cpp:799:8: note: Shadow variable golly-3.3-src/gollybase/hlifedraw.cpp:50:31: style: Parameter 'z' can be declared as pointer to const [constParameter] golly-3.3-src/gollybase/hlifealgo.h:294:8: performance:inconclusive: Technically the member function 'hlifealgo::log2' can be static (but you may consider moving to unnamed namespace). [functionStatic] golly-3.3-src/gollybase/hlifealgo.cpp:1559:16: note: Technically the member function 'hlifealgo::log2' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gollybase/hlifealgo.h:294:8: note: Technically the member function 'hlifealgo::log2' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gollybase/hlifealgo.h:303:9: performance:inconclusive: Technically the member function 'hlifealgo::unpack8x8' can be static (but you may consider moving to unnamed namespace). [functionStatic] golly-3.3-src/gollybase/hlifealgo.cpp:1852:17: note: Technically the member function 'hlifealgo::unpack8x8' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gollybase/hlifealgo.h:303:9: note: Technically the member function 'hlifealgo::unpack8x8' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gollybase/hlifealgo.cpp:968:17: style: Condition 'depth>=32' is always false [knownConditionTrueFalse] golly-3.3-src/gollybase/hlifealgo.cpp:942:17: note: Assuming that condition 'depth>=32' is not redundant golly-3.3-src/gollybase/hlifealgo.cpp:968:17: note: Condition 'depth>=32' is always false golly-3.3-src/gollybase/hlifealgo.cpp:969:20: style: Condition 'depth==32' is always false [knownConditionTrueFalse] golly-3.3-src/gollybase/hlifealgo.cpp:942:17: note: Assuming that condition 'depth>=32' is not redundant golly-3.3-src/gollybase/hlifealgo.cpp:969:20: note: Condition 'depth==32' is always false golly-3.3-src/gollybase/hlifealgo.cpp:539:7: warning: Either the condition 'freenodes==0' is redundant or there is possible null pointer dereference: freenodes. [nullPointerRedundantCheck] golly-3.3-src/gollybase/hlifealgo.cpp:536:21: note: Assuming that condition 'freenodes==0' is not redundant golly-3.3-src/gollybase/hlifealgo.cpp:539:7: note: Null pointer dereference golly-3.3-src/gollybase/hlifealgo.cpp:1369:4: warning: Either the condition 'stack==0' is redundant or there is possible null pointer dereference: stack. [nullPointerRedundantCheck] golly-3.3-src/gollybase/hlifealgo.cpp:1365:17: note: Assuming that condition 'stack==0' is not redundant golly-3.3-src/gollybase/hlifealgo.cpp:1369:4: note: Null pointer dereference golly-3.3-src/gollybase/hlifealgo.cpp:540:29: warning: Either the condition 'freenodes==0' is redundant or there is pointer arithmetic with NULL pointer. [nullPointerArithmeticRedundantCheck] golly-3.3-src/gollybase/hlifealgo.cpp:536:21: note: Assuming that condition 'freenodes==0' is not redundant golly-3.3-src/gollybase/hlifealgo.cpp:540:29: note: Null pointer addition golly-3.3-src/gollybase/hlifealgo.cpp:155:15: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:172:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:175:23: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:234:11: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:236:12: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:240:26: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:242:30: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:254:17: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:256:9: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:291:10: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:294:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:295:36: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:298:10: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:301:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:302:44: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:304:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:305:41: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:444:21: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:445:47: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:446:47: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:447:47: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:448:21: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:449:47: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:450:47: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:451:47: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:452:21: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:453:47: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:454:47: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:455:47: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:456:21: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:457:47: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:458:47: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:459:47: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:535:19: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:559:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:571:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:592:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:613:11: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:713:16: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:714:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:769:11: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:782:19: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:792:29: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:824:17: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:853:22: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:917:21: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:951:17: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1002:17: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1162:17: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1163:11: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1234:25: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1277:15: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1282:7: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1285:7: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1364:15: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1393:7: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1394:11: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1438:15: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1450:27: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1485:7: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1536:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1639:16: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1673:21: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1877:7: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1882:17: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1884:18: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1904:20: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1925:7: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1932:18: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1942:20: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1966:17: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1967:18: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:1999:20: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:2053:22: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:2057:22: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:2070:22: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:2079:22: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/hlifealgo.cpp:2033:20: style: Variable '*p' is reassigned a value before the old one has been used. [redundantAssignment] golly-3.3-src/gollybase/hlifealgo.cpp:2031:20: note: *p is assigned golly-3.3-src/gollybase/hlifealgo.cpp:2033:20: note: *p is overwritten golly-3.3-src/gollybase/hlifealgo.cpp:576:8: style: The scope of the variable 'i' can be reduced. [variableScope] golly-3.3-src/gollybase/hlifealgo.cpp:722:34: style:inconclusive: Function 'setMaxMemory' argument 1 names different: declaration 'm' definition 'newmemlimit'. [funcArgNamesDifferent] golly-3.3-src/gollybase/hlifealgo.h:167:34: note: Function 'setMaxMemory' argument 1 names different: declaration 'm' definition 'newmemlimit'. golly-3.3-src/gollybase/hlifealgo.cpp:722:34: note: Function 'setMaxMemory' argument 1 names different: declaration 'm' definition 'newmemlimit'. golly-3.3-src/gollybase/hlifealgo.cpp:1116:44: style:inconclusive: Function 'nextcell' argument 3 names different: declaration 'state' definition 'v'. [funcArgNamesDifferent] golly-3.3-src/gollybase/hlifealgo.h:159:44: note: Function 'nextcell' argument 3 names different: declaration 'state' definition 'v'. golly-3.3-src/gollybase/hlifealgo.cpp:1116:44: note: Function 'nextcell' argument 3 names different: declaration 'state' definition 'v'. golly-3.3-src/gollybase/hlifealgo.cpp:768:8: style: Local variable 'depth' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/hlifealgo.h:200:8: note: Shadowed declaration golly-3.3-src/gollybase/hlifealgo.cpp:768:8: note: Shadow variable golly-3.3-src/gollybase/hlifealgo.cpp:804:8: style: Local variable 'depth' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/hlifealgo.h:200:8: note: Shadowed declaration golly-3.3-src/gollybase/hlifealgo.cpp:804:8: note: Shadow variable golly-3.3-src/gollybase/hlifealgo.cpp:1196:8: style: Local variable 'depth' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/hlifealgo.h:200:8: note: Shadowed declaration golly-3.3-src/gollybase/hlifealgo.cpp:1196:8: note: Shadow variable golly-3.3-src/gollybase/hlifealgo.cpp:1344:8: style: Local variable 'depth' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/hlifealgo.h:200:8: note: Shadowed declaration golly-3.3-src/gollybase/hlifealgo.cpp:1344:8: note: Shadow variable golly-3.3-src/gollybase/hlifealgo.cpp:1605:8: style: Local variable 'depth' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/hlifealgo.h:200:8: note: Shadowed declaration golly-3.3-src/gollybase/hlifealgo.cpp:1605:8: note: Shadow variable golly-3.3-src/gollybase/hlifealgo.cpp:1749:28: style: Local variable 'i' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/hlifealgo.cpp:1632:16: note: Shadowed declaration golly-3.3-src/gollybase/hlifealgo.cpp:1749:28: note: Shadow variable golly-3.3-src/gollybase/hlifealgo.cpp:2007:8: style: Local variable 'depth' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/hlifealgo.h:200:8: note: Shadowed declaration golly-3.3-src/gollybase/hlifealgo.cpp:2007:8: note: Shadow variable golly-3.3-src/gollybase/hlifealgo.cpp:328:37: style: Parameter 'su' can be declared as reference to const [constParameter] golly-3.3-src/gollybase/hlifealgo.cpp:885:16: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. See condition at line 881. [shiftTooManyBitsSigned] golly-3.3-src/gollybase/hlifealgo.cpp:881:17: note: Assuming that condition 'depth>=32' is not redundant golly-3.3-src/gollybase/hlifealgo.cpp:885:16: note: Shift golly-3.3-src/gollybase/hlifealgo.cpp:972:16: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. See condition at line 942. [shiftTooManyBitsSigned] golly-3.3-src/gollybase/hlifealgo.cpp:942:17: note: Assuming that condition 'depth>=32' is not redundant golly-3.3-src/gollybase/hlifealgo.cpp:972:16: note: Shift golly-3.3-src/gollybase/hlifealgo.cpp:1070:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. See condition at line 1069. [shiftTooManyBitsSigned] golly-3.3-src/gollybase/hlifealgo.cpp:1069:14: note: Assuming that condition 'depth<=31' is not redundant golly-3.3-src/gollybase/hlifealgo.cpp:1070:9: note: Shift golly-3.3-src/gollybase/hlifealgo.cpp:1071:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. See condition at line 1069. [shiftTooManyBitsSigned] golly-3.3-src/gollybase/hlifealgo.cpp:1069:14: note: Assuming that condition 'depth<=31' is not redundant golly-3.3-src/gollybase/hlifealgo.cpp:1071:9: note: Shift golly-3.3-src/gollybase/hlifealgo.cpp:1073:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] golly-3.3-src/gollybase/hlifealgo.cpp:1074:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] golly-3.3-src/gollybase/hlifealgo.cpp:1100:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. See condition at line 1099. [shiftTooManyBitsSigned] golly-3.3-src/gollybase/hlifealgo.cpp:1099:14: note: Assuming that condition 'depth<=31' is not redundant golly-3.3-src/gollybase/hlifealgo.cpp:1100:9: note: Shift golly-3.3-src/gollybase/hlifealgo.cpp:1101:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. See condition at line 1099. [shiftTooManyBitsSigned] golly-3.3-src/gollybase/hlifealgo.cpp:1099:14: note: Assuming that condition 'depth<=31' is not redundant golly-3.3-src/gollybase/hlifealgo.cpp:1101:9: note: Shift golly-3.3-src/gollybase/hlifealgo.cpp:1103:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] golly-3.3-src/gollybase/hlifealgo.cpp:1104:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] golly-3.3-src/gollybase/hlifealgo.cpp:1122:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. See condition at line 1121. [shiftTooManyBitsSigned] golly-3.3-src/gollybase/hlifealgo.cpp:1121:14: note: Assuming that condition 'depth<=31' is not redundant golly-3.3-src/gollybase/hlifealgo.cpp:1122:9: note: Shift golly-3.3-src/gollybase/hlifealgo.cpp:1123:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. See condition at line 1121. [shiftTooManyBitsSigned] golly-3.3-src/gollybase/hlifealgo.cpp:1121:14: note: Assuming that condition 'depth<=31' is not redundant golly-3.3-src/gollybase/hlifealgo.cpp:1123:9: note: Shift golly-3.3-src/gollybase/hlifealgo.cpp:1125:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] golly-3.3-src/gollybase/hlifealgo.cpp:1126:9: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] golly-3.3-src/gollybase/hlifealgo.cpp:885:16: warning: Either the condition 'depth>=32' is redundant or there is signed integer overflow for expression '1<=32' is not redundant golly-3.3-src/gollybase/hlifealgo.cpp:885:16: note: Integer overflow golly-3.3-src/gollybase/hlifealgo.cpp:972:16: warning: Either the condition 'depth>=32' is redundant or there is signed integer overflow for expression '1<=32' is not redundant golly-3.3-src/gollybase/hlifealgo.cpp:972:16: note: Integer overflow golly-3.3-src/gollybase/jvnalgo.h:14:18: style: The function 'slowcalc' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/ghashbase.h:64:18: note: Virtual function in base class golly-3.3-src/gollybase/jvnalgo.h:14:18: note: Function in derived class golly-3.3-src/gollybase/jvnalgo.h:16:24: style: The function 'setrule' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/ghashbase.h:82:24: note: Virtual function in base class golly-3.3-src/gollybase/jvnalgo.h:16:24: note: Function in derived class golly-3.3-src/gollybase/jvnalgo.h:17:24: style: The function 'getrule' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/ghashbase.h:83:24: note: Virtual function in base class golly-3.3-src/gollybase/jvnalgo.h:17:24: note: Function in derived class golly-3.3-src/gollybase/jvnalgo.h:18:24: style: The function 'DefaultRule' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:88:24: note: Virtual function in base class golly-3.3-src/gollybase/jvnalgo.h:18:24: note: Function in derived class golly-3.3-src/gollybase/jvnalgo.h:19:16: style: The function 'NumCellStates' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:90:16: note: Virtual function in base class golly-3.3-src/gollybase/jvnalgo.h:19:16: note: Function in derived class golly-3.3-src/gollybase/lifealgo.cpp:891:17: warning: Member variable 'staticAlgoInfo::minstates' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/lifealgo.cpp:891:17: warning: Member variable 'staticAlgoInfo::maxstates' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/lifealgo.cpp:891:17: warning: Member variable 'staticAlgoInfo::defgradient' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/lifealgo.cpp:891:17: warning: Member variable 'staticAlgoInfo::defr1' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/lifealgo.cpp:891:17: warning: Member variable 'staticAlgoInfo::defg1' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/lifealgo.cpp:891:17: warning: Member variable 'staticAlgoInfo::defb1' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/lifealgo.cpp:891:17: warning: Member variable 'staticAlgoInfo::defr2' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/lifealgo.cpp:891:17: warning: Member variable 'staticAlgoInfo::defg2' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/lifealgo.cpp:891:17: warning: Member variable 'staticAlgoInfo::defb2' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/lifealgo.cpp:891:17: warning: Member variable 'staticAlgoInfo::defr' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/lifealgo.cpp:891:17: warning: Member variable 'staticAlgoInfo::defg' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/lifealgo.cpp:891:17: warning: Member variable 'staticAlgoInfo::defb' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/lifealgo.cpp:891:17: warning: Member variable 'staticAlgoInfo::algoName' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/lifealgo.cpp:891:17: warning: Member variable 'staticAlgoInfo::creator' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/lifealgo.cpp:461:41: style: Condition 'shiftedx0' is redundant or the array 'nullroots[40]' is accessed at index 40, which is out of bounds. [arrayIndexOutOfBoundsCond] golly-3.3-src/gollybase/qlifealgo.cpp:872:12: note: Assuming that condition 'lev>0' is not redundant golly-3.3-src/gollybase/qlifealgo.cpp:873:25: note: Array index out of bounds golly-3.3-src/gollybase/qlifealgo.cpp:195:12: warning: Member variable 'qlifealgo::ruletable' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/qlifealgo.cpp:195:12: warning: Member variable 'qlifealgo::renderer' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/qlifealgo.cpp:195:12: warning: Member variable 'qlifealgo::view' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/qlifealgo.cpp:195:12: warning: Member variable 'qlifealgo::uviewh' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/qlifealgo.cpp:195:12: warning: Member variable 'qlifealgo::uvieww' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/qlifealgo.cpp:195:12: warning: Member variable 'qlifealgo::viewh' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/qlifealgo.cpp:195:12: warning: Member variable 'qlifealgo::vieww' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/qlifealgo.cpp:195:12: warning: Member variable 'qlifealgo::mag' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/qlifealgo.cpp:195:12: warning: Member variable 'qlifealgo::pmag' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/qlifealgo.cpp:195:12: warning: Member variable 'qlifealgo::kadd' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/qlifealgo.cpp:195:12: warning: Member variable 'qlifealgo::oddgen' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/qlifealgo.cpp:195:12: warning: Member variable 'qlifealgo::bmleft' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/qlifealgo.cpp:195:12: warning: Member variable 'qlifealgo::bmtop' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/qlifealgo.cpp:195:12: warning: Member variable 'qlifealgo::bmlev' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/qlifealgo.cpp:195:12: warning: Member variable 'qlifealgo::shbmsize' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/qlifealgo.cpp:195:12: warning: Member variable 'qlifealgo::logshbmsize' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/qlifealgo.cpp:195:12: warning: Member variable 'qlifealgo::quickb' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/qlifealgo.h:241:8: style:inconclusive: Technically the member function 'qlifealgo::uproot_needed' can be const. [functionConst] golly-3.3-src/gollybase/qlifealgo.cpp:1096:16: note: Technically the member function 'qlifealgo::uproot_needed' can be const. golly-3.3-src/gollybase/qlifealgo.h:241:8: note: Technically the member function 'qlifealgo::uproot_needed' can be const. golly-3.3-src/gollybase/qlifealgo.h:193:17: style: Virtual function 'clearall' is called from constructor 'qlifealgo()' at line 201. Dynamic binding is not used. [virtualCallInConstructor] golly-3.3-src/gollybase/qlifealgo.cpp:201:4: note: Calling clearall golly-3.3-src/gollybase/qlifealgo.h:193:17: note: clearall is a virtual function golly-3.3-src/gollybase/qlifealgo.h:193:17: style: The function 'clearall' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:53:17: note: Virtual function in base class golly-3.3-src/gollybase/qlifealgo.h:193:17: note: Function in derived class golly-3.3-src/gollybase/qlifealgo.h:194:16: style: The function 'setcell' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:55:16: note: Virtual function in base class golly-3.3-src/gollybase/qlifealgo.h:194:16: note: Function in derived class golly-3.3-src/gollybase/qlifealgo.h:195:16: style: The function 'getcell' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:56:16: note: Virtual function in base class golly-3.3-src/gollybase/qlifealgo.h:195:16: note: Function in derived class golly-3.3-src/gollybase/qlifealgo.h:196:16: style: The function 'nextcell' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:57:16: note: Virtual function in base class golly-3.3-src/gollybase/qlifealgo.h:196:16: note: Function in derived class golly-3.3-src/gollybase/qlifealgo.h:198:17: style: The function 'endofpattern' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:60:17: note: Virtual function in base class golly-3.3-src/gollybase/qlifealgo.h:198:17: note: Function in derived class golly-3.3-src/gollybase/qlifealgo.h:203:17: style: The function 'setIncrement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:61:17: note: Virtual function in base class golly-3.3-src/gollybase/qlifealgo.h:203:17: note: Function in derived class golly-3.3-src/gollybase/qlifealgo.h:204:17: style: The function 'setIncrement' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:62:17: note: Virtual function in base class golly-3.3-src/gollybase/qlifealgo.h:204:17: note: Function in derived class golly-3.3-src/gollybase/qlifealgo.h:205:17: style: The function 'setGeneration' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:63:17: note: Virtual function in base class golly-3.3-src/gollybase/qlifealgo.h:205:17: note: Function in derived class golly-3.3-src/gollybase/qlifealgo.h:206:26: style: The function 'getPopulation' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:66:26: note: Virtual function in base class golly-3.3-src/gollybase/qlifealgo.h:206:26: note: Function in derived class golly-3.3-src/gollybase/qlifealgo.h:207:16: style: The function 'isEmpty' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:67:16: note: Virtual function in base class golly-3.3-src/gollybase/qlifealgo.h:207:16: note: Function in derived class golly-3.3-src/gollybase/qlifealgo.h:209:16: style: The function 'hyperCapable' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:69:16: note: Virtual function in base class golly-3.3-src/gollybase/qlifealgo.h:209:16: note: Function in derived class golly-3.3-src/gollybase/qlifealgo.h:210:17: style: The function 'setMaxMemory' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:70:17: note: Virtual function in base class golly-3.3-src/gollybase/qlifealgo.h:210:17: note: Function in derived class golly-3.3-src/gollybase/qlifealgo.h:211:16: style: The function 'getMaxMemory' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:71:16: note: Virtual function in base class golly-3.3-src/gollybase/qlifealgo.h:211:16: note: Function in derived class golly-3.3-src/gollybase/qlifealgo.h:212:24: style: The function 'setrule' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:72:24: note: Virtual function in base class golly-3.3-src/gollybase/qlifealgo.h:212:24: note: Function in derived class golly-3.3-src/gollybase/qlifealgo.h:213:24: style: The function 'getrule' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:73:24: note: Virtual function in base class golly-3.3-src/gollybase/qlifealgo.h:213:24: note: Function in derived class golly-3.3-src/gollybase/qlifealgo.h:214:17: style: The function 'step' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:74:17: note: Virtual function in base class golly-3.3-src/gollybase/qlifealgo.h:214:17: note: Function in derived class golly-3.3-src/gollybase/qlifealgo.h:215:18: style: The function 'getcurrentstate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:95:18: note: Virtual function in base class golly-3.3-src/gollybase/qlifealgo.h:215:18: note: Function in derived class golly-3.3-src/gollybase/qlifealgo.h:216:17: style: The function 'setcurrentstate' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:96:17: note: Virtual function in base class golly-3.3-src/gollybase/qlifealgo.h:216:17: note: Function in derived class golly-3.3-src/gollybase/qlifealgo.h:217:17: style: The function 'draw' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:75:17: note: Virtual function in base class golly-3.3-src/gollybase/qlifealgo.h:217:17: note: Function in derived class golly-3.3-src/gollybase/qlifealgo.h:218:17: style: The function 'fit' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:76:17: note: Virtual function in base class golly-3.3-src/gollybase/qlifealgo.h:218:17: note: Function in derived class golly-3.3-src/gollybase/qlifealgo.h:219:17: style: The function 'lowerRightPixel' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:78:17: note: Virtual function in base class golly-3.3-src/gollybase/qlifealgo.h:219:17: note: Function in derived class golly-3.3-src/gollybase/qlifealgo.h:220:17: style: The function 'findedges' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:77:17: note: Virtual function in base class golly-3.3-src/gollybase/qlifealgo.h:220:17: note: Function in derived class golly-3.3-src/gollybase/qlifealgo.h:221:24: style: The function 'writeNativeFormat' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:79:24: note: Virtual function in base class golly-3.3-src/gollybase/qlifealgo.h:221:24: note: Function in derived class golly-3.3-src/gollybase/qlifealgo.cpp:813:10: style: Condition 'xmax' is always false [knownConditionTrueFalse] golly-3.3-src/gollybase/qlifealgo.cpp:811:24: note: Assuming that condition 'x>max' is not redundant golly-3.3-src/gollybase/qlifealgo.cpp:813:21: note: Condition 'x>max' is always false golly-3.3-src/gollybase/qlifealgo.cpp:813:32: style: Condition 'ymax' is always false [knownConditionTrueFalse] golly-3.3-src/gollybase/qlifealgo.cpp:811:46: note: Assuming that condition 'y>max' is not redundant golly-3.3-src/gollybase/qlifealgo.cpp:813:43: note: Condition 'y>max' is always false golly-3.3-src/gollybase/qlifealgo.cpp:867:10: style: Condition 'x>max' is always false [knownConditionTrueFalse] golly-3.3-src/gollybase/qlifealgo.cpp:865:24: note: Assuming that condition 'x>max' is not redundant golly-3.3-src/gollybase/qlifealgo.cpp:867:10: note: Condition 'x>max' is always false golly-3.3-src/gollybase/qlifealgo.cpp:867:21: style: Condition 'xmax' is always false [knownConditionTrueFalse] golly-3.3-src/gollybase/qlifealgo.cpp:865:46: note: Assuming that condition 'y>max' is not redundant golly-3.3-src/gollybase/qlifealgo.cpp:867:43: note: Condition 'y>max' is always false golly-3.3-src/gollybase/qlifealgo.cpp:56:4: warning: Either the condition 'r==0' is redundant or there is possible null pointer dereference: r. [nullPointerRedundantCheck] golly-3.3-src/gollybase/qlifealgo.cpp:54:10: note: Assuming that condition 'r==0' is not redundant golly-3.3-src/gollybase/qlifealgo.cpp:56:4: note: Null pointer dereference golly-3.3-src/gollybase/qlifealgo.cpp:58:47: warning: Either the condition 'r==0' is redundant or there is pointer arithmetic with NULL pointer. [nullPointerArithmeticRedundantCheck] golly-3.3-src/gollybase/qlifealgo.cpp:54:10: note: Assuming that condition 'r==0' is not redundant golly-3.3-src/gollybase/qlifealgo.cpp:58:47: note: Null pointer addition golly-3.3-src/gollybase/qlifealgo.cpp:52:31: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:60:17: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:61:11: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:79:8: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:93:8: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:108:8: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:230:37: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:344:41: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:351:41: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:352:41: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:393:41: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:395:41: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:396:40: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:646:18: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:662:17: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:663:28: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:667:10: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:668:20: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:694:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:695:29: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:760:30: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:767:8: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:837:8: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:903:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:904:16: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:936:18: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:980:18: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:1023:18: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:1037:23: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:1038:34: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:1051:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:1052:24: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:1069:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:1070:29: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifealgo.cpp:643:8: style: The scope of the variable 'i' can be reduced. [variableScope] golly-3.3-src/gollybase/qlifealgo.cpp:934:11: style: The scope of the variable 'j' can be reduced. [variableScope] golly-3.3-src/gollybase/qlifealgo.cpp:934:14: style: The scope of the variable 'b' can be reduced. [variableScope] golly-3.3-src/gollybase/qlifealgo.cpp:978:11: style: The scope of the variable 'j' can be reduced. [variableScope] golly-3.3-src/gollybase/qlifealgo.cpp:978:14: style: The scope of the variable 'k' can be reduced. [variableScope] golly-3.3-src/gollybase/qlifealgo.cpp:978:17: style: The scope of the variable 'b' can be reduced. [variableScope] golly-3.3-src/gollybase/qlifealgo.cpp:254:34: style:inconclusive: Function 'setMaxMemory' argument 1 names different: declaration 'm' definition 'newmemlimit'. [funcArgNamesDifferent] golly-3.3-src/gollybase/qlifealgo.h:210:34: note: Function 'setMaxMemory' argument 1 names different: declaration 'm' definition 'newmemlimit'. golly-3.3-src/gollybase/qlifealgo.cpp:254:34: note: Function 'setMaxMemory' argument 1 names different: declaration 'm' definition 'newmemlimit'. golly-3.3-src/gollybase/qlifealgo.cpp:649:18: style: Local variable 'i' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/qlifealgo.cpp:643:8: note: Shadowed declaration golly-3.3-src/gollybase/qlifealgo.cpp:649:18: note: Shadow variable golly-3.3-src/gollybase/qlifealgo.cpp:659:18: style: Local variable 'i' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/qlifealgo.cpp:643:8: note: Shadowed declaration golly-3.3-src/gollybase/qlifealgo.cpp:659:18: note: Shadow variable golly-3.3-src/gollybase/qlifealgo.cpp:165:15: warning: Either the condition 'max>500000000' is redundant or there is signed integer overflow for expression '8*max'. [integerOverflowCond] golly-3.3-src/gollybase/qlifealgo.cpp:162:12: note: Assuming that condition 'max>500000000' is not redundant golly-3.3-src/gollybase/qlifealgo.cpp:165:15: note: Integer overflow golly-3.3-src/gollybase/qlifealgo.cpp:165:21: warning: Either the condition 'max>500000000' is redundant or there is signed integer overflow for expression '8*max-121'. [integerOverflowCond] golly-3.3-src/gollybase/qlifealgo.cpp:162:12: note: Assuming that condition 'max>500000000' is not redundant golly-3.3-src/gollybase/qlifealgo.cpp:165:21: note: Integer overflow golly-3.3-src/gollybase/ltlalgo.cpp:36:10: warning: Member variable 'ltlalgo::canonrule' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/ltlalgo.cpp:36:10: warning: Member variable 'ltlalgo::ccht' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/ltlalgo.cpp:36:10: warning: Member variable 'ltlalgo::halfccwd' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/ltlalgo.cpp:36:10: warning: Member variable 'ltlalgo::nrows' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/ltlalgo.cpp:36:10: warning: Member variable 'ltlalgo::ncols' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/ltlalgo.cpp:36:10: warning: Member variable 'ltlalgo::rangec' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/ltlalgo.cpp:36:10: warning: Member variable 'ltlalgo::totalistic' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/ltlalgo.cpp:36:10: warning: Member variable 'ltlalgo::minS' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/ltlalgo.cpp:36:10: warning: Member variable 'ltlalgo::maxS' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/ltlalgo.cpp:36:10: warning: Member variable 'ltlalgo::minB' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/ltlalgo.cpp:36:10: warning: Member variable 'ltlalgo::maxB' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/ltlalgo.cpp:36:10: warning: Member variable 'ltlalgo::topology' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gollybase/ltlalgo.h:93:9: style:inconclusive: Technically the member function 'ltlalgo::getcount' can be const. [functionConst] golly-3.3-src/gollybase/ltlalgo.cpp:1507:14: note: Technically the member function 'ltlalgo::getcount' can be const. golly-3.3-src/gollybase/ltlalgo.h:93:9: note: Technically the member function 'ltlalgo::getcount' can be const. golly-3.3-src/gollybase/ltlalgo.cpp:319:39: style: Condition 'newstate>0' is always true [knownConditionTrueFalse] golly-3.3-src/gollybase/ltlalgo.cpp:319:22: note: Assuming that condition 'oldstate==0' is not redundant golly-3.3-src/gollybase/ltlalgo.cpp:316:18: note: Assuming that condition 'newstate!=oldstate' is not redundant golly-3.3-src/gollybase/ltlalgo.cpp:319:39: note: Condition 'newstate>0' is always true golly-3.3-src/gollybase/ltlalgo.cpp:107:27: warning: Either the condition 'outergrid1==NULL' is redundant or there is pointer arithmetic with NULL pointer. [nullPointerArithmeticRedundantCheck] golly-3.3-src/gollybase/ltlalgo.cpp:105:20: note: Assuming that condition 'outergrid1==NULL' is not redundant golly-3.3-src/gollybase/ltlalgo.cpp:107:27: note: Null pointer addition golly-3.3-src/gollybase/ltlalgo.cpp:114:31: warning: Either the condition 'outergrid2==NULL' is redundant or there is pointer arithmetic with NULL pointer. [nullPointerArithmeticRedundantCheck] golly-3.3-src/gollybase/ltlalgo.cpp:112:24: note: Assuming that condition 'outergrid2==NULL' is not redundant golly-3.3-src/gollybase/ltlalgo.cpp:114:31: note: Null pointer addition golly-3.3-src/gollybase/ltlalgo.cpp:69:21: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ltlalgo.cpp:77:25: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ltlalgo.cpp:104:18: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ltlalgo.cpp:111:22: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ltlalgo.cpp:197:30: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ltlalgo.cpp:198:30: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ltlalgo.cpp:701:30: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ltlalgo.cpp:748:20: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ltlalgo.cpp:1143:30: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ltlalgo.cpp:1190:20: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ltlalgo.cpp:2282:13: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ltlalgo.cpp:2372:26: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ltlalgo.cpp:1170:13: style: Redundant initialization for 'prevptr'. The initialized value is overwritten before it is read. [redundantInitialization] golly-3.3-src/gollybase/ltlalgo.cpp:1120:18: note: prevptr is initialized golly-3.3-src/gollybase/ltlalgo.cpp:1170:13: note: prevptr is overwritten golly-3.3-src/gollybase/ltlalgo.cpp:970:9: style: The scope of the variable 'rowcount' can be reduced. [variableScope] golly-3.3-src/gollybase/ltlalgo.cpp:461:28: style: Local variable 'nextcell' shadows outer function [shadowFunction] golly-3.3-src/gollybase/ltlalgo.h:20:17: note: Shadowed declaration golly-3.3-src/gollybase/ltlalgo.cpp:461:28: note: Shadow variable golly-3.3-src/gollybase/ltlalgo.cpp:473:28: style: Local variable 'nextcell' shadows outer function [shadowFunction] golly-3.3-src/gollybase/ltlalgo.h:20:17: note: Shadowed declaration golly-3.3-src/gollybase/ltlalgo.cpp:473:28: note: Shadow variable golly-3.3-src/gollybase/ltlalgo.cpp:482:28: style: Local variable 'nextcell' shadows outer function [shadowFunction] golly-3.3-src/gollybase/ltlalgo.h:20:17: note: Shadowed declaration golly-3.3-src/gollybase/ltlalgo.cpp:482:28: note: Shadow variable golly-3.3-src/gollybase/ltlalgo.cpp:497:28: style: Local variable 'nextcell' shadows outer function [shadowFunction] golly-3.3-src/gollybase/ltlalgo.h:20:17: note: Shadowed declaration golly-3.3-src/gollybase/ltlalgo.cpp:497:28: note: Shadow variable golly-3.3-src/gollybase/ltlalgo.cpp:970:18: style: Variable 'rowcount' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gollybase/qlifealgo.h:252:8: style:inconclusive: Technically the member function 'qlifealgo::gethbitsfromleaves' can be const. [functionConst] golly-3.3-src/gollybase/qlifedraw.cpp:724:16: note: Technically the member function 'qlifealgo::gethbitsfromleaves' can be const. golly-3.3-src/gollybase/qlifealgo.h:252:8: note: Technically the member function 'qlifealgo::gethbitsfromleaves' can be const. golly-3.3-src/gollybase/qlifealgo.h:253:8: style:inconclusive: Technically the member function 'qlifealgo::getvbitsfromleaves' can be const. [functionConst] golly-3.3-src/gollybase/qlifedraw.cpp:746:16: note: Technically the member function 'qlifealgo::getvbitsfromleaves' can be const. golly-3.3-src/gollybase/qlifealgo.h:253:8: note: Technically the member function 'qlifealgo::getvbitsfromleaves' can be const. golly-3.3-src/gollybase/qlifedraw.cpp:854:15: style: Condition 'bitval>0' is always false [knownConditionTrueFalse] golly-3.3-src/gollybase/qlifedraw.cpp:798:18: note: Assuming that condition 'bitval>0' is not redundant golly-3.3-src/gollybase/qlifedraw.cpp:854:15: note: Condition 'bitval>0' is always false golly-3.3-src/gollybase/qlifedraw.cpp:62:30: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifedraw.cpp:131:26: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifedraw.cpp:256:38: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifedraw.cpp:287:20: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifedraw.cpp:295:20: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifedraw.cpp:330:20: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifedraw.cpp:351:20: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifedraw.cpp:377:20: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifedraw.cpp:658:31: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifedraw.cpp:662:34: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifedraw.cpp:691:31: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifedraw.cpp:695:35: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifedraw.cpp:719:31: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifedraw.cpp:730:15: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifedraw.cpp:752:15: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/qlifedraw.cpp:91:11: style: The scope of the variable 'xinc' can be reduced. [variableScope] golly-3.3-src/gollybase/qlifedraw.cpp:91:19: style: The scope of the variable 'yinc' can be reduced. [variableScope] golly-3.3-src/gollybase/qlifedraw.cpp:195:8: style: The scope of the variable 'i' can be reduced. [variableScope] golly-3.3-src/gollybase/qlifedraw.cpp:227:11: style: The scope of the variable 'xxinc' can be reduced. [variableScope] golly-3.3-src/gollybase/qlifedraw.cpp:228:11: style: The scope of the variable 'yyinc' can be reduced. [variableScope] golly-3.3-src/gollybase/qlifedraw.cpp:211:19: portability: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS] golly-3.3-src/gollybase/qlifedraw.cpp:450:32: style:inconclusive: Function 'draw' argument 1 names different: declaration 'view' definition 'viewarg'. [funcArgNamesDifferent] golly-3.3-src/gollybase/qlifealgo.h:217:32: note: Function 'draw' argument 1 names different: declaration 'view' definition 'viewarg'. golly-3.3-src/gollybase/qlifedraw.cpp:450:32: note: Function 'draw' argument 1 names different: declaration 'view' definition 'viewarg'. golly-3.3-src/gollybase/qlifedraw.cpp:450:53: style:inconclusive: Function 'draw' argument 2 names different: declaration 'renderer' definition 'renderarg'. [funcArgNamesDifferent] golly-3.3-src/gollybase/qlifealgo.h:217:50: note: Function 'draw' argument 2 names different: declaration 'renderer' definition 'renderarg'. golly-3.3-src/gollybase/qlifedraw.cpp:450:53: note: Function 'draw' argument 2 names different: declaration 'renderer' definition 'renderarg'. golly-3.3-src/gollybase/qlifedraw.cpp:746:55: style:inconclusive: Function 'getvbitsfromleaves' argument 1 names different: declaration 'v' definition 'vec'. [funcArgNamesDifferent] golly-3.3-src/gollybase/qlifealgo.h:253:47: note: Function 'getvbitsfromleaves' argument 1 names different: declaration 'v' definition 'vec'. golly-3.3-src/gollybase/qlifedraw.cpp:746:55: note: Function 'getvbitsfromleaves' argument 1 names different: declaration 'v' definition 'vec'. golly-3.3-src/gollybase/qlifedraw.cpp:770:35: style:inconclusive: Function 'findedges' argument 1 names different: declaration 't' definition 'ptop'. [funcArgNamesDifferent] golly-3.3-src/gollybase/qlifealgo.h:220:35: note: Function 'findedges' argument 1 names different: declaration 't' definition 'ptop'. golly-3.3-src/gollybase/qlifedraw.cpp:770:35: note: Function 'findedges' argument 1 names different: declaration 't' definition 'ptop'. golly-3.3-src/gollybase/qlifedraw.cpp:770:49: style:inconclusive: Function 'findedges' argument 2 names different: declaration 'l' definition 'pleft'. [funcArgNamesDifferent] golly-3.3-src/gollybase/qlifealgo.h:220:46: note: Function 'findedges' argument 2 names different: declaration 'l' definition 'pleft'. golly-3.3-src/gollybase/qlifedraw.cpp:770:49: note: Function 'findedges' argument 2 names different: declaration 'l' definition 'pleft'. golly-3.3-src/gollybase/qlifedraw.cpp:770:64: style:inconclusive: Function 'findedges' argument 3 names different: declaration 'b' definition 'pbottom'. [funcArgNamesDifferent] golly-3.3-src/gollybase/qlifealgo.h:220:57: note: Function 'findedges' argument 3 names different: declaration 'b' definition 'pbottom'. golly-3.3-src/gollybase/qlifedraw.cpp:770:64: note: Function 'findedges' argument 3 names different: declaration 'b' definition 'pbottom'. golly-3.3-src/gollybase/qlifedraw.cpp:770:81: style:inconclusive: Function 'findedges' argument 4 names different: declaration 'r' definition 'pright'. [funcArgNamesDifferent] golly-3.3-src/gollybase/qlifealgo.h:220:68: note: Function 'findedges' argument 4 names different: declaration 'r' definition 'pright'. golly-3.3-src/gollybase/qlifedraw.cpp:770:81: note: Function 'findedges' argument 4 names different: declaration 'r' definition 'pright'. golly-3.3-src/gollybase/qlifedraw.cpp:145:43: style: Local variable 'p' shadows outer argument [shadowArgument] golly-3.3-src/gollybase/qlifedraw.cpp:89:38: note: Shadowed declaration golly-3.3-src/gollybase/qlifedraw.cpp:145:43: note: Shadow variable golly-3.3-src/gollybase/qlifedraw.cpp:738:9: style: Local variable 'v' shadows outer argument [shadowArgument] golly-3.3-src/gollybase/qlifedraw.cpp:724:55: note: Shadowed declaration golly-3.3-src/gollybase/qlifedraw.cpp:738:9: note: Shadow variable golly-3.3-src/gollybase/qlifedraw.cpp:1006:8: style: Local variable 'mag' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/qlifealgo.h:273:38: note: Shadowed declaration golly-3.3-src/gollybase/qlifedraw.cpp:1006:8: note: Shadow variable golly-3.3-src/gollybase/qlifedraw.cpp:763:21: error: Signed integer overflow for expression '0xf<<(4*j)'. [integerOverflow] golly-3.3-src/gollybase/qlifedraw.cpp:761:20: note: Assuming that condition 'j<8' is not redundant golly-3.3-src/gollybase/qlifedraw.cpp:763:21: note: Integer overflow golly-3.3-src/gollybase/readpattern.cpp:833:15: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/readpattern.cpp:376:9: style: Variable 'n' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gollybase/readpattern.cpp:376:14: style: Variable 'x' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gollybase/ruleloaderalgo.cpp:189:5: warning: Class 'ruleloaderalgo' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] golly-3.3-src/gollybase/ruleloaderalgo.cpp:189:5: warning: Class 'ruleloaderalgo' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] golly-3.3-src/gollybase/ruletable_algo.h:19:18: style: The function 'slowcalc' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/ghashbase.h:64:18: note: Virtual function in base class golly-3.3-src/gollybase/ruletable_algo.h:19:18: note: Function in derived class golly-3.3-src/gollybase/ruletable_algo.h:21:24: style: The function 'setrule' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/ghashbase.h:82:24: note: Virtual function in base class golly-3.3-src/gollybase/ruletable_algo.h:21:24: note: Function in derived class golly-3.3-src/gollybase/ruletable_algo.h:22:24: style: The function 'getrule' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/ghashbase.h:83:24: note: Virtual function in base class golly-3.3-src/gollybase/ruletable_algo.h:22:24: note: Function in derived class golly-3.3-src/gollybase/ruletable_algo.h:23:24: style: The function 'DefaultRule' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:88:24: note: Virtual function in base class golly-3.3-src/gollybase/ruletable_algo.h:23:24: note: Function in derived class golly-3.3-src/gollybase/ruletable_algo.h:24:16: style: The function 'NumCellStates' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:90:16: note: Virtual function in base class golly-3.3-src/gollybase/ruletable_algo.h:24:16: note: Function in derived class golly-3.3-src/gollybase/ruletreealgo.h:14:18: style: The function 'slowcalc' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/ghashbase.h:64:18: note: Virtual function in base class golly-3.3-src/gollybase/ruletreealgo.h:14:18: note: Function in derived class golly-3.3-src/gollybase/ruletreealgo.h:16:24: style: The function 'setrule' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/ghashbase.h:82:24: note: Virtual function in base class golly-3.3-src/gollybase/ruletreealgo.h:16:24: note: Function in derived class golly-3.3-src/gollybase/ruletreealgo.h:17:24: style: The function 'getrule' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/ghashbase.h:83:24: note: Virtual function in base class golly-3.3-src/gollybase/ruletreealgo.h:17:24: note: Function in derived class golly-3.3-src/gollybase/ruletreealgo.h:18:24: style: The function 'DefaultRule' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:88:24: note: Virtual function in base class golly-3.3-src/gollybase/ruletreealgo.h:18:24: note: Function in derived class golly-3.3-src/gollybase/ruletreealgo.h:19:16: style: The function 'NumCellStates' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:90:16: note: Virtual function in base class golly-3.3-src/gollybase/ruletreealgo.h:19:16: note: Function in derived class golly-3.3-src/gollybase/ruleloaderalgo.h:18:19: style: The function 'slowcalc' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/ghashbase.h:64:18: note: Virtual function in base class golly-3.3-src/gollybase/ruleloaderalgo.h:18:19: note: Function in derived class golly-3.3-src/gollybase/ruleloaderalgo.h:20:25: style: The function 'setrule' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/ghashbase.h:82:24: note: Virtual function in base class golly-3.3-src/gollybase/ruleloaderalgo.h:20:25: note: Function in derived class golly-3.3-src/gollybase/ruleloaderalgo.h:21:25: style: The function 'getrule' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/ghashbase.h:83:24: note: Virtual function in base class golly-3.3-src/gollybase/ruleloaderalgo.h:21:25: note: Function in derived class golly-3.3-src/gollybase/ruleloaderalgo.h:22:25: style: The function 'DefaultRule' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:88:24: note: Virtual function in base class golly-3.3-src/gollybase/ruleloaderalgo.h:22:25: note: Function in derived class golly-3.3-src/gollybase/ruleloaderalgo.h:23:17: style: The function 'NumCellStates' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/lifealgo.h:90:16: note: Virtual function in base class golly-3.3-src/gollybase/ruleloaderalgo.h:23:17: note: Function in derived class golly-3.3-src/gollybase/ruletreealgo.h:23:9: performance:inconclusive: Technically the member function 'ruletreealgo::IsDefaultRule' can be static (but you may consider moving to unnamed namespace). [functionStatic] golly-3.3-src/gollybase/ruletreealgo.cpp:17:20: note: Technically the member function 'ruletreealgo::IsDefaultRule' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gollybase/ruletreealgo.h:23:9: note: Technically the member function 'ruletreealgo::IsDefaultRule' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gollybase/ruletreealgo.cpp:194:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ruletreealgo.cpp:195:16: style: C-style pointer casting [cstyleCast] golly-3.3-src/gollybase/ruletreealgo.cpp:83:12: style: Variable 'f' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gollybase/ruletable_algo.cpp:278:13: warning: %d in format string (no. 1) requires 'int *' but the argument type is 'unsigned int *'. [invalidScanfArgType_int] golly-3.3-src/gollybase/ruletable_algo.cpp:195:45: style:inconclusive: Function 'LoadRuleTable' argument 1 names different: declaration 'filename' definition 'rule'. [funcArgNamesDifferent] golly-3.3-src/gollybase/ruletable_algo.h:33:42: note: Function 'LoadRuleTable' argument 1 names different: declaration 'filename' definition 'rule'. golly-3.3-src/gollybase/ruletable_algo.cpp:195:45: note: Function 'LoadRuleTable' argument 1 names different: declaration 'filename' definition 'rule'. golly-3.3-src/gollybase/ruletable_algo.cpp:244:18: style: Local variable 'neighborhood' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/ruletable_algo.h:42:72: note: Shadowed declaration golly-3.3-src/gollybase/ruletable_algo.cpp:244:18: note: Shadow variable golly-3.3-src/gollybase/ruletable_algo.cpp:245:17: style: Local variable 'n_states' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/ruletable_algo.h:41:17: note: Shadowed declaration golly-3.3-src/gollybase/ruletable_algo.cpp:245:17: note: Shadow variable golly-3.3-src/gollybase/ruletable_algo.cpp:397:19: style: Local variable 'output' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/ruletable_algo.h:50:23: note: Shadowed declaration golly-3.3-src/gollybase/ruletable_algo.cpp:397:19: note: Shadow variable golly-3.3-src/gollybase/ruletable_algo.cpp:449:19: style: Local variable 'output' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/ruletable_algo.h:50:23: note: Shadowed declaration golly-3.3-src/gollybase/ruletable_algo.cpp:449:19: note: Shadow variable golly-3.3-src/gollybase/ruletable_algo.cpp:615:13: style: Local variable 'output' shadows outer variable [shadowVariable] golly-3.3-src/gollybase/ruletable_algo.h:50:23: note: Shadowed declaration golly-3.3-src/gollybase/ruletable_algo.cpp:615:13: note: Shadow variable golly-3.3-src/gollybase/ruletable_algo.cpp:68:10: performance: Passing the result of c_str() to a function that takes std::string as argument no. 1 is slow and redundant. [stlcstrParam] golly-3.3-src/gollybase/util.cpp:19:17: style: The function 'fatal' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/util.h:42:17: note: Virtual function in base class golly-3.3-src/gollybase/util.cpp:19:17: note: Function in derived class golly-3.3-src/gollybase/util.cpp:23:17: style: The function 'warning' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/util.h:43:17: note: Virtual function in base class golly-3.3-src/gollybase/util.cpp:23:17: note: Function in derived class golly-3.3-src/gollybase/util.cpp:26:17: style: The function 'status' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/util.h:44:17: note: Virtual function in base class golly-3.3-src/gollybase/util.cpp:26:17: note: Function in derived class golly-3.3-src/gollybase/util.cpp:29:17: style: The function 'beginprogress' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/util.h:45:17: note: Virtual function in base class golly-3.3-src/gollybase/util.cpp:29:17: note: Function in derived class golly-3.3-src/gollybase/util.cpp:32:17: style: The function 'abortprogress' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/util.h:46:17: note: Virtual function in base class golly-3.3-src/gollybase/util.cpp:32:17: note: Function in derived class golly-3.3-src/gollybase/util.cpp:35:17: style: The function 'endprogress' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/util.h:47:17: note: Virtual function in base class golly-3.3-src/gollybase/util.cpp:35:17: note: Function in derived class golly-3.3-src/gollybase/util.cpp:38:24: style: The function 'getuserrules' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/util.h:48:24: note: Virtual function in base class golly-3.3-src/gollybase/util.cpp:38:24: note: Function in derived class golly-3.3-src/gollybase/util.cpp:41:24: style: The function 'getrulesdir' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] golly-3.3-src/gollybase/util.h:49:24: note: Virtual function in base class golly-3.3-src/gollybase/util.cpp:41:24: note: Function in derived class golly-3.3-src/gollybase/util.cpp:49:46: style:inconclusive: Function 'seterrorhandler' argument 1 names different: declaration 'obj' definition 'o'. [funcArgNamesDifferent] golly-3.3-src/gollybase/util.h:50:44: note: Function 'seterrorhandler' argument 1 names different: declaration 'obj' definition 'o'. golly-3.3-src/gollybase/util.cpp:49:46: note: Function 'seterrorhandler' argument 1 names different: declaration 'obj' definition 'o'. golly-3.3-src/gollybase/util.cpp:222:61: style:inconclusive: Function 'reportStep' argument 3 names different: declaration 'genval' definition 'newGen'. [funcArgNamesDifferent] golly-3.3-src/gollybase/util.h:86:43: note: Function 'reportStep' argument 3 names different: declaration 'genval' definition 'newGen'. golly-3.3-src/gollybase/util.cpp:222:61: note: Function 'reportStep' argument 3 names different: declaration 'genval' definition 'newGen'. golly-3.3-src/gollybase/ruletable_algo.cpp:443:111: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/gollybase/ruletable_algo.cpp:612:8: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/gollybase/ruletable_algo.cpp:666:94: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/gollybase/viewport.cpp:29:25: style:inconclusive: Function 'zoom' argument 1 names different: declaration 'x' definition 'xx'. [funcArgNamesDifferent] golly-3.3-src/gollybase/viewport.h:27:18: note: Function 'zoom' argument 1 names different: declaration 'x' definition 'xx'. golly-3.3-src/gollybase/viewport.cpp:29:25: note: Function 'zoom' argument 1 names different: declaration 'x' definition 'xx'. golly-3.3-src/gollybase/viewport.cpp:29:33: style:inconclusive: Function 'zoom' argument 2 names different: declaration 'y' definition 'yy'. [funcArgNamesDifferent] golly-3.3-src/gollybase/viewport.h:27:25: note: Function 'zoom' argument 2 names different: declaration 'y' definition 'yy'. golly-3.3-src/gollybase/viewport.cpp:29:33: note: Function 'zoom' argument 2 names different: declaration 'y' definition 'yy'. golly-3.3-src/gollybase/viewport.cpp:59:27: style:inconclusive: Function 'unzoom' argument 1 names different: declaration 'x' definition 'xx'. [funcArgNamesDifferent] golly-3.3-src/gollybase/viewport.h:29:20: note: Function 'unzoom' argument 1 names different: declaration 'x' definition 'xx'. golly-3.3-src/gollybase/viewport.cpp:59:27: note: Function 'unzoom' argument 1 names different: declaration 'x' definition 'xx'. golly-3.3-src/gollybase/viewport.cpp:59:35: style:inconclusive: Function 'unzoom' argument 2 names different: declaration 'y' definition 'yy'. [funcArgNamesDifferent] golly-3.3-src/gollybase/viewport.h:29:27: note: Function 'unzoom' argument 2 names different: declaration 'y' definition 'yy'. golly-3.3-src/gollybase/viewport.cpp:59:35: note: Function 'unzoom' argument 2 names different: declaration 'y' definition 'yy'. golly-3.3-src/gollybase/viewport.cpp:207:45: style:inconclusive: Function 'setpositionmag' argument 1 names different: declaration 'xlo' definition 'xmin'. [funcArgNamesDifferent] golly-3.3-src/gollybase/viewport.h:39:38: note: Function 'setpositionmag' argument 1 names different: declaration 'xlo' definition 'xmin'. golly-3.3-src/gollybase/viewport.cpp:207:45: note: Function 'setpositionmag' argument 1 names different: declaration 'xlo' definition 'xmin'. golly-3.3-src/gollybase/viewport.cpp:207:65: style:inconclusive: Function 'setpositionmag' argument 2 names different: declaration 'xhi' definition 'xmax'. [funcArgNamesDifferent] golly-3.3-src/gollybase/viewport.h:39:57: note: Function 'setpositionmag' argument 2 names different: declaration 'xhi' definition 'xmax'. golly-3.3-src/gollybase/viewport.cpp:207:65: note: Function 'setpositionmag' argument 2 names different: declaration 'xhi' definition 'xmax'. golly-3.3-src/gollybase/viewport.cpp:208:45: style:inconclusive: Function 'setpositionmag' argument 3 names different: declaration 'ylo' definition 'ymin'. [funcArgNamesDifferent] golly-3.3-src/gollybase/viewport.h:40:38: note: Function 'setpositionmag' argument 3 names different: declaration 'ylo' definition 'ymin'. golly-3.3-src/gollybase/viewport.cpp:208:45: note: Function 'setpositionmag' argument 3 names different: declaration 'ylo' definition 'ymin'. golly-3.3-src/gollybase/viewport.cpp:208:65: style:inconclusive: Function 'setpositionmag' argument 4 names different: declaration 'yhi' definition 'ymax'. [funcArgNamesDifferent] golly-3.3-src/gollybase/viewport.h:40:57: note: Function 'setpositionmag' argument 4 names different: declaration 'yhi' definition 'ymax'. golly-3.3-src/gollybase/viewport.cpp:208:65: note: Function 'setpositionmag' argument 4 names different: declaration 'yhi' definition 'ymax'. golly-3.3-src/gollybase/viewport.cpp:221:38: style:inconclusive: Function 'contains' argument 1 names different: declaration 'x' definition 'xarg'. [funcArgNamesDifferent] golly-3.3-src/gollybase/viewport.h:45:31: note: Function 'contains' argument 1 names different: declaration 'x' definition 'xarg'. golly-3.3-src/gollybase/viewport.cpp:221:38: note: Function 'contains' argument 1 names different: declaration 'x' definition 'xarg'. golly-3.3-src/gollybase/viewport.cpp:221:58: style:inconclusive: Function 'contains' argument 2 names different: declaration 'y' definition 'yarg'. [funcArgNamesDifferent] golly-3.3-src/gollybase/viewport.h:45:48: note: Function 'contains' argument 2 names different: declaration 'y' definition 'yarg'. golly-3.3-src/gollybase/viewport.cpp:221:58: note: Function 'contains' argument 2 names different: declaration 'y' definition 'yarg'. golly-3.3-src/gollybase/writepattern.cpp:114:13: style: Variable '*p' is reassigned a value before the old one has been used. [redundantAssignment] golly-3.3-src/gollybase/writepattern.cpp:112:13: note: *p is assigned golly-3.3-src/gollybase/writepattern.cpp:114:13: note: *p is overwritten golly-3.3-src/gollybase/writepattern.cpp:135:21: style: Variable 'laststate' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gui-android/Golly/app/src/main/jni/jnicalls.cpp:246:9: style: Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 'setitimer' instead. [prohibitedusleepCalled] golly-3.3-src/gui-android/Golly/app/src/main/jni/jnicalls.cpp:2487:31: style:inconclusive: Function 'AndroidYesNo' argument 1 names different: declaration 'msg' definition 'query'. [funcArgNamesDifferent] golly-3.3-src/gui-android/Golly/app/src/main/jni/jnicalls.h:52:31: note: Function 'AndroidYesNo' argument 1 names different: declaration 'msg' definition 'query'. golly-3.3-src/gui-android/Golly/app/src/main/jni/jnicalls.cpp:2487:31: note: Function 'AndroidYesNo' argument 1 names different: declaration 'msg' definition 'query'. golly-3.3-src/gui-android/Golly/app/src/main/jni/jnicalls.cpp:1320:17: performance: Inefficient usage of string::find() in condition; string::starts_with() could be faster. [stlIfStrFind] golly-3.3-src/gui-android/Golly/app/src/main/jni/jnicalls.cpp:1324:21: performance: Inefficient usage of string::find() in condition; string::starts_with() could be faster. [stlIfStrFind] golly-3.3-src/gui-android/Golly/app/src/main/jni/jnicalls.cpp:1334:13: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/gui-common/MiniZip/unzip.c:415:25: style: Condition 'unz_copyright[0]!=' '' is always false [knownConditionTrueFalse] golly-3.3-src/gui-common/MiniZip/unzip.c:399:24: style: Parameter 'pzlib_filefunc_def' can be declared as pointer to const [constParameter] golly-3.3-src/gui-common/MiniZip/unzip.c:712:22: style: Variable 'lSeek' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gui-common/MiniZip/unzip.c:719:14: style: Variable 'lSeek' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gui-common/MiniZip/unzip.c:722:14: style: Variable 'lSeek' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gui-common/MiniZip/unzip.c:1104:12: style: Variable 'err' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gui-common/MiniZip/zip.c:611:13: error: Memory leak: zi [memleak] golly-3.3-src/gui-common/MiniZip/zip.c:1047:12: style: Variable 'err' is reassigned a value before the old one has been used. [redundantAssignment] golly-3.3-src/gui-common/MiniZip/zip.c:1042:21: note: err is assigned golly-3.3-src/gui-common/MiniZip/zip.c:1047:12: note: err is overwritten golly-3.3-src/gui-common/MiniZip/zip.c:501:24: style: Parameter 'pzlib_filefunc_def' can be declared as pointer to const [constParameter] golly-3.3-src/gui-common/control.cpp:145:16: style: The scope of the variable 'himantissa' can be reduced. [variableScope] golly-3.3-src/gui-common/algos.cpp:859:11: warning: Member variable 'AlgoData::canhash' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/algos.cpp:859:11: warning: Member variable 'AlgoData::statusrgb' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/algos.cpp:859:11: warning: Member variable 'AlgoData::gradient' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/algos.cpp:859:11: warning: Member variable 'AlgoData::fromrgb' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/algos.cpp:859:11: warning: Member variable 'AlgoData::torgb' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/algos.cpp:859:11: warning: Member variable 'AlgoData::algor' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/algos.cpp:859:11: warning: Member variable 'AlgoData::algog' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/algos.cpp:859:11: warning: Member variable 'AlgoData::algob' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/algos.cpp:589:13: warning: %x in format string (no. 1) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int] golly-3.3-src/gui-common/algos.cpp:593:13: warning: %x in format string (no. 1) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int] golly-3.3-src/gui-common/algos.cpp:593:13: warning: %x in format string (no. 2) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int] golly-3.3-src/gui-common/algos.cpp:593:13: warning: %x in format string (no. 3) requires 'unsigned int *' but the argument type is 'signed int *'. [invalidScanfArgType_int] golly-3.3-src/gui-common/algos.cpp:601:27: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/algos.cpp:628:28: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/algos.cpp:634:32: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/algos.cpp:638:33: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/algos.cpp:651:36: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/algos.cpp:655:37: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/algos.cpp:673:24: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/algos.cpp:677:25: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/algos.cpp:716:24: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/algos.cpp:720:25: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/algos.cpp:795:28: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/algos.cpp:671:52: style: Parameter 'indata' can be declared as pointer to const [constParameter] golly-3.3-src/gui-common/algos.cpp:708:51: style: Parameter 'indata' can be declared as pointer to const [constParameter] golly-3.3-src/gui-common/file.cpp:299:1: error: Found a exit path from function with non-void return type that has missing return statement [missingReturn] golly-3.3-src/gui-common/file.cpp:324:1: error: Found a exit path from function with non-void return type that has missing return statement [missingReturn] golly-3.3-src/gui-common/file.cpp:1112:1: error: Found a exit path from function with non-void return type that has missing return statement [missingReturn] golly-3.3-src/gui-common/file.cpp:459:27: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/file.cpp:575:21: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/file.cpp:631:10: style: The scope of the variable 'dirseen' can be reduced. [variableScope] golly-3.3-src/gui-common/file.cpp:633:17: style: The scope of the variable 'firstdir' can be reduced. [variableScope] golly-3.3-src/gui-common/file.cpp:634:17: style: The scope of the variable 'lastpattern' can be reduced. [variableScope] golly-3.3-src/gui-common/file.cpp:635:17: style: The scope of the variable 'lastscript' can be reduced. [variableScope] golly-3.3-src/gui-common/file.cpp:636:9: style: The scope of the variable 'patternseps' can be reduced. [variableScope] golly-3.3-src/gui-common/file.cpp:637:9: style: The scope of the variable 'scriptseps' can be reduced. [variableScope] golly-3.3-src/gui-common/file.cpp:638:9: style: The scope of the variable 'patternfiles' can be reduced. [variableScope] golly-3.3-src/gui-common/file.cpp:639:9: style: The scope of the variable 'scriptfiles' can be reduced. [variableScope] golly-3.3-src/gui-common/file.cpp:640:9: style: The scope of the variable 'textfiles' can be reduced. [variableScope] golly-3.3-src/gui-common/file.cpp:248:9: performance: Inefficient usage of string::find() in condition; string::starts_with() could be faster. [stlIfStrFind] golly-3.3-src/gui-common/file.cpp:684:17: performance: Inefficient usage of string::find() in condition; string::starts_with() could be faster. [stlIfStrFind] golly-3.3-src/gui-common/file.cpp:861:13: performance: Inefficient usage of string::find() in condition; string::starts_with() could be faster. [stlIfStrFind] golly-3.3-src/gui-common/file.cpp:1024:9: performance: Inefficient usage of string::find() in condition; string::starts_with() could be faster. [stlIfStrFind] golly-3.3-src/gui-common/file.cpp:1040:9: performance: Inefficient usage of string::find() in condition; string::starts_with() could be faster. [stlIfStrFind] golly-3.3-src/gui-common/file.cpp:1041:9: performance: Inefficient usage of string::find() in condition; string::starts_with() could be faster. [stlIfStrFind] golly-3.3-src/gui-common/file.cpp:1042:9: performance: Inefficient usage of string::find() in condition; string::starts_with() could be faster. [stlIfStrFind] golly-3.3-src/gui-common/file.cpp:268:13: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/gui-common/layer.cpp:1873:13: warning: Class 'Layer' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s). [noCopyConstructor] golly-3.3-src/gui-common/layer.cpp:1873:13: warning: Class 'Layer' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s). [noOperatorEq] golly-3.3-src/gui-common/layer.cpp:401:28: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/layer.cpp:406:36: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/layer.cpp:414:41: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/layer.cpp:445:31: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/layer.cpp:1187:35: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/layer.cpp:1275:29: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/layer.cpp:1290:34: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/layer.cpp:1924:27: style: Variable 'startname' is reassigned a value before the old one has been used. [redundantAssignment] golly-3.3-src/gui-common/layer.cpp:1920:23: note: startname is assigned golly-3.3-src/gui-common/layer.cpp:1924:27: note: startname is overwritten golly-3.3-src/gui-common/render.cpp:536:71: style:inconclusive: Function 'pixblit' argument 5 names different: declaration 'pm' definition 'pmdata'. [funcArgNamesDifferent] golly-3.3-src/gui-common/render.cpp:527:69: note: Function 'pixblit' argument 5 names different: declaration 'pm' definition 'pmdata'. golly-3.3-src/gui-common/render.cpp:536:71: note: Function 'pixblit' argument 5 names different: declaration 'pm' definition 'pmdata'. golly-3.3-src/gui-common/render.cpp:693:23: style:inconclusive: Function 'InitPaste' argument 1 names different: declaration 'pastelayer' definition 'player'. [funcArgNamesDifferent] golly-3.3-src/gui-common/render.h:23:23: note: Function 'InitPaste' argument 1 names different: declaration 'pastelayer' definition 'player'. golly-3.3-src/gui-common/render.cpp:693:23: note: Function 'InitPaste' argument 1 names different: declaration 'pastelayer' definition 'player'. golly-3.3-src/gui-common/render.cpp:593:27: style: Parameter 'rect' can be declared as reference to const [constParameter] golly-3.3-src/gui-common/render.cpp:693:38: style: Parameter 'bbox' can be declared as reference to const [constParameter] golly-3.3-src/gui-common/render.cpp:387:31: style: Parameter 'statedata' can be declared as pointer to const [constParameter] golly-3.3-src/gui-common/render.cpp:453:40: style: Parameter 'statedata' can be declared as pointer to const [constParameter] golly-3.3-src/gui-common/select.h:24:10: style:inconclusive: Technically the member function 'Selection::Exists' can be const. [functionConst] golly-3.3-src/gui-common/select.cpp:86:17: note: Technically the member function 'Selection::Exists' can be const. golly-3.3-src/gui-common/select.h:24:10: note: Technically the member function 'Selection::Exists' can be const. golly-3.3-src/gui-common/select.h:33:10: style:inconclusive: Technically the member function 'Selection::DisplaySize' can be const. [functionConst] golly-3.3-src/gui-common/select.cpp:107:17: note: Technically the member function 'Selection::DisplaySize' can be const. golly-3.3-src/gui-common/select.h:33:10: note: Technically the member function 'Selection::DisplaySize' can be const. golly-3.3-src/gui-common/select.h:48:10: style:inconclusive: Technically the member function 'Selection::Contains' can be const. [functionConst] golly-3.3-src/gui-common/select.cpp:190:17: note: Technically the member function 'Selection::Contains' can be const. golly-3.3-src/gui-common/select.h:48:10: note: Technically the member function 'Selection::Contains' can be const. golly-3.3-src/gui-common/select.h:51:10: style:inconclusive: Technically the member function 'Selection::Outside' can be const. [functionConst] golly-3.3-src/gui-common/select.cpp:197:17: note: Technically the member function 'Selection::Outside' can be const. golly-3.3-src/gui-common/select.h:51:10: note: Technically the member function 'Selection::Outside' can be const. golly-3.3-src/gui-common/select.h:98:10: style:inconclusive: Technically the member function 'Selection::CanPaste' can be const. [functionConst] golly-3.3-src/gui-common/select.cpp:1363:17: note: Technically the member function 'Selection::CanPaste' can be const. golly-3.3-src/gui-common/select.h:98:10: note: Technically the member function 'Selection::CanPaste' can be const. golly-3.3-src/gui-common/select.h:115:10: performance:inconclusive: Technically the member function 'Selection::EmptyUniverse' can be static (but you may consider moving to unnamed namespace). [functionStatic] golly-3.3-src/gui-common/select.cpp:877:17: note: Technically the member function 'Selection::EmptyUniverse' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gui-common/select.h:115:10: note: Technically the member function 'Selection::EmptyUniverse' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gui-common/select.h:121:10: performance:inconclusive: Technically the member function 'Selection::AddEOL' can be static (but you may consider moving to unnamed namespace). [functionStatic] golly-3.3-src/gui-common/select.cpp:1132:17: note: Technically the member function 'Selection::AddEOL' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gui-common/select.h:121:10: note: Technically the member function 'Selection::AddEOL' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gui-common/select.h:124:10: performance:inconclusive: Technically the member function 'Selection::SaveDifferences' can be static (but you may consider moving to unnamed namespace). [functionStatic] golly-3.3-src/gui-common/select.cpp:212:17: note: Technically the member function 'Selection::SaveDifferences' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gui-common/select.h:124:10: note: Technically the member function 'Selection::SaveDifferences' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gui-common/select.h:129:10: performance:inconclusive: Technically the member function 'Selection::FlipRect' can be static (but you may consider moving to unnamed namespace). [functionStatic] golly-3.3-src/gui-common/select.cpp:1474:17: note: Technically the member function 'Selection::FlipRect' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gui-common/select.h:129:10: note: Technically the member function 'Selection::FlipRect' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gui-common/select.h:135:10: performance:inconclusive: Technically the member function 'Selection::RotateRect' can be static (but you may consider moving to unnamed namespace). [functionStatic] golly-3.3-src/gui-common/select.cpp:1663:17: note: Technically the member function 'Selection::RotateRect' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gui-common/select.h:135:10: note: Technically the member function 'Selection::RotateRect' can be static (but you may consider moving to unnamed namespace). golly-3.3-src/gui-common/select.cpp:1216:15: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/select.cpp:1309:33: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/select.cpp:1237:9: style: The scope of the variable 'laststate' can be reduced. [variableScope] golly-3.3-src/gui-common/select.cpp:1483:17: style: The scope of the variable 'newx' can be reduced. [variableScope] golly-3.3-src/gui-common/select.cpp:1673:23: style: The scope of the variable 'newy' can be reduced. [variableScope] golly-3.3-src/gui-common/select.cpp:1747:23: style: The scope of the variable 'newy' can be reduced. [variableScope] golly-3.3-src/gui-common/select.cpp:62:45: style:inconclusive: Function 'operator==' argument 1 names different: declaration 'sel' definition 's'. [funcArgNamesDifferent] golly-3.3-src/gui-common/select.h:21:38: note: Function 'operator==' argument 1 names different: declaration 'sel' definition 's'. golly-3.3-src/gui-common/select.cpp:62:45: note: Function 'operator==' argument 1 names different: declaration 'sel' definition 's'. golly-3.3-src/gui-common/select.cpp:79:45: style:inconclusive: Function 'operator!=' argument 1 names different: declaration 'sel' definition 's'. [funcArgNamesDifferent] golly-3.3-src/gui-common/select.h:22:38: note: Function 'operator!=' argument 1 names different: declaration 'sel' definition 's'. golly-3.3-src/gui-common/select.cpp:79:45: note: Function 'operator!=' argument 1 names different: declaration 'sel' definition 's'. golly-3.3-src/gui-common/select.cpp:1475:30: style:inconclusive: Function 'FlipRect' argument 5 names different: declaration 'top' definition 'itop'. [funcArgNamesDifferent] golly-3.3-src/gui-common/select.h:130:23: note: Function 'FlipRect' argument 5 names different: declaration 'top' definition 'itop'. golly-3.3-src/gui-common/select.cpp:1475:30: note: Function 'FlipRect' argument 5 names different: declaration 'top' definition 'itop'. golly-3.3-src/gui-common/select.cpp:1475:40: style:inconclusive: Function 'FlipRect' argument 6 names different: declaration 'left' definition 'ileft'. [funcArgNamesDifferent] golly-3.3-src/gui-common/select.h:130:32: note: Function 'FlipRect' argument 6 names different: declaration 'left' definition 'ileft'. golly-3.3-src/gui-common/select.cpp:1475:40: note: Function 'FlipRect' argument 6 names different: declaration 'left' definition 'ileft'. golly-3.3-src/gui-common/select.cpp:1475:51: style:inconclusive: Function 'FlipRect' argument 7 names different: declaration 'bottom' definition 'ibottom'. [funcArgNamesDifferent] golly-3.3-src/gui-common/select.h:130:42: note: Function 'FlipRect' argument 7 names different: declaration 'bottom' definition 'ibottom'. golly-3.3-src/gui-common/select.cpp:1475:51: note: Function 'FlipRect' argument 7 names different: declaration 'bottom' definition 'ibottom'. golly-3.3-src/gui-common/select.cpp:1475:64: style:inconclusive: Function 'FlipRect' argument 8 names different: declaration 'right' definition 'iright'. [funcArgNamesDifferent] golly-3.3-src/gui-common/select.h:130:54: note: Function 'FlipRect' argument 8 names different: declaration 'right' definition 'iright'. golly-3.3-src/gui-common/select.cpp:1475:64: note: Function 'FlipRect' argument 8 names different: declaration 'right' definition 'iright'. golly-3.3-src/gui-common/select.cpp:153:34: style: Parameter 't' can be declared as reference to const [constParameter] golly-3.3-src/gui-common/select.cpp:153:45: style: Parameter 'l' can be declared as reference to const [constParameter] golly-3.3-src/gui-common/select.cpp:153:56: style: Parameter 'b' can be declared as reference to const [constParameter] golly-3.3-src/gui-common/select.cpp:153:67: style: Parameter 'r' can be declared as reference to const [constParameter] golly-3.3-src/gui-common/select.cpp:190:34: style: Parameter 't' can be declared as reference to const [constParameter] golly-3.3-src/gui-common/select.cpp:190:45: style: Parameter 'l' can be declared as reference to const [constParameter] golly-3.3-src/gui-common/select.cpp:190:56: style: Parameter 'b' can be declared as reference to const [constParameter] golly-3.3-src/gui-common/select.cpp:190:67: style: Parameter 'r' can be declared as reference to const [constParameter] golly-3.3-src/gui-common/select.cpp:197:33: style: Parameter 't' can be declared as reference to const [constParameter] golly-3.3-src/gui-common/select.cpp:197:44: style: Parameter 'l' can be declared as reference to const [constParameter] golly-3.3-src/gui-common/select.cpp:197:55: style: Parameter 'b' can be declared as reference to const [constParameter] golly-3.3-src/gui-common/select.cpp:197:66: style: Parameter 'r' can be declared as reference to const [constParameter] golly-3.3-src/gui-common/undo.cpp:486:11: warning: Member variable 'UndoRedo::prevmag' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/undo.cpp:486:11: warning: Member variable 'UndoRedo::prevbase' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/undo.cpp:486:11: warning: Member variable 'UndoRedo::prevexpo' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/undo.cpp:40:5: warning: Member variable 'VariableInfo::layerptr' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/undo.cpp:40:5: warning: Member variable 'VariableInfo::savemag' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/undo.cpp:40:5: warning: Member variable 'VariableInfo::savebase' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/undo.cpp:40:5: warning: Member variable 'VariableInfo::saveexpo' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/undo.cpp:256:13: warning: Member variable 'ChangeNode::olddirty' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/undo.cpp:256:13: warning: Member variable 'ChangeNode::newdirty' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/undo.cpp:256:13: warning: Member variable 'ChangeNode::scriptgen' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/undo.cpp:256:13: warning: Member variable 'ChangeNode::oldmag' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/undo.cpp:256:13: warning: Member variable 'ChangeNode::newmag' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/undo.cpp:256:13: warning: Member variable 'ChangeNode::oldbase' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/undo.cpp:256:13: warning: Member variable 'ChangeNode::newbase' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/undo.cpp:256:13: warning: Member variable 'ChangeNode::oldexpo' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/undo.cpp:256:13: warning: Member variable 'ChangeNode::newexpo' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/undo.cpp:256:13: warning: Member variable 'ChangeNode::oldsave' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/undo.cpp:256:13: warning: Member variable 'ChangeNode::newsave' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/undo.cpp:256:13: warning: Member variable 'ChangeNode::oldalgo' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/undo.cpp:256:13: warning: Member variable 'ChangeNode::newalgo' is not initialized in the constructor. [uninitMemberVar] golly-3.3-src/gui-common/undo.h:105:10: style:inconclusive: Technically the member function 'UndoRedo::CanUndo' can be const. [functionConst] golly-3.3-src/gui-common/undo.cpp:1199:16: note: Technically the member function 'UndoRedo::CanUndo' can be const. golly-3.3-src/gui-common/undo.h:105:10: note: Technically the member function 'UndoRedo::CanUndo' can be const. golly-3.3-src/gui-common/undo.h:106:10: style:inconclusive: Technically the member function 'UndoRedo::CanRedo' can be const. [functionConst] golly-3.3-src/gui-common/undo.cpp:1210:16: note: Technically the member function 'UndoRedo::CanRedo' can be const. golly-3.3-src/gui-common/undo.h:106:10: note: Technically the member function 'UndoRedo::CanRedo' can be const. golly-3.3-src/gui-common/undo.cpp:57:10: style:inconclusive: Technically the member function 'StartingInfo::Restore' can be const. [functionConst] golly-3.3-src/gui-common/undo.cpp:131:20: note: Technically the member function 'StartingInfo::Restore' can be const. golly-3.3-src/gui-common/undo.cpp:57:10: note: Technically the member function 'StartingInfo::Restore' can be const. golly-3.3-src/gui-common/undo.cpp:198:5: style: Class 'ChangeNode' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] golly-3.3-src/gui-common/undo.cpp:600:9: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:598:20: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:600:9: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:601:9: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:598:20: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:601:9: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:602:9: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:598:20: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:602:9: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:603:9: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:598:20: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:603:9: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:629:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:627:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:629:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:630:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:627:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:630:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:645:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:643:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:645:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:646:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:643:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:646:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:662:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:660:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:662:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:663:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:660:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:663:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:664:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:660:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:664:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:665:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:660:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:665:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:711:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:709:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:711:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:712:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:709:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:712:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:838:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:836:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:838:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:839:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:836:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:839:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:840:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:836:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:840:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:841:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:836:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:841:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:842:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:836:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:842:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:843:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:836:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:843:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:844:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:836:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:844:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:845:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:836:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:845:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:846:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:836:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:846:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:847:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:836:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:847:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:848:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:836:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:848:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:849:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:836:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:849:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:850:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:836:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:850:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:851:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:836:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:851:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:852:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:836:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:852:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:853:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:836:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:853:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:854:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:836:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:854:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:858:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:836:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:858:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:860:9: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:836:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:860:9: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:967:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:965:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:967:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:968:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:965:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:968:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:969:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:965:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:969:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:970:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:965:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:970:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:971:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:965:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:971:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:972:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:965:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:972:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:973:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:965:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:973:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:974:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:965:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:974:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:975:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:965:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:975:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:976:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:965:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:976:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:1001:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:999:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:1001:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:1002:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:999:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:1002:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:1003:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:999:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:1003:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:1004:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:999:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:1004:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:1005:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:999:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:1005:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:1006:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:999:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:1006:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:1007:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:999:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:1007:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:1008:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:999:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:1008:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:1012:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:999:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:1012:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:1067:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:1065:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:1067:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:1068:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:1065:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:1068:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:1071:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:1065:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:1071:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:1072:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:1065:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:1072:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:1107:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:1105:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:1107:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:1108:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:1105:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:1108:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:1109:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:1105:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:1109:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:1110:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:1105:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:1110:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:1113:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:1105:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:1113:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:1114:5: warning: Either the condition 'change==NULL' is redundant or there is possible null pointer dereference: change. [nullPointerRedundantCheck] golly-3.3-src/gui-common/undo.cpp:1105:16: note: Assuming that condition 'change==NULL' is not redundant golly-3.3-src/gui-common/undo.cpp:1114:5: note: Null pointer dereference golly-3.3-src/gui-common/undo.cpp:537:26: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/undo.cpp:546:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/undo.cpp:588:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/undo.cpp:672:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/undo.cpp:1079:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/undo.cpp:1121:14: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/undo.cpp:1467:22: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/undo.cpp:1496:36: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/undo.cpp:1547:36: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/undo.cpp:912:17: style: The scope of the variable 'change' can be reduced. [variableScope] golly-3.3-src/gui-common/undo.cpp:947:39: style: Parameter 'oldgen' can be declared as reference to const [constParameter] golly-3.3-src/gui-common/undo.cpp:947:55: style: Parameter 'newgen' can be declared as reference to const [constParameter] golly-3.3-src/gui-common/undo.cpp:948:39: style: Parameter 'oldstartgen' can be declared as reference to const [constParameter] golly-3.3-src/gui-common/undo.cpp:72:55: style: Parameter 'oldlayer' can be declared as pointer to const [constParameter] golly-3.3-src/gui-common/undo.cpp:159:39: style: Parameter 'cloneptr' can be declared as pointer to const [constParameter] golly-3.3-src/gui-common/undo.cpp:1479:19: error: Iterators of different containers 'history->undolist' and 'undolist' are used together. [mismatchingContainers] golly-3.3-src/gui-common/undo.cpp:1530:19: error: Iterators of different containers 'history->redolist' and 'redolist' are used together. [mismatchingContainers] golly-3.3-src/gui-common/undo.cpp:1239:23: warning: Either the condition 'node==undolist.end()' is redundant or there is possible dereference of an invalid iterator: node. [derefInvalidIteratorRedundantCheck] golly-3.3-src/gui-common/undo.cpp:1238:22: note: Assuming that condition 'node==undolist.end()' is not redundant golly-3.3-src/gui-common/undo.cpp:1239:23: note: Dereference of an invalid iterator golly-3.3-src/gui-common/undo.cpp:1290:23: warning: Either the condition 'node==redolist.end()' is redundant or there is possible dereference of an invalid iterator: node. [derefInvalidIteratorRedundantCheck] golly-3.3-src/gui-common/undo.cpp:1289:22: note: Assuming that condition 'node==redolist.end()' is not redundant golly-3.3-src/gui-common/undo.cpp:1290:23: note: Dereference of an invalid iterator golly-3.3-src/gui-common/undo.cpp:1038:9: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/gui-common/undo.cpp:1050:9: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/gui-common/undo.cpp:1526:9: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/gui-common/undo.cpp:1577:9: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/gui-common/utils.cpp:332:1: error: Found a exit path from function with non-void return type that has missing return statement [missingReturn] golly-3.3-src/gui-common/utils.cpp:354:1: error: Found a exit path from function with non-void return type that has missing return statement [missingReturn] golly-3.3-src/gui-common/view.cpp:244:9: style: The scope of the variable 'currstate' can be reduced. [variableScope] golly-3.3-src/gui-common/view.cpp:698:19: style:inconclusive: Function 'CopyRect' argument 1 names different: declaration 'top' definition 'itop'. [funcArgNamesDifferent] golly-3.3-src/gui-common/view.h:39:19: note: Function 'CopyRect' argument 1 names different: declaration 'top' definition 'itop'. golly-3.3-src/gui-common/view.cpp:698:19: note: Function 'CopyRect' argument 1 names different: declaration 'top' definition 'itop'. golly-3.3-src/gui-common/view.cpp:698:29: style:inconclusive: Function 'CopyRect' argument 2 names different: declaration 'left' definition 'ileft'. [funcArgNamesDifferent] golly-3.3-src/gui-common/view.h:39:28: note: Function 'CopyRect' argument 2 names different: declaration 'left' definition 'ileft'. golly-3.3-src/gui-common/view.cpp:698:29: note: Function 'CopyRect' argument 2 names different: declaration 'left' definition 'ileft'. golly-3.3-src/gui-common/view.cpp:698:40: style:inconclusive: Function 'CopyRect' argument 3 names different: declaration 'bottom' definition 'ibottom'. [funcArgNamesDifferent] golly-3.3-src/gui-common/view.h:39:38: note: Function 'CopyRect' argument 3 names different: declaration 'bottom' definition 'ibottom'. golly-3.3-src/gui-common/view.cpp:698:40: note: Function 'CopyRect' argument 3 names different: declaration 'bottom' definition 'ibottom'. golly-3.3-src/gui-common/view.cpp:698:53: style:inconclusive: Function 'CopyRect' argument 4 names different: declaration 'right' definition 'iright'. [funcArgNamesDifferent] golly-3.3-src/gui-common/view.h:39:50: note: Function 'CopyRect' argument 4 names different: declaration 'right' definition 'iright'. golly-3.3-src/gui-common/view.cpp:698:53: note: Function 'CopyRect' argument 4 names different: declaration 'right' definition 'iright'. golly-3.3-src/gui-common/view.cpp:745:22: style:inconclusive: Function 'CopyAllRect' argument 1 names different: declaration 'top' definition 'itop'. [funcArgNamesDifferent] golly-3.3-src/gui-common/view.h:42:22: note: Function 'CopyAllRect' argument 1 names different: declaration 'top' definition 'itop'. golly-3.3-src/gui-common/view.cpp:745:22: note: Function 'CopyAllRect' argument 1 names different: declaration 'top' definition 'itop'. golly-3.3-src/gui-common/view.cpp:745:32: style:inconclusive: Function 'CopyAllRect' argument 2 names different: declaration 'left' definition 'ileft'. [funcArgNamesDifferent] golly-3.3-src/gui-common/view.h:42:31: note: Function 'CopyAllRect' argument 2 names different: declaration 'left' definition 'ileft'. golly-3.3-src/gui-common/view.cpp:745:32: note: Function 'CopyAllRect' argument 2 names different: declaration 'left' definition 'ileft'. golly-3.3-src/gui-common/view.cpp:745:43: style:inconclusive: Function 'CopyAllRect' argument 3 names different: declaration 'bottom' definition 'ibottom'. [funcArgNamesDifferent] golly-3.3-src/gui-common/view.h:42:41: note: Function 'CopyAllRect' argument 3 names different: declaration 'bottom' definition 'ibottom'. golly-3.3-src/gui-common/view.cpp:745:43: note: Function 'CopyAllRect' argument 3 names different: declaration 'bottom' definition 'ibottom'. golly-3.3-src/gui-common/view.cpp:745:56: style:inconclusive: Function 'CopyAllRect' argument 4 names different: declaration 'right' definition 'iright'. [funcArgNamesDifferent] golly-3.3-src/gui-common/view.h:42:53: note: Function 'CopyAllRect' argument 4 names different: declaration 'right' definition 'iright'. golly-3.3-src/gui-common/view.cpp:745:56: note: Function 'CopyAllRect' argument 4 names different: declaration 'right' definition 'iright'. golly-3.3-src/gui-common/view.cpp:101:28: style: Parameter 't' can be declared as reference to const [constParameter] golly-3.3-src/gui-common/view.cpp:101:39: style: Parameter 'l' can be declared as reference to const [constParameter] golly-3.3-src/gui-common/view.cpp:101:50: style: Parameter 'b' can be declared as reference to const [constParameter] golly-3.3-src/gui-common/view.cpp:101:61: style: Parameter 'r' can be declared as reference to const [constParameter] golly-3.3-src/gui-common/view.cpp:1447:41: error: Undefined behavior: Variable 'rule' is used as parameter and destination in sprintf(). [sprintfOverlappingData] golly-3.3-src/gui-web/main.cpp:124:5: error: There is an unknown macro here somewhere. Configuration is required. If EM_ASM is a macro then please configure it. [unknownMacro] golly-3.3-src/gui-web/webcalls.cpp:245:81: error: There is an unknown macro here somewhere. Configuration is required. If ; is a macro then please configure it. [unknownMacro] golly-3.3-src/gui-web/zlib/deflate.c:155:32: style: struct member 'static_tree_desc_s::dummy' is never used. [unusedStructMember] golly-3.3-src/gui-web/zlib/deflate.c:1842:9: style: Variable 'bflush' is assigned a value that is never used. [unreadVariable] golly-3.3-src/gui-web/zlib/gzwrite.c:295:17: style:inconclusive: Function 'gzputs' argument 2 names different: declaration 's' definition 'str'. [funcArgNamesDifferent] golly-3.3-src/gui-web/zlib/zlib.h:1364:28: note: Function 'gzputs' argument 2 names different: declaration 's' definition 'str'. golly-3.3-src/gui-web/zlib/gzwrite.c:295:17: note: Function 'gzputs' argument 2 names different: declaration 's' definition 'str'. golly-3.3-src/gui-web/zlib/inflate.c:1497:17: style: Variable 'state->sane' is reassigned a value before the old one has been used. [redundantAssignment] golly-3.3-src/gui-web/zlib/inflate.c:1493:17: note: state->sane is assigned golly-3.3-src/gui-web/zlib/inflate.c:1497:17: note: state->sane is overwritten golly-3.3-src/gui-web/zlib/inflate.c:1507:61: portability: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS] golly-3.3-src/gui-web/zlib/inftrees.c:34:21: style: Parameter 'lens' can be declared as pointer to const [constParameter] golly-3.3-src/gui-web/zlib/trees.c:1155:14: style:inconclusive: Function 'bi_reverse' argument 1 names different: declaration 'value' definition 'code'. [funcArgNamesDifferent] golly-3.3-src/gui-web/zlib/trees.c:152:27: note: Function 'bi_reverse' argument 1 names different: declaration 'value' definition 'code'. golly-3.3-src/gui-web/zlib/trees.c:1155:14: note: Function 'bi_reverse' argument 1 names different: declaration 'value' definition 'code'. golly-3.3-src/gui-web/zlib/trees.c:1156:9: style:inconclusive: Function 'bi_reverse' argument 2 names different: declaration 'length' definition 'len'. [funcArgNamesDifferent] golly-3.3-src/gui-web/zlib/trees.c:152:27: note: Function 'bi_reverse' argument 2 names different: declaration 'length' definition 'len'. golly-3.3-src/gui-web/zlib/trees.c:1156:9: note: Function 'bi_reverse' argument 2 names different: declaration 'length' definition 'len'. golly-3.3-src/gui-web/zlib/trees.c:578:11: style: Parameter 'bl_count' can be declared as pointer to const [constParameter] golly-3.3-src/gui-web/zlib/zutil.c:309:31: style: Same expression on both sides of '-'. [duplicateExpression] golly-3.3-src/gui-web/zlib/zutil.c:305:12: style: Parameter 'opaque' can be declared as pointer to const [constParameter] golly-3.3-src/gui-web/zlib/zutil.c:315:12: style: Parameter 'opaque' can be declared as pointer to const [constParameter] golly-3.3-src/gui-web/zlib/zutil.c:14:33: style: struct member 'internal_state::dummy' is never used. [unusedStructMember] golly-3.3-src/gui-wx/wxgolly.h:36:1: error: There is an unknown macro here somewhere. Configuration is required. If DECLARE_APP is a macro then please configure it. [unknownMacro] golly-3.3-src/gui-common/prefs.cpp:486:13: warning:inconclusive: The buffer 'initrule' may not be null-terminated after the call to strncpy(). [terminateStrncpy] golly-3.3-src/gui-common/prefs.cpp:404:25: style: C-style pointer casting [cstyleCast] golly-3.3-src/gui-common/prefs.cpp:589:21: performance: Inefficient usage of string::find() in condition; string::starts_with() could be faster. [stlIfStrFind] golly-3.3-src/gui-common/prefs.cpp:258:13: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] golly-3.3-src/lua/luaconf.h:581:0: error: #error "Compiler does not support 'long long'. Use option '-DLUA_32BITS' \ [preprocessorErrorDirective] diff: head golly-3.3-src/Rules/TreeGenerators/LifeOnTheEdge.cpp:18:12: style: Parameter 'a' can be declared as pointer to const [constParameter] 2.8 golly-3.3-src/Rules/TreeGenerators/LifeOnTheEdge.cpp:18:12: style: Parameter 'a' can be declared with const [constParameter] head golly-3.3-src/Rules/TreeGenerators/LifeOnTheSlope.cpp:17:12: style: Parameter 'a' can be declared as pointer to const [constParameter] 2.8 golly-3.3-src/Rules/TreeGenerators/LifeOnTheSlope.cpp:17:12: style: Parameter 'a' can be declared with const [constParameter] head golly-3.3-src/Rules/TreeGenerators/RuleTreeGen.cpp:14:12: style: Parameter 'a' can be declared as pointer to const [constParameter] 2.8 golly-3.3-src/Rules/TreeGenerators/RuleTreeGen.cpp:14:12: style: Parameter 'a' can be declared with const [constParameter] head golly-3.3-src/cmdline/RuleTableToTree.cpp:179:15: warning: Redundant assignment of 'n_states' to itself. [selfAssignment] head golly-3.3-src/gollybase/ghashbase.cpp:261:43: style: Parameter 'su' can be declared as reference to const [constParameter] 2.8 golly-3.3-src/gollybase/ghashbase.cpp:261:43: style: Parameter 'su' can be declared with const [constParameter] head golly-3.3-src/gollybase/ghashdraw.cpp:84:46: style: Parameter 'z' can be declared as pointer to const [constParameter] 2.8 golly-3.3-src/gollybase/ghashdraw.cpp:84:46: style: Parameter 'z' can be declared with const [constParameter] head golly-3.3-src/gollybase/hlifealgo.cpp:328:37: style: Parameter 'su' can be declared as reference to const [constParameter] 2.8 golly-3.3-src/gollybase/hlifealgo.cpp:328:37: style: Parameter 'su' can be declared with const [constParameter] head golly-3.3-src/gollybase/hlifedraw.cpp:50:31: style: Parameter 'z' can be declared as pointer to const [constParameter] 2.8 golly-3.3-src/gollybase/hlifedraw.cpp:50:31: style: Parameter 'z' can be declared with const [constParameter] head golly-3.3-src/gui-common/MiniZip/unzip.c:399:24: style: Parameter 'pzlib_filefunc_def' can be declared as pointer to const [constParameter] 2.8 golly-3.3-src/gui-common/MiniZip/unzip.c:399:24: style: Parameter 'pzlib_filefunc_def' can be declared with const [constParameter] head golly-3.3-src/gui-common/MiniZip/zip.c:501:24: style: Parameter 'pzlib_filefunc_def' can be declared as pointer to const [constParameter] 2.8 golly-3.3-src/gui-common/MiniZip/zip.c:501:24: style: Parameter 'pzlib_filefunc_def' can be declared with const [constParameter] head golly-3.3-src/gui-common/algos.cpp:671:52: style: Parameter 'indata' can be declared as pointer to const [constParameter] 2.8 golly-3.3-src/gui-common/algos.cpp:671:52: style: Parameter 'indata' can be declared with const [constParameter] head golly-3.3-src/gui-common/algos.cpp:708:51: style: Parameter 'indata' can be declared as pointer to const [constParameter] 2.8 golly-3.3-src/gui-common/algos.cpp:708:51: style: Parameter 'indata' can be declared with const [constParameter] head golly-3.3-src/gui-common/render.cpp:387:31: style: Parameter 'statedata' can be declared as pointer to const [constParameter] 2.8 golly-3.3-src/gui-common/render.cpp:387:31: style: Parameter 'statedata' can be declared with const [constParameter] head golly-3.3-src/gui-common/render.cpp:453:40: style: Parameter 'statedata' can be declared as pointer to const [constParameter] 2.8 golly-3.3-src/gui-common/render.cpp:453:40: style: Parameter 'statedata' can be declared with const [constParameter] head golly-3.3-src/gui-common/render.cpp:593:27: style: Parameter 'rect' can be declared as reference to const [constParameter] 2.8 golly-3.3-src/gui-common/render.cpp:593:27: style: Parameter 'rect' can be declared with const [constParameter] head golly-3.3-src/gui-common/render.cpp:693:38: style: Parameter 'bbox' can be declared as reference to const [constParameter] 2.8 golly-3.3-src/gui-common/render.cpp:693:38: style: Parameter 'bbox' can be declared with const [constParameter] head golly-3.3-src/gui-common/select.cpp:153:34: style: Parameter 't' can be declared as reference to const [constParameter] 2.8 golly-3.3-src/gui-common/select.cpp:153:34: style: Parameter 't' can be declared with const [constParameter] head golly-3.3-src/gui-common/select.cpp:153:45: style: Parameter 'l' can be declared as reference to const [constParameter] 2.8 golly-3.3-src/gui-common/select.cpp:153:45: style: Parameter 'l' can be declared with const [constParameter] head golly-3.3-src/gui-common/select.cpp:153:56: style: Parameter 'b' can be declared as reference to const [constParameter] 2.8 golly-3.3-src/gui-common/select.cpp:153:56: style: Parameter 'b' can be declared with const [constParameter] head golly-3.3-src/gui-common/select.cpp:153:67: style: Parameter 'r' can be declared as reference to const [constParameter] 2.8 golly-3.3-src/gui-common/select.cpp:153:67: style: Parameter 'r' can be declared with const [constParameter] head golly-3.3-src/gui-common/select.cpp:190:34: style: Parameter 't' can be declared as reference to const [constParameter] 2.8 golly-3.3-src/gui-common/select.cpp:190:34: style: Parameter 't' can be declared with const [constParameter] head golly-3.3-src/gui-common/select.cpp:190:45: style: Parameter 'l' can be declared as reference to const [constParameter] 2.8 golly-3.3-src/gui-common/select.cpp:190:45: style: Parameter 'l' can be declared with const [constParameter] head golly-3.3-src/gui-common/select.cpp:190:56: style: Parameter 'b' can be declared as reference to const [constParameter] 2.8 golly-3.3-src/gui-common/select.cpp:190:56: style: Parameter 'b' can be declared with const [constParameter] head golly-3.3-src/gui-common/select.cpp:190:67: style: Parameter 'r' can be declared as reference to const [constParameter] 2.8 golly-3.3-src/gui-common/select.cpp:190:67: style: Parameter 'r' can be declared with const [constParameter] head golly-3.3-src/gui-common/select.cpp:197:33: style: Parameter 't' can be declared as reference to const [constParameter] 2.8 golly-3.3-src/gui-common/select.cpp:197:33: style: Parameter 't' can be declared with const [constParameter] head golly-3.3-src/gui-common/select.cpp:197:44: style: Parameter 'l' can be declared as reference to const [constParameter] 2.8 golly-3.3-src/gui-common/select.cpp:197:44: style: Parameter 'l' can be declared with const [constParameter] head golly-3.3-src/gui-common/select.cpp:197:55: style: Parameter 'b' can be declared as reference to const [constParameter] 2.8 golly-3.3-src/gui-common/select.cpp:197:55: style: Parameter 'b' can be declared with const [constParameter] head golly-3.3-src/gui-common/select.cpp:197:66: style: Parameter 'r' can be declared as reference to const [constParameter] 2.8 golly-3.3-src/gui-common/select.cpp:197:66: style: Parameter 'r' can be declared with const [constParameter] head golly-3.3-src/gui-common/undo.cpp:159:39: style: Parameter 'cloneptr' can be declared as pointer to const [constParameter] 2.8 golly-3.3-src/gui-common/undo.cpp:159:39: style: Parameter 'cloneptr' can be declared with const [constParameter] head golly-3.3-src/gui-common/undo.cpp:72:55: style: Parameter 'oldlayer' can be declared as pointer to const [constParameter] 2.8 golly-3.3-src/gui-common/undo.cpp:72:55: style: Parameter 'oldlayer' can be declared with const [constParameter] head golly-3.3-src/gui-common/undo.cpp:947:39: style: Parameter 'oldgen' can be declared as reference to const [constParameter] 2.8 golly-3.3-src/gui-common/undo.cpp:947:39: style: Parameter 'oldgen' can be declared with const [constParameter] head golly-3.3-src/gui-common/undo.cpp:947:55: style: Parameter 'newgen' can be declared as reference to const [constParameter] 2.8 golly-3.3-src/gui-common/undo.cpp:947:55: style: Parameter 'newgen' can be declared with const [constParameter] head golly-3.3-src/gui-common/undo.cpp:948:39: style: Parameter 'oldstartgen' can be declared as reference to const [constParameter] 2.8 golly-3.3-src/gui-common/undo.cpp:948:39: style: Parameter 'oldstartgen' can be declared with const [constParameter] head golly-3.3-src/gui-common/view.cpp:101:28: style: Parameter 't' can be declared as reference to const [constParameter] 2.8 golly-3.3-src/gui-common/view.cpp:101:28: style: Parameter 't' can be declared with const [constParameter] head golly-3.3-src/gui-common/view.cpp:101:39: style: Parameter 'l' can be declared as reference to const [constParameter] 2.8 golly-3.3-src/gui-common/view.cpp:101:39: style: Parameter 'l' can be declared with const [constParameter] head golly-3.3-src/gui-common/view.cpp:101:50: style: Parameter 'b' can be declared as reference to const [constParameter] 2.8 golly-3.3-src/gui-common/view.cpp:101:50: style: Parameter 'b' can be declared with const [constParameter] head golly-3.3-src/gui-common/view.cpp:101:61: style: Parameter 'r' can be declared as reference to const [constParameter] 2.8 golly-3.3-src/gui-common/view.cpp:101:61: style: Parameter 'r' can be declared with const [constParameter] head golly-3.3-src/gui-web/zlib/inftrees.c:34:21: style: Parameter 'lens' can be declared as pointer to const [constParameter] 2.8 golly-3.3-src/gui-web/zlib/inftrees.c:34:21: style: Parameter 'lens' can be declared with const [constParameter] head golly-3.3-src/gui-web/zlib/trees.c:578:11: style: Parameter 'bl_count' can be declared as pointer to const [constParameter] 2.8 golly-3.3-src/gui-web/zlib/trees.c:578:11: style: Parameter 'bl_count' can be declared with const [constParameter] head golly-3.3-src/gui-web/zlib/zutil.c:305:12: style: Parameter 'opaque' can be declared as pointer to const [constParameter] 2.8 golly-3.3-src/gui-web/zlib/zutil.c:305:12: style: Parameter 'opaque' can be declared with const [constParameter] head golly-3.3-src/gui-web/zlib/zutil.c:315:12: style: Parameter 'opaque' can be declared as pointer to const [constParameter] 2.8 golly-3.3-src/gui-web/zlib/zutil.c:315:12: style: Parameter 'opaque' can be declared with const [constParameter] DONE