2021-10-15 22:13 ftp://ftp.de.debian.org/debian/pool/main/g/gobby/gobby_0.6.0~20170204~e5c2d1.orig.tar.gz cppcheck-options: --library=posix --library=gnu --showtime=top5 --check-library --inconclusive --enable=style,information --template=daca2 -D__GNUC__ --platform=unix64 -rp=temp platform: Linux-4.4.0-19041-Microsoft-x86_64-with-glibc2.32 python: 3.9.7 client-version: 1.3.15 compiler: g++ (Debian 10.3.0-11) 10.3.0 cppcheck: head 2.6 head-info: d4a98dfaa (2021-10-15 22:50:29 +0200) count: 82 76 elapsed-time: 5.0 4.3 head-timing-info: Overall time: 0s old-timing-info: Overall time: 0s head results: code/commands/file-tasks/task-open-multiple.cpp:52:36: style: Variable 'operation' is assigned a value that is never used. [unreadVariable] code/core/applicationactions.hpp:28:2: style: Class 'ApplicationActions' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/commands/subscription-commands.cpp:45:16: style:inconclusive: Technically the member function 'SessionInfo::get_folder' can be const. [functionConst] code/commands/folder-commands.cpp:34:2: style: Class 'DocInfo' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/commands/folder-commands.cpp:204:2: style: Class 'TextDocInfo' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/commands/user-join-commands.cpp:117:28: style:inconclusive: Function 'add_text_parameters' argument 1 names different: declaration 'parameters' definition 'params'. [funcArgNamesDifferent] code/commands/user-join-commands.cpp:81:53: note: Function 'add_text_parameters' argument 1 names different: declaration 'parameters' definition 'params'. code/commands/user-join-commands.cpp:117:28: note: Function 'add_text_parameters' argument 1 names different: declaration 'parameters' definition 'params'. code/core/menumanager.hpp:33:31: style:inconclusive: Technically the member function 'Gobby::MenuManager::get_app_menu' can be const. [functionConst] code/core/menumanager.hpp:34:31: style:inconclusive: Technically the member function 'Gobby::MenuManager::get_menu' can be const. [functionConst] code/core/menumanager.hpp:31:2: style: Class 'MenuManager' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/dialogs/initial-dialog.cpp:281:7: debug: Wrong data detected by condition !tok->next()->astOperand1() [DacaWrongData] code/dialogs/entry-dialog.cpp:39:2: warning:inconclusive: Possible null pointer dereference: dialog [nullPointer] code/dialogs/entry-dialog.cpp:36:24: note: Assignment 'dialog=NULL', assigned value is 0 code/dialogs/entry-dialog.cpp:39:2: note: Null pointer dereference code/dialogs/entry-dialog.cpp:40:2: warning:inconclusive: Possible null pointer dereference: dialog [nullPointer] code/dialogs/entry-dialog.cpp:36:24: note: Assignment 'dialog=NULL', assigned value is 0 code/dialogs/entry-dialog.cpp:40:2: note: Null pointer dereference code/dialogs/entry-dialog.cpp:41:2: warning:inconclusive: Possible null pointer dereference: dialog [nullPointer] code/dialogs/entry-dialog.cpp:36:24: note: Assignment 'dialog=NULL', assigned value is 0 code/dialogs/entry-dialog.cpp:41:2: note: Null pointer dereference code/core/documentinfostorage.cpp:98:3: performance: Variable 'm_begin_explore_handler' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] code/commands/view-commands.cpp:40:2: style: Class 'Fullscreen' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/core/folder.cpp:76:29: style: Local variable 'record' shadows outer function [shadowFunction] code/core/folder.cpp:65:7: note: Shadowed declaration code/core/folder.cpp:76:29: note: Shadow variable code/commands/browser-commands.cpp:46:3: style: Class 'ParameterProvider' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/commands/view-commands.cpp:30:3: style: Class 'Preserve' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/commands/browser-commands.cpp:429:20: style: The scope of the variable 'connection' can be reduced. [variableScope] code/core/foldermanager.cpp:79:24: style:inconclusive: Technically the member function 'SessionInfo::get_browser_iter' can be const. [functionConst] code/dialogs/document-location-dialog.cpp:54:2: warning:inconclusive: Possible null pointer dereference: dialog [nullPointer] code/dialogs/document-location-dialog.cpp:50:39: note: Assignment 'dialog_ptr=NULL', assigned value is 0 code/dialogs/document-location-dialog.cpp:52:49: note: Assignment 'std::unique_ptrdialog(dialog_ptr)', assigned value is 0 code/dialogs/document-location-dialog.cpp:54:2: note: Null pointer dereference code/dialogs/document-location-dialog.cpp:56:2: warning:inconclusive: Possible null pointer dereference: dialog [nullPointer] code/dialogs/document-location-dialog.cpp:50:39: note: Assignment 'dialog_ptr=NULL', assigned value is 0 code/dialogs/document-location-dialog.cpp:52:49: note: Assignment 'std::unique_ptrdialog(dialog_ptr)', assigned value is 0 code/dialogs/document-location-dialog.cpp:56:2: note: Null pointer dereference code/dialogs/document-location-dialog.cpp:58:17: warning:inconclusive: Possible null pointer dereference: dialog [nullPointer] code/dialogs/document-location-dialog.cpp:50:39: note: Assignment 'dialog_ptr=NULL', assigned value is 0 code/dialogs/document-location-dialog.cpp:52:49: note: Assignment 'std::unique_ptrdialog(dialog_ptr)', assigned value is 0 code/dialogs/document-location-dialog.cpp:58:17: note: Null pointer dereference code/dialogs/document-location-dialog.cpp:59:18: warning:inconclusive: Possible null pointer dereference: dialog [nullPointer] code/dialogs/document-location-dialog.cpp:50:39: note: Assignment 'dialog_ptr=NULL', assigned value is 0 code/dialogs/document-location-dialog.cpp:52:49: note: Assignment 'std::unique_ptrdialog(dialog_ptr)', assigned value is 0 code/dialogs/document-location-dialog.cpp:59:18: note: Null pointer dereference code/dialogs/document-location-dialog.cpp:61:19: warning:inconclusive: Possible null pointer dereference: dialog [nullPointer] code/dialogs/document-location-dialog.cpp:50:39: note: Assignment 'dialog_ptr=NULL', assigned value is 0 code/dialogs/document-location-dialog.cpp:52:49: note: Assignment 'std::unique_ptrdialog(dialog_ptr)', assigned value is 0 code/dialogs/document-location-dialog.cpp:61:19: note: Null pointer dereference code/core/gobject/gobby-undo-manager.c:43:56: style: Parameter 'user' can be declared with const [constParameter] code/core/gobject/gobby-undo-manager.c:68:56: style: Parameter 'user' can be declared with const [constParameter] code/core/gobject/gobby-undo-manager.c:185:8: style: Variable 'priv' is assigned a value that is never used. [unreadVariable] code/core/statusbar.cpp:79:30: warning: Possible null pointer dereference: parent [nullPointer] code/core/statusbar.cpp:73:25: note: Assignment 'parent=NULL', assigned value is 0 code/core/statusbar.cpp:75:28: note: Assuming condition is false code/core/statusbar.cpp:79:30: note: Null pointer dereference code/dialogs/connection-info-dialog.cpp:251:18: style: Local variable 'iter' shadows outer variable [shadowVariable] code/dialogs/connection-info-dialog.cpp:243:17: note: Shadowed declaration code/dialogs/connection-info-dialog.cpp:251:18: note: Shadow variable code/util/historyentry.cpp:49:2: style: Class 'Loader' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/operations/operation-export-html.cpp:243:35: portability: Non reentrant function 'localtime' called. For threadsafe applications it is recommended to use the reentrant replacement function 'localtime_r'. [prohibitedlocaltimeCalled] code/core/preferences.hpp:575:10: style:inconclusive: Member variable 'Option < unsigned int >::m_changed_handler' is in the wrong place in the initializer list. [initializerList] code/core/preferences.hpp:446:28: note: Member variable 'Option < unsigned int >::m_changed_handler' is in the wrong place in the initializer list. code/core/preferences.hpp:575:10: note: Member variable 'Option < unsigned int >::m_changed_handler' is in the wrong place in the initializer list. code/core/preferences.hpp:575:10: style:inconclusive: Member variable 'Option < Glib :: ustring >::m_changed_handler' is in the wrong place in the initializer list. [initializerList] code/core/preferences.hpp:446:28: note: Member variable 'Option < Glib :: ustring >::m_changed_handler' is in the wrong place in the initializer list. code/core/preferences.hpp:575:10: note: Member variable 'Option < Glib :: ustring >::m_changed_handler' is in the wrong place in the initializer list. code/core/preferences.hpp:575:10: style:inconclusive: Member variable 'Option < double >::m_changed_handler' is in the wrong place in the initializer list. [initializerList] code/core/preferences.hpp:446:28: note: Member variable 'Option < double >::m_changed_handler' is in the wrong place in the initializer list. code/core/preferences.hpp:575:10: note: Member variable 'Option < double >::m_changed_handler' is in the wrong place in the initializer list. code/core/preferences.hpp:575:10: style:inconclusive: Member variable 'Option < bool >::m_changed_handler' is in the wrong place in the initializer list. [initializerList] code/core/preferences.hpp:446:28: note: Member variable 'Option < bool >::m_changed_handler' is in the wrong place in the initializer list. code/core/preferences.hpp:575:10: note: Member variable 'Option < bool >::m_changed_handler' is in the wrong place in the initializer list. code/core/preferences.hpp:575:10: style:inconclusive: Member variable 'Option < std :: string >::m_changed_handler' is in the wrong place in the initializer list. [initializerList] code/core/preferences.hpp:446:28: note: Member variable 'Option < std :: string >::m_changed_handler' is in the wrong place in the initializer list. code/core/preferences.hpp:575:10: note: Member variable 'Option < std :: string >::m_changed_handler' is in the wrong place in the initializer list. code/core/preferences.hpp:575:10: style:inconclusive: Member variable 'Option < Gtk :: WrapMode >::m_changed_handler' is in the wrong place in the initializer list. [initializerList] code/core/preferences.hpp:446:28: note: Member variable 'Option < Gtk :: WrapMode >::m_changed_handler' is in the wrong place in the initializer list. code/core/preferences.hpp:575:10: note: Member variable 'Option < Gtk :: WrapMode >::m_changed_handler' is in the wrong place in the initializer list. code/core/preferences.hpp:575:10: style:inconclusive: Member variable 'Option < GtkSourceDrawSpacesFlags >::m_changed_handler' is in the wrong place in the initializer list. [initializerList] code/core/preferences.hpp:446:28: note: Member variable 'Option < GtkSourceDrawSpacesFlags >::m_changed_handler' is in the wrong place in the initializer list. code/core/preferences.hpp:575:10: note: Member variable 'Option < GtkSourceDrawSpacesFlags >::m_changed_handler' is in the wrong place in the initializer list. code/core/preferences.hpp:575:10: style:inconclusive: Member variable 'Option < Gtk :: ToolbarStyle >::m_changed_handler' is in the wrong place in the initializer list. [initializerList] code/core/preferences.hpp:446:28: note: Member variable 'Option < Gtk :: ToolbarStyle >::m_changed_handler' is in the wrong place in the initializer list. code/core/preferences.hpp:575:10: note: Member variable 'Option < Gtk :: ToolbarStyle >::m_changed_handler' is in the wrong place in the initializer list. code/core/preferences.hpp:575:10: style:inconclusive: Member variable 'Option < Pango :: FontDescription >::m_changed_handler' is in the wrong place in the initializer list. [initializerList] code/core/preferences.hpp:446:28: note: Member variable 'Option < Pango :: FontDescription >::m_changed_handler' is in the wrong place in the initializer list. code/core/preferences.hpp:575:10: note: Member variable 'Option < Pango :: FontDescription >::m_changed_handler' is in the wrong place in the initializer list. code/core/preferences.hpp:575:10: style:inconclusive: Member variable 'Option < InfXmppConnectionSecurityPolicy >::m_changed_handler' is in the wrong place in the initializer list. [initializerList] code/core/preferences.hpp:446:28: note: Member variable 'Option < InfXmppConnectionSecurityPolicy >::m_changed_handler' is in the wrong place in the initializer list. code/core/preferences.hpp:575:10: note: Member variable 'Option < InfXmppConnectionSecurityPolicy >::m_changed_handler' is in the wrong place in the initializer list. code/core/preferences.hpp:575:10: style:inconclusive: Member variable 'Option < InfKeepalive >::m_changed_handler' is in the wrong place in the initializer list. [initializerList] code/core/preferences.hpp:446:28: note: Member variable 'Option < InfKeepalive >::m_changed_handler' is in the wrong place in the initializer list. code/core/preferences.hpp:575:10: note: Member variable 'Option < InfKeepalive >::m_changed_handler' is in the wrong place in the initializer list. code/commands/folder-commands.hpp:30:2: style: Class 'FolderCommands' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/core/toolbar.hpp:31:2: style: Class 'Toolbar' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/core/preferences.hpp:581:2: style: Class 'Preferences' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/core/knownhoststorage.hpp:31:2: style: Class 'KnownHostStorage' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/util/serialize.hpp:38:2: style: Class 'conversion_error' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/util/serialize.hpp:183:2: style: Class 'data' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/util/serialize.hpp:189:2: style: Class 'data' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/util/config.hpp:314:2: style: Class 'Config' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/util/config.hpp:129:3: style: Class 'TypedValueEntry' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/util/config.hpp:173:3: style: Class 'ParentEntry' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/util/config.hpp:177:3: style: Class 'ParentEntry' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/application.cpp:72:2: style: Class 'Data' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/util/config.hpp:150:4: style: Class 'iterator_base < std :: map < Glib :: ustring , Entry * > :: iterator , Entry >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/util/config.hpp:150:4: style: Class 'iterator_base < std :: map < Glib :: ustring , Entry * > :: const_iterator , const Entry >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/core/preferences.hpp:445:3: style: Class 'Option < unsigned int >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/core/preferences.hpp:445:3: style: Class 'Option < Glib :: ustring >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/core/preferences.hpp:445:3: style: Class 'Option < double >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/core/preferences.hpp:445:3: style: Class 'Option < bool >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/core/preferences.hpp:445:3: style: Class 'Option < std :: string >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/core/preferences.hpp:445:3: style: Class 'Option < Gtk :: WrapMode >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/core/preferences.hpp:445:3: style: Class 'Option < GtkSourceDrawSpacesFlags >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/core/preferences.hpp:445:3: style: Class 'Option < Gtk :: ToolbarStyle >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/core/preferences.hpp:445:3: style: Class 'Option < Pango :: FontDescription >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/core/preferences.hpp:445:3: style: Class 'Option < InfXmppConnectionSecurityPolicy >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/core/preferences.hpp:445:3: style: Class 'Option < InfKeepalive >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] code/commands/file-tasks/task-open.hpp:34:15: style: The function 'run' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] code/commands/file-commands.hpp:55:16: note: Virtual function in base class code/commands/file-tasks/task-open.hpp:34:15: note: Function in derived class code/commands/file-tasks/task-open-multiple.hpp:38:15: style: The function 'run' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] code/commands/file-commands.hpp:55:16: note: Virtual function in base class code/commands/file-tasks/task-open-multiple.hpp:38:15: note: Function in derived class code/util/serialize.hpp:146:22: style: The function 'to_string' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] code/util/serialize.hpp:68:22: note: Virtual function in base class code/util/serialize.hpp:146:22: note: Function in derived class code/util/serialize.hpp:155:20: style: The function 'from_string' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] code/util/serialize.hpp:82:20: note: Virtual function in base class code/util/serialize.hpp:155:20: note: Function in derived class code/util/serialize.hpp:164:22: style: The function 'to_string' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] code/util/serialize.hpp:68:22: note: Virtual function in base class code/util/serialize.hpp:164:22: note: Function in derived class code/util/config.hpp:44:29: style: The function 'to_string' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] code/util/serialize.hpp:68:22: note: Virtual function in base class code/util/config.hpp:44:29: note: Function in derived class code/util/config.hpp:54:27: style: The function 'from_string' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] code/util/serialize.hpp:82:20: note: Virtual function in base class code/util/config.hpp:54:27: note: Function in derived class code/util/config.hpp:133:16: style: The function 'save' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] code/util/config.hpp:72:16: note: Virtual function in base class code/util/config.hpp:133:16: note: Function in derived class code/util/config.hpp:182:16: style: The function 'save' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] code/util/config.hpp:72:16: note: Virtual function in base class code/util/config.hpp:182:16: note: Function in derived class code/util/config.hpp:336:52: style:inconclusive: Function 'get' argument 1 names different: declaration 'ctx' definition 'from'. [funcArgNamesDifferent] code/util/config.hpp:102:50: note: Function 'get' argument 1 names different: declaration 'ctx' definition 'from'. code/util/config.hpp:336:52: note: Function 'get' argument 1 names different: declaration 'ctx' definition 'from'. code/dialogs/preferences-dialog.cpp:634:10: warning: Possible null pointer dereference: parent [nullPointer] code/dialogs/preferences-dialog.cpp:628:24: note: Assignment 'parent=NULL', assigned value is 0 code/dialogs/preferences-dialog.cpp:630:27: note: Assuming condition is false code/dialogs/preferences-dialog.cpp:634:10: note: Null pointer dereference code/window.hpp:132:18: style:inconclusive: Member variable 'Window::m_browser_commands' is in the wrong place in the initializer list. [initializerList] code/window.cpp:57:2: note: Member variable 'Window::m_browser_commands' is in the wrong place in the initializer list. code/window.hpp:132:18: note: Member variable 'Window::m_browser_commands' is in the wrong place in the initializer list. code/window.cpp:233:5: style: Condition '!chat_view' is always false [knownConditionTrueFalse] code/window.cpp:248:5: style: Condition '!text_view' is always false [knownConditionTrueFalse] diff: head code/dialogs/document-location-dialog.cpp:56:2: warning:inconclusive: Possible null pointer dereference: dialog [nullPointer] code/dialogs/document-location-dialog.cpp:50:39: note: Assignment 'dialog_ptr=NULL', assigned value is 0 code/dialogs/document-location-dialog.cpp:52:49: note: Assignment 'std::unique_ptrdialog(dialog_ptr)', assigned value is 0 code/dialogs/document-location-dialog.cpp:56:2: note: Null pointer dereference head code/dialogs/document-location-dialog.cpp:58:17: warning:inconclusive: Possible null pointer dereference: dialog [nullPointer] code/dialogs/document-location-dialog.cpp:50:39: note: Assignment 'dialog_ptr=NULL', assigned value is 0 code/dialogs/document-location-dialog.cpp:52:49: note: Assignment 'std::unique_ptrdialog(dialog_ptr)', assigned value is 0 code/dialogs/document-location-dialog.cpp:58:17: note: Null pointer dereference head code/dialogs/document-location-dialog.cpp:59:18: warning:inconclusive: Possible null pointer dereference: dialog [nullPointer] code/dialogs/document-location-dialog.cpp:50:39: note: Assignment 'dialog_ptr=NULL', assigned value is 0 code/dialogs/document-location-dialog.cpp:52:49: note: Assignment 'std::unique_ptrdialog(dialog_ptr)', assigned value is 0 code/dialogs/document-location-dialog.cpp:59:18: note: Null pointer dereference head code/dialogs/document-location-dialog.cpp:61:19: warning:inconclusive: Possible null pointer dereference: dialog [nullPointer] code/dialogs/document-location-dialog.cpp:50:39: note: Assignment 'dialog_ptr=NULL', assigned value is 0 code/dialogs/document-location-dialog.cpp:52:49: note: Assignment 'std::unique_ptrdialog(dialog_ptr)', assigned value is 0 code/dialogs/document-location-dialog.cpp:61:19: note: Null pointer dereference head code/window.cpp:233:5: style: Condition '!chat_view' is always false [knownConditionTrueFalse] head code/window.cpp:248:5: style: Condition '!text_view' is always false [knownConditionTrueFalse] DONE